Re: [PATCH 14/16] arm/aspeed: Drop aspeed_board_init_flashes() parameter @errp

On 6/5/20 4:56 PM, Markus Armbruster wrote: > We always pass _abort. Drop the parameter, use _abort > directly. > > Cc: Cédric Le Goater > Cc: Peter Maydell > Cc: Andrew Jeffery > Cc: Joel Stanley > Cc: qemu-...@nongnu.org > Signed-off-by: Markus Armbruster Reviewed-by: Philippe

Re: [PATCH 13/16] qdev: Make qdev_prop_set_drive() match the other helpers

On 6/8/20 7:20 AM, Markus Armbruster wrote: > Philippe Mathieu-Daudé writes: > >> On 6/5/20 4:56 PM, Markus Armbruster wrote: >>> qdev_prop_set_drive() can fail. None of the other qdev_prop_set_FOO() >>> can; they abort on error. >>> >>> To clean up this inconsistency, rename

Re: [PATCH v5 12/13] qcow2: QcowHeaderExtension print names for extension magics

From: Vladimir Sementsov-Ogievskiy Sent: Saturday, June 6, 2020 11:18 AM To: qemu-bl...@nongnu.org Cc: qemu-devel@nongnu.org ; mre...@redhat.com ; kw...@redhat.com ; ebl...@redhat.com ; Denis Lunev ; Andrey Shinkevich ; Vladimir Sementsov-Ogievskiy

Re: [PATCH 13/16] qdev: Make qdev_prop_set_drive() match the other helpers

Philippe Mathieu-Daudé writes: > On 6/5/20 4:56 PM, Markus Armbruster wrote: >> qdev_prop_set_drive() can fail. None of the other qdev_prop_set_FOO() >> can; they abort on error. >> >> To clean up this inconsistency, rename qdev_prop_set_drive() to >> qdev_prop_set_drive_err(), and create a

Re: [PULL 00/19] Linux user for 5.1 patches

On 05/06/2020 23.48, Richard Henderson wrote: > On 6/5/20 1:32 PM, Peter Maydell wrote: >> On Fri, 5 Jun 2020 at 20:20, Laurent Vivier wrote: >>> I was thinking this kind of problem would be detected by the travis-ci >>> builds, but in fact ppc64 and s390 builds don't build other architecture >>>

Re: [PATCH] block: Remove trailing newline in format used by error_report API

Philippe Mathieu-Daudé writes: [...] > Why warn_reportf_err() doesn't take a 'Error **err' instead, to set err > to NULL after freeing *err? Why doesn't free() take a void ** argument, to set the pointer to null after freeing what it points to? Why doesn't close() take an int * argument?

Re: [PATCH for-5.1 V4 3/4] hw/mips: Add Loongson-3 machine support (with KVM)

Hi, Alexandar, On Mon, Jun 8, 2020 at 4:00 AM Aleksandar Markovic wrote: > > On Sun, Jun 7, 2020 at 3:13 AM chen huacai wrote: > > > > On Sat, Jun 6, 2020 at 4:01 AM Aleksandar Markovic > > wrote: > > > > > > суб, 6. јун 2020. у 09:32 Aleksandar Markovic > > > је написао/ла: > > > > > > > >

Re: [PATCH v2 13/13] tests: Disable select tests under TSan, which hit TSan issue.

On Fri, Jun 05, 2020 at 13:34:22 -0400, Robert Foley wrote: > Disable a few tests under CONFIG_TSAN, which > run into a known TSan issue that results in a hang. > https://github.com/google/sanitizers/issues/1116 > > The disabled tests under TSan include all the qtests as well as > the test-char,

Re: [PATCH v1 7/9] plugins: add API to return a name for a IO device

On Tue, Jun 02, 2020 at 16:46:22 +0100, Alex Bennée wrote: > This may well end up being anonymous but it should always be unique. > > Signed-off-by: Alex Bennée > --- > include/qemu/qemu-plugin.h | 5 + > plugins/api.c | 18 ++ > 2 files changed, 23

Re: [PATCH v8 30/62] target/riscv: Update fp_status when float rounding mode changes

On 2020/6/5 11:30, Richard Henderson wrote: On 6/4/20 7:50 PM, LIU Zhiwei wrote: So no scalar insns will require changes within a translation block. Not true -- scalar insns can encode rm into the instruction. I think there is a error in gen_set_rm static void gen_set_rm(DisasContext

Re: hw/char: a question about watch callback function in serial

On 2020/6/5 10:19, LIU Zhiwei wrote: On 2020/6/4 21:32, Peter Maydell wrote: On Thu, 4 Jun 2020 at 13:15, LIU Zhiwei wrote: I see many UART implementations have a G_IO_OUT | G_IO_HUP callback function. In hw/serial.c, it is serial_watch_cb, setting by the following code,

[PATCH] migration: fix xbzrle encoding rate calculation

It's reported an error of implicit conversion from "unsigned long" to "double" when compiling with Clang 10. Simply make the encoding rate 0 when the encoded_size is 0. Fixes: e460a4b1a4 Reported-by: Richard Henderson Signed-off-by: Wei Wang --- migration/ram.c | 4 +--- 1 file changed, 1

Re: Forward migration broken down since virt-4.2 machine type

ping On 6/4/2020 4:51 PM, Ying Fang wrote: Hi Richard, Recently we are doing some tests on forward migration based on arm virt machine. And we found the patch below breaks forward migration compatibility from virt-4.2 to virt-5.0 above machine type. The patch which breaks this down given by

RE: [RFC] hw: nios2: update interrupt_request when STATUS_PIE disabled

@Chris Wulff @Marek Vasut could you please take a look this issue and patch? Thanks in advance! -Original Message- From: Thomas Huth Sent: Friday, June 5, 2020 3:07 PM To: Wu, Wentong ; qemu-devel@nongnu.org Cc: Chris Wulff ; Marek Vasut Subject: Re: [RFC] hw: nios2: update

Re: [PATCH] net: tulip: Set PCI revision to match dec21143

Hi Sven, could you review thiw one-line patch? On 4/18/20 2:25 AM, Marek Vasut wrote: > The tulip driver claims to emulate dec21143 and it does not emulate dec21142. > The dec21142 and dec21143 can be discerned by the PCI revision register, > where dec21142 reports value < 0x20 and dec21143 value

[PATCH v5] tcg: Sanitize shift constants on ppc64le so that shift operations with large constants don't generate invalid instructions.

From: "Catherine A. Frederick" Signed-off-by: Catherine A. Frederick --- Okay, I removed the bad "fix" on sar_i64, and the asserts in the various functions. Crossing my fingers here. tcg/ppc/tcg-target.inc.c | 34 +- 1 file changed, 29 insertions(+), 5

Re: [PULL 00/21] MIPS queue for June 7th, 2020

Patchew URL: https://patchew.org/QEMU/1591559185-31287-1-git-send-email-aleksandar.qemu.de...@gmail.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally.

Re: [PATCH for-5.1 V4 3/4] hw/mips: Add Loongson-3 machine support (with KVM)

On Sun, Jun 7, 2020 at 3:13 AM chen huacai wrote: > > On Sat, Jun 6, 2020 at 4:01 AM Aleksandar Markovic > wrote: > > > > суб, 6. јун 2020. у 09:32 Aleksandar Markovic > > је написао/ла: > > > > > > уто, 2. јун 2020. у 04:40 Huacai Chen је > > > написао/ла: > > > > > > > > Add Loongson-3

[PATCH V3 2/3] migration/colo: Update checkpoint time lately

From: Zhang Chen Previous operation(like vm_start and replication_start_all) will consume extra time for first forced synchronization, so reduce it in this patch. Signed-off-by: Zhang Chen Reviewed-by: zhanghailiang Reviewed-by: Lukas Straub Tested-by: Lukas Straub --- migration/colo.c | 5

[PULL 20/21] target/mips: Add Loongson-3 CPU definition

From: Huacai Chen Loongson-3 CPU family include Loongson-3A R1/R2/R3/R4 and Loongson-3B R1/R2. Loongson-3A R1 is the oldest and its ISA is the smallest, while Loongson-3A R4 is the newest and its ISA is almost the superset of all others. To reduce complexity, we just define two CPU types: 1)

[PULL 21/21] target/mips: Enable hardware page table walker and CMGCR features for P5600

From: Andrea Oliveri Enable hardware page table walker and CMGCR features for P5600 that supports both. Signed-off-by: Andrea Oliveri Reviewed-by: Aleksandar Markovic Signed-off-by: Aleksandar Markovic Message-Id: --- target/mips/translate_init.inc.c | 9 + 1 file changed, 5

[PULL 18/21] target/mips: fpu: Refactor conversion from ieee to mips exception flags

The original coversion function is used for regular and MSA floating point instructions handling. Since there are some nuanced differences between regular and MSA floating point exception handling, provide two instances of the conversion function, rather than just a single common one. Inline both

[PULL 16/21] target/mips: fpu: Remove now unused FLOAT_RINT macro

After demacroing RINT., this macro is not needed anymore. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic Message-Id: <20200518200920.17344-15-aleksandar.qemu.de...@gmail.com> --- target/mips/fpu_helper.c | 13 - 1 file changed, 13 deletions(-) diff --git

[PULL 15/21] target/mips: fpu: Demacro RINT.

This is just a cosmetic change to enable tools like gcov, gdb, callgrind, etc. to better display involved source code. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic Message-Id: <20200518200920.17344-14-aleksandar.qemu.de...@gmail.com> --- target/mips/fpu_helper.c | 20

[PATCH V3 3/3] migration/migration.c: Remove MIGRATION_STATUS_ACTIVE in migration_iteration_finish

From: Zhang Chen MIGRATION_STATUS_ACTIVE is invalid here, handle it by default case. Suggested-by: Lukas Straub Signed-off-by: Zhang Chen --- migration/migration.c | 5 - 1 file changed, 5 deletions(-) diff --git a/migration/migration.c b/migration/migration.c index

[PATCH V3 1/3] migration/colo: Optimize COLO boot code path

From: Zhang Chen No need to reuse MIGRATION_STATUS_ACTIVE boot COLO. Signed-off-by: Zhang Chen Reviewed-by: zhanghailiang --- migration/colo.c | 2 -- migration/migration.c | 17 ++--- 2 files changed, 10 insertions(+), 9 deletions(-) diff --git a/migration/colo.c

[PULL 14/21] target/mips: fpu: Remove now unused FLOAT_CLASS macro

After demacroing CLASS., this macro is not needed anymore. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic Message-Id: <20200518200920.17344-13-aleksandar.qemu.de...@gmail.com> --- target/mips/fpu_helper.c | 39 --- 1 file changed, 39

[PULL 12/21] target/mips: fpu: Remove now unused UNFUSED_FMA and FLOAT_FMA macros

After demacroing ., these macros are not needed anymore. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic Message-Id: <20200518200920.17344-11-aleksandar.qemu.de...@gmail.com> --- target/mips/fpu_helper.c | 50 1 file changed,

[PATCH V3 0/3] migration/colo: Optimize COLO framework code

From: Zhang Chen This series optimize some code of COLO, please review. Zhang Chen (3): migration/colo: Optimize COLO boot code path migration/colo: Update checkpoint time lately migration/migration.c: Remove MIGRATION_STATUS_ACTIVE in migration_iteration_finish migration/colo.c

[PULL 19/21] hw/mips: Implement the kvm_type() hook in MachineClass

From: Huacai Chen MIPS has two types of KVM: TE & VZ, and TE is the default type. Now we can't create a VZ guest in QEMU because it lacks the kvm_type() hook in MachineClass. Besides, libvirt uses a null-machine to detect the kvm capability, so by default it will return "KVM not supported" on a

[PULL 17/21] target/mips: fpu: Name better paired-single variables

Use consistently 'l' and 'h' for low and high halves. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic Message-Id: <20200518200920.17344-16-aleksandar.qemu.de...@gmail.com> --- target/mips/fpu_helper.c | 62 1 file changed, 31

[PULL 11/21] target/mips: fpu: Demacro NMSUB.

This is just a cosmetic change to enable tools like gcov, gdb, callgrind, etc. to better display involved source code. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic Message-Id: <20200518200920.17344-10-aleksandar.qemu.de...@gmail.com> --- target/mips/fpu_helper.c | 44

[PULL 09/21] target/mips: fpu: Demacro MSUB.

This is just a cosmetic change to enable tools like gcov, gdb, callgrind, etc. to better display involved source code. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic Message-Id: <20200518200920.17344-8-aleksandar.qemu.de...@gmail.com> --- target/mips/fpu_helper.c | 40

[PULL 10/21] target/mips: fpu: Demacro NMADD.

This is just a cosmetic change to enable tools like gcov, gdb, callgrind, etc. to better display involved source code. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic Message-Id: <20200518200920.17344-9-aleksandar.qemu.de...@gmail.com> --- target/mips/fpu_helper.c | 44

[PULL 08/21] target/mips: fpu: Demacro MADD.

This is just a cosmetic change to enable tools like gcov, gdb, callgrind, etc. to better display involved source code. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic Message-Id: <20200518200920.17344-7-aleksandar.qemu.de...@gmail.com> --- target/mips/fpu_helper.c | 41

[PULL 13/21] target/mips: fpu: Demacro CLASS.

This is just a cosmetic change to enable tools like gcov, gdb, callgrind, etc. to better display involved source code. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic Message-Id: <20200518200920.17344-12-aleksandar.qemu.de...@gmail.com> --- target/mips/fpu_helper.c | 70

[PULL 07/21] target/mips: fpu: Remove now unused macro FLOAT_BINOP

After demacroing ., this macro is not needed anymore. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic Message-Id: <20200518200920.17344-6-aleksandar.qemu.de...@gmail.com> --- target/mips/fpu_helper.c | 39 --- 1 file changed, 39

[PULL 04/21] target/mips: fpu: Demacro SUB.

This is just a cosmetic change to enable tools like gcov, gdb, callgrind, etc. to better display involved source code. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic Message-Id: <20200518200920.17344-3-aleksandar.qemu.de...@gmail.com> --- target/mips/fpu_helper.c | 37

[PULL 06/21] target/mips: fpu: Demacro DIV.

This is just a cosmetic change to enable tools like gcov, gdb, callgrind, etc. to better display involved source code. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic Message-Id: <20200518200920.17344-5-aleksandar.qemu.de...@gmail.com> --- target/mips/fpu_helper.c | 37

[PULL 05/21] target/mips: fpu: Demacro MUL.

This is just a cosmetic change to enable tools like gcov, gdb, callgrind, etc. to better display involved source code. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic Message-Id: <20200518200920.17344-4-aleksandar.qemu.de...@gmail.com> --- target/mips/fpu_helper.c | 37

[PULL 00/21] MIPS queue for June 7th, 2020

The following changes since commit 175198ad91d8bac540159705873b4ffe4fb94eab: Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20200605' into staging (2020-06-05 17:45:59 +0100) are available in the git repository at: https://github.com/AMarkovic/qemu tags/mips-queue-june-07-2020

[PULL 02/21] mailmap: Change email address of Stefan Brankovic

Stefan Brankovic wants to use his new email address for his future work in QEMU. CC: Stefan Brankovic Signed-off-by: Aleksandar Markovic Reviewed-by: Stefan Brankovic Message-Id: <20200602085215.12585-3-aleksandar.qemu.de...@gmail.com> --- .mailmap | 1 + 1 file changed, 1 insertion(+) diff

[PULL 03/21] target/mips: fpu: Demacro ADD.

This is just a cosmetic change to enable tools like gcov, gdb, callgrind, etc. to better display involved source code. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic Message-Id: <20200518200920.17344-2-aleksandar.qemu.de...@gmail.com> --- target/mips/fpu_helper.c | 38

[PULL 01/21] mailmap: Change email address of Filip Bozuta

Filip Bozuta wants to use his new email address for his future work in QEMU. CC: Filip Bozuta Signed-off-by: Aleksandar Markovic Reviewed-by: Filip Bozuta Message-Id: <20200602085215.12585-2-aleksandar.qemu.de...@gmail.com> --- .mailmap | 1 + 1 file changed, 1 insertion(+) diff --git

RE: [PATCH V2 1/2] migration/colo: Optimize COLO boot code path

> -Original Message- > From: Lukas Straub > Sent: Sunday, June 7, 2020 3:57 AM > To: Zhang, Chen > Cc: Dr . David Alan Gilbert ; qemu-dev de...@nongnu.org>; Zhanghailiang ; > Zhang Chen > Subject: Re: [PATCH V2 1/2] migration/colo: Optimize COLO boot code path > > On Thu, 4 Jun

Re: [PATCH v6 00/20] nvme: small fixes, refactoring and cleanups

On Sun, 2020-06-07 at 15:51 +0300, Maxim Levitsky wrote: > On Tue, 2020-06-02 at 17:31 +0200, Kevin Wolf wrote: > > Am 14.05.2020 um 06:45 hat Klaus Jensen geschrieben: > > > From: Klaus Jensen > > > > > > Changes since v5 > > > > > > * Prefixed all patches with "hw/block/nvme"

Re: [PATCH v7 00/14] LUKS: encryption slot management using amend interface

On Tue, 2020-06-02 at 18:29 +0200, Max Reitz wrote: > On 18.05.20 14:20, Maxim Levitsky wrote: > > Hi! > > Here is the updated series of my patches, incorporating all the feedback I > > received. > > You asked me on IRC what to do to get this series to move forward; > considering I don’t think

Re: [PATCH] MAINTAINERS: Fix the classification of bios-tables-test-allowed-diff.h

On Sun, Jun 7, 2020 at 7:21 AM Thomas Huth wrote: > > The file tests/qtest/bios-tables-test-allowed-diff.h is currently only > assigned to the qtest section according MAINTAINERS. However, this file > normally only gets updated when the ACPI tables changed - something the > qtest maintainers

Re: [PATCH v6 00/20] nvme: small fixes, refactoring and cleanups

On Tue, 2020-06-02 at 17:31 +0200, Kevin Wolf wrote: > Am 14.05.2020 um 06:45 hat Klaus Jensen geschrieben: > > From: Klaus Jensen > > > > Changes since v5 > > > > * Prefixed all patches with "hw/block/nvme" to avoid confusion with the > > nvme block driver. > > > > * Added

Re: [PATCH] Makefile: set PYTHON to python2 instead of python

I should have included [SeaBIOS]. Sorry. On 2020-06-07 10:56, Frédéric Pierret (fepitre) wrote: > Newer distro like CentOS 8 does not include any reference > to 'python' binary but only 'python2'. > --- > Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Makefile

[PATCH] Makefile: set PYTHON to python2 instead of python

Newer distro like CentOS 8 does not include any reference to 'python' binary but only 'python2'. --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index c20be15..995dc86 100644 --- a/Makefile +++ b/Makefile @@ -22,7 +22,7 @@ LD=$(CROSS_PREFIX)ld

Re: gitlab-ci: Do not use the standard container images from gitlab

I see, thanks for the clarification. However sometimes builds usually do tend to work on Ubuntu but fail to work on Debian since it's not always a 1-1 (as in this case) - so you might want to consider to keep testing Debian together with Ubuntu. Regarding the Ubuntu 20 problem - have you tried

Re: [PATCH v1 00/14] various fixes for next PR (testing, vhost, guest_base fixes)

On 05/06/2020 17.49, Alex Bennée wrote: > Hi, > > These are all the patches I've currently got which are ready for a > pull request next week. I've included some patches which are destined > to go in via other trees so I can keep the testing green on the CI. > > In summary: > > Some simple

Re: [PATCH v5 0/2] Makefile: libfdt: build only the strict necessary

Hi David, could you maybe take this through your ppc tree? Thanks, Thomas On 01/06/2020 13.28, Claudio Fontana wrote: > Hello all, > > is this queued somewhere? > > Thanks, > > Claudio > > On 5/18/20 6:03 PM, Claudio Fontana wrote: >> v4 -> v5: >> >> * include the dtc submodule update

Re: [PATCH] hw/misc/auxbus: Use qemu_log_mask(UNIMP) instead of debug printf

On 06/06/2020 09.02, Philippe Mathieu-Daudé wrote: > Replace a deprecated DPRINTF() call by qemu_log_mask(LOG_UNIMP). > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/misc/auxbus.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/misc/auxbus.c b/hw/misc/auxbus.c