Re: [PATCH 5/6] audio/jack: honour the enable state of the audio device

2020-06-20 Thread Geoffrey McRae
On 2020-06-19 19:29, Gerd Hoffmann wrote: Hi, > Hmm, I guess feeding silence into jack needs some cpu cycles? > Maybe add a timer to close the jack server connection? Keep the > connection open for re-use for a while, but in case the guest stops > playing sound altogether close the jack

[PATCH v1 0/1] COLO: migrate dirty ram pages before colo checkpoint

2020-06-20 Thread Derek Su
This series is to reduce the guest's downtime during colo checkpoint by migrating dirty ram pages as many as possible before colo checkpoint. If the iteration count reaches COLO_RAM_MIGRATE_ITERATION_MAX or ram pending size is lower than 'x-colo-migrate-ram-threshold', stop the ram migration and

[PATCH v1 1/1] migration/colo.c: migrate dirty ram pages before colo checkpoint

2020-06-20 Thread Derek Su
To reduce the guest's downtime during checkpoint, migrate dirty ram pages as many as possible before colo checkpoint. If the iteration count reaches COLO_RAM_MIGRATE_ITERATION_MAX or ram pending size is lower than 'x-colo-migrate-ram-threshold', stop the ram migration and colo checkpoint.

Re: [PATCH v3 1/7] hw/misc: Add a LED device

2020-06-20 Thread Richard Henderson
On 6/20/20 4:07 PM, Philippe Mathieu-Daudé wrote: > Add a LED device which can be connected to a GPIO output. > LEDs are limited to a set of colors. > They can also be dimmed with PWM devices. For now we do > not implement the dimmed mode, but in preparation of a > future implementation, we start

[Bug 1668041] Re: x86 Floating point exceptions - incorrect support?

2020-06-20 Thread Rin Okuyama
Hi, This problem still exists on QEMU 5.0.0 both for i386 and x86_64; floating-point zero division is not trapped at all, while integer one is trapped correctly. This seriously affects NetBSD project, which carries out periodic regression tests on QEMU:

Re: [PATCH v3 0/7] hw/misc: Add LED device

2020-06-20 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200620230719.32139-1-f4...@amsat.org/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

Re: [PATCH v3 00/11] Record/replay acceptance tests

2020-06-20 Thread Philippe Mathieu-Daudé
Hi Pavel, On 5/31/20 5:09 PM, Philippe Mathieu-Daudé wrote: > On 5/29/20 9:04 AM, Pavel Dovgalyuk wrote: >> The following series adds record/replay tests to the acceptance group. >> Test pass successfully with the latest submitted record/replay fixes: >> - replay: notify the main loop when there

[PATCH] .travis.yml: Build acceptance tests with -O2 compiler optimization

2020-06-20 Thread Philippe Mathieu-Daudé
As we just want the tests to succeed, build them with compiler optimizations enabled to run the tests faster. Signed-off-by: Philippe Mathieu-Daudé --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 74158f741b..61b247db9f 100644

Re: [PATCH v2] docs/devel: add some notes on tcg-icount for developers

2020-06-20 Thread Richard Henderson
On 6/19/20 10:09 AM, Alex Bennée wrote: > +TCG has long supported a feature known as icount which allows for > +instruction counting during execution. This should be confused with should not be > +cycle accurate emulation - QEMU does not attempt to emulate how long --- for em-dash, iirc, and

Re: [PATCH rc1 12/15] hw/rx: Register R5F562N7 and R5F562N8 MCUs

2020-06-20 Thread Philippe Mathieu-Daudé
On 6/20/20 7:31 PM, Richard Henderson wrote: > On 6/17/20 12:15 PM, Philippe Mathieu-Daudé wrote: >> +/* XTAL range: 8-14 MHz */ >> +if (s->xtal_freq_hz < 8e6 || s->xtal_freq_hz > 14e6) { >> +error_setg(errp, "\"xtal-frequency-hz\" property in incorrect >> range."); >> +

[PATCH v3 7/7] hw/arm/tosa: Replace fprintf() calls by LED devices

2020-06-20 Thread Philippe Mathieu-Daudé
The recently added LED device reports LED status changes with the 'led_set_intensity' trace event. It is less invasive than the fprintf() calls. We need however to have a binary built with tracing support. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/tosa.c | 40

[PATCH v3 6/7] hw/misc/mps2-scc: Use the LED device

2020-06-20 Thread Philippe Mathieu-Daudé
Per the 'ARM MPS2 and MPS2+ FPGA Prototyping Boards Technical Reference Manual' (100112_0200_07_en): 2.1 Overview of the MPS2 and MPS2+ hardware The MPS2 and MPS2+ FPGA Prototyping Boards contain the following components and interfaces: * User switches and user LEDs:

[PATCH v3 5/7] hw/misc/mps2-fpgaio: Use the LED device

2020-06-20 Thread Philippe Mathieu-Daudé
Per the 'ARM MPS2 and MPS2+ FPGA Prototyping Boards Technical Reference Manual' (100112_0200_07_en): 2.1 Overview of the MPS2 and MPS2+ hardware The MPS2 and MPS2+ FPGA Prototyping Boards contain the following components and interfaces: * User switches and user LEDs:

[PATCH v3 4/7] hw/arm/aspeed: Add the 3 front LEDs drived by the PCA9552 #1

2020-06-20 Thread Philippe Mathieu-Daudé
The Witherspoon has 3 LEDs connected to a PCA9552. Add them. The names and reset values are taken from: https://github.com/open-power/witherspoon-xml/blob/master/witherspoon.xml Example booting obmc-phosphor-image: $ qemu-system-arm -M witherspoon-bmc -trace led_change_intensity

[PATCH v3 1/7] hw/misc: Add a LED device

2020-06-20 Thread Philippe Mathieu-Daudé
Add a LED device which can be connected to a GPIO output. LEDs are limited to a set of colors. They can also be dimmed with PWM devices. For now we do not implement the dimmed mode, but in preparation of a future implementation, we start using the LED intensity. When used with GPIOs, the intensity

[PATCH v3 2/7] hw/misc/led: Add helper to connect LED to GPIO output

2020-06-20 Thread Philippe Mathieu-Daudé
Some devices expose GPIO lines. Add the create_led_by_gpio_id() helper to connect a LED to such GPIO. Signed-off-by: Philippe Mathieu-Daudé --- Adding support for named GPIO is trivial. We don't need it yet. --- include/hw/misc/led.h | 20 hw/misc/led.c | 25

[PATCH v3 3/7] hw/misc/led: Emit a trace event when LED intensity has changed

2020-06-20 Thread Philippe Mathieu-Daudé
Track the LED intensity, and emit a trace event when it changes. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/misc/led.h | 1 + hw/misc/led.c | 5 + hw/misc/trace-events | 1 + 3 files changed, 7 insertions(+) diff --git a/include/hw/misc/led.h b/include/hw/misc/led.h

[PATCH v3 0/7] hw/misc: Add LED device

2020-06-20 Thread Philippe Mathieu-Daudé
Hello, These patches are part of the GSoC unselected 'QEMU visualizer' project. As the AVR port is not merged, I switched to microbit to keep working on it. This series presents a proof of concept of LED device that can be easily connected to a GPIO. Since v2: - Rebased on PCA9552 - Model

[PATCH v4 8/8] hw/misc/pca9552: Model qdev output GPIOs

2020-06-20 Thread Philippe Mathieu-Daudé
The PCA9552 has 16 GPIOs which can be used as input, output or PWM mode. QEMU models the output GPIO with the qemu_irq type. Let the device expose the 16 GPIOs to allow us to later connect LEDs to these outputs. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/misc/pca9552.h | 1 +

[PATCH v4 4/8] hw/misc/pca9552: Add a 'description' property for debugging purpose

2020-06-20 Thread Philippe Mathieu-Daudé
Add a description field to distinguish between multiple devices. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/misc/pca9552.h | 1 + hw/misc/pca9552.c | 10 ++ 2 files changed, 11 insertions(+) diff --git a/include/hw/misc/pca9552.h b/include/hw/misc/pca9552.h index

[PATCH v4 2/8] hw/misc/pca9552: Replace magic value by PCA9552_PIN_COUNT definition

2020-06-20 Thread Philippe Mathieu-Daudé
Replace the '16' magic value by the PCA9552_PIN_COUNT definition. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/misc/pca9552.h | 1 + hw/misc/pca9552.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/include/hw/misc/pca9552.h b/include/hw/misc/pca9552.h

[PATCH v4 5/8] hw/misc/pca9552: Trace GPIO High/Low events

2020-06-20 Thread Philippe Mathieu-Daudé
Add a trivial representation of the PCA9552 GPIOs. Example booting obmc-phosphor-image: $ qemu-system-arm -M witherspoon-bmc -trace pca9552_gpio_status 1592689902.327837:pca9552_gpio_status pca-unspecified GPIOs 0-15 [*...] 1592689902.329934:pca9552_gpio_status pca-unspecified

[PATCH v4 6/8] hw/arm/aspeed: Describe each PCA9552 device

2020-06-20 Thread Philippe Mathieu-Daudé
We have 2 distinct PCA9552 devices. Set their description to distinguish them when looking at the trace events. Description name taken from: https://github.com/open-power/witherspoon-xml/blob/master/witherspoon.xml Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/aspeed.c | 13 + 1

[PATCH v4 7/8] hw/misc/pca9552: Trace GPIO change events

2020-06-20 Thread Philippe Mathieu-Daudé
Emit a trace event when a GPIO change its state. Example booting obmc-phosphor-image: $ qemu-system-arm -M witherspoon-bmc -trace pca9552_gpio_change 1592690552.687372:pca9552_gpio_change pca1 GPIO id:0 status: 0 -> 1 1592690552.690169:pca9552_gpio_change pca1 GPIO id:1 status: 0 -> 1

[PATCH v4 0/8] hw/misc/pca9552: Trace GPIO change events

2020-06-20 Thread Philippe Mathieu-Daudé
This series add trace events to better display GPIO changes. We'll continue in the following series by connecting LEDs to these GPIOs. This helps me to work on a generic LED device, see: https://www.mail-archive.com/qemu-devel@nongnu.org/msg711917.html Example when booting an

[PATCH v4 1/8] hw/i2c/core: Add i2c_try_create_slave() and i2c_realize_and_unref()

2020-06-20 Thread Philippe Mathieu-Daudé
Extract i2c_try_create_slave() and i2c_realize_and_unref() from i2c_create_slave(). We can now set properties on a I2CSlave before it is realized. This is in line with the recent qdev/QOM changes merged in commit 6675a653d2e. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/i2c/i2c.h | 2

[PATCH v4 3/8] hw/misc/pca9552: Use the PCA9552_PIN_COUNT definition

2020-06-20 Thread Philippe Mathieu-Daudé
The current code models the PCA9552, but there are comments saying the code could be easily adapted for the rest of the PCA955x family. Since we assume we have at most 16 pins (for the PCA9552), add a definition and check the instance doesn't use more than this number. This makes the code a bit

Re: [PATCH 00/78] Patch Round-up for stable 4.2.1, freeze on 2020-06-22

2020-06-20 Thread Bruce Rogers
Hi Michael, Our upcoming SLE15-SP2 and Leap 15.2 releases have a qemu package which is based on v4.2.0. In addition to some of the patches already mentioned, here is a list of others we have backported as being stable material. I threw a little wider net this time than usual, so feel free to

[PATCH] tests/qht-bench: Adjust rate computation and comparisons

2020-06-20 Thread Richard Henderson
Use <= comparisons vs the threshold, so that threshold UINT64_MAX is always true, corresponding to rate 1.0 being unity. Simplify do_threshold scaling to 2**64, with a special case for 1.0. Cc: Emilio G. Cota Signed-off-by: Richard Henderson --- tests/qht-bench.c | 15 +++ 1 file

[PATCH v3 3/9] sm501: Ignore no-op blits

2020-06-20 Thread BALATON Zoltan
Some guests seem to try source copy blits with same source and dest which are no-op so avoid calling pixman for these. Signed-off-by: BALATON Zoltan Reviewed-by: Peter Maydell --- hw/display/sm501.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/display/sm501.c

[PATCH v3 6/9] sm501: Use stn_he_p/ldn_he_p instead of switch/case

2020-06-20 Thread BALATON Zoltan
Instead of open coding op with different sizes using a switch and type casting it can be written more compactly using stn_he_p/ldn_he_p. Suggested-by: Peter Maydell Signed-off-by: BALATON Zoltan Reviewed-by: Philippe Mathieu-Daudé --- hw/display/sm501.c | 12 +--- 1 file changed, 1

[PATCH v3 4/9] sm501: Introduce variable for commonly used value for better readability

2020-06-20 Thread BALATON Zoltan
The bytes per pixel value can be calculated from format but it's used freqently enough (and will be used more in subseqent patches) so store it in a variable for better readabilty. Also drop some unneded 0x prefix around where new variable is defined. Signed-off-by: BALATON Zoltan Reviewed-by:

[PATCH v3 5/9] sm501: Optimise 1 pixel 2d ops

2020-06-20 Thread BALATON Zoltan
Some guests do 1x1 blits which is faster to do directly than calling a function for it so avoid overhead in this case. Signed-off-by: BALATON Zoltan Reviewed-by: Peter Maydell --- hw/display/sm501.c | 19 --- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git

[PATCH v3 0/9] More sm501 fixes and optimisations

2020-06-20 Thread BALATON Zoltan
Version 3: added R-b tags and new patch to fix overlap checks. Hopefully I got it right this time, unless there are any more comments this should be good to go. BALATON Zoltan (9): sm501: Fix bounds checks sm501: Drop unneded variable sm501: Ignore no-op blits sm501: Introduce variable

[PATCH QEMU v25 15/17] vfio: Add ioctl to get dirty pages bitmap during dma unmap.

2020-06-20 Thread Kirti Wankhede
With vIOMMU, IO virtual address range can get unmapped while in pre-copy phase of migration. In that case, unmap ioctl should return pages pinned in that range and QEMU should find its correcponding guest physical addresses and report those dirty. Suggested-by: Alex Williamson Signed-off-by:

[PATCH v3 8/9] sm501: Convert debug printfs to traces

2020-06-20 Thread BALATON Zoltan
Signed-off-by: BALATON Zoltan Reviewed-by: Peter Maydell --- hw/display/sm501.c | 50 +++-- hw/display/trace-events | 12 ++ 2 files changed, 25 insertions(+), 37 deletions(-) diff --git a/hw/display/sm501.c b/hw/display/sm501.c index

[PATCH v3 7/9] sm501: Do not allow guest to set invalid format

2020-06-20 Thread BALATON Zoltan
Prevent guest setting invalid format value that might trip checks in sm501_2d_operation(). Signed-off-by: BALATON Zoltan Reviewed-by: Peter Maydell --- hw/display/sm501.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/display/sm501.c b/hw/display/sm501.c index 6349f31e64..7e4c042d52

[PATCH v3 2/9] sm501: Drop unneded variable

2020-06-20 Thread BALATON Zoltan
We don't need a separate variable to keep track if we allocated memory that needs to be freed as we can test the pointer itself. Signed-off-by: BALATON Zoltan Reviewed-by: Peter Maydell --- hw/display/sm501.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git

[PATCH v3 9/9] sm501: Fix and optimize overlap check

2020-06-20 Thread BALATON Zoltan
When doing reverse blit we need to check if source and dest overlap but it is not trivial due to possible different base and pitch of source and dest. Do rectangle overlap if base and pitch match, otherwise just check if memory area containing the rects overlaps so rects could possibly overlap.

[PATCH QEMU v25 13/17] vfio: create mapped iova list when vIOMMU is enabled

2020-06-20 Thread Kirti Wankhede
Create mapped iova list when vIOMMU is enabled. For each mapped iova save translated address. Add node to list on MAP and remove node from list on UNMAP. This list is used to track dirty pages during migration. Signed-off-by: Kirti Wankhede --- hw/vfio/common.c | 58

[PATCH v3 1/9] sm501: Fix bounds checks

2020-06-20 Thread BALATON Zoltan
We don't need to add width to pitch when calculating last point, that would reject valid ops within the card's local_mem. Fixes: b15a22bbcbe6a78dc3d88fe3134985e4cdd87de4 Signed-off-by: BALATON Zoltan Reviewed-by: Peter Maydell --- hw/display/sm501.c | 8 1 file changed, 4

[PATCH QEMU v25 16/17] vfio: Make vfio-pci device migration capable

2020-06-20 Thread Kirti Wankhede
If device is not failover primary device call vfio_migration_probe() and vfio_migration_finalize() functions for vfio-pci device to enable migration for vfio PCI device which support migration. Removed vfio_pci_vmstate structure. Removed migration blocker from VFIO PCI device specific structure

[PATCH QEMU v25 11/17] vfio: Get migration capability flags for container

2020-06-20 Thread Kirti Wankhede
Added helper functions to get IOMMU info capability chain. Added function to get migration capability information from that capability chain for IOMMU container. Similar change was proposed earlier: https://lists.gnu.org/archive/html/qemu-devel/2018-05/msg03759.html Signed-off-by: Kirti Wankhede

[PATCH QEMU v25 17/17] qapi: Add VFIO devices migration stats in Migration stats

2020-06-20 Thread Kirti Wankhede
Added amount of bytes transferred to the target VM by all VFIO devices Signed-off-by: Kirti Wankhede --- hw/vfio/common.c| 20 hw/vfio/migration.c | 11 ++- include/qemu/vfio-helpers.h | 3 +++ migration/migration.c | 14 ++

[PATCH QEMU v25 14/17] vfio: Add vfio_listener_log_sync to mark dirty pages

2020-06-20 Thread Kirti Wankhede
vfio_listener_log_sync gets list of dirty pages from container using VFIO_IOMMU_GET_DIRTY_BITMAP ioctl and mark those pages dirty when all devices are stopped and saving state. Return early for the RAM block section of mapped MMIO region. Signed-off-by: Kirti Wankhede Reviewed-by: Neo Jia ---

[PATCH QEMU v25 10/17] memory: Set DIRTY_MEMORY_MIGRATION when IOMMU is enabled

2020-06-20 Thread Kirti Wankhede
mr->ram_block is NULL when mr->is_iommu is true, then fr.dirty_log_mask wasn't set correctly due to which memory listener's log_sync doesn't get called. This patch returns log_mask with DIRTY_MEMORY_MIGRATION set when IOMMU is enabled. Signed-off-by: Kirti Wankhede --- memory.c | 2 +- 1 file

[PATCH QEMU v25 12/17] vfio: Add function to start and stop dirty pages tracking

2020-06-20 Thread Kirti Wankhede
Call VFIO_IOMMU_DIRTY_PAGES ioctl to start and stop dirty pages tracking for VFIO devices. Signed-off-by: Kirti Wankhede Reviewed-by: Dr. David Alan Gilbert --- hw/vfio/migration.c | 36 1 file changed, 36 insertions(+) diff --git a/hw/vfio/migration.c

[PATCH QEMU v25 06/17] vfio: Add migration state change notifier

2020-06-20 Thread Kirti Wankhede
Added migration state change notifier to get notification on migration state change. These states are translated to VFIO device state and conveyed to vendor driver. Signed-off-by: Kirti Wankhede Reviewed-by: Neo Jia Reviewed-by: Dr. David Alan Gilbert --- hw/vfio/migration.c | 29

[PATCH QEMU v25 05/17] vfio: Add VM state change handler to know state of VM

2020-06-20 Thread Kirti Wankhede
VM state change handler gets called on change in VM's state. This is used to set VFIO device state to _RUNNING. Signed-off-by: Kirti Wankhede Reviewed-by: Neo Jia Reviewed-by: Dr. David Alan Gilbert --- hw/vfio/migration.c | 87 +++

[PATCH QEMU v25 09/17] vfio: Add load state functions to SaveVMHandlers

2020-06-20 Thread Kirti Wankhede
Sequence during _RESUMING device state: While data for this device is available, repeat below steps: a. read data_offset from where user application should write data. b. write data of data_size to migration region from data_offset. c. write data_size which indicates vendor driver that data is

[PATCH QEMU v25 08/17] vfio: Add save state functions to SaveVMHandlers

2020-06-20 Thread Kirti Wankhede
Added .save_live_pending, .save_live_iterate and .save_live_complete_precopy functions. These functions handles pre-copy and stop-and-copy phase. In _SAVING|_RUNNING device state or pre-copy phase: - read pending_bytes. If pending_bytes > 0, go through below steps. - read data_offset - indicates

[PATCH QEMU v25 04/17] vfio: Add migration region initialization and finalize function

2020-06-20 Thread Kirti Wankhede
Whether the VFIO device supports migration or not is decided based of migration region query. If migration region query is successful and migration region initialization is successful then migration is supported else migration is blocked. Signed-off-by: Kirti Wankhede Reviewed-by: Neo Jia

[PATCH QEMU v25 07/17] vfio: Register SaveVMHandlers for VFIO device

2020-06-20 Thread Kirti Wankhede
Define flags to be used as delimeter in migration file stream. Added .save_setup and .save_cleanup functions. Mapped & unmapped migration region from these functions at source during saving or pre-copy phase. Set VFIO device state depending on VM's state. During live migration, VM is running when

[PATCH QEMU v25 03/17] vfio: Add save and load functions for VFIO PCI devices

2020-06-20 Thread Kirti Wankhede
These functions save and restore PCI device specific data - config space of PCI device. Tested save and restore with MSI and MSIX type. Signed-off-by: Kirti Wankhede Reviewed-by: Neo Jia --- hw/vfio/pci.c | 95 +++

[PATCH QEMU v25 01/17] vfio: Add function to unmap VFIO region

2020-06-20 Thread Kirti Wankhede
This function will be used for migration region. Migration region is mmaped when migration starts and will be unmapped when migration is complete. Signed-off-by: Kirti Wankhede Reviewed-by: Neo Jia Reviewed-by: Cornelia Huck --- hw/vfio/common.c | 32

[PATCH QEMU v25 00/17] Add migration support for VFIO devices

2020-06-20 Thread Kirti Wankhede
Hi, Sorry for little delay for this iteration. I had adresses most of the concerns raised in v16, v18 and v23 versions. More details about changes below. This Patch set adds migration support for VFIO devices in QEMU. This Patch set include patches as below: Patch 1-2: - Few code refactor

[PATCH QEMU v25 02/17] vfio: Add vfio_get_object callback to VFIODeviceOps

2020-06-20 Thread Kirti Wankhede
Hook vfio_get_object callback for PCI devices. Signed-off-by: Kirti Wankhede Reviewed-by: Neo Jia Suggested-by: Cornelia Huck Reviewed-by: Cornelia Huck --- hw/vfio/pci.c | 8 include/hw/vfio/vfio-common.h | 1 + 2 files changed, 9 insertions(+) diff --git

Re: [PATCH v9 1/5] hw/nvram/fw_cfg: Add the FW_CFG_DATA_GENERATOR interface

2020-06-20 Thread Richard Henderson
On 6/16/20 8:31 AM, Daniel P. Berrangé wrote: >fw_cfg_add_file(s, filename, g_byte_array_steal(data, NULL), >(guint)g_byte_array_get_size(data)); FWIW, you can't both read the size and steal the data in the argument list like this -- the evaluation order is unspecified.

Re: [PATCH v4 2/7] MAINTAINERS: Add an entry for common Renesas peripherals

2020-06-20 Thread Richard Henderson
On 6/11/20 4:43 AM, Philippe Mathieu-Daudé wrote: > Renesas peripherals are common to SH4/RX based MCUs. Their > datasheets share common sections. It makes sense to maintain > them altogether. > Add the uncovered UART SCI peripheral. > The current names are misleading (see the 'sh_' prefix). > In

Re: [PATCH rc1 15/15] docs: Document the RX target

2020-06-20 Thread Richard Henderson
On 6/17/20 12:15 PM, Philippe Mathieu-Daudé wrote: > From: Yoshinori Sato > > Add rx-virt target specification document. > > Signed-off-by: Yoshinori Sato > Message-Id: <20200308130637.37651-1-ys...@users.sourceforge.jp> > [PMD: Cover in MAINTAINERS, rename as gdbsim, use machine argument] >

Re: [PATCH rc1 14/15] BootLinuxConsoleTest: Test the RX GDB simulator

2020-06-20 Thread Richard Henderson
On 6/17/20 12:15 PM, Philippe Mathieu-Daudé wrote: > From: Philippe Mathieu-Daudé > > Add two tests for the rx-gdbsim machine, based on the recommended > test setup from Yoshinori Sato: > https://lists.gnu.org/archive/html/qemu-devel/2019-05/msg03586.html > > - U-Boot prompt > - Linux kernel

Re: [PATCH rc1 12/15] hw/rx: Register R5F562N7 and R5F562N8 MCUs

2020-06-20 Thread Richard Henderson
On 6/17/20 12:15 PM, Philippe Mathieu-Daudé wrote: > +/* XTAL range: 8-14 MHz */ > +if (s->xtal_freq_hz < 8e6 || s->xtal_freq_hz > 14e6) { > +error_setg(errp, "\"xtal-frequency-hz\" property in incorrect > range."); > +return; > +} > +/* Use a 4x fixed multiplier

Re: [PATCH v2] target/mips: Fix PageMask with variable page size

2020-06-20 Thread Aleksandar Markovic
уторак, 16. јун 2020., Jiaxun Yang је написао/ла: > Our current code assumed the target page size is always 4k > when handling PageMask and VPN2, however, variable page size > was just added to mips target and that's nolonger true. > > Signed-off-by: Jiaxun Yang > --- > v2: Remove Big Page

[PATCH 0/2] hw/arm/aspeed: Improve QOM usage

2020-06-20 Thread Philippe Mathieu-Daudé
Yet another cleanup. Simplify aspeed machine QOM usage. Philippe Mathieu-Daudé (2): hw/arm/aspeed: Remove extraneous MemoryRegion object owner hw/arm/aspeed: QOM'ify AspeedBoardState include/hw/arm/aspeed.h | 8 +--- hw/arm/aspeed.c | 17 ++--- 2 files changed, 11

[PATCH 2/2] hw/arm/aspeed: QOM'ify AspeedBoardState

2020-06-20 Thread Philippe Mathieu-Daudé
AspeedBoardState seems crippled. We use incorrectly 2 different structures to do the same thing. Merge them altogether: - Move AspeedMachine fields to AspeedBoardState - AspeedBoardState is now QOM - Remove unused AspeedMachine Signed-off-by: Philippe Mathieu-Daudé --- include/hw/arm/aspeed.h |

[PATCH 1/2] hw/arm/aspeed: Remove extraneous MemoryRegion object owner

2020-06-20 Thread Philippe Mathieu-Daudé
I'm confused by this code, 'bmc' is created as: bmc = g_new0(AspeedBoardState, 1); Then we use it as QOM owner for different MemoryRegion objects. But looking at memory_region_init_ram (similarly for ROM): void memory_region_init_ram(MemoryRegion *mr, struct

[PATCH] hw/core/qdev: Increase qdev_realize() kindness

2020-06-20 Thread Philippe Mathieu-Daudé
Since commit 510ef98dca5, qdev_realize() aborts if bus-less device is realized on a bus. Be kind with the developer by displaying a hint about what is wrong. Signed-off-by: Philippe Mathieu-Daudé --- hw/core/qdev.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git

Re: [PATCH v4 0/9] Rework iotests/check

2020-06-20 Thread Vladimir Sementsov-Ogievskiy
Ping :) (of course, master is updated and 04 should cover more iotests now, but still, the core scripts of the series need some review) 16.05.2020 00:14, Vladimir Sementsov-Ogievskiy wrote: Hi all! These series has 3 goals: - get rid of group file - introduce human-readable names for

Re: [PATCH 0/2] checkpatch: Do appropriate kernel->qemu renaming

2020-06-20 Thread Aleksandar Markovic
суб, 20. јун 2020. у 17:09 Aleksandar Markovic је написао/ла: > > суб, 20. јун 2020. у 16:25 Peter Maydell је > написао/ла: > > > > On Sat, 20 Jun 2020 at 14:33, Aleksandar Markovic > > wrote: > > > There are several places where 'kernel' is mentioned instead of > > > 'qemu' in checkpatch.pl. >

Re: [PATCH 0/2] checkpatch: Do appropriate kernel->qemu renaming

2020-06-20 Thread Aleksandar Markovic
суб, 20. јун 2020. у 16:25 Peter Maydell је написао/ла: > > On Sat, 20 Jun 2020 at 14:33, Aleksandar Markovic > wrote: > > There are several places where 'kernel' is mentioned instead of > > 'qemu' in checkpatch.pl. > > > > This small series corrects this. > > So, the thing about this kind of

Re: [PATCH 2/2] checkpatch: Change occurences of 'kernel' to 'qemu' in user messages

2020-06-20 Thread Peter Maydell
On Sat, 20 Jun 2020 at 14:33, Aleksandar Markovic wrote: > > It is odd that we inform user that, for example, his current working > directory is not kernel root, when, in face, we mean qemu root. > > Replace that and few other similar odd user messages. > > Signed-off-by: Aleksandar Markovic >

[PATCH 3/5] block: introduce preallocate filter

2020-06-20 Thread Vladimir Sementsov-Ogievskiy
It may be used for file-systems with slow allocation. Signed-off-by: Vladimir Sementsov-Ogievskiy --- qapi/block-core.json | 3 +- block/preallocate.c | 255 +++ block/Makefile.objs | 1 + 3 files changed, 258 insertions(+), 1 deletion(-) create

[PATCH 4/5] iotests: QemuIoInteractive: use qemu_io_args_no_fmt

2020-06-20 Thread Vladimir Sementsov-Ogievskiy
All users of QemuIoInteractive provides -f argument, so it's incorrect to use qemu_io_args, which contains -f too. Let's use qemu_io_args_no_fmt, which also makes possible to use --image-opts with QemuIoInteractive in the following patch. Signed-off-by: Vladimir Sementsov-Ogievskiy ---

[PATCH 5/5] iotests: add 298 to test new preallocate filter driver

2020-06-20 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/298 | 45 ++ tests/qemu-iotests/298.out | 5 + tests/qemu-iotests/group | 1 + 3 files changed, 51 insertions(+) create mode 100644 tests/qemu-iotests/298 create mode 100644

[PATCH 1/5] block/io: introduce bdrv_try_mark_request_serialising

2020-06-20 Thread Vladimir Sementsov-Ogievskiy
Introduce a function to mark the request serialising only if there are no conflicting request to wait for. The function is static, so mark it unused. The attribute is to be dropped in the next commit. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/io.c | 58

[PATCH 2/5] block/io: introduce bdrv_co_range_try_lock

2020-06-20 Thread Vladimir Sementsov-Ogievskiy
Introduce an interface to make a "critical section" on top of serialising requests feature. This is needed to avoid intersecting with other requests during a set of operations. Will be used in a next commit to implement preallocate filter. To keep assertions during intersecting requests handling,

[PATCH 0/5] preallocate filter

2020-06-20 Thread Vladimir Sementsov-Ogievskiy
Hi all! Here is a filter, which does preallocation on write. In Virtuozzo we have to deal with some custom distributed storage solution, where allocation is relatively expensive operation. We have to workaround it in Qemu, so here is a new filter. Performance results with the following test are

Re: [PATCH 0/2] checkpatch: Do appropriate kernel->qemu renaming

2020-06-20 Thread Peter Maydell
On Sat, 20 Jun 2020 at 14:33, Aleksandar Markovic wrote: > There are several places where 'kernel' is mentioned instead of > 'qemu' in checkpatch.pl. > > This small series corrects this. So, the thing about this kind of change is that it's implicitly saying "we have forked checkpatch and will

[PATCH 2/2] checkpatch: Change occurences of 'kernel' to 'qemu' in user messages

2020-06-20 Thread Aleksandar Markovic
It is odd that we inform user that, for example, his current working directory is not kernel root, when, in face, we mean qemu root. Replace that and few other similar odd user messages. Signed-off-by: Aleksandar Markovic --- scripts/checkpatch.pl | 6 +++--- 1 file changed, 3 insertions(+), 3

[PATCH 1/2] checkpatch: Rename top_of_kernel_tree() to top_of_qemu_tree()

2020-06-20 Thread Aleksandar Markovic
This subroutine establishes top of qemu, not kernel, tree. Do appropriate renaming. Signed-off-by: Aleksandar Markovic --- scripts/checkpatch.pl | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index

[PATCH 0/2] checkpatch: Do appropriate kernel->qemu renaming

2020-06-20 Thread Aleksandar Markovic
There are several places where 'kernel' is mentioned instead of 'qemu' in checkpatch.pl. This small series corrects this. Aleksandar Markovic (2): checkpatch: Rename top_of_kernel_tree() to top_of_qemu_tree() checkpatch: Change occurences of 'kernel' to 'qemu' in user messages

Re: [PATCH 00/22] ADB: fix autopoll issues and rework mac_via state machine

2020-06-20 Thread Mark Cave-Ayland
On 16/06/2020 11:24, Finn Thain wrote: > Tested-by: Finn Thain > > Thanks for all your work on this. > > I've just noticed a discrepancy between the traces from an ADB bus scan on > Laurent's Apple Quadra and an ADB bus scan on your patched QEMU machine. > > Apple Q800: > > [C1f][s

Re: [PATCH 21/22] adb: use adb_device prefix for ADB device trace events

2020-06-20 Thread Mark Cave-Ayland
On 14/06/2020 18:20, Philippe Mathieu-Daudé wrote: > On 6/14/20 4:28 PM, Mark Cave-Ayland wrote: >> This is to allow us to distinguish between ADB device events and ADB >> bus events separately. >> >> Signed-off-by: Mark Cave-Ayland >> --- >> hw/input/adb-kbd.c| 12 ++-- >>

Re: [PATCH 22/22] adb: add ADB bus trace events

2020-06-20 Thread Mark Cave-Ayland
On 14/06/2020 18:16, Philippe Mathieu-Daudé wrote: > Hi Mark, > > On 6/14/20 4:28 PM, Mark Cave-Ayland wrote: >> Signed-off-by: Mark Cave-Ayland >> --- >> hw/input/adb.c| 23 ++- >> hw/input/trace-events | 7 +++ >> 2 files changed, 29 insertions(+), 1

Re: [PATCH v3 0/4] hw/misc/pca9552: Trace LED On/Off events

2020-06-20 Thread Philippe Mathieu-Daudé
On 6/19/20 4:50 PM, Philippe Mathieu-Daudé wrote: > This series add trace events to better display LEDs changes. > This helps me to work on a generic LED device, see: > https://www.mail-archive.com/qemu-devel@nongnu.org/msg711917.html FYI I'm going to send a v4, using the generic LED device. >

[Bug 1873338] Re: Dos on the fly CD image replacement is not Working with DOS

2020-06-20 Thread ruthan
Its not incomplete. i gave lots of info. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1873338 Title: Dos on the fly CD image replacement is not Working with DOS Status in QEMU: Expired Bug

[Bug 1883984] Re: QEMU S/390x sqxbr (128-bit IEEE 754 square root) crashes qemu-system-s390x

2020-06-20 Thread Bruno Haible
I confirm that the patch https://lists.gnu.org/archive/html/qemu- s390x/2020-06/msg00213.html fixes the issue, both for qemu-s390x and qemu-system-s390x. Thanks Richard! -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [PATCH v3 0/3] python/machine.py: refactor shutdown

2020-06-20 Thread Philippe Mathieu-Daudé
On 6/17/20 7:13 PM, Philippe Mathieu-Daudé wrote: > On 6/16/20 11:49 PM, Cleber Rosa wrote: >> On Mon, Jun 15, 2020 at 05:21:18PM +0200, Philippe Mathieu-Daudé wrote: >>> On 6/9/20 11:55 PM, John Snow wrote: On 6/9/20 9:08 AM, Philippe Mathieu-Daudé wrote: > Hi John, >

Re: [PATCH v2 2/3] scripts/performance: Add topN_callgrind.py script

2020-06-20 Thread Aleksandar Markovic
петак, 19. јун 2020., Ahmed Karaman је написао/ла: > Python script that prints the top N most executed functions in QEMU > using callgrind. > > Example Usage: > topN_callgrind.py -n 20 -- /path/to/qemu program -program -flags > > If '-n' is not specified, the default is 25. > > Comments similar

Re: [PATCH v2 1/3] scripts/performance: Add topN_perf.py script

2020-06-20 Thread Aleksandar Markovic
петак, 19. јун 2020., Ahmed Karaman је написао/ла: > Python script that prints the top N most executed functions in QEMU > using perf. > > Example Usage: > topN_perf.py -n 20 -- /path/to/qemu program -program -flags > > If '-n' is not specified, the default is 25. > > Comments similar to the one

Re: [PATCH v2 1/3] scripts/performance: Add topN_perf.py script

2020-06-20 Thread Aleksandar Markovic
петак, 19. јун 2020., Ahmed Karaman је написао/ла: > Python script that prints the top N most executed functions in QEMU > using perf. > > Example Usage: Don't use capitalization when not appropriate. This is better: Example of usage: > topN_perf.py -n 20 -- /path/to/qemu program -program

Re: [PATCH v2 0/3] Add Scripts for Finding Top 25 Executed Functions

2020-06-20 Thread Aleksandar Markovic
петак, 19. јун 2020., Ahmed Karaman је написао/ла: > Greetings, > > This series implements the improvements and changes requested to be > added to the two scripts. > > Thanks to Mr. Aleksandar Markovic, Mr. Alex Bennée, and Mr. Eric Blake > for their valuable feedback. > > First version of the

Re: [PATCH v3 9/9] host trust limitation: Alter virtio default properties for protected guests

2020-06-20 Thread David Gibson
On Fri, Jun 19, 2020 at 04:05:56PM +0100, Daniel P. Berrangé wrote: > On Sat, Jun 20, 2020 at 12:45:41AM +1000, David Gibson wrote: > > On Fri, Jun 19, 2020 at 11:12:45AM +0100, Daniel P. Berrangé wrote: > > > On Fri, Jun 19, 2020 at 12:06:02PM +1000, David Gibson wrote: > > > > The default

Re: [PATCH v3 12/16] python/machine.py: Add _qmp access shim

2020-06-20 Thread Philippe Mathieu-Daudé
On Sat, Jun 20, 2020 at 10:14 AM Philippe Mathieu-Daudé wrote: > > On 6/4/20 10:22 PM, John Snow wrote: > > Like many other Optional[] types, it's not always a given that this > > object will be set. Wrap it in a type-shim that raises a meaningful > > error and will always return a concrete type.

Re: [PATCH v3 12/16] python/machine.py: Add _qmp access shim

2020-06-20 Thread Philippe Mathieu-Daudé
On 6/4/20 10:22 PM, John Snow wrote: > Like many other Optional[] types, it's not always a given that this > object will be set. Wrap it in a type-shim that raises a meaningful > error and will always return a concrete type. > > Signed-off-by: John Snow > --- > python/qemu/machine.py | 12

Re: [PATCH V3] Rename use_acpi_pci_hotplug to more appropriate use_acpi_hotplug_bridge

2020-06-20 Thread Ani Sinha
This failure seems to be happening even without my patch in my workspace. So I do not think this is related to my change. Traceback (most recent call last): File "./tests/docker/docker.py", line 664, in sys.exit(main()) File "./tests/docker/docker.py", line 660, in main return

[PATCH v10 61/61] target/riscv: configure and turn on vector extension from command line

2020-06-20 Thread LIU Zhiwei
Vector extension is default off. The only way to use vector extension is 1. use cpu rv32 or rv64 2. turn on it by command line "-cpu rv64,x-v=true,vlen=128,elen=64,vext_spec=v0.7.1". vlen is the vector register length, default value is 128 bit. elen is the max operator size in bits, default

[PATCH v10 60/61] target/riscv: vector compress instruction

2020-06-20 Thread LIU Zhiwei
Signed-off-by: LIU Zhiwei Reviewed-by: Richard Henderson --- target/riscv/helper.h | 5 target/riscv/insn32.decode | 1 + target/riscv/insn_trans/trans_rvv.inc.c | 32 + target/riscv/vector_helper.c| 26

[PATCH v10 59/61] target/riscv: vector register gather instruction

2020-06-20 Thread LIU Zhiwei
Signed-off-by: LIU Zhiwei Reviewed-by: Richard Henderson --- target/riscv/helper.h | 9 +++ target/riscv/insn32.decode | 3 + target/riscv/insn_trans/trans_rvv.inc.c | 78 + target/riscv/vector_helper.c| 60 +++

[PATCH v10 58/61] target/riscv: vector slide instructions

2020-06-20 Thread LIU Zhiwei
Signed-off-by: LIU Zhiwei Reviewed-by: Richard Henderson --- target/riscv/helper.h | 17 target/riscv/insn32.decode | 6 ++ target/riscv/insn_trans/trans_rvv.inc.c | 18 target/riscv/vector_helper.c| 114 4 files

  1   2   >