Wonderful work, May I reproduce the work on my local machine?
On Mon, Jun 29, 2020 at 6:26 PM Ahmed Karaman
wrote:
> Hi,
>
> The second report of the TCG Continuous Benchmarking series builds
> upon the QEMU performance metrics calculated in the previous report.
> This report presents a method
On 29/06/2020 22.25, Michele Denber wrote:
On 06-29-2020 8:12 AM, Thomas Huth wrote:
...
It's not the same bug as last year, but a new one: Seems like newer
versions of Solaris now have this functions in their libraries!
Yes - I just checked. Solaris 10 does not have openpty, but Solaris 11.4
On Jun 18 06:34, Dmitry Fomichev wrote:
> From: Niklas Cassel
>
> Define the structures and constants required to implement
> Namespace Types support.
>
> Signed-off-by: Niklas Cassel
> Signed-off-by: Dmitry Fomichev
> ---
> hw/block/nvme.h | 3 ++
> include/block/nvme.h | 75
On Jun 18 06:34, Dmitry Fomichev wrote:
> This log page becomes necessary to implement to allow checking for
> Zone Append command support in Zoned Namespace Command Set.
>
> This commit adds the code to report this log page for NVM Command
> Set only. The parts that are specific to zoned
On Jun 18 06:34, Dmitry Fomichev wrote:
> Removed unused struct NvmeAerResult and SMART-related async event
> codes. All other event codes are now categorized by their type.
> This avoids having to define the same values in a single enum,
> NvmeAsyncEventRequest, that is now removed.
>
> Later
Dne 29. 06. 20 v 12:25 Ahmed Karaman napsal(a):
> Hi,
>
> The second report of the TCG Continuous Benchmarking series builds
> upon the QEMU performance metrics calculated in the previous report.
> This report presents a method to dissect the number of instructions
> executed by a QEMU invocation
From: Klaus Jensen
If a command results in a non-zero status code, trace it.
Signed-off-by: Klaus Jensen
---
hw/block/nvme.c | 5 +
hw/block/trace-events | 1 +
2 files changed, 6 insertions(+)
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
index 9f1a1ba03b8a..25d79bcd0bc9 100644
From: Gollu Appalanaidu
This is to support for the Commands Supported and Effects log page. See
NVM Express Spec 1.3d, sec. 5.14.1.5 ("Commands Supported and Effects")
Signed-off-by: Gollu Appalanaidu
Co-authored-by: Klaus Jensen
---
hw/block/nvme.c | 20 +++-
From: Klaus Jensen
This bumps the supported version to v1.4 and adds the CSE log page.
Based-on: <20200630042304.1305269-1-...@irrelevant.dk>
("[PATCH] hw/block/nvme: add support for dulbe")
Gollu Appalanaidu (1):
hw/block/nvme: add commands supported and effects log page
Klaus Jensen (2):
From: Klaus Jensen
Add new fields from NVM Express v1.4.
Signed-off-by: Klaus Jensen
---
hw/block/nvme.c | 3 +-
include/block/nvme.h | 195 +--
2 files changed, 172 insertions(+), 26 deletions(-)
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
[Expired for QEMU because there has been no activity for 60 days.]
** Changed in: qemu
Status: Incomplete => Expired
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1869858
Title:
qemu can't
From: Klaus Jensen
This adds support for reporting the Deallocated or Unwritten Logical
Block error (DULBE). This requires tracking the allocated/deallocated
status of all logical blocks.
Introduce a bitmap that does this. The bitmap is persisted on the new
'state' drive that is associated with
From: Klaus Jensen
Allos the LBA data size (lbads) to be set between 9 and 12.
Signed-off-by: Klaus Jensen
Acked-by: Keith Busch
Reviewed-by: Maxim Levitsky
Reviewed-by: Philippe Mathieu-Daudé
---
Based-on: <20200629214051.1282060-1-...@irrelevant.dk>
("[PATCH v2 0/4] hw/block/nvme: support
On Jun 18 06:33, Dmitry Fomichev wrote:
> From: Ajay Joshi
>
> A new write command, Zone Append, is added as a part of Zoned
> Namespace Command Set. Upon successful completion of this command,
> the controller returns the start LBA of the performed write operation
> in cqe.result field.
On Jun 18 06:33, Dmitry Fomichev wrote:
> In addition to the existing has_sg flag, a few more Boolean
> NvmeRequest flags are going to be introduced in subsequent patches.
> Convert "has_sg" variable to "flags" and define NvmeRequestFlags
> enum for individual flag values.
>
> Signed-off-by:
> -Original Message-
> From: Moger, Babu
> Sent: Thursday, June 25, 2020 5:55 PM
> To: Igor Mammedov
> Cc: ehabk...@redhat.com; m...@redhat.com; qemu-devel@nongnu.org;
> pbonz...@redhat.com; r...@twiddle.net
> Subject: Re: [PATCH 1/2] hw/386: Fix uninitialized memory with -device and
On 2020/6/29 下午9:34, Peter Xu wrote:
On Mon, Jun 29, 2020 at 01:51:47PM +0800, Jason Wang wrote:
On 2020/6/28 下午10:47, Peter Xu wrote:
On Sun, Jun 28, 2020 at 03:03:41PM +0800, Jason Wang wrote:
On 2020/6/27 上午5:29, Peter Xu wrote:
Hi, Eugenio,
(CCing Eric, Yan and Michael too)
On Fri,
On Wed, Jun 17, 2020 at 2:47 PM Dmitry Fomichev wrote:
>
> From: Niklas Cassel
>
> Define the structures and constants required to implement
> Namespace Types support.
>
> Signed-off-by: Niklas Cassel
> Signed-off-by: Dmitry Fomichev
> ---
> hw/block/nvme.h | 3 ++
>
On Wed, Jun 17, 2020 at 3:05 PM Dmitry Fomichev wrote:
>
> This log page becomes necessary to implement to allow checking for
> Zone Append command support in Zoned Namespace Command Set.
>
> This commit adds the code to report this log page for NVM Command
> Set only. The parts that are specific
On Mon, 29 Jun 2020, Markus Armbruster wrote:
BALATON Zoltan writes:
On Sat, 27 Jun 2020, Markus Armbruster wrote:
Quick reply without having thought through the issues at all: I'm not
Does that mean you'll reply later with more detail or this is all you
had to say about this? (Just to know
On Wed, Jun 17, 2020 at 2:48 PM Dmitry Fomichev wrote:
>
> Removed unused struct NvmeAerResult and SMART-related async event
> codes. All other event codes are now categorized by their type.
> This avoids having to define the same values in a single enum,
> NvmeAsyncEventRequest, that is now
On Wed, Jun 17, 2020 at 2:44 PM Dmitry Fomichev wrote:
>
> From: Ajay Joshi
>
> A new write command, Zone Append, is added as a part of Zoned
> Namespace Command Set. Upon successful completion of this command,
> the controller returns the start LBA of the performed write operation
> in
On Wed, Jun 17, 2020 at 2:43 PM Dmitry Fomichev wrote:
>
> In addition to the existing has_sg flag, a few more Boolean
> NvmeRequest flags are going to be introduced in subsequent patches.
> Convert "has_sg" variable to "flags" and define NvmeRequestFlags
> enum for individual flag values.
>
>
On Tue, Jun 30, 2020 at 2:50 AM Atish Patra wrote:
>
> On Sat, Jun 27, 2020 at 2:55 AM Bin Meng wrote:
> >
> > On Sat, Jun 27, 2020 at 12:37 PM Atish Patra wrote:
> > >
> > > On Fri, Jun 26, 2020 at 7:54 PM Bin Meng wrote:
> > > >
> > > > Hi Atish,
> > > >
> > > > On Sat, Jun 27, 2020 at 12:58
On Mon, 29 Jun 2020, Philippe Mathieu-Daudé wrote:
Use popcount instruction to count the number of bits set in
the RAM size. Allow at most 1 bit for each bank. This avoid
using invalid hardware configurations.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/ppc/ppc4xx_devs.c | 9 +
1 file
>From b821b7e9bbf1f327058ee858a92c7a7ee6740e63 Mon Sep 17 00:00:00 2001
From: David Carlier
Date: Mon, 29 Jun 2020 22:20:39 +
Subject: [PATCH 8/9] Skipping sys/syscall.h inclusion as only used in
qemu_signalfd anyway.
Signed-off-by: David Carlier
---
util/compatfd.c | 2 ++
1 file
>From 93c001e7da19c76a73a687dc6584bc31385a2693 Mon Sep 17 00:00:00 2001
From: David Carlier
Date: Mon, 29 Jun 2020 22:18:32 +
Subject: [PATCH 5/9] Define SIGIO constant with SIGPOLL equivalence,
Signed-off-by: David Carlier
---
include/qemu/osdep.h | 4
1 file changed, 4 insertions(+)
>From 2f65cab41a8f4508532b3893815f222bf2293463 Mon Sep 17 00:00:00 2001
From: David Carlier
Date: Mon, 29 Jun 2020 22:19:34 +
Subject: [PATCH 6/9] Including endian.h for bswap operations.
Signed-off-by: David Carlier
---
include/qemu/bswap.h | 2 ++
1 file changed, 2 insertions(+)
diff
>From fcdb25804af98329b52a04e7a4e5191135aac4f6 Mon Sep 17 00:00:00 2001
From: David Carlier
Date: Mon, 29 Jun 2020 22:36:03 +
Subject: [PATCH 9/9] Implementing qemu_init_exec_dir.
Signed-off-by: David Carlier
---
util/oslib-posix.c | 19 +++
1 file changed, 19 insertions(+)
>From 8b205a027dacad08ce9187474d9490667904a4e2 Mon Sep 17 00:00:00 2001
From: David Carlier
Date: Mon, 29 Jun 2020 22:14:53 +
Subject: [PATCH 2/9] Enabling *pty api
Signed-off-by: David Carlier
---
configure | 9 +
util/qemu-openpty.c | 2 +-
2 files changed, 10
>From 9d43c8cd1611d0347db9066b1df1dc34431b2028 Mon Sep 17 00:00:00 2001
From: David Carlier
Date: Mon, 29 Jun 2020 22:17:53 +
Subject: [PATCH 4/9] Checking sys/signal.h presence.
Signed-off-by: David Carlier
---
configure | 8
hw/xen/xen-legacy-backend.c | 1 -
>From 157a0374093371719de42e99364352d64190f52a Mon Sep 17 00:00:00 2001
From: David Carlier
Date: Mon, 29 Jun 2020 22:20:06 +
Subject: [PATCH 7/9] Skipping drm build, unsupported.
Signed-off-by: David Carlier
---
util/Makefile.objs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
>From fcdb25804af98329b52a04e7a4e5191135aac4f6 Mon Sep 17 00:00:00 2001
From: David Carlier
Date: Mon, 29 Jun 2020 22:36:32 +
Subject: [PATCH 0/9] *** SUBJECT HERE ***
*** BLURB HERE ***
David Carlier (9):
Enabling BSD symbols.
Enabling *pty api
Checking mlockall symbol presence.
>From 5c6022f21289eb6e78e93d584c766db82165dced Mon Sep 17 00:00:00 2001
From: David Carlier
Date: Mon, 29 Jun 2020 22:13:35 +
Subject: [PATCH 1/9] Enabling BSD symbols.
Signed-off-by: David Carlier
---
configure | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
>From ac450c4abe03e0e461fede18727500e616d9f7e2 Mon Sep 17 00:00:00 2001
From: David Carlier
Date: Mon, 29 Jun 2020 22:15:21 +
Subject: [PATCH 3/9] Checking mlockall symbol presence.
Signed-off-by: David Carlier
---
configure | 15 +++
os-posix.c | 4
2 files changed, 19
Hi,
> common-obj-y = audio.o audio_legacy.o noaudio.o wavaudio.o mixeng.o
> -common-obj-$(CONFIG_SPICE) += spiceaudio.o
> +spice-app.mo-objs += ../audio/spiceaudio.o
Hmm. audio/audio.c will try to load audio-${backend}.so when you run
qemu -audiodev ${backend}, so I suspect this is not going
Hi,
> > +#
> > +# common-obj-m has some crap here, probably as side effect from
> > +# filling obj-y. Clear it. Fixes suspicious dependency errors when
> > +# building devices as modules.
> > +#
> > +common-obj-m :=
>
> This comment doesn't fill me with confidence - makes it feel like
Hi,
> obj-$(CONFIG_PC) += pc.o pc_sysfw.o
> +pc.o-cflags += $(SPICE_CFLAGS)
Hmm, looks strange. Why does pc.c need spice?
> +qmp-cmds.o-cflags += $(SPICE_CFLAGS)
> +hmp-cmds.o-cflags += $(SPICE_CFLAGS)
spice monitor commands need this I guess?
> +misc.o-cflags += $(SPICE_CFLAGS)
Why
Hi,
> > If so the more normal approach would be to have a struct defining
> > a set of callbacks, that can be registered. Or if there's a natural
> > fit with QOM, then a QOM interface that can then have a QOM object
> > impl registered as a singleton.
>
> That was my second attempt (after the
Your pipeline has failed.
Project: QEMU ( https://gitlab.com/qemu-project/qemu )
Branch: master ( https://gitlab.com/qemu-project/qemu/-/commits/master )
Commit: fc1bff95 (
https://gitlab.com/qemu-project/qemu/-/commit/fc1bff958998910ec8d25db86cd2f53ff125f7ab
)
Commit Message:
From: Klaus Jensen
This adds support for multiple namespaces by introducing a new 'nvme-ns'
device model. The nvme device creates a bus named from the device name
('id'). The nvme-ns devices then connect to this and registers
themselves with the nvme device.
This changes how an nvme device is
From: Klaus Jensen
The emulated nvme device (hw/block/nvme.c) is currently using an
internal Intel device id.
Prepare to change that by allocating a device id under the 1b36 (Red
Hat, Inc.) vendor id.
Signed-off-by: Klaus Jensen
Acked-by: Keith Busch
Acked-by: Gerd Hoffmann
Reviewed-by:
From: Klaus Jensen
Prepare to support inactive namespaces.
Signed-off-by: Klaus Jensen
Reviewed-by: Maxim Levitsky
---
hw/block/nvme.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
index 4bcd114f76b1..eaee420219fd 100644
---
From: Klaus Jensen
v2: bummer, v1 didn't apply cleanly to master (it applied to Kevin's
block tree); rebased to make patchew happy
This adds a new 'nvme-ns' device that attaches to the nvme device
through a bus. This decouples the nvme controller and nvme namespaces
such that multiple
From: Klaus Jensen
There are two reasons for changing this:
1. The nvme device currently uses an internal Intel device id.
2. Since commits "nvme: fix write zeroes offset and count" and "nvme:
support multiple namespaces" the controller device no longer has
the quirks that the
On Mon, 29 Jun 2020, Philippe Mathieu-Daudé wrote:
We use "new" names for functions that allocate and initialize
device objects: pci_new(), isa_new(), usb_new().
Let's call this one i2c_slave_new(). Since we have to update
all the callers, also let it return a I2CSlave object.
All the callers
On Jun 29 14:07, no-re...@patchew.org wrote:
> Patchew URL:
> https://patchew.org/QEMU/20200629202053.1223342-1-...@irrelevant.dk/
>
>
>
> Hi,
>
> This series failed the docker-quick@centos7 build test. Please find the
> testing commands and
> their output below. If you have Docker
On Mon, 29 Jun 2020, Philippe Mathieu-Daudé wrote:
On 6/27/20 9:17 AM, Markus Armbruster wrote:
BALATON Zoltan writes:
On Wed, 22 Apr 2020, BALATON Zoltan wrote:
On Wed, 22 Apr 2020, Philippe Mathieu-Daudé wrote:
On 4/22/20 4:27 PM, BALATON Zoltan wrote:
On Wed, 22 Apr 2020, Markus
On Mon, Jun 29, 2020 at 07:38:21PM +0200, Philippe Mathieu-Daudé wrote:
> In commit d88c42ff2c we added new prototype but neglected to
> add their documentation. Fix that.
Reviewed-by: Corey Minyard
>
> Reported-by: Peter Maydell
> Signed-off-by: Philippe Mathieu-Daudé
> ---
>
On Mon, Jun 29, 2020 at 07:38:20PM +0200, Philippe Mathieu-Daudé wrote:
> We use "create_simple" names for functions that allocate, initialize,
> configure and realize device objects: pci_create_simple(),
> isa_create_simple(), usb_create_simple(). For consistency, rename
> i2c_create_slave() as
On Mon, Jun 29, 2020 at 07:38:19PM +0200, Philippe Mathieu-Daudé wrote:
> The other i2c functions are called i2c_slave_FOO(). Rename as
> i2c_slave_realize_and_unref() to be consistent.
Reviewed-by: Corey Minyard
>
> Suggested-by: Markus Armbruster
> Signed-off-by: Philippe Mathieu-Daudé
>
On Mon, Jun 29, 2020 at 07:38:18PM +0200, Philippe Mathieu-Daudé wrote:
> We use "new" names for functions that allocate and initialize
> device objects: pci_new(), isa_new(), usb_new().
> Let's call this one i2c_slave_new(). Since we have to update
> all the callers, also let it return a I2CSlave
On Mon, Jun 29, 2020 at 07:38:16PM +0200, Philippe Mathieu-Daudé wrote:
> In commit d88c42ff2c we added 2 methods: i2c_try_create_slave()
> and i2c_realize_and_unref().
> Markus noted their name could be improved for consistency [1],
> and Peter reported the lack of documentation [2]. Fix that
On Mon, Jun 29, 2020 at 6:03 PM Alex Bennée wrote:
>
>
> Ahmed Karaman writes:
>
> > Hi,
> >
> > The second report of the TCG Continuous Benchmarking series builds
> > upon the QEMU performance metrics calculated in the previous report.
> > This report presents a method to dissect the number of
On Mon, 29 Jun 2020 at 08:47, Philippe Mathieu-Daudé wrote:
>
> When adding the generic PCA955xClass in commit 736132e455, we
> forgot to set the class_size field. Fill it now to avoid:
Thanks; I've applied this to master since it fixes a memory
corruption that affects all arm targets and I'm
Patchew URL:
https://patchew.org/QEMU/20200629202053.1223342-1-...@irrelevant.dk/
Hi,
This series failed the docker-quick@centos7 build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN
From: Klaus Jensen
This adds support for multiple namespaces by introducing a new 'nvme-ns'
device model. The nvme device creates a bus named from the device name
('id'). The nvme-ns devices then connect to this and registers
themselves with the nvme device.
This changes how an nvme device is
From: Klaus Jensen
There are two reasons for changing this:
1. The nvme device currently uses an internal Intel device id.
2. Since commits "nvme: fix write zeroes offset and count" and "nvme:
support multiple namespaces" the controller device no longer has
the quirks that the
From: Klaus Jensen
This adds a new 'nvme-ns' device that attaches to the nvme device
through a bus. This decouples the nvme controller and nvme namespaces
such that multiple namespaces may be attached to the controller.
With this in place, we can allocate a fresh pci vendor/device id and get
From: Klaus Jensen
Prepare to support inactive namespaces.
Signed-off-by: Klaus Jensen
Reviewed-by: Maxim Levitsky
---
hw/block/nvme.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
index 4bcd114f76b1..eaee420219fd 100644
---
From: Klaus Jensen
The emulated nvme device (hw/block/nvme.c) is currently using an
internal Intel device id.
Prepare to change that by allocating a device id under the 1b36 (Red
Hat, Inc.) vendor id.
Signed-off-by: Klaus Jensen
Acked-by: Keith Busch
Acked-by: Gerd Hoffmann
Reviewed-by:
From: Klaus Jensen
Since the controller has only supported PRPs so far it has not been
required to check the ending address (addr + len - 1) of the CMB access
for validity since it has been guaranteed to be in range of the CMB.
This changes when the controller adds support for SGLs (next
From: Klaus Jensen
For now, support the Data Block, Segment and Last Segment descriptor
types.
See NVM Express 1.3d, Section 4.4 ("Scatter Gather List (SGL)").
Signed-off-by: Klaus Jensen
Signed-off-by: Klaus Jensen
Acked-by: Keith Busch
---
hw/block/nvme.c | 331
From: Klaus Jensen
This adds support for scatter gather lists (SGLs). The full flexibility
of SGLs require the device to be a bit more strict about CMB access,
hence the "hw/block/nvme: harden cmb access" patch.
Based-on: <20200629202053.1223342-1-...@irrelevant.dk>
("[PATCH 0/2] hw/block/nvme:
From: Gollu Appalanaidu
This adds support for SGL descriptor type 0x1 (bit bucket descriptor).
See the NVM Express v1.3d specification, Section 4.4 ("Scatter Gather
List (SGL)").
Signed-off-by: Gollu Appalanaidu
Signed-off-by: Klaus Jensen
---
hw/block/nvme.c | 33
Bump... Any feedback on this series?
> -Original Message-
> From: Dmitry Fomichev
> Sent: Wednesday, June 17, 2020 5:34 PM
> To: Kevin Wolf ; Keith Busch ;
> Philippe Mathieu-Daudé ; Maxim Levitsky
>
> Cc: qemu-bl...@nongnu.org; qemu-devel@nongnu.org; Matias Bjorling
> ; Damien Le Moal
On 06-29-2020 8:12 AM, Thomas Huth wrote:
...
It's not the same bug as last year, but a new one: Seems like newer
versions of Solaris now have this functions in their libraries!
Yes - I just checked. Solaris 10 does not have openpty, but Solaris 11.4
indeed does have it
So what you want is
From: Klaus Jensen
Handling DMA errors gracefully is required for the device to pass the
block/011 test ("disable PCI device while doing I/O") in the blktests
suite.
With this patch the device passes the test by retrying "critical"
transfers (posting of completion entries and processing of
From: Klaus Jensen
Some devices might want to know the return value of dma_memory_rw, so
pass it along instead of ignoring it.
There are no existing users of the return value, so this patch should be
safe.
Signed-off-by: Klaus Jensen
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Michael
From: Klaus Jensen
QEMU actually respects that Bus Master Enabling for a PCI device gets
flipped, so in order to succesfully pass the block/011 test ("disable
PCI device while doing I/O") the nvme device needs to know if a dma
transfer was successful or not.
Based-on:
Yes, the maintainer will likely get the submodule updated before the
next release.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1884990
Title:
Cirrus graphics results in monochrome colour depth
On 200629 2000, Alex Bennée wrote:
>
> Alexander Bulekov <1878...@bugs.launchpad.net> writes:
>
> > I don't think this is a qtest-specific error:
> > cat << EOF| qemu-system-i386 -M q35 -nographic -serial none -monitor stdio
> > o/4 0xcf8 0x8400f841
> > o/4 0xcfc 0xaa215d6d
> > o/4 0x6d30
Use popcount instruction to count the number of bits set in
the RAM size. Allow at most 1 bit for each bank. This avoid
using invalid hardware configurations.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/ppc/ppc4xx_devs.c | 9 +
1 file changed, 9 insertions(+)
diff --git
From: Klaus Jensen
Move clearing of the structure from "clear before use" to "clear after
use". Also, carry a reference to the namespace the (I/O) command is
acting on instead of passing it around explicitly.
Signed-off-by: Klaus Jensen
---
hw/block/nvme.c | 28
From: Klaus Jensen
This refactors how the device issues asynchronous block backend
requests. The NvmeRequest now holds a queue of NvmeAIOs that are
associated with the command. This allows multiple aios to be issued for
a command. Only when all requests have been completed will the device
post a
From: Klaus Jensen
Move various request checks to a separate function.
Signed-off-by: Klaus Jensen
---
hw/block/nvme.c | 32 +++-
1 file changed, 23 insertions(+), 9 deletions(-)
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
index d836319f068a..ec08841f74b6
From: Klaus Jensen
Since clean up of the request qsg/iov is now always done post-use, there
is no need to use a stack-allocated qsg/iov in nvme_dma_prp.
Signed-off-by: Klaus Jensen
Acked-by: Keith Busch
Reviewed-by: Maxim Levitsky
---
hw/block/nvme.c | 18 ++
1 file changed,
Le 29/06/2020 à 19:56, Philippe Mathieu-Daudé a écrit :
> On 6/29/20 6:26 PM, Mark Cave-Ayland wrote:
>> The result of the get_physical_address() function should be combined with the
>> offset of the original page access before being returned. Otherwise the
>> m68k_cpu_get_phys_page_debug()
From: Klaus Jensen
Keep a copy of the raw nvme command in the NvmeRequest and remove the
now redundant NvmeCmd parameter.
Signed-off-by: Klaus Jensen
---
hw/block/nvme.c | 177 +---
hw/block/nvme.h | 1 +
2 files changed, 93 insertions(+), 85
From: Klaus Jensen
Hoist bounds checking into its own function.
Signed-off-by: Klaus Jensen
Reviewed-by: Maxim Levitsky
---
hw/block/nvme.c | 26 +-
1 file changed, 21 insertions(+), 5 deletions(-)
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
index
From: Klaus Jensen
Always destroy the request qsg/iov at the end of request use.
Signed-off-by: Klaus Jensen
---
hw/block/nvme.c | 48 +---
1 file changed, 17 insertions(+), 31 deletions(-)
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
index
From: Klaus Jensen
The NVM Express specification generally uses 'zeroes' and not 'zeros'.
It might very well be wrong, but let us align with it.
Signed-off-by: Klaus Jensen
---
block/nvme.c | 4 ++--
hw/block/nvme.c | 8
include/block/nvme.h | 4 ++--
3 files changed, 8
From: Klaus Jensen
Refactor the nvme_dma_{read,write}_prp functions into a common function
taking a DMADirection parameter.
Signed-off-by: Klaus Jensen
Reviewed-by: Maxim Levitsky
---
hw/block/nvme.c | 88 -
1 file changed, 43 insertions(+), 45
From: Klaus Jensen
Before this patch the device already supported PRP lists in the CMB, but
it did not check for the validity of it nor announced the support in the
Identify Controller data structure LISTS field.
If some of the PRPs in a PRP list are in the CMB, then ALL entries must
be there.
From: Klaus Jensen
Introduce the nvme_map helper to remove some noise in the main nvme_rw
function.
Signed-off-by: Klaus Jensen
Reviewed-by: Maxim Levitsky
---
hw/block/nvme.c | 13 ++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
From: Klaus Jensen
Add 'mdts' device parameter to control the Maximum Data Transfer Size of
the controller and check that it is respected.
Signed-off-by: Klaus Jensen
Reviewed-by: Maxim Levitsky
---
hw/block/nvme.c | 32 ++--
hw/block/nvme.h | 1 +
From: Klaus Jensen
The QSG isn't always initialized, so accounting could be wrong. Issue a
call to blk_acct_start instead with the size taken from the QSG or IOV
depending on the kind of I/O.
Signed-off-by: Klaus Jensen
Reviewed-by: Maxim Levitsky
---
hw/block/nvme.c | 5 -
1 file
From: Klaus Jensen
Add nvme_map_addr, nvme_map_addr_cmb and nvme_addr_to_cmb helpers and
use them in nvme_map_prp.
This fixes a bug where in the case of a CMB transfer, the device would
map to the buffer with a wrong length.
Fixes: b2b2b67a00574 ("nvme: Add support for Read Data and Write Data
From: Klaus Jensen
Remove the has_sg member from NvmeRequest since it's redundant.
Also, make sure the request iov is destroyed at completion time.
Signed-off-by: Klaus Jensen
Reviewed-by: Maxim Levitsky
---
hw/block/nvme.c | 11 ++-
hw/block/nvme.h | 1 -
2 files changed, 6
From: Klaus Jensen
Pass along the NvmeRequest in various functions since it is very useful
for tracing.
Signed-off-by: Klaus Jensen
Reviewed-by: Maxim Levitsky
---
hw/block/nvme.c | 67 +--
hw/block/trace-events | 1 +
2 files changed, 40
From: Klaus Jensen
This series is based on "[PATCH 00/17] hw/block/nvme: bump to v1.3" and
mostly consists of patches that refactors and clean up dma/cmb address
mappings.
The "hw/block/nvme: allow multiple aios per command" patch does what it
says on the tin and is in preparation for metadata,
From: Klaus Jensen
This is preparatory to subsequent patches that change how QSGs/IOVs are
handled. It is important that the qsg and iov members of the NvmeRequest
are initially zeroed.
Signed-off-by: Klaus Jensen
Reviewed-by: Maxim Levitsky
---
hw/block/nvme.c | 2 +-
1 file changed, 1
On Sun, Jun 28, 2020 at 7:27 AM Peter Maydell wrote:
>
> Keep pointers to scp0, scp1 in SpitzMachineState, and just pass
> that to spitz_scoop_gpio_setup().
>
> (We'll want to use some of the other fields in SpitzMachineState
> in that function in the next commit.)
>
> Signed-off-by: Peter
On Sun, Jun 28, 2020 at 7:24 AM Peter Maydell wrote:
>
> Keep pointers to the MPU and the SSI devices in SpitzMachineState.
> We're going to want to make GPIO connections between some of the
> SSI devices and the SCPs, so we want to keep hold of a pointer to
> those; putting the MPU into the
On Sun, Jun 28, 2020 at 7:24 AM Peter Maydell wrote:
>
> The spitz board has been around a long time, and still has a fair number
> of hard-coded tab characters in it. We're about to do some work on
> this source file, so start out by expanding out the tabs.
>
> This commit is a pure whitespace
Hi,
> > >> Do you intend to add a "sysbus model" in a future patch?
> > > [Sai Pavan Boddu] Yes. I would be sending it along with that a device
> > > which would be using it. (i.e for zynqmp soc ) Let me know, if its good to
> > include hcd-xhci-sysbus.c here ?
I think this would be useful,
Merge the existing object-add test cases into a single test
functions and cover more failure cases.
Signed-off-by: Eric Auger
---
v4 -> v5:
- use 1M instead of 4G
---
tests/qtest/qmp-cmd-test.c | 114 +++--
1 file changed, 97 insertions(+), 17 deletions(-)
This new test checks that attempting to create an object
with an existing ID gracefully fails.
Signed-off-by: Eric Auger
Acked-by: Thomas Huth
Reviewed-by: Markus Armbruster
---
v4 -> v5
- use 1MB instead of 4GB
---
tests/qtest/qmp-cmd-test.c | 19 +++
1 file changed, 19
Attempting to add an object through QMP with an id that is
already used leads to a qemu abort. This is a regression since
d2623129a7de ("qom: Drop parameter @errp of object_property_add()
& friends").
The first patch fixes the issue and the second patch adds a test
to check the error is
object_property_add() does not allow object_property_try_add()
to gracefully fail as _abort is passed as an error handle.
However such failure can easily be triggered from the QMP shell when,
for instance, one attempts to create an object with an id that already
exists. This is achieved from the
1 - 100 of 400 matches
Mail list logo
