Hi,
> > > schedule a bottom half calling qjack_client_fini()
> >
> > Does QEMU have such a mechanism for doing this?
>
> There could also be a possible race here if `jack_client_connect` is called
> before the scheduled shutdown takes place.
You can cancel a scheduled bottom half, and
Hi,
> > > Have another small question. Do you know how force show cursor working
> > > in this case?
> >
> > Which display and which vga do you use?
>
> -vga std \
So stdvga (has no hardware cursor support).
display not specified, so it is the default.
i.e. gtk or sdl depending on what
> From: Yan Zhao
> Sent: Wednesday, August 19, 2020 9:01 AM
> On Tue, Aug 18, 2020 at 09:39:24AM +, Parav Pandit wrote:
> > Please refer to my previous email which has more example and details.
> hi Parav,
> the example is based on a new vdpa tool running over netlink, not based on
>
From: César Belley
This patch adds the U2F key base class implementation.
The U2F key base mainly takes care of the HID interfacing with guest.
On the one hand, it retrieves the guest U2FHID packets and transmits
them to the variant associated according to the mode: pass-through
or emulated.
On
From: César Belley
Add USB U2F key device documentation:
- USB U2F key device
- Building
- Using u2f-emulated
- Using u2f-passthru
- Libu2f-emu
Signed-off-by: César Belley
Message-id: 20200812094135.20550-3-cesar.bel...@lse.epita.fr
Signed-off-by: Gerd Hoffmann
---
docs/u2f.txt | 101
From: César Belley
This patch adds the U2F key emulated mode.
The emulated mode consists of completely emulating the behavior of a
U2F device through software part. Libu2f-emu is used for that.
The emulated mode is associated with a device inheriting from
u2f-key base.
To work, an emulated
To fully work this also needs the fix for bug 1890881 as identified
there.
** Changed in: qemu (Ubuntu Focal)
Status: New => Triaged
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1886811
From: César Belley
This patch adds the specification for the U2F key base class.
Used to group the common characteristics, this device class will be
inherited by its two variants, corresponding to the two modes:
passthrough and emulated
This prepares the U2F devices hierarchy which is as
From: César Belley
This patch adds the U2F key pass-through mode.
The pass-through mode consists of passing all requests made from the
guest to the physical security key connected to the host machine and
vice versa.
In addition, the dedicated pass-through allows to have a U2F security key
The following changes since commit d0ed6a69d399ae193959225cdeaa9382746c91cc:
Update version for v5.1.0 release (2020-08-11 17:07:03 +0100)
are available in the Git repository at:
git://git.kraxel.org/qemu tags/usb-20200819-pull-request
for you to fetch changes up to
From: César Belley
This patchs adds a check to verify that the device passed through the
hidraw property is a U2F device.
The check is done by ensuring that the first values of the report
descriptor (USAGE PAGE and USAGE) correspond to those of a U2F device.
Signed-off-by: César Belley
From: César Belley
Signed-off-by: César Belley
Message-id: 20200812094135.20550-8-cesar.bel...@lse.epita.fr
Signed-off-by: Gerd Hoffmann
---
hw/usb/Kconfig | 5 +
hw/usb/Makefile.objs | 7 +++
2 files changed, 12 insertions(+)
diff --git a/hw/usb/Kconfig b/hw/usb/Kconfig
index
From: César Belley
This patch adds an autoscan to let u2f-passthru choose the first U2F
device it finds.
The autoscan is performed using libudev with an enumeration of all the
hidraw devices present on the host.
The first device which happens to be a U2F device is taken to do the
pass-through.
From: César Belley
Group some HID values that are used pretty much everywhere when
dealing with HID devices.
Signed-off-by: César Belley
Message-id: 20200812094135.20550-2-cesar.bel...@lse.epita.fr
Signed-off-by: Gerd Hoffmann
---
include/hw/usb/hid.h | 17 +
hw/usb/dev-hid.c
From: César Belley
Signed-off-by: César Belley
Message-id: 20200812094135.20550-9-cesar.bel...@lse.epita.fr
Signed-off-by: Gerd Hoffmann
---
configure | 27 +++
1 file changed, 27 insertions(+)
diff --git a/configure b/configure
index 2acc4d1465f8..3ea5e561ff43 100755
We have a tracepoint at the same place which can be enabled if needed.
Buglink: https://bugzilla.redhat.com//show_bug.cgi?id=1859236
Signed-off-by: Gerd Hoffmann
Reviewed-by: Philippe Mathieu-Daudé
Message-Id: <20200722072613.10390-1-kra...@redhat.com>
---
hw/usb/hcd-ehci.c | 1 -
1 file
From: Li Qiang
If 'usb_packet_map' fails, we should stop to process the usb
request.
Signed-off-by: Li Qiang
Message-Id: <20200812161727.29412-1-liq...@163.com>
Signed-off-by: Gerd Hoffmann
---
hw/usb/hcd-ehci.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git
From: César Belley
Signed-off-by: César Belley
Message-id: 20200812094135.20550-11-cesar.bel...@lse.epita.fr
Signed-off-by: Gerd Hoffmann
---
docs/qdev-device-use.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/docs/qdev-device-use.txt b/docs/qdev-device-use.txt
index
From: César Belley
This patch adds the script used to generate setup directories, needed
for the device u2f-emulated configuration in directory mode:
python u2f-setup-gen.py $DIR
qemu -usb -device u2f-emulated,dir=$DIR
Signed-off-by: César Belley
Message-id:
On Wed, Aug 12, 2020 at 11:41:22AM +0200, César Belley wrote:
> This patch series adds the U2F dedicated support to Qemu through a USB
> U2F key device that can operate in two modes: pass-through and emulated.
>
> This work is also part of the GSoC program of this year and follows the
> proposal
From: César Belley
Signed-off-by: César Belley
Message-id: 20200812094135.20550-10-cesar.bel...@lse.epita.fr
Signed-off-by: Gerd Hoffmann
---
docs/system/usb.rst | 3 +++
1 file changed, 3 insertions(+)
diff --git a/docs/system/usb.rst b/docs/system/usb.rst
index ddfa828d74ae..9a2f1927c451
From: Li Qiang
Currently we don't check the return value of 'usb_packet_map',
this will cause an UAF issue. This is LP#1891341.
Following is the reproducer provided in:
-->https://bugs.launchpad.net/qemu/+bug/1891341
cat << EOF | ./i386-softmmu/qemu-system-i386 -device nec-usb-xhci \
-trace
From: Li Qiang
This may cause resource leak.
Signed-off-by: Li Qiang
Message-Id: <20200812161712.29361-1-liq...@163.com>
Signed-off-by: Gerd Hoffmann
---
hw/usb/hcd-ehci.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c
index
Hi,
> > schedule a bottom half calling qjack_client_fini()
>
> Does QEMU have such a mechanism for doing this?
Yes, look for QEMUBH in include/qemu/main-loop.h
HTH,
Gerd
On 2020-08-19 15:28, Geoffrey McRae wrote:
On 2020-08-19 15:04, Gerd Hoffmann wrote:
Hi,
As JACK1 and JACK2 are interchangeable and JACK2 has "cleanup"
routine
that JACK1 does not have, we need to determine which version is in
use
at runtime. Unfortunatly there is no way to determine which
On 2020-08-19 15:04, Gerd Hoffmann wrote:
Hi,
As JACK1 and JACK2 are interchangeable and JACK2 has "cleanup" routine
that JACK1 does not have, we need to determine which version is in use
at runtime. Unfortunatly there is no way to determine which is in use
other then to look for symbols that
> From: Jason Wang
> Sent: Wednesday, August 19, 2020 8:16 AM
> On 2020/8/18 下午5:32, Parav Pandit wrote:
> > Hi Jason,
> >
> > From: Jason Wang
> > Sent: Tuesday, August 18, 2020 2:32 PM
> >
> >
> > On 2020/8/18 下午4:55, Daniel P. Berrangé wrote:
> > On Tue, Aug 18, 2020 at 11:24:30AM +0800,
On 2020-08-19 14:46, Philippe Mathieu-Daudé wrote:
On 8/19/20 5:36 AM, Geoffrey McRae wrote:
On 2020-08-19 13:32, Philippe Mathieu-Daudé wrote:
Hi Geoffrey,
On 8/19/20 3:18 AM, Geoffrey McRae wrote:
The client may have been freed already by a secondary audio device
recovering its
Hi,
> As JACK1 and JACK2 are interchangeable and JACK2 has "cleanup" routine
> that JACK1 does not have, we need to determine which version is in use
> at runtime. Unfortunatly there is no way to determine which is in use
> other then to look for symbols that are missing in JACK1, which in this
On 8/19/20 5:36 AM, Geoffrey McRae wrote:
>
>
> On 2020-08-19 13:32, Philippe Mathieu-Daudé wrote:
>> Hi Geoffrey,
>>
>> On 8/19/20 3:18 AM, Geoffrey McRae wrote:
>>> The client may have been freed already by a secondary audio device
>>> recovering its session as JACK2 has some cleanup code to
On Tue, Aug 18, 2020 at 09:39:24AM +, Parav Pandit wrote:
> Hi Cornelia,
>
> > From: Cornelia Huck
> > Sent: Tuesday, August 18, 2020 3:07 PM
> > To: Daniel P. Berrangé
> > Cc: Jason Wang ; Yan Zhao
> > ; k...@vger.kernel.org; libvir-l...@redhat.com;
> > qemu-devel@nongnu.org; Kirti
On 2020-08-19 13:32, Philippe Mathieu-Daudé wrote:
Hi Geoffrey,
On 8/19/20 3:18 AM, Geoffrey McRae wrote:
The client may have been freed already by a secondary audio device
recovering its session as JACK2 has some cleanup code to work around
broken clients, which doesn't account for well
On 8/18/20 11:20 PM, Sunil Muthuswamy wrote:
It's still shameful that MS is forcing developers to waste time
rewriting API headers, just because the MS legal departments are not
able to understand the needs of Open Source development.
>>> There has be a big switch from Microsoft
Hi Geoffrey,
On 8/19/20 3:18 AM, Geoffrey McRae wrote:
> The client may have been freed already by a secondary audio device
> recovering its session as JACK2 has some cleanup code to work around
> broken clients, which doesn't account for well behaved clients.
>
>
Hi Julia,
On 8/18/20 11:52 PM, Julia Suvorova wrote:
> Implement notifications and gpe to support q35 ACPI PCI hot-plug.
> Use 0xcc4 - 0xcd7 range for 'acpi-pci-hotplug' io ports.
>
> Signed-off-by: Julia Suvorova
> ---
> include/hw/acpi/pcihp.h | 3 ++-
> hw/acpi/pcihp.c | 10
On 8/18/20 11:52 PM, Julia Suvorova wrote:
> Add trace events similar to piix4_gpe_readb() to check gpe status.
>
> Signed-off-by: Julia Suvorova
> Reviewed-by: Igor Mammedov
> ---
> hw/acpi/ich9.c | 7 ++-
> hw/acpi/trace-events | 4
> 2 files changed, 10 insertions(+), 1
On 8/19/20 4:42 AM, Thiago Jung Bauermann wrote:
> Instead of setting CPUState::halted to 1 in s390_cpu_initfn(), use the
> start-powered-off property which makes cpu_common_reset() initialize it
> to 1 in common code.
>
> Note that this changes behavior by setting cs->halted to 1 on reset, which
On 8/19/20 4:42 AM, Thiago Jung Bauermann wrote:
> Instead of setting CPUState::halted to 1 in secondary_cpu_reset(), use the
> start-powered-off property which makes cpu_common_reset() initialize it
> to 1 in common code.
>
> This makes secondary_cpu_reset() unnecessary, so remove it.
>
> Also
On 8/19/20 4:42 AM, Thiago Jung Bauermann wrote:
> We rely on cpu_common_reset() to set cs->halted to 0, so main_cpu_reset()
> is pointless.
>
> Suggested-by: Philippe Mathieu-Daudé
> Reviewed-by: David Gibson
> Signed-off-by: Thiago Jung Bauermann
Reviewed-by: Philippe Mathieu-Daudé
> ---
On 8/19/20 4:42 AM, Thiago Jung Bauermann wrote:
> Instead of setting CPUState::halted to 1 in main_cpu_reset(), use the
> start-powered-off property which makes cpu_common_reset() initialize it
> to 1 in common code.
>
> Also change creation of CPU object from cpu_create() to object_new() and
>
On 8/19/20 4:42 AM, Thiago Jung Bauermann wrote:
> Instead of setting CPUState::halted to 1 in ppce500_cpu_reset_sec(), use
> the start-powered-off property which makes cpu_common_reset() initialize it
> to 1 in common code.
>
> Also change creation of CPU object from cpu_create() to object_new()
On 2020/8/18 下午5:36, Cornelia Huck wrote:
On Tue, 18 Aug 2020 10:16:28 +0100
Daniel P. Berrangé wrote:
On Tue, Aug 18, 2020 at 05:01:51PM +0800, Jason Wang wrote:
On 2020/8/18 下午4:55, Daniel P. Berrangé wrote:
On Tue, Aug 18, 2020 at 11:24:30AM +0800, Jason Wang wrote:
On
On 2020/8/18 下午5:32, Parav Pandit wrote:
Hi Jason,
From: Jason Wang
Sent: Tuesday, August 18, 2020 2:32 PM
On 2020/8/18 下午4:55, Daniel P. Berrangé wrote:
On Tue, Aug 18, 2020 at 11:24:30AM +0800, Jason Wang wrote:
On 2020/8/14 下午1:16, Yan Zhao wrote:
On Thu, Aug 13, 2020 at 12:24:50PM
Le mar. 18 août 2020 23:30, Eduardo Habkost a écrit :
> CCing maintainer (pmaydell).
>
> On Fri, Aug 14, 2020 at 07:45:40PM +0200, Philippe Mathieu-Daudé wrote:
> > On 8/14/20 12:25 AM, Eduardo Habkost wrote:
> > > The PL1110 enum value name will conflict with the PL1110 type
> > > cast checker,
Instead of setting CPUState::halted to 1 in main_cpu_reset(), use the
start-powered-off property which makes cpu_common_reset() initialize it
to 1 in common code.
Also change creation of CPU object from cpu_create() to object_new() and
qdev_realize_and_unref() because cpu_create() realizes the
Instead of setting CPUState::halted to 1 in secondary_cpu_reset(), use the
start-powered-off property which makes cpu_common_reset() initialize it
to 1 in common code.
This makes secondary_cpu_reset() unnecessary, so remove it.
Also remove setting of cs->halted from cpu_devinit(), which seems
We rely on cpu_common_reset() to set cs->halted to 0, so main_cpu_reset()
is pointless.
Suggested-by: Philippe Mathieu-Daudé
Reviewed-by: David Gibson
Signed-off-by: Thiago Jung Bauermann
---
hw/sparc/sun4m.c | 13 +
1 file changed, 1 insertion(+), 12 deletions(-)
diff --git
Instead of setting CPUState::halted to 1 in ppce500_cpu_reset_sec(), use
the start-powered-off property which makes cpu_common_reset() initialize it
to 1 in common code.
Also change creation of CPU object from cpu_create() to object_new() and
qdev_realize_and_unref() because cpu_create() realizes
This version, like the previous one, tries to fix an issue found by
David Gibson when running the Travis CI:
Unexpected error in qdev_prop_set_after_realize() at
/home/travis/build/dgibson/qemu/hw/core/qdev-properties.c:30:
qemu-system-mips64el: Attempt to set property 'start-powered-off' on
There are other platforms which also have CPUs that start powered off, so
generalize the start-powered-off property so that it can be used by them.
Note that ARMv7MState also has a property of the same name but this patch
doesn't change it because that class isn't a subclass of CPUState so it
Instead of setting CPUState::halted to 1 in s390_cpu_initfn(), use the
start-powered-off property which makes cpu_common_reset() initialize it
to 1 in common code.
Note that this changes behavior by setting cs->halted to 1 on reset, which
didn't happen before.
Acked-by: Cornelia Huck
This change is in a separate patch because it's not so obvious that it
won't cause a regression.
Suggested-by: Eduardo Habkost
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: David Gibson
Reviewed-by: Greg Kurz
Signed-off-by: Thiago Jung Bauermann
---
hw/core/cpu.c| 2 +-
PowerPC sPAPR CPUs start in the halted state, and spapr_reset_vcpu()
attempts to implement this by setting CPUState::halted to 1. But that's too
late for the case of hotplugged CPUs in a machine configure with 2 or more
threads per core.
By then, other parts of QEMU have already caused the vCPU
On 2020/8/18 下午5:16, Daniel P. Berrangé wrote:
Your mail came through as HTML-only so all the quoting and attribution
is mangled / lost now :-(
My bad, sorry.
On Tue, Aug 18, 2020 at 05:01:51PM +0800, Jason Wang wrote:
On 2020/8/18 下午4:55, Daniel P. Berrangé wrote:
On Tue, Aug
This is where the error occurred:
(gdb) x/30i 0x40007ff2c0
0x40007ff2c0:xor%al,%dh
0x40007ff2c2:(bad)
0x40007ff2c3:add%al,(%rax)
0x40007ff2c5:add%al,(%rax)
0x40007ff2c7:add%ch,0x0(%rbp)
0x40007ff2cd:add
On 8/18/2020 10:10 AM, Paolo Bonzini wrote:
From: Marc-André Lureau
Meson warns if xgettext is not found. In the future we may want to add
a required argument to i18n.gettext(); in the meanwhile, I am adding a
--enable-gettext/--disable-gettext option and feature detection in
configure.
Signed-off-by: Yi Li
---
qemu-img.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/qemu-img.c b/qemu-img.c
index 5308773811..aa2e31c8ae 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -1200,10 +1200,10 @@ static int is_allocated_sectors(const uint8_t *buf, int
n, int
On Tue, Aug 18, 2020 at 9:55 PM Anup Patel wrote:
>
> On Tue, Aug 18, 2020 at 6:39 PM wrote:
> >
> > On 8/18/20 7:17 AM, Anup Patel wrote:
> > > EXTERNAL EMAIL: Do not click links or open attachments unless you know
> > > the content is safe
> > >
> > > On Tue, Aug 18, 2020 at 1:23 AM wrote:
>
Now, I found something new when I use gdb:
=> 0x400523c858:ud2
0x400523c85a:pushq $0xd
0x400523c85c:mov-0x230(%rbp),%rax
0x400523c863:mov-0x240(%rbp),%rdi
0x400523c86a:mov$0x1,%esi
0x400523c86f:movq
Fixed accidental eof newline strip from `configure`
Geoffrey McRae (1):
audio/jack: fix use after free segfault
audio/jackaudio.c | 37 -
configure | 4 +++-
2 files changed, 39 insertions(+), 2 deletions(-)
--
2.20.1
The client may have been freed already by a secondary audio device
recovering its session as JACK2 has some cleanup code to work around
broken clients, which doesn't account for well behaved clients.
https://github.com/jackaudio/jack2/issues/627
As JACK1 and JACK2 are interchangeable and JACK2
The client may have been freed already by a secondary audio device
recovering its session as JACK2 has some cleanup code to work around
broken clients, which doesn't account for well behaved clients.
https://github.com/jackaudio/jack2/issues/627
As JACK1 and JACK2 are interchangeable and JACK2
Philippe Mathieu-Daudé writes:
> On 8/18/20 5:33 AM, Thiago Jung Bauermann wrote:
>> Instead of setting CPUState::halted to 1 in main_cpu_reset(), use the
>> start-powered-off property which makes cpu_common_reset() initialize it
>> to 1 in common code.
>>
>> Also change creation of CPU object
Thiago Jung Bauermann writes:
> Hello Philippe,
>
> Thanks for your review.
>
> Philippe Mathieu-Daudé writes:
>
>> On 8/18/20 9:22 AM, Philippe Mathieu-Daudé wrote:
@@ -897,6 +895,19 @@ void ppce500_init(MachineState *machine)
} else {
/* Secondary CPUs
Hello Philippe,
Thanks for your review.
Philippe Mathieu-Daudé writes:
> On 8/18/20 9:22 AM, Philippe Mathieu-Daudé wrote:
>> On 8/18/20 5:33 AM, Thiago Jung Bauermann wrote:
>>> Instead of setting CPUState::halted to 1 in ppce500_cpu_reset_sec(), use
>>> the start-powered-off property which
Hi Igor,
Thank you for reviewing these patches, and the tips you provided here
and on other messages on how to fix the refcount issues.
Igor Mammedov writes:
> On Tue, 18 Aug 2020 00:33:19 -0300
> Thiago Jung Bauermann wrote:
>
> [...]
>
>> Also change creation of CPU object from
Patchew URL: https://patchew.org/QEMU/20200818215227.181654-1-jus...@redhat.com/
Hi,
This series failed the docker-quick@centos7 build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
On 2020-08-19 04:11, Christian Schoenebeck wrote:
On Dienstag, 18. August 2020 14:40:36 CEST Geoffrey McRae wrote:
Due to a ridiculous commit in the Jack library, the client may have
been
freed already by a secondary audio device recovering its session.
Ok, we may store these functions in syscall.c.
вт, 18 авг. 2020 г. в 18:56, Laurent Vivier :
> Le 18/08/2020 à 01:57, Andrew Aladjev a écrit :
> > Signed-off-by: Andrew Aladjev
> > ---
> > linux-user/Makefile.objs | 5 +++--
> > linux-user/syscall.c | 33
Add acpi_pcihp to ich9_pm and use ACPI PCI hot-plug by default.
Signed-off-by: Julia Suvorova
---
Note: New pc_compats are usually added shortly after release.
I will switch to pc_compat_5_1 when it becomes available.
hw/i386/acpi-build.h | 1 +
include/hw/acpi/ich9.h | 3 +++
Other methods may be used if the system is capable of this and the _OSC bit
is set. Disable them explicitly to force ACPI PCI hot-plug use. The older
versions will still use PCIe native.
Signed-off-by: Julia Suvorova
---
hw/i386/acpi-build.h | 11 +++
hw/i386/acpi-build.c | 21
Add trace events similar to piix4_gpe_readb() to check gpe status.
Signed-off-by: Julia Suvorova
Reviewed-by: Igor Mammedov
---
hw/acpi/ich9.c | 7 ++-
hw/acpi/trace-events | 4
2 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c
index
Implement notifications and gpe to support q35 ACPI PCI hot-plug.
Use 0xcc4 - 0xcd7 range for 'acpi-pci-hotplug' io ports.
Signed-off-by: Julia Suvorova
---
include/hw/acpi/pcihp.h | 3 ++-
hw/acpi/pcihp.c | 10 ++
hw/acpi/piix4.c | 2 +-
hw/i386/acpi-build.c| 25
PCIe native hot-plug has numerous problems with racing events and unpredictable
guest behaviour (Windows). Switching to ACPI hot-plug for now.
Tested on RHEL 8 and Windows 2019.
pxb-pcie is not yet supported.
v2:
* new ioport range for acpiphp [Gerd]
* drop find_pci_host() [Igor]
*
On Mon, Aug 17, 2020 at 09:07:58PM +0200, Niek Linnenbank wrote:
> Hi,
>
> Interesting suggestion Philippe. I modelled the initial code of the H3 SoC
> mostly in-line with the aspeed SoC,
> to let it use commonly applied code structures where possible. And it looks
> like in this series,
Hello. I want to explain situation we have in qemu today.
It looks simple, but gives complex problems.
Please open "linux-user/main.c":
execfd = qemu_getauxval(AT_EXECFD);
if (execfd == 0) {
execfd = open(exec_path, O_RDONLY);
if (execfd < 0) { ... }
}
...
close(execfd);
We may take
> >> It's still shameful that MS is forcing developers to waste time
> >> rewriting API headers, just because the MS legal departments are not
> >> able to understand the needs of Open Source development.
> > There has be a big switch from Microsoft toward Open Source, I attended
> > some of there
CCing maintainer (pmaydell).
On Fri, Aug 14, 2020 at 07:45:40PM +0200, Philippe Mathieu-Daudé wrote:
> On 8/14/20 12:25 AM, Eduardo Habkost wrote:
> > The PL1110 enum value name will conflict with the PL1110 type
> > cast checker, when we replace the existing macro with an inline
> > function.
Add support for the recently introduced functions
bdrv_co_preadv_part()
and
bdrv_co_pwritev_part()
to the COR-filter driver.
Signed-off-by: Andrey Shinkevich
---
block/copy-on-read.c | 28
1 file changed, 16 insertions(+), 12 deletions(-)
diff --git
Provide the possibility to pass the 'filter-node-name' parameter to the
block-stream job as it is done for the commit block job. That will be
needed for further iotests implementations.
Signed-off-by: Andrey Shinkevich
---
block/monitor/block-hmp-cmds.c | 4 ++--
block/stream.c
The patch completes the series with the COR-filter insertion to any
block-stream operation. It also makes changes to the iotests 030.
The test case 'test_stream_parallel' was deleted due to multiple
errors.
Signed-off-by: Andrey Shinkevich
---
block/stream.c | 76
Note: this series is based on the another one "block: Deal with filters"
by Max Reitz that could be found in the branches:
https://git.xanclic.moe/XanClic/qemu child-access-functions-v6
https://github.com/XanClic/qemu child-access-functions-v6
v6:
Re-based to the series
Provide API for the COR-filter insertion/removal.
Also, drop the filter child permissions for an inactive state when the
filter node is being removed.
Signed-off-by: Andrey Shinkevich
---
block/copy-on-read.c | 103 +++
block/copy-on-read.h | 36
Host CPU : Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz
Host Memory : 15.49 GB
Start Time (UTC) : 2020-08-18 21:00:01
End Time (UTC) : 2020-08-18 21:00:11
Execution Time : 0:00:10.419271
Status : FAILURE
On Mon, Aug 17, 2020 at 05:08:41PM +0100, Daniel P. Berrangé wrote:
> On Thu, Aug 13, 2020 at 06:26:14PM -0400, Eduardo Habkost wrote:
> > The existing type check macros all unconditionally drop const
> > qualifiers from their arguments. Keep this behavior in the
> > macros generated by
Reviewed-by: Andrey Shinkevich
On 10.08.2020 14:04, Vladimir Sementsov-Ogievskiy wrote:
10.08.2020 11:12, Max Reitz wrote:
On 07.08.20 12:29, Vladimir Sementsov-Ogievskiy wrote:
16.07.2020 17:59, Max Reitz wrote:
On 10.07.20 19:41, Andrey Shinkevich wrote:
On 10.07.2020 18:24, Max Reitz
On 18/08/20 22:10, Paolo Bonzini wrote:
> Ok I can see the -mms-bitfields here too, hopefully that's enough to
> debug it.
Hrm no, I don't see it anymore with ea922aa50b2a8688. Can you send me
the config-host.mak, build.ninja and Makefile.ninja files?
Here I get:
$ make
Le 18/08/2020 à 20:07, Filip Bozuta a écrit :
> The implementations of syscalls 'semop()' and 'semtimedop()' in
> file 'syscall.c' use function 'target_to_host_sembuf()' to convert
> values of 'struct sembuf' from host to target. However, before this
> conversion it should be check whether the
Ok I can see the -mms-bitfields here too, hopefully that's enough to debug
it.
Il mar 18 ago 2020, 21:27 Peter Maydell ha
scritto:
> On Tue, 18 Aug 2020 at 15:14, Paolo Bonzini wrote:
> >
> > The following changes since commit
> d0ed6a69d399ae193959225cdeaa9382746c91cc:
> >
> > Update
On Tue, 18 Aug 2020 at 15:14, Paolo Bonzini wrote:
>
> The following changes since commit d0ed6a69d399ae193959225cdeaa9382746c91cc:
>
> Update version for v5.1.0 release (2020-08-11 17:07:03 +0100)
>
> are available in the Git repository at:
>
> https://gitlab.com/bonzini/qemu.git
On Mon, 23 Mar 2020 at 13:32, Stefan Hajnoczi wrote:
> On Sat, Mar 21, 2020 at 11:50:23PM +0100, BALATON Zoltan wrote:
> > This was discussed before. I think instead of annoying people with a
> > warning, rather configure should be changed to create a build dir if run
> > from source and have a
** Attachment added: "before.png"
https://bugs.launchpad.net/qemu/+bug/1892081/+attachment/5402578/+files/before.png
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1892081
Title:
Performance
Public bug reported:
Attached below is a matrix multiplication program for double data
types. The program performs the casting operation "(double)rand()"
when generating random numbers.
This operation calls the integer to float softfloat conversion
function "int32_to_float_64".
Adding the
** Attachment added: "after.png"
https://bugs.launchpad.net/qemu/+bug/1892081/+attachment/5402579/+files/after.png
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1892081
Title:
Performance
On Dienstag, 18. August 2020 15:25:56 CEST David Vossel wrote:
> - Guest Agent SSH add/remove Support?
>
> As a PoC, I cobbled together some guest agent exec and file write client
> commands which can technically achieve the desired result of
> adding/removing entries in a
The implementations of syscalls 'semop()' and 'semtimedop()' in
file 'syscall.c' use function 'target_to_host_sembuf()' to convert
values of 'struct sembuf' from host to target. However, before this
conversion it should be check whether the number of semaphore operations
'nsops' is not bigger than
On Dienstag, 18. August 2020 14:40:36 CEST Geoffrey McRae wrote:
> Due to a ridiculous commit in the Jack library, the client may have been
> freed already by a secondary audio device recovering its session.
>
> https://github.com/jackaudio/jack2/issues/627
>
> Until there is a proper fix for
Patchew URL:
https://patchew.org/QEMU/20200818141025.21608-1-pbonz...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20200818141025.21608-1-pbonz...@redhat.com
Subject: [PULL 000/150] Meson-based build
On Tue, 18 Aug 2020 18:45:08 +0200
Philippe Mathieu-Daudé wrote:
> qemu_vfio_pci_init_irq() allows us to initialize any type of IRQ,
> but only one. Introduce qemu_vfio_pci_init_msix_irqs() which is
> specific to MSIX IRQ type, and allow us to use multiple IRQs
> (thus passing multiple eventfd
On 8/18/20 7:12 PM, Alex Williamson wrote:
> On Tue, 18 Aug 2020 18:45:06 +0200
> Philippe Mathieu-Daudé wrote:
>
>> The vfio-helpers implementation expects a TYPEv1 IOMMU, see
>> qemu_vfio_init_pci:
>>
>> 263 if (!ioctl(s->container, VFIO_CHECK_EXTENSION, VFIO_TYPE1_IOMMU)) {
>> 264
1 - 100 of 458 matches
Mail list logo