Re: [PATCH v2] audio/jack: fix use after free segfault

2020-08-18 Thread Gerd Hoffmann
Hi, > > > schedule a bottom half calling qjack_client_fini() > > > > Does QEMU have such a mechanism for doing this? > > There could also be a possible race here if `jack_client_connect` is called > before the scheduled shutdown takes place. You can cancel a scheduled bottom half, and

Re: [PATCH] hw: dev-wacom: Support wacom tablet emulation in linux qemu

2020-08-18 Thread Gerd Hoffmann
Hi, > > > Have another small question. Do you know how force show cursor working > > > in this case? > > > > Which display and which vga do you use? > > -vga std \ So stdvga (has no hardware cursor support). display not specified, so it is the default. i.e. gtk or sdl depending on what

RE: device compatibility interface for live migration with assigned devices

2020-08-18 Thread Parav Pandit
> From: Yan Zhao > Sent: Wednesday, August 19, 2020 9:01 AM > On Tue, Aug 18, 2020 at 09:39:24AM +, Parav Pandit wrote: > > Please refer to my previous email which has more example and details. > hi Parav, > the example is based on a new vdpa tool running over netlink, not based on >

[PULL 08/17] hw/usb: Add U2F key base class implementation

2020-08-18 Thread Gerd Hoffmann
From: César Belley This patch adds the U2F key base class implementation. The U2F key base mainly takes care of the HID interfacing with guest. On the one hand, it retrieves the guest U2FHID packets and transmits them to the variant associated according to the mode: pass-through or emulated. On

[PULL 06/17] docs: Add USB U2F key device documentation

2020-08-18 Thread Gerd Hoffmann
From: César Belley Add USB U2F key device documentation: - USB U2F key device - Building - Using u2f-emulated - Using u2f-passthru - Libu2f-emu Signed-off-by: César Belley Message-id: 20200812094135.20550-3-cesar.bel...@lse.epita.fr Signed-off-by: Gerd Hoffmann --- docs/u2f.txt | 101

[PULL 10/17] hw/usb: Add U2F key emulated mode

2020-08-18 Thread Gerd Hoffmann
From: César Belley This patch adds the U2F key emulated mode. The emulated mode consists of completely emulating the behavior of a U2F device through software part. Libu2f-emu is used for that. The emulated mode is associated with a device inheriting from u2f-key base. To work, an emulated

[Bug 1886811] Re: systemd complains Failed to enqueue loopback interface start request: Operation not supported

2020-08-18 Thread Christian Ehrhardt 
To fully work this also needs the fix for bug 1890881 as identified there. ** Changed in: qemu (Ubuntu Focal) Status: New => Triaged -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1886811

[PULL 07/17] hw/usb: Add U2F key base class

2020-08-18 Thread Gerd Hoffmann
From: César Belley This patch adds the specification for the U2F key base class. Used to group the common characteristics, this device class will be inherited by its two variants, corresponding to the two modes: passthrough and emulated This prepares the U2F devices hierarchy which is as

[PULL 09/17] hw/usb: Add U2F key passthru mode

2020-08-18 Thread Gerd Hoffmann
From: César Belley This patch adds the U2F key pass-through mode. The pass-through mode consists of passing all requests made from the guest to the physical security key connected to the host machine and vice versa. In addition, the dedicated pass-through allows to have a U2F security key

[PULL 00/17] Usb 20200819 patches

2020-08-18 Thread Gerd Hoffmann
The following changes since commit d0ed6a69d399ae193959225cdeaa9382746c91cc: Update version for v5.1.0 release (2020-08-11 17:07:03 +0100) are available in the Git repository at: git://git.kraxel.org/qemu tags/usb-20200819-pull-request for you to fetch changes up to

[PULL 16/17] hw/usb: Add U2F device check to passthru mode

2020-08-18 Thread Gerd Hoffmann
From: César Belley This patchs adds a check to verify that the device passed through the hidraw property is a U2F device. The check is done by ensuring that the first values of the report descriptor (USAGE PAGE and USAGE) correspond to those of a U2F device. Signed-off-by: César Belley

[PULL 11/17] hw/usb: Add U2F key build recipe

2020-08-18 Thread Gerd Hoffmann
From: César Belley Signed-off-by: César Belley Message-id: 20200812094135.20550-8-cesar.bel...@lse.epita.fr Signed-off-by: Gerd Hoffmann --- hw/usb/Kconfig | 5 + hw/usb/Makefile.objs | 7 +++ 2 files changed, 12 insertions(+) diff --git a/hw/usb/Kconfig b/hw/usb/Kconfig index

[PULL 17/17] hw/usb: Add U2F device autoscan to passthru mode

2020-08-18 Thread Gerd Hoffmann
From: César Belley This patch adds an autoscan to let u2f-passthru choose the first U2F device it finds. The autoscan is performed using libudev with an enumeration of all the hidraw devices present on the host. The first device which happens to be a U2F device is taken to do the pass-through.

[PULL 05/17] hw/usb: Regroup USB HID protocol values

2020-08-18 Thread Gerd Hoffmann
From: César Belley Group some HID values that are used pretty much everywhere when dealing with HID devices. Signed-off-by: César Belley Message-id: 20200812094135.20550-2-cesar.bel...@lse.epita.fr Signed-off-by: Gerd Hoffmann --- include/hw/usb/hid.h | 17 + hw/usb/dev-hid.c

[PULL 12/17] configure: Add USB U2F key device

2020-08-18 Thread Gerd Hoffmann
From: César Belley Signed-off-by: César Belley Message-id: 20200812094135.20550-9-cesar.bel...@lse.epita.fr Signed-off-by: Gerd Hoffmann --- configure | 27 +++ 1 file changed, 27 insertions(+) diff --git a/configure b/configure index 2acc4d1465f8..3ea5e561ff43 100755

[PULL 04/17] ehci: drop pointless warn_report for guest bugs.

2020-08-18 Thread Gerd Hoffmann
We have a tracepoint at the same place which can be enabled if needed. Buglink: https://bugzilla.redhat.com//show_bug.cgi?id=1859236 Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20200722072613.10390-1-kra...@redhat.com> --- hw/usb/hcd-ehci.c | 1 - 1 file

[PULL 03/17] hw: ehci: check return value of 'usb_packet_map'

2020-08-18 Thread Gerd Hoffmann
From: Li Qiang If 'usb_packet_map' fails, we should stop to process the usb request. Signed-off-by: Li Qiang Message-Id: <20200812161727.29412-1-liq...@163.com> Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ehci.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git

[PULL 14/17] docs/qdev-device-use.txt: Add USB U2F key to the QDEV devices examples

2020-08-18 Thread Gerd Hoffmann
From: César Belley Signed-off-by: César Belley Message-id: 20200812094135.20550-11-cesar.bel...@lse.epita.fr Signed-off-by: Gerd Hoffmann --- docs/qdev-device-use.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/qdev-device-use.txt b/docs/qdev-device-use.txt index

[PULL 15/17] scripts: Add u2f-setup-gen script

2020-08-18 Thread Gerd Hoffmann
From: César Belley This patch adds the script used to generate setup directories, needed for the device u2f-emulated configuration in directory mode: python u2f-setup-gen.py $DIR qemu -usb -device u2f-emulated,dir=$DIR Signed-off-by: César Belley Message-id:

Re: [PATCH 00/13] Introduce USB U2F key device

2020-08-18 Thread Gerd Hoffmann
On Wed, Aug 12, 2020 at 11:41:22AM +0200, César Belley wrote: > This patch series adds the U2F dedicated support to Qemu through a USB > U2F key device that can operate in two modes: pass-through and emulated. > > This work is also part of the GSoC program of this year and follows the > proposal

[PULL 13/17] docs/system: Add U2F key to the USB devices examples

2020-08-18 Thread Gerd Hoffmann
From: César Belley Signed-off-by: César Belley Message-id: 20200812094135.20550-10-cesar.bel...@lse.epita.fr Signed-off-by: Gerd Hoffmann --- docs/system/usb.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/docs/system/usb.rst b/docs/system/usb.rst index ddfa828d74ae..9a2f1927c451

[PULL 01/17] hw: xhci: check return value of 'usb_packet_map'

2020-08-18 Thread Gerd Hoffmann
From: Li Qiang Currently we don't check the return value of 'usb_packet_map', this will cause an UAF issue. This is LP#1891341. Following is the reproducer provided in: -->https://bugs.launchpad.net/qemu/+bug/1891341 cat << EOF | ./i386-softmmu/qemu-system-i386 -device nec-usb-xhci \ -trace

[PULL 02/17] hw: ehci: destroy sglist in error path

2020-08-18 Thread Gerd Hoffmann
From: Li Qiang This may cause resource leak. Signed-off-by: Li Qiang Message-Id: <20200812161712.29361-1-liq...@163.com> Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ehci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index

Re: [PATCH v2] audio/jack: fix use after free segfault

2020-08-18 Thread Gerd Hoffmann
Hi, > > schedule a bottom half calling qjack_client_fini() > > Does QEMU have such a mechanism for doing this? Yes, look for QEMUBH in include/qemu/main-loop.h HTH, Gerd

Re: [PATCH v2] audio/jack: fix use after free segfault

2020-08-18 Thread Geoffrey McRae
On 2020-08-19 15:28, Geoffrey McRae wrote: On 2020-08-19 15:04, Gerd Hoffmann wrote: Hi, As JACK1 and JACK2 are interchangeable and JACK2 has "cleanup" routine that JACK1 does not have, we need to determine which version is in use at runtime. Unfortunatly there is no way to determine which

Re: [PATCH v2] audio/jack: fix use after free segfault

2020-08-18 Thread Geoffrey McRae
On 2020-08-19 15:04, Gerd Hoffmann wrote: Hi, As JACK1 and JACK2 are interchangeable and JACK2 has "cleanup" routine that JACK1 does not have, we need to determine which version is in use at runtime. Unfortunatly there is no way to determine which is in use other then to look for symbols that

RE: device compatibility interface for live migration with assigned devices

2020-08-18 Thread Parav Pandit
> From: Jason Wang > Sent: Wednesday, August 19, 2020 8:16 AM > On 2020/8/18 下午5:32, Parav Pandit wrote: > > Hi Jason, > > > > From: Jason Wang > > Sent: Tuesday, August 18, 2020 2:32 PM > > > > > > On 2020/8/18 下午4:55, Daniel P. Berrangé wrote: > > On Tue, Aug 18, 2020 at 11:24:30AM +0800,

Re: [PATCH v3 1/1] audio/jack: fix use after free segfault

2020-08-18 Thread Geoffrey McRae
On 2020-08-19 14:46, Philippe Mathieu-Daudé wrote: On 8/19/20 5:36 AM, Geoffrey McRae wrote: On 2020-08-19 13:32, Philippe Mathieu-Daudé wrote: Hi Geoffrey, On 8/19/20 3:18 AM, Geoffrey McRae wrote: The client may have been freed already by a secondary audio device recovering its

Re: [PATCH v2] audio/jack: fix use after free segfault

2020-08-18 Thread Gerd Hoffmann
Hi, > As JACK1 and JACK2 are interchangeable and JACK2 has "cleanup" routine > that JACK1 does not have, we need to determine which version is in use > at runtime. Unfortunatly there is no way to determine which is in use > other then to look for symbols that are missing in JACK1, which in this

Re: [PATCH v3 1/1] audio/jack: fix use after free segfault

2020-08-18 Thread Philippe Mathieu-Daudé
On 8/19/20 5:36 AM, Geoffrey McRae wrote: > > > On 2020-08-19 13:32, Philippe Mathieu-Daudé wrote: >> Hi Geoffrey, >> >> On 8/19/20 3:18 AM, Geoffrey McRae wrote: >>> The client may have been freed already by a secondary audio device >>> recovering its session as JACK2 has some cleanup code to

Re: device compatibility interface for live migration with assigned devices

2020-08-18 Thread Yan Zhao
On Tue, Aug 18, 2020 at 09:39:24AM +, Parav Pandit wrote: > Hi Cornelia, > > > From: Cornelia Huck > > Sent: Tuesday, August 18, 2020 3:07 PM > > To: Daniel P. Berrangé > > Cc: Jason Wang ; Yan Zhao > > ; k...@vger.kernel.org; libvir-l...@redhat.com; > > qemu-devel@nongnu.org; Kirti

Re: [PATCH v3 1/1] audio/jack: fix use after free segfault

2020-08-18 Thread Geoffrey McRae
On 2020-08-19 13:32, Philippe Mathieu-Daudé wrote: Hi Geoffrey, On 8/19/20 3:18 AM, Geoffrey McRae wrote: The client may have been freed already by a secondary audio device recovering its session as JACK2 has some cleanup code to work around broken clients, which doesn't account for well

Re: [EXTERNAL] Re: [PATCH v2 0/3] testing: Build WHPX enabled binaries

2020-08-18 Thread Philippe Mathieu-Daudé
On 8/18/20 11:20 PM, Sunil Muthuswamy wrote: It's still shameful that MS is forcing developers to waste time rewriting API headers, just because the MS legal departments are not able to understand the needs of Open Source development. >>> There has be a big switch from Microsoft

Re: [PATCH v3 1/1] audio/jack: fix use after free segfault

2020-08-18 Thread Philippe Mathieu-Daudé
Hi Geoffrey, On 8/19/20 3:18 AM, Geoffrey McRae wrote: > The client may have been freed already by a secondary audio device > recovering its session as JACK2 has some cleanup code to work around > broken clients, which doesn't account for well behaved clients. > >

Re: [RFC PATCH v2 2/4] hw/i386/acpi-build: Add ACPI PCI hot-plug methods to q35

2020-08-18 Thread Philippe Mathieu-Daudé
Hi Julia, On 8/18/20 11:52 PM, Julia Suvorova wrote: > Implement notifications and gpe to support q35 ACPI PCI hot-plug. > Use 0xcc4 - 0xcd7 range for 'acpi-pci-hotplug' io ports. > > Signed-off-by: Julia Suvorova > --- > include/hw/acpi/pcihp.h | 3 ++- > hw/acpi/pcihp.c | 10

Re: [RFC PATCH v2 1/4] hw/acpi/ich9: Trace ich9_gpe_readb()/writeb()

2020-08-18 Thread Philippe Mathieu-Daudé
On 8/18/20 11:52 PM, Julia Suvorova wrote: > Add trace events similar to piix4_gpe_readb() to check gpe status. > > Signed-off-by: Julia Suvorova > Reviewed-by: Igor Mammedov > --- > hw/acpi/ich9.c | 7 ++- > hw/acpi/trace-events | 4 > 2 files changed, 10 insertions(+), 1

Re: [PATCH v5 8/8] target/s390x: Use start-powered-off CPUState property

2020-08-18 Thread Philippe Mathieu-Daudé
On 8/19/20 4:42 AM, Thiago Jung Bauermann wrote: > Instead of setting CPUState::halted to 1 in s390_cpu_initfn(), use the > start-powered-off property which makes cpu_common_reset() initialize it > to 1 in common code. > > Note that this changes behavior by setting cs->halted to 1 on reset, which

Re: [PATCH v5 7/8] sparc/sun4m: Use start-powered-off CPUState property

2020-08-18 Thread Philippe Mathieu-Daudé
On 8/19/20 4:42 AM, Thiago Jung Bauermann wrote: > Instead of setting CPUState::halted to 1 in secondary_cpu_reset(), use the > start-powered-off property which makes cpu_common_reset() initialize it > to 1 in common code. > > This makes secondary_cpu_reset() unnecessary, so remove it. > > Also

Re: [PATCH v5 6/8] sparc/sun4m: Remove main_cpu_reset()

2020-08-18 Thread Philippe Mathieu-Daudé
On 8/19/20 4:42 AM, Thiago Jung Bauermann wrote: > We rely on cpu_common_reset() to set cs->halted to 0, so main_cpu_reset() > is pointless. > > Suggested-by: Philippe Mathieu-Daudé > Reviewed-by: David Gibson > Signed-off-by: Thiago Jung Bauermann Reviewed-by: Philippe Mathieu-Daudé > ---

Re: [PATCH v5 5/8] mips/cps: Use start-powered-off CPUState property

2020-08-18 Thread Philippe Mathieu-Daudé
On 8/19/20 4:42 AM, Thiago Jung Bauermann wrote: > Instead of setting CPUState::halted to 1 in main_cpu_reset(), use the > start-powered-off property which makes cpu_common_reset() initialize it > to 1 in common code. > > Also change creation of CPU object from cpu_create() to object_new() and >

Re: [PATCH v5 4/8] ppc/e500: Use start-powered-off CPUState property

2020-08-18 Thread Philippe Mathieu-Daudé
On 8/19/20 4:42 AM, Thiago Jung Bauermann wrote: > Instead of setting CPUState::halted to 1 in ppce500_cpu_reset_sec(), use > the start-powered-off property which makes cpu_common_reset() initialize it > to 1 in common code. > > Also change creation of CPU object from cpu_create() to object_new()

Re: device compatibility interface for live migration with assigned devices

2020-08-18 Thread Jason Wang
On 2020/8/18 下午5:36, Cornelia Huck wrote: On Tue, 18 Aug 2020 10:16:28 +0100 Daniel P. Berrangé wrote: On Tue, Aug 18, 2020 at 05:01:51PM +0800, Jason Wang wrote: On 2020/8/18 下午4:55, Daniel P. Berrangé wrote: On Tue, Aug 18, 2020 at 11:24:30AM +0800, Jason Wang wrote: On

Re: device compatibility interface for live migration with assigned devices

2020-08-18 Thread Jason Wang
On 2020/8/18 下午5:32, Parav Pandit wrote: Hi Jason, From: Jason Wang Sent: Tuesday, August 18, 2020 2:32 PM On 2020/8/18 下午4:55, Daniel P. Berrangé wrote: On Tue, Aug 18, 2020 at 11:24:30AM +0800, Jason Wang wrote: On 2020/8/14 下午1:16, Yan Zhao wrote: On Thu, Aug 13, 2020 at 12:24:50PM

Re: [PATCH 01/41] pl1110: Rename PL1110 enum

2020-08-18 Thread Philippe Mathieu-Daudé
Le mar. 18 août 2020 23:30, Eduardo Habkost a écrit : > CCing maintainer (pmaydell). > > On Fri, Aug 14, 2020 at 07:45:40PM +0200, Philippe Mathieu-Daudé wrote: > > On 8/14/20 12:25 AM, Eduardo Habkost wrote: > > > The PL1110 enum value name will conflict with the PL1110 type > > > cast checker,

[PATCH v5 5/8] mips/cps: Use start-powered-off CPUState property

2020-08-18 Thread Thiago Jung Bauermann
Instead of setting CPUState::halted to 1 in main_cpu_reset(), use the start-powered-off property which makes cpu_common_reset() initialize it to 1 in common code. Also change creation of CPU object from cpu_create() to object_new() and qdev_realize_and_unref() because cpu_create() realizes the

[PATCH v5 7/8] sparc/sun4m: Use start-powered-off CPUState property

2020-08-18 Thread Thiago Jung Bauermann
Instead of setting CPUState::halted to 1 in secondary_cpu_reset(), use the start-powered-off property which makes cpu_common_reset() initialize it to 1 in common code. This makes secondary_cpu_reset() unnecessary, so remove it. Also remove setting of cs->halted from cpu_devinit(), which seems

[PATCH v5 6/8] sparc/sun4m: Remove main_cpu_reset()

2020-08-18 Thread Thiago Jung Bauermann
We rely on cpu_common_reset() to set cs->halted to 0, so main_cpu_reset() is pointless. Suggested-by: Philippe Mathieu-Daudé Reviewed-by: David Gibson Signed-off-by: Thiago Jung Bauermann --- hw/sparc/sun4m.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git

[PATCH v5 4/8] ppc/e500: Use start-powered-off CPUState property

2020-08-18 Thread Thiago Jung Bauermann
Instead of setting CPUState::halted to 1 in ppce500_cpu_reset_sec(), use the start-powered-off property which makes cpu_common_reset() initialize it to 1 in common code. Also change creation of CPU object from cpu_create() to object_new() and qdev_realize_and_unref() because cpu_create() realizes

[PATCH v5 0/8] Generalize start-powered-off property from ARM

2020-08-18 Thread Thiago Jung Bauermann
This version, like the previous one, tries to fix an issue found by David Gibson when running the Travis CI: Unexpected error in qdev_prop_set_after_realize() at /home/travis/build/dgibson/qemu/hw/core/qdev-properties.c:30: qemu-system-mips64el: Attempt to set property 'start-powered-off' on

[PATCH v5 1/8] target/arm: Move start-powered-off property to generic CPUState

2020-08-18 Thread Thiago Jung Bauermann
There are other platforms which also have CPUs that start powered off, so generalize the start-powered-off property so that it can be used by them. Note that ARMv7MState also has a property of the same name but this patch doesn't change it because that class isn't a subclass of CPUState so it

[PATCH v5 8/8] target/s390x: Use start-powered-off CPUState property

2020-08-18 Thread Thiago Jung Bauermann
Instead of setting CPUState::halted to 1 in s390_cpu_initfn(), use the start-powered-off property which makes cpu_common_reset() initialize it to 1 in common code. Note that this changes behavior by setting cs->halted to 1 on reset, which didn't happen before. Acked-by: Cornelia Huck

[PATCH v5 2/8] target/arm: Move setting of CPU halted state to generic code

2020-08-18 Thread Thiago Jung Bauermann
This change is in a separate patch because it's not so obvious that it won't cause a regression. Suggested-by: Eduardo Habkost Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: David Gibson Reviewed-by: Greg Kurz Signed-off-by: Thiago Jung Bauermann --- hw/core/cpu.c| 2 +-

[PATCH v5 3/8] ppc/spapr: Use start-powered-off CPUState property

2020-08-18 Thread Thiago Jung Bauermann
PowerPC sPAPR CPUs start in the halted state, and spapr_reset_vcpu() attempts to implement this by setting CPUState::halted to 1. But that's too late for the case of hotplugged CPUs in a machine configure with 2 or more threads per core. By then, other parts of QEMU have already caused the vCPU

Re: device compatibility interface for live migration with assigned devices

2020-08-18 Thread Jason Wang
On 2020/8/18 下午5:16, Daniel P. Berrangé wrote: Your mail came through as HTML-only so all the quoting and attribution is mangled / lost now :-( My bad, sorry. On Tue, Aug 18, 2020 at 05:01:51PM +0800, Jason Wang wrote: On 2020/8/18 下午4:55, Daniel P. Berrangé wrote: On Tue, Aug

[Bug 1890545] Re: (ARM64) qemu-x86_64+schroot(Debian bullseye) can't run chrome and can't load HTML

2020-08-18 Thread Tony.LI
This is where the error occurred: (gdb) x/30i 0x40007ff2c0 0x40007ff2c0:xor%al,%dh 0x40007ff2c2:(bad) 0x40007ff2c3:add%al,(%rax) 0x40007ff2c5:add%al,(%rax) 0x40007ff2c7:add%ch,0x0(%rbp) 0x40007ff2cd:add

Re: [PULL 147/150] meson: convert po/

2020-08-18 Thread Brad Smith
On 8/18/2020 10:10 AM, Paolo Bonzini wrote: From: Marc-André Lureau Meson warns if xgettext is not found. In the future we may want to add a required argument to i18n.gettext(); in the meanwhile, I am adding a --enable-gettext/--disable-gettext option and feature detection in configure.

[PATCH v2] qemu-img: Explicit number replaced by a constant

2020-08-18 Thread Yi Li
Signed-off-by: Yi Li --- qemu-img.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 5308773811..aa2e31c8ae 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -1200,10 +1200,10 @@ static int is_allocated_sectors(const uint8_t *buf, int n, int

Re: [PATCH 00/18] hw/riscv: Add Microchip PolarFire SoC Icicle Kit board support

2020-08-18 Thread Bin Meng
On Tue, Aug 18, 2020 at 9:55 PM Anup Patel wrote: > > On Tue, Aug 18, 2020 at 6:39 PM wrote: > > > > On 8/18/20 7:17 AM, Anup Patel wrote: > > > EXTERNAL EMAIL: Do not click links or open attachments unless you know > > > the content is safe > > > > > > On Tue, Aug 18, 2020 at 1:23 AM wrote: >

[Bug 1890545] Re: (ARM64) qemu-x86_64+schroot(Debian bullseye) can't run chrome and can't load HTML

2020-08-18 Thread Tony.LI
Now, I found something new when I use gdb: => 0x400523c858:ud2 0x400523c85a:pushq $0xd 0x400523c85c:mov-0x230(%rbp),%rax 0x400523c863:mov-0x240(%rbp),%rdi 0x400523c86a:mov$0x1,%esi 0x400523c86f:movq

[PATCH v3 0/1] audio/jack: fix use after free segfault

2020-08-18 Thread Geoffrey McRae
Fixed accidental eof newline strip from `configure` Geoffrey McRae (1): audio/jack: fix use after free segfault audio/jackaudio.c | 37 - configure | 4 +++- 2 files changed, 39 insertions(+), 2 deletions(-) -- 2.20.1

[PATCH v3 1/1] audio/jack: fix use after free segfault

2020-08-18 Thread Geoffrey McRae
The client may have been freed already by a secondary audio device recovering its session as JACK2 has some cleanup code to work around broken clients, which doesn't account for well behaved clients. https://github.com/jackaudio/jack2/issues/627 As JACK1 and JACK2 are interchangeable and JACK2

[PATCH v2] audio/jack: fix use after free segfault

2020-08-18 Thread Geoffrey McRae
The client may have been freed already by a secondary audio device recovering its session as JACK2 has some cleanup code to work around broken clients, which doesn't account for well behaved clients. https://github.com/jackaudio/jack2/issues/627 As JACK1 and JACK2 are interchangeable and JACK2

Re: [PATCH v4 5/8] mips/cps: Use start-powered-off CPUState property

2020-08-18 Thread Thiago Jung Bauermann
Philippe Mathieu-Daudé writes: > On 8/18/20 5:33 AM, Thiago Jung Bauermann wrote: >> Instead of setting CPUState::halted to 1 in main_cpu_reset(), use the >> start-powered-off property which makes cpu_common_reset() initialize it >> to 1 in common code. >> >> Also change creation of CPU object

Re: [PATCH v4 4/8] ppc/e500: Use start-powered-off CPUState property

2020-08-18 Thread Thiago Jung Bauermann
Thiago Jung Bauermann writes: > Hello Philippe, > > Thanks for your review. > > Philippe Mathieu-Daudé writes: > >> On 8/18/20 9:22 AM, Philippe Mathieu-Daudé wrote: @@ -897,6 +895,19 @@ void ppce500_init(MachineState *machine) } else { /* Secondary CPUs

Re: [PATCH v4 4/8] ppc/e500: Use start-powered-off CPUState property

2020-08-18 Thread Thiago Jung Bauermann
Hello Philippe, Thanks for your review. Philippe Mathieu-Daudé writes: > On 8/18/20 9:22 AM, Philippe Mathieu-Daudé wrote: >> On 8/18/20 5:33 AM, Thiago Jung Bauermann wrote: >>> Instead of setting CPUState::halted to 1 in ppce500_cpu_reset_sec(), use >>> the start-powered-off property which

Re: [PATCH v4 4/8] ppc/e500: Use start-powered-off CPUState property

2020-08-18 Thread Thiago Jung Bauermann
Hi Igor, Thank you for reviewing these patches, and the tips you provided here and on other messages on how to fix the refcount issues. Igor Mammedov writes: > On Tue, 18 Aug 2020 00:33:19 -0300 > Thiago Jung Bauermann wrote: > > [...] > >> Also change creation of CPU object from

Re: [RFC PATCH v2 0/4] Use ACPI PCI hot-plug for q35

2020-08-18 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200818215227.181654-1-jus...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

Re: [PATCH] audio/jack: fix use after free segfault

2020-08-18 Thread Geoffrey McRae
On 2020-08-19 04:11, Christian Schoenebeck wrote: On Dienstag, 18. August 2020 14:40:36 CEST Geoffrey McRae wrote: Due to a ridiculous commit in the Jack library, the client may have been freed already by a secondary audio device recovering its session.

Re: [PATCH 2/3] linux user: moving is proc functions to separate file

2020-08-18 Thread Андрей Аладьев
Ok, we may store these functions in syscall.c. вт, 18 авг. 2020 г. в 18:56, Laurent Vivier : > Le 18/08/2020 à 01:57, Andrew Aladjev a écrit : > > Signed-off-by: Andrew Aladjev > > --- > > linux-user/Makefile.objs | 5 +++-- > > linux-user/syscall.c | 33

[RFC PATCH v2 4/4] hw/acpi/ich9: Enable ACPI PCI hot-plug

2020-08-18 Thread Julia Suvorova
Add acpi_pcihp to ich9_pm and use ACPI PCI hot-plug by default. Signed-off-by: Julia Suvorova --- Note: New pc_compats are usually added shortly after release. I will switch to pc_compat_5_1 when it becomes available. hw/i386/acpi-build.h | 1 + include/hw/acpi/ich9.h | 3 +++

[RFC PATCH v2 3/4] hw/i386/acpi-build: Turn off support of PCIe native hot-plug and SHPC in _OSC

2020-08-18 Thread Julia Suvorova
Other methods may be used if the system is capable of this and the _OSC bit is set. Disable them explicitly to force ACPI PCI hot-plug use. The older versions will still use PCIe native. Signed-off-by: Julia Suvorova --- hw/i386/acpi-build.h | 11 +++ hw/i386/acpi-build.c | 21

[RFC PATCH v2 1/4] hw/acpi/ich9: Trace ich9_gpe_readb()/writeb()

2020-08-18 Thread Julia Suvorova
Add trace events similar to piix4_gpe_readb() to check gpe status. Signed-off-by: Julia Suvorova Reviewed-by: Igor Mammedov --- hw/acpi/ich9.c | 7 ++- hw/acpi/trace-events | 4 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c index

[RFC PATCH v2 2/4] hw/i386/acpi-build: Add ACPI PCI hot-plug methods to q35

2020-08-18 Thread Julia Suvorova
Implement notifications and gpe to support q35 ACPI PCI hot-plug. Use 0xcc4 - 0xcd7 range for 'acpi-pci-hotplug' io ports. Signed-off-by: Julia Suvorova --- include/hw/acpi/pcihp.h | 3 ++- hw/acpi/pcihp.c | 10 ++ hw/acpi/piix4.c | 2 +- hw/i386/acpi-build.c| 25

[RFC PATCH v2 0/4] Use ACPI PCI hot-plug for q35

2020-08-18 Thread Julia Suvorova
PCIe native hot-plug has numerous problems with racing events and unpredictable guest behaviour (Windows). Switching to ACPI hot-plug for now. Tested on RHEL 8 and Windows 2019. pxb-pcie is not yet supported. v2: * new ioport range for acpiphp [Gerd] * drop find_pci_host() [Igor] *

Re: [PATCH 06/41] allwinner-h3: Rename memmap enum constants

2020-08-18 Thread Eduardo Habkost
On Mon, Aug 17, 2020 at 09:07:58PM +0200, Niek Linnenbank wrote: > Hi, > > Interesting suggestion Philippe. I modelled the initial code of the H3 SoC > mostly in-line with the aspeed SoC, > to let it use commonly applied code structures where possible. And it looks > like in this series,

Re: [PATCH 1/3] linux user: make execfd global (like exec path) and keep it open

2020-08-18 Thread Андрей Аладьев
Hello. I want to explain situation we have in qemu today. It looks simple, but gives complex problems. Please open "linux-user/main.c": execfd = qemu_getauxval(AT_EXECFD); if (execfd == 0) { execfd = open(exec_path, O_RDONLY); if (execfd < 0) { ... } } ... close(execfd); We may take

RE: [EXTERNAL] Re: [PATCH v2 0/3] testing: Build WHPX enabled binaries

2020-08-18 Thread Sunil Muthuswamy
> >> It's still shameful that MS is forcing developers to waste time > >> rewriting API headers, just because the MS legal departments are not > >> able to understand the needs of Open Source development. > > There has be a big switch from Microsoft toward Open Source, I attended > > some of there

Re: [PATCH 01/41] pl1110: Rename PL1110 enum

2020-08-18 Thread Eduardo Habkost
CCing maintainer (pmaydell). On Fri, Aug 14, 2020 at 07:45:40PM +0200, Philippe Mathieu-Daudé wrote: > On 8/14/20 12:25 AM, Eduardo Habkost wrote: > > The PL1110 enum value name will conflict with the PL1110 type > > cast checker, when we replace the existing macro with an inline > > function.

[PATCH v6 1/4] copy-on-read: Support preadv/pwritev_part functions

2020-08-18 Thread Andrey Shinkevich
Add support for the recently introduced functions bdrv_co_preadv_part() and bdrv_co_pwritev_part() to the COR-filter driver. Signed-off-by: Andrey Shinkevich --- block/copy-on-read.c | 28 1 file changed, 16 insertions(+), 12 deletions(-) diff --git

[PATCH v6 3/4] qapi: add filter-node-name to block-stream

2020-08-18 Thread Andrey Shinkevich
Provide the possibility to pass the 'filter-node-name' parameter to the block-stream job as it is done for the commit block job. That will be needed for further iotests implementations. Signed-off-by: Andrey Shinkevich --- block/monitor/block-hmp-cmds.c | 4 ++-- block/stream.c

[PATCH v6 4/4] block: apply COR-filter to block-stream jobs

2020-08-18 Thread Andrey Shinkevich
The patch completes the series with the COR-filter insertion to any block-stream operation. It also makes changes to the iotests 030. The test case 'test_stream_parallel' was deleted due to multiple errors. Signed-off-by: Andrey Shinkevich --- block/stream.c | 76

[PATCH v6 0/4] Apply COR-filter to the block-stream permanently

2020-08-18 Thread Andrey Shinkevich
Note: this series is based on the another one "block: Deal with filters" by Max Reitz that could be found in the branches: https://git.xanclic.moe/XanClic/qemu child-access-functions-v6 https://github.com/XanClic/qemu child-access-functions-v6 v6: Re-based to the series

[PATCH v6 2/4] copy-on-read: add filter append/drop functions

2020-08-18 Thread Andrey Shinkevich
Provide API for the COR-filter insertion/removal. Also, drop the filter child permissions for an inactive state when the filter node is being removed. Signed-off-by: Andrey Shinkevich --- block/copy-on-read.c | 103 +++ block/copy-on-read.h | 36

[REPORT] Nightly Performance Tests - Tuesday, August 18, 2020

2020-08-18 Thread Ahmed Karaman
Host CPU : Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz Host Memory : 15.49 GB Start Time (UTC) : 2020-08-18 21:00:01 End Time (UTC) : 2020-08-18 21:00:11 Execution Time : 0:00:10.419271 Status : FAILURE

Re: [PATCH 30/41] qom: Make type checker functions accept const pointers

2020-08-18 Thread Eduardo Habkost
On Mon, Aug 17, 2020 at 05:08:41PM +0100, Daniel P. Berrangé wrote: > On Thu, Aug 13, 2020 at 06:26:14PM -0400, Eduardo Habkost wrote: > > The existing type check macros all unconditionally drop const > > qualifiers from their arguments. Keep this behavior in the > > macros generated by

Re: [PATCH v7 14/47] stream: Deal with filters

2020-08-18 Thread Andrey Shinkevich
Reviewed-by: Andrey Shinkevich On 10.08.2020 14:04, Vladimir Sementsov-Ogievskiy wrote: 10.08.2020 11:12, Max Reitz wrote: On 07.08.20 12:29, Vladimir Sementsov-Ogievskiy wrote: 16.07.2020 17:59, Max Reitz wrote: On 10.07.20 19:41, Andrey Shinkevich wrote: On 10.07.2020 18:24, Max Reitz

Re: [PULL 000/150] Meson-based build system

2020-08-18 Thread Paolo Bonzini
On 18/08/20 22:10, Paolo Bonzini wrote: > Ok I can see the -mms-bitfields here too, hopefully that's enough to > debug it. Hrm no, I don't see it anymore with ea922aa50b2a8688. Can you send me the config-host.mak, build.ninja and Makefile.ninja files? Here I get: $ make

Re: [PATCH v3] linux-user: Fix 'semop()' and 'semtimedop()' implementation

2020-08-18 Thread Laurent Vivier
Le 18/08/2020 à 20:07, Filip Bozuta a écrit : > The implementations of syscalls 'semop()' and 'semtimedop()' in > file 'syscall.c' use function 'target_to_host_sembuf()' to convert > values of 'struct sembuf' from host to target. However, before this > conversion it should be check whether the

Re: [PULL 000/150] Meson-based build system

2020-08-18 Thread Paolo Bonzini
Ok I can see the -mms-bitfields here too, hopefully that's enough to debug it. Il mar 18 ago 2020, 21:27 Peter Maydell ha scritto: > On Tue, 18 Aug 2020 at 15:14, Paolo Bonzini wrote: > > > > The following changes since commit > d0ed6a69d399ae193959225cdeaa9382746c91cc: > > > > Update

Re: [PULL 000/150] Meson-based build system

2020-08-18 Thread Peter Maydell
On Tue, 18 Aug 2020 at 15:14, Paolo Bonzini wrote: > > The following changes since commit d0ed6a69d399ae193959225cdeaa9382746c91cc: > > Update version for v5.1.0 release (2020-08-11 17:07:03 +0100) > > are available in the Git repository at: > > https://gitlab.com/bonzini/qemu.git

Re: deprecation of in-tree builds

2020-08-18 Thread Peter Maydell
On Mon, 23 Mar 2020 at 13:32, Stefan Hajnoczi wrote: > On Sat, Mar 21, 2020 at 11:50:23PM +0100, BALATON Zoltan wrote: > > This was discussed before. I think instead of annoying people with a > > warning, rather configure should be changed to create a build dir if run > > from source and have a

[Bug 1892081] Re: Performance improvement when using "QEMU_FLATTEN" with softfloat type conversions

2020-08-18 Thread Ahmed Karaman
** Attachment added: "before.png" https://bugs.launchpad.net/qemu/+bug/1892081/+attachment/5402578/+files/before.png -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1892081 Title: Performance

[Bug 1892081] [NEW] Performance improvement when using "QEMU_FLATTEN" with softfloat type conversions

2020-08-18 Thread Ahmed Karaman
Public bug reported: Attached below is a matrix multiplication program for double data types. The program performs the casting operation "(double)rand()" when generating random numbers. This operation calls the integer to float softfloat conversion function "int32_to_float_64". Adding the

[Bug 1892081] Re: Performance improvement when using "QEMU_FLATTEN" with softfloat type conversions

2020-08-18 Thread Ahmed Karaman
** Attachment added: "after.png" https://bugs.launchpad.net/qemu/+bug/1892081/+attachment/5402579/+files/after.png -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1892081 Title: Performance

Re: guest agent public ssh key add/remove support?

2020-08-18 Thread Christian Schoenebeck
On Dienstag, 18. August 2020 15:25:56 CEST David Vossel wrote: > - Guest Agent SSH add/remove Support? > > As a PoC, I cobbled together some guest agent exec and file write client > commands which can technically achieve the desired result of > adding/removing entries in a

[PATCH v3] linux-user: Fix 'semop()' and 'semtimedop()' implementation

2020-08-18 Thread Filip Bozuta
The implementations of syscalls 'semop()' and 'semtimedop()' in file 'syscall.c' use function 'target_to_host_sembuf()' to convert values of 'struct sembuf' from host to target. However, before this conversion it should be check whether the number of semaphore operations 'nsops' is not bigger than

Re: [PATCH] audio/jack: fix use after free segfault

2020-08-18 Thread Christian Schoenebeck
On Dienstag, 18. August 2020 14:40:36 CEST Geoffrey McRae wrote: > Due to a ridiculous commit in the Jack library, the client may have been > freed already by a secondary audio device recovering its session. > > https://github.com/jackaudio/jack2/issues/627 > > Until there is a proper fix for

Re: [PULL 000/150] Meson-based build system

2020-08-18 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200818141025.21608-1-pbonz...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20200818141025.21608-1-pbonz...@redhat.com Subject: [PULL 000/150] Meson-based build

Re: [RFC PATCH v3 4/5] util/vfio-helpers: Introduce qemu_vfio_pci_init_msix_irqs()

2020-08-18 Thread Alex Williamson
On Tue, 18 Aug 2020 18:45:08 +0200 Philippe Mathieu-Daudé wrote: > qemu_vfio_pci_init_irq() allows us to initialize any type of IRQ, > but only one. Introduce qemu_vfio_pci_init_msix_irqs() which is > specific to MSIX IRQ type, and allow us to use multiple IRQs > (thus passing multiple eventfd

Re: [RFC PATCH v3 2/5] util/vfio-helpers: Report error on unsupported host architectures

2020-08-18 Thread Philippe Mathieu-Daudé
On 8/18/20 7:12 PM, Alex Williamson wrote: > On Tue, 18 Aug 2020 18:45:06 +0200 > Philippe Mathieu-Daudé wrote: > >> The vfio-helpers implementation expects a TYPEv1 IOMMU, see >> qemu_vfio_init_pci: >> >> 263 if (!ioctl(s->container, VFIO_CHECK_EXTENSION, VFIO_TYPE1_IOMMU)) { >> 264

  1   2   3   4   5   >