From: Zong Li
The minimum granularity of PMP is 4 bytes, it is small than 4KB page
size, therefore, the pmp checking would be ignored if its range doesn't
start from the alignment of one page. This patch detects the pmp entries
and sets the small page size to TLB if there is a PMP entry which
From: Hou Weiying
First, sizeof(target_ulong) equals to 4 on riscv32, so this change
does not change the function on riscv32. Second, sizeof(target_ulong)
equals to 8 on riscv64, and 'reg_index * 8 + i' is not a legal
pmp_index (we will explain later), which should be 'reg_index * 4 + i'.
If
From: Bin Meng
Now we need to ship the OpenSBI fw_dynamic.elf image for the
RISC-V Spike machine, it requires us to create symbolic links
for pc-bios/*.elf files.
Signed-off-by: Bin Meng
Reviewed-by: Alistair Francis
Message-Id: <1596439832-29238-2-git-send-email-bmeng...@gmail.com>
From: Bin Meng
It is enough to simply map the SiFive FU540 L2 cache controller
into the MMIO space using create_unimplemented_device(), with an
FDT fragment generated, to make the latest upstream U-Boot happy.
Signed-off-by: Bin Meng
Reviewed-by: Alistair Francis
Message-Id:
From: Richard Henderson
If a 32-bit input is not properly nanboxed, then the input is
replaced with the default qnan.
Signed-off-by: Richard Henderson
Reviewed-by: LIU Zhiwei
Message-Id: <20200724002807.441147-5-richard.hender...@linaro.org>
Signed-off-by: Alistair Francis
---
From: Bin Meng
This updates the GitLab CI opensbi job to build opensbi bios images
for the generic platform.
Signed-off-by: Bin Meng
Reviewed-by: Anup Patel
Reviewed-by: Alistair Francis
Message-Id: <1596439832-29238-7-git-send-email-bmeng...@gmail.com>
Signed-off-by: Alistair Francis
---
From: Richard Henderson
Make sure that all results from single-precision scalar helpers
are properly nan-boxed to 64-bits.
Signed-off-by: Richard Henderson
Reviewed-by: LIU Zhiwei
Message-Id: <20200724002807.441147-2-richard.hender...@linaro.org>
Signed-off-by: Alistair Francis
---
From: Bin Meng
Upgrade OpenSBI from v0.7 to v0.8.
The v0.8 release includes the following commits:
1bb00ab lib: No need to provide default PMP region using platform callbacks
a9eac67 include: sbi_platform: Combine reboot and shutdown into one callback
6585fab lib: utils: Add SiFive test device
From: Bin Meng
The RISC-V generic platform is a flattened device tree (FDT) based
platform where all platform specific functionality is provided based
on FDT passed by previous booting stage. The support was added in
the upstream OpenSBI v0.8 release recently.
Update our Makefile to build the
From: Richard Henderson
Make sure that all results from inline single-precision scalar
operations are properly nan-boxed to 64-bits.
Signed-off-by: Richard Henderson
Reviewed-by: LIU Zhiwei
Message-Id: <20200724002807.441147-4-richard.hender...@linaro.org>
Signed-off-by: Alistair Francis
---
From: LIU Zhiwei
Signed-off-by: LIU Zhiwei
Signed-off-by: Richard Henderson
Message-Id: <20200626205917.4545-5-zhiwei_...@c-sky.com>
Signed-off-by: Richard Henderson
Message-Id: <20200724002807.441147-8-richard.hender...@linaro.org>
Signed-off-by: Alistair Francis
---
From: Richard Henderson
Do not depend on the RVD extension, take input and output via
TCGv_i64 instead of fpu regno. Move the function to translate.c
so that it can be used in multiple trans_*.inc.c files.
Signed-off-by: Richard Henderson
Reviewed-by: LIU Zhiwei
Message-Id:
From: LIU Zhiwei
Use tcg_gen_extu_tl_i64 to avoid the ifdef.
Signed-off-by: LIU Zhiwei
Signed-off-by: Richard Henderson
Message-Id: <20200626205917.4545-7-zhiwei_...@c-sky.com>
Signed-off-by: Richard Henderson
Message-Id: <20200724002807.441147-7-richard.hender...@linaro.org>
Signed-off-by:
-20200821-1
for you to fetch changes up to 01c41d15de13104774d08e951db24815c8cffc79:
hw/intc: ibex_plic: Honour source priorities (2020-08-21 22:37:55 -0700)
The first RISC-V PR for the 5.2 window.
This includes:
- NaNBox fixes
From: Richard Henderson
If a 32-bit input is not properly nanboxed, then the input is replaced
with the default qnan. The only inline expansion is for the sign-changing
set of instructions: FSGNJ.S, FSGNJX.S, FSGNJN.S.
Signed-off-by: Richard Henderson
Reviewed-by: LIU Zhiwei
Message-Id:
Reported-by: Eduardo Habkost
Signed-off-by: Alistair Francis
---
hw/core/register.c | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/hw/core/register.c b/hw/core/register.c
index ddf91eb445..5e8e8199d0 100644
--- a/hw/core/register.c
+++ b/hw/core/register.c
@@
On 2020-08-22 03:47, Paolo Bonzini wrote:
On 21/08/20 19:34, Christian Schoenebeck wrote:
static void qjack_fini_out(HWVoiceOut *hw)
{
QJackOut *jo = (QJackOut *)hw;
qjack_client_fini(>c);
+
+qemu_bh_delete(jo->c.shutdown_bh);
Paolo wrapped that qemu_bh_delete() call inside
All autopkgtests for the newly accepted qemu (1:4.2-3ubuntu6.5) for focal have
finished running.
The following regressions have been reported in tests triggered by the package:
ubuntu-image/1.9+20.04ubuntu1 (amd64)
systemd/245.4-4ubuntu3.2 (amd64, armhf, s390x, ppc64el)
livecd-rootfs/2.664.4
While technically compatible will (depending on the CPU) hopefully fail
later with a cryptic error:
qemu: Unexpected FPU mode
Provide an earlier hint of what the problem might be by detecting if the
binary might not be using the n32 ABI and print a warning.
Signed-off-by: Carlo Marcelo Arenas
To support some of the complex topology, we introduced EPYC mode apicid decode.
But, EPYC mode decode is running into problems. Also it can become quite a
maintenance problem in the future. So, it was decided to remove that code and
use the generic decode which works for majority of the topology.
apic_id contains all the information required to build
CPUID_8000_001E. core_id and node_id is already part of
apic_id generated by x86_topo_ids_from_apicid_epyc.
Also remove the restriction on number bits on core_id and
node_id.
Remove all the hardcoded values and replace with generalized
Remove the EPYC specific apicid decoding and use the generic
default decoding.
This reverts commit 247b18c593ec298446645af8d5d28911daf653b1.
Signed-off-by: Babu Moger
---
target/i386/cpu.c |2 --
1 file changed, 2 deletions(-)
diff --git a/target/i386/cpu.c b/target/i386/cpu.c
index
Remove the EPYC specific apicid decoding and use the generic
default decoding.
This reverts commit 7568b20a6405042f62c64af3268f4330aed5.
Signed-off-by: Babu Moger
---
include/hw/i386/topology.h | 79
target/i386/cpu.c |2 +
2
Remove the EPYC specific apicid decoding and use the generic
default decoding.
This reverts commit 7b225762c8c05fd31d4c2be116aedfbc00383f8b.
Signed-off-by: Babu Moger
---
hw/i386/pc.c |1 -
target/i386/cpu.c |6 +++---
target/i386/cpu.h |1 -
3 files changed, 3 insertions(+),
Remove the EPYC specific apicid decoding and use the generic
default decoding.
This reverts commit 0c1538cb1a26287c072645f4759b9872b1596d79.
Signed-off-by: Babu Moger
---
target/i386/cpu.c | 16
target/i386/cpu.h |1 -
2 files changed, 17 deletions(-)
diff --git
Remove the EPYC specific apicid decoding and use the generic
default decoding.
This reverts commit 2e26f4ab3bf8390a2677d3afd9b1a04f015d7721.
Signed-off-by: Babu Moger
---
hw/i386/pc.c |6 +++---
hw/i386/x86.c | 37 +++--
2 files changed, 10 insertions(+),
Remove the EPYC specific apicid decoding and use the generic
default decoding.
This reverts commit 6121c7fbfd98dbc3af1b00b56ff2eef66df87828.
Signed-off-by: Babu Moger
---
hw/i386/x86.c |5 -
include/hw/i386/x86.h |9 -
2 files changed, 14 deletions(-)
diff --git
Remove node_id, nr_nodes and nodes_per_pkg from topology. Use
die_id, nr_dies and dies_per_pkg which is already available.
Removes the confusion over two variables.
With node_id removed in topology the uninitialized memory issue
with -device and CPU hotplug will be fixed.
Link:
On Fri, Aug 21, 2020 at 07:38:31PM +0200, Philippe Mathieu-Daudé wrote:
> Instead of setting the instance size on each implementations,
> set it on the abstract parent, so we are sure no implementation
> will forget to set it.
>
> Reported-by: Eduardo Habkost
> Signed-off-by: Philippe
On Wed, 19 Aug 2020 at 06:54, Gerd Hoffmann wrote:
>
> The following changes since commit d0ed6a69d399ae193959225cdeaa9382746c91cc:
>
> Update version for v5.1.0 release (2020-08-11 17:07:03 +0100)
>
> are available in the Git repository at:
>
> git://git.kraxel.org/qemu
The following changes since commit d6f83a72a7db94a3ede9f5cc4fb39f9c8e89f954:
Merge remote-tracking branch
'remotes/philmd-gitlab/tags/acceptance-testing-20200812' into staging
(2020-08-21 14:51:43 +0100)
are available in the Git repository at:
https://gitlab.com/bonzini/qemu.git
files() is needed to avoid
../meson.build:977:2: ERROR: File tcg-stub.c does not exist.
Signed-off-by: Paolo Bonzini
---
target/s390x/meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/s390x/meson.build b/target/s390x/meson.build
index d2a3315903..c42eadb7d2
From: Philippe Mathieu-Daudé
Fixes:
$ ../configure --disable-tools --disable-user
../tests/qemu-iotests/meson.build:7:0: ERROR: Unknown variable
"qemu_block_tools".
Suggested-by: Paolo Bonzini
Signed-off-by: Philippe Mathieu-Daudé
Acked-by: Paolo Bonzini
Message-Id:
From: Marc-André Lureau
Note that sl and sv keymaps were not created by qemu-keymap.
Signed-off-by: Marc-André Lureau
Tested-by: Philippe Mathieu-Daudé
Signed-off-by: Paolo Bonzini
---
Makefile| 8 --
meson.build | 11
From: Stefano Garzarella
If there are less than 2 arguments in version_ge(), the second
'shift' prints this error:
../configure: line 232: shift: shift count out of range
As Eric suggested, we can use 'shift ${2:+2}' which works out to
'shift 2' if $2 is set, or 'shift' (implicitly shift 1)
From: Stefano Garzarella
libqemuutil.a build fails with this error:
/usr/bin/ld: libqemuutil.a(util_fdmon-io_uring.c.o): in function `get_sqe':
qemu/build/../util/fdmon-io_uring.c:83: undefined reference to
`io_uring_get_sqe'
/usr/bin/ld: qemu/build/../util/fdmon-io_uring.c:92: undefined
On Fri, Aug 21, 2020 at 11:43:35AM +0200, Cornelia Huck wrote:
> On Thu, 20 Aug 2020 17:55:29 -0400
> Eduardo Habkost wrote:
>
> > While trying to convert TypeInfo declarations to the new
> > OBJECT_DECLARE* macros, I've stumbled on a few suspicious cases
> > where instance_size or class_size is
ote-tracking branch 'remotes/stefanha/tags/block-pull-request' into
staging (2020-08-21 17:26:52 +0100)
are available in the Git repository at:
git://github.com/OSLL/qemu-xtensa.git tags/20200821-xtensa
for you to fetch changes up to c621b4142bf1ff8c663811c10bd1628481e494a6:
target/xte
On 8/21/20 3:35 PM, Stefano Garzarella wrote:
If there are less than 2 arguments in version_ge(), the second
'shift' prints this error:
../configure: line 232: shift: shift count out of range
As Eric suggested, we can use 'shift ${2:+2}' which works out to
'shift 2' if $2 is set, or
On Fri, Aug 21, 2020 at 07:55:02PM +0200, Philippe Mathieu-Daudé wrote:
> On 8/21/20 6:54 PM, Stefano Garzarella wrote:
> > Install liburing-devel dependencies to get better coverage on
> > io-uring stuff (block/io_uring.c and util/fdmon-io_uring.c).
> >
> > Suggested-by: Philippe Mathieu-Daudé
If there are less than 2 arguments in version_ge(), the second
'shift' prints this error:
../configure: line 232: shift: shift count out of range
As Eric suggested, we can use 'shift ${2:+2}' which works out to
'shift 2' if $2 is set, or 'shift' (implicitly shift 1) if $2
is not set.
This
Hi everyone,
My name is Alex, I’m a student at the University of Michigan and I just
completed an internship at IBM Research. There, I have been working on a
project very related to this topic. I tested using Cloud Hypervisor’s
Rust-based vhost-user virtiofs and block devices with QEMU. Bigger
On Fri, Aug 21, 2020 at 01:18:54PM -0500, Eric Blake wrote:
> On 8/21/20 11:33 AM, Stefano Garzarella wrote:
> > If there are less than 2 arguments in version_ge(), the second
> > 'shift' prints this error:
> > ../configure: line 232: shift: shift count out of range
> >
> > Let's skip it if
As we want to do per-queue polling, extract the nvme_poll_queue()
method which operates on a single queue.
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Stefano Garzarella
Signed-off-by: Philippe Mathieu-Daudé
---
block/nvme.c | 44 +++-
1 file changed, 27
nvme_init_queue() doesn't require BlockDriverState anymore.
Replace it by BDRVNVMeState to simplify.
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Stefano Garzarella
Signed-off-by: Philippe Mathieu-Daudé
---
block/nvme.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git
In preparation of using multiple IRQ (thus multiple eventfds)
make BDRVNVMeState::irq_notifier an array (for now of a single
element, the admin queue notifier).
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Stefano Garzarella
Signed-off-by: Philippe Mathieu-Daudé
---
block/nvme.c | 31
qemu_try_blockalign() is a generic API that call back to the
block driver to return its page alignment. As we call from
within the very same driver, we already know to page alignment
stored in our state. Remove indirections and use the value from
BDRVNVMeState.
This change is required to later
nvme_create_queue_pair() doesn't require BlockDriverState anymore.
Replace it by BDRVNVMeState and AioContext to simplify.
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Stefano Garzarella
Signed-off-by: Philippe Mathieu-Daudé
---
block/nvme.c | 13 +++--
1 file changed, 7 insertions(+), 6
In the next commit we'll get rid of qemu_try_blockalign().
To ease review, first replace qemu_try_blockalign0() by explicit
calls to qemu_try_blockalign() and memset().
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Stefano Garzarella
Signed-off-by: Philippe Mathieu-Daudé
---
block/nvme.c | 16
We are going to modify the code in the next commit. Renaming
the 'resp' variable to 'id' first makes the next commit easier
to review. No logical changes.
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Stefano Garzarella
Signed-off-by: Philippe Mathieu-Daudé
---
block/nvme.c | 19
BDRV_POLL_WHILE() is defined as:
#define BDRV_POLL_WHILE(bs, cond) ({ \
BlockDriverState *bs_ = (bs); \
AIO_WAIT_WHILE(bdrv_get_aio_context(bs_), \
cond); })
As we will remove the BlockDriverState use in the next commit,
start by using the
Do not use the same error message for different failures.
Display a different error whether it is the CQ or the SQ.
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Stefano Garzarella
Signed-off-by: Philippe Mathieu-Daudé
---
block/nvme.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
As nvme_create_queue_pair() is allowed to fail, replace the
alloc() calls by try_alloc() to avoid aborting QEMU.
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Stefano Garzarella
Signed-off-by: Philippe Mathieu-Daudé
---
block/nvme.c | 12 ++--
1 file changed, 10 insertions(+), 2
We allocate an unique chunk of memory then use it for two
different structures. By using an union, we make it clear
the data is overlapping (and we can remove the casts).
Suggested-by: Stefan Hajnoczi
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Stefano Garzarella
Signed-off-by: Philippe
Rearrange nvme_add_io_queue() by using a common error path.
This will be proven useful in few commits where we add IRQ
notification to the IO queues.
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Stefano Garzarella
Signed-off-by: Philippe Mathieu-Daudé
---
block/nvme.c | 9 +
1 file
Use self-explicit SCALE_MS definition instead of magic value.
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Stefano Garzarella
Signed-off-by: Philippe Mathieu-Daudé
---
block/nvme.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/nvme.c b/block/nvme.c
index
Hi Kevin,
This series is mostly code rearrangement (cleanups) to be
able to split the hardware code from the block driver code,
to be able to use multiple queues on the same hardware, or
multiple block drivers on the same hardware.
All this series is reviewed.
Since v5:
- audit rebase on
Use definitions instead of '0' or '1' indexes. Also this will
be useful when using multi-queues later.
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Stefano Garzarella
Signed-off-by: Philippe Mathieu-Daudé
---
block/nvme.c | 33 +++--
1 file changed, 19 insertions(+),
Avoid further processing if TRACE_NVME_SUBMIT_COMMAND_RAW is
not enabled. This is an untested intend of performance optimization.
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Philippe Mathieu-Daudé
---
block/nvme.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/block/nvme.c
Op do 20 aug. 2020 02:12 schreef Eduardo Habkost :
> Some of the enum constant names conflict with the QOM type check
> macros (AW_H3_CCU, AW_H3_SYSCTRL). This needs to be addressed to
> allow us to transform the QOM type check macros into functions
> generated by OBJECT_DECLARE_TYPE().
>
>
error output
```
$ ../qemu.org/configure \
> --python=python3 \
> --cross-prefix=x86_64-w64-mingw32- --enable-gtk --enable-sdl \
> --enable-capstone=git \
> --enable-stack-protector \
> --enable-gnutls \
> --enable-nettle \
> --enable-vnc \
> --enable-vnc-sasl \
>
Public bug reported:
pacman -S base-devel mingw-w64-x86_64-toolchain git
pacman -S mingw-w64-x86_64-python mingw-w64-x86_64-python-setuptools
pacman -S mingw-w64-x86_64-spice-protocol
cd /mingw64/bin
cp x86_64-w64-mingw32-gcc-ar.exe x86_64-w64-mingw32-ar.exe
cp x86_64-w64-mingw32-gcc-ranlib.exe
Public bug reported:
Command install and start win7
qemu-system-x86_64 -smbios type=1,uuid=e77aacd6-0acb-4a5c-9a83-a80d029b36f1
-smp 2,sockets=1,cores=2,maxcpus=2 -nodefaults -boot
menu=on,strict=on,reboot-timeout=1000 -m 8192 ^
-readconfig pve-q35-4.0.cfg ^
-device
Hello,
On 21.8.20. 20:45, Laurent Vivier wrote:
Filip,
could you have a look to see what's going wrong?
Thanks,
LAurent
Le 21/08/2020 à 18:23, Peter Maydell a écrit :
On Thu, 13 Aug 2020 at 07:51, Laurent Vivier wrote:
The following changes since commit
Public bug reported:
Booting NetBSD/sparc in qemu no longer works. It broke between qemu
version 5.0.0 and 5.1.0, and a bisection identified the following as the
offending commit:
[5d971f9e672507210e77d020d89e0e89165c8fc9] memory: Revert "memory:
accept mismatching sizes in
On Mon, 17 Aug 2020 at 16:16, Stefan Hajnoczi wrote:
>
> The following changes since commit d0ed6a69d399ae193959225cdeaa9382746c91cc:
>
> Update version for v5.1.0 release (2020-08-11 17:07:03 +0100)
>
> are available in the Git repository at:
>
> https://github.com/stefanha/qemu.git
Le 21/08/2020 à 18:23, Peter Maydell a écrit :
> On Thu, 13 Aug 2020 at 07:51, Laurent Vivier wrote:
>>
>> The following changes since commit d0ed6a69d399ae193959225cdeaa9382746c91cc:
>>
>> Update version for v5.1.0 release (2020-08-11 17:07:03 +0100)
>>
>> are available in the Git repository
On Mon, Aug 17, 2020 at 2:53 AM Bin Meng wrote:
>
> On Sat, Aug 15, 2020 at 1:56 AM Philippe Mathieu-Daudé
> wrote:
> >
> > On 8/14/20 12:25 AM, Eduardo Habkost wrote:
> > > Some of the enum constant names conflict with the QOM type check
> > > macros. This needs to be addressed to allow us to
On Fri, Aug 14, 2020 at 9:49 AM Bin Meng wrote:
>
> From: Bin Meng
>
> Add some useful comments to document the software used for testing.
> including how to patch HSS to bypass the DDR memory initialization,
> HSS and Yocto BSP build instructions, etc.
>
> To launch this machine for testing:
>
On Fri, Aug 14, 2020 at 9:53 AM Bin Meng wrote:
>
> From: Bin Meng
>
> Microchip PolarFire SoC integrates 3 GPIOs controllers. It seems
> enough to create unimplemented devices to cover their register
> spaces at this point.
>
> With this commit, QEMU can boot to U-Boot (2nd stage bootloader)
>
On Fri, Aug 14, 2020 at 9:51 AM Bin Meng wrote:
>
> From: Bin Meng
>
> Microchip PolarFire SoC integrates 2 Candence GEMs to provide
> IEEE 802.3 standard-compliant 10/100/1000 Mbps ethernet interface.
>
> On the Icicle Kit board, GEM0 connects to a PHY at address 8 while
> GEM1 connects to a
On Fri, Aug 21, 2020 at 11:33 AM Alistair Francis wrote:
>
> On Mon, Mar 9, 2020 at 3:00 AM Gerd Hoffmann wrote:
> >
> > The bochs-display mmio bar has some sub-regions with the actual hardware
> > registers. What happens when the guest access something outside those
> > regions depends on the
Filip,
could you have a look to see what's going wrong?
Thanks,
LAurent
Le 21/08/2020 à 18:23, Peter Maydell a écrit :
> On Thu, 13 Aug 2020 at 07:51, Laurent Vivier wrote:
>>
>> The following changes since commit d0ed6a69d399ae193959225cdeaa9382746c91cc:
>>
>> Update version for v5.1.0
On Mon, Mar 9, 2020 at 3:00 AM Gerd Hoffmann wrote:
>
> The bochs-display mmio bar has some sub-regions with the actual hardware
> registers. What happens when the guest access something outside those
> regions depends on the archirecture. On x86 those reads succeed (and
> return 0xff I think).
On Fri, Aug 21, 2020 at 9:24 AM Peter Maydell wrote:
> On Thu, 13 Aug 2020 at 00:24, Max Filippov wrote:
> > please pull the following batch of updates for target/xtensa.
>
> Hi; this conflicts with the meson buildsystem merge, I'm
> afraid -- can you rebase and resend, please?
Sure.
--
On Wed, Aug 19, 2020 at 3:13 AM wrote:
>
> On 8/19/20 2:34 AM, Bin Meng wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> > content is safe
> >
> > On Tue, Aug 18, 2020 at 9:55 PM Anup Patel wrote:
> >> On Tue, Aug 18, 2020 at 6:39 PM wrote:
> >>> On
On Fri, Aug 21, 2020 at 11:40:12AM +0200, David Hildenbrand wrote:
> On 20.08.20 23:55, Eduardo Habkost wrote:
> > While trying to convert TypeInfo declarations to the new
> > OBJECT_DECLARE* macros, I've stumbled on a few suspicious cases
> > where instance_size or class_size is not set, despite
On 20.08.20 02:11, Eduardo Habkost wrote:
> The macro was incorrectly defined using OBJECT_CHECK.
>
> Acked-by: Cornelia Huck
> Reviewed-by: Daniel P. Berrangé
> Signed-off-by: Eduardo Habkost
> ---
> Changes v1 -> v2: none
>
> ---
> Cc: "Michael S. Tsirkin"
> Cc: Cornelia Huck
> Cc: Halil
On 8/21/20 11:33 AM, Stefano Garzarella wrote:
If there are less than 2 arguments in version_ge(), the second
'shift' prints this error:
../configure: line 232: shift: shift count out of range
Let's skip it if there are no more arguments.
Signed-off-by: Stefano Garzarella
---
v2:
- do
On Fri, Aug 21, 2020 at 01:02:59PM +0200, Philippe Mathieu-Daudé wrote:
> Hi Edgar,
>
> On 8/20/20 9:43 PM, Edgar E. Iglesias wrote:
> > From: "Edgar E. Iglesias"
> >
> > This adds missing device-tree source files for the petalogix boards
> > with recompiled DTBs.
> >
> > Cheers,
> > Edgar
> >
On Fri, Aug 21, 2020 at 11:47:32AM +1000, David Gibson wrote:
> On Thu, Aug 20, 2020 at 05:55:29PM -0400, Eduardo Habkost wrote:
> > While trying to convert TypeInfo declarations to the new
> > OBJECT_DECLARE* macros, I've stumbled on a few suspicious cases
> > where instance_size or class_size is
On Fri, Aug 21, 2020 at 10:46 AM Philippe Mathieu-Daudé wrote:
>
> Set the abstract TYPE_SSI_SLAVE instance size in case an
> implementation forgot to set it.
>
> Reported-by: Eduardo Habkost
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Alistair Francis
Alistair
> ---
> See:
>
On 8/21/20 10:21 AM, Peter Maydell wrote:
On Fri, 21 Aug 2020 at 16:00, Stefano Garzarella wrote:
If there are less than 2 arguments in version_ge(), the second shift
prints this error:
../configure: line 232: shift: shift count out of range
Let's shut it up, since we're expecting this
On 8/21/20 5:52 PM, Paolo Bonzini wrote:
> files() is needed to avoid
>
> ../meson.build:977:2: ERROR: File tcg-stub.c does not exist.
>
> Signed-off-by: Paolo Bonzini
> ---
> target/s390x/meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
btw, I'm surprised README does not mention meson, shouldn't you instruct
that it's a build-dep? Maybe suggest pip install command?
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1892533
Title:
On Fri, Aug 21, 2020 at 9:40 PM Philippe Mathieu-Daudé
wrote:
> On 8/21/20 1:58 PM, Daniel P. Berrangé wrote:
> > On Fri, Aug 21, 2020 at 11:41:26AM +0800, Jiachen Zhang wrote:
> >> Due to the commit 65da4539803373ec4eec97ffc49ee90083e56efd, the O_DIRECT
> >> open flag of guest applications will
On 8/21/20 6:14 PM, Paolo Bonzini wrote:
> Looks like update-keymaps has not been run in a while.
>
> Signed-off-by: Paolo Bonzini
> ---
> pc-bios/keymaps/ar| 242 +-
> pc-bios/keymaps/bepo | 242 +-
>
Meson is still hidden, you need to use ../configure.
"can't shift that many" will be fixed shortly (patch already on the
list).
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1892533
Title:
Meson:
On 21/08/20 19:34, Christian Schoenebeck wrote:
>>
>> static void qjack_fini_out(HWVoiceOut *hw)
>> {
>> QJackOut *jo = (QJackOut *)hw;
>> qjack_client_fini(>c);
>> +
>> +qemu_bh_delete(jo->c.shutdown_bh);
> Paolo wrapped that qemu_bh_delete() call inside the lock as well. So I
On 8/21/20 6:54 PM, Stefano Garzarella wrote:
> Install liburing-devel dependencies to get better coverage on
> io-uring stuff (block/io_uring.c and util/fdmon-io_uring.c).
>
> Suggested-by: Philippe Mathieu-Daudé
> Signed-off-by: Stefano Garzarella
> ---
>
configure does not seems to work better:
build$ ../configure
../configure: 232: shift: can't shift that many
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1892533
Title:
Meson: Missing
On Fri, Aug 21, 2020 at 7:58 PM Daniel P. Berrangé
wrote:
> On Fri, Aug 21, 2020 at 11:41:26AM +0800, Jiachen Zhang wrote:
> > Due to the commit 65da4539803373ec4eec97ffc49ee90083e56efd, the O_DIRECT
> > open flag of guest applications will be discarded by virtiofsd. While
> > this behavior
On Fri, Aug 21, 2020 at 01:29:38PM -0400, Eduardo Habkost wrote:
> On Fri, Aug 21, 2020 at 01:53:52PM +0300, Roman Bolshakov wrote:
> > On Thu, Aug 20, 2020 at 05:55:29PM -0400, Eduardo Habkost wrote:
> > > While trying to convert TypeInfo declarations to the new
> > > OBJECT_DECLARE* macros, I've
From: Bin Meng
Per the SD spec, Standard Capacity SD Memory Card (SDSC) supports
capacity up to and including 2 GiB.
Fixes: 2d7adea4fe ("hw/sd: Support SDHC size cards")
Signed-off-by: Bin Meng
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Sai Pavan Boddu
Message-Id:
Set the abstract TYPE_SSI_SLAVE instance size in case an
implementation forgot to set it.
Reported-by: Eduardo Habkost
Signed-off-by: Philippe Mathieu-Daudé
---
See:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg731954.html
---
hw/ssi/ssi.c | 1 +
1 file changed, 1 insertion(+)
diff
Add a sdbus_read_data() method to read multiple bytes on the
data line of a SD bus.
We might improve the tracing later, for now keep logging each
byte individually.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
Message-Id: <20200814092346.21825-7-f4...@amsat.org>
---
The sdbus_read_data() method do a single byte access on the data
line of a SD bus. Rename it as sdbus_read_byte() and document it.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
Message-Id: <20200814092346.21825-4-f4...@amsat.org>
---
include/hw/sd/sd.h| 10
From: Bin Meng
At present the function switch status data structure bit [399:376]
are wrongly pupulated. These 3 bytes encode function switch status
for the 6 function groups, with 4 bits per group, starting from
function group 6 at bit 399, then followed by function group 5 at
bit 395, and so
The read/write_data() methods write do a single byte access
on the data line of a SD card. Rename them as read/write_byte().
Add some documentation (not in "hw/sd/sdcard_legacy.h" which we
are going to remove soon).
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
Use the recently added sdbus_read_data() to read multiple
bytes at once, instead of looping calling sdbus_read_byte().
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
Message-Id: <20200814092346.21825-8-f4...@amsat.org>
---
hw/sd/allwinner-sdhost.c | 10 +++---
1 - 100 of 511 matches
Mail list logo
