[[PATCH v3] 5/5] meson: Fixes ninjatool can not be recognized as script under Window/MSYS2

2020-08-26 Thread luoyonggang
From: Yonggang Luo use ninja instead ${build_path}/ninjatool Signed-off-by: Yonggang Luo --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 3b9e79923d..2ad0c58492 100755 --- a/configure +++ b/configure @@ -8222,7 +8222,7 @@ fi mv

[[PATCH v3] 4/5] configure: Fix include and linkage issue on msys2

2020-08-26 Thread luoyonggang
From: Yonggang Luo On msys2, the -I/e/path/to/qemu -L/e/path/to/qemu are not recognized by the compiler Cause $PWD are result posix style path such as /e/path/to/qemu that can not be recognized by mingw gcc, and `pwd -W` are result Windows style path such as E:/path/to/qemu that can be

[[PATCH v3] 1/5] meson: Fixes the ninjatool issue that E$$: are generated in Makefile.ninja

2020-08-26 Thread luoyonggang
From: Yonggang Luo SIMPLE_PATH_RE should match the full path token. Or the $ and : contained in path would not matched if the path are start with C:/ and E:/ Signed-off-by: Yonggang Luo --- scripts/ninjatool.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[[PATCH v3] 2/5] meson: fixes relpath may fail on win32.

2020-08-26 Thread luoyonggang
From: Yonggang Luo On win32, os.path.relpath would raise exception when do the following relpath: C:/msys64/mingw64/x.exe relative to E:/path/qemu-build would fail. So we try catch it for stopping it from raise exception on msys2 Signed-off-by: Yonggang Luo --- scripts/mtest2make.py | 11

Re: [PATCH v5 07/10] block: introduce preallocate filter

2020-08-26 Thread Vladimir Sementsov-Ogievskiy
26.08.2020 12:58, Max Reitz wrote: On 26.08.20 11:15, Vladimir Sementsov-Ogievskiy wrote: 26.08.2020 11:52, Max Reitz wrote: On 26.08.20 08:49, Vladimir Sementsov-Ogievskiy wrote: 25.08.2020 18:11, Max Reitz wrote: On 21.08.20 16:11, Vladimir Sementsov-Ogievskiy wrote: It's intended to be

Re: [PATCH for-4.2 v2 3/3] block/file-posix: Let post-EOF fallocate serialize

2020-08-26 Thread Vladimir Sementsov-Ogievskiy
26.08.2020 11:23, Vladimir Sementsov-Ogievskiy wrote: 22.08.2020 20:04, Vladimir Sementsov-Ogievskiy wrote: 22.08.2020 20:03, Vladimir Sementsov-Ogievskiy wrote: 01.11.2019 18:25, Max Reitz wrote: The XFS kernel driver has a bug that may cause data corruption for qcow2 images as of qemu

Re: [PATCH v4 2/6] util: refactor qemu_open_old to split off variadic args handling

2020-08-26 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Tue, Aug 25, 2020 at 04:56:40PM +0200, Markus Armbruster wrote: >> Daniel P. Berrangé writes: >> >> > This simple refactoring prepares for future patches. The variadic args >> > handling is split from the main bulk of the open logic. The duplicated >> > calls to

Re: [PATCH v4 5/6] util: give a specific error message when O_DIRECT doesn't work

2020-08-26 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Tue, Aug 25, 2020 at 05:19:53PM +0200, Markus Armbruster wrote: >> Daniel P. Berrangé writes: >> >> > A common error scenario is to tell QEMU to use O_DIRECT in combination >> > with a filesystem that doesn't support it. To aid users to diagnosing >> > their

Re: [PATCH v3 00/74] qom: Automated conversion of type checking boilerplate

2020-08-26 Thread Eduardo Habkost
On Wed, Aug 26, 2020 at 01:22:38PM +0300, Roman Bolshakov wrote: > On Tue, Aug 25, 2020 at 03:19:56PM -0400, Eduardo Habkost wrote: > > git tree for this series: > > https://github.com/ehabkost/qemu-hacks/tree/work/qom-macros-autoconvert > > > > Hi Eduardo, > > another assert fires during QEMU

[PATCH v3 8/8] meson: add NSIS building

2020-08-26 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé --- Makefile| 56 --- meson.build | 25 scripts/nsis.py | 78 + 3 files changed, 103

Re: [PATCH 00/12] Add a General Virtual Device Fuzzer

2020-08-26 Thread Dima Stepanov
Hi Alex, Thanks for the nice general fuzzer implementation, looks pretty exciting. Are there any future plans discussion which i can read or maybe join? I have some ideas about it so it could be great to syncronize. Regards, Dima. On Wed, Jul 22, 2020 at 11:39:21PM -0400, Alexander Bulekov

[PATCH v3 4/8] meson: pass qemu_suffix option

2020-08-26 Thread marcandre . lureau
From: Marc-André Lureau The following patches will make use of it to fix installation paths. Signed-off-by: Marc-André Lureau --- configure | 1 + meson_options.txt | 2 ++ 2 files changed, 3 insertions(+) diff --git a/configure b/configure index e880e5676d..05b944fb8e 100755 ---

[PATCH v3 1/8] configure: rename confsuffix option

2020-08-26 Thread marcandre . lureau
From: Marc-André Lureau The value is used to construct conf/mod/data directories. Signed-off-by: Marc-André Lureau --- configure | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/configure b/configure index b1e11397a8..0e04c47722 100755 --- a/configure

[PATCH v3 7/8] meson: use meson mandir instead of qemu_mandir

2020-08-26 Thread marcandre . lureau
From: Marc-André Lureau When cross-compiling, by default qemu_mandir is 'c:\Program Files\QEMU', which is not recognized as being an absolute path, and meson will end up adding the prefix again. Use the pre-prefixed meson mandir option instead. Reviewed-by: Daniel P. Berrangé Signed-off-by:

[PATCH v3 6/8] meson: pass docdir option

2020-08-26 Thread marcandre . lureau
From: Marc-André Lureau When cross-compiling, by default qemu_docdir is 'c:\Program Files\QEMU\' which is not recognized as being an absolute path, and meson will end up adding the prefix again. Add an option to pass docdir location to meson, pre-prefixed like we do with other directories,

[PATCH v3 3/8] configure: build docdir like other suffixed directories

2020-08-26 Thread marcandre . lureau
From: Marc-André Lureau As documented in --help for --docdir. Signed-off-by: Marc-André Lureau --- configure | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/configure b/configure index 61216b9210..e880e5676d 100755 --- a/configure +++ b/configure @@ -1676,14

[PATCH v3 0/8] meson: mingw installation fixes & nsis conversion

2020-08-26 Thread marcandre . lureau
From: Marc-André Lureau Hi, The following patches fix installation path when cross-compiling Windows version, and move the NSIS build rule to meson. v3: - change qemu suffix handling, make /-separator implicit - use qemu suffix to build qemu_docdir, as --help says - use / to construct qemu

[PATCH v3 5/8] meson: use meson datadir instead of qemu_datadir

2020-08-26 Thread marcandre . lureau
From: Marc-André Lureau When cross-compiling, by default qemu_datadir is 'c:\Program Files\QEMU', which is not recognized as being an absolute path, and meson will end up adding the prefix again. Signed-off-by: Marc-André Lureau --- contrib/vhost-user-gpu/meson.build | 2 +- meson.build

[PATCH v3 2/8] configure: always /-seperate directory from qemu_suffix

2020-08-26 Thread marcandre . lureau
From: Marc-André Lureau Otherwise, we may accept very strange directory names... While at it, quote the variables. Signed-off-by: Marc-André Lureau --- configure | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/configure b/configure index

Re: [PATCH 02/12] hw/vfio/ap: Plug memleak in vfio_ap_get_group()

2020-08-26 Thread Li Qiang
Pan Nengyuan 于2020年8月14日周五 下午6:29写道: > > Missing g_error_free() in vfio_ap_get_group() error path. Fix that. > > Reported-by: Euler Robot > Signed-off-by: Pan Nengyuan Reviewed-by: Li Qiang I see Cornelia Huck has merged this in his tree. Don't know whether this series will go separate

Re: [PATCH 03/12] elf2dmp/qemu_elf: Plug memleak in QEMU_Elf_init

2020-08-26 Thread Li Qiang
Pan Nengyuan 于2020年8月14日周五 下午6:28写道: > > Missing g_error_free in QEMU_Elf_init() error path. Fix that. > > Reported-by: Euler Robot > Signed-off-by: Pan Nengyuan Reviewed-by: Li Qiang > --- > Cc: Viktor Prutyanov > --- > contrib/elf2dmp/qemu_elf.c | 1 + > 1 file changed, 1 insertion(+) >

Re: [PATCH v4 3/6] util: add Error object for qemu_open_internal error reporting

2020-08-26 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Tue, Aug 25, 2020 at 05:14:21PM +0200, Markus Armbruster wrote: >> Daniel P. Berrangé writes: >> >> > Instead of relying on the limited information from errno, we can now >> > also provide detailed error messages. >> >> The more detailed error messages are

Re: [PATCH 05/12] target/i386/sev: Plug memleak in sev_read_file_base64

2020-08-26 Thread Li Qiang
Pan Nengyuan 于2020年8月14日周五 下午6:37写道: > > Missing g_error_free() in sev_read_file_base64() error path. > Fix that. > > Reported-by: Euler Robot > Signed-off-by: Pan Nengyuan Reviewed-by: Li Qiang > --- > Cc: Paolo Bonzini > Cc: Richard Henderson > Cc: Eduardo Habkost > --- >

Re: linux-user static build broken

2020-08-26 Thread Laurent Vivier
Le 26/08/2020 à 11:08, Paolo Bonzini a écrit : > $ORIGIN is a special literal used by ld.so. It's probably fixed by the > same patch that was posted for msys. If I remove the "-Wl,-rpath,RIGIN/" from the command line to build qemu-m68k, it works again. What the patch name or series? Thanks,

[PATCH v6 06/20] acpi: move acpi_dsdt_add_power_button() to ged

2020-08-26 Thread Gerd Hoffmann
Allow reuse for microvm. Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Igor Mammedov --- include/hw/acpi/generic_event_device.h | 1 + hw/acpi/generic_event_device.c | 8 hw/arm/virt-acpi-build.c | 8 3 files changed, 9

[PATCH v6 09/20] microvm/acpi: add acpi_dsdt_add_virtio() for x86

2020-08-26 Thread Gerd Hoffmann
Makes x86 linux kernel find virtio-mmio devices automatically. Signed-off-by: Gerd Hoffmann Reviewed-by: Sergio Lopez Reviewed-by: Igor Mammedov --- hw/i386/acpi-microvm.c | 52 ++ 1 file changed, 52 insertions(+) diff --git a/hw/i386/acpi-microvm.c

Re: [PATCH 04/12] elf2dmp/pdb: Plug memleak in pdb_init_from_file

2020-08-26 Thread Li Qiang
Pan Nengyuan 于2020年8月14日周五 下午6:51写道: > > Missing g_error_free in pdb_init_from_file() error path. Fix that. > > Reported-by: Euler Robot > Signed-off-by: Pan Nengyuan Reviewed-by: Li Qiang > --- > Cc: Viktor Prutyanov > --- > contrib/elf2dmp/pdb.c | 1 + > 1 file changed, 1 insertion(+) >

[PATCH v6 13/20] x86: constify x86_machine_is_*_enabled

2020-08-26 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- include/hw/i386/x86.h | 4 ++-- hw/i386/x86.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/include/hw/i386/x86.h b/include/hw/i386/x86.h index b79f24e28545..a350ea3609f5 100644 --- a/include/hw/i386/x86.h +++

[PATCH v6 18/20] tests/acpi: allow override blkdev

2020-08-26 Thread Gerd Hoffmann
microvm needs virtio-blk instead of ide. Signed-off-by: Gerd Hoffmann Reviewed-by: Igor Mammedov --- tests/qtest/bios-tables-test.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c index

[PATCH v6 17/20] tests/acpi: allow microvm test data updates.

2020-08-26 Thread Gerd Hoffmann
Also add empty test data files. Signed-off-by: Gerd Hoffmann --- tests/qtest/bios-tables-test-allowed-diff.h | 3 +++ tests/data/acpi/microvm/APIC| 0 tests/data/acpi/microvm/DSDT| 0 tests/data/acpi/microvm/FACP| 0 4 files changed, 3

[PATCH v6 16/20] microvm: wire up hotplug

2020-08-26 Thread Gerd Hoffmann
The cpu hotplug code handles the initialization of coldplugged cpus too, so it is needed even in case cpu hotplug is not supported. Wire cpu hotplug up for microvm. Without this we get a broken MADT table. Signed-off-by: Gerd Hoffmann Reviewed-by: Igor Mammedov --- hw/i386/microvm.c | 42

[PATCH v6 00/20] microvm: add acpi support

2020-08-26 Thread Gerd Hoffmann
I know that not supporting ACPI in microvm is intentional. If you still don't want ACPI this is perfectly fine, you can use the usual -no-acpi switch to toggle ACPI support. These are the advantages you are going to loose then: (1) virtio-mmio device discovery without command line hacks

[PATCH v6 11/20] microvm/acpi: use seabios with acpi=on

2020-08-26 Thread Gerd Hoffmann
With acpi=off continue to use qboot. Signed-off-by: Gerd Hoffmann Reviewed-by: Igor Mammedov --- hw/i386/microvm.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/i386/microvm.c b/hw/i386/microvm.c index ca0c9983f137..54510a03f754 100644 --- a/hw/i386/microvm.c +++

[PATCH v6 08/20] microvm/acpi: add minimal acpi support

2020-08-26 Thread Gerd Hoffmann
$subject says all. Can be controlled using -M microvm,acpi=on/off. Signed-off-by: Gerd Hoffmann --- hw/i386/acpi-microvm.h| 8 ++ include/hw/i386/microvm.h | 9 ++ hw/i386/acpi-microvm.c| 187 ++ hw/i386/microvm.c | 40

[PATCH v6 07/20] microvm: make virtio irq base runtime configurable

2020-08-26 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Reviewed-by: Sergio Lopez Reviewed-by: Igor Mammedov --- include/hw/i386/microvm.h | 2 +- hw/i386/microvm.c | 11 +++ 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/include/hw/i386/microvm.h b/include/hw/i386/microvm.h index

[PATCH v6 20/20] tests/acpi: update expected data files for microvm

2020-08-26 Thread Gerd Hoffmann
Also clear tests/qtest/bios-tables-test-allowed-diff.h Signed-off-by: Gerd Hoffmann --- tests/qtest/bios-tables-test-allowed-diff.h | 3 --- tests/data/acpi/microvm/APIC| Bin 0 -> 70 bytes tests/data/acpi/microvm/DSDT| Bin 0 -> 365 bytes

[PATCH v6 10/20] microvm/acpi: use GSI 16-23 for virtio

2020-08-26 Thread Gerd Hoffmann
With ACPI enabled and IO-APIC being properly declared in the ACPI tables we can use interrupt lines 16-23 for virtio and avoid shared interrupts. With acpi disabled we continue to use lines 5-12. Signed-off-by: Gerd Hoffmann Reviewed-by: Sergio Lopez Reviewed-by: Igor Mammedov ---

[PATCH v6 14/20] x86: move acpi_dev from pc/microvm

2020-08-26 Thread Gerd Hoffmann
Both pc and microvm machine types have a acpi_dev field. Move it to the common base type. Signed-off-by: Gerd Hoffmann --- include/hw/i386/microvm.h | 1 - include/hw/i386/pc.h | 1 - include/hw/i386/x86.h | 1 + hw/i386/acpi-build.c | 2 +- hw/i386/acpi-microvm.c| 5

[PATCH v6 19/20] tests/acpi: add microvm test

2020-08-26 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- tests/qtest/bios-tables-test.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c index 058ba3886659..883532e531d6 100644 --- a/tests/qtest/bios-tables-test.c +++

Re: [PATCH v5 03/12] migration/dirtyrate: Add RamlockDirtyInfo to store sampled page info

2020-08-26 Thread David Edmondson
On Wednesday, 2020-08-26 at 11:33:30 +01, Dr. David Alan Gilbert wrote: > * David Edmondson (d...@dme.org) wrote: >> On Monday, 2020-08-24 at 17:14:31 +08, Chuan Zheng wrote: >> >> > Add RamlockDirtyInfo to store sampled page info of each ramblock. >> > >> > Signed-off-by: Chuan Zheng >> > ---

[PATCH v6 15/20] x86: move cpu hotplug from pc to x86

2020-08-26 Thread Gerd Hoffmann
The cpu hotplug code handles the initialization of coldplugged cpus too, so it is needed even in case cpu hotplug is not supported. Move the code from pc to x86, so microvm can use it. Move both plug and unplug to keep everything in one place, even though microvm needs plug only. Signed-off-by:

[PATCH v6 03/20] seabios: add bios-microvm.bin binary

2020-08-26 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- pc-bios/bios-microvm.bin | Bin 0 -> 131072 bytes 1 file changed, 0 insertions(+), 0 deletions(-) create mode 100644 pc-bios/bios-microvm.bin diff --git a/pc-bios/bios-microvm.bin b/pc-bios/bios-microvm.bin new file mode 100644 index

[PATCH v6 12/20] microvm/acpi: disable virtio-mmio cmdline hack

2020-08-26 Thread Gerd Hoffmann
... in case we are using ACPI. Signed-off-by: Gerd Hoffmann Reviewed-by: Igor Mammedov --- hw/i386/microvm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/i386/microvm.c b/hw/i386/microvm.c index 54510a03f754..04209eb38fbe 100644 --- a/hw/i386/microvm.c +++

[PATCH v6 05/20] acpi: ged: add x86 device variant.

2020-08-26 Thread Gerd Hoffmann
Set AcpiDeviceIfClass->madt_cpu, otherwise identical to TYPE_ACPI_GED. Signed-off-by: Gerd Hoffmann Reviewed-by: Igor Mammedov --- include/hw/acpi/generic_event_device.h | 4 +++ hw/i386/generic_event_device_x86.c | 36 ++ hw/i386/meson.build|

[PATCH v6 02/20] seabios: add microvm config, update build rules

2020-08-26 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- roms/Makefile | 5 - roms/config.seabios-microvm | 26 ++ 2 files changed, 30 insertions(+), 1 deletion(-) create mode 100644 roms/config.seabios-microvm diff --git a/roms/Makefile b/roms/Makefile index

[PATCH v6 01/20] microvm: name qboot binary qboot.rom

2020-08-26 Thread Gerd Hoffmann
qboot isn't a bios and shouldnt be named that way. Signed-off-by: Gerd Hoffmann --- hw/i386/microvm.c | 4 ++-- pc-bios/{bios-microvm.bin => qboot.rom} | Bin roms/Makefile | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) rename

[PATCH v6 04/20] acpi: ged: add control regs

2020-08-26 Thread Gerd Hoffmann
Add control regs (sleep, reset) for hw-reduced acpi. Signed-off-by: Gerd Hoffmann Reviewed-by: Igor Mammedov --- include/hw/acpi/generic_event_device.h | 12 +++ hw/acpi/generic_event_device.c | 44 ++ 2 files changed, 56 insertions(+) diff --git

QEMU | Pipeline #182124352 has failed for master | 78dca230

2020-08-26 Thread GitLab via
Your pipeline has failed. Project: QEMU ( https://gitlab.com/qemu-project/qemu ) Branch: master ( https://gitlab.com/qemu-project/qemu/-/commits/master ) Commit: 78dca230 ( https://gitlab.com/qemu-project/qemu/-/commit/78dca230c97ed0d6e16ae0c96d5407644d991994 ) Commit Message: Merge

Re: [PATCH 09/12] blockdev: Fix a memleak in drive_backup_prepare()

2020-08-26 Thread Li Qiang
Pan Nengyuan 于2020年8月14日周五 下午6:54写道: > > 'local_err' seems forgot to propagate in error path, it'll cause > a memleak. Fix it. > > Reported-by: Euler Robot > Signed-off-by: Pan Nengyuan Reviewed-by: Li Qiang > --- > Cc: Kevin Wolf > Cc: Max Reitz > Cc: Markus Armbruster > Cc:

Re: [PATCH 10/12] block/file-posix: fix a possible undefined behavior

2020-08-26 Thread Li Qiang
Pan Nengyuan 于2020年8月14日周五 下午6:32写道: > > local_err is not initialized to NULL, it will cause a assert error as below: > qemu/util/error.c:59: error_setv: Assertion `*errp == NULL' failed. > > Fixes: c6447510690 > Reported-by: Euler Robot > Signed-off-by: Pan Nengyuan Reviewed-by: Li Qiang >

Re: [PATCH 11/12] vnc-auth-sasl: Plug memleak in vnc_socket_ip_addr_string

2020-08-26 Thread Li Qiang
Pan Nengyuan 于2020年8月14日周五 下午6:40写道: > > 'addr' forgot to free in vnc_socket_ip_addr_string error path. Fix that. s/forgot/is forgot, I think the maintainer will do this minor adjustment. . > > Reported-by: Euler Robot > Signed-off-by: Pan Nengyuan Reviewed-by: Li Qiang > --- > Cc: Gerd

Re: [PATCH v5 03/12] migration/dirtyrate: Add RamlockDirtyInfo to store sampled page info

2020-08-26 Thread Dr. David Alan Gilbert
* David Edmondson (d...@dme.org) wrote: > On Monday, 2020-08-24 at 17:14:31 +08, Chuan Zheng wrote: > > > Add RamlockDirtyInfo to store sampled page info of each ramblock. > > > > Signed-off-by: Chuan Zheng > > --- > > migration/dirtyrate.h | 18 ++ > > 1 file changed, 18

Re: [PATCH v5 11/12] migration/dirtyrate: Implement qmp_cal_dirty_rate()/qmp_get_dirty_rate() function

2020-08-26 Thread David Edmondson
On Monday, 2020-08-24 at 17:14:39 +08, Chuan Zheng wrote: > Implement qmp_cal_dirty_rate()/qmp_get_dirty_rate() function which could be > called > > Signed-off-by: Chuan Zheng > --- > migration/dirtyrate.c | 45 + > qapi/migration.json | 44

Re: [PATCH v2 05/10] hw/virtio/vhost-user:Remove dead assignment in scrub_shadow_regions()

2020-08-26 Thread Li Qiang
Chen Qun 于2020年8月25日周二 下午7:28写道: > > Clang static code analyzer show warning: > hw/virtio/vhost-user.c:606:9: warning: Value stored to 'mr' is never read > mr = vhost_user_get_mr_data(reg->userspace_addr, , ); > ^~ > >

Re: [PATCH v3 00/74] qom: Automated conversion of type checking boilerplate

2020-08-26 Thread Roman Bolshakov
On Tue, Aug 25, 2020 at 03:19:56PM -0400, Eduardo Habkost wrote: > git tree for this series: > https://github.com/ehabkost/qemu-hacks/tree/work/qom-macros-autoconvert > Hi Eduardo, another assert fires during QEMU start: $ lldb -- $QEMU -cpu nahelem -M q35,accel=hvf -cdrom test.iso (lldb)

Re: [PATCH v5 10/12] migration/dirtyrate: Implement calculate_dirtyrate() function

2020-08-26 Thread David Edmondson
On Monday, 2020-08-24 at 17:14:38 +08, Chuan Zheng wrote: > Implement calculate_dirtyrate() function. > > Signed-off-by: Chuan Zheng > Signed-off-by: YanYing Zhuang > --- > migration/dirtyrate.c | 45 +++-- > 1 file changed, 43 insertions(+), 2

Re: oslib-posix:Fix handle fd leak in qemu_write_pidfile()

2020-08-26 Thread Daniel P . Berrangé
On Wed, Aug 26, 2020 at 06:14:48PM +0800, AlexChen wrote: > From: alexchen > > The fd will leak when (a.st_ino == b.st_ino) is true, fix it. That is *INTENTIONAL*. We're holding a lock on the file and the lock exists only while the FD is open. When QEMU exists, the FD is closed and the lock

Re: [PATCH v3 49/74] swim: Rename struct SWIM to Swim

2020-08-26 Thread Laurent Vivier
Le 25/08/2020 à 21:20, Eduardo Habkost a écrit : > Currently we have a SWIM typedef and a SWIM type checking macro, > but OBJECT_DECLARE* would transform the SWIM macro into a > function, and the function name would conflict with the SWIM > typedef name. > > Rename the struct and typedef to

Re: [PATCH v5 09/12] migration/dirtyrate: Implement get_sample_page_period() and block_sample_page_period()

2020-08-26 Thread David Edmondson
On Monday, 2020-08-24 at 17:14:37 +08, Chuan Zheng wrote: > Implement get_sample_page_period() and set_sample_page_period() to > sleep specific time between sample actions. > > Signed-off-by: Chuan Zheng > --- > migration/dirtyrate.c | 24 > migration/dirtyrate.h | 2

Re: [PATCH v3 43/74] nubus: Rename class type checking macros

2020-08-26 Thread Laurent Vivier
Le 25/08/2020 à 21:20, Eduardo Habkost a écrit : > Rename the existing class type checking macros to be consistent > with the type name and instance type checking macro. Use a > NUBUS_MACFB prefix instead of MACFB_NUBUS. > > This will make future conversion to OBJECT_DECLARE* easier. > >

Re: [PATCH v2 07/10] vfio/platform: Remove dead assignment in vfio_intp_interrupt()

2020-08-26 Thread Li Qiang
Chenqun (kuhn) 于2020年8月26日周三 上午9:47写道: > > > > > Clang static code analyzer show warning: > > > hw/vfio/platform.c:239:9: warning: Value stored to 'ret' is never read > > > ret = event_notifier_test_and_clear(intp->interrupt); > > > ^

elf2dmp: Fix memory leak on main() error paths

2020-08-26 Thread AlexChen
From: AlexChen The 'kdgb' is allocating memory in get_kdbg(), but it is not freed in both fill_header() and fill_context() failed branches, fix it. Signed-off-by: AlexChen --- contrib/elf2dmp/main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/contrib/elf2dmp/main.c

oslib-posix:Fix handle fd leak in qemu_write_pidfile()

2020-08-26 Thread AlexChen
From: alexchen The fd will leak when (a.st_ino == b.st_ino) is true, fix it. Signed-off-by: AlexChen --- util/oslib-posix.c | 1 + 1 file changed, 1 insertion(+) diff --git a/util/oslib-posix.c b/util/oslib-posix.c index ad8001a4ad..74cf5e9c73 100644 --- a/util/oslib-posix.c +++

Re: [PATCH v5 08/12] migration/dirtyrate: skip sampling ramblock with size below MIN_RAMBLOCK_SIZE

2020-08-26 Thread David Edmondson
On Monday, 2020-08-24 at 17:14:36 +08, Chuan Zheng wrote: > In order to sample real RAM, skip ramblock with size below MIN_RAMBLOCK_SIZE > which is set as 128M. > > Signed-off-by: Chuan Zheng > --- > migration/dirtyrate.c | 24 > migration/dirtyrate.h | 10 ++ >

Re: [PATCH v5 07/12] migration/dirtyrate: Compare page hash results for recorded sampled page

2020-08-26 Thread David Edmondson
On Monday, 2020-08-24 at 17:14:35 +08, Chuan Zheng wrote: > Compare page hash results for recorded sampled page. > > Signed-off-by: Chuan Zheng > Signed-off-by: YanYing Zhuang > --- > migration/dirtyrate.c | 64 > +++ > 1 file changed, 64

Re: [PULL 00/18] riscv-to-apply queue

2020-08-26 Thread Bin Meng
Hi Peter, On Wed, Aug 26, 2020 at 5:25 PM Peter Maydell wrote: > > On Wed, 26 Aug 2020 at 04:21, Bin Meng wrote: > > On Wed, Aug 26, 2020 at 6:41 AM Alistair Francis > > wrote: > > > Richard and Philippe review patches and some of the RISC-V patches get > > > reviewed by the RISC-V community.

Re: [PATCH v5 03/12] migration/dirtyrate: Add RamlockDirtyInfo to store sampled page info

2020-08-26 Thread Zheng Chuan
On 2020/8/26 17:40, Zheng Chuan wrote: > > > On 2020/8/26 17:29, David Edmondson wrote: >> On Monday, 2020-08-24 at 17:14:31 +08, Chuan Zheng wrote: >> >>> Add RamlockDirtyInfo to store sampled page info of each ramblock. >>> >>> Signed-off-by: Chuan Zheng >>> --- >>> migration/dirtyrate.h

Re: [PATCH v5 07/10] block: introduce preallocate filter

2020-08-26 Thread Max Reitz
On 26.08.20 11:15, Vladimir Sementsov-Ogievskiy wrote: > 26.08.2020 11:52, Max Reitz wrote: >> On 26.08.20 08:49, Vladimir Sementsov-Ogievskiy wrote: >>> 25.08.2020 18:11, Max Reitz wrote: On 21.08.20 16:11, Vladimir Sementsov-Ogievskiy wrote: > It's intended to be inserted between format

Re: [PATCH v5 1/8] hw/i386: Remove node_id, nr_nodes and nodes_per_pkg from topology

2020-08-26 Thread Igor Mammedov
On Fri, 21 Aug 2020 17:12:25 -0500 Babu Moger wrote: > Remove node_id, nr_nodes and nodes_per_pkg from topology. Use > die_id, nr_dies and dies_per_pkg which is already available. > Removes the confusion over two variables. > > With node_id removed in topology the uninitialized memory issue >

Re: [PATCH v5 06/12] migration/dirtyrate: Record hash results for each sampled page

2020-08-26 Thread David Edmondson
On Monday, 2020-08-24 at 17:14:34 +08, Chuan Zheng wrote: > Record hash results for each sampled page, crc32 is taken to calculate > hash results for each sampled 4K-page. > > Signed-off-by: Chuan Zheng > Signed-off-by: YanYing Zhuang > --- > migration/dirtyrate.c | 136 >

Re: [PATCH v2 0/3] hw/misc/unimp: Improve how offset/value are displayed

2020-08-26 Thread Philippe Mathieu-Daudé
Le mer. 26 août 2020 11:54, Philippe Mathieu-Daudé a écrit : > Hi Peter, > > Le lun. 24 août 2020 17:01, Peter Maydell a > écrit : > >> On Sat, 22 Aug 2020 at 21:02, Philippe Mathieu-Daudé >> wrote: >> > >> > On 8/12/20 9:02 PM, Philippe Mathieu-Daudé wrote: >> > > This series aims to ease

Re: [PATCH v2 0/3] hw/misc/unimp: Improve how offset/value are displayed

2020-08-26 Thread Philippe Mathieu-Daudé
Hi Peter, Le lun. 24 août 2020 17:01, Peter Maydell a écrit : > On Sat, 22 Aug 2020 at 21:02, Philippe Mathieu-Daudé > wrote: > > > > On 8/12/20 9:02 PM, Philippe Mathieu-Daudé wrote: > > > This series aims to ease looking at the '-d unimp' output reported > > > by the UnimplementedDevice. > >

Re: [PATCH-for-5.2 0/4] hw/char/serial: Use the Clock API to feed the UART reference clock

2020-08-26 Thread Philippe Mathieu-Daudé
Hi Peter, Le lun. 24 août 2020 17:20, Peter Maydell a écrit : > On Sat, 22 Aug 2020 at 21:00, Philippe Mathieu-Daudé > wrote: > > > > On 8/6/20 3:03 PM, Philippe Mathieu-Daudé wrote: > > > This series improve tracing of multiple UART device in the same > > > chipset, and allow to use the Clock

Re: [PATCH v2 2/5] meson: use meson datadir instead of qemu_datadir

2020-08-26 Thread Paolo Bonzini
You'd need to check first if it works correctly if confsuffix "looks like" an absolute path ('/qemu'). So + looks correct to me. (Sorry for top posting). Paolo Il mer 26 ago 2020, 10:53 Marc-André Lureau ha scritto: > Hi > > On Wed, Aug 26, 2020 at 12:30 PM Daniel P. Berrangé > wrote: > >>

Re: [PATCH v2 1/1] core/register: Specify instance_size in the TypeInfo

2020-08-26 Thread Philippe Mathieu-Daudé
Le mar. 25 août 2020 19:42, Alistair Francis a écrit : > Reported-by: Eduardo Habkost > Signed-off-by: Alistair Francis > --- > hw/core/register.c | 31 +-- > 1 file changed, 13 insertions(+), 18 deletions(-) > > diff --git a/hw/core/register.c b/hw/core/register.c

Re: [PATCH v5 03/12] migration/dirtyrate: Add RamlockDirtyInfo to store sampled page info

2020-08-26 Thread Zheng Chuan
On 2020/8/26 17:29, David Edmondson wrote: > On Monday, 2020-08-24 at 17:14:31 +08, Chuan Zheng wrote: > >> Add RamlockDirtyInfo to store sampled page info of each ramblock. >> >> Signed-off-by: Chuan Zheng >> --- >> migration/dirtyrate.h | 18 ++ >> 1 file changed, 18

Re: [PATCH] hw/timer/armv7m_systick: assert that board code set system_clock_scale

2020-08-26 Thread Philippe Mathieu-Daudé
Le mar. 25 août 2020 18:09, Peter Maydell a écrit : > It is the responsibility of board code for an armv7m system to set > system_clock_scale appropriately for the CPU speed of the core. > If it forgets to do this, then QEMU will hang if the guest tries > to use the systick timer in the "tick at

Re: [PATCH v5 03/12] migration/dirtyrate: Add RamlockDirtyInfo to store sampled page info

2020-08-26 Thread David Edmondson
On Monday, 2020-08-24 at 17:14:31 +08, Chuan Zheng wrote: > Add RamlockDirtyInfo to store sampled page info of each ramblock. > > Signed-off-by: Chuan Zheng > --- > migration/dirtyrate.h | 18 ++ > 1 file changed, 18 insertions(+) > > diff --git a/migration/dirtyrate.h

Re: [PULL 00/18] riscv-to-apply queue

2020-08-26 Thread Peter Maydell
On Tue, 25 Aug 2020 at 20:01, Alistair Francis wrote: > > The following changes since commit 7774e403f2ac58b3e87bfe8d2f77676501ba893e: > > Merge remote-tracking branch > 'remotes/kraxel/tags/fixes-20200825-pull-request' into staging (2020-08-25 > 10:54:51 +0100) > > are available in the Git

Re: [PULL 00/18] riscv-to-apply queue

2020-08-26 Thread Peter Maydell
On Wed, 26 Aug 2020 at 04:21, Bin Meng wrote: > On Wed, Aug 26, 2020 at 6:41 AM Alistair Francis wrote: > > Richard and Philippe review patches and some of the RISC-V patches get > > reviewed by the RISC-V community. The main problem (which is a common > > problem in open source) is that large

Re: [PATCH v2 6/7] x68: acpi: trigger SMI before sending hotplug Notify event to OSPM

2020-08-26 Thread Laszlo Ersek
Hi Igor, On 08/25/20 19:25, Laszlo Ersek wrote: > So I would suggest fetching the CNEW array element back into "uid" > first, then using "uid" for both the NOTIFY call, and the (currently > missing) restoration of CSEL. Then we can write 1 to CINS. > > Expressed as a patch on top of yours: > >>

Re: [PATCH v2 6/7] x68: acpi: trigger SMI before sending hotplug Notify event to OSPM

2020-08-26 Thread Igor Mammedov
On Tue, 25 Aug 2020 19:25:48 +0200 Laszlo Ersek wrote: > On 08/18/20 14:22, Igor Mammedov wrote: > > In case firmware has negotiated CPU hotplug SMI feature, generate > > AML to describe SMI IO port region and send SMI to firmware > > on each CPU hotplug SCI in case new CPUs were hotplugged. > >

Re: [PATCH v5 02/12] migration/dirtyrate: add DirtyRateStatus to denote calculation status

2020-08-26 Thread David Edmondson
Minor wordsmithing... On Monday, 2020-08-24 at 17:14:30 +08, Chuan Zheng wrote: > add DirtyRateStatus to denote calculating status. > > Signed-off-by: Chuan Zheng > --- > migration/dirtyrate.c | 22 ++ > qapi/migration.json | 17 + > 2 files changed, 39

[Bug 1892604] Re: qemu-system-arm: ../hw/usb/hcd-dwc2.c:666: dwc2_glbreg_read: Assertion `addr <= GINTSTS2' failed.

2020-08-26 Thread Peter Maydell
It is still a bug in QEMU -- we shouldn't allow guest behaviour to make QEMU assert(). If there's unimplemented functionality in the USB controller model that can be logged with qemu_log_mask(LOG_UNIMP, ...) -- You received this bug notification because you are a member of qemu- devel-ml, which

Re: [PATCH v5 07/10] block: introduce preallocate filter

2020-08-26 Thread Vladimir Sementsov-Ogievskiy
26.08.2020 11:52, Max Reitz wrote: On 26.08.20 08:49, Vladimir Sementsov-Ogievskiy wrote: 25.08.2020 18:11, Max Reitz wrote: On 21.08.20 16:11, Vladimir Sementsov-Ogievskiy wrote: It's intended to be inserted between format and protocol nodes to preallocate additional space (expanding

Re: linux-user static build broken

2020-08-26 Thread Paolo Bonzini
$ORIGIN is a special literal used by ld.so. It's probably fixed by the same patch that was posted for msys. Paolo Il mer 26 ago 2020, 10:51 Laurent Vivier ha scritto: > Le 26/08/2020 à 10:44, Daniel P. Berrangé a écrit : > > On Tue, Aug 25, 2020 at 10:36:13PM +0200, Laurent Vivier wrote: > >>

Re: device compatibility interface for live migration with assigned devices

2020-08-26 Thread Yan Zhao
On Thu, Aug 20, 2020 at 02:24:26PM +0100, Sean Mooney wrote: > On Thu, 2020-08-20 at 14:27 +0800, Yan Zhao wrote: > > On Thu, Aug 20, 2020 at 06:16:28AM +0100, Sean Mooney wrote: > > > On Thu, 2020-08-20 at 12:01 +0800, Yan Zhao wrote: > > > > On Thu, Aug 20, 2020 at 02:29:07AM +0100, Sean Mooney

Re: [PATCH v5 06/10] block: introduce BDRV_REQ_NO_WAIT flag

2020-08-26 Thread Vladimir Sementsov-Ogievskiy
26.08.2020 11:36, Max Reitz wrote: On 26.08.20 08:26, Vladimir Sementsov-Ogievskiy wrote: 25.08.2020 16:10, Max Reitz wrote: On 21.08.20 16:11, Vladimir Sementsov-Ogievskiy wrote: Add flag to make serialising request no wait: if there are conflicting requests, just return error immediately.

[Bug 1893003] Re: qemu linux-user doesn't translate host/target data for iovec I/O

2020-08-26 Thread Mike Gelfand
** Summary changed: - qemu-user doesn't translate host/target data for iovec I/O + qemu linux-user doesn't translate host/target data for iovec I/O ** Tags added: linux-user ** Tags added: ppc s390x -- You received this bug notification because you are a member of qemu- devel-ml, which is

[Bug 1893010] Re: qemu linux-user doesn't support OFD fcntl locks

2020-08-26 Thread Mike Gelfand
** Summary changed: - qemu-user doesn't support OFD fcntl locks + qemu linux-user doesn't support OFD fcntl locks ** Tags added: linux-user -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1893010

Re: [PATCH v2 2/5] meson: use meson datadir instead of qemu_datadir

2020-08-26 Thread Marc-André Lureau
Hi On Wed, Aug 26, 2020 at 12:30 PM Daniel P. Berrangé wrote: > On Tue, Aug 25, 2020 at 09:58:24PM +0400, marcandre.lur...@redhat.com > wrote: > > From: Marc-André Lureau > > > > When cross-compiling, by default qemu_datadir is 'c:\Program > > Files\QEMU', which is not recognized as being an

Re: [PATCH v5 07/10] block: introduce preallocate filter

2020-08-26 Thread Max Reitz
On 26.08.20 08:49, Vladimir Sementsov-Ogievskiy wrote: > 25.08.2020 18:11, Max Reitz wrote: >> On 21.08.20 16:11, Vladimir Sementsov-Ogievskiy wrote: >>> It's intended to be inserted between format and protocol nodes to >>> preallocate additional space (expanding protocol file) on writes >>>

Re: linux-user static build broken

2020-08-26 Thread Laurent Vivier
Le 26/08/2020 à 10:44, Daniel P. Berrangé a écrit : > On Tue, Aug 25, 2020 at 10:36:13PM +0200, Laurent Vivier wrote: >> Hi, >> >> since we have switched to meson, the statically linked binaries of qemu >> linux-user are broken: >> >> cd $OBJ >> $SRC/configure --static

[Bug 1893010] [NEW] qemu linux-user doesn't support OFD fcntl locks

2020-08-26 Thread Mike Gelfand
Public bug reported: "Open file description locks (non-POSIX)", as they are described in fcntl(2) man page, aren't supported by qemu-user and attempting to use those results in EINVAL. I'm on Gentoo with latest QEMU version currently available (5.0.0-r2), and trying to emulate ppc64 and s390x on

Re: linux-user static build broken

2020-08-26 Thread Daniel P . Berrangé
On Tue, Aug 25, 2020 at 10:36:13PM +0200, Laurent Vivier wrote: > Hi, > > since we have switched to meson, the statically linked binaries of qemu > linux-user are broken: > > cd $OBJ > $SRC/configure --static --target-list=m68k-linux-user > make > ./qemu-m68k > Segmentation fault (core dumped) >

Re: [PATCH v2 5/5] meson: add NSIS building

2020-08-26 Thread Daniel P . Berrangé
On Tue, Aug 25, 2020 at 09:58:27PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > --- > Makefile| 56 --- > meson.build | 25 > scripts/nsis.py | 78

Re: [PATCH v2 3/5] meson: add docdir option and pass pre-prefix qemu_docdir

2020-08-26 Thread Marc-André Lureau
Hi On Wed, Aug 26, 2020 at 12:32 PM Daniel P. Berrangé wrote: > On Tue, Aug 25, 2020 at 09:58:25PM +0400, marcandre.lur...@redhat.com > wrote: > > From: Marc-André Lureau > > > > When cross-compiling, by default qemu_docdir is 'c:\Program Files\QEMU\' > > which is not recognized as being an

Re: [PATCH v5 06/10] block: introduce BDRV_REQ_NO_WAIT flag

2020-08-26 Thread Max Reitz
On 26.08.20 08:26, Vladimir Sementsov-Ogievskiy wrote: > 25.08.2020 16:10, Max Reitz wrote: >> On 21.08.20 16:11, Vladimir Sementsov-Ogievskiy wrote: >>> Add flag to make serialising request no wait: if there are conflicting >>> requests, just return error immediately. It's will be used in

Re: [PATCH v2 4/5] meson: use meson mandir instead of qemu_mandir

2020-08-26 Thread Daniel P . Berrangé
On Tue, Aug 25, 2020 at 09:58:26PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > When cross-compiling, by default qemu_mandir is 'c:\Program > Files\QEMU', which is not recognized as being an absolute path, and > meson will end up adding the prefix again. > > Use the

Re: [PATCH v2 3/5] meson: add docdir option and pass pre-prefix qemu_docdir

2020-08-26 Thread Daniel P . Berrangé
On Tue, Aug 25, 2020 at 09:58:25PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > When cross-compiling, by default qemu_docdir is 'c:\Program Files\QEMU\' > which is not recognized as being an absolute path, and meson will end up > adding the prefix again. > > Add an

<    1   2   3   4   5   >