Re: [PATCH v2 2/5] meson: use meson datadir instead of qemu_datadir

2020-08-26 Thread Daniel P . Berrangé
On Tue, Aug 25, 2020 at 09:58:24PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > When cross-compiling, by default qemu_datadir is 'c:\Program > Files\QEMU', which is not recognized as being an absolute path, and > meson will end up adding the prefix again. > >

Re: [PATCH v2 1/5] meson: pass confsuffix option

2020-08-26 Thread Daniel P . Berrangé
On Tue, Aug 25, 2020 at 09:58:23PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > The following patches will make use of it to fix installation paths. > > Signed-off-by: Marc-André Lureau > --- > configure | 1 + > meson_options.txt | 1 + > 2 files changed, 2

Re: [PATCH for-4.2 v2 3/3] block/file-posix: Let post-EOF fallocate serialize

2020-08-26 Thread Vladimir Sementsov-Ogievskiy
22.08.2020 20:04, Vladimir Sementsov-Ogievskiy wrote: 22.08.2020 20:03, Vladimir Sementsov-Ogievskiy wrote: 01.11.2019 18:25, Max Reitz wrote: The XFS kernel driver has a bug that may cause data corruption for qcow2 images as of qemu commit c8bb23cbdbe32f.  We can work around it by treating

Re: [PATCH 3/4] meson: Mingw64 gcc doesn't recognize system include_type for sdl2

2020-08-26 Thread Daniel P . Berrangé
On Wed, Aug 26, 2020 at 08:48:22AM +0200, Paolo Bonzini wrote: > On Tue, Aug 25, 2020 at 11:38 PM Mark Cave-Ayland > wrote: > > Marc-André had a query about why this is marked as a system include, > > however I can > > confirm that it fixes the missing "SDL.h" issue during build. > > It was

Re: [PATCH] os-posix: Restore firmware location ../share/qemu

2020-08-26 Thread Paolo Bonzini
Hi, I will post next week a patch to make all searches relative to the executable path. I will CC you so you can test it. Thanks! Paolo Il mer 26 ago 2020, 10:01 ha scritto: > Prior to commit 6dd2dacedd83d12328afa8559bffb2b9ec5c89ed (v5.0.0), the > binary relative path ../share/qemu was

Re: [PATCH v3 66/74] [automated] Use DECLARE_*CHECKER* macros

2020-08-26 Thread Juan Quintela
Eduardo Habkost wrote: > $ ./scripts/codeconverter/converter.py -i \ >--pattern=TypeCheckMacro $(git grep -l '' -- '*.[ch]') > > Reviewed-by: Daniel P. Berrangé > Signed-off-by: Eduardo Habkost > --- > Changes v2 -> v3: > * Removed hunks due to rebase conflicts: > hw/arm/integratorcp.c

Re: [PATCH] meson: skip SDL2 detection if --disable-system

2020-08-26 Thread Marc-André Lureau
On Wed, Aug 26, 2020 at 11:03 AM Paolo Bonzini wrote: > SDL is only used for system emulation; avoid spurious warnings for > static --disable-system emulation by skipping the detection of > the library if there are no system emulation targets. > > Reported-by: Peter Maydell > Signed-off-by:

Re: [PATCH v3 67/74] [automated] Use DECLARE_*CHECKER* macros (pass 2)

2020-08-26 Thread Juan Quintela
Eduardo Habkost wrote: > $ ./scripts/codeconverter/converter.py -i \ >--pattern=TypeCheckMacro $(git grep -l '' -- '*.[ch]') > > Signed-off-by: Eduardo Habkost > --- > Changes series v2 -> v3: this is a new patch added in series v3 > > The script was re-run after rebase and after additional

Re: [PATCH v3 64/74] [automated] Move QOM typedefs and add missing includes

2020-08-26 Thread Juan Quintela
[dropped people from CC] Eduardo Habkost wrote: > Some typedefs and macros are defined after the type check macros. > This makes it difficult to automatically replace their > definitions with OBJECT_DECLARE_TYPE. > > Patch generated using: > > $ ./scripts/codeconverter/converter.py -i \ >

Re: [PATCH v3 65/74] [automated] Move QOM typedefs and add missing includes (pass 2)

2020-08-26 Thread Juan Quintela
Eduardo Habkost wrote: > Some typedefs and macros are defined after the type check macros. > This makes it difficult to automatically replace their > definitions with OBJECT_DECLARE_TYPE. > > Patch generated using: > > $ ./scripts/codeconverter/converter.py -i \ >

Re: [PATCH v3 62/74] [automated] Use TYPE_INFO macro

2020-08-26 Thread Juan Quintela
Eduardo Habkost wrote: > Generated using: > $ ./scripts/codeconverter/converter.py -i --passes=2 \ > --pattern=TypeRegisterCall,TypeInitMacro $(git grep -l TypeInfo -- > '*.[ch]') > > One notable difference is that files declaring multiple types > will now have multiple separate

Re: [PATCH v3 50/74] migration: Rename class type checking macros

2020-08-26 Thread Juan Quintela
Eduardo Habkost wrote: > Rename the macros to make them consistent with the MIGRATION_OBJ > macro name. > > This will make future conversion to OBJECT_DECLARE* easier. > > Signed-off-by: Eduardo Habkost > --- > Changes series v2 -> v3: new patch added to series v3 > > --- > Cc: Juan Quintela >

Re: [PATCH] meson: don't require CONFIG_VTE for the GTK UI

2020-08-26 Thread Paolo Bonzini
Queued, thanks. Paolo On Wed, Aug 26, 2020 at 12:23 AM Mark Cave-Ayland wrote: > > Prevously CONFIG_VTE was not required to build QEMU with GTK UI support as not > all platforms have VTE available (in particular Windows). > > Remove this requirement from the meson build system to enable QEMU to

[Bug 1893003] [NEW] qemu-user doesn't translate host/target data for iovec I/O

2020-08-26 Thread Mike Gelfand
Public bug reported: When using iovec I/O functions (like `readv`), no data translation happens. I'm hitting this issue with libevent upon constructing a bufferevent over an inotify descriptor, and then building for either ppc64 or s390x (both big-endian) on x86_64 (little-endian) and running

[PULL v2 00/34] Block patches

2020-08-26 Thread Max Reitz
The following changes since commit 30aa19446d82358a30eac3b556b4d6641e00b7c1: Merge remote-tracking branch 'remotes/cschoenebeck/tags/pull-9p-20200812' into staging (2020-08-24 16:39:53 +0100) are available in the Git repository at: https://github.com/XanClic/qemu.git

[PATCH V2 08/10] disas/: fix some comment spelling errors

2020-08-26 Thread zhaolichang
I found that there are many spelling errors in the comments of qemu, so I used the spellcheck tool to check the spelling errors and finally found some spelling errors in the disas folder. Signed-off-by: zhaolichang --- disas/hppa.c | 2 +- disas/m68k.c | 8 disas/ppc.c | 2 +- 3 files

[PATCH V2 09/10] qapi/: fix some comment spelling errors

2020-08-26 Thread zhaolichang
I found that there are many spelling errors in the comments of qemu, so I used the spellcheck tool to check the spelling errors and finally found some spelling errors in the qapi folder. Signed-off-by: zhaolichang Reviewed-by: Markus Armbruster --- qapi/block-core.json | 4 ++-- qapi/crypto.json

[PATCH V2 06/10] linux-user/: fix some comment spelling errors

2020-08-26 Thread zhaolichang
I found that there are many spelling errors in the comments of qemu, so I used the spellcheck tool to check the spelling errors and finally found some spelling errors in the linux-user folder. Signed-off-by: zhaolichang Reviewed-by: Alex Bennée --- linux-user/aarch64/signal.c | 2

[PATCH V2 07/10] block/: fix some comment spelling errors

2020-08-26 Thread zhaolichang
I found that there are many spelling errors in the comments of qemu, so I used the spellcheck tool to check the spelling errors and finally found some spelling errors in the block folder. Signed-off-by: zhaolichang --- block/block-copy.c | 2 +- block/linux-aio.c | 2 +- block/mirror.c | 2 +-

[PATCH V2 05/10] util/: fix some comment spelling errors

2020-08-26 Thread zhaolichang
I found that there are many spelling errors in the comments of qemu, so I used the spellcheck tool to check the spelling errors and finally found some spelling errors in the util folder. Signed-off-by: zhaolichang Reviewed-by: Alex Bennée --- util/osdep.c | 2 +- util/qemu-progress.c

[PATCH V2 03/10] docs/: fix some comment spelling errors

2020-08-26 Thread zhaolichang
I found that there are many spelling errors in the comments of qemu, so I used the spellcheck tool to check the spelling errors and finally found some spelling errors in the docs folder. Signed-off-by: zhaolichang Reviewed-by: Peter Maydell --- docs/COLO-FT.txt | 6 +++---

[PATCH V2 10/10] contrib/: fix some comment spelling errors

2020-08-26 Thread zhaolichang
I found that there are many spelling errors in the comments of qemu, so I used the spellcheck tool to check the spelling errors and finally found some spelling errors in the contrib folder. Signed-off-by: zhaolichang Reviewed-by: Alex Bennée --- contrib/gitdm/filetypes.txt | 6

[PATCH V2 02/10] migration/: fix some comment spelling errors

2020-08-26 Thread zhaolichang
I found that there are many spelling errors in the comments of qemu, so I used the spellcheck tool to check the spelling errors and finally found some spelling errors in the migration folder. Signed-off-by: zhaolichang Reviewed-by: Peter Maydell --- migration/colo-failover.c | 2 +-

[PATCH V2 04/10] scripts/: fix some comment spelling errors

2020-08-26 Thread zhaolichang
I found that there are many spelling errors in the comments of qemu, so I used the spellcheck tool to check the spelling errors and finally found some spelling errors in the scripts folder. Signed-off-by: zhaolichang Reviewed-by: Peter Maydell --- scripts/checkpatch.pl | 2 +-

[PATCH V2 01/10] qemu/: fix some comment spelling errors

2020-08-26 Thread zhaolichang
I found that there are many spelling errors in the comments of qemu, so I used the spellcheck tool to check the spelling errors and finally found some spelling errors in the folder. Signed-off-by: zhaolichang Reviewed-by: Alex Bennée --- Changelog | 2 +- accel/tcg/user-exec.c

[PATCH V2 00/10] fix some comment spelling errors

2020-08-26 Thread zhaolichang
I found that there are many spelling errors in the comments of qemu, so I used the spellcheck tool to check the spelling errors, this series fixed this spelling errors. v1 -> v2: address Peter Maydell's comments address Alex Bennée's comments add reviewed-by for patch 1,2,3,4,5,6,9,10

Re: [PATCH 1/4] meson: Fixes the ninjatool issue that E$$: are generated in Makefile.ninja SIMPLE_PATH_RE should match the full path token. Or the $ and : contained in path would not matched if the pa

2020-08-26 Thread Markus Armbruster
Please do not put all of your commit message in the subject line. https://wiki.qemu.org/Contribute/SubmitAPatch#Write_a_meaningful_commit_message https://chris.beams.io/posts/git-commit/

Re: [PATCH v3 48/74] s390-virtio-ccw: Rename S390_MACHINE_CLASS macro

2020-08-26 Thread Cornelia Huck
On Tue, 25 Aug 2020 15:20:44 -0400 Eduardo Habkost wrote: > Rename it to be consistent with S390_CCW_MACHINE and > TYPE_S390_CCW_MACHINE. > > This will make future conversion to OBJECT_DECLARE* easier. > > Signed-off-by: Eduardo Habkost > --- > Changes series v2 -> v3: new patch added to

Re: [PATCH v5 07/10] block: introduce preallocate filter

2020-08-26 Thread Vladimir Sementsov-Ogievskiy
24.08.2020 20:52, Vladimir Sementsov-Ogievskiy wrote: 21.08.2020 17:11, Vladimir Sementsov-Ogievskiy wrote: It's intended to be inserted between format and protocol nodes to preallocate additional space (expanding protocol file) on writes crossing EOF. It improves performance for file-systems

[PATCH] meson: move pixman detection to meson

2020-08-26 Thread Paolo Bonzini
When pixman is not installed (or too old), but virglrenderer is available and "configure" has been run with "--disable-system", the build currently aborts when trying to compile vhost-user-gpu (since it requires pixman). Let's skip the build of vhost-user-gpu when pixman is not installed or too

[PATCH] configure: add --ninja option

2020-08-26 Thread Paolo Bonzini
On Windows it is not possible to invoke a Python script as $NINJA. If ninja is present use it directly, while if it is not we can keep using ninjatool. Reported-by: Mark Cave-Ayland Signed-off-by: Paolo Bonzini --- configure | 16 +++- 1 file changed, 15 insertions(+), 1

[PATCH] meson: skip SDL2 detection if --disable-system

2020-08-26 Thread Paolo Bonzini
SDL is only used for system emulation; avoid spurious warnings for static --disable-system emulation by skipping the detection of the library if there are no system emulation targets. Reported-by: Peter Maydell Signed-off-by: Paolo Bonzini --- meson.build | 27 --- 1

Re: [PATCH v5 07/10] block: introduce preallocate filter

2020-08-26 Thread Vladimir Sementsov-Ogievskiy
25.08.2020 18:11, Max Reitz wrote: On 21.08.20 16:11, Vladimir Sementsov-Ogievskiy wrote: It's intended to be inserted between format and protocol nodes to preallocate additional space (expanding protocol file) on writes crossing EOF. It improves performance for file-systems with slow

Re: [PATCH 3/4] meson: Mingw64 gcc doesn't recognize system include_type for sdl2

2020-08-26 Thread Paolo Bonzini
On Tue, Aug 25, 2020 at 11:38 PM Mark Cave-Ayland wrote: > Marc-André had a query about why this is marked as a system include, however > I can > confirm that it fixes the missing "SDL.h" issue during build. It was marked as a system include in an attempt to work around the SDL 2.0.8 bug that

Re: [PATCH 2/4] meson: fixes relpath may fail on win32.

2020-08-26 Thread Paolo Bonzini
On Tue, Aug 25, 2020 at 11:31 PM Mark Cave-Ayland wrote: > On 25/08/2020 17:53, luoyongg...@gmail.com wrote: > > > From: Yonggang Luo > > > > On win32, os.path.relpath would raise exception when do the following > > relpath: > > C:/msys64/mingw64/x.exe relative to E:/path/qemu-build would fail.

Re: [PATCH 1/4] meson: Fixes the ninjatool issue that E$$: are generated in Makefile.ninja

2020-08-26 Thread Paolo Bonzini
On Tue, Aug 25, 2020 at 11:26 PM Mark Cave-Ayland wrote: > I've tested this and it changes build.ninja so instead of Windows paths > beginning C$$ > they now begin C$ instead e.g.: > > build qemu-version.h: CUSTOM_COMMAND | > C$:/msys64/home/Mark/qemu/scripts/qemu-version.sh PHONY The patch

Re: device compatibility interface for live migration with assigned devices

2020-08-26 Thread Yan Zhao
On Tue, Aug 25, 2020 at 04:39:25PM +0200, Cornelia Huck wrote: <...> > > do you think the bin_attribute I proposed yesterday good? > > Then we can have a single compatible with a variable in the mdev_type and > > aggregator. > > > >mdev_type=i915-GVTg_V5_{val1:int:2,4,8} > >

Re: [PATCH 00/12] fix some error memleaks

2020-08-26 Thread Pan Nengyuan
ping! On 2020/8/15 0:02, Pan Nengyuan wrote: > This series fix some Error/GError memleaks. > > Pan Nengyuan (12): > qga/channel-posix: Plug memory leak in ga_channel_write_all() > hw/vfio/ap: Plug memleak in vfio_ap_get_group() > elf2dmp/qemu_elf: Plug memleak in QEMU_Elf_init >

Re: [PATCH v5 06/10] block: introduce BDRV_REQ_NO_WAIT flag

2020-08-26 Thread Vladimir Sementsov-Ogievskiy
25.08.2020 16:10, Max Reitz wrote: On 21.08.20 16:11, Vladimir Sementsov-Ogievskiy wrote: Add flag to make serialising request no wait: if there are conflicting requests, just return error immediately. It's will be used in upcoming preallocate filter. Signed-off-by: Vladimir

Re: [PATCH] disas/libvixl: Fix fall-through annotation for GCC >= 7

2020-08-26 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200824130114.41368-1-th...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20200824130114.41368-1-th...@redhat.com Subject: [PATCH] disas/libvixl: Fix fall-through

Re: [External] Re: [PATCH 2/2] coroutine: take exactly one batch from global pool at a time

2020-08-26 Thread 王洪浩
The purpose of this patch is to improve performance without increasing memory consumption. My test case: QEMU command line arguments -drive file=/dev/nvme2n1p1,format=raw,if=none,id=local0,cache=none,aio=native \ -device virtio-blk,id=blk0,drive=local0,iothread=iothread0,num-queues=4 \ -drive

[PATCH v7 8/8] target/s390x: Use start-powered-off CPUState property

2020-08-26 Thread Thiago Jung Bauermann
Instead of setting CPUState::halted to 1 in s390_cpu_initfn(), use the start-powered-off property which makes cpu_common_reset() initialize it to 1 in common code. Note that this changes behavior by setting cs->halted to 1 on reset, which didn't happen before. Acked-by: Cornelia Huck

[PATCH v7 5/8] mips/cps: Use start-powered-off CPUState property

2020-08-26 Thread Thiago Jung Bauermann
Instead of setting CPUState::halted to 1 in main_cpu_reset(), use the start-powered-off property which makes cpu_common_reset() initialize it to 1 in common code. Also change creation of CPU object from cpu_create() to object_new() and qdev_realize_and_unref() because cpu_create() realizes the

[PATCH v7 7/8] sparc/sun4m: Use start-powered-off CPUState property

2020-08-26 Thread Thiago Jung Bauermann
Instead of setting CPUState::halted to 1 in secondary_cpu_reset(), use the start-powered-off property which makes cpu_common_reset() initialize it to 1 in common code. Now secondary_cpu_reset() becomes equivalent to main_cpu_reset() so rename the function to sun4m_cpu_reset(). Also remove

<    1   2   3   4   5