Re: ui: fix potential compile error.

2020-09-01 Thread kra...@redhat.com
Hi, > 1. CentOS7 with Python 2.7.5 > Root cause is my argparse and python version. But change the invoking order > can adapt both new and old argparse. python2 is EOL and not supported any more. please "yum install python3" (yes, centos7 has it, was added in 7.8). take care, Gerd

Re: [RFC v3 1/1] memory: Skip bad range assertion if notifier supports arbitrary masks

2020-09-01 Thread Jason Wang
On 2020/9/2 上午3:35, Peter Xu wrote: On Tue, Sep 01, 2020 at 11:05:18AM +0800, Jason Wang wrote: On 2020/8/21 下午10:12, Peter Xu wrote: On Thu, Aug 20, 2020 at 10:28:00AM +0800, Jason Wang wrote: On 2020/8/19 下午11:50, Peter Xu wrote: On Wed, Aug 19, 2020 at 03:15:26PM +0800, Jason Wang

ui: fix potential compile error.

2020-09-01 Thread 潘睿
We compiled the upstream qemu and result in this GEN code error: ‘’’ GEN ui/input-keymap-atset1-to-qcode.c usage: keymap-gen [-h] {code-map,code-table,name-map,name-table,code-docs,name-docs} ... keymap-gen: error: invalid choice: 'glib2' (choose from

Re: [PATCH] vhost-user: add separate memslot counter for vhost-user

2020-09-01 Thread Raphael Norwitz
I see how this fixes vhost_has_free_slot() to correctly determine whether or not regions can be added, but why are the used_memslots_exceeded variable and the used_memslots_is_exceeded() API needed? On Mon, Aug 10, 2020 at 9:44 PM Jiajun Chen wrote: > > Used_memslots is equal to

Re: [PATCH] linux-user: fix implicit conversion from enumeration type error

2020-09-01 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200901153321.920490-1-laur...@vivier.eu/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20200901153321.920490-1-laur...@vivier.eu Subject: [PATCH] linux-user: fix implicit

Re: [PATCH 3/5] hw/ppc/ppc4xx_pci: Use ARRAY_SIZE() instead of magic value

2020-09-01 Thread David Gibson
On Tue, Sep 01, 2020 at 12:40:41PM +0200, Philippe Mathieu-Daudé wrote: > Replace the magic '4' by ARRAY_SIZE(s->irq) which is more explicit. > > Signed-off-by: Philippe Mathieu-Daudé Acked-by: David Gibson > --- > hw/ppc/ppc4xx_pci.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-)

Re: [PATCH 4/5] hw/ppc/ppc4xx_pci: Replace pointless warning by assert()

2020-09-01 Thread David Gibson
On Tue, Sep 01, 2020 at 12:40:42PM +0200, Philippe Mathieu-Daudé wrote: > We call pci_register_root_bus() to register 4 IRQs with the > ppc4xx_pci_set_irq() handler. As it can only be called with > values in the [0-4[ range, replace the pointless warning by > an assert(). > > Signed-off-by:

Re: [RFC v8 1/5] memory: Rename memory_region_notify_one to memory_region_notify_iommu_one

2020-09-01 Thread David Gibson
On Tue, Sep 01, 2020 at 04:26:04PM +0200, Eugenio Pérez wrote: > Previous name didn't reflect the iommu operation. > > Signed-off-by: Eugenio Pérez Reviewed-by: David Gibson > --- > hw/arm/smmu-common.c | 2 +- > hw/arm/smmuv3.c | 2 +- > hw/i386/intel_iommu.c | 4 ++-- >

Re: [PATCH v2 06/10] target/i386/cpu: Fix memleak in x86_cpu_class_check_missing_features

2020-09-01 Thread Pan Nengyuan
On 2020/9/1 20:03, Markus Armbruster wrote: > Pan Nengyuan writes: > >> 'err' forgot to free in x86_cpu_class_check_missing_features error path. >> Fix that. >> >> Reported-by: Euler Robot >> Signed-off-by: Pan Nengyuan >> Reviewed-by: Li Qiang >> --- >> Cc: Paolo Bonzini >> Cc: Richard

Re: [PATCH v3 12/16] hw/arm: xlnx: Set all boards' GEM 'phy-addr' property value to 23

2020-09-01 Thread Alistair Francis
On Mon, Aug 31, 2020 at 6:50 PM Bin Meng wrote: > > From: Bin Meng > > When cadence_gem model was created for Xilinx boards, the PHY address > was hard-coded to 23 in the GEM model. Now that we have introduced a > property we can use that to tell GEM model what our PHY address is. > Change all

Re: [PATCH] riscv: sifive_test: Allow 16-bit writes to memory region

2020-09-01 Thread Alistair Francis
On Mon, Aug 31, 2020 at 10:59 PM Nathan Chancellor wrote: > > When shutting down the machine running a mainline Linux kernel, the > following error happens: > > $ build/riscv64-softmmu/qemu-system-riscv64 -bios default -M virt \ > -display none -initrd rootfs.cpio -kernel Image -m 512m \ >

Re: [PATCH] riscv: sifive_test: Allow 16-bit writes to memory region

2020-09-01 Thread Alistair Francis
On Mon, Aug 31, 2020 at 10:59 PM Nathan Chancellor wrote: > > When shutting down the machine running a mainline Linux kernel, the > following error happens: > > $ build/riscv64-softmmu/qemu-system-riscv64 -bios default -M virt \ > -display none -initrd rootfs.cpio -kernel Image -m 512m \ >

[REPORT] Nightly Performance Tests - Tuesday, September 1, 2020

2020-09-01 Thread Ahmed Karaman
Host CPU : Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz Host Memory : 15.49 GB Start Time (UTC) : 2020-09-01 22:30:02 End Time (UTC) : 2020-09-01 23:02:51 Execution Time : 0:32:49.638129 Status : SUCCESS Note: Changes denoted by '-' are less than 0.01%.

QEMU | Pipeline #184542228 has failed for master | 8d90bfc5

2020-09-01 Thread GitLab via
Your pipeline has failed. Project: QEMU ( https://gitlab.com/qemu-project/qemu ) Branch: master ( https://gitlab.com/qemu-project/qemu/-/commits/master ) Commit: 8d90bfc5 ( https://gitlab.com/qemu-project/qemu/-/commit/8d90bfc5c31ad60f6049dd39be636b06bc00b652 ) Commit Message: Merge

Re: [PATCH 6/7] hw/display/artist: Fix artist screen resolution

2020-09-01 Thread Richard Henderson
On 9/1/20 11:34 AM, Helge Deller wrote: > Artist screen size is limited to 2048 x 2048 pixels and x/y coordination > addressing needs to be done by OS via an uint32 value which is based on > a 2048 byte line length, independend of the real screen size. > > Since HP-UX seems to ideally need at

Re: [PULL 00/47] target-arm queue

2020-09-01 Thread Peter Maydell
8a04b4815861e6d5fd244d75: > > Merge remote-tracking branch > 'remotes/kraxel/tags/usb-20200831-pull-request' into staging (2020-08-31 > 19:39:13 +0100) > > are available in the Git repository at: > > https://git.linaro.org/people/pmaydell/qemu-arm.git > tags/pull-

Re: [PATCH 5/7] hw/hppa: Add power button emulation

2020-09-01 Thread Richard Henderson
On 9/1/20 11:34 AM, Helge Deller wrote: > Emulate a power button switch, tell SeaBIOS the address via fw_cfg and > bind the power button to the qemu UI. > > Signed-off-by: Helge Deller > --- > hw/hppa/machine.c | 32 > 1 file changed, 32 insertions(+)

Re: [PATCH 4/7] hw/hppa: Inform SeaBIOS about fw_cfg port address

2020-09-01 Thread Richard Henderson
On 9/1/20 11:34 AM, Helge Deller wrote: > -/* QEMU fw_cfg interface port */ > -#define QEMU_FW_CFG_IO_BASE (MEMORY_HPA + 0x80) > +#define FW_CFG_IO_BASE 0xfffa Why is this value changing? r~

Re: [PATCH 3/7] hw/hppa: Store boot device in fw_cfg section

2020-09-01 Thread Richard Henderson
On 9/1/20 11:34 AM, Helge Deller wrote: > Signed-off-by: Helge Deller > --- > hw/hppa/machine.c | 9 + > 1 file changed, 9 insertions(+) Reviewed-by: Richard Henderson r~

Re: [PATCH 2/7] hw/hppa: Make number of TLB and BTLB entries configurable

2020-09-01 Thread Richard Henderson
On 9/1/20 11:34 AM, Helge Deller wrote: > diff --git a/hw/hppa/machine.c b/hw/hppa/machine.c > index 90aeefe2a4..e9d84d0f03 100644 > --- a/hw/hppa/machine.c > +++ b/hw/hppa/machine.c > @@ -72,6 +72,14 @@ static FWCfgState *create_fw_cfg(MachineState *ms) > fw_cfg_add_file(fw_cfg,

Re: [PATCH 0/4] hw/misc/a9scu: Verify CPU count is valid and simplify a bit

2020-09-01 Thread Richard Henderson
On 9/1/20 7:40 AM, Philippe Mathieu-Daudé wrote: > Trivial patches: > - verify the A9 CPU count is in range, > - simplify using MemoryRegionOps valid/impl, > - log unimplemented registers. > > Philippe Mathieu-Daudé (4): > hw/misc/a9scu: Do not allow invalid CPU count > hw/misc/a9scu:

Re: [PATCH 00/13] Make QEMU installation relocatable

2020-09-01 Thread Paolo Bonzini
Il mar 1 set 2020, 23:15 Mark Cave-Ayland ha scritto: > I think this means that it's missing something from Yonggang Luo's patch > here: > https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg07668.html. Yes, I am a bit afraid of that patch. I don't understand exactly why it's needed and I

Re: [PATCH 00/13] Make QEMU installation relocatable

2020-09-01 Thread Mark Cave-Ayland
On 01/09/2020 07:20, Paolo Bonzini wrote: > Right now, the installation of QEMU is not relocatable; there is > a local hack in os_find_datadir() so that Windows binaries look > for ROMs in the executable directory, but that has several limitations: > > - it does not extend to configuration

Re: [RFC v8 0/5] memory: Delete assertion in memory_region_unregister_iommu_notifier

2020-09-01 Thread Peter Xu
On Tue, Sep 01, 2020 at 04:26:03PM +0200, Eugenio Pérez wrote: > I am able to hit this assertion when a Red Hat 7 guest virtio_net device > raises an "Invalidation" of all the TLB entries. This happens in the > guest's startup if 'intel_iommu=on' argument is passed to the guest > kernel and right

Re: [RFC v8 5/5] memory: Skip bad range assertion if notifier is DEVIOTLB type

2020-09-01 Thread Peter Xu
On Tue, Sep 01, 2020 at 04:26:08PM +0200, Eugenio Pérez wrote: > Signed-off-by: Eugenio Pérez Reviewed-by: Peter Xu -- Peter Xu

Re: [RFC v8 1/5] memory: Rename memory_region_notify_one to memory_region_notify_iommu_one

2020-09-01 Thread Peter Xu
On Tue, Sep 01, 2020 at 04:26:04PM +0200, Eugenio Pérez wrote: > Previous name didn't reflect the iommu operation. > > Signed-off-by: Eugenio Pérez Reviewed-by: Peter Xu -- Peter Xu

Re: [RFC v8 4/5] intel_iommu: Do not notify regular iotlb to device-iotlb notifiers

2020-09-01 Thread Peter Xu
On Tue, Sep 01, 2020 at 04:26:07PM +0200, Eugenio Pérez wrote: > This improves performance in case of netperf with vhost-net: > * TCP_STREAM: From 1923.6Mbit/s to 2175.13Mbit/s (13%) > * TCP_RR: From 8464.73 trans/s to 8932.70 trans/s (5.5%) > * UDP_RR: From 8562.08 trans/s to 9005.62/s (5.1%)

Re: [RFC v8 3/5] memory: Add IOMMU_DEVIOTLB_UNMAP IOMMUTLBNotificationType

2020-09-01 Thread Peter Xu
On Tue, Sep 01, 2020 at 04:26:06PM +0200, Eugenio Pérez wrote: > Adapt intel and vhost to use this new notification type > > Signed-off-by: Eugenio Pérez Reviewed-by: Peter Xu -- Peter Xu

Re: [RFC v8 2/5] memory: Add IOMMUTLBEvent

2020-09-01 Thread Peter Xu
On Tue, Sep 01, 2020 at 04:26:05PM +0200, Eugenio Pérez wrote: > This way we can tell between regulars IOMMURLBEntries (entry of IOMMU > hardware) and notifications. s/regulars IOMMURLBEntries/regular IOMMUTLBEntry/ > > In the notifications, we set explicitly if it is a MAPs or an UNMAP, >

Cirrus CI for msys2 are working now, but still buiding failed

2020-09-01 Thread Yonggang Luo
https://cirrus-ci.com/task/6375504892657664 failed with: ``` Compiling C object libqemu-s390x-softmmu.fa.p/meson-generated_.._trace_generated-helpers.c.obj Compiling C object libqemu-s390x-softmmu.fa.p/meson-generated_.._qapi_qapi-events.c.obj Compiling C object

Re: [PATCH v1 1/6] net/can: Initial host SocketCan support for CAN FD.

2020-09-01 Thread Vikram Garhwal
Hi Jan, A couple of comments on this patch. On Tue, Jul 14, 2020 at 02:20:14PM +0200, p...@cmp.felk.cvut.cz wrote: > From: Jan Charvat > > Signed-off-by: Jan Charvat > Signed-off-by: Pavel Pisa > --- > hw/net/can/can_sja1000.c | 2 ++ > include/net/can_emu.h| 8 ++- >

Re: [PATCH 0/7] hppa power button support, graphics updates and firmware fixes

2020-09-01 Thread Helge Deller
Hi Philippe, On 01.09.20 21:37, Philippe Mathieu-Daudé wrote: > On 9/1/20 8:34 PM, Helge Deller wrote: >> Add emulation for a power button on hppa, >> fix quite some bugs in seabios-hppa firmware for artist graphics card >> fix boot with old Linux installation CDs. > > I started to review the

Re: [RFC v3 1/1] memory: Skip bad range assertion if notifier supports arbitrary masks

2020-09-01 Thread Peter Xu
On Tue, Sep 01, 2020 at 11:05:18AM +0800, Jason Wang wrote: > > On 2020/8/21 下午10:12, Peter Xu wrote: > > On Thu, Aug 20, 2020 at 10:28:00AM +0800, Jason Wang wrote: > > > On 2020/8/19 下午11:50, Peter Xu wrote: > > > > On Wed, Aug 19, 2020 at 03:15:26PM +0800, Jason Wang wrote: > > > > > Yes,

Re: [PATCH 0/7] hppa power button support, graphics updates and firmware fixes

2020-09-01 Thread Philippe Mathieu-Daudé
Hi Helge, On 9/1/20 8:34 PM, Helge Deller wrote: > Add emulation for a power button on hppa, > fix quite some bugs in seabios-hppa firmware for artist graphics card > fix boot with old Linux installation CDs. I started to review the version you sent last week and took few notes, are there big

Re: [PATCH] fuzz: Add support for custom fuzzing library

2020-09-01 Thread Paolo Bonzini
On 01/09/20 20:18, Alexander Bulekov wrote: > --- > configure| 12 ++-- > meson.build | 6 +- > tests/qtest/fuzz/meson.build | 5 ++--- > 3 files changed, 17 insertions(+), 6 deletions(-) > > > Hi Paolo, > Here I'm trying to specify the

Re: [PATCH 03/13] oslib-posix: default exec_dir to bindir

2020-09-01 Thread Paolo Bonzini
On 01/09/20 20:04, Richard Henderson wrote: > On 8/31/20 11:20 PM, Paolo Bonzini wrote: >> +exec_dir = g_strdup(CONFIG_BINDIR); > > Why the strdup? The string constant should be fine, IIUC. Of course it is. Paolo

Re: [PATCH v7 4/8] ppc/e500: Use start-powered-off CPUState property

2020-09-01 Thread Thiago Jung Bauermann
Philippe Mathieu-Daudé writes: > On 8/26/20 7:55 AM, Thiago Jung Bauermann wrote: >> Instead of setting CPUState::halted to 1 in ppce500_cpu_reset_sec(), use >> the start-powered-off property which makes cpu_common_reset() initialize it >> to 1 in common code. >> >> Also change creation of

Re: [PATCH] fuzz: Add support for custom fuzzing library

2020-09-01 Thread Paolo Bonzini
On 01/09/20 20:18, Alexander Bulekov wrote: > Maybe if I can get the oss-fuzz LIB_FUZZING_ENGINE > (/usr/lib/libFuzzingEngine.a) into the --start-group, that could also > solve the issue... I'll take another look at exactly what the oss-fuzz > build container does. Yeah, that might do it. You

[PATCH 7/7] target/hppa: Fix boot with old Linux installation CDs

2020-09-01 Thread Helge Deller
The current qemu hppa emulation emulates a PA1.1 CPU, which can only execute the 32-bit instruction set. For unknown 64-bit instructions, a instruction trap is sent to the virtual CPU. This behaviour is correct in the sense that we emulate what the PA1.1 specification says. But when trying to

[PATCH 2/7] hw/hppa: Make number of TLB and BTLB entries configurable

2020-09-01 Thread Helge Deller
Until now the TLB size was fixed at 256 entries. To allow operating systems to utilize more TLB entries in the future, we need to tell firmware how many TLB entries we actually support in the emulation. Firmware then reports this to the operating system via the PDC_CACHE_INFO call. This patch

[PATCH 3/7] hw/hppa: Store boot device in fw_cfg section

2020-09-01 Thread Helge Deller
Signed-off-by: Helge Deller --- hw/hppa/machine.c | 9 + 1 file changed, 9 insertions(+) diff --git a/hw/hppa/machine.c b/hw/hppa/machine.c index e9d84d0f03..4b35afc9d5 100644 --- a/hw/hppa/machine.c +++ b/hw/hppa/machine.c @@ -58,6 +58,12 @@ static uint64_t cpu_hppa_to_phys(void

[PATCH 5/7] hw/hppa: Add power button emulation

2020-09-01 Thread Helge Deller
Emulate a power button switch, tell SeaBIOS the address via fw_cfg and bind the power button to the qemu UI. Signed-off-by: Helge Deller --- hw/hppa/machine.c | 32 1 file changed, 32 insertions(+) diff --git a/hw/hppa/machine.c b/hw/hppa/machine.c index

[PATCH 0/7] hppa power button support, graphics updates and firmware fixes

2020-09-01 Thread Helge Deller
Add emulation for a power button on hppa, fix quite some bugs in seabios-hppa firmware for artist graphics card fix boot with old Linux installation CDs. Helge Deller (7): seabios-hppa: Update SeaBIOS to hppa-qemu-5.2-2 tag hw/hppa: Make number of TLB and BTLB entries configurable hw/hppa:

[PATCH 6/7] hw/display/artist: Fix artist screen resolution

2020-09-01 Thread Helge Deller
Artist screen size is limited to 2048 x 2048 pixels and x/y coordination addressing needs to be done by OS via an uint32 value which is based on a 2048 byte line length, independend of the real screen size. Since HP-UX seems to ideally need at least 640 pixels in width, this patch ensures that

[PATCH 4/7] hw/hppa: Inform SeaBIOS about fw_cfg port address

2020-09-01 Thread Helge Deller
Signed-off-by: Helge Deller --- hw/hppa/hppa_hardware.h | 3 +-- hw/hppa/machine.c | 7 ++- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/hw/hppa/hppa_hardware.h b/hw/hppa/hppa_hardware.h index cdb7fa6240..bc258895c9 100644 --- a/hw/hppa/hppa_hardware.h +++

[PATCH] fuzz: Add support for custom fuzzing library

2020-09-01 Thread Alexander Bulekov
--- configure| 12 ++-- meson.build | 6 +- tests/qtest/fuzz/meson.build | 5 ++--- 3 files changed, 17 insertions(+), 6 deletions(-) Hi Paolo, Here I'm trying to specify the linker-script with add_project_link_arguments. How I'm testing this:

[PATCH v3 0/4] Introducing QMP query-netdevs command

2020-09-01 Thread Alexey Kirillov
This patch series introduces a new QMP command "query-netdevs" to get information about currently attached backend network devices (netdevs). Also, since the "info_str" field of "NetClientState" is now deprecated, we no longer use it for netdevs, only for NIC/hubports. The HMP command "info

[PATCH v3 3/4] hmp: Use QMP query-netdevs in hmp_info_network

2020-09-01 Thread Alexey Kirillov
Replace usage of legacy field info_str of NetClientState for backend network devices with result of QMP command query-netdevs. NIC and hubports still use legacy info_str field. Signed-off-by: Alexey Kirillov --- include/net/net.h | 3 +- net/clients.h | 1 + net/hub.c | 4 +-

[PATCH v3 4/4] net: Do not use legacy info_str for backends

2020-09-01 Thread Alexey Kirillov
As we use QMP query-netdevs to store and get information about backend network devices, we can drop usage legacy field info_str for them. We still use this field for NIC and hubports, so we can not completely remove it. Signed-off-by: Alexey Kirillov --- net/l2tpv3.c | 2 -- net/slirp.c

[PATCH v3 2/4] tests: Add tests for query-netdevs command

2020-09-01 Thread Alexey Kirillov
Signed-off-by: Alexey Kirillov --- tests/qtest/meson.build | 3 + tests/qtest/test-query-netdevs.c | 117 +++ 2 files changed, 120 insertions(+) create mode 100644 tests/qtest/test-query-netdevs.c diff --git a/tests/qtest/meson.build

[PATCH v3 1/4] qapi: net: Add query-netdevs command

2020-09-01 Thread Alexey Kirillov
Add a qmp command that provides information about currently attached backend network devices and their configuration. Signed-off-by: Alexey Kirillov --- include/net/net.h | 1 + net/l2tpv3.c | 19 +++ net/net.c | 32 net/netmap.c | 13 + net/slirp.c

Re: [PATCH 03/13] oslib-posix: default exec_dir to bindir

2020-09-01 Thread Richard Henderson
On 8/31/20 11:20 PM, Paolo Bonzini wrote: > +exec_dir = g_strdup(CONFIG_BINDIR); Why the strdup? The string constant should be fine, IIUC. r~

Re: [PATCH v3 08/16] hw/riscv: microchip_pfsoc: Connect a Cadence SDHCI controller and an SD card

2020-09-01 Thread Philippe Mathieu-Daudé
On 9/1/20 12:27 PM, Bin Meng wrote: > Hi Philippe, > > On Tue, Sep 1, 2020 at 5:42 PM Philippe Mathieu-Daudé wrote: >> >> On 9/1/20 3:39 AM, Bin Meng wrote: >>> From: Bin Meng >>> >>> Microchip PolarFire SoC integrates one Cadence SDHCI controller. >>> On the Icicle Kit board, one eMMC chip and

Re: [PATCH v2 2/3] hw/sd/sdhci: Document the datasheet used

2020-09-01 Thread Richard Henderson
On 9/1/20 7:04 AM, Philippe Mathieu-Daudé wrote: > Add datasheet name in the file header. > > We can not add the direct download link since there is a disclaimers > to agree first on the SD Association website (www.sdcard.org). > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/sd/sdhci.c |

Re: [PATCH v2 1/3] hw/sd/sdhci: Fix qemu_log_mask() format string

2020-09-01 Thread Richard Henderson
On 9/1/20 7:04 AM, Philippe Mathieu-Daudé wrote: > Add missing newline character in qemu_log_mask() format. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/sd/sdhci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard Henderson r~

Re: [PATCH 5/5] hw/isa/isa-bus: Replace hw_error() by assert()

2020-09-01 Thread Richard Henderson
On 9/1/20 3:40 AM, Philippe Mathieu-Daudé wrote: > As we can never have more than ISA_NUM_IRQS (16) ISA IRQs, > replace the not very interesting hw_error() call by an > assert() which is more useful to debug condition that can > not happen. > > Signed-off-by: Philippe Mathieu-Daudé > --- >

Re: [PATCH 4/5] hw/ppc/ppc4xx_pci: Replace pointless warning by assert()

2020-09-01 Thread Richard Henderson
On 9/1/20 3:40 AM, Philippe Mathieu-Daudé wrote: > We call pci_register_root_bus() to register 4 IRQs with the > ppc4xx_pci_set_irq() handler. As it can only be called with > values in the [0-4[ range, replace the pointless warning by > an assert(). > > Signed-off-by: Philippe Mathieu-Daudé >

Re: [PATCH 3/5] hw/ppc/ppc4xx_pci: Use ARRAY_SIZE() instead of magic value

2020-09-01 Thread Richard Henderson
On 9/1/20 3:40 AM, Philippe Mathieu-Daudé wrote: > Replace the magic '4' by ARRAY_SIZE(s->irq) which is more explicit. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/ppc/ppc4xx_pci.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Richard Henderson r~

Re: [PATCH 2/5] hw/mips/fuloong2e: Convert pointless error message to an assert()

2020-09-01 Thread Richard Henderson
On 9/1/20 3:40 AM, Philippe Mathieu-Daudé wrote: > Displaying "vt82c686b_init error" doesn't give any hint about why > this call failed. As this message targets developers and not users, > replace the pointless error message by a call to assert() which > will provide more useful information. > >

Re: [PATCH v6 11/16] cpus: remove checks for non-NULL cpus_accel

2020-09-01 Thread Richard Henderson
On 9/1/20 12:21 AM, Claudio Fontana wrote: > now that all accelerators support the CpusAccel interface, > we can remove most checks for non-NULL cpus_accel, > we just add a sanity check/assert at vcpu creation. > > Signed-off-by: Claudio Fontana > --- > softmmu/cpus.c | 33

Re: [PATCH v6 12/16] cpus: add handle_interrupt to the CpusAccel interface

2020-09-01 Thread Richard Henderson
On 9/1/20 12:21 AM, Claudio Fontana wrote: > kvm: uses the generic handler > qtest: uses the generic handler > whpx: changed to use the generic handler (identical implementation) > hax: changed to use the generic handler (identical implementation) > hvf: changed to use the generic handler

[PULL 24/26] meson: add description to options

2020-09-01 Thread Paolo Bonzini
This will be useful in the future to generate configure command line parsing from meson_options.txt. Signed-off-by: Paolo Bonzini --- meson_options.txt | 29 - 1 file changed, 20 insertions(+), 9 deletions(-) diff --git a/meson_options.txt b/meson_options.txt index

[PULL 26/26] Makefile: Fix in-tree clean/distclean

2020-09-01 Thread Paolo Bonzini
From: Greg Kurz Doing 'make clean' or 'make distclean' in a freshly cloned tree results in: make: *** No rule to make target 'ninja-clean', needed by 'clean'. Stop. Make the fallback rules global. While here, change the ninjatool recipe to always have a zero exit status and thus prevent make

[PULL v2 00/26] Meson changes for 2020-09-01

2020-09-01 Thread Paolo Bonzini
The following changes since commit 2f4c51c0f384d7888a04b4815861e6d5fd244d75: Merge remote-tracking branch 'remotes/kraxel/tags/usb-20200831-pull-request' into staging (2020-08-31 19:39:13 +0100) are available in the Git repository at: https://gitlab.com/bonzini/qemu.git tags/for-upstream

[PULL 25/26] Makefile: Add back TAGS/ctags/cscope rules

2020-09-01 Thread Paolo Bonzini
From: Greg Kurz It is a bit of a pain to be forced to run configure before being able to use cscope and friends. Add back the rules to build them in-tree as before commit a56650518f5b. Fixes: a56650518f5b ("configure: integrate Meson in the build system") Signed-off-by: Greg Kurz Message-Id:

[PULL 10/26] meson: move zlib detection to meson

2020-09-01 Thread Paolo Bonzini
Meson includes the same logic that tries to look for -lz if pkg-config (and cmake) cannot find zlib. The undocumented --disable-zlib-test option becomes a no-op. There is still an instance of "-lz" in the LIBS directory. It will go away as soon as tests are converted to meson, because the zlib

Re: [PATCH v6 05/16] cpus: extract out qtest-specific code to accel/qtest

2020-09-01 Thread Richard Henderson
On 9/1/20 12:21 AM, Claudio Fontana wrote: > register a "CpusAccel" interface for qtest as well. > > Signed-off-by: Claudio Fontana > --- > MAINTAINERS | 2 +- > accel/meson.build | 2 +- > accel/qtest/meson.build | 7 +++ > accel/qtest/qtest-cpus.c | 91

Re: [PATCH v6 04/16] cpus: extract out TCG-specific code to accel/tcg

2020-09-01 Thread Richard Henderson
On 9/1/20 12:21 AM, Claudio Fontana wrote: > TCG is the first accelerator to register a "CpusAccel" interface > on initialization, providing functions for starting a vcpu, > kicking a vcpu, sychronizing state and getting virtual clock > and ticks. > > Signed-off-by: Claudio Fontana >

Re: [PATCH v6 03/16] cpus: prepare new CpusAccel cpu accelerator interface

2020-09-01 Thread Richard Henderson
On 9/1/20 12:21 AM, Claudio Fontana wrote: > The new interface starts unused, will start being used by the > next patches. > > It provides methods for each accelerator to start a vcpu, kick a vcpu, > synchronize state, get cpu virtual clock and elapsed ticks. > > In qemu_wait_io_event, make it

Re: [PATCH v6 01/16] cpu-timers, icount: new modules

2020-09-01 Thread Richard Henderson
On 9/1/20 12:21 AM, Claudio Fontana wrote: > refactoring of cpus.c continues with cpu timer state extraction. > > cpu-timers: responsible for the softmmu cpu timers state, > including cpu clocks and ticks. > > icount: counts the TCG instructions executed. As such it is specific to >

Re: [PATCH v3 5/5] pc-bios: s390x: Go into disabled wait when encountering a PGM exception

2020-09-01 Thread Thomas Huth
On 31/08/2020 17.09, Janosch Frank wrote: > Let's setup a PGM PSW, so we won't load 0s when a program exception > happens. Instead we'll load a disabled wait PSW. > > Signed-off-by: Janosch Frank > Reviewed-by: Christian Borntraeger > --- > pc-bios/s390-ccw/start.S | 3 +++ > 1 file changed, 3

Re: [PATCH v1 2/6] hw/net/can: sja1000 ignore CAN FD frames

2020-09-01 Thread Vikram Garhwal
On Tue, Jul 14, 2020 at 02:20:15PM +0200, p...@cmp.felk.cvut.cz wrote: > From: Jan Charvat > > Signed-off-by: Jan Charvat > Signed-off-by: Pavel Pisa Reviewed-by: Vikram Garhwal > --- > hw/net/can/can_sja1000.c | 29 +++-- > 1 file changed, 23 insertions(+), 6

Re: [PATCH v3 4/5] pc-bios: s390x: Save io and external new PSWs before overwriting them

2020-09-01 Thread Thomas Huth
On 31/08/2020 17.09, Janosch Frank wrote: > Currently we always overwrite the mentioned exception new PSWs before > loading the enabled wait PSW. Let's save the PSW before overwriting > and restore it right before starting the loaded kernel. > > Signed-off-by: Janosch Frank > --- >

Re: [PATCH-for-5.2 1/2] hw/mips/mipssim: Use MMIO serial device on fake ISA I/O

2020-09-01 Thread Marc-André Lureau
Hi On Thu, Jul 30, 2020 at 9:04 PM Philippe Mathieu-Daudé wrote: > The 'mipssim' is not a real hardware, it is a simulator. > > There is an ISA MMIO space mapped at 0x1fd0, however > this is not a real ISA bus (no ISA IRQ). So can not use > the TYPE_ISA_SERIAL device... > Instead we have

Re: [PATCH v6 02/16] icount: rename functions to be consistent with the module name

2020-09-01 Thread Richard Henderson
On 9/1/20 12:21 AM, Claudio Fontana wrote: > Signed-off-by: Claudio Fontana > --- > accel/tcg/cpu-exec.c| 4 ++-- > docs/replay.txt | 6 +++--- > include/sysemu/cpu-timers.h | 16 +++--- > include/sysemu/replay.h | 4 ++-- > replay/replay.c | 2 +-

QEMU | Pipeline #184436315 has failed for master | 071a6dba

2020-09-01 Thread GitLab via
Your pipeline has failed. Project: QEMU ( https://gitlab.com/qemu-project/qemu ) Branch: master ( https://gitlab.com/qemu-project/qemu/-/commits/master ) Commit: 071a6dba ( https://gitlab.com/qemu-project/qemu/-/commit/071a6dba7d4db57e28f659b30829b1c22b945f4e ) Commit Message: Merge

Re: [PATCH-for-5.2 0/4] hw/char/serial: Use the Clock API to feed the UART reference clock

2020-09-01 Thread Paolo Bonzini
On 06/08/20 15:03, Philippe Mathieu-Daudé wrote: > This series improve tracing of multiple UART device in the same > chipset, and allow to use the Clock API to feed each device with > an (updatable) input clock. > > Based-on: <20200730165900.7030-1-phi...@redhat.com> > "hw/char: Remove

Re: [PATCH v3 3/5] pc-bios: s390x: Use reset PSW if avaliable

2020-09-01 Thread Thomas Huth
On 31/08/2020 17.09, Janosch Frank wrote: > If a blob provides a reset PSW then we should use it instead of > branching to the PSW address and using our own mask. > > Signed-off-by: Janosch Frank > --- > pc-bios/s390-ccw/bootmap.c | 3 ++- > pc-bios/s390-ccw/jump2ipl.c | 22

Re: [PATCH-for-5.2 0/4] hw/char/serial: Use the Clock API to feed the UART reference clock

2020-09-01 Thread Marc-André Lureau
Hi On Wed, Aug 26, 2020 at 1:52 PM Philippe Mathieu-Daudé wrote: > Hi Peter, > > Le lun. 24 août 2020 17:20, Peter Maydell a > écrit : > >> On Sat, 22 Aug 2020 at 21:00, Philippe Mathieu-Daudé >> wrote: >> > >> > On 8/6/20 3:03 PM, Philippe Mathieu-Daudé wrote: >> > > This series improve

Re: [PATCH v3 7/7] migration: introduce snapshot-{save, load, delete} QMP commands

2020-09-01 Thread Daniel P . Berrangé
On Tue, Sep 01, 2020 at 04:20:47PM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > savevm, loadvm and delvm are some of the few HMP commands that have never > > been converted to use QMP. The primary reason for this lack of conversion > > is that they block execution of the

Re: [PATCH 0/2] hw/core: Move hw_error() out of cpus.c

2020-09-01 Thread Richard Henderson
On 9/1/20 4:23 AM, Philippe Mathieu-Daudé wrote: > Move hw_error() out of cpus.c because we already have cpu_abort() > there. > > Philippe Mathieu-Daudé (2): > cpus: Do not dump CPU state when calling hw_error() > hw/core: Move hw_error() out of cpus.c Reviewed-by: Richard Henderson r~

Re: [PATCH v4 4/7] usb: hcd-xhci-sysbus: Attach xhci to sysbus device

2020-09-01 Thread Philippe Mathieu-Daudé
On 8/28/20 9:19 PM, Sai Pavan Boddu wrote: > Use XHCI as sysbus device, add memory region property to get the > address space instance for dma read/write. > > Signed-off-by: Sai Pavan Boddu > --- > hw/usb/Kconfig | 5 +++ > hw/usb/Makefile.objs | 1 + > hw/usb/hcd-xhci-sysbus.c

Re: [PATCH v2 0/7] Run cross-compilation build tests in the gitlab-CI

2020-09-01 Thread Thomas Huth
On 01/09/2020 18.29, Daniel P. Berrangé wrote: > On Sun, Aug 23, 2020 at 01:17:50PM +0200, Thomas Huth wrote: >> Now that we can use all our QEMU build containers in the gitlab-CI, >> we can also run the cross-compilation jobs there. Of course, some >> problems have to be fixed first, so this is

Re: [PATCH v4 2/7] usb/hcd-xhci: Move qemu-xhci device to hcd-xhci-pci.c

2020-09-01 Thread Philippe Mathieu-Daudé
On 8/28/20 9:19 PM, Sai Pavan Boddu wrote: > Move pci specific devices to new file. This set the environment to move all > pci specific hooks in hcd-xhci.c to hcd-xhci-pci.c. > > Signed-off-by: Sai Pavan Boddu > --- > hw/usb/Kconfig| 6 + > hw/usb/Makefile.objs | 1 + >

Re: [PATCH v2 7/7] gitlab-ci: Add cross-compiling build tests

2020-09-01 Thread Thomas Huth
On 01/09/2020 18.27, Daniel P. Berrangé wrote: > On Sun, Aug 23, 2020 at 01:17:57PM +0200, Thomas Huth wrote: >> Now that we can use all our QEMU test containers in the gitlab-CI, we can >> easily add some jobs that test cross-compilation for various architectures. >> There is just only small

Re: [PATCH v4 1/7] usb/hcd-xhci: Make dma read/writes hooks pci free

2020-09-01 Thread Philippe Mathieu-Daudé
On 8/28/20 9:19 PM, Sai Pavan Boddu wrote: > This patch starts making the hcd-xhci.c pci free, as part of this > restructuring dma read/writes are handled without passing pci object. > > Signed-off-by: Sai Pavan Boddu > --- > hw/usb/hcd-xhci.c | 24 +++- > hw/usb/hcd-xhci.h

Re: [PATCH v2 5/7] dockerfiles/debian-win64-cross: Download WHPX MinGW headers

2020-09-01 Thread Thomas Huth
On 01/09/2020 18.25, Daniel P. Berrangé wrote: > On Sun, Aug 23, 2020 at 01:17:55PM +0200, Thomas Huth wrote: >> To compile-test the WHPX accelerator, we need to download these system >> headers first (they are unfortunately not part of any released and >> packaged MinGW toolchain yet). >> >> Idea

[Bug 1893807] [NEW] Crash when launching windows qemu version from WSL2

2020-09-01 Thread Jesús Sanz del Rey
Public bug reported: Version: 5.1.0 Command line from WSL2: qemu-system-x86_64.exe -hdd /home/jesus/proyectos/RWivOS/bin/RELEASE/image.hdd -m 4G -smp 4 -machine q35 -debugcon stdio OS: Windows 10(64 bits) from WSL2 Ubuntu 18.04 The error:

Re: [PATCH v2 0/7] Run cross-compilation build tests in the gitlab-CI

2020-09-01 Thread Daniel P . Berrangé
On Sun, Aug 23, 2020 at 01:17:50PM +0200, Thomas Huth wrote: > Now that we can use all our QEMU build containers in the gitlab-CI, > we can also run the cross-compilation jobs there. Of course, some > problems have to be fixed first, so this is taken care of in the first > four patches. > > The

Re: [PATCH v2 7/7] gitlab-ci: Add cross-compiling build tests

2020-09-01 Thread Daniel P . Berrangé
On Sun, Aug 23, 2020 at 01:17:57PM +0200, Thomas Huth wrote: > Now that we can use all our QEMU test containers in the gitlab-CI, we can > easily add some jobs that test cross-compilation for various architectures. > There is just only small ugliness: Since the shared runners on gitlab.com > are

Re: [PATCH v2 6/7] configure: Allow automatic WHPX detection

2020-09-01 Thread Daniel P . Berrangé
On Sun, Aug 23, 2020 at 01:17:56PM +0200, Thomas Huth wrote: > The whpx variable is currently initialized to "no" which causes the WHPX > check to skip the detection unless the user specified --enable-whpx. > Since the detection code should be able to figure it out correctly, let's > initialized

Re: [PATCH v2 5/7] dockerfiles/debian-win64-cross: Download WHPX MinGW headers

2020-09-01 Thread Daniel P . Berrangé
On Sun, Aug 23, 2020 at 01:17:55PM +0200, Thomas Huth wrote: > To compile-test the WHPX accelerator, we need to download these system > headers first (they are unfortunately not part of any released and > packaged MinGW toolchain yet). > > Idea taken from another patch by Stefan Weil. > >

Re: [PATCH 1/2] Makefile: Add back TAGS/ctags/cscope rules

2020-09-01 Thread Greg Kurz
On Tue, 1 Sep 2020 18:04:59 +0200 Paolo Bonzini wrote: > On 01/09/20 16:59, Connor Kuehl wrote: > > On 9/1/20 9:20 AM, Greg Kurz wrote: > >> It is a bit of a pain to be forced to run configure before being able > >> to use cscope and friends. Add back the rules to build them in-tree > >> as

Re: [PATCH v2 4/7] tests/Makefile: test-replication needs CONFIG_POSIX

2020-09-01 Thread Daniel P . Berrangé
On Sun, Aug 23, 2020 at 01:17:54PM +0200, Thomas Huth wrote: > test-replication uses sigaction() and friends which are only available > on POSIX-like systems. > > Reviewed-by: Philippe Mathieu-Daudé > Message-Id: <20200804170055.2851-5-th...@redhat.com> > Signed-off-by: Thomas Huth > --- >

Re: [PATCH v2 3/7] tests/Makefile: test-image-locking needs CONFIG_POSIX

2020-09-01 Thread Daniel P . Berrangé
On Sun, Aug 23, 2020 at 01:17:53PM +0200, Thomas Huth wrote: > test-image-locking.c uses the qemu_lock_fd_test() function which is > only available on POSIX-like systems. > > Reviewed-by: John Snow > Message-Id: <20200804170055.2851-4-th...@redhat.com> > Signed-off-by: Thomas Huth > --- >

[PATCH 1/2] arm.risu: Correct VLDR/VSTR U=0 patterns

2020-09-01 Thread Peter Maydell
Correct the VLDR and VSTR patterns, which claimed to be setting U=0 but in fact left it identical to the U=1 pattern due to a cut-and-paste error. Signed-off-by: Peter Maydell --- Somehow the pre-generated test binaries I have from Alex have U=0 insns in them -- I suspect this got fixed locally

[RISU PATCH 0/2] arm.risu: two minor fixes

2020-09-01 Thread Peter Maydell
These are a couple of minor fixes to arm.risu patterns. (They're a prereq at least textually to the fp16 arm.risu change, and I should have sent them out with that but I forgot I had them in my patchstack.) thanks -- PMM Peter Maydell (2): arm.risu: Correct VLDR/VSTR U=0 patterns arm.risu:

[PATCH 2/2] arm.risu: Fix typo in VCVT_B_TT pattern name

2020-09-01 Thread Peter Maydell
Fix typo in VCVT_B_TT pattern name. Signed-off-by: Peter Maydell --- arm.risu | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arm.risu b/arm.risu index 43a72ae..048215b 100644 --- a/arm.risu +++ b/arm.risu @@ -669,7 +669,7 @@ VABS A2 cond:4 11101 d 11 vd:4 101 sz 1 1 m

Re: [PULL 00/24] Meson changes for 2020-09-01

2020-09-01 Thread Paolo Bonzini
On 01/09/20 15:19, 罗勇刚(Yonggang Luo) wrote: > Seems forgot queue my undefsym.py patch No it's just that I didn't have time to test it properly. Paolo

Re: [PATCH v2 2/7] tests/docker: Install python3-setuptools in the debian9-mxe containers

2020-09-01 Thread Daniel P . Berrangé
On Sun, Aug 23, 2020 at 01:17:52PM +0200, Thomas Huth wrote: > The python setuptools are a requirement for meson, so we need to install > this additional package now. > > Signed-off-by: Thomas Huth > --- > tests/docker/dockerfiles/debian9-mxe.docker | 2 +- > 1 file changed, 1 insertion(+), 1

  1   2   3   4   5   6   7   >