[PATCH v8 38/43] iotests: Test that qcow2's data-file is flushed

Flushing a qcow2 node must lead to the data-file node being flushed as well. Signed-off-by: Max Reitz Reviewed-by: Andrey Shinkevich Reviewed-by: Kevin Wolf --- tests/qemu-iotests/244 | 49 ++ tests/qemu-iotests/244.out | 7 ++ 2 files changed, 56

[PATCH v8 27/43] block: Use child access functions for QAPI queries

query-block, query-named-block-nodes, and query-blockstats now return any filtered child under "backing", not just bs->backing or COW children. This is so that filters do not interrupt the reported backing chain. This changes the output for iotest 184, as the throttled node now appears as a

Re: [PATCH v8 1/8] Introduce yank feature

One more question... Lukas Straub writes: > The yank feature allows to recover from hanging qemu by "yanking" > at various parts. Other qemu systems can register themselves and > multiple yank functions. Then all yank functions for selected > instances can be called by the 'yank' out-of-band

[PATCH v8 37/43] block: Leave BDS.backing_{file,format} constant

Parts of the block layer treat BDS.backing_file as if it were whatever the image header says (i.e., if it is a relative path, it is relative to the overlay), other parts treat it like a cache for bs->backing->bs->filename (relative paths are relative to the CWD). Considering

[PATCH v8 25/43] blockdev: Use CAF in external_snapshot_prepare()

This allows us to differentiate between filters and nodes with COW backing files: Filters cannot be used as overlays at all (for this function). Signed-off-by: Max Reitz Reviewed-by: Andrey Shinkevich Reviewed-by: Kevin Wolf --- blockdev.c | 7 ++- 1 file changed, 6 insertions(+), 1

[PATCH v8 33/43] qemu-img: Use child access functions

This changes iotest 204's output, because blkdebug on top of a COW node used to make qemu-img map disregard the rest of the backing chain (the backing chain was broken by the filter). With this patch, the allocation in the base image is reported correctly. Signed-off-by: Max Reitz ---

[PATCH v8 22/43] block: Use CAFs for debug breakpoints

When looking for a blkdebug node (which implements debug breakpoints), use bdrv_primary_bs() to iterate through the graph, because that is where a blkdebug node would be. Signed-off-by: Max Reitz Reviewed-by: Andrey Shinkevich Reviewed-by: Kevin Wolf --- block.c | 16 +++- 1 file

Re: [PULL 0/8] Linux user for 5.2 patches

Le 01/09/2020 à 15:54, Filip Bozuta a écrit : > > On 1.9.20. 15:06, Peter Maydell wrote: >> On Mon, 31 Aug 2020 at 12:08, Laurent Vivier wrote: >>> The following changes since commit >>> 39335fab59e11cfda9b7cf63929825db2dd3a3e0: >>> >>>    Merge remote-tracking branch >>>

Re: [PATCH 01/13] fuzz: use qemu_get_exec_dir

On 200901 0220, Paolo Bonzini wrote: > Make things consistent with how softmmu/vl.c uses os_find_datadir. > Initializing the path to the executables will also be needed for > get_relocatable_path to work. > > Signed-off-by: Paolo Bonzini > --- > tests/qtest/fuzz/fuzz.c | 3 ++- > 1 file

[PATCH v8 30/43] backup: Deal with filters

Signed-off-by: Max Reitz Reviewed-by: Kevin Wolf --- block/backup-top.c | 2 +- block/backup.c | 9 + blockdev.c | 19 +++ 3 files changed, 21 insertions(+), 9 deletions(-) diff --git a/block/backup-top.c b/block/backup-top.c index af2f20f346..430d1be068

[PATCH v8 21/43] block/snapshot: Fix fallback

If the top node's driver does not provide snapshot functionality and we want to fall back to a node down the chain, we need to snapshot all non-COW children. For simplicity's sake, just do not fall back if there is more than one such child. Furthermore, we really only can fall back to bs->file

[PATCH v8 42/43] iotests: Add test for commit in sub directory

Add a test for committing an overlay in a sub directory to one of the images in its backing chain, using both relative and absolute filenames. Signed-off-by: Max Reitz --- tests/qemu-iotests/020 | 44 ++ tests/qemu-iotests/020.out | 10 + 2 files

[PATCH v8 26/43] block: Report data child for query-blockstats

It makes no sense to report the block stats of a purely metadata-storing child in query-blockstats. So if the primary child does not have any data, try to find a unique data-storing child. Signed-off-by: Max Reitz Reviewed-by: Andrey Shinkevich Reviewed-by: Kevin Wolf --- block/qapi.c | 31

[PATCH v8 40/43] iotests: Add filter commit test cases

This patch adds some tests on how commit copes with filter nodes. Signed-off-by: Max Reitz --- tests/qemu-iotests/040 | 177 + tests/qemu-iotests/040.out | 4 +- 2 files changed, 179 insertions(+), 2 deletions(-) diff --git a/tests/qemu-iotests/040

[PATCH v8 41/43] iotests: Add filter mirror test cases

This patch adds some test cases how mirroring relates to filters. One of them tests what happens when you mirror off a filtered COW node, two others use the mirror filter node as basically our only example of an implicitly created filter node so far (besides the commit filter). Signed-off-by:

[PATCH v8 20/43] block: Use CAF in bdrv_co_rw_vmstate()

If a node whose driver does not provide VM state functions has a metadata child, the VM state should probably go there; if it is a filter, the VM state should probably go there. It follows that we should generally go down to the primary child. Signed-off-by: Max Reitz Reviewed-by: Vladimir

[PATCH v8 39/43] iotests: Let complete_and_wait() work with commit

complete_and_wait() and wait_ready() currently only work for mirror jobs. Let them work for active commit jobs, too. Signed-off-by: Max Reitz Reviewed-by: Andrey Shinkevich Reviewed-by: Kevin Wolf --- tests/qemu-iotests/iotests.py | 10 +++--- 1 file changed, 7 insertions(+), 3

[PATCH v8 19/43] block: Use CAFs in bdrv_refresh_filename()

bdrv_refresh_filename() and the kind of related bdrv_dirname() should look to the primary child when they wish to copy the underlying file's filename. Signed-off-by: Max Reitz Reviewed-by: Kevin Wolf --- block.c | 29 + 1 file changed, 21 insertions(+), 8

[PATCH v8 24/43] block/null: Implement bdrv_get_allocated_file_size

It is trivial, so we might as well do it. Remove _filter_actual_image_size from iotest 184, so we get to see the result in its reference output. Signed-off-by: Max Reitz --- block/null.c | 7 +++ tests/qemu-iotests/153.out | 2 +- tests/qemu-iotests/184 | 3 +--

[PATCH v8 35/43] blockdev: Fix active commit choice

We have to perform an active commit whenever the top node has a parent that has taken the WRITE permission on it. This means that block-commit's @backing-file parameter is longer allowed for such nodes, and that users will have to issue a block-job-complete command. Neither should pose a problem

[PATCH v8 32/43] nbd: Use CAF when looking for dirty bitmap

When looking for a dirty bitmap to share, we should handle filters by just including them in the search (so they do not break backing chains). Signed-off-by: Max Reitz Reviewed-by: Andrey Shinkevich Reviewed-by: Kevin Wolf --- nbd/server.c | 6 +++--- 1 file changed, 3 insertions(+), 3

[PATCH v8 31/43] commit: Deal with filters

This includes some permission limiting (for example, we only need to take the RESIZE permission if the base is smaller than the top). Signed-off-by: Max Reitz --- block/block-backend.c | 7 ++- block/commit.c | 94 +-

[PATCH v8 23/43] block: Improve get_allocated_file_size's default

There are two practical problems with bdrv_get_allocated_file_size()'s default right now: (1) For drivers with children, we should generally sum all their sizes instead of just passing the request through to bs->file. The latter is good for filters, but not so much for format drivers.

[PATCH v8 16/43] block: Flush all children in generic code

If the driver does not support .bdrv_co_flush() so bdrv_co_flush() itself has to flush the children of the given node, it should not flush just bs->file->bs, but in fact all children that might have been written to (judging from the permissions taken on them). This is a bug fix for qcow2 images

[PATCH v8 14/43] block: Use bdrv_cow_child() in bdrv_co_truncate()

The condition modified here is not about potentially filtered children, but only about COW sources (i.e. traditional backing files). Signed-off-by: Max Reitz Reviewed-by: Andrey Shinkevich Reviewed-by: Kevin Wolf --- block/io.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-)

[PATCH v8 29/43] mirror: Deal with filters

This includes some permission limiting (for example, we only need to take the RESIZE permission for active commits where the base is smaller than the top). base_overlay is introduced so we can query bdrv_is_allocated_above() on it - we cannot do that with base itself, because a filter's

[PATCH v8 12/43] stream: Deal with filters

Because of the (not so recent anymore) changes that make the stream job independent of the base node and instead track the node above it, we have to split that "bottom" node into two cases: The bottom COW node, and the node directly above the base node (which may be an R/W filter or the bottom COW

[PATCH v8 17/43] vmdk: Drop vmdk_co_flush()

Before HEAD^, we needed this because bdrv_co_flush() by itself would only flush bs->file. With HEAD^, bdrv_co_flush() will flush all children on which a WRITE or WRITE_UNCHANGED permission has been taken. Thus, vmdk no longer needs to do it itself. Signed-off-by: Max Reitz Reviewed-by: Kevin

[PATCH v8 18/43] block: Iterate over children in refresh_limits

Instead of looking at just bs->file and bs->backing, we should look at all children that could end up receiving forwarded requests. Signed-off-by: Max Reitz Reviewed-by: Kevin Wolf --- block/io.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff

[PATCH v8 15/43] block: Re-evaluate backing file handling in reopen

Reopening a node's backing child needs a bit of special handling because the "backing" child has different defaults than all other children (among other things). Adding filter support here is a bit more difficult than just using the child access functions. In fact, we often have to directly use

[PATCH v8 09/43] copy-on-read: Support compressed writes

Signed-off-by: Max Reitz Reviewed-by: Andrey Shinkevich Reviewed-by: Kevin Wolf --- block/copy-on-read.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/block/copy-on-read.c b/block/copy-on-read.c index a6e3c74a68..a6a864f147 100644 --- a/block/copy-on-read.c +++

[PATCH v8 07/43] block: Add bdrv_supports_compressed_writes()

Filters cannot compress data themselves but they have to implement .bdrv_co_pwritev_compressed() still (or they cannot forward compressed writes). Therefore, checking whether bs->drv->bdrv_co_pwritev_compressed is non-NULL is not sufficient to know whether the node can actually handle compressed

[PATCH v8 13/43] block: Use CAFs when working with backing chains

Use child access functions when iterating through backing chains so filters do not break the chain. In addition, bdrv_find_overlay() will now always return the actual overlay; that is, it will never return a filter node but only one with a COW backing file (there may be filter nodes between that

[PATCH v8 05/43] block: Include filters when freezing backing chain

In order to make filters work in backing chains, the associated functions must be able to deal with them and freeze both COW and filter child links. While at it, add some comments that note which functions require their caller to ensure that a given child link is not frozen, and how the callers

[PATCH v8 10/43] block: Use bdrv_filter_(bs|child) where obvious

Places that use patterns like if (bs->drv->is_filter && bs->file) { ... something about bs->file->bs ... } should be BlockDriverState *filtered = bdrv_filter_bs(bs); if (filtered) { ... something about @filtered ... } instead. Signed-off-by: Max Reitz

[RFC v8 4/5] intel_iommu: Do not notify regular iotlb to device-iotlb notifiers

This improves performance in case of netperf with vhost-net: * TCP_STREAM: From 1923.6Mbit/s to 2175.13Mbit/s (13%) * TCP_RR: From 8464.73 trans/s to 8932.70 trans/s (5.5%) * UDP_RR: From 8562.08 trans/s to 9005.62/s (5.1%) * UDP_STREAM: No change observed (insignificant 0.1% improvement)

[PATCH v8 06/43] block: Drop bdrv_is_encrypted()

The original purpose of bdrv_is_encrypted() was to inquire whether a BDS can be used without the user entering a password or not. It has not been used for that purpose for quite some time. Actually, it is not even fit for that purpose, because to answer that question, it would have recursively

[PATCH v8 08/43] throttle: Support compressed writes

Signed-off-by: Max Reitz Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Andrey Shinkevich Reviewed-by: Kevin Wolf --- block/throttle.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/block/throttle.c b/block/throttle.c index 1c1ac57bee..b21ee42d98 100644 ---

[PATCH v8 02/43] block: Add chain helper functions

Add some helper functions for skipping filters in a chain of block nodes. Signed-off-by: Max Reitz --- include/block/block_int.h | 3 ++ block.c | 62 +++ 2 files changed, 65 insertions(+) diff --git a/include/block/block_int.h

[PATCH v8 04/43] block: bdrv_set_backing_hd() is about bs->backing

bdrv_set_backing_hd() is a function that explicitly cares about the bs->backing child. Highlight that in its description and use child_bs(bs->backing) instead of backing_bs(bs) to make it more obvious. Signed-off-by: Max Reitz Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Andrey

[RFC v8 2/5] memory: Add IOMMUTLBEvent

This way we can tell between regulars IOMMURLBEntries (entry of IOMMU hardware) and notifications. In the notifications, we set explicitly if it is a MAPs or an UNMAP, instead of trusting in entry permissions to differenciate them. Signed-off-by: Eugenio Pérez --- hw/arm/smmu-common.c | 13

[PATCH v8 03/43] block: bdrv_cow_child() for bdrv_has_zero_init()

bdrv_has_zero_init() should use bdrv_cow_child() if it wants to check whether the given BDS has a COW backing file. Signed-off-by: Max Reitz Reviewed-by: Andrey Shinkevich Reviewed-by: Kevin Wolf --- block.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block.c b/block.c

Re: [PATCH v3 7/7] migration: introduce snapshot-{save, load, delete} QMP commands

Daniel P. Berrangé writes: > savevm, loadvm and delvm are some of the few HMP commands that have never > been converted to use QMP. The primary reason for this lack of conversion > is that they block execution of the thread for as long as they run. Nope. The primary reason is that the HMP

[PATCH v8 11/43] block: Use CAFs in block status functions

Use the child access functions in the block status inquiry functions as appropriate. Signed-off-by: Max Reitz --- block/io.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/block/io.c b/block/io.c index 01e3477a77..4ee8fe5465 100644 --- a/block/io.c +++

[RFC v8 0/5] memory: Delete assertion in memory_region_unregister_iommu_notifier

I am able to hit this assertion when a Red Hat 7 guest virtio_net device raises an "Invalidation" of all the TLB entries. This happens in the guest's startup if 'intel_iommu=on' argument is passed to the guest kernel and right IOMMU/ATS devices are declared in qemu's command line. Command line:

[PATCH v8 01/43] block: Add child access functions

There are BDS children that the general block layer code can access, namely bs->file and bs->backing. Since the introduction of filters and external data files, their meaning is not quite clear. bs->backing can be a COW source, or it can be a filtered child; bs->file can be a filtered child, it

Re: [RFC PATCH v3 33/34] Hexagon (tests/tcg/hexagon) TCG tests

On Fri, 28 Aug 2020 20:05:44 -0700 Richard Henderson wrote: > Could you please work with Alex Bennee to set up a > tests/docker/dockerfile/ script containing the cross-compiler from > the Qualcomm SDK? That way these tests can be run automatically. > > Compare debian-xtensa-cross.docker, which

Re: [PULL 00/44] Trivial branch for 5.2 patches

mentation (2020-09-01 12:09:30 +0200) > > ---- > Pull request trivial patches 20200901 > > > > Chen Qun (10): > hw/arm/virt-acpi-build:Remove dead assignment in build_madt() > hw/arm/omap1:

[PATCH v8 00/43] block: Deal with filters

v6: https://lists.nongnu.org/archive/html/qemu-devel/2019-08/msg01715.html v7: https://lists.nongnu.org/archive/html/qemu-block/2020-06/msg01357.html Branch: https://github.com/XanClic/qemu.git child-access-functions-v8 Branch: https://git.xanclic.moe/XanClic/qemu.git child-access-functions-v8

[RFC v8 1/5] memory: Rename memory_region_notify_one to memory_region_notify_iommu_one

Previous name didn't reflect the iommu operation. Signed-off-by: Eugenio Pérez --- hw/arm/smmu-common.c | 2 +- hw/arm/smmuv3.c | 2 +- hw/i386/intel_iommu.c | 4 ++-- include/exec/memory.h | 6 +++--- softmmu/memory.c | 6 +++--- 5 files changed, 10 insertions(+), 10 deletions(-)

[PATCH 2/2] Makefile: Fix in-tree clean/distclean

Doing 'make clean' or 'make distclean' in a freshly cloned tree results in: make: *** No rule to make target 'ninja-clean', needed by 'clean'. Stop. Make the fallback rules global. While here, change the ninjatool recipe to always have a zero exit status and thus prevent make to emit a warning.

[PATCH 0/2] Makefile: A few post-meson-conversion fixes

The meson conversion broke the ability to use cscope, etags and ctags without running configure beforehand, which is a bit painful. This series restore the previous behavior. --- Greg Kurz (2): Makefile: Add back TAGS/ctags/cscope rules Makefile: Fix in-tree clean/distclean

[RFC v8 3/5] memory: Add IOMMU_DEVIOTLB_UNMAP IOMMUTLBNotificationType

Adapt intel and vhost to use this new notification type Signed-off-by: Eugenio Pérez --- hw/i386/intel_iommu.c | 2 +- hw/virtio/vhost.c | 2 +- include/exec/memory.h | 2 ++ 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c index

Re: [PULL 0/5] Ui 20200831 patches

Hi, > Generating ar with a custom command > cp: '../../pc-bios/keymaps/ar' and 'pc-bios/keymaps/ar' are the same file Hmm, strange. No failures in gitlab ci: https://gitlab.com/kraxel/qemu/-/pipelines/183769485 Any chance this is an old build tree? Specifically created before commit

[PULL 40/44] usb/bus: Remove dead assignment in usb_get_fw_dev_path()

From: Chen Qun Clang static code analyzer show warning: qemu/hw/usb/bus.c:615:13: warning: Value stored to 'pos' is never read pos += snprintf(fw_path + pos, fw_len - pos, "%s@%lx", Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Markus Armbruster Reviewed-by: Gerd

[PULL 42/44] hw/display/vga:Remove redundant statement in vga_draw_graphic()

From: Chen Qun Clang static code analyzer show warning: hw/display/vga.c:1677:9: warning: Value stored to 'update' is never read update = full_update; ^~~~ Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Gerd Hoffmann Reviewed-by: Li Qiang

[RFC v8 5/5] memory: Skip bad range assertion if notifier is DEVIOTLB type

Signed-off-by: Eugenio Pérez --- softmmu/memory.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/softmmu/memory.c b/softmmu/memory.c index 09b3443eac..3ee99b4dc0 100644 --- a/softmmu/memory.c +++ b/softmmu/memory.c @@ -1895,6 +1895,7 @@ void

Re: [PATCH v2] cirrus: handle wraparound in cirrus_invalidate_region

Gerd Hoffmann 于2020年9月1日周二 下午10:12写道： > > Code simply asserts that there is no wraparound instead of handling > it properly. The assert() can be triggered by the guest (must be > privilidged inside the guest though). Fix it. > > Buglink: https://bugs.launchpad.net/qemu/+bug/1880189 > Cc: Li

[PULL 38/44] hw/net/virtio-net:Remove redundant statement in virtio_net_rsc_tcp_ctrl_check()

From: Chen Qun Clang static code analyzer show warning: hw/net/virtio-net.c:2077:5: warning: Value stored to 'tcp_flag' is never read tcp_flag &= VIRTIO_NET_TCP_FLAG; ^ ~~~ The 'VIRTIO_NET_TCP_FLAG' is '0x3F'. The last ‘tcp_flag’ assignment statement is the

[PULL 41/44] hw/intc: fix default registers value in exynos4210_combiner_read()

From: Chen Qun Clang static code analyzer show warning: hw/intc/exynos4210_combiner.c:231:9: warning: Value stored to 'val' is never read val = s->reg_set[offset >> 2]; The default register return value should be return 'val'. Reported-by: Euler Robot Signed-off-by: Chen Qun

Re: [PULL 0/1] tricore queue

are available in the Git repository at: > > https://github.com/bkoppelmann/qemu.git tags/pull-tricore-20200901 > > for you to fetch changes up to 2c15af48abb71b3cddadd63c5bb416b250f53fef: > > tricore: added triboard

[PATCH 1/2] Makefile: Add back TAGS/ctags/cscope rules

It is a bit of a pain to be forced to run configure before being able to use cscope and friends. Add back the rules to build them in-tree as before commit a56650518f5b. Fixes: a56650518f5b ("configure: integrate Meson in the build system") Signed-off-by: Greg Kurz --- Makefile | 17

[PULL 39/44] vfio/platform: Remove dead assignment in vfio_intp_interrupt()

From: Chen Qun Clang static code analyzer show warning: hw/vfio/platform.c:239:9: warning: Value stored to 'ret' is never read ret = event_notifier_test_and_clear(intp->interrupt); ^ ~~ Reported-by: Euler Robot Signed-off-by: Chen

Re: [PATCH v2 1/2] crypto: fix build with gcrypt enabled

Daniel P. Berrangé writes: > If nettle is disabled and gcrypt enabled, the compiler and linker flags > needed for gcrypt are not passed. > > Gnutls was also not added as a dependancy when gcrypt is enabled. > > Attempting to add the library dependencies at the same time as the > source

[PULL 33/44] hw/arm/virt-acpi-build:Remove dead assignment in build_madt()

From: Chen Qun Clang static code analyzer show warning: hw/arm/virt-acpi-build.c:641:5: warning: Value stored to 'madt' is never read madt = acpi_data_push(table_data, sizeof *madt); ^ Reported-by: Euler Robot Signed-off-by: Chen Qun

Re: [PATCH] cirrus: handle wraparound in cirrus_invalidate_region

On Tue, Sep 01, 2020 at 03:37:17PM +0800, Li Qiang wrote: > Gerd Hoffmann 于2020年9月1日周二 下午3:16写道： > > > > Hi, > > > > > +/* wraparound */ > > > +memory_region_set_dirty(>vga.vram, off_cur, > > > s->cirrus_addr_mask - off_cur); > > > > > So the len is

[PULL 35/44] target/arm/translate-a64:Remove dead assignment in handle_scalar_simd_shli()

From: Chen Qun Clang static code analyzer show warning: target/arm/translate-a64.c:8635:14: warning: Value stored to 'tcg_rn' during its initialization is never read TCGv_i64 tcg_rn = new_tmp_a64(s); ^~ ~~ target/arm/translate-a64.c:8636:14: warning: Value

[PULL 37/44] hw/virtio/vhost-user:Remove dead assignment in scrub_shadow_regions()

From: Chen Qun Clang static code analyzer show warning: hw/virtio/vhost-user.c:606:9: warning: Value stored to 'mr' is never read mr = vhost_user_get_mr_data(reg->userspace_addr, , ); ^~ Reported-by: Euler Robot

[PULL 30/44] hw/net/xilinx_axienet: Remove unused code

From: Philippe Mathieu-Daudé Most of the MDIOBus fields are unused. The ADVERTISE_10HALF definition is unused. Remove unused code. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Reviewed-by: Edgar E. Iglesias Message-Id: <20200814133007.16850-1-f4...@amsat.org>

[PULL 36/44] target/arm/translate-a64:Remove redundant statement in disas_simd_two_reg_misc_fp16()

From: Chen Qun Clang static code analyzer show warning: target/arm/translate-a64.c:13007:5: warning: Value stored to 'rd' is never read rd = extract32(insn, 0, 5); ^~ target/arm/translate-a64.c:13008:5: warning: Value stored to 'rn' is never read rn =

[PULL 43/44] main-loop: Fix comment

From: Stefan Weil Signed-off-by: Stefan Weil Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20200827175520.32355-1...@weilnetz.de> Signed-off-by: Laurent Vivier --- include/qemu/main-loop.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/qemu/main-loop.h

[PULL 31/44] util/vfio-helpers: Unify trace-events size format

From: Philippe Mathieu-Daudé Some 'qemu_vfio_*' trace events sizes are displayed using decimal notation, other using hexadecimal notation: qemu_vfio_ram_block_added s 0xf2448d90 host 0x5bc0 size 0x400 qemu_vfio_dma_map s 0xf2448d90 host 0x5bc0 size 67108864

[PULL 09/44] target/cris: Remove superfluous breaks

From: Liao Pingfang Remove superfluous breaks, as there is a "return" before them. Signed-off-by: Liao Pingfang Signed-off-by: Yi Wang Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Message-Id: <1594631150-36801-1-git-send-email-wang.y...@zte.com.cn> Signed-off-by: Laurent

[PULL 44/44] docs/system: Fix grammar in documentation

From: Stefan Weil Signed-off-by: Stefan Weil Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20200827173051.31050-1...@weilnetz.de> Signed-off-by: Laurent Vivier --- docs/system/build-platforms.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

[PULL 06/44] block/vmdk: Remove superfluous breaks

From: Liao Pingfang Remove superfluous breaks, as there is a "return" before them. Signed-off-by: Liao Pingfang Signed-off-by: Yi Wang Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Message-Id: <1594631107-36574-1-git-send-email-wang.y...@zte.com.cn> Signed-off-by: Laurent

[PULL 34/44] hw/arm/omap1:Remove redundant statement in omap_clkdsp_read()

From: Chen Qun Clang static code analyzer show warning: hw/arm/omap1.c:1760:15: warning: Value stored to 'cpu' during its initialization is never read CPUState *cpu = CPU(s->cpu); ^~~ ~~~ Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Peter Maydell

[PULL 29/44] hw/scsi/scsi-disk: Replace magic '512' value by BDRV_SECTOR_SIZE

From: Philippe Mathieu-Daudé Use self-explicit definitions instead of magic '512' value. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Kevin Wolf Reviewed-by: Li Qiang Reviewed-by: Richard Henderson Reviewed-by: Stefano Garzarella Message-Id: <20200814082841.27000-8-f4...@amsat.org>

[PULL 25/44] hw/ide/core: Trivial typo fix

From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Kevin Wolf Reviewed-by: Li Qiang Reviewed-by: Richard Henderson Reviewed-by: Stefano Garzarella Message-Id: <20200814082841.27000-3-f4...@amsat.org> Signed-off-by: Laurent Vivier --- hw/ide/core.c | 2 +- 1

[PULL 22/44] util/vfio-helpers: Fix typo in description

From: Philippe Mathieu-Daudé Remove the second 'and' introduced in commit 418026ca43 ("util: Introduce vfio helpers"). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Li Qiang Reviewed-by: Peter Maydell Message-Id: <20200811151643.21293-4-phi...@redhat.com> Signed-off-by: Laurent Vivier

[PULL 05/44] vnc: Remove the superfluous break

From: Liao Pingfang Remove the superfluous break, as there is a "return" before. Signed-off-by: Liao Pingfang a Signed-off-by: Yi Wang Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: Juan Quintela Message-Id: <1594631086-36509-1-git-send-email-wang.y...@zte.com.cn>

[PULL 27/44] hw/ide/atapi: Replace magic '512' value by BDRV_SECTOR_SIZE

From: Philippe Mathieu-Daudé Use self-explicit definitions instead of magic '512' value. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Li Qiang Reviewed-by: Richard Henderson Reviewed-by: Stefano Garzarella Message-Id: <20200814082841.27000-6-f4...@amsat.org> Signed-off-by: Laurent

[PULL 28/44] hw/ide/pci: Replace magic '512' value by BDRV_SECTOR_SIZE

From: Philippe Mathieu-Daudé Use self-explicit definitions instead of magic '512' value. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Li Qiang Reviewed-by: Richard Henderson Reviewed-by: Stefano Garzarella Message-Id: <20200814082841.27000-7-f4...@amsat.org> Signed-off-by: Laurent

[PULL 24/44] docs/system/target-avr: Improve the AVR docs and add to MAINTAINERS

From: Thomas Huth The examples look nicer when using "::" code blocks. Also mention that "-d in_asm" only outputs instructions that have not been translated by the JIT layer yet. And while we're at it, also add the AVR doc file to the MAINTAINERS file. Signed-off-by: Thomas Huth Reviewed-by:

[PULL 26/44] hw/ide/ahci: Replace magic '512' value by BDRV_SECTOR_SIZE

From: Philippe Mathieu-Daudé Use self-explicit definitions instead of magic '512' value. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Li Qiang Reviewed-by: Richard Henderson Reviewed-by: Stefano Garzarella Message-Id: <20200814082841.27000-5-f4...@amsat.org> Signed-off-by: Laurent

[PULL 21/44] util/qemu-timer: Fix typo in description

From: Philippe Mathieu-Daudé Remove the second 'and' introduced in commit e81f86790f ("qemu-timer: avoid checkpoints for virtual clock timers in external subsystems"). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Li Qiang Reviewed-by: Peter Maydell Message-Id:

[PULL 07/44] hw: Remove superfluous breaks

From: Liao Pingfang Remove superfluous breaks, as there is a "return" before them. Signed-off-by: Liao Pingfang Signed-off-by: Yi Wang Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Message-Id: <1594631126-36631-1-git-send-email-wang.y...@zte.com.cn> Signed-off-by: Laurent

[PULL 32/44] linux-user: Add strace support for printing OFD fcntl operations

From: Mike Gelfand Signed-off-by: Mike Gelfand Reviewed-by: Laurent Vivier Message-Id: <20200830092242.31506-1-mike...@mikedld.com> Signed-off-by: Laurent Vivier --- linux-user/strace.c | 12 1 file changed, 12 insertions(+) diff --git a/linux-user/strace.c

[PULL 17/44] Revert "mailmap: Update philmd email address"

From: Philippe Mathieu-Daudé This mailmap entry does not work as I expected. I am receiving emails related to my hobbyist contributions in my work mailbox and I get distracted :) Remove the entry to keep things separated. This reverts commit 289371239153b24cb7bd96b6948c6b40b4627a9b.

[PULL 19/44] .mailmap: Update Paul Burton email address

From: Philippe Mathieu-Daudé Following the Linux kernel equivalent patch posted on linux-m...@vger.kernel.org [*], update Paul Burton email address to avoid emails bouncing. [*] 'MAINTAINERS: Use @kernel.org address for Paul Burton' https://lore.kernel.org/patchwork/patch/1140341/ Cc: Paul

[PULL 14/44] qemu-options.hx: Fix typo for netdev documentation

From: Tianjia Zhang This patch fixes the netdev document description typo in qemu-option.hx. Signed-off-by: Tianjia Zhang Reviewed-by: Thomas Huth Reviewed-by: Li Qiang Reviewed-by: Michael S. Tsirkin Message-Id: <20200727045925.29375-1-tianjia.zh...@linux.alibaba.com> Signed-off-by:

[PULL 02/44] target/arm/kvm: Remove superfluous break

From: Liao Pingfang Remove superfluous break. Signed-off-by: Liao Pingfang Signed-off-by: Yi Wang Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Message-Id: <1594630986-36148-1-git-send-email-wang.y...@zte.com.cn> Signed-off-by: Laurent Vivier --- target/arm/kvm64.c | 1 - 1

[PULL 11/44] hw/i386/kvm/ioapic.c: fix typo in error message

From: Kenta Ishiguro Fix a typo in an error message for KVM_SET_IRQCHIP ioctl: "KVM_GET_IRQCHIP" should be "KVM_SET_IRQCHIP". Fixes: a39c1d47ac ("kvm: x86: Add user space part for in-kernel IOAPIC") Signed-off-by: Kenta Ishiguro Reviewed-by: Stefano Garzarella Reviewed-by: Philippe

[PULL 08/44] target/sh4: Remove superfluous breaks

From: Liao Pingfang Remove superfluous breaks, as there is a "return" before them. Signed-off-by: Liao Pingfang Signed-off-by: Yi Wang Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Message-Id: <1594631142-36745-1-git-send-email-wang.y...@zte.com.cn> Signed-off-by: Laurent

[PULL 23/44] mailmap: Add entry for Greg Kurz

From: Greg Kurz I had stopped using gk...@linux.vnet.ibm.com a while back already but this email address was shutdown last June when I quit IBM. It's about time to map it to gr...@kaod.org. Signed-off-by: Greg Kurz Reviewed-by: Philippe Mathieu-Daudé Message-Id:

[PULL 20/44] hw/i2c: Fix typo in description

From: Philippe Mathieu-Daudé Remove the second 'and' introduced in commit 73d5f22ecb ("hw/i2c: Document the I2C qdev helpers"). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Corey Minyard Reviewed-by: Li Qiang Reviewed-by: Peter Maydell Message-Id:

[PULL 16/44] hw/core/sysbus: Assert memory region index is in range

From: Philippe Mathieu-Daudé Devices incorrectly modelled might use invalid index while calling sysbus_mmio_get_region(), leading to OOB access. Help developers by asserting the index is in range. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id:

[PULL 13/44] stubs/cmos: Use correct include

From: Philippe Mathieu-Daudé cmos_get_fd_drive_type() is declared in "hw/block/fdc.h". This currently works because "hw/i386/pc.h" happens to include it. Simplify including the correct header. Fixes: 2055dbc1c9 ("acpi: move aml builder code for floppy device") Signed-off-by: Philippe

[PULL 18/44] docs: Fix broken links

From: Han Han Signed-off-by: Han Han Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20200807101736.3544506-1-h...@redhat.com> Signed-off-by: Laurent Vivier --- docs/amd-memory-encryption.txt | 4 ++-- docs/pvrdma.txt| 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)

[PULL 04/44] scsi: Remove superfluous breaks

From: Liao Pingfang Remove superfluous breaks, as there is a "return" before them. Signed-off-by: Liao Pingfang Signed-off-by: Yi Wang Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Message-Id: <1594631062-36341-1-git-send-email-wang.y...@zte.com.cn> Signed-off-by: Laurent

[PATCH v2] cirrus: handle wraparound in cirrus_invalidate_region

Code simply asserts that there is no wraparound instead of handling it properly. The assert() can be triggered by the guest (must be privilidged inside the guest though). Fix it. Buglink: https://bugs.launchpad.net/qemu/+bug/1880189 Cc: Li Qiang Reported-by: Philippe Mathieu-Daudé

<    1   2   3   4   5   6   7   >