[PATCH] iotests: Remove 030 from the auto group

2020-09-03 Thread Thomas Huth
Test 030 is still occasionally failing in the CI ... so for the time being, let's disable it in the "auto" group. We can add it back once it got more stable. Signed-off-by: Thomas Huth --- I just saw the problem here: https://cirrus-ci.com/task/5449330930745344?command=main#L6482 and Peter

RE: [PATCH 0/2][RFC] exclude ivshmem mr from vhost sections

2020-09-03 Thread Wangxin (Alexander)
Ping. > > The ivshmem me now mapped to vhost memory regions, and it reduces > the number of available memslots of vhost backend, which may > causes vhost backend memory slots limit check failure in > vhost dev init. > > Since ivshmem_bar2 not normal RAM in Guest, and it shouldn't > have vhost

Re: [PATCH 5/5] memory: Skip bad range assertion if notifier is DEVIOTLB_UNMAP type

2020-09-03 Thread Jason Wang
On 2020/9/4 上午12:14, Eugenio Pérez wrote: Device IOTLB invalidations can unmap arbitrary ranges, eiter outside of the memory region or even [0, ~0ULL] for all the space. The assertion could be hit by a guest, and rhel7 guest effectively hit it. Signed-off-by: Eugenio Pérez Reviewed-by: Peter

Re: [PATCH] configure: the error info not consistence with option.

2020-09-03 Thread Yonggang Luo
On Fri, Sep 4, 2020 at 8:18 AM Paolo Bonzini wrote: > test "$vhost_net_user" = "" && vhost_net_user=$vhost_user >> if test "$vhost_net_user" = "yes" && test "$vhost_user" = "no"; then >> - error_exit "--enable-vhost-net-user requires --enable-vhost-user" >> + error_exit "--enable-vhost-net

[PULL 27/30] spapr: introduce SpaprMachineState::numa_assoc_array

2020-09-03 Thread David Gibson
From: Daniel Henrique Barboza The next step to centralize all NUMA/associativity handling in the spapr machine is to create a 'one stop place' for all things ibm,associativity. This patch introduces numa_assoc_array, a 2 dimensional array that will store all ibm,associativity arrays of all NUMA

[PULL 20/30] sparc/sun4m: Don't set cs->halted = 0 in main_cpu_reset()

2020-09-03 Thread David Gibson
From: Thiago Jung Bauermann We rely on cpu_common_reset() to set cs->halted to 0, it's redundant to do it in main_cpu_reset(). Signed-off-by: Thiago Jung Bauermann Message-Id: <20200826055535.951207-7-bauer...@linux.ibm.com> Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: David Gibson ---

[PULL 30/30] spapr_numa: move NVLink2 associativity handling to spapr_numa.c

2020-09-03 Thread David Gibson
From: Daniel Henrique Barboza The NVLink2 GPUs works like a regular NUMA node with its own associativity values, regardless of user input. This can be handled inside spapr_numa_associativity_init(), initializing NVGPU_MAX_NUM associativity arrays that can be used by the GPUs. Signed-off-by:

[PULL 26/30] ppc/spapr_nvdimm: turn spapr_dt_nvdimm() static

2020-09-03 Thread David Gibson
From: Daniel Henrique Barboza This function is only used inside spapr_nvdimm.c. Signed-off-by: Daniel Henrique Barboza Message-Id: <20200901125645.118026-3-danielhb...@gmail.com> Signed-off-by: David Gibson --- hw/ppc/spapr_nvdimm.c | 22 +++---

[PULL 21/30] sparc/sun4m: Use start-powered-off CPUState property

2020-09-03 Thread David Gibson
From: Thiago Jung Bauermann Instead of setting CPUState::halted to 1 in secondary_cpu_reset(), use the start-powered-off property which makes cpu_common_reset() initialize it to 1 in common code. Now secondary_cpu_reset() becomes equivalent to main_cpu_reset() so rename the function to

[PULL 28/30] spapr, spapr_numa: handle vcpu ibm,associativity

2020-09-03 Thread David Gibson
From: Daniel Henrique Barboza Vcpus have an additional paramenter to be appended, vcpu_id. This also changes the size of the of property itself, which is being represented in index 0 of numa_assoc_array[cpu->node_id], and defaults to MAX_DISTANCE_REF_POINTS for all cases but vcpus. All this

[Bug 1894071] Re: qemu-i386-static ioctl return -14 (Bad Address)

2020-09-03 Thread Tony.LI
Hi,I found some problems, but I don't know if how to solve it better(I'm not really familiar with the source code). When I use ioctl() and use a structure like this: struct drm_mode_card_res { __u64 fb_id_ptr; __u64 crtc_id_ptr; __u64 connector_id_ptr; __u64

[PULL 23/30] hw/ppc/ppc4xx_pci: Use ARRAY_SIZE() instead of magic value

2020-09-03 Thread David Gibson
From: Philippe Mathieu-Daudé Replace the magic '4' by ARRAY_SIZE(s->irq) which is more explicit. Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20200901104043.91383-4-f4...@amsat.org> Reviewed-by: Richard Henderson Reviewed-by: Cédric Le Goater Signed-off-by: David Gibson ---

[PULL 15/30] target/arm: Move start-powered-off property to generic CPUState

2020-09-03 Thread David Gibson
From: Thiago Jung Bauermann There are other platforms which also have CPUs that start powered off, so generalize the start-powered-off property so that it can be used by them. Note that ARMv7MState also has a property of the same name but this patch doesn't change it because that class isn't a

[PULL 29/30] spapr, spapr_numa: move lookup-arrays handling to spapr_numa.c

2020-09-03 Thread David Gibson
From: Daniel Henrique Barboza In a similar fashion as the previous patch, let's move the handling of ibm,associativity-lookup-arrays from spapr.c to spapr_numa.c. A spapr_numa_write_assoc_lookup_arrays() helper was created, and spapr_dt_dynamic_reconfiguration_memory() can now use it to

[PULL 14/30] ppc/spapr_nvdimm: do not enable support with 'nvdimm=off'

2020-09-03 Thread David Gibson
From: Daniel Henrique Barboza The NVDIMM support for pSeries was introduced in 5.1, but it didn't contemplate the 'nvdimm' machine option that other archs uses. For every other arch, if no '-machine nvdimm(=on)' is present, it is assumed that the NVDIMM support is disabled. The user must

[PULL 24/30] hw/ppc/ppc4xx_pci: Replace pointless warning by assert()

2020-09-03 Thread David Gibson
From: Philippe Mathieu-Daudé We call pci_register_root_bus() to register 4 IRQs with the ppc4xx_pci_set_irq() handler. As it can only be called with values in the [0-4[ range, replace the pointless warning by an assert(). Signed-off-by: Philippe Mathieu-Daudé Message-Id:

[PULL 22/30] target/s390x: Use start-powered-off CPUState property

2020-09-03 Thread David Gibson
From: Thiago Jung Bauermann Instead of setting CPUState::halted to 1 in s390_cpu_initfn(), use the start-powered-off property which makes cpu_common_reset() initialize it to 1 in common code. Note that this changes behavior by setting cs->halted to 1 on reset, which didn't happen before.

[PULL 07/30] spapr/xive: Use the xics flag to check for XIVE-only IRQ backends

2020-09-03 Thread David Gibson
From: Cédric Le Goater The sPAPR machine has four different IRQ backends, each implementing the XICS or XIVE interrupt mode or both in the case of the 'dual' backend. If a machine is started in P8 compat mode, QEMU should necessarily support the XICS interrupt mode and in that case, the

[PULL 16/30] target/arm: Move setting of CPU halted state to generic code

2020-09-03 Thread David Gibson
From: Thiago Jung Bauermann This change is in a separate patch because it's not so obvious that it won't cause a regression. Suggested-by: Eduardo Habkost Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: David Gibson Reviewed-by: Greg Kurz Signed-off-by: Thiago Jung Bauermann Message-Id:

[PULL 06/30] spapr_vscsi: do not allow device hotplug

2020-09-03 Thread David Gibson
From: Daniel Henrique Barboza We do not implement hotplug in the vscsi bus, but we forgot to tell qdev about it. The result is that users are able to hotplug devices in the vscsi bus, the devices appear in qdev, but they aren't usable by the guest OS unless the user reboots it first. Setting

[PULL 19/30] mips/cps: Use start-powered-off CPUState property

2020-09-03 Thread David Gibson
From: Thiago Jung Bauermann Instead of setting CPUState::halted to 1 in main_cpu_reset(), use the start-powered-off property which makes cpu_common_reset() initialize it to 1 in common code. Also change creation of CPU object from cpu_create() to object_new() and qdev_realize_and_unref()

[PULL 13/30] spapr, spapr_nvdimm: fold NVDIMM validation in the same place

2020-09-03 Thread David Gibson
From: Daniel Henrique Barboza NVDIMM has different contraints and conditions than the regular DIMM and we'll need to add at least one more. Instead of relying on 'if (nvdimm)' conditionals in the body of spapr_memory_pre_plug(), use the existing spapr_nvdimm_validate_opts() and put all NVDIMM

[PULL 25/30] ppc: introducing spapr_numa.c NUMA code helper

2020-09-03 Thread David Gibson
From: Daniel Henrique Barboza We're going to make changes in how spapr handles all ibm,associativity* related properties to enhance our current NUMA support. At this moment we have associativity code scattered all around spapr_* files, with hardcoded values and array sizes. This makes it harder

[PULL 02/30] ppc/pnv: Fix TypeInfo of PnvLpcController abstract class

2020-09-03 Thread David Gibson
From: Cédric Le Goater It was missing the instance_size field. Cc: Eduardo Habkost Signed-off-by: Cédric Le Goater Message-Id: <20200822083920.2668930-1-...@kaod.org> Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: David Gibson --- hw/ppc/pnv_lpc.c | 3 +-- 1 file changed, 1

[PULL 17/30] ppc/spapr: Use start-powered-off CPUState property

2020-09-03 Thread David Gibson
From: Thiago Jung Bauermann PowerPC sPAPR CPUs start in the halted state, and spapr_reset_vcpu() attempts to implement this by setting CPUState::halted to 1. But that's too late for the case of hotplugged CPUs in a machine configure with 2 or more threads per core. By then, other parts of QEMU

[PULL 18/30] ppc/e500: Use start-powered-off CPUState property

2020-09-03 Thread David Gibson
From: Thiago Jung Bauermann Instead of setting CPUState::halted to 1 in ppce500_cpu_reset_sec(), use the start-powered-off property which makes cpu_common_reset() initialize it to 1 in common code. Also change creation of CPU object from cpu_create() to object_new() and qdev_realize_and_unref()

[PULL 10/30] spapr/xive: Allocate IPIs independently from the other sources

2020-09-03 Thread David Gibson
From: Cédric Le Goater The vCPU IPIs are now allocated in kvmppc_xive_cpu_connect() when the vCPU connects to the KVM device and not when all the sources are reset in kvmppc_xive_source_reset() This requires extra care for hotplug vCPUs and VM restore. Signed-off-by: Cédric Le Goater

[PULL 03/30] spapr: Remove unnecessary DRC type-checker macros

2020-09-03 Thread David Gibson
spapr_drc.h includes typechecker macro boilerplate for the many different DRC subclasses. However, most of these types don't actually have different data in their class and/or instance, making these unneeded, unused, and in fact a bad idea. Remove them. Signed-off-by: David Gibson Reviewed-by:

[PULL 11/30] spapr/xive: Allocate vCPU IPIs from the vCPU contexts

2020-09-03 Thread David Gibson
From: Cédric Le Goater When QEMU switches to the XIVE interrupt mode, it creates all the guest interrupts at the level of the KVM device. These interrupts are backed by real HW interrupts from the IPI interrupt pool of the XIVE controller. Currently, this is done from the QEMU main thread,

[PULL 12/30] ppc/spapr_nvdimm: use g_autofree in spapr_nvdimm_validate_opts()

2020-09-03 Thread David Gibson
From: Daniel Henrique Barboza Since we're using the string just once, just use g_autofree and avoid leaking it without calling g_free(). Signed-off-by: Daniel Henrique Barboza Message-Id: <20200825215749.213536-2-danielhb...@gmail.com> Signed-off-by: David Gibson --- hw/ppc/spapr_nvdimm.c |

[PULL 01/30] adb: Correct class size on TYPE_ADB_DEVICE

2020-09-03 Thread David Gibson
The TypeInfo incorrectly just lets the class size be inherited. It won't actually break things, since the class is abstract, but we should get it right. Signed-off-by: David Gibson Reviewed-by: Cédric Le Goater Reviewed-by: Philippe Mathieu-Daudé --- hw/input/adb.c | 1 + 1 file changed, 1

[PULL 08/30] spapr/xive: Modify kvm_cpu_is_enabled() interface

2020-09-03 Thread David Gibson
From: Cédric Le Goater We will use to check if a vCPU IPI has been created. Signed-off-by: Cédric Le Goater Message-Id: <20200820134547.2355743-2-...@kaod.org> Signed-off-by: David Gibson --- hw/intc/spapr_xive_kvm.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git

[PULL 09/30] spapr/xive: Use kvmppc_xive_source_reset() in post_load

2020-09-03 Thread David Gibson
From: Cédric Le Goater This is doing an extra loop but should be equivalent. It also differentiate the reset of the sources from the restore of the sources configuration. This will help in allocating the vCPU IPIs independently. Signed-off-by: Cédric Le Goater Message-Id:

[PULL 00/30] ppc-for-5.2 queue 20200904

2020-09-03 Thread David Gibson
The following changes since commit 67a7bfe560a1bba59efab085cb3430f45176d382: Merge remote-tracking branch 'remotes/huth-gitlab/tags/pull-request-2020-09-03' into staging (2020-09-03 16:58:25 +0100) are available in the Git repository at: git://github.com/dgibson/qemu.git

[PULL 05/30] ppc/pnv: Add a HIOMAP erase command

2020-09-03 Thread David Gibson
From: Cédric Le Goater The OPAL test suite runs a read-erase-write test on the PNOR : https://github.com/open-power/op-test/blob/master/testcases/OpTestPNOR.py which revealed that the IPMI HIOMAP handlers didn't support HIOMAP_C_ERASE. Implement the sector erase command by writing 0xFF in

[PULL 04/30] spapr/xive: Add a 'hv-prio' property to represent the KVM escalation priority

2020-09-03 Thread David Gibson
From: Cédric Le Goater On POWER9, the KVM XIVE device uses priority 7 for the escalation interrupts. On POWER10, the host can use a reduced set of priorities and KVM will configure the escalation priority to a lower number. In any case, the guest is allowed to use priorities in a single range :

Re: [RFC PATCH 00/12] hw: Forbid DMA write accesses to MMIO regions

2020-09-03 Thread Jason Wang
On 2020/9/4 上午3:46, Edgar E. Iglesias wrote: On Thu, Sep 03, 2020 at 07:53:33PM +0200, Paolo Bonzini wrote: On 03/09/20 17:50, Edgar E. Iglesias wrote: Hmm, I guess it would make sense to have a configurable option in KVM to isolate passthrough devices so they only can DMA to guest RAM...

Re: [RFC 0/3] try to solve the DMA to MMIO issue

2020-09-03 Thread Jason Wang
On 2020/9/3 下午7:19, Peter Maydell wrote: On Thu, 3 Sep 2020 at 12:11, Li Qiang wrote: Peter Maydell 于2020年9月3日周四 下午6:53写道: On Thu, 3 Sep 2020 at 04:55, Jason Wang wrote: I think we still need to seek a way to address this issue completely. How about adding a flag in MemoryRegionOps and

[PATCH v4 2/2] file-posix: add sg_get_max_segments that actually works with sg

2020-09-03 Thread Tom Yan
sg devices have different major/minor than their corresponding block devices. Using sysfs to get max segments never really worked for them. Fortunately the sg driver provides an ioctl to get sg_tablesize, which is apparently equivalent to max segments. Signed-off-by: Tom Yan ---

[PATCH v4 1/2] file-posix: split hdev_refresh_limits from raw_refresh_limits

2020-09-03 Thread Tom Yan
We can and should get max transfer length and max segments for all host devices / cdroms (on Linux). Also use MIN_NON_ZERO instead when we clamp max transfer length against max segments. Signed-off-by: Tom Yan --- v2: fix get_max_transfer_length for non-sg devices; also add/fix

[PATCH v3 2/2] file-posix: add sg_get_max_segments that actually works with sg

2020-09-03 Thread Tom Yan
sg devices have different major/minor than their corresponding block devices. Using sysfs to get max segments never really worked for them. Fortunately the sg driver provides an ioctl to get sg_tablesize, which is apparently equivalent to max segments. Signed-off-by: Tom Yan ---

[PATCH v3 1/2] file-posix: split hdev_refresh_limits from raw_refresh_limits

2020-09-03 Thread Tom Yan
We can and should get max transfer length and max segments for all host devices / cdroms (on Linux). Also use MIN_NON_ZERO instead when we clamp max transfer length against max segments. Signed-off-by: Tom Yan --- v2: fix get_max_transfer_length for non-sg devices; also add/fix

[PATCH RESEND v2 2/2] file-posix: add sg_get_max_segments that actually works with sg

2020-09-03 Thread Tom Yan
sg devices have different major/minor than their corresponding block devices. Using sysfs to get max segments never really worked for them. Fortunately the sg driver provides an ioctl to get sg_tablesize, which is apparently equivalent to max segments. Signed-off-by: Tom Yan ---

[PATCH RESEND v2 1/2] file-posix: split hdev_refresh_limits from raw_refresh_limits

2020-09-03 Thread Tom Yan
We can and should get max transfer length and max segments for all host devices / cdroms (on Linux). Also use MIN_NON_ZERO instead when we clamp max transfer length against max segments. Signed-off-by: Tom Yan --- v2: fix get_max_transfer_length for non-sg devices; also add/fix

[PATCH v4 3/3] spapr_numa: use spapr_numa_get_vcpu_assoc() in home_node hcall

2020-09-03 Thread Daniel Henrique Barboza
The current implementation of h_home_node_associativity hard codes the values of associativity domains of the vcpus. Let's make it consider the values already initialized in spapr->numa_assoc_array, via the spapr_numa_get_vcpu_assoc() helper. We want to set it and forget it, and for that we also

[PATCH v4 2/3] spapr_numa: create a vcpu associativity helper

2020-09-03 Thread Daniel Henrique Barboza
The work to be done in h_home_node_associativity() intersects with what is already done in spapr_numa_fixup_cpu_dt(). This patch creates a new helper, spapr_numa_get_vcpu_assoc(), to be used for both spapr_numa_fixup_cpu_dt() and h_home_node_associativity(). While we're at it, use memcpy()

Re: elf2dmp: Fix memory leak on main() error paths

2020-09-03 Thread AlexChen
Kindly ping. On 2020/8/26 18:15, AlexChen wrote: > From: AlexChen > > The 'kdgb' is allocating memory in get_kdbg(), but it is not freed > in both fill_header() and fill_context() failed branches, fix it. > > Signed-off-by: AlexChen > --- > contrib/elf2dmp/main.c | 4 ++-- > 1 file changed,

[PATCH v4 1/3] spapr: move h_home_node_associativity to spapr_numa.c

2020-09-03 Thread Daniel Henrique Barboza
The implementation of this hypercall will be modified to use spapr->numa_assoc_arrays input. Moving it to spapr_numa.c makes make more sense. Signed-off-by: Daniel Henrique Barboza --- hw/ppc/spapr_hcall.c | 40 --- hw/ppc/spapr_numa.c | 45

[PATCH v4 0/3] pseries NUMA distance rework

2020-09-03 Thread Daniel Henrique Barboza
Hi, Another spin for this rework of the existing NUMA support for pSeries, prior to incoming changes in how we calculate NUMA distance in the pseries machine. Changes here were made based on David Gibson's review of v3. This patches were rebased using David's ppc-for-5.2 tree. changes from v3:

[PATCH v2 2/2] file-posix: add sg_get_max_segments that actually works with sg

2020-09-03 Thread Tom Yan
sg devices have different major/minor than their corresponding block devices. Using sysfs to get max segments never really worked for them. Fortunately the sg driver provides an ioctl to get sg_tablesize, which is apparently equivalent to max segments. Signed-off-by: Tom Yan ---

[PATCH v2 1/2] file-posix: split hdev_refresh_limits from raw_refresh_limits

2020-09-03 Thread Tom Yan
We can and should get max transfer length and max segments for all host devices / cdroms (on Linux). Also use MIN_NON_ZERO instead when we clamp max transfer length against max segments. Signed-off-by: Tom Yan --- v2: fix get_max_transfer_length for non-sg devices; also add/fix

Re: [PATCH v2 2/2] GitLab Gating CI: initial set of jobs, documentation and scripts

2020-09-03 Thread Cleber Rosa
On Wed, Jul 29, 2020 at 11:16:29AM +0100, Stefan Hajnoczi wrote: > On Wed, Jul 08, 2020 at 10:46:57PM -0400, Cleber Rosa wrote: > > Awesome, thanks for creating this stuff! Minor suggestions: > > > diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst > > index c1ff24370b..f8dab788ea

Re: [PATCH v3 2/7] spapr, spapr_numa: handle vcpu ibm,associativity

2020-09-03 Thread Daniel Henrique Barboza
On 9/3/20 8:23 PM, David Gibson wrote: On Thu, Sep 03, 2020 at 07:06:34PM -0300, Daniel Henrique Barboza wrote: Vcpus have an additional paramenter to be appended, vcpu_id. This also changes the size of the of property itself, which is being represented in index 0 of

Re: [PATCH] configure: the error info not consistence with option.

2020-09-03 Thread Paolo Bonzini
> > test "$vhost_net_user" = "" && vhost_net_user=$vhost_user > if test "$vhost_net_user" = "yes" && test "$vhost_user" = "no"; then > - error_exit "--enable-vhost-net-user requires --enable-vhost-user" > + error_exit "--enable-vhost-net requires --enable-vhost-user" > fi > This change seems

Re: [PATCH v2 2/2] GitLab Gating CI: initial set of jobs, documentation and scripts

2020-09-03 Thread Cleber Rosa
On Thu, Jul 09, 2020 at 01:28:27PM +0200, Andrea Bolognani wrote: > On Thu, 2020-07-09 at 11:30 +0100, Daniel P. Berrangé wrote: > > On Wed, Jul 08, 2020 at 10:46:57PM -0400, Cleber Rosa wrote: > > > +- name: Installation of basic packages to build QEMU > > > + hosts: all > > > + vars_files: > >

Re: [PATCH v2 2/2] GitLab Gating CI: initial set of jobs, documentation and scripts

2020-09-03 Thread Cleber Rosa
On Thu, Jul 09, 2020 at 11:30:29AM +0100, Daniel P. Berrangé wrote: > On Wed, Jul 08, 2020 at 10:46:57PM -0400, Cleber Rosa wrote: > > This is a mapping of Peter's "remake-merge-builds" and > > "pull-buildtest" scripts, gone through some updates, adding some build > > option and removing others. >

Re: [PATCH] file-posix: split hdev_refresh_limits from raw_refresh_limits

2020-09-03 Thread Tom Yan
Oops I forgot max_transfer needs to be in bytes (and BLKSECTGET in sg has always been implemented wrongly). Will send a new version. On Fri, 4 Sep 2020 at 06:37, Tom Yan wrote: > > sg_get_max_transfer_length() and sg_get_max_segments() have nothing > to do with the sg driver or SG_IO at all.

Re: [PATCH 51/63] tpm_spapr: Rename VIO_SPAPR_VTPM to TPM_SPAPR

2020-09-03 Thread Stefan Berger
On 9/2/20 6:42 PM, Eduardo Habkost wrote: Make the type checking macro name consistent with the TYPE_* constant. Signed-off-by: Eduardo Habkost Reviewed-by: Stefan Berger --- Cc: Stefan Berger Cc: qemu-devel@nongnu.org --- hw/tpm/tpm_spapr.c | 14 +++--- 1 file changed, 7

Re: [PATCH 50/63] tpm_crb: Rename CRB to TPM_CRB

2020-09-03 Thread Stefan Berger
On 9/2/20 6:42 PM, Eduardo Habkost wrote: Make the type checking macro name consistent with the TYPE_* constant. Signed-off-by: Eduardo Habkost Reviewed-by: Stefan Berger --- Cc: Stefan Berger Cc: qemu-devel@nongnu.org --- hw/tpm/tpm_crb.c | 14 +++--- 1 file changed, 7

Re: [PATCH v3 5/7] spapr: move h_home_node_associativity to spapr_numa.c

2020-09-03 Thread David Gibson
On Thu, Sep 03, 2020 at 07:06:37PM -0300, Daniel Henrique Barboza wrote: > The implementation of this hypercall will be modified to use > spapr->numa_assoc_arrays input. Moving it to spapr_numa.c makes > make more sense. > > Signed-off-by: Daniel Henrique Barboza > --- > hw/ppc/spapr_hcall.c

Re: [PATCH v3 7/7] spapr_numa: use spapr_numa_get_vcpu_assoc() in home_node hcall

2020-09-03 Thread David Gibson
On Thu, Sep 03, 2020 at 07:06:39PM -0300, Daniel Henrique Barboza wrote: > The current implementation of h_home_node_associativity hard codes > the values of associativity domains of the vcpus. Let's make > it consider the values already initialized in spapr->numa_assoc_array, > via the

Re: [PATCH v3 2/7] spapr, spapr_numa: handle vcpu ibm,associativity

2020-09-03 Thread David Gibson
On Thu, Sep 03, 2020 at 07:06:34PM -0300, Daniel Henrique Barboza wrote: > Vcpus have an additional paramenter to be appended, vcpu_id. This > also changes the size of the of property itself, which is being > represented in index 0 of numa_assoc_array[cpu->node_id], > and defaults to

Re: [PATCH v3 0/7] pseries NUMA distance rework

2020-09-03 Thread David Gibson
On Thu, Sep 03, 2020 at 07:06:32PM -0300, Daniel Henrique Barboza wrote: > Hi, > > This spin attempts to cover all suggestions and concerns pointed > out by David Gibson in the v2 review. > > The patches were rebased with David's ppc-for-5.2 at 615ae3763144. > They can also be cloned from >

Re: [PATCH v3 6/7] spapr_numa: create a vcpu associativity helper

2020-09-03 Thread David Gibson
On Thu, Sep 03, 2020 at 07:06:38PM -0300, Daniel Henrique Barboza wrote: > The work to be done in h_home_node_associativity() intersects > with what is already done in spapr_numa_fixup_cpu_dt(). This > patch creates a new helper, spapr_numa_get_vcpu_assoc(), to > be used for both

Re: [PATCH v4 03/12] tcg: Fixes dup_const link error

2020-09-03 Thread Richard Henderson
On 9/3/20 2:19 PM, 罗勇刚(Yonggang Luo) wrote: > No, really, as I asked before: what symbol is present in tcg-op-gvec.c.obj > without this patch? > > The   tcg-op-gvec.c.obj are missing now, maybe skip this patch first? Yes, please. > Anyway have same name with function and macro is not

Re: [PATCH v2 2/2] GitLab Gating CI: initial set of jobs, documentation and scripts

2020-09-03 Thread Cleber Rosa
On Thu, Jul 09, 2020 at 12:07:32PM +0200, Philippe Mathieu-Daudé wrote: > On 7/9/20 4:46 AM, Cleber Rosa wrote: > > This is a mapping of Peter's "remake-merge-builds" and > > "pull-buildtest" scripts, gone through some updates, adding some build > > option and removing others. > > > > The jobs

[REPORT] Nightly Performance Tests - Thursday, September 3, 2020

2020-09-03 Thread Ahmed Karaman
Host CPU : Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz Host Memory : 15.49 GB Start Time (UTC) : 2020-09-03 22:30:01 End Time (UTC) : 2020-09-03 23:02:32 Execution Time : 0:32:30.542730 Status : SUCCESS Note: Changes denoted by '-' are less than 0.01%.

Re: make -i check resut for msys2

2020-09-03 Thread Yonggang Luo
On Thu, Sep 3, 2020 at 10:33 PM Thomas Huth wrote: > On 03/09/2020 11.18, 罗勇刚(Yonggang Luo) wrote: > [...] > > TESTcheck-unit: tests/test-replication.exe > > ** > > ERROR:C:/work/xemu/qemu/tests/test-replication.c:136:make_temp: > > assertion failed: (fd >= 0) > > ERROR

[PATCH] file-posix: split hdev_refresh_limits from raw_refresh_limits

2020-09-03 Thread Tom Yan
sg_get_max_transfer_length() and sg_get_max_segments() have nothing to do with the sg driver or SG_IO at all. They can be and should be used on all host devices / cdroms (on Linux). Also use MIN_NON_ZERO instead when we clamp max_sectors against max_segments. Signed-off-by: Tom Yan ---

[PATCH v3 4/7] spapr_numa: move NVLink2 associativity handling to spapr_numa.c

2020-09-03 Thread Daniel Henrique Barboza
The NVLink2 GPUs works like a regular NUMA node with its own associativity values, regardless of user input. This can be handled inside spapr_numa_associativity_init(), initializing NVGPU_MAX_NUM associativity arrays that can be used by the GPUs. Signed-off-by: Daniel Henrique Barboza ---

[PATCH v3 3/7] spapr, spapr_numa: move lookup-arrays handling to spapr_numa.c

2020-09-03 Thread Daniel Henrique Barboza
In a similar fashion as the previous patch, let's move the handling of ibm,associativity-lookup-arrays from spapr.c to spapr_numa.c. A spapr_numa_write_assoc_lookup_arrays() helper was created, and spapr_dt_dynamic_reconfiguration_memory() can now use it to advertise the lookup-arrays.

[PATCH v2 7/7] hw/net/can: Correct Kconfig dependencies after switch to meson build.

2020-09-03 Thread Pavel Pisa
The original CAN_PCI config option enables multiple SJA1000 PCI boards emulation build. These boards bridge SJA1000 into I/O or memory address space of the host CPU and depend on SJA1000 emulation. Signed-off-by: Pavel Pisa --- hw/net/Kconfig | 7 +++ 1 file changed, 3 insertions(+), 4

[PATCH v2 4/7] hw/net/can/ctucafd: Add CTU CAN FD core register definitions.

2020-09-03 Thread Pavel Pisa
From: Jan Charvat Definitions of registers and CAN FD frame message box of CTU CAN FD IP core are generated the specification in CACTUS/IP-XACT format. CTU CAN FD IP core repository https://gitlab.fel.cvut.cz/canbus/ctucanfd_ip_core The location of the CTU CAN IP core specification within

[PATCH v2] tests: Trying fixes test-replication.c on msys2.

2020-09-03 Thread Yonggang Luo
Signed-off-by: Yonggang Luo --- tests/test-replication.c | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/tests/test-replication.c b/tests/test-replication.c index 9ab3666a90..d0e06f8d77 100644 --- a/tests/test-replication.c +++ b/tests/test-replication.c @@

[PATCH v3 7/7] spapr_numa: use spapr_numa_get_vcpu_assoc() in home_node hcall

2020-09-03 Thread Daniel Henrique Barboza
The current implementation of h_home_node_associativity hard codes the values of associativity domains of the vcpus. Let's make it consider the values already initialized in spapr->numa_assoc_array, via the spapr_numa_get_vcpu_assoc() helper. We want to set it and forget it, and for that we also

Re: [RFC PATCH 11/12] hw/pci: Only allow PCI slave devices to write to direct memory

2020-09-03 Thread Paolo Bonzini
On 03/09/20 15:18, Philippe Mathieu-Daudé wrote: > As of this patch, all the non-PCI, but I plan to add a similar > check for USB on top of this series. Do you mean for memory-mapped USB host controllers? >> I'm worried that there are cases of MMIO reads that would be broken. >> They are

[PATCH v3 6/7] spapr_numa: create a vcpu associativity helper

2020-09-03 Thread Daniel Henrique Barboza
The work to be done in h_home_node_associativity() intersects with what is already done in spapr_numa_fixup_cpu_dt(). This patch creates a new helper, spapr_numa_get_vcpu_assoc(), to be used for both spapr_numa_fixup_cpu_dt() and h_home_node_associativity(). Signed-off-by: Daniel Henrique Barboza

[PATCH v3 5/7] spapr: move h_home_node_associativity to spapr_numa.c

2020-09-03 Thread Daniel Henrique Barboza
The implementation of this hypercall will be modified to use spapr->numa_assoc_arrays input. Moving it to spapr_numa.c makes make more sense. Signed-off-by: Daniel Henrique Barboza --- hw/ppc/spapr_hcall.c| 37 + hw/ppc/spapr_numa.c | 36

[PULL 1/5] cputlb: Make store_helper less fragile to compiler optimizations

2020-09-03 Thread Richard Henderson
This has no functional change. The current function structure is: inline QEMU_ALWAYSINLINE store_memop() { switch () { ... default: qemu_build_not_reached(); } } inline QEMU_ALWAYSINLINE store_helper() { ... if

[PATCH v3 1/7] spapr: introduce SpaprMachineState::numa_assoc_array

2020-09-03 Thread Daniel Henrique Barboza
The next step to centralize all NUMA/associativity handling in the spapr machine is to create a 'one stop place' for all things ibm,associativity. This patch introduces numa_assoc_array, a 2 dimensional array that will store all ibm,associativity arrays of all NUMA nodes. This array is

[PATCH v3 2/7] spapr, spapr_numa: handle vcpu ibm,associativity

2020-09-03 Thread Daniel Henrique Barboza
Vcpus have an additional paramenter to be appended, vcpu_id. This also changes the size of the of property itself, which is being represented in index 0 of numa_assoc_array[cpu->node_id], and defaults to MAX_DISTANCE_REF_POINTS for all cases but vcpus. All this logic makes more sense in

[PULL 0/5] tcg patch queue

2020-09-03 Thread Richard Henderson
The following changes since commit 3dd23a4fb8fd72d2220a90a809f213999ffe7f3a: Merge remote-tracking branch 'remotes/legoater/tags/pull-aspeed-20200901' into staging (2020-09-03 14:12:48 +0100) are available in the Git repository at: https://github.com/rth7680/qemu.git tags/pull-tcg-20200903

[PATCH v2 1/7] net/can: Initial host SocketCan support for CAN FD.

2020-09-03 Thread Pavel Pisa
From: Jan Charvat Signed-off-by: Jan Charvat Signed-off-by: Pavel Pisa Reviewed-by: Vikram Garhwal --- hw/net/can/can_sja1000.c | 2 ++ include/net/can_emu.h| 8 ++- net/can/can_socketcan.c | 47 +--- 3 files changed, 53 insertions(+), 4

[PATCH] configure: the error info not consistence with option.

2020-09-03 Thread Yonggang Luo
Signed-off-by: Yonggang Luo --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index e42d210e5f..ae63c4fd54 100755 --- a/configure +++ b/configure @@ -2545,7 +2545,7 @@ fi # vhost-user backends test "$vhost_net_user" = "" &&

[PATCH v3 0/7] pseries NUMA distance rework

2020-09-03 Thread Daniel Henrique Barboza
Hi, This spin attempts to cover all suggestions and concerns pointed out by David Gibson in the v2 review. The patches were rebased with David's ppc-for-5.2 at 615ae3763144. They can also be cloned from https://github.com/danielhb/qemu/tree/spapr_numa_v3. Changes from v2: - patches 1 and 2 from

[PULL 5/5] tcg: Implement 256-bit dup for tcg_gen_gvec_dup_mem

2020-09-03 Thread Richard Henderson
We already support duplication of 128-bit blocks. This extends that support to 256-bit blocks. This will be needed by SVE2. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- tcg/tcg-op-gvec.c | 52 --- 1 file changed, 49

[PATCH v2 0/7] CTU CAN FD core support

2020-09-03 Thread pisa
From: Pavel Pisa CTU CAN FD is an open source soft core written in VHDL. It originated in 2015 as Ondrej Ille's project at the Department of Measurement of FEE at CTU. Integration for Xilinx Zynq and Intel based SoCs is available as well as support for PCIe integration of the core. The core

QEMU | Pipeline #185547365 has failed for master | 67a7bfe5

2020-09-03 Thread GitLab via
Your pipeline has failed. Project: QEMU ( https://gitlab.com/qemu-project/qemu ) Branch: master ( https://gitlab.com/qemu-project/qemu/-/commits/master ) Commit: 67a7bfe5 ( https://gitlab.com/qemu-project/qemu/-/commit/67a7bfe560a1bba59efab085cb3430f45176d382 ) Commit Message: Merge

Re: [PATCH] riscv: sifive_test: Allow 16-bit writes to memory region

2020-09-03 Thread Michael Roth
Quoting Alistair Francis (2020-09-01 18:59:29) > On Mon, Aug 31, 2020 at 10:59 PM Nathan Chancellor > wrote: > > > > When shutting down the machine running a mainline Linux kernel, the > > following error happens: > > > > $ build/riscv64-softmmu/qemu-system-riscv64 -bios default -M virt \ > >

[PATCH v2 6/7] hw/net/can: Documentation for CTU CAN FD IP open hardware core emulation.

2020-09-03 Thread Pavel Pisa
Updated MAINTAINERS for CAN bus related emulation as well. Signed-off-by: Pavel Pisa --- MAINTAINERS | 9 docs/can.txt | 113 ++- 2 files changed, 111 insertions(+), 11 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index

[PATCH 07/77] virtio-balloon: fix free page hinting without an iothread

2020-09-03 Thread Michael Roth
From: David Hildenbrand In case we don't have an iothread, we mark the feature as abscent but still add the queue. 'free_page_bh' remains set to NULL. qemu-system-i386 \ -M microvm \ -nographic \ -device virtio-balloon-device,free-page-hint=true \ -nographic \

[PATCH 75/77] virtio-net: align RSC fields with updated virtio-net header

2020-09-03 Thread Michael Roth
From: Yuri Benditovich Removal of duplicated RSC definitions. Changing names of the fields to ones defined in the Linux header. Signed-off-by: Yuri Benditovich Signed-off-by: Jason Wang (cherry picked from commit dd3d85e89123c907be7628957457af3d03e3b85b) Conflicts:

[PATCH v2 5/7] hw/net/can: CTU CAN FD IP open hardware core emulation.

2020-09-03 Thread Pavel Pisa
From: Jan Charvat The implementation of the model of complete open-source/design/hardware CAN FD controller. The IP core project has been started and is maintained by Ondrej Ille at Czech Technical University in Prague. CTU CAN FD project pages:

[PULL 4/5] tcg: Eliminate one store for in-place 128-bit dup_mem

2020-09-03 Thread Richard Henderson
Do not store back to the exact memory from which we just loaded. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- tcg/tcg-op-gvec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tcg/tcg-op-gvec.c b/tcg/tcg-op-gvec.c index 793d4ba64c..fcc25b04e6

[PATCH 76/77] hw/arm/sbsa-ref: fix typo breaking PCIe IRQs

2020-09-03 Thread Michael Roth
From: Graeme Gregory Fixing a typo in a previous patch that translated an "i" to a 1 and therefore breaking the allocation of PCIe interrupts. This was discovered when virtio-net-pci devices ceased to function correctly. Cc: qemu-sta...@nongnu.org Fixes: 48ba18e6d3f3 ("hw/arm/sbsa-ref: Simplify

[PULL 3/5] softmmu/cpus: Only set parallel_cpus for SMP

2020-09-03 Thread Richard Henderson
Do not set parallel_cpus if there is only one cpu instantiated. This will allow tcg to use serial code to implement atomics. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- softmmu/cpus.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git

[PATCH 73/77] iotests/028: Add test for cross-base-EOF reads

2020-09-03 Thread Michael Roth
From: Max Reitz Signed-off-by: Max Reitz Message-Id: <20200728120806.265916-3-mre...@redhat.com> Reviewed-by: Vladimir Sementsov-Ogievskiy Tested-by: Vladimir Sementsov-Ogievskiy Tested-by: Claudio Fontana (cherry picked from commit ae159450e161b3e1e2c5b815d19632acd1a1) Signed-off-by:

[PATCH 06/77] nbd/server: Avoid long error message assertions CVE-2020-10761

2020-09-03 Thread Michael Roth
From: Eric Blake Ever since commit 36683283 (v2.8), the server code asserts that error strings sent to the client are well-formed per the protocol by not exceeding the maximum string length of 4096. At the time the server first started sending error messages, the assertion could not be

[PATCH v2 3/7] net/can: Add can_dlc2len and can_len2dlc for CAN FD.

2020-09-03 Thread Pavel Pisa
From: Jan Charvat Signed-off-by: Jan Charvat Signed-off-by: Pavel Pisa Reviewed-by: Vikram Garhwal --- include/net/can_emu.h | 4 net/can/can_core.c| 36 2 files changed, 40 insertions(+) diff --git a/include/net/can_emu.h

Re: [PATCH v4 03/12] tcg: Fixes dup_const link error

2020-09-03 Thread Yonggang Luo
On Fri, Sep 4, 2020 at 1:20 AM Richard Henderson < richard.hender...@linaro.org> wrote: > On 9/3/20 1:31 AM, Yonggang Luo wrote: > > Rename function dup_const to dup_const_eval for avoid confliction with > macro dup_const > > > > The link error on msys2 > > > > Linking target

  1   2   3   4   5   6   7   >