Re: [PATCH v7 11/12] migration/dirtyrate: Implement qmp_cal_dirty_rate()/qmp_get_dirty_rate() function

On 2020/9/10 22:27, Li Qiang wrote: > Chuan Zheng 于2020年9月9日周三 下午10:14写道： >> >> Implement qmp_cal_dirty_rate()/qmp_get_dirty_rate() function which could be >> called >> >> Signed-off-by: Chuan Zheng >> --- >> migration/dirtyrate.c | 62 >> +++

Re: [PATCH v7 09/12] migration/dirtyrate: Implement set_sample_page_period() and get_sample_page_period()

On 2020/9/10 21:59, Li Qiang wrote: > Chuan Zheng 于2020年9月9日周三 下午10:15写道： >> >> Implement set_sample_page_period()/get_sample_page_period() to sleep >> specific time between sample actions. >> >> Signed-off-by: Chuan Zheng >> Reviewed-by: Dr. David Alan Gilbert >> Reviewed-by: David

Re: [PATCH v7 06/12] migration/dirtyrate: Record hash results for each sampled page

On 2020/9/10 21:51, Li Qiang wrote: > Chuan Zheng 于2020年9月9日周三 下午10:14写道： >> >> Record hash results for each sampled page, crc32 is taken to calculate >> hash results for each sampled length in TARGET_PAGE_SIZE. >> >> Signed-off-by: Chuan Zheng >> Signed-off-by: YanYing Zhuang >>

Re: Moving to C11? (was Re: Redefinition of typedefs (C11 feature))

On Sat, Sep 12, 2020 at 08:45:19AM +0200, Thomas Huth wrote: > On 11/09/2020 22.06, Eduardo Habkost wrote: > > On Fri, Sep 11, 2020 at 08:06:10PM +0100, Peter Maydell wrote: > >> On Fri, 11 Sep 2020 at 19:49, Eduardo Habkost wrote: > >>> > >>> I'm wondering: do our supported build host platforms

[PATCH v3 4/6] migration/tls: extract cleanup function for common-use

multifd channel cleanup is need if multifd handshake failed, let's extract it. Signed-off-by: Chuan Zheng Signed-off-by: Yan Jin Reviewed-by: Daniel P. Berrangé --- migration/multifd.c | 34 ++ 1 file changed, 22 insertions(+), 12 deletions(-) diff --git

[PATCH v3 1/6] migration/tls: save hostname into MigrationState

hostname is need in multifd-tls, save hostname into MigrationState. Signed-off-by: Chuan Zheng Signed-off-by: Yan Jin --- migration/channel.c | 6 ++ migration/migration.c | 1 + migration/migration.h | 5 + 3 files changed, 12 insertions(+) diff --git a/migration/channel.c

[PATCH v3 6/6] migration/tls: add trace points for multifd-tls

add trace points for multifd-tls for debug. Signed-off-by: Chuan Zheng Signed-off-by: Yan Jin --- migration/multifd.c| 10 +- migration/trace-events | 4 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/migration/multifd.c b/migration/multifd.c index

[PATCH v3 2/6] migration/tls: extract migration_tls_client_create for common-use

migration_tls_client_create will be used in multifd-tls, let's extract it. Signed-off-by: Chuan Zheng Signed-off-by: Yan Jin Reviewed-by: Daniel P. Berrangé --- migration/tls.c | 26 ++ migration/tls.h | 6 ++ 2 files changed, 24 insertions(+), 8 deletions(-)

[PATCH v3 5/6] migration/tls: add support for multifd tls-handshake

Similar like migration main thread, we need to do handshake for each multifd thread. Signed-off-by: Chuan Zheng Signed-off-by: Yan Jin Reviewed-by: Daniel P. Berrangé --- migration/multifd.c | 77 +++-- 1 file changed, 75 insertions(+), 2

[PATCH v3 0/6] *** Add Multifd support for TLS migration ***

v2 -> v3: rebase patches on master v1 -> v2: fix memoryleak of MigrationState hostname add tls_hostname into MultiFDSendParams for handshake use fix function alignment squash Patch005 and Patch006 add ioc into trace-events TLS migration could easily reach bottleneck of

[PATCH v3 3/6] migration/tls: add MigrationState and tls_hostname into MultiFDSendParams

MigrationState is need for tls session build and tls hostname is need for tls handshake, add both MigrationState and tls_hostname into MultiFDSendParams. Signed-off-by: Chuan Zheng Signed-off-by: Yan Jin --- migration/multifd.c | 5 + migration/multifd.h | 4 2 files changed, 9

[Bug 1895363] Re: borland IDEs double up cursor key presses (need timing on PS2 port input)

Just found the complete conversation regarding the abovementioned patch: https://lists.nongnu.org/archive/html/qemu-devel/2009-08/msg01182.html -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1895363

[REPORT] Nightly Performance Tests - Saturday, September 12, 2020

Host CPU : Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz Host Memory : 15.49 GB Start Time (UTC) : 2020-09-12 23:30:02 End Time (UTC) : 2020-09-13 00:10:47 Execution Time : 0:40:45.297747 Status : SUCCESS Note: Changes denoted by '-' are less than 0.01%.

[Bug 1895363] Re: borland IDEs double up cursor key presses (need timing on PS2 port input)

This virtualbox bug talks about the same thing, and also mentions qemu: https://www.virtualbox.org/ticket/58 One of the people in the conversation created a patch for qemu which wasn't accepted: http://qemu.11.n7.nabble.com/PATCH-Fix-for-DOS-keyboard-problems- td114076.html ** Bug watch

Re: [PATCH v2 00/15] hw/block/nvme: Support Namespace Types and Zoned Namespace Command Set

Patchew URL: https://patchew.org/QEMU/20200912225430.1772-1-dmitry.fomic...@wdc.com/ Hi, This series seems to have some coding style problems. See output below for more information: N/A. Internal error while reading log file The full log is available at

Re: [PATCH v8 00/27] W32, W64 msys2/mingw patches

Patchew URL: https://patchew.org/QEMU/20200912224431.1428-1-luoyongg...@gmail.com/ Hi, This series seems to have some coding style problems. See output below for more information: N/A. Internal error while reading log file The full log is available at

[PATCH v2 10/15] hw/block/nvme: Support Zoned Namespace Command Set

The emulation code has been changed to advertise NVM Command Set when "zoned" device property is not set (default) and Zoned Namespace Command Set otherwise. Handlers for three new NVMe commands introduced in Zoned Namespace Command Set specification are added, namely for Zone Management Receive,

[PATCH v2 14/15] hw/block/nvme: Use zone metadata file for persistence

A ZNS drive that is emulated by this module is currently initialized with all zones Empty upon startup. However, actual ZNS SSDs save the state and condition of all zones in their internal NVRAM in the event of power loss. When such a drive is powered up again, it closes or finishes all zones that

[PATCH v2 09/15] hw/block/nvme: Define Zoned NS Command Set trace events

The Zoned Namespace Command Set / Namespace Types implementation that is being introduced in this series adds a good number of trace events. Combine all tracepoint definitions into a separate patch to make reviewing more convenient. Signed-off-by: Dmitry Fomichev --- hw/block/trace-events | 26

[PATCH v2 06/15] hw/block/nvme: Add support for Namespace Types

From: Niklas Cassel Namespace Types introduce a new command set, "I/O Command Sets", that allows the host to retrieve the command sets associated with a namespace. Introduce support for the command set and enable detection for the NVM Command Set. The new workflows for identify commands rely

[PATCH v2 12/15] hw/block/nvme: Support Zone Descriptor Extensions

Zone Descriptor Extension is a label that can be assigned to a zone. It can be set to an Empty zone and it stays assigned until the zone is reset. This commit adds a new optional module property, "zone_descr_ext_size". Its value must be a multiple of 64 bytes. If this value is non-zero, it

[PATCH v2 08/15] hw/block/nvme: Make Zoned NS Command Set definitions

Define values and structures that are needed to support Zoned Namespace Command Set (NVMe TP 4053) in PCI NVMe controller emulator. All new protocol definitions are located in include/block/nvme.h and everything added that is specific to this implementation is kept in hw/block/nvme.h. In order

[PATCH v2 00/15] hw/block/nvme: Support Namespace Types and Zoned Namespace Command Set

v1 -> v2: - Rebased on top of qemu-nvme/next branch. - Incorporated feedback from Klaus and Alistair. - Dropped "Simulate Zone Active excursions" patch. Excursion behavior may depend on the internal controller architecture and therefore be vendor-specific. - Dropped support for Zone

[PATCH v2 13/15] hw/block/nvme: Add injection of Offline/Read-Only zones

ZNS specification defines two zone conditions for the zones that no longer can function properly, possibly because of flash wear or other internal fault. It is useful to be able to "inject" a small number of such zones for testing purposes. This commit defines two optional device properties,

[PATCH v8 27/27] Revert "configure: add --ninja option"

This reverts commit 48328880fddf0145bdccc499160fb24dfabfbd41. The --ninja option doesn't need anymore because of upgrade meson to 0.55.2 At that version we can use ninjatool Signed-off-by: Yonggang Luo --- configure | 16 +--- 1 file changed, 1 insertion(+), 15 deletions(-) diff

[PATCH v2 04/15] hw/block/nvme: Introduce the Namespace Types definitions

From: Niklas Cassel Define the structures and constants required to implement Namespace Types support. Signed-off-by: Niklas Cassel Signed-off-by: Dmitry Fomichev --- hw/block/nvme.c | 2 +- hw/block/nvme.h | 3 ++ include/block/nvme.h | 74

[PATCH v2 05/15] hw/block/nvme: Define trace events related to NS Types

A few trace events are defined that are relevant to implementing Namespace Types (NVMe TP 4056). Signed-off-by: Dmitry Fomichev Reviewed-by: Klaus Jensen --- hw/block/trace-events | 10 ++ 1 file changed, 10 insertions(+) diff --git a/hw/block/trace-events b/hw/block/trace-events

[PATCH v2 15/15] hw/block/nvme: Document zoned parameters in usage text

Added brief descriptions of the new device properties that are now available to users to configure features of Zoned Namespace Command Set in the emulator. This patch is for documentation only, no functionality change. Signed-off-by: Dmitry Fomichev --- hw/block/nvme.c | 43

[PATCH v2 02/15] hw/block/nvme: Report actual LBA data shift in LBAF

Calculate the data shift value to report based on the set value of logical_block_size device property. In the process, use a local variable to calculate the LBA format index instead of the hardcoded value 0. This makes the code more readable and it will make it easier to add support for multiple

[PATCH v8 26/27] meson: remove --ninja option in configure.

Signed-off-by: Yonggang Luo --- .cirrus.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.cirrus.yml b/.cirrus.yml index 1ff9f0a72f..87bd110d28 100644 --- a/.cirrus.yml +++ b/.cirrus.yml @@ -99,7 +99,7 @@ windows_msys2_task: mingw-w64-x86_64-zstd" script:

[PATCH v2 03/15] hw/block/nvme: Add Commands Supported and Effects log

This log page becomes necessary to implement to allow checking for Zone Append command support in Zoned Namespace Command Set. This commit adds the code to report this log page for NVM Command Set only. The parts that are specific to zoned operation will be added later in the series.

[PATCH v8 24/27] ci: Enable msys2 ci in cirrus

Install msys2 in a proper way refer to https://github.com/cirruslabs/cirrus-ci-docs/issues/699 The https://wiki.qemu.org/Hosts/W32#Native_builds_with_MSYS2 need to be updated. There is no need of --cross-prefix, open mingw64.exe instead of msys2.exe then we don't need the --cross-prefix, besides

[PATCH v8 25/27] meson: upgrade meson for execute custom ninjatool under msys2 properly

* Bump versions to 0.55.2 for release * Tag Info: object 008d13038f95e7c7d8ad553f14e408da5b94c360 type commit tag 0.55.2 tagger Jussi Pakkanen 2020/9/11 1:24:47 Signed-off-by: Yonggang Luo --- meson | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson b/meson index

[PATCH v2 11/15] hw/block/nvme: Introduce max active and open zone limits

Added two module properties, "max_active" and "max_open" to control the maximum number of zones that can be active or open. Once these variables are set to non-default values, these limits are checked during I/O and Too Many Active or Too Many Open command status is returned if they are exceeded.

[PATCH v8 20/27] tests: Fixes test-io-channel-file by mask only owner file state mask bits

This is the error on msys2/mingw Running test test-io-channel-file ** ERROR:../tests/test-io-channel-file.c:59:test_io_channel_file_helper: assertion failed (TEST_MASK & ~mask == st.st_mode & 0777): (384 == 438) ERROR test-io-channel-file - Bail out!

[PATCH v8 23/27] rcu: fixes test-logging.c by call drain_call_rcu before rmdir_full

drain_call_rcu is necessary on win32, because under win32, if you don't close the file before remove it, the remove would be fail. Signed-off-by: Yonggang Luo --- tests/test-logging.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/test-logging.c b/tests/test-logging.c index

[PATCH v8 22/27] tests: Fixes test-qdev-global-props.c

On win32 the line ending are \r\n, so we skip the \n in function test_dynamic_globalprop Signed-off-by: Yonggang Luo Reviewed-by: Daniel P. Berrangé --- tests/test-qdev-global-props.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/test-qdev-global-props.c

[PATCH v2 07/15] hw/block/nvme: Add support for active/inactive namespaces

From: Niklas Cassel In NVMe, a namespace is active if it exists and is attached to the controller. CAP.CSS (together with the I/O Command Set data structure) defines what command sets are supported by the controller. CC.CSS (together with Set Profile) can be set to enable a subset of the

[PATCH v8 18/27] tests: Fixes test-io-channel-socket.c tests under msys2/mingw

Currently test-io-channel-socket doesn't init with qemu_init_main_loop and that's cause the qemu_aio_context not inited, and the following is the stack when null pointer accessed: qemu_fd_register (c:\work\xemu\qemu\util\main-loop.c:336) qemu_try_set_nonblock

[PATCH v2 01/15] hw/block/nvme: Define 64 bit cqe.result

From: Ajay Joshi A new write command, Zone Append, is added as a part of Zoned Namespace Command Set. Upon successful completion of this command, the controller returns the start LBA of the performed write operation in cqe.result field. Therefore, the maximum size of this variable needs to be

[PATCH v8 13/27] tests: Enable crypto tests under msys2/mingw

Fixes following tests on msys2/mingw 'test-crypto-tlscredsx509': ['crypto-tls-x509-helpers.c', 'pkix_asn1_tab.c', tasn1, crypto], 'test-crypto-tlssession': ['crypto-tls-x509-helpers.c', 'pkix_asn1_tab.c', 'crypto-tls-psk-helpers.c',

[PATCH v8 21/27] tests: fix test-util-sockets.c

Fixes following errors: Running test test-util-sockets ERROR test-util-sockets - missing test plan # Start of name tests ** ERROR:../tests/test-util-sockets.c:93:test_socket_fd_pass_name_good: assertion failed (fd != -1): (-1 != -1) Bail out!

[PATCH v8 17/27] tests: Convert g_free to g_autofree macro in test-logging.c

g_autofree are prefer than g_free when possible. Signed-off-by: Yonggang Luo Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Daniel P. Berrangé --- tests/test-logging.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/test-logging.c b/tests/test-logging.c index

[PATCH v8 14/27] meson: remove empty else and duplicated gio deps

Signed-off-by: Yonggang Luo Reviewed-by: Daniel P. Berrangé --- meson.build | 6 -- 1 file changed, 6 deletions(-) diff --git a/meson.build b/meson.build index bd84a1e777..a725b66a83 100644 --- a/meson.build +++ b/meson.build @@ -317,7 +317,6 @@ opengl = not_found if 'CONFIG_OPENGL' in

[PATCH v8 16/27] cirrus: Building freebsd in a single short

This reverts commit 45f7b7b9f38f5c4d1529a37c93dedfc26a231bba ("cirrus.yml: Split FreeBSD job into two parts"). freebsd 1 hour limit not hit anymore I think we going to a wrong direction, I think there is some tests a stall the test runner, please look at

[PATCH v8 12/27] gcrypt: test_tls_psk_init should write binary file instead text file.

On windows, if open file with "w", it's will automatically convert "\n" to "\r\n" when writing to file. Convert unlink to use g_remove. Signed-off-by: Yonggang Luo --- tests/crypto-tls-psk-helpers.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

[PATCH v8 15/27] vmstate: Fixes test-vmstate.c on msys2/mingw

The vmstate are valid on win32, just need generate tmp path properly Signed-off-by: Yonggang Luo Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: Daniel P. Berrangé --- tests/test-vmstate.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH v8 11/27] meson: Use -b to ignore CR vs. CR-LF issues on Windows

On windows, a difference in line endings causes testsuite failures complaining that every single line in files such as 'tests/qapi-schemadoc-good.texi' is wrong. Fix it by adding -b to diff. Signed-off-by: Yonggang Luo Reviewed-by: Eric Blake Reviewed-by: Daniel P. Berrangé ---

[PATCH v8 10/27] osdep: file locking functions are not available on Win32

int qemu_lock_fd(int fd, int64_t start, int64_t len, bool exclusive); int qemu_unlock_fd(int fd, int64_t start, int64_t len); int qemu_lock_fd_test(int fd, int64_t start, int64_t len, bool exclusive); bool qemu_has_ofd_lock(void); Signed-off-by: Yonggang Luo Reviewed-by: Daniel P. Berrangé ---

[PATCH v8 08/27] tests: Fixes test-replication.c on msys2/mingw.

On Windows there is no path like /tmp/s_local_disk.XX Use g_get_tmp_dir instead of /tmp. Signed-off-by: Yonggang Luo Reviewed-by: Daniel P. Berrangé --- tests/test-replication.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/tests/test-replication.c

[PATCH v8 19/27] tests: fixes aio-win32 about aio_remove_fd_handler, get it consistence with aio-posix.c

This is a fixes for (C:\work\xemu\qemu\build\tests\test-aio-multithread.exe:19100): GLib-CRITICAL **: 23:03:24.965: g_source_remove_poll: assertion '!SOURCE_DESTROYED (source)' failed ERROR test-aio-multithread - Bail out! GLib-FATAL-CRITICAL: g_source_remove_poll: assertion '!SOURCE_DESTROYED

[PATCH v8 07/27] tests: disable /char/stdio/* tests in test-char.c on win32

These tests are blocking test-char to be finished. Disable them by using variable is_win32, so we doesn't need macro to open it. and easy recover those function latter. Signed-off-by: Yonggang Luo --- tests/test-char.c | 26 -- 1 file changed, 16 insertions(+), 10

[PATCH v8 04/27] configure: Fixes ncursesw detection under msys2/mingw and enable curses

The mingw pkg-config are showing following absolute path and contains : as the separator, so we must not use : as path separator. and we know the command line parameter are not likely contains newline, we could use newline as path command line parameter separator -D_XOPEN_SOURCE=600

[PATCH v8 05/27] win32: Simplify gmtime_r detection direct base on _POSIX_THREAD_SAFE_FUNCTIONS.

First, this reduce the size of configure, configure are tending to removal in future, and this didn't introduce any new feature or remove any exist feature. Second, the current localtime_r detection are conflict with ncursesw detection in mingw, when ncursesw detected, it will provide the

[PATCH v8 09/27] tests: test-replication disable /replication/secondary/* on msys2/mingw.

They caused failure on msys2/mingw, that's because file-win32.c not implement .bdrv_reopen_prepare/commit/abort yet. This is the error message: > $ ./tests/test-replication.exe > # random seed: R02S3f4d1c01af2b0a046990e0235c481faf > 1..13 > # Start of replication tests > # Start of primary tests

[PATCH v8 06/27] curses: Fixes curses compiling errors.

This is the compiling error: ../ui/curses.c: In function 'curses_refresh': ../ui/curses.c:256:5: error: 'next_maybe_keycode' may be used uninitialized in this function [-Werror=maybe-uninitialized] 256 | curses2foo(_curses2keycode, _curseskey2keycode, chr, maybe_keycode) |

[PATCH v8 03/27] ci: fixes msys2 build by upgrading capstone to 4.0.2

The currently random version capstone have the following compiling issue: CC /c/work/xemu/qemu/build/slirp/src/arp_table.o make[1]: *** No rule to make target “/c/work/xemu/qemu/build/capstone/capstone.lib”。 Stop. Subproject commit 1d230532840a37ac032c6ab80128238fc930c6c1 are the tagged

[PATCH v8 00/27] W32, W64 msys2/mingw patches

It first introduce msys2 CI on cirrus by fixes nfs, capstone, curses and disable partial test-char tests. And then fixes all unit tests failure on msys2/mingw This fixes the reviews suggested in the mailling list All cirrus CI are passed Maxim Levitsky (1): rcu: Implement drain_call_rcu

[PATCH v8 01/27] rcu: Implement drain_call_rcu

From: Maxim Levitsky This will allow is to preserve the semantics of hmp_device_del, that the device is deleted immediatly which was changed by previos patch that delayed this to RCU callback Signed-off-by: Maxim Levitsky Suggested-by: Stefan Hajnoczi Reviewed-by: Stefan Hajnoczi ---

[PATCH v8 02/27] block: Fixes nfs compiling error on msys2/mingw

These compiling errors are fixed: ../block/nfs.c:27:10: fatal error: poll.h: No such file or directory 27 | #include | ^~~~ compilation terminated. ../block/nfs.c:63:5: error: unknown type name 'blkcnt_t' 63 | blkcnt_t st_blocks; | ^~~~ ../block/nfs.c:

Re: [PATCH] iotests: Allow running from different directory

On 9/3/20 7:21 PM, Kevin Wolf wrote: > Am 03.09.2020 um 14:54 hat Max Reitz geschrieben: >> On 02.09.20 13:03, Kevin Wolf wrote: >>> It is convenient to be able to edit the tests and run them without >>> changing the current working directory back and forth. Instead of >>> assuming that $PWD is

Re: [PATCH v9 11/14] hw/arm: Wire up BMC boot flash for npcm750-evb and quanta-gsj

On Fri, Sep 11, 2020 at 5:46 AM Philippe Mathieu-Daudé wrote: > > > On 9/11/20 7:20 AM, Havard Skinnemoen via wrote: > > This allows these NPCM7xx-based boards to boot from a flash image, e.g. > > one built with OpenBMC. For example like this: > > > >

Re: [PULL 00/17] Crypto next patches

On Thu, 10 Sep 2020 at 11:07, Daniel P. Berrangé wrote: > > The following changes since commit 9435a8b3dd35f1f926f1b9127e8a906217a5518a: > > Merge remote-tracking branch 'remotes/kraxel/tags/sirius/ipxe-20200908-pull= > -request' into staging (2020-09-08 21:21:13 +0100) > > are available in the

Re: [PULL 00/18] Trivial branch for 5.2 patches

On Fri, 11 Sep 2020 at 20:35, Laurent Vivier wrote: > > The following changes since commit 9435a8b3dd35f1f926f1b9127e8a906217a5518a: > > Merge remote-tracking branch 'remotes/kraxel/tags/sirius/ipxe-20200908-pull= > -request' into staging (2020-09-08 21:21:13 +0100) > > are available in the Git

Re: [PATCH v2 0/7] hw/char/serial: Housekeeping

On Sat, 12 Sep 2020 at 07:46, wrote: > > Patchew URL: https://patchew.org/QEMU/20200912114040.918464-1-f4...@amsat.org/ > > Hi, > > This series failed build test on FreeBSD host. Please find the details below. > > The full log is available at >

Re: [PATCH 0/3] gitmodules: add qboot, meson, and vbootrom mirrors

On 09/09/20 12:16, Stefan Hajnoczi wrote: > This patch series adds qemu.org mirrors for qboot, meson, and vbootrom. > > vbootrom is not yet used by qemu.git/master so you may wish to hold off on > applying the final patch. > > Stefan Hajnoczi (3): > gitmodules: switch to qemu.org qboot mirror

Re: [PULL v2] Block layer patches

On Sat, 12 Sep 2020 at 13:27, Thomas Huth wrote: > Peter, why did this slip through your merge tests, do you still skip the > iotests there? I forget what the reason for them being skipped is, maybe it's because they demand a gnu sed ? thanks -- PMM

Re: [PATCH v2 2/2] hw/timer/hpet: Fix DPRINTF format string

Hi Phil, On 10/09/2020 16:58, Philippe Mathieu-Daudé wrote: Fix building with HPET_DEBUG enabled: hw/timer/hpet.c:512:73: error: format specifies type 'unsigned int' but the argument has type 'uint64_t' (aka 'unsigned long') [-Werror,-Wformat] DPRINTF("qemu: Enter hpet_ram_writel at

[Bug 1895399] [NEW] Docfix: add missing virtiofsd cache default 'auto'

Public bug reported: The usage command line for virtiofsd has: void fuse_cmdline_help(void) { printf("-h --helpprint help\n" ... "-o cache=cache mode. could be one of \"auto, " "always, none\"\n" "

Re: [PULL v5 00/46] Next round of Meson bugfixes and cleanups

On Tue, Sep 8, 2020 at 3:27 PM Peter Maydell wrote: > > On Tue, 8 Sep 2020 at 10:45, Paolo Bonzini wrote: > > > > The following changes since commit e11bd71f89649da3cff439c030d2ccac0cc914e3: > > > > Merge remote-tracking branch > > 'remotes/huth-gitlab/tags/pull-request-2020-09-07' into

Re: [PATCH 7/7] hw/char/serial: Let SerialState have an 'id' field

On 12/09/20 13:33, Philippe Mathieu-Daudé wrote: >> I'll send a new patch for the PCI-single device: > Bah this can simply be squashed into the previous patch. > Yup, done. Paolo

Re: [PATCH] ui/spice-input: Remove superfluous forward declaration

Le 09/09/2020 à 19:11, Philippe Mathieu-Daudé a écrit : > We only need to forward-declare kbd_push_key() and kbd_get_leds() > which are used in kbd_interface, not kbd_leds(). Remove this > superfluous forward declaration. > > Signed-off-by: Philippe Mathieu-Daudé > --- > ui/spice-input.c | 1 -

Re: Moving to C11? (was Re: Redefinition of typedefs (C11 feature))

On Sat, Sep 12, 2020, 2:16 AM Philippe Mathieu-Daudé wrote: > On 9/11/20 10:10 PM, Warner Losh wrote: > > > > > > On Fri, Sep 11, 2020 at 2:07 PM Eduardo Habkost > > wrote: > > > > On Fri, Sep 11, 2020 at 08:06:10PM +0100, Peter Maydell wrote: > > > On Fri,

Re: [PATCH v6 0/7] hw/misc: Add LED device

Patchew URL: https://patchew.org/QEMU/20200912134041.946260-1-f4...@amsat.org/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. The full log is

[PATCH v6 7/7] hw/arm/tosa: Replace fprintf() calls by LED devices

The recently added LED device reports LED status changes with the 'led_set_intensity' trace event. It is less invasive than the fprintf() calls. We need however to have a binary built with tracing support. Reviewed-by: Luc Michel Reviewed-by: Richard Henderson Signed-off-by: Philippe

[PATCH v6 4/7] hw/arm/aspeed: Add the 3 front LEDs drived by the PCA9552 #1

The Witherspoon has 3 LEDs connected to a PCA9552. Add them. The names and reset values are taken from: https://github.com/open-power/witherspoon-xml/blob/master/witherspoon.xml Example booting obmc-phosphor-image: $ qemu-system-arm -M witherspoon-bmc -trace led_change_intensity

[PATCH v6 6/7] hw/misc/mps2-scc: Use the LED device

Per the 'ARM MPS2 and MPS2+ FPGA Prototyping Boards Technical Reference Manual' (100112_0200_07_en): 2.1 Overview of the MPS2 and MPS2+ hardware The MPS2 and MPS2+ FPGA Prototyping Boards contain the following components and interfaces: * User switches and user LEDs:

[PATCH v6 3/7] hw/misc/led: Emit a trace event when LED intensity has changed

Track the LED intensity, and emit a trace event when it changes. Reviewed-by: Richard Henderson Reviewed-by: Luc Michel Signed-off-by: Philippe Mathieu-Daudé --- hw/misc/led.c| 4 hw/misc/trace-events | 1 + 2 files changed, 5 insertions(+) diff --git a/hw/misc/led.c

[PATCH v6 1/7] hw/misc/led: Add a LED device

Add a LED device which can be connected to a GPIO output. They can also be dimmed with PWM devices. For now we do not implement the dimmed mode, but in preparation of a future implementation, we start using the LED intensity. LEDs are limited to a fixed set of colors. Reviewed-by: Luc Michel

[PATCH v6 5/7] hw/misc/mps2-fpgaio: Use the LED device

Per the 'ARM MPS2 and MPS2+ FPGA Prototyping Boards Technical Reference Manual' (100112_0200_07_en): 2.1 Overview of the MPS2 and MPS2+ hardware The MPS2 and MPS2+ FPGA Prototyping Boards contain the following components and interfaces: * User switches and user LEDs:

[PATCH v6 0/7] hw/misc: Add LED device

Hello, These patches are part of the GSoC unselected 'QEMU visualizer' project. This series introduce a LED device that can be easily connected to a GPIO output. Missing review: - Patch #2: "hw/misc/led: Allow connecting from GPIO output" Since v5: - Rebased on "QOM boilerplate cleanup" (use

[PATCH v6 2/7] hw/misc/led: Allow connecting from GPIO output

Some devices expose GPIO lines. Add a GPIO qdev input to our LED device, so we can connect a GPIO output using qdev_connect_gpio_out(). When used with GPIOs, the intensity can only be either minium or maximum. This depends of the polarity of the GPIO (which can be inverted). Declare the

Re: [PATCH v5 2/7] hw/misc/led: Allow connecting from GPIO output

On 9/12/20 10:50 AM, Philippe Mathieu-Daudé wrote: > Eduardo is already in Cc, adding Markus. > > On 9/12/20 12:44 AM, Richard Henderson wrote: >> On 9/10/20 1:54 PM, Philippe Mathieu-Daudé wrote: >>> Some devices expose GPIO lines. >>> >>> Add a GPIO qdev input to our LED device, so we can >>>

Re: [PULL v2] Block layer patches

On 10/09/2020 00.09, Eric Blake wrote: > On 9/9/20 4:55 PM, Peter Maydell wrote: > >> >> This fails 'make check' on NetBSD and OpenBSD: >> >> ./check: line 47: realpath: command not found >> ./check: line 60: /common.env: No such file or directory >> check: failed to source common.env (make sure

[Bug 1895219] Re: qemu git -vnc fails due to missing en-us keymap

A work around to get vnc enabled for those that need it until this is fixed is to manually copy from source tree pc-bios/keymaps/* to qemu- data keymaps directory, usually installed at /usr/share/qemu/keymaps or /usr/local/share/qemu/keymaps (default prefix). Commit that broke the install of

[PATCH] tests/check-block: Do not run the iotests with old versions of bash

macOS is shipped with a very old version of the bash (3.2), which is currently not suitable for running the iotests anymore. Add a check to skip the iotests in this case - if someone still wants to run the iotests on macOS, they can install a newer version from homebrew, for example.

Re: [PATCH v2 0/7] hw/char/serial: Housekeeping

Patchew URL: https://patchew.org/QEMU/20200912114040.918464-1-f4...@amsat.org/ Hi, This series seems to have some coding style problems. See output below for more information: N/A. Internal error while reading log file The full log is available at

Re: [PATCH v2 0/7] hw/char/serial: Housekeeping

Patchew URL: https://patchew.org/QEMU/20200912114040.918464-1-f4...@amsat.org/ Hi, This series failed build test on FreeBSD host. Please find the details below. The full log is available at http://patchew.org/logs/20200912114040.918464-1-f4...@amsat.org/testing.FreeBSD/?type=message. ---

[PATCH v2 6/7] hw/char/serial: Alias QDEV properties from generic serial object

Instead of overwritting the properties of the generic 'state' object, alias them. Note we can now propagate the "baudbase" property (except on the PCI multi-UART device). Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- hw/char/serial-isa.c | 4 ++--

[PATCH v2 7/7] hw/char/serial: Let SerialState have an 'id' field

When a SoC has multiple UARTs (some configured differently), it is hard to associate events to their UART. To be able to distinct trace events between various instances, add an 'id' field. Update the trace format accordingly. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé

[PATCH v2 5/7] hw/char/serial: Make 'wakeup' property boolean

Make the "wakeup" property introduced in commit 9826fd597df ("suspend: make serial ports wakeup the guest") a boolean. As we want to reuse the generic serial properties in the ISA model (next commit), expose this property. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé

[PATCH v2 3/7] hw/char/serial: Remove old DEBUG_SERIAL commented code

All useful DPRINTF() calls have been converted to trace events. Remove a pointless one in the IOEventHandler, and drop the DEBUG_SERIAL ifdef'ry. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- hw/char/serial.c | 11 --- 1 file changed, 11 deletions(-) diff

[PATCH v2 2/7] hw/char/serial: Replace commented DPRINTF() by trace event

Convert the old debug PRINTF() call to display the UART baudrate to a trace event. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- hw/char/serial.c | 4 +--- hw/char/trace-events | 1 + 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/char/serial.c

[PATCH v2 1/7] hw/char/serial: Assert serial_ioport_read/write offset fits 8 bytes

The serial device has 8 registers, each 8-bit. The MemoryRegionOps 'serial_io_ops' is initialized with max_access_size=1, and all memory_region_init_io() callers correctly set the region size to 8 bytes: - serial_io_realize - serial_isa_realizefn - serial_pci_realize - multi_serial_pci_realize It

[PATCH v2 0/7] hw/char/serial: Housekeeping

Nothing very exciting, cleanups before more serious changes. Since v1: addressed Paolo's comments - Also alias QDev properties on the PCI device (patch 6) - Initialize the 'id' property on the PCI multi-UART device (patch 7) Patches 1-6 already queued by Paolo. $ git backport-diff -r v2 -u v1

[PATCH v2 4/7] hw/char/serial: Rename I/O read/write trace events

The serial_mm_read/write() handlers from the TYPE_SERIAL_MM device call the serial_ioport_read/write() handlers with shifted offset. When looking at the trace events from this MMIO device, it is confusing to read the accesses as I/O. Simplify using generic trace event names which make sense the

Re: [PATCH 7/7] hw/char/serial: Let SerialState have an 'id' field

On 9/12/20 1:28 PM, Philippe Mathieu-Daudé wrote: > On 9/12/20 11:14 AM, Paolo Bonzini wrote: >> On 07/09/20 03:55, Philippe Mathieu-Daudé wrote: >>> When a SoC has multiple UARTs (some configured differently), >>> it is hard to associate events to their UART. >>> >>> To be able to distinct trace

Re: [PATCH 7/7] hw/char/serial: Let SerialState have an 'id' field

On 9/12/20 11:14 AM, Paolo Bonzini wrote: > On 07/09/20 03:55, Philippe Mathieu-Daudé wrote: >> When a SoC has multiple UARTs (some configured differently), >> it is hard to associate events to their UART. >> >> To be able to distinct trace events between various instances, >> add an 'id' field.

[PATCH v2 6/6] migration/tls: add trace points for multifd-tls

add trace points for multifd-tls for debug. Signed-off-by: Chuan Zheng Signed-off-by: Yan Jin --- migration/multifd.c| 10 +- migration/trace-events | 5 + 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/migration/multifd.c b/migration/multifd.c index

[PATCH v2 3/6] migration/tls: add MigrationState and tls_hostname into MultiFDSendParams

MigrationState is need for tls session build and tls hostname is need for tls handshake, add both MigrationState and tls_hostname into MultiFDSendParams. Signed-off-by: Chuan Zheng Signed-off-by: Yan Jin --- migration/multifd.c | 5 + migration/multifd.h | 4 2 files changed, 9

  1   2   >