Re: [PATCH] hw/arm/aspeed: Map the UART5 device unconditionally

2020-09-15 Thread Cédric Le Goater
On 9/15/20 7:23 PM, Philippe Mathieu-Daudé wrote: > ping? It's reviewed : http://patchwork.ozlabs.org/project/qemu-devel/patch/20200905212415.760452-1-f4...@amsat.org/ I will send a PR when I have more patches. Thanks, C. > On 9/5/20 11:24 PM, Philippe Mathieu-Daudé wrote: >> The UART5

[Bug 1894869] Re: Chelsio T4 has old MSIX PBA offset bug

2020-09-15 Thread Alex Williamson
The device ID on function 7 is 0x which is typically not valid, there's no entry for it in the PCI IDs database. Someone from Chelsio would need to explain why it's even exposed, but there doesn't seem to be any value in quirking it since it provides no useful function. ** Changed in: qemu

Re: [PATCH v9 07/12] migration/dirtyrate: Compare page hash results for recorded sampled page

2020-09-15 Thread Zheng Chuan
On 2020/9/16 0:30, Li Qiang wrote: > Chuan Zheng 于2020年9月15日周二 上午10:34写道: >> >> Compare page hash results for recorded sampled page. >> >> Signed-off-by: Chuan Zheng >> Signed-off-by: YanYing Zhuang >> Reviewed-by: Dr. David Alan Gilbert >> --- >> migration/dirtyrate.c | 63 >>

Re: [PATCH v2 1/6] util/oslib-win32: Use _aligned_malloc for qemu_try_memalign

2020-09-15 Thread Stefan Weil
Am 16.09.20 um 02:46 schrieb Richard Henderson: > We do not need or want to be allocating page sized quanta. > > Signed-off-by: Richard Henderson > --- > Cc: Stefan Weil > --- > util/oslib-win32.c | 10 +++--- > 1 file changed, 3 insertions(+), 7 deletions(-) > > diff --git

Re: [PATCH 0/5] qom: Allow object to be aligned

2020-09-15 Thread Stefan Weil
Am 16.09.20 um 00:47 schrieb Richard Henderson: > On 9/15/20 10:46 AM, Richard Henderson wrote: >> We already have a function that can alloc with alignment, >> but we need to pass this down from the structure. We also >> don't want to use this function unconditionally, because >> the windows

[Bug 1883984] Update Released

2020-09-15 Thread Chris Halse Rogers
The verification of the Stable Release Update for qemu has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a

[Bug 1883984] Re: QEMU S/390x sqxbr (128-bit IEEE 754 square root) crashes qemu-system-s390x

2020-09-15 Thread Launchpad Bug Tracker
This bug was fixed in the package qemu - 1:4.2-3ubuntu6.5 --- qemu (1:4.2-3ubuntu6.5) focal; urgency=medium * further stabilize qemu by importing patches of qemu v4.2.1 Fixes (LP: #1891203) and (LP: #1891877) - d/p/stable/lp-1891877-* - as part of the stabilization this

[PATCH V9 6/6] hw/mips: Add Loongson-3 machine support

2020-09-15 Thread Huacai Chen
Add Loongson-3 based machine support, it use liointc as the interrupt controler and use GPEX as the pci controller. Currently it can work with both TCG and KVM. As the machine model is not based on any exiting physical hardware, the name of the machine is "loongson3-virt". It may be superseded in

[PATCH V9 5/6] target/mips: Add loongson-ext lsdc2 group of instructions

2020-09-15 Thread Huacai Chen
From: Jiaxun Yang LDC2/SDC2 opcodes have been rewritten as "load & store with offset" group of instructions by loongson-ext ASE. This patch add implementation of these instructions: gslbx: load 1 bytes to GPR gslhx: load 2 bytes to GPR gslwx: load 4 bytes to GPR gsldx: load 8 bytes to GPR

[PATCH V9 4/6] target/mips: Add loongson-ext lswc2 group of instructions (Part 2)

2020-09-15 Thread Huacai Chen
From: Jiaxun Yang LWC2 & SWC2 have been rewritten by Loongson EXT vendor ASE as "load/store quad word" and "shifted load/store" groups of instructions. This patch add implementation of these instructions: gslwlc1: similar to lwl but RT is FPR instead of GPR gslwrc1: similar to lwr but RT is FPR

[PATCH V9 2/6] target/mips: Fix PageMask with variable page size

2020-09-15 Thread Huacai Chen
From: Jiaxun Yang Our current code assumed the target page size is always 4k when handling PageMask and VPN2, however, variable page size was just added to mips target and that's nolonger true. Signed-off-by: Huacai Chen Signed-off-by: Jiaxun Yang --- target/mips/cp0_helper.c | 36

[PATCH V9 3/6] target/mips: Add loongson-ext lswc2 group of instructions (Part 1)

2020-09-15 Thread Huacai Chen
From: Jiaxun Yang LWC2 & SWC2 have been rewritten by Loongson EXT vendor ASE as "load/store quad word" and "shifted load/store" groups of instructions. This patch add implementation of these instructions: gslq: load 16 bytes to GPR gssq: store 16 bytes from GPR gslqc1: load 16 bytes to FPR

[PATCH V9 1/6] linux-headers: Update MIPS KVM type defintition

2020-09-15 Thread Huacai Chen
Update MIPS KVM type defintition from Linux 5.9-rc6. Signed-off-by: Huacai Chen --- linux-headers/linux/kvm.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/linux-headers/linux/kvm.h b/linux-headers/linux/kvm.h index a28c366..36a480f 100644 ---

[PATCH V9 0/6] mips: Add Loongson-3 machine support

2020-09-15 Thread Huacai Chen
Loongson-3 CPU family include Loongson-3A R1/R2/R3/R4 and Loongson-3B R1/R2. Loongson-3A R1 is the oldest and its ISA is the smallest, while Loongson-3A R4 is the newest and its ISA is almost the superset of all others. To reduce complexity, in QEMU we just define two CPU types: 1,

[PATCH] target/arm: Fix sve ldr/str

2020-09-15 Thread Richard Henderson
The mte update missed a bit when producing clean addresses. Fixes: b2aa8879b88 Signed-off-by: Richard Henderson --- target/arm/translate-sve.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/arm/translate-sve.c b/target/arm/translate-sve.c index

[PATCH v2 2/6] qom: Allow objects to be allocated with increased alignment

2020-09-15 Thread Richard Henderson
It turns out that some hosts have a default malloc alignment less than that required for vectors. We assume that, with compiler annotation on CPUArchState, that we can properly align the vector portion of the guest state. Fix the alignment of the allocation by using qemu_memalloc when required.

[PATCH v2 4/6] target/ppc: Set instance_align on PowerPCCPU TypeInfo

2020-09-15 Thread Richard Henderson
Fix alignment of CPUPPCState.vsr. Signed-off-by: Richard Henderson --- Cc: David Gibson Cc: qemu-...@nongnu.org --- target/ppc/translate_init.c.inc | 1 + 1 file changed, 1 insertion(+) diff --git a/target/ppc/translate_init.c.inc b/target/ppc/translate_init.c.inc index 230a062d29..accb4f2fae

[PATCH v2 6/6] target/s390x: Set instance_align on S390CPU TypeInfo

2020-09-15 Thread Richard Henderson
Fix alignment of CPUS390XState.vregs. Signed-off-by: Richard Henderson --- Cc: David Hildenbrand Cc: Cornelia Huck Cc: qemu-s3...@nongnu.org --- target/s390x/cpu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/s390x/cpu.c b/target/s390x/cpu.c index 749cd548f0..e350edc9f5 100644

[PATCH v2 1/6] util/oslib-win32: Use _aligned_malloc for qemu_try_memalign

2020-09-15 Thread Richard Henderson
We do not need or want to be allocating page sized quanta. Signed-off-by: Richard Henderson --- Cc: Stefan Weil --- util/oslib-win32.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/util/oslib-win32.c b/util/oslib-win32.c index c654dafd93..8d838bf342 100644 ---

[PATCH v2 5/6] target/riscv: Set instance_align on RISCVCPU TypeInfo

2020-09-15 Thread Richard Henderson
Fix alignment of CPURISCVState.vreg. Signed-off-by: Richard Henderson --- Cc: Alistair Francis Cc: qemu-ri...@nongnu.org --- target/riscv/cpu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index 57c006df5d..0bbfd7f457 100644 ---

[PATCH v2 3/6] target/arm: Set instance_align on CPUARM TypeInfo

2020-09-15 Thread Richard Henderson
Fix alignment of CPUARMState.vfp.zregs. Signed-off-by: Richard Henderson --- Cc: Peter Maydell Cc: qemu-...@nongnu.org --- target/arm/cpu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/arm/cpu.c b/target/arm/cpu.c index 7b5ea65fab..a7643deab4 100644 --- a/target/arm/cpu.c +++

[PATCH v2 0/6] qom: Allow object to be aligned

2020-09-15 Thread Richard Henderson
I've seen some failures on arm and s390x hosts after enabling host vector support. It turns out that the malloc for these hosts does not provide 16-byte alignment. We already have a function that can alloc with alignment, but we need to pass this down from the structure. We also don't want to

[Bug 1894869] Re: Chelsio T4 has old MSIX PBA offset bug

2020-09-15 Thread Nick Bauer
I was able to boot a VM with just the functions of the device with the ethernet controller function ID added as PCI devices. Something I noticed while adding in those devices though is that all of the others have a description associated with them in Proxmox, but the one that's causing the boot to

[Bug 1892604] Re: qemu-system-arm: ../hw/usb/hcd-dwc2.c:666: dwc2_glbreg_read: Assertion `addr <= GINTSTS2' failed.

2020-09-15 Thread Paul Zimmerman
Hmm, that's odd. I will try to reproduce this. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1892604 Title: qemu-system-arm: ../hw/usb/hcd-dwc2.c:666: dwc2_glbreg_read: Assertion `addr <=

[PATCH 33/37] qapi/introspect.py: add notational type hints

2020-09-15 Thread John Snow
Add a tiny hint into schema.py to allow introspect.py to type check, too. Signed-off-by: John Snow --- scripts/qapi/introspect.py | 123 ++--- scripts/qapi/mypy.ini | 5 -- scripts/qapi/schema.py | 2 +- 3 files changed, 87 insertions(+), 43

[PATCH 35/37] qapi/types.py: remove one-letter variables

2020-09-15 Thread John Snow
"John, if pylint told you to jump off a bridge, would you?" Hey, if it looked like fun, I might. Now that this file is clean, enable pylint checks on this file. Signed-off-by: John Snow --- scripts/qapi/pylintrc | 1 - scripts/qapi/types.py | 29 +++-- 2 files changed,

Re: [PATCH 0/5] qom: Allow object to be aligned

2020-09-15 Thread Richard Henderson
On 9/15/20 10:46 AM, Richard Henderson wrote: > We already have a function that can alloc with alignment, > but we need to pass this down from the structure. We also > don't want to use this function unconditionally, because > the windows version does page allocation, which would be > overkill

[PATCH 31/37] qapi/introspect.py: add _gen_features helper

2020-09-15 Thread John Snow
_make_tree doesn't know if it is receiving an object or some other type; adding features information should arguably be performed by the caller. This will help us refactor _make_tree more gracefully in the next patch. Signed-off-by: John Snow --- scripts/qapi/introspect.py | 22

[PATCH 25/37] qapi/gen.py: add notational type hints

2020-09-15 Thread John Snow
Signed-off-by: John Snow --- scripts/qapi/gen.py | 105 +++- 1 file changed, 56 insertions(+), 49 deletions(-) diff --git a/scripts/qapi/gen.py b/scripts/qapi/gen.py index fc46813d1a..c87c84e7c9 100644 --- a/scripts/qapi/gen.py +++ b/scripts/qapi/gen.py

[PATCH 36/37] qapi/visit.py: remove unused parameters from gen_visit_object

2020-09-15 Thread John Snow
And this fixes the pylint report for this file, so make sure we check this in the future, too. Signed-off-by: John Snow --- scripts/qapi/pylintrc | 1 - scripts/qapi/visit.py | 4 ++-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/scripts/qapi/pylintrc b/scripts/qapi/pylintrc

[PATCH 26/37] qapi/gen.py: Enable checking with mypy

2020-09-15 Thread John Snow
Signed-off-by: John Snow --- scripts/qapi/mypy.ini | 5 - 1 file changed, 5 deletions(-) diff --git a/scripts/qapi/mypy.ini b/scripts/qapi/mypy.ini index 43c8bd1973..dbfeda748c 100644 --- a/scripts/qapi/mypy.ini +++ b/scripts/qapi/mypy.ini @@ -19,11 +19,6 @@ disallow_untyped_defs = False

[PATCH 27/37] qapi/gen.py: Remove unused parameter

2020-09-15 Thread John Snow
module_basename doesn't use the 'what' argument, so remove it. Signed-off-by: John Snow --- scripts/qapi/gen.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/qapi/gen.py b/scripts/qapi/gen.py index c87c84e7c9..e873901672 100644 --- a/scripts/qapi/gen.py +++

[PATCH 20/37] qapi/commands.py: add notational type hints

2020-09-15 Thread John Snow
Signed-off-by: John Snow --- scripts/qapi/commands.py | 72 ++-- 1 file changed, 54 insertions(+), 18 deletions(-) diff --git a/scripts/qapi/commands.py b/scripts/qapi/commands.py index b215e58357..3c950da10a 100644 --- a/scripts/qapi/commands.py +++

[PATCH 32/37] qapi/introspect.py: create a typed 'Node' data structure

2020-09-15 Thread John Snow
Replacing the un-typed tuple, add a typed Node that we can add typed metadata to. Signed-off-by: John Snow --- scripts/qapi/introspect.py | 53 -- 1 file changed, 28 insertions(+), 25 deletions(-) diff --git a/scripts/qapi/introspect.py

[PATCH 30/37] qapi/introspect.py: Add a typed 'extra' structure

2020-09-15 Thread John Snow
Typing arbitrarily shaped dicts with mypy is difficult prior to Python 3.8; using explicit structures is nicer. Since we always define an Extra type now, the return type of _make_tree simplifies and always returns the tuple. Signed-off-by: John Snow --- scripts/qapi/introspect.py | 31

[PATCH 17/37] qapi/events.py: add notational type hints

2020-09-15 Thread John Snow
This is enough to enable type-checking on events.py, so enable that in this patch, too. Signed-off-by: John Snow --- scripts/qapi/events.py | 46 -- scripts/qapi/mypy.ini | 5 - 2 files changed, 35 insertions(+), 16 deletions(-) diff --git

[PATCH 28/37] qapi/gen.py: update write() to be more idiomatic

2020-09-15 Thread John Snow
Make the file handling here just a tiny bit more idiomatic. (I realize this is heavily subjective.) Use exist_ok=True for os.makedirs and remove the exception, use fdopen() to wrap the file descriptor in a File-like object, and use a context manager for managing the file pointer. Signed-off-by:

[PATCH 21/37] qapi/commands.py: enable checking with mypy

2020-09-15 Thread John Snow
Signed-off-by: John Snow --- scripts/qapi/mypy.ini | 5 - 1 file changed, 5 deletions(-) diff --git a/scripts/qapi/mypy.ini b/scripts/qapi/mypy.ini index b668776d94..9da1dccef4 100644 --- a/scripts/qapi/mypy.ini +++ b/scripts/qapi/mypy.ini @@ -4,11 +4,6 @@ strict_optional = False

[PATCH 37/37] qapi/visit.py: add notational type hints

2020-09-15 Thread John Snow
Signed-off-by: John Snow --- scripts/qapi/mypy.ini | 5 --- scripts/qapi/visit.py | 72 +-- 2 files changed, 55 insertions(+), 22 deletions(-) diff --git a/scripts/qapi/mypy.ini b/scripts/qapi/mypy.ini index 3babc380a8..5ab3433c5f 100644 ---

[PATCH 22/37] qapi/source.py: add notational type hints

2020-09-15 Thread John Snow
Signed-off-by: John Snow --- scripts/qapi/mypy.ini | 5 - scripts/qapi/source.py | 31 ++- 2 files changed, 18 insertions(+), 18 deletions(-) diff --git a/scripts/qapi/mypy.ini b/scripts/qapi/mypy.ini index 9da1dccef4..43c8bd1973 100644 ---

[PATCH 24/37] qapi/gen.py: Fix edge-case of _is_user_module

2020-09-15 Thread John Snow
The edge case is that if the name is '', this expression returns a string instead of a bool, which violates our declared type. Signed-off-by: John Snow --- scripts/qapi/gen.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/qapi/gen.py b/scripts/qapi/gen.py index

[PATCH 19/37] qapi/commands.py: Don't re-bind to variable of different type

2020-09-15 Thread John Snow
Mypy isn't a fan of rebinding a variable with a new data type. It's easy enough to avoid. Signed-off-by: John Snow --- scripts/qapi/commands.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/scripts/qapi/commands.py b/scripts/qapi/commands.py index 0c0fe854fe..b215e58357

[PATCH 34/37] qapi/types.py: add notational type hints

2020-09-15 Thread John Snow
Signed-off-by: John Snow --- scripts/qapi/mypy.ini | 5 --- scripts/qapi/types.py | 86 --- 2 files changed, 64 insertions(+), 27 deletions(-) diff --git a/scripts/qapi/mypy.ini b/scripts/qapi/mypy.ini index 9ce8b56f22..3babc380a8 100644 ---

[PATCH 18/37] qapi/events.py: Move comments into docstrings

2020-09-15 Thread John Snow
Signed-off-by: John Snow --- scripts/qapi/events.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/scripts/qapi/events.py b/scripts/qapi/events.py index 449a700ffe..0b49cf5fea 100644 --- a/scripts/qapi/events.py +++ b/scripts/qapi/events.py @@ -49,8 +49,10 @@ def

[PATCH 12/37] qapi/common.py: check with pylint

2020-09-15 Thread John Snow
Remove qapi/common.py from the pylintrc ignore list. Signed-off-by: John Snow --- scripts/qapi/pylintrc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/scripts/qapi/pylintrc b/scripts/qapi/pylintrc index c2bbb8e8e1..c800055589 100644 --- a/scripts/qapi/pylintrc +++

[PATCH 16/37] qapi: establish mypy type-checking baseline

2020-09-15 Thread John Snow
Fix two very minor issues, and then establish a mypy type-checking baseline. Like pylint, this should be run from the folder above: > mypy --config-file=qapi/mypy.ini qapi/ Signed-off-by: John Snow --- scripts/qapi/doc.py| 3 +- scripts/qapi/mypy.ini | 65

[PATCH 29/37] qapi/gen.py: delint with pylint

2020-09-15 Thread John Snow
'fp' and 'fd' are self-evident in context, add them to the list of OK names. _top and _bottom also need to stay class methods because some users override the method and need to use `self`. Tell pylint to shush. Signed-off-by: John Snow --- scripts/qapi/gen.py | 2 ++ scripts/qapi/pylintrc |

[PATCH 11/37] qapi/common.py: Replace one-letter 'c' variable

2020-09-15 Thread John Snow
Signed-off-by: John Snow --- scripts/qapi/common.py | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/scripts/qapi/common.py b/scripts/qapi/common.py index c665e67495..4c079755d3 100644 --- a/scripts/qapi/common.py +++ b/scripts/qapi/common.py @@ -30,14 +30,14 @@ def

[PATCH 15/37] qapi/common.py: split build_params into new file

2020-09-15 Thread John Snow
Including it in common.py creates a circular import dependency, because schema relies on common.py. To type build_params properly, it needs to be moved outside of the chain. Signed-off-by: John Snow --- scripts/qapi/commands.py | 2 +- scripts/qapi/common.py | 23 ---

[PATCH 23/37] qapi/source.py: delint with pylint

2020-09-15 Thread John Snow
Shush an error and leave a hint for future cleanups when we're allowed to use Python 3.7+. Signed-off-by: John Snow --- scripts/qapi/pylintrc | 1 - scripts/qapi/source.py | 3 +++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/scripts/qapi/pylintrc b/scripts/qapi/pylintrc index

[PATCH 09/37] qapi/common.py: Add indent manager

2020-09-15 Thread John Snow
Code style tools really dislike the use of global keywords, because it generally involves re-binding the name at runtime which can have strange effects depending on when and how that global name is referenced in other modules. Make a little indent level manager instead. Signed-off-by: John Snow

[PATCH 08/37] qapi/common.py: Remove python compatibility workaround

2020-09-15 Thread John Snow
Signed-off-by: John Snow --- scripts/qapi/common.py | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/scripts/qapi/common.py b/scripts/qapi/common.py index ba35abea47..4fb265a8bf 100644 --- a/scripts/qapi/common.py +++ b/scripts/qapi/common.py @@ -119,10 +119,7 @@ def

[PATCH 13/37] qapi/common.py: add notational type hints

2020-09-15 Thread John Snow
Signed-off-by: John Snow --- scripts/qapi/common.py | 27 --- 1 file changed, 16 insertions(+), 11 deletions(-) diff --git a/scripts/qapi/common.py b/scripts/qapi/common.py index 4c079755d3..af01348b35 100644 --- a/scripts/qapi/common.py +++ b/scripts/qapi/common.py @@

[PATCH 14/37] qapi/common.py: Move comments into docstrings

2020-09-15 Thread John Snow
As docstrings, they'll show up in documentation and IDE help. Signed-off-by: John Snow --- scripts/qapi/common.py | 50 ++ 1 file changed, 36 insertions(+), 14 deletions(-) diff --git a/scripts/qapi/common.py b/scripts/qapi/common.py index

[PATCH 05/37] qapi: Remove wildcard includes

2020-09-15 Thread John Snow
Wildcard includes become hard to manage when refactoring and dealing with circular dependencies with strictly typed mypy. Remove them and include things explicitly by name instead. Signed-off-by: John Snow --- scripts/qapi/commands.py | 6 +- scripts/qapi/events.py | 7 ++-

[PATCH 06/37] qapi: delint using flake8

2020-09-15 Thread John Snow
Petty style guide fixes and line length enforcement. Not a big win, not a big loss, but flake8 passes 100% on the qapi module, which gives us an easy baseline to enforce hereafter. Signed-off-by: John Snow --- scripts/qapi/.flake8 | 2 ++ scripts/qapi/commands.py | 3 ++-

[PATCH 07/37] qapi: add pylintrc

2020-09-15 Thread John Snow
Add a skeleton pylintrc file. Right now, it ignores quite a few things. Files will be removed from the known-bad list throughout this and following series as they are repaired. Note: Normally, pylintrc would go in the folder above the module, but as that folder is shared by many things, it is

[PATCH 03/37] qapi-gen: Separate arg-parsing from generation

2020-09-15 Thread John Snow
This is a minor re-work of the entrypoint script. It isolates a generate() method from the actual command-line mechanism. Signed-off-by: John Snow --- scripts/qapi-gen.py | 87 - 1 file changed, 63 insertions(+), 24 deletions(-) diff --git

[PATCH 10/37] qapi/common.py: delint with pylint

2020-09-15 Thread John Snow
Signed-off-by: John Snow --- scripts/qapi/common.py | 16 +++- scripts/qapi/schema.py | 14 +++--- 2 files changed, 14 insertions(+), 16 deletions(-) diff --git a/scripts/qapi/common.py b/scripts/qapi/common.py index 87d87b95e5..c665e67495 100644 --- a/scripts/qapi/common.py

[PATCH 04/37] qapi: move generator entrypoint into module

2020-09-15 Thread John Snow
As part of delinting and adding type hints to the QAPI generator, it's helpful for the entrypoint to be part of the module, only leaving a very tiny entrypoint shim outside of the module. As a result, all of the include statements are reworked to be module-aware, as explicit relative imports.

[PATCH 00/37] qapi: static typing conversion, pt1

2020-09-15 Thread John Snow
Hi, this series starts adding static type hints to the QAPI module. As you can see, the series started getting quite a bit long, so this is only a partial conversion that focuses on a handful of the easier files. The tougher files -- schema.py, expr.py, parser.py -- will each receive their own

[PATCH 02/37] [DO-NOT-MERGE] qapi: add debugging tools

2020-09-15 Thread John Snow
This adds some really childishly simple debugging tools. Maybe they're interesting for someone else, too? Signed-off-by: John Snow --- scripts/qapi/debug.py | 78 +++ 1 file changed, 78 insertions(+) create mode 100644 scripts/qapi/debug.py diff --git

[PATCH 01/37] python: Require 3.6+

2020-09-15 Thread John Snow
Python 3.5 is now EOL. Python 3.6 brings with it several nice things: - Literal string interpolation (PEP 498) - Syntax for variable annotations (PEP 526) - Preserving keyword argument order (PEP 468) * PEP 526 in particular will allow us to convert the QAPI module to the statically typed subset

Re: [PATCH 1/5] qom: Allow objects to be allocated with increased alignment

2020-09-15 Thread Eduardo Habkost
On Tue, Sep 15, 2020 at 02:30:34PM -0700, Richard Henderson wrote: > On 9/15/20 2:27 PM, Eduardo Habkost wrote: > > On Tue, Sep 15, 2020 at 01:51:48PM -0700, Richard Henderson wrote: > >> On 9/15/20 1:19 PM, Eduardo Habkost wrote: > >>> Once we move to C11, we can just use max_align_t. > >> > >>

[PATCH v3 0/5] Qemu SEV-ES guest support

2020-09-15 Thread Tom Lendacky
From: Tom Lendacky This patch series provides support for launching an SEV-ES guest. Secure Encrypted Virtualization - Encrypted State (SEV-ES) expands on the SEV support to protect the guest register state from the hypervisor. See "AMD64 Architecture Programmer's Manual Volume 2: System

[ANNOUNCE] QEMU 5.0.1 Stable released

2020-09-15 Thread Michael Roth
Hi everyone, I am pleased to announce that the QEMU v5.0.1 stable release is now available: You can grab the tarball from our download page here: https://www.qemu.org/download/#source v5.0.1 is now tagged in the official qemu.git repository, and the stable-5.0 branch has been updated

[PATCH v3 5/5] sev/i386: Enable an SEV-ES guest based on SEV policy

2020-09-15 Thread Tom Lendacky
From: Tom Lendacky Update the sev_es_enabled() function return value to be based on the SEV policy that has been specified. SEV-ES is enabled if SEV is enabled and the SEV-ES policy bit is set in the policy object. Signed-off-by: Tom Lendacky --- target/i386/sev.c | 4 +++- 1 file changed, 3

[PATCH v3 4/5] sev/i386: Don't allow a system reset under an SEV-ES guest

2020-09-15 Thread Tom Lendacky
From: Tom Lendacky An SEV-ES guest does not allow register state to be altered once it has been measured. When a SEV-ES guest issues a reboot command, Qemu will reset the vCPU state and resume the guest. This will cause failures under SEV-ES, so prevent that from occurring. Signed-off-by: Tom

Re: [PATCH 1/5] qom: Allow objects to be allocated with increased alignment

2020-09-15 Thread Richard Henderson
On 9/15/20 2:27 PM, Eduardo Habkost wrote: > On Tue, Sep 15, 2020 at 01:51:48PM -0700, Richard Henderson wrote: >> On 9/15/20 1:19 PM, Eduardo Habkost wrote: >>> Once we move to C11, we can just use max_align_t. >> >> Yes. >> >>> While we don't move to C11, why not just use >>> __alignof__(union

[PATCH v3 2/5] sev/i386: Require in-kernel irqchip support for SEV-ES guests

2020-09-15 Thread Tom Lendacky
From: Tom Lendacky In prep for AP booting, require the use of in-kernel irqchip support. This lessens the Qemu support burden required to boot APs. Signed-off-by: Tom Lendacky --- target/i386/sev.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/target/i386/sev.c b/target/i386/sev.c

[PATCH v3 3/5] sev/i386: Allow AP booting under SEV-ES

2020-09-15 Thread Tom Lendacky
From: Tom Lendacky When SEV-ES is enabled, it is not possible modify the guests register state after it has been initially created, encrypted and measured. Normally, an INIT-SIPI-SIPI request is used to boot the AP. However, the hypervisor cannot emulate this because it cannot update the AP

[PATCH v3 1/5] sev/i386: Add initial support for SEV-ES

2020-09-15 Thread Tom Lendacky
From: Tom Lendacky Provide initial support for SEV-ES. This includes creating a function to indicate the guest is an SEV-ES guest (which will return false until all support is in place), performing the proper SEV initialization and ensuring that the guest CPU state is measured as part of the

Re: [PATCH 1/5] qom: Allow objects to be allocated with increased alignment

2020-09-15 Thread Eduardo Habkost
On Tue, Sep 15, 2020 at 01:51:48PM -0700, Richard Henderson wrote: > On 9/15/20 1:19 PM, Eduardo Habkost wrote: > > Once we move to C11, we can just use max_align_t. > > Yes. > > > While we don't move to C11, why not just use > > __alignof__(union { long l; void *p; double d; long double ld;})

[REPORT] Nightly Performance Tests - Tuesday, September 15, 2020

2020-09-15 Thread Ahmed Karaman
Host CPU : Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz Host Memory : 15.49 GB Start Time (UTC) : 2020-09-15 20:40:01 End Time (UTC) : 2020-09-15 21:12:43 Execution Time : 0:32:41.290408 Status : SUCCESS Note: Changes denoted by '-' are less than 0.01%.

[Bug 1892604] Re: qemu-system-arm: ../hw/usb/hcd-dwc2.c:666: dwc2_glbreg_read: Assertion `addr <= GINTSTS2' failed.

2020-09-15 Thread Petunia
Nope: qemu-system-arm -M raspi2 -m 1G -dtb bcm2709-rpi-2-b.dtb -kernel kernel7.img -append "rw earlyprintk loglevel=8 console=ttyAMA0,115200 dwc_otg.lpm_enable=0 root=/dev/mmcblk0p2 dwc_otg.fiq_fsm_enable=0" -sd 2016-05-27-raspbian-jessie.img -smp 4 -serial stdio -display none raspberrypi login:

Re: [PATCH 1/5] qom: Allow objects to be allocated with increased alignment

2020-09-15 Thread Richard Henderson
On 9/15/20 1:19 PM, Eduardo Habkost wrote: > Once we move to C11, we can just use max_align_t. Yes. > While we don't move to C11, why not just use > __alignof__(union { long l; void *p; double d; long double ld;}) > ? For i386, this is 4. r~

Re: [PATCH v3 01/15] hw/block/nvme: Define 64 bit cqe.result

2020-09-15 Thread Klaus Jensen
On Sep 15 20:44, Dmitry Fomichev wrote: > > -Original Message- > > From: Klaus Jensen > > Sent: Tuesday, September 15, 2020 3:56 PM > > To: Dmitry Fomichev > > Cc: Fam Zheng ; Kevin Wolf ; > > Damien Le Moal ; qemu-bl...@nongnu.org; > > Niklas Cassel ; Klaus Jensen > > ;

Re: [PATCH v3 14/15] hw/block/nvme: Use zone metadata file for persistence

2020-09-15 Thread Klaus Jensen
On Sep 15 20:44, Dmitry Fomichev wrote: > > -Original Message- > > From: Klaus Jensen > > Sent: Tuesday, September 15, 2020 3:10 PM > > To: Dmitry Fomichev > > Cc: Keith Busch ; Klaus Jensen > > ; Kevin Wolf ; Philippe > > Mathieu-Daudé ; Maxim Levitsky > > ; Fam Zheng ; Niklas Cassel >

RE: [PATCH v3 01/15] hw/block/nvme: Define 64 bit cqe.result

2020-09-15 Thread Dmitry Fomichev
> -Original Message- > From: Klaus Jensen > Sent: Tuesday, September 15, 2020 3:56 PM > To: Dmitry Fomichev > Cc: Fam Zheng ; Kevin Wolf ; > Damien Le Moal ; qemu-bl...@nongnu.org; > Niklas Cassel ; Klaus Jensen > ; qemu-devel@nongnu.org; Alistair Francis > ; Keith Busch ; Philippe >

RE: [PATCH v3 14/15] hw/block/nvme: Use zone metadata file for persistence

2020-09-15 Thread Dmitry Fomichev
> -Original Message- > From: Klaus Jensen > Sent: Tuesday, September 15, 2020 3:10 PM > To: Dmitry Fomichev > Cc: Keith Busch ; Klaus Jensen > ; Kevin Wolf ; Philippe > Mathieu-Daudé ; Maxim Levitsky > ; Fam Zheng ; Niklas Cassel > ; Damien Le Moal ; > qemu-bl...@nongnu.org;

Re: [PATCH 1/5] qom: Allow objects to be allocated with increased alignment

2020-09-15 Thread Eduardo Habkost
On Tue, Sep 15, 2020 at 12:09:59PM -0700, Richard Henderson wrote: > On 9/15/20 11:07 AM, Eduardo Habkost wrote: > > On Tue, Sep 15, 2020 at 10:46:31AM -0700, Richard Henderson wrote: > >> It turns out that some hosts have a default malloc alignment less > >> than that required for vectors. > >> >

[Bug 1892604] Re: qemu-system-arm: ../hw/usb/hcd-dwc2.c:666: dwc2_glbreg_read: Assertion `addr <= GINTSTS2' failed.

2020-09-15 Thread Paul Zimmerman
Are you able to modify the -append string to add "dwc_otg.fiq_fsm_enable=0", and if so does it fix the problem? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1892604 Title: qemu-system-arm:

Re: [PATCH v8 4/7] scripts: add block-coroutine-wrapper.py

2020-09-15 Thread Vladimir Sementsov-Ogievskiy
15.09.2020 19:44, Vladimir Sementsov-Ogievskiy wrote: We have a very frequent pattern of creating coroutine from function with several arguments: - create structure to pack parameters - create _entry function to call original function taking parameters from struct - do different

Re: [PATCH v6 0/8] s390: Extended-Length SCCB & DIAGNOSE 0x318

2020-09-15 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200915194416.107460-1-wall...@linux.ibm.com/ Hi, This series failed build test on FreeBSD host. Please find the details below. === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under the git checkout with # HEAD pointing to a

Re: [PATCH v3 01/15] hw/block/nvme: Define 64 bit cqe.result

2020-09-15 Thread Klaus Jensen
On Sep 15 18:56, Dmitry Fomichev wrote: > > -Original Message- > > From: Klaus Jensen > > Sent: Tuesday, September 15, 2020 3:37 AM > > To: Dmitry Fomichev > > Cc: Keith Busch ; Klaus Jensen > > ; Kevin Wolf ; Philippe > > Mathieu-Daudé ; Maxim Levitsky > > ; Fam Zheng ; Niklas Cassel >

[PATCH v6 6/8] s390/sclp: add extended-length sccb support for kvm guest

2020-09-15 Thread Collin Walling
As more features and facilities are added to the Read SCP Info (RSCPI) response, more space is required to store them. The space used to store these new features intrudes on the space originally used to store CPU entries. This means as more features and facilities are added to the RSCPI response,

[PATCH v6 7/8] s390/kvm: header sync for diag318

2020-09-15 Thread Collin Walling
Signed-off-by: Collin Walling --- linux-headers/asm-s390/kvm.h | 7 +-- linux-headers/linux/kvm.h| 1 + 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/linux-headers/asm-s390/kvm.h b/linux-headers/asm-s390/kvm.h index 0138ccb0d8..f053b8304a 100644 ---

[PATCH v6 2/8] s390/sclp: rework sclp boundary checks

2020-09-15 Thread Collin Walling
Rework the SCLP boundary check to account for different SCLP commands (eventually) allowing different boundary sizes. Signed-off-by: Collin Walling Acked-by: Janosch Frank Reviewed-by: Cornelia Huck --- hw/s390x/sclp.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-)

[PATCH v6 4/8] s390/sclp: check sccb len before filling in data

2020-09-15 Thread Collin Walling
The SCCB must be checked for a sufficient length before it is filled with any data. If the length is insufficient, then the SCLP command is suppressed and the proper response code is set in the SCCB header. While we're at it, let's cleanup the length check by placing the calculation inside a

[PATCH v6 5/8] s390/sclp: use cpu offset to locate cpu entries

2020-09-15 Thread Collin Walling
The start of the CPU entry region in the Read SCP Info response data is denoted by the offset_cpu field. As such, QEMU needs to begin creating entries at this address. This is in preparation for when Read SCP Info inevitably introduces new bytes that push the start of the CPUEntry field further

[PATCH v6 1/8] s390/sclp: get machine once during read scp/cpu info

2020-09-15 Thread Collin Walling
Functions within read scp/cpu info will need access to the machine state. Let's make a call to retrieve the machine state once and pass the appropriate data to the respective functions. Signed-off-by: Collin Walling Reviewed-by: David Hildenbrand Reviewed-by: Thomas Huth Reviewed-by: Janosch

[PATCH v6 8/8] s390: guest support for diagnose 0x318

2020-09-15 Thread Collin Walling
DIAGNOSE 0x318 (diag318) is an s390 instruction that allows the storage of diagnostic information that is collected by the firmware in the case of hardware/firmware service events. QEMU handles the instruction by storing the info in the CPU state. A subsequent register sync will communicate the

[PATCH v6 0/8] s390: Extended-Length SCCB & DIAGNOSE 0x318

2020-09-15 Thread Collin Walling
Changelog: v6 • sccb_verify_boundary function: • s/len/sccb_len • removed the endian check/conversion of the sccb_len from within this function (caller is now responsible) • proper endian conversion when using header length to malloc • use g_autofree

[PATCH v6 3/8] s390/sclp: read sccb from mem based on provided length

2020-09-15 Thread Collin Walling
The header contained within the SCCB passed to the SCLP service call contains the actual length of the SCCB. Instead of allocating a static 4K size for the work sccb, let's allow for a variable size determined by the value in the header. The proper checks are already in place to ensure the SCCB

[PATCH v3 4/5] s390x/pci: Add routine to get the vfio dma available count

2020-09-15 Thread Matthew Rosato
Create new files for separating out vfio-specific work for s390 pci. Add the first such routine, which issues VFIO_IOMMU_GET_INFO ioctl to collect the current dma available count. Signed-off-by: Matthew Rosato --- hw/s390x/meson.build | 1 + hw/s390x/s390-pci-vfio.c | 54

[PATCH v3 2/5] vfio: Create shared routine for scanning info capabilities

2020-09-15 Thread Matthew Rosato
Rather than duplicating the same loop in multiple locations, create a static function to do the work. Signed-off-by: Matthew Rosato --- hw/vfio/common.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/hw/vfio/common.c b/hw/vfio/common.c index

[PATCH v3 1/5] linux-headers: update against 5.9-rc5

2020-09-15 Thread Matthew Rosato
PLACEHOLDER as the kernel patch driving the need for this ("vfio iommu: Add dma available capability") is not merged yet. Signed-off-by: Matthew Rosato --- include/standard-headers/drm/drm_fourcc.h | 140 + include/standard-headers/linux/ethtool.h | 87

Re: [PATCH] guest agent: Fixes for windows guest agent building on msys2/mingw

2020-09-15 Thread Yonggang Luo
On Wed, Sep 16, 2020 at 1:55 AM Philippe Mathieu-Daudé wrote: > > On 9/15/20 7:41 PM, 罗勇刚(Yonggang Luo) wrote: > > On Wed, Sep 16, 2020 at 12:41 AM Philippe Mathieu-Daudé > > mailto:phi...@redhat.com>> wrote: > >> > >> On 9/15/20 6:33 PM, Yonggang Luo wrote: > >> > error message: > >> > "cc"

[PATCH v3 0/5] s390x/pci: Accomodate vfio DMA limiting

2020-09-15 Thread Matthew Rosato
Kernel commit 492855939bdb added a limit to the number of outstanding DMA requests for a type1 vfio container. However, lazy unmapping in s390 can in fact cause quite a large number of outstanding DMA requests to build up prior to being purged, potentially the entire guest DMA space. This

[PATCH v3 3/5] vfio: Find DMA available capability

2020-09-15 Thread Matthew Rosato
The underlying host may be limiting the number of outstanding DMA requests for type 1 IOMMU. Add helper functions to check for the DMA available capability and retrieve the current number of DMA mappings allowed. Signed-off-by: Matthew Rosato --- hw/vfio/common.c | 31

  1   2   3   4   5   >