[PATCH v2 7/8] qemu/bswap: Use compiler __builtin_bswap() on NetBSD

2020-09-28 Thread Philippe Mathieu-Daudé
Since commit efc6c070aca ("configure: Add a test for the minimum compiler version") the minimum compiler version required for GCC is 4.8, which supports __builtin_bswap(). Remove the NetBSD specific ifdef'ry. This reverts commit 1360677cfe3ca8f945fa1de77823df21a77e4500 ("makes NetBSD use the nativ

Re: [PATCH v2 1/9] s390x/cpu_model: S390_FEAT_MISC_INSTRUCTION_EXT -> S390_FEAT_MISC_INSTRUCTION_EXT2

2020-09-28 Thread Christian Borntraeger
On 28.09.20 14:27, David Hildenbrand wrote: > Let's avoid confusion with the "Miscellaneous-Instruction-Extensions > Facility 1" > > Suggested-by: Thomas Huth > Cc: Christian Borntraeger > Signed-off-by: David Hildenbrand > --- > target/s390x/cpu_features_def.h.inc | 2 +- strange this is t

[PULL 1/5] usb/hcd-xhci: Make dma read/writes hooks pci free

2020-09-28 Thread Gerd Hoffmann
From: Sai Pavan Boddu This patch starts making the hcd-xhci.c pci free, as part of this restructuring dma read/writes are handled without passing pci object. Signed-off-by: Sai Pavan Boddu Reviewed-by: Edgar E. Iglesias Message-id: 1600957256-6494-2-git-send-email-sai.pavan.bo...@xilinx.com Si

[PULL 3/5] usb/hcd-xhci: Split pci wrapper for xhci base model

2020-09-28 Thread Gerd Hoffmann
From: Sai Pavan Boddu This patch sets the base to use xhci as sysbus model, for which pci specific hooks are moved to hcd-xhci-pci.c. As a part of this requirment msi/msix interrupts handling is moved under XHCIPCIState. Made required changes for qemu-xhci-nec. Signed-off-by: Sai Pavan Boddu Me

Re: [PATCH] hw/usb: Use lock guard macros

2020-09-28 Thread Gerd Hoffmann
On Wed, Sep 23, 2020 at 07:13:27PM +0530, Amey Narkhede wrote: > Use qemu LOCK_GUARD macros from "qemu/lockable.h" in > hw/usb/ccid-card-emulated.c, saves manual unlock calls. > > Signed-off-by: Amey Narkhede Added to usb queue. thanks, Gerd

Re: [PATCH v6 02/21] qapi/block.json: Add newline after "Example:" for block-latency-histogram-set

2020-09-28 Thread Peter Maydell
On Mon, 28 Sep 2020 at 13:42, Markus Armbruster wrote: > > Peter Maydell writes: > > > The block-latency-histogram-set command is the only one which uses > > the Example/Examples section with the first line of the documentation > > immediately following the ':'. Bring it into line with the rest.

[PULL 4/5] usb: hcd-xhci-sysbus: Attach xhci to sysbus device

2020-09-28 Thread Gerd Hoffmann
From: Sai Pavan Boddu Use XHCI as sysbus device, add memory region property to get the address space instance for dma read/write. Signed-off-by: Sai Pavan Boddu Message-id: 1600957256-6494-5-git-send-email-sai.pavan.bo...@xilinx.com Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-xhci-sysbus.h |

[PULL 2/5] usb/hcd-xhci: Move qemu-xhci device to hcd-xhci-pci.c

2020-09-28 Thread Gerd Hoffmann
From: Sai Pavan Boddu Move pci specific devices to new file. This set the environment to move all pci specific hooks in hcd-xhci.c to hcd-xhci-pci.c. Signed-off-by: Sai Pavan Boddu Message-id: 1600957256-6494-3-git-send-email-sai.pavan.bo...@xilinx.com Signed-off-by: Gerd Hoffmann --- hw/usb/

RE: [PATCH v1 1/3] i386: Remove the limitation of IP payloads for Intel PT

2020-09-28 Thread Kang, Luwei
> No, it's not possible. KVM doesn't have a say on what the > processor writes in the tracing packets. > >>> Can KVM refuse to enable packet generation if CSbase is not zero and > >>> CPUID.(EAX=14H,ECX=0)[bit 31] seen by guest is different from host? > >> > >> Yes, but the processor cou

[PATCH v9 5/9] copy-on-read: limit guest COR activity to base in COR driver

2020-09-28 Thread Andrey Shinkevich via
Limit the guest's COR operations by the base node in the backing chain when the base node name is given. It will be useful for a block stream job when the COR-filter is applied. Signed-off-by: Andrey Shinkevich --- block/copy-on-read.c | 38 -- 1 file changed,

Re: [PATCH v10 7/7] Versal: Connect DWC3 controller with virt-versal

2020-09-28 Thread Gerd Hoffmann
On Fri, Sep 25, 2020 at 08:39:46PM +0200, Edgar E. Iglesias wrote: > On Thu, Sep 24, 2020 at 07:50:56PM +0530, Sai Pavan Boddu wrote: > > From: Vikram Garhwal > > > > Connect dwc3 controller and usb2-reg module to xlnx-versal SOC, its placed > > in iou of lpd domain and configure it as dual port

[PULL 0/5] Usb 20200928 patches

2020-09-28 Thread Gerd Hoffmann
The following changes since commit 8d16e72f2d4df2c9e631393adf1669a1da7efe8a: Merge remote-tracking branch 'remotes/dgilbert/tags/pull-migration-20200925a' into staging (2020-09-25 14:46:18 +0100) are available in the Git repository at: git://git.kraxel.org/qemu tags/usb-202

Re: [External] Re: [PATCH] aspeed: Add support for the g220a-bmc board

2020-09-28 Thread 王志强
Cédric Le Goater, Sorry, I did not reply to all, this email is the same as the previous one. On Mon, Sep 28, 2020 at 3:55 PM Cédric Le Goater wrote: > > On 9/28/20 8:12 AM, John Wang wrote: > > G220A is a 2 socket x86 motherboard supported by OpenBMC. > > Strapping configuration was obtained fr

[PATCH v9 4/9] copy-on-read: pass base node name to COR driver

2020-09-28 Thread Andrey Shinkevich via
To limit the guest's COR operations by the base node in the backing chain during stream job, pass the base node name to the copy-on-read driver. The rest of the functionality will be implemented in the patch that follows. Signed-off-by: Andrey Shinkevich --- block/copy-on-read.c | 13 +++

Re: [PATCH v6 00/21] Convert QAPI doc comments to generate rST instead of texinfo

2020-09-28 Thread Markus Armbruster
Peter Maydell writes: > On Fri, 25 Sep 2020 at 20:25, wrote: > >> In file included from ../src/qapi/qapi-schema.json:78: >> ../src/qapi/migration.json:1747:1: unexpected de-indent (expected at least >> 13 spaces) > > This is yet another mis-indented line in a change to the QAPI > doc-comments (

[PATCH v2] aspeed: Add support for the g220a-bmc board

2020-09-28 Thread John Wang
G220A is a 2 socket x86 motherboard supported by OpenBMC. Strapping configuration was obtained from hardware. Signed-off-by: John Wang --- v2: - Add macs_mask --- hw/arm/aspeed.c | 36 1 file changed, 36 insertions(+) diff --git a/hw/arm/aspeed.c b/hw/arm/

Re: [PATCH 1/3] util/cutils: Introduce freq_to_str() to display Hertz units

2020-09-28 Thread Philippe Mathieu-Daudé
On 9/28/20 9:50 AM, Luc Michel wrote: > Hi Philippe, > > On 11:08 Sun 27 Sep , Philippe Mathieu-Daudé wrote: >> Introduce freq_to_str() to convert frequency values in human >> friendly units using the SI units for Hertz. >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> include/qemu/cuti

Re: [PULL v7 00/87] Misc patches for 2020-09-24

2020-09-28 Thread Peter Maydell
On Sat, 26 Sep 2020 at 00:26, Paolo Bonzini wrote: > > The following changes since commit 8c1c07929feae876202ba26f07a540c5115c18cd: > > Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' > into staging (2020-09-24 18:48:45 +0100) > > are available in the Git repository at:

[PATCH v9 8/9] block: remove unused backing-file name parameter

2020-09-28 Thread Andrey Shinkevich via
The block stream QMP parameter backing-file is in use no more. It designates a backing file name to set in QCOW2 image header after the block stream job finished. The base file name is used instead. Signed-off-by: Andrey Shinkevich --- block/monitor/block-hmp-cmds.c | 2 +- block/stream.c

[PATCH] aspeed: Add support for the g220a-bmc board

2020-09-28 Thread John Wang
G220A is a 2 socket x86 motherboard supported by OpenBMC. Strapping configuration was obtained from hardware. Signed-off-by: John Wang --- hw/arm/aspeed.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c index bdb981d2f8..

[RFC PATCH v4 29/29] Hexagon build infrastructure

2020-09-28 Thread Taylor Simpson
Add file to default-configs Change configure Add hexagon to meson.build Add hexagon to target/meson.build Add target/hexagon/meson.build Change scripts/qemu-binfmt-conf.sh We can build a hexagon-linux-user target and run programs on the Hexagon scalar core. With hexagon-linux-clang installed, "ma

[PATCH v9 7/9] stream: skip filters when writing backing file name to QCOW2 header

2020-09-28 Thread Andrey Shinkevich via
Avoid writing a filter JSON-name to QCOW2 image when the backing file is changed after the block stream job. Signed-off-by: Andrey Shinkevich --- block/stream.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/block/stream.c b/block/stream.c index e0540ee..b0719e9 100

[PATCH v9 1/9] copy-on-read: Support preadv/pwritev_part functions

2020-09-28 Thread Andrey Shinkevich via
Add support for the recently introduced functions bdrv_co_preadv_part() and bdrv_co_pwritev_part() to the COR-filter driver. Signed-off-by: Andrey Shinkevich Reviewed-by: Vladimir Sementsov-Ogievskiy --- block/copy-on-read.c | 28 1 file changed, 16 insertions(+), 1

[PATCH v9 2/9] copy-on-read: add filter append/drop functions

2020-09-28 Thread Andrey Shinkevich via
Provide API for the COR-filter insertion/removal. Also, drop the filter child permissions for an inactive state when the filter node is being removed. Signed-off-by: Andrey Shinkevich --- block/copy-on-read.c | 84 1 file changed, 84 insertion

[PATCH 2/3] qemu/atomic: Drop special case for unsupported compiler

2020-09-28 Thread Philippe Mathieu-Daudé
Since commit efc6c070aca ("configure: Add a test for the minimum compiler version") the minimum compiler version required for GCC is 4.8, which has the GCC BZ#36793 bug fixed. We can safely remove the special case introduced in commit a281ebc11a6 ("virtio: add missing mb() on notification"). Sign

Re: [PATCH] migration/dirtyrate: present dirty rate only when querying the rate has completed

2020-09-28 Thread Zheng Chuan
On 2020/9/28 20:23, David Edmondson wrote: > On Sunday, 2020-09-27 at 12:55:20 +08, Chuan Zheng wrote: > >> Make dirty_rate field optional, present dirty rate only when querying >> the rate has completed. >> The qmp results is shown as follow: >> @unstarted: >> {"return":{"status":"unstarted","

[PATCH v9 3/9] qapi: add filter-node-name to block-stream

2020-09-28 Thread Andrey Shinkevich via
Provide the possibility to pass the 'filter-node-name' parameter to the block-stream job as it is done for the commit block job. Signed-off-by: Andrey Shinkevich Reviewed-by: Vladimir Sementsov-Ogievskiy --- block/monitor/block-hmp-cmds.c | 4 ++-- block/stream.c | 4 +++- block

[PATCH 0/3] qemu/compiler: Remove unused special case code for GCC < 4.8

2020-09-28 Thread Philippe Mathieu-Daudé
Since commit efc6c070aca we require GCC 4.8 minimum. Drop the special cases for older versions. Philippe Mathieu-Daudé (3): qemu/compiler: Simplify as all compilers support attribute 'gnu_printf' qemu/atomic: Drop special case for unsupported compiler accel/tcg: Remove special case for G

[RFC PATCH v4 25/29] Hexagon (target/hexagon) TCG for instructions with multiple definitions

2020-09-28 Thread Taylor Simpson
Helpers won't work if there are multiple definitions, so we override these instructions using #define fGEN_TCG_. Signed-off-by: Taylor Simpson --- target/hexagon/gen_tcg.h | 198 +++ 1 file changed, 198 insertions(+) create mode 100644 target/hexagon/

Re: [PATCH v2 1/9] s390x/cpu_model: S390_FEAT_MISC_INSTRUCTION_EXT -> S390_FEAT_MISC_INSTRUCTION_EXT2

2020-09-28 Thread David Hildenbrand
On 28.09.20 14:50, Christian Borntraeger wrote: > > > On 28.09.20 14:27, David Hildenbrand wrote: >> Let's avoid confusion with the "Miscellaneous-Instruction-Extensions >> Facility 1" >> >> Suggested-by: Thomas Huth >> Cc: Christian Borntraeger >> Signed-off-by: David Hildenbrand >> --- >> t

Re: [PATCH 08/12] tests/9pfs: refactor test names and test devices

2020-09-28 Thread Paolo Bonzini
On 28/09/20 13:56, Christian Schoenebeck wrote: >> The implementation in patches 1 and 2 is reasonable, but what is the >> advantage of this as opposed to specifying the fsdev in the edge options >> for the test (similar to virtio-net)? I was expecting both >> virtio-9p-device-synth and virtio-9p-

[RFC PATCH v4 23/29] Hexagon (target/hexagon) instruction classes

2020-09-28 Thread Taylor Simpson
Determine legal VLIW slots for each instruction Signed-off-by: Taylor Simpson --- target/hexagon/iclass.h| 40 +++ target/hexagon/iclass.c| 80 ++ target/hexagon/imported/iclass.def | 52 + 3 file

[RFC PATCH v4 26/29] Hexagon (target/hexagon) translation

2020-09-28 Thread Taylor Simpson
Read the instruction memory Create a packet data structure Generate TCG code for the start of the packet Invoke the generate function for each instruction Generate TCG code for the end of the packet Signed-off-by: Taylor Simpson --- target/hexagon/translate.h | 89 ++ target/hexagon/transla

[RFC PATCH v4 22/29] Hexagon (target/hexagon) macros

2020-09-28 Thread Taylor Simpson
macros to interface with the generator macros referenced in instruction semantics Signed-off-by: Taylor Simpson --- target/hexagon/macros.h | 654 1 file changed, 654 insertions(+) create mode 100644 target/hexagon/macros.h diff --git a/target/h

Re: [PATCH v6 02/21] qapi/block.json: Add newline after "Example:" for block-latency-histogram-set

2020-09-28 Thread Markus Armbruster
Peter Maydell writes: > The block-latency-histogram-set command is the only one which uses > the Example/Examples section with the first line of the documentation > immediately following the ':'. Bring it into line with the rest. > > This allows us to avoid special-casing the indentation handling

[RFC PATCH v4 20/29] Hexagon (target/hexagon) generater phase 4 - decode tree

2020-09-28 Thread Taylor Simpson
Python script that emits the decode tree in dectree_generated.h. Signed-off-by: Taylor Simpson --- target/hexagon/dectree.py | 352 ++ 1 file changed, 352 insertions(+) create mode 100755 target/hexagon/dectree.py diff --git a/target/hexagon/dectree.

[RFC PATCH v4 24/29] Hexagon (target/hexagon) TCG generation

2020-09-28 Thread Taylor Simpson
Include the generated files and set up the data structures Signed-off-by: Taylor Simpson --- target/hexagon/genptr.h | 25 ++ target/hexagon/genptr.c | 234 2 files changed, 259 insertions(+) create mode 100644 target/hexagon/genptr.h creat

[RFC PATCH v4 21/29] Hexagon (target/hexagon) opcode data structures

2020-09-28 Thread Taylor Simpson
Signed-off-by: Taylor Simpson --- target/hexagon/opcodes.h | 66 target/hexagon/opcodes.c | 199 +++ 2 files changed, 265 insertions(+) create mode 100644 target/hexagon/opcodes.h create mode 100644 target/hexagon/opcodes.c diff --g

Re: [PATCH v6 01/21] qapi: Fix doc comment indentation again

2020-09-28 Thread Markus Armbruster
Peter Maydell writes: > In commit 26ec4e53f2 and similar commits we fixed the indentation > for doc comments in our qapi json files to follow a new stricter > standard for indentation, which permits only: > @arg: description line 1 > description line 2 > > or: > @arg: > line

[RFC PATCH v4 18/29] Hexagon (target/hexagon) generator phase 2 - generate header files

2020-09-28 Thread Taylor Simpson
Python scripts generate the following files helper_protos_generated.h For each instruction we create DEF_HELPER function prototype helper_funcs_generated.h For each instruction we create the helper function definition tcg_funcs_generated.h For each instruction we

[RFC PATCH v4 13/29] Hexagon (target/hexagon) instruction/packet decode

2020-09-28 Thread Taylor Simpson
Take the words from instruction memory and build a packet_t for TCG code generation The following operations are performed Convert the .new encoded offset to the register number of the producer Reorder the packet so .new producer is before consumer Apply constant extenders Separate

[RFC PATCH v4 27/29] Hexagon (linux-user/hexagon) Linux user emulation

2020-09-28 Thread Taylor Simpson
Implementation of Linux user emulation for Hexagon Some common files modified in addition to new files in linux-user/hexagon Signed-off-by: Taylor Simpson --- linux-user/hexagon/sockbits.h | 18 ++ linux-user/hexagon/syscall_nr.h | 343 linux-user/

[RFC PATCH v4 17/29] Hexagon (target/hexagon) generator phase 1 - C preprocessor for semantics

2020-09-28 Thread Taylor Simpson
Run the C preprocessor across the instruction definition files and macro definitoin file to expand macros and prepare the semantics_generated.pyinc file. The resulting file contains one entry with the semantics for each instruction and one line with the instruction attributes associated with each

[RFC PATCH v4 12/29] Hexagon (target/hexagon) instruction attributes

2020-09-28 Thread Taylor Simpson
Signed-off-by: Taylor Simpson --- target/hexagon/attribs.h | 32 +++ target/hexagon/attribs_def.h | 98 2 files changed, 130 insertions(+) create mode 100644 target/hexagon/attribs.h create mode 100644 target/hexagon/attribs_def.h di

[RFC PATCH v4 15/29] Hexagon (target/hexagon) utility functions

2020-09-28 Thread Taylor Simpson
Utility functions called by various instructions Signed-off-by: Taylor Simpson --- target/hexagon/arch.h | 42 +++ target/hexagon/conv_emu.h | 50 +++ target/hexagon/fma_emu.h | 27 ++ target/hexagon/arch.c | 354 + target/hexagon/conv_emu.c | 369

[RFC PATCH v4 09/29] Hexagon (target/hexagon) architecture types

2020-09-28 Thread Taylor Simpson
Define types used in files imported from the Hexagon architecture library Signed-off-by: Taylor Simpson --- target/hexagon/hex_arch_types.h | 43 + 1 file changed, 43 insertions(+) create mode 100644 target/hexagon/hex_arch_types.h diff --git a/target/he

[RFC PATCH v4 01/29] Hexagon Update MAINTAINERS file

2020-09-28 Thread Taylor Simpson
Add Taylor Simpson as the Hexagon target maintainer Signed-off-by: Taylor Simpson --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 3d17cad..3aaafb3 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -185,6 +185,14 @@ F: include/hw/cris/ F: t

[RFC PATCH v4 04/29] Hexagon (target/hexagon) scalar core definition

2020-09-28 Thread Taylor Simpson
Add target state header, target definitions and initialization routines Signed-off-by: Taylor Simpson --- target/hexagon/cpu-param.h | 29 + target/hexagon/cpu.h | 159 +++ target/hexagon/cpu_bits.h | 34 + target/hexagon/internal.h | 36 ++ target/hexa

[RFC PATCH v4 14/29] Hexagon (target/hexagon) instruction printing

2020-09-28 Thread Taylor Simpson
Signed-off-by: Taylor Simpson --- target/hexagon/printinsn.h | 26 + target/hexagon/printinsn.c | 91 ++ 2 files changed, 117 insertions(+) create mode 100644 target/hexagon/printinsn.h create mode 100644 target/hexagon/printinsn.c diff -

[RFC PATCH v4 10/29] Hexagon (target/hexagon) instruction and packet types

2020-09-28 Thread Taylor Simpson
The insn_t and packet_t are the interface between instruction decoding and TCG code generation Signed-off-by: Taylor Simpson --- target/hexagon/insn.h | 74 +++ 1 file changed, 74 insertions(+) create mode 100644 target/hexagon/insn.h diff --git

[RFC PATCH v4 19/29] Hexagon (target/hexagon) generator phase 3 - C preprocessor for decode tree

2020-09-28 Thread Taylor Simpson
Run the C preprocessor across the instruction definition and encoding files to expand macros and prepare the iset.py file. The resulting fill contains python data structures used to build the decode tree. Signed-off-by: Taylor Simpson --- target/hexagon/gen_dectree_import.c | 191 ++

[RFC PATCH v4 05/29] Hexagon (disas) disassembler

2020-09-28 Thread Taylor Simpson
Add hexagon to disas/meson.build Add disas/hexagon.c Add hexagon to include/disas/dis-asm.h Signed-off-by: Taylor Simpson --- include/disas/dis-asm.h | 1 + disas/hexagon.c | 62 + disas/meson.build | 1 + 3 files changed, 64 insert

[RFC PATCH v4 08/29] Hexagon (target/hexagon) GDB Stub

2020-09-28 Thread Taylor Simpson
GDB register read and write routines Signed-off-by: Taylor Simpson --- target/hexagon/internal.h | 3 +++ target/hexagon/cpu.c | 2 ++ target/hexagon/gdbstub.c | 47 +++ 3 files changed, 52 insertions(+) create mode 100644 target/hexagon/gdbst

[RFC PATCH v4 07/29] Hexagon (target/hexagon) scalar core helpers

2020-09-28 Thread Taylor Simpson
The majority of helpers are generated. Define the helper functions needed then include the generated file Signed-off-by: Taylor Simpson --- target/hexagon/helper.h| 31 target/hexagon/op_helper.c | 381 + 2 files changed, 412 insertions(+)

[RFC PATCH v4 02/29] Hexagon (target/hexagon) README

2020-09-28 Thread Taylor Simpson
Gives an introduction and overview to the Hexagon target Signed-off-by: Taylor Simpson --- target/hexagon/README | 236 ++ 1 file changed, 236 insertions(+) create mode 100644 target/hexagon/README diff --git a/target/hexagon/README b/target/hexa

[RFC PATCH v4 06/29] Hexagon (target/hexagon) register names

2020-09-28 Thread Taylor Simpson
Signed-off-by: Taylor Simpson --- target/hexagon/hex_regs.h | 83 +++ 1 file changed, 83 insertions(+) create mode 100644 target/hexagon/hex_regs.h diff --git a/target/hexagon/hex_regs.h b/target/hexagon/hex_regs.h new file mode 100644 index 000..

[PATCH v2 6/9] s390x/tcg: Implement BRANCH INDIRECT ON CONDITION (BIC)

2020-09-28 Thread David Hildenbrand
Just like BRANCH ON CONDITION - however the address is read from memory (always 8 bytes are read), we have to wrap the address manually. The address is read using current CPU DAT/address-space controls, just like ordinary data. Signed-off-by: David Hildenbrand --- target/s390x/insn-data.def | 2

[RFC PATCH v4 03/29] Hexagon (include/elf.h) ELF machine definition

2020-09-28 Thread Taylor Simpson
Define EM_HEXAGON 164 Signed-off-by: Taylor Simpson Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- include/elf.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/elf.h b/include/elf.h index c117a4d..141a86f 100644 --- a/include/elf.h +++ b/include/elf.h

[RFC PATCH v4 11/29] Hexagon (target/hexagon) register fields

2020-09-28 Thread Taylor Simpson
Declare bitfields within registers such as user status register (USR) Signed-off-by: Taylor Simpson --- target/hexagon/reg_fields.h | 36 target/hexagon/reg_fields_def.h | 41 + target/hexagon/reg_fields.c | 28

[PATCH v2 7/9] s390x/tcg: Implement MULTIPLY SINGLE (MSC, MSGC, MSGRKC, MSRKC)

2020-09-28 Thread David Hildenbrand
We need new CC handling, determining the CC based on the intermediate result (64bit for MSC and MSRKC, 128bit for MSGC and MSGRKC). We want to store out2 ("low") after muls128 to r1, so add "wout_out2_r1". Signed-off-by: David Hildenbrand --- target/s390x/cc_helper.c | 32

[PATCH v2 3/9] s390x/tcg: Implement SUBTRACT HALFWORD (SGH)

2020-09-28 Thread David Hildenbrand
Easy to wire up. Reviewed-by: Thomas Huth Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/insn-data.def | 1 + 1 file changed, 1 insertion(+) diff --git a/target/s390x/insn-data.def b/target/s390x/insn-data.def index 8dbeaf8c49..e851e9df5e 100644 --- a/target/

[PATCH v2 5/9] s390x/tcg: Implement MULTIPLY HALFWORD (MGH)

2020-09-28 Thread David Hildenbrand
Just like MULTIPLY HALFWORD IMMEDIATE (MGHI), only the second operand (signed 16 bit) comes from memory. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/insn-data.def | 1 + 1 file changed, 1 insertion(+) diff --git a/target/s390x/insn-data.def b/target/s390x/i

[PATCH v2 9/9] s390x/tcg: Implement CIPHER MESSAGE WITH AUTHENTICATION (KMA)

2020-09-28 Thread David Hildenbrand
As with the other crypto functions, we only implement subcode 0 (query) and no actual encryption/decryption. We now implement S390_FEAT_MSA_EXT_8. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/gen-features.c | 1 + target/s390x/insn-data.def | 1 + target/s39

[PATCH v2 4/9] s390x/tcg: Implement MULTIPLY (MG, MGRK)

2020-09-28 Thread David Hildenbrand
Multiply two signed 64bit values and store the 128bit result in r1 (0-63) and r1 + 1 (64-127). Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/insn-data.def | 2 ++ target/s390x/translate.c | 13 + 2 files changed, 15 insertions(+) diff --git a/t

[PATCH v2 8/9] s390x/tcg: We support Miscellaneous-Instruction-Extensions Facility 2

2020-09-28 Thread David Hildenbrand
We implement all relevant instructions. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/gen-features.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/s390x/gen-features.c b/target/s390x/gen-features.c index 210cee65f3..00af4f95bd 100644 --- a/target/

[PATCH v2 0/9] s390x/tcg: Implement some z14 facilities

2020-09-28 Thread David Hildenbrand
With this patchset, I can boot a kernel compiled for z14 (requiring Miscellaneous-Instruction-Extensions Facility 2) (using -cpu max). I am currently working on "vector-enhancements facility 1", I have most stuff in place except: - VECTOR FP (MAXIMUM|MINIMUM): needs some manual work to cover all t

[PATCH v2 2/9] s390x/tcg: Implement ADD HALFWORD (AGH)

2020-09-28 Thread David Hildenbrand
Easy, just like ADD HALFWORD IMMEDIATE (AGHI). Reviewed-by: Thomas Huth Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/insn-data.def | 1 + target/s390x/translate.c | 1 + 2 files changed, 2 insertions(+) diff --git a/target/s390x/insn-data.def b/target/s39

[PATCH v2 1/9] s390x/cpu_model: S390_FEAT_MISC_INSTRUCTION_EXT -> S390_FEAT_MISC_INSTRUCTION_EXT2

2020-09-28 Thread David Hildenbrand
Let's avoid confusion with the "Miscellaneous-Instruction-Extensions Facility 1" Suggested-by: Thomas Huth Cc: Christian Borntraeger Signed-off-by: David Hildenbrand --- target/s390x/cpu_features_def.h.inc | 2 +- target/s390x/gen-features.c | 2 +- 2 files changed, 2 insertions(+), 2

Re: [PATCH] migration/dirtyrate: present dirty rate only when querying the rate has completed

2020-09-28 Thread David Edmondson
On Sunday, 2020-09-27 at 12:55:20 +08, Chuan Zheng wrote: > Make dirty_rate field optional, present dirty rate only when querying > the rate has completed. > The qmp results is shown as follow: > @unstarted: > {"return":{"status":"unstarted","start-time":0,"calc-time":0},"id":"libvirt-12"} > @meas

Re: [PATCH v7 07/13] monitor: Make current monitor a per-coroutine property

2020-09-28 Thread Markus Armbruster
Kevin Wolf writes: > Am 28.09.2020 um 09:47 hat Markus Armbruster geschrieben: >> Kevin Wolf writes: >> >> > Am 14.09.2020 um 17:11 hat Markus Armbruster geschrieben: >> >> Kevin Wolf writes: >> >> >> >> > This way, a monitor command handler will still be able to access the >> >> > current mo

Re: [PATCH v3 12/47] qapi: enforce import order/styling with isort

2020-09-28 Thread Markus Armbruster
John Snow writes: > On 9/25/20 5:20 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> While we're mucking around with imports, we might as well formalize the >>> style we use. Let's use isort to do it for us. >>> >>> force_sort_within_sections: Intermingles "from x" and "import x" style

Re: [PATCH v1 6/8] s390x/tcg: Implement MULTIPLY SINGLE (MSC, MSGC, MSGRKC, MSRKC)

2020-09-28 Thread David Hildenbrand
On 26.09.20 00:06, Richard Henderson wrote: > On 9/22/20 3:31 AM, David Hildenbrand wrote: >> +static uint32_t cc_calc_muls_32(int64_t res) >> +{ >> +/* Arithmetic shift with sign extension so we can compare against >> -1ull. */ >> +const uint64_t tmp = res >> 31; >> + >> +if (!res) {

Re: [PATCH 06/12] tests/qtest/qos-test: add environment variable QTEST_DEBUG

2020-09-28 Thread Christian Schoenebeck
On Montag, 28. September 2020 10:31:21 CEST Paolo Bonzini wrote: > On 27/09/20 12:40, Christian Schoenebeck wrote: > > For now this new environment variable QTEST_DEBUG will cause the > > assembled qemu command line to be printed before running each test. > > > > Signed-off-by: Christian Schoenebe

Re: [PATCH v2 28/38] qapi/gen.py: update write() to be more idiomatic

2020-09-28 Thread Markus Armbruster
Eric Blake writes: > On 9/25/20 8:52 AM, Markus Armbruster wrote: > This was my best attempt to open the file read/write, creating it if it doesn't exist. Plain f = open(pathname, "r+", encoding='utf-8') fails instead of creates, and

Re: [PATCH v4 0/4] Introducing QMP query-netdev command

2020-09-28 Thread Alexey Kirillov
Ping 21.09.2020 22:19, Alexey Kirillov writes: > This patch series introduces a new QMP command "query-netdev" to get > information about currently attached backend network devices (netdevs). > Also, since the "info_str" field of "NetClientState" is now deprecated, > we no longer use it for netdev

Re: [PATCH v2 24/38] qapi/gen.py: Fix edge-case of _is_user_module

2020-09-28 Thread Markus Armbruster
Eduardo Habkost writes: > On Fri, Sep 25, 2020 at 11:15:28AM -0400, Eduardo Habkost wrote: >> On Fri, Sep 25, 2020 at 03:00:51PM +0200, Markus Armbruster wrote: >> > Eduardo Habkost writes: >> > >> > > On Tue, Sep 22, 2020 at 05:00:47PM -0400, John Snow wrote: >> > >> The edge case is that if t

PING: [PATCH v2 0/3] add MEMORY_FAILURE event

2020-09-28 Thread zhenwei pi
PING On 9/22/20 5:56 PM, zhenwei pi wrote: v1->v2: Suggested by Peter Maydell, rename events to make them architecture-neutral: 'PC-RAM' -> 'guest-memory' 'guest-triple-fault' -> 'guest-mce-fatal' Suggested by Paolo, add more fields in event: 'action-required': boolean type to distinguish a gue

Re: [PATCH v1 0/8] s390x/tcg: Implement some z14 facilities

2020-09-28 Thread David Hildenbrand
On 26.09.20 00:43, Richard Henderson wrote: > On 9/22/20 3:31 AM, David Hildenbrand wrote: >> With this patchset, I can boot a kernel compiled for z14 (requiring >> Miscellaneous-Instruction-Extensions Facility 2) (using -cpu max). > > Excellent. > > Looks like it wouldn't take too much additiona

Re: [PATCH 08/12] tests/9pfs: refactor test names and test devices

2020-09-28 Thread Christian Schoenebeck
On Montag, 28. September 2020 10:37:52 CEST Paolo Bonzini wrote: > On 27/09/20 12:40, Christian Schoenebeck wrote: > > +qos_node_consumes("virtio-9p-device-local", "virtio-bus", &opts); > > +qos_node_produces("virtio-9p-device-local", "virtio-local"); > > This should produce "virtio", simi

[PATCH v2 5/5] virito-mem: Implement get_min_alignment()

2020-09-28 Thread David Hildenbrand
The block size determines the alignment requirements. Implement get_min_alignment() of the TYPE_MEMORY_DEVICE interface. This allows auto-assignment of a properly aligned address in guest physical address space. For example, when specifying a 2GB block size for a virtio-mem device with 10GB with a

Re: [PATCH v1 5/8] s390x/tcg: Implement BRANCH INDIRECT ON CONDITION (BIC)

2020-09-28 Thread David Hildenbrand
On 25.09.20 23:45, Richard Henderson wrote: > On 9/22/20 3:31 AM, David Hildenbrand wrote: >> +/* BRANCH INDIRECT ON CONDITION */ >> +C(0xe347, BIC, RXY_b, MIE2,0, m2_64, 0, 0, bc, 0) >> /* BRANCH ON CONDITION */ >> C(0x0700, BCR, RR_b, Z, 0, r2_nz, 0, 0, bc, 0) >> C(0x470

[PATCH v2 3/5] memory-device: Support big alignment requirements

2020-09-28 Thread David Hildenbrand
Let's warn instead of bailing out - the worst thing that can happen is that we'll fail hot/coldplug later. The user got warned, and this should be rare. This will be necessary for memory devices with rather big (user-defined) alignment requirements - say a virtio-mem device with a 2G block size -

[PATCH v2 2/5] virtio-mem: Check that "memaddr" is multiples of the block size

2020-09-28 Thread David Hildenbrand
The spec requires us to set the "addr" in guest physical address space to multiples of the block size. In some cases, this is not the case right now: For example, when starting a VM with 4 GiB boot memory and a virtio-mem device with a block size of 2 GiB, "memaddr" will be auto-assigned to 0x14000

Re: [PATCH v2 18/38] qapi/events.py: Move comments into docstrings

2020-09-28 Thread Markus Armbruster
John Snow writes: > On 9/25/20 8:19 AM, Markus Armbruster wrote: >> What about: >> Generate a QAPI struct variable holding the event parameters, >> initialized with the function's arguments. > > Line length and style-guide limitations; docstrings need a one-liner > summary. They do! >

[PATCH v2 1/5] virtio-mem: Probe THP size to determine default block size

2020-09-28 Thread David Hildenbrand
Let's allow a minimum block size of 1 MiB in all configurations. Select the default block size based on - The page size of the memory backend. - The THP size if the memory backend size corresponds to the real hsot page size. - The global minimum of 1 MiB. and warn if something smaller is configur

[PATCH v2 4/5] memory-device: Add get_min_alignment() callback

2020-09-28 Thread David Hildenbrand
Add a callback that can be used to express additional alignment requirements (exceeding the ones from the memory region). Will be used by virtio-mem to express special alignment requirements due to manually configured, big block sizes (e.g., 1GB with an ordinary memory-backend-ram). This avoids fa

[PATCH v2 0/5] virtio-mem: block size and address-assignment optimizations

2020-09-28 Thread David Hildenbrand
Let's try to detect the actual THP size and use it as default block size (unless the page size of the backend indicates that THP don't apply). Always allow to set a block size of 1 MiB, but warn if the configured block size is smaller than the default. Handle large block sizes better, avoiding a vi

Re: [PATCH v2 02/38] qapi-gen: Separate arg-parsing from generation

2020-09-28 Thread Markus Armbruster
John Snow writes: > On 9/25/20 7:34 AM, Markus Armbruster wrote: >> Cleber Rosa writes: >> >>> On Tue, Sep 22, 2020 at 05:00:25PM -0400, John Snow wrote: This is a minor re-work of the entrypoint script. It isolates a generate() method from the actual command-line mechanism.

Re: [RFC PATCH v6 0/2] Add file-backed and write-once features to OTP

2020-09-28 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200928101146.12786-1-green@sifive.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN =

Re: [PATCH v7 06/13] qmp: Call monitor_set_cur() only in qmp_dispatch()

2020-09-28 Thread Markus Armbruster
Kevin Wolf writes: > Am 14.09.2020 um 17:10 hat Markus Armbruster geschrieben: >> Kevin Wolf writes: >> >> > The correct way to set the current monitor for a coroutine handler will >> > be different than for a blocking handler, so monitor_set_cur() needs to >> > be called in qmp_dispatch(). >>

Re: [PATCH] vfio-ccw: plug memory leak while getting region info

2020-09-28 Thread Philippe Mathieu-Daudé
On 9/28/20 12:17 PM, Cornelia Huck wrote: > vfio_get_dev_region_info() unconditionally allocates memory > for a passed-in vfio_region_info structure (and does not re-use > an already allocated structure). Therefore, we have to free > the structure we pass to that function in vfio_ccw_get_region() >

Re: [PATCH v4 0/4] Introducing QMP query-netdev command

2020-09-28 Thread Alexey Kirillov
Ping 21.09.2020 22:19, Alexey Kirillov writes:> This patch series introduces a new QMP command "query-netdev" to get> information about currently attached backend network devices (netdevs).> Also, since the "info_str" field of "NetClientState" is now deprecated,> we no longer use it for netdevs, on

Re: Outline for VHOST_USER_PROTOCOL_F_VDPA

2020-09-28 Thread Marc-André Lureau
Hi On Mon, Sep 28, 2020 at 1:25 PM Stefan Hajnoczi Where this converges with multi-process QEMU > > At this point QEMU can run ad-hoc vhost-user backends using existing > VIRTIO device models. It is possible to go further by creating a > qemu-dev launc

Re: [PATCH] tests/venv: force compatible avocado-framework-plugin-result-html version

2020-09-28 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200928100902.28638-1-kra...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #

Re: [PATCH] pci: check bus pointer before dereference

2020-09-28 Thread P J P
Hello, +-- On Wed, 16 Sep 2020, Peter Maydell wrote --+ | On Wed, 16 Sep 2020 at 07:28, P J P wrote: | > -> https://ruhr-uni-bochum.sciebo.de/s/NNWP2GfwzYKeKwE?path=%2Flsi_nullptr1 | > ==1183858==Hint: address points to the zero page. | > #0 pci_change_irq_level hw/pci/pci.c:259 | > #1 pci_irq_

Re: [PATCH 3/3] hw/qdev-clock: Display error hint when clock is missing from device

2020-09-28 Thread Edgar E. Iglesias
On Mon, Sep 28, 2020 at 12:45:15PM +0200, Damien Hedde wrote: > > > On 9/28/20 9:53 AM, Luc Michel wrote: > > On 11:08 Sun 27 Sep , Philippe Mathieu-Daudé wrote: > >> Instead of directly aborting, display a hint to help the developer > >> figure out the problem (likely trying to connect a clo

Re: [PATCH v6] nvme: allow cmb and pmr emulation on same device

2020-09-28 Thread Klaus Jensen
On Jul 29 15:01, Andrzej Jakowski wrote: > Resending series recently posted on mailing list related to nvme device > extension with couple of fixes after review. > > This patch series does following: > - Fixes problem where CMBS bit was not set in controller capabilities >register, so support

Re: [RFC PATCH 0/7] block-backend: Introduce I/O hang

2020-09-28 Thread Kevin Wolf
Am 27.09.2020 um 15:04 hat Ying Fang geschrieben: > A VM in the cloud environment may use a virutal disk as the backend storage, > and there are usually filesystems on the virtual block device. When backend > storage is temporarily down, any I/O issued to the virtual block device will > cause an er

[PATCH v3 00/12] microvm: add pcie support

2020-09-28 Thread Gerd Hoffmann
v2: - move aml generator to gpex and have arm virt + microvm share it. - add 64bit window. - add testcase. v3: - fix testcase: force tcg, disable on i386. Gerd Hoffmann (12): move MemMapEntry acpi: add acpi_dsdt_add_gpex arm: use acpi_dsdt_add_gpex microvm: add irq table microvm: add

[PATCH v3 09/12] tests/acpi: factor out common microvm test setup

2020-09-28 Thread Gerd Hoffmann
... into new test_acpi_microvm_prepare helper Signed-off-by: Gerd Hoffmann Reviewed-by: Michael S. Tsirkin --- tests/qtest/bios-tables-test.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c inde

<    1   2   3   4   >