[RFC v5 43/68] target/riscv: rvv-1.0: narrowing integer right shift instructions

2020-09-29 Thread frank . chang
From: Frank Chang Signed-off-by: Frank Chang Reviewed-by: Richard Henderson --- target/riscv/helper.h | 24 ++-- target/riscv/insn32.decode | 12 +- target/riscv/insn_trans/trans_rvv.c.inc | 30 -

[RFC v5 40/68] target/riscv: rvv-1.0: single-width averaging add and subtract instructions

2020-09-29 Thread frank . chang
From: Frank Chang Add the following instructions: * vaaddu.vv * vaaddu.vx * vasubu.vv * vasubu.vx Remove the following instructions: * vadd.vi Signed-off-by: Frank Chang Reviewed-by: Richard Henderson --- target/riscv/helper.h | 16 ++ target/riscv/insn32.decode

[RFC v5 27/68] target/riscv: rvv-1.0: floating-point classify instructions

2020-09-29 Thread frank . chang
From: Frank Chang Signed-off-by: Frank Chang Reviewed-by: Richard Henderson --- target/riscv/insn32.decode | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/riscv/insn32.decode b/target/riscv/insn32.decode index 6c95a3460a..958914458d 100644 ---

[RFC v5 24/68] target/riscv: rvv-1.0: update vext_max_elems() for load/store insns

2020-09-29 Thread frank . chang
From: Frank Chang Signed-off-by: Frank Chang --- target/riscv/insn_trans/trans_rvv.c.inc | 32 +++-- target/riscv/vector_helper.c| 90 ++--- 2 files changed, 74 insertions(+), 48 deletions(-) diff --git a/target/riscv/insn_trans/trans_rvv.c.inc

[RFC v5 39/68] target/riscv: rvv-1.0: integer extension instructions

2020-09-29 Thread frank . chang
From: Frank Chang Add the following instructions: * vzext.vf2 * vzext.vf4 * vzext.vf8 * vsext.vf2 * vsext.vf4 * vsext.vf8 Signed-off-by: Frank Chang Reviewed-by: Richard Henderson --- target/riscv/helper.h | 14 + target/riscv/insn32.decode | 8 +++

[RFC v5 36/68] target/riscv: rvv-1.0: floating-point move instruction

2020-09-29 Thread frank . chang
From: Frank Chang NaN-boxed the scalar floating-point register based on RVV 1.0's rules. Signed-off-by: Frank Chang --- target/riscv/insn_trans/trans_rvv.c.inc | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/target/riscv/insn_trans/trans_rvv.c.inc

[RFC v5 23/68] target/riscv: rvv-1.0: load/store whole register instructions

2020-09-29 Thread frank . chang
From: Frank Chang Add the following instructions: * vlre.v * vsr.v Signed-off-by: Frank Chang --- target/riscv/helper.h | 21 target/riscv/insn32.decode | 22 target/riscv/insn_trans/trans_rvv.c.inc | 69 +

[RFC v5 21/68] target/riscv: rvv-1.0: fault-only-first unit stride load

2020-09-29 Thread frank . chang
From: Frank Chang Signed-off-by: Frank Chang Reviewed-by: Richard Henderson --- target/riscv/helper.h | 27 +++- target/riscv/insn32.decode | 14 +++ target/riscv/insn_trans/trans_rvv.c.inc | 33 --- target/riscv/vector_helper.c

[RFC v5 38/68] target/riscv: rvv-1.0: whole register move instructions

2020-09-29 Thread frank . chang
From: Frank Chang Add the following instructions: * vmv1r.v * vmv2r.v * vmv4r.v * vmv8r.v Signed-off-by: Frank Chang --- target/riscv/insn32.decode | 4 target/riscv/insn_trans/trans_rvv.c.inc | 25 + 2 files changed, 29 insertions(+) diff --git

[RFC v5 31/68] target/riscv: rvv-1.0: iota instruction

2020-09-29 Thread frank . chang
From: Frank Chang Signed-off-by: Frank Chang Reviewed-by: Richard Henderson --- target/riscv/insn32.decode | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/riscv/insn32.decode b/target/riscv/insn32.decode index 0fed7c9e56..33b4612a69 100644 ---

[RFC v5 19/68] target/riscv: rvv-1.0: index load and store instructions

2020-09-29 Thread frank . chang
From: Frank Chang Signed-off-by: Frank Chang --- target/riscv/helper.h | 67 - target/riscv/insn32.decode | 21 ++- target/riscv/insn_trans/trans_rvv.c.inc | 190 target/riscv/vector_helper.c| 89 ++- 4

[RFC v5 22/68] target/riscv: rvv-1.0: amo operations

2020-09-29 Thread frank . chang
From: Frank Chang Signed-off-by: Frank Chang --- target/riscv/helper.h | 100 +++--- target/riscv/insn32-64.decode | 18 +- target/riscv/insn32.decode | 36 +++- target/riscv/insn_trans/trans_rvv.c.inc | 229 +++

[RFC v5 30/68] target/riscv: rvv-1.0: set-X-first mask bit instructions

2020-09-29 Thread frank . chang
From: Frank Chang Signed-off-by: Frank Chang Reviewed-by: Richard Henderson --- target/riscv/insn32.decode | 6 +++--- target/riscv/insn_trans/trans_rvv.c.inc | 5 - target/riscv/vector_helper.c| 4 3 files changed, 7 insertions(+), 8 deletions(-) diff --git

[RFC v5 29/68] target/riscv: rvv-1.0: find-first-set mask bit instruction

2020-09-29 Thread frank . chang
From: Frank Chang Signed-off-by: Frank Chang Reviewed-by: Richard Henderson --- target/riscv/helper.h | 2 +- target/riscv/insn32.decode | 2 +- target/riscv/insn_trans/trans_rvv.c.inc | 4 ++-- target/riscv/vector_helper.c| 6 +++--- 4 files

[RFC v5 18/68] target/riscv: rvv-1.0: stride load and store instructions

2020-09-29 Thread frank . chang
From: Frank Chang Signed-off-by: Frank Chang --- target/riscv/helper.h | 129 +++--- target/riscv/insn32.decode | 43 +++-- target/riscv/insn_trans/trans_rvv.c.inc | 227 +++- target/riscv/vector_helper.c| 190

[RFC v5 15/68] target/riscv: introduce more imm value modes in translator functions

2020-09-29 Thread frank . chang
From: Frank Chang Immediate value in translator function is extended not only zero-extended and sign-extended but with more modes to be applicable with multiple formats of vector instructions. * IMM_ZX: Zero-extended * IMM_SX: Sign-extended * IMM_TRUNC_SEW: Truncate to log(SEW)

[RFC v5 14/68] target/riscv: rvv-1.0: update check functions

2020-09-29 Thread frank . chang
From: Frank Chang Update check functions with RVV 1.0 rules. Signed-off-by: Frank Chang --- target/riscv/insn_trans/trans_rvv.c.inc | 735 1 file changed, 502 insertions(+), 233 deletions(-) diff --git a/target/riscv/insn_trans/trans_rvv.c.inc

[RFC v5 20/68] target/riscv: rvv-1.0: fix address index overflow bug of indexed load/store insns

2020-09-29 Thread frank . chang
From: Frank Chang Replace ETYPE from signed int to unsigned int to prevent index overflow issue, which would lead to wrong index address. Signed-off-by: Frank Chang Reviewed-by: Richard Henderson --- target/riscv/vector_helper.c | 8 1 file changed, 4 insertions(+), 4 deletions(-)

[RFC v5 09/68] target/riscv: rvv-1.0: add vlenb register

2020-09-29 Thread frank . chang
From: Greentime Hu Signed-off-by: Greentime Hu Signed-off-by: Frank Chang Reviewed-by: Richard Henderson --- target/riscv/cpu_bits.h | 1 + target/riscv/csr.c | 7 +++ 2 files changed, 8 insertions(+) diff --git a/target/riscv/cpu_bits.h b/target/riscv/cpu_bits.h index

[RFC v5 11/68] target/riscv: rvv-1.0: remove MLEN calculations

2020-09-29 Thread frank . chang
From: Frank Chang As in RVV 1.0 design, MLEN is hardcoded with value 1 (Section 4.5). Thus, remove all MLEN related calculations. Signed-off-by: Frank Chang Reviewed-by: Richard Henderson --- target/riscv/insn_trans/trans_rvv.c.inc | 35 +--- target/riscv/internals.h| 9 +-

[RFC v5 17/68] target/riscv: rvv-1.0: configure instructions

2020-09-29 Thread frank . chang
From: Frank Chang Signed-off-by: Frank Chang Reviewed-by: Richard Henderson --- target/riscv/insn_trans/trans_rvv.c.inc | 14 ++ target/riscv/vector_helper.c| 14 +- 2 files changed, 23 insertions(+), 5 deletions(-) diff --git

[RFC v5 08/68] target/riscv: rvv-1.0: add vcsr register

2020-09-29 Thread frank . chang
From: LIU Zhiwei Signed-off-by: LIU Zhiwei Signed-off-by: Frank Chang Reviewed-by: Richard Henderson --- target/riscv/cpu_bits.h | 7 +++ target/riscv/csr.c | 21 + 2 files changed, 28 insertions(+) diff --git a/target/riscv/cpu_bits.h b/target/riscv/cpu_bits.h

[RFC v5 12/68] target/riscv: rvv-1.0: add fractional LMUL

2020-09-29 Thread frank . chang
From: Frank Chang Introduce the concepts of fractional LMUL for RVV 1.0. In RVV 1.0, LMUL bits are contiguous in vtype register. Signed-off-by: Frank Chang Reviewed-by: Richard Henderson --- target/riscv/cpu.h | 15 --- target/riscv/translate.c | 16 ++--

[RFC v5 06/68] target/riscv: rvv-1.0: add translation-time vector context status

2020-09-29 Thread frank . chang
From: Frank Chang Signed-off-by: LIU Zhiwei Signed-off-by: Frank Chang Reviewed-by: Richard Henderson --- target/riscv/insn_trans/trans_rvv.c.inc | 70 - target/riscv/translate.c| 33 2 files changed, 90 insertions(+), 13 deletions(-)

[RFC v5 16/68] target/riscv: rvv:1.0: add translation-time nan-box helper function

2020-09-29 Thread frank . chang
From: Frank Chang * Add fp16 nan-box check generator function, if a 16-bit input is not properly nanboxed, then the input is replaced with the default qnan. * Add do_nanbox() helper function to utilize gen_check_nanbox_X() to generate the NaN-boxed floating-point values based on SEW setting.

[RFC v5 10/68] target/riscv: rvv-1.0: check MSTATUS_VS when accessing vector csr registers

2020-09-29 Thread frank . chang
From: Frank Chang If VS field is off, accessing vector csr registers should raise an illegal-instruction exception. Signed-off-by: Frank Chang Reviewed-by: Richard Henderson --- target/riscv/csr.c | 5 + 1 file changed, 5 insertions(+) diff --git a/target/riscv/csr.c

[RFC v5 07/68] target/riscv: rvv-1.0: remove rvv related codes from fcsr registers

2020-09-29 Thread frank . chang
From: Frank Chang * Remove VXRM and VXSAT fields from FCSR register as they are only presented in VCSR register. * Remove RVV loose check in fs() predicate function. Signed-off-by: Frank Chang Reviewed-by: Richard Henderson --- target/riscv/csr.c | 13 - 1 file changed, 13

[RFC v5 05/68] target/riscv: rvv-1.0: introduce writable misa.v field

2020-09-29 Thread frank . chang
From: Frank Chang Implementations may have a writable misa.v field. Analogous to the way in which the floating-point unit is handled, the mstatus.vs field may exist even if misa.v is clear. Signed-off-by: Frank Chang Reviewed-by: Richard Henderson --- target/riscv/csr.c | 2 +- 1 file

[RFC v5 03/68] target/riscv: rvv-1.0: add mstatus VS field

2020-09-29 Thread frank . chang
From: LIU Zhiwei Signed-off-by: LIU Zhiwei Signed-off-by: Frank Chang Reviewed-by: Richard Henderson --- target/riscv/cpu.h| 6 ++ target/riscv/cpu_bits.h | 1 + target/riscv/cpu_helper.c | 16 +++- target/riscv/csr.c| 25 - 4 files

[RFC v5 02/68] target/riscv: Use FIELD_EX32() to extract wd field

2020-09-29 Thread frank . chang
From: Frank Chang Signed-off-by: Frank Chang Reviewed-by: Richard Henderson --- target/riscv/vector_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/riscv/vector_helper.c b/target/riscv/vector_helper.c index a156573d28..bc3f212cea 100644 ---

[RFC v5 01/68] target/riscv: drop vector 0.7.1 and add 1.0 support

2020-09-29 Thread frank . chang
From: Frank Chang Signed-off-by: Frank Chang Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis --- target/riscv/cpu.c | 10 +- target/riscv/cpu.h | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index

[RFC v5 04/68] target/riscv: rvv-1.0: add sstatus VS field

2020-09-29 Thread frank . chang
From: LIU Zhiwei Signed-off-by: LIU Zhiwei Signed-off-by: Frank Chang Reviewed-by: Richard Henderson --- target/riscv/cpu_bits.h | 1 + target/riscv/csr.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/target/riscv/cpu_bits.h b/target/riscv/cpu_bits.h index

[RFC v5 00/68] support vector extension v1.0

2020-09-29 Thread frank . chang
From: Frank Chang This patchset implements the vector extension v1.0 for RISC-V on QEMU. This patchset is sent as RFC because RVV v1.0 is still in draft state. v2 patchset was sent for RVV v0.9 and bumped to RVV v1.0 since v3 patchset. The port is available here:

Re: [PATCH v4 00/14] hw/block/nvme: Support Namespace Types and Zoned Namespace Command Set

2020-09-29 Thread Klaus Jensen
On Sep 29 15:42, Dmitry Fomichev wrote: > > -Original Message- > > From: Klaus Jensen > > Sent: Monday, September 28, 2020 2:37 AM > > To: Dmitry Fomichev > > Cc: Keith Busch ; Damien Le Moal > > ; Klaus Jensen ; Kevin > > Wolf ; Philippe Mathieu-Daudé ; > > Maxim Levitsky ; Fam Zheng ;

Re: Outline for VHOST_USER_PROTOCOL_F_VDPA

2020-09-29 Thread Stefan Hajnoczi
On Tue, Sep 29, 2020 at 06:04:34AM -0400, Michael S. Tsirkin wrote: > On Tue, Sep 29, 2020 at 09:57:51AM +0100, Stefan Hajnoczi wrote: > > On Tue, Sep 29, 2020 at 02:09:55AM -0400, Michael S. Tsirkin wrote: > > > On Mon, Sep 28, 2020 at 10:25:37AM +0100, Stefan Hajnoczi wrote: > > > > Why extend

Re: [PATCH v4 00/14] hw/block/nvme: Support Namespace Types and Zoned Namespace Command Set

2020-09-29 Thread Klaus Jensen
On Sep 29 18:17, Matias Bjorling wrote: > > > > -Original Message- > > From: Klaus Jensen > > Sent: Tuesday, 29 September 2020 20.00 > > To: Keith Busch > > Cc: Damien Le Moal ; Fam Zheng > > ; Kevin Wolf ; qemu- > > bl...@nongnu.org; Niklas Cassel ; Klaus Jensen > > ;

Re: [PATCH v3 06/47] [DO-NOT-MERGE] docs: enable sphinx-autodoc for scripts/qapi

2020-09-29 Thread John Snow
On 9/29/20 12:00 AM, Cleber Rosa wrote: On Thu, Sep 24, 2020 at 08:28:19PM -0400, John Snow wrote: Signed-off-by: John Snow --- docs/conf.py | 6 +- docs/devel/index.rst | 1 + docs/devel/python/index.rst | 7 +++

Re: [PATCH v3 17/19] hw/arm: Automatically select the 'virt' machine on KVM

2020-09-29 Thread Philippe Mathieu-Daudé
On 3/16/20 9:06 PM, Richard Henderson wrote: > On 3/16/20 9:06 AM, Philippe Mathieu-Daudé wrote: >> When building a KVM-only QEMU, the 'virt' machine is a good >> default :) >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> hw/arm/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff

Re: [PATCH v3 03/47] [DO-NOT-MERGE] docs/sphinx: change default role to "any"

2020-09-29 Thread John Snow
On 9/28/20 11:30 PM, Cleber Rosa wrote: On Thu, Sep 24, 2020 at 08:28:16PM -0400, John Snow wrote: Signed-off-by: John Snow --- docs/conf.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/docs/conf.py b/docs/conf.py index 0dbd90dc11..a68f616d5a 100644 --- a/docs/conf.py +++

Re: [PATCH v3 05/47] qapi/doc.py: Change code templates from function to string

2020-09-29 Thread John Snow
On 9/28/20 11:51 PM, Cleber Rosa wrote: On Thu, Sep 24, 2020 at 08:28:18PM -0400, John Snow wrote: For whatever reason, when these are stored as functions instead of strings, it confuses sphinx-autodoc into believing them to be docstrings, and it chokes on the syntax. Interesting...

Re: [PATCH] PoC: Rust binding for QAPI (qemu-ga only, for now)

2020-09-29 Thread Paolo Bonzini
On 29/09/20 19:55, Marc-André Lureau wrote: > My understanding of what you propose is: > - ForeignConvert::with_foreign > - FromForeign::from_foreign (with implied into_native) > And: > - ForeignConvert::as_foreign (with the BorrowedPointer/stash-like) > - ToForeign::to_foreign +

Re: [PATCH v4 00/14] hw/block/nvme: Support Namespace Types and Zoned Namespace Command Set

2020-09-29 Thread Klaus Jensen
On Sep 29 11:15, Keith Busch wrote: > On Tue, Sep 29, 2020 at 08:00:04PM +0200, Klaus Jensen wrote: > > On Sep 29 10:29, Keith Busch wrote: > > > On Tue, Sep 29, 2020 at 12:46:33PM +0200, Klaus Jensen wrote: > > > > It is unmistakably clear that you are invalidating my arguments about > > > >

Re: [PATCH v3 02/47] [DO-NOT-MERGE] docs: repair broken references

2020-09-29 Thread John Snow
On 9/28/20 11:14 PM, Cleber Rosa wrote: On Thu, Sep 24, 2020 at 08:28:15PM -0400, John Snow wrote: Signed-off-by: John Snow --- docs/devel/multi-thread-tcg.rst | 2 +- docs/devel/testing.rst | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 1/1] docs: repair broken references

2020-09-29 Thread John Snow
In two different places, we are making a cross-reference to some resource incorrectly. These were being interpreted as "content" instead of a link and a reference, accordingly. Signed-off-by: John Snow --- docs/devel/multi-thread-tcg.rst | 2 +- docs/devel/testing.rst | 2 +- 2 files

[Bug 1897783] [NEW] avocado tests not running on aarch64 host

2020-09-29 Thread Philippe Mathieu-Daudé
Public bug reported: $ lsb_release -a No LSB modules are available. Distributor ID: Ubuntu Description:Ubuntu 20.04.1 LTS Release:20.04 Codename: focal $ make check-venv VENV/home/phil/qemu/build/tests/venv PIP /home/phil/qemu/tests/requirements.txt ERROR: Command

[PATCH 0/1] docs: repair broken references

2020-09-29 Thread John Snow
Found while doing other work for the QAPI generator. John Snow (1): docs: repair broken references docs/devel/multi-thread-tcg.rst | 2 +- docs/devel/testing.rst | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) -- 2.26.2

Re: [PATCH v4 00/14] hw/block/nvme: Support Namespace Types and Zoned Namespace Command Set

2020-09-29 Thread Keith Busch
On Tue, Sep 29, 2020 at 08:00:04PM +0200, Klaus Jensen wrote: > On Sep 29 10:29, Keith Busch wrote: > > On Tue, Sep 29, 2020 at 12:46:33PM +0200, Klaus Jensen wrote: > > > It is unmistakably clear that you are invalidating my arguments about > > > portability and endianness issues by suggesting

Re: [PATCH] job: delete job_{lock, unlock} functions and replace them with lock guard

2020-09-29 Thread John Snow
On 9/29/20 9:42 AM, Elena Afanasova wrote: Signed-off-by: Elena Afanasova Hi, can I have a commit message here, please? --- job.c | 46 +- 1 file changed, 17 insertions(+), 29 deletions(-) diff --git a/job.c b/job.c index

[PATCH v2 2/2] hw/arm/sbsa-ref: add SBSA watchdog device

2020-09-29 Thread Shashi Mallela
Included the newly implemented SBSA generic watchdog device model into SBSA platform Signed-off-by: Shashi Mallela --- hw/arm/sbsa-ref.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/hw/arm/sbsa-ref.c b/hw/arm/sbsa-ref.c index 257ada942550..99a16f3c93ba 100644 ---

[PATCH v2 0/2] Add watchdog support for SbsaQemu

2020-09-29 Thread Shashi Mallela
This patch series adds watchdog timer support for SbsaQemu platform. The watchdog timer has been implemented first based on the generic watchdog timer specifications from ARM BSA v0.9 and then used in the SbsaQemu reference platform Changes in v2: - split the previous single patch into 2 -

[PATCH v2 1/2] hw/watchdog: Implement SBSA watchdog device

2020-09-29 Thread Shashi Mallela
Generic watchdog device model has been implemented as per ARM BSAv0.9 Signed-off-by: Shashi Mallela --- hw/arm/Kconfig | 1 + hw/watchdog/Kconfig | 4 + hw/watchdog/meson.build | 1 + hw/watchdog/wdt_sbsa_gwdt.c | 344

Re: [PATCH v4 00/14] hw/block/nvme: Support Namespace Types and Zoned Namespace Command Set

2020-09-29 Thread Klaus Jensen
On Sep 29 10:29, Keith Busch wrote: > On Tue, Sep 29, 2020 at 12:46:33PM +0200, Klaus Jensen wrote: > > It is unmistakably clear that you are invalidating my arguments about > > portability and endianness issues by suggesting that we just remove > > persistent state and deal with it later, but

Re: [PATCH] PoC: Rust binding for QAPI (qemu-ga only, for now)

2020-09-29 Thread Marc-André Lureau
Hi On Fri, Sep 11, 2020 at 7:17 PM Paolo Bonzini wrote: > On 11/09/20 16:00, Marc-André Lureau wrote: > > - from_qemu_none should be a "to_*" or "constructor" conversion (I > used > > new_from_foreign) > > > > new_ prefix is not very rusty. > > Right, I have changed it to with_foreign

Re: [PATCH 4/4] qemu-storage-daemon: Remove QemuOpts from --object parser

2020-09-29 Thread Eric Blake
On 9/29/20 12:26 PM, Kevin Wolf wrote: > The command line parser for --object parses the input twice: Once into > QemuOpts just for detecting help options, and then again into a QDict > using the keyval parser for actually creating the object. > > Now that the keyval parser can also detect help

Re: [PATCH 3/4] qom: Add user_creatable_print_help_from_qdict()

2020-09-29 Thread Eric Blake
On 9/29/20 12:26 PM, Kevin Wolf wrote: > This adds a function that, given a QDict of non-help options, prints > help for user creatable objects. > > Signed-off-by: Kevin Wolf > --- > include/qom/object_interfaces.h | 9 + > qom/object_interfaces.c | 9 + > 2 files

Re: [PATCH 2/4] qom: Factor out helpers from user_creatable_print_help()

2020-09-29 Thread Eric Blake
On 9/29/20 12:26 PM, Kevin Wolf wrote: > This creates separate helper functions for printing a list of user > creatable object types and for printing a list of properties of a given > type. This allows using these parts without having a QemuOpts. > > Signed-off-by: Kevin Wolf > --- >

Re: [PATCH 1/4] keyval: Parse help options

2020-09-29 Thread Eric Blake
On 9/29/20 12:26 PM, Kevin Wolf wrote: > This adds a new parameter 'help' to keyval_parse() that enables parsing > of help options. If NULL is passed, the function behaves the same as > before. But if a bool pointer is given, it contains the information > whether an option "help" without value was

Re: [RFC 0/3] QEMU as IPMI BMC emulator

2020-09-29 Thread Corey Minyard
On Mon, Sep 28, 2020 at 05:39:13PM -0700, Havard Skinnemoen via wrote: > This series briefly documents the existing IPMI device support for main > processor emulation, and goes on to propose a similar device structure to > emulate IPMI responder devices in BMC machines. This would allow a qemu >

Re: [PATCH v4 00/14] hw/block/nvme: Support Namespace Types and Zoned Namespace Command Set

2020-09-29 Thread Keith Busch
On Tue, Sep 29, 2020 at 11:13:51AM +, Damien Le Moal wrote: > OK. Then let's move the persistence implementation as the last patch in the > series. This way, if it is still controversial, it will not block the rest. > > Here is what I propose: > Dmitry: remove persistence stuff from your

Re: [Qemu-devel PATCH v2] target/i386: add "-cpu,lbr-fmt=*" support to enable guest LBR

2020-09-29 Thread Eduardo Habkost
(CCing the people from the thread, as kvm_exact_match_flags would be useful for INTEL_PT_IP_LIP) On Tue, Sep 29, 2020 at 02:12:17PM +0800, Like Xu wrote: > The last branch recording (LBR) is a performance monitor unit (PMU) > feature on Intel processors that records a running trace of the most >

Re: [PATCH v2 3/4] block: move block exports to libblockdev

2020-09-29 Thread Eric Blake
On 9/29/20 7:55 AM, Stefan Hajnoczi wrote: > Block exports are used by softmmu, qemu-storage-daemon, and qemu-nbd. > They are not used by other programs and are not otherwise needed in > libblock. > > Undo the recent move of blockdev-nbd.c from blockdev_ss into block_ss. > Since bdrv_close_all()

[PATCH 1/4] keyval: Parse help options

2020-09-29 Thread Kevin Wolf
This adds a new parameter 'help' to keyval_parse() that enables parsing of help options. If NULL is passed, the function behaves the same as before. But if a bool pointer is given, it contains the information whether an option "help" without value was given (which would otherwise either result in

Re: [PATCH v4 00/14] hw/block/nvme: Support Namespace Types and Zoned Namespace Command Set

2020-09-29 Thread Keith Busch
On Tue, Sep 29, 2020 at 12:46:33PM +0200, Klaus Jensen wrote: > It is unmistakably clear that you are invalidating my arguments about > portability and endianness issues by suggesting that we just remove > persistent state and deal with it later, but persistence is the killer > feature that sets

[PATCH 3/4] qom: Add user_creatable_print_help_from_qdict()

2020-09-29 Thread Kevin Wolf
This adds a function that, given a QDict of non-help options, prints help for user creatable objects. Signed-off-by: Kevin Wolf --- include/qom/object_interfaces.h | 9 + qom/object_interfaces.c | 9 + 2 files changed, 18 insertions(+) diff --git

[PATCH 0/4] qemu-storage-daemon: Remove QemuOpts from --object parser

2020-09-29 Thread Kevin Wolf
This replaces the QemuOpts-based help code for --object in the storage daemon with code based on the keyval parser. Kevin Wolf (4): keyval: Parse help options qom: Factor out helpers from user_creatable_print_help() qom: Add user_creatable_print_help_from_qdict() qemu-storage-daemon:

[PATCH 2/4] qom: Factor out helpers from user_creatable_print_help()

2020-09-29 Thread Kevin Wolf
This creates separate helper functions for printing a list of user creatable object types and for printing a list of properties of a given type. This allows using these parts without having a QemuOpts. Signed-off-by: Kevin Wolf --- qom/object_interfaces.c | 90

[PATCH 4/4] qemu-storage-daemon: Remove QemuOpts from --object parser

2020-09-29 Thread Kevin Wolf
The command line parser for --object parses the input twice: Once into QemuOpts just for detecting help options, and then again into a QDict using the keyval parser for actually creating the object. Now that the keyval parser can also detect help options, we can simplify this and remove the

Re: [PATCH PROTOTYPE 0/6] virtio-mem: vfio support

2020-09-29 Thread David Hildenbrand
On 29.09.20 19:02, Dr. David Alan Gilbert wrote: > * David Hildenbrand (da...@redhat.com) wrote: >> This is a quick and dirty (1.5 days of hacking) prototype to make >> vfio and virtio-mem play together. The basic idea was the result of Alex >> brainstorming with me on how to tackle this. >> >> A

Re: [RFC PATCH v5 2/2] hw/riscv: sifive_u: Add backend drive support

2020-09-29 Thread Alistair Francis
On Mon, Sep 28, 2020 at 2:18 AM Green Wan wrote: > > Hi Alistair, > > Thanks for the review. See the reply inline below. > > > On Sat, Sep 26, 2020 at 5:52 AM Alistair Francis wrote: > > > > On Tue, Sep 1, 2020 at 8:49 AM Green Wan wrote: > > > > > > Add '-drive' support to OTP device. Allow

Re: [PATCH PROTOTYPE 0/6] virtio-mem: vfio support

2020-09-29 Thread Dr. David Alan Gilbert
* David Hildenbrand (da...@redhat.com) wrote: > This is a quick and dirty (1.5 days of hacking) prototype to make > vfio and virtio-mem play together. The basic idea was the result of Alex > brainstorming with me on how to tackle this. > > A virtio-mem device manages a memory region in guest

Re: [RFC PATCH v4 00/29] Hexagon patch series

2020-09-29 Thread Philippe Mathieu-Daudé
On 9/29/20 5:53 PM, Taylor Simpson wrote: >> -Original Message- >> From: Philippe Mathieu-Daudé On >> Behalf Of Philippe Mathieu-Daudé >> Sent: Tuesday, September 29, 2020 6:22 AM >> To: Taylor Simpson ; qemu-devel@nongnu.org >> Cc: a...@rev.ng; riku.voi...@iki.fi;

Re: [PATCH v5 13/14] hw/block/nvme: Use zone metadata file for persistence

2020-09-29 Thread Klaus Jensen
On Sep 29 15:43, Dmitry Fomichev wrote: > > > > -Original Message- > > From: Klaus Jensen > > Sent: Monday, September 28, 2020 3:52 AM > > To: Dmitry Fomichev > > Cc: Keith Busch ; Klaus Jensen > > ; Kevin Wolf ; Philippe > > Mathieu-Daudé ; Maxim Levitsky > > ; Fam Zheng ; Niklas

Re: [PATCH v4 00/14] hw/block/nvme: Support Namespace Types and Zoned Namespace Command Set

2020-09-29 Thread Klaus Jensen
On Sep 29 15:43, Dmitry Fomichev wrote: > > -Original Message- > > From: Qemu-block > bounces+dmitry.fomichev=wdc@nongnu.org> On Behalf Of Klaus > > Jensen > > Sent: Tuesday, September 29, 2020 6:47 AM > > To: Damien Le Moal > > Cc: Fam Zheng ; Kevin Wolf ; qemu- > >

[PATCH v2 2/2] vhost: Don't call log_access_ok() when using IOTLB

2020-09-29 Thread Greg Kurz
When the IOTLB device is enabled, the log_guest_addr that is passed by userspace to the VHOST_SET_VRING_ADDR ioctl, and which is then written to vq->log_addr, is a GIOVA. All writes to this address are translated by log_user() to writes to an HVA, and then ultimately logged through the

[PATCH v2 1/2] vhost: Don't call access_ok() when using IOTLB

2020-09-29 Thread Greg Kurz
When the IOTLB device is enabled, the vring addresses we get from userspace are GIOVAs. It is thus wrong to pass them down to access_ok() which only takes HVAs. Access validation is done at prefetch time with IOTLB. Teach vq_access_ok() about that by moving the (vq->iotlb) check from

[PATCH v2 0/2] vhost: Skip access checks on GIOVAs

2020-09-29 Thread Greg Kurz
This series addresses some misuse around vring addresses provided by userspace when using an IOTLB device. The misuse cause failures of the VHOST_SET_VRING_ADDR ioctl on POWER, which in turn causes QEMU to crash at migration time. While digging some more I realized that log_access_ok() can also

Re: [RFC 0/3] QEMU as IPMI BMC emulator

2020-09-29 Thread Havard Skinnemoen
On Mon, Sep 28, 2020 at 10:27 PM Cédric Le Goater wrote: > > On 9/29/20 2:39 AM, Havard Skinnemoen wrote: > > This series briefly documents the existing IPMI device support for main > > processor emulation, and goes on to propose a similar device structure to > > emulate IPMI responder devices in

Re: [PATCH v4] introduce vfio-user protocol specification

2020-09-29 Thread John G Johnson
> On Sep 29, 2020, at 3:37 AM, Stefan Hajnoczi wrote: > > On Mon, Sep 28, 2020 at 09:58:37AM +, Thanos Makatos wrote: >>> It should be accompanied by a test in tests/. PCI-level testing APIS for >>> BARs, configuration space, interrupts, etc are available in >>> tests/qtest/libqos/pci.h.

Re: [PULL 0/1] acpi: fixup

2020-09-29 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200929111255.381871-1-...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20200929111255.381871-1-...@redhat.com Subject: [PULL 0/1] acpi: fixup === TEST SCRIPT BEGIN

Re: [PATCH] qcow2: Use L1E_SIZE in qcow2_write_l1_entry()

2020-09-29 Thread Eric Blake
On 9/28/20 11:23 AM, Alberto Garcia wrote: > We overlooked these in 02b1ecfa100e7ecc2306560cd27a4a2622bfeb04 > > Signed-off-by: Alberto Garcia > --- > block/qcow2-cluster.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Reviewed-by: Eric Blake > diff --git

Re: [PATCH v2 2/2] util/vfio-helpers: Rework the IOVA allocator to avoid IOVA reserved regions

2020-09-29 Thread Stefan Hajnoczi
On Tue, Sep 29, 2020 at 10:55:50AM +0200, Eric Auger wrote: > diff --git a/util/vfio-helpers.c b/util/vfio-helpers.c > index ba0ee6e21c..71145970f3 100644 > --- a/util/vfio-helpers.c > +++ b/util/vfio-helpers.c > @@ -667,6 +667,50 @@ static bool qemu_vfio_verify_mappings(QEMUVFIOState *s) >

Re: [PATCH v2] build-sys: fix git version from -version

2020-09-29 Thread Yonggang Luo
On Tue, Sep 29, 2020 at 11:33 PM Marc-André Lureau < marcandre.lur...@gmail.com> wrote: > > > > On Tue, Sep 29, 2020 at 6:43 PM 罗勇刚(Yonggang Luo) wrote: >> >> >> >> On Tue, Sep 29, 2020 at 10:38 PM wrote: >> > >> > From: Marc-André Lureau >> > >> > Typo introduced with the script. >> > >> >

RE: [RFC PATCH v4 00/29] Hexagon patch series

2020-09-29 Thread Taylor Simpson
> -Original Message- > From: Philippe Mathieu-Daudé On > Behalf Of Philippe Mathieu-Daudé > Sent: Tuesday, September 29, 2020 6:22 AM > To: Taylor Simpson ; qemu-devel@nongnu.org > Cc: a...@rev.ng; riku.voi...@iki.fi; richard.hender...@linaro.org; > laur...@vivier.eu;

Re: [PATCH v6 00/14] Reverse debugging

2020-09-29 Thread no-reply
Patchew URL: https://patchew.org/QEMU/160137726426.31007.12061315974029139983.stgit@pasha-ThinkPad-X280/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 160137726426.31007.12061315974029139983.stgit@pasha-ThinkPad-X280

Re: [PATCH v11 0/3] Add Versal usb model

2020-09-29 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1601376942-9648-1-git-send-email-sai.pavan.bo...@xilinx.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. ===

RE: [RFC PATCH v4 15/29] Hexagon (target/hexagon) utility functions

2020-09-29 Thread Taylor Simpson
OK > -Original Message- > From: Philippe Mathieu-Daudé On > Behalf Of Philippe Mathieu-Daudé > Sent: Tuesday, September 29, 2020 5:26 AM > To: Taylor Simpson ; qemu-devel@nongnu.org > Cc: richard.hender...@linaro.org; laur...@vivier.eu; riku.voi...@iki.fi; > aleksandar.m.m...@gmail.com;

Re: [PULL 5/5] crypto/tls-cipher-suites: Produce fw_cfg consumable blob

2020-09-29 Thread Kevin Wolf
Am 04.07.2020 um 18:39 hat Philippe Mathieu-Daudé geschrieben: > Since our format is consumable by the fw_cfg device, > we can implement the FW_CFG_DATA_GENERATOR interface. > > Example of use to dump the cipher suites (if tracing enabled): > > $ qemu-system-x86_64 -S \ > -object

RE: [PATCH v4 00/14] hw/block/nvme: Support Namespace Types and Zoned Namespace Command Set

2020-09-29 Thread Dmitry Fomichev
> -Original Message- > From: Qemu-block bounces+dmitry.fomichev=wdc@nongnu.org> On Behalf Of Klaus > Jensen > Sent: Tuesday, September 29, 2020 6:47 AM > To: Damien Le Moal > Cc: Fam Zheng ; Kevin Wolf ; qemu- > bl...@nongnu.org; Niklas Cassel ; Klaus Jensen > ;

RE: [PATCH v5 13/14] hw/block/nvme: Use zone metadata file for persistence

2020-09-29 Thread Dmitry Fomichev
> -Original Message- > From: Klaus Jensen > Sent: Monday, September 28, 2020 3:52 AM > To: Dmitry Fomichev > Cc: Keith Busch ; Klaus Jensen > ; Kevin Wolf ; Philippe > Mathieu-Daudé ; Maxim Levitsky > ; Fam Zheng ; Niklas Cassel > ; Damien Le Moal ; > qemu-bl...@nongnu.org;

Re: [PATCH v2 4/4] block/export: add iothread and fixed-iothread options

2020-09-29 Thread Stefan Hajnoczi
On Tue, Sep 29, 2020 at 08:07:38AM -0500, Eric Blake wrote: > On 9/29/20 7:55 AM, Stefan Hajnoczi wrote: > > Make it possible to specify the iothread where the export will run. By > > default the block node can be moved to other AioContexts later and the > > export will follow. The fixed-iothread

RE: [PATCH v4 00/14] hw/block/nvme: Support Namespace Types and Zoned Namespace Command Set

2020-09-29 Thread Dmitry Fomichev
> -Original Message- > From: Klaus Jensen > Sent: Monday, September 28, 2020 2:37 AM > To: Dmitry Fomichev > Cc: Keith Busch ; Damien Le Moal > ; Klaus Jensen ; Kevin > Wolf ; Philippe Mathieu-Daudé ; > Maxim Levitsky ; Fam Zheng ; > Niklas Cassel ; qemu-bl...@nongnu.org; qemu- >

Re: [PATCH v6 00/21] Convert QAPI doc comments to generate rST instead of texinfo

2020-09-29 Thread Peter Maydell
On Tue, 29 Sep 2020 at 16:26, Markus Armbruster wrote: > One more issue: > > /work/armbru/qemu/docs/../qapi/machine.json:1000: WARNING: Unexpected > indentation. > /work/armbru/qemu/docs/../qapi/machine.json:1000: WARNING: Block quote > ends without a blank line; unexpected unindent. >

Re: [PATCH v3 04/47] qapi: modify docstrings to be sphinx-compatible

2020-09-29 Thread John Snow
On 9/28/20 11:39 PM, Cleber Rosa wrote: On Thu, Sep 24, 2020 at 08:28:17PM -0400, John Snow wrote: I did not say "sphinx beautiful", just "sphinx compatible". They will not throw errors when parsed and interpreted as ReST. Signed-off-by: John Snow --- scripts/qapi/doc.py| 10 +-

Re: [PATCH v3 03/47] [DO-NOT-MERGE] docs/sphinx: change default role to "any"

2020-09-29 Thread John Snow
On 9/28/20 11:30 PM, Cleber Rosa wrote: On Thu, Sep 24, 2020 at 08:28:16PM -0400, John Snow wrote: Signed-off-by: John Snow --- docs/conf.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/docs/conf.py b/docs/conf.py index 0dbd90dc11..a68f616d5a 100644 --- a/docs/conf.py +++

Re: [PATCH v2] build-sys: fix git version from -version

2020-09-29 Thread Marc-André Lureau
On Tue, Sep 29, 2020 at 6:43 PM 罗勇刚(Yonggang Luo) wrote: > > > On Tue, Sep 29, 2020 at 10:38 PM wrote: > > > > From: Marc-André Lureau > > > > Typo introduced with the script. > > > > Fixes: 2c273f32d3 ("meson: generate qemu-version.h") > > Signed-off-by: Marc-André Lureau > > --- > >

Re: [PATCH v2 3/3] qga: add implementation of guest-get-disks for Windows

2020-09-29 Thread Marc-André Lureau
Hi On Mon, Sep 7, 2020 at 1:15 PM Tomáš Golembiovský wrote: > The command lists all the physical disk drives. Unlike for Linux > partitions and virtual volumes are not listed. > > Example output: > > { > "return": [ > { > "name": ".\\PhysicalDrive0", > "partition": false,

Re: [PATCH v3 02/47] [DO-NOT-MERGE] docs: repair broken references

2020-09-29 Thread John Snow
On 9/28/20 11:14 PM, Cleber Rosa wrote: On Thu, Sep 24, 2020 at 08:28:15PM -0400, John Snow wrote: Signed-off-by: John Snow --- docs/devel/multi-thread-tcg.rst | 2 +- docs/devel/testing.rst | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [Virtio-fs] virtiofs vs 9p performance(Re: tools/virtiofs: Multi threading seems to hurt performance)

2020-09-29 Thread Vivek Goyal
On Tue, Sep 29, 2020 at 03:49:04PM +0200, Miklos Szeredi wrote: > On Tue, Sep 29, 2020 at 3:18 PM Vivek Goyal wrote: > > > - virtiofs cache=none mode is faster than cache=auto mode for this > > workload. > > Not sure why. One cause could be that readahead is not perfect at > detecting the

Re: [PATCH v6 00/21] Convert QAPI doc comments to generate rST instead of texinfo

2020-09-29 Thread Markus Armbruster
Peter Maydell writes: > On Mon, 28 Sep 2020 at 14:04, Markus Armbruster wrote: >> >> Peter Maydell writes: >> >> > On Fri, 25 Sep 2020 at 20:25, wrote: >> > >> >> In file included from ../src/qapi/qapi-schema.json:78: >> >> ../src/qapi/migration.json:1747:1: unexpected de-indent (expected at

Re: [PATCH v2 2/3] qga: add implementation of guest-get-disks for Linux

2020-09-29 Thread Marc-André Lureau
Hi On Mon, Sep 7, 2020 at 1:17 PM Tomáš Golembiovský wrote: > The command lists all disks (real and virtual) as well as disk > partitions. For each disk the list of slave disks is also listed and > /dev path is used as a handle so it can be matched with "name" filed of > field other returned

<    1   2   3   4   5   6   >