Re: [PATCH] tests: tcg: do not use implicit rules

Patchew URL: https://patchew.org/QEMU/20201003085054.332992-1-pbonz...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN

Re: [PATCH v10 0/8] linux-user: User support for AArch64 BTI

Patchew URL: https://patchew.org/QEMU/20201002215955.254866-1-richard.hender...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20201002215955.254866-1-richard.hender...@linaro.org Subject: [PATCH v10 0/8]

Re: [PATCH v7 00/14] Reverse debugging

Patchew URL: https://patchew.org/QEMU/160174516520.12451.10785284392438702137.stgit@pasha-ThinkPad-X280/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 160174516520.12451.10785284392438702137.stgit@pasha-ThinkPad-X280

QEMU API cleanup initiative - Let's chat during the KVM call

Hi, everyone! I'd like to discuss some of this in the upstream KVM call. TLDR: I would like to begin an organized effort to consolidate our CLI parsing, moving it onto QAPI. I'd like to talk about how we should proceed on the KVM call, prior to KVM Forum, where we should continue these

Re: [PATCH v2] scripts/qmp/qom-set: Allow setting integer value

On 10/3/20 1:33 PM, Philippe Mathieu-Daudé wrote: Hi Jonatan, On 10/2/20 10:52 PM, Jonatan Pålsson wrote: If the value appears to be an integer, parse it as such. This allows the following: qmp/qom-set -s ~/qmp.sock sensor.temperature 2 Maybe instead: Fix the following error:

Re: [PATCH 04/14] hw/arm/raspi: add a skeleton implementation of the cprman

On 10/3/20 1:54 PM, Luc Michel wrote: > On 16:37 Fri 02 Oct , Philippe Mathieu-Daudé wrote: > > [snip] > > +struct BCM2835CprmanState { > +/*< private >*/ > +SysBusDevice parent_obj; > + > +/*< public >*/ > +MemoryRegion iomem; > + > +

Re: [PATCH v10 6/8] linux-user/elfload: Move PT_INTERP detection to first loop

On 10/3/20 7:38 PM, Philippe Mathieu-Daudé wrote: > On 10/2/20 11:59 PM, Richard Henderson wrote: >> For BTI, we need to know if the executable is static or dynamic, >> which means looking for PT_INTERP earlier. >> >> Signed-off-by: Richard Henderson >> --- >> linux-user/elfload.c | 60

Re: [PATCH v2] hw/avr: Add limited support for avr gpio registers

On 10/3/20 2:38 PM, Heecheol Yang wrote: > Add some of these features for avr gpio: > > - GPIO I/O : PORTx registers > - Data Direction : DDRx registers > > Following things are not supported yet: > - PINx registers > - MCUR registers > - Even though read/write for DDRx registers are >

Re: [PATCH] dockerfiles: add diffutils to Fedora

On 10/3/20 10:50 AM, Paolo Bonzini wrote: > For some reason diffutils is not included in the Fedora containers anymore, > causing the build to fail. > > Signed-off-by: Paolo Bonzini > --- > tests/docker/dockerfiles/fedora.docker | 1 + > 1 file changed, 1 insertion(+) > > diff --git

Re: [PATCH 1/6] qom: Fix DECLARE_*CHECKER documentation

On 10/3/20 4:54 AM, Eduardo Habkost wrote: > Correct copy/paste mistake in the DECLARE_INSTANCE_CHECKER and > DECLARE_CLASS_CHECKERS documentation. > > Signed-off-by: Eduardo Habkost > --- > include/qom/object.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git

Re: [PATCH] tests: tcg: do not use implicit rules

On 10/3/20 10:50 AM, Paolo Bonzini wrote: > Use pattern rules to clarify which targets are going to match the > rule and to provide clearer error messages. > > Signed-off-by: Paolo Bonzini Reviewed-by: Philippe Mathieu-Daudé > --- > tests/Makefile.include | 6 +++--- > 1 file changed, 3

Re: [PATCH 6/6] docs/devel/qom: Avoid long lines

On 10/3/20 4:54 AM, Eduardo Habkost wrote: > Long code lines don't look good in the rendered documents, make > them shorter. > > Signed-off-by: Eduardo Habkost Reviewed-by: Philippe Mathieu-Daudé > --- > docs/devel/qom.rst | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > >

Re: [PATCH 4/6] docs/devel/qom: Use *emphasis* for emphasis

On 10/3/20 4:54 AM, Eduardo Habkost wrote: > is not valid reST syntax. > > Signed-off-by: Eduardo Habkost Reviewed-by: Philippe Mathieu-Daudé > --- > docs/devel/qom.rst | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/docs/devel/qom.rst b/docs/devel/qom.rst >

Re: [PATCH v10 5/8] linux-user/elfload: Adjust iteration over phdr

On 10/2/20 11:59 PM, Richard Henderson wrote: > The second loop uses a loop induction variable, and the first > does not. Transform the first to match the second, to simplify > a following patch moving code between them. > > Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé

[PATCH] linux-user/elfload: Avoid leaking interp_name using GLib memory API

Fix an unlikely memory leak in load_elf_image(). Fixes: bf858897b7 ("linux-user: Re-use load_elf_image for the main binary.") Signed-off-by: Philippe Mathieu-Daudé --- linux-user/elfload.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/linux-user/elfload.c

Re: [PATCH v10 6/8] linux-user/elfload: Move PT_INTERP detection to first loop

On 10/2/20 11:59 PM, Richard Henderson wrote: > For BTI, we need to know if the executable is static or dynamic, > which means looking for PT_INTERP earlier. > > Signed-off-by: Richard Henderson > --- > linux-user/elfload.c | 60 +++- > 1 file changed, 31

Re: [PATCH 5/5] memory: Skip bad range assertion if notifier is DEVIOTLB_UNMAP type

On Mon, Sep 28, 2020 at 01:48:57PM -0400, Peter Xu wrote: > On Mon, Sep 28, 2020 at 11:05:01AM +0200, Eugenio Perez Martin wrote: > > On Fri, Sep 4, 2020 at 6:34 AM Jason Wang wrote: > > > > > > > > > On 2020/9/4 上午12:14, Eugenio Pérez wrote: > > > > Device IOTLB invalidations can unmap arbitrary

Re: [PATCH v10 4/8] linux-user/elfload: Fix coding style in load_elf_image

On 10/2/20 11:59 PM, Richard Henderson wrote: > Fixing this now will clarify following patches. > > Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé > --- > linux-user/elfload.c | 12 +--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git

Re: [PATCH v2] scripts/qmp/qom-set: Allow setting integer value

Hi Jonatan, On 10/2/20 10:52 PM, Jonatan Pålsson wrote: > If the value appears to be an integer, parse it as such. > > This allows the following: > > qmp/qom-set -s ~/qmp.sock sensor.temperature 2 Maybe instead: Fix the following error: $ scripts/qmp/qom-set -s ~/qmp.sock

Re: [PATCH v6 00/14] Reverse debugging

On 02.10.2020 18:39, Paolo Bonzini wrote: On 29/09/20 13:01, Pavel Dovgalyuk wrote: GDB remote protocol supports reverse debugging of the targets. It includes 'reverse step' and 'reverse continue' operations. The first one finds the previous step of the execution, and the second one is intended

[PATCH v7 13/14] replay: create temporary snapshot at debugger connection

When record/replay does not uses overlays for storing the snapshots, user is not capable of issuing reverse debugging commands. This patch adds creation of the VM snapshot on the temporary overlay image, when the debugger connects to QEMU. Therefore the execution can be rewind to the moment of the

[PATCH v7 11/14] gdbstub: add reverse continue support in replay mode

From: Pavel Dovgalyuk This patch adds support of the reverse continue operation for gdbstub. Reverse continue finds the last breakpoint that would happen in normal execution from the beginning to the current moment. Implementation of the reverse continue replays the execution twice: to find the

[PATCH v7 10/14] gdbstub: add reverse step support in replay mode

From: Pavel Dovgalyuk GDB remote protocol supports two reverse debugging commands: reverse step and reverse continue. This patch adds support of the first one to the gdbstub. Reverse step is intended to step one instruction in the backwards direction. This is not possible in regular execution.

[PATCH v7 06/14] replay: introduce info hmp/qmp command

From: Pavel Dovgalyuk This patch introduces 'info replay' monitor command and corresponding qmp request. These commands request the current record/replay mode, replay log file name, and the instruction count (number of recorded/replayed instructions). The instruction count can be used with the

Re: [PATCH v3 4/4] hw/arm/bcm2835_peripherals: Correctly wire the SYS_timer IRQs

On 10/2/20 11:42 AM, Philippe Mathieu-Daudé wrote: > The SYS_timer is not directly wired to the ARM core, but to the > SoC (peripheral) interrupt controller. > > Fixes: 0e5bbd74064 ("hw/arm/bcm2835_peripherals: Use the SYS_timer") > Reviewed-by: Luc Michel > Signed-off-by: Philippe Mathieu-Daudé

[PATCH v7 09/14] replay: flush rr queue before loading the vmstate

From: Pavel Dovgalyuk Non-empty record/replay queue prevents saving and loading the VM state, because it includes pending bottom halves and block coroutines. But when the new VM state is loaded, we don't have to preserve the consistency of the current state anymore. Therefore this patch just

Re: [PATCH v3 3/4] hw/timer/bcm2835: Support the timer COMPARE registers

On 10/2/20 11:42 AM, Philippe Mathieu-Daudé wrote: > @@ -78,16 +71,29 @@ static void bcm2835_systmr_write(void *opaque, hwaddr > offset, > uint64_t value, unsigned size) > { > BCM2835SystemTimerState *s = BCM2835_SYSTIMER(opaque); > +int index; > +

[PATCH v7 14/14] tests/acceptance: add reverse debugging test

From: Pavel Dovgalyuk This is a test for GDB reverse debugging commands: reverse step and reverse continue. Every test in this suite consists of two phases: record and replay. Recording saves the execution of some instructions and makes an initial VM snapshot to allow reverse execution. Replay

[PATCH v7 08/14] replay: implement replay-seek command

From: Pavel Dovgalyuk This patch adds hmp/qmp commands replay_seek/replay-seek that proceed the execution to the specified instruction count. The command automatically loads nearest snapshot and replays the execution to find the desired instruction count. Signed-off-by: Pavel Dovgalyuk

[PATCH v7 05/14] qapi: introduce replay.json for record/replay-related stuff

From: Pavel Dovgalyuk This patch adds replay.json file. It will be used for adding record/replay-related data structures and commands. Signed-off-by: Pavel Dovgalyuk Reviewed-by: Markus Armbruster Reviewed-by: Alex Bennée --- MAINTAINERS |1 + include/sysemu/replay.h |1

[PATCH v7 12/14] replay: describe reverse debugging in docs/replay.txt

From: Pavel Dovgalyuk This patch updates the documentation and describes usage of the reverse debugging in QEMU+GDB. Signed-off-by: Pavel Dovgalyuk Reviewed-by: Alex Bennée -- v4 changes: - added an example of the command line for reverse debugging of the diskless machine ---

[PATCH v7 04/14] migration: introduce icount field for snapshots

Saving icount as a parameters of the snapshot allows navigation between them in the execution replay scenario. This information can be used for finding a specific snapshot for proceeding the recorded execution to the specific moment of the time. E.g., 'reverse step' action (introduced in one of

[PATCH v7 02/14] replay: provide an accessor for rr filename

From: Pavel Dovgalyuk This patch adds an accessor function for the name of the record/replay log file. Adding an accessor instead of making variable global, prevents accidental modification of this variable by other modules. Signed-off-by: Pavel Dovgalyuk Reviewed-by: Alex Bennée Reviewed-by:

[PATCH v7 07/14] replay: introduce breakpoint at the specified step

From: Pavel Dovgalyuk This patch introduces replay_break, replay_delete_break qmp and hmp commands. These commands allow stopping at the specified instruction. It may be useful for debugging when there are some known events that should be investigated. replay_break command has one argument -

[PATCH v7 03/14] qcow2: introduce icount field for snapshots

This patch introduces the icount field for saving within the snapshot. It is required for navigation between the snapshots in record/replay mode. Signed-off-by: Pavel Dovgalyuk Acked-by: Kevin Wolf -- v7 changes: - also fix the test which checks qcow2 snapshot extra data ---

[PATCH v7 01/14] replay: don't record interrupt poll

Interrupt poll is not a real interrupt event. It is needed only for thread safety. This interrupt is used for i386 and converted to hardware interrupt by cpu_handle_interrupt function. Therefore it is not needed to be recorded, because hardware interrupt will be recorded after converting.

[PATCH v7 00/14] Reverse debugging

GDB remote protocol supports reverse debugging of the targets. It includes 'reverse step' and 'reverse continue' operations. The first one finds the previous step of the execution, and the second one is intended to stop at the last breakpoint that would happen when the program is executed

Re: [PATCH v2] hw/avr: Add limited support for avr gpio registers

On Sat, Oct 3, 2020 at 3:39 PM Heecheol Yang wrote: > Add some of these features for avr gpio: > > - GPIO I/O : PORTx registers > - Data Direction : DDRx registers > > Following things are not supported yet: > - PINx registers > - MCUR registers > - Even though read/write for DDRx

Re: [PATCH v3 2/4] hw/timer/bcm2835: Rename variable holding CTRL_STATUS register

On 10/2/20 11:42 AM, Philippe Mathieu-Daudé wrote: > The variable holding the CTRL_STATUS register is misnamed > 'status'. Rename it 'ctrl_status' to make it more obvious > this register is also used to control the peripheral. > > Reviewed-by: Luc Michel > Signed-off-by: Philippe Mathieu-Daudé

Re: [PATCH v3 1/4] hw/timer/bcm2835: Introduce BCM2835_SYSTIMER_COUNT definition

On 10/2/20 11:42 AM, Philippe Mathieu-Daudé wrote: > Use the BCM2835_SYSTIMER_COUNT definition instead of the > magic '4' value. > > Reviewed-by: Luc Michel > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/timer/bcm2835_systmr.h | 4 +++- > hw/timer/bcm2835_systmr.c | 3 ++- >

[PATCH v2] hw/avr: Add limited support for avr gpio registers

Add some of these features for avr gpio: - GPIO I/O : PORTx registers - Data Direction : DDRx registers Following things are not supported yet: - PINx registers - MCUR registers - Even though read/write for DDRx registers are implemented, actual direction controls are not

[PATCH v3] hw/avr: Add limited support for avr gpio registers

I am very sorry for your inconvenience. This is 3rd version of the patch for what I did. I should have read the contribution guide again and again. I am very sorry again. The contents of the patch is the same with the v2. This mail is just for patchew and making a new thread. Here are what I

Re: [PATCH 04/14] hw/arm/raspi: add a skeleton implementation of the cprman

On 16:37 Fri 02 Oct , Philippe Mathieu-Daudé wrote: [snip] > >>> +struct BCM2835CprmanState { > >>> +/*< private >*/ > >>> +SysBusDevice parent_obj; > >>> + > >>> +/*< public >*/ > >>> +MemoryRegion iomem; > >>> + > >>> +uint32_t regs[CPRMAN_NUM_REGS]; > >>> +uint32_t

[PATCH v3] hw/avr: Add limited support for avr gpio registers

I am very sorry for your inconvenience. This is 3rd version of the patch for what I did. I should have read the contribution guide again and again. I am very sorry again. The contents of the patch is the same with the v2. This mail is just for patchew and making a new thread. Here are what I

Emulate Rpi with QEMU fails

Hi, I'm trying to emulate Rpi with QEMU. I found [url=https://www.raspberry-pi-geek.de/ausgaben/rpg/2014/04/raspberry-pi-emulieren/]this[/url] arcticle in Raspberry Pi Geek documenting the steps including persistent storage on host. However when starting the emulation with command

[PATCH v2] hw/avr: Add limited support for avr gpio registers

Hello, Thank you very much for your prompt and kind review. This is my next version of the patch. Here are what I changed from the previous one: * Remove unnecessary header inclusions * Replace codes for unreachable conditions with g_assert_not_reached() function * Remove 'enable'

Re: [PATCH v4 12/12] .travis.yml: Add a KVM-only Aarch64 job

On 10/3/20 5:14 AM, Thomas Huth wrote: > On 03/10/2020 12.03, Richard Henderson wrote: >> On 9/29/20 5:43 PM, Philippe Mathieu-Daudé wrote: >>> Add a job to build QEMU on Aarch64 with TCG disabled, so >>> this configuration won't bitrot over time. >>> >>> We explicitly modify

Re: [PATCH v4 12/12] .travis.yml: Add a KVM-only Aarch64 job

On 03/10/2020 12.03, Richard Henderson wrote: On 9/29/20 5:43 PM, Philippe Mathieu-Daudé wrote: Add a job to build QEMU on Aarch64 with TCG disabled, so this configuration won't bitrot over time. We explicitly modify default-configs/aarch64-softmmu.mak to only select the 'virt' and 'SBSA-REF'

[PATCH v3 3/3] vhost: Don't call log_access_ok() when using IOTLB

When the IOTLB device is enabled, the log_guest_addr that is passed by userspace to the VHOST_SET_VRING_ADDR ioctl, and which is then written to vq->log_addr, is a GIOVA. All writes to this address are translated by log_user() to writes to an HVA, and then ultimately logged through the

Re: [PATCH v4 12/12] .travis.yml: Add a KVM-only Aarch64 job

On 9/29/20 5:43 PM, Philippe Mathieu-Daudé wrote: > Add a job to build QEMU on Aarch64 with TCG disabled, so > this configuration won't bitrot over time. > > We explicitly modify default-configs/aarch64-softmmu.mak to > only select the 'virt' and 'SBSA-REF' machines. I really wish we didn't have

[PATCH v3 2/3] vhost: Use vhost_get_used_size() in vhost_vring_set_addr()

The open-coded computation of the used size doesn't take the event into account when the VIRTIO_RING_F_EVENT_IDX feature is present. Fix that by using vhost_get_used_size(). Signed-off-by: Greg Kurz --- drivers/vhost/vhost.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[PATCH v3 0/3] vhost: Skip access checks on GIOVAs

This series addresses some misuse around vring addresses provided by userspace when using an IOTLB device. The misuse cause failures of the VHOST_SET_VRING_ADDR ioctl on POWER, which in turn causes QEMU to crash at migration time. Jason suggested that we should use vhost_get_used_size() during

[PATCH v3 1/3] vhost: Don't call access_ok() when using IOTLB

When the IOTLB device is enabled, the vring addresses we get from userspace are GIOVAs. It is thus wrong to pass them down to access_ok() which only takes HVAs. Access validation is done at prefetch time with IOTLB. Teach vq_access_ok() about that by moving the (vq->iotlb) check from

Re: [PATCH v4 11/12] target/arm: Reorder meson.build rules

On 9/29/20 5:43 PM, Philippe Mathieu-Daudé wrote: > Reorder the rules to make this file easier to modify. > > Signed-off-by: Philippe Mathieu-Daudé > --- > I prefer to not squash that with the previous patch, > as it makes it harder to review. > --- > target/arm/meson.build | 22

Re: [PATCH v4 10/12] target/arm: Do not build TCG objects when TCG is off

On 9/29/20 5:43 PM, Philippe Mathieu-Daudé wrote: > -arm_ss.add(when: 'CONFIG_TCG', if_true: files('arm-semi.c')) Aha, so you remove the line in the next patch anyway. I suspect that you can not add it in the previous. Reviewed-by: Richard Henderson r~

Re: [PATCH v4 09/12] target/arm: Make m_helper.c optional via CONFIG_ARM_V7M

On 9/29/20 5:43 PM, Philippe Mathieu-Daudé wrote: > +arm_ss.add(when: 'CONFIG_ARM_V7M', if_true: files('m_helper.c'), if_false: > files('m_helper-stub.c')) > + > arm_ss.add(zlib) > > arm_ss.add(when: 'CONFIG_TCG', if_true: files('arm-semi.c')) > +arm_ss.add(when: 'CONFIG_TCG', if_false:

Re: [PATCH v4 03/12] target/arm: Select SEMIHOSTING if TCG is available

On 9/29/20 5:43 PM, Philippe Mathieu-Daudé wrote: > Add a kconfig entry which not explicitly selected by another > entry, but which selects SEMIHOSTING if TCG is available. > > This avoids: > > /usr/bin/ld: libqemu-aarch64-softmmu.fa.p/target_arm_arm-semi.c.o: in > function

[PULL v3 01/11] capstone: Convert Makefile bits to meson bits

There are better ways to do this, e.g. meson cmake subproject, but that requires cmake 3.7 and some of our CI environments only provide cmake 3.5. Nor can we add a meson.build file to capstone/, because the git submodule would then always report "untracked files". Fixing that would require

[PULL v3 00/11] capstone + disassembler patch queue

~ The following changes since commit dd8c1e808f1ca311e1f50bff218c3ee3198b1f02: Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20201002' into staging (2020-10-02 14:29:49 +0100) are available in the Git repository at: https://gitlab.com/rth7680/qemu.git tags/pull-cap-20201003 for you

Re: [PATCH v4 02/12] meson: Allow optional target/${ARCH}/Kconfig

On 10/3/20 4:15 AM, Paolo Bonzini wrote: > On 03/10/20 11:13, Richard Henderson wrote: >>> +target_kconfig = 'target' / config_target['TARGET_BASE_ARCH'] / >>> 'Kconfig' >>> +minikconf_input = ['default-configs' / target + '.mak', 'Kconfig'] >>> +if fs.is_file(target_kconfig) >>

Re: [PATCH] meson.build: Don't look for libudev for static builds

On Sat, Oct 3, 2020 at 4:43 PM Paolo Bonzini wrote: > > On 03/10/20 10:29, 罗勇刚(Yonggang Luo) wrote: > > For some meson script like this: > > curses = not_found > > if iconv.found() and not get_option('curses').disabled() > > curses_libname_list = ['ncursesw', 'ncurses', 'cursesw', 'pdcurses'] >

Re: [PATCH v6 00/10] Fix scsi devices plug/unplug races w.r.t virtio-scsi iothread

Patchew URL: https://patchew.org/QEMU/20201002173558.232960-1-pbonz...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20201002173558.232960-1-pbonz...@redhat.com Subject: [PATCH v6 00/10] Fix scsi devices

Re: [PULL v2 00/11] capstone + disassembler patch queue

On 10/3/20 2:06 AM, Paolo Bonzini wrote: > On 02/10/20 22:37, Peter Maydell wrote: >> Found CMake: /usr/bin/cmake (2.8.12.2) >> WARNING: The version of CMake /usr/bin/cmake is 2.8.12.2 but version >>> =3.4 is required >> Run-time dependency capstone found: NO (tried pkgconfig and cmake) >>

Re: [PATCH v4 04/12] target/arm: Restrict ARMv4 cpus to TCG accel

On 30/09/2020 10.03, Philippe Mathieu-Daudé wrote: On 9/30/20 12:43 AM, Philippe Mathieu-Daudé wrote: KVM requires a cpu based on (at least) the ARMv7 architecture. Only enable the following ARMv4 CPUs when TCG is available: - StrongARM (SA1100/1110) - OMAP1510 (TI925T) Signed-off-by:

Re: [PATCH v4 02/12] meson: Allow optional target/${ARCH}/Kconfig

On 03/10/20 11:13, Richard Henderson wrote: >> +target_kconfig = 'target' / config_target['TARGET_BASE_ARCH'] / >> 'Kconfig' >> +minikconf_input = ['default-configs' / target + '.mak', 'Kconfig'] >> +if fs.is_file(target_kconfig) > Missing a meson.current_source_dir()? > Leastwise

Re: [PATCH v4 02/12] meson: Allow optional target/${ARCH}/Kconfig

On 9/29/20 5:43 PM, Philippe Mathieu-Daudé wrote: > +++ b/meson.build > @@ -529,6 +529,7 @@ kconfig_external_symbols = [ > ] > ignored = ['TARGET_XML_FILES', 'TARGET_ABI_DIR', 'TARGET_DIRS'] > > +fs = import('fs') Note that I have this in the capstone update, and I placed it closer to the top

Re: [PATCH v4 01/12] accel/tcg: Add stub for cpu_loop_exit()

On 9/29/20 5:43 PM, Philippe Mathieu-Daudé wrote: > Since the support of SYS_READC in commit 8de702cb67 the > semihosting code is strongly depedent of the TCG accelerator > via a call to cpu_loop_exit(). > > Ideally we would only build semihosting support when TCG > is available, but

Re: [PATCH 0/6] qom documentation fixes

On 03/10/20 04:54, Eduardo Habkost wrote: > A few fixes to the QOM documentation in docs/devel/qom.rst and > include/qom/object.h. > > Eduardo Habkost (6): > qom: Fix DECLARE_*CHECKER documentation > docs/devel/qom: Fix indentation of bulleted list > docs/devel/qom: Fix indentation of code

Re: [PATCH 5/6] docs/devel/qom: Remove usage of

On 03/10/20 04:54, Eduardo Habkost wrote: > is not valid reST syntax. > > Function @argument references don't need additional markup, so > just remove . > > Constants were changed to use reST ``code`` syntax > > Signed-off-by: Eduardo Habkost > --- > include/qom/object.h | 12 ++-- >

Re: [PATCH 0/5] kernel-doc ixes

On 03/10/20 04:41, Eduardo Habkost wrote: > Among other fixes in kernel-doc, this series get rid of > QEMU-specific $decl_type='type name' hack in kernel-doc, because > it made it impossible to document macros with names starting with > uppercase letters (like most of the macros at qom/object.h).

[PATCH] tests: tcg: do not use implicit rules

Use pattern rules to clarify which targets are going to match the rule and to provide clearer error messages. Signed-off-by: Paolo Bonzini --- tests/Makefile.include | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index

[PATCH] dockerfiles: add diffutils to Fedora

For some reason diffutils is not included in the Fedora containers anymore, causing the build to fail. Signed-off-by: Paolo Bonzini --- tests/docker/dockerfiles/fedora.docker | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/docker/dockerfiles/fedora.docker

Re: [PATCH v3] qemu/atomic.h: rename atomic_ to qatomic_

On 02/10/20 18:43, Matthew Rosato wrote: >> diff --git >> a/include/standard-headers/drivers/infiniband/hw/vmw_pvrdma/pvrdma_ring.h >> b/include/standard-headers/drivers/infiniband/hw/vmw_pvrdma/pvrdma_ring.h >> index acd4c8346d..7b4062a1a1 100644 >> --- >>

[Bug 1898084] Re: Assertion failed: (buf_len != 0), function soread, file socket.c, line 183.

libslirp is a separate project now, and I see that you already reported it there (https://gitlab.freedesktop.org/slirp/libslirp/-/issues/29), so I'm closing this QEMU ticket now. ** Bug watch added: gitlab.freedesktop.org/slirp/libslirp/-/issues #29

[Bug 1898084] Re: Assertion failed: (buf_len != 0), function soread, file socket.c, line 183.

Hmm, thinking about it twice, maybe let's rather keep this open, to make sure that we update to the right version of libslirp in QEMU once the fix is released there. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [PATCH] meson.build: Don't look for libudev for static builds

On 03/10/20 10:29, 罗勇刚(Yonggang Luo) wrote: > For some meson script like this: > curses = not_found > if iconv.found() and not get_option('curses').disabled() >   curses_libname_list = ['ncursesw', 'ncurses', 'cursesw', 'pdcurses'] >   curses_test = ''' >     #include >     #include >    

Re: [PATCH] meson.build: Don't look for libudev for static builds

On 03/10/20 10:28, 罗勇刚(Yonggang Luo) wrote: >> Yes, I think adding a "links" argument to dependency (similar to >> find_library's has_headers argument) makes sense.  That would be written >> >>     dependency('libudev', >>                required: get_option('mpath').enabled(), >>                

Re: [PATCH v2 2/2] vhost: Don't call log_access_ok() when using IOTLB

On Sat, 3 Oct 2020 09:58:59 +0800 Jason Wang wrote: > > On 2020/9/30 上午12:30, Greg Kurz wrote: > > When the IOTLB device is enabled, the log_guest_addr that is passed by > > userspace to the VHOST_SET_VRING_ADDR ioctl, and which is then written > > to vq->log_addr, is a GIOVA. All writes to

Re: [PATCH] meson.build: Don't look for libudev for static builds

On Sat, Oct 3, 2020 at 3:50 PM Paolo Bonzini wrote: > > On 03/10/20 09:24, 罗勇刚(Yonggang Luo) wrote: > > > > > > On Fri, Oct 2, 2020 at 9:11 PM Peter Maydell > > wrote: > >> > >> On Fri, 2 Oct 2020 at 14:05, Paolo Bonzini > > wrote: >

Re: [PATCH] meson.build: Don't look for libudev for static builds

On Sat, Oct 3, 2020 at 3:50 PM Paolo Bonzini wrote: > > On 03/10/20 09:24, 罗勇刚(Yonggang Luo) wrote: > > > > > > On Fri, Oct 2, 2020 at 9:11 PM Peter Maydell > > wrote: > >> > >> On Fri, 2 Oct 2020 at 14:05, Paolo Bonzini > > wrote: >

[Bug 1894804] Re: Second DEVICE_DELETED event missing during virtio-blk disk device detach

I was seeing in my manual tests that the delete->Event was taking a bit longer, maybe your retry logic kicks in before it is complete now. And due to that the problem takes place. So with the PPA you should get: a) a warning, but no more the cancelled/undefined behavior on double delete b) can

Re: [PATCH] meson.build: Don't look for libudev for static builds

On 03/10/20 09:24, 罗勇刚(Yonggang Luo) wrote: > > > On Fri, Oct 2, 2020 at 9:11 PM Peter Maydell > wrote: >> >> On Fri, 2 Oct 2020 at 14:05, Paolo Bonzini > wrote: >> > >> > On 02/10/20 14:35, Peter Maydell wrote: >> > > >> > > It

Re: [PATCH] meson.build: Don't look for libudev for static builds

On Fri, Oct 2, 2020 at 9:11 PM Peter Maydell wrote: > > On Fri, 2 Oct 2020 at 14:05, Paolo Bonzini wrote: > > > > On 02/10/20 14:35, Peter Maydell wrote: > > > > > > It would be better to do the "see if a static library is present" > > > test. This isn't too hard to do in configure (compare that

Re: [PULL v2 00/11] capstone + disassembler patch queue

On 02/10/20 22:37, Peter Maydell wrote: > ../src/meson.build:753: WARNING: Trying to compare values of different > types (bool, str) using ==. > The result of this is undefined and will become a hard error in a > future Meson release. > Configuring config-host.h using configuration > Program

Re: [PULL v2 00/11] capstone + disassembler patch queue

On 02/10/20 22:37, Peter Maydell wrote: > Found CMake: /usr/bin/cmake (2.8.12.2) > WARNING: The version of CMake /usr/bin/cmake is 2.8.12.2 but version >> =3.4 is required > Run-time dependency capstone found: NO (tried pkgconfig and cmake) > Configuring capstone-defs.h using configuration >