Re: [PATCH v5 03/36] qapi-gen: Separate arg-parsing from generation

2020-10-07 Thread Markus Armbruster
John Snow writes: > On 10/7/20 3:54 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> On 10/6/20 7:51 AM, Markus Armbruster wrote: John Snow writes: > This is a minor re-work of the entrypoint script. It isolates a > generate() method from the actual command-line

[PATCH] linux-user: target: signal: Support TARGET_SS_AUTODISARM

2020-10-07 Thread chengang
From: Chen Gang Add definitions to pass building. Signed-off-by: Chen Gang --- linux-user/alpha/target_signal.h | 6 ++ linux-user/hppa/target_signal.h | 5 + linux-user/mips/target_signal.h | 6 ++ linux-user/mips64/target_signal.h | 5 + linux-user/sparc/target_signal.h

[Bug 584146] Re: Virtual fat breaks with -snapshot

2020-10-07 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/584146 Title: Virtual fat

[Bug 1860610] Re: cap_disas_plugin leaks memory

2020-10-07 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1860610 Title:

[PATCH] linux-user: signal: Support TARGET_SS_AUTODISARM

2020-10-07 Thread chengang
From: Chen Gang Microsoft sqlserver 2017 x86_64 uses it. The implementation references from the linux kernel. Signed-off-by: Chen Gang --- linux-user/generic/signal.h | 6 ++ linux-user/signal.c | 23 ++- 2 files changed, 24 insertions(+), 5 deletions(-) diff

[Bug 1667613] Re: Qemu 2.8 on PPC64 issue with input

2020-10-07 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1667613 Title: Qemu 2.8

[PATCH v3 0/2] Add watchdog support for SbsaQemu

2020-10-07 Thread Shashi Mallela
This patch series adds watchdog timer support for SbsaQemu platform. The watchdog timer has been implemented first based on the generic watchdog timer specifications from ARM BSA v0.9 and then used in the SbsaQemu reference platform Changes in v3: - overall functionality has been tested

[PATCH v3 2/2] hw/arm/sbsa-ref: add SBSA watchdog device

2020-10-07 Thread Shashi Mallela
Included the newly implemented SBSA generic watchdog device model into SBSA platform Signed-off-by: Shashi Mallela --- hw/arm/sbsa-ref.c | 44 1 file changed, 44 insertions(+) diff --git a/hw/arm/sbsa-ref.c b/hw/arm/sbsa-ref.c index

[PATCH v3 1/2] hw/watchdog: Implement SBSA watchdog device

2020-10-07 Thread Shashi Mallela
Generic watchdog device model has been implemented as per ARM BSAv0.9 Signed-off-by: Shashi Mallela --- hw/arm/Kconfig | 1 + hw/watchdog/Kconfig | 4 + hw/watchdog/meson.build | 1 + hw/watchdog/wdt_sbsa_gwdt.c | 345

Re: [External] Re: [PATCH 1/2] hw/misc: add an EMC141{3, 4} device model

2020-10-07 Thread John Wang
On Thu, Oct 1, 2020 at 11:04 PM Cédric Le Goater wrote: > > Hello, > > On 9/29/20 7:53 AM, John Wang wrote: > > Largely inspired by the TMP423 temperature sensor, here is a model for > > It's a TMP421 temperature sensor Will fix > > > the EMC1413 temperature sensors. > > > > Specs can be found

Re: [External] Re: [PATCH 2/2] aspeed: Add support for the g220a-bmc board

2020-10-07 Thread John Wang
On Thu, Oct 1, 2020 at 10:56 PM Cédric Le Goater wrote: > > On 9/29/20 7:53 AM, John Wang wrote: > > G220A is a 2 socket x86 motherboard supported by OpenBMC. > > Strapping configuration was obtained from hardware. > > > > Signed-off-by: John Wang > > Reviewed-by: Cédric Le Goater > > > One

Re: [PATCH v1 21/22] cirrus: use V=1 when running tests on FreeBSD and macOS

2020-10-07 Thread Ed Maste
On Wed, 7 Oct 2020 at 12:09, Alex Bennée wrote: > > From: Paolo Bonzini > > Using "V=1" makes it easier to identify hanging tests, especially > since they are run with -j1. It is already used on Windows builds, > do the same for FreeBSD and macOS. > > Signed-off-by: Paolo Bonzini >

[Bug 1898954] [NEW] x86 f1 opcode hangs qemu

2020-10-07 Thread pat leese
Public bug reported: I have qemu installed and running in linux and windows in linux i execute the following simple code in real mode of cpu in my vm 90 nop 90 nop 90 nop f1 ;this should conjure up my interrupt handler from ivt int 1 - end of code it works properly in

Re: [PATCH 00/24] qom: Convert some properties to class properties

2020-10-07 Thread Eduardo Habkost
On Tue, Sep 22, 2020 at 05:00:40PM -0400, Eduardo Habkost wrote: > On Mon, Sep 21, 2020 at 06:10:21PM -0400, Eduardo Habkost wrote: > > Class properties make QOM introspection simpler and easier, as it > > doesn't require an object to be instantiated. This series > > converts a few existing

[PATCH] qom: Fix "typddef" typo

2020-10-07 Thread Eduardo Habkost
Fix typo introduced in the C11 #ifdef for qemu_max_align_t. It never caused any problems because we always compile using -std=gnu99. Fixes: 4c880f363e9e ("qom: Allow objects to be allocated with increased alignment") Signed-off-by: Eduardo Habkost --- qom/object.c | 2 +- 1 file changed, 1

[PATCH v2] bsd-user/elfload: use g_new/g_malloc

2020-10-07 Thread Elena Afanasova
Signed-off-by: Elena Afanasova --- bsd-user/elfload.c | 88 -- 1 file changed, 30 insertions(+), 58 deletions(-) diff --git a/bsd-user/elfload.c b/bsd-user/elfload.c index 32378af7b2..f1be01c410 100644 --- a/bsd-user/elfload.c +++ b/bsd-user/elfload.c

Re: [PATCH v2 4/5] nbd: Add new qemu:allocation-depth metacontext

2020-10-07 Thread Eric Blake
On 10/7/20 8:40 AM, Vladimir Sementsov-Ogievskiy wrote: > 30.09.2020 15:11, Eric Blake wrote: >> 'qemu-img map' provides a way to determine which extents of an image >> come from the top layer vs. inherited from a backing chain.  This is >> useful information worth exposing over NBD.  There is a

Re: [PATCH v10] scripts: Convert qemu-version.sh to qemu-version.py

2020-10-07 Thread Yonggang Luo
On Thu, Oct 8, 2020 at 4:31 AM Paolo Bonzini wrote: > > You won't hear no for an answer, right?... I am trying to figure out the real issue, it's the issue of git, https://github.com/msys2/MSYS2-packages/issues/2176 The windows wildcard can be disabled and git disabled it, didn't know what's

Re: [PATCH v2 3/5] nbd: Simplify meta-context parsing

2020-10-07 Thread Eric Blake
On 10/7/20 6:51 AM, Vladimir Sementsov-Ogievskiy wrote: > 30.09.2020 15:11, Eric Blake wrote: >> We had a premature optimization of trying to read as little from the >> wire as possible while handling NBD_OPT_SET_META_CONTEXT in phases. >> But in reality, we HAVE to read the entire string from the

Re: [PATCH V1 30/32] vfio-pci: save and restore

2020-10-07 Thread Steven Sistare
On 8/20/2020 6:33 AM, Jason Zeng wrote: > On Wed, Aug 19, 2020 at 05:15:11PM -0400, Steven Sistare wrote: >> On 8/9/2020 11:50 PM, Jason Zeng wrote: >>> On Fri, Aug 07, 2020 at 04:38:12PM -0400, Steven Sistare wrote: On 8/6/2020 6:22 AM, Jason Zeng wrote: > Hi Steve, > > On

Re: [PATCH v2 1/5] qemu-nbd: Honor SIGINT and SIGHUP

2020-10-07 Thread Eric Blake
On 10/7/20 5:32 AM, Vladimir Sementsov-Ogievskiy wrote: > 30.09.2020 15:11, Eric Blake wrote: >> Honoring just SIGTERM on Linux is too weak; we also want to handle >> other common signals, and do so even on BSD.  Why?  Because at least >> 'qemu-nbd -B bitmap' needs a chance to clean up the in-use

[PATCH v2 3/5] target/mips: Demacro helpers for .

2020-10-07 Thread Aleksandar Markovic
Remove function definitions via macros to achieve better code clarity. Signed-off-by: Aleksandar Markovic --- target/mips/fpu_helper.c | 104 --- 1 file changed, 81 insertions(+), 23 deletions(-) diff --git a/target/mips/fpu_helper.c

[PATCH v2 2/5] target/mips: Demacro helpers for MF.

2020-10-07 Thread Aleksandar Markovic
Remove function definitions via macros to achieve better code clarity. Signed-off-by: Aleksandar Markovic --- target/mips/fpu_helper.c | 63 +++- 1 file changed, 46 insertions(+), 17 deletions(-) diff --git a/target/mips/fpu_helper.c

[PATCH v2 5/5] MAINTAINERS: Remove myself

2020-10-07 Thread Aleksandar Markovic
I have been working on project other than QEMU for some time, and would like to devote myself to that project. It is imposible for me to find enough time to perform maintainer's duties with needed meticulousness and patience. I wish prosperous future to QEMU and all colegues in QEMU community.

[PATCH v2 4/5] target/mips: Refactor helpers for fp comparison instructions

2020-10-07 Thread Aleksandar Markovic
This change causes slighlty better performance of emulation of fp comparison instructions via better compiler optimization of refactored code. The functionality is otherwise unchanged. Signed-off-by: Aleksandar Markovic --- target/mips/fpu_helper.c | 56

[PATCH v2 1/5] target/mips: Demacro helpers for .

2020-10-07 Thread Aleksandar Markovic
Remove function definitions via macros to achieve better code clarity. Signed-off-by: Aleksandar Markovic --- target/mips/fpu_helper.c | 61 +++- 1 file changed, 40 insertions(+), 21 deletions(-) diff --git a/target/mips/fpu_helper.c

[PATCH v2 0/5] target/mips: Misc patches

2020-10-07 Thread Aleksandar Markovic
A set of several, mostly FP, refactorings and improvements. v1->v2: - added a patch on MAINTAINERS Aleksandar Markovic (5): target/mips: Demacro helpers for . target/mips: Demacro helpers for MF. target/mips: Demacro helpers for . target/mips: Refactor helpers for fp comparison

Re: [PATCH v10] scripts: Convert qemu-version.sh to qemu-version.py

2020-10-07 Thread Paolo Bonzini
You won't hear no for an answer, right?... Paolo Il mer 7 ott 2020, 22:00 Yonggang Luo ha scritto: > The sh script are harder to maintain for compatible different > xsh environment so convert it to python script > Also incorporate the fixes in > >

[PATCH v10] scripts: Convert qemu-version.sh to qemu-version.py

2020-10-07 Thread Yonggang Luo
The sh script are harder to maintain for compatible different xsh environment so convert it to python script Also incorporate the fixes in https://patchew.org/QEMU/20200929143654.518157-1-marcandre.lur...@redhat.com/ Using v\\* on Windows and v* on other platform for matching version. Tested

Re: [PATCH v9] scripts: Convert qemu-version.sh to qemu-version.py

2020-10-07 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20201007195035.2006-1-luoyongg...@gmail.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20201007195035.2006-1-luoyongg...@gmail.com Subject: [PATCH v9] scripts: Convert

Re: [PATCH v8] scripts: Convert qemu-version.sh to qemu-version.py

2020-10-07 Thread Paolo Bonzini
Il mer 7 ott 2020, 21:46 Yonggang Luo ha scritto: > The sh script are harder to maintain for compatible different > xsh environment so convert it to python script > Also incorporate the fixes in > > https://patchew.org/QEMU/20200929143654.518157-1-marcandre.lur...@redhat.com/ > Using --match=v*

Re: [PATCH v8] scripts: Convert qemu-version.sh to qemu-version.py

2020-10-07 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20201007194526.1778-1-luoyongg...@gmail.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20201007194526.1778-1-luoyongg...@gmail.com Subject: [PATCH v8] scripts: Convert

Re: [PATCH v6] scripts: Convert qemu-version.sh to qemu-version.py

2020-10-07 Thread Paolo Bonzini
Il mer 7 ott 2020, 21:18 Peter Maydell ha scritto: > > I have no idea how to fix it. Probably it can be made to work using a > > string argument and "shell=True", but at this point it makes more sense > > to keep the shell script version. > > If you're keeping the shell script version could you

[PATCH v9] scripts: Convert qemu-version.sh to qemu-version.py

2020-10-07 Thread Yonggang Luo
The sh script are harder to maintain for compatible different xsh environment so convert it to python script Also incorporate the fixes in https://patchew.org/QEMU/20200929143654.518157-1-marcandre.lur...@redhat.com/ Using --match=v* instead of --match 'v*' for speed up the git version And using

[PATCH v8] scripts: Convert qemu-version.sh to qemu-version.py

2020-10-07 Thread Yonggang Luo
The sh script are harder to maintain for compatible different xsh environment so convert it to python script Also incorporate the fixes in https://patchew.org/QEMU/20200929143654.518157-1-marcandre.lur...@redhat.com/ Using --match=v* instead of --match 'v*' for speed up the git version And using

Re: [PATCH v7] scripts: Convert qemu-version.sh to qemu-version.py

2020-10-07 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20201007192940.280-1-luoyongg...@gmail.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20201007192940.280-1-luoyongg...@gmail.com Subject: [PATCH v7] scripts: Convert

Re: [PATCH v10 8/9] block: remove unused backing-file name parameter

2020-10-07 Thread Andrey Shinkevich
On 07.10.2020 13:21, Vladimir Sementsov-Ogievskiy wrote: 29.09.2020 15:38, Andrey Shinkevich wrote: The block stream QMP parameter backing-file is in use no more. It designates a backing file name to set in QCOW2 image header after the block stream job finished. The base file name is used

[PATCH v7] scripts: Convert qemu-version.sh to qemu-version.py

2020-10-07 Thread Yonggang Luo
The sh script are harder to maintain for compatible different xsh environment so convert it to python script Also incorporate the fixes in https://patchew.org/QEMU/20200929143654.518157-1-marcandre.lur...@redhat.com/ Using --match=v* instead of --match 'v*' for speed up the git version retrieve,

Re: [PATCH v10 6/9] copy-on-read: skip non-guest reads if no copy needed

2020-10-07 Thread Vladimir Sementsov-Ogievskiy
07.10.2020 22:01, Andrey Shinkevich wrote: On 07.10.2020 13:06, Vladimir Sementsov-Ogievskiy wrote: 29.09.2020 15:38, Andrey Shinkevich wrote: If the flag BDRV_REQ_PREFETCH was set, pass it further to the COR-driver to skip unneeded reading. It can be taken into account for the COR-algorithms

Re: [PATCH v6] scripts: Convert qemu-version.sh to qemu-version.py

2020-10-07 Thread Peter Maydell
On Wed, 7 Oct 2020 at 17:43, Paolo Bonzini wrote: > I have no idea how to fix it. Probably it can be made to work using a > string argument and "shell=True", but at this point it makes more sense > to keep the shell script version. If you're keeping the shell script version could you queue the

Re: [PATCH 18/20] python/qemu/qmp.py: re-raise OSError when encountered

2020-10-07 Thread John Snow
On 10/7/20 7:30 AM, Kevin Wolf wrote: Am 07.10.2020 um 01:58 hat John Snow geschrieben: Nested if conditions don't change when the exception block fires; we need to explicitly re-raise the error if we didn't intend to capture and suppress it. Signed-off-by: John Snow --- python/qemu/qmp.py

Re: [PATCH v6] scripts: Convert qemu-version.sh to qemu-version.py

2020-10-07 Thread Yonggang Luo
On Thu, Oct 8, 2020 at 12:43 AM Paolo Bonzini wrote: > > On 07/10/20 18:23, 罗勇刚(Yonggang Luo) wrote: > >> +if not pkgversion and os.path.exists('.git'): > >> +# The quote of v* should preserve, otherwise git command > > would fail > >> +pc = subprocess.run(['git', 'describe',

[PATCH v3 10/10] s390x/pci: get zPCI function info from host

2020-10-07 Thread Matthew Rosato
We use the capability chains of the VFIO_DEVICE_GET_INFO ioctl to retrieve the CLP information that the kernel exports. To be compatible with previous kernel versions we fall back on previous predefined values, same as the emulation values, when the ioctl is found to not support capability

[PATCH v3 09/10] vfio: Add routine for finding VFIO_DEVICE_GET_INFO capabilities

2020-10-07 Thread Matthew Rosato
Now that VFIO_DEVICE_GET_INFO supports capability chains, add a helper function to find specific capabilities in the chain. Signed-off-by: Matthew Rosato --- hw/vfio/common.c | 10 ++ include/hw/vfio/vfio-common.h | 2 ++ 2 files changed, 12 insertions(+) diff --git

Re: [PATCH 20/20] python: add mypy config

2020-10-07 Thread John Snow
On 10/7/20 7:35 AM, Kevin Wolf wrote: Am 07.10.2020 um 01:58 hat John Snow geschrieben: Formalize the options used for checking the python library. You can run mypy from the directory that mypy.ini is in by typing `mypy qemu/`. Signed-off-by: John Snow --- python/mypy.ini | 4 1 file

[PATCH v3 07/10] s390x/pci: clean up s390 PCI groups

2020-10-07 Thread Matthew Rosato
Add a step to remove all stashed PCI groups to avoid stale data between machine resets. Signed-off-by: Matthew Rosato --- hw/s390x/s390-pci-bus.c | 12 1 file changed, 12 insertions(+) diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c index c99f2f0..c34f14a 100644 ---

[PATCH v3 03/10] update-linux-headers: Add vfio_zdev.h

2020-10-07 Thread Matthew Rosato
vfio_zdev.h is used by s390x zPCI support to pass device-specific CLP information between host and userspace. Signed-off-by: Matthew Rosato Acked-by: Cornelia Huck --- scripts/update-linux-headers.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v3 04/10] linux-headers: update against 5.9-rc8

2020-10-07 Thread Matthew Rosato
PLACEHOLDER as the kernel patch driving the need for this ("vfio: Introduce capability definitions for VFIO_DEVICE_GET_INFO") isn't merged yet. Signed-off-by: Matthew Rosato --- linux-headers/linux/kvm.h | 6 ++-- linux-headers/linux/vfio.h | 11 ++

[PATCH v3 08/10] s390x/pci: use a PCI Function structure

2020-10-07 Thread Matthew Rosato
From: Pierre Morel We use a ClpRspQueryPci structure to hold the information related to a zPCI Function. This allows us to be ready to support different zPCI functions and to retrieve the zPCI function information from the host. Signed-off-by: Pierre Morel Signed-off-by: Matthew Rosato ---

[PATCH v3 02/10] vfio: Create shared routine for scanning info capabilities

2020-10-07 Thread Matthew Rosato
Rather than duplicating the same loop in multiple locations, create a static function to do the work. Signed-off-by: Matthew Rosato Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Cornelia Huck --- hw/vfio/common.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-)

[PATCH v3 05/10] s390x/pci: create a header dedicated to PCI CLP

2020-10-07 Thread Matthew Rosato
From: Pierre Morel To have a clean separation between s390-pci-bus.h and s390-pci-inst.h headers we export the PCI CLP instructions in a dedicated header. Signed-off-by: Pierre Morel Signed-off-by: Matthew Rosato Reviewed-by: Cornelia Huck --- include/hw/s390x/s390-pci-bus.h | 1 +

[PATCH v3 00/10] Retrieve zPCI hardware information from VFIO

2020-10-07 Thread Matthew Rosato
This patchset adds code to s390 pci to examine the VFIO_DEVICE_GET_INFO capability chain, looking for capabilities that describe the underlying hardware and features of the passed-through device. The retrieval of this information is done once per function (and for a subset of data, once per

[PATCH v3 01/10] s390x/pci: Move header files to include/hw/s390x

2020-10-07 Thread Matthew Rosato
Seems a more appropriate location for them. Signed-off-by: Matthew Rosato --- MAINTAINERS | 1 + hw/s390x/s390-pci-bus.c | 4 ++-- hw/s390x/s390-pci-inst.c | 4 ++-- hw/s390x/s390-virtio-ccw.c | 2 +- {hw =>

Re: [PATCH 17/20] python/qemu/qmp.py: Preserve error context on re-raise

2020-10-07 Thread John Snow
On 10/7/20 7:21 AM, Kevin Wolf wrote: Am 07.10.2020 um 01:58 hat John Snow geschrieben: Use the "from ..." phrasing when re-raising errors to preserve their initial context, to help aid debugging when things go wrong. This also silences a pylint 2.6.0+ error. Signed-off-by: John Snow I

[PATCH v3 06/10] s390x/pci: use a PCI Group structure

2020-10-07 Thread Matthew Rosato
From: Pierre Morel We use a S390PCIGroup structure to hold the information related to a zPCI Function group. This allows us to be ready to support multiple groups and to retrieve the group information from the host. Signed-off-by: Pierre Morel Signed-off-by: Matthew Rosato ---

Re: [PATCH v10 6/9] copy-on-read: skip non-guest reads if no copy needed

2020-10-07 Thread Andrey Shinkevich
On 07.10.2020 13:06, Vladimir Sementsov-Ogievskiy wrote: 29.09.2020 15:38, Andrey Shinkevich wrote: If the flag BDRV_REQ_PREFETCH was set, pass it further to the COR-driver to skip unneeded reading. It can be taken into account for the COR-algorithms optimization. That check is being made

[Bug 1716510] Re: qemu 2.10.0 cannot boot Windows 10 familly

2020-10-07 Thread Thomas Huth
Since this seems to be fixed when using EDK, I'm marking this ticket as Fix Released ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1716510

[Bug 1704186] Re: no option for handling ^C in stdio

2020-10-07 Thread Thomas Huth
You can select the behavior of ^C when specifying "-chardev stdio,signal=[on|off]". See also https://www.qemu.org/docs/master/system/invocation.html#hxtool-6 ** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which

[Bug 1718719] Re: qemu can't capture keys properly under wayland

2020-10-07 Thread Thomas Huth
Is there still an issue left here for upstream QEMU? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1718719 Title: qemu can't capture keys

Re: [PATCH v5 1/2] cirrus: Fixing and speedup the msys2/mingw CI

2020-10-07 Thread Alex Bennée
罗勇刚(Yonggang Luo) writes: > On Wed, Oct 7, 2020 at 11:12 PM Thomas Huth wrote: >> >> On 07/10/2020 16.52, Yonggang Luo wrote: >> > Use cache of cirrus caching msys2 >> > The install of msys2 are refer to https://github.com/msys2/setup-msys2 >> > The first time install msys2 would be time

[Bug 1722884] Re: keyboard input while mouse moving triggers mouse failure

2020-10-07 Thread Thomas Huth
Ok, so if this bug has been fixed, let's close this ticket. ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1722884 Title: keyboard input

Re: [PATCH 12/20] python/qemu/console_socket.py: Correct type of recv()

2020-10-07 Thread John Snow
On 10/7/20 6:59 AM, Kevin Wolf wrote: Am 07.10.2020 um 01:58 hat John Snow geschrieben: The type and parameter names of recv() should match socket.socket(). Should this be socket.socket without parentheses (the class name)? socket.socket() is the constructor and it takes very different

Re: [PATCH 11/20] python/qemu: Add mypy type annotations

2020-10-07 Thread John Snow
On 10/7/20 6:46 AM, Kevin Wolf wrote: Am 07.10.2020 um 01:58 hat John Snow geschrieben: These should all be purely annotations with no changes in behavior at all. You need to be in the python folder, but you should be able to confirm that these annotations are correct (or at least

[Bug 1723488] Re: HAX on Windows, memory lease error

2020-10-07 Thread Thomas Huth
Looking through old bug tickets... is this still an issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Bug 1723161] Re: Migration failing in qemu-2.10.1 but working qemu-2.9.1 and earlier with same options

2020-10-07 Thread Thomas Huth
Looking through old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is

Re: [PATCH 08/20] python/machine.py: fix _popen access

2020-10-07 Thread John Snow
On 10/7/20 6:07 AM, Kevin Wolf wrote: Am 07.10.2020 um 01:58 hat John Snow geschrieben: As always, Optional[T] causes problems with unchecked access. Add a helper that asserts the pipe is present before we attempt to talk with it. Signed-off-by: John Snow First a question about the

[PATCH] migration/postcopy: Release fd before going into 'postcopy-pause'

2020-10-07 Thread Peter Xu
Logically below race could trigger with the old code: test programmigration thread wait_until('postcopy-pause') postcopy_pause()

Re: [PATCH 07/20] python/machine.py: Add _qmp access shim

2020-10-07 Thread John Snow
On 10/7/20 5:53 AM, Kevin Wolf wrote: Am 07.10.2020 um 01:58 hat John Snow geschrieben: Like many other Optional[] types, it's not always a given that this object will be set. Wrap it in a type-shim that raises a meaningful error and will always return a concrete type. Signed-off-by: John Snow

Re: [PATCH v5 11/36] qapi/common.py: Add indent manager

2020-10-07 Thread Eduardo Habkost
On Wed, Oct 07, 2020 at 02:08:33PM -0400, John Snow wrote: > On 10/7/20 4:50 AM, Markus Armbruster wrote: > > John Snow writes: > > > > > Code style tools really dislike the use of global keywords, because it > > > generally involves re-binding the name at runtime which can have strange > > >

Re: [PATCH 03/20] python/machine.py: reorder __init__

2020-10-07 Thread John Snow
On 10/7/20 5:43 AM, Kevin Wolf wrote: Am 07.10.2020 um 01:58 hat John Snow geschrieben: Put the init arg handling all at the top, and mostly in order (deviating when one is dependent on another), and put what is effectively runtime state declaration at the bottom. Signed-off-by: John Snow ---

Re: [PATCH v5 17/36] qapi/common.py: move build_params into gen.py

2020-10-07 Thread Eduardo Habkost
On Wed, Oct 07, 2020 at 11:21:51AM +0200, Markus Armbruster wrote: > John Snow writes: > > > Including it in common.py creates a circular import dependency; schema > > relies on common, but common.build_params requires a type annotation > > from schema. To type this properly, it needs to be

Re: [PATCH v5 11/36] qapi/common.py: Add indent manager

2020-10-07 Thread John Snow
On 10/7/20 4:50 AM, Markus Armbruster wrote: John Snow writes: Code style tools really dislike the use of global keywords, because it generally involves re-binding the name at runtime which can have strange effects depending on when and how that global name is referenced in other modules.

Re: KVM call for agenda for 2020-10-06

2020-10-07 Thread Daniel P . Berrangé
On Wed, Oct 07, 2020 at 07:50:20PM +0200, Paolo Bonzini wrote: > On 06/10/20 20:21, Stefan Hajnoczi wrote: > > * Does command-line order matter? > > * Two options: allow any order OR left-to-right ordering > > * Andrea Bolognani: Most users expect left-to-right ordering, > >

Re: [PATCH v2] Adding ani's email as an individual contributor

2020-10-07 Thread Philippe Mathieu-Daudé
On 10/7/20 6:19 PM, Ani Sinha wrote: > Ani is an individual contributor into qemu project. Adding my email into the > correct file to reflect so. > Reviewed-by: Philippe Mathieu-Daudé Thanks! > Signed-off-by: Ani Sinha > --- > contrib/gitdm/group-map-individuals | 1 + > 1 file changed, 1

Re: [PATCH v1 03/22] hw/ide: restore replay support of IDE

2020-10-07 Thread Philippe Mathieu-Daudé
On 10/7/20 6:00 PM, Alex Bennée wrote: > A recent change to weak reset handling broke replay due to the use of > aio_bh_schedule_oneshot instead of the replay aware > replay_bh_schedule_oneshot_event. > > Fixes: 55adb3c456 ("ide: cancel pending callbacks on SRST") > Suggested-by: Pavel Dovgalyuk

Re: KVM call for agenda for 2020-10-06

2020-10-07 Thread Paolo Bonzini
On 06/10/20 20:21, Stefan Hajnoczi wrote: > * Does command-line order matter? > * Two options: allow any order OR left-to-right ordering > * Andrea Bolognani: Most users expect left-to-right ordering, > why allow any order? > * Eduardo Habkost: Can we enforce

Re: [PATCH v10 3/4] tests/qtest: Introduce tests for Xilinx ZynqMP CAN controller

2020-10-07 Thread Vikram Garhwal
Hi Philippe, Thanks for reviewing this one. I will address the comments in next version and add reviewed-by tags. On Fri, Oct 02, 2020 at 03:49:31PM +0200, Philippe Mathieu-Daudé wrote: > Hi Vikram, > > On 9/15/20 12:08 AM, Vikram Garhwal wrote: > > The QTests perform five tests on the Xilinx

Re: [PATCH v10 9/9] block: apply COR-filter to block-stream jobs

2020-10-07 Thread Andrey Shinkevich
On 07.10.2020 20:27, Andrey Shinkevich wrote: On 29.09.2020 15:38, Andrey Shinkevich wrote: This patch completes the series with the COR-filter insertion for block-stream operations. Adding the filter makes it possible for copied regions to be discarded in backing files during the

Re: [PATCH v10 1/4] hw/net/can: Introduce Xilinx ZynqMP CAN controller

2020-10-07 Thread Vikram Garhwal
Hi Philippe, Thank you so much for reviewing this patch. On Fri, Oct 02, 2020 at 04:18:08PM +0200, Philippe Mathieu-Daudé wrote: > Hi Vikram, > > Sorry for reviewing that late (v10). > > On 9/15/20 12:08 AM, Vikram Garhwal wrote: > > The Xilinx ZynqMP CAN controller is developed based on

Re: [PATCH v3 1/4] keyval: Parse help options

2020-10-07 Thread Eric Blake
On 10/7/20 11:49 AM, Kevin Wolf wrote: > This adds a special meaning for 'help' and '?' as options to the keyval > parser. Instead of being an error (because of a missing value) or a > value for an implied key, they now request help, which is a new boolean > ouput of the parser in addition to the

[PATCH v4 5/5] specs/ppc-spapr-numa: update with new NUMA support

2020-10-07 Thread Daniel Henrique Barboza
This update provides more in depth information about the choices and drawbacks of the new NUMA support for the spapr machine. Signed-off-by: Daniel Henrique Barboza --- docs/specs/ppc-spapr-numa.rst | 235 -- 1 file changed, 227 insertions(+), 8 deletions(-)

[PATCH v4 4/5] spapr_numa: consider user input when defining associativity

2020-10-07 Thread Daniel Henrique Barboza
A new function called spapr_numa_define_associativity_domains() is created to calculate the associativity domains and change the associativity arrays considering user input. This is how the associativity domain between two NUMA nodes A and B is calculated: - get the distance D between them - get

[PATCH v4 3/5] spapr_numa: change reference-points and maxdomain settings

2020-10-07 Thread Daniel Henrique Barboza
This is the first guest visible change introduced in spapr_numa.c. The previous settings of both reference-points and maxdomains were too restrictive, but enough for the existing associativity we're setting in the resources. We'll change that in the following patches, populating the associativity

[PATCH v4 2/5] spapr_numa: forbid asymmetrical NUMA setups

2020-10-07 Thread Daniel Henrique Barboza
The pSeries machine does not support asymmetrical NUMA configurations. This doesn't make much of a different since we're not using user input for pSeries NUMA setup, but this will change in the next patches. To avoid breaking existing setups, gate this change by checking for legacy NUMA support.

[PATCH v4 1/5] spapr: add spapr_machine_using_legacy_numa() helper

2020-10-07 Thread Daniel Henrique Barboza
The changes to come to NUMA support are all guest visible. In theory we could just create a new 5_1 class option flag to avoid the changes to cascade to 5.1 and under. The reality is that these changes are only relevant if the machine has more than one NUMA node. There is no need to change guest

[PATCH v4 0/5] pseries NUMA distance calculation

2020-10-07 Thread Daniel Henrique Barboza
This forth version is based on review comments and suggestion from David in v3. changes from v3: - patch 4: * copied the explanation in spapr_numa_define_associativity_domains() to the commit message * return numa_level directly instead of calculating a temp value in

Re: [PATCH v10 9/9] block: apply COR-filter to block-stream jobs

2020-10-07 Thread Andrey Shinkevich
On 29.09.2020 15:38, Andrey Shinkevich wrote: This patch completes the series with the COR-filter insertion for block-stream operations. Adding the filter makes it possible for copied regions to be discarded in backing files during the block-stream job, what will reduce the disk overuse. The

Re: [PATCH v1 22/22] tests/acceptance: disable machine_rx_gdbsim on GitLab

2020-10-07 Thread Willian Rampazzo
On Wed, Oct 7, 2020 at 1:37 PM Alex Bennée wrote: > > While I can get the ssh test to fail on my test setup this seems a lot > more stable except when on GitLab. Hopefully we can re-enable both > once the serial timing patches have been added. Fair enough! > > Signed-off-by: Alex Bennée > ---

[Bug 1898490] Re: gtk with virtio and opengl black screen

2020-10-07 Thread Olivier Robert
Oops sorry, I misposted, is there any way to remove this ? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1898490 Title: gtk with virtio and opengl black screen Status in QEMU: New Bug

Re: [PATCH v5 02/36] qapi: modify docstrings to be sphinx-compatible

2020-10-07 Thread John Snow
On 10/7/20 3:24 AM, Markus Armbruster wrote: John Snow writes: On 10/6/20 7:21 AM, Markus Armbruster wrote: John Snow writes: A precise style guide and a package-wide overhaul is forthcoming pending further discussion and consensus. At present, we are avoiding obvious errors that cause

Re: [PATCH v5 27/36] qapi/gen.py: add type hint annotations

2020-10-07 Thread John Snow
On 10/7/20 9:20 AM, Markus Armbruster wrote: John Snow writes: Annotations do not change runtime behavior. This commit *only* adds annotations. Signed-off-by: John Snow Reviewed-by: Eduardo Habkost Reviewed-by: Cleber Rosa --- scripts/qapi/gen.py | 104

Re: [PATCH v6] scripts: Convert qemu-version.sh to qemu-version.py

2020-10-07 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20201007162138.425-1-luoyongg...@gmail.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20201007162138.425-1-luoyongg...@gmail.com Subject: [PATCH v6] scripts: Convert

[PATCH v3 4/4] qemu-storage-daemon: Remove QemuOpts from --object parser

2020-10-07 Thread Kevin Wolf
The command line parser for --object parses the input twice: Once into QemuOpts just for detecting help options, and then again into a QDict using the keyval parser for actually creating the object. Now that the keyval parser can also detect help options, we can simplify this and remove the

[Bug 1898490] Re: gtk with virtio and opengl black screen

2020-10-07 Thread Olivier Robert
Hello Christian, I should have pointed that the log is from the Android system, not Qemu or my host system ! I got the failure message running the following command in an Android shell : logcat '*:F' (which means display log entries from all facilities (*), with the Fatal (F) severity) It

[PATCH v3 3/4] qom: Add user_creatable_print_help_from_qdict()

2020-10-07 Thread Kevin Wolf
This adds a function that, given a QDict of non-help options, prints help for user creatable objects. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake Reviewed-by: Markus Armbruster --- include/qom/object_interfaces.h | 21 ++--- qom/object_interfaces.c | 9 +

[PATCH v3 0/4] qemu-storage-daemon: Remove QemuOpts from --object parser

2020-10-07 Thread Kevin Wolf
This replaces the QemuOpts-based help code for --object in the storage daemon with code based on the keyval parser. v3: - Always parse help options, no matter if the caller implements help or not. If it doesn't, return an error. [Markus] - Document changes to the keyval parser grammar [Markus]

[PATCH v3 1/4] keyval: Parse help options

2020-10-07 Thread Kevin Wolf
This adds a special meaning for 'help' and '?' as options to the keyval parser. Instead of being an error (because of a missing value) or a value for an implied key, they now request help, which is a new boolean ouput of the parser in addition to the QDict. A new parameter 'p_help' is added to

[PATCH] vhost: Don't special case vq->used_phys in vhost_get_log_size()

2020-10-07 Thread Greg Kurz
The first loop in vhost_get_log_size() computes the size of the dirty log bitmap so that it allows to track changes in the entire guest memory, in terms of GPA. When not using a vIOMMU, the address of the vring's used structure, vq->used_phys, is a GPA. It is thus already covered by the first

Re: [PATCH v6] scripts: Convert qemu-version.sh to qemu-version.py

2020-10-07 Thread Paolo Bonzini
On 07/10/20 18:23, 罗勇刚(Yonggang Luo) wrote: >> +    if not pkgversion and os.path.exists('.git'): >> +        # The quote of v* should preserve, otherwise git command > would fail >> +        pc = subprocess.run(['git', 'describe', '--match', "'v*'", > '--dirty', '--always'], >> +                  

[PATCH v3 2/4] qom: Factor out helpers from user_creatable_print_help()

2020-10-07 Thread Kevin Wolf
This creates separate helper functions for printing a list of user creatable object types and for printing a list of properties of a given type. This will allow using these parts without having a QemuOpts. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake Reviewed-by: Markus Armbruster ---

  1   2   3   4   >