[PATCH V2 09/10] net/colo-compare.c: Add secondary old packet detection

2020-10-15 Thread Zhang Chen
From: Zhang Chen Detect queued secondary packet to sync VM state in time. Signed-off-by: Zhang Chen Reviewed-by: Li Zhijian --- net/colo-compare.c | 25 - 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/net/colo-compare.c b/net/colo-compare.c index

[PATCH V2 05/10] colo-compare: fix missing compare_seq initialization

2020-10-15 Thread Zhang Chen
From: Li Zhijian Fixes: f449c9e549c ("colo: compare the packet based on the tcp sequence number") Signed-off-by: Li Zhijian Signed-off-by: Zhang Chen Reviewed-by: Zhang Chen Reviewed-by: Philippe Mathieu-Daudé --- net/colo.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff

[PATCH V2 08/10] net/colo-compare.c: Change the timer clock type

2020-10-15 Thread Zhang Chen
From: Zhang Chen The virtual clock only runs during the emulation. It stops when the virtual machine is stopped. The host clock should be used for device models that emulate accurate real time sources. It will continue to run when the virtual machine is suspended. COLO need to know the host time

[PATCH V2 03/10] Reduce the time of checkpoint for COLO

2020-10-15 Thread Zhang Chen
From: "Rao, Lei" we should set ram_bulk_stage to false after ram_state_init, otherwise the bitmap will be unused in migration_bitmap_find_dirty. all pages in ram cache will be flushed to the ram of secondary guest for each checkpoint. Signed-off-by: Lei Rao Signed-off-by: Derek Su

[PATCH V2 06/10] colo-compare: check mark in mutual exclusion

2020-10-15 Thread Zhang Chen
From: Li Zhijian Signed-off-by: Li Zhijian Signed-off-by: Zhang Chen Reviewed-by: Zhang Chen --- net/colo-compare.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/net/colo-compare.c b/net/colo-compare.c index a35c10fb59..8d476bbd99 100644 --- a/net/colo-compare.c

[PATCH V2 04/10] Fix the qemu crash when guest shutdown in COLO mode

2020-10-15 Thread Zhang Chen
From: "Rao, Lei" In COLO mode, if the startup parameters of QEMU include "no-shutdown", QEMU will crash when the guest shutdown. The root cause is when the guest shutdown, the state of VM will switch COLO to SHUTDOWN. When do checkpoint again, the state will be changed to COLO. But the state

[PATCH V2 01/10] net/filter-rewriter: destroy g_hash_table in colo_rewriter_cleanup

2020-10-15 Thread Zhang Chen
From: Pan Nengyuan s->connection_track_table forgot to destroy in colo_rewriter_cleanup. Fix it. Reported-by: Euler Robot Signed-off-by: Pan Nengyuan Signed-off-by: Zhang Chen Reviewed-by: Zhang Chen Reviewed-by: Li Qiang --- net/filter-rewriter.c | 2 ++ 1 file changed, 2 insertions(+)

[PATCH V2 02/10] Optimize seq_sorter function for colo-compare

2020-10-15 Thread Zhang Chen
From: "Rao, Lei" The seq of tcp has been filled in fill_pkt_tcp_info, it can be used directly here. Signed-off-by: Lei Rao Signed-off-by: Zhang Chen Reviewed-by: Li Zhijian Reviewed-by: Zhang Chen --- net/colo-compare.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff

[PATCH V2 07/10] net/colo-compare.c: Fix compare_timeout format issue

2020-10-15 Thread Zhang Chen
From: Zhang Chen This parameter need compare with the return of qemu_clock_get_ms(), it is uint64_t. So we need fix this issue here. Fixes: 9cc43c94b31 ("net/colo-compare.c: Expose "compare_timeout" to users") Reported-by: Derek Su Signed-off-by: Zhang Chen Reviewed-by: Li Zhijian

[PATCH V2 00/10] COLO project queued patches 20-Oct

2020-10-15 Thread Zhang Chen
From: Zhang Chen Hi Jason, this series include latest COLO related patches. please check and merge it. Li Zhijian (2): colo-compare: fix missing compare_seq initialization colo-compare: check mark in mutual exclusion Pan Nengyuan (1): net/filter-rewriter: destroy g_hash_table in

[PULL 3/3] hw/usb/hcd-dwc2: fix divide-by-zero in dwc2_handle_packet()

2020-10-15 Thread Gerd Hoffmann
From: Mauro Matteo Cascella Check the value of mps to avoid potential divide-by-zero later in the function. Since HCCHAR_MPS is guest controllable, this prevents a malicious/buggy guest from crashing the QEMU process on the host. Signed-off-by: Mauro Matteo Cascella Reviewed-by: Paul Zimmerman

[PULL 0/3] Usb 20201016 patches

2020-10-15 Thread Gerd Hoffmann
The following changes since commit 57c98ea9acdcef5021f5671efa6475a5794a51c4: Merge remote-tracking branch 'remotes/kraxel/tags/ui-20201014-pull-request' into staging (2020-10-14 13:56:06 +0100) are available in the Git repository at: git://git.kraxel.org/qemu tags/usb-20201016-pull-request

[PULL 1/3] usb: hcd-dwc2: change assert()s to qemu_log_mask(LOG_GUEST_ERROR...)

2020-10-15 Thread Gerd Hoffmann
From: Paul Zimmerman Change several assert()s to qemu_log_mask(LOG_GUEST_ERROR...), to prevent the guest from causing Qemu to assert. Also fix up several existing qemu_log_mask()s to include the function name in the message. Suggested-by: Peter Maydell Signed-off-by: Paul Zimmerman

[PULL 2/3] usb/hcd-ehci: Fix error handling on missing device for iTD

2020-10-15 Thread Gerd Hoffmann
From: Anthony PERARD via The EHCI Host Controller emulation attempt to locate the device associated with a periodic isochronous transfer description (iTD) and when this fail the host controller is reset. But according the EHCI spec 1.0 section 5.15.2.4 Host System Error, the host controller is

RE: [PATCH 00/10] COLO project queued patches 20-Oct

2020-10-15 Thread Zhang, Chen
> -Original Message- > From: Jason Wang > Sent: Friday, October 16, 2020 10:24 AM > To: Zhang, Chen ; qemu-dev de...@nongnu.org> > Cc: Zhang Chen > Subject: Re: [PATCH 00/10] COLO project queued patches 20-Oct > > > On 2020/10/15 下午3:58, Zhang, Chen wrote: > > > >> -Original

Re: [RFC PATCH] contrib/gitdm: Add more individual contributors

2020-10-15 Thread Thomas Huth
Am Sun, 4 Oct 2020 20:25:06 +0200 schrieb Philippe Mathieu-Daudé : > These individual contributors have a number of contributions, > add them to the 'individual' group map. > > Cc: Ahmed Karaman > Cc: Aleksandar Markovic > Cc: Alistair Francis > Cc: Artyom Tarasenko > Cc: David Carlier >

[PATCH v2 1/2] vhost-vdpa: Add qemu_close in vhost_vdpa_cleanup

2020-10-15 Thread Cindy Lu
fix the bug that fd will still open after the cleanup Signed-off-by: Cindy Lu --- net/vhost-vdpa.c | 4 1 file changed, 4 insertions(+) diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c index bc0e0d2d35..0480b92102 100644 --- a/net/vhost-vdpa.c +++ b/net/vhost-vdpa.c @@ -144,6 +144,10 @@

[PATCH v2 2/2] net: Add vhost-vdpa in show_netdevs()

2020-10-15 Thread Cindy Lu
Fix the bug that while Check qemu supported netdev, there is no vhost-vdpa Signed-off-by: Cindy Lu --- net/net.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/net.c b/net/net.c index 7a2a0fb5ac..794c652282 100644 --- a/net/net.c +++ b/net/net.c @@ -1049,6 +1049,9 @@ static void

Re: [PATCH v4 1/4] docs: Fixes build docs on msys2/mingw

2020-10-15 Thread Yonggang Luo
On Fri, Oct 16, 2020 at 6:19 AM Paolo Bonzini wrote: > > > > Il ven 16 ott 2020, 00:06 Yonggang Luo ha scritto: >> >> meson didn't support running ../scripts/kernel-do directly > > > Can you explain why this matters? Meson does not look at docs/conf.py. > > Paolo > >> >> Signed-off-by: Yonggang

Re: [PATCH 00/10] COLO project queued patches 20-Oct

2020-10-15 Thread Jason Wang
On 2020/10/15 下午3:58, Zhang, Chen wrote: -Original Message- From: Jason Wang Sent: Thursday, October 15, 2020 3:56 PM To: Zhang, Chen ; qemu-dev Cc: Zhang Chen Subject: Re: [PATCH 00/10] COLO project queued patches 20-Oct On 2020/10/14 下午3:25, Zhang Chen wrote: From: Zhang Chen

Re: [PATCH v2] virtio-net: Set mac address to hardware if the peer is vdpa

2020-10-15 Thread Jason Wang
On 2020/9/25 下午11:13, Cindy Lu wrote: If the peer's type is vdpa, we need to set the mac address to hardware in virtio_net_device_realize, Signed-off-by: Cindy Lu --- hw/net/virtio-net.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c

Re: [PATCH v2 2/2] hw/rtc/m48t59: Simplify m48t59_init() passing MemoryRegion argument

2020-10-15 Thread David Gibson
On Thu, Oct 15, 2020 at 09:46:47PM +0200, Philippe Mathieu-Daudé wrote: > Pass a MemoryRegion* to m48t59_init(), directly call > memory_region_add_subregion() instead of sysbus_mmio_map(). > > Signed-off-by: Philippe Mathieu-Daudé ppc parts Acked-by: David Gibson > --- >

Re: [RFC PATCH v2 0/8] block-backend: Introduce I/O hang

2020-10-15 Thread Ying Fang
On 10/10/2020 10:27 AM, cenjiahui wrote: Hi Kevin, Could you please spend some time reviewing and commenting on this patch series. Thanks, Jiahui Cen This feature is confirmed effective in a cloud storage environment since it can help to improve the availability without pausing the entire

Re: [PATCH] spapr: Move spapr_create_nvdimm_dr_connectors() to core machine code

2020-10-15 Thread David Gibson
On Tue, Oct 13, 2020 at 09:33:44AM +0200, Greg Kurz wrote: > On Tue, 13 Oct 2020 11:40:14 +1100 > David Gibson wrote: > > > On Mon, Oct 12, 2020 at 12:15:21PM +0200, Greg Kurz wrote: > > > The spapr_create_nvdimm_dr_connectors() function doesn't need to access > > > any internal details of the

Re: [PATCH] hw/net: move allocation to the heap due to very large stack frame

2020-10-15 Thread David Gibson
On Wed, Oct 14, 2020 at 07:15:47AM -0700, Elena Afanasova wrote: > On Tue, 2020-10-13 at 16:32 +1100, David Gibson wrote: > > On Mon, Oct 12, 2020 at 03:45:02PM +0200, Paolo Bonzini wrote: > > > On 12/10/20 12:44, Thomas Huth wrote: > > > > I think this is one of the tasks from: > > > > > > > >

Re: [PATCH v2 3/3] uninorth: use qdev gpios for PCI IRQs

2020-10-15 Thread David Gibson
On Tue, Oct 13, 2020 at 05:58:52PM +0100, Mark Cave-Ayland wrote: > On 13/10/2020 14:38, BALATON Zoltan via wrote: > > > On Tue, 13 Oct 2020, Mark Cave-Ayland wrote: > > > Currently an object link property is used to pass a reference to the > > > OpenPIC > > > into the PCI host bridge so that

Re: [PATCH v2 1/3] macio: don't reference serial_hd() directly within the device

2020-10-15 Thread David Gibson
On Tue, Oct 13, 2020 at 12:49:20PM +0100, Mark Cave-Ayland wrote: > Instead use qdev_prop_set_chr() to configure the ESCC serial chardevs at the > Mac Old World and New World machine level. > > Also remove the now obsolete comment referring to the use of serial_hd() and > the setting of

Re: [PATCH v2 2/3] grackle: use qdev gpios for PCI IRQs

2020-10-15 Thread David Gibson
On Tue, Oct 13, 2020 at 12:49:21PM +0100, Mark Cave-Ayland wrote: > Currently an object link property is used to pass a reference to the Heathrow > PIC into the PCI host bridge so that grackle_init_irqs() can connect the PCI > IRQs to the PIC itself. > > This can be simplified by defining the PCI

Re: [PATCH v2 3/3] uninorth: use qdev gpios for PCI IRQs

2020-10-15 Thread David Gibson
On Tue, Oct 13, 2020 at 12:49:22PM +0100, Mark Cave-Ayland wrote: > Currently an object link property is used to pass a reference to the OpenPIC > into the PCI host bridge so that pci_unin_init_irqs() can connect the PCI > IRQs to the PIC itself. > > This can be simplified by defining the PCI

Re: [PATCH] ppc/spapr: re-assert IRQs during event-scan if there are pending

2020-10-15 Thread David Gibson
On Thu, Oct 15, 2020 at 11:03:18PM +0200, Laurent Vivier wrote: > If we hotplug a CPU during the first second of the kernel boot, > the IRQ can be sent to the kernel while the RTAS event handler > is not installed. The event is queued, but the kernel doesn't > collect it and ignores the new CPU. >

Re: [PATCH v2 2/3] grackle: use qdev gpios for PCI IRQs

2020-10-15 Thread BALATON Zoltan via
On Thu, 15 Oct 2020, Mark Cave-Ayland wrote: I've queued the grackle/uninorth patches to my qemu-macppc branch, however when I try to apply patches from the above series git fails with the following message: Applying: mac_oldworld: Drop a variable, use get_system_memory() directly error: sha1

[PATCH v8 1/5] mac_oldworld: Allow loading binary ROM image

2020-10-15 Thread BALATON Zoltan via
The beige G3 Power Macintosh has a 4MB firmware ROM. Fix the size of the rom region and fall back to loading a binary image with -bios if loading ELF image failed. This allows testing emulation with a ROM image from real hardware as well as using an ELF OpenBIOS image. Signed-off-by: BALATON

[PATCH v8 2/5] mac_newworld: Allow loading binary ROM image

2020-10-15 Thread BALATON Zoltan via
Fall back to load binary ROM image if loading ELF fails. This also moves PROM_BASE and PROM_SIZE defines to board as these are matching the ROM size and address on this board and removes the now unused PROM_ADDR and BIOS_SIZE defines from common mac.h. Signed-off-by: BALATON Zoltan Reviewed-by:

[PATCH v8 0/5] Mac Old World ROM experiment (ppc/mac_* clean ups and loading binary ROM)

2020-10-15 Thread BALATON Zoltan via
This is the cut down version of the earlier series omitting unfinished patches that I plan to rework later and rebased to Mark's qemu-macppc branch. Compared to v7 the only change is the cast to (target_ulong) from (uint32_t) as requested by Mark in patch 1. Regards, BALATON Zoltan BALATON

[PATCH v8 4/5] mac_oldworld: Drop some variables

2020-10-15 Thread BALATON Zoltan via
Values not used frequently enough may not worth putting in a local variable, especially with names almost as long as the original value because that does not improve readability, to the contrary it makes it harder to see what value is used. Drop a few such variables. Signed-off-by: BALATON Zoltan

[PATCH v8 3/5] mac_oldworld: Drop a variable, use get_system_memory() directly

2020-10-15 Thread BALATON Zoltan via
Half of the occurances already use get_system_memory() directly instead of sysmem variable, convert the two other uses to get_system_memory() too which seems to be more common and drop the variable. Signed-off-by: BALATON Zoltan Reviewed-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé

[PATCH v8 5/5] mac_oldworld: Change PCI address of macio to match real hardware

2020-10-15 Thread BALATON Zoltan via
The board firmware expect these to be at fixed addresses and programs them without probing, this patch puts the macio device at the expected PCI address. Signed-off-by: BALATON Zoltan Reviewed-by: Mark Cave-Ayland --- hw/ppc/mac_oldworld.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH 0/7] build: replace ninjatool with ninja

2020-10-15 Thread Howard Spoelstra
On Thu, Oct 15, 2020 at 7:39 PM Volker Rümelin wrote: > > > > > Thanks Paolo, > > > > Then only the issue regarding the pcbios/optionrom stuff remains ;-) > > > > make[1]: *** No rule to make target 'multiboot.bin', needed by 'all'. > Stop. > > make: *** [Makefile:171: pc-bios/optionrom/all]

[RFC PATCH v2 4/4] target/mips: Allow using the 34Kf with 16/32/64 preset TLB entries

2020-10-15 Thread Philippe Mathieu-Daudé
Per "MIPS32 34K Processor Core Family Software User's Manual, Revision 01.13" page 8 in "Joint TLB (JTLB)" section: "The JTLB is a fully associative TLB cache containing 16, 32, or 64-dual-entries mapping up to 128 virtual pages to their corresponding physical addresses." Add these

[RFC PATCH v2 1/4] target/mips: Make cpu_mips_realize_env() propagate Error

2020-10-15 Thread Philippe Mathieu-Daudé
To be able to propagate error to our caller, make cpu_mips_realize_env() take an Error argument and return a boolean value indicating an error is set or not, following the example documented since commit e3fe3988d7 ("error: Document Error API usage rules"). Signed-off-by: Philippe Mathieu-Daudé

[RFC PATCH v2 2/4] target/mips: Store number of TLB entries in CPUMIPSState

2020-10-15 Thread Philippe Mathieu-Daudé
As we want to make the number of TLB entries configurable, store it in CPUMIPSState. Introduce the init_tlb_entries() helper which initializes it from the CP0C1_MMU config content. Signed-off-by: Philippe Mathieu-Daudé --- target/mips/cpu.h| 1 + target/mips/translate.c

[RFC PATCH v2 3/4] target/mips: Make the number of TLB entries a CPU property

2020-10-15 Thread Philippe Mathieu-Daudé
Allow selecting the number of TLB entries from a preset array. Signed-off-by: Philippe Mathieu-Daudé --- target/mips/internal.h | 1 + target/mips/cpu.c | 8 +++- target/mips/translate.c | 26 -- 3 files changed, 32 insertions(+), 3 deletions(-) diff --git

[RFC PATCH v2 0/4] target/mips: Make the number of TLB entries a CPU property

2020-10-15 Thread Philippe Mathieu-Daudé
Yocto developers have expressed interest in running MIPS32 CPU with preset number of TLB: https://lists.gnu.org/archive/html/qemu-devel/2020-10/msg03428.html Help them by allowing to set the TLB entries from a preset array of valid hardware values. Please test/review, Phil. Philippe

Re: [PATCH] ppc/spapr: re-assert IRQs during event-scan if there are pending

2020-10-15 Thread Greg Kurz
On Thu, 15 Oct 2020 23:03:18 +0200 Laurent Vivier wrote: > If we hotplug a CPU during the first second of the kernel boot, > the IRQ can be sent to the kernel while the RTAS event handler > is not installed. The event is queued, but the kernel doesn't > collect it and ignores the new CPU. > >

Re: [PATCH v4 1/4] docs: Fixes build docs on msys2/mingw

2020-10-15 Thread Paolo Bonzini
Il ven 16 ott 2020, 00:06 Yonggang Luo ha scritto: > meson didn't support running ../scripts/kernel-do directly > Can you explain why this matters? Meson does not look at docs/conf.py. Paolo > Signed-off-by: Yonggang Luo > --- > docs/conf.py | 2 +- > docs/sphinx/kerneldoc.py |

[PATCH v4 3/4] meson: Move the detection logic for sphinx to meson

2020-10-15 Thread Yonggang Luo
Signed-off-by: Yonggang Luo --- configure | 59 +++--- docs/meson.build | 4 +-- meson.build | 60 +++ meson_options.txt | 5 ++- tests/qapi-schema/meson.build | 2 +- 5

[PATCH v4 4/4] cirrus: Enable doc build on msys2/mingw

2020-10-15 Thread Yonggang Luo
Currently rST depends on old version sphinx-2.x. Install it by downloading it. Remove the need of university mirror, the main repo are recovered. Signed-off-by: Yonggang Luo --- .cirrus.yml | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.cirrus.yml b/.cirrus.yml index

[PATCH v4 1/4] docs: Fixes build docs on msys2/mingw

2020-10-15 Thread Yonggang Luo
meson didn't support running ../scripts/kernel-do directly Signed-off-by: Yonggang Luo --- docs/conf.py | 2 +- docs/sphinx/kerneldoc.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/conf.py b/docs/conf.py index 00e1b750e2..e584f68393 100644 ---

[PATCH v4 0/4] Fixes docs building on msys2/mingw

2020-10-15 Thread Yonggang Luo
V3-V4 Quic fixes of python style if xxx: tested locally V2-V3 No need convert perl trick to python script anymore after Paolo's removal of ninjatool. Revise Meson: Move the detection logic for sphinx to meson for pass other platform by letting SPHINX_ARGS to be empty when build_docs are false

[PATCH v4 2/4] configure: the docdir option should passed to meson as is.

2020-10-15 Thread Yonggang Luo
Signed-off-by: Yonggang Luo --- configure | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/configure b/configure index f839c2a557..1ce31f97b4 100755 --- a/configure +++ b/configure @@ -971,7 +971,7 @@ for opt do ;; --with-suffix=*) qemu_suffix="$optarg" ;; -

Re: [PATCH v2 0/4] Fixes docs building on msys2/mingw

2020-10-15 Thread Yonggang Luo
On Fri, Oct 16, 2020 at 5:53 AM Paolo Bonzini wrote: > > Looks good, apart from the CR removal patch that can simply be dropped. Resend with fixes, the CR removal patch composite two part. > > Paolo > > Il gio 15 ott 2020, 22:10 Yonggang Luo ha scritto: >> >> v1 - v2 >> Also move the docs

[PATCH v3 3/4] meson: Move the detection logic for sphinx to meson

2020-10-15 Thread Yonggang Luo
Signed-off-by: Yonggang Luo --- configure | 59 +++ docs/meson.build | 4 +-- meson.build | 59 ++- meson_options.txt | 5 ++- tests/qapi-schema/meson.build | 2 +- 5

[PATCH v3 4/4] cirrus: Enable doc build on msys2/mingw

2020-10-15 Thread Yonggang Luo
Currently rST depends on old version sphinx-2.x. Install it by downloading it. Remove the need of university mirror, the main repo are recovered. Signed-off-by: Yonggang Luo --- .cirrus.yml | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.cirrus.yml b/.cirrus.yml index

[PATCH v3 0/4] Fixes docs building on msys2/mingw

2020-10-15 Thread Yonggang Luo
V2-V3 No need convert perl trick to python script anymore after Paolo's removal of ninjatool. Revise Meson: Move the detection logic for sphinx to meson for pass other platform by letting SPHINX_ARGS to be empty when build_docs are false v1 - v2 Also move the docs configure part from configure to

[PATCH v3 2/4] configure: the docdir option should passed to meson as is.

2020-10-15 Thread Yonggang Luo
Signed-off-by: Yonggang Luo --- configure | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/configure b/configure index f839c2a557..1ce31f97b4 100755 --- a/configure +++ b/configure @@ -971,7 +971,7 @@ for opt do ;; --with-suffix=*) qemu_suffix="$optarg" ;; -

[PATCH v3 1/4] docs: Fixes build docs on msys2/mingw

2020-10-15 Thread Yonggang Luo
meson didn't support running ../scripts/kernel-do directly Signed-off-by: Yonggang Luo --- docs/conf.py | 2 +- docs/sphinx/kerneldoc.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/conf.py b/docs/conf.py index 00e1b750e2..e584f68393 100644 ---

Re: [PATCH v2 0/4] Fixes docs building on msys2/mingw

2020-10-15 Thread Paolo Bonzini
Looks good, apart from the CR removal patch that can simply be dropped. Paolo Il gio 15 ott 2020, 22:10 Yonggang Luo ha scritto: > v1 - v2 > Also move the docs configure part from > configure to meson, this also fixed the pending > ninjatool removal caused issue that docs can > not be build

Re: [PATCH 0/7] build: replace ninjatool with ninja

2020-10-15 Thread Paolo Bonzini
Il gio 15 ott 2020, 20:49 Mark Cave-Ayland ha scritto: > Is there any reason why > https://lists.gnu.org/archive/html/qemu-devel/2020-09/msg06997.html still > can't be > merged? > Because it's not the right approach. There is no reason why building firmware cannot be done with cross compilers,

Re: [PATCH v2 2/4] configure: the docdir option should passed to meson as is.

2020-10-15 Thread Yonggang Luo
Grep qemu_docdir and docdir in configure, you will know why, qemu_docdir not used at all in configure, On Fri, Oct 16, 2020 at 5:24 AM Paolo Bonzini wrote: > > Why? > > Paolo > > Il gio 15 ott 2020, 22:11 Yonggang Luo ha scritto: >> >> Signed-off-by: Yonggang Luo >> --- >> configure | 3

Re: [PATCH v2 1/4] docs: Fixes build docs on msys2/mingw

2020-10-15 Thread Yonggang Luo
It's tests, running by make On Fri, Oct 16, 2020 at 5:23 AM Paolo Bonzini wrote: > > > > Il gio 15 ott 2020, 22:30 Peter Maydell ha scritto: >> >> On Thu, 15 Oct 2020 at 21:13, Yonggang Luo wrote: >> > >> > Signed-off-by: Yonggang Luo >> > --- >> > docs/conf.py | 2 +- >> >

Re: [PATCH v2 2/4] configure: the docdir option should passed to meson as is.

2020-10-15 Thread Paolo Bonzini
Why? Paolo Il gio 15 ott 2020, 22:11 Yonggang Luo ha scritto: > Signed-off-by: Yonggang Luo > --- > configure | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/configure b/configure > index f839c2a557..1ce31f97b4 100755 > --- a/configure > +++ b/configure > @@ -971,7

[PATCH v2 1/5] spapr: Fix leak of CPU machine specific data

2020-10-15 Thread Greg Kurz
When a CPU core is being removed, the machine specific data of each CPU thread object is leaked. Fix this by calling the dedicated helper we have for that instead of simply unparenting the CPU object. Call it from a separate loop in spapr_cpu_core_unrealize() for symmetry with

Re: [PATCH v2 1/4] docs: Fixes build docs on msys2/mingw

2020-10-15 Thread Paolo Bonzini
Il gio 15 ott 2020, 22:30 Peter Maydell ha scritto: > On Thu, 15 Oct 2020 at 21:13, Yonggang Luo wrote: > > > > Signed-off-by: Yonggang Luo > > --- > > docs/conf.py | 2 +- > > docs/sphinx/kerneldoc.py | 2 +- > > scripts/rst-sanitize.py | 21

[PATCH v2 0/5] spapr: Fix and cleanups for sPAPR CPU core

2020-10-15 Thread Greg Kurz
While reading the code _again_ I spotted a memory leak and I realized that the realize/unrealize paths are uselessly complex and not really symmetrical. This series fixes the leak and re-shuffles the code to make it cleaner. Tested with 'make check', travis-ci and manual hotplug/unplug of CPU

[PATCH v2 5/5] spapr: Simplify spapr_cpu_core_realize() and spapr_cpu_core_unrealize()

2020-10-15 Thread Greg Kurz
Now that the error path of spapr_cpu_core_realize() is just to call idempotent spapr_cpu_core_unrealize() for rollback, no need to create and realize the vCPUs in two separate loops. Merge them and do them same in spapr_cpu_core_unrealize() for symmetry. Signed-off-by: Greg Kurz ---

Re: [PULL 0/3] microblaze patch queue

2020-10-15 Thread Peter Maydell
On Thu, 15 Oct 2020 at 05:52, Richard Henderson wrote: > > The following changes since commit 57c98ea9acdcef5021f5671efa6475a5794a51c4: > > Merge remote-tracking branch 'remotes/kraxel/tags/ui-20201014-pull-request' > into staging (2020-10-14 13:56:06 +0100) > > are available in the Git

[PATCH v2 2/5] spapr: Unrealize vCPUs with qdev_unrealize()

2020-10-15 Thread Greg Kurz
Since we introduced CPU hot-unplug in sPAPR, we don't unrealize the vCPU objects explicitly. Instead, we let QOM handle that for us under object_property_del_all() when the CPU core object is finalized. The only thing we do is calling cpu_remove_sync() to tear the vCPU thread down. This happens

[PATCH v2 3/5] spapr: Drop spapr_delete_vcpu() unused argument

2020-10-15 Thread Greg Kurz
The 'sc' argument is unused. Drop it. Signed-off-by: Greg Kurz --- hw/ppc/spapr_cpu_core.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/ppc/spapr_cpu_core.c b/hw/ppc/spapr_cpu_core.c index e4aeb93c0299..45eb2121876e 100644 --- a/hw/ppc/spapr_cpu_core.c +++

[PATCH v2 4/5] spapr: Make spapr_cpu_core_unrealize() idempotent

2020-10-15 Thread Greg Kurz
spapr_cpu_core_realize() has a rollback path which partially duplicates the code of spapr_cpu_core_unrealize(). Let's make spapr_cpu_core_unrealize() idempotent and call it instead. This requires to: - move the registration and unregistration of the reset handler around but it is harmless, -

Re: ide: Linux reports drive diagnostic failures on boot

2020-10-15 Thread John Snow
On 10/15/20 4:17 PM, Mark Cave-Ayland wrote: On 13/10/2020 19:39, John Snow wrote: On 10/13/20 6:59 AM, Mark Cave-Ayland wrote: During my latest OpenBIOS boot tests I've noticed the following IDE diagnostics failure message appearing in dmesg at Linux boot time when booting from CDROM on

[PULL 3/5] tests/9pfs: wipe local 9pfs test directory

2020-10-15 Thread Christian Schoenebeck
Before running the first 9pfs test case, make sure the test directory for running the 9pfs 'local' tests on is entirely empty. For that reason simply delete the test directory (if any) before (re)creating it on test suite startup. Note: The preferable precise behaviour would be the test directory

[PULL 2/5] tests/9pfs: introduce local tests

2020-10-15 Thread Christian Schoenebeck
This patch introduces 9pfs test cases using the 9pfs 'local' filesystem driver which reads/writes/creates/deletes real files and directories. In this initial version, there is only one local test which actually only checks if the 9pfs 'local' device was created successfully. Before the 9pfs

[PULL 5/5] tests/9pfs: add local Tmkdir test

2020-10-15 Thread Christian Schoenebeck
This test case uses the 9pfs 'local' driver to create a directory and then checks if the expected directory was actually created (as real directory) on host side. This patch introduces a custom split() implementation, because the test code requires non empty array elements as result. For that

[PULL 1/5] tests/9pfs: change qtest name prefix to synth

2020-10-15 Thread Christian Schoenebeck
All existing 9pfs test cases are using the 'synth' fs driver so far, which means they are not accessing real files, but a purely simulated (in RAM only) file system. Let's make this clear by changing the prefix of the individual qtest case names from 'fs/' to 'synth/'. That way they'll be easily

[PULL 0/5] 9p queue 2020-10-15

2020-10-15 Thread Christian Schoenebeck
-20201015 for you to fetch changes up to 97a64ec211d051439b654950ed3f7cffc47d489b: tests/9pfs: add local Tmkdir test (2020-10-15 16:11:17 +0200) 9pfs: add tests using local fs driver The currently existing 9pfs test cases are all

[PULL 4/5] tests/9pfs: add virtio_9p_test_path()

2020-10-15 Thread Christian Schoenebeck
This new public function virtio_9p_test_path() allows 9pfs 'local' tests to translate a path from guest scope to host scope. For instance by passing an empty string it would return the root path on host of the exported 9pfs tree. Signed-off-by: Christian Schoenebeck Message-Id: Signed-off-by:

[PATCH] ppc/spapr: re-assert IRQs during event-scan if there are pending

2020-10-15 Thread Laurent Vivier
If we hotplug a CPU during the first second of the kernel boot, the IRQ can be sent to the kernel while the RTAS event handler is not installed. The event is queued, but the kernel doesn't collect it and ignores the new CPU. As the code relies on edge-triggered IRQ, we can re-assert it during the

Re: [PATCH 0/3] hw/misc/mac_via: Factor generic via_irq_request() out

2020-10-15 Thread Mark Cave-Ayland
On 13/10/2020 21:49, Philippe Mathieu-Daudé wrote: The same logic is used in 4 different places: - via1_irq_request() - via2_irq_request() - via1_VBL() - via1_one_second() Extract the common function and reuse it. Philippe Mathieu-Daudé (3): hw/misc/mac_via: Make generic via_irq_request()

Re: [PATCH v2 1/4] docs: Fixes build docs on msys2/mingw

2020-10-15 Thread Yonggang Luo
On Fri, Oct 16, 2020 at 4:30 AM Peter Maydell wrote: > > On Thu, 15 Oct 2020 at 21:13, Yonggang Luo wrote: > > > > Signed-off-by: Yonggang Luo > > --- > > docs/conf.py | 2 +- > > docs/sphinx/kerneldoc.py | 2 +- > > scripts/rst-sanitize.py | 21

Re: [PATCH V1 18/32] osdep: import MADV_DOEXEC

2020-10-15 Thread Alex Williamson
On Thu, 8 Oct 2020 12:32:35 -0400 Steven Sistare wrote: > On 8/24/2020 6:30 PM, Alex Williamson wrote: > > On Wed, 19 Aug 2020 17:52:26 -0400 > > Steven Sistare wrote: > >> On 8/17/2020 10:42 PM, Alex Williamson wrote: > >>> On Mon, 17 Aug 2020 15:44:03 -0600 > >>> Alex Williamson wrote:

Re: [PATCH v2 1/4] docs: Fixes build docs on msys2/mingw

2020-10-15 Thread Peter Maydell
On Thu, 15 Oct 2020 at 21:13, Yonggang Luo wrote: > > Signed-off-by: Yonggang Luo > --- > docs/conf.py | 2 +- > docs/sphinx/kerneldoc.py | 2 +- > scripts/rst-sanitize.py | 21 + > tests/qapi-schema/meson.build | 5 +++-- > 4 files changed, 26

[PATCH] meson: Only install icons and qemu.desktop if have_system

2020-10-15 Thread Bruce Rogers
These files are not needed for a linux-user only install. Signed-off-by: Bruce Rogers --- ui/meson.build | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/ui/meson.build b/ui/meson.build index 78ad792ffb..fb36d305ca 100644 --- a/ui/meson.build +++ b/ui/meson.build @@

Re: ide: Linux reports drive diagnostic failures on boot

2020-10-15 Thread Mark Cave-Ayland
On 13/10/2020 19:39, John Snow wrote: On 10/13/20 6:59 AM, Mark Cave-Ayland wrote: During my latest OpenBIOS boot tests I've noticed the following IDE diagnostics failure message appearing in dmesg at Linux boot time when booting from CDROM on both SPARC64 and PPC: Sorry for the

[PATCH v3 1/2] block: Fixes nfs compiling error on msys2/mingw

2020-10-15 Thread Yonggang Luo
These compiling errors are fixed: ../block/nfs.c:27:10: fatal error: poll.h: No such file or directory 27 | #include | ^~~~ compilation terminated. ../block/nfs.c:63:5: error: unknown type name 'blkcnt_t' 63 | blkcnt_t st_blocks; | ^~~~ ../block/nfs.c:

[PATCH v3 0/2] Fixes building nfs on msys2/mingw

2020-10-15 Thread Yonggang Luo
Revise the commit message of * block: enable libnfs on msys2/mingw in cirrus.yml V1-V2 Apply suggestion from Peter Lieven Yonggang Luo (2): block: Fixes nfs compiling error on msys2/mingw block: enable libnfs on msys2/mingw in cirrus.yml .cirrus.yml | 1 + block/nfs.c | 15

[PATCH v3 2/2] block: enable libnfs on msys2/mingw in cirrus.yml

2020-10-15 Thread Yonggang Luo
Initially, libnfs has not been enabled, and now it's fixed, so enable it on cirrus. Signed-off-by: Yonggang Luo --- .cirrus.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.cirrus.yml b/.cirrus.yml index f42ccb956a..2c6bf45e6d 100644 --- a/.cirrus.yml +++ b/.cirrus.yml @@ -109,6 +109,7

[PATCH v2 3/4] meson: Move the detection logic for sphinx to meson

2020-10-15 Thread Yonggang Luo
Signed-off-by: Yonggang Luo --- configure | 59 +++ docs/meson.build | 4 +-- meson.build | 59 ++- meson_options.txt | 5 ++- tests/qapi-schema/meson.build | 2 +- 5

[PATCH v2 0/4] Fixes docs building on msys2/mingw

2020-10-15 Thread Yonggang Luo
v1 - v2 Also move the docs configure part from configure to meson, this also fixed the pending ninjatool removal caused issue that docs can not be build under msys2/mingw Yonggang Luo (4): docs: Fixes build docs on msys2/mingw configure: the docdir option should passed to meson as is.

[PATCH v2 2/4] configure: the docdir option should passed to meson as is.

2020-10-15 Thread Yonggang Luo
Signed-off-by: Yonggang Luo --- configure | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/configure b/configure index f839c2a557..1ce31f97b4 100755 --- a/configure +++ b/configure @@ -971,7 +971,7 @@ for opt do ;; --with-suffix=*) qemu_suffix="$optarg" ;; -

[PATCH v2 4/4] cirrus: Enable doc build on msys2/mingw

2020-10-15 Thread Yonggang Luo
Currently rST depends on old version sphinx-2.x. Install it by downloading it. Remove the need of university mirror, the main repo are recovered. Signed-off-by: Yonggang Luo --- .cirrus.yml | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.cirrus.yml b/.cirrus.yml index

[PATCH v2 1/4] docs: Fixes build docs on msys2/mingw

2020-10-15 Thread Yonggang Luo
Signed-off-by: Yonggang Luo --- docs/conf.py | 2 +- docs/sphinx/kerneldoc.py | 2 +- scripts/rst-sanitize.py | 21 + tests/qapi-schema/meson.build | 5 +++-- 4 files changed, 26 insertions(+), 4 deletions(-) create mode 100644

Re: [PATCH v5] hw/avr: Add limited support for avr gpio registers

2020-10-15 Thread Michael Rolnik
Reviewed-by: Michael Rolnik On Sat, Oct 10, 2020 at 5:34 PM Heecheol Yang wrote: > Add some of these features for AVR GPIO: > > - GPIO I/O : PORTx registers > - Data Direction : DDRx registers > - DDRx toggling : PINx registers > > Following things are not supported yet: > - MCUR

Re: [PATCH 1/2] pci: Change error_report to assert(3)

2020-10-15 Thread Philippe Mathieu-Daudé
On 10/15/20 9:55 PM, Philippe Mathieu-Daudé wrote: On 10/15/20 8:14 PM, Ben Widawsky wrote: Asserts are used for developer bugs. As registering a bar of the wrong size is not something that should be possible for a user to achieve, this is a developer bug. While here, use the more obvious

Re: [RFC PATCH] contrib/gitdm: Add more individual contributors

2020-10-15 Thread Michael Rolnik
Acked-by: Michael Rolnik > On Mon, Oct 12, 2020 at 8:56 AM sundeep subbaraya wrote: > Acked-by: Subbaraya Sundeep > > Thanks, > Sundeep > > On Sun, Oct 4, 2020 at 11:55 PM Philippe Mathieu-Daudé > wrote: > > > > These individual contributors have a number of contributions, > > add them to the

Re: [PATCH 1/2] pci: Change error_report to assert(3)

2020-10-15 Thread Philippe Mathieu-Daudé
On 10/15/20 8:14 PM, Ben Widawsky wrote: Asserts are used for developer bugs. As registering a bar of the wrong size is not something that should be possible for a user to achieve, this is a developer bug. While here, use the more obvious helper function. Signed-off-by: Ben Widawsky ---

Re: [PATCH] configure: fix handling of --docdir parameter

2020-10-15 Thread Philippe Mathieu-Daudé
On 10/15/20 9:07 PM, Bruce Rogers wrote: Commit ca8c0909f01 changed qemu_docdir to be docdir, then later uses the qemu_docdir name in the final assignment. Unfortunately, one instance of qemu_docdir was missed: the one which comes from the --docdir parameter. This patch restores the proper

[PATCH v2 2/2] hw/rtc/m48t59: Simplify m48t59_init() passing MemoryRegion argument

2020-10-15 Thread Philippe Mathieu-Daudé
Pass a MemoryRegion* to m48t59_init(), directly call memory_region_add_subregion() instead of sysbus_mmio_map(). Signed-off-by: Philippe Mathieu-Daudé --- include/hw/rtc/m48t59.h | 2 +- hw/ppc/ppc405_boards.c | 2 +- hw/rtc/m48t59.c | 10 +++--- hw/sparc/sun4m.c| 3 ++-

[PATCH v2 1/2] hw/rtc/m48t59: Simplify m48t59_init() removing 'io_base' argument

2020-10-15 Thread Philippe Mathieu-Daudé
As the 'io_base' argument of m48t59_init() is unused (set to 0), remove it to simplify. To create a device on the ISA bus, m48t59_init_isa() is the preferred function to use. Acked-by: David Gibson Reviewed-by: Mark Cave-Ayland Signed-off-by: Philippe Mathieu-Daudé --- include/hw/rtc/m48t59.h

[PATCH v2 0/2] hw/rtc/m48t59: Simplify m48t59_init()

2020-10-15 Thread Philippe Mathieu-Daudé
Since v1: - Do not remove mem_base in patch 1 (Laurent) - Pass MemoryRegion* (new patch) - Run check-qtest Philippe Mathieu-Daudé (2): hw/rtc/m48t59: Simplify m48t59_init() removing 'io_base' argument hw/rtc/m48t59: Simplify m48t59_init() passing MemoryRegion argument

Re: [PATCH v2 2/3] grackle: use qdev gpios for PCI IRQs

2020-10-15 Thread Mark Cave-Ayland
On 13/10/2020 18:05, BALATON Zoltan via wrote: Hello, Not related to this patch but while you're at it could you please take those patches that are already reviewed by you from this series as well? http://patchwork.ozlabs.org/project/qemu-devel/list/?series=186439 That would help cleaning

  1   2   3   4   >