On Sat, Oct 17, 2020 at 7:37 AM Willy Tarreau wrote:
> On Sat, Oct 17, 2020 at 07:01:31AM +0200, Jann Horn wrote:
> > Microsoft's documentation
> > (http://go.microsoft.com/fwlink/?LinkId=260709) says that the VM
> > Generation ID that we get after a fork "is a 128-bit,
> > cryptographically
This has been fixed in mainline, probably commit
8ef618859c379fdce81c91bc93e0574e36ea76ff.
** Changed in: qemu
Status: New => Fix Committed
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
On Sat, Oct 17, 2020 at 6:34 AM Colm MacCarthaigh wrote:
> On 16 Oct 2020, at 21:02, Jann Horn wrote:
> > On Sat, Oct 17, 2020 at 5:36 AM Willy Tarreau wrote:
> > But in userspace, we just need a simple counter. There's no need for
> > us to worry about anything else, like timestamps or
Multifd RDMA is need to poll when we send data, record it.
Signed-off-by: Chuan Zheng
---
migration/migration.c | 1 +
migration/migration.h | 1 +
migration/rdma.c | 14 ++
3 files changed, 16 insertions(+)
diff --git a/migration/migration.c b/migration/migration.c
index
Signed-off-by: Chuan Zheng
---
migration/multifd.c | 6 ++
migration/multifd.h | 1 +
migration/rdma.c| 16 +++-
3 files changed, 22 insertions(+), 1 deletion(-)
diff --git a/migration/multifd.c b/migration/multifd.c
index c4d90ef..f548122 100644
--- a/migration/multifd.c
Create multifd_setup_ops for TxRx thread, no logic change.
Signed-off-by: Chuan Zheng
---
migration/multifd.c | 44 +++-
migration/multifd.h | 7 +++
2 files changed, 46 insertions(+), 5 deletions(-)
diff --git a/migration/multifd.c
Signed-off-by: Zhimin Feng
Signed-off-by: Chuan Zheng
---
migration/multifd.c | 8
1 file changed, 8 insertions(+)
diff --git a/migration/multifd.c b/migration/multifd.c
index 0d494df..8ccfd46 100644
--- a/migration/multifd.c
+++ b/migration/multifd.c
@@ -580,6 +580,10 @@ void
Signed-off-by: Chuan Zheng
---
migration/migration.c | 1 +
migration/migration.h | 3 +++
migration/rdma.c | 3 +++
3 files changed, 7 insertions(+)
diff --git a/migration/migration.c b/migration/migration.c
index be6166a..7061410 100644
--- a/migration/migration.c
+++
Signed-off-by: Chuan Zheng
---
migration/multifd.c | 4 ++--
migration/multifd.h | 2 ++
migration/rdma.c| 56 +
3 files changed, 60 insertions(+), 2 deletions(-)
diff --git a/migration/multifd.c b/migration/multifd.c
index
Add the 'qemu_rdma_registration' function, multifd send threads
call it to register memory.
Signed-off-by: Zhimin Feng
Signed-off-by: Chuan Zheng
---
migration/rdma.c | 51 +++
1 file changed, 51 insertions(+)
diff --git a/migration/rdma.c
Add enabled_rdma_migration into MigrationState to judge
whether or not the RDMA is used for migration.
Signed-off-by: Zhimin Feng
Signed-off-by: Chuan Zheng
---
migration/migration.c | 13 +
migration/migration.h | 6 ++
2 files changed, 19 insertions(+)
diff --git
We still don't transmit anything through them, and we only build
the RDMA connections.
Signed-off-by: Zhimin Feng
Signed-off-by: Chuan Zheng
---
migration/rdma.c | 70 ++--
1 file changed, 68 insertions(+), 2 deletions(-)
diff --git
Signed-off-by: Chuan Zheng
---
migration/rdma.c | 52
1 file changed, 52 insertions(+)
diff --git a/migration/rdma.c b/migration/rdma.c
index ad4e4ba..2baa933 100644
--- a/migration/rdma.c
+++ b/migration/rdma.c
@@ -4010,6 +4010,48 @@ static
Signed-off-by: Zhimin Feng
Signed-off-by: Chuan Zheng
---
migration/rdma.c | 67 +++-
1 file changed, 62 insertions(+), 5 deletions(-)
diff --git a/migration/rdma.c b/migration/rdma.c
index 327f80f..519fa7a 100644
--- a/migration/rdma.c
+++
Now I continue to support multifd for RDMA migration based on my colleague
zhiming's work:)
The previous RFC patches is listed below:
v1:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg669455.html
v2:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg679188.html
As descried in
All data is sent by multifd Channels, so we only register its for
multifd channels and main channel don't register its.
Signed-off-by: Zhimin Feng
Signed-off-by: Chuan Zheng
---
migration/rdma.c | 8
1 file changed, 8 insertions(+)
diff --git a/migration/rdma.c b/migration/rdma.c
Signed-off-by: Zhimin Feng
Signed-off-by: Chuan Zheng
---
migration/qemu-file.c | 5 +
migration/qemu-file.h | 1 +
2 files changed, 6 insertions(+)
diff --git a/migration/qemu-file.c b/migration/qemu-file.c
index be21518..37f6201 100644
--- a/migration/qemu-file.c
+++
Signed-off-by: Zhimin Feng
Signed-off-by: Chuan Zheng
---
migration/multifd.c | 3 ++
migration/rdma.c| 94 +++--
2 files changed, 95 insertions(+), 2 deletions(-)
diff --git a/migration/multifd.c b/migration/multifd.c
index 9439b3c..c4d90ef
Signed-off-by: Zhimin Feng
Signed-off-by: Chuan Zheng
---
migration/migration.c | 9 +
migration/migration.h | 1 +
2 files changed, 10 insertions(+)
diff --git a/migration/migration.c b/migration/migration.c
index 0575ecb..64ae417 100644
--- a/migration/migration.c
+++
MultiFDSendParams and MultiFDRecvParams is need for rdma, export it
Signed-off-by: Zhimin Feng
Signed-off-by: Chuan Zheng
---
migration/multifd.c | 26 ++
migration/multifd.h | 2 ++
2 files changed, 28 insertions(+)
diff --git a/migration/multifd.c
Signed-off-by: Chuan Zheng
---
migration/multifd.c | 6
migration/multifd.h | 4 +++
migration/rdma.c| 82 +
3 files changed, 92 insertions(+)
diff --git a/migration/multifd.c b/migration/multifd.c
index 1f82307..0d494df 100644
---
Note we do want to export any rdma struct, take void * instead.
Signed-off-by: Chuan Zheng
---
migration/multifd.h | 8
1 file changed, 8 insertions(+)
diff --git a/migration/multifd.h b/migration/multifd.h
index 2f4e585..ff80bd5 100644
--- a/migration/multifd.h
+++
On Sat, Oct 17, 2020 at 5:36 AM Willy Tarreau wrote:
> On Sat, Oct 17, 2020 at 03:40:08AM +0200, Jann Horn wrote:
> > [adding some more people who are interested in RNG stuff: Andy, Jason,
> > Theodore, Willy Tarreau, Eric Biggers. also linux-api@, because this
> > concerns some pretty
The resulting cc is only dependent on the result and the
borrow-out. So save those things rather than the inputs.
Borrow-out for 64-bit inputs is had via tcg_gen_sub2_i64 directly
into cc_src. Borrow-out for 32-bit inputs is had via extraction
from a normal 64-bit sub (with zero-extended
Now that ADD LOGICAL outputs carry, we can use that as input directly.
It also means we can re-use CC_OP_ZC and produce an output carry
directly from ADD LOGICAL WITH CARRY.
Signed-off-by: Richard Henderson
---
target/s390x/internal.h| 2 --
target/s390x/cc_helper.c | 26 ---
Now that SUB LOGICAL outputs carry, we can use that as input directly.
It also means we can re-use CC_OP_ZC and produce an output carry
directly from SUB LOGICAL WITH BORROW.
Signed-off-by: Richard Henderson
---
target/s390x/internal.h| 2 --
target/s390x/cc_helper.c | 32
While testing the float128_muladd changes for s390x host,
emulating under x86_64 of course, I noticed that the code
we generate for strings of ALCGR and SLBGR is pretty awful.
I realized that we were missing a trick: the output cc is
based only on the output (result and carry) and so we don't
The resulting cc is only dependent on the result and the
carry-out. So save those things rather than the inputs.
Carry-out for 64-bit inputs is had via tcg_gen_add2_i64 directly
into cc_src. Carry-out for 32-bit inputs is had via extraction
from a normal 64-bit add (with zero-extended inputs).
[adding some more people who are interested in RNG stuff: Andy, Jason,
Theodore, Willy Tarreau, Eric Biggers. also linux-api@, because this
concerns some pretty fundamental API stuff related to RNG usage]
On Fri, Oct 16, 2020 at 4:33 PM Catangiu, Adrian Costin
wrote:
> - Background
>
> The VM
Plz take a look at this issue please.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1891748
Title:
qemu-arm-static 5.1 can't run gcc
Status in QEMU:
New
Bug description:
Issue discovered
On 10/16/20 3:11 PM, Alexey Baturo wrote:
> Signed-off-by: Alexey Baturo
> ---
> target/riscv/cpu.c | 1 +
> target/riscv/cpu.h | 11 ++
> target/riscv/cpu_bits.h | 66 ++
> target/riscv/csr.c | 264
> 4 files changed, 342
On 10/16/20 3:11 PM, Alexey Baturo wrote:
> Signed-off-by: Alexey Baturo
> ---
> target/riscv/cpu.c | 4
> target/riscv/cpu.h | 2 ++
> 2 files changed, 6 insertions(+)
Reviewed-by: Richard Henderson
r~
Anyone? Seriously, the problem really exists and we even made a case
that reproduces it. Someone please take a look at this.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1891748
Title:
On 10/16/20 3:11 PM, Alexey Baturo wrote:
> Signed-off-by: Alexey Baturo
> ---
> target/riscv/insn_trans/trans_rva.c.inc | 3 +++
> target/riscv/insn_trans/trans_rvd.c.inc | 2 ++
> target/riscv/insn_trans/trans_rvf.c.inc | 2 ++
> target/riscv/insn_trans/trans_rvi.c.inc | 2 ++
>
On 10/16/20 3:11 PM, Alexey Baturo wrote:
> Signed-off-by: Alexey Baturo
> ---
> target/riscv/cpu.c | 19 +++
> 1 file changed, 19 insertions(+)
Reviewed-by: Richard Henderson
r~
On 10/16/20 3:11 PM, Alexey Baturo wrote:
> From: Anatoly Parshintsev
>
> Signed-off-by: Anatoly Parshintsev
> ---
> target/riscv/cpu.h | 19 +++
> target/riscv/translate.c | 34 --
> 2 files changed, 51 insertions(+), 2 deletions(-)
On Fri, Oct 16, 2020 at 2:35 PM Peer Adelt wrote:
>
> The solution was even easier: I forgot to load the proxy kernel. As soon as I
> replaced the command-line parameter "-kernel " with "-kernel
> -append ", everything was working as expected.
Even better, you can skip the proxy kernel.
You
Patchew URL:
https://patchew.org/QEMU/20201016221138.10371-1-space.monkey.deliv...@gmail.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20201016221138.10371-1-space.monkey.deliv...@gmail.com
Subject: [PATCH v3
Signed-off-by: Alexey Baturo
---
target/riscv/insn_trans/trans_rva.c.inc | 3 +++
target/riscv/insn_trans/trans_rvd.c.inc | 2 ++
target/riscv/insn_trans/trans_rvf.c.inc | 2 ++
target/riscv/insn_trans/trans_rvi.c.inc | 2 ++
target/riscv/translate.c| 14 ++
5
Signed-off-by: Alexey Baturo
---
target/riscv/cpu.c | 19 +++
1 file changed, 19 insertions(+)
diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c
index d63031eb08..6ba3e98508 100644
--- a/target/riscv/cpu.c
+++ b/target/riscv/cpu.c
@@ -255,6 +255,25 @@ static void
From: Anatoly Parshintsev
Signed-off-by: Anatoly Parshintsev
---
target/riscv/cpu.h | 19 +++
target/riscv/translate.c | 34 --
2 files changed, 51 insertions(+), 2 deletions(-)
diff --git a/target/riscv/cpu.h b/target/riscv/cpu.h
index
Signed-off-by: Alexey Baturo
---
target/riscv/cpu.c | 1 +
target/riscv/cpu.h | 11 ++
target/riscv/cpu_bits.h | 66 ++
target/riscv/csr.c | 264
4 files changed, 342 insertions(+)
diff --git a/target/riscv/cpu.c
Hi folks,
This is third iteration of patches to support Pointer Masking for RISC-V.
Most of suggestions have been addressed, however some of them not:
- applying mask for return value while reading PM CSR has been kept to mask
higher priv level bits
- check_pm_current_disabled is not placed into
Signed-off-by: Alexey Baturo
---
target/riscv/cpu.c | 4
target/riscv/cpu.h | 2 ++
2 files changed, 6 insertions(+)
diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c
index 0bbfd7f457..fe6bab4a52 100644
--- a/target/riscv/cpu.c
+++ b/target/riscv/cpu.c
@@ -438,6 +438,9 @@ static void
On Fri, 16 Oct 2020 at 22:07, Richard Henderson
wrote:
>
> On ARM, the Top Byte Ignore feature means that only 56 bits of
> the address are significant in the virtual address. We are
> required to give the entire 64-bit address to FAR_ELx on fault,
> which means that we do not "clean" the top
The solution was even easier: I forgot to load the proxy kernel. As soon as I
replaced the command-line parameter "-kernel " with "-kernel -append
", everything was working as expected.
Without your hint about my possibly misconfigured toolchain I would have
probably continued to search for
On ARM, the Top Byte Ignore feature means that only 56 bits of
the address are significant in the virtual address. We are
required to give the entire 64-bit address to FAR_ELx on fault,
which means that we do not "clean" the top byte early in TCG.
This new interface allows us to flush all 256
When TBI is enabled in a given regime, 56 bits of the address
are significant and we need to clear out any other matching
virtual addresses with differing tags.
The other uses of tlb_flush_page (without mmuidx) in this file
are only used by aarch32 mode.
Fixes: 38d931687fa1
Reported-by: Jordan
Since the FAR_ELx fix at 38d931687fa1, it is reported that
page granularity flushing is broken.
This makes sense, since TCG will record the entire virtual
address in its TLB, not simply the 56 significant bits.
With no other TCG support, the ARM backend should require
256 different page flushes
On Fri, Oct 2, 2020 at 9:11 AM Daniel P. Berrangé wrote:
>
> On Wed, Sep 30, 2020 at 09:28:54PM -0400, Dan Streetman wrote:
> > On Tue, Sep 22, 2020 at 12:34 PM Daniel P. Berrangé
> > wrote:
> > >
> > > On Wed, Jul 29, 2020 at 03:58:29PM -0400, Dan Streetman wrote:
> > > > The
Replace the --enable-git-update and --disable-git-update configure params
with the param --with-git-submodules=(update|validate|ignore) to
allow 3 options for building from a git repo.
This is needed because downstream packagers, e.g. Debian, Ubuntu, etc,
also keep the source code in git, but do
On Fri, 16 Oct 2020, Mark Cave-Ayland wrote:
Signed-off-by: Mark Cave-Ayland
---
hw/ppc/ppc405_boards.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/hw/ppc/ppc405_boards.c b/hw/ppc/ppc405_boards.c
index 6198ec1035..4687715b15 100644
--- a/hw/ppc/ppc405_boards.c
Le 16/10/2020 à 20:27, Mark Cave-Ayland a écrit :
This patchset is inspired by Philippe's "hw/rtc/m48t59: Simplify m48t59_init()"
patchset at https://lists.gnu.org/archive/html/qemu-devel/2020-10/msg04493.html
but goes further: rather than tidy-up the legacy init functions, convert the
callers
On 10/9/20 4:47 PM, Philippe Mathieu-Daudé wrote:
Hi Aleksandar,
On 10/7/20 10:37 PM, Aleksandar Markovic wrote:
This change causes slighlty better performance of emulation of fp
comparison instructions via better compiler optimization of refactored
code. The functionality is otherwise
On Fri, Oct 16, 2020 at 11:16 AM Laurent Vivier wrote:
>
> After a migration the clock offset is updated, but we also
> need to re-arm the alarm if needed.
>
> Signed-off-by: Laurent Vivier
Reviewed-by: Alistair Francis
Alistair
> ---
> hw/rtc/goldfish_rtc.c | 2 ++
> 1 file changed, 2
On Thu, 15 Oct 2020 at 15:50, Kevin Wolf wrote:
>
> The following changes since commit 57c98ea9acdcef5021f5671efa6475a5794a51c4:
>
> Merge remote-tracking branch 'remotes/kraxel/tags/ui-20201014-pull-request'
> into staging (2020-10-14 13:56:06 +0100)
>
> are available in the Git repository
Patchew URL:
https://patchew.org/QEMU/20201016184207.786698-1-richard.hender...@linaro.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20201016184207.786698-1-richard.hender...@linaro.org
Subject: [PATCH v11
The note test requires gcc 10 for -mbranch-protection=standard.
The mmap test uses PROT_BTI and does not require special compiler support.
Acked-by: Alex Bennée
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
v9: Expect and require gcc 10.
v11: Squash mmap smoke test.
---
Use the new generic support for NT_GNU_PROPERTY_TYPE_0.
Signed-off-by: Richard Henderson
---
v11: Split out aarch64 bits from generic patch.
---
linux-user/elfload.c | 48 ++--
1 file changed, 46 insertions(+), 2 deletions(-)
diff --git
This is slightly clearer than just using strerror, though
the different forms produced by error_setg_file_open and
error_setg_errno isn't entirely convenient.
Signed-off-by: Richard Henderson
---
linux-user/elfload.c | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff
This is generic support, with the code disabled for all targets.
Signed-off-by: Richard Henderson
---
v9: Only map the startup executable with BTI; anything else must be
handled by the interpreter.
v10: Split out preparatory patches (pmm).
v11: Mirror(-ish) the kernel's code structure (pmm).
Transform the prot bit to a qemu internal page bit, and save
it in the page tables.
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
v10: Add PAGE_BTI define (pmm).
---
include/exec/cpu-all.h | 2 ++
linux-user/syscall_defs.h | 4
target/arm/cpu.h | 5
This is a bit clearer than open-coding some of this
with a bare c string.
Signed-off-by: Richard Henderson
---
linux-user/elfload.c | 37 -
1 file changed, 20 insertions(+), 17 deletions(-)
diff --git a/linux-user/elfload.c b/linux-user/elfload.c
index
These are all of the defines required to parse
GNU_PROPERTY_AARCH64_FEATURE_1_AND, copied from binutils.
Other missing defines related to other GNU program headers
and notes are elided for now.
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
include/elf.h | 22
For BTI, we need to know if the executable is static or dynamic,
which means looking for PT_INTERP earlier.
Signed-off-by: Richard Henderson
---
linux-user/elfload.c | 60 +++-
1 file changed, 31 insertions(+), 29 deletions(-)
diff --git
Fixing this now will clarify following patches.
Signed-off-by: Richard Henderson
---
linux-user/elfload.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/linux-user/elfload.c b/linux-user/elfload.c
index 1a3150df7c..290ef70222 100644
--- a/linux-user/elfload.c
The second loop uses a loop induction variable, and the first
does not. Transform the first to match the second, to simplify
a following patch moving code between them.
Signed-off-by: Richard Henderson
---
linux-user/elfload.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
The kernel sets btype for the signal handler as if for a call.
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
linux-user/aarch64/signal.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/linux-user/aarch64/signal.c b/linux-user/aarch64/signal.c
From: Philippe Mathieu-Daudé
Fix an unlikely memory leak in load_elf_image().
Fixes: bf858897b7 ("linux-user: Re-use load_elf_image for the main binary.")
Signed-off-by: Philippe Mathieu-Daudé
Message-Id: <20201003174944.1972444-1-f4...@amsat.org>
Signed-off-by: Richard Henderson
---
The kernel abi for this was merged in v5.8, just as the qemu 5.1
merge window was closing, so this slipped to the next dev cycle.
Changes from v10:
* Include Phil's plug of interp_name memory leak.
* Convert error reporting to Error api.
* Mirror the kernel's code structure for parsing
Now that all of the callers of this function have been switched to use qdev
properties, this legacy init function can now be removed.
Signed-off-by: Mark Cave-Ayland
---
hw/rtc/m48t59.c | 35 ---
include/hw/rtc/m48t59.h | 4
2 files changed, 39
Signed-off-by: Mark Cave-Ayland
---
hw/ppc/ppc405_boards.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/hw/ppc/ppc405_boards.c b/hw/ppc/ppc405_boards.c
index 6198ec1035..4687715b15 100644
--- a/hw/ppc/ppc405_boards.c
+++ b/hw/ppc/ppc405_boards.c
@@ -28,6 +28,8 @@
This function is no longer used within the codebase.
Signed-off-by: Mark Cave-Ayland
---
hw/rtc/m48t59-isa.c | 25 -
include/hw/rtc/m48t59.h | 2 --
2 files changed, 27 deletions(-)
diff --git a/hw/rtc/m48t59-isa.c b/hw/rtc/m48t59-isa.c
index cae315e488..dc21fb10a5
Signed-off-by: Mark Cave-Ayland
---
hw/sparc/sun4m.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/hw/sparc/sun4m.c b/hw/sparc/sun4m.c
index 54a2b2f9ef..a9bb60f2b2 100644
--- a/hw/sparc/sun4m.c
+++ b/hw/sparc/sun4m.c
@@ -966,7 +966,13 @@ static void
Signed-off-by: Mark Cave-Ayland
---
hw/sparc64/sun4u.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/hw/sparc64/sun4u.c b/hw/sparc64/sun4u.c
index ad5ca2472a..05e659c8a4 100644
--- a/hw/sparc64/sun4u.c
+++ b/hw/sparc64/sun4u.c
@@ -671,10 +671,13 @@ static void
This patchset is inspired by Philippe's "hw/rtc/m48t59: Simplify m48t59_init()"
patchset at https://lists.gnu.org/archive/html/qemu-devel/2020-10/msg04493.html
but goes further: rather than tidy-up the legacy init functions, convert the
callers to use qdev properties directly so they can simply be
After a migration the clock offset is updated, but we also
need to re-arm the alarm if needed.
Signed-off-by: Laurent Vivier
---
hw/rtc/goldfish_rtc.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/rtc/goldfish_rtc.c b/hw/rtc/goldfish_rtc.c
index 0f4e8185a796..e07ff0164e0c 100644
---
On Fri, Oct 16, 2020 at 7:59 AM Peer Adelt wrote:
>
> Hi,
>
> I have a problem with the RISC-V HTIF device.
>
> Every binary I have compiled for Spike on riscv32 fails with the following
> error message: "HTIF tohost must be 8 bytes"
>
> This happens regardless of which program I have translated
On 10/16/20 12:04 PM, Ju Hyung Park wrote:
> A small update:
>
> As per Stefano's suggestion, disabling io_uring support from QEMU from
> the configuration step did fix the problem and I'm no longer having
> hangs.
>
> Looks like it __is__ an io_uring issue :(
Would be great if you could try
A small update:
As per Stefano's suggestion, disabling io_uring support from QEMU from
the configuration step did fix the problem and I'm no longer having
hangs.
Looks like it __is__ an io_uring issue :(
Btw, I used liburing fe50048 for linking QEMU.
Thanks.
On Fri, Oct 2, 2020 at 4:35 PM
On Fri, Oct 16, 2020 at 10:10 AM Ivan Griffin wrote:
>
> Adding the PolarFire SoC IOSCBCTRL memory region to prevent QEMU
> reporting a STORE/AMO Access Fault.
>
> This region is used by the PolarFire SoC port of U-Boot to
> interact with the FPGA system controller.
>
> Signed-off-by: Ivan
On 10/16/20 6:33 AM, Philippe Mathieu-Daudé wrote:
> Per "MIPS32 34K Processor Core Family Software User's Manual,
> Revision 01.13" page 8 in "Joint TLB (JTLB)" section:
>
> "The JTLB is a fully associative TLB cache containing 16, 32,
>or 64-dual-entries mapping up to 128 virtual pages to
On 10/10/20 3:57 PM, Luc Michel wrote:
[...]
Hi,
This series add the BCM2835 CPRMAN clock manager peripheral to the
Raspberry Pi machine.
Series:
Tested-by: Philippe Mathieu-Daudé
It's better to return status together with setting errp. It allows to
reduce error propagation.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Greg Kurz
Reviewed-by: Alberto Garcia
---
block/qcow2.c | 19 +--
1 file changed, 9 insertions(+), 10 deletions(-)
diff
qcow2_do_open correctly sets errp on each failure path. So, we can
simplify code in qcow2_co_invalidate_cache() and drop explicit error
propagation.
Add ERRP_GUARD() as mandated by the documentation in
include/qapi/error.h so that error_prepend() is actually called even if
errp is _fatal.
Set errp always on failure. Generic bdrv_open_driver supports driver
functions which can return negative value and forget to set errp.
That's a strange thing.. Let's improve bdrv_qed_do_open to not behave
this way. This allows to simplify code in
bdrv_qed_co_invalidate_cache().
Signed-off-by:
It's recommended for bool functions with errp to return true on success
and false on failure. Non-standard interfaces don't help to understand
the code. The change is also needed to reduce error propagation.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Alberto Garcia
Reviewed-by:
On 10/15/20 11:56 AM, Victor Kamensky (kamensky) via wrote:
> Is possible to come back to 34Kf route, doing
> very small localized very well defined change
> of bumping TLBs number for model that we know
> works well for us?
Yes, thanks for testing.
I think we should also add a property to
Let's check return value of mirror_start_job to check for failure
instead of local_err.
Rename ret to job, as ret is usually integer variable.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Greg Kurz
Reviewed-by: Alberto Garcia
---
block/mirror.c | 12 +---
1 file changed,
It's better to return status together with setting errp. It makes
possible to avoid error propagation.
While being here, put ERRP_GUARD() to fix error_prepend(errp, ...)
usage inside qcow2_store_persistent_dirty_bitmaps() (see the comment
above ERRP_GUARD() definition in include/qapi/error.h)
On 10/15/20 11:05 AM, Alexey Baturo wrote:
> Meanwhile, do you think applying **MTE *masks while reading CSR values is a
> good solution for now?
Yes.
r~
bdrv_set_backing_hd now returns status, let's use it.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Greg Kurz
Reviewed-by: Alberto Garcia
---
block.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/block.c b/block.c
index 7b6818c681..a35dc80dd4 100644
---
Better to return status together with setting errp. It allows to avoid
error propagation in the caller.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Greg Kurz
Reviewed-by: Alberto Garcia
---
include/block/blockjob.h | 2 +-
blockjob.c | 18 --
2
Don't use error propagation in qcow2_get_specific_info(). For this
refactor qcow2_get_bitmap_info_list, its current interface is rather
weird.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Greg Kurz
Reviewed-by: Alberto Garcia
---
block/qcow2.h| 4 ++--
Now bdrv_append returns status and we can drop all the local_err things
around it.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Greg Kurz
Reviewed-by: Alberto Garcia
---
block.c | 5 +
block/backup-top.c | 20
block/commit.c
This patch is generated by cocci script:
@@
symbol bdrv_open_child, errp, local_err;
expression file;
@@
file = bdrv_open_child(...,
-_err
+errp
);
- if (local_err)
+ if (!file)
{
...
- error_propagate(errp,
The recommended use of qemu error api assumes returning status together
with setting errp and avoid void functions with errp parameter. Let's
improve bdrv_append and some friends to reduce error-propagation
overhead in further patches.
Choose int return status, because bdrv_replace_node() has
On 10/11/20 8:26 PM, Luc Michel wrote:
On 18:18 Sat 10 Oct , Philippe Mathieu-Daudé wrote:
On 10/10/20 3:57 PM, Luc Michel wrote:
Those reset values have been extracted from a Raspberry Pi 3 model B
v1.2, using the 2020-08-20 version of raspios. The dump was done using
the debugfs
We leak local_err and don't report failure to the caller. It's
definitely wrong, let's fix.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Greg Kurz
Reviewed-by: Alberto Garcia
---
blockdev.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/blockdev.c
v3:
08: update comment, add Alberto's r-b
09: update comment, add Alberto's and Greg's r-bs
10: add Alberto's r-b
12: Update commit msg, add Alberto's and Greg's r-bs
13: add Greg's r-b
Vladimir Sementsov-Ogievskiy (13):
block: return status from bdrv_append and friends
block: use return
1 - 100 of 258 matches
Mail list logo