[PATCH v2] hw/riscv: microchip_pfsoc: IOSCBCTRL memmap entry

2020-10-16 Thread Ivan Griffin
Adding the PolarFire SoC IOSCBCTRL memory region to prevent QEMU reporting a STORE/AMO Access Fault. This region is used by the PolarFire SoC port of U-Boot to interact with the FPGA system controller. Signed-off-by: Ivan Griffin --- hw/riscv/microchip_pfsoc.c | 10 ++

Re: [PATCH v2 03/10] softfloat: Tidy a * b + inf return

2020-10-16 Thread Philippe Mathieu-Daudé
On 9/25/20 5:20 PM, Richard Henderson wrote: No reason to set values in 'a', when we already have float_class_inf in 'c', and can flip that sign. Reviewed-by: David Hildenbrand Signed-off-by: Richard Henderson --- fpu/softfloat.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)

Re: [PATCH] hw/xen: Set suppress-vmdesc for Xen machines

2020-10-16 Thread Jason Andryuk
On Fri, Oct 16, 2020 at 12:44 PM Anthony PERARD wrote: > > On Fri, Oct 16, 2020 at 12:01:47PM -0400, Jason Andryuk wrote: > > On Fri, Oct 16, 2020 at 11:38 AM Anthony PERARD > > wrote: > > > > > > On Tue, Oct 13, 2020 at 03:05:06PM -0400, Jason Andryuk wrote: > > > > xen-save-devices-state

Re: [PATCH v2 06/10] softfloat: Implement float128_muladd

2020-10-16 Thread Richard Henderson
On 10/16/20 9:31 AM, Alex Bennée wrote: >> +static void float128_unpack(FloatParts128 *p, float128 a, float_status >> *status) >> +{ >> +p->sign = extractFloat128Sign(a); >> +p->exp = extractFloat128Exp(a); >> +p->frac0 = extractFloat128Frac0(a); >> +p->frac1 =

Re: [PATCH v2] hw/block/nand: Decommission the NAND museum

2020-10-16 Thread Philippe Mathieu-Daudé
Cc'ing qemu-trivial@ since this patch is reviewed. On 10/15/20 8:12 PM, Philippe Mathieu-Daudé wrote: ping^2... On 10/1/20 7:31 PM, Philippe Mathieu-Daudé wrote: ping qemu-block or qemu-arm? On 9/15/20 7:16 PM, Philippe Mathieu-Daudé wrote: This is the QEMU equivalent of this Linux commit

Re: [PATCH] tests/acceptance: add MIPS record/replay tests

2020-10-16 Thread Philippe Mathieu-Daudé
On 10/16/20 5:40 PM, Philippe Mathieu-Daudé wrote: On 10/15/20 1:25 PM, Pavel Dovgalyuk wrote: This patch adds MIPS-targeted acceptance tests for record/replay functions. Signed-off-by: Pavel Dovgalyuk ---   0 files changed diff --git a/tests/acceptance/replay_kernel.py

Re: [PATCH V14 0/8] mips: Add Loongson-3 machine support

2020-10-16 Thread Philippe Mathieu-Daudé
On 10/16/20 8:51 AM, Huacai Chen wrote: Loongson-3 CPU family include Loongson-3A R1/R2/R3/R4 and Loongson-3B R1/R2. Loongson-3A R1 is the oldest and its ISA is the smallest, while Loongson-3A R4 is the newest and its ISA is almost the superset of all others. To reduce complexity, in QEMU we

Re: [PATCH v4 00/21] hw/mips: Set CPU frequency

2020-10-16 Thread Philippe Mathieu-Daudé
On 10/12/20 11:57 AM, Philippe Mathieu-Daudé wrote: Since v3: - Introduced mips_cpu_create_with_clock() helper (Huacai) - Added R-b tags Since v2: - Renamed "clk" -> "clk-in" - Renamed "cpuclk-out -> "cpu-refclk" Missing review: patches 7, 10-13, 15-21 ~~~ All the MIPS cores emulated by QEMU

Re: [PATCH] hw/xen: Set suppress-vmdesc for Xen machines

2020-10-16 Thread Anthony PERARD via
On Fri, Oct 16, 2020 at 12:01:47PM -0400, Jason Andryuk wrote: > On Fri, Oct 16, 2020 at 11:38 AM Anthony PERARD > wrote: > > > > On Tue, Oct 13, 2020 at 03:05:06PM -0400, Jason Andryuk wrote: > > > xen-save-devices-state doesn't currently generate a vmdesc, so restore > > > always triggers

[Bug 1900122] Re: Unsupported ioctl: cmd=0xffffffff80685600 when accessing /dev/video* in aarch64 guest

2020-10-16 Thread vak
** Description changed: **Description:** Any attempt to work with video in aarch64 architecture emulated on x86_64 leads currently to the error "Function not implemented". For example: ``` # v4l2-ctl -l --verbose Failed to open /dev/video0: Function not implemented

Re: [PULL 0/8] Modules 20201015 patches

2020-10-16 Thread Peter Maydell
On Thu, 15 Oct 2020 at 13:55, Gerd Hoffmann wrote: > > The following changes since commit 57c98ea9acdcef5021f5671efa6475a5794a51c4: > > Merge remote-tracking branch 'remotes/kraxel/tags/ui-20201014-pull-request' > into staging (2020-10-14 13:56:06 +0100) > > are available in the Git repository

Re: [PATCH v2 05/10] softfloat: Inline pick_nan_muladd into its caller

2020-10-16 Thread Richard Henderson
On 10/16/20 9:20 AM, Alex Bennée wrote: > > Richard Henderson writes: > >> Because of FloatParts, there will only ever be one caller. > > Isn't that admitting defeat - after all the logic here will be the same > as the login in the up coming float128_muladd code and we only seem to > need

Re: [PATCH] hw/riscv: microchip_pfsoc: IOSCBCTRL memmap entry

2020-10-16 Thread Alistair Francis
On Fri, Oct 16, 2020 at 9:31 AM Ivan Griffin wrote: > > I don't know why it isn't documented in that PDF (or in the register map), > but if you check > https://github.com/polarfire-soc/polarfire-soc-bare-metal-library/blob/master/src/platform/drivers/mss_sys_services/mss_sys_services.h >

Re: [PATCH v2 06/10] softfloat: Implement float128_muladd

2020-10-16 Thread Alex Bennée
Richard Henderson writes: > Signed-off-by: Richard Henderson > --- > include/fpu/softfloat.h | 2 + > fpu/softfloat.c | 416 +++- > tests/fp/fp-test.c | 2 +- > tests/fp/wrap.c.inc | 12 ++ > 4 files changed, 430 insertions(+), 2

RE: [PATCH] hw/riscv: microchip_pfsoc: IOSCBCTRL memmap entry

2020-10-16 Thread Ivan Griffin
I don't know why it isn't documented in that PDF (or in the register map), but if you check https://github.com/polarfire-soc/polarfire-soc-bare-metal-library/blob/master/src/platform/drivers/mss_sys_services/mss_sys_services.h you'll see the following ``` typedef struct { volatile uint32_t

Re: [PATCH v2 05/10] softfloat: Inline pick_nan_muladd into its caller

2020-10-16 Thread Alex Bennée
Richard Henderson writes: > Because of FloatParts, there will only ever be one caller. Isn't that admitting defeat - after all the logic here will be the same as the login in the up coming float128_muladd code and we only seem to need additional information: > Inlining allows us to re-use

Re: [PATCH] hw/riscv: microchip_pfsoc: IOSCBCTRL memmap entry

2020-10-16 Thread Alistair Francis
On Fri, Oct 16, 2020 at 8:04 AM Ivan Griffin wrote: > > Adding the PolarFire SoC IOSCBCTRL memory region to prevent QEMU > reporting a STORE/AMO Access Fault. > > This region is used by the PolarFire SoC port of U-Boot to > interact with the FPGA system controller. > > Signed-off-by: Ivan Griffin

Re: [PATCH 6/30] semihosting: Fix Lesser GPL version number

2020-10-16 Thread Alex Bennée
Chetan Pant writes: > There is no "version 2" of the "Lesser" General Public License. > It is either "GPL version 2.0" or "Lesser GPL version 2.1". > This patch replaces all occurrences of "Lesser GPL version 2" with > "Lesser GPL version 2.1" in comment section. > > Signed-off-by: Chetan Pant

Re: [PATCH] hw/xen: Set suppress-vmdesc for Xen machines

2020-10-16 Thread Jason Andryuk
On Fri, Oct 16, 2020 at 11:38 AM Anthony PERARD wrote: > > On Tue, Oct 13, 2020 at 03:05:06PM -0400, Jason Andryuk wrote: > > xen-save-devices-state doesn't currently generate a vmdesc, so restore > > always triggers "Expected vmdescription section, but got 0". This is > > not a problem when

[PULL 18/22] meson: Move the detection logic for sphinx to meson

2020-10-16 Thread Paolo Bonzini
From: Yonggang Luo Signed-off-by: Yonggang Luo Message-Id: <20201015220626.418-4-luoyongg...@gmail.com> Signed-off-by: Paolo Bonzini --- configure | 59 --- docs/meson.build | 46 meson.build | 30

[PULL v2 00/22] Build system + misc changes for 2020-10-16

2020-10-16 Thread Paolo Bonzini
The following changes since commit 3e40748834923798aa57e3751db13a069e2c617b: Merge remote-tracking branch 'remotes/rth/tags/pull-mb-20201014' into staging (2020-10-15 20:30:24 +0100) are available in the Git repository at: https://gitlab.com/bonzini/qemu.git tags/for-upstream for you to

Re: [PATCH v11 13/13] block: apply COR-filter to block-stream jobs

2020-10-16 Thread Vladimir Sementsov-Ogievskiy
15.10.2020 20:16, Andrey Shinkevich wrote: On 14.10.2020 19:24, Max Reitz wrote: On 12.10.20 19:43, Andrey Shinkevich wrote: [...] ---   block/stream.c | 93 +-   tests/qemu-iotests/030 | 51 +++--  

Re: [PATCH] tests/acceptance: add MIPS record/replay tests

2020-10-16 Thread Philippe Mathieu-Daudé
On 10/15/20 1:25 PM, Pavel Dovgalyuk wrote: This patch adds MIPS-targeted acceptance tests for record/replay functions. Signed-off-by: Pavel Dovgalyuk --- 0 files changed diff --git a/tests/acceptance/replay_kernel.py b/tests/acceptance/replay_kernel.py index 952f429cac..6c3d1ec3fb 100644

Re: [PATCH] hw/xen: Set suppress-vmdesc for Xen machines

2020-10-16 Thread Anthony PERARD via
On Tue, Oct 13, 2020 at 03:05:06PM -0400, Jason Andryuk wrote: > xen-save-devices-state doesn't currently generate a vmdesc, so restore > always triggers "Expected vmdescription section, but got 0". This is > not a problem when restore comes from a file. However, when QEMU runs > in a linux

Re: [PATCH] s390x/s390-virtio-ccw: Reset PCI devices during subsystem reset

2020-10-16 Thread Halil Pasic
On Thu, 15 Oct 2020 09:16:07 -0400 Matthew Rosato wrote: > Currently, a subsystem reset event leaves PCI devices enabled, causing > issues post-reset in the guest (an example would be after a kexec). These > devices need to be reset during a subsystem reset, allowing them to be > properly

Re: [PATCH v4 0/4] Introducing QMP query-netdev command

2020-10-16 Thread Alexey Kirillov
Ping again, as no progress since september 22. http://patchwork.ozlabs.org/project/qemu-devel/list/?series=203284 21.09.2020, 22:19, "Alexey Kirillov" : > This patch series introduces a new QMP command "query-netdev" to get > information about currently attached backend network devices

Re: [PATCH v6 0/7] hw/misc: Add LED device

2020-10-16 Thread Philippe Mathieu-Daudé
Hi Cédric, On 9/19/20 2:30 PM, Philippe Mathieu-Daudé wrote: On 9/12/20 3:40 PM, Philippe Mathieu-Daudé wrote: Hello, These patches are part of the GSoC unselected 'QEMU visualizer' project. This series introduce a LED device that can be easily connected to a GPIO output. [...] Philippe

Re: [PATCH V14 1/8] target/mips: Fix PageMask with variable page size

2020-10-16 Thread Philippe Mathieu-Daudé
On 10/16/20 8:51 AM, Huacai Chen wrote: From: Jiaxun Yang Our current code assumed the target page size is always 4k when handling PageMask and VPN2, however, variable page size was just added to mips target and that's no longer true. Fixes: ee3863b9d414 ("target/mips: Support variable page

Re: [PATCH] drivers/virt: vmgenid: add vm generation id driver

2020-10-16 Thread gre...@linuxfoundation.org
On Fri, Oct 16, 2020 at 02:33:15PM +, Catangiu, Adrian Costin wrote: > +config VMGENID > + tristate "Virtual Machine Generation ID driver" > + depends on ACPI > + default M Unless this is required to boot a machine, this should be removed. > + help > + This is a Virtual

Re: [PATCH V14 2/8] target/mips: Add loongson-ext lswc2 group of instructions (Part 1)

2020-10-16 Thread Philippe Mathieu-Daudé
On 10/16/20 8:51 AM, Huacai Chen wrote: From: Jiaxun Yang LWC2 & SWC2 have been rewritten by Loongson EXT vendor ASE as "load/store quad word" and "shifted load/store" groups of instructions. This patch add implementation of these instructions: gslq: load 16 bytes to GPR gssq: store 16 bytes

Re: [PATCH v11 13/13] block: apply COR-filter to block-stream jobs

2020-10-16 Thread Andrey Shinkevich
On 15.10.2020 20:16, Andrey Shinkevich wrote: On 14.10.2020 19:24, Max Reitz wrote: On 12.10.20 19:43, Andrey Shinkevich wrote: [...] ---   block/stream.c | 93 +-   tests/qemu-iotests/030 | 51 +++--  

Re: [PATCH] drivers/virt: vmgenid: add vm generation id driver

2020-10-16 Thread Catangiu, Adrian Costin
Sorry, I forgot to add a few people interested in this and the KVM ML to CC. Added them. On 16/10/2020, 17:33, "Catangiu, Adrian Costin" wrote: - Background The VM Generation ID is a feature defined by Microsoft (paper: http://go.microsoft.com/fwlink/?LinkId=260709) and

Re: [PATCH v2 3/3] accel: Add xen CpusAccel using dummy-cpus

2020-10-16 Thread Anthony PERARD via
On Tue, Oct 13, 2020 at 10:05:11AM -0400, Jason Andryuk wrote: > Xen was broken by commit 1583a3898853 ("cpus: extract out qtest-specific > code to accel/qtest"). Xen relied on qemu_init_vcpu() calling > qemu_dummy_start_vcpu() in the default case, but that was replaced by >

[PATCH] hw/riscv: microchip_pfsoc: IOSCBCTRL memmap entry

2020-10-16 Thread Ivan Griffin
Adding the PolarFire SoC IOSCBCTRL memory region to prevent QEMU reporting a STORE/AMO Access Fault. This region is used by the PolarFire SoC port of U-Boot to interact with the FPGA system controller. Signed-off-by: Ivan Griffin --- hw/riscv/microchip_pfsoc.c | 6 ++

[PATCH] drivers/virt: vmgenid: add vm generation id driver

2020-10-16 Thread Catangiu, Adrian Costin
- Background The VM Generation ID is a feature defined by Microsoft (paper: http://go.microsoft.com/fwlink/?LinkId=260709) and supported by multiple hypervisor vendors. The feature is required in virtualized environments by apps that work with local copies/caches of world-unique data such as

HTIF tohost symbol size check always fails

2020-10-16 Thread Peer Adelt
Hi, I have a problem with the RISC-V HTIF device. Every binary I have compiled for Spike on riscv32 fails with the following error message: "HTIF tohost must be 8 bytes" This happens regardless of which program I have translated for Spike. This is also the case with the official

[Bug 1900155] [NEW] MIPS Malta fails booting due to IDE error

2020-10-16 Thread Philippe Mathieu-Daudé
Public bug reported: As of commit 3e407488349: $ avocado --show=console run -t machine:malta tests/acceptance/boot_linux_console.py console: [0.00] Linux version 4.5.0-2-4kc-malta (debian-ker...@lists.debian.org) (gcc version 5.3.1 20160519 (Debian 5.3.1-20) ) #1 Debian 4.5.5-1

[PATCH 7/30] non-virt: Fix Lesser GPL version number

2020-10-16 Thread Chetan Pant
There is no "version 2" of the "Lesser" General Public License. It is either "GPL version 2.0" or "Lesser GPL version 2.1". This patch replaces all occurrences of "Lesser GPL version 2" with "Lesser GPL version 2.1" in comment section. Signed-off-by: Chetan Pant --- hw/intc/xics_pnv.c |

Re: [PATCH v4 14/16] fuzz: add general-fuzz configs for oss-fuzz

2020-10-16 Thread Alexander Bulekov
On 201016 1532, Paolo Bonzini wrote: > On 15/10/20 15:41, Alexander Bulekov wrote: > > +typedef struct general_fuzz_config { > > +const char *name, *args, *objects; > > +} general_fuzz_config; > > + > > +GArray *get_general_fuzz_configs(void); > > Can't it be even a "const struct

[PATCH 6/30] semihosting: Fix Lesser GPL version number

2020-10-16 Thread Chetan Pant
There is no "version 2" of the "Lesser" General Public License. It is either "GPL version 2.0" or "Lesser GPL version 2.1". This patch replaces all occurrences of "Lesser GPL version 2" with "Lesser GPL version 2.1" in comment section. Signed-off-by: Chetan Pant ---

[PATCH 5/30] mips tcg: Fix Lesser GPL version number

2020-10-16 Thread Chetan Pant
There is no "version 2" of the "Lesser" General Public License. It is either "GPL version 2.0" or "Lesser GPL version 2.1". This patch replaces all occurrences of "Lesser GPL version 2" with "Lesser GPL version 2.1" in comment section. Signed-off-by: Chetan Pant --- hw/mips/cps.c

Re: [PATCH v11 05/13] copy-on-read: limit COR operations to base in COR driver

2020-10-16 Thread Vladimir Sementsov-Ogievskiy
15.10.2020 20:37, Andrey Shinkevich wrote: On 15.10.2020 18:56, Max Reitz wrote: On 14.10.20 20:57, Andrey Shinkevich wrote: On 14.10.2020 15:01, Max Reitz wrote: On 12.10.20 19:43, Andrey Shinkevich wrote: Limit COR operations by the base node in the backing chain when the overlay base node

Re: [PATCH V14 8/8] docs/system: Update MIPS machine documentation

2020-10-16 Thread Philippe Mathieu-Daudé
On 10/16/20 8:52 AM, Huacai Chen wrote: Add Loongson-3A CPU models and Loongson-3 based machine description. Signed-off-by: Huacai Chen --- docs/system/cpu-models-mips.rst.inc | 10 -- docs/system/target-mips.rst | 10 ++ 2 files changed, 18 insertions(+), 2

Re: [PATCH V14 6/8] hw/mips: Add Loongson-3 boot parameter helpers

2020-10-16 Thread Philippe Mathieu-Daudé
Hi Huacai, On 10/16/20 8:51 AM, Huacai Chen wrote: Preparing to add Loongson-3 machine support, add Loongson-3's LEFI (a UEFI-like interface for BIOS-Kernel boot parameters) helpers first. Signed-off-by: Huacai Chen Co-developed-by: Jiaxun Yang From the kernel documentation [*] on the

Re: About 'qemu-security' mailing list

2020-10-16 Thread P J P
Hello Darren, all +-- On Thu, 1 Oct 2020, Darren Kenny wrote --+ | On Thursday, 2020-10-01 at 16:05:58 +0530, P J P wrote: | > - A list member triaging such issue, would have to select their individual | > keys for each reply. | | Maybe, honestly not had to deal with it personally.

Re: [PATCH V14 4/8] target/mips: Add loongson-ext lsdc2 group of instructions

2020-10-16 Thread Philippe Mathieu-Daudé
On 10/16/20 8:51 AM, Huacai Chen wrote: From: Jiaxun Yang LDC2/SDC2 opcodes have been rewritten as "load & store with offset" group of instructions by loongson-ext ASE. This patch add implementation of these instructions: gslbx: load 1 bytes to GPR gslhx: load 2 bytes to GPR gslwx: load 4

Re: [PATCH 0/2] hw/mips/malta: Minor housekeeping in mips_malta_init()

2020-10-16 Thread Philippe Mathieu-Daudé
On 10/12/20 6:05 PM, Philippe Mathieu-Daudé wrote: Move some code around to make this big function easier to review. Philippe Mathieu-Daudé (2): hw/mips/malta: Move gt64120 related code together hw/mips/malta: Use clearer qdev style hw/mips/malta.c | 21 ++--- 1 file

Re: [PATCH v2 0/4] MAINTAINERS: Update MIPS sections

2020-10-16 Thread Philippe Mathieu-Daudé
On 10/13/20 12:16 PM, Philippe Mathieu-Daudé wrote: Volunteer to maintain MIPS TCG. As discussed on list, Huacai will likely send a similar patch. Few more adjustments (in particular around Boston board). Based-on: <1602103041-32017-1-git-send-email-aleksandar.qemu.de...@gmail.com>

Re: [PATCH v2 4/4] MAINTAINERS: Move MIPS GIC timer files to Boston board section

2020-10-16 Thread Philippe Mathieu-Daudé
On 10/14/20 3:39 PM, Thomas Huth wrote: On 13/10/2020 12.16, Philippe Mathieu-Daudé wrote: The MIPS GIC timer is only used by the Boston board. Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS

Re: [PATCH v4 00/16] Add a General Virtual Device Fuzzer

2020-10-16 Thread Paolo Bonzini
If you have to do a v5, the correct word is generic not general. :) Otherwise looks great. Paolo On 15/10/20 15:41, Alexander Bulekov wrote: > v4: > - Replace yaml + c template-based oss-fuzz configs, with C code to > register a FuzzTarget for each config (as suggested by Paolo) >

[RFC PATCH v3] target/mips: Increase number of TLB entries on the 34Kf core (16 -> 64)

2020-10-16 Thread Philippe Mathieu-Daudé
Per "MIPS32 34K Processor Core Family Software User's Manual, Revision 01.13" page 8 in "Joint TLB (JTLB)" section: "The JTLB is a fully associative TLB cache containing 16, 32, or 64-dual-entries mapping up to 128 virtual pages to their corresponding physical addresses." There is no

Re: [PATCH v4 14/16] fuzz: add general-fuzz configs for oss-fuzz

2020-10-16 Thread Paolo Bonzini
On 15/10/20 15:41, Alexander Bulekov wrote: > +typedef struct general_fuzz_config { > +const char *name, *args, *objects; > +} general_fuzz_config; > + > +GArray *get_general_fuzz_configs(void); Can't it be even a "const struct general_fuzz_config general_fuzz_configs[] = ..." instead of a

Re: [PULL 18/22] meson: Move the detection logic for sphinx to meson

2020-10-16 Thread Yonggang Luo
On Fri, Oct 16, 2020 at 7:48 PM Paolo Bonzini wrote: > > From: Yonggang Luo > > Signed-off-by: Yonggang Luo > Message-Id: <20201015220626.418-4-luoyongg...@gmail.com> > Signed-off-by: Paolo Bonzini > --- > configure | 59 --- >

Re: [PATCH 0/4] RfC: microvm: add second ioapic

2020-10-16 Thread Philippe Mathieu-Daudé
On 10/16/20 1:43 PM, Gerd Hoffmann wrote: Add a second ioapic to microvm. Gives us more IRQ lines we can use for virtio-mmio devices. Bump number of possible virtio-mmio devices from 8 to 24. Gerd Hoffmann (4): microvm: make number of virtio transports runtime configurable microvm: make

Re: [PATCH v10 00/10] virtio-iommu: VFIO integration

2020-10-16 Thread Auger Eric
Hi Jean, On 10/8/20 7:15 PM, Jean-Philippe Brucker wrote: > This series adds support for VFIO endpoints to virtio-iommu. > > Versions 1 to 9 were posted by Bharat Bhushan, but I am taking over for > now since he doesn't have much time to spend on it. Thanks again Bharat > for the work! > > Two

Re: [PATCH v10 09/10] virtio-iommu: Set supported page size mask

2020-10-16 Thread Auger Eric
Hi Jean, On 10/8/20 7:15 PM, Jean-Philippe Brucker wrote: > From: Bharat Bhushan > > The virtio-iommu device can deal with arbitrary page sizes for virtual > endpoints, but for endpoints assigned with VFIO it must follow the page > granule used by the host IOMMU driver. > > Implement the

Re: [PATCH v8 0/5] Mac Old World ROM experiment (ppc/mac_* clean ups and loading binary ROM)

2020-10-16 Thread Philippe Mathieu-Daudé
On 10/16/20 11:58 AM, Mark Cave-Ayland wrote: On 16/10/2020 00:47, BALATON Zoltan via wrote: This is the cut down version of the earlier series omitting unfinished patches that I plan to rework later and rebased to Mark's qemu-macppc branch. Compared to v7 the only change is the cast to

Re: aio_poll() assertion fail on Windows

2020-10-16 Thread Howard Spoelstra
On Fri, Oct 16, 2020 at 1:32 PM Mark Cave-Ayland < mark.cave-ayl...@ilande.co.uk> wrote: > Whilst testing a Windows build of git master of qemu-system-ppc in > MSYS2/MingW64 I > noticed the following assertion message in the console after booting into > OpenBIOS > and then closing the GTK GUI

Re: [PATCH v8 0/5] Mac Old World ROM experiment (ppc/mac_* clean ups and loading binary ROM)

2020-10-16 Thread BALATON Zoltan via
On Fri, 16 Oct 2020, Mark Cave-Ayland wrote: On 16/10/2020 00:47, BALATON Zoltan via wrote: This is the cut down version of the earlier series omitting unfinished patches that I plan to rework later and rebased to Mark's qemu-macppc branch. Compared to v7 the only change is the cast to

[PULL 12/22] meson.build: don't condition iconv detection on library detection

2020-10-16 Thread Paolo Bonzini
From: Bruce Rogers It isn't necessarily the case that use of iconv requires an additional library. For that reason we shouldn't conditionalize iconv detection on libiconv.found. Fixes: 5285e593c33 (configure: Fixes ncursesw detection under msys2/mingw by convert them to meson) Signed-off-by:

[PULL 22/22] ci: include configure and meson logs in all jobs if configure fails

2020-10-16 Thread Paolo Bonzini
Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Paolo Bonzini --- .cirrus.yml| 6 +++--- .gitlab-ci.yml | 6 +++--- .travis.yml| 8 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/.cirrus.yml b/.cirrus.yml index e099da0fec..81a2960b1a 100644 ---

[PULL 13/22] meson: cleanup curses/iconv test

2020-10-16 Thread Paolo Bonzini
Skip the test if it is system emulation is not requested, and differentiate errors for lack of iconv and lack of curses. Signed-off-by: Paolo Bonzini --- meson.build | 85 - 1 file changed, 45 insertions(+), 40 deletions(-) diff --git

[PULL 21/22] hax: unbreak accelerator cpu code after cpus.c split

2020-10-16 Thread Paolo Bonzini
From: Claudio Fontana during my split of cpus.c, code line "current_cpu = cpu" was removed by mistake, causing hax to break. This commit fixes the situation restoring it. Reported-by: Volker Rümelin Fixes: e92558e4bf8059ce4f0b310afe218802b72766bc Signed-off-by: Claudio Fontana Message-Id:

[PULL 19/22] cirrus: Enable doc build on msys2/mingw

2020-10-16 Thread Paolo Bonzini
From: Yonggang Luo Currently rST depends on old version sphinx-2.x. Install it by downloading it. Remove the need of university mirror, the main repo are recovered. Signed-off-by: Yonggang Luo Message-Id: <20201015220626.418-5-luoyongg...@gmail.com> Signed-off-by: Paolo Bonzini ---

[PULL 20/22] fuzz: Disable QEMU's SIG{INT,HUP,TERM} handlers

2020-10-16 Thread Paolo Bonzini
From: Alexander Bulekov Prior to this patch, the only way I found to terminate the fuzzer was either to: 1. Explicitly specify the number of fuzzer runs with the -runs= flag 2. SIGKILL the process with "pkill -9 qemu-fuzz-*" or similar In addition to being annoying to deal with, SIGKILLing

[PULL 18/22] meson: Move the detection logic for sphinx to meson

2020-10-16 Thread Paolo Bonzini
From: Yonggang Luo Signed-off-by: Yonggang Luo Message-Id: <20201015220626.418-4-luoyongg...@gmail.com> Signed-off-by: Paolo Bonzini --- configure | 59 --- docs/meson.build | 46 meson.build | 30

[PULL 05/22] tests: add missing generated sources to testqapi

2020-10-16 Thread Paolo Bonzini
Ninja notices them due to a different order in visiting the graph. Reviewed-by: Daniel P. Berrangé Signed-off-by: Paolo Bonzini --- tests/include/meson.build | 8 tests/meson.build | 14 -- 2 files changed, 16 insertions(+), 6 deletions(-) diff --git

[PULL 15/22] meson: Only install icons and qemu.desktop if have_system

2020-10-16 Thread Paolo Bonzini
From: Bruce Rogers These files are not needed for a linux-user only install. Signed-off-by: Bruce Rogers Message-Id: <20201015201840.282956-1-brog...@suse.com> Signed-off-by: Paolo Bonzini --- ui/meson.build | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git

[PULL 17/22] meson: move SPHINX_ARGS references within "if build_docs"

2020-10-16 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- tests/qapi-schema/meson.build | 88 +-- 1 file changed, 44 insertions(+), 44 deletions(-) diff --git a/tests/qapi-schema/meson.build b/tests/qapi-schema/meson.build index 1f222a7a13..304ef939bd 100644 ---

[PULL 03/22] tests/Makefile.include: unbreak non-tcg builds

2020-10-16 Thread Paolo Bonzini
Remove from check-block the requirement that all TARGET_DIRS are built. Reviewed-by: Daniel P. Berrangé Signed-off-by: Paolo Bonzini --- tests/Makefile.include | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index

[PULL 16/22] docs: Fix Sphinx configuration for msys2/mingw

2020-10-16 Thread Paolo Bonzini
From: Yonggang Luo Python doesn't support running ../scripts/kernel-doc directly. Signed-off-by: Yonggang Luo Message-Id: <20201015220626.418-2-luoyongg...@gmail.com> Signed-off-by: Paolo Bonzini --- docs/conf.py | 2 +- docs/sphinx/kerneldoc.py | 2 +- 2 files changed, 2

[PULL 09/22] build: cleanups to Makefile

2020-10-16 Thread Paolo Bonzini
Group similar rules, add comments to "else" and "endif" lines, detect too-old config-host.mak before messing things up. Signed-off-by: Paolo Bonzini --- Makefile | 45 - 1 file changed, 28 insertions(+), 17 deletions(-) diff --git a/Makefile

[PULL 10/22] build: replace ninjatool with ninja

2020-10-16 Thread Paolo Bonzini
Now that the build is done entirely by Meson, there is no need to keep the Makefile conversion. Instead, we can ask Ninja about the targets it exposes and forward them. The main advantages are, from smallest to largest: - reducing the possible namespace pollution within the Makefile - removal

[PULL 01/22] submodules: bump meson to 0.55.3

2020-10-16 Thread Paolo Bonzini
This adds some bugfixes, and allows MSYS2 to configure without "--ninja=ninja". Signed-off-by: Paolo Bonzini --- .cirrus.yml | 3 +-- meson | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/.cirrus.yml b/.cirrus.yml index 99d118239c..0f46cb5eaf 100644 ---

[PULL 04/22] make: run shell with pipefail

2020-10-16 Thread Paolo Bonzini
Without pipefail, it is possible to miss failures if the recipes include pipes. Reviewed-by: Daniel P. Berrangé Signed-off-by: Paolo Bonzini --- Makefile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Makefile b/Makefile index d20c7a3f80..91c62a26c8 100644 --- a/Makefile +++ b/Makefile

[PULL 14/22] configure: fix handling of --docdir parameter

2020-10-16 Thread Paolo Bonzini
From: Bruce Rogers Commit ca8c0909f01 changed qemu_docdir to be docdir, then later uses the qemu_docdir name in the final assignment. Unfortunately, one instance of qemu_docdir was missed: the one which comes from the --docdir parameter. This patch restores the proper handling of the --docdir

[PATCH 4/4] microvm: reconfigure irqs if second ioapic is available

2020-10-16 Thread Gerd Hoffmann
Use GSI 16+ for PCIe (needs acpi_build_madt() tweak). Use GSI 24+ (second ioapic) for virtio-mmio. Use all irq lines of the second ioapic and allow up to 24 virtio-mmio devices. Signed-off-by: Gerd Hoffmann --- hw/i386/acpi-common.c | 2 +- hw/i386/microvm.c | 6 +- 2 files changed, 6

[PULL 06/22] configure: move QEMU_INCLUDES to meson

2020-10-16 Thread Paolo Bonzini
Confusingly, QEMU_INCLUDES is not used by configure tests. Moving it to meson.build ensures that Windows paths are specified instead of the msys paths like /c/Users/... Reviewed-by: Daniel P. Berrangé Signed-off-by: Paolo Bonzini --- configure | 20 meson.build | 30

[PULL 11/22] build: add --enable/--disable-libudev

2020-10-16 Thread Paolo Bonzini
Initially, libudev detection was bundled with --enable-mpath because qemu-pr-helper was the only user of libudev. Recently however the USB U2F emulation has also started using libudev, so add a separate option. This also allows 1) disabling libudev if desired for static builds and 2) for

[PULL 07/22] dockerfiles: enable Centos 8 PowerTools

2020-10-16 Thread Paolo Bonzini
ninja is included in the CentOS PowerTools repository. Signed-off-by: Paolo Bonzini --- tests/docker/dockerfiles/centos8.docker | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/docker/dockerfiles/centos8.docker b/tests/docker/dockerfiles/centos8.docker index

[PULL 00/22] Build system + misc changes for 2020-10-16

2020-10-16 Thread Paolo Bonzini
The following changes since commit 57c98ea9acdcef5021f5671efa6475a5794a51c4: Merge remote-tracking branch 'remotes/kraxel/tags/ui-20201014-pull-request' into staging (2020-10-14 13:56:06 +0100) are available in the Git repository at: https://gitlab.com/bonzini/qemu.git tags/for-upstream

[PULL 08/22] add ninja to dockerfiles, CI configurations and test VMs

2020-10-16 Thread Paolo Bonzini
Reviewed-by: Daniel P. Berrangé Acked-by: Alex Bennée Signed-off-by: Paolo Bonzini --- .cirrus.yml| 6 +++--- .travis.yml| 13 + tests/docker/dockerfiles/centos7.docker| 1 +

[PATCH 3/4] microvm: add second ioapic

2020-10-16 Thread Gerd Hoffmann
Add more IRQ lines. Depends on ACPI. Also enable this only with userspace ioapic, not sure whenever the kernel can handle two ioapics. Signed-off-by: Gerd Hoffmann --- include/hw/i386/ioapic_internal.h | 2 +- include/hw/i386/x86.h | 1 + hw/i386/acpi-common.c | 10

[PULL 02/22] Makefile: Ensure cscope.out/tags/TAGS are generated in the source tree

2020-10-16 Thread Paolo Bonzini
From: Greg Kurz Tools usually expect the index files to be in the source tree, eg. emacs. This is already the case when doing out-of-tree builds, but with in-tree builds they end up in the build directory. Force cscope, ctags and etags to put them in the source tree. Signed-off-by: Greg Kurz

[PATCH 2/4] microvm: make pcie irq base runtime configurable

2020-10-16 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- include/hw/i386/microvm.h | 2 +- hw/i386/microvm.c | 11 ++- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/include/hw/i386/microvm.h b/include/hw/i386/microvm.h index 0154ad5bd707..ede9625756b8 100644 ---

[PATCH 1/4] microvm: make number of virtio transports runtime configurable

2020-10-16 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- include/hw/i386/microvm.h | 2 +- hw/i386/microvm.c | 9 +++-- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/include/hw/i386/microvm.h b/include/hw/i386/microvm.h index 91b064575d55..0154ad5bd707 100644 --- a/include/hw/i386/microvm.h

[PATCH 3/7] x86: make pci irqs runtime configurable

2020-10-16 Thread Gerd Hoffmann
Add a variable to x86 machine state instead of hard-coding the PCI interrupts. Signed-off-by: Gerd Hoffmann --- include/hw/i386/x86.h | 2 ++ hw/i386/acpi-common.c | 3 +-- hw/i386/x86.c | 1 + 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/include/hw/i386/x86.h

[PATCH 0/4] RfC: microvm: add second ioapic

2020-10-16 Thread Gerd Hoffmann
Add a second ioapic to microvm. Gives us more IRQ lines we can use for virtio-mmio devices. Bump number of possible virtio-mmio devices from 8 to 24. Gerd Hoffmann (4): microvm: make number of virtio transports runtime configurable microvm: make pcie irq base runtime configurable microvm:

Re: [PATCH 1/1] Skip flatview_simplify() for cpu vendor zhaoxin

2020-10-16 Thread Paolo Bonzini
On 16/10/20 13:29, FelixCuioc wrote: > The issue here is that an assinged EHCI device accesses > an adjacent mapping between the delete and add phases > of the VFIO MemoryListener. > We want to skip flatview_simplify() is to prevent EHCI > device IOVA mappings from being unmapped. Hi, there is

[PATCH 0/7] microvm: fix PCIe IRQs in APIC table.

2020-10-16 Thread Gerd Hoffmann
Gerd Hoffmann (7): tests/acpi: allow changes for microvm/APIC.pcie tests/acpi: add empty microvm/APIC.pcie x86: make pci irqs runtime configurable microvm: set pci_irq_mask apci: drop has_pci arg for acpi_build_madt tests/acpi: update expected data files tests/acpi: disallow

[PATCH 5/7] apci: drop has_pci arg for acpi_build_madt

2020-10-16 Thread Gerd Hoffmann
Setting x86ms->pci_irq_mask to zero has the same effect, so we don't need the has_pci argument any more. Signed-off-by: Gerd Hoffmann --- hw/i386/acpi-common.h | 3 +-- hw/i386/acpi-build.c | 2 +- hw/i386/acpi-common.c | 25 +++-- hw/i386/acpi-microvm.c | 2 +- 4

[PATCH 1/7] tests/acpi: allow changes for microvm/APIC.pcie

2020-10-16 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- tests/qtest/bios-tables-test-allowed-diff.h | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h index dfb8523c8bf4..0c37ccebc5ba 100644 ---

[PATCH 7/7] tests/acpi: disallow changes for microvm/APIC.pcie

2020-10-16 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- tests/qtest/bios-tables-test-allowed-diff.h | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h index 0c37ccebc5ba..dfb8523c8bf4 100644 ---

[PATCH 2/7] tests/acpi: add empty microvm/APIC.pcie

2020-10-16 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- tests/data/acpi/microvm/APIC.pcie | 0 1 file changed, 0 insertions(+), 0 deletions(-) create mode 100644 tests/data/acpi/microvm/APIC.pcie diff --git a/tests/data/acpi/microvm/APIC.pcie b/tests/data/acpi/microvm/APIC.pcie new file mode 100644 index

[PATCH 6/7] tests/acpi: update expected data files

2020-10-16 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- tests/data/acpi/microvm/APIC.pcie | Bin 0 -> 110 bytes 1 file changed, 0 insertions(+), 0 deletions(-) diff --git a/tests/data/acpi/microvm/APIC.pcie b/tests/data/acpi/microvm/APIC.pcie index

[PATCH 4/7] microvm: set pci_irq_mask

2020-10-16 Thread Gerd Hoffmann
Makes sure the PCI interrupt overrides are added to the APIC table in case PCIe is enabled. Signed-off-by: Gerd Hoffmann --- hw/i386/acpi-microvm.c | 2 +- hw/i386/microvm.c | 6 ++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/hw/i386/acpi-microvm.c

[PATCH 0/1] Skip flatview_simplify() for cpu vendor zhaoxin

2020-10-16 Thread FelixCuioc
The actual situation we encountered is: When assign EHCI device to the virtual machine, after initializing EHCI in seabios,it will continuously send dma cycles. After flatview_simplify(),the IOVA mappings of the EHCI device will be innocently unmapped between the delate and add phases of the VFIO

[PATCH 1/1] Skip flatview_simplify() for cpu vendor zhaoxin

2020-10-16 Thread FelixCuioc
The issue here is that an assinged EHCI device accesses an adjacent mapping between the delete and add phases of the VFIO MemoryListener. We want to skip flatview_simplify() is to prevent EHCI device IOVA mappings from being unmapped. Signed-off-by: FelixCuioc --- softmmu/memory.c | 20

aio_poll() assertion fail on Windows

2020-10-16 Thread Mark Cave-Ayland
Whilst testing a Windows build of git master of qemu-system-ppc in MSYS2/MingW64 I noticed the following assertion message in the console after booting into OpenBIOS and then closing the GTK GUI window without booting a client OS: $ ./qemu-system-ppc ** ERROR:../util/aio-win32.c:337:aio_poll:

[PATCH v3 2/2] coroutine: take exactly one batch from global pool at a time

2020-10-16 Thread wanghonghao
This patch replace the global coroutine queue with a lock-free stack of which the elements are coroutine queues. Threads can put coroutine queues into the stack or take queues from it and each coroutine queue has exactly POOL_BATCH_SIZE coroutines. Note that the stack is not strictly LIFO, but

<    1   2   3   >