Re: [PATCH v3] hw/arm: Restrict APEI tables generation to the 'virt' machine

2020-10-19 Thread Peter Maydell
On Thu, 8 Oct 2020 at 17:14, Philippe Mathieu-Daudé wrote: > > While APEI is a generic ACPI feature (usable by X86 and ARM64), only > the 'virt' machine uses it, by enabling the RAS Virtualization. See > commit 2afa8c8519: "hw/arm/virt: Introduce a RAS machine option"). > > Restrict the APEI table

[PATCH v2 08/10] target/arm: Fix has_vfp/has_neon ID reg squashing for M-profile

2020-10-19 Thread Peter Maydell
In arm_cpu_realizefn(), if the CPU has VFP or Neon disabled then we squash the ID register fields so that we don't advertise it to the guest. This code was written for A-profile and needs some tweaks to work correctly on M-profile: * A-profile only fields should not be zeroed on M-profile: -

Re: [PATCH] hw/arm/strongarm: Fix 'time to transmit a char' unit comment

2020-10-19 Thread Peter Maydell
On Wed, 14 Oct 2020 at 22:36, Philippe Mathieu-Daudé wrote: > > The time to transmit a char is expressed in nanoseconds, not in ticks. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/arm/strongarm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/arm/strongarm.c

[PATCH v2 10/10] target/arm: Implement FPSCR.LTPSIZE for M-profile LOB extension

2020-10-19 Thread Peter Maydell
If the M-profile low-overhead-branch extension is implemented, FPSCR bits [18:16] are a new field LTPSIZE. If MVE is not implemented (currently always true for us) then this field always reads as 4 and ignores writes. These bits used to be the vector-length field for the old short-vector extensio

Re: Kernel patch cases qemu live migration failed.

2020-10-19 Thread Andrew Jones
On Mon, Oct 19, 2020 at 03:58:40PM +0100, Dave Martin wrote: > On Mon, Oct 19, 2020 at 03:18:11PM +0100, Peter Maydell wrote: > > On Mon, 19 Oct 2020 at 14:40, Andrew Jones wrote: > > > > > > On Mon, Oct 19, 2020 at 12:43:33PM +0100, Peter Maydell wrote: > > > > Well, ID regs are special in the ar

[PATCH v2 04/10] target/arm: Make the t32 insn[25:23]=111 group non-overlapping

2020-10-19 Thread Peter Maydell
The t32 decode has a group which represents a set of insns which overlap with B_cond_thumb because they have [25:23]=111 (which is an invalid condition code field for the branch insn). This group is currently defined using the {} overlap-OK syntax, but it is almost entirely non-overlapping patterns

[PATCH v2 09/10] target/arm: Allow M-profile CPUs with FP16 to set FPSCR.FP16

2020-10-19 Thread Peter Maydell
M-profile CPUs with half-precision floating point support should be able to write to FPSCR.FZ16, but an M-profile specific masking of the value at the top of vfp_set_fpscr() currently prevents that. This is not yet an active bug because we have no M-profile FP16 CPUs, but needs to be fixed before w

[PATCH v2 03/10] target/arm: Implement v8.1M conditional-select insns

2020-10-19 Thread Peter Maydell
v8.1M brings four new insns to M-profile: * CSEL : Rd = cond ? Rn : Rm * CSINC : Rd = cond ? Rn : Rm+1 * CSINV : Rd = cond ? Rn : ~Rm * CSNEG : Rd = cond ? Rn : -Rm Implement these. Reviewed-by: Richard Henderson Signed-off-by: Peter Maydell --- target/arm/t32.decode | 3 +++ target/arm

[PATCH v2 00/10] target/arm: Various v8.1M minor features

2020-10-19 Thread Peter Maydell
This patchseries implements various minor v8.1M new features, notably the branch-future and low-overhead-loop extensions. (None of this will get enabled until we have enough to implement a CPU model which has v8.1M, which will be the Cortex-M55, but as usual we can get stuff into the tree graduall

[PATCH v2 02/10] target/arm: Implement v8.1M NOCP handling

2020-10-19 Thread Peter Maydell
>From v8.1M, disabled-coprocessor handling changes slightly: * coprocessors 8, 9, 14 and 15 are also governed by the cp10 enable bit, like cp11 * an extra range of instruction patterns is considered to be inside the coprocessor space We previously marked these up with TODO comments; implem

[PATCH v2 07/10] target/arm: Implement v8.1M low-overhead-loop instructions

2020-10-19 Thread Peter Maydell
v8.1M's "low-overhead-loop" extension has three instructions for looping: * DLS (start of a do-loop) * WLS (start of a while-loop) * LE (end of a loop) The loop-start instructions are both simple operations to start a loop whose iteration count (if any) is in LR. The loop-end instruction handl

[PATCH v2 06/10] target/arm: Implement v8.1M branch-future insns (as NOPs)

2020-10-19 Thread Peter Maydell
v8.1M implements a new 'branch future' feature, which is a set of instructions that request the CPU to perform a branch "in the future", when it reaches a particular execution address. In hardware, the expected implementation is that the information about the branch location and destination is cach

[PATCH v2 05/10] target/arm: Don't allow BLX imm for M-profile

2020-10-19 Thread Peter Maydell
The BLX immediate insn in the Thumb encoding always performs a switch from Thumb to Arm state. This would be totally useless in M-profile which has no Arm decoder, and so the instruction does not exist at all there. Make the encoding UNDEF for M-profile. (This part of the encoding space is used fo

Re: [PATCH v3 0/3] tcg-cpus: split into 3 tcg variants

2020-10-19 Thread Richard Henderson
On 10/15/20 7:32 AM, Claudio Fontana wrote: > Claudio Fontana (3): > accel/tcg: split CpusAccel into three TCG variants > accel/tcg: split tcg_start_vcpu_thread > accel/tcg: rename tcg-cpus functions to match module name Reviewed-by: Richard Henderson r~

[PATCH v2 01/10] decodetree: Fix codegen for non-overlapping group inside overlapping group

2020-10-19 Thread Peter Maydell
For nested groups like: { [ pattern 1 pattern 2 ] pattern 3 } the intended behaviour is that patterns 1 and 2 must not overlap with each other; if the insn matches neither then we fall through to pattern 3 as the next thing in the outer overlapping group. Currently we

Re: Kernel patch cases qemu live migration failed.

2020-10-19 Thread Dave Martin
On Mon, Oct 19, 2020 at 03:18:11PM +0100, Peter Maydell wrote: > On Mon, 19 Oct 2020 at 14:40, Andrew Jones wrote: > > > > On Mon, Oct 19, 2020 at 12:43:33PM +0100, Peter Maydell wrote: > > > Well, ID regs are special in the architecture -- they always exist > > > and must RAZ/WI, even if they're

Re: [PATCH] drivers/virt: vmgenid: add vm generation id driver

2020-10-19 Thread Michael S. Tsirkin
On Sun, Oct 18, 2020 at 09:14:00AM -0700, Andy Lutomirski wrote: > On Sun, Oct 18, 2020 at 8:59 AM Michael S. Tsirkin wrote: > > > > On Sun, Oct 18, 2020 at 08:54:36AM -0700, Andy Lutomirski wrote: > > > On Sun, Oct 18, 2020 at 8:52 AM Michael S. Tsirkin > > > wrote: > > > > > > > > On Sat, Oct

Re: [PULL v3 0/6] 9p queue (previous 2020-10-17)

2020-10-19 Thread Peter Maydell
On Mon, 19 Oct 2020 at 13:55, Christian Schoenebeck wrote: > > The following changes since commit ba2a9a9e6318bfd93a2306dec40137e198205b86: > > Merge remote-tracking branch 'remotes/mcayland/tags/qemu-macppc-20201019' > into staging (2020-10-19 11:46:03 +0100) >

Re: [PATCH v5] sev: add sev-inject-launch-secret

2020-10-19 Thread Eduardo Habkost
On Thu, Oct 15, 2020 at 10:37:13AM -0400, to...@linux.ibm.com wrote: > From: Tobin Feldman-Fitzthum > > AMD SEV allows a guest owner to inject a secret blob > into the memory of a virtual machine. The secret is > encrypted with the SEV Transport Encryption Key and > integrity is guaranteed with t

[PATCH] x86/kvm: Reserve KVM_FEATURE_MSI_EXT_DEST_ID

2020-10-19 Thread David Woodhouse
From: David Woodhouse No functional change; just reserve the feature bit for now so that VMMs can start to implement it. This will allow the host to indicate that MSI emulation supports 15-bit destination IDs, allowing up to 32768 CPUs without interrupt remapping. cf. https://patchwork.kernel.o

Re: [PATCH] hw/arm/nseries: Fix loading kernel image on n8x0 machines

2020-10-19 Thread Richard Henderson
On 10/19/20 2:51 AM, Philippe Mathieu-Daudé wrote: > Commit 7998beb9c2e removed the ram_size initialization in the > arm_boot_info structure, however it is used by arm_load_kernel(). > > Initialize the field to fix: > > $ qemu-system-arm -M n800 -append 'console=ttyS1' \ > -kernel meego-arm

Re: [PATCH 1/30] cryptodev: Fix Lesser GPL version number

2020-10-19 Thread Thomas Huth
On 14/10/2020 15.37, Chetan Pant wrote: > There is no "version 2" of the "Lesser" General Public License. > It is either "GPL version 2.0" or "Lesser GPL version 2.1". > This patch replaces all occurrences of "Lesser GPL version 2" with > "Lesser GPL version 2.1" in comment section. > > Signed-off

Re: [PATCH 1/2] travis: Check if docs can be built with multiple Sphinx versions

2020-10-19 Thread Daniel P . Berrangé
On Mon, Oct 19, 2020 at 10:31:08AM -0400, Eduardo Habkost wrote: > Add new jobs to .travis.yml to test if docs can be built with > multiple Sphinx versions: 1.6.1, latest 1.x, 2.0.0, and latest > 2.x. > > Signed-off-by: Eduardo Habkost > --- > .travis.yml | 37 +++

[PATCH 2/2] scripts: fix error from checkpatch.pl when no commits are found

2020-10-19 Thread Daniel P . Berrangé
The error message was supposed to mention the input revision list start point, not the branch flag. Signed-off-by: Daniel P. Berrangé --- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 6ed34970f9..88c8

Re: [PATCH] hw/pci-host/grackle: Verify PIC link is properly set

2020-10-19 Thread Mark Cave-Ayland
On 19/10/2020 15:00, Markus Armbruster wrote: BALATON Zoltan via writes: On Mon, 19 Oct 2020, Markus Armbruster wrote: Philippe Mathieu-Daudé writes: On 10/12/20 1:50 PM, BALATON Zoltan via wrote: On Mon, 12 Oct 2020, David Gibson wrote: On Mon, Oct 12, 2020 at 08:21:41AM +0200, Philippe

[PATCH 1/2] gitlab: skip checkpatch.pl checks if no commit delta on branch

2020-10-19 Thread Daniel P . Berrangé
If the current branch is synced to the current upstream git master, there are no commits that need checking. This causes checkpatch.pl to print an error that it found no commits. We need to avoid calling checkpatch.pl in this case. Signed-off-by: Daniel P. Berrangé --- .gitlab-ci.d/check-patch.p

[PATCH 2/2] travis: Remove docs from "tools and docs" job

2020-10-19 Thread Eduardo Habkost
We have other jobs that will test documentation builds, so we don't need to build docs in that job. Signed-off-by: Eduardo Habkost --- .travis.yml | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/.travis.yml b/.travis.yml index f5208301d6..626b61b077 100644 --- a/.travi

[PATCH 0/2] gitlab: minor fixes for checkpatch CI job

2020-10-19 Thread Daniel P . Berrangé
This fixes a bogus error when pushing a branch whose content has no delta against upstream git master. Daniel P. Berrangé (2): gitlab: skip checkpatch.pl checks if no commit delta on branch scripts: fix error from checkpatch.pl when no commits are found .gitlab-ci.d/check-patch.py | 8 ++

Re: [PULL 00/34] QAPI patches patches for 2020-10-10

2020-10-19 Thread John Snow
On 10/18/20 3:29 AM, Philippe Mathieu-Daudé wrote: On 10/10/20 11:54 AM, Markus Armbruster wrote: The following changes since commit 4a7c0bd9dcb08798c6f82e55b5a3423f7ee669f1:    Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-5.2-20201009' into staging (2020-10-09 15:48:04 +0100)

[PATCH 1/2] travis: Check if docs can be built with multiple Sphinx versions

2020-10-19 Thread Eduardo Habkost
Add new jobs to .travis.yml to test if docs can be built with multiple Sphinx versions: 1.6.1, latest 1.x, 2.0.0, and latest 2.x. Signed-off-by: Eduardo Habkost --- .travis.yml | 37 + 1 file changed, 37 insertions(+) diff --git a/.travis.yml b/.travis.yml in

[Bug 1900155] Re: MIPS Malta fails booting due to IDE error

2020-10-19 Thread John Snow
Yup. Mark Cave-Ayland pointed this out to me. I have a patch ready for it: diff --git a/hw/ide/core.c b/hw/ide/core.c index 693b352d5e..98cea7ad45 100644 --- a/hw/ide/core.c +++ b/hw/ide/core.c @@ -2254,10 +2254,8 @@ static void ide_perform_srst(IDEState *s) /* Cancel PIO callback, reset reg

Re: [PATCH] microbit_i2c: Fix coredump when dump-vmstate

2020-10-19 Thread Peng Liang
On 10/19/2020 6:35 PM, Philippe Mathieu-Daudé wrote: > On 10/19/20 11:34 AM, Peng Liang wrote: >> VMStateDescription.fields should be end with VMSTATE_END_OF_LIST(). >> However, microbit_i2c_vmstate doesn't follow it.  Let's change it. > > It might be easy to add a Coccinelle script to avoid futur

Re: [PATCH v3 0/3] target/arm: Implement an IMPDEF pauth algorithm

2020-10-19 Thread Mark Rutland
Hi Richard, Thanks again for this, and sorry for the radiosilence -- I broke my arm the weekend this was sent, and once I had recovered enough to use a computer again this had slipped off my TODO list. I've just given this a go, applied atop of this morning's HEAD commit (ba2a9a9e6318bfd93a2306de

[PATCH] virtio-iommu: fix incorrect print type

2020-10-19 Thread Zhengui li
The type of input variable is unsigned int while the printer type is int. So fix incorrect print type. Signed-off-by: Zhengui li --- hw/virtio/virtio-iommu.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/virtio/virtio-iommu.c b/hw/virtio/virtio-iommu.c index 21ec63

[PATCH] vfio: fix incorrect print type

2020-10-19 Thread Zhengui li
The type of input variable is unsigned int while the printer type is int. So fix incorrect print type. Signed-off-by: Zhengui li --- hw/vfio/common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/vfio/common.c b/hw/vfio/common.c index 13471ae..acc3356 100644 --- a/hw

[PATCH] vhost-user: fix incorrect print type

2020-10-19 Thread Zhengui li
The type of input variable is unsigned int while the printer type is int. So fix incorrect print type. Signed-off-by: Zhengui li --- hw/virtio/vhost-user.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c index 9c5b4f7

[PATCH] virtio-gpu: fix incorrect print type

2020-10-19 Thread Zhengui li
The type of input variable is unsigned int while the printer type is int. So fix incorrect print type. Signed-off-by: Zhengui li --- hw/display/virtio-gpu.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/hw/display/virtio-gpu.c b/hw/display

[PATCH] vhost-user-scsi: fix incorrect print type

2020-10-19 Thread Zhengui li
The type of input variable is unsigned int while the printer type is int. So fix incorrect print type. Signed-off-by: Zhengui li --- contrib/vhost-user-scsi/vhost-user-scsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/vhost-user-scsi/vhost-user-scsi.c b/contrib/

[PATCH] vhost-user-gpu: fix incorrect print type

2020-10-19 Thread Zhengui li
The type of input variable is unsigned int while the printer type is int. So fix incorrect print type. Signed-off-by: Zhengui li --- contrib/vhost-user-gpu/vhost-user-gpu.c | 34 - 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/contrib/vhost-user-

Re: Kernel patch cases qemu live migration failed.

2020-10-19 Thread Peter Maydell
On Mon, 19 Oct 2020 at 14:40, Andrew Jones wrote: > > On Mon, Oct 19, 2020 at 12:43:33PM +0100, Peter Maydell wrote: > > Well, ID regs are special in the architecture -- they always exist > > and must RAZ/WI, even if they're not actually given any fields yet. > > This is different from other "unus

[Bug 1414466] Re: -net user, hostfwd=... is not working(qemu-system-aarch64)

2020-10-19 Thread srinivasan magudeeswaran
Is this issue resolved.? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1414466 Title: -net user,hostfwd=... is not working(qemu-system-aarch64) Status in QEMU: Confirmed Bug description: QEMU

Re: [PATCH] hw/pci-host/grackle: Verify PIC link is properly set

2020-10-19 Thread Markus Armbruster
BALATON Zoltan via writes: > On Mon, 19 Oct 2020, Markus Armbruster wrote: >> Philippe Mathieu-Daudé writes: >>> On 10/12/20 1:50 PM, BALATON Zoltan via wrote: On Mon, 12 Oct 2020, David Gibson wrote: > On Mon, Oct 12, 2020 at 08:21:41AM +0200, Philippe > Mathieu-Daudé wrote:

Re: [PATCH 8/30] powerpc tcg: Fix Lesser GPL version number

2020-10-19 Thread Chetan
Hello, On Mon, Oct 19, 2020 at 4:13 PM Daniel P. Berrangé wrote: >This subject line says 8/30, but I've never received patches >9->30, and I don't see them in the mailing list archive >either... I'm working on the rest of the patches and will be pushing them before the end of this week. Please

Re: [PATCH] target/i386: Support up to 32768 CPUs without IRQ remapping

2020-10-19 Thread Paolo Bonzini
On 19/10/20 14:21, David Woodhouse wrote: > On Thu, 2020-10-08 at 09:53 +0200, Paolo Bonzini wrote: >> I think you're not >> handling that correctly for CPUs >255, so after all we _do_ need some >> kernel support. > > I think that works out OK. > > In QEMU's ioapic_update_kvm_routes() it calls io

Re: [PATCH] vfio: fix incorrect print type

2020-10-19 Thread Alex Williamson
On Mon, 19 Oct 2020 13:32:17 + Zhengui li wrote: > fix incorrect print type. Why is it incorrect, describe your change. Patches must include a Signed-off-by to adhere to the developer's certificate of origin. Thanks, Alex > --- > hw/vfio/common.c | 4 ++-- > 1 file changed, 2 insertions(

Re: [PATCH] vfio: fix incorrect print type

2020-10-19 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1603114337-28056-1-git-send-email-lizhen...@huawei.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1603114337-28056-1-git-send-email-lizhen...@huawei.com Subject: [PATCH] vfio:

Re: Kernel patch cases qemu live migration failed.

2020-10-19 Thread Andrew Jones
On Mon, Oct 19, 2020 at 12:43:33PM +0100, Peter Maydell wrote: > On Mon, 19 Oct 2020 at 12:32, Dave Martin wrote: > > I'm not quite sure about Peter's assessment here. > > > > I agree with the inconsistency identified here: we always enumerate all > > unallocated ID regs, but we enumerate ID_AA64Z

Re: [PATCH] virtio-iommu: fix incorrect print type

2020-10-19 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1603114311-7392-1-git-send-email-lizhen...@huawei.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1603114311-7392-1-git-send-email-lizhen...@huawei.com Subject: [PATCH] virtio-

Re: [PATCH] virtio-gpu: fix incorrect print type

2020-10-19 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1603114292-10332-1-git-send-email-lizhen...@huawei.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1603114292-10332-1-git-send-email-lizhen...@huawei.com Subject: [PATCH] virti

Re: [PULL 0/3] Usb 20201019 patches

2020-10-19 Thread Peter Maydell
available in the Git repository at: > > git://git.kraxel.org/qemu tags/usb-20201019-pull-request > > for you to fetch changes up to bea2a9e3e00b275dc40cfa09c760c715b8753e03: > > hw/usb/hcd-dwc2: fix divide-by-zero in d

Re: [PATCH] vhost-user-scsi: fix incorrect print type

2020-10-19 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1603114225-22628-1-git-send-email-lizhen...@huawei.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1603114225-22628-1-git-send-email-lizhen...@huawei.com Subject: [PATCH] vhost

Re: [PATCH] vhost-user-gpu: incorrect print type

2020-10-19 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1603114196-22776-1-git-send-email-lizhen...@huawei.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1603114196-22776-1-git-send-email-lizhen...@huawei.com Subject: [PATCH] vhost

Re: [PATCH] vhost-user: fix incorrect print type

2020-10-19 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1603114272-25004-1-git-send-email-lizhen...@huawei.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1603114272-25004-1-git-send-email-lizhen...@huawei.com Subject: [PATCH] vhost

[PATCH] vfio: fix incorrect print type

2020-10-19 Thread Zhengui li
fix incorrect print type. --- hw/vfio/common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/vfio/common.c b/hw/vfio/common.c index 13471ae..acc3356 100644 --- a/hw/vfio/common.c +++ b/hw/vfio/common.c @@ -203,7 +203,7 @@ void vfio_region_write(void *opaque, hwaddr add

[PATCH] virtio-gpu: fix incorrect print type

2020-10-19 Thread Zhengui li
fix incorrect print type. --- hw/display/virtio-gpu.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c index 90be4e3..d785d88 100644 --- a/hw/display/virtio-gpu.c +++ b/hw/display/virtio-gpu.c @

[PATCH] virtio-iommu: fix incorrect print type

2020-10-19 Thread Zhengui li
fix incorrect print type. --- hw/virtio/virtio-iommu.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/virtio/virtio-iommu.c b/hw/virtio/virtio-iommu.c index 21ec63b..bd6ce44 100644 --- a/hw/virtio/virtio-iommu.c +++ b/hw/virtio/virtio-iommu.c @@ -632,7 +632,7 @@ stati

[PATCH] vhost-user-scsi: fix incorrect print type

2020-10-19 Thread Zhengui li
fix incorrect print type. --- contrib/vhost-user-scsi/vhost-user-scsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/vhost-user-scsi/vhost-user-scsi.c b/contrib/vhost-user-scsi/vhost-user-scsi.c index 3c91238..1527ffd 100644 --- a/contrib/vhost-user-scsi/vhost-user-

[PATCH] vhost-user: fix incorrect print type

2020-10-19 Thread Zhengui li
fix incorrect print type. --- hw/virtio/vhost-user.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c index 9c5b4f7..db563bd 100644 --- a/hw/virtio/vhost-user.c +++ b/hw/virtio/vhost-user.c @@ -308,7 +308,7 @@ static int

[PATCH] vhost-user-gpu: incorrect print type

2020-10-19 Thread Zhengui li
fix incorrect print type. --- contrib/vhost-user-gpu/vhost-user-gpu.c | 34 - 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/contrib/vhost-user-gpu/vhost-user-gpu.c b/contrib/vhost-user-gpu/vhost-user-gpu.c index a019d0a..ee2bf59 100644 --- a/contr

Re: [PATCH] configure: Test that gio libs from pkg-config work

2020-10-19 Thread Paolo Bonzini
On 19/10/20 13:16, Peter Maydell wrote: > On Mon, 28 Sep 2020 at 17:42, Paolo Bonzini wrote: >> >> On 28/09/20 18:04, Peter Maydell wrote: >>> I wanted a statically-linked system emulation binary (which, yes, >>> I know is not really something we support :-)). I got one with >>> suitably liberal u

Re: [PATCH v1 0/2] Add timeout mechanism to qmp actions

2020-10-19 Thread Paolo Bonzini
On 19/10/20 14:40, Zhenyu Ye wrote: > The kernel backtrace for io_submit in GUEST is: > > guest# ./offcputime -K -p `pgrep -nx fio` > b'finish_task_switch' > b'__schedule' > b'schedule' > b'io_schedule' > b'blk_mq_get_tag' > b'blk_m

[Bug 1900352] Re: no sound in spice when VNC enabled

2020-10-19 Thread Daniel Berrange
If VNC is enabled, then libvirt sets QEMU_AUDIO_DRV=none unless /etc/libvirt/qemu.conf is set to allow output to host audio. Clearly this doesn't do the right thing when SPICE is present at the same time as VNC, but that's libvirt's fault rather than QEMU. -- You received this bug notification b

[PULL v3 5/6] tests/9pfs: add virtio_9p_test_path()

2020-10-19 Thread Christian Schoenebeck
This new public function virtio_9p_test_path() allows 9pfs 'local' tests to translate a path from guest scope to host scope. For instance by passing an empty string it would return the root path on host of the exported 9pfs tree. Signed-off-by: Christian Schoenebeck Message-Id: Signed-off-by: C

Re: [PATCH v3 12/13] block/qcow2: simplify qcow2_co_invalidate_cache()

2020-10-19 Thread Kevin Wolf
Am 16.10.2020 um 19:10 hat Vladimir Sementsov-Ogievskiy geschrieben: > qcow2_do_open correctly sets errp on each failure path. So, we can > simplify code in qcow2_co_invalidate_cache() and drop explicit error > propagation. qcow2_update_options_prepare() can return -EINVAL without setting errp:

[PULL v3 4/6] tests/9pfs: wipe local 9pfs test directory

2020-10-19 Thread Christian Schoenebeck
Before running the first 9pfs test case, make sure the test directory for running the 9pfs 'local' tests on is entirely empty. For that reason simply delete the test directory (if any) before (re)creating it on test suite startup. Note: The preferable precise behaviour would be the test directory

Re: [PATCH v4 0/3] unbreak non-tcg builds

2020-10-19 Thread Paolo Bonzini
On 19/10/20 12:11, Claudio Fontana wrote: > Hi all, > > anything more for me to do here? I think nothing, I picked up patch 1 due to conflicts but I was waiting for comments from Richard. I have now picked them up. Paolo > On 10/13/20 9:21 PM, Claudio Fontana wrote: >> This series now unbreaks

[PULL v3 3/6] tests/9pfs: introduce local tests

2020-10-19 Thread Christian Schoenebeck
This patch introduces 9pfs test cases using the 9pfs 'local' filesystem driver which reads/writes/creates/deletes real files and directories. In this initial version, there is only one local test which actually only checks if the 9pfs 'local' device was created successfully. Before the 9pfs 'loca

[Bug 1900352] Re: no sound in spice when VNC enabled

2020-10-19 Thread Gerd Hoffmann
What is in the libvirt logs (/var/log/libvirt/qemu/${guest}.log) ? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1900352 Title: no sound in spice when VNC enabled Status in QEMU: New Bug descri

[PULL v3 6/6] tests/9pfs: add local Tmkdir test

2020-10-19 Thread Christian Schoenebeck
This test case uses the 9pfs 'local' driver to create a directory and then checks if the expected directory was actually created (as real directory) on host side. This patch introduces a custom split() implementation, because the test code requires non empty array elements as result. For that reas

[PULL v3 1/6] 9pfs: suppress performance warnings on qtest runs

2020-10-19 Thread Christian Schoenebeck
Don't trigger any performance warning if we're just running test cases, because tests intentionally run for edge cases. So far performance warnings were suppressed for the 'synth' fs driver backend only. This patch suppresses them for all 9p fs driver backends. Signed-off-by: Christian Schoenebec

[PULL v3 2/6] tests/9pfs: change qtest name prefix to synth

2020-10-19 Thread Christian Schoenebeck
All existing 9pfs test cases are using the 'synth' fs driver so far, which means they are not accessing real files, but a purely simulated (in RAM only) file system. Let's make this clear by changing the prefix of the individual qtest case names from 'fs/' to 'synth/'. That way they'll be easily d

[PULL v3 0/6] 9p queue (previous 2020-10-17)

2020-10-19 Thread Christian Schoenebeck
The following changes since commit ba2a9a9e6318bfd93a2306dec40137e198205b86: Merge remote-tracking branch 'remotes/mcayland/tags/qemu-macppc-20201019' into staging (2020-10-19 11:46:03 +0100) are available in the Git repository at: https://github.com/cschoenebeck/qemu.git ta

Re: io: Don't use '#' flag of printf format

2020-10-19 Thread Philippe Mathieu-Daudé
On 10/19/20 2:12 PM, AlexChen wrote: Signed-off-by: AlexChen --- io/channel-websock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/io/channel-websock.c b/io/channel-websock.c index 47a0e941d9..e94a1fcf99 100644 --- a/io/channel-websock.c +++ b/io/channel-websock.c @@ -7

Re: [PATCH v1 0/2] Add timeout mechanism to qmp actions

2020-10-19 Thread Zhenyu Ye
Hi Stefan, On 2020/10/13 18:00, Stefan Hajnoczi wrote: > > Sorry, I lost track of this on-going email thread. > > Thanks for the backtrace. It shows the io_submit call is done while the > AioContext lock is held. The monitor thread is waiting for the > IOThread's AioContext lock. vcpus threads c

Re: [PATCH 1/1] 9pfs: suppress performance warnings on qtest runs

2020-10-19 Thread Greg Kurz
On Mon, 19 Oct 2020 14:12:46 +0200 Christian Schoenebeck wrote: > On Montag, 19. Oktober 2020 13:48:22 CEST Greg Kurz wrote: > > On Mon, 19 Oct 2020 13:10:18 +0200 > > > > Christian Schoenebeck wrote: > > > Don't trigger any performance warning if we're just running test cases, > > > because te

Re: [PATCH v7 05/11] hw/block/nvme: Support Zoned Namespace Command Set

2020-10-19 Thread Klaus Jensen
On Oct 19 11:17, Dmitry Fomichev wrote: > diff --git a/hw/block/nvme-ns.h b/hw/block/nvme-ns.h > index d6b2808b97..170cbb8cdc 100644 > --- a/hw/block/nvme-ns.h > +++ b/hw/block/nvme-ns.h > @@ -34,6 +45,18 @@ typedef struct NvmeNamespace { > const uint32_t *iocs; > uint8_t csi; > >

Re: [PATCH 8/30] powerpc tcg: Fix Lesser GPL version number

2020-10-19 Thread Thomas Huth
On 19/10/2020 08.11, Chetan Pant wrote: > There is no "version 2" of the "Lesser" General Public License. > It is either "GPL version 2.0" or "Lesser GPL version 2.1". > This patch replaces all occurrences of "Lesser GPL version 2" with > "Lesser GPL version 2.1" in comment section. > > Signed-off

[PULL 3/3] hw/usb/hcd-dwc2: fix divide-by-zero in dwc2_handle_packet()

2020-10-19 Thread Gerd Hoffmann
From: Mauro Matteo Cascella Check the value of mps to avoid potential divide-by-zero later in the function. Since HCCHAR_MPS is guest controllable, this prevents a malicious/buggy guest from crashing the QEMU process on the host. Signed-off-by: Mauro Matteo Cascella Reviewed-by: Paul Zimmerman

[PULL 0/3] Usb 20201019 patches

2020-10-19 Thread Gerd Hoffmann
The following changes since commit e12ce85b2c79d83a340953291912875c30b3af06: Merge remote-tracking branch 'remotes/ehabkost/tags/x86-next-pull-request' into staging (2020-10-16 22:46:28 +0100) are available in the Git repository at: git://git.kraxel.org/qemu tags/usb-20201019-pu

[PULL 2/3] usb/hcd-ehci: Fix error handling on missing device for iTD

2020-10-19 Thread Gerd Hoffmann
From: Anthony PERARD The EHCI Host Controller emulation attempt to locate the device associated with a periodic isochronous transfer description (iTD) and when this fail the host controller is reset. But according the EHCI spec 1.0 section 5.15.2.4 Host System Error, the host controller is suppo

[PULL 1/3] usb: hcd-dwc2: change assert()s to qemu_log_mask(LOG_GUEST_ERROR...)

2020-10-19 Thread Gerd Hoffmann
From: Paul Zimmerman Change several assert()s to qemu_log_mask(LOG_GUEST_ERROR...), to prevent the guest from causing Qemu to assert. Also fix up several existing qemu_log_mask()s to include the function name in the message. Suggested-by: Peter Maydell Signed-off-by: Paul Zimmerman Message-id:

Re: [PATCH v2 0/5] qapi: Restrict machine (and migration) specific commands

2020-10-19 Thread Eduardo Habkost
On Mon, Oct 19, 2020 at 09:55:20AM +0200, Markus Armbruster wrote: > Eduardo Habkost writes: > > > On Mon, Oct 12, 2020 at 02:15:31PM +0200, Philippe Mathieu-Daudé wrote: > >> Reduce the machine code pulled into qemu-storage-daemon. > >> > >> The series is fully Acked, but Markus wants it review

Re: [PATCH] target/i386: Support up to 32768 CPUs without IRQ remapping

2020-10-19 Thread David Woodhouse
On Thu, 2020-10-08 at 09:53 +0200, Paolo Bonzini wrote: > Indeed the nice thing about irqchip=split is that the handling of device > interrupts is entirely confined within QEMU, no matter if they're IOAPIC > or MSI. And because we had to implement interrupt remapping, the IOAPIC > is effectively u

Re: io: Don't use '#' flag of printf format

2020-10-19 Thread Daniel P . Berrangé
On Mon, Oct 19, 2020 at 08:12:02PM +0800, AlexChen wrote: > Signed-off-by: AlexChen > --- > io/channel-websock.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/io/channel-websock.c b/io/channel-websock.c > index 47a0e941d9..e94a1fcf99 100644 > --- a/io/channel-websock.c

Re: [PATCH v3 02/13] block: use return status of bdrv_append()

2020-10-19 Thread Kevin Wolf
Am 16.10.2020 um 19:10 hat Vladimir Sementsov-Ogievskiy geschrieben: > Now bdrv_append returns status and we can drop all the local_err things > around it. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Reviewed-by: Greg Kurz > Reviewed-by: Alberto Garcia > --- > block.c

Re: [PATCH 1/1] 9pfs: suppress performance warnings on qtest runs

2020-10-19 Thread Christian Schoenebeck
On Montag, 19. Oktober 2020 13:48:22 CEST Greg Kurz wrote: > On Mon, 19 Oct 2020 13:10:18 +0200 > > Christian Schoenebeck wrote: > > Don't trigger any performance warning if we're just running test cases, > > because tests intentionally run for edge cases. > > > > So far performance warnings wer

io: Don't use '#' flag of printf format

2020-10-19 Thread AlexChen
Signed-off-by: AlexChen --- io/channel-websock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/io/channel-websock.c b/io/channel-websock.c index 47a0e941d9..e94a1fcf99 100644 --- a/io/channel-websock.c +++ b/io/channel-websock.c @@ -746,7 +746,7 @@ static int qio_channel_we

Re: [PATCH v2 3/8] migration: Add spaces around operator

2020-10-19 Thread Markus Armbruster
Bihong Yu writes: > Yes, I used to think "const VMStateDescription *[]" was right, but when I > search > similar expressions, most of all are "xxx * []". Such as: > fsdev/qemu-fsdev.c:54:.opts = (const char * []) > hw/intc/s390_flic_kvm.c:567:.subsections = (const VMStateDescription

Re: [PATCH] do not use colons in test names

2020-10-19 Thread Philippe Mathieu-Daudé
On 10/19/20 1:41 PM, Paolo Bonzini wrote: Starting with meson 0.56, colons are used to separate the subproject name from the test name. Use dash or slash depending on what looks nicer. Signed-off-by: Paolo Bonzini Reviewed-by: Philippe Mathieu-Daudé --- tests/fp/meson.build| 4 ++--

Re: [PATCH v3 01/13] block: return status from bdrv_append and friends

2020-10-19 Thread Kevin Wolf
Am 16.10.2020 um 19:10 hat Vladimir Sementsov-Ogievskiy geschrieben: > The recommended use of qemu error api assumes returning status together > with setting errp and avoid void functions with errp parameter. Let's > improve bdrv_append and some friends to reduce error-propagation > overhead in fur

Re: [PATCH 1/1] 9pfs: suppress performance warnings on qtest runs

2020-10-19 Thread Greg Kurz
On Mon, 19 Oct 2020 13:10:18 +0200 Christian Schoenebeck wrote: > Don't trigger any performance warning if we're just running test cases, > because tests intentionally run for edge cases. > > So far performance warnings were suppressed for the 'synth' fs driver > backend only. This patch suppres

Re: [PATCH] qemu-img: add support for rate limit in qemu-img convert

2020-10-19 Thread Alberto Garcia
On Sun 18 Oct 2020 08:34:39 AM CEST, Zhengui li wrote: > @@ -2729,6 +2757,10 @@ out: > qemu_opts_del(opts); > qemu_opts_free(create_opts); > qemu_opts_del(sn_opts); > +if (s.target && rate_limit && > +blk_get_public(s.target)->throttle_group_member.throttle_state) { > +

Re: [PATCH v2 6/9] tcg: implement mirror mapped JIT for iOS

2020-10-19 Thread BALATON Zoltan via
On Sun, 18 Oct 2020, Joelle van Dyne wrote: From: osy On iOS, we cannot allocate RWX pages without special entitlements. As a workaround, we can allocate a RX region and then mirror map it to a separate RX region. Then we can write to one region and execute from the other one. We also define `

Re: Kernel patch cases qemu live migration failed.

2020-10-19 Thread Peter Maydell
On Mon, 19 Oct 2020 at 12:32, Dave Martin wrote: > I'm not quite sure about Peter's assessment here. > > I agree with the inconsistency identified here: we always enumerate all > unallocated ID regs, but we enumerate ID_AA64ZFR0_EL1 conditionally. > This doesn't feel right: on a non-SVE guest, ID_

Re: [PATCH v7 08/11] hw/block/nvme: Add injection of Offline/Read-Only zones

2020-10-19 Thread Klaus Jensen
On Oct 19 11:17, Dmitry Fomichev wrote: > ZNS specification defines two zone conditions for the zones that no > longer can function properly, possibly because of flash wear or other > internal fault. It is useful to be able to "inject" a small number of > such zones for testing purposes. > > This

[PATCH] meson: use b_staticpic=false for meson >=0.56.0

2020-10-19 Thread Paolo Bonzini
Meson 0.56.0 correctly builds non-PIC static libraries with -fPIE if b_pie=true. We do not have to pass b_staticpic=true if PIE is requested if Meson is new-enough, which improves performance. Signed-off-by: Paolo Bonzini --- configure | 6 +- meson.build | 4 ++-- 2 files changed, 7 inse

[PATCH] do not use colons in test names

2020-10-19 Thread Paolo Bonzini
Starting with meson 0.56, colons are used to separate the subproject name from the test name. Use dash or slash depending on what looks nicer. Signed-off-by: Paolo Bonzini --- tests/fp/meson.build| 4 ++-- tests/qtest/meson.build | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) dif

Re: Kernel patch cases qemu live migration failed.

2020-10-19 Thread Dave Martin
On Mon, Oct 19, 2020 at 11:25:25AM +0200, Andrew Jones wrote: > On Thu, Oct 15, 2020 at 03:57:02PM +0100, Peter Maydell wrote: > > On Thu, 15 Oct 2020 at 15:41, Andrew Jones wrote: > > > The reporter states neither the source nor destination hardware supports > > > SVE. My guess is that what's hap

[PATCH 1/1] 9pfs: suppress performance warnings on qtest runs

2020-10-19 Thread Christian Schoenebeck
Don't trigger any performance warning if we're just running test cases, because tests intentionally run for edge cases. So far performance warnings were suppressed for the 'synth' fs driver backend only. This patch suppresses them for all 9p fs driver backends. Signed-off-by: Christian Schoenebec

[PATCH] hw/block/nvme: fix prp mapping status codes

2020-10-19 Thread Klaus Jensen
From: Gollu Appalanaidu Differentiate between missing PRPs and misaligned PRPs, return the relevant status code and streamline the trace event naming. See NVMe Express v1.3d, Section 4.3 ("Physical Region Page Entry and List"). Signed-off-by: Gollu Appalanaidu Signed-off-by: Klaus Jensen ---

<    1   2   3   4   5   >