Re: [PATCH] qtest: Fix bad printf format specifiers

2020-11-08 Thread Markus Armbruster
Thomas Huth writes: > On 06/11/2020 15.18, Philippe Mathieu-Daudé wrote: >> On 11/6/20 7:33 AM, Markus Armbruster wrote: >>> Thomas Huth writes: >>> On 05/11/2020 06.14, AlexChen wrote: > On 2020/11/4 18:44, Thomas Huth wrote: >> On 04/11/2020 11.23, AlexChen wrote: >>> We

Re: [PATCH v2 4/7] block: add bdrv_refresh_perms() helper

2020-11-08 Thread Vladimir Sementsov-Ogievskiy
06.11.2020 18:14, Alberto Garcia wrote: On Fri 06 Nov 2020 01:42:38 PM CET, Vladimir Sementsov-Ogievskiy wrote: Make separate function for common pattern. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block.c | 60 - 1 file changed,

Re: nbd: bitmap_to_extents() calls nbd_extent_array_add() without checking return value: coverity false positive?

2020-11-08 Thread Vladimir Sementsov-Ogievskiy
07.11.2020 01:53, Peter Maydell wrote: On Fri, 6 Nov 2020 at 20:36, Eric Blake wrote: On 11/6/20 11:22 AM, Peter Maydell wrote: Hi; Coverity's "you usually check the return value of this function but you didn't do that here" heuristic has fired on the code in nbd/server.c:bitmap_to_extents()

[Bug 1902470] Re: migration with TLS-MultiFD is stuck when the dst-libvirtd service restarts

2020-11-08 Thread Chuan Zheng
** Changed in: qemu Status: Confirmed => In Progress -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1902470 Title: migration with TLS-MultiFD is stuck when the dst-libvirtd service

RE: [PATCH] scripts/checkpatch.pl: Modify the line length limit of the code

2020-11-08 Thread ganqixin
> -Original Message- > From: Peter Maydell [mailto:peter.mayd...@linaro.org] > Sent: Saturday, November 7, 2020 12:20 AM > To: Markus Armbruster > Cc: Philippe Mathieu-Daudé ; Daniel P. Berrange > ; Zhanghailiang > ; Michael S. Tsirkin ; > QEMU Trivial ; QEMU Developers > ; ganqixin ;

Re: [PATCH] target/microblaze: Fix possible array out of bounds in mmu_write()

2020-11-08 Thread AlexChen
On 2020/11/6 22:16, Philippe Mathieu-Daudé wrote: > On 11/3/20 8:46 AM, AlexChen wrote: >> The size of env->mmu.regs is 3, but the range of 'rn' is [0, 5]. >> To avoid data access out of bounds, only if 'rn' is less than 3, we >> can print env->mmu.regs[rn]. In other cases, we can print >>

[RFC PATCH v3 13/13] hw/arm/virt-acpi-build: Enable cpu and cache topology

2020-11-08 Thread Ying Fang
A helper struct AcpiCacheOffset is introduced to describe the offset of three level caches. The cache hierarchy is built according to ACPI spec v6.3 5.2.29.2. Let's enable CPU cache topology now. Signed-off-by: Ying Fang --- hw/acpi/aml-build.c | 19 +-

[RFC PATCH v3 03/13] hw/arm/virt: Replace smp_parse with one that prefers cores

2020-11-08 Thread Ying Fang
From: Andrew Jones The virt machine type has never used the CPU topology parameters, other than number of online CPUs and max CPUs. When choosing how to allocate those CPUs the default has been to assume cores. In preparation for using the other CPU topology parameters let's use an smp_parse

[RFC PATCH v3 08/13] hw/acpi/aml-build: add processor hierarchy node structure

2020-11-08 Thread Ying Fang
Add the processor hierarchy node structures to build ACPI information for cpu topology. Three helpers are introduced: (1) build_socket_hierarchy for socket description structure (2) build_processor_hierarchy for processor description structure (3) build_smt_hierarchy for thread (logic processor)

[RFC PATCH v3 11/13] hw/arm/virt: add fdt cache information

2020-11-08 Thread Ying Fang
Support devicetree cpu cache information descriptions Signed-off-by: Ying Fang --- hw/arm/virt.c | 92 +++ 1 file changed, 92 insertions(+) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index b6cebb5549..21275e03c2 100644 --- a/hw/arm/virt.c +++

[RFC PATCH v3 10/13] target/arm/cpu: Add cpu cache description for arm

2020-11-08 Thread Ying Fang
Add the CPUCacheInfo structure to hold cpu cache information for ARM cpus. A classic three level cache topology is used here. The default cache capacity is given and userspace can overwrite these values. Signed-off-by: Ying Fang --- target/arm/cpu.c | 42

[RFC PATCH v3 01/13] hw/arm/virt: Spell out smp.cpus and smp.max_cpus

2020-11-08 Thread Ying Fang
From: Andrew Jones Prefer to spell out the smp.cpus and smp.max_cpus machine state variables in order to make grepping easier and to avoid any confusion as to what cpu count is being used where. Signed-off-by: Andrew Jones --- hw/arm/virt-acpi-build.c | 8 +++ hw/arm/virt.c|

[RFC PATCH v3 07/13] hw/arm/virt-acpi-build: distinguish possible and present cpus

2020-11-08 Thread Ying Fang
When building ACPI tables regarding CPUs we should always build them for the number of possible CPUs, not the number of present CPUs. We then ensure only the present CPUs are enabled in madt. Furthermore, it is also needed if we are going to support CPU hotplug in the future. This patch is a

[RFC PATCH v3 05/13] hw: add compat machines for 5.3

2020-11-08 Thread Ying Fang
Add 5.3 machine types for arm/i440fx/q35/s390x/spapr. Signed-off-by: Ying Fang --- hw/arm/virt.c | 9 - hw/core/machine.c | 3 +++ hw/i386/pc.c | 3 +++ hw/i386/pc_piix.c | 15 ++- hw/i386/pc_q35.c | 14 +-

[RFC PATCH v3 02/13] hw/arm/virt: Remove unused variable

2020-11-08 Thread Ying Fang
From: Andrew Jones We no longer use the smp_cpus virtual machine state variable. Remove it. Signed-off-by: Andrew Jones --- hw/arm/virt.c | 2 -- include/hw/arm/virt.h | 1 - 2 files changed, 3 deletions(-) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 0069fa1298..ea24b576c6

[RFC PATCH v3 09/13] hw/arm/virt-acpi-build: add PPTT table

2020-11-08 Thread Ying Fang
Add the Processor Properties Topology Table (PPTT) to present cpu topology information to the guest. Signed-off-by: Ying Fang --- hw/arm/virt-acpi-build.c | 42 1 file changed, 42 insertions(+) diff --git a/hw/arm/virt-acpi-build.c

[RFC PATCH v3 00/13] hw/arm/virt: Introduce cpu and cache topology support

2020-11-08 Thread Ying Fang
An accurate cpu topology may help improve the cpu scheduler's decision making when dealing with multi-core system. So cpu topology description is helpful to provide guest with the right view. Cpu cache information may also have slight impact on the sched domain, and even userspace software may

[RFC PATCH v3 12/13] hw/acpi/aml-build: Build ACPI cpu cache hierarchy information

2020-11-08 Thread Ying Fang
To build cache information, An AcpiCacheInfo structure is defined to hold the type 1 cache structure according to ACPI spec v6.3 5.2.29.2. A helper function build_cache_hierarchy is also introduced to encode the cache information. Signed-off-by: Ying Fang --- hw/acpi/aml-build.c | 26

[RFC PATCH v3 04/13] device_tree: Add qemu_fdt_add_path

2020-11-08 Thread Ying Fang
From: Andrew Jones qemu_fdt_add_path() works like qemu_fdt_add_subnode(), except it also adds any missing parent nodes. We also tweak an error message of qemu_fdt_add_subnode(). We'll make use of the new function in a coming patch. Signed-off-by: Andrew Jones --- device_tree.c

[RFC PATCH v3 06/13] hw/arm/virt: DT: add cpu-map

2020-11-08 Thread Ying Fang
From: Andrew Jones Support devicetree CPU topology descriptions. Signed-off-by: Andrew Jones Signed-off-by: Ying Fang --- hw/arm/virt.c | 40 +++- include/hw/arm/virt.h | 1 + 2 files changed, 40 insertions(+), 1 deletion(-) diff --git

Re: [PATCH] net/e1000e_core: make sure RDH never exceeds RDT in e1000e_ring_advance()

2020-11-08 Thread Jason Wang
On 2020/11/5 下午6:56, Mauro Matteo Cascella wrote: The e1000e_write_packet_to_guest() function iterates over a set of receive descriptors by advancing rx descriptor head register (RDH) from its initial value to rx descriptor tail register (RDT). The check in e1000e_ring_empty() is responsible

Re: [RFC PATCH 0/6] eBPF RSS support for virtio-net

2020-11-08 Thread Jason Wang
On 2020/11/5 下午11:13, Yuri Benditovich wrote: First of all, thank you for all your feedbacks Please help me to summarize and let us understand better what we do in v2: Major questions are: 1. Building eBPF from source during qemu build vs. regenerating it on demand and keeping in the

[Bug 1903470] [NEW] qemu 5.1.0: Add UNIX socket support for netdev socket

2020-11-08 Thread Mark Karpeles
Public bug reported: Note: this is a feature request. qemu has a way to connect instances using a socket: -netdev socket,id=str[,fd=h][,listen=[host]:port][,connect=host:port] This can also be used to connect a qemu instance to something else using a socket connection, however there is no

[PATCH v5 3/4] hmp: Use QMP query-netdev in hmp_info_network

2020-11-08 Thread Alexey Kirillov
Replace usage of legacy field info_str of NetClientState for backend network devices with result of QMP command query-netdev. NIC and hubports still use legacy info_str field. Signed-off-by: Alexey Kirillov --- include/net/net.h | 3 +- net/clients.h | 1 + net/hub.c | 4 +-

[PATCH v5 1/4] qapi: net: Add query-netdev command

2020-11-08 Thread Alexey Kirillov
Add a qmp command that provides information about currently attached backend network devices and their configuration. Signed-off-by: Alexey Kirillov Acked-by: Markus Armbruster --- include/net/net.h | 1 + net/l2tpv3.c | 19 +++ net/net.c | 32 net/netmap.c

Re: [PATCH v5 4/7] coroutine: add libucontext as external library

2020-11-08 Thread Philippe Mathieu-Daudé
On 11/9/20 12:24 AM, Joelle van Dyne wrote: > iOS does not support ucontext natively for aarch64 and the sigaltstack is > also unsupported (even worse, it fails silently, see: > https://openradar.appspot.com/13002712 ) > > As a workaround we include a library implementation of ucontext and add it

[PATCH v5 4/4] net: Do not use legacy info_str for backends

2020-11-08 Thread Alexey Kirillov
As we use QMP query-netdev to store and get information about backend network devices, we can drop usage legacy field info_str for them. We still use this field for NIC and hubports, so we can not completely remove it. Signed-off-by: Alexey Kirillov --- net/l2tpv3.c | 2 -- net/slirp.c

[PULL 2/2] hw/rx/rx-gdbsim: Fix memory leak (CID 1432307)

2020-11-08 Thread Philippe Mathieu-Daudé
As load_device_tree() returns allocated memory, we need to free it. Cc: Yoshinori Sato Fixes: bda19d7bb56 ("hw/rx: Add RX GDB simulator") Reported-by: Coverity (CID 1432307: RESOURCE_LEAK) Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Message-Id:

[PATCH v5 2/4] tests: Add tests for query-netdev command

2020-11-08 Thread Alexey Kirillov
Signed-off-by: Alexey Kirillov Acked-by: Thomas Huth --- tests/qtest/meson.build | 3 + tests/qtest/test-query-netdev.c | 120 2 files changed, 123 insertions(+) create mode 100644 tests/qtest/test-query-netdev.c diff --git a/tests/qtest/meson.build

[PATCH v5 0/4] Introducing QMP query-netdev command

2020-11-08 Thread Alexey Kirillov
This patch series introduces a new QMP command "query-netdev" to get information about currently attached backend network devices (netdevs). Also, since the "info_str" field of "NetClientState" is now deprecated, we no longer use it for netdevs, only for NIC/hubports. The HMP command "info

[PULL 0/2] Renesas patches for 5.2-rc1

2020-11-08 Thread Philippe Mathieu-Daudé
The following changes since commit 3493c36f0371777c62d1d72b205b0eb6117e2156: Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20201106' into staging (2020-11-06 13:43:28 +) are available in the Git repository at: https://gitlab.com/philmd/qemu.git tags/renesas-fixes-20201109

[PULL 1/2] MAINTAINERS: Demote Renesas target & hardware to 'Odd Fixes'

2020-11-08 Thread Philippe Mathieu-Daudé
To be fair with other subsystems listed as 'Odd Fixes' but having maintainers more present, demote the Renesas sections from being 'Maintained' to 'Odd Fixes' (has a maintainer but they don't have time to do much other than throw the odd patch in.) This matches Magnus's possibilities so far:

Re: [PATCH-for-5.2] MAINTAINERS: Demote Renesas target & hardware to 'Odd Fixes'

2020-11-08 Thread Philippe Mathieu-Daudé
On 11/2/20 11:40 AM, Philippe Mathieu-Daudé wrote: > To be fair with other subsystems listed as 'Odd Fixes' but having > maintainers more present, demote the Renesas sections from being > 'Maintained' to 'Odd Fixes' (has a maintainer but they don't have > time to do much other than throw the odd

Re: [PATCH-for-5.2 v3] hw/rx/rx-gdbsim: Fix memory leak

2020-11-08 Thread Philippe Mathieu-Daudé
On 11/2/20 11:45 AM, Philippe Mathieu-Daudé wrote: > As load_device_tree() returns allocated memory, > we need to free it. > > Cc: Yoshinori Sato > Fixes: bda19d7bb56 ("hw/rx: Add RX GDB simulator") > Reported-by: Coverity (CID 1432307: RESOURCE_LEAK) > Reviewed-by: Richard Henderson >

[PULL 0/3] MIPS patches for 5.2-rc1

2020-11-08 Thread Philippe Mathieu-Daudé
The following changes since commit 3493c36f0371777c62d1d72b205b0eb6117e2156: Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20201106' into staging (2020-11-06 13:43:28 +) are available in the Git repository at: https://gitlab.com/philmd/qemu.git tags/mips-fixes-20201109 for

[PULL 3/3] hw/mips/boston: Fix memory leak in boston_fdt_filter() error-handling paths

2020-11-08 Thread Philippe Mathieu-Daudé
From: Peter Maydell Coverity points out that the error-handling paths in the boston_fdt_filter() function don't free the fdt that was allocated. Fix the leak by using g_autofree. Fixes: Coverity CID 1432275 Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Message-Id:

[PULL 2/3] target/mips: Fix PageMask with variable page size

2020-11-08 Thread Philippe Mathieu-Daudé
From: Jiaxun Yang Our current code assumed the target page size is always 4k when handling PageMask and VPN2, however, variable page size was just added to mips target and that's no longer true. Fixes: ee3863b9d414 ("target/mips: Support variable page size") Signed-off-by: Jiaxun Yang

[PULL 1/3] target/mips: Deprecate nanoMIPS ISA

2020-11-08 Thread Philippe Mathieu-Daudé
The nanoMIPS ISA has been announced in 2018 for various projects: GCC: https://gcc.gnu.org/legacy-ml/gcc/2018-05/msg00012.html Linux: https://lwn.net/Articles/753605/ QEMU: https://www.mail-archive.com/qemu-devel@nongnu.org/msg530721.html Unfortunately the links referenced doesn't work

[PATCH v5 5/7] slirp: update build flags for iOS resolv fix

2020-11-08 Thread Joelle van Dyne
A future libslirp update will use libresolv on Darwin systems, so we add the flags in QEMU build now. Reviewed-by: Stefan Hajnoczi Signed-off-by: Joelle van Dyne --- meson.build | 2 ++ 1 file changed, 2 insertions(+) diff --git a/meson.build b/meson.build index b087721f63..40dd3b30fc 100644

[PATCH v5 3/7] qemu: add support for iOS host

2020-11-08 Thread Joelle van Dyne
This introduces support for building for iOS hosts. When the correct Xcode toolchain is used, iOS host will be detected automatically. * block: disable features not supported by iOS sandbox * slirp: disable SMB features for iOS * osdep: disable system() calls for iOS Signed-off-by: Joelle van

[Bug 1663287] Re: Illegal delay slot code causes abort on mips64

2020-11-08 Thread Philippe Mathieu-Daudé
** Changed in: qemu Status: New => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1663287 Title: Illegal delay slot code causes abort on mips64 Status in QEMU: Confirmed Bug

[PATCH v5 6/7] tcg: implement JIT for iOS and Apple Silicon

2020-11-08 Thread Joelle van Dyne
When entitlements are available (macOS or jailbroken iOS), a hardware feature called APRR exists on newer Apple Silicon that can cheaply mark JIT pages as either RX or RW. Reverse engineered functions from libsystem_pthread.dylib are implemented to handle this. The following rules apply for JIT

[PATCH v5 2/7] configure: cross-compiling with empty cross_prefix

2020-11-08 Thread Joelle van Dyne
The iOS toolchain does not use the host prefix naming convention. So we need to enable cross-compile options while allowing the PREFIX to be blank. Signed-off-by: Joelle van Dyne --- configure | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/configure b/configure index

[PATCH v5 1/7] configure: option to disable host block devices

2020-11-08 Thread Joelle van Dyne
Some hosts (iOS) have a sandboxed filesystem and do not provide low-level APIs for interfacing with host block devices. Signed-off-by: Joelle van Dyne --- configure| 4 meson.build | 1 + qapi/block-core.json | 10 +++--- block/file-posix.c | 10 +- 4

[PATCH v5 0/7] iOS and Apple Silicon host support

2020-11-08 Thread Joelle van Dyne
Based-on: 20201106032921.600200-1-richard.hender...@linaro.org ([PATCH v3 00/41] Mirror map JIT memory for TCG) These set of changes brings QEMU TCG to iOS devices and future Apple Silicon devices. They were originally developed last year and have been working in the UTM app. Recently, we ported

[PATCH v5 7/7] block: check availablity for preadv/pwritev on mac

2020-11-08 Thread Joelle van Dyne
macOS 11/iOS 14 added preadv/pwritev APIs. Due to weak linking, configure will succeed with CONFIG_PREADV even when targeting a lower OS version. We therefore need to check at run time if we can actually use these APIs. Signed-off-by: Joelle van Dyne --- block/file-posix.c | 12 1

[PATCH v5 4/7] coroutine: add libucontext as external library

2020-11-08 Thread Joelle van Dyne
iOS does not support ucontext natively for aarch64 and the sigaltstack is also unsupported (even worse, it fails silently, see: https://openradar.appspot.com/13002712 ) As a workaround we include a library implementation of ucontext and add it as a build option. Signed-off-by: Joelle van Dyne

Re: [PATCH-for-5.2] target/mips: Deprecate nanoMIPS ISA

2020-11-08 Thread Philippe Mathieu-Daudé
On 11/2/20 9:27 PM, Philippe Mathieu-Daudé wrote: > The nanoMIPS ISA has been announced in 2018 for various projects: > > GCC: https://gcc.gnu.org/legacy-ml/gcc/2018-05/msg00012.html > Linux: https://lwn.net/Articles/753605/ > QEMU:

Re: [PATCH V17 1/6] target/mips: Fix PageMask with variable page size

2020-11-08 Thread Philippe Mathieu-Daudé
On 11/6/20 5:21 AM, Huacai Chen wrote: > From: Jiaxun Yang > > Our current code assumed the target page size is always 4k > when handling PageMask and VPN2, however, variable page size > was just added to mips target and that's no longer true. > > Fixes: ee3863b9d414 ("target/mips: Support

Re: [PATCH for-5.2] hw/mips/boston.c: Fix memory leak in boston_fdt_filter() error-handling paths

2020-11-08 Thread Philippe Mathieu-Daudé
On 11/6/20 6:58 PM, Peter Maydell wrote: > Coverity points out that the error-handling paths in the > boston_fdt_filter() function don't free the fdt that was allocated. > Fix the leak by using g_autofree. > > Fixes: Coverity CID 1432275 > > Signed-off-by: Peter Maydell > --- >

Re: [PATCH v4 4/7] coroutine: add libucontext as external library

2020-11-08 Thread Joelle van Dyne
Thanks, it built on my 18.04 machine but it seems that newer versions of GCC had different behavior on the underscore assembly functions. I will fix it and test on 20.04. -j On Sun, Nov 8, 2020 at 7:46 AM Philippe Mathieu-Daudé wrote: > > Hi Joelle, > > On 11/8/20 6:26 AM, Joelle van Dyne

[PATCH v3 11/11] gitlab-ci: Move artifacts expiry rule to common 'native_build_job'

2020-11-08 Thread Philippe Mathieu-Daudé
Build jobs include the 'native_build_job' template. Move the 'artifacts expiry' rule there. Now all build jobs benefit from it. Signed-off-by: Philippe Mathieu-Daudé --- .gitlab-ci.yml | 24 1 file changed, 4 insertions(+), 20 deletions(-) diff --git a/.gitlab-ci.yml

[PATCH v3 10/11] gitlab-ci: Add rules to select building/testing native jobs

2020-11-08 Thread Philippe Mathieu-Daudé
Add rules to select various build/test jobs. The following tags are available to restrict CI jobs: - user(user-mode jobs) - system (system-mode jobs) - centos (jobs based on CentOS distribution image) - debian (... Debian) - fedora (... Fedora) -

[PATCH v3 09/11] gitlab-ci: Add rules to select cross-jobs to build

2020-11-08 Thread Philippe Mathieu-Daudé
Add rules to select some crossbuild jobs. The following tags are available to restrict the CI jobs: - all(select all jobs, this is default) - cross (select all cross-jobs) - system (select all cross-system jobs) - user (select all cross-user jobs) - $ARCH (select an architecture:

[PATCH v3 08/11] gitlab-ci: Extract common job definition as 'native_common_job'

2020-11-08 Thread Philippe Mathieu-Daudé
Extract the common definitions shared by '.native_build_job' and '.native_test_job' to '.native_common_job'. Signed-off-by: Philippe Mathieu-Daudé --- .gitlab-ci.yml | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index

[PATCH v3 06/11] gitlab-ci: Rename acceptance_test_job -> integration_test_job

2020-11-08 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- .gitlab-ci.yml | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 0ef814764a0..d4526323169 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -42,7 +42,7 @@ include: - find .

[PATCH v3 04/11] gitlab-ci: Replace YAML anchors by extends (native_test_job)

2020-11-08 Thread Philippe Mathieu-Daudé
'extends' is an alternative to using YAML anchors and is a little more flexible and readable. See: https://docs.gitlab.com/ee/ci/yaml/#extends Signed-off-by: Philippe Mathieu-Daudé --- .gitlab-ci.yml | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git

[PATCH v3 03/11] gitlab-ci: Replace YAML anchors by extends (native_build_job)

2020-11-08 Thread Philippe Mathieu-Daudé
'extends' is an alternative to using YAML anchors and is a little more flexible and readable. See: https://docs.gitlab.com/ee/ci/yaml/#extends Signed-off-by: Philippe Mathieu-Daudé --- .gitlab-ci.yml | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff

[PATCH v3 05/11] gitlab-ci: Replace YAML anchors by extends (acceptance_test_job)

2020-11-08 Thread Philippe Mathieu-Daudé
'extends' is an alternative to using YAML anchors and is a little more flexible and readable. See: https://docs.gitlab.com/ee/ci/yaml/#extends Signed-off-by: Philippe Mathieu-Daudé --- .gitlab-ci.yml | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git

[PATCH v3 02/11] gitlab-ci: Replace YAML anchors by extends (cross_system_build_job)

2020-11-08 Thread Philippe Mathieu-Daudé
'extends' is an alternative to using YAML anchors and is a little more flexible and readable. See: https://docs.gitlab.com/ee/ci/yaml/#extends Signed-off-by: Philippe Mathieu-Daudé --- .gitlab-ci.d/crossbuilds.yml | 40 ++-- 1 file changed, 20 insertions(+), 20

[PATCH v3 07/11] gitlab-ci: Extract common job definition as 'cross_common_job'

2020-11-08 Thread Philippe Mathieu-Daudé
Extract the common definitions shared by '.cross_system_build_job' and '.cross_user_build_job' to '.cross_common_job'. Signed-off-by: Philippe Mathieu-Daudé --- .gitlab-ci.d/crossbuilds.yml | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/.gitlab-ci.d/crossbuilds.yml

[PATCH v3 00/11] gitlab-ci: Allow forks to select & restrict build jobs

2020-11-08 Thread Philippe Mathieu-Daudé
Hi, 2 months ago GitLab added time limit to their free CI offer [1]. This series provide developers with the possibility to not run all jobs. By default all jobs are started, but we can restrict by selecting a subset of them. Since v2: - no more RFC - project-wide environment variable works - do

[PATCH v3 01/11] gitlab-ci: Drop generic cache rule

2020-11-08 Thread Philippe Mathieu-Daudé
This cache rule is meant for Avocado artifacts, but affects all jobs. Moreover the 'acceptance_template' template already include a more detailled rule to cache artifacts. Signed-off-by: Philippe Mathieu-Daudé --- .gitlab-ci.yml | 6 -- 1 file changed, 6 deletions(-) diff --git

Re: [PATCH-for-6.0 v4 16/17] gitlab-ci: Make some ARM 32-bit jobs optional

2020-11-08 Thread Philippe Mathieu-Daudé
On 11/8/20 9:45 PM, Philippe Mathieu-Daudé wrote: > The armel/armhf targets have a lot in common. Instead of > testing both user/system emulation on each target, test > each one once. Mark the other combination optional, so > user can still run the tests manually. > > We now test system-mode

[PATCH-for-6.0 v4 17/17] gitlab-ci: Make MIPS user-mode 32-bit little-endian job optional

2020-11-08 Thread Philippe Mathieu-Daudé
Keep the mips user-mode emulation by default on 32-bit big endian and 64-bit little endian targets, but make it optional on 32-bit little endian. User can still run the job manually. Signed-off-by: Philippe Mathieu-Daudé --- Cc: Laurent Vivier --- .gitlab-ci.d/crossbuilds.yml | 3 +++ 1 file

[PATCH-for-6.0 v4 14/17] gitlab-ci: Move trace backend tests across to gitlab

2020-11-08 Thread Philippe Mathieu-Daudé
Similarly to commit 8cdb2cef3f1, move the trace backend tests to GitLab. Signed-off-by: Philippe Mathieu-Daudé --- Cc: Stefan Hajnoczi --- .gitlab-ci.yml | 18 ++ .travis.yml| 19 --- 2 files changed, 18 insertions(+), 19 deletions(-) diff --git

[PATCH-for-6.0 v4 13/17] tests/docker: Install lttng-ust-devel package in Fedora image

2020-11-08 Thread Philippe Mathieu-Daudé
Install the lttng-ust-devel package to be able to build QEMU using the User-Space Tracer trace backend (configure --enable-trace-backends=ust). Signed-off-by: Philippe Mathieu-Daudé --- Cc: Stefan Hajnoczi Cc: Daniel P . Berrange --- tests/docker/dockerfiles/fedora.docker | 1 + 1 file

[PATCH-for-6.0 v4 16/17] gitlab-ci: Make some ARM 32-bit jobs optional

2020-11-08 Thread Philippe Mathieu-Daudé
The armel/armhf targets have a lot in common. Instead of testing both user/system emulation on each target, test each one once. Mark the other combination optional, so user can still run the tests manually. We now test system-mode emulation on armel target, and user-mode emulation to armhf

[PATCH-for-6.0 v4 09/17] gitlab-ci: Move gprof/gcov test across to gitlab

2020-11-08 Thread Philippe Mathieu-Daudé
Similarly to commit 8cdb2cef3f1, move the gprof/gcov test to GitLab. The coverage-summary.sh script is not Travis-CI specific, make it generic. Signed-off-by: Philippe Mathieu-Daudé --- .gitlab-ci.yml | 12 .travis.yml|

[PATCH-for-6.0 v4 11/17] gitlab-ci: Move tools-only and softfloat tests across to gitlab

2020-11-08 Thread Philippe Mathieu-Daudé
Similarly to commit 8cdb2cef3f1, move the tools-only and softfloat test to GitLab (splitting it in 2 different jobs). Signed-off-by: Philippe Mathieu-Daudé --- Cc: Alex Bennée Cc: Emilio G. Cota --- .gitlab-ci.yml | 14 ++ .travis.yml| 9 - 2 files changed, 14

[PATCH-for-6.0 v4 10/17] gitlab-ci: Move user-static test across to gitlab

2020-11-08 Thread Philippe Mathieu-Daudé
Similarly to commit 8cdb2cef3f1, move the user-static test to GitLab. Signed-off-by: Philippe Mathieu-Daudé --- Cc: Laurent Vivier --- .gitlab-ci.yml | 7 +++ .travis.yml| 5 - 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index

[PATCH-for-6.0 v4 15/17] gitlab-ci: Add test for Xen (on CentOS 7)

2020-11-08 Thread Philippe Mathieu-Daudé
Xen packages are available in CentOS 7, but have been removed from CentOS 8. Use the CentOS 7 container. Signed-off-by: Philippe Mathieu-Daudé --- Cc: Eduardo Habkost Cc: Stefano Stabellini Cc: Anthony Perard Cc: Paul Durrant Cc: xen-de...@lists.xenproject.org --- .gitlab-ci.yml | 21

[PATCH-for-5.2 v4 03/17] hw/i386/acpi-build: Fix maybe-uninitialized error when ACPI hotplug off

2020-11-08 Thread Philippe Mathieu-Daudé
GCC 9.3.0 thinks that 'method' can be left uninitialized. This code is already in the "if (bsel || pcihp_bridge_en)" block statement, but it isn't smart enough to figure it out. Restrict the code to be used only in the "if (bsel || pcihp_bridge_en)" block statement to fix (on Ubuntu):

[PATCH-for-6.0 v4 08/17] gitlab-ci: Move linux-user debug-tcg test across to gitlab

2020-11-08 Thread Philippe Mathieu-Daudé
Similarly to commit 8cdb2cef3f1, move the linux-user (debug-tcg) test to GitLab. Signed-off-by: Philippe Mathieu-Daudé --- Cc: Laurent Vivier --- .gitlab-ci.yml | 7 +++ .travis.yml| 9 - 2 files changed, 7 insertions(+), 9 deletions(-) diff --git a/.gitlab-ci.yml

[PATCH-for-6.0 v4 07/17] gitlab-ci: Move job testing --without-default-devices across to gitlab

2020-11-08 Thread Philippe Mathieu-Daudé
Similarly to commit 8cdb2cef3f1, move the job testing the '--without-default-devices' configure option to GitLab. Since building all softmmu targets takes too long, split the job in 2. As smoke test, run the qtests on the AVR and m68k targets. Signed-off-by: Philippe Mathieu-Daudé --- Cc:

[PATCH-for-6.0 v4 12/17] gitlab-ci: Move coroutine tests across to gitlab

2020-11-08 Thread Philippe Mathieu-Daudé
Similarly to commit 8cdb2cef3f1, move the coroutine tests to GitLab. Signed-off-by: Philippe Mathieu-Daudé --- Cc: Stefan Hajnoczi Cc: Kevin Wolf --- .gitlab-ci.yml | 16 .travis.yml| 14 -- 2 files changed, 16 insertions(+), 14 deletions(-) diff --git

[PATCH-for-5.2 v4 02/17] meson: always include contrib/libvhost-user

2020-11-08 Thread Philippe Mathieu-Daudé
From: Stefan Hajnoczi libvhost-user is needed when CONFIG_LINUX is set. The CONFIG_VHOST_USER check in meson.build is incorrect. In fact, no explicit check is needed since this dependency is not built by default. If something declares a dependency on libvhost-user then it will be built,

[PATCH-for-6.0 v4 06/17] gitlab-ci: Update 'build-disabled' to cover all configurable options

2020-11-08 Thread Philippe Mathieu-Daudé
Add these missing options to the 'build-disabled' job: --disable-auth-pam (commit 8953caf3cd38) --disable-gcrypt (commit 91bfcdb01d48) --disable-keyring (commit 54e7aac05624) --disable-libudev (commit 5c53015a480b) --disable-opengl

[PATCH-for-5.2 v4 00/17] ci: Move various jobs from Travis to GitLab CI

2020-11-08 Thread Philippe Mathieu-Daudé
We have various job covered on Travis-CI, but recommend the community to use GitLab, so build failures are missed. We need help to move the jobs to GitLab (we will keep the s390x and ppc64 containerized jobs on Travis as there is no similar offer on GitLab). Start moving jobs. Resulting

[PATCH-for-6.0 v4 04/17] MAINTAINERS: Add gitlab-pipeline-status script to GitLab CI section

2020-11-08 Thread Philippe Mathieu-Daudé
Do not let the gitlab-pipeline-status script unmaintained, add it to the 'GitLab Continuous Integration' section. Fixes: c02b2eac55e ("GitLab Gating CI: introduce pipeline-status contrib script") Signed-off-by: Philippe Mathieu-Daudé --- Cc: Cleber Rosa --- MAINTAINERS | 1 + 1 file changed,

[PATCH-for-6.0 v4 05/17] gitlab-ci: Split CONFIGURE_ARGS one argument per line for build-disabled

2020-11-08 Thread Philippe Mathieu-Daudé
We will keep adding/removing options to our 'configure' script, so for easier maintainability it makes sense to have CONFIGURE_ARGS declared as one option per line. This way we can review diff easily (or rebase/cherry-pick). No logical change. Signed-off-by: Philippe Mathieu-Daudé --- Cc:

[PATCH-for-5.2 v4 01/17] configure: Check vhost-user is available to build vhost-user-blk-server

2020-11-08 Thread Philippe Mathieu-Daudé
Check vhost-user is available to build vhost-user-blk-server to fix: $ ../configure \ --disable-vhost-user --enable-vhost-user-blk-server && \ make qemu-nbd ... [505/505] Linking target qemu-nbd FAILED: qemu-nbd cc -o qemu-nbd qemu-nbd.p/qemu-nbd.c.o -Wl,--as-needed

[Bug 1652459] Re: kvm rbd driver (and maybe others, i.e. qcow2, qed and so on) does not report DISCARD-ZERO flag

2020-11-08 Thread Коренберг Марк
** Changed in: qemu Status: Incomplete => New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1652459 Title: kvm rbd driver (and maybe others, i.e. qcow2, qed and so on) does not report

Re: --enable-xen on gitlab CI? (was Re: [PATCH 09/36] qdev: Make qdev_get_prop_ptr() get Object* arg)

2020-11-08 Thread Philippe Mathieu-Daudé
On 10/31/20 11:25 AM, Thomas Huth wrote: > On 30/10/2020 18.13, Paolo Bonzini wrote: >> On 30/10/20 12:35, Eduardo Habkost wrote: >>> >>> What is necessary to make sure we have a CONFIG_XEN=y job in >>> gitlab CI? Maybe just including xen-devel in some of the >>> container images is enough? >> >>

[PATCH] scripts/oss-fuzz: give all fuzzers -target names

2020-11-08 Thread Alexander Bulekov
We switched to hardlinks in a942f64cc4 ("scripts/oss-fuzz: use hardlinks instead of copying") The motivation was to conserve space (50 fuzzers built with ASAN, can weigh close to 9 GB). Unfortunately, OSS-Fuzz (partially) treated the underlying copy of the fuzzer as a standalone fuzzer. To

Re: [PATCH-for-5.2 v2] hw/i386/acpi-build: Fix maybe-uninitialized error when ACPI hotplug off

2020-11-08 Thread Philippe Mathieu-Daudé
On 11/8/20 4:58 AM, Ani Sinha wrote: > On Sun, Nov 8, 2020 at 1:10 AM Philippe Mathieu-Daudé > wrote: >> >> GCC 9.3.0 thinks that 'method' can be left uninitialized. This code >> is already in the "if (bsel || pcihp_bridge_en)" block statement, >> but it isn't smart enough to figure it out. >>

Re: [PATCH for-5.2] qga: fix missing closedir() in qmp_guest_get_disks()

2020-11-08 Thread Philippe Mathieu-Daudé
On 11/8/20 5:11 PM, Michael Roth wrote: > We opendir("/sys/block") at the beginning of the function, but we never > close it prior to returning. > > Fixes: Coverity CID 1436130 > Fixes: fed3956429d5 ("qga: add implementation of guest-get-disks for Linux") > Reported-by: Peter Maydell > Cc:

Re: mmap2 is probably still broken in linux-user & other things

2020-11-08 Thread Philippe Mathieu-Daudé
Cc'ing user-mode team. On 11/8/20 4:53 PM, Catherine A. Frederick wrote: > Hi, I submitted a patch a while ago and then dropped off the face of the > planet like most people do. In my journey to fix DRM/radeonsi in > user-mode emulation I discovered a few bugs. I don't really have the > time to

Re: [PULL v3 05/12] qga: add command guest-get-disks

2020-11-08 Thread Michael Roth
Quoting Eric Blake (2020-11-04 15:56:17) > [Adding Markus in CC] > > On 11/2/20 8:43 PM, Michael Roth wrote: > > From: Tomá\u0161 Golembiovský > > > > Add API and stubs for new guest-get-disks command. > > > > The command guest-get-fsinfo can be used to list information about disks > > and

[PATCH] ui/gtk: Fix guest absolute pointer position under Wayland

2020-11-08 Thread Andrei Borzenkov
Ubuntu 20.04, GNOME Wayland desktop, QEMU 5.1.0 compiled from sources. Absolute tablet/vmmouse location in guest window does not match cursor - coordinates reported to guest are smaller than visible mouse cursor location. Adding debug print to ui/gtk.c:gd_motion_event() to print surface and

[PATCH for-5.2] qga: fix missing closedir() in qmp_guest_get_disks()

2020-11-08 Thread Michael Roth
We opendir("/sys/block") at the beginning of the function, but we never close it prior to returning. Fixes: Coverity CID 1436130 Fixes: fed3956429d5 ("qga: add implementation of guest-get-disks for Linux") Reported-by: Peter Maydell Cc: Marc-André Lureau Cc: Tomáš Golembiovský Signed-off-by:

Re: [PATCH] meson: always include contrib/libvhost-user

2020-11-08 Thread Philippe Mathieu-Daudé
On 11/6/20 10:03 PM, Stefan Hajnoczi wrote: > libvhost-user is needed when CONFIG_LINUX is set. The CONFIG_VHOST_USER > check in meson.build is incorrect. > > In fact, no explicit check is needed since this dependency is not built > by default. If something declares a dependency on libvhost-user

mmap2 is probably still broken in linux-user & other things

2020-11-08 Thread Catherine A. Frederick
Hi, I submitted a patch a while ago and then dropped off the face of the planet like most people do. In my journey to fix DRM/radeonsi in user-mode emulation I discovered a few bugs. I don't really have the time to write the infrastructure to make wrapping DRM IOCTLs remotely not-ugly, but I

Re: [PATCH v4 4/7] coroutine: add libucontext as external library

2020-11-08 Thread Philippe Mathieu-Daudé
Hi Joelle, On 11/8/20 6:26 AM, Joelle van Dyne wrote: > iOS does not support ucontext natively for aarch64 and the sigaltstack is > also unsupported (even worse, it fails silently, see: > https://openradar.appspot.com/13002712 ) > > As a workaround we include a library implementation of ucontext

[Bug 1630723] Re: UART writes to netduino2/stm32f205-soc disappear

2020-11-08 Thread Philippe Mathieu-Daudé
Example program tested successfully on commit 3493c36f037. Eventually fixed by fc38a1120c2 ("Remove checks on MAX_SERIAL_PORTS that are just bounds checks"). ** Changed in: qemu Status: Incomplete => Fix Released -- You received this bug notification because you are a member of qemu-

Re: [PATCH v2 00/44] Make qdev static property API usable by any QOM type

2020-11-08 Thread Paolo Bonzini
On 06/11/20 22:10, Eduardo Habkost wrote: This was implemented at: https://gitlab.com/ehabkost/qemu/-/commits/work/qdev-make-generic This is the interface I'd like to submit as v3: static Property machine_props[] = { DEFINE_PROP_STRING("kernel", MachineState, kernel_filename,

RE: [PATCH-for-5.2 1/5] hw/usb/hcd-xhci: Make xhci base model abstract

2020-11-08 Thread Sai Pavan Boddu
Looks good. Reviewed-by: Sai Pavan Boddu Thanks, Sai Pavan > -Original Message- > From: Philippe Mathieu-Daudé > Sent: Saturday, November 7, 2020 4:43 PM > To: qemu-devel@nongnu.org > Cc: Gerd Hoffmann ; Sai Pavan Boddu > ; Philippe Mathieu-Daudé ; > Miroslav Rezanina > Subject:

RE: [PATCH-for-5.2 2/5] hw/usb/Kconfig: Fix USB_XHCI_NEC (depends on USB_XHCI_PCI)

2020-11-08 Thread Sai Pavan Boddu
Thanks, good fix. Reviewed-by: Sai Pavan Boddu Regards, Sai Pavan > -Original Message- > From: Philippe Mathieu-Daudé > Sent: Saturday, November 7, 2020 4:43 PM > To: qemu-devel@nongnu.org > Cc: Gerd Hoffmann ; Sai Pavan Boddu > ; Philippe Mathieu-Daudé > Subject: [PATCH-for-5.2 2/5]

Re: Qemu first time contribution

2020-11-08 Thread Harshavardhan Unnibhavi
Hi, Thank you for the reply! Yes, I understand that gsoc is over for 2020, and projects for 2021 will come up next year. I was thinking of contributing outside of gsoc(for which I won't be eligible anyways for next year). Anyway, I will work on some of the bite sized tasks, and get back to you

Re: Migrating to the gitlab issue tracker

2020-11-08 Thread Peter Maydell
On Sun, 8 Nov 2020 at 09:01, Thomas Huth wrote: > I agree with Daniel. Please let's not clog the new bug tracker right from > the start with hundreds of bugs - that only makes it harder to focus on the > tickets that are really important. Let's use the migration instead to start > as clean as

  1   2   >