HI,
> -Original Message-
> From: kra...@redhat.com
> Sent: Monday, November 16, 2020 12:34 PM
> To: Sai Pavan Boddu
> Cc: Dr. David Alan Gilbert ;
> marcandre.lur...@redhat.com; qemu-devel@nongnu.org
> Subject: Re: nec-usb-xhci migration breakage
>
> On Mon, Nov 16, 2020 at 05:18:22AM
Queued this series to COLO tree.
Thanks
Chen
> -Original Message-
> From: Lukas Straub
> Sent: Sunday, November 15, 2020 7:19 PM
> To: qemu-devel
> Cc: Zhang, Chen ; Li Zhijian
> ; Jason Wang
> Subject: [PATCH 0/2] colo-compare: Fix memory leak for non-tcp packet
>
> Hello Everyone,
> -Original Message-
> From: Lukas Straub
> Sent: Sunday, November 15, 2020 7:19 PM
> To: qemu-devel
> Cc: Zhang, Chen ; Li Zhijian
> ; Jason Wang
> Subject: [PATCH 1/2] net/colo-compare.c: Fix memory leak for non-tcp
> packet
>
> Additional to removing the packet from the secondary
> -Original Message-
> From: Lukas Straub
> Sent: Sunday, November 15, 2020 7:19 PM
> To: qemu-devel
> Cc: Zhang, Chen ; Li Zhijian
> ; Jason Wang
> Subject: [PATCH 2/2] net/colo-compare.c: Optimize removal of secondary
> packet
>
> g_queue_remove needs to look up the list entry
Thanks, I did not observe that.
Regards,
Sai Pavan
> -Original Message-
> From: kra...@redhat.com
> Sent: Monday, November 16, 2020 12:34 PM
> To: Sai Pavan Boddu
> Cc: Dr. David Alan Gilbert ;
> marcandre.lur...@redhat.com; qemu-devel@nongnu.org
> Subject: Re: nec-usb-xhci migration
On Mon, Nov 16, 2020 at 05:18:22AM +, Sai Pavan Boddu wrote:
> +Gerd
> Hi David,
>
> Sorry for the delayed response. I was able to reproduce your issue with
> nec-usb-xhci, in my previous testing we have tested with qemu-xhci model
> which was good.
> I would look further into this.
>
>
"Dr. David Alan Gilbert" writes:
> * Markus Armbruster (arm...@redhat.com) wrote:
>> "Dr. David Alan Gilbert" writes:
>>
>> > * Markus Armbruster (arm...@redhat.com) wrote:
>> >> migrate-set-parameters passes the size to xbzrle_cache_resize().
>> >> xbzrle_cache_resize() checks it fits into
"Chenqun (kuhn)" writes:
>> -Original Message-
>> From: Chenzhendong (alex)
>> Sent: Friday, November 13, 2020 10:55 PM
>> To: arm...@redhat.com
>> Cc: Chenzhendong (alex) ; qemu-devel@nongnu.org;
>> qemu-triv...@nongnu.org; Zhanghailiang ;
>> Chenqun (kuhn)
>> Subject: [PATCH v2] json:
+Gerd
Hi David,
Sorry for the delayed response. I was able to reproduce your issue with
nec-usb-xhci, in my previous testing we have tested with qemu-xhci model which
was good.
I would look further into this.
@Gerd: Do you have any high level comments on this ?
Regards,
Sai Pavan
>
ads7846 is a touch-screen controller that is an input device rather
than a display device, so move it to the hw/input folder.
Signed-off-by: Gan Qixin
---
hw/arm/Kconfig | 2 +-
hw/display/Kconfig | 3 ---
hw/display/meson.build | 1 -
hw/input/Kconfig
When using -Wimplicit-fallthrough in our CFLAGS on GCC9, the compiler showed
warning:
../accel/tcg/user-exec.c: In function ‘handle_cpu_signal’:
../accel/tcg/user-exec.c:169:13: warning: this statement may fall through
[-Wimplicit-fallthrough=]
169 |
When using -Wimplicit-fallthrough in our CFLAGS on GCC9, the compiler showed
warning:
hw/intc/arm_gicv3_kvm.c: In function ‘kvm_arm_gicv3_put’:
hw/intc/arm_gicv3_kvm.c:484:13: warning: this statement may fall through
[-Wimplicit-fallthrough=]
kvm_gicc_access(s, ICC_AP0R_EL1(1),
When using -Wimplicit-fallthrough in our CFLAGS, the compiler showed warning:
hw/ppc/ppc.c: In function ‘ppc6xx_set_irq’:
hw/ppc/ppc.c:118:16: warning: this statement may fall through
[-Wimplicit-fallthrough=]
118 | if (level) {
|^
hw/ppc/ppc.c:123:9: note:
When using -Wimplicit-fallthrough in our CFLAGS, the compiler showed warning:
target/ppc/mmu_helper.c: In function ‘dump_mmu’:
target/ppc/mmu_helper.c:1351:12: warning: this statement may fall through
[-Wimplicit-fallthrough=]
1351 | if (ppc64_v3_radix(env_archcpu(env))) {
|
Hi folks,
This series fix some "fall through" warnings reported by GCC_9.3. They've
been
reviewed for a long time. Some of these patchs may be important for QEMU 5.2.
Such as the Patch6 miss a break statement. Others only add "fall through"
comments and may not have a negative impact for
The current "#ifdef TARGET_X86_64" statement affects
the compiler's determination of fall through.
When using -Wimplicit-fallthrough in our CFLAGS on GCC9, the compiler showed
warning:
target/i386/translate.c: In function ‘gen_shiftd_rm_T1’:
target/i386/translate.c:1773:12: warning: this
When using -Wimplicit-fallthrough in our CFLAGS on GCC9, the compiler showed
warning:
target/sparc/translate.c: In function ‘gen_st_asi’:
target/sparc/translate.c:2320:12: warning: this statement may fall through
[-Wimplicit-fallthrough=]
2320 | if (!(dc->def->features &
When using -Wimplicit-fallthrough in our CFLAGS on GCC9, the compiler showed
warning:
target/sparc/win_helper.c: In function ‘get_gregset’:
target/sparc/win_helper.c:304:9: warning: this statement may fall through
[-Wimplicit-fallthrough=]
304 | trace_win_helper_gregset_error(pstate);
Kindly ping...
On 2020/11/5 22:02, AlexChen wrote:
> Currently, the 'v' is not checked whether it is between 0 and 16,
> which may result in an out-of-bounds access to the array 'xhci->intr[]'.
> This is LP#1902112. Following is the reproducer provided in:
>
Kindly ping...
On 2020/11/4 18:23, AlexChen wrote:
> We should use printf format specifier "%u" instead of "%d" for
> argument of type "unsigned int".
>
> Reported-by: Euler Robot
> Signed-off-by: Alex Chen
> ---
> contrib/libvhost-user/libvhost-user.c | 24
> 1 file
Kindly ping！
Maybe it should be need for version 5.2.
> -Original Message-
> From: Chenqun (kuhn)
> Sent: Wednesday, November 11, 2020 10:18 PM
> To: qemu-devel@nongnu.org; qemu-triv...@nongnu.org
> Cc: Zhanghailiang ; ganqixin
> ; f4...@amsat.org; Chenqun (kuhn)
> ; Peter Maydell ;
>
On 2020/11/9 17:08, Zeyu Jin wrote:
> Currently we have both multi-thread compression and multifd to optimize
> live migration in Qemu. Mulit-thread compression deals with the situation
> where network bandwith is limited but cpu resource adequate. Multifd instead
> aims to take full advantage of
From: Stefan Hajnoczi
Do not leave stdin and stdout open after fork. stdout is the
tap-driver.pl pipe. If we keep the pipe open then tap-driver.pl will not
detect that qos-test has terminated and it will hang.
Signed-off-by: Stefan Hajnoczi
Message-Id:
From: Stefan Hajnoczi
Validate discard/write zeroes the same way we do for virtio-blk. Some of
these checks are mandated by the VIRTIO specification, others are
internal to QEMU.
Signed-off-by: Stefan Hajnoczi
Message-Id: <2020124331.1393747-9-stefa...@redhat.com>
Reviewed-by: Michael S.
From: AlexChen
We should use printf format specifier "%u" instead of "%d" for
argument of type "unsigned int".
Reported-by: Euler Robot
Signed-off-by: Alex Chen
Message-Id: <5fa28106.6000...@huawei.com>
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
From: Stefan Hajnoczi
Pass the QMP and vhost-user-blk server sockets as file descriptors. That
way the sockets are already open and in a listen state when the QEMU
process is launched.
This solves the race with qemu-storage-daemon startup where the UNIX
domain sockets may not be ready yet when
From: AlexChen
When socket() fails, it returns -1, 0 is the normal return value and should not
return error.
Reported-by: Euler Robot
Signed-off-by: AlexChen
Message-Id: <5f9a5b48.9030...@huawei.com>
Reviewed-by: Raphael Norwitz
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S.
From: Stefan Hajnoczi
The vhost-user protocol uses the Linux eventfd feature and is typically
connected to Linux kvm.ko ioeventfd and irqfd file descriptors. The
protocol specification in docs/interop/vhost-user.rst does not describe
how platforms without eventfd support work.
The QEMU
From: Stefan Hajnoczi
Exercise input validation code paths in
block/export/vhost-user-blk-server.c.
Signed-off-by: Stefan Hajnoczi
Message-Id: <2020124331.1393747-10-stefa...@redhat.com>
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
From: Stefan Hajnoczi
The function is used not just for image files but also for UNIX domain
sockets (QMP monitor and vhost-user-blk). Reflect that in the name.
Signed-off-by: Stefan Hajnoczi
Message-Id: <2020124331.1393747-5-stefa...@redhat.com>
Reviewed-by: Michael S. Tsirkin
From: Philippe Mathieu-Daudé
GCC 9.3.0 thinks that 'method' can be left uninitialized. This code
is already in the "if (bsel || pcihp_bridge_en)" block statement,
but it isn't smart enough to figure it out.
Restrict the code to be used only in the "if (bsel || pcihp_bridge_en)"
block statement
From: Stefan Hajnoczi
Check that the sector number and byte count are valid.
Signed-off-by: Stefan Hajnoczi
Message-Id: <2020124331.1393747-11-stefa...@redhat.com>
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
block/export/vhost-user-blk-server.c | 14
From: Stefan Hajnoczi
The sock_path return value was unused and bogus (it doesn't make sense
when there are multiple drives because only the last path is arbitrarily
returned).
Signed-off-by: Stefan Hajnoczi
Message-Id: <2020124331.1393747-7-stefa...@redhat.com>
Reviewed-by: Michael S.
From: Coiby Xu
This test case has the same tests as tests/virtio-blk-test.c except for
tests have block_resize. Since vhost-user server can only server one
client one time, two instances of vhost-user-blk-server are started by
qemu-storage-daemon for the hotplug test.
In order to not block
From: Stefan Hajnoczi
The --enable/disable-vhost-user-blk-server options were implemented in
./configure. There has been confusion about them and part of the problem
is that the shell syntax used for setting the default value is not easy
to read. Move the option over to meson where the
From: Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi
Message-id: 20201001144604.559733-3-stefa...@redhat.com
Signed-off-by: Stefan Hajnoczi
Message-Id: <2020124331.1393747-3-stefa...@redhat.com>
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
From: Stefan Hajnoczi
There is a qtest_socket_client() API. Add an equivalent
qtest_socket_server() API that returns a new UNIX domain socket in the
listen state. The code for this was already there but only used
internally in init_socket().
Signed-off-by: Stefan Hajnoczi
Message-Id:
The following changes since commit c6f28ed5075df79fef39c500362a3f4089256c9c:
Update version for v5.2.0-rc1 release (2020-11-10 22:29:57 +)
are available in the Git repository at:
git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream
for you to fetch changes up to
From: Stefan Hajnoczi
I interpreted CONFIG_VHOST_USER as controlling only QEMU's vhost-user
device frontends. However, virtiofsd and contrib/ vhost-user device
backends are also controlled by CONFIG_VHOST_USER. Make the
vhost-user-blk server depend on CONFIG_VHOST_USER for consistency.
Now the
From: Stefan Hajnoczi
QEMU currently truncates the mmap_offset field when sending
VHOST_USER_ADD_MEM_REG and VHOST_USER_REM_MEM_REG messages. The struct
layout looks like this:
typedef struct VhostUserMemoryRegion {
uint64_t guest_phys_addr;
uint64_t memory_size;
uint64_t
On 14/11/2020 05.01, Brad Smith wrote:
> tests/vm: update NetBSD to 9.1
>
> Signed-off-by: Brad Smith
> Reviewed-by: Gerd Hoffmann
> Tested-by: Gerd Hoffmann
> ---
> tests/vm/netbsd | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tests/vm/netbsd
Patchew URL: https://patchew.org/QEMU/20201115162613.74645-1-th...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20201115162613.74645-1-th...@redhat.com
Type: series
Subject: [PULL 00/26] Fixes for Lesser GPL license
Hi Michael,
On Wed, Nov 11, 2020 at 2:35 PM Michael S. Tsirkin wrote:
> On Thu, Oct 22, 2020 at 02:40:26PM +0300, Marcel Apfelbaum wrote:
> > From: Marcel Apfelbaum
> >
> > During PCIe Root Port's transition from Power-Off to Power-ON (or
> vice-versa)
> > the "Slot Control Register" has the
From: Chetan Pant
There is no "version 2" of the "Lesser" General Public License.
It is either "GPL version 2.0" or "Lesser GPL version 2.1".
This patch replaces all occurrences of "Lesser GPL version 2" with
"Lesser GPL version 2.1" in comment section.
Signed-off-by: Chetan Pant
Message-Id:
Hi Roman,
On Wed, Nov 11, 2020 at 6:10 PM Roman Kagan wrote:
> On Thu, Oct 22, 2020 at 02:40:26PM +0300, Marcel Apfelbaum wrote:
> > From: Marcel Apfelbaum
> >
> > During PCIe Root Port's transition from Power-Off to Power-ON (or
> vice-versa)
> > the "Slot Control Register" has the "Power
From: Gan Qixin
There never was a "Lesser GPL version 2.0", It is either "GPL version 2.0"
or "Lesser GPL version 2.1". This patch replaces all "Lesser GPL version 2.0"
with "Lesser GPL version 2.1" in the tests/acceptance folder.
Signed-off-by: Gan Qixin
Message-Id:
From: Chetan Pant
There is no "version 2" of the "Lesser" General Public License.
It is either "GPL version 2.0" or "Lesser GPL version 2.1".
This patch replaces all occurrences of "Lesser GPL version 2" with
"Lesser GPL version 2.1" in comment section.
Signed-off-by: Chetan Pant
Message-Id:
From: Chetan Pant
There is no "version 2" of the "Lesser" General Public License.
It is either "GPL version 2.0" or "Lesser GPL version 2.1".
This patch replaces all occurrences of "Lesser GPL version 2" with
"Lesser GPL version 2.1" in comment section.
Signed-off-by: Chetan Pant
Message-Id:
From: Chetan Pant
There is no "version 2" of the "Lesser" General Public License.
It is either "GPL version 2.0" or "Lesser GPL version 2.1".
This patch replaces all occurrences of "Lesser GPL version 2" with
"Lesser GPL version 2.1" in comment section.
Signed-off-by: Chetan Pant
Message-Id:
From: Chetan Pant
There is no "version 2" of the "Lesser" General Public License.
It is either "GPL version 2.0" or "Lesser GPL version 2.1".
This patch replaces all occurrences of "Lesser GPL version 2" with
"Lesser GPL version 2.1" in comment section.
Signed-off-by: Chetan Pant
Message-Id:
From: Chetan Pant
There is no "version 2" of the "Lesser" General Public License.
It is either "GPL version 2.0" or "Lesser GPL version 2.1".
This patch replaces all occurrences of "Lesser GPL version 2" with
"Lesser GPL version 2.1" in comment section.
Signed-off-by: Chetan Pant
Message-Id:
From: Chetan Pant
There is no "version 2" of the "Lesser" General Public License.
It is either "GPL version 2.0" or "Lesser GPL version 2.1".
This patch replaces all occurrences of "Lesser GPL version 2" with
"Lesser GPL version 2.1" in comment section.
This patch contains all the files, whose
From: Gan Qixin
There never was a "Lesser GPL version 2.0", It is either "GPL version 2.0"
or "Lesser GPL version 2.1". This patch replaces all "Lesser GPL version 2.0"
with "Lesser GPL version 2.1" in the test folder.
Signed-off-by: Gan Qixin
Message-Id:
From: Chetan Pant
There is no "version 2" of the "Lesser" General Public License.
It is either "GPL version 2.0" or "Lesser GPL version 2.1".
This patch replaces all occurrences of "Lesser GPL version 2" with
"Lesser GPL version 2.1" in comment section.
Signed-off-by: Chetan Pant
Message-Id:
From: Chetan Pant
There is no "version 2" of the "Lesser" General Public License.
It is either "GPL version 2.0" or "Lesser GPL version 2.1".
This patch replaces all occurrences of "Lesser GPL version 2" with
"Lesser GPL version 2.1" in comment section.
Signed-off-by: Chetan Pant
Message-Id:
From: Chetan Pant
There is no "version 2" of the "Lesser" General Public License.
It is either "GPL version 2.0" or "Lesser GPL version 2.1".
This patch replaces all occurrences of "Lesser GPL version 2" with
"Lesser GPL version 2.1" in comment section.
Signed-off-by: Chetan Pant
Message-Id:
From: Chetan Pant
There is no "version 2" of the "Lesser" General Public License.
It is either "GPL version 2.0" or "Lesser GPL version 2.1".
This patch replaces all occurrences of "Lesser GPL version 2" with
"Lesser GPL version 2.1" in comment section.
Signed-off-by: Chetan Pant
Message-Id:
From: Gan Qixin
There never was a "Lesser GPL version 2.0", It is either "GPL version 2.0"
or "Lesser GPL version 2.1". This patch replaces all "Lesser GPL version 2.0"
with "Lesser GPL version 2.1" in the tests/migration folder.
Signed-off-by: Gan Qixin
Message-Id:
From: Chetan Pant
There is no "version 2" of the "Lesser" General Public License.
It is either "GPL version 2.0" or "Lesser GPL version 2.1".
This patch replaces all occurrences of "Lesser GPL version 2" with
"Lesser GPL version 2.1" in comment section.
Signed-off-by: Chetan Pant
Message-Id:
From: Chetan Pant
There is no "version 2" of the "Lesser" General Public License.
It is either "GPL version 2.0" or "Lesser GPL version 2.1".
This patch replaces all occurrences of "Lesser GPL version 2" with
"Lesser GPL version 2.1" in comment section.
Signed-off-by: Chetan Pant
Message-Id:
From: Chetan Pant
There is no "version 2" of the "Lesser" General Public License.
It is either "GPL version 2.0" or "Lesser GPL version 2.1".
This patch replaces all occurrences of "Lesser GPL version 2" with
"Lesser GPL version 2.1" in comment section.
Signed-off-by: Chetan Pant
Message-Id:
From: Chetan Pant
There is no "version 2" of the "Lesser" General Public License.
It is either "GPL version 2.0" or "Lesser GPL version 2.1".
This patch replaces all occurrences of "Lesser GPL version 2" with
"Lesser GPL version 2.1" in comment section.
Signed-off-by: Chetan Pant
Message-Id:
From: Chetan Pant
There is no "version 2" of the "Lesser" General Public License.
It is either "GPL version 2.0" or "Lesser GPL version 2.1".
This patch replaces all occurrences of "Lesser GPL version 2" with
"Lesser GPL version 2.1" in comment section.
Signed-off-by: Chetan Pant
Message-Id:
From: Chetan Pant
There is no "version 2" of the "Lesser" General Public License.
It is either "GPL version 2.0" or "Lesser GPL version 2.1".
This patch replaces all occurrences of "Lesser GPL version 2" with
"Lesser GPL version 2.1" in comment section.
Signed-off-by: Chetan Pant
Message-Id:
From: Chetan Pant
There is no "version 2" of the "Lesser" General Public License.
It is either "GPL version 2.0" or "Lesser GPL version 2.1".
This patch replaces all occurrences of "Lesser GPL version 2" with
"Lesser GPL version 2.1" in comment section.
Signed-off-by: Chetan Pant
Message-Id:
From: Chetan Pant
There is no "version 2" of the "Lesser" General Public License.
It is either "GPL version 2.0" or "Lesser GPL version 2.1".
This patch replaces all occurrences of "Lesser GPL version 2" with
"Lesser GPL version 2.1" in comment section.
Signed-off-by: Chetan Pant
Message-Id:
From: Chetan Pant
There is no "version 2" of the "Lesser" General Public License.
It is either "GPL version 2.0" or "Lesser GPL version 2.1".
This patch replaces all occurrences of "Lesser GPL version 2" with
"Lesser GPL version 2.1" in comment section.
Signed-off-by: Chetan Pant
Message-Id:
Hi Peter,
the following changes since commit b50ea0d54bbca7d440315c3d0c0f7a4d6537b180:
Merge remote-tracking branch
'remotes/alistair/tags/pull-riscv-to-apply-20201113-1' into staging (2020-11-14
11:22:07 +)
are available in the Git repository at:
https://gitlab.com/huth/qemu.git
From: Chetan Pant
There is no "version 2" of the "Lesser" General Public License.
It is either "GPL version 2.0" or "Lesser GPL version 2.1".
This patch replaces all occurrences of "Lesser GPL version 2" with
"Lesser GPL version 2.1" in comment section.
Signed-off-by: Chetan Pant
Message-Id:
From: Chetan Pant
There is no "version 2" of the "Lesser" General Public License.
It is either "GPL version 2.0" or "Lesser GPL version 2.1".
This patch replaces all occurrences of "Lesser GPL version 2" with
"Lesser GPL version 2.1" in comment section.
Signed-off-by: Chetan Pant
Message-Id:
From: Chetan Pant
There is no "version 2" of the "Lesser" General Public License.
It is either "GPL version 2.0" or "Lesser GPL version 2.1".
This patch replaces all occurrences of "Lesser GPL version 2" with
"Lesser GPL version 2.1" in comment section.
Signed-off-by: Chetan Pant
Message-Id:
Public bug reported:
Branch hash: b50ea0d (pulled from github).
I was reviewing the code and noticed the following in the function
serial_ioport_write:
assert(size == 1 && addr < 8);
.
.
.
switch(addr) {
default:
case 0:
if (s->lcf &
On 23/10/2020 14.44, Chetan Pant wrote:
> There is no "version 2" of the "Lesser" General Public License.
> It is either "GPL version 2.0" or "Lesser GPL version 2.1".
> This patch replaces all occurrences of "Lesser GPL version 2" with
> "Lesser GPL version 2.1" in comment section.
>
> This
On Solaris and Haiku, the _IO() macros are defined in .
Add a proper check for this header to our build system, and make sure
to include the header in tpm_ioctl.h to fix a build failure on Solaris
and Haiku.
Signed-off-by: Thomas Huth
---
v2: Check in meson.build instead of using the configure
On 15/11/2020 15.34, Paolo Bonzini wrote:
> On 15/11/20 15:00, Thomas Huth wrote:
>> On 14/11/2020 17.56, 罗勇刚(Yonggang Luo) wrote:
>>> Can we check this in meson.build?
>>
>> That would be nicer, indeed, but I did not spot a place where I could add my
>> code there ... all the other HAVE_xxx_H
On 23/10/2020 14.37, Chetan Pant wrote:
> There is no "version 2" of the "Lesser" General Public License.
> It is either "GPL version 2.0" or "Lesser GPL version 2.1".
> This patch replaces all occurrences of "Lesser GPL version 2" with
> "Lesser GPL version 2.1" in comment section.
>
>
On 23/10/2020 14.31, Chetan Pant wrote:
> There is no "version 2" of the "Lesser" General Public License.
> It is either "GPL version 2.0" or "Lesser GPL version 2.1".
> This patch replaces all occurrences of "Lesser GPL version 2" with
> "Lesser GPL version 2.1" in comment section.
>
>
On 15/11/20 15:31, Zenghui Yu wrote:
diff --git a/softmmu/memory.c b/softmmu/memory.c
index 71951fe4dc..0958db1a08 100644
--- a/softmmu/memory.c
+++ b/softmmu/memory.c
@@ -1806,7 +1806,10 @@ bool memory_region_is_ram_device(MemoryRegion *mr)
uint8_t
On 15/11/20 15:00, Thomas Huth wrote:
On 14/11/2020 17.56, 罗勇刚(Yonggang Luo) wrote:
Can we check this in meson.build?
That would be nicer, indeed, but I did not spot a place where I could add my
code there ... all the other HAVE_xxx_H symbols are added in the configure
script.
There is one
Hi folks,
While trying the new vfio-pci migration on my arm64 server, I noticed an
error at the very beginning:
qemu-system-aarch64: kvm_set_user_memory_region:
KVM_SET_USER_MEMORY_REGION failed, slot=5, start=0x80,
size=0x10: Invalid argument
The reason is that we've registered
On 14/11/2020 17.56, 罗勇刚(Yonggang Luo) wrote:
> Can we check this in meson.build?
That would be nicer, indeed, but I did not spot a place where I could add my
code there ... all the other HAVE_xxx_H symbols are added in the configure
script.
Maybe Paolo or Marc-André (now on CC:) have an idea
A connecting chardev object has an additional reference by the connecting
thread, so if the chardev is still connecting by the end of the test,
then the chardev object won't be freed. This in turn means that the yank
instance won't be unregistered and when running the next test-case
Make qio_channel_tls_shutdown thread-safe by using atomics when
accessing tioc->shutdown.
Signed-off-by: Lukas Straub
Acked-by: Stefan Hajnoczi
Reviewed-by: Daniel P. Berrangé
---
io/channel-tls.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/io/channel-tls.c
Migration and yank code assume that qio_channel_shutdown is thread
-safe and can be called from qmp oob handler. Document this after
checking the code.
Signed-off-by: Lukas Straub
Acked-by: Stefan Hajnoczi
Reviewed-by: Daniel P. Berrangé
---
include/io/channel.h | 5 -
1 file changed, 4
Register yank functions on sockets to shut them down.
Signed-off-by: Lukas Straub
Acked-by: Stefan Hajnoczi
Acked-by: Dr. David Alan Gilbert
---
migration/channel.c | 13 +
migration/migration.c | 25 +
migration/multifd.c | 10
The yank feature allows to recover from hanging qemu by "yanking"
at various parts. Other qemu systems can register themselves and
multiple yank functions. Then all yank functions for selected
instances can be called by the 'yank' out-of-band qmp command.
Available instances can be queried by a
Register a yank function to shutdown the socket on yank.
Signed-off-by: Lukas Straub
Acked-by: Stefan Hajnoczi
---
chardev/char-socket.c | 35 +++
1 file changed, 35 insertions(+)
diff --git a/chardev/char-socket.c b/chardev/char-socket.c
index
Register a yank function which shuts down the socket and sets
s->state = NBD_CLIENT_QUIT. This is the same behaviour as if an
error occured.
Signed-off-by: Lukas Straub
Acked-by: Stefan Hajnoczi
---
block/nbd.c | 154 +++-
1 file changed, 93
Hello Everyone,
So here is v11.
@Eric Blake and @Marc-André Lureau: We still need ACKs for NBD and chardev.
Changes:
v11:
-squashed MAINTAINERS update into patch 1
-move qmp doc of yank before misc
-add title for qmp docs
-change "Since:" to 6.0
-add Reviewed-by tags
v10:
-moved from
g_queue_remove needs to look up the list entry first, but we
already have it as result and can remove it directly with
g_queue_delete_link.
Signed-off-by: Lukas Straub
---
net/colo-compare.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/colo-compare.c
Additional to removing the packet from the secondary queue,
we also need to free it.
Signed-off-by: Lukas Straub
---
net/colo-compare.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/colo-compare.c b/net/colo-compare.c
index 337025b44f..eed0fbb27b 100644
--- a/net/colo-compare.c
+++
Hello Everyone,
This fixes a memory leak for non-tcp packets and optimizes the removal from
the queue.
Lukas Straub (2):
net/colo-compare.c: Fix memory leak for non-tcp packet
net/colo-compare.c: Optimize removal of secondary packet
net/colo-compare.c | 3 ++-
1 file changed, 2
Dear all,
yesterday I tried to build new QEMU installers for Windows and noticed
two regressions which break my build process:
*** Change in handling of --extra-cflags
Running `configure [...] --extra-cflags="-I /xyz"` results in compiler
flags `-I [...] /xyz`, so the `-I` and `/xyz` are
Public bug reported:
On windows with -accel whpx, "-cpu" is ignored without any messages.
Guest recognizes features as same as host's.
Confirmed on v5.2.0-rc1.
I suggest qemu may do,
- Warn with incompatible -cpu options were given.
- Enhance cpuid handling.
Background:
I was investigated
Public bug reported:
I am building and using qemu on Windows 10 via git.
Building for targeting windows, on debian.
Since meson is introduced, my executable, qemu-system-x86_64.exe, tends to
ignore hotkeys
(like CTRL+ATL+G, CTRL+ALT+2)
As far as I have been investigating the issue, I am
On Mon, 02 Nov 2020 07:33:54 +0100
Markus Armbruster wrote:
> Lukas Straub writes:
>
> > I'll maintain this for now as the colo usecase is the first user
> > of this functionality.
> >
> > Signed-off-by: Lukas Straub
> > Acked-by: Stefan Hajnoczi
> > ---
> > MAINTAINERS | 7 +++
> > 1
On Mon, 02 Nov 2020 07:32:55 +0100
Markus Armbruster wrote:
> Lukas Straub writes:
>
> > The yank feature allows to recover from hanging qemu by "yanking"
> > at various parts. Other qemu systems can register themselves and
> > multiple yank functions. Then all yank functions for selected
> >
97 matches
Mail list logo
