Re: [PATCH] tests/acceptance: Re-enable the microblaze test

2021-02-05 Thread Philippe Mathieu-Daudé
On 1/28/21 4:28 PM, Thomas Huth wrote: > The microblaze kernel sometimes gets stuck during boot (ca. 1 out of 200 > times), so we disabled the corresponding acceptance tests some months > ago. However, it's likely better to check that the kernel is still > starting than to not testing it at all

[PATCH 11/24] hw/arm/mps2-tz: Correct wrong interrupt numbers for DMA and SPI

2021-02-05 Thread Peter Maydell
On the MPS2 boards, the first 32 interrupt lines are entirely internal to the SSE; interrupt lines for devices outside the SSE start at 32. In the application notes that document each FPGA image, the interrupt wiring is documented from the point of view of the CPU, so '0' is the first of the

[PATCH v2 3/8] scripts/tracetool: Replace the word 'whitelist'

2021-02-05 Thread Philippe Mathieu-Daudé
Follow the inclusive terminology from the "Conscious Language in your Open Source Projects" guidelines [*] and replace the words "whitelist" appropriately. [*] https://github.com/conscious-lang/conscious-lang-docs/blob/main/faq.md Reviewed-by: Daniel P. Berrangé Reviewed-by: Stefan Hajnoczi

Re: [PATCH 0/1] tests/acceptance/boot_linux: Switch to Fedora 32

2021-02-05 Thread Daniel P . Berrangé
On Fri, Feb 05, 2021 at 05:54:24PM +0100, Philippe Mathieu-Daudé wrote: > Hi Wainer, > > On 1/28/21 11:06 PM, Daniele Buono wrote: > > On 1/28/2021 3:19 PM, Wainer dos Santos Moschetta wrote: > >> Hi, > >> > >> On 1/26/21 10:09 PM, Daniele Buono wrote: > >>> Local acceptance tests run with "make

[PATCH 16/24] hw/arm/mps2-tz: Make RAM arrangement board-specific

2021-02-05 Thread Peter Maydell
The AN505 and AN521 have the same layout of RAM; the AN524 does not. Replace the current hard-coding of where the RAM is and which parts of it are behind which MPCs with a data-driven approach. Signed-off-by: Peter Maydell --- hw/arm/mps2-tz.c | 175

[PATCH v5] qga: Utilize QAPI_LIST_APPEND in qmp_guest_network_get_interfaces

2021-02-05 Thread Eric Blake
I found another spot that can benefit from using our macros instead of open-coding qapi list creation. Signed-off-by: Eric Blake --- Marked v5 because it missed commit 95b3a8c8a82, which was v4: https://lists.gnu.org/archive/html/qemu-devel/2021-01/msg06574.html qga/commands-posix.c | 75

[PATCH 09/24] hw/arm/mps2-tz: Make number of IRQs board-specific

2021-02-05 Thread Peter Maydell
The AN524 has more interrupt lines than the AN505 and AN521; make numirq board-specific rather than a compile-time constant. Since the difference is small (92 on the current boards and 95 on the new one) we don't dynamically allocate the cpu_irq_splitter[] array but leave it as a fixed length

[PATCH v2 7/8] tests/fp/fp-test: Replace the word 'blacklist'

2021-02-05 Thread Philippe Mathieu-Daudé
Follow the inclusive terminology from the "Conscious Language in your Open Source Projects" guidelines [*] and replace the word "blacklist" appropriately. [*] https://github.com/conscious-lang/conscious-lang-docs/blob/main/faq.md Acked-by: Alex Bennée Reviewed-by: Daniel P. Berrangé

[PATCH 18/24] hw/arm/mps2-tz: Support ROMs as well as RAMs

2021-02-05 Thread Peter Maydell
The AN505 and AN521 don't have any read-only memory, but the AN524 does; add a flag to ROMInfo to mark a region as ROM. Signed-off-by: Peter Maydell --- hw/arm/mps2-tz.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/hw/arm/mps2-tz.c b/hw/arm/mps2-tz.c index b46b32746e0..ce5e804c734

[PATCH 04/24] hw/arm/mps2-tz: Make the OSCCLK settings be configurable per-board

2021-02-05 Thread Peter Maydell
The AN505 and AN511 happen to share the same OSCCLK values, but the AN524 will have a different set (and more of them), so split the settings out to be per-board. Signed-off-by: Peter Maydell --- hw/arm/mps2-tz.c | 23 ++- 1 file changed, 18 insertions(+), 5 deletions(-)

[PATCH] arm: Update infocenter.arm.com URLs

2021-02-05 Thread Peter Maydell
Update infocenter.arm.com URLs for various pieces of Arm documentation to the new developer.arm.com equivalents. (There is a redirection in place from the old URLs, but we might as well update our comments in case the redirect ever disappears in future.) This patch covers all the URLs which are

[PATCH 14/24] hw/arm/mps2-tz: Size the uart-irq-orgate based on the number of UARTs

2021-02-05 Thread Peter Maydell
We create an OR gate to wire together the overflow IRQs for all the UARTs on the board; this has to have twice the number of inputs as there are UARTs, since each UART feeds it a TX overflow and an RX overflow interrupt line. Replace the hardcoded '10' with a calculation based on the size of the

[PATCH 20/24] hw/arm/mps2-tz: Add new mps3-an524 board

2021-02-05 Thread Peter Maydell
Add support for the mps3-an524 board; this is an SSE-200 based FPGA image, like the existing mps2-an521. It has a usefully larger amount of RAM, and a PL031 RTC, as well as some more minor differences. In real hardware this image runs on a newer generation of the FPGA board, the MPS3 rather than

[PATCH 02/24] hw/misc/mps2-scc: Support configurable number of OSCCLK values

2021-02-05 Thread Peter Maydell
Currently the MPS2 SCC device implements a fixed number of OSCCLK values (3). The variant of this device in the MPS3 AN524 board has 6 OSCCLK values. Switch to using a PROP_ARRAY, which allows board code to specify how large the OSCCLK array should be as well as its values. With a

Re: acceptance-system-fedora and acceptance-system-centos failing sporadically with timeout?

2021-02-05 Thread Philippe Mathieu-Daudé
On 2/5/21 5:49 PM, Thomas Huth wrote: > On 05/02/2021 17.43, Philippe Mathieu-Daudé wrote: >> Cc'ing Avocado team & John (Python inferior exit delay?). >> >> On 1/28/21 11:10 AM, Thomas Huth wrote: >>> On 28/01/2021 10.45, Claudio Fontana wrote: is it just me, or is the CI sometimes

[PATCH 21/24] hw/arm/mps2-tz: Stub out USB controller for mps3-an524

2021-02-05 Thread Peter Maydell
The AN524 has a USB controller (an ISP1763); we don't have a model of it but we should provide a stub "unimplemented-device" for it. This is slightly complicated because the USB controller shares a PPC port with the ethernet controller. Implement a make_* function which provides creates a

[PATCH 05/24] hw/misc/mps2-fpgaio: Make number of LEDs configurable by board

2021-02-05 Thread Peter Maydell
The MPS2 board has 2 LEDs, but the MPS3 board has 10 LEDs. The FPGAIO device is similar on both sets of boards, but the LED0 register has correspondingly more bits that have an effect. Add a device property for number of LEDs. Signed-off-by: Peter Maydell --- include/hw/misc/mps2-fpgaio.h |

[PATCH 01/24] hw/arm/mps2-tz: Make SYSCLK frequency board-specific

2021-02-05 Thread Peter Maydell
The AN524 has a different SYSCLK frequency from the AN505 and AN521; make the SYSCLK frequency a field in the MPS2TZMachineClass rather than a compile-time constant so we can support the AN524. Signed-off-by: Peter Maydell --- hw/arm/mps2-tz.c | 10 ++ 1 file changed, 6 insertions(+), 4

[PATCH 15/24] hw/arm/mps2-tz: Allow boards to have different PPCInfo data

2021-02-05 Thread Peter Maydell
The AN505 and AN521 have the same device layout, but the AN524 is somewhat different. Allow for more than one PPCInfo array, which can be selected based on the board type. Signed-off-by: Peter Maydell --- We can't just put the arrays at file-scope and set up pointers to them in the

[PATCH 19/24] hw/arm/mps2-tz: Get armv7m_load_kernel() size argument from RAMInfo

2021-02-05 Thread Peter Maydell
The armv7m_load_kernel() function takes a mem_size argument which it expects to be the size of the memory region at guest address 0. (It uses this argument only as a limit on how large a raw image file it can load at address zero). Instead of hardcoding this value, find the RAMInfo corresponding

[PATCH 00/24] hw/arm: New board model mps3-an524

2021-02-05 Thread Peter Maydell
This patchseries implements a new board model in the mps2/mps3 family, based on Application Note AN524: https://developer.arm.com/documentation/dai0524/latest/ Like the other MPS models, this board is an FPGA image; the AN524 image is based on the SSE-200, like the mps2-an521, but it is for the

Re: Detecting Faulting Instructions From Plugins

2021-02-05 Thread Alex Bennée
Aaron Lindsay writes: > On Feb 05 15:03, Alex Bennée wrote: >> Aaron Lindsay writes: >> > Assuming you're right that TCG is detecting "a io_readx/io_writex when >> > ->can_do_io is not true", could we detect this case when it occurs and >> > omit the instruction callbacks for the

[PATCH 17/24] hw/arm/mps2-tz: Set MachineClass default_ram info from RAMInfo data

2021-02-05 Thread Peter Maydell
Instead of hardcoding the MachineClass default_ram_size and default_ram_id fields, set them on class creation by finding the entry in the RAMInfo array which is marked as being the QEMU system RAM. Signed-off-by: Peter Maydell --- hw/arm/mps2-tz.c | 24 ++-- 1 file changed,

[PATCH 06/24] hw/misc/mps2-fpgaio: Support SWITCH register

2021-02-05 Thread Peter Maydell
MPS3 boards have an extra SWITCH register in the FPGAIO block which reports the value of some switches. Implement this, governed by a property the board code can use to specify whether whether it exists. Signed-off-by: Peter Maydell --- include/hw/misc/mps2-fpgaio.h | 1 +

[PULL v3 25/27] multi-process: Retrieve PCI info from remote process

2021-02-05 Thread Stefan Hajnoczi
From: Jagannathan Raman Retrieve PCI configuration info about the remote device and configure the Proxy PCI object based on the returned information Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Reviewed-by: Stefan Hajnoczi Message-id:

[PATCH 24/24] hw/arm/mps2: Update old infocenter.arm.com URLs

2021-02-05 Thread Peter Maydell
Update old infocenter.arm.com URLs to the equivalent developer.arm.com ones (the old URLs should redirect, but we might as well avoid the redirection notice, and the new URLs are pleasantly shorter). This commit covers the links to the MPS2 board TRM, the various Application Notes, the IoTKit and

[PATCH 07/24] hw/arm/mps2-tz: Make FPGAIO switch and LED config per-board

2021-02-05 Thread Peter Maydell
Set the FPGAIO num-leds and have-switches properties explicitly per-board, rather than relying on the defaults. The AN505 and AN521 both have the same settings as the default values, but the AN524 will be different. Signed-off-by: Peter Maydell --- hw/arm/mps2-tz.c | 9 + 1 file

Re: [PULL v2 00/27] Block patches

2021-02-05 Thread Daniel P . Berrangé
On Fri, Feb 05, 2021 at 05:52:59PM +0100, Thomas Huth wrote: > On 05/02/2021 17.23, Peter Maydell wrote: > > On Fri, 5 Feb 2021 at 16:21, Stefan Hajnoczi wrote: > > > Thanks, I update the patch in question. > > > > > > It looks like the GitLab CI doesn't include a clang version that > > >

[PULL v3 24/27] multi-process: create IOHUB object to handle irq

2021-02-05 Thread Stefan Hajnoczi
From: Jagannathan Raman IOHUB object is added to manage PCI IRQs. It uses KVM_IRQFD ioctl to create irqfd to injecting PCI interrupts to the guest. IOHUB object forwards the irqfd to the remote process. Remote process uses this fd to directly send interrupts to the guest, bypassing QEMU.

[PATCH 08/24] hw/arm/mps2-tz: Condition IRQ splitting on number of CPUs, not board type

2021-02-05 Thread Peter Maydell
In the mps2-tz board code, we handle devices whose interrupt lines must be wired to all CPUs by creating IRQ splitter devices for the AN521, because it has 2 CPUs, but wiring the device IRQ directly to the SSE/IoTKit input for the AN505, which has only 1 CPU. We can avoid making an explicit check

[PATCH 13/24] hw/arm/mps2-tz: Move device IRQ info to data structures

2021-02-05 Thread Peter Maydell
Move the specification of the IRQ information for the uart, ethernet, dma and spi devices to the data structures. (The other devices handled by the PPCPortInfo structures don't have any interrupt lines we need to wire up.) Signed-off-by: Peter Maydell --- hw/arm/mps2-tz.c | 52

Re: [PATCH 0/1] tests/acceptance/boot_linux: Switch to Fedora 32

2021-02-05 Thread Philippe Mathieu-Daudé
Hi Wainer, On 1/28/21 11:06 PM, Daniele Buono wrote: > On 1/28/2021 3:19 PM, Wainer dos Santos Moschetta wrote: >> Hi, >> >> On 1/26/21 10:09 PM, Daniele Buono wrote: >>> Local acceptance tests run with "make check-acceptance" are now >>> showing some cases canceled like the following: >>> >>>

[PULL v3 23/27] multi-process: Synchronize remote memory

2021-02-05 Thread Stefan Hajnoczi
From: Jagannathan Raman Add ProxyMemoryListener object which is used to keep the view of the RAM in sync between QEMU and remote process. A MemoryListener is registered for system-memory AddressSpace. The listener sends SYNC_SYSMEM message to the remote process when memory listener commits the

[PATCH 12/24] hw/arm/mps2-tz: Allow PPCPortInfo structures to specify device interrupts

2021-02-05 Thread Peter Maydell
The mps2-tz code uses PPCPortInfo data structures to define what devices are present and how they are wired up. Currently we use these to specify device types and addresses, but hard-code the interrupt line wiring in each make_* helper function. This works for the two boards we have at the

Re: [PATCH 2/9] tests/qtest: Restrict xlnx-can-test to TCG builds

2021-02-05 Thread Alistair Francis
On Fri, Feb 5, 2021 at 6:45 AM Philippe Mathieu-Daudé wrote: > > The Xilinx CAN controller test is uses the ZCU102 board which is > based on a ZynqMP SoC. In the default configuration - used by this > test - this SoC creates 2 Cortex R5F cores. Such cores are not > v8A archicture, thus can not be

[PULL v3 22/27] multi-process: PCI BAR read/write handling for proxy & remote endpoints

2021-02-05 Thread Stefan Hajnoczi
From: Jagannathan Raman Proxy device object implements handler for PCI BAR writes and reads. The handler uses BAR_WRITE/BAR_READ message to communicate to the remote process with the BAR address and value to be written/read. The remote process implements handler for BAR_WRITE/BAR_READ message.

Re: [PATCH v2 1/5] travis.yml: Move gprof/gcov test across to gitlab

2021-02-05 Thread Alex Bennée
Thomas Huth writes: > From: Philippe Mathieu-Daudé > > Similarly to commit 8cdb2cef3f1, move the gprof/gcov test to GitLab. > > The coverage-summary.sh script is not Travis-CI specific, make it > generic. > > Signed-off-by: Philippe Mathieu-Daudé > Message-Id:

[PATCH 10/24] hw/misc/mps2-scc: Implement CFG_REG5 and CFG_REG6 for MPS3 AN524

2021-02-05 Thread Peter Maydell
The AN524 version of the SCC interface has different behaviour for some of the CFG registers; implement it. Each board in this family can have minor differences in the meaning of the CFG registers, so rather than trying to specify all the possible semantics via individual device properties, we

Re: [PULL v2 00/27] Block patches

2021-02-05 Thread Thomas Huth
On 05/02/2021 17.23, Peter Maydell wrote: On Fri, 5 Feb 2021 at 16:21, Stefan Hajnoczi wrote: Thanks, I update the patch in question. It looks like the GitLab CI doesn't include a clang version that produces this error because the pipeline passed for me:

[PULL v3 19/27] multi-process: introduce proxy object

2021-02-05 Thread Stefan Hajnoczi
From: Elena Ufimtseva Defines a PCI Device proxy object as a child of TYPE_PCI_DEVICE. Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman Signed-off-by: John G Johnson Reviewed-by: Stefan Hajnoczi Message-id:

[PATCH 03/24] hw/arm/mps2-tz: Correct the OSCCLK settings for mps2-an505 and mps2-an511

2021-02-05 Thread Peter Maydell
We were previously using the default OSCCLK settings, which are correct for the older MPS2 boards (mps2-an385, mps2-an386, mps2-an500, mps2-an511), but wrong for the mps2-an505 and mps2-511 implemented in mps2-tz.c. Now we're setting the values explicitly we can fix them to be correct.

[PULL v3 26/27] multi-process: perform device reset in the remote process

2021-02-05 Thread Stefan Hajnoczi
From: Elena Ufimtseva Perform device reset in the remote process when QEMU performs device reset. This is required to reset the internal state (like registers, etc...) of emulated devices Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman

[PULL v3 16/27] multi-process: Initialize message handler in remote device

2021-02-05 Thread Stefan Hajnoczi
From: Jagannathan Raman Initializes the message handler function in the remote process. It is called whenever there's an event pending on QIOChannel that registers this function. Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Reviewed-by: Stefan

Re: acceptance-system-fedora and acceptance-system-centos failing sporadically with timeout?

2021-02-05 Thread Thomas Huth
On 05/02/2021 17.43, Philippe Mathieu-Daudé wrote: Cc'ing Avocado team & John (Python inferior exit delay?). On 1/28/21 11:10 AM, Thomas Huth wrote: On 28/01/2021 10.45, Claudio Fontana wrote: is it just me, or is the CI sometimes failing with timeout? Fedora:

Re: [PATCH 2/9] tests/qtest: Restrict xlnx-can-test to TCG builds

2021-02-05 Thread Peter Maydell
On Fri, 5 Feb 2021 at 14:43, Philippe Mathieu-Daudé wrote: > > The Xilinx CAN controller test is uses the ZCU102 board which is > based on a ZynqMP SoC. In the default configuration - used by this > test - this SoC creates 2 Cortex R5F cores. Such cores are not > v8A archicture, thus can not be

[PULL v3 15/27] multi-process: define MPQemuMsg format and transmission functions

2021-02-05 Thread Stefan Hajnoczi
From: Elena Ufimtseva Defines MPQemuMsg, which is the message that is sent to the remote process. This message is sent over QIOChannel and is used to command the remote process to perform various tasks. Define transmission functions used by proxy and by remote. Signed-off-by: Jagannathan Raman

[PULL v3 17/27] multi-process: Associate fd of a PCIDevice with its object

2021-02-05 Thread Stefan Hajnoczi
From: Jagannathan Raman Associate the file descriptor for a PCIDevice in remote process with DeviceState object. Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Reviewed-by: Stefan Hajnoczi Message-id:

[PULL v3 18/27] multi-process: setup memory manager for remote device

2021-02-05 Thread Stefan Hajnoczi
From: Jagannathan Raman SyncSysMemMsg message format is defined. It is used to send file descriptors of the RAM regions to remote device. RAM on the remote device is configured with a set of file descriptors. Old RAM regions are deleted and new regions, each with an fd, is added to the RAM.

[PULL v3 27/27] docs: fix Parallels Image "dirty bitmap" section

2021-02-05 Thread Stefan Hajnoczi
From: "Denis V. Lunev" Original specification says that l1 table size if 64 * l1_size, which is obviously wrong. The size of the l1 entry is 64 _bits_, not bytes. Thus 64 is to be replaces with 8 as specification says about bytes. There is also minor tweak, field name is renamed from l1 to

[PULL v3 14/27] io: add qio_channel_readv_full_all_eof & qio_channel_readv_full_all helpers

2021-02-05 Thread Stefan Hajnoczi
From: Elena Ufimtseva Adds qio_channel_readv_full_all_eof() and qio_channel_readv_full_all() to read both data and FDs. Refactors existing code to use these helpers. Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Acked-by: Daniel P. Berrangé

[PULL v3 11/27] multi-process: setup PCI host bridge for remote device

2021-02-05 Thread Stefan Hajnoczi
From: Jagannathan Raman PCI host bridge is setup for the remote device process. It is implemented using remote-pcihost object. It is an extension of the PCI host bridge setup by QEMU. Remote-pcihost configures a PCI bus which could be used by the remote PCI device to latch on to. Signed-off-by:

[PULL v3 06/27] get_maintainer: update repo URL to GitLab

2021-02-05 Thread Stefan Hajnoczi
qemu.org is running out of bandwidth and the QEMU project is moving towards a gating CI on GitLab. Use the GitLab repos instead of qemu.org (they will become mirrors). Signed-off-by: Stefan Hajnoczi Reviewed-by: Wainer dos Santos Moschetta Reviewed-by: Thomas Huth Reviewed-by: Philippe

[PULL v3 21/27] multi-process: Forward PCI config space acceses to the remote process

2021-02-05 Thread Stefan Hajnoczi
From: Elena Ufimtseva The Proxy Object sends the PCI config space accesses as messages to the remote process over the communication channel Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman Signed-off-by: John G Johnson Reviewed-by: Stefan Hajnoczi Message-id:

[PULL v3 10/27] multi-process: Add config option for multi-process QEMU

2021-02-05 Thread Stefan Hajnoczi
From: Jagannathan Raman Add configuration options to enable or disable multiprocess QEMU code Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Signed-off-by: Elena Ufimtseva Reviewed-by: Stefan Hajnoczi Message-id:

[PULL v3 13/27] io: add qio_channel_writev_full_all helper

2021-02-05 Thread Stefan Hajnoczi
From: Elena Ufimtseva Adds qio_channel_writev_full_all() to transmit both data and FDs. Refactors existing code to use this helper. Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Reviewed-by: Stefan Hajnoczi Acked-by: Daniel P. Berrangé

[PULL v3 05/27] pc-bios: update mirror URLs to GitLab

2021-02-05 Thread Stefan Hajnoczi
qemu.org is running out of bandwidth and the QEMU project is moving towards a gating CI on GitLab. Use the GitLab repos instead of qemu.org (they will become mirrors). Signed-off-by: Stefan Hajnoczi Reviewed-by: Wainer dos Santos Moschetta Reviewed-by: Thomas Huth Reviewed-by: Philippe

[PULL v3 20/27] multi-process: add proxy communication functions

2021-02-05 Thread Stefan Hajnoczi
From: Elena Ufimtseva Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman Signed-off-by: John G Johnson Reviewed-by: Stefan Hajnoczi Message-id: d54edb4176361eed86b903e8f27058363b6c83b3.1611938319.git.jag.ra...@oracle.com Signed-off-by: Stefan Hajnoczi ---

[PULL v3 09/27] memory: alloc RAM from file at offset

2021-02-05 Thread Stefan Hajnoczi
From: Jagannathan Raman Allow RAM MemoryRegion to be created from an offset in a file, instead of allocating at offset of 0 by default. This is needed to synchronize RAM between QEMU & remote process. Signed-off-by: Jagannathan Raman Signed-off-by: John G Johnson Signed-off-by: Elena

[PULL v3 04/27] docs: update README to use GitLab repo URLs

2021-02-05 Thread Stefan Hajnoczi
qemu.org is running out of bandwidth and the QEMU project is moving towards a gating CI on GitLab. Use the GitLab repos instead of qemu.org (they will become mirrors). Signed-off-by: Stefan Hajnoczi Reviewed-by: Wainer dos Santos Moschetta Reviewed-by: Thomas Huth Reviewed-by: Philippe

Re: [PULL v2 00/16] pc,virtio,pci: fixes, features,code removal

2021-02-05 Thread Peter Maydell
tracking branch > 'remotes/kraxel/tags/vga-ui-20210205-pull-request' into staging (2021-02-05 > 10:09:16 +) > > are available in the Git repository at: > > git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream > > for you to fetch changes up to 277a582

[PULL v3 12/27] multi-process: setup a machine object for remote device process

2021-02-05 Thread Stefan Hajnoczi
From: Jagannathan Raman x-remote-machine object sets up various subsystems of the remote device process. Instantiate PCI host bridge object and initialize RAM, IO & PCI memory regions. Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Signed-off-by: Elena Ufimtseva Reviewed-by:

Re: acceptance-system-fedora and acceptance-system-centos failing sporadically with timeout?

2021-02-05 Thread Philippe Mathieu-Daudé
Cc'ing Avocado team & John (Python inferior exit delay?). On 1/28/21 11:10 AM, Thomas Huth wrote: > On 28/01/2021 10.45, Claudio Fontana wrote: >> >> is it just me, or is the CI sometimes failing with timeout? >> >> Fedora: >> https://gitlab.com/hw-claudio/qemu/-/jobs/986936506 > > I've sent a

[PULL v3 08/27] multi-process: add configure and usage information

2021-02-05 Thread Stefan Hajnoczi
From: Elena Ufimtseva Adds documentation explaining the command-line arguments needed to use multi-process. Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman Signed-off-by: John G Johnson Reviewed-by: Stefan Hajnoczi Message-id:

[PATCH v2 09/10] block/backup: implement .cancel job handler

2021-02-05 Thread Vladimir Sementsov-Ogievskiy
Cancel in-flight io on target to not waste the time. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake --- block/backup.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/block/backup.c b/block/backup.c index cc525d5544..94e6dcd72e 100644 --- a/block/backup.c

[PULL v3 07/27] multi-process: add the concept description to docs/devel/qemu-multiprocess

2021-02-05 Thread Stefan Hajnoczi
From: John G Johnson Signed-off-by: John G Johnson Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman Reviewed-by: Stefan Hajnoczi Message-id: 02a68adef99f5df6a380bf8fd7b90948777e411c.1611938319.git.jag.ra...@oracle.com Signed-off-by: Stefan Hajnoczi --- MAINTAINERS

[PATCH v2] net/macos: implement vmnet-based network device

2021-02-05 Thread phillip . ennen
From: Phillip Tennen This patch implements a new netdev device, reachable via -netdev vmnet-macos, that’s backed by macOS’s vmnet framework. The vmnet framework provides native bridging support, and its usage in this patch is intended as a replacement for attempts to use a tap device via the

[PULL v3 03/27] gitlab-ci: remove redundant GitLab repo URL command

2021-02-05 Thread Stefan Hajnoczi
It is no longer necessary to point .gitmodules at GitLab repos when running in GitLab CI since they are now used all the time. Signed-off-by: Stefan Hajnoczi Reviewed-by: Wainer dos Santos Moschetta Reviewed-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Message-id:

[PATCH v2 07/10] iotests.py: qemu_nbd_popen: remove pid file after use

2021-02-05 Thread Vladimir Sementsov-Ogievskiy
To not interfere with other qemu_nbd_popen() calls in same test. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake --- tests/qemu-iotests/iotests.py | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tests/qemu-iotests/iotests.py

[PULL v3 02/27] gitmodules: use GitLab repos instead of qemu.org

2021-02-05 Thread Stefan Hajnoczi
qemu.org is running out of bandwidth and the QEMU project is moving towards a gating CI on GitLab. Use the GitLab repos instead of qemu.org (they will become mirrors). Signed-off-by: Stefan Hajnoczi Reviewed-by: Wainer dos Santos Moschetta Reviewed-by: Thomas Huth Reviewed-by: Philippe

[PULL v3 00/27] Block patches

2021-02-05 Thread Stefan Hajnoczi
The following changes since commit e2c5093c993ef646e4e28f7aa78429853bcc06ac: iotests: 30: drop from auto group (and effectively from make check) (2021-02-05 15:16:13 +) are available in the Git repository at: https://gitlab.com/stefanha/qemu.git tags/block-pull-request for you to

[PATCH v2 08/10] iotests/264: add mirror-cancel test-case

2021-02-05 Thread Vladimir Sementsov-Ogievskiy
Check that cancel doesn't wait for 10s of nbd reconnect timeout. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake --- tests/qemu-iotests/264 | 38 ++ tests/qemu-iotests/264.out | 4 ++-- 2 files changed, 32 insertions(+), 10

[PATCH v2 04/10] job: add .cancel handler for the driver

2021-02-05 Thread Vladimir Sementsov-Ogievskiy
To be used in mirror in the following commit to cancel in-flight io on target to not waste the time. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/qemu/job.h | 5 + job.c | 3 +++ 2 files changed, 8 insertions(+) diff --git a/include/qemu/job.h b/include/qemu/job.h

[PULL v3 01/27] .github: point Repo Lockdown bot to GitLab repo

2021-02-05 Thread Stefan Hajnoczi
Use the GitLab repo URL as the main repo location in order to reduce load on qemu.org. Signed-off-by: Stefan Hajnoczi Reviewed-by: Wainer dos Santos Moschetta Reviewed-by: Thomas Huth Message-id: 2021015017.156802-2-stefa...@redhat.com Signed-off-by: Stefan Hajnoczi ---

[PATCH v2 10/10] iotests/264: add backup-cancel test-case

2021-02-05 Thread Vladimir Sementsov-Ogievskiy
Check that cancel doesn't wait for 10s of nbd reconnect timeout. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake --- tests/qemu-iotests/264 | 21 ++--- tests/qemu-iotests/264.out | 4 ++-- 2 files changed, 16 insertions(+), 9 deletions(-) diff --git

[PATCH v2 05/10] block/mirror: implement .cancel job handler

2021-02-05 Thread Vladimir Sementsov-Ogievskiy
Cancel in-flight io on target to not waste the time. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake --- block/mirror.c | 9 + 1 file changed, 9 insertions(+) diff --git a/block/mirror.c b/block/mirror.c index 8e1ad6eceb..9faffe4707 100644 --- a/block/mirror.c +++

[PATCH v2 03/10] block/raw-format: implement .bdrv_cancel_in_flight handler

2021-02-05 Thread Vladimir Sementsov-Ogievskiy
We are going to cancel in-flight requests on mirror nbd target on job cancel. Still nbd is often used not directly but as raw-format child. So, add pass-through handler here. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake --- block/raw-format.c | 6 ++ 1 file changed,

[PATCH v2 02/10] block/nbd: implement .bdrv_cancel_in_flight

2021-02-05 Thread Vladimir Sementsov-Ogievskiy
Just stop waiting for connection in existing requests. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake --- block/nbd.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/block/nbd.c b/block/nbd.c index b3cbbeb4b0..c26dc5a54f 100644 --- a/block/nbd.c +++

[PATCH v2 00/10] mirror: cancel nbd reconnect

2021-02-05 Thread Vladimir Sementsov-Ogievskiy
Hi all! The problem Assume we have mirror job with nbd target node with enabled reconnect. Connection failed. So, all current requests to nbd node are waiting for nbd driver to reconnect. And they will wait for reconnect-delay time specified in nbd blockdev options. This timeout may be long

[PATCH v2 06/10] iotests/264: move to python unittest

2021-02-05 Thread Vladimir Sementsov-Ogievskiy
We are going to add more test cases, so use the library supporting test cases. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake --- tests/qemu-iotests/264 | 93 ++ tests/qemu-iotests/264.out | 20 ++-- 2 files changed, 58

Re: [PATCH] tests/acceptance: Increase the timeout in the replay tests

2021-02-05 Thread Philippe Mathieu-Daudé
On 1/27/21 7:52 AM, Thomas Huth wrote: > Our gitlab-CI just showed a failed test_ppc_mac99 since it was apparently > killed some few seconds before the test finished. Allow it some more > time to complete. > > Signed-off-by: Thomas Huth > --- > Seen in this test log: > >

Re: [PATCH v2 29/36] blockdev: qmp_x_blockdev_reopen: acquire all contexts

2021-02-05 Thread Kevin Wolf
Am 05.02.2021 um 17:16 hat Vladimir Sementsov-Ogievskiy geschrieben: > 05.02.2021 19:01, Kevin Wolf wrote: > > Am 27.11.2020 um 15:45 hat Vladimir Sementsov-Ogievskiy geschrieben: > > > During reopen we may add backing bs from other aio context, which may > > > lead to changing original context of

[PATCH v2 01/10] block: add new BlockDriver handler: bdrv_cancel_in_flight

2021-02-05 Thread Vladimir Sementsov-Ogievskiy
It will be used to stop retrying NBD requests on mirror cancel. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake --- include/block/block.h | 3 +++ include/block/block_int.h | 9 + block/io.c| 11 +++ 3 files changed, 23 insertions(+)

Re: [PATCH v2 28/36] block: add bdrv_set_backing_noperm() transaction action

2021-02-05 Thread Kevin Wolf
Am 05.02.2021 um 17:06 hat Vladimir Sementsov-Ogievskiy geschrieben: > 05.02.2021 17:00, Kevin Wolf wrote: > > Am 27.11.2020 um 15:45 hat Vladimir Sementsov-Ogievskiy geschrieben: > > > Split out no-perm part of bdrv_set_backing_hd() as a separate > > > transaction action. Note the in case of

Re: [PATCH 19/33] migration: push Error **errp into check_section_footer()

2021-02-05 Thread Philippe Mathieu-Daudé
On 2/4/21 6:18 PM, Daniel P. Berrangé wrote: > This is an incremental step in converting vmstate loading code to report > via Error objects instead of printing directly to the console/monitor. > > Signed-off-by: Daniel P. Berrangé > --- > migration/savevm.c | 22 ++ > 1 file

Re: [PATCH v2 28/36] block: add bdrv_set_backing_noperm() transaction action

2021-02-05 Thread Kevin Wolf
Am 27.11.2020 um 15:45 hat Vladimir Sementsov-Ogievskiy geschrieben: > Split out no-perm part of bdrv_set_backing_hd() as a separate > transaction action. Note the in case of existing BdrvChild we reuse it, > not recreate, just to do less actions. > > Signed-off-by: Vladimir Sementsov-Ogievskiy

Re: [PATCH 14/33] migration: push Error **errp into loadvm_postcopy_ram_handle_discard()

2021-02-05 Thread Philippe Mathieu-Daudé
On 2/4/21 6:18 PM, Daniel P. Berrangé wrote: > This is an incremental step in converting vmstate loading code to report > via Error objects instead of printing directly to the console/monitor. > > Signed-off-by: Daniel P. Berrangé > --- > migration/savevm.c | 31 +++

Re: [PATCH 12/33] migration: push Error **errp into loadvm_postcopy_handle_listen()

2021-02-05 Thread Philippe Mathieu-Daudé
On 2/4/21 6:18 PM, Daniel P. Berrangé wrote: > This is an incremental step in converting vmstate loading code to report > via Error objects instead of printing directly to the console/monitor. > > Signed-off-by: Daniel P. Berrangé > --- > migration/savevm.c | 18 +++--- > 1 file

Re: [PATCH 13/33] migration: push Error **errp into loadvm_postcopy_handle_run()

2021-02-05 Thread Philippe Mathieu-Daudé
On 2/4/21 6:18 PM, Daniel P. Berrangé wrote: > This is an incremental step in converting vmstate loading code to report > via Error objects instead of printing directly to the console/monitor. > > Signed-off-by: Daniel P. Berrangé > --- > migration/savevm.c | 11 +++ > 1 file changed, 3

Re: [PULL v2 00/27] Block patches

2021-02-05 Thread Peter Maydell
On Fri, 5 Feb 2021 at 16:21, Stefan Hajnoczi wrote: > Thanks, I update the patch in question. > > It looks like the GitLab CI doesn't include a clang version that > produces this error because the pipeline passed for me: > https://gitlab.com/stefanha/qemu/-/pipelines/251524779 > > Is there

Re: [PATCH 10/33] migration: push Error **errp into loadvm_postcopy_handle_advise()

2021-02-05 Thread Philippe Mathieu-Daudé
On 2/4/21 6:18 PM, Daniel P. Berrangé wrote: > This is an incremental step in converting vmstate loading code to report > via Error objects instead of printing directly to the console/monitor. > > Signed-off-by: Daniel P. Berrangé > --- > migration/savevm.c | 43

Re: [PULL v2 00/27] Block patches

2021-02-05 Thread Stefan Hajnoczi
On Thu, Feb 04, 2021 at 05:35:31PM +, Peter Maydell wrote: > On Thu, 4 Feb 2021 at 15:43, Stefan Hajnoczi wrote: > > > > The following changes since commit db754f8ccaf2f073c9aed46a4389e9c0c2080399: > > > > Merge remote-tracking branch 'remotes/rth-gitlab/tags/pull-tcg-20210202' > > into

Re: [PATCH 08/33] migration: push Error **errp into loadvm_process_command()

2021-02-05 Thread Philippe Mathieu-Daudé
On 2/4/21 6:18 PM, Daniel P. Berrangé wrote: > This is an incremental step in converting vmstate loading code to report > via Error objects instead of printing directly to the console/monitor. > > Signed-off-by: Daniel P. Berrangé > --- > migration/savevm.c | 87

Re: [PULL v2 00/27] Block patches

2021-02-05 Thread Stefan Hajnoczi
On Thu, Feb 04, 2021 at 10:49:26AM -0800, elena wrote: > On Thu, Feb 04, 2021 at 05:35:31PM +, Peter Maydell wrote: > > On Thu, 4 Feb 2021 at 15:43, Stefan Hajnoczi wrote: > > > > > > The following changes since commit > > > db754f8ccaf2f073c9aed46a4389e9c0c2080399: > > > > > > Merge

Re: [PATCH v2 29/36] blockdev: qmp_x_blockdev_reopen: acquire all contexts

2021-02-05 Thread Vladimir Sementsov-Ogievskiy
05.02.2021 19:01, Kevin Wolf wrote: Am 27.11.2020 um 15:45 hat Vladimir Sementsov-Ogievskiy geschrieben: During reopen we may add backing bs from other aio context, which may lead to changing original context of top bs. We are going to move graph modification to prepare stage. So, it will be

Re: [PATCH 07/33] migration: push Error **errp into qemu_loadvm_section_part_end()

2021-02-05 Thread Philippe Mathieu-Daudé
On 2/4/21 6:18 PM, Daniel P. Berrangé wrote: > This is an incremental step in converting vmstate loading code to report > via Error objects instead of printing directly to the console/monitor. > > Signed-off-by: Daniel P. Berrangé > --- > migration/savevm.c | 26 +- > 1

Re: [RFC PATCH v1 01/01] PCIe DOE for PCIe and CXL 2.0

2021-02-05 Thread Jonathan Cameron
On Wed, 3 Feb 2021 23:53:53 -0500 Chris Browy wrote: > Hi Jonathan, > > Thanks for the review comments and we'll put out a v2 patch series > based on a genuine git send-email flow in a day or so and plan to include > - functionally separate patches > - new MSI-X support > - few bugs found in

Re: [PATCH v2 28/36] block: add bdrv_set_backing_noperm() transaction action

2021-02-05 Thread Vladimir Sementsov-Ogievskiy
05.02.2021 17:00, Kevin Wolf wrote: Am 27.11.2020 um 15:45 hat Vladimir Sementsov-Ogievskiy geschrieben: Split out no-perm part of bdrv_set_backing_hd() as a separate transaction action. Note the in case of existing BdrvChild we reuse it, not recreate, just to do less actions. Signed-off-by:

Re: [PATCH 1/9] tests/qtest/arm-cpu-features: Remove Cortex-A15 check

2021-02-05 Thread Philippe Mathieu-Daudé
On 2/5/21 4:33 PM, Andrew Jones wrote: > On Fri, Feb 05, 2021 at 04:15:45PM +0100, Philippe Mathieu-Daudé wrote: >> Hi Drew, >> >> On 2/5/21 3:59 PM, Andrew Jones wrote: >>> On Fri, Feb 05, 2021 at 03:43:37PM +0100, Philippe Mathieu-Daudé wrote: Support for ARMv7 has been dropped in commit

Re: About creating machines on the command line

2021-02-05 Thread Luc Michel
On 2/4/21 9:29 PM, John Snow wrote: On 2/3/21 12:09 PM, graf--- via wrote: On 03.02.21 17:55, Philippe Mathieu-Daudé wrote: On 1/11/21 3:50 PM, Luc Michel wrote: Hi, We would like to work on improving QEMU to be able to create custom machines from the command line. The goal here is to get

Re: [PATCH v2] hw/scsi/scsi-disk: Fix out of bounds access in mode_sense_page()

2021-02-05 Thread Alexander Bulekov
On 210204 2350, Philippe Mathieu-Daudé wrote: > Per the "SCSI Commands Reference Manual" (Rev. J) chapter 5.3 > "Mode parameters" and table 359 "Mode page codes and subpage > codes", the last page code is 0x3f. When using it as array index, > the array must have 0x40 elements. Replace the magic

<    1   2   3   4   >