Re: USB port claiming / set configuration problems

2021-03-08 Thread Ben Leslie
On Fri, 5 Mar 2021 at 11:50, Ben Leslie wrote: > On Fri, 5 Mar 2021 at 01:31, Gerd Hoffmann wrote: > >> Hi, >> >> > Would adding support to host-libusb to use these >> > ioctl to claim the port be beneficial? >> >> I don't feel like side-stepping libusb. That is asking for trouble >> because

Re: What is the intended behaviour of usb_host_get_port for root hubs?

2021-03-08 Thread Ben Leslie
On Tue, 9 Mar 2021 at 18:24, Gerd Hoffmann wrote: > On Tue, Mar 09, 2021 at 10:54:15AM +1100, Ben Leslie wrote: > > When usb_host_get_port is called for a root-hub device what string should > > be output in the port parameter? > > Just the port number, as string. > > (and in case this isn't a

[Bug 1918084] Re: Build fails on macOS 11.2.2

2021-03-08 Thread Thomas Huth
That looks weird, like a bug in the toolchain ... no clue how to fix that right now, but as a work-around, you could try to disable just the related part of the code by running configure with "--target-list- exclude=aarch64-softmmu,aarch64_be-linux-user,aarch64-linux-user" ** Changed in: qemu

[RFC 0/1] target/riscv: add RNMI support

2021-03-08 Thread frank . chang
From: Frank Chang This patchset add suport of Resumable NMI (RNMI) in RISC-V. There are four new CSRs and one new instruction added to allow NMI to be resumable in RISC-V, which are: = * mnscratch (0x350) * mnepc (0x351) *

[RFC 1/1] target/riscv: add support of RNMI

2021-03-08 Thread frank . chang
From: Frank Chang Signed-off-by: Frank Chang --- target/riscv/cpu.c| 40 + target/riscv/cpu.h| 16 - target/riscv/cpu_bits.h | 19 ++ target/riscv/cpu_helper.c | 47

Re: [PATCH qemu v14] spapr: Implement Open Firmware client interface

2021-03-08 Thread Alexey Kardashevskiy
On 09/03/2021 16:29, David Gibson wrote: +struct ClientArchitectureSupportClass { +InterfaceClass parent; +target_ulong (*cas)(CPUState *cs, target_ulong vec); +void (*quiesce)(void); Is there actually any real connection of quiesce behaviour to cas behaviour? Basically, I'm

Re: [PATCH v3 3/3] vfio: Avoid disabling and enabling vectors repeatedly in VFIO migration

2021-03-08 Thread Shenming Lu
On 2021/3/3 5:26, Alex Williamson wrote: > > MST/Marcel, > > Do you have an Ack or objection to exporting msix_masked() as below? Or could we use msix_function_masked instead as below? :-) if (!pdev->msix_function_masked) { for (nr = 0; nr < msix_nr_vectors_allocated(pdev); nr++) {

Re: [PATCH] hw/char: disable ibex uart receive if the buffer is full

2021-03-08 Thread Alexander Wagner
On 08.03.21 14:47, Alistair Francis wrote: hw/char/ibex_uart.c | 20 +++- include/hw/char/ibex_uart.h | 4 2 files changed, 19 insertions(+), 5 deletions(-) diff --git a/hw/char/ibex_uart.c b/hw/char/ibex_uart.c index 89f1182c9b..dac09d53d6 100644 ---

Re: [PATCH v6 0/5] m68k: add Virtual M68k Machine

2021-03-08 Thread Laurent Vivier
Le 08/03/2021 à 23:47, Philippe Mathieu-Daudé a écrit : > Hi Laurent, > > On 3/8/21 10:24 PM, Laurent Vivier wrote: >> The Quadra 800 machine is very limited to run linux, it manages >> only 1 GiB of memory and only some specific interfaces. >> >> The Virtual M68k Machine is based on Goldfish

Re: What is the intended behaviour of usb_host_get_port for root hubs?

2021-03-08 Thread Gerd Hoffmann
On Tue, Mar 09, 2021 at 10:54:15AM +1100, Ben Leslie wrote: > When usb_host_get_port is called for a root-hub device what string should > be output in the port parameter? Just the port number, as string. (and in case this isn't a root port the hub port number(s) are appended, separated by a

Re: [PATCH] virtio-gpu: Add spaces around operator

2021-03-08 Thread Gerd Hoffmann
On Tue, Mar 09, 2021 at 11:57:02AM +0800, 李皆俊 wrote: > From 0512d1cbe5c01844b4aca260024006e058dc1b6c Mon Sep 17 00:00:00 2001 > > From: lijiejun > > Date: Tue, 9 Mar 2021 11:17:59 +0800 > > Subject: [PATCH] virtio-gpu: Add spaces around operator Patch is mangled by your mailer. Please use

Re: [RFC] adding a generic QAPI event for failed device hotunplug

2021-03-08 Thread Markus Armbruster
Cc: Paolo and Julia in addition to Igor, because the thread is wandering towards DeviceState member pending_deleted_event. Cc: Laine for libvirt expertise. Laine, if you're not the right person, please loop in the right person. David Gibson writes: > On Mon, Mar 08, 2021 at 03:01:53PM -0300,

Re: [PATCH v2 2/2] tests/acceptance: Test ast2600 machine

2021-03-08 Thread Joel Stanley
On Fri, 5 Mar 2021 at 20:46, Wainer dos Santos Moschetta wrote: > > Hi, > > On 3/4/21 9:39 AM, Joel Stanley wrote: > > This tests a Debian multi-soc arm32 Linux kernel on the AST2600 based > > Tacoma BMC machine. > > > > There is no root file system so the test terminates when boot reaches > >

Re: [PATCH qemu v14] spapr: Implement Open Firmware client interface

2021-03-08 Thread David Gibson
On Tue, Mar 02, 2021 at 06:21:51PM +1100, Alexey Kardashevskiy wrote: > > > On 02/03/2021 14:35, David Gibson wrote: > > On Wed, Feb 24, 2021 at 04:41:30PM +1100, Alexey Kardashevskiy wrote: > > > The PAPR platform which describes an OS environment that's presented by > > > a combination of a

Re: [PATCH qemu v14] spapr: Implement Open Firmware client interface

2021-03-08 Thread David Gibson
On Tue, Mar 02, 2021 at 10:37:59AM +0100, BALATON Zoltan wrote: > On Tue, 2 Mar 2021, Alexey Kardashevskiy wrote: > > On 02/03/2021 14:35, David Gibson wrote: > > > Alexey or Zoltan, any thoughts on how non-PAPR versions of this would > > > call into qemu to get the non-guest parts of VOF to

Re: [PATCH 1/1] i386/cpu: Expose AVX_VNNI instruction to guset

2021-03-08 Thread Yang Zhong
Paolo, please help review this patch when you are not busy. The related kernel patch has been merged by you last time, thanks! Regards, Yang On Mon, Mar 01, 2021 at 01:15:52PM +0800, Yang Zhong wrote: > Expose AVX (VEX-encoded) versions of the Vector Neural Network > Instructions to guest. >

Re: [PATCH v2] FreeBSD: Upgrade to 12.2 release

2021-03-08 Thread Thomas Huth
On 08/03/2021 20.57, Warner Losh wrote: On Mon, Mar 8, 2021 at 12:51 PM Warner Losh > wrote: On Mon, Mar 8, 2021 at 8:46 AM Roman Bolshakov mailto:r.bolsha...@yadro.com>> wrote: > 8 марта 2021 г., в 18:41, Thomas Huth mailto:th...@redhat.com>>

Re: [PATCH v2] block/file-posix: Optimize for macOS

2021-03-08 Thread Akihiko Odaki
2021年3月9日(火) 0:37 Akihiko Odaki : > > 2021年3月9日(火) 0:17 Stefan Hajnoczi : > > > > The live migration compatibility issue is still present. Migrating to > > another host might not work if the block limits are different. > > > > Here is an idea for solving it: > > > > Modify

[PATCH] virtio-gpu: Add spaces around operator

2021-03-08 Thread 李皆俊
From 0512d1cbe5c01844b4aca260024006e058dc1b6c Mon Sep 17 00:00:00 2001 From: lijiejun Date: Tue, 9 Mar 2021 11:17:59 +0800 Subject: [PATCH] virtio-gpu: Add spaces around operator Fix code style. Operator needs spaces forend sides. Signed-off-by: lijiejun ---

[Bug 1908266] Re: spice unnecessary forces nographic

2021-03-08 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1908266 Title: spice

Re: [PATCH] virtio-net: calculating proper msix vectors on init

2021-03-08 Thread Jason Wang
On 2021/3/8 6:06 下午, Philippe Mathieu-Daudé wrote: Hi Jason, On 3/8/21 6:30 AM, Jason Wang wrote: Currently, the default msix vectors for virtio-net-pci is 3 which is obvious not suitable for multiqueue guest, so we depends on the user or management tools to pass a correct vectors parameter.

[PATCH V2] virtio-net: calculating proper msix vectors on init

2021-03-08 Thread Jason Wang
Currently, the default msix vectors for virtio-net-pci is 3 which is obvious not suitable for multiqueue guest, so we depends on the user or management tools to pass a correct vectors parameter. In fact, we can simplifying this by calculating the number of vectors on realize. Consider we have N

Re: [PATCH] ui/gtk: fix NULL pointer dereference

2021-03-08 Thread Akihiko Odaki
2021年3月8日(月) 23:58 Christian Schoenebeck : > > Yes, but the optimizer part could be disabled with > -fno-delete-null-pointer-checks which would render it a pure diagnostic > feature: > > https://gcc.gnu.org/onlinedocs/gcc/Common-Function-Attributes.html#index-nonnull-function-attribute > > Is

[PATCH] coroutine: add libucontext as external library

2021-03-08 Thread Joelle van Dyne
iOS does not support ucontext natively for aarch64 and the sigaltstack is also unsupported (even worse, it fails silently, see: https://openradar.appspot.com/13002712 ) As a workaround we include a library implementation of ucontext and add it as a build option. Signed-off-by: Joelle van Dyne

Re: [RFC] adding a generic QAPI event for failed device hotunplug

2021-03-08 Thread David Gibson
On Mon, Mar 08, 2021 at 03:01:53PM -0300, Daniel Henrique Barboza wrote: > > > On 3/8/21 2:04 PM, Markus Armbruster wrote: > > Daniel Henrique Barboza writes: > > > > > On 3/6/21 3:57 AM, Markus Armbruster wrote: > > > > Cc: ACPI maintainers for additional expertise. > > > > > > > > Daniel

[PATCH v2] vfio/migrate: Move switch of dirty tracking into vfio_memory_listener

2021-03-08 Thread Keqian Zhu
For now the switch of vfio dirty page tracking is integrated into @vfio_save_handler. The reason is that some PCI vendor driver may start to track dirty base on _SAVING state of device, so if dirty tracking is started before setting device state, vfio will report full-dirty to QEMU. However, the

Re: [PATCH v3 2/2] tests: Add functional test for out-of-process device emulation

2021-03-08 Thread Cleber Rosa
On Wed, Mar 03, 2021 at 05:53:20PM -0300, Willian Rampazzo wrote: > From: Jagannathan Raman > > Runs the Avocado acceptance test to check if a > remote lsi53c895a device gets identified by the guest. > > Signed-off-by: Elena Ufimtseva > Signed-off-by: John G Johnson > Signed-off-by:

Re: [PATCH v3 1/2] avocado_qemu: add exec_command function

2021-03-08 Thread Cleber Rosa
On Wed, Mar 03, 2021 at 05:53:19PM -0300, Willian Rampazzo wrote: > Sometimes a test needs to send a command to a console without waiting > for a pattern as a result, or the command issued do not produce any kind > of output, like, for example, a `mount` command. > > This introduces the

Re: [PATCH 2/2] aspeed: Integrate HACE

2021-03-08 Thread Andrew Jeffery
On Wed, 3 Mar 2021, at 17:33, Joel Stanley wrote: > Add the hash and crypto engine model to the aspeed socs. > > Signed-off-by: Joel Stanley > [ clg: documentation update ] > Signed-off-by: Cédric Le Goater Reviewed-by: Andrew Jeffery

Re: [PATCH 1/2] hw: Model ASPEED's Hash and Crypto Engine

2021-03-08 Thread Andrew Jeffery
On Wed, 3 Mar 2021, at 17:33, Joel Stanley wrote: > The HACE (Hash and Crpyto Engine) is a device that offloads MD5, SHA1, > SHA2, RSA and other cryptographic algorithms. > > This initial model implements a subset of the device's functionality; > currently only direct access (non-scatter

[PATCH v2 2/4] block: check for sys/disk.h

2021-03-08 Thread Joelle van Dyne
Some BSD platforms do not have this header. Signed-off-by: Joelle van Dyne --- meson.build | 1 + block.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 0e53876f69..ba0db9fa1f 100644 --- a/meson.build +++ b/meson.build @@ -1153,6

[PATCH v2 3/4] block: detect DKIOCGETBLOCKCOUNT/SIZE before use

2021-03-08 Thread Joelle van Dyne
iOS hosts do not have these defined so we fallback to the default behaviour. Co-authored-by: Warner Losh Signed-off-by: Joelle van Dyne --- block/file-posix.c | 18 +++--- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/block/file-posix.c b/block/file-posix.c index

[PATCH v2 4/4] slirp: feature detection for smbd

2021-03-08 Thread Joelle van Dyne
Replace Windows specific macro with a more generic feature detection macro. Allows slirp smb feature to be disabled manually as well. Signed-off-by: Joelle van Dyne --- configure | 26 +++--- meson.build | 2 +- net/slirp.c | 16 3 files changed, 32

[PATCH v2 1/4] block: feature detection for host block support

2021-03-08 Thread Joelle van Dyne
On Darwin (iOS), there are no system level APIs for directly accessing host block devices. We detect this at configure time. Signed-off-by: Joelle van Dyne --- meson.build | 6 +- qapi/block-core.json | 10 +++--- block/file-posix.c | 33 ++--- 3

[PATCH v2 0/4] Disable unsupported features on iOS hosts

2021-03-08 Thread Joelle van Dyne
These patches disables code that cannot be compiled or run on iOS by adding feature/header detection at configure time. v2: * Broken merge where config_host['CONFIG_SMBD_COMMAND'] was duplicated. -j Joelle van Dyne (4): block: feature detection for host block support block: check for

What is the intended behaviour of usb_host_get_port for root hubs?

2021-03-08 Thread Ben Leslie
When usb_host_get_port is called for a root-hub device what string should be output in the port parameter? The current behaviour writes a string with whatever stack value happened to be in the paths stack array. Possible behaviours that I can see being useful are: 1: Don't modify the port

Re: [PATCH 2/3] memory: Provide 'base address' argument to mtree_print_mr()

2021-03-08 Thread Peter Xu
Phil, On Sat, Mar 06, 2021 at 12:54:13AM +0100, Philippe Mathieu-Daudé wrote: > @@ -3188,14 +3188,15 @@ void mtree_info(bool flatview, bool dispatch_tree, > bool owner, bool disabled) > > QTAILQ_FOREACH(as, _spaces, address_spaces_link) { > qemu_printf("address-space: %s\n",

[PATCH v2 3/3] target/arm: set ID_AA64ISAR0.TLB to 2 for max AARCH64 CPU type

2021-03-08 Thread Rebecca Cran
Indicate support for FEAT_TLBIOS and FEAT_TLBIRANGE by setting ID_AA64ISAR0.TLB to 2 for the max AARCH64 CPU type. Signed-off-by: Rebecca Cran --- target/arm/cpu64.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/arm/cpu64.c b/target/arm/cpu64.c index c255f1bcc393..e1003fd96138

[PATCH v2 2/3] target/arm: Add support for FEAT_TLBIOS

2021-03-08 Thread Rebecca Cran
ARMv8.4 adds the mandatory FEAT_TLBIOS. It provides TLBI maintenance instructions that extend to the Outer Shareable domain. Signed-off-by: Rebecca Cran --- target/arm/cpu.h| 6 ++ target/arm/helper.c | 75 2 files changed, 81 insertions(+) diff --git

[PATCH v2 1/3] target/arm: Add support for FEAT_TLBIRANGE

2021-03-08 Thread Rebecca Cran
ARMv8.4 adds the mandatory FEAT_TLBIRANGE. It provides TLBI maintenance instructions that apply to a range of input addresses. Signed-off-by: Rebecca Cran --- accel/tcg/cputlb.c | 67 ++ include/exec/exec-all.h | 41 target/arm/cpu.h| 5 + target/arm/helper.c | 248

[PATCH v2 0/3] target/arm: Add support for FEAT_TLBIOS and FEAT_TLBIRANGE

2021-03-08 Thread Rebecca Cran
ARMv8.4 adds the mandatory FEAT_TLBIOS and FEAT_TLBIRANGE. They provides TLBI maintenance instructions that extend to the Outer Shareable domain and that apply to a range of input addresses. Changes from v1 to v2: o Split new instructions into different ARMCPRegInfo sections, and only add

Re: [PATCH v1 1/1] vfio: Make migration support non experimental by default.

2021-03-08 Thread Alex Williamson
On Mon, 8 Mar 2021 16:36:34 + Daniel P. Berrangé wrote: > On Mon, Mar 08, 2021 at 09:39:49PM +0530, Tarun Gupta wrote: > > VFIO migration support in QEMU is experimental as of now, which was done to > > provide soak time and resolve concerns regarding bit-stream. > > But, with the patches

Re: [PATCH v1 1/1] vfio: Make migration support non experimental by default.

2021-03-08 Thread Alex Williamson
[Cc +Intel] On Mon, 8 Mar 2021 21:39:49 +0530 Tarun Gupta wrote: > VFIO migration support in QEMU is experimental as of now, which was done to > provide soak time and resolve concerns regarding bit-stream. > But, with the patches discussed in >

Re: [PATCH v6 0/5] m68k: add Virtual M68k Machine

2021-03-08 Thread Philippe Mathieu-Daudé
Hi Laurent, On 3/8/21 10:24 PM, Laurent Vivier wrote: > The Quadra 800 machine is very limited to run linux, it manages > only 1 GiB of memory and only some specific interfaces. > > The Virtual M68k Machine is based on Goldfish interfaces defined by Google > for Android simulator. It uses

[PATCH v2 2/2] hw/arm: versal: Add support for the XRAMs

2021-03-08 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Connect the support for the Versal Accelerator RAMs (XRAMs). Reviewed-by: Luc Michel Acked-by: Alistair Francis Signed-off-by: Edgar E. Iglesias --- docs/system/arm/xlnx-versal-virt.rst | 1 + include/hw/arm/xlnx-versal.h | 13 ++

[PATCH v2 1/2] hw/misc: versal: Add a model of the XRAM controller

2021-03-08 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Add a model of the Xilinx Versal Accelerator RAM (XRAM). This is mainly a stub to make firmware happy. The size of the RAMs can be probed. The interrupt mask logic is modelled but none of the interrups will ever be raised unless injected. Signed-off-by: Edgar E.

[PATCH v2 0/2] hw/arm: versal: Add support for the XRAMs

2021-03-08 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" This series adds support for the 4x1MB Versal Accelerator RAMs (XRAMs). Most of the controller is dummy, but it's got enough to make firmware and some of our test SW happy. Cheers, Edgar ChangeLog: v1 -> v2: * Reduce list of included files in both .h and .c. * Remove

[PATCH v3] bsd-user: Add new maintainers

2021-03-08 Thread Warner Losh
The FreeBSD project has a number of enhancements to bsd-user. These changes have evolved over the past 10 year, and aren't currently updated to the latest version of qemu due to fluxuations in staffing causing us to fall behind in the past. We're working on porting all the changes forward and

Re: [PATCH v1 1/2] hw/misc: versal: Add a model of the XRAM controller

2021-03-08 Thread Edgar E. Iglesias
On Mon, Mar 08, 2021 at 04:54:26PM +, Peter Maydell wrote: > On Tue, 2 Mar 2021 at 11:09, Edgar E. Iglesias > wrote: > > > > From: "Edgar E. Iglesias" > > > > Add a model of the Xilinx Versal Accelerator RAM (XRAM). > > This is mainly a stub to make firmware happy. The size of > > the RAMs

Re: [PATCH v6 5/5] m68k: add Virtual M68k Machine

2021-03-08 Thread Philippe Mathieu-Daudé
On 3/8/21 10:25 PM, Laurent Vivier wrote: > The machine is based on Goldfish interfaces defined by Google > for Android simulator. It uses Goldfish-rtc (timer and RTC), > Goldfish-pic (PIC) and Goldfish-tty (for serial port and early tty). > > The machine is created with 128 virtio-mmio bus, and

Re: [PATCH v6 4/5] m68k: add a system controller

2021-03-08 Thread Philippe Mathieu-Daudé
On 3/8/21 10:25 PM, Laurent Vivier wrote: > Add a system controller for the m68k-virt machine. > This controller allows the kernel to power off or reset the machine. > > Signed-off-by: Laurent Vivier > Reviewed-by: Richard Henderson > --- > docs/specs/virt-ctlr.txt| 26 +++ >

Re: [PATCH v3 3/3] migration/ram: Optimize ram_save_host_page()

2021-03-08 Thread Peter Xu
On Mon, Mar 08, 2021 at 09:58:02PM +0800, Kunkun Jiang wrote: > Hi, > > On 2021/3/5 22:30, Peter Xu wrote: > > On Fri, Mar 05, 2021 at 03:50:35PM +0800, Kunkun Jiang wrote: > > > Starting from pss->page, ram_save_host_page() will check every page > > > and send the dirty pages up to the end of

[PATCH v6 4/5] m68k: add a system controller

2021-03-08 Thread Laurent Vivier
Add a system controller for the m68k-virt machine. This controller allows the kernel to power off or reset the machine. Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson --- docs/specs/virt-ctlr.txt| 26 +++ include/hw/misc/virt_ctrl.h | 22 ++ hw/misc/virt_ctrl.c

[PATCH v6 2/5] intc: add goldfish-pic

2021-03-08 Thread Laurent Vivier
Implement the goldfish pic device as defined in https://android.googlesource.com/platform/external/qemu/+/master/docs/GOLDFISH-VIRTUAL-HARDWARE.TXT Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé --- include/hw/intc/goldfish_pic.h | 33 +

[PATCH v6 5/5] m68k: add Virtual M68k Machine

2021-03-08 Thread Laurent Vivier
The machine is based on Goldfish interfaces defined by Google for Android simulator. It uses Goldfish-rtc (timer and RTC), Goldfish-pic (PIC) and Goldfish-tty (for serial port and early tty). The machine is created with 128 virtio-mmio bus, and they can be used to use serial console, GPU, disk,

[PATCH v6 3/5] m68k: add an interrupt controller

2021-03-08 Thread Laurent Vivier
A (generic) copy of the GLUE device we already have for q800 to use with the m68k-virt machine. The q800 one would disappear in the future as q800 uses actually the djMEMC controller. Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé ---

[PATCH v6 1/5] char: add goldfish-tty

2021-03-08 Thread Laurent Vivier
Implement the goldfish tty device as defined in https://android.googlesource.com/platform/external/qemu/+/master/docs/GOLDFISH-VIRTUAL-HARDWARE.TXT and based on the kernel driver code: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/tty/goldfish.c Signed-off-by:

[PATCH v6 0/5] m68k: add Virtual M68k Machine

2021-03-08 Thread Laurent Vivier
The Quadra 800 machine is very limited to run linux, it manages only 1 GiB of memory and only some specific interfaces. The Virtual M68k Machine is based on Goldfish interfaces defined by Google for Android simulator. It uses Goldfish-rtc (timer and RTC), Goldfish-pic (PIC) and Goldfish-tty (for

Re: [PATCH v3 1/1] hw/s390x: modularize virtio-gpu-ccw

2021-03-08 Thread Halil Pasic
On Fri, 5 Mar 2021 16:46:03 -0500 Eduardo Habkost wrote: > On Tue, Mar 02, 2021 at 06:35:44PM +0100, Halil Pasic wrote: > > Since the virtio-gpu-ccw device depends on the hw-display-virtio-gpu > > module, which provides the type virtio-gpu-device, packaging the > > hw-display-virtio-gpu module

Re: [PATCH v3 2/3] migration/ram: Reduce unnecessary rate limiting

2021-03-08 Thread Peter Xu
On Mon, Mar 08, 2021 at 06:34:58PM +0800, Kunkun Jiang wrote: > Hi, > > On 2021/3/5 22:22, Peter Xu wrote: > > Kunkun, > > > > On Fri, Mar 05, 2021 at 03:50:34PM +0800, Kunkun Jiang wrote: > > > When the host page is a huge page and something is sent in the > > > current iteration, the

Re: [PATCH v3 1/3] migration/ram: Modify the code comment of ram_save_host_page()

2021-03-08 Thread Peter Xu
On Mon, Mar 08, 2021 at 06:33:56PM +0800, Kunkun Jiang wrote: > Hi, Peter > > On 2021/3/5 21:59, Peter Xu wrote: > > On Fri, Mar 05, 2021 at 03:50:33PM +0800, Kunkun Jiang wrote: > > > The ram_save_host_page() has been modified several times > > > since its birth. But the comment hasn't been

Re: [PATCH v3 2/5] tests/acceptance/boot_linux_console: remove Armbian 19.11.3 bionic test for orangepi-pc machine

2021-03-08 Thread Willian Rampazzo
On Mon, Mar 8, 2021 at 5:41 PM Willian Rampazzo wrote: > > On Mon, Mar 8, 2021 at 5:32 PM Niek Linnenbank > wrote: > > > > Hi Philippe, Willian, > > > > On Mon, Mar 8, 2021 at 8:52 AM Philippe Mathieu-Daudé > > wrote: > >> > >> On 3/5/21 4:16 PM, Willian Rampazzo wrote: > >> > On Thu, Mar 4,

Re: [PATCH v3 2/5] tests/acceptance/boot_linux_console: remove Armbian 19.11.3 bionic test for orangepi-pc machine

2021-03-08 Thread Willian Rampazzo
On Mon, Mar 8, 2021 at 5:32 PM Niek Linnenbank wrote: > > Hi Philippe, Willian, > > On Mon, Mar 8, 2021 at 8:52 AM Philippe Mathieu-Daudé > wrote: >> >> On 3/5/21 4:16 PM, Willian Rampazzo wrote: >> > On Thu, Mar 4, 2021 at 5:44 PM Niek Linnenbank >> > wrote: >> >> >> >> The image for Armbian

Re: [PATCH] plugins: Expose physical addresses instead of device offsets

2021-03-08 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210308201406.1240023-1-aa...@os.amperecomputing.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210308201406.1240023-1-aa...@os.amperecomputing.com Subject: [PATCH]

Re: [PATCH v3 2/5] tests/acceptance/boot_linux_console: remove Armbian 19.11.3 bionic test for orangepi-pc machine

2021-03-08 Thread Niek Linnenbank
Hi Philippe, Willian, On Mon, Mar 8, 2021 at 8:52 AM Philippe Mathieu-Daudé wrote: > On 3/5/21 4:16 PM, Willian Rampazzo wrote: > > On Thu, Mar 4, 2021 at 5:44 PM Niek Linnenbank > wrote: > >> > >> The image for Armbian 19.11.3 bionic has been removed from the armbian > server. > >> Without

[PATCH] plugins: Expose physical addresses instead of device offsets

2021-03-08 Thread Aaron Lindsay
This allows plugins to query for full virtual-to-physical address translation for a given `qemu_plugin_hwaddr` and stops exposing the offset within the device itself. As this change breaks the API, QEMU_PLUGIN_VERSION is incremented. Signed-off-by: Aaron Lindsay --- contrib/plugins/hotpages.c

Re: [PATCH v3 4/5] tests/acceptance: update sunxi kernel from armbian to 5.10.16

2021-03-08 Thread Niek Linnenbank
Hi Philippe, Willian, Thanks for reviewing! On Mon, Mar 8, 2021 at 8:50 AM Philippe Mathieu-Daudé wrote: > On 3/5/21 4:04 PM, Willian Rampazzo wrote: > > On Thu, Mar 4, 2021 at 5:45 PM Niek Linnenbank > wrote: > >> > >> The linux kernel 4.20.7 binary for sunxi has been removed from >

Re: [PATCH] plugins: Expose physical addresses instead of device offsets

2021-03-08 Thread Aaron Lindsay
Alex, I've now tested this change, and it is giving what appear to be valid and correct physical addresses for both RAM and IO accesses in all the cases I've thrown at it. My main concern with this patch at this point is that I am concerned I may be breaking your new plugin here: > +++

Re: [PULL 00/14] Renesas patches for 2021-03-06

2021-03-08 Thread Peter Maydell
On Sat, 6 Mar 2021 at 15:38, Philippe Mathieu-Daudé wrote: > > Hi Peter, > > As SH-4 is not very active, I'm here covering up with this trivial patch > queue. > > The following changes since commit 91e92cad67caca3bc4b8e920ddb5c8ca64aac9e1: > > Merge remote-tracking branch

Re: RESEND [PATCH v2] bsd-user: Add new maintainers

2021-03-08 Thread Warner Losh
On Mon, Mar 8, 2021 at 8:28 AM Daniel P. Berrangé wrote: > On Mon, Mar 08, 2021 at 08:21:34AM -0700, Warner Losh wrote: > > On Mon, Mar 8, 2021 at 6:14 AM Philippe Mathieu-Daudé > > > wrote: > > > > > On 3/8/21 1:14 PM, Daniel P. Berrangé wrote: > > > > On Mon, Mar 08, 2021 at 12:55:10PM +0100,

Re: [PATCH v2] FreeBSD: Upgrade to 12.2 release

2021-03-08 Thread Warner Losh
On Mon, Mar 8, 2021 at 12:51 PM Warner Losh wrote: > > > On Mon, Mar 8, 2021 at 8:46 AM Roman Bolshakov > wrote: > >> >> > 8 марта 2021 г., в 18:41, Thomas Huth написал(а): >> > >> > On 08/03/2021 16.26, Warner Losh wrote: >> >> On Mon, Mar 8, 2021 at 6:30 AM Thomas Huth > th...@redhat.com>>

Re: [PATCH] scsi: Silence gcc warning

2021-03-08 Thread Eric Blake
Adding qemu-trivial in cc. On 2/9/21 9:44 AM, Philippe Mathieu-Daudé wrote: > On 2/9/21 4:23 PM, Eric Blake wrote: >> On Fedora 33, gcc 10.2.1 notes that scsi_cdb_length(buf) can set >> len==-1, which in turn overflows g_malloc(): >> >> [5/5] Linking target qemu-system-x86_64 >> In function

Re: [PATCH v2] FreeBSD: Upgrade to 12.2 release

2021-03-08 Thread Warner Losh
On Mon, Mar 8, 2021 at 8:46 AM Roman Bolshakov wrote: > > > 8 марта 2021 г., в 18:41, Thomas Huth написал(а): > > > > On 08/03/2021 16.26, Warner Losh wrote: > >> On Mon, Mar 8, 2021 at 6:30 AM Thomas Huth th...@redhat.com>> wrote: > >>On 07/03/2021 16.56, Warner Losh wrote: > >> >

Re: [PATCH v3 29/30] vl: QAPIfy -object

2021-03-08 Thread Eric Blake
On 3/8/21 10:54 AM, Kevin Wolf wrote: > This switches the system emulator from a QemuOpts-based parser for > -object to user_creatable_parse_str() which uses a keyval parser and > enforces the QAPI schema. > > Apart from being a cleanup, this makes non-scalar properties accessible. > > This

Re: [PATCH v3 26/30] qemu-img: Use user_creatable_process_cmdline() for --object

2021-03-08 Thread Eric Blake
On 3/8/21 10:54 AM, Kevin Wolf wrote: > This switches qemu-img from a QemuOpts-based parser for --object to > user_creatable_process_cmdline() which uses a keyval parser and enforces > the QAPI schema. > > Apart from being a cleanup, this makes non-scalar properties accessible. > >

Re: [PATCH v2] MAINTAINERS: Merge the Gitlab-CI section into the generic CI section

2021-03-08 Thread Philippe Mathieu-Daudé
On 3/8/21 6:49 PM, Willian Rampazzo wrote: > On Mon, Mar 8, 2021 at 12:46 PM Thomas Huth wrote: >> >> The status of the gitlab-CI files is currently somewhat confusing, and >> it is often not quite clear whether a patch should go via my tree or >> via the testing tree of Alex. That situation has

Re: [PATCH v3 06/30] qapi/qom: Add ObjectOptions for memory-backend-*

2021-03-08 Thread Eric Blake
On 3/8/21 10:54 AM, Kevin Wolf wrote: > This adds a QAPI schema for the properties of the memory-backend-* > objects. > > HostMemPolicy has to be moved to an include file that can be used by the > storage daemon, too, because ObjectOptions must be the same in all > binaries if we don't want to

Re: [PATCH v3 04/30] qapi/qom: Add ObjectOptions for cryptodev-*

2021-03-08 Thread Eric Blake
On 3/8/21 10:54 AM, Kevin Wolf wrote: > This adds a QAPI schema for the properties of the cryptodev-* objects. > > These interfaces have some questionable aspects (cryptodev-backend is > really an abstract base class without function, and the queues option > only makes sense for

Re: [PULL 01/38] hw/block/nvme: introduce nvme-subsys device

2021-03-08 Thread Klaus Jensen
On Mar 8 18:53, Peter Maydell wrote: > On Mon, 8 Mar 2021 at 18:46, Klaus Jensen wrote: > > > > On Mar 8 19:32, Paolo Bonzini wrote: > > > On 08/03/21 13:22, Klaus Jensen wrote: > > > > > > > > This patch introduced a simple nvme-subsys device model. The subsystem > > > > will be prepared with

Re: [PULL 00/54] target-arm queue

2021-03-08 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210308173244.20710-1-peter.mayd...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210308173244.20710-1-peter.mayd...@linaro.org Subject: [PULL 00/54] target-arm

Re: [PULL 01/38] hw/block/nvme: introduce nvme-subsys device

2021-03-08 Thread Klaus Jensen
On Mar 8 19:32, Paolo Bonzini wrote: > On 08/03/21 13:22, Klaus Jensen wrote: > > > > This patch introduced a simple nvme-subsys device model. The subsystem > > will be prepared with subsystem NQN with provided in > > nvme-subsys device: > > > >ex) -device nvme-subsys,id=subsys0:

Re: [RFC PATCH 17/42] target/mips/tx79: Introduce PEXTUW (Parallel Extend Upper from Word)

2021-03-08 Thread Philippe Mathieu-Daudé
On 2/15/21 5:44 PM, Richard Henderson wrote: > On 2/14/21 9:58 AM, Philippe Mathieu-Daudé wrote: >> +tcg_gen_deposit_i64(cpu_gpr[a->rd], bx, ax, 32, 32); >> +tcg_gen_shri_i64(bx, bx, 32); >> +tcg_gen_deposit_i64(cpu_gpr_hi[a->rd], ax, bx, 0, 32); > > I think you should pull this out

Re: [PULL 01/38] hw/block/nvme: introduce nvme-subsys device

2021-03-08 Thread Paolo Bonzini
On 08/03/21 13:22, Klaus Jensen wrote: This patch introduced a simple nvme-subsys device model. The subsystem will be prepared with subsystem NQN with provided in nvme-subsys device: ex) -device nvme-subsys,id=subsys0: nqn.2019-08.org.qemu:subsys0 Hi Klaus, sorry for not spotting this

Re: [PATCH] xen-block: Fix removal of backend instance via xenstore

2021-03-08 Thread Paolo Bonzini
On 08/03/21 19:14, Anthony PERARD wrote: On Mon, Mar 08, 2021 at 06:37:38PM +0100, Paolo Bonzini wrote: On 08/03/21 18:29, Anthony PERARD wrote: If nothing else works then I guess it's okay, but why can't you do the xen_block_drive_destroy from e.g. an unrealize callback? I'm not sure if

[Bug 1918084] Re: Build fails on macOS 11.2.2

2021-03-08 Thread Eddy Hahn
[87/5089] Compiling C++ object libcommon.fa.p/disas_libvixl_vixl_utils.cc.o FAILED: libcommon.fa.p/disas_libvixl_vixl_utils.cc.o c++ -Ilibcommon.fa.p -I. -I.. -I../capstone/include/capstone -I../slirp -I../slirp/src -I../dtc/libfdt -Iqapi -Itrace -Iui -Iui/shader

Re: [PATCH] xen-block: Fix removal of backend instance via xenstore

2021-03-08 Thread Anthony PERARD via
On Mon, Mar 08, 2021 at 06:37:38PM +0100, Paolo Bonzini wrote: > On 08/03/21 18:29, Anthony PERARD wrote: > > > If nothing else works then I guess it's okay, but why can't you do the > > > xen_block_drive_destroy from e.g. an unrealize callback? > > > > I'm not sure if that's possible. > > > >

Re: [RFC] adding a generic QAPI event for failed device hotunplug

2021-03-08 Thread Daniel Henrique Barboza
On 3/8/21 2:04 PM, Markus Armbruster wrote: Daniel Henrique Barboza writes: On 3/6/21 3:57 AM, Markus Armbruster wrote: Cc: ACPI maintainers for additional expertise. Daniel Henrique Barboza writes: Hi, Recent changes in pseries code (not yet pushed, available at David's ppc-for-6.0)

Re: [PULL 01/38] hw/block/nvme: introduce nvme-subsys device

2021-03-08 Thread Peter Maydell
On Mon, 8 Mar 2021 at 18:46, Klaus Jensen wrote: > > On Mar 8 19:32, Paolo Bonzini wrote: > > On 08/03/21 13:22, Klaus Jensen wrote: > > > > > > This patch introduced a simple nvme-subsys device model. The subsystem > > > will be prepared with subsystem NQN with provided in > > > nvme-subsys

Re: [PATCH v2] MAINTAINERS: Merge the Gitlab-CI section into the generic CI section

2021-03-08 Thread Philippe Mathieu-Daudé
On 3/8/21 6:01 PM, Thomas Huth wrote: > On 08/03/2021 17.35, Philippe Mathieu-Daudé wrote: >> On 3/8/21 4:46 PM, Thomas Huth wrote: >>> The status of the gitlab-CI files is currently somewhat confusing, and >>> it is often not quite clear whether a patch should go via my tree or >>> via the

Re: [RFC PATCH 16/42] target/mips/tx79: Introduce PSUB* opcodes (Parallel Subtract)

2021-03-08 Thread Philippe Mathieu-Daudé
On 2/15/21 5:38 PM, Richard Henderson wrote: > On 2/14/21 9:58 AM, Philippe Mathieu-Daudé wrote: >> +/* Parallel Subtract Byte */ >> +static bool trans_PSUBB(DisasContext *ctx, arg_rtype *a) >> +{ >> +return trans_parallel_substract(ctx, a, 8); >> +} >> + >> +/* Parallel Subtract Halfword */

Re: [PATCH v2 2/3] target/m68k: reformat m68k_features enum

2021-03-08 Thread Laurent Vivier
Le 08/03/2021 à 13:11, Mark Cave-Ayland a écrit : > Move the feature comment from after the feature name to the preceding line to > allow for longer feature names and descriptions without hitting the 80 > character line limit. > > Signed-off-by: Mark Cave-Ayland > --- > target/m68k/cpu.h | 66

Re: [RFC PATCH v2] meson: Only generate trace files for selected targets

2021-03-08 Thread Philippe Mathieu-Daudé
On 3/8/21 5:46 PM, Stefan Hajnoczi wrote: > On Wed, Feb 24, 2021 at 10:35:15PM +0100, Philippe Mathieu-Daudé wrote: >> We don't need to generate trace files for targets we >> are not building. Restrict the the ones selected. >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> meson.build | 16

[PULL 54/54] hw/timer/renesas_tmr: Fix use of uninitialized data in read_tcnt()

2021-03-08 Thread Peter Maydell
The read_tcnt() function calculates the TCNT register values for the two channels of the timer module; it sets these up in the local tcnt[] array, and eventually returns either one or both of them, depending on whether the access is 8 or 16 bits. However, not all of the code paths through this

Re: [PATCH 43/44] docs/system/arm/mps2.rst: Document the new mps3-an547 board

2021-03-08 Thread Peter Maydell
On Fri, 5 Mar 2021 at 10:22, Peter Maydell wrote: > > On Fri, 5 Mar 2021 at 01:28, Richard Henderson > wrote: > > > > On 2/19/21 6:46 AM, Peter Maydell wrote: > > > @@ -1,5 +1,5 @@ > > > -Arm MPS2 and MPS3 boards (``mps2-an385``, ``mps2-an386``, > > > ``mps2-an500``, ``mps2-an505``,

[PULL 45/54] tests/qtest/sse-timer-test: Test the system timer

2021-03-08 Thread Peter Maydell
Add a test which tests various parts of the functionality of the SSE system timer. Signed-off-by: Peter Maydell Tested-by: Philippe Mathieu-Daudé Reviewed-by: Philippe Mathieu-Daudé --- tests/qtest/sse-timer-test.c | 91 1 file changed, 91 insertions(+)

[PULL 37/54] hw/misc/mps2-fpgaio: Fold counters subsection into main vmstate

2021-03-08 Thread Peter Maydell
We've already broken migration compatibility for all the MPS boards, so we might as well take advantage of this to simplify the vmstate for the FPGAIO device by folding the counters subsection into the main vmstate description. Signed-off-by: Peter Maydell Tested-by: Philippe Mathieu-Daudé

[PULL 48/54] hw/dma: Implement a Xilinx CSU DMA model

2021-03-08 Thread Peter Maydell
From: Xuzhou Cheng ZynqMP QSPI supports SPI transfer using DMA mode, but currently this is unimplemented. When QSPI is programmed to use DMA mode, QEMU will crash. This is observed when testing VxWorks 7. This adds a Xilinx CSU DMA model and the implementation is based on

[PULL 46/54] tests/qtest/sse-timer-test: Test counter scaling changes

2021-03-08 Thread Peter Maydell
Test that when we change the scaling of the system counter that the system timer responds appropriately. Signed-off-by: Peter Maydell Tested-by: Philippe Mathieu-Daudé Reviewed-by: Philippe Mathieu-Daudé --- tests/qtest/sse-timer-test.c | 32 1 file changed,

Re: [PATCH v2] MAINTAINERS: Merge the Gitlab-CI section into the generic CI section

2021-03-08 Thread Willian Rampazzo
On Mon, Mar 8, 2021 at 12:46 PM Thomas Huth wrote: > > The status of the gitlab-CI files is currently somewhat confusing, and > it is often not quite clear whether a patch should go via my tree or > via the testing tree of Alex. That situation has grown historically... > Initially, I was the only

[PULL 49/54] hw/arm: xlnx-zynqmp: Clean up coding convention issues

2021-03-08 Thread Peter Maydell
From: Xuzhou Cheng There are some coding convention warnings in xlnx-zynqmp.c and xlnx-zynqmp.h, as reported by: $ ./scripts/checkpatch.pl include/hw/arm/xlnx-zynqmp.h $ ./scripts/checkpatch.pl hw/arm/xlnx-zynqmp.c Let's clean them up. Signed-off-by: Xuzhou Cheng Signed-off-by: Bin Meng

  1   2   3   4   5   >