On Sat, 13 Mar 2021 07:43:38 +0200
Mahmoud Mandour wrote:
> Thanks for the fast review. I asked on the QEMU IRC channel
> before committing whether to put all the changes into one patch
> or split them and was instructed that it was better to split them up.
> But in any case I was open to both
On 13/03/21 08:40, Markus Armbruster wrote:
+if (!user_creatable_add_from_str(optarg, _err)) {
+if (local_err) {
+error_report_err(local_err);
+exit(2);
+} else {
+/*
Kevin Wolf writes:
> This switches qemu-img from a QemuOpts-based parser for --object to
> user_creatable_process_cmdline() which uses a keyval parser and enforces
> the QAPI schema.
>
> Apart from being a cleanup, this makes non-scalar properties accessible.
>
> Signed-off-by: Kevin Wolf
>
spapr_memory_unplug() is the last step of the hot unplug sequence.
It is indirectly called by:
spapr_lmb_release()
hotplug_handler_unplug()
and spapr_lmb_release() already buys us that DIMM unplug state is
present : it gets restored with spapr_recover_pending_dimm_state()
if missing.
On Friday, 12 March 2021, Maciej W. Rozycki wrote:
> On Fri, 12 Mar 2021, Philippe Mathieu-Daudé wrote:
>
> > > but your two options to
> > > choose from are:
> > >
> > > 1. Build for the soft-float ABI (`-msoft-float') where any FP
> > > calculations
> > >are compiled such as to be made
Thank you for the fast review and I'm sorry for the silly and obvious style
errors. Unfortunately I did not notice the section on using the checkpatch
script in the Contributing page on the wiki before committing. But I assure
you that such errors will not occur again.
On Fri, Mar 12, 2021 at
Thanks for the fast review. I asked on the QEMU IRC channel
before committing whether to put all the changes into one patch
or split them and was instructed that it was better to split them up.
But in any case I was open to both ways and you can decide
on the best way to go.
On Thu, Mar 11, 2021
On Tue, 9 Mar 2021 13:21:14 +
Daniel P. Berrangé wrote:
> > Well, yes, in a non-modular world this will work perfectly fine. We
> > only compile objects actually supported into the system emulator.
> >
> > With modular builds we have the situation that we have shared modules
> > which may
On 3/11/21 1:44 PM, David Hildenbrand wrote:
The PoP states:
When EDAT-1 does not apply, and a program interruption due to a
page-translation exception is recognized by the MOVE PAGE
instruction, the contents of the R1 field of the instruction are
stored in bit positions 0-3
On 3/11/21 1:44 PM, David Hildenbrand wrote:
+if (exc) {
+#if !defined(CONFIG_USER_ONLY)
+if (exc == PGM_PROTECTION) {
+stq_phys(env_cpu(env)->as,
+ env->psa + offsetof(LowCore, trans_exc_code),
+ env->tlb_fill_tec);
+
Verify that hflags was updated correctly whenever we change
cpu state that is used by hflags.
Signed-off-by: Richard Henderson
---
target/ppc/cpu.h | 5 +
target/ppc/helper_regs.c | 29 +++--
2 files changed, 32 insertions(+), 2 deletions(-)
diff --git
We weren't recording MSR_GS in hflags, which means that BookE
memory accesses were essentially random vs Guest State.
Instead of adding this bit directly, record the completed mmu
indexes instead. This makes it obvious that we are recording
exactly the information that we need.
This also means
Nothing within the translator -- or anywhere else for that
matter -- checks MSR_SA or MSR_AP on the 602. This may be
a mistake. However, for the moment, we need not record these
bits in hflags.
This allows us to simplify HFLAGS_VSX computation by moving
it to overlap with MSR_VSX.
Because this bit was not in hflags, the privilege check
for tlb instructions was essentially random.
Recompute hflags when storing to LPCR.
Signed-off-by: Richard Henderson
---
target/ppc/cpu.h | 1 +
target/ppc/helper_regs.c | 3 +++
target/ppc/mmu-hash64.c | 3 +++
Because these bits were not in hflags, the code generated
for single-stepping on BookE was essentially random.
Recompute hflags when storing to dbcr0.
Signed-off-by: Richard Henderson
---
target/ppc/helper_regs.c | 20 +++-
target/ppc/misc_helper.c | 3 +++
Only one of the three places in hw/ppc that modify msr updated
hflags. Even in that case, use the official interface instead
of a direct call to hreg_compute_hflags.
Signed-off-by: Richard Henderson
---
Cc: Cédric Le Goater
Cc: Greg Kurz
---
hw/ppc/pnv_core.c| 3 ++-
hw/ppc/spapr_hcall.c
As per hreg_compute_hflags:
We 'forget' FE0 & FE1: we'll never generate imprecise exceptions
remove the hflags marker from the respective comments.
Signed-off-by: Richard Henderson
---
target/ppc/cpu.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/target/ppc/cpu.h
Perform the test against FSCR_SCV at runtime, in the helper.
This means we can remove the incorrect set against SCV in
ppc_tr_init_disas_context and do not need to add an HFLAGS bit.
Signed-off-by: Richard Henderson
---
target/ppc/helper.h | 1 +
target/ppc/excp_helper.c | 9 +
It will be stored in tb->flags, which is also uint32_t,
so let's use the correct size.
Signed-off-by: Richard Henderson
---
target/ppc/cpu.h | 4 ++--
target/ppc/misc_helper.c | 2 +-
target/ppc/translate.c | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git
We have eliminated all normal uses of hflags_nmsr. We need
not even compute it except when we want to migrate. Rename
the field to emphasize this.
Remove the fixme comment for migrating access_type. This value
is only ever used with the current executing instruction, and
is never live when the
In ppc_store_msr we call hreg_compute_hflags, which itself
calls hreg_compute_mem_idx. Rely on ppc_store_msr to update
everything required by the msr update.
Signed-off-by: Richard Henderson
---
target/ppc/machine.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git
Copying flags directly from msr has drawbacks: (1) msr bits
mean different things per cpu, (2) msr has 64 bits on 64 cpus
while tb->flags has only 32 bits.
Create a enum to define these bits. Document the origin of each bit.
This fixes the truncation of env->hflags to tb->flags, because we no
Match cpu_post_load in using ppc_store_msr to set all of
the cpu state implied by the value of msr. Do not restore
hflags or hflags_nmsr, as we recompute them in ppc_store_msr.
Signed-off-by: Richard Henderson
---
target/ppc/machine.c | 13 +++--
1 file changed, 11 insertions(+), 2
Keep all hflags computation in one place, as this will be
especially important later.
Introduce a new POWERPC_FLAG_HID0_LE bit to indicate when
LE should be taken from HID0. This appears to be set if
and only if POWERPC_FLAG_RTC_CLK is set, but we're not
short of bits and having both names will
Version 2 is totally new.
Clean up everything that touches hflags, fixing quite a few
other bugs in the process.
* Do not put tcg internal state into migration, except to
retain backward compatibility.
* Do not touch anything in env in ppc_tr_init_disas_context.
* Do make sure that hflags
Move the functions to a new file, helper_regs.c.
Note int_helper.c was relying on helper_regs.h to
indirectly include qemu/log.h.
Signed-off-by: Richard Henderson
---
target/ppc/helper_regs.h | 184 ++--
target/ppc/helper_regs.c | 197
https://gitlab.com/qemu-project/ asks for sign in and if I do sign in, I get a
404. Is this expected?
https://status.gitlab.com/ describes "shared runner degradation" but that
doesn't sound like this problem.
-Brian
Pull request coming next Monday.
Paolo
Il ven 12 mar 2021, 23:40 Igor Mammedov ha scritto:
> happens on current master,
>
> to reproduce start
> ./x86_64-softmmu/qemu-system-x86_64 -enable-kvm -m 1g -M pc -vnc
> localhost:0 \
> -snapshot -cdrom Fedora-Workstation-Live-x86_64-33-1.2.iso
>
happens on current master,
to reproduce start
./x86_64-softmmu/qemu-system-x86_64 -enable-kvm -m 1g -M pc -vnc localhost:0 \
-snapshot -cdrom Fedora-Workstation-Live-x86_64-33-1.2.iso
connect to guest using 'Remote Desktop', wait till it boots to graphical desktop
then try to change
Add a system controller for the m68k-virt machine.
This controller allows the kernel to power off or reset the machine.
Signed-off-by: Laurent Vivier
Reviewed-by: Richard Henderson
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Philippe Mathieu-Daudé
---
docs/specs/virt-ctlr.txt| 26
The Quadra 800 machine is very limited to run linux, it manages
only 1 GiB of memory and only some specific interfaces.
The Virtual M68k Machine is based on Goldfish interfaces defined by Google
for Android simulator. It uses Goldfish-rtc (timer and RTC),
Goldfish-pic (PIC) and Goldfish-tty (for
Implement the goldfish tty device as defined in
https://android.googlesource.com/platform/external/qemu/+/master/docs/GOLDFISH-VIRTUAL-HARDWARE.TXT
and based on the kernel driver code:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/tty/goldfish.c
Signed-off-by:
The machine is based on Goldfish interfaces defined by Google
for Android simulator. It uses Goldfish-rtc (timer and RTC),
Goldfish-pic (PIC) and Goldfish-tty (for serial port and early tty).
The machine is created with 128 virtio-mmio bus, and they can
be used to use serial console, GPU, disk,
A (generic) copy of the GLUE device we already have for q800 to use with
the m68k-virt machine.
The q800 one would disappear in the future as q800 uses actually the djMEMC
controller.
Signed-off-by: Laurent Vivier
Reviewed-by: Richard Henderson
Reviewed-by: Philippe Mathieu-Daudé
Tested-by:
Implement the goldfish pic device as defined in
https://android.googlesource.com/platform/external/qemu/+/master/docs/GOLDFISH-VIRTUAL-HARDWARE.TXT
Signed-off-by: Laurent Vivier
Reviewed-by: Richard Henderson
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Philippe Mathieu-Daudé
---
On Fri, Mar 12, 2021 at 07:28:49PM +0100, Philippe Mathieu-Daudé wrote:
> The pci_io_non_contiguous region is mapped on top of pci_io
> with higher priority, but simply dispatch into this region
> address space. Simplify by directly registering the former
> region in place, and adapt the address
Hi Peter,
On 3/12/21 6:29 PM, Peter Maydell wrote:
> For Arm M-profile CPUs, on reset the CPU must load its initial PC and
> SP from a vector table in guest memory. Because we can't guarantee
> reset ordering, we have to handle the possibility that the ROM blob
> loader's reset function has not
On 3/12/21 6:29 PM, Peter Maydell wrote:
> The function flatview_for_each_range() calls a callback for each
> range in a FlatView. Currently the callback gets the start and
> length of the range and the MemoryRegion involved, but not the offset
> within the MemoryRegion. Add this to the
At this moment we only provide one event to report a hotunplug error,
MEM_UNPLUG_ERROR. There will be other device types that are going to be
throwing unplug errors in the future though.
Instead of creating a (device_type)_UNPLUG_ERROR for each new device,
create a generic DEVICE_UNPLUG_ERROR
Other device types in the pseries machine will use DEVICE_UNPLUG_ERROR
to report hotunplug errors. Use it to report the memory hotunplug error
in spapr_memory_unplug_rollback() as well.
Signed-off-by: Daniel Henrique Barboza
---
hw/ppc/spapr.c | 2 +-
1 file changed, 1 insertion(+), 1
The newly added DEVICE_NOT_DELETED QAPI event is adequate to be
sent when the hotunplug timeout expires, letting users know that
something happened inside the guest and the pseries machine didn't
delete the device from QOM.
After this patch, if an user try to hotunplug the last online CPU of
the
This new event informs QAPI listeners that a previously issued
'device_del' command failed to delete the device from the machine.
Note that no assertion can be made about the failure reason. The goal of
this event is to inform management that QEMU is not able to assess
whether the hotunplug is
Hi,
This series adds 2 new QAPI events, DEVICE_NOT_DELETED and
DEVICE_UNPLUG_ERROR. They were (and are still being) discussed in [1].
Patches 1 and 3 are independent of the ppc patches and can be applied
separately. Patches 2 and 4 are based on David's ppc-for-6.0 branch and
are dependent on the
On 3/12/21 7:24 PM, Fredrik Noring wrote:
> On Friday, 12 March 2021, Maciej W. Rozycki wrote:
>> On Fri, 12 Mar 2021, Philippe Mathieu-Daudé wrote:
>>
>> Is there any way we can do this with a distro that isn't Gentoo
>> so that we can get a container build that is fast enough to be
On Fri, 12 Mar 2021, Philippe Mathieu-Daudé wrote:
> > but your two options to
> > choose from are:
> >
> > 1. Build for the soft-float ABI (`-msoft-float') where any FP calculations
> >are compiled such as to be made by the CPU using integer arithmetic.
>
> With the Debian toolchain I
Thanks very much for the information.
However, when I try to run configure with --enable-opengl it reports
the following:
ERROR: User requested feature opengl
configure was not able to find it.
Please install opengl (mesa) devel pkgs: epoxy gbm
It looks like it requires gbm which
On Mar 12 17:28, Alex Bennée wrote:
> Signed-off-by: Alex Bennée
Small comment below, but otherwise:
Reviewed-by: Aaron Lindsay
> ---
> include/qemu/qemu-plugin.h | 35 ---
> 1 file changed, 28 insertions(+), 7 deletions(-)
>
> diff --git
On Mar 12 17:28, Alex Bennée wrote:
> Signed-off-by: Alex Bennée
Reviewed-by: Aaron Lindsay
> ---
> include/qemu/qemu-plugin.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/include/qemu/qemu-plugin.h b/include/qemu/qemu-plugin.h
> index c98866a637..5ac6fe5f02 100644
> ---
Public bug reported:
I want QEMU user static to propagate interpreter to spawned processes,
for instances by adding -R recursive.
I.e. if my program is interpreted by QEMU static than everything what it
launches should be interpreted by it, too.
** Affects: qemu
Importance: Undecided
On Mar 12 17:28, Alex Bennée wrote:
> Also add a note to explain currently they are unused.
>
> Signed-off-by: Alex Bennée
I'm personally interested in one clarification below, but don't think
that affects my:
Reviewed-by: Aaron Lindsay
> ---
> include/qemu/qemu-plugin.h | 16
The flash mmio region is exposed as an AddressSpace.
AddressSpaces must not be sysbus-mapped, therefore map
the region using an alias.
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/ssi/aspeed_smc.h | 1 +
hw/ssi/aspeed_smc.c | 4 +++-
2 files changed, 4 insertions(+), 1
On Thu, 11 Mar 2021 at 14:48, Kevin Wolf wrote:
>
> The following changes since commit d689ecad073e0289afa8ca863e45879d719e5c21:
>
> Merge remote-tracking branch 'remotes/nvme/tags/nvme-next-pull-request'
> into staging (2021-03-10 20:11:33 +)
>
> are available in the Git repository at:
>
On Mar 12 17:28, Alex Bennée wrote:
> Signed-off-by: Alex Bennée
One nit below, but otherwise:
Reviewed-by: Aaron Lindsay
> ---
> include/qemu/qemu-plugin.h | 25 ++---
> 1 file changed, 22 insertions(+), 3 deletions(-)
>
> diff --git a/include/qemu/qemu-plugin.h
From: NDNF
Only one interrupt is in progress at the moment.It is necessary to set to
reset interrupt_request only after all interrupts have been executed
Signed-off-by: Arkasha
---
target/avr/helper.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/target/avr/helper.c
On Friday, 12 March 2021, Maciej W. Rozycki wrote:
> On Fri, 12 Mar 2021, Philippe Mathieu-Daudé wrote:
>
> > >>> Is there any way we can do this with a distro that isn't Gentoo
> > >>> so that we can get a container build that is fast enough to be
> > >>> useful for CI ?
> >
> > Using the
On Friday, 12 March 2021, Philippe Mathieu-Daudé wrote:
> Now than SQ is properly implemented, we can move the RDHWR
> kludge required to have usermode working with recent glibc.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> v2: { RDHWR_user } (rth)
>
> Fredrik, I'm not understanding fully
On Fri, 12 Mar 2021 at 17:29, Peter Maydell wrote:
> This series handles the possibility of aliasing by iterating through
> the whole FlatView of the CPU's address space checking for other
> mappings of the MemoryRegion corresponding to the location of the
> vector table. If we find any aliases
On 05.03.21 18:35, Vladimir Sementsov-Ogievskiy wrote:
Compressed writes are unaligned to 512, which works very slow in
O_DIRECT mode. Let's use the cache.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/coroutines.h | 3 +
block/qcow2.h | 4 ++
On Fri, Mar 12, 2021 at 01:30:24PM +0100, Thomas Huth wrote:
> On 29/01/2021 17.46, Jagannathan Raman wrote:
> > Hi,
> >
> > This is the v21 of the patchset. This version has the following changes:
> >
> > [PATCH v18 08/20] io: add qio_channel_readv_full_all_eof &
> >
A few clarifications inline:
On Mar 12 17:28, Alex Bennée wrote:
> Signed-off-by: Alex Bennée
> ---
> include/qemu/qemu-plugin.h | 52 --
> 1 file changed, 50 insertions(+), 2 deletions(-)
>
> diff --git a/include/qemu/qemu-plugin.h
On Mar 12 17:28, Alex Bennée wrote:
> Remove the extraneous @cb parameter and document the non-atomic nature
> of the INLINE_ADD_U64 operation.
>
> Signed-off-by: Alex Bennée
Reviewed-by: Aaron Lindsay
> ---
> include/qemu/qemu-plugin.h | 12 +++-
> 1 file changed, 11 insertions(+),
12.03.2021 21:15, Max Reitz wrote:
On 05.03.21 18:35, Vladimir Sementsov-Ogievskiy wrote:
Compressed writes are unaligned to 512, which works very slow in
O_DIRECT mode. Let's use the cache.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/coroutines.h | 3 +
block/qcow2.h
The raven bus-master memory region is exposed as an AddressSpace.
AddressSpaces root MemoryRegion must not be mapped into other
MemoryRegion, therefore map the region using its alias.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/pci-host/prep.c | 6 --
1 file changed, 4 insertions(+), 2
From: Peter Xu
Add a bool for MR to mark whether this MR is a root MR of an AS. We bail out
asap if this MR is added as a subregion of another MR.
Signed-off-by: Peter Xu
---
include/exec/memory.h | 1 +
softmmu/memory.c | 2 ++
2 files changed, 3 insertions(+)
diff --git
On Thu, 11 Mar 2021 at 12:34, Gerd Hoffmann wrote:
>
> The following changes since commit 821e7ed167f11f482d2d1a8eaf114a667295a581:
>
> Merge remote-tracking branch 'remotes/thuth-gitlab/tags/pull-request-2021-0=
> 3-09' into staging (2021-03-10 17:22:45 +)
>
> are available in the Git
12.03.2021 21:15, Max Reitz wrote:
@@ -1834,6 +1835,10 @@ static int coroutine_fn qcow2_do_open(BlockDriverState
*bs, QDict *options,
s->inflight_writes_counters =
g_hash_table_new_full(g_int64_hash, g_int64_equal, g_free, g_free);
+ if (!has_data_file(bs) &&
Hi,
This series is the result of a long thread with Peter:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg788366.html
AddressSpace are physical address view and shouldn't be using
non-zero base address. The correct way to map a MR used as AS
root is to use a MR alias.
Fix the current
On Mar 12 17:28, Alex Bennée wrote:
> Signed-off-by: Alex Bennée
Reviewed-by: Aaron Lindsay
> ---
> include/qemu/qemu-plugin.h | 17 ++---
> 1 file changed, 10 insertions(+), 7 deletions(-)
>
> diff --git a/include/qemu/qemu-plugin.h b/include/qemu/qemu-plugin.h
> index
Cc'ing TCG maintainer ;)
On 3/12/21 1:14 PM, mreza...@redhat.com wrote:
> From: Miroslav Rezanina
>
> There are two different versions of prototype for tcg_out_op and
> tcg_out_vec_op functions:
>
> 1) using const TCGArg *args and const int *const_args arguments
> 2) using const TCGArg
On Mar 12 17:28, Alex Bennée wrote:
> kernel-doc doesn't like multiple Note sections. Also add an explicit
> Return.
>
> Signed-off-by: Alex Bennée
Reviewed-by: Aaron Lindsay
> ---
> include/qemu/qemu-plugin.h | 12 ++--
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff
On Mar 12 17:28, Alex Bennée wrote:
> It seems kernel-doc struggles a bit with typedef structs but with
> enough encouragement we can get something out of it.
>
> Signed-off-by: Alex Bennée
Reviewed-by: Aaron Lindsay
> ---
> include/qemu/qemu-plugin.h | 22 +++---
> 1 file
On Mar 12 17:28, Alex Bennée wrote:
> We have kerneldoc tags for the headers so we might as well extract
> them into our developer documentation whilst we are at it.
>
> Signed-off-by: Alex Bennée
Reviewed-by: Aaron Lindsay
> ---
> docs/devel/tcg-plugins.rst | 5 +
> 1 file changed, 5
Extend the ObjectOption code that was added in the previous patch to
enable passing JSON to -object. Even though we cannot yet add
non-scalar properties with the human-friendly comma-separated syntax,
they can now be added as JSON.
Reviewed-by: Eric Blake
Reviewed-by: Kevin Wolf
Signed-off-by:
The pci_io_non_contiguous region is mapped on top of pci_io
with higher priority, but simply dispatch into this region
address space. Simplify by directly registering the former
region in place, and adapt the address space dispatch offsets.
Signed-off-by: Philippe Mathieu-Daudé
---
For Arm M-profile CPUs, on reset the CPU must load its initial PC and
SP from a vector table in guest memory. Because we can't guarantee
reset ordering, we have to handle the possibility that the ROM blob
loader's reset function has not yet run when the CPU resets, in which
case the data in an
For Arm M-profile CPUs, on reset the CPU must load its initial PC and
SP from a vector table in guest memory. Because we can't guarantee
reset ordering, we have to handle the possibility that the ROM blob
loader's reset function has not yet run when the CPU resets, in which
case the data in an
The RAM container is exposed as an AddressSpace.
AddressSpaces root MemoryRegion must not be mapped into other
MemoryRegion, therefore map the RAM container using an alias.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/arm/aspeed.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff
Hi Maciej,
On 3/12/21 6:05 PM, Maciej W. Rozycki wrote:
> On Fri, 12 Mar 2021, Philippe Mathieu-Daudé wrote:
>
> Is there any way we can do this with a distro that isn't Gentoo
> so that we can get a container build that is fast enough to be
> useful for CI ?
>>
>> Using the Debian
Signed-off-by: Alex Bennée
---
include/qemu/qemu-plugin.h | 52 --
1 file changed, 50 insertions(+), 2 deletions(-)
diff --git a/include/qemu/qemu-plugin.h b/include/qemu/qemu-plugin.h
index dc05fc1932..d4adce730a 100644
--- a/include/qemu/qemu-plugin.h
+++
The function flatview_for_each_range() calls a callback for each
range in a FlatView. Currently the callback gets the start and
length of the range and the MemoryRegion involved, but not the offset
within the MemoryRegion. Add this to the callback's arguments; we're
going to want it for a new
It seems kernel-doc struggles a bit with typedef structs but with
enough encouragement we can get something out of it.
Signed-off-by: Alex Bennée
---
include/qemu/qemu-plugin.h | 22 +++---
1 file changed, 15 insertions(+), 7 deletions(-)
diff --git a/include/qemu/qemu-plugin.h
From: Yonggang Luo
Getting the comment consistence with the function name
Signed-off-by: Yonggang Luo
Signed-off-by: Alex Bennée
Message-Id: <20201013002806.1447-3-luoyongg...@gmail.com>
---
include/qemu/qemu-plugin.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
Signed-off-by: Alex Bennée
---
include/qemu/qemu-plugin.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/qemu/qemu-plugin.h b/include/qemu/qemu-plugin.h
index c98866a637..5ac6fe5f02 100644
--- a/include/qemu/qemu-plugin.h
+++ b/include/qemu/qemu-plugin.h
@@ -32,6 +32,9 @@
Remove the extraneous @cb parameter and document the non-atomic nature
of the INLINE_ADD_U64 operation.
Signed-off-by: Alex Bennée
---
include/qemu/qemu-plugin.h | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/include/qemu/qemu-plugin.h
On 12/03/21 18:24, Claudio Fontana wrote:
Ah, just saw this. I already sent the series, but we can rework and rethink
this.
No big deal; since you have the assertion it's okay as you posted, too.
Paolo
On 3/12/21 6:22 PM, Claudio Fontana wrote:
> start by moving minimal init and realizefn code.
>
> Signed-off-by: Claudio Fontana
> Cc: Paolo Bonzini
> ---
> target/arm/tcg/tcg-cpu.h| 4 ++-
> target/arm/cpu.c| 38 +++
>
kernel-doc doesn't like multiple Note sections. Also add an explicit
Return.
Signed-off-by: Alex Bennée
---
include/qemu/qemu-plugin.h | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/include/qemu/qemu-plugin.h b/include/qemu/qemu-plugin.h
index
Signed-off-by: Alex Bennée
---
include/qemu/qemu-plugin.h | 25 ++---
1 file changed, 22 insertions(+), 3 deletions(-)
diff --git a/include/qemu/qemu-plugin.h b/include/qemu/qemu-plugin.h
index ac1bb318da..09b235f0b4 100644
--- a/include/qemu/qemu-plugin.h
+++
From: Yonggang Luo
This is used for counting how much function are export to qemu plugin.
Signed-off-by: Yonggang Luo
Reviewed-by: Alex Bennée
Signed-off-by: Alex Bennée
Message-Id: <20201013002806.1447-2-luoyongg...@gmail.com>
---
plugins/api.c | 8 +++-
1 file changed, 3
Emulators are currently using OptsVisitor (via user_creatable_add_opts)
to parse the -object command line option. This has one extra feature,
compared to keyval, which is automatic conversion of integers to lists
as well as support for lists as repeated options:
-object
From: Aaron Lindsay
This allows plugins to query for full virtual-to-physical address
translation for a given `qemu_plugin_hwaddr` and stops exposing the
offset within the device itself. As this change breaks the API,
QEMU_PLUGIN_VERSION is incremented.
Signed-off-by: Aaron Lindsay
Signed-off-by: Alex Bennée
---
include/qemu/qemu-plugin.h | 17 ++---
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/include/qemu/qemu-plugin.h b/include/qemu/qemu-plugin.h
index 09b235f0b4..9ae3940d89 100644
--- a/include/qemu/qemu-plugin.h
+++
Signed-off-by: Alex Bennée
---
include/qemu/qemu-plugin.h | 35 ---
1 file changed, 28 insertions(+), 7 deletions(-)
diff --git a/include/qemu/qemu-plugin.h b/include/qemu/qemu-plugin.h
index d4adce730a..aed868d42a 100644
--- a/include/qemu/qemu-plugin.h
+++
The command-line creation test is using QemuOpts. Switch it to keyval,
since the emulator has some special needs and thus the last user of
user_creatable_add_opts will go away with the next patch.
Reviewed-by: Kevin Wolf
Signed-off-by: Paolo Bonzini
---
tests/check-qom-proplist.c | 77
From: Matthias Weckbecker
This commit adds a new syscalls plugin that displays the syscalls
as they are executed and returned. This plugin outputs the number
of the syscall as well as the syscall return value.
Works in *-user only.
Essentially, this commit restores:
Hi,
This is rolling up the plugins changes for 6.0. A couple of fixes and
I've also spent some time cleaning up the kernel-doc comments for the
developer manual.
The following need review:
- plugins: expand kernel-doc for memory query and instrumentation
- plugins: expand kernel-doc for
Also add a note to explain currently they are unused.
Signed-off-by: Alex Bennée
---
include/qemu/qemu-plugin.h | 16 +---
1 file changed, 13 insertions(+), 3 deletions(-)
diff --git a/include/qemu/qemu-plugin.h b/include/qemu/qemu-plugin.h
index 9ae3940d89..c98866a637 100644
---
This is a replacement for -object QAPIfication that keeps QemuOpts
in order to not break some of the CLI parsing extensions that OptsVisitor
includes. Since keyval is not used, support for directly passing
JSON syntax to the option must be added manually, which is what patch
3 does. However,
On 3/12/21 6:04 PM, Paolo Bonzini wrote:
> On 12/03/21 14:40, Claudio Fontana wrote:
>> /*
>> * double dispatch. The first callback allows the accel cpu
>> * to run initializations for the CPU,
>> * the second one allows the CPU to customize the accel cpu
>> * behavior
We have kerneldoc tags for the headers so we might as well extract
them into our developer documentation whilst we are at it.
Signed-off-by: Alex Bennée
---
docs/devel/tcg-plugins.rst | 5 +
1 file changed, 5 insertions(+)
diff --git a/docs/devel/tcg-plugins.rst
1 - 100 of 460 matches
Mail list logo
