[PATCH] hw/char/pl011: Fix clock migration failure

2021-03-16 Thread Gavin Shan
There is a added clock to trace buad rate change since v5.2.0 by commit aac63e0e6ea3 ("hw/char/pl011: add a clock input"). The added clock causes migration failure. For example, migration from v5.2.0 to v5.1.0 can fail with the following error messages: qemu-system-aarch64: error while loading

Re: [PULL V2 16/20] qapi: net: Add query-netdev command

2021-03-16 Thread Jason Wang
在 2021/3/17 上午5:27, Peter Maydell 写道: On Mon, 15 Mar 2021 at 09:15, Jason Wang wrote: From: Alexey Kirillov The query-netdev command is used to get the configuration of the current network device backends (netdevs). This is the QMP analog of the HMP command "info network" but only for

Re: [PATCH v5 42/57] tcg/tci: Split out tcg_out_op_r[iI]

2021-03-16 Thread Richard Henderson
On 3/16/21 5:39 PM, Philippe Mathieu-Daudé wrote: "And support mov_i64 on 32-bit host"? Um, no... +case TCG_TYPE_I32: +tcg_out_op_ri(s, INDEX_op_tci_movi_i32, ret, arg); +break; #if TCG_TARGET_REG_BITS == 64 +case TCG_TYPE_I64: +tcg_out_op_rI(s,

[PULL 3/5] avocado_qemu: add exec_command function

2021-03-16 Thread Cleber Rosa
From: Willian Rampazzo Sometimes a test needs to send a command to a console without waiting for a pattern as a result, or the command issued do not produce any kind of output, like, for example, a `mount` command. This introduces the `exec_command` function to the avocado_qemu, allowing the

[PULL 4/5] tests: Add functional test for out-of-process device emulation

2021-03-16 Thread Cleber Rosa
From: Jagannathan Raman Runs the Avocado acceptance test to check if a remote lsi53c895a device gets identified by the guest. Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Reviewed-by: Wainer dos Santos Moschetta Reviewed-by: Marc-André Lureau

[PULL 2/5] tests/migration: fix unix socket batch migration

2021-03-16 Thread Cleber Rosa
From: Hyman when execute the following test command: "guestperf-batch.py --dst-host localhost --transport unix ..." test aborts and error message as the following be throwed: "launching VM Failed: [Errno 98] Address already in use". The reason is that batch script use the same monitor socket in

[PULL 1/5] tests/acceptance: Print expected message on wait_for_console_pattern

2021-03-16 Thread Cleber Rosa
From: Wainer dos Santos Moschetta For the sake of improve debuggability of tests which use the wait_for_console_pattern(), this changed the _console_interaction() so that the expected message is printed if the test fail. Signed-off-by: Wainer dos Santos Moschetta Message-Id:

[PULL 5/5] tests/acceptance: linux-related tests fix

2021-03-16 Thread Cleber Rosa
From: Pavel Dovgalyuk This patch allows cloudinit images download when ssh key is not specified. Signed-off-by: Pavel Dovgalyuk Message-Id: <161373266228.1608713.7614311331725780044.stgit@pasha-ThinkPad-X280> Reviewed-by: Willian Rampazzo Signed-off-by: Cleber Rosa ---

[PULL 0/5] Acceptance Tests and Python libs patches for 2021-03-16

2021-03-16 Thread Cleber Rosa
The following changes since commit 5b7f5586d182b0cafb1f8d558992a14763e2953e: Merge remote-tracking branch 'remotes/kraxel/tags/usb-20210315-pull-request= ' into staging (2021-03-16 13:17:54 +) are available in the Git repository at: https://gitlab.com/cleber.gnu/qemu.git/

Re: Question about two option formats for netdev

2021-03-16 Thread Jason Wang
- 原始邮件 - > Hi. > > I have a question about adding > a network device. > > > qemu-system-arm -machine vexpress-a9 \ > -net nic,model=lan9118 -net user ... > > works for me, but 'man qemu-system-arm' > says this is "Legacy option". > > > Is there any new (or recommended) form > to

Re: [PATCH v5 22/57] tcg: Build ffi data structures for helpers

2021-03-16 Thread Richard Henderson
On 3/16/21 4:35 PM, Philippe Mathieu-Daudé wrote: Hi Richard, On 3/11/21 3:39 PM, Richard Henderson wrote: We will shortly use libffi for tci, as that is the only portable way of calling arbitrary functions. Signed-off-by: Richard Henderson --- meson.build| 9

Can not use hmp block_resize command with -blockdev option

2021-03-16 Thread zhao xiaojun
Hi, I use -blockdev option to specify a drive when qemu boot and i want to resize it with hmp block_resize command. The hmp block_resize comand's arguments: block_resize device new_size. So I query the device by qmp query_block command, but the device filed of the result output is NULL string.

Re: [PULL for-6.0 0/6] qemu-ga patch queue for soft-freeze

2021-03-16 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210317032217.1460684-1-michael.r...@amd.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210317032217.1460684-1-michael.r...@amd.com Subject: [PULL for-6.0 0/6] qemu-ga

Re: [PATCH v5 05/57] tcg/tci: Split out tci_args_rrr

2021-03-16 Thread Richard Henderson
On 3/16/21 4:53 PM, Philippe Mathieu-Daudé wrote: On 3/11/21 3:39 PM, Richard Henderson wrote: Signed-off-by: Richard Henderson --- tcg/tci.c | 154 -- 1 file changed, 57 insertions(+), 97 deletions(-) Out of curiosity, did you do that

[PULL for-6.0 0/6] qemu-ga patch queue for soft-freeze

2021-03-16 Thread Michael Roth
The following changes since commit 5b7f5586d182b0cafb1f8d558992a14763e2953e: Merge remote-tracking branch 'remotes/kraxel/tags/usb-20210315-pull-request' into staging (2021-03-16 13:17:54 +) are available in the Git repository at: g...@github.com:mdroth/qemu.git

Re: [PULL V2 16/20] qapi: net: Add query-netdev command

2021-03-16 Thread Jason Wang
在 2021/3/17 上午5:37, Peter Maydell 写道: On Mon, 15 Mar 2021 at 09:15, Jason Wang wrote: From: Alexey Kirillov The query-netdev command is used to get the configuration of the current network device backends (netdevs). This is the QMP analog of the HMP command "info network" but only for

[PULL for-6.0 5/6] qga: Switch and case should be at the same indent

2021-03-16 Thread Michael Roth
From: AlexChen Reported-by: Euler Robot Signed-off-by: AlexChen Reviewed-by: Marc-André Lureau Signed-off-by: Michael Roth --- qga/main.c | 52 ++-- 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a/qga/main.c b/qga/main.c index

[PULL for-6.0 4/6] qga: Open brace '{' following struct go on the same

2021-03-16 Thread Michael Roth
From: AlexChen Reported-by: Euler Robot Signed-off-by: AlexChen Reviewed-by: Marc-André Lureau Signed-off-by: Michael Roth --- qga/main.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/qga/main.c b/qga/main.c index 560490467b..20db0058db 100644 --- a/qga/main.c +++

[PULL for-6.0 6/6] qga: return a more explicit error on why a command is disabled

2021-03-16 Thread Michael Roth
From: Marc-André Lureau qmp_disable_command() now takes an optional error string to return a more explicit error message. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1928806 Signed-off-by: Marc-André Lureau *fix up 80+ char line Signed-off-by: Michael Roth ---

[PULL for-6.0 3/6] qga: Delete redundant spaces

2021-03-16 Thread Michael Roth
From: AlexChen Reported-by: Euler Robot Signed-off-by: AlexChen Reviewed-by: Marc-André Lureau Signed-off-by: Michael Roth --- qga/commands-win32.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qga/commands-win32.c b/qga/commands-win32.c index

[PULL for-6.0 1/6] qga: Correct loop count in qmp_guest_get_vcpus()

2021-03-16 Thread Michael Roth
From: Lin Ma The guest-get-vcpus returns incorrect vcpu info in case we hotunplug vcpus(not the last one). e.g.: A VM has 4 VCPUs: cpu0 + 3 hotunpluggable online vcpus(cpu1, cpu2 and cpu3). Hotunplug cpu2, Now only cpu0, cpu1 and cpu3 are present & online. ./qmp-shell /tmp/qmp-monitor.sock

[PULL for-6.0 2/6] qga: Add spaces around operator

2021-03-16 Thread Michael Roth
From: AlexChen Reported-by: Euler Robot Signed-off-by: AlexChen Reviewed-by: Marc-André Lureau *fix 80+ char violation while we're here *fix w32 build breakage from changing INVALID_SET_FILE_POINTER definition from a cast to a subtraction Signed-off-by: Michael Roth --- qga/channel-win32.c

Re: [RFC v2 11/13] vhost: Shadow virtqueue buffers forwarding

2021-03-16 Thread Jason Wang
在 2021/3/17 上午12:05, Eugenio Perez Martin 写道: On Tue, Mar 16, 2021 at 9:15 AM Jason Wang wrote: 在 2021/3/16 上午3:48, Eugenio Pérez 写道: Initial version of shadow virtqueue that actually forward buffers. It reuses the VirtQueue code for the device part. The driver part is based on Linux's

Re: [PATCH 06/38] target/riscv: SIMD 16-bit Shift Instructions

2021-03-16 Thread LIU Zhiwei
On 2021/3/17 3:54, Alistair Francis wrote: On Mon, Mar 15, 2021 at 10:40 PM LIU Zhiwei wrote: On 2021/3/16 5:25, Alistair Francis wrote: On Fri, Feb 12, 2021 at 10:16 AM LIU Zhiwei wrote: Signed-off-by: LIU Zhiwei --- target/riscv/helper.h | 9 ++

Re: [RFC v2 10/13] vhost: add vhost_kernel_set_vring_enable

2021-03-16 Thread Jason Wang
在 2021/3/16 下午6:43, Eugenio Perez Martin 写道: On Tue, Mar 16, 2021 at 8:30 AM Jason Wang wrote: 在 2021/3/16 上午3:48, Eugenio Pérez 写道: This method is already present in vhost-user. This commit adapts it to vhost-net, so SVQ can use. vhost_kernel_set_enable stops the device, so qemu can ask

Re: [RFC v2 05/13] vhost: Route guest->host notification through shadow virtqueue

2021-03-16 Thread Jason Wang
在 2021/3/16 下午6:31, Eugenio Perez Martin 写道: On Tue, Mar 16, 2021 at 8:18 AM Jason Wang wrote: 在 2021/3/16 上午3:48, Eugenio Pérez 写道: Shadow virtqueue notifications forwarding is disabled when vhost_dev stops, so code flow follows usual cleanup. Signed-off-by: Eugenio Pérez ---

Re: [PATCH v2 1/2] tests/acceptance: Test ast2400 and ast2500 machines

2021-03-16 Thread Cleber Rosa
On Thu, Mar 04, 2021 at 11:09:50PM +1030, Joel Stanley wrote: > Test MTD images from the OpenBMC project on AST2400 and AST2500 SoCs > from ASPEED, by booting Palmetto and Romulus BMC machines. > > The images are fetched from OpenBMC's release directory on github. > > Co-developed-by: Cédric Le

RE: [PATCH v2 1/1] docs/devel: Add VFIO device migration documentation

2021-03-16 Thread Tian, Kevin
> From: Tarun Gupta (SW-GPU) > Sent: Tuesday, March 16, 2021 9:35 PM > > > >> + > >> +* A ``save_live_iterate`` function that reads the VFIO device's data from > the > >> + vendor driver through the migration region during iterative phase. > >> + > >> +* A ``save_live_complete_precopy``

RE: [PATCH v2 1/1] docs/devel: Add VFIO device migration documentation

2021-03-16 Thread Tian, Kevin
> From: Dr. David Alan Gilbert > Sent: Tuesday, March 16, 2021 11:47 PM > > * Tian, Kevin (kevin.t...@intel.com) wrote: > > > From: Qemu-devel bounces+kevin.tian=intel@nongnu.org> > > > On Behalf Of Dr. David Alan Gilbert > > > > > > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > > >

[PATCH v10 3/7] vt82c686: Introduce abstract TYPE_VIA_ISA and base vt82c686b_isa on it

2021-03-16 Thread BALATON Zoltan
To allow reusing ISA bridge emulation for vt8231_isa move the device state of vt82c686b_isa emulation in an abstract via_isa class. This change breaks migration back compatibility but this is not an issue for Fuloong2E machine which is not versioned or migration supported. Signed-off-by: BALATON

Re: [PATCH v4 1/2] migration/ram: Reduce unnecessary rate limiting

2021-03-16 Thread Kunkun Jiang
Hi  Peter, On 2021/3/17 5:39, Peter Xu wrote: On Tue, Mar 16, 2021 at 08:57:15PM +0800, Kunkun Jiang wrote: When the host page is a huge page and something is sent in the current iteration, migration_rate_limit() should be executed. If not, it can be omitted. Signed-off-by: Keqian Zhu

[PATCH v10 1/7] vt82c686: QOM-ify superio related functionality

2021-03-16 Thread BALATON Zoltan
Collect superio functionality and its controlling config registers handling in an abstract VIA_SUPERIO class that is a subclass of ISA_SUPERIO and put vt82c686b specific parts in a subclass of this abstract class. Signed-off-by: BALATON Zoltan Reviewed-by: Mark Cave-Ayland ---

Re: [PATCH v9 0/7] Pegasos2 emulation

2021-03-16 Thread BALATON Zoltan
On Wed, 17 Mar 2021, Mark Cave-Ayland wrote: On 16/03/2021 22:03, BALATON Zoltan wrote: Hello, This is adding a new PPC board called pegasos2. More info on it can be found at: https://osdn.net/projects/qmiga/wiki/SubprojectPegasos2 Currently it needs a firmware ROM image that I cannot

[PATCH v10 7/7] hw/ppc: Add emulation of Genesi/bPlan Pegasos II

2021-03-16 Thread BALATON Zoltan
Add new machine called pegasos2 emulating the Genesi/bPlan Pegasos II, a PowerPC board based on the Marvell MV64361 system controller and the VIA VT8231 integrated south bridge/superio chips. It can run Linux, AmigaOS and a wide range of MorphOS versions. Currently a firmware ROM image is needed

[PATCH v10 0/7] Pegasos2 emulation

2021-03-16 Thread BALATON Zoltan
Hello, This is adding a new PPC board called pegasos2. More info on it can be found at: https://osdn.net/projects/qmiga/wiki/SubprojectPegasos2 Currently it needs a firmware ROM image that I cannot include due to original copyright holder (bPlan) did not release it under a free licence but I

[PATCH v10 2/7] vt82c686: Add VT8231_SUPERIO based on VIA_SUPERIO

2021-03-16 Thread BALATON Zoltan
The VT8231 south bridge is very similar to VT82C686B but there are some differences in register addresses and functionality, e.g. the VT8231 only has one serial port. This commit adds VT8231_SUPERIO subclass based on the abstract VIA_SUPERIO class to emulate the superio part of VT8231.

[PATCH v10 6/7] hw/pci-host: Add emulation of Marvell MV64361 PPC system controller

2021-03-16 Thread BALATON Zoltan
The Marvell Discovery II aka. MV64361 is a PowerPC system controller chip that is used on the pegasos2 PPC board. This adds emulation of it that models the device enough to boot guests on this board. The mv643xx.h header with register definitions is taken from Linux 4.15.10 only fixing white space

[PATCH v10 5/7] hw/isa/Kconfig: Add missing dependency VIA VT82C686 -> APM

2021-03-16 Thread BALATON Zoltan
From: Philippe Mathieu-Daudé TYPE_VIA_PM calls apm_init() in via_pm_realize(), so requires APM to be selected. Reported-by: BALATON Zoltan Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: BALATON Zoltan --- hw/isa/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH v10 4/7] vt82c686: Add emulation of VT8231 south bridge

2021-03-16 Thread BALATON Zoltan
Add emulation of VT8231 south bridge ISA part based on the similar VT82C686B but implemented in a separate subclass that holds the differences while reusing parts that can be shared. Signed-off-by: BALATON Zoltan Reviewed-by: Philippe Mathieu-Daudé --- hw/isa/vt82c686.c | 84

Re: [PATCH v9 6/7] hw/pci-host: Add emulation of Marvell MV64361 PPC system controller

2021-03-16 Thread BALATON Zoltan
On Wed, 17 Mar 2021, Philippe Mathieu-Daudé wrote: On 3/16/21 11:03 PM, BALATON Zoltan wrote: The Marvell Discovery II aka. MV64361 is a PowerPC system controller chip that is used on the pegasos2 PPC board. This adds emulation of it that models the device enough to boot guests on this board.

[PATCH v3] linux-user: add missing MULTICAST_IF get/setsockopt option

2021-03-16 Thread Jiaxun Yang
{IP,IPV6}_MULTICAST_IF was not supported. Signed-off-by: Jiaxun Yang Reported-by: Yunqiang Su --- v3: Add missing reported-by. --- linux-user/syscall.c | 4 1 file changed, 4 insertions(+) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 389ec09764..77343130b3 100644 ---

[PATCH v2] target/mips: Deprecate Trap-and-Emul KVM support

2021-03-16 Thread Jiaxun Yang
Upstream kernel had removed both host[1] and guest[2] support. [1]: https://git.kernel.org/pub/scm/linux/kernel/git/mips/linux.git/commit/?id=45c7e8af4a5e3f0bea4ac209eea34118dd57ac64 [2]:

Re: [PATCH] tests/acceptance: Print expected message on wait_for_console_pattern

2021-03-16 Thread Cleber Rosa
On Tue, Mar 09, 2021 at 12:35:07PM -0300, Wainer dos Santos Moschetta wrote: > For the sake of improve debuggability of tests which use the > wait_for_console_pattern(), this changed the _console_interaction() so that > the expected message is printed if the test fail. > > Signed-off-by: Wainer

Re: [PATCH v9 6/7] hw/pci-host: Add emulation of Marvell MV64361 PPC system controller

2021-03-16 Thread Philippe Mathieu-Daudé
On 3/16/21 11:03 PM, BALATON Zoltan wrote: > The Marvell Discovery II aka. MV64361 is a PowerPC system controller > chip that is used on the pegasos2 PPC board. This adds emulation of it > that models the device enough to boot guests on this board. The > mv643xx.h header with register definitions

Re: [PATCH v5 00/57] TCI fixes and cleanups

2021-03-16 Thread Philippe Mathieu-Daudé
On 3/11/21 3:39 PM, Richard Henderson wrote: > Changes since v4: > * 19 more patches now upstream. I'm done for today. Hope in time so you can squeeze another batch in 6.0. Regards, Phil.

Re: [PATCH v5 21/57] tcg/tci: Implement the disassembler properly

2021-03-16 Thread Philippe Mathieu-Daudé
On 3/11/21 3:39 PM, Richard Henderson wrote: > Actually print arguments as opposed to simply the opcodes > and, uselessly, the argument counts. Reuse all of the helpers > developed as part of the interpreter. > > Signed-off-by: Richard Henderson > --- > meson.build | 2 +- >

Re: [PATCH v5 16/57] tcg/tci: Clean up deposit operations

2021-03-16 Thread Philippe Mathieu-Daudé
On 3/11/21 3:39 PM, Richard Henderson wrote: > Use the correct set of asserts during code generation. > We do not require the first input to overlap the output; > the existing interpreter already supported that. > > Split out tci_args_rrrbb in the translator. > Use the deposit32/64 functions

Re: [PATCH v5 13/57] tcg/tci: Reuse tci_args_l for goto_tb

2021-03-16 Thread Philippe Mathieu-Daudé
On 3/11/21 3:39 PM, Richard Henderson wrote: > Convert to indirect jumps, as it's less complicated. > Then we just have a pointer to the tb address at which > the chain is stored, from which we read. > > Signed-off-by: Richard Henderson > --- > tcg/tci/tcg-target.h | 11 +++ >

Re: [PATCH v9 0/7] Pegasos2 emulation

2021-03-16 Thread Mark Cave-Ayland
On 16/03/2021 22:03, BALATON Zoltan wrote: Hello, This is adding a new PPC board called pegasos2. More info on it can be found at: https://osdn.net/projects/qmiga/wiki/SubprojectPegasos2 Currently it needs a firmware ROM image that I cannot include due to original copyright holder (bPlan)

Re: [PATCH v5 00/57] TCI fixes and cleanups

2021-03-16 Thread Philippe Mathieu-Daudé
On 3/11/21 3:39 PM, Richard Henderson wrote: > > Richard Henderson (57): > tcg/tci: Remove ifdefs for TCG_TARGET_HAS_ext32[us]_i64 > tcg/tci: Rename tci_read_r to tci_read_rval > tcg/tci: Split out tci_args_rrs > tcg/tci: Split out tci_args_rr > tcg/tci: Split out tci_args_rrr >

Re: [PATCH 0/4] esp: fix asserts/segfaults discovered by fuzzer

2021-03-16 Thread Philippe Mathieu-Daudé
+Laurent for 1 & 4. On 3/17/21 12:30 AM, Mark Cave-Ayland wrote: > Recently there have been a number of issues raised on Launchpad as a result of > fuzzing the am53c974 (ESP) device. I spent some time over the past couple of > days checking to see if anything had improved since my last patchset:

Re: [PATCH 2/4] esp: don't overflow cmdfifo if TC is larger than the cmdfifo size

2021-03-16 Thread Philippe Mathieu-Daudé
On 3/17/21 12:30 AM, Mark Cave-Ayland wrote: > If a guest transfers the message out/command phase data using DMA with a TC > that is larger than the cmdfifo size then the cmdfifo overflows triggering > an assert. Limit the size of the transfer to the free space available in > cmdfifo. > >

Re: [PATCH 3/4] esp: ensure cmdfifo is not empty and current_dev is non-NULL

2021-03-16 Thread Philippe Mathieu-Daudé
On 3/17/21 12:30 AM, Mark Cave-Ayland wrote: > When about to execute a SCSI command, ensure that cmdfifo is not empty and > current_dev is non-NULL. This can happen if the guest tries to execute a TI > (Transfer Information) command without issuing one of the select commands > first. > > Buglink:

Re: [PATCH v1] piix: fix regression during unplug in Xen HVM domUs

2021-03-16 Thread Philippe Mathieu-Daudé
On 3/16/21 11:44 PM, Olaf Hering wrote: > Commit ee358e919e385fdc79d59d0d47b4a81e349cd5c9 causes a regression in > Xen HVM domUs which run xenlinux based kernels. > > If the domU has an USB device assigned, for example with > "usbdevice=['tablet']" in domU.cfg, the late unplug of devices will >

Re: [PATCH v7 00/35] Hexagon patch series

2021-03-16 Thread Philippe Mathieu-Daudé
On 1/26/21 12:28 AM, Brian Cain wrote: >> -Original Message- >> From: Taylor Simpson >> Sent: Monday, January 25, 2021 5:09 PM >> To: Philippe Mathieu-Daudé ; qemu-devel@nongnu.org >> Cc: richard.hender...@linaro.org; alex.ben...@linaro.org; >> laur...@vivier.eu; a...@rev.ng; Brian Cain

Re: [PATCH v9 1/7] vt82c686: QOM-ify superio related functionality

2021-03-16 Thread Mark Cave-Ayland
On 16/03/2021 22:03, BALATON Zoltan wrote: Collect superio functionality and its controlling config registers handling in an abstract VIA_SUPERIO class that is a subclass of ISA_SUPERIO and put vt82c686b specific parts in a subclass of this abstract class. Signed-off-by: BALATON Zoltan ---

Re: [PATCH v3 1/3] hw: Model ASPEED's Hash and Crypto Engine

2021-03-16 Thread Andrew Jeffery
On Fri, 12 Mar 2021, at 21:27, Joel Stanley wrote: > The HACE (Hash and Crypto Engine) is a device that offloads MD5, SHA1, > SHA2, RSA and other cryptographic algorithms. > > This initial model implements a subset of the device's functionality; > currently only direct access (non-scatter

Re: [PATCH v5 10/57] tcg/tci: Split out tci_args_ri and tci_args_rI

2021-03-16 Thread Philippe Mathieu-Daudé
On 3/11/21 3:39 PM, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/tci.c | 38 ++ > 1 file changed, 22 insertions(+), 16 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v5 15/57] tcg/tci: Split out tci_args_rrrr

2021-03-16 Thread Philippe Mathieu-Daudé
On 3/11/21 3:39 PM, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/tci.c | 16 +++- > 1 file changed, 11 insertions(+), 5 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v5 30/57] tcg/tci: Split out tcg_out_op_rr

2021-03-16 Thread Philippe Mathieu-Daudé
On 3/11/21 3:39 PM, Richard Henderson wrote: > At the same time, validate the type argument in tcg_out_mov. > > Signed-off-by: Richard Henderson > --- > tcg/tci/tcg-target.c.inc | 36 +++- > 1 file changed, 23 insertions(+), 13 deletions(-) Reviewed-by: Philippe

Re: [PATCH v5 39/57] tcg/tci: Split out tcg_out_op_{rrm,rrrm,rrrrm}

2021-03-16 Thread Philippe Mathieu-Daudé
On 3/11/21 3:39 PM, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/tci/tcg-target.c.inc | 70 ++-- > 1 file changed, 53 insertions(+), 17 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v5 40/57] tcg/tci: Split out tcg_out_op_v

2021-03-16 Thread Philippe Mathieu-Daudé
On 3/11/21 3:39 PM, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/tci/tcg-target.c.inc | 14 ++ > 1 file changed, 10 insertions(+), 4 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v5 42/57] tcg/tci: Split out tcg_out_op_r[iI]

2021-03-16 Thread Philippe Mathieu-Daudé
"And support mov_i64 on 32-bit host"? On 3/11/21 3:39 PM, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/tci/tcg-target.c.inc | 50 > 1 file changed, 35 insertions(+), 15 deletions(-) Reviewed-by: Philippe Mathieu-Daudé >

Re: [PATCH v5 37/57] tcg/tci: Split out tcg_out_op_rrrr

2021-03-16 Thread Philippe Mathieu-Daudé
On 3/11/21 3:39 PM, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/tci/tcg-target.c.inc | 21 +++-- > 1 file changed, 15 insertions(+), 6 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v5 41/57] tcg/tci: Split out tcg_out_op_np

2021-03-16 Thread Philippe Mathieu-Daudé
On 3/11/21 3:39 PM, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/tci/tcg-target.c.inc | 18 +- > 1 file changed, 13 insertions(+), 5 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

[PATCH 0/4] esp: fix asserts/segfaults discovered by fuzzer

2021-03-16 Thread Mark Cave-Ayland
Recently there have been a number of issues raised on Launchpad as a result of fuzzing the am53c974 (ESP) device. I spent some time over the past couple of days checking to see if anything had improved since my last patchset: from what I can tell the issues are still present, but the cmdfifo

[PATCH 3/4] esp: ensure cmdfifo is not empty and current_dev is non-NULL

2021-03-16 Thread Mark Cave-Ayland
When about to execute a SCSI command, ensure that cmdfifo is not empty and current_dev is non-NULL. This can happen if the guest tries to execute a TI (Transfer Information) command without issuing one of the select commands first. Buglink: https://bugs.launchpad.net/qemu/+bug/1910723 Buglink:

Re: [PATCH v5 36/57] tcg/tci: Split out tcg_out_op_rrrrrr

2021-03-16 Thread Philippe Mathieu-Daudé
On 3/11/21 3:39 PM, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/tci/tcg-target.c.inc | 27 +++ > 1 file changed, 19 insertions(+), 8 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v5 38/57] tcg/tci: Split out tcg_out_op_rrrrcl

2021-03-16 Thread Philippe Mathieu-Daudé
On 3/11/21 3:39 PM, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/tci/tcg-target.c.inc | 27 +++ > 1 file changed, 19 insertions(+), 8 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

[PATCH 2/4] esp: don't overflow cmdfifo if TC is larger than the cmdfifo size

2021-03-16 Thread Mark Cave-Ayland
If a guest transfers the message out/command phase data using DMA with a TC that is larger than the cmdfifo size then the cmdfifo overflows triggering an assert. Limit the size of the transfer to the free space available in cmdfifo. Buglink: https://bugs.launchpad.net/qemu/+bug/1919036

Re: [PATCH v5 35/57] tcg/tci: Split out tcg_out_op_rrcl

2021-03-16 Thread Philippe Mathieu-Daudé
On 3/11/21 3:39 PM, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/tci/tcg-target.c.inc | 21 +++-- > 1 file changed, 15 insertions(+), 6 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

[PATCH 4/4] esp: always check current_req is not NULL before use in DMA callbacks

2021-03-16 Thread Mark Cave-Ayland
After issuing a SCSI command the SCSI layer can call the SCSIBusInfo .cancel callback which resets both current_req and current_dev to NULL. If any data is left in the transfer buffer (async_len != 0) then the next TI (Transfer Information) command will attempt to reference the NULL pointer

[PATCH 1/4] esp: don't underflow cmdfifo if no message out/command data is present

2021-03-16 Thread Mark Cave-Ayland
If a guest sends a TI (Transfer Information) command without previously sending any message out/command phase data then cmdfifo will underflow triggering an assert reading the IDENTIFY byte. Buglink: https://bugs.launchpad.net/qemu/+bug/1919035 Signed-off-by: Mark Cave-Ayland --- hw/scsi/esp.c

Re: [PATCH v5 34/57] tcg/tci: Split out tcg_out_op_rrrbb

2021-03-16 Thread Philippe Mathieu-Daudé
On 3/11/21 3:39 PM, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/tci/tcg-target.c.inc | 23 --- > 1 file changed, 16 insertions(+), 7 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v5 33/57] tcg/tci: Split out tcg_out_op_rrrrrc

2021-03-16 Thread Philippe Mathieu-Daudé
On 3/11/21 3:39 PM, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/tci/tcg-target.c.inc | 30 +- > 1 file changed, 21 insertions(+), 9 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v5 32/57] tcg/tci: Split out tcg_out_op_rrrc

2021-03-16 Thread Philippe Mathieu-Daudé
On 3/11/21 3:39 PM, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/tci/tcg-target.c.inc | 21 +++-- > 1 file changed, 15 insertions(+), 6 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v5 31/57] tcg/tci: Split out tcg_out_op_rrr

2021-03-16 Thread Philippe Mathieu-Daudé
On 3/11/21 3:39 PM, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/tci/tcg-target.c.inc | 19 ++- > 1 file changed, 14 insertions(+), 5 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v5 29/57] tcg/tci: Split out tcg_out_op_p

2021-03-16 Thread Philippe Mathieu-Daudé
On 3/11/21 3:39 PM, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/tci/tcg-target.c.inc | 18 -- > 1 file changed, 12 insertions(+), 6 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v5 28/57] tcg/tci: Split out tcg_out_op_l

2021-03-16 Thread Philippe Mathieu-Daudé
On 3/11/21 3:39 PM, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/tci/tcg-target.c.inc | 14 +++--- > 1 file changed, 11 insertions(+), 3 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v5 18/57] tcg/tci: Split out tci_args_{rrm,rrrm,rrrrm}

2021-03-16 Thread Philippe Mathieu-Daudé
On 3/11/21 3:39 PM, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/tci.c | 147 ++ > 1 file changed, 81 insertions(+), 66 deletions(-) Chapeau. Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v5 17/57] tcg/tci: Reduce qemu_ld/st TCGMemOpIdx operand to 32-bits

2021-03-16 Thread Philippe Mathieu-Daudé
On 3/11/21 3:39 PM, Richard Henderson wrote: > We are currently using the "natural" size routine, which > uses 64-bits on a 64-bit host. The TCGMemOpIdx operand > has 11 bits, so we can safely reduce to 32-bits. > > Signed-off-by: Richard Henderson > --- > tcg/tci.c| 8

Re: [PATCH v5 12/57] tcg/tci: Reuse tci_args_l for exit_tb

2021-03-16 Thread Philippe Mathieu-Daudé
On 3/11/21 3:39 PM, Richard Henderson wrote: > Do not emit a uint64_t, but a tcg_target_ulong, aka uintptr_t. > This reduces the size of the constant on 32-bit hosts. > The assert for label != NULL has to be removed because that > is a valid value for exit_tb. > > Signed-off-by: Richard Henderson

Re: [PATCH v5 14/57] tcg/tci: Split out tci_args_rrrrrr

2021-03-16 Thread Philippe Mathieu-Daudé
On 3/11/21 3:39 PM, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/tci.c | 31 --- > 1 file changed, 20 insertions(+), 11 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v5 11/57] tcg/tci: Reuse tci_args_l for calls.

2021-03-16 Thread Philippe Mathieu-Daudé
On 3/11/21 3:39 PM, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/tci.c | 38 +++--- > 1 file changed, 19 insertions(+), 19 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v5 09/57] tcg/tci: Split out tci_args_rrcl and tci_args_rrrrcl

2021-03-16 Thread Philippe Mathieu-Daudé
On 3/11/21 3:39 PM, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/tci.c | 52 > 1 file changed, 32 insertions(+), 20 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v5 08/57] tcg/tci: Split out tci_args_rrrrrc

2021-03-16 Thread Philippe Mathieu-Daudé
On 3/11/21 3:39 PM, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/tci.c | 25 +++-- > 1 file changed, 19 insertions(+), 6 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v5 07/57] tcg/tci: Split out tci_args_l

2021-03-16 Thread Philippe Mathieu-Daudé
On 3/11/21 3:39 PM, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/tci.c | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/tcg/tci.c b/tcg/tci.c > index bdd2127ec8..6e9d482885 100644 > --- a/tcg/tci.c > +++ b/tcg/tci.c > @@ -184,6 +184,11

Re: [PATCH v5 06/57] tcg/tci: Split out tci_args_rrrc

2021-03-16 Thread Philippe Mathieu-Daudé
On 3/11/21 3:39 PM, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/tci.c | 23 +-- > 1 file changed, 13 insertions(+), 10 deletions(-) > > diff --git a/tcg/tci.c b/tcg/tci.c > index 1c879a2536..bdd2127ec8 100644 > --- a/tcg/tci.c > +++ b/tcg/tci.c >

Re: [PATCH v5 05/57] tcg/tci: Split out tci_args_rrr

2021-03-16 Thread Philippe Mathieu-Daudé
On 3/11/21 3:39 PM, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/tci.c | 154 -- > 1 file changed, 57 insertions(+), 97 deletions(-) Out of curiosity, did you do that manually or coccinelle? Reviewed-by: Philippe

Re: [PATCH v5 04/57] tcg/tci: Split out tci_args_rr

2021-03-16 Thread Philippe Mathieu-Daudé
On 3/11/21 3:39 PM, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/tci.c | 67 +-- > 1 file changed, 31 insertions(+), 36 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v5 03/57] tcg/tci: Split out tci_args_rrs

2021-03-16 Thread Philippe Mathieu-Daudé
On 3/11/21 3:39 PM, Richard Henderson wrote: > Begin splitting out functions that do pure argument decode, > without actually loading values from the register set. > > This means that decoding need not concern itself between > input and output registers. We can assert that the register > number

Re: [PATCH v1] piix: fix regression during unplug in Xen HVM domUs

2021-03-16 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210316224412.11609-1-o...@aepfle.de/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210316224412.11609-1-o...@aepfle.de Subject: [PATCH v1] piix: fix regression during unplug

Re: [PATCH v5 02/57] tcg/tci: Rename tci_read_r to tci_read_rval

2021-03-16 Thread Philippe Mathieu-Daudé
On 3/11/21 3:39 PM, Richard Henderson wrote: > In the next patches, we want to use tci_read_r to return > the raw register number. So rename the existing function, > which returns the register value, to tci_read_rval. > > Signed-off-by: Richard Henderson > --- > tcg/tci.c | 192

Re: [PATCH v5 52/57] tcg/tci: Implement mulu2, muls2

2021-03-16 Thread Philippe Mathieu-Daudé
On 3/11/21 3:39 PM, Richard Henderson wrote: > We already had mulu2_i32 for a 32-bit host; expand this to 64-bit > hosts as well. The muls2_i32 and the 64-bit opcodes are new. > > Signed-off-by: Richard Henderson > --- > tcg/tci/tcg-target.h | 8 > tcg/tci.c| 35

[PATCH v1] piix: fix regression during unplug in Xen HVM domUs

2021-03-16 Thread Olaf Hering
Commit ee358e919e385fdc79d59d0d47b4a81e349cd5c9 causes a regression in Xen HVM domUs which run xenlinux based kernels. If the domU has an USB device assigned, for example with "usbdevice=['tablet']" in domU.cfg, the late unplug of devices will kill the emulated USB host. As a result the khubd

Re: [PATCH v5 26/57] tcg/tci: Push opcode emit into each case

2021-03-16 Thread Philippe Mathieu-Daudé
On 3/11/21 3:39 PM, Richard Henderson wrote: > We're about to split out bytecode output into helpers, but > we can't do that one at a time if tcg_out_op_t is being done > outside of the switch. > > Signed-off-by: Richard Henderson > --- > tcg/tci/tcg-target.c.inc | 35

Re: [PATCH v5 22/57] tcg: Build ffi data structures for helpers

2021-03-16 Thread Philippe Mathieu-Daudé
Hi Richard, On 3/11/21 3:39 PM, Richard Henderson wrote: > We will shortly use libffi for tci, as that is the only > portable way of calling arbitrary functions. > > Signed-off-by: Richard Henderson > --- > meson.build| 9 +- > include/exec/helper-ffi.h

Re: [PATCH 0/5] tcg: Issue memory barriers for guest memory model

2021-03-16 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210316220735.2048137-1-richard.hender...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210316220735.2048137-1-richard.hender...@linaro.org Subject: [PATCH 0/5]

[PATCH v9 5/7] hw/isa/Kconfig: Add missing dependency VIA VT82C686 -> APM

2021-03-16 Thread BALATON Zoltan
From: Philippe Mathieu-Daudé TYPE_VIA_PM calls apm_init() in via_pm_realize(), so requires APM to be selected. Reported-by: BALATON Zoltan Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: BALATON Zoltan --- hw/isa/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH 4/5] tcg: Create tcg_req_mo

2021-03-16 Thread Richard Henderson
Split out the logic to emit a host memory barrier in response to a guest memory operation. Do not provide a true default for TCG_GUEST_DEFAULT_MO because the defined() check will still be useful for determining if a guest has been updated for MTTCG. Signed-off-by: Richard Henderson ---

  1   2   3   4   5   6   >