[PATCH v2 4/4] tests/qtest: Do not restrict bios-tables-test to Aarch64 hosts anymore

2021-03-16 Thread Philippe Mathieu-Daudé
Since commit 82bf7ae84ce ("target/arm: Remove KVM support for 32-bit Arm hosts") we can remove the comment / check added in commit ab6b6a4 and directly run the bios-tables-test. Signed-off-by: Philippe Mathieu-Daudé --- tests/qtest/meson.build | 3 +-- 1 file changed, 1 insertion(+), 2 delet

[PATCH v2 3/4] qtest/bios-tables-test: Make test build-independent from accelerator

2021-03-16 Thread Philippe Mathieu-Daudé
Now than we can probe if the TCG accelerator is available at runtime with a QMP command, do it once at the beginning and only register the tests we can run. We can then replace the #ifdef'ry by an assertion. Signed-off-by: Philippe Mathieu-Daudé --- v2: use global tcg_accel_available, call qtest_

Re: [RFC v2 00/13] vDPA software assisted live migration

2021-03-16 Thread Eugenio Perez Martin
On Tue, Mar 16, 2021 at 9:28 AM Jason Wang wrote: > > > 在 2021/3/16 上午3:48, Eugenio Pérez 写道: > > This series enable shadow virtqueue for vhost-net devices. This is a > > new method of vhost devices migration: Instead of relay on vhost > > device's dirty logging capability, SW assisted LM intercep

Re: [PATCH v2 4/4] tests/qtest: Do not restrict bios-tables-test to Aarch64 hosts anymore

2021-03-16 Thread Eric Blake
On 3/16/21 12:24 PM, Philippe Mathieu-Daudé wrote: > Since commit 82bf7ae84ce ("target/arm: Remove KVM support for > 32-bit Arm hosts") we can remove the comment / check added in > commit ab6b6a4 and directly run the bios-tables-test. > > Signed-off-by: Philippe Mathieu-Daudé > --- > tests/q

Half a usb-redir idea

2021-03-16 Thread Dr. David Alan Gilbert
Hi, I've got a half-baked idea, which I thought might be worth mentioning. How hard would it be to give qemu a usbredir server rather than client? It would have nothing guest visible but would look logically like the front (?) half of a usb interface; then you could use all of the existing qemu

Re: [PATCH v7 0/8] Pegasos2 emulation

2021-03-16 Thread BALATON Zoltan
On Tue, 16 Mar 2021, Mark Cave-Ayland wrote: On 16/03/2021 13:06, BALATON Zoltan wrote: The PATCH 1 doesn't seem to be needed to have a working Pegasos 2 machine, does it? It is needed (as well as all other patches in the series). Patch 1 is needed for getting serial output which is the only

[PATCH v2 1/4] accel: Introduce 'query-accels' QMP command

2021-03-16 Thread Philippe Mathieu-Daudé
Introduce the 'query-accels' QMP command which returns a list of built-in accelerator names. - Accelerator is a QAPI enum of all existing accelerators, - AcceleratorInfo is a QAPI structure providing accelerator specific information. Currently the common structure base provides the name of th

[PATCH v2 2/4] tests/qtest: Add qtest_has_accel() method

2021-03-16 Thread Philippe Mathieu-Daudé
Introduce the qtest_has_accel() method which allows to query at runtime if a QEMU instance has an accelerator built-in. Signed-off-by: Philippe Mathieu-Daudé --- Since v1: - rename qtest_probe_accel() -> qtest_has_accel() - run with -machine none before creating QTestState --- tests/qtest/libqos

[PATCH v2 0/4] qtests: Check accelerator available at runtime via QMP 'query-accels'

2021-03-16 Thread Philippe Mathieu-Daudé
Hi, This series aims at having accelerator-independent qtests by querying a QEMU instance at runtime to check the list of built-in accelerators. First we add the 'query-accels' QMP command, then we add the qtest_has_accel() method to libqtest, finally we use this new method to allow running bios-

Re: [PULL 00/11] QOM and fdc patches patches for 2021-03-16

2021-03-16 Thread Eric Blake
On 3/16/21 11:52 AM, Markus Armbruster wrote: > The following changes since commit 6e31b3a5c34c6e5be7ef60773e607f189eaa15f3: > > Merge remote-tracking branch 'remotes/jasowang/tags/net-pull-request' into > staging (2021-03-16 10:53:47 +) > > are available in the Git repository at: > > g

[PULL 10/10] vfio/migrate: Move switch of dirty tracking into vfio_memory_listener

2021-03-16 Thread Alex Williamson
From: Keqian Zhu For now the switch of vfio dirty page tracking is integrated into @vfio_save_handler. The reason is that some PCI vendor driver may start to track dirty base on _SAVING state of device, so if dirty tracking is started before setting device state, vfio will report full-dirty to QE

Re: [PULL 00/11] QOM and fdc patches patches for 2021-03-16

2021-03-16 Thread Markus Armbruster
Duplicate sent by accident, my apologies.

Re: [PATCH 8/8] tools/virtiofsd: Replacing malloc-like calls with GLib's variants

2021-03-16 Thread Stefan Hajnoczi
On Mon, Mar 15, 2021 at 12:46:29PM +0200, Mahmoud Mandour wrote: > On Mon, Mar 15, 2021 at 12:01 PM Stefan Hajnoczi > wrote: > > > On Sun, Mar 14, 2021 at 05:23:24AM +0200, Mahmoud Mandour wrote: > > > @@ -130,7 +130,7 @@ static struct fuse_req *fuse_ll_alloc_req(struct > > fuse_session *se) > >

[PULL 08/10] vfio: Avoid disabling and enabling vectors repeatedly in VFIO migration

2021-03-16 Thread Alex Williamson
From: Shenming Lu In VFIO migration resume phase and some guest startups, there are already unmasked vectors in the vector table when calling vfio_msix_enable(). So in order to avoid inefficiently disabling and enabling vectors repeatedly, let's allocate all needed vectors first and then enable t

[PULL 07/10] vfio: Set the priority of the VFIO VM state change handler explicitly

2021-03-16 Thread Alex Williamson
From: Shenming Lu In the VFIO VM state change handler when stopping the VM, the _RUNNING bit in device_state is cleared which makes the VFIO device stop, including no longer generating interrupts. Then we can save the pending states of all interrupts in the GIC VM state change handler (on ARM).

Re: Windows 10 won't run on default x86_64 machine anymore

2021-03-16 Thread Igor Mammedov
On Tue, 16 Mar 2021 17:28:52 +0100 Reinoud Zandijk wrote: > On Tue, Mar 16, 2021 at 01:53:01PM +0100, Igor Mammedov wrote: > > > The image file was downloaded pre-installed from Microsoft for Edge > > > browser > > > evaluation. I used it first on Qemu 5.1 IIRC and it kept working in Qemu > > >

Re: [PULL v2 00/42] Block layer patches and object-add QAPIfication

2021-03-16 Thread Stefan Hajnoczi
On Tue, Mar 16, 2021 at 03:55:59PM +0100, Kevin Wolf wrote: > Am 16.03.2021 um 15:35 hat Kevin Wolf geschrieben: > > Am 16.03.2021 um 14:17 hat Peter Maydell geschrieben: > > > On Mon, 15 Mar 2021 at 12:35, Kevin Wolf wrote: > > > > > > > > The following changes since commit > > > > 6157b0e19721a

[PULL 03/11] qapi: Implement deprecated-output=hide for QMP command results

2021-03-16 Thread Markus Armbruster
This policy suppresses deprecated bits in output, and thus permits "testing the future". Implement it for QMP command results. Example: when QEMU is run with -compat deprecated-output=hide, then {"execute": "query-cpus-fast"} yields {"return": [{"thread-id": 9805, "props": {"core-id":

[PULL 04/10] vfio: Do not register any IOMMU_NOTIFIER_DEVIOTLB_UNMAP notifier

2021-03-16 Thread Alex Williamson
From: Eric Auger In an attempt to fix smmu/virtio-iommu - vhost regression, commit 958ec334bca3 ("vhost: Unbreak SMMU and virtio-iommu on dev-iotlb support") broke virtio-iommu integration. This is due to the fact VFIO registers IOMMU_NOTIFIER_ALL notifiers, which includes IOMMU_NOTIFIER_DEVIOTLB

[PULL 09/10] vfio: Support host translation granule size

2021-03-16 Thread Alex Williamson
From: Kunkun Jiang The cpu_physical_memory_set_dirty_lebitmap() can quickly deal with the dirty pages of memory by bitmap-traveling, regardless of whether the bitmap is aligned correctly or not. cpu_physical_memory_set_dirty_lebitmap() supports pages in bitmap of host page size. So it'd better t

[PULL 06/10] vfio: Move the saving of the config space to the right place in VFIO migration

2021-03-16 Thread Alex Williamson
From: Shenming Lu On ARM64 the VFIO SET_IRQS ioctl is dependent on the VM interrupt setup, if the restoring of the VFIO PCI device config space is before the VGIC, an error might occur in the kernel. So we move the saving of the config space to the non-iterable process, thus it will be called af

[PULL 02/10] hw/vfio/pci-quirks: Replace the word 'blacklist'

2021-03-16 Thread Alex Williamson
From: Philippe Mathieu-Daudé Follow the inclusive terminology from the "Conscious Language in your Open Source Projects" guidelines [*] and replace the word "blacklist" appropriately. [*] https://github.com/conscious-lang/conscious-lang-docs/blob/main/faq.md Reviewed-by: Alex Williamson Acked-

[PULL 11/11] qapi: New -compat deprecated-input=crash

2021-03-16 Thread Markus Armbruster
Policy "crash" calls abort() when deprecated input is received. Bugs in integration tests may mask the error from policy "reject". Provide a larger hammer: crash outright. Masking that seems unlikely. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Message-Id: <20210312153210.2810514-

[PULL 05/10] spapr_iommu: Fix vhost integration regression

2021-03-16 Thread Alex Williamson
From: Eric Auger Previous work on dev-iotlb message broke spapr_iommu/vhost integration as it did for SMMU and virtio-iommu. The spapr_iommu currently only sends IOMMU_NOTIFIER_UNMAP notifications. Since commit 958ec334bca3 ("vhost: Unbreak SMMU and virtio-iommu on dev-iotlb support"), VHOST firs

[PULL 05/11] qapi: Implement deprecated-output=hide for QMP event data

2021-03-16 Thread Markus Armbruster
This policy suppresses deprecated bits in output, and thus permits "testing the future". Implement it for QMP event data: suppress deprecated members. No QMP event data is deprecated right now. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Message-Id: <20210312153210.2810514-5-arm..

[PULL 10/11] qapi: Implement deprecated-input=reject for QMP command arguments

2021-03-16 Thread Markus Armbruster
This policy rejects deprecated input, and thus permits "testing the future". Implement it for QMP command arguments: reject commands with deprecated ones. Example: when QEMU is run with -compat deprecated-input=reject, then {"execute": "eject", "arguments": {"device": "cd"}} fails like this

[PULL 09/11] qapi: Implement deprecated-input=reject for QMP commands

2021-03-16 Thread Markus Armbruster
This policy rejects deprecated input, and thus permits "testing the future". Implement it for QMP commands: make deprecated ones fail. Example: when QEMU is run with -compat deprecated-input=reject, then {"execute": "query-cpus"} fails like this {"error": {"class": "CommandNotFound", "d

[PULL 03/10] MAINTAINERS: Cover docs/igd-assign.txt in VFIO section

2021-03-16 Thread Alex Williamson
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20210202155611.998424-1-phi...@redhat.com> Signed-off-by: Alex Williamson --- MAINTAINERS |1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index b6ab3d25a751..5b74df54dccc 100644 ---

[PULL 08/11] test-util-sockets: Add stub for monitor_set_cur()

2021-03-16 Thread Markus Armbruster
Without this stub, the next commit fails to link. I suspect the real cause is 947e47448d "monitor: Use getter/setter functions for cur_mon". Cc: Kevin Wolf Signed-off-by: Markus Armbruster Message-Id: <20210312153210.2810514-8-arm...@redhat.com> Reviewed-by: Eric Blake --- tests/unit/test-uti

[PULL 06/11] monitor: Drop query-qmp-schema 'gen': false hack

2021-03-16 Thread Markus Armbruster
QMP commands return their response as a generated QAPI type, which the monitor core converts to JSON via QObject. query-qmp-schema's response is the generated introspection data. This is a QLitObject since commit 7d0f982bfb "qapi: generate a literal qobject for introspection", v2.12). Before, it

[PULL 05/11] qapi: Implement deprecated-output=hide for QMP event data

2021-03-16 Thread Markus Armbruster
This policy suppresses deprecated bits in output, and thus permits "testing the future". Implement it for QMP event data: suppress deprecated members. No QMP event data is deprecated right now. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Message-Id: <20210312153210.2810514-5-arm..

[PULL 01/10] vfio: Fix vfio_listener_log_sync function name typo

2021-03-16 Thread Alex Williamson
From: Zenghui Yu There is an obvious typo in the function name of the .log_sync() callback. Spell it correctly. Signed-off-by: Zenghui Yu Message-Id: <20201204014240.772-1-yuzeng...@huawei.com> Signed-off-by: Alex Williamson --- hw/vfio/common.c |4 ++-- 1 file changed, 2 insertions(+), 2

[PULL 04/11] qapi: Implement deprecated-output=hide for QMP events

2021-03-16 Thread Markus Armbruster
This policy suppresses deprecated bits in output, and thus permits "testing the future". Implement it for QMP events: suppress deprecated ones. No QMP event is deprecated right now. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Message-Id: <20210312153210.2810514-4-arm...@redhat.com

[PULL 00/11] QOM and fdc patches patches for 2021-03-16

2021-03-16 Thread Markus Armbruster
The following changes since commit 6e31b3a5c34c6e5be7ef60773e607f189eaa15f3: Merge remote-tracking branch 'remotes/jasowang/tags/net-pull-request' into staging (2021-03-16 10:53:47 +) are available in the Git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-qom-fdc-2021-03-16

[PULL 03/11] qapi: Implement deprecated-output=hide for QMP command results

2021-03-16 Thread Markus Armbruster
This policy suppresses deprecated bits in output, and thus permits "testing the future". Implement it for QMP command results. Example: when QEMU is run with -compat deprecated-output=hide, then {"execute": "query-cpus-fast"} yields {"return": [{"thread-id": 9805, "props": {"core-id":

[PULL 00/10] VFIO updates for QEMU 6.0

2021-03-16 Thread Alex Williamson
This is a resend of the same sent on 2021-03-11 where 00/10 and 02/10 were eaten by the mail server. Rebased to current staging and re-tagged. The following changes since commit 5b7f5586d182b0cafb1f8d558992a14763e2953e: Merge remote-tracking branch 'remotes/kraxel/tags/usb-20210315-pull-reques

Re: [PATCH] tests/acceptance: Print expected message on wait_for_console_pattern

2021-03-16 Thread Willian Rampazzo
On Tue, Mar 9, 2021 at 12:36 PM Wainer dos Santos Moschetta wrote: > > For the sake of improve debuggability of tests which use the > wait_for_console_pattern(), this changed the _console_interaction() so that > the expected message is printed if the test fail. > > Signed-off-by: Wainer dos Santos

Re: [PATCH v4 0/3] target/arm: Add support for FEAT_TLBIOS and FEAT_TLBIRANGE

2021-03-16 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210316154910.25804-1-rebe...@nuviainc.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210316154910.25804-1-rebe...@nuviainc.com Subject: [PATCH v4 0/3] target/arm: Add supp

[PULL 11/11] qapi: New -compat deprecated-input=crash

2021-03-16 Thread Markus Armbruster
Policy "crash" calls abort() when deprecated input is received. Bugs in integration tests may mask the error from policy "reject". Provide a larger hammer: crash outright. Masking that seems unlikely. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Message-Id: <20210312153210.2810514-

[PULL 02/11] qemu-options: New -compat to set policy for deprecated interfaces

2021-03-16 Thread Markus Armbruster
New option -compat lets you configure what to do when deprecated interfaces get used. This is intended for testing users of the management interfaces. It is experimental. -compat deprecated-input= configures what to do when deprecated input is received. Input policy can be "accept" (accept sile

[PULL 06/11] monitor: Drop query-qmp-schema 'gen': false hack

2021-03-16 Thread Markus Armbruster
QMP commands return their response as a generated QAPI type, which the monitor core converts to JSON via QObject. query-qmp-schema's response is the generated introspection data. This is a QLitObject since commit 7d0f982bfb "qapi: generate a literal qobject for introspection", v2.12). Before, it

[PULL 02/11] qemu-options: New -compat to set policy for deprecated interfaces

2021-03-16 Thread Markus Armbruster
New option -compat lets you configure what to do when deprecated interfaces get used. This is intended for testing users of the management interfaces. It is experimental. -compat deprecated-input= configures what to do when deprecated input is received. Input policy can be "accept" (accept sile

[PULL 04/11] qapi: Implement deprecated-output=hide for QMP events

2021-03-16 Thread Markus Armbruster
This policy suppresses deprecated bits in output, and thus permits "testing the future". Implement it for QMP events: suppress deprecated ones. No QMP event is deprecated right now. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Message-Id: <20210312153210.2810514-4-arm...@redhat.com

[PULL 09/11] qapi: Implement deprecated-input=reject for QMP commands

2021-03-16 Thread Markus Armbruster
This policy rejects deprecated input, and thus permits "testing the future". Implement it for QMP commands: make deprecated ones fail. Example: when QEMU is run with -compat deprecated-input=reject, then {"execute": "query-cpus"} fails like this {"error": {"class": "CommandNotFound", "d

[PULL 08/11] test-util-sockets: Add stub for monitor_set_cur()

2021-03-16 Thread Markus Armbruster
Without this stub, the next commit fails to link. I suspect the real cause is 947e47448d "monitor: Use getter/setter functions for cur_mon". Cc: Kevin Wolf Signed-off-by: Markus Armbruster Message-Id: <20210312153210.2810514-8-arm...@redhat.com> Reviewed-by: Eric Blake --- tests/unit/test-uti

[PULL 07/11] qapi: Implement deprecated-output=hide for QMP introspection

2021-03-16 Thread Markus Armbruster
This policy suppresses deprecated bits in output, and thus permits "testing the future". Implement it for QMP command query-qmp-schema: suppress information on deprecated commands, events and object type members, i.e. anything that has the special feature flag "deprecated". Signed-off-by: Markus

[PULL 00/11] QOM and fdc patches patches for 2021-03-16

2021-03-16 Thread Markus Armbruster
The following changes since commit 6e31b3a5c34c6e5be7ef60773e607f189eaa15f3: Merge remote-tracking branch 'remotes/jasowang/tags/net-pull-request' into staging (2021-03-16 10:53:47 +) are available in the Git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-qom-fdc-2021-03-16

[PULL 07/11] qapi: Implement deprecated-output=hide for QMP introspection

2021-03-16 Thread Markus Armbruster
This policy suppresses deprecated bits in output, and thus permits "testing the future". Implement it for QMP command query-qmp-schema: suppress information on deprecated commands, events and object type members, i.e. anything that has the special feature flag "deprecated". Signed-off-by: Markus

[PULL 12/13] block: remove 'dirty-bitmaps' field from 'BlockInfo' struct

2021-03-16 Thread Daniel P . Berrangé
The same data is available in the 'BlockDeviceInfo' struct. Reviewed-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Daniel P. Berrangé --- block/qapi.c| 5 - docs/system/deprecated.rst | 13 - docs/system/removed

[PULL 01/11] qemuutil: remove qemu_set_fd_handler duplicate symbol

2021-03-16 Thread Markus Armbruster
From: Paolo Bonzini libqemuutil has two definitions of qemu_set_fd_handler. This is not needed since the only users of the function are qemu-io.c and the emulators, both of which already include util/main-loop.c. Signed-off-by: Paolo Bonzini Message-Id: Tested-by: Markus Armbruster Signed-of

[PULL 01/11] qemuutil: remove qemu_set_fd_handler duplicate symbol

2021-03-16 Thread Markus Armbruster
From: Paolo Bonzini libqemuutil has two definitions of qemu_set_fd_handler. This is not needed since the only users of the function are qemu-io.c and the emulators, both of which already include util/main-loop.c. Signed-off-by: Paolo Bonzini Message-Id: Tested-by: Markus Armbruster Signed-of

[PULL 09/13] hw/scsi: remove 'scsi-disk' device

2021-03-16 Thread Daniel P . Berrangé
The 'scsi-hd' and 'scsi-cd' devices provide suitable alternatives. Reviewed-by: Thomas Huth Signed-off-by: Daniel P. Berrangé --- docs/system/deprecated.rst | 9 - docs/system/removed-features.rst | 6 hw/i386/pc.c | 1 - hw/scsi/scsi-disk.c |

[PULL 08/13] hw/ide: remove 'ide-drive' device

2021-03-16 Thread Daniel P . Berrangé
The 'ide-hd' and 'ide-cd' devices provide suitable alternatives. Reviewed-by: Thomas Huth Signed-off-by: Daniel P. Berrangé --- docs/qdev-device-use.txt | 2 +- docs/system/deprecated.rst | 6 - docs/system/removed-features.rst | 8 +++ hw/i386/pc.c

[PULL 13/13] block: remove support for using "file" driver with block/char devices

2021-03-16 Thread Daniel P . Berrangé
The 'host_device' and 'host_cdrom' drivers must be used instead. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrangé --- block/file-posix.c | 17 ++--- docs/system/deprecated.rst | 7 --- docs/system/removed-features.rst | 7 +++ tests/qemu-iotest

Re: [PATCH] target/mips: Deprecate Trap-and-Emul KVM support

2021-03-16 Thread Philippe Mathieu-Daudé
Jiaxun, ping for moving the section? On 3/12/21 10:43 AM, Philippe Mathieu-Daudé wrote: > +Paolo/Thomas/KVM > > On 3/12/21 2:03 AM, Jiaxun Yang wrote: >> Upstream kernel had removed both host[1] and guest[2] support. >> >> [1]: >> https://git.kernel.org/pub/scm/linux/kernel/git/mips/linux.git/co

[PULL 07/13] chardev: reject use of 'wait' flag for socket client chardevs

2021-03-16 Thread Daniel P . Berrangé
This only makes sense conceptually when used with listener chardevs. Reviewed-by: Marc-André Lureau Signed-off-by: Daniel P. Berrangé --- chardev/char-socket.c| 12 docs/system/deprecated.rst | 6 -- docs/system/removed-features.rst | 6 ++ 3 files chang

[PULL 05/13] machine: remove 'query-cpus' QMP command

2021-03-16 Thread Daniel P . Berrangé
The newer 'query-cpus-fast' command avoids side effects on the guest execution. Note that some of the field names are different in the 'query-cpus-fast' command. Reviewed-by: Wainer dos Santos Moschetta Tested-by: Wainer dos Santos Moschetta Signed-off-by: Daniel P. Berrangé --- docs/system/de

[PULL 11/13] block: remove dirty bitmaps 'status' field

2021-03-16 Thread Daniel P . Berrangé
The same information is available via the 'recording' and 'busy' fields. Reviewed-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Daniel P. Berrangé --- block/dirty-bitmap.c | 38 docs/system/deprecated.rst | 7 - docs/system/removed-features.rst | 7 + include/block

[PULL 06/13] machine: remove 'arch' field from 'query-cpus-fast' QMP command

2021-03-16 Thread Daniel P . Berrangé
Reviewed-by: Thomas Huth Signed-off-by: Daniel P. Berrangé --- docs/system/deprecated.rst | 6 - docs/system/removed-features.rst | 6 + hw/core/machine-qmp-cmds.c | 41 qapi/machine.json| 22 - 4 files change

[PULL 10/11] qapi: Implement deprecated-input=reject for QMP command arguments

2021-03-16 Thread Markus Armbruster
This policy rejects deprecated input, and thus permits "testing the future". Implement it for QMP command arguments: reject commands with deprecated ones. Example: when QEMU is run with -compat deprecated-input=reject, then {"execute": "eject", "arguments": {"device": "cd"}} fails like this

[PULL 04/13] migrate: remove QMP/HMP commands for speed, downtime and cache size

2021-03-16 Thread Daniel P . Berrangé
The generic 'migrate_set_parameters' command handle all types of param. Only the QMP commands were documented in the deprecations page, but the rationale for deprecating applies equally to HMP, and the replacements exist. Furthermore the HMP commands are just shims to the QMP commands, so removing

[PULL 10/13] block: remove 'encryption_key_missing' flag from QAPI

2021-03-16 Thread Daniel P . Berrangé
This has been hardcoded to "false" since 2.10.0, since secrets required to unlock block devices are now always provided up front instead of using interactive prompts. Reviewed-by: Eric Blake Reviewed-by: Thomas Huth Signed-off-by: Daniel P. Berrangé --- block/qapi.c | 1 -

Re: Windows 10 won't run on default x86_64 machine anymore

2021-03-16 Thread Igor Mammedov
On Tue, 16 Mar 2021 14:10:44 +0100 Igor Mammedov wrote: > On Tue, 16 Mar 2021 13:49:57 +0100 > Paolo Bonzini wrote: > > > On 16/03/21 13:13, Igor Mammedov wrote: > > >>> Surprisingly without accelerator ie with tcg the default machine does > > >>> seem to > > >>> get to the login prompt. Is

[PULL 01/13] ui, monitor: remove deprecated VNC ACL option and HMP commands

2021-03-16 Thread Daniel P . Berrangé
The VNC ACL concept has been replaced by the pluggable "authz" framework which does not use monitor commands. Reviewed-by: Thomas Huth Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrangé --- docs/system/deprecated.rst | 16 --- docs/system/removed-features.rst | 13 ++

[PULL 00/13] misc patches removing deprecated features

2021-03-16 Thread Daniel P . Berrangé
The following changes since commit 6e31b3a5c34c6e5be7ef60773e607f189eaa15f3: Merge remote-tracking branch 'remotes/jasowang/tags/net-pull-request' into staging (2021-03-16 10:53:47 +) are available in the Git repository at: https://gitlab.com/berrange/qemu tags/dep-many-pull-request fo

[PULL 03/13] monitor: remove 'query-events' QMP command

2021-03-16 Thread Daniel P . Berrangé
The code comment suggests removing QAPIEvent_(str|lookup) symbols too, however, these are both auto-generated as standard for any enum in QAPI. As such it they'll exist whether we use them or not. Reviewed-by: Eric Blake Reviewed-by: Thomas Huth Signed-off-by: Daniel P. Berrangé --- docs/syste

[PULL 02/13] monitor: raise error when 'pretty' option is used with HMP

2021-03-16 Thread Daniel P . Berrangé
This is only semantically useful for QMP. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrangé --- docs/system/deprecated.rst | 7 --- docs/system/removed-features.rst | 6 ++ monitor/monitor.c| 4 ++-- qemu-options.hx | 5 +++-- 4

Re: Windows 10 won't run on default x86_64 machine anymore

2021-03-16 Thread Reinoud Zandijk
On Mon, Mar 15, 2021 at 06:55:03PM -0700, Isaku Yamahata wrote: > I think tcg case can be explained by x86_machine_is_smm_enabled() > > bool x86_machine_is_smm_enabled(const X86MachineState *x86ms) > ... > if (tcg_enabled() || qtest_enabled()) { > smm_available = true; >

Re: Windows 10 won't run on default x86_64 machine anymore

2021-03-16 Thread Reinoud Zandijk
On Tue, Mar 16, 2021 at 01:53:01PM +0100, Igor Mammedov wrote: > > The image file was downloaded pre-installed from Microsoft for Edge browser > > evaluation. I used it first on Qemu 5.1 IIRC and it kept working in Qemu > > 5.2. > > issue looks similar to: > 0a343a5add7 i386/acpi: restore device

Re: Windows 10 won't run on default x86_64 machine anymore

2021-03-16 Thread Reinoud Zandijk
On Mon, Mar 15, 2021 at 06:55:03PM -0700, Isaku Yamahata wrote: > > If I add in '-M pc-i440fx-5.2' it works again with the accelerator. If I add > > in '-M q35' it does work fine with or without the accelerator. > > Anyhow, can you please try "-global PIIX4_PM.smm-compat=on" > (or "-global ICH9-LP

Re: [PATCH 1/9] qemu-edid: use qemu_edid_size()

2021-03-16 Thread Philippe Mathieu-Daudé
On 3/16/21 3:38 PM, Gerd Hoffmann wrote: > So we only write out that part of the edid blob > which has been filled with data. > Also use a larger buffer for the blob. > > Signed-off-by: Gerd Hoffmann > --- > qemu-edid.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) Reviewed-by:

Re: Windows 10 won't run on default x86_64 machine anymore

2021-03-16 Thread Reinoud Zandijk
On Tue, Mar 16, 2021 at 01:49:57PM +0100, Paolo Bonzini wrote: > On 16/03/21 13:13, Igor Mammedov wrote: > > > Although I don't know about nvmm case, this function also needs to be > > > updated > > > if smi isn't supported. > > can you submit a patch for this please? > nvmm is not part of upstre

Re: [PATCH 0/7] block/nbd: decouple reconnect from drain

2021-03-16 Thread Roman Kagan
On Tue, Mar 16, 2021 at 09:41:36AM -0500, Eric Blake wrote: > On 3/15/21 1:06 AM, Roman Kagan wrote: > > The reconnection logic doesn't need to stop while in a drained section. > > Moreover it has to be active during the drained section, as the requests > > that were caught in-flight with the conne

Re: [PATCH v2 1/1] docs/devel: Add VFIO device migration documentation

2021-03-16 Thread Tarun Gupta (SW-GPU)
On 3/15/2021 10:52 PM, Cornelia Huck wrote: On Thu, 11 Mar 2021 00:50:09 +0530 Tarun Gupta wrote: Document interfaces used for VFIO device migration. Added flow of state changes during live migration with VFIO device. Tested by building docs with the new vfio-migration.rst file. v2: - Inc

Re: [PATCH v7 0/8] Pegasos2 emulation

2021-03-16 Thread Mark Cave-Ayland
On 16/03/2021 13:06, BALATON Zoltan wrote: The PATCH 1 doesn't seem to be needed to have a working Pegasos 2 machine, does it? It is needed (as well as all other patches in the series). Patch 1 is needed for getting serial output which is the only way to communicate with the Pegasos2 firmwar

Re: [PATCH 6/7] block/nbd: decouple reconnect from drain

2021-03-16 Thread Roman Kagan
On Mon, Mar 15, 2021 at 11:10:14PM +0300, Vladimir Sementsov-Ogievskiy wrote: > 15.03.2021 09:06, Roman Kagan wrote: > > The reconnection logic doesn't need to stop while in a drained section. > > Moreover it has to be active during the drained section, as the requests > > that were caught in-fligh

Re: [PATCH 9/9] edid: add support for DisplayID extension (5k resolution)

2021-03-16 Thread Philippe Mathieu-Daudé
On 3/16/21 3:38 PM, Gerd Hoffmann wrote: > From: Konstantin Nazarov > > The Detailed Timing Descriptor has only 12 bits to store the > resolution. This limits the guest to 4095 pixels. > > This patch adds support for the DisplayID extension, that has 2 full > bytes for that purpose, thus allowin

Re: [PATCH 1/2] hw/intc: GICv3 ITS implementation

2021-03-16 Thread Peter Maydell
On Mon, 15 Mar 2021 at 16:49, Shashi Mallela wrote: > > Implementation of Interrupt Translation Service which allows eventid > from devices to be translated to physical LPI IntIds.Extended the > redistributor functionality to process LPI Interrupts as well. > > Signed-off-by: Shashi Mallela > ---

Re: [PATCH 7/7] block/nbd: stop manipulating in_flight counter

2021-03-16 Thread Roman Kagan
On Mon, Mar 15, 2021 at 11:15:44PM +0300, Vladimir Sementsov-Ogievskiy wrote: > 15.03.2021 09:06, Roman Kagan wrote: > > As the reconnect logic no longer interferes with drained sections, it > > appears unnecessary to explicitly manipulate the in_flight counter. > > > > Fixes: 5ad81b4946 ("nbd: Re

[PATCH 2/5] block/vdi: Don't assume that blocks are larger than VdiHeader

2021-03-16 Thread Paolo Bonzini
From: David Edmondson Given that the block size is read from the header of the VDI file, a wide variety of sizes might be seen. Rather than re-using a block sized memory region when writing the VDI header, allocate an appropriately sized buffer. Signed-off-by: David Edmondson Message-Id: <20210

[PATCH v3 0/5] coroutine rwlock downgrade fix, minor VDI changes

2021-03-16 Thread Paolo Bonzini
This is a resubmit of David Edmondson's series at https://patchew.org/QEMU/20210309144015.557477-1-david.edmond...@oracle.com/. After closer analysis on IRC, the CoRwLock's attempt to ensure fairness turned out to be flawed. Therefore, this series reimplements CoRwLock without using a CoQueue. Tr

Re: [RFC v2 11/13] vhost: Shadow virtqueue buffers forwarding

2021-03-16 Thread Eugenio Perez Martin
On Tue, Mar 16, 2021 at 9:15 AM Jason Wang wrote: > > > 在 2021/3/16 上午3:48, Eugenio Pérez 写道: > > Initial version of shadow virtqueue that actually forward buffers. > > > > It reuses the VirtQueue code for the device part. The driver part is > > based on Linux's virtio_ring driver, but with stripp

Re: [PATCH 17/38] target/riscv: Signed MSW 32x16 Multiply and Add Instructions

2021-03-16 Thread Alistair Francis
On Fri, Feb 12, 2021 at 10:38 AM LIU Zhiwei wrote: > > Signed-off-by: LIU Zhiwei Acked-by: Alistair Francis Alistair > --- > target/riscv/helper.h | 17 ++ > target/riscv/insn32.decode | 17 ++ > target/riscv/insn_trans/trans_rvp.c.inc | 18 ++ > target/risc

[PATCH 1/5] block/vdi: When writing new bmap entry fails, don't leak the buffer

2021-03-16 Thread Paolo Bonzini
From: David Edmondson If a new bitmap entry is allocated, requiring the entire block to be written, avoiding leaking the buffer allocated for the block should the write fail. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: David Edmondson Message-Id: <20210309144015.557477-2-david.edmond...

[PATCH 5/5] test-coroutine: Add rwlock downgrade test

2021-03-16 Thread Paolo Bonzini
From: David Edmondson Test that downgrading an rwlock does not result in a failure to schedule coroutines queued on the rwlock. The diagram associated with test_co_rwlock_downgrade() describes the intended behaviour, but what was observed previously corresponds to: | c1 | c2 | c3

[PATCH 3/5] coroutine/mutex: Store the coroutine in the CoWaitRecord only once

2021-03-16 Thread Paolo Bonzini
From: David Edmondson When taking the slow path for mutex acquisition, set the coroutine value in the CoWaitRecord in push_waiter(), rather than both there and in the caller. Reviewed-by: Paolo Bonzini Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: David Edmondson Message-Id: <20210309144

[PATCH 4/5] coroutine-lock: reimplement CoRwLock to fix downgrade bug

2021-03-16 Thread Paolo Bonzini
A feature of the current rwlock is that if multiple coroutines hold a reader lock, all must be runnable. The unlock implementation relies on this, choosing to wake a single coroutine when the final read lock holder exits the critical section, assuming that it will wake a coroutine attempting to acq

Re: [PATCH v2] util: fix use-after-free in module_load_one

2021-03-16 Thread Philippe Mathieu-Daudé
On 3/16/21 2:44 PM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > g_hash_table_add always retains ownership of the pointer passed in as > the key. Its return status merely indicates whether the added entry was > new, or replaced an existing entry. Thus key must never be freed a

Re: [PULL v2 00/42] Block layer patches and object-add QAPIfication

2021-03-16 Thread Stefan Hajnoczi
On Tue, Mar 16, 2021 at 2:36 PM Kevin Wolf wrote: > > Am 16.03.2021 um 14:17 hat Peter Maydell geschrieben: > > On Mon, 15 Mar 2021 at 12:35, Kevin Wolf wrote: > > > > > > The following changes since commit > > > 6157b0e19721aadb4c7fdcfe57b2924af6144b14: > > > > > > Merge remote-tracking branc

Re: [RFC PATCH 5/8] qtest/libqos: Restrict CPU I/O instructions

2021-03-16 Thread Philippe Mathieu-Daudé
Hi Richard and Laszlo, On 3/16/21 4:43 PM, Richard Henderson wrote: > On 3/16/21 9:37 AM, Laszlo Ersek wrote: >> (+Peter, comment below) >> >> On 03/15/21 00:29, Philippe Mathieu-Daudé wrote: >>> Restrict CPU I/O instructions to architectures providing >>> I/O bus. >>> >>> Signed-off-by: Philippe

Re: [PATCH 0/7] block/nbd: decouple reconnect from drain

2021-03-16 Thread Roman Kagan
On Mon, Mar 15, 2021 at 10:45:39PM +0300, Vladimir Sementsov-Ogievskiy wrote: > 15.03.2021 09:06, Roman Kagan wrote: > > The reconnection logic doesn't need to stop while in a drained section. > > Moreover it has to be active during the drained section, as the requests > > that were caught in-fligh

Re: [PATCH v3 1/3] target/arm: Add support for FEAT_TLBIRANGE

2021-03-16 Thread Rebecca Cran
On 3/16/21 9:09 AM, Richard Henderson wrote: On 3/16/21 12:20 AM, Rebecca Cran wrote: On 3/10/21 12:24 PM, Richard Henderson wrote: On 3/9/21 6:29 PM, Rebecca Cran wrote: +    uint64_t addr = (value & 0xFUL) << TARGET_PAGE_BITS; The manual does not explicitly say, but I'm certain t

[PATCH v4 0/3] target/arm: Add support for FEAT_TLBIOS and FEAT_TLBIRANGE

2021-03-16 Thread Rebecca Cran
ARMv8.4 adds the mandatory FEAT_TLBIOS and FEAT_TLBIRANGE. They provides TLBI maintenance instructions that extend to the Outer Shareable domain and that apply to a range of input addresses. Changes from v3 to v4: o Adapted code from the existing flush_page_bits_* functions to support flushing

[PATCH v4 2/3] target/arm: Add support for FEAT_TLBIOS

2021-03-16 Thread Rebecca Cran
ARMv8.4 adds the mandatory FEAT_TLBIOS. It provides TLBI maintenance instructions that extend to the Outer Shareable domain. Signed-off-by: Rebecca Cran --- target/arm/cpu.h| 5 ++ target/arm/helper.c | 75 2 files changed, 80 insertions(+) diff --git a/target/arm/cpu.

[PATCH v4 3/3] target/arm: set ID_AA64ISAR0.TLB to 2 for max AARCH64 CPU type

2021-03-16 Thread Rebecca Cran
Indicate support for FEAT_TLBIOS and FEAT_TLBIRANGE by setting ID_AA64ISAR0.TLB to 2 for the max AARCH64 CPU type. Signed-off-by: Rebecca Cran Reviewed-by: Richard Henderson --- target/arm/cpu64.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/arm/cpu64.c b/target/arm/cpu64.c index

[PATCH v4 1/3] target/arm: Add support for FEAT_TLBIRANGE

2021-03-16 Thread Rebecca Cran
ARMv8.4 adds the mandatory FEAT_TLBIRANGE. It provides TLBI maintenance instructions that apply to a range of input addresses. Signed-off-by: Rebecca Cran --- accel/tcg/cputlb.c | 135 + include/exec/exec-all.h | 45 +++ target/arm/cpu.h| 5 + target/arm/helper.c | 31

Re: [PATCH v2 1/1] docs/devel: Add VFIO device migration documentation

2021-03-16 Thread Dr. David Alan Gilbert
* Tian, Kevin (kevin.t...@intel.com) wrote: > > From: Qemu-devel > > On Behalf Of Dr. David Alan Gilbert > > > > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > > On Thu, Mar 11, 2021 at 12:50:09AM +0530, Tarun Gupta wrote: > > > > Document interfaces used for VFIO device migration. Added f

Re: [PATCH 0/9] edid: windows fixes

2021-03-16 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210316143812.2363588-1-kra...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210316143812.2363588-1-kra...@redhat.com Subject: [PATCH 0/9] edid: windows fixes ===

Re: [RFC PATCH 5/8] qtest/libqos: Restrict CPU I/O instructions

2021-03-16 Thread Richard Henderson
On 3/16/21 9:37 AM, Laszlo Ersek wrote: (+Peter, comment below) On 03/15/21 00:29, Philippe Mathieu-Daudé wrote: Restrict CPU I/O instructions to architectures providing I/O bus. Signed-off-by: Philippe Mathieu-Daudé --- tests/qtest/libqos/fw_cfg.h | 3 +++ tests/qtest/libqos/fw_cfg.c | 2

Re: [RFC PATCH 5/8] qtest/libqos: Restrict CPU I/O instructions

2021-03-16 Thread Laszlo Ersek
(+Peter, comment below) On 03/15/21 00:29, Philippe Mathieu-Daudé wrote: > Restrict CPU I/O instructions to architectures providing > I/O bus. > > Signed-off-by: Philippe Mathieu-Daudé > --- > tests/qtest/libqos/fw_cfg.h | 3 +++ > tests/qtest/libqos/fw_cfg.c | 2 ++ > 2 files changed, 5 insert

<    1   2   3   4   5   6   >