Re: [PATCH v3 6/6] iotests: iothreads need ioeventfd

2021-03-19 Thread Thomas Huth
On 19/03/2021 21.23, Laurent Vivier wrote: And ioeventfd are only available with virtio-scsi-pci or virtio-scsi-ccw, use the alias but add a rule to require virtio-scsi-pci or virtio-scsi-ccw for the tests that use iothreads. Signed-off-by: Laurent Vivier --- tests/qemu-iotests/127|

Re: [PATCH] configure: Improve alias attribute check

2021-03-19 Thread Thomas Huth
On 20/03/2021 05.27, Gavin Shan wrote: It's still possible that the wrong value is returned from the alias of variable even if the program can be compiled without issue. This improves the check by executing the binary to check the result. If alias attribute can't be working properly, the

[PATCH] configure: Improve alias attribute check

2021-03-19 Thread Gavin Shan
It's still possible that the wrong value is returned from the alias of variable even if the program can be compiled without issue. This improves the check by executing the binary to check the result. If alias attribute can't be working properly, the @target_page in exec-vary.c will always return

[PATCH 1/2] disas/arm-a64.cc: Fix build error

2021-03-19 Thread Gavin Shan
This fixes the following build error with gcc v11.0.0: # gcc --version gcc (GCC) 11.0.0 20210210 (Red Hat 11.0.0-0) [969/2604] Compiling C++ object libcommon.fa.p/disas_arm-a64.cc.o FAILED: libcommon.fa.p/disas_arm-a64.cc.o : In file included from

[PATCH for-6.0] target/arm: Set ARMMMUFaultInfo.level in user-only arm_cpu_tlb_fill

2021-03-19 Thread Richard Henderson
Pretend the fault always happens at page table level 3. Failure to set this leaves level = 0, which is impossible for ARMFault_Permission, and produces an invalid syndrome, which reaches g_assert_not_reached in cpu_loop. Fixes: 8db94ab4e5db ("linux-user/aarch64: Pass syndrome to EXC_*_ABORT")

Re: QEMU PCI subsystem: what code is responsible for making accesses to non-mapped addresses read as -1?

2021-03-19 Thread Laszlo Ersek
On 03/19/21 15:14, Philippe Mathieu-Daudé wrote: > On 3/19/21 1:35 PM, Peter Maydell wrote: >> I'm looking at a bug reported against the QEMU arm virt board's pci-gpex >> PCI controller: https://bugs.launchpad.net/qemu/+bug/1918917 >> where an attempt to write to an address within the PCI IO

[Bug 1918917] Re: synchronous abort on accessing unused I/O ports on aarch64

2021-03-19 Thread Laszlo Ersek (Red Hat)
** Summary changed: - synchronous about on accessing unused I/O ports on aarch64 + synchronous abort on accessing unused I/O ports on aarch64 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1918917

[PATCH 1/2] migration/block-dirty-bitmap: make incoming disabled bitmaps busy

2021-03-19 Thread Vladimir Sementsov-Ogievskiy
Incoming enabled bitmaps are busy, because we do bdrv_dirty_bitmap_create_successor() for them. But disabled bitmaps being migrated are not marked busy, and user can remove them during the incoming migration. Then we may crash in cancel_incoming_locked() when try to remove the bitmap that was

[PATCH 2/2] migrate-bitmaps-postcopy-test: check that we can't remove in-flight bitmaps

2021-03-19 Thread Vladimir Sementsov-Ogievskiy
Check that we can't remove bitmaps being migrated on destination vm. The new check proves that previous commit helps. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test | 9 + 1 file changed, 9 insertions(+) diff --git

[PATCH 0/2] Fix crash if try to remove bitmap on target during migration

2021-03-19 Thread Vladimir Sementsov-Ogievskiy
Hi all! Bitmaps on source are marked busy during migration. Enabled bitmaps on target have successor, so they are busy. But disabled migrated bitmaps are not protected on target. User can simple remove them and it lead to use-after-free. These bitmaps should be marked busy. Vladimir

Re: [PULL 26/40] linux-user/aarch64: Pass syndrome to EXC_*_ABORT

2021-03-19 Thread Richard Henderson
On 3/19/21 1:19 PM, Laurent Vivier wrote: Richard, do you have any idea how to fix this problem? Oops, started building ltp, then forgot about it. Looking now. r~ Thanks, Laurent Le 12/03/2021 à 12:09, Laurent Vivier a écrit : Hi, On 16/02/2021 17:16, Peter Maydell wrote: From:

[PATCH v3 3/6] blockdev: with -drive if=virtio, use generic virtio-blk

2021-03-19 Thread Laurent Vivier
Rather than checking if the machine is an s390x to use virtio-blk-ccw instead of virtio-blk-pci, use the alias virtio-blk that is set to the expected target. This also enables the use of virtio-blk-device for targets without PCI or CCW. Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe

[PATCH v3 5/6] iotests: test m68k with the virt machine

2021-03-19 Thread Laurent Vivier
This allows to cover the virtio tests with a 32bit big-endian virtio-mmio machine. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Cornelia Huck Signed-off-by: Laurent Vivier --- tests/qemu-iotests/testenv.py | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/qemu-iotests/testenv.py

[PATCH v3 6/6] iotests: iothreads need ioeventfd

2021-03-19 Thread Laurent Vivier
And ioeventfd are only available with virtio-scsi-pci or virtio-scsi-ccw, use the alias but add a rule to require virtio-scsi-pci or virtio-scsi-ccw for the tests that use iothreads. Signed-off-by: Laurent Vivier --- tests/qemu-iotests/127| 3 ++- tests/qemu-iotests/256| 6

[PATCH v3 2/6] m68k: add the virtio devices aliases

2021-03-19 Thread Laurent Vivier
Similarly to 5f629d943cb0 ("s390x: fix s390 virtio aliases"), define the virtio aliases. This allows to start machines with virtio devices without knowledge of the implementation type. For instance, we can use "-device virtio-scsi" on m68k, s390x or PC, and the device will be respectively

[PATCH v3 4/6] iotests: Revert "iotests: use -ccw on s390x for 040, 139, and 182"

2021-03-19 Thread Laurent Vivier
Commit f1d5516ab583 introduces a test in some iotests to check if the machine is a s390-ccw-virtio and to select virtio-*-ccw rather than virtio-*-pci. We don't need that because QEMU already provides aliases to use the correct virtio interface according to the machine type. This patch removes

[PATCH v3 0/6] iotests: fix failures with non-PCI machines

2021-03-19 Thread Laurent Vivier
Tests are executed using virtio-*-pci even on a non PCI machine. The problem can be easily fixed using the virtio aliases (virtio-*), to run virtio-*-ccw on s390x and virtio-*-device on m68k. A first attempt was tried with virtio-*-ccw by detecting the machine type, this series removes it to use

[PATCH v3 1/6] qdev: define list of archs with virtio-pci or virtio-ccw

2021-03-19 Thread Laurent Vivier
This is used to define virtio-*-pci and virtio-*-ccw aliases rather than substracting the CCW architecture from all the others. Reviewed-by: Cornelia Huck Signed-off-by: Laurent Vivier --- include/sysemu/arch_init.h | 8 ++ softmmu/qdev-monitor.c | 53

Re: [PATCH] FreeBSD: Upgrade to 12.2 release

2021-03-19 Thread Warner Losh
On Fri, Mar 19, 2021 at 10:52 AM Thomas Huth wrote: > From: Warner Losh > > FreeBSD 12.1 has reached end of life. Use 12.2 instead so that FreeBSD's > project's packages will work. Update which timezone to pick. Work around > a QEMU > bug that incorrectly raises an exception on a CRC32

Re: [PATCH v4 0/5] block: add block-dirty-bitmap-populate job

2021-03-19 Thread Vladimir Sementsov-Ogievskiy
Hi! Any plans on v5? Now I have a request for this feature.. If no plans, I can take care of it and make a v5 02.09.2020 21:18, Eric Blake wrote: This is NOT the final version of this patch series, but I'm posting it to revive conversation on the topic while fixing it to compile on top of

[PATCH] net/npcm7xx_emc.c: Fix handling of receiving packets when RSDR not set

2021-03-19 Thread Doug Evans
Turning REG_MCMDR_RXON is enough to start receiving packets. Signed-off-by: Doug Evans --- hw/net/npcm7xx_emc.c | 4 +++- tests/qtest/npcm7xx_emc-test.c | 30 +- 2 files changed, 24 insertions(+), 10 deletions(-) diff --git a/hw/net/npcm7xx_emc.c

[ RFC 6/6] hw/riscv: virt: DEBUG PATCH to test PMU

2021-03-19 Thread Atish Patra
** DO NOT MERGE IT ** This is just a test patch to test various kinds of PMU events. The counters don't actually increment as virt machine doesn't support any of the PMU events. However, it helps to test the OpenSBI/Kernel implementation. Please ignore this patch while merging it.

[ RFC 3/6] target/riscv: Support mcycle/minstret write operation

2021-03-19 Thread Atish Patra
mcycle/minstret are actually WARL registers and can be written with any given value. With SBI PMU extension, it will be used to store a initial value provided from supervisor OS. The Qemu also need prohibit the counter increment if mcountinhibit is set. Signed-off-by: Atish Patra ---

[ RFC 5/6] hw/riscv: virt: Add PMU device tree node to support SBI PMU extension

2021-03-19 Thread Atish Patra
Qemu can't really support any PMU events other than cycle & instructions counters. Add a PMU device tree node only for these events based on device tree bindings defined in OpenSBI Signed-off-by: Atish Patra --- hw/riscv/virt.c | 22 -- 1 file changed, 20 insertions(+), 2

[ RFC 0/6] Improve PMU support

2021-03-19 Thread Atish Patra
The latest version of the SBI specification includes a Performance Monitoring Unit(PMU) extension[1] which allows the supervisor to start/stop/configure various PMU events. This series implements basic infrastructure to support PMU in virt machine. Qemu can support only cycle and instruction

[ RFC 2/6] target/riscv: Implement mcountinhibit CSR

2021-03-19 Thread Atish Patra
As per the privilege specification v1.11, mcountinhibit allows to start/stop a pmu counter selectively. Signed-off-by: Atish Patra --- target/riscv/cpu.h | 2 ++ target/riscv/cpu_bits.h | 4 target/riscv/csr.c | 23 +++ target/riscv/machine.c | 1 + 4

[ RFC 4/6] target/riscv: Add support for hpmcounters/hpmevents

2021-03-19 Thread Atish Patra
With SBI PMU extension, user can use any of the available hpmcounters to track any perf events based on the value written to mhpmevent csr. Add read/write functionality for these csrs. Signed-off-by: Atish Patra --- target/riscv/cpu.h | 7 + target/riscv/csr.c | 444

[ RFC 1/6] target/riscv: Remove privilege v1.9 specific CSR related code

2021-03-19 Thread Atish Patra
Qemu doesn't support RISC-V privilege specification v1.9. Remove the remaining v1.9 specific references from the implementation. Signed-off-by: Atish Patra --- target/riscv/cpu.c| 2 +- target/riscv/cpu.h| 4 +--- target/riscv/cpu_bits.h | 23 -

Re: [PULL 26/40] linux-user/aarch64: Pass syndrome to EXC_*_ABORT

2021-03-19 Thread Laurent Vivier
Richard, do you have any idea how to fix this problem? Thanks, Laurent Le 12/03/2021 à 12:09, Laurent Vivier a écrit : > Hi, > > On 16/02/2021 17:16, Peter Maydell wrote: >> From: Richard Henderson >> >> A proper syndrome is required to fill in the proper si_code. >> Use page_get_flags to

[PATCH 2/2] spapr.c: remove 'ibm,chip-id' from DT

2021-03-19 Thread Daniel Henrique Barboza
The attribute 'ibm,chip-id' does not exist in PAPR. This alone would be enough reason to remove it from the spapr DT, but before doing that, let's give a brief context on how and why it was introduced. 'ibm,chip-id' was added in the spapr DT by commit 10582ff83279. This commit references kernel

[PATCH 1/2] spapr: number of SMP sockets must be equal to NUMA nodes

2021-03-19 Thread Daniel Henrique Barboza
Kernel commit 4bce545903fa ("powerpc/topology: Update topology_core_cpumask") cause a regression in the pseries machine when defining certain SMP topologies [1]. The reasoning behind the change is explained in kernel commit 4ca234a9cbd7 ("powerpc/smp: Stop updating cpu_core_mask"). In short,

[PATCH 0/2] pseries: SMP sockets must match NUMA nodes

2021-03-19 Thread Daniel Henrique Barboza
Hi, The main change made in this series, in patch 01, is result of discussions with the kernel community. See the commit message for more details. Patch 02 is a second version of the patch sent in [1], but now the changes are only effective for the default pseries machine. It's being

Re: [Qemu-devel] [PULL 18/76] optionrom: add new PVH option rom

2021-03-19 Thread Stefano Garzarella
On Fri, Mar 19, 2021 at 7:20 PM Stefano Garzarella wrote: > > On Fri, Mar 19, 2021 at 06:52:39PM +0100, Paolo Bonzini wrote: > >It's likely that the compiler will online it. But indeed it's better to add > >-minline-all-stringops to the compiler command line. > > > > Cool, I didn't know that one!

Re: [Qemu-devel] [PULL 18/76] optionrom: add new PVH option rom

2021-03-19 Thread Stefano Garzarella
On Fri, Mar 19, 2021 at 06:52:39PM +0100, Paolo Bonzini wrote: It's likely that the compiler will online it. But indeed it's better to add -minline-all-stringops to the compiler command line. Cool, I didn't know that one! I tried but I did something wrong because the linker is not happy, next

Re: [PATCH v2 3/6] blockdev: with -drive if=virtio, use generic virtio-blk

2021-03-19 Thread Laurent Vivier
Le 19/03/2021 à 15:46, Cornelia Huck a écrit : > On Fri, 19 Mar 2021 14:25:34 +0100 > Laurent Vivier wrote: > >> Rather than checking if the machine is an s390x to use virtio-blk-ccw >> instead of virtio-blk-pci, use the alias virtio-blk that is set to >> the expected target. > > One side

Re: [PATCH v5 00/10] KVM: Dirty ring support (QEMU part)

2021-03-19 Thread Peter Xu
On Wed, Mar 10, 2021 at 03:32:51PM -0500, Peter Xu wrote: > This is v5 of the qemu dirty ring interface support. > > v5: > - rebase > - dropped patch "update-linux-headers: Include const.h" after rebase > - dropped patch "KVM: Fixup kvm_log_clear_one_slot() ioctl return check" since > similar

Re: [PULL v4 00/11] QAPI patches patches for 2021-03-16

2021-03-19 Thread Peter Maydell
On Fri, 19 Mar 2021 at 15:23, Markus Armbruster wrote: > > The following changes since commit 92566947b3ac5ca75f91a34acb188219c455fc71: > > Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging > (2021-03-19 11:27:40 +) > > are available in the Git repository at: > >

Re: [PATCH 0/2] More qemu_strtosz fixes

2021-03-19 Thread Alex Bennée
Eric Blake writes: > The MSYS2 build exposed a latent problem in qemu_strto*l, which in > turn now causes failures ever since test-utils added tests for > qemu_strtosz that depends on a particular behavior when parsing "0x". > > https://cirrus-ci.com/task/5180846782021632?command=test#L543 > >

Re: [Qemu-devel] [PULL 18/76] optionrom: add new PVH option rom

2021-03-19 Thread Paolo Bonzini
It's likely that the compiler will online it. But indeed it's better to add -minline-all-stringops to the compiler command line. Paolo Il ven 19 mar 2021, 18:35 Stefano Garzarella ha scritto: > On Fri, Mar 19, 2021 at 06:03:59PM +0100, Paolo Bonzini wrote: > >On 19/03/21 15:06, Philippe

Re: CXL 2.0 memory device design

2021-03-19 Thread Ben Widawsky
On 21-03-19 18:07:05, Igor Mammedov wrote: > On Wed, 17 Mar 2021 14:40:58 -0700 > Ben Widawsky wrote: > > > Phil, Igor, Markus > > > > TL;DR: What to do about multiple capacities in a single device, and what to > > do > > about interleave? > > > > I've hacked together a basic CXL 2.0

Re: [Qemu-devel] [PULL 18/76] optionrom: add new PVH option rom

2021-03-19 Thread Stefano Garzarella
On Fri, Mar 19, 2021 at 06:03:59PM +0100, Paolo Bonzini wrote: On 19/03/21 15:06, Philippe Mathieu-Daudé wrote: + +/* Search RSDP signature. */ +static uintptr_t search_rsdp(uint32_t start_addr, uint32_t end_addr) +{ +uint64_t *rsdp_p; + +/* RSDP signature is always on a 16 byte

[Bug 1918917] Re: synchronous about on accessing unused I/O ports on aarch64

2021-03-19 Thread Peter Maydell
** Tags added: arm -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1918917 Title: synchronous about on accessing unused I/O ports on aarch64 Status in QEMU: New Bug description: version: QEMU

Re: CXL 2.0 memory device design

2021-03-19 Thread Igor Mammedov
On Wed, 17 Mar 2021 14:40:58 -0700 Ben Widawsky wrote: > Phil, Igor, Markus > > TL;DR: What to do about multiple capacities in a single device, and what to do > about interleave? > > I've hacked together a basic CXL 2.0 implementation which exposes a CXL "Type > 3" > memory device (CXL 2.0

[PATCH v1] introduce multifd into guestperf

2021-03-19 Thread huangy81
From: Hyman Huang(黄勇) This is the v1 of guestperf multifd migration support It is merely the same as the original patch, just change the maintainer, since the ./scripts/get_maintainer.pl do not get the maintainer of tests/migration before this patch:

[PATCH v1] tests/migration: introduce multifd into guestperf

2021-03-19 Thread huangy81
From: Hyman Guestperf tool does not cover the multifd-enabled migration currently, it is worth supporting so that developers can analysis the migration performance with all kinds of migration. To request that multifd is enabled, with 4 channels: $ ./tests/migration/guestperf.py \ --multifd

Re: [Qemu-devel] [PULL 18/76] optionrom: add new PVH option rom

2021-03-19 Thread Paolo Bonzini
On 19/03/21 15:06, Philippe Mathieu-Daudé wrote: + +/* Search RSDP signature. */ +static uintptr_t search_rsdp(uint32_t start_addr, uint32_t end_addr) +{ +uint64_t *rsdp_p; + +/* RSDP signature is always on a 16 byte boundary */ +for (rsdp_p = (uint64_t *)start_addr; rsdp_p <

Re: [RFC PATCH] i386: Add ratelimit for bus locks acquired in guest

2021-03-19 Thread Marcelo Tosatti
On Fri, Mar 19, 2021 at 10:59:20AM +0800, Chenyi Qiang wrote: > Hi Marcelo, > > Thank you for your comment. > > On 3/19/2021 1:32 AM, Marcelo Tosatti wrote: > > On Wed, Mar 17, 2021 at 04:47:09PM +0800, Chenyi Qiang wrote: > > > Virtual Machines can exploit bus locks to degrade the performance

[PATCH] FreeBSD: Upgrade to 12.2 release

2021-03-19 Thread Thomas Huth
From: Warner Losh FreeBSD 12.1 has reached end of life. Use 12.2 instead so that FreeBSD's project's packages will work. Update which timezone to pick. Work around a QEMU bug that incorrectly raises an exception on a CRC32 instruction with the FPU disabled. The qemu bug is described here:

Re: [PATCH v4 13/14] qmp: Include "reserve" property of memory backends

2021-03-19 Thread David Hildenbrand
On 19.03.21 17:32, Markus Armbruster wrote: David Hildenbrand writes: On 19.03.21 16:40, Markus Armbruster wrote: David Hildenbrand writes: Let's include the new property. Cc: Eric Blake Cc: Markus Armbruster Signed-off-by: David Hildenbrand --- hw/core/machine-qmp-cmds.c | 1 +

Re: [PULL v5 0/7] QOM and fdc patches patches for 2021-03-16

2021-03-19 Thread Peter Maydell
On Fri, 19 Mar 2021 at 14:43, Markus Armbruster wrote: > > The following changes since commit 92566947b3ac5ca75f91a34acb188219c455fc71: > > Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging > (2021-03-19 11:27:40 +) > > are available in the Git repository at: > >

Re: [PATCH v4 13/14] qmp: Include "reserve" property of memory backends

2021-03-19 Thread Markus Armbruster
David Hildenbrand writes: > On 19.03.21 16:40, Markus Armbruster wrote: >> David Hildenbrand writes: >> >>> Let's include the new property. >>> >>> Cc: Eric Blake >>> Cc: Markus Armbruster >>> Signed-off-by: David Hildenbrand >>> --- >>> hw/core/machine-qmp-cmds.c | 1 + >>>

[PATCH for-6.0] hw/timer/renesas_tmr: Add default-case asserts in read_tcnt()

2021-03-19 Thread Peter Maydell
In commit 81b3ddaf8772ec we fixed a use of uninitialized data in read_tcnt(). However this change wasn't enough to placate Coverity, which is not smart enough to see that if we read a 2 bit field and then handle cases 0, 1, 2 and 3 then there cannot be a flow of execution through the switch

Re: [PATCH V4 3/7] qapi/net: Add new QMP command for COLO passthrough

2021-03-19 Thread Markus Armbruster
Zhang Chen writes: > Since the real user scenario does not need COLO to monitor all traffic. > Add colo-passthrough-add and colo-passthrough-del to maintain > a COLO network passthrough list. > > Signed-off-by: Zhang Chen > --- > net/net.c | 10 ++ > qapi/net.json | 40

Re: [PATCH V4 2/7] qapi/net.json: Add L4_Connection definition

2021-03-19 Thread Markus Armbruster
One more little thing... Zhang Chen writes: > Add L4_Connection struct for other QMP commands. > Except protocol field is necessary, other fields are optional. > > Signed-off-by: Zhang Chen > --- > qapi/net.json | 26 ++ > 1 file changed, 26 insertions(+) > > diff

Re: [Qemu-devel] [PULL 18/76] optionrom: add new PVH option rom

2021-03-19 Thread Stefano Garzarella
On Fri, Mar 19, 2021 at 03:06:25PM +0100, Philippe Mathieu-Daudé wrote: Hi Stefano, On 2/5/19 7:14 PM, Paolo Bonzini wrote: From: Stefano Garzarella The new pvh.bin option rom can be used with SeaBIOS to boot uncompressed kernel using the x86/HVM direct boot ABI. pvh.S contains the entry

Re: [PATCH v4 13/14] qmp: Include "reserve" property of memory backends

2021-03-19 Thread David Hildenbrand
On 19.03.21 16:40, Markus Armbruster wrote: David Hildenbrand writes: Let's include the new property. Cc: Eric Blake Cc: Markus Armbruster Signed-off-by: David Hildenbrand --- hw/core/machine-qmp-cmds.c | 1 + qapi/machine.json | 6 ++ 2 files changed, 7 insertions(+)

Re: [PATCH V4 2/7] qapi/net.json: Add L4_Connection definition

2021-03-19 Thread Markus Armbruster
Zhang Chen writes: > Add L4_Connection struct for other QMP commands. > Except protocol field is necessary, other fields are optional. > > Signed-off-by: Zhang Chen > --- > qapi/net.json | 26 ++ > 1 file changed, 26 insertions(+) > > diff --git a/qapi/net.json

Re: [PATCH V4 1/7] qapi/net.json: Add IP_PROTOCOL definition

2021-03-19 Thread Markus Armbruster
Zhang Chen writes: > Add IP_PROTOCOL as enum include TCP,UDP, ICMP... for other QMP commands. > > Signed-off-by: Zhang Chen > --- > qapi/net.json | 31 +++ > 1 file changed, 31 insertions(+) > > diff --git a/qapi/net.json b/qapi/net.json > index

Re: [PATCH v4 13/14] qmp: Include "reserve" property of memory backends

2021-03-19 Thread Markus Armbruster
David Hildenbrand writes: > Let's include the new property. > > Cc: Eric Blake > Cc: Markus Armbruster > Signed-off-by: David Hildenbrand > --- > hw/core/machine-qmp-cmds.c | 1 + > qapi/machine.json | 6 ++ > 2 files changed, 7 insertions(+) > > diff --git

Re: [PATCH 0/2] Fix atomic test in "configure" + bump FreeBSD CI to 12.2

2021-03-19 Thread Alex Bennée
Thomas Huth writes: > FreeBSD 12.1 is out of service now, so the Cirrus-CI task is failing due > to using some packages from 12.2 on the 12.1 image. We have to update > it to 12.2. However, there are two obstacles: > > First, the check for the 128-bit atomic functions in the configure > script

Re: [RFC PATCH 1/2] modules: introduce target specific modules

2021-03-19 Thread Halil Pasic
On Thu, 18 Mar 2021 12:36:48 +0100 Philippe Mathieu-Daudé wrote: > > diff --git a/roms/SLOF b/roms/SLOF > > index 33a7322de1..e18ddad851 16 > > --- a/roms/SLOF > > +++ b/roms/SLOF > > @@ -1 +1 @@ > > -Subproject commit 33a7322de13e9dca4b38851a345a58d37e7a441d > > +Subproject commit

Re: Serious doubts about Gitlab CI

2021-03-19 Thread Wainer dos Santos Moschetta
Hi, On 3/19/21 8:34 AM, Philippe Mathieu-Daudé wrote: On 3/19/21 11:59 AM, Paolo Bonzini wrote: On 19/03/21 11:18, Andrew Jones wrote: Yikes, that is 41 hours per CI run. I wonder if GitLab's CI minutes are on slow machines or if we'll hit the same issue with dedicated runners. It seems like

[PULL v4 00/11] QAPI patches patches for 2021-03-16

2021-03-19 Thread Markus Armbruster
The following changes since commit 92566947b3ac5ca75f91a34acb188219c455fc71: Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging (2021-03-19 11:27:40 +) are available in the Git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-qapi-2021-03-16-v4 for

Re: [PATCH] target/riscv: Prevent lost illegal instruction exceptions

2021-03-19 Thread Richard Henderson
On 3/16/21 9:03 AM, Georg Kotheimer wrote: When decode_insn16() fails, we fall back to decode_RV32_64C() for further compressed instruction decoding. I think this is all dead code now. Certainly c.ld/c.sd are in insn16-64.decode and c.flw/c.fsw are in insn16-32.decode. Digging, we failed

Re: [PATCH 1/2] floppy: add a regression test for CVE-2020-25741

2021-03-19 Thread Alexander Bulekov
On 210319 1026, Paolo Bonzini wrote: > On 19/03/21 06:53, Markus Armbruster wrote: > > I guess this is a reproducer. Please also describe actual and expected > > result. Same for PATCH 2. > > Isn't it in the patch itself? > > Alexander, I think these reproducers are self-contained enough (no

[PATCH v1 0/3] migration: Fixes to the 'background-snapshot' code

2021-03-19 Thread Andrey Gruzdev
Changes v0->v1: * Using qemu_real_host_page_size instead of TARGET_PAGE_SIZE for host page size in ram_block_populate_pages() * More elegant implementation of ram_block_populate_pages() This patch series contains: * Fix to the issue with occasionally truncated non-iterable device state *

[PATCH v1 2/3] migration: Inhibit virtio-balloon for the duration of background snapshot

2021-03-19 Thread Andrey Gruzdev
The same thing as for incoming postcopy - we cannot deal with concurrent RAM discards when using background snapshot feature in outgoing migration. Signed-off-by: Andrey Gruzdev Reviewed-by: David Hildenbrand --- hw/virtio/virtio-balloon.c | 8 ++-- include/migration/misc.h | 2 ++

[PATCH v1 3/3] migration: Pre-fault memory before starting background snasphot

2021-03-19 Thread Andrey Gruzdev
This commit solves the issue with userfault_fd WP feature that background snapshot is based on. For any never poluated or discarded memory page, the UFFDIO_WRITEPROTECT ioctl() would skip updating PTE for that page, thereby loosing WP setting for it. So we need to pre-fault pages for each RAM

Re: [PATCH 1/2] floppy: add a regression test for CVE-2020-25741

2021-03-19 Thread Alexander Bulekov
On 210319 1054, Markus Armbruster wrote: > Paolo Bonzini writes: > > > On 19/03/21 06:53, Markus Armbruster wrote: > >> I guess this is a reproducer. Please also describe actual and expected > >> result. Same for PATCH 2. > > > > Isn't it in the patch itself? > > A commit message should tell

[PATCH v1 1/3] migration: Fix missing qemu_fflush() on buffer file in bg_migration_thread

2021-03-19 Thread Andrey Gruzdev
Added missing qemu_fflush() on buffer file holding precopy device state. Increased initial QIOChannelBuffer allocation to 512KB to avoid reallocs. Typical configurations often require >200KB for device state and VMDESC. Signed-off-by: Andrey Gruzdev --- migration/migration.c | 4 +++- 1 file

Re: [PULL 0/8] Misc bugfixes for QEMU soft freeze

2021-03-19 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210319143924.2173798-1-pbonz...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210319143924.2173798-1-pbonz...@redhat.com Subject: [PULL 0/8] Misc bugfixes for

Re: [PATCH] gitlab-ci: Restrict jobs using Docker to runners having 'docker' tag

2021-03-19 Thread Laszlo Ersek
On 03/19/21 06:40, Thomas Huth wrote: > On 19/03/2021 01.43, Philippe Mathieu-Daudé wrote: >> When a job is based on a Docker image [1], or is using a Docker >> service, it requires a runner with Docker installed. >> >> Gitlab shared runners provide the 'docker' tag when they have it >> installed.

Re: [PATCH v2 5/6] iotests: test m68k with the virt machine

2021-03-19 Thread Cornelia Huck
On Fri, 19 Mar 2021 14:25:36 +0100 Laurent Vivier wrote: > This allows to cover the virtio tests with a 32bit big-endian > virtio-mmio machine. > > Reviewed-by: Philippe Mathieu-Daudé > Signed-off-by: Laurent Vivier > --- > tests/qemu-iotests/testenv.py | 1 + > 1 file changed, 1

Re: [PATCH v2 4/6] iotests: Revert "iotests: use -ccw on s390x for 040, 139, and 182"

2021-03-19 Thread Cornelia Huck
On Fri, 19 Mar 2021 14:25:35 +0100 Laurent Vivier wrote: > Commit f1d5516ab583 introduces a test in some iotests to check if > the machine is a s390-ccw-virtio and to select virtio-*-ccw rather > than virtio-*-pci. > > We don't need that because QEMU already provides aliases to use the correct

Re: [PATCH v2 3/6] blockdev: with -drive if=virtio, use generic virtio-blk

2021-03-19 Thread Cornelia Huck
On Fri, 19 Mar 2021 14:25:34 +0100 Laurent Vivier wrote: > Rather than checking if the machine is an s390x to use virtio-blk-ccw > instead of virtio-blk-pci, use the alias virtio-blk that is set to > the expected target. One side effect: if we add a new architecture and don't define the aliases

Re: [PATCH v2 2/6] m68k: add the virtio devices aliases

2021-03-19 Thread Cornelia Huck
On Fri, 19 Mar 2021 14:25:33 +0100 Laurent Vivier wrote: > Similarly to 5f629d943cb0 ("s390x: fix s390 virtio aliases"), > define the virtio aliases. > > This allows to start machines with virtio devices without > knowledge of the implementation type. > > For instance, we can use "-device

[PULL v5 0/7] QOM and fdc patches patches for 2021-03-16

2021-03-19 Thread Markus Armbruster
The following changes since commit 92566947b3ac5ca75f91a34acb188219c455fc71: Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging (2021-03-19 11:27:40 +) are available in the Git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-qom-fdc-2021-03-16-v5 for

[Bug 1920211] [NEW] shrink option for discard (for bad host-filesystems and -backup solutions)

2021-03-19 Thread kolAflash
Public bug reported: When using discard=unmap for virtio or scsi devices with QCOW2 images, space discarded by the guest will be unmaped on the host, which is basically great! This will turn the QCOW2 image into a sparse file which is efficient for most scenarios. But it may be that you need to

[PULL 5/8] i386: Fix 'hypercall_hypercall' typo

2021-03-19 Thread Paolo Bonzini
From: Vitaly Kuznetsov Even the name of this section is 'cpu/msr_hyperv_hypercall', 'hypercall_hypercall' is clearly a typo. Signed-off-by: Vitaly Kuznetsov Message-Id: <20210318160249.1084178-3-vkuzn...@redhat.com> Signed-off-by: Paolo Bonzini --- target/i386/machine.c | 4 ++-- 1 file

[PULL 8/8] tests/qtest: cleanup the testcase for bug 1878642

2021-03-19 Thread Paolo Bonzini
Clean up the writes to the configuration space and the PM region, and rename the test to lpc-ich9-test. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Paolo Bonzini --- tests/qtest/{fuzz-test.c => lpc-ich9-test.c} | 12 +++- tests/qtest/meson.build | 2 +- 2

[PULL 6/8] i386: Make migration fail when Hyper-V reenlightenment was enabled but 'user_tsc_khz' is unset

2021-03-19 Thread Paolo Bonzini
From: Vitaly Kuznetsov KVM doesn't fully support Hyper-V reenlightenment notifications on migration. In particular, it doesn't support emulating TSC frequency of the source host by trapping all TSC accesses so unless TSC scaling is supported on the destination host and KVM_SET_TSC_KHZ succeeds,

Re: [PATCH] fuzz: Avoid deprecated misuse of -drive if=sd

2021-03-19 Thread Alexander Bulekov
On 210319 1420, Markus Armbruster wrote: > qemu-fuzz-i386-target-generic-fuzz-sdhci-v3 uses -drive=sd where it > should use -drive if=none instead. This prints a deprecation warning: > > $ ./build-oss-fuzz/DEST_DIR/qemu-fuzz-i386-target-generic-fuzz-sdhci-v3 > -runs=1 -seed=1 > [ASan

[PULL 7/8] hw/intc/i8259: Refactor pic_read_irq() to avoid uninitialized variable

2021-03-19 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé Some compiler versions are smart enough to detect a potentially uninitialized variable, but are not smart enough to detect that this cannot happen due to the code flow: ../hw/intc/i8259.c: In function ‘pic_read_irq’: ../hw/intc/i8259.c:203:13: error: ‘irq2’ may be

[PULL 4/8] target/i386: svm: do not discard high 32 bits of EXITINFO1

2021-03-19 Thread Paolo Bonzini
env->error_code is only 32-bits wide, so the high 32 bits of EXITINFO1 are being lost. However, even though saving guest state and restoring host state must be delayed to do_vmexit, because they might take tb_lock, it is always possible to write to the VMCB. So do this for the exit code and

[PULL 3/8] target/i386: fail if toggling LA57 in 64-bit mode

2021-03-19 Thread Paolo Bonzini
This fixes kvm-unit-tests access.flat with -cpu qemu64,la57. Signed-off-by: Paolo Bonzini --- target/i386/tcg/misc_helper.c | 4 1 file changed, 4 insertions(+) diff --git a/target/i386/tcg/misc_helper.c b/target/i386/tcg/misc_helper.c index 90b87fdef0..a25428c36e 100644 ---

Re: [PATCH v2 1/6] qdev: define list of archs with virtio-pci or virtio-ccw

2021-03-19 Thread Cornelia Huck
On Fri, 19 Mar 2021 14:25:32 +0100 Laurent Vivier wrote: > This is used to define virtio-*-pci and virtio-*-ccw aliases > rather than substracting the CCW architecture from all the others. > > Signed-off-by: Laurent Vivier > --- > include/sysemu/arch_init.h | 7 + >

[PULL 2/8] target/i386: allow modifying TCG phys-addr-bits

2021-03-19 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- target/i386/cpu.c | 23 --- target/i386/cpu.h | 1 - target/i386/tcg/excp_helper.c | 7 --- target/i386/tcg/helper-tcg.h | 12 4 files changed, 16 insertions(+), 27 deletions(-) diff --git

[PULL 0/8] Misc bugfixes for QEMU soft freeze

2021-03-19 Thread Paolo Bonzini
The following changes since commit cf6b56d4f2107259f52413f979a1d474dad0c1e1: Merge remote-tracking branch 'remotes/philmd/tags/pflash-20210318' into staging (2021-03-18 23:04:41 +) are available in the Git repository at: https://gitlab.com/bonzini/qemu.git tags/for-upstream for you to

[PULL 1/8] qom: use qemu_printf to print help for user-creatable objects

2021-03-19 Thread Paolo Bonzini
Since we have added help support for object_add, the help is printed on stdout. Switch to qemu_printf so that it goes to the monitor. Signed-off-by: Paolo Bonzini --- qom/object_interfaces.c | 1 + 1 file changed, 1 insertion(+) diff --git a/qom/object_interfaces.c b/qom/object_interfaces.c

Re: [Qemu-devel] [PULL 18/76] optionrom: add new PVH option rom

2021-03-19 Thread Stefano Garzarella
On Fri, Mar 19, 2021 at 03:06:25PM +0100, Philippe Mathieu-Daudé wrote: Hi Stefano, On 2/5/19 7:14 PM, Paolo Bonzini wrote: From: Stefano Garzarella The new pvh.bin option rom can be used with SeaBIOS to boot uncompressed kernel using the x86/HVM direct boot ABI. pvh.S contains the entry

Re: [PATCH v2] target/riscv: Add proper two-stage lookup exception detection

2021-03-19 Thread Alistair Francis
On Fri, Mar 19, 2021 at 10:16 AM Georg Kotheimer wrote: > > The current two-stage lookup detection in riscv_cpu_do_interrupt falls > short of its purpose, as all it checks is whether two-stage address > translation either via the hypervisor-load store instructions or the > MPRV feature would be

Re: [PATCH v2 6/6] iotests: iothreads need ioeventfd

2021-03-19 Thread Cornelia Huck
On Fri, 19 Mar 2021 15:27:24 +0100 Laurent Vivier wrote: > Le 19/03/2021 à 15:23, Cornelia Huck a écrit : > > On Fri, 19 Mar 2021 14:51:59 +0100 > > Laurent Vivier wrote: > > > >> Le 19/03/2021 à 14:36, Philippe Mathieu-Daudé a écrit : > >>> On 3/19/21 2:25 PM, Laurent Vivier wrote: >

[Bug 1920013] Re: Unable to pass-through PCIe devices from a ppc64le host to an x86_64 guest

2021-03-19 Thread Laurent Vivier
I think cross-arch VFIO has already been discussed in: https://bugs.launchpad.net/qemu/+bug/1869006 Perhaps you will have some answers. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1920013 Title:

Re: [PATCH for 6.0 v4] hw/intc/i8259: Refactor pic_read_irq() to avoid uninitialized variable

2021-03-19 Thread Philippe Mathieu-Daudé
On 3/19/21 3:23 PM, Philippe Mathieu-Daudé wrote: > Some compiler versions are smart enough to detect a potentially > uninitialized variable, but are not smart enough to detect that this > cannot happen due to the code flow: > > ../hw/intc/i8259.c: In function ‘pic_read_irq’: >

Re: [PATCH v2 6/6] iotests: iothreads need ioeventfd

2021-03-19 Thread Laurent Vivier
Le 19/03/2021 à 15:23, Cornelia Huck a écrit : > On Fri, 19 Mar 2021 14:51:59 +0100 > Laurent Vivier wrote: > >> Le 19/03/2021 à 14:36, Philippe Mathieu-Daudé a écrit : >>> On 3/19/21 2:25 PM, Laurent Vivier wrote: And ioeventfd are only available with virtio-scsi-pci or virtio-scsi-ccw,

Re: [PATCH v2 6/6] iotests: iothreads need ioeventfd

2021-03-19 Thread Cornelia Huck
On Fri, 19 Mar 2021 14:51:59 +0100 Laurent Vivier wrote: > Le 19/03/2021 à 14:36, Philippe Mathieu-Daudé a écrit : > > On 3/19/21 2:25 PM, Laurent Vivier wrote: > >> And ioeventfd are only available with virtio-scsi-pci or virtio-scsi-ccw, > >> use the alias but add a rule to require

[PATCH for 6.0 v4] hw/intc/i8259: Refactor pic_read_irq() to avoid uninitialized variable

2021-03-19 Thread Philippe Mathieu-Daudé
Some compiler versions are smart enough to detect a potentially uninitialized variable, but are not smart enough to detect that this cannot happen due to the code flow: ../hw/intc/i8259.c: In function ‘pic_read_irq’: ../hw/intc/i8259.c:203:13: error: ‘irq2’ may be used uninitialized in this

Re: [PATCH] tests/qtest: cleanup the testcase for bug 1878642

2021-03-19 Thread Philippe Mathieu-Daudé
On 3/19/21 9:56 AM, Paolo Bonzini wrote: > Clean up the writes to the configuration space and the PM region, and > rename the test to lpc-ich9-test. > > Signed-off-by: Paolo Bonzini > --- > tests/qtest/{fuzz-test.c => lpc-ich9-test.c} | 12 +++- > tests/qtest/meson.build

[PATCH v2] target/riscv: Add proper two-stage lookup exception detection

2021-03-19 Thread Georg Kotheimer
The current two-stage lookup detection in riscv_cpu_do_interrupt falls short of its purpose, as all it checks is whether two-stage address translation either via the hypervisor-load store instructions or the MPRV feature would be allowed. What we really need instead is whether two-stage address

Re: QEMU PCI subsystem: what code is responsible for making accesses to non-mapped addresses read as -1?

2021-03-19 Thread Philippe Mathieu-Daudé
On 3/19/21 1:35 PM, Peter Maydell wrote: > I'm looking at a bug reported against the QEMU arm virt board's pci-gpex > PCI controller: https://bugs.launchpad.net/qemu/+bug/1918917 > where an attempt to write to an address within the PCI IO window > where the guest hasn't mapped a BAR causes a CPU

  1   2   3   >