John Snow writes:
> On 3/23/21 5:40 AM, Markus Armbruster wrote:
>> Naming rules differ for the various kinds of names. To prepare
>> enforcing them, define functions to check them: check_name_upper(),
>> check_name_lower(), and check_name_camel(). For now, these merely
>> wrap around
John Snow writes:
> On 3/23/21 5:40 AM, Markus Armbruster wrote:
>> check_name_str() masks leading digits when passed enum_member=True.
>> Only check_enum() does. Lift the masking into check_enum().
>> Signed-off-by: Markus Armbruster
>> ---
>> scripts/qapi/expr.py | 23
On 23/03/2021 16.51, Philippe Mathieu-Daudé wrote:
Signed-off-by: Philippe Mathieu-Daudé
---
Cc: Cornelia Huck
Cc: Thomas Huth
Cc: qemu-s3...@nongnu.org
---
meson.build | 2 ++
pc-bios/meson.build | 9 +++--
2 files changed, 9 insertions(+), 2 deletions(-)
diff --git
On 23/03/2021 20.40, Dr. David Alan Gilbert wrote:
* huang...@chinatelecom.cn (huang...@chinatelecom.cn) wrote:
From: Hyman Huang(黄勇)
when execute the following test command:
$ ./guestperf-batch.py --auto-converge \
--auto-converge-step {percent} ...
test aborts and error message be
On 22/03/2021 16:44, David Gibson wrote:
On Thu, Feb 25, 2021 at 02:23:35PM +1100, Alexey Kardashevskiy wrote:
There is no H_REGISTER_PROCESS_TABLE, it is H_REGISTER_PROC_TBL handler
for which is still called h_register_process_table() though.
Signed-off-by: Alexey Kardashevskiy
Applied
On Tue, Mar 23, 2021 at 09:47:55AM -0400, Shivaprasad G Bhat wrote:
> The patch adds the 'sync-dax' property to the nvdimm device.
>
> When the sync-dax is 'off', the device tree property
> "hcall-flush-required" is added to the nvdimm node which makes the
> guest to issue H_SCM_FLUSH hcalls to
On Tue, Mar 23, 2021 at 09:47:38AM -0400, Shivaprasad G Bhat wrote:
> The patch adds support for the SCM flush hcall for the nvdimm devices.
> To be available for exploitation by guest through the next patch.
>
> The hcall expects the semantics such that the flush to return
> with H_BUSY when the
On Tue, Mar 23, 2021 at 09:47:23AM -0400, Shivaprasad G Bhat wrote:
> The subsequent patches add definitions which tend to
> get the compilation to cyclic dependency. So, prepare
> with forward declarations, move the defitions and clean up.
>
> Signed-off-by: Shivaprasad G Bhat
> ---
>
Hi Peter,
On 2021/3/23 22:34, Peter Xu wrote:
> Keqian,
>
> On Tue, Mar 23, 2021 at 02:40:43PM +0800, Keqian Zhu wrote:
The second question is that you observed longer migration time (55s->73s)
when guest
has 24G ram and dirty rate is 800M/s. I am not clear about the reason. As
Jiaxun Yang 于2021年3月24日周三 上午9:29写道：
>
>
>
> On Tue, Mar 23, 2021, at 9:56 PM, Philippe Mathieu-Daudé wrote:
> > Hi Huacai,
> >
> > We are going to tag QEMU v6.0-rc0 today.
> >
> > I only have access to a 64-bit MIPS in little-endian to
> > test KVM.
> >
> > Can you test the other configurations
On Tue, Mar 23, 2021 at 11:04:03AM -0600, Richard Henderson wrote:
> On 3/22/21 5:54 PM, David Gibson wrote:
> > On Mon, Mar 22, 2021 at 10:55:46AM -0600, Richard Henderson wrote:
> > > On 3/21/21 9:52 PM, David Gibson wrote:
> > > > > +/*
> > > > > + * Bits for env->hflags.
> > > > > + *
> > > >
On Tue, Mar 23, 2021 at 02:31:07PM +0100, BALATON Zoltan wrote:
> On Tue, 23 Mar 2021, David Gibson wrote:
> > On Wed, Mar 17, 2021 at 02:17:51AM +0100, BALATON Zoltan wrote:
[snip]
> > > +static void setup_mem_windows(MV64361State *s, uint32_t val)
> > > +{
> > > +MV64361PCIState *p;
> > > +
The rw portion of the buffer is the only one in which overruns
can be generated. Allow the rx portion to be more completely
covered by huge pages.
Signed-off-by: Richard Henderson
Tested-by: Roman Bolshakov
Reviewed-by: Roman Bolshakov
Message-Id:
On Tue, Mar 23, 2021 at 02:01:27PM +0100, BALATON Zoltan wrote:
> On Tue, 23 Mar 2021, David Gibson wrote:
> > On Wed, Mar 17, 2021 at 02:17:51AM +0100, BALATON Zoltan wrote:
> > > Add new machine called pegasos2 emulating the Genesi/bPlan Pegasos II,
> > > a PowerPC board based on the Marvell
There's a change in mprotect() behaviour [1] in the latest macOS
on M1 and it's not yet clear if it's going to be fixed by Apple.
As a short-term fix, ignore failures setting up the guard pages.
[1] https://gist.github.com/hikalium/75ae822466ee4da13cbbe486498a191f
Signed-off-by: Richard
On Tue, Mar 23, 2021 at 02:10:22PM -0300, Daniel Henrique Barboza wrote:
>
>
> On 3/22/21 10:12 PM, David Gibson wrote:
> > On Fri, Mar 12, 2021 at 05:07:36PM -0300, Daniel Henrique Barboza wrote:
> > > Hi,
> > >
> > > This series adds 2 new QAPI events, DEVICE_NOT_DELETED and
> > >
The following changes since commit 266469947161aa10b1d36843580d369d5aa38589:
Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2021-03-23' into
staging (2021-03-23 22:28:58 +)
are available in the Git repository at:
https://github.com/rth7680/qemu.git tags/pull-tcg-20210323
In bbc17caf81f, we used an alias attribute to allow target_page
to be declared const, and yet be initialized late.
This fails when using LTO with several versions of gcc.
The compiler looks through the alias and decides that the const
variable is statically initialized to zero, then propagates
In the next commit we will extract the generic code out of
page-vary.c, only keeping the target specific code. Both
files will use the same TargetPageBits structure, so make
its declaration in a shared header.
As the common header can not use target specific types,
use a uint64_t to hold the page
exec-vary.c is about variable page size handling,
rename it page-vary.c. Currently this file is target
specific (built once for each target), comment this.
Signed-off-by: Philippe Mathieu-Daudé
Message-Id: <20210322112427.4045204-2-f4...@amsat.org>
[rth: Update MAINTAINERS]
Signed-off-by:
On Tue, Mar 23, 2021 at 12:43:40PM -0600, Richard Henderson wrote:
> Verify that hflags was updated correctly whenever we change
> cpu state that is used by hflags.
>
> Signed-off-by: Richard Henderson
Applied to ppc-for-6.0, thanks.
> ---
> target/ppc/cpu.h | 5 +
>
On Tue, Mar 23, 2021 at 12:43:37PM -0600, Richard Henderson wrote:
> Nothing within the translator -- or anywhere else for that
> matter -- checks MSR_SA or MSR_AP on the 602. This may be
> a mistake. However, for the moment, we need not record these
> bits in hflags.
And frankly, even if it's
On Tue, Mar 23, 2021 at 12:43:38PM -0600, Richard Henderson wrote:
> We weren't recording MSR_GS in hflags, which means that BookE
> memory accesses were essentially random vs Guest State.
>
> Instead of adding this bit directly, record the completed mmu
> indexes instead. This makes it obvious
On Tue, Mar 23, 2021 at 12:43:36PM -0600, Richard Henderson wrote:
> Because this bit was not in hflags, the privilege check
> for tlb instructions was essentially random.
> Recompute hflags when storing to LPCR.
>
> Reviewed-by: David Gibson
> Signed-off-by: Richard Henderson
Applied to
On Tue, Mar 23, 2021 at 12:43:34PM -0600, Richard Henderson wrote:
> Because these bits were not in hflags, the code generated
> for single-stepping on BookE was essentially random.
> Recompute hflags when storing to dbcr0.
>
> Reviewed-by: David Gibson
> Signed-off-by: Richard Henderson
On Tue, Mar 23, 2021 at 12:43:39PM -0600, Richard Henderson wrote:
> In save_user_regs, there are two bugs where we OR in a bit number
> instead of the bit, clobbering the low bits of MSR. However:
>
> The MSR_VR and MSR_SPE bits control the availability of the insns.
> If the bits were not
On Tue, Mar 23, 2021 at 12:43:31PM -0600, Richard Henderson wrote:
> Extract post_load_update_msr to share between cpu_load_old
> and cpu_post_load in updating the msr.
>
> Suggested-by: Cédric Le Goater
> Signed-off-by: Richard Henderson
Applied to ppc-for-6.0.
> ---
> target/ppc/machine.c
On Tue, Mar 23, 2021 at 12:43:35PM -0600, Richard Henderson wrote:
> Perform the test against FSCR_SCV at runtime, in the helper.
>
> This means we can remove the incorrect set against SCV in
> ppc_tr_init_disas_context and do not need to add an HFLAGS bit.
>
> Signed-off-by: Richard Henderson
On Tue, Mar 23, 2021 at 12:43:32PM -0600, Richard Henderson wrote:
> Copying flags directly from msr has drawbacks: (1) msr bits
> mean different things per cpu, (2) msr has 64 bits on 64 cpus
> while tb->flags has only 32 bits.
>
> Create a enum to define these bits. Document the origin of each
On Tue, Mar 23, 2021 at 12:43:33PM -0600, Richard Henderson wrote:
> It will be stored in tb->flags, which is also uint32_t,
> so let's use the correct size.
>
> Reviewed-by: Cédric Le Goater
> Reviewed-by: David Gibson
> Signed-off-by: Richard Henderson
Applied to ppc-for-6.0.
> ---
>
On Tue, Mar 23, 2021, at 9:56 PM, Philippe Mathieu-Daudé wrote:
> Hi Huacai,
>
> We are going to tag QEMU v6.0-rc0 today.
>
> I only have access to a 64-bit MIPS in little-endian to
> test KVM.
>
> Can you test the other configurations please?
> - 32-bit BE
> - 32-bit LE
> - 64-bit BE
+syq
cc th...@redhat.com and berra...@redhat.com
Please review, thanks
在 2021/3/20 1:04, huang...@chinatelecom.cn 写道:
From: Hyman
Guestperf tool does not cover the multifd-enabled migration
currently, it is worth supporting so that developers can
analysis the migration performance with all kinds
Public bug reported:
Hi,
I had this working before, but in the latest version of QEMU (built from
master), when I try to install Corsair iCUE, and it gets to the driver
install point => my Windows 10 VM just reboots! I would be happy to
capture logs, but ... what logs exist for an uncontrolled
> -Original Message-
> From: Markus Armbruster
> Sent: Tuesday, March 23, 2021 5:55 PM
> To: Zhang, Chen
> Cc: Lukas Straub ; Li Zhijian
> ; Jason Wang ; qemu-
> dev ; Dr. David Alan Gilbert
> ; Zhang Chen
> Subject: Re: [PATCH V4 2/7] qapi/net.json: Add L4_Connection definition
>
>
On Tue, 23 Mar 2021 at 21:57, Markus Armbruster wrote:
>
> The following changes since commit 9950da284fa5e2ea9ab57d87e05b693fb60c79ce:
>
> Merge remote-tracking branch
> 'remotes/alistair/tags/pull-riscv-to-apply-20210322-2' into staging
> (2021-03-23 15:30:46 +)
>
> are available in the
On Wed, 24 Mar 2021, Philippe Mathieu-Daudé wrote:
Instead of creating an input IRQ with qemu_allocate_irqs()
to pass it as output IRQ of the PIC, with its handler simply
dispatching into the "intr" output IRQ, simplify by directly
connecting the PIC to the "intr" named output.
I think I've
The guys on the Fedora side seem to have found the patch to fix this:
https://bugzilla.redhat.com/show_bug.cgi?id=1941652#c6
Apparently it will go upstream in Linux 5.11, but earlier versions also
need the fix, specifically 5.9 and 5.10
Thank you!
** Bug watch added: Red Hat Bugzilla #1941652
On 3/24/21 12:00 AM, Greg Kurz wrote:
> Cc'ing David
>
> On Tue, 23 Mar 2021 17:48:36 +0100
> Thomas Huth wrote:
>
>>
>> In case anyone is interested in fixing those, there are two regressions with
>> qemu-system-ppc64 in the current master branch:
>>
>> $ ./qemu-system-ppc64 -M ppce500
On Tue, Mar 23, 2021 at 04:51:27PM +0100, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> Cc: David Gibson
> Cc: Greg Kurz
> Cc: qemu-...@nongnu.org
> Cc: Mark Cave-Ayland
> Cc: Hervé Poussineau
> Cc: Cédric Le Goater
> Cc: BALATON Zoltan
> ---
> meson.build
On 3/1/21 12:28 PM, Connor Kuehl wrote:
The contents of this patch were initially developed and posted by Han
Han[1], however, it appears the original patch was not applied. Since
then, the relevant documentation has been moved and adapted to a new
format.
I've taken most of the original
On 3/18/21 4:09 PM, Connor Kuehl wrote:
A patch was recently applied that touched up some error messages that
pertained to key names like 'node-name'. The trouble is it only updated
tests/qemu-iotests/051.pc.out and not tests/qemu-iotests/051.out as
well.
Do that now.
Fixes: 785ec4b1b9
We locally create an input IRQ with qemu_allocate_irqs() to
pass it as output IRQ of the PIC, but its handler simply dispatch
into another of our output IRQ ("intr" output).
Simplify by directly connecting the PIC output to our "intr"
output.
This fixes when using QEMU built with
Instead of creating an input IRQ with qemu_allocate_irqs()
to pass it as output IRQ of the PIC, with its handler simply
dispatching into the "intr" output IRQ, simplify by directly
connecting the PIC to the "intr" named output.
Fixes: 3dc31cb8490 ("vt82c686: Move creation of ISA devices to the
Named IRQs are easier to understand in the monitor.
Name the single output interrupt as 'intr'.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/isa/vt82c686.c | 2 +-
hw/mips/fuloong2e.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/isa/vt82c686.c b/hw/isa/vt82c686.c
When the i82378 model was added in commit a04ff940974 ("prep:
Add i82378 PCI-to-ISA bridge emulation") the i8259 model was
not yet QOM'ified. This happened later in commit 747c70af78f
("i8259: Convert to qdev").
Instead of creating an input IRQ with qemu_allocate_irqs()
to pass it as output IRQ
Named IRQs are easier to understand in the monitor.
Name the single output interrupt as 'intr'.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/isa/i82378.c | 2 +-
hw/ppc/prep.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/isa/i82378.c b/hw/isa/i82378.c
index
The i82378 has 2 output IRQs: "INT" and "NMI".
We do not model the NMI, so simplify I82378State by
removing the unused IRQ. To avoid keeping an array of
one element, remove the array and rename the variable.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/isa/i82378.c | 6 +++---
1 file changed, 3
On Tue, 23 Mar 2021, Mark Cave-Ayland wrote:
On 23/03/2021 12:54, BALATON Zoltan wrote:
On Wed, 10 Mar 2021, BALATON Zoltan wrote:
In VIA super south bridge the io ranges of superio components
(parallel and serial ports and FDC) can be controlled by superio
config registers to set their base
I started to fix the LeakSanitizer error in piix4_realize(),
then looked for similar pattern and found 2 other places.
The older is i82378 (historically the first one) which then
spread.
Philippe Mathieu-Daudé (6):
hw/isa/i82378: Name output IRQ as 'intr'
hw/isa/i82378: Simplify removing
On 3/23/21 4:51 PM, Philippe Mathieu-Daudé wrote:
Signed-off-by: Philippe Mathieu-Daudé
---
Cc: Richard Henderson
Cc: Helge Deller
Acked-by: Helge Deller
---
meson.build | 2 ++
pc-bios/meson.build | 7 ++-
2 files changed, 8 insertions(+), 1 deletion(-)
diff --git
Cc'ing David
On Tue, 23 Mar 2021 17:48:36 +0100
Thomas Huth wrote:
>
> In case anyone is interested in fixing those, there are two regressions with
> qemu-system-ppc64 in the current master branch:
>
> $ ./qemu-system-ppc64 -M ppce500 -device macio-oldworld
> qemu-system-ppc64:
On Tue, 23 Mar 2021 at 21:21, Mark Cave-Ayland
wrote:
> I'm not sure what the right solution is here. In my mind there hasn't really
> been any
> difference between TYPE_DEVICE and TYPE_SYS_BUS_DEVICE other than the APIs
> that
> expose the memory regions and IRQs are different, but clearly
Claudio Fontana writes:
> After this patch it is possible to build only kvm:
>
> ./configure --disable-tcg --enable-kvm
FWIW at this point we get a different failure than later on:
21:10:25 [alex@aarch64-new:~/l/q/b/disable.tcg] (94e2abe0…)|… + make
check-qtest
GIT ui/keycodemapdb
On 3/18/21 1:44 PM, Wainer dos Santos Moschetta wrote:
With the recent move of the unit tests to tests/unit directory some
instructions under the "Unit tests" section became imprecise, which
are fixed by this change.
Fixes: da668aa15b99 ("tests: Move unit tests into a separate directory")
"Michael S. Tsirkin" writes:
>> +#include "qemu/cutils.h"
>> +
>> +#define ACPI_BUILD_APPNAME6 "BOCHS "
>> +#define ACPI_BUILD_APPNAME8 "BXPC"
>
> A single user for each of these now ... drop the defines?
>
Unfortunately ACPI_BUILD_APPNAME8 is still used in build_header() in
aml-build.c,
o
> staging (2021-03-22 18:50:25 +)
>
> are available in the Git repository at:
>
> https://git.linaro.org/people/pmaydell/qemu-arm.git
> tags/pull-target-arm-20210323
>
> for you to fetch changes up to dad90de78e9e9d47cefcbcd30115706b98e6ec87:
>
>
On 3/23/21 5:40 AM, Markus Armbruster wrote:
We require lowercase __RFQDN_ downstream prefixes only where we
require the prefixed name to be lowercase. Don't; permit any case in
__RFQDN_ prefixes anywhere.
Signed-off-by: Markus Armbruster
Reviewed-by: John Snow
---
scripts/qapi/expr.py
On Tue, 23 Mar 2021, Philippe Mathieu-Daudé wrote:
Hi Isaku,
On 3/23/21 6:24 PM, Isaku Yamahata wrote:
Without this patch, the following patch will triger clan runtime
sanitizer warnings as follows. This patch proactively works around it.
I let v582c686.c maintainer address a correct fix as
The LinuxTest specifically targets users that need to interact with Linux
guests. So, it makes sense to give a connection by default, and avoid
requiring it as boiler-plate code.
Signed-off-by: Cleber Rosa
---
tests/acceptance/avocado_qemu/__init__.py | 5 -
On 3/23/21 5:40 AM, Markus Armbruster wrote:
Event names should be ALL_CAPS with words separated by underscore.
Enforce this. The only offenders are in tests/. Fix them. Existing
test event-case covers the new error.
Signed-off-by: Markus Armbruster
---
tests/unit/test-qmp-event.c
The LinuxTest class' launch_and_wait() method now behaves the same way
as this test's custom launch_vm(), so let's just use the upper layer
(common) method.
Signed-off-by: Cleber Rosa
---
tests/acceptance/virtiofs_submounts.py | 13 +
1 file changed, 5 insertions(+), 8 deletions(-)
Both the virtiofs submounts and the linux ssh mips malta tests
contains useful methods related to ssh that deserve to be made
available to other tests. Let's move them to the base LinuxTest
class.
The method that helps with setting up an ssh connection will now
support both key and password
On 3/23/21 5:40 AM, Markus Armbruster wrote:
check_name_lower() is the only user of check_name_str() using
permit_upper=False. Move the associated code from check_name_str() to
check_name_lower(), and drop the parameter.
Signed-off-by: Markus Armbruster
Reviewed-by: John Snow
---
Slightly different versions for the same utility code are currently
present on different locations. This unifies them all, giving
preference to the version from virtiofs_submounts.py, because of the
last tweaks added to it.
While at it, this adds a "qemu.utils" module to host the utility
On 23/03/2021 12:54, BALATON Zoltan wrote:
On Wed, 10 Mar 2021, BALATON Zoltan wrote:
In VIA super south bridge the io ranges of superio components
(parallel and serial ports and FDC) can be controlled by superio
config registers to set their base address and enable/disable them.
This is not
On Fri, Mar 19, 2021 at 05:52:46PM +0300, Andrey Gruzdev wrote:
> Changes v0->v1:
> * Using qemu_real_host_page_size instead of TARGET_PAGE_SIZE for host
>page size in ram_block_populate_pages()
> * More elegant implementation of ram_block_populate_pages()
>
> This patch series contains:
>
This introduces a base class for tests that need to interact with a
Linux guest. It generalizes the "boot_linux.py" code, already been
used by the "virtiofs_submounts.py" and also SSH related code being
used by that and "linux_ssh_mips_malta.py".
While at it, a number of fixes on hopeful
Even though there are qtest based tests for hotplugging CPUs (from
which this test took some inspiration from), this one adds checks
from a Linux guest point of view.
It should also serve as an example for tests that follow a similar
pattern and need to interact with QEMU (via qmp) and with the
For users of the LinuxTest class, let's set up the VM with the port
redirection for SSH, instead of requiring each test to set the same
arguments.
Signed-off-by: Cleber Rosa
---
tests/acceptance/avocado_qemu/__init__.py | 4 +++-
tests/acceptance/virtiofs_submounts.py| 4
2 files
On 3/23/21 5:40 AM, Markus Armbruster wrote:
Naming rules differ for the various kinds of names. To prepare
enforcing them, define functions to check them: check_name_upper(),
check_name_lower(), and check_name_camel(). For now, these merely
wrap around check_name_str(), but that will change
Signed-off-by: Cleber Rosa
Reviewed-by: Marc-André Lureau
Reviewed-by: Willian Rampazzo
---
docs/devel/testing.rst | 25 +
1 file changed, 25 insertions(+)
diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst
index 1da4c4e4c4..ed2a06db28 100644
---
Rename pragma returns-whitelist to command-returns-exceptions, and
name-case-whitelist to member-name-case-exceptions.
Signed-off-by: Markus Armbruster
Message-Id: <20210323094025.3569441-20-arm...@redhat.com>
Reviewed-by: Eric Blake
---
docs/devel/qapi-code-gen.txt | 21
This makes the username/password used for authentication configurable,
because some guest operating systems may have restrictions on accounts
to be used for logins, and it just makes it better documented.
Signed-off-by: Cleber Rosa
---
tests/acceptance/avocado_qemu/__init__.py | 6 --
1
Struct members, including command arguments, event data, and union
inline base members, should use '-', not '_'. Enforce this. Fix the
fixable offenders (all in tests/), and add the remainder to pragma
member-name-exceptions.
Signed-off-by: Markus Armbruster
Message-Id:
On 3/23/21 5:40 AM, Markus Armbruster wrote:
check_name_str() masks leading digits when passed enum_member=True.
Only check_enum() does. Lift the masking into check_enum().
Signed-off-by: Markus Armbruster
---
scripts/qapi/expr.py | 23 ++-
1 file changed, 10
The tag is useful to select tests that depend/use a particular
feature.
Signed-off-by: Cleber Rosa
Reviewed-by: Wainer dos Santos Moschetta
Reviewed-by: Willian Rampazzo
---
tests/acceptance/virtiofs_submounts.py | 1 +
1 file changed, 1 insertion(+)
diff --git
If the vmlinuz variable is set to anything that evaluates to True,
then the respective arguments should be set. If the variable contains
an empty string, than it will evaluate to False, and the extra
arguments will not be set.
This keeps the same logic, but improves readability a bit.
Rename pragma-doc-required-crap to pragma-not-bool,
pragma-returns-whitelist-crap to pragma-value-not-list, and
pragma-name-case-whitelist-crap to pragma-value-not-list-of-str.
Signed-off-by: Markus Armbruster
Message-Id: <20210323094025.3569441-18-arm...@redhat.com>
Reviewed-by: Eric Blake
---
Even with -smp 1 you will see the same errors. The problem is because
there is nothing to run after OpenSBI jumps to the next stage.
If you load a kernel you will not see the error messages.
** Changed in: qemu
Status: New => Invalid
--
You received this bug notification because you are
Union branch names should use '-', not '_'. Enforce this. The only
offenders are in tests/. Fix them.
Signed-off-by: Markus Armbruster
Message-Id: <20210323094025.3569441-29-arm...@redhat.com>
Reviewed-by: Eric Blake
[Commit message typo fixed]
---
scripts/qapi/expr.py
Naming rules differ for the various kinds of names. To prepare
enforcing them, define functions to check them: check_name_upper(),
check_name_lower(), and check_name_camel(). For now, these merely
wrap around check_name_str(), but that will change shortly. Replace
the other uses of
Command names and member names within a type should be all lower case
with words separated by a hyphen. We also accept underscore. Rework
check_name_lower() to optionally reject underscores, but don't use
that option, yet.
Update expected test output for the changed error message.
check_name_lower() is the only user of check_name_str() using
permit_upper=False. Move the associated code from check_name_str() to
check_name_lower(), and drop the parameter.
Signed-off-by: Markus Armbruster
Message-Id: <20210323094025.3569441-12-arm...@redhat.com>
Reviewed-by: Eric Blake
---
Enum members should use '-', not '_'. Enforce this. Fix the fixable
offenders (all in tests/), and add the remainder to pragma
member-name-exceptions.
Signed-off-by: Markus Armbruster
Message-Id: <20210323094025.3569441-28-arm...@redhat.com>
Reviewed-by: Eric Blake
---
qapi/pragma.json
The previous commit changed this test to clash with a predefined enum
type, not a built-in type. Adjust its name.
Signed-off-by: Markus Armbruster
Message-Id: <20210323094025.3569441-16-arm...@redhat.com>
Reviewed-by: Eric Blake
---
tests/qapi-schema/meson.build
Signed-off-by: Markus Armbruster
Message-Id: <20210323094025.3569441-21-arm...@redhat.com>
Reviewed-by: Eric Blake
---
qapi/pragma.json | 16 +---
1 file changed, 9 insertions(+), 7 deletions(-)
diff --git a/qapi/pragma.json b/qapi/pragma.json
index 4895848c5e..4c47c802d1 100644
Flat union branch names match the tag enum's member names. Omitted
branches default to "no members for this tag value".
Branch names starting with a digit get rejected like "'data' member
'0' has an invalid name". However, omitting the branch works.
This is because flat union tag values get
Signed-off-by: Markus Armbruster
Message-Id: <20210323094025.3569441-17-arm...@redhat.com>
Reviewed-by: Eric Blake
---
scripts/qapi/parser.py | 19 +--
1 file changed, 9 insertions(+), 10 deletions(-)
diff --git a/scripts/qapi/parser.py b/scripts/qapi/parser.py
index
Command block_passwd always fails since
Commit c01c214b69 "block: remove all encryption handling APIs"
(v2.10.0) turned block_passwd into a stub that always fails, and
hardcoded encryption_key_missing to false in query-named-block-nodes
and query-block.
Commit ad1324e044 "block: remove
We require lowercase __RFQDN_ downstream prefixes only where we
require the prefixed name to be lowercase. Don't; permit any case in
__RFQDN_ prefixes anywhere.
Signed-off-by: Markus Armbruster
Message-Id: <20210323094025.3569441-13-arm...@redhat.com>
Reviewed-by: Eric Blake
---
Commit 967c885108 "qapi: add 'if' to top-level expressions" added
command TestIfCmd with an 'if' condition. It also added the
qmp_TestIfCmd() to go with it, guarded by the corresponding #if.
Commit ccadd6bcba "qapi: Add 'if' to implicit struct members" changed
the command, but not the function.
Command names should be lower-case. Enforce this. Fix the fixable
offenders (all in tests/), and add the remainder to pragma
command-name-exceptions.
Signed-off-by: Markus Armbruster
Message-Id: <20210323094025.3569441-25-arm...@redhat.com>
Reviewed-by: Eric Blake
---
This test covers returning "bad" types. Pragma returns-whitelist is
just one aspect. Naming it returns-whitelist is suboptimal. Rename
to returns-bad-type.
Signed-off-by: Markus Armbruster
Message-Id: <20210323094025.3569441-19-arm...@redhat.com>
Reviewed-by: Eric Blake
---
Commit 0426d53c65 "qapi: Simplify visiting of alternate types"
eliminated the implicit alternate enum, but neglected to update a
comment about it in a test. Do that now.
Signed-off-by: Markus Armbruster
Message-Id: <20210323094025.3569441-5-arm...@redhat.com>
Reviewed-by: John Snow
---
flat-union-inline.json covers longhand branch definition with an
invalid type value. It's redundant: longhand branch definition is
covered by flat-union-inline-invalid-dict.json, and invalid type value
is covered by nested-struct-data.json. Drop the test.
Signed-off-by: Markus Armbruster
Type names should be CamelCase. Enforce this. The only offenders are
in tests/. Fix them. Add test type-case to cover the new error.
Signed-off-by: Markus Armbruster
Message-Id: <20210323094025.3569441-15-arm...@redhat.com>
Reviewed-by: Eric Blake
[Regexp simplified, new test made more
Feature names should use '-', not '_'. Enforce this.
Signed-off-by: Markus Armbruster
Message-Id: <20210323094025.3569441-24-arm...@redhat.com>
Reviewed-by: Eric Blake
---
scripts/qapi/expr.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/qapi/expr.py
Test args-name-clash covers command parameter name clash. This
effectively covers struct member name clash as well. The next commit
will make parameter name clash impossible. Convert args-name-clash
from testing command to testing a struct, and rename it to
struct-member-name-clash.
A few old comments talk about "desired future use of defaults" and
"anonymous inline branch types". Kind of misleading since commit
87adbbffd4 "qapi: add a dictionary form for TYPE" added longhand
member definitions. Talk about that instead.
Signed-off-by: Markus Armbruster
Message-Id:
check_name_str() masks leading digits when passed enum_member=True.
Only check_enum() does. Lift the masking into check_enum().
Signed-off-by: Markus Armbruster
Message-Id: <20210323094025.3569441-10-arm...@redhat.com>
Reviewed-by: Eric Blake
---
scripts/qapi/expr.py | 23
1 - 100 of 549 matches
Mail list logo
