Re: any remaining for-6.0 issues?

2021-04-12 Thread Bin Meng
On Mon, Apr 12, 2021 at 11:33 PM Peter Maydell wrote: > > Last call to note anything we need to fix for 6.0 on > https://wiki.qemu.org/Planning/6.0#Known_issues please. > The schedule is to tag rc3 tomorrow, which I would ideally like > to be the last rc before release. After rc3 I will only be

Re: [PATCH v2 2/3] qom: move user_creatable_add_opts logic to vl.c and QAPIfy it

2021-04-12 Thread Markus Armbruster
David Hildenbrand writes: > On 12.03.21 18:35, Paolo Bonzini wrote: >> Emulators are currently using OptsVisitor (via user_creatable_add_opts) >> to parse the -object command line option. This has one extra feature, >> compared to keyval, which is automatic conversion of integers to lists >> as

Re: any remaining for-6.0 issues?

2021-04-12 Thread Markus Armbruster
Peter Maydell writes: > Last call to note anything we need to fix for 6.0 on > https://wiki.qemu.org/Planning/6.0#Known_issues please. Done for [PATCH 0/1] sphinx: qapidoc: Wrap "If" section body in a paragraph node I asked how to get it merged last week: Message-ID:

Re: [PATCH 1/1] sphinx: qapidoc: Wrap "If" section body in a paragraph node

2021-04-12 Thread Markus Armbruster
John Snow writes: > These sections need to be wrapped in a block-level element, such as > Paragraph in order for them to be rendered into Texinfo correctly. Into man, not into Texinfo. [...]

Re: [PATCH RFC RESEND v2 2/6] hw/pci: Add iommu option for pci root bus

2021-04-12 Thread Wang Xingang
Hi Eric, On 2021/4/13 1:36, Auger Eric wrote: Hi Wang, On 3/25/21 8:22 AM, Wang Xingang wrote: From: Xingang Wang This add iommu option for pci root bus, including primary bus and pxb root bus. The option is valid only if there is a virtual iommu device. Signed-off-by: Xingang Wang

Re: [PATCH 00/38] target/riscv: support packed extension v0.9.2

2021-04-12 Thread LIU Zhiwei
ping +1. On 2021/2/12 下午11:02, LIU Zhiwei wrote: This patchset implements the packed extension for RISC-V on QEMU. This patchset have passed all my direct Linux user mode cases(RV64) and bare metal cases(RV32) on X86-64 Ubuntu host machine. I will later push these test cases to my

Re: [PATCH RFC RESEND v2 1/6] hw/pci/pci_host: Add iommu property for pci host

2021-04-12 Thread Wang Xingang
Hi Eric, On 2021/4/13 1:36, Auger Eric wrote: Hi Wang, On 3/25/21 8:22 AM, Wang Xingang wrote: From: Xingang Wang The pci host iommu property is useful to check whether the iommu is enabled on the pci root bus. Signed-off-by: Xingang Wang Signed-off-by: Jiahui Cen --- hw/pci/pci.c

Re: Better alternative to strncpy in QEMU.

2021-04-12 Thread Chetan
Hello All, > I'm not sure what's the improvement over strncpy() here? Paolo, could you > elaborate? > (Note that we also have some functions like strpadcpy() in QEMU already, > which can be used in similar ways) Ok Thanks, I'll wait for Paolo to clarify if the functions are needed, if yes then

[PATCH v3 7/8] target/riscv/pmp: Remove outdated comment

2021-04-12 Thread Alistair Francis
Signed-off-by: Alistair Francis Reviewed-by: Bin Meng --- target/riscv/pmp.c | 4 1 file changed, 4 deletions(-) diff --git a/target/riscv/pmp.c b/target/riscv/pmp.c index 00f91d074f..68be893e16 100644 --- a/target/riscv/pmp.c +++ b/target/riscv/pmp.c @@ -19,10 +19,6 @@ * this program.

[PATCH v3 5/8] target/riscv: Implementation of enhanced PMP (ePMP)

2021-04-12 Thread Alistair Francis
From: Hou Weiying This commit adds support for ePMP v0.9.1. The ePMP spec can be found in: https://docs.google.com/document/d/1Mh_aiHYxemL0umN3GTTw8vsbmzHZ_nxZXgjgOUzbvc8 Signed-off-by: Hongzheng-Li Signed-off-by: Hou Weiying Signed-off-by: Myriad-Dreamin Message-Id: [ Changes by AF: -

[PATCH v3 8/8] target/riscv: Add ePMP support for the Ibex CPU

2021-04-12 Thread Alistair Francis
The physical Ibex CPU has ePMP support and it's enabled for the OpenTitan machine so let's enable ePMP support for the Ibex CPU in QEMU. Signed-off-by: Alistair Francis Reviewed-by: Bin Meng --- target/riscv/cpu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/riscv/cpu.c

[PATCH v3 3/8] target/riscv: Add the ePMP feature

2021-04-12 Thread Alistair Francis
The spec is avaliable at: https://docs.google.com/document/d/1Mh_aiHYxemL0umN3GTTw8vsbmzHZ_nxZXgjgOUzbvc8 Signed-off-by: Alistair Francis Reviewed-by: Bin Meng --- target/riscv/cpu.h | 1 + 1 file changed, 1 insertion(+) diff --git a/target/riscv/cpu.h b/target/riscv/cpu.h index

[PATCH v3 2/8] target/riscv: Define ePMP mseccfg

2021-04-12 Thread Alistair Francis
From: Hou Weiying Use address 0x390 and 0x391 for the ePMP CSRs. Signed-off-by: Hongzheng-Li Signed-off-by: Hou Weiying Signed-off-by: Myriad-Dreamin Reviewed-by: Alistair Francis Message-Id: [ Changes by AF: - Tidy up commit message ] Signed-off-by: Alistair Francis Reviewed-by: Bin

[PATCH v3 1/8] target/riscv: Fix the PMP is locked check when using TOR

2021-04-12 Thread Alistair Francis
The RISC-V spec says: if PMP entry i is locked and pmpicfg.A is set to TOR, writes to pmpaddri-1 are ignored. The current QEMU code ignores accesses to pmpaddri-1 and pmpcfgi-1 which is incorrect. Update the pmp_is_locked() function to not check the supporting fields and instead enforce

[PATCH v3 6/8] target/riscv: Add a config option for ePMP

2021-04-12 Thread Alistair Francis
From: Hou Weiying Add a config option to enable experimental support for ePMP. This is disabled by default and can be enabled with 'x-epmp=true'. Signed-off-by: Hongzheng-Li Signed-off-by: Hou Weiying Signed-off-by: Myriad-Dreamin Message-Id: Signed-off-by: Alistair Francis Reviewed-by:

[PATCH v3 4/8] target/riscv: Add ePMP CSR access functions

2021-04-12 Thread Alistair Francis
From: Hou Weiying Signed-off-by: Hongzheng-Li Signed-off-by: Hou Weiying Signed-off-by: Myriad-Dreamin Message-Id: [ Changes by AF: - Rebase on master - Fix build errors - Fix some style issues ] Signed-off-by: Alistair Francis Reviewed-by: Bin Meng --- target/riscv/cpu.h| 1

[PATCH v3 0/8] RISC-V: Add support for ePMP v0.9.1

2021-04-12 Thread Alistair Francis
This series adds support for ePMP v0.9.1 to the QEMU RISC-V target. This is based on previous patches, but has been rebased on the latest master and updated for the latest spec. The spec is avaliable at: https://docs.google.com/document/d/1Mh_aiHYxemL0umN3GTTw8vsbmzHZ_nxZXgjgOUzbvc8 This was

Re: [PATCH] aspeed: Emulate the AST2600A3

2021-04-12 Thread Joel Stanley
On Mon, 12 Apr 2021 at 22:57, Andrew Jeffery wrote: > > > > On Tue, 13 Apr 2021, at 00:57, Cédric Le Goater wrote: > > On 3/4/21 1:43 PM, Joel Stanley wrote: > > > This is the latest revision of the ASPEED 2600 SoC. > > > > Should we change all machines to use the new SoC ? > > > > I would prefer

[Bug 1922617] Re: qemu-aarch64-static "Illegal instruction" with debootstrap

2021-04-12 Thread Richard Henderson
Fix commit: 52c01ada8661 ("exec: Fix overlap of PAGE_ANON and PAGE_TARGET_1") ** Changed in: qemu Status: In Progress => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1922617

[PULL 0/2] ppc-for-6.0 queue 20210412

2021-04-12 Thread David Gibson
-20210412 for you to fetch changes up to 2b18fc794f312a91482998bae5ea6c8724200e06: spapr.c: always pulse guest IRQ in spapr_core_unplug_request() (2021-04-12 12:27:14 +1000) Ugh, sorry Peter. I meant to sent this yesterday, but apparently forgot to execute the last step to actuall send it out

[PULL 2/2] spapr.c: always pulse guest IRQ in spapr_core_unplug_request()

2021-04-12 Thread David Gibson
From: Daniel Henrique Barboza Commit 47c8c915b162 fixed a problem where multiple spapr_drc_detach() requests were breaking QEMU. The solution was to just spapr_drc_detach() once, and use spapr_drc_unplug_requested() to filter whether we already detached it or not. The commit also tied the

[PULL 1/2] spapr: rollback 'unplug timeout' for CPU hotunplugs

2021-04-12 Thread David Gibson
From: Daniel Henrique Barboza The pseries machines introduced the concept of 'unplug timeout' for CPU hotunplugs. The idea was to circunvent a deficiency in the pSeries specification (PAPR), that currently does not define a proper way for the hotunplug to fail. If the guest refuses to release

Re: [PATCH] aspeed: Emulate the AST2600A3

2021-04-12 Thread Andrew Jeffery
On Tue, 13 Apr 2021, at 00:57, Cédric Le Goater wrote: > On 3/4/21 1:43 PM, Joel Stanley wrote: > > This is the latest revision of the ASPEED 2600 SoC. > > Should we change all machines to use the new SoC ? > > I would prefer if we introduced an "ast2600-a3" Aspeed SoC, that we would > use

[PULL 11/13] esp: don't reset async_len directly in esp_select() if cancelling request

2021-04-12 Thread Mark Cave-Ayland
Instead let the SCSI layer invoke the .cancel callback itself to cancel and reset the request state. Signed-off-by: Mark Cave-Ayland Tested-by: Alexander Bulekov Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20210407195801.685-11-mark.cave-ayl...@ilande.co.uk> --- hw/scsi/esp.c | 2 +- 1

[PULL 13/13] tests/qtest: add tests for am53c974 device

2021-04-12 Thread Mark Cave-Ayland
Use the autogenerated fuzzer test cases as the basis for a set of am53c974 regression tests. Signed-off-by: Mark Cave-Ayland Tested-by: Alexander Bulekov Message-Id: <20210407195801.685-13-mark.cave-ayl...@ilande.co.uk> --- MAINTAINERS | 1 + tests/qtest/am53c974-test.c | 218

[PULL 09/13] esp: don't overflow cmdfifo in get_cmd()

2021-04-12 Thread Mark Cave-Ayland
If the guest tries to read a CDB using DMA and cmdfifo is not empty then it is possible to overflow cmdfifo. Since this can only occur by issuing deliberately incorrect instruction sequences, ensure that the maximum length of the CDB transferred to cmdfifo is limited to the available free space

[PULL 12/13] esp: ensure that do_cmd is set to zero before submitting an ESP select command

2021-04-12 Thread Mark Cave-Ayland
When a CDB has been received and is about to be submitted to the SCSI layer via one of the ESP select commands, ensure that do_cmd is set to zero before executing the command. Otherwise a guest executing 2 valid CDBs in quick sequence can invoke the SCSI .transfer_data callback again before

[PULL 06/13] esp: introduce esp_fifo_pop_buf() and use it instead of fifo8_pop_buf()

2021-04-12 Thread Mark Cave-Ayland
The const pointer returned by fifo8_pop_buf() lies directly within the array used to model the FIFO. Building with address sanitizers enabled shows that if the caller expects a minimum number of bytes present then if the FIFO is nearly full, the caller may unexpectedly access past the end of the

[PULL 08/13] esp: don't underflow cmdfifo in do_cmd()

2021-04-12 Thread Mark Cave-Ayland
If the guest tries to execute a CDB when cmdfifo is not empty before the start of the message out phase then clearing the message out phase data will cause cmdfifo to underflow due to cmdfifo_cdb_offset being larger than the amount of data within. Since this can only occur by issuing deliberately

[PULL 10/13] esp: don't overflow cmdfifo if TC is larger than the cmdfifo size

2021-04-12 Thread Mark Cave-Ayland
If a guest transfers the message out/command phase data using DMA with a TC that is larger than the cmdfifo size then the cmdfifo overflows triggering an assert. Limit the size of the transfer to the free space available in cmdfifo. Buglink: https://bugs.launchpad.net/qemu/+bug/1919036

[PULL 04/13] esp: consolidate esp_cmdfifo_push() into esp_fifo_push()

2021-04-12 Thread Mark Cave-Ayland
Each FIFO currently has its own push functions with the only difference being the capacity check. The original reason for this was that the fifo8 implementation doesn't have a formal API for retrieving the FIFO capacity, however there are multiple examples within QEMU where the capacity field is

[PULL 05/13] esp: consolidate esp_cmdfifo_pop() into esp_fifo_pop()

2021-04-12 Thread Mark Cave-Ayland
Each FIFO currently has its own pop functions with the only difference being the capacity check. The original reason for this was that the fifo8 implementation doesn't have a formal API for retrieving the FIFO capacity, however there are multiple examples within QEMU where the capacity field is

[PULL 07/13] esp: ensure cmdfifo is not empty and current_dev is non-NULL

2021-04-12 Thread Mark Cave-Ayland
When about to execute a SCSI command, ensure that cmdfifo is not empty and current_dev is non-NULL. This can happen if the guest tries to execute a TI (Transfer Information) command without issuing one of the select commands first. Buglink: https://bugs.launchpad.net/qemu/+bug/1910723 Buglink:

[PULL 00/13] qemu-sparc queue 20210412

2021-04-12 Thread Mark Cave-Ayland
The following changes since commit c1e90def01bdb8fcbdbebd9d1eaa8e4827ece620: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20210412' into staging (2021-04-12 12:12:09 +0100) are available in the Git repository at: git://github.com/mcayland/qemu.git tags/qemu-sparc

[PULL 02/13] esp: always check current_req is not NULL before use in DMA callbacks

2021-04-12 Thread Mark Cave-Ayland
After issuing a SCSI command the SCSI layer can call the SCSIBusInfo .cancel callback which resets both current_req and current_dev to NULL. If any data is left in the transfer buffer (async_len != 0) then the next TI (Transfer Information) command will attempt to reference the NULL pointer

[PULL 03/13] esp: rework write_response() to avoid using the FIFO for DMA transactions

2021-04-12 Thread Mark Cave-Ayland
The code for write_response() has always used the FIFO to store the data for the status/message in phases, even for DMA transactions. Switch to using a separate buffer that can be used directly for DMA transactions and restrict the FIFO use to the non-DMA case. Signed-off-by: Mark Cave-Ayland

[PULL 01/13] esp: fix setting of ESPState mig_version_id when launching QEMU with -S option

2021-04-12 Thread Mark Cave-Ayland
If QEMU is launched with the -S option then the ESPState mig_version_id property is left unset due to the ordering of the VMState fields in the VMStateDescription for sysbusespscsi and pciespscsi. If the VM is migrated and restored in this stopped state, the version tests in the vmstate_esp

Re: any remaining for-6.0 issues?

2021-04-12 Thread Mark Cave-Ayland
On 12/04/2021 20:40, Peter Maydell wrote: On Mon, 12 Apr 2021 at 19:44, Mark Cave-Ayland wrote: On 12/04/2021 16:32, Peter Maydell wrote: Last call to note anything we need to fix for 6.0 on https://wiki.qemu.org/Planning/6.0#Known_issues please. The schedule is to tag rc3 tomorrow, which

Re: any remaining for-6.0 issues?

2021-04-12 Thread Mark Cave-Ayland
On 12/04/2021 20:40, Peter Maydell wrote: On 12/04/2021 16:32, Peter Maydell wrote: Last call to note anything we need to fix for 6.0 on https://wiki.qemu.org/Planning/6.0#Known_issues please. The schedule is to tag rc3 tomorrow, which I would ideally like to be the last rc before release.

Re: [PATCH] target/ppc: code motion from translate_init.c.inc to gdbstub.c

2021-04-12 Thread Fabiano Rosas
"Bruno Larsen (billionai)" writes: Please send ppc patches to both qemu-devel and qemu-ppc. > As suggested by Fabiano Rosas, In these situations you can just add along with your signed-off-by: Suggested-by: Fabiano Rosas > all the code related to gdb has been moved > from

[Bug 1923497] [NEW] bios_linker_loader_add_checksum: Assertion `start_offset < file->blob->len' failed

2021-04-12 Thread Ed Davison
Public bug reported: Trying boot/start a Windows 10 VM. Worked until recently when this error started showing up. I have the following installed on Fedora 33: qemu-kvm-5.1.0-9.fc33.x86_64 This is the error: Error starting domain: internal error: process exited while connecting to monitor:

[PATCH v4 4/4] hw/i2c: add pca954x i2c-mux switch

2021-04-12 Thread Patrick Venture
The pca954x is an i2c mux, and this adds support for two variants of this device: the pca9546 and pca9548. This device is very common on BMCs to route a different channel to each PCIe i2c bus downstream from the BMC. Signed-off-by: Patrick Venture Reviewed-by: Hao Wu Reviewed-by: Havard

[PATCH v4 2/4] hw/i2c: add match method for device search

2021-04-12 Thread Patrick Venture
At the start of an i2c transaction, the i2c bus searches its list of children to identify which devices correspond to the address (or broadcast). Now the I2CSlave device has a method "match" that encapsulates the lookup behavior. This allows the behavior to be changed to support devices, such as

[PATCH v4 3/4] hw/i2c: move search to i2c_scan_bus method

2021-04-12 Thread Patrick Venture
Moves the search for matching devices on an i2c bus into a separate method. This allows for an object that owns an I2CBus can avoid duplicating this method. Tested: A BMC firmware was booted to userspace and i2c devices were detected. Signed-off-by: Patrick Venture Reviewed-by: Hao Wu ---

[PATCH v4 0/4] hw/i2c: Adds pca954x i2c mux switch device

2021-04-12 Thread Patrick Venture
The i2c mux device pca954x implements two devices: - the pca9546 and pca9548. v4: - Fixed up bug where the i2c_scan_bus wasn't parameterizing the current_devs list. - Minor consistency changes in the i2c mux pca954x. v3: - fixup comment with missing end parenthesis. - removed superfluous

[PATCH v4 1/4] hw/i2c: name I2CNode list in I2CBus

2021-04-12 Thread Patrick Venture
To enable passing the current_devs field as a parameter, we need to use a named struct type. Tested: BMC firmware with i2c devices booted to userspace. Signed-off-by: Patrick Venture Reviewed-by: Hao Wu Reviewed-by: Philippe Mathieu-Daudé --- include/hw/i2c/i2c.h | 4 +++- 1 file changed, 3

Re: any remaining for-6.0 issues?

2021-04-12 Thread Peter Maydell
On Mon, 12 Apr 2021 at 19:44, Mark Cave-Ayland wrote: > > On 12/04/2021 16:32, Peter Maydell wrote: > > > Last call to note anything we need to fix for 6.0 on > > https://wiki.qemu.org/Planning/6.0#Known_issues please. > > The schedule is to tag rc3 tomorrow, which I would ideally like > > to be

Re: [PATCH 2/2] spapr.c: always pulse guest IRQ in spapr_core_unplug_request()

2021-04-12 Thread Daniel Henrique Barboza
On 3/31/21 11:37 PM, David Gibson wrote: On Wed, Mar 31, 2021 at 09:04:37PM -0300, Daniel Henrique Barboza wrote: Commit 47c8c915b162 fixed a problem where multiple spapr_drc_detach() requests were breaking QEMU. The solution was to just spapr_drc_detach() once, and use

Re: trace_FOO_tcg bit-rotted?

2021-04-12 Thread Alex Bennée
Stefan Hajnoczi writes: > On Fri, Apr 09, 2021 at 05:29:08PM +0100, Alex Bennée wrote: >> >> Laurent Vivier writes: >> >> > Le 06/04/2021 à 18:00, Alex Bennée a écrit : >> >> Hi, >> >> >> >> It's been awhile since I last played with this but I think we are >> >> suffering from not having

[PATCH] target/ppc: code motion from translate_init.c.inc to gdbstub.c

2021-04-12 Thread Bruno Larsen (billionai)
As suggested by Fabiano Rosas, all the code related to gdb has been moved from translate_init.c.inc file to the gdbstub.c file, where it makes more sense Signed-off-by: Bruno Larsen (billionai) --- target/ppc/cpu.h| 11 ++ target/ppc/gdbstub.c| 261

Re: [PATCH v3 11/11] tests/acceptance/virtiofs_submounts.py: fix setup of SSH pubkey

2021-04-12 Thread Willian Rampazzo
On Mon, Apr 12, 2021 at 1:48 AM Cleber Rosa wrote: > > The public key argument should be a path to a file, and not the > public key data. > > Reported-by: Wainer dos Santos Moschetta > Signed-off-by: Cleber Rosa > --- > tests/acceptance/virtiofs_submounts.py | 2 +- > 1 file changed, 1

Re: any remaining for-6.0 issues?

2021-04-12 Thread Mark Cave-Ayland
On 12/04/2021 16:32, Peter Maydell wrote: Last call to note anything we need to fix for 6.0 on https://wiki.qemu.org/Planning/6.0#Known_issues please. The schedule is to tag rc3 tomorrow, which I would ideally like to be the last rc before release. After rc3 I will only be taking fixes for bugs

Re: [Virtio-fs] [PATCH] vhost-user-fs: fix features handling

2021-04-12 Thread Vivek Goyal
On Sun, Apr 11, 2021 at 09:21:54AM +0300, Anton Kuchin wrote: > > On 09/04/2021 18:56, Vivek Goyal wrote: > > On Thu, Apr 08, 2021 at 10:55:34PM +0300, Anton Kuchin wrote: > > > Make virtio-fs take into account server capabilities. > > > > > > Just returning requested features assumes they all

Re: [PATCH 0/3] mps3-an524: support memory remapping

2021-04-12 Thread Richard Henderson
On 4/12/21 6:43 AM, Peter Maydell wrote: Peter Maydell (3): hw/misc/mps2-scc: Add "QEMU interface" comment hw/misc/mps2-scc: Support using CFG0 bit 0 for remapping hw/arm/mps2-tz: Implement AN524 memory remapping via machine property Reviewed-by: Richard Henderson r~

Re: [PATCH v6 6/8] hw/isa/Kconfig: Add missing dependency VIA VT82C686 -> APM

2021-04-12 Thread Richard Henderson
On 3/9/21 12:28 PM, BALATON Zoltan wrote: From: Philippe Mathieu-Daudé TYPE_VIA_PM calls apm_init() in via_pm_realize(), so requires APM to be selected. Reported-by: BALATON Zoltan Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: BALATON Zoltan Reviewed-by: Richard Henderson r~

Re: [PATCH] tests/acceptance: Add a 'virt_kvm' test using the GICv3

2021-04-12 Thread Philippe Mathieu-Daudé
On 4/6/21 7:12 PM, Alex Bennée wrote: > > Philippe Mathieu-Daudé writes: > >> On 3/31/21 5:45 PM, Alex Bennée wrote: >>> >>> Philippe Mathieu-Daudé writes: >>> The current 'virt_kvm' test is restricted to GICv2, but can also work with a GICv3. Duplicate it but add a GICv3 test which

[PATCH] docs: Add documentation for shakti_c machine

2021-04-12 Thread Vijai Kumar K
Add documentation for Shakti C reference platform. Signed-off-by: Vijai Kumar K --- docs/system/riscv/shakti-c.rst | 82 ++ 1 file changed, 82 insertions(+) create mode 100644 docs/system/riscv/shakti-c.rst diff --git a/docs/system/riscv/shakti-c.rst

Re: [PATCH RFC RESEND v2 2/6] hw/pci: Add iommu option for pci root bus

2021-04-12 Thread Auger Eric
Hi Wang, On 3/25/21 8:22 AM, Wang Xingang wrote: > From: Xingang Wang > > This add iommu option for pci root bus, including primary bus > and pxb root bus. The option is valid only if there is a virtual > iommu device. > > Signed-off-by: Xingang Wang > Signed-off-by: Jiahui Cen same in this

Re: [PATCH RFC RESEND v2 1/6] hw/pci/pci_host: Add iommu property for pci host

2021-04-12 Thread Auger Eric
Hi Wang, On 3/25/21 8:22 AM, Wang Xingang wrote: > From: Xingang Wang > > The pci host iommu property is useful to check whether > the iommu is enabled on the pci root bus. > > Signed-off-by: Xingang Wang > Signed-off-by: Jiahui Cen > --- > hw/pci/pci.c | 18 +-

[PATCH] cutils: fix memory leak in get_relocated_path()

2021-04-12 Thread Stefano Garzarella
get_relocated_path() allocates a GString object and returns the character data (C string) to the caller without freeing the memory allocated for that object as reported by valgrind: 24 bytes in 1 blocks are definitely lost in loss record 2,805 of 6,532 at 0x4839809: malloc

Re: [PATCH v2 2/3] qom: move user_creatable_add_opts logic to vl.c and QAPIfy it

2021-04-12 Thread David Hildenbrand
On 12.03.21 18:35, Paolo Bonzini wrote: Emulators are currently using OptsVisitor (via user_creatable_add_opts) to parse the -object command line option. This has one extra feature, compared to keyval, which is automatic conversion of integers to lists as well as support for lists as repeated

Re: [PATCH] qapi/qom.json: Do not use CONFIG_VIRTIO_CRYPTO in common code

2021-04-12 Thread Kevin Wolf
Am 12.04.2021 um 18:07 hat Thomas Huth geschrieben: > The ObjectType enum and ObjectOptions are included from qapi-types-qom.h > into common code. We should not use target-specific config switches like > CONFIG_VIRTIO_CRYPTO here, since this is not defined in common code and > thus the enum will

[PATCH] qapi/qom.json: Do not use CONFIG_VIRTIO_CRYPTO in common code

2021-04-12 Thread Thomas Huth
The ObjectType enum and ObjectOptions are included from qapi-types-qom.h into common code. We should not use target-specific config switches like CONFIG_VIRTIO_CRYPTO here, since this is not defined in common code and thus the enum will look differently between common and target specific code. For

Re: [PATCH v3 09/36] block: bdrv_refresh_perms: check for parents permissions conflict

2021-04-12 Thread Alberto Garcia
On Wed 17 Mar 2021 03:35:02 PM CET, Vladimir Sementsov-Ogievskiy wrote: > Add additional check that node parents do not interfere with each > other. This should not hurt existing callers and allows in further > patch use bdrv_refresh_perms() to update a subtree of changed > BdrvChild (check that

[PATCH v2] migration: Move populate_vfio_info() into a separate file

2021-04-12 Thread Thomas Huth
The CONFIG_VFIO switch only works in target specific code. Since migration/migration.c is common code, the #ifdef does not have the intended behavior here. Move the related code to a separate file now which gets compiled via specific_ss instead. Fixes: 3710586caa ("qapi: Add VFIO devices

Re: [PULL 0/1] NBD fix for 6.0-rc3

2021-04-12 Thread Peter Maydell
On Mon, 12 Apr 2021 at 13:19, Vladimir Sementsov-Ogievskiy wrote: > > The following changes since commit 555249a59e9cdd6b58da103aba5cf3a2d45c899f: > > Merge remote-tracking branch > 'remotes/ehabkost-gl/tags/x86-next-pull-request' into staging (2021-04-10 > 16:58:56 +0100) > > are available

Re: [RFC PATCH 5/5] sockets: Support multipath TCP

2021-04-12 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Thu, Apr 08, 2021 at 08:11:59PM +0100, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > Multipath TCP allows combining multiple interfaces/routes into a single > > socket, with very little work for the

Re: [PATCH 2/4] target/ppc: added solutions for building with disable-tcg

2021-04-12 Thread Richard Henderson
On 4/11/21 10:08 PM, David Gibson wrote: Not directly related to what you're trying to accomplish here, but the whole vscr_sat thing looks really weird. I have no idea why we're splitting out the storage of VSCR[SAT] for the TCG case at all. If you wanted to clean that up as a preliminary, I'd

Re: [PATCH v3] libqtest: refuse QTEST_QEMU_BINARY=qemu-kvm

2021-04-12 Thread Emanuele Giuseppe Esposito
On 12/04/2021 16:30, Stefan Hajnoczi wrote: Some downstreams rename the QEMU binary to "qemu-kvm". This breaks qtest_get_arch(), which attempts to parse the target architecture from the QTEST_QEMU_BINARY environment variable. Print an error instead of returning the architecture "kvm". Things

any remaining for-6.0 issues?

2021-04-12 Thread Peter Maydell
Last call to note anything we need to fix for 6.0 on https://wiki.qemu.org/Planning/6.0#Known_issues please. The schedule is to tag rc3 tomorrow, which I would ideally like to be the last rc before release. After rc3 I will only be taking fixes for bugs which are absolutely critical... thanks --

Re: [PATCH 2/2] Support monitor chardev hotswap with QMP

2021-04-12 Thread Pankaj Gupta
Hi Li, > For some scenarios, it needs to hot-add a monitor device. > But QEMU doesn't support hotplug yet. It also works by adding > a monitor with null backend by default and then change its > backend to socket by QMP command "chardev-change". > > So this patch is to support monitor chardev

Re: [PATCH] aspeed: Emulate the AST2600A3

2021-04-12 Thread Cédric Le Goater
On 3/4/21 1:43 PM, Joel Stanley wrote: > This is the latest revision of the ASPEED 2600 SoC. Should we change all machines to use the new SoC ? I would prefer if we introduced an "ast2600-a3" Aspeed SoC, that we would use for the newer rainier machine, and leave the tacoma-bmc and ast2600-evb

[Bug 1759522] Re: windows qemu-img create vpc/vhdx error

2021-04-12 Thread Albert Kao
I noticed the cloudbase version does NOT have this issue. https://cloudbase.it/qemu-img-windows/ The weilnetz version DOES have this issue. https://qemu.weilnetz.de/w64/ So, I found the source code for each release and compared them. cloudbase https://repo.or.cz/w/qemu/ar7.git/ weilnetz

Re: [PATCH v3 11/11] tests/acceptance/virtiofs_submounts.py: fix setup of SSH pubkey

2021-04-12 Thread Wainer dos Santos Moschetta
On 4/12/21 1:46 AM, Cleber Rosa wrote: The public key argument should be a path to a file, and not the public key data. Reported-by: Wainer dos Santos Moschetta Signed-off-by: Cleber Rosa --- tests/acceptance/virtiofs_submounts.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH v3 05/36] block: BdrvChildClass: add .get_parent_aio_context handler

2021-04-12 Thread Alberto Garcia
On Wed 17 Mar 2021 03:34:58 PM CET, Vladimir Sementsov-Ogievskiy wrote: > Add new handler to get aio context and implement it in all child > classes. Add corresponding public interface to be used soon. > > Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Alberto Garcia Berto

Re: trace_FOO_tcg bit-rotted?

2021-04-12 Thread Stefan Hajnoczi
On Fri, Apr 09, 2021 at 05:29:08PM +0100, Alex Bennée wrote: > > Laurent Vivier writes: > > > Le 06/04/2021 à 18:00, Alex Bennée a écrit : > >> Hi, > >> > >> It's been awhile since I last played with this but I think we are > >> suffering from not having some test cases for tracing code > >>

Re: [RFC PATCH 0/5] mptcp support

2021-04-12 Thread Daniel P . Berrangé
On Mon, Apr 12, 2021 at 03:51:10PM +0100, Dr. David Alan Gilbert wrote: > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > On Thu, Apr 08, 2021 at 08:11:54PM +0100, Dr. David Alan Gilbert (git) > > wrote: > > > From: "Dr. David Alan Gilbert" > > > > > > Hi, > > > This RFC set adds

Re: [PATCH v4 for-6.0 12/12] tests/qtest: add tests for am53c974 device

2021-04-12 Thread Peter Maydell
On Wed, 7 Apr 2021 at 21:16, Mark Cave-Ayland wrote: > > Use the autogenerated fuzzer test cases as the basis for a set of am53c974 > regression tests. > > Signed-off-by: Mark Cave-Ayland > Tested-by: Alexander Bulekov > --- > MAINTAINERS | 1 + > tests/qtest/am53c974-test.c

Re: [RFC PATCH 0/5] mptcp support

2021-04-12 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Thu, Apr 08, 2021 at 08:11:54PM +0100, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > Hi, > > This RFC set adds support for multipath TCP (mptcp), > > in particular on the migration path - but should be

Re: [PULL 0/5] target-arm queue

2021-04-12 Thread Peter Maydell
021-04-10 > 16:58:56 +0100) > > are available in the Git repository at: > > https://git.linaro.org/people/pmaydell/qemu-arm.git > tags/pull-target-arm-20210412 > > for you to fetch changes up to 52c01ada86611136e3122dd139788dbcbc292d86: > > exec: Fix overlap of PAG

Re: [PATCH 0/3] mps3-an524: support memory remapping

2021-04-12 Thread Peter Maydell
On Mon, 12 Apr 2021 at 15:37, Philippe Mathieu-Daudé wrote: > > Hi Peter, > > On 4/12/21 3:43 PM, Peter Maydell wrote: > > The AN524 FPGA image supports two memory maps, which differ > > in where the QSPI and BRAM are. In the default map, the BRAM > > is at 0x_, and the QSPI at

Re: [RFC PATCH 0/5] mptcp support

2021-04-12 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Fri, Apr 09, 2021 at 10:34:30AM +0100, Daniel P. Berrangé wrote: > > On Thu, Apr 08, 2021 at 08:11:54PM +0100, Dr. David Alan Gilbert (git) > > wrote: > > > From: "Dr. David Alan Gilbert" > > > I had a quick go at trying NBD as well, but I

Re: [PATCH v3] libqtest: refuse QTEST_QEMU_BINARY=qemu-kvm

2021-04-12 Thread Thomas Huth
On 12/04/2021 16.30, Stefan Hajnoczi wrote: Some downstreams rename the QEMU binary to "qemu-kvm". This breaks qtest_get_arch(), which attempts to parse the target architecture from the QTEST_QEMU_BINARY environment variable. Print an error instead of returning the architecture "kvm". Things

Re: [PATCH v2] libqtest: refuse QTEST_QEMU_BINARY=qemu-kvm

2021-04-12 Thread Thomas Huth
On 12/04/2021 16.35, Thomas Huth wrote: On 12/04/2021 16.21, Stefan Hajnoczi wrote: On Mon, Apr 12, 2021 at 11:35:40AM +0200, Thomas Huth wrote: On 12/04/2021 11.18, Stefan Hajnoczi wrote: Some downstreams rename the QEMU binary to "qemu-kvm". This breaks qtest_get_arch(), which attempts to

Re: [PATCH 2/2] docs/devel/qgraph: add troubleshooting information

2021-04-12 Thread Stefan Hajnoczi
On Sat, Apr 10, 2021 at 06:41:03AM +0200, Thomas Huth wrote: > On 09/04/2021 21.01, Stefan Hajnoczi wrote: > > It can be tricky to troubleshoot qos-test when a test won't execute. Add > > an explanation of how to trace qgraph node connectivity and find which > > node has the problem. > > > > Cc:

Re: [PATCH 0/3] mps3-an524: support memory remapping

2021-04-12 Thread Philippe Mathieu-Daudé
Hi Peter, On 4/12/21 3:43 PM, Peter Maydell wrote: > The AN524 FPGA image supports two memory maps, which differ > in where the QSPI and BRAM are. In the default map, the BRAM > is at 0x_, and the QSPI at 0x2800_. In the second > map, they are the other way around. > > In hardware,

[PATCH v2 2/2] docs/devel/qgraph: add troubleshooting information

2021-04-12 Thread Stefan Hajnoczi
It can be tricky to troubleshoot qos-test when a test won't execute. Add an explanation of how to trace qgraph node connectivity and find which node has the problem. Cc: Emanuele Giuseppe Esposito Cc: Paolo Bonzini Signed-off-by: Stefan Hajnoczi --- docs/devel/qgraph.rst | 58

Re: [PATCH v2] libqtest: refuse QTEST_QEMU_BINARY=qemu-kvm

2021-04-12 Thread Thomas Huth
On 12/04/2021 16.21, Stefan Hajnoczi wrote: On Mon, Apr 12, 2021 at 11:35:40AM +0200, Thomas Huth wrote: On 12/04/2021 11.18, Stefan Hajnoczi wrote: Some downstreams rename the QEMU binary to "qemu-kvm". This breaks qtest_get_arch(), which attempts to parse the target architecture from the

[PATCH v2 1/2] libqos/qgraph: fix "UNAVAILBLE" typo

2021-04-12 Thread Stefan Hajnoczi
Cc: Emanuele Giuseppe Esposito Cc: Paolo Bonzini Signed-off-by: Stefan Hajnoczi Reviewed-by: Philippe Mathieu-Daudé --- tests/qtest/libqos/qgraph.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qtest/libqos/qgraph.c b/tests/qtest/libqos/qgraph.c index

[PATCH v2 0/2] docs/devel/qgraph: add troubleshooting information

2021-04-12 Thread Stefan Hajnoczi
v2: * Fix "will unavailable" typo [Thomas] I recently needed to troubleshoot a case where qos-test terminated immediately with no output. In other words, qos-test decided that no tests are runnable. After lots of head scratching and some help from Emanuele it turned out that the machine types

[PATCH v3] libqtest: refuse QTEST_QEMU_BINARY=qemu-kvm

2021-04-12 Thread Stefan Hajnoczi
Some downstreams rename the QEMU binary to "qemu-kvm". This breaks qtest_get_arch(), which attempts to parse the target architecture from the QTEST_QEMU_BINARY environment variable. Print an error instead of returning the architecture "kvm". Things fail in weird ways when the architecture string

Re: [PATCH 07/27] arc: TCG instruction definitions

2021-04-12 Thread Cupertino Miranda
Hi Richard, I totally understand your position with a new scripting language and the unclean code produced by the auto generated tools. In order to ease out the review process, I propose to drop the idea of the generated code and cleanup by hand all of the semfunc.c functions. What is you

Re: *** ARC port for review ***

2021-04-12 Thread Cupertino Miranda
Hi Richard, Thanks for your quick reply. For the time, ARCv3 is an under development architecture and unfortunately, for the time being, there is no public documentation available. Please notice that this should be all available once ARCv3 gets released. QEMU ARCv3 port is really an early

Re: [PATCH v3 06/36] block: drop ctx argument from bdrv_root_attach_child

2021-04-12 Thread Alberto Garcia
On Wed 17 Mar 2021 03:34:59 PM CET, Vladimir Sementsov-Ogievskiy wrote: > Passing parent aio context is redundant, as child_class and parent > opaque pointer are enough to retrieve it. Drop the argument and use new > bdrv_child_get_parent_aio_context() interface. > > Signed-off-by: Vladimir

Re: [PATCH v2] libqtest: refuse QTEST_QEMU_BINARY=qemu-kvm

2021-04-12 Thread Stefan Hajnoczi
On Mon, Apr 12, 2021 at 11:35:40AM +0200, Thomas Huth wrote: > On 12/04/2021 11.18, Stefan Hajnoczi wrote: > > Some downstreams rename the QEMU binary to "qemu-kvm". This breaks > > qtest_get_arch(), which attempts to parse the target architecture from > > the QTEST_QEMU_BINARY environment

Re: [RFC v12 12/65] target/arm: move physical address translation to cpu-mmu

2021-04-12 Thread Alex Bennée
Claudio Fontana writes: > get_phys_addr is needed for KVM too, and in turn it requires > the aa64_va_parameter* family of functions. > > Create cpu-mmu and cpu-mmu-sysemu to store these and > other mmu-related functions. > > Signed-off-by: Claudio Fontana > Reviewed-by: Richard Henderson >

RE: [PATCH 1/4] target/ppc: Code motion required to build disabling tcg

2021-04-12 Thread Fabiano Rosas
Bruno Piazera Larsen writes: >> > This commit does the necessary code motion from translate_init.c.inc >> >> For instance, I don't immediately see why these changes are necessary. I >> see that translate_init.c.inc already has some `#ifdef CONFIG_TCG`, so >> why do we need to move a bunch of

Re: [RFC PATCH 3/3] hw/arm/smmuv3: Post-load stage 1 configurations to the host

2021-04-12 Thread Kunkun Jiang
Hi Eric, On 2021/4/12 16:34, Auger Eric wrote: Hi Kunkun, On 2/19/21 10:42 AM, Kunkun Jiang wrote: In nested mode, we call the set_pasid_table() callback on each STE update to pass the guest stage 1 configuration to the host and apply it at physical level. In the case of live migration, we

Re: [RFC PATCH 2/3] vfio: Add vfio_prereg_listener_log_sync in nested stage

2021-04-12 Thread Kunkun Jiang
Hi Eric, On 2021/4/8 21:56, Auger Eric wrote: Hi Kunkun, On 2/19/21 10:42 AM, Kunkun Jiang wrote: On Intel, the DMA mapped through the host single stage. Instead we set up the stage 2 and stage 1 separately in nested mode as there is no "Caching Mode". You need to rewrite the above

Re: [RFC PATCH 0/3] Add migration support for VFIO PCI devices in SMMUv3 nested stage mode

2021-04-12 Thread Kunkun Jiang
Hi Eric, On 2021/4/12 16:40, Auger Eric wrote: Hi Kunkun, On 2/19/21 10:42 AM, Kunkun Jiang wrote: Hi all, Since the SMMUv3's nested translation stages[1] has been introduced by Eric, we need to pay attention to the migration of VFIO PCI devices in SMMUv3 nested stage mode. At present, it

  1   2   >