[PULL 07/17] numa: Make all callbacks of ram block notifiers optional

2021-05-11 Thread Dr. David Alan Gilbert (git)
From: David Hildenbrand Let's make add/remove optional. We want to introduce a RAM block notifier for RAM migration that is only interested in resize events. Reviewed-by: Peter Xu Signed-off-by: David Hildenbrand Message-Id: <20210429112708.12291-4-da...@redhat.com> Signed-off-by: Dr. David

[PULL 13/17] migration/multifd: Print used_length of memory block

2021-05-11 Thread Dr. David Alan Gilbert (git)
From: David Hildenbrand We actually want to print the used_length, against which we check. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: David Hildenbrand Message-Id: <20210429112708.12291-10-da...@redhat.com> Signed-off-by: Dr. David Alan Gilbert --- migration/multifd.c | 2 +- 1 file

[PULL 10/17] migration/ram: Discard RAM when growing RAM blocks after ram_postcopy_incoming_init()

2021-05-11 Thread Dr. David Alan Gilbert (git)
From: David Hildenbrand In case we grow our RAM after ram_postcopy_incoming_init() (e.g., when synchronizing the RAM block state with the migration source), the resized part would not get discarded. Let's perform that when being notified about a resize while postcopy has been advised, but is not

[PULL 05/17] util: vfio-helpers: Factor out and fix processing of existing ram blocks

2021-05-11 Thread Dr. David Alan Gilbert (git)
From: David Hildenbrand Factor it out into common code when a new notifier is registered, just as done with the memory region notifier. This keeps logic about how to process existing ram blocks at a central place. Just like when adding a new ram block, we have to register the max_length. Ram

Re: [Virtio-fs] [for-6.1 v3 3/3] virtiofsd: Add support for FUSE_SYNCFS request

2021-05-11 Thread Vivek Goyal
On Tue, May 11, 2021 at 05:08:42PM +0200, Miklos Szeredi wrote: > On Tue, May 11, 2021 at 4:49 PM Vivek Goyal wrote: > > > > On Tue, May 11, 2021 at 08:54:09AM -0400, Vivek Goyal wrote: > > > On Tue, May 11, 2021 at 02:31:14PM +0200, Miklos Szeredi wrote: > > > > On Mon, May 10, 2021 at 5:55 PM

[PULL 12/17] migration/ram: Handle RAM block resizes during postcopy

2021-05-11 Thread Dr. David Alan Gilbert (git)
From: David Hildenbrand Resizing while migrating is dangerous and does not work as expected. The whole migration code works with the usable_length of a ram block and does not expect this value to change at random points in time. In the case of postcopy, relying on used_length is racy as soon as

[PULL 08/17] migration/ram: Handle RAM block resizes during precopy

2021-05-11 Thread Dr. David Alan Gilbert (git)
From: David Hildenbrand Resizing while migrating is dangerous and does not work as expected. The whole migration code works on the usable_length of ram blocks and does not expect this to change at random points in time. In the case of precopy, the ram block size must not change on the source,

[PULL 02/17] migration/ram: Reduce unnecessary rate limiting

2021-05-11 Thread Dr. David Alan Gilbert (git)
From: Kunkun Jiang When the host page is a huge page and something is sent in the current iteration, migration_rate_limit() should be executed. If not, it can be omitted. Signed-off-by: Keqian Zhu Signed-off-by: Kunkun Jiang Reviewed-by: David Edmondson Reviewed-by: Dr. David Alan Gilbert

[PULL 04/17] migration: Drop redundant query-migrate result @blocked

2021-05-11 Thread Dr. David Alan Gilbert (git)
From: Markus Armbruster Result @blocked is redundant. Unfortunately, we realized this too close to the release to risk dropping it, so we deprecated it instead, in commit e11ce6c06. Since it was deprecated from the start, we can delete it without the customary grace period. Do so.

[PULL 06/17] numa: Teach ram block notifiers about resizeable ram blocks

2021-05-11 Thread Dr. David Alan Gilbert (git)
From: David Hildenbrand Ram block notifiers are currently not aware of resizes. To properly handle resizes during migration, we want to teach ram block notifiers about resizeable ram. Introduce the basic infrastructure but keep using max_size in the existing notifiers. Supply the max_size when

[PULL 03/17] migration/ram: Optimize ram_save_host_page()

2021-05-11 Thread Dr. David Alan Gilbert (git)
From: Kunkun Jiang Starting from pss->page, ram_save_host_page() will check every page and send the dirty pages up to the end of the current host page or the boundary of used_length of the block. If the host page size is a huge page, the step "check" will take a lot of time. It will improve

[PULL 01/17] migrate/ram: remove "ram_bulk_stage" and "fpo_enabled"

2021-05-11 Thread Dr. David Alan Gilbert (git)
From: David Hildenbrand The bulk stage is kind of weird: migration_bitmap_find_dirty() will indicate a dirty page, however, ram_save_host_page() will never save it, as migration_bitmap_clear_dirty() detects that it is not dirty. We already fill the bitmap in ram_list_init_bitmaps() with ones,

[PULL 00/17] migration queue

2021-05-11 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" The following changes since commit e4f3ede95ce813d5705c65e1c0e1c80c70739ebb: Merge remote-tracking branch 'remotes/kraxel/tags/usb-20210505-pull-request' into staging (2021-05-10 19:55:06 +0100) are available in the Git repository at:

[PULL 11/17] migration/ram: Simplify host page handling in ram_load_postcopy()

2021-05-11 Thread Dr. David Alan Gilbert (git)
From: David Hildenbrand Add two new helper functions. This will come in come handy once we want to handle ram block resizes while postcopy is active. Note that ram_block_from_stream() will already print proper errors. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: David Hildenbrand

Re: [Virtio-fs] [for-6.1 v3 3/3] virtiofsd: Add support for FUSE_SYNCFS request

2021-05-11 Thread Miklos Szeredi
On Tue, May 11, 2021 at 4:49 PM Vivek Goyal wrote: > > On Tue, May 11, 2021 at 08:54:09AM -0400, Vivek Goyal wrote: > > On Tue, May 11, 2021 at 02:31:14PM +0200, Miklos Szeredi wrote: > > > On Mon, May 10, 2021 at 5:55 PM Greg Kurz wrote: > > > > > > > > Honor the expected behavior of syncfs()

Re: [Virtio-fs] [for-6.1 v3 3/3] virtiofsd: Add support for FUSE_SYNCFS request

2021-05-11 Thread Greg Kurz
On Tue, 11 May 2021 14:31:14 +0200 Miklos Szeredi wrote: > On Mon, May 10, 2021 at 5:55 PM Greg Kurz wrote: > > > > Honor the expected behavior of syncfs() to synchronously flush all data > > and metadata on linux systems. Simply loop on all known submounts and > > call syncfs() on them. > >

RE: [PATCH v1 08/25] gitlab: add build-user-hexagon test

2021-05-11 Thread Brian Cain
> -Original Message- > From: Brian Cain ... > > I suspect the easiest thing to do is to drop the patches again so I > > don't hold up the rest of testing/next. I can include the initial > > docker image patch but I won't enable it in configure.sh/gitlab. > > Sorry -- I sent along a patch

Re: [PULL 00/12] virtiofs queue

2021-05-11 Thread Peter Maydell
On Thu, 6 May 2021 at 20:05, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > The following changes since commit d90f154867ec0ec22fd719164b88716e8fd48672: > > Merge remote-tracking branch 'remotes/dg-gitlab/tags/ppc-for-6.1-20210504' > into staging (2021-05-05

Re: [PATCH 08/12] tests/vm: convert centos VM recipe to CentOS 8

2021-05-11 Thread Daniel P . Berrangé
On Tue, May 11, 2021 at 02:26:37PM +0100, Daniel P. Berrangé wrote: > Signed-off-by: Daniel P. Berrangé > --- > tests/vm/centos | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/tests/vm/centos b/tests/vm/centos > index efe3dbbb36..215da14c23 100755 > ---

Re: [PATCH 25/72] softfloat: Rearrange FloatParts64

2021-05-11 Thread Richard Henderson
On 5/11/21 8:57 AM, Alex Bennée wrote: +union { +/* Routines that know the structure may reference the singular name. */ +uint64_t frac; +/* + * Routines expanded with multiple structures reference "hi" and "lo". + * In this structure, the one word is

Re: vhost-user reconnection and crash recovery

2021-05-11 Thread Boeuf, Sebastien
Hi Stefan, Thanks for the explanation. So reconnection for vhost-user is not a well defined behavior, and QEMU is doing its best to retry when possible, depending on each device. The guest does not know about it, so it's never notified that the device needs to be reset. But what about the

Re: [PATCH] hw/block/nvme: re-enable NVMe PCI hotplug

2021-05-11 Thread Hannes Reinecke
On 5/11/21 3:37 PM, Klaus Jensen wrote: > On May 11 15:12, Hannes Reinecke wrote: >> On 5/11/21 2:22 PM, Klaus Jensen wrote: [ .. ] >>> The hotplug fix looks good - I'll post a series that tries to integrate >>> both. >>> >> Ta. >> >> The more I think about it, the more I think we should be

RE: [PATCH v1 08/25] gitlab: add build-user-hexagon test

2021-05-11 Thread Brian Cain
> -Original Message- > From: Alex Bennée ... > Which leads to the compiler complaining: > > hexagon-unknown-linux-musl-clang -Wno-incompatible-pointer-types - > Wno-undefined-internal -fno-unroll-loops -Wall -Werror -O0 -g -fno-strict- > aliasing -mv67 -O2 -static /home >

Re: [Virtio-fs] [for-6.1 v3 3/3] virtiofsd: Add support for FUSE_SYNCFS request

2021-05-11 Thread Vivek Goyal
On Tue, May 11, 2021 at 08:54:09AM -0400, Vivek Goyal wrote: > On Tue, May 11, 2021 at 02:31:14PM +0200, Miklos Szeredi wrote: > > On Mon, May 10, 2021 at 5:55 PM Greg Kurz wrote: > > > > > > Honor the expected behavior of syncfs() to synchronously flush all data > > > and metadata on linux

Re: [PATCH v1 08/25] gitlab: add build-user-hexagon test

2021-05-11 Thread Alex Bennée
Alex Bennée writes: > We special case this as the container with the cross compiler for the > tests takes so long to build it is manually uploaded into the > registry. Gahh, something changed underneath me with the inclusion of: commit 46ef47e2a77d1a34996964760b4a0d2b19476f25 Author:

Re: [PATCH 12/12] configure: bump min required CLang to 7.0.0 / XCode 10.2

2021-05-11 Thread Daniel P . Berrangé
On Tue, May 11, 2021 at 04:18:54PM +0200, Thomas Huth wrote: > On 11/05/2021 15.26, Daniel P. Berrangé wrote: > > Several distros have been dropped since the last time we bumped the > > minimum required CLang version. > [...] > > -# if __clang_major__ < 3 || (__clang_major__ == 3 &&

Re: [PATCH 00/12] Wave goodbye to RHEL 7 vintage distros

2021-05-11 Thread Thomas Huth
On 11/05/2021 15.26, Daniel P. Berrangé wrote: The main motivation for this series is to eliminate some backcompat logic in the crypto code only needed for RHEL-7. I take the opportunity to also bump the min required versions of glib, gcc and clang since we have dropped many distros since they

Re: [PATCH 09/12] tests/docker: drop CentOS 7 container

2021-05-11 Thread Alex Bennée
Daniel P. Berrangé writes: > It has been over two years since RHEL-8 was released, and thus per the > platform build policy, we no longer need to support RHEL-7 as a build > target. > > Signed-off-by: Daniel P. Berrangé Acked-by: Alex Bennée -- Alex Bennée

Re: [PATCH 11/12] configure: bump min required GCC to 6.3.0

2021-05-11 Thread Daniel P . Berrangé
On Tue, May 11, 2021 at 04:15:57PM +0200, Thomas Huth wrote: > On 11/05/2021 15.26, Daniel P. Berrangé wrote: > > Several distros have been dropped since the last time we bumped the > > minimum required GCC version. > > > > Per repology, currently shipping versions are: > > > >

Re: [RFC PATCH 14/15] gitlab-ci: Allow forks to use different set of jobs

2021-05-11 Thread Daniel P . Berrangé
On Tue, May 11, 2021 at 08:48:44AM +0200, Philippe Mathieu-Daudé wrote: > +Stefan/Peter > > Not sure if following up this thread or start a new one, but I got > blocked again from Gitlab, tagged as a crypto miner for running QEMU > CI... > [1] >

[PATCH v3] make sample page count configurable

2021-05-11 Thread huangy81
From: Hyman Huang(黄勇) This is v3 of introducing sample pages argument to dirty rate interface v3: - only add the "6.1" tag to the sample-pages field of DirtyRateInfo v2: - do the code clean on the basis of review by David - add qemu version to 6.1 since which the argument introduced - raise

[PATCH v3] migration/dirtyrate: make sample page count configurable

2021-05-11 Thread huangy81
From: Hyman Huang(黄勇) introduce optional sample-pages argument in calc-dirty-rate, making sample page count per GB configurable so that more accurate dirtyrate can be calculated. Signed-off-by: Hyman Huang(黄勇) --- migration/dirtyrate.c | 31 +++

Re: [PATCH 12/12] configure: bump min required CLang to 7.0.0 / XCode 10.2

2021-05-11 Thread Thomas Huth
On 11/05/2021 15.26, Daniel P. Berrangé wrote: Several distros have been dropped since the last time we bumped the minimum required CLang version. [...] -# if __clang_major__ < 3 || (__clang_major__ == 3 && __clang_minor__ < 4) -# error You need at least Clang v3.4 to compile QEMU +# if

Re: [PATCH 11/12] configure: bump min required GCC to 6.3.0

2021-05-11 Thread Thomas Huth
On 11/05/2021 15.26, Daniel P. Berrangé wrote: Several distros have been dropped since the last time we bumped the minimum required GCC version. Per repology, currently shipping versions are: RHEL-8: 8.3.1 Debian Stretch: 6.3.0 Debian Buster: 8.3.0 openSUSE Leap

Re: [PATCH 09/12] tests/docker: drop CentOS 7 container

2021-05-11 Thread Thomas Huth
On 11/05/2021 15.26, Daniel P. Berrangé wrote: It has been over two years since RHEL-8 was released, and thus per the platform build policy, we no longer need to support RHEL-7 as a build target. Signed-off-by: Daniel P. Berrangé --- .gitlab-ci.d/containers.yml | 5 ---

Re: [PATCH 10/12] bump min required glib version to 2.50

2021-05-11 Thread Thomas Huth
On 11/05/2021 15.26, Daniel P. Berrangé wrote: The glib version was not previously constrained by RHEL-7 since it rebases fairly often. Instead SLES 12 and Ubuntu 16.04 were the constraints in 00f2cfbbec63fb6f5a7789797a62ccedd22466ea. Both of these are old enough that they are outside our

Re: [PATCH 06/12] crypto: bump min gnutls to 3.5.8, dropping RHEL-7 support

2021-05-11 Thread Thomas Huth
On 11/05/2021 15.26, Daniel P. Berrangé wrote: It has been over two years since RHEL-8 was released, and thus per the platform build policy, we no longer need to support RHEL-7 as a build target. This lets us increment the minimum required gnutls version Per repology, current shipping versions

Re: [PATCH 05/12] crypto: bump min gcrypt to 1.7.6, dropping RHEL-7 support

2021-05-11 Thread Thomas Huth
On 11/05/2021 15.26, Daniel P. Berrangé wrote: It has been over two years since RHEL-8 was released, and thus per the platform build policy, we no longer need to support RHEL-7 as a build target. This lets us increment the minimum required gcrypt version and assume that HMAC is always supported

Re: [PATCH 0/6] coroutine: new sleep/wake API

2021-05-11 Thread Stefan Hajnoczi
On Mon, May 03, 2021 at 01:25:44PM +0200, Paolo Bonzini wrote: > This is a revamp of the qemu_co_sleep* API that makes it easier to > extend the API: the state that is needed to wake up a coroutine is now > part of the public API instead of hidden behind a pointer-to-pointer; > the API is made

Re: [PATCH 01/12] gitlab: move linux user build job from CentOS 7 to CentOS 8

2021-05-11 Thread Daniel P . Berrangé
On Tue, May 11, 2021 at 03:54:26PM +0200, Thomas Huth wrote: > On 11/05/2021 15.26, Daniel P. Berrangé wrote: > > It has been over two years since RHEL-8 was released, and thus per the > > platform build policy, we no longer need to support RHEL-7 as a build > > target. > > > > Signed-off-by:

Re: [Question] Indefinitely block in the host when remove the PF driver

2021-05-11 Thread Yicong Yang
[ +qemu-devel ] On 2021/4/30 22:29, Alex Williamson wrote: > On Fri, 30 Apr 2021 15:57:47 +0800 > Yicong Yang wrote: > >> When I try to remove the PF driver in the host, the process will be blocked >> if the related VF of the device is added in the Qemu as an iEP. >> >> here's what I got in the

Re: [RFC PATCH 14/15] gitlab-ci: Allow forks to use different set of jobs

2021-05-11 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > +Stefan/Peter > > On 4/19/21 12:59 PM, Thomas Huth wrote: >> On 19/04/2021 12.51, Daniel P. Berrangé wrote: >>> On Mon, Apr 19, 2021 at 12:48:25PM +0200, Thomas Huth wrote: On 19/04/2021 12.36, Daniel P. Berrangé wrote: > On Mon, Apr 19, 2021 at

Re: [PATCH 04/12] crypto: drop back compatibility typedefs for nettle

2021-05-11 Thread Thomas Huth
On 11/05/2021 15.26, Daniel P. Berrangé wrote: Now that we only support modern nettle, we don't need to have local typedefs to mask the real nettle types. Signed-off-by: Daniel P. Berrangé --- crypto/cipher-nettle.c.inc | 60 -- crypto/hash-nettle.c

Re: [PATCH 03/12] crypto: bump min nettle to 3.3, dropping RHEL-7 support

2021-05-11 Thread Thomas Huth
On 11/05/2021 15.26, Daniel P. Berrangé wrote: It has been over two years since RHEL-8 was released, and thus per the platform build policy, we no longer need to support RHEL-7 as a build target. This lets us increment the minimum required nettle version and drop a lot of backwards compatibility

Re: [PATCH 02/12] patchew: move quick build job from CentOS 7 to CentOS 8 container

2021-05-11 Thread Thomas Huth
On 11/05/2021 15.26, Daniel P. Berrangé wrote: It has been over two years since RHEL-8 was released, and thus per the platform build policy, we no longer need to support RHEL-7 as a build target. Signed-off-by: Daniel P. Berrangé --- .patchew.yml | 6 +++--- 1 file changed, 3 insertions(+),

Re: [PATCH 25/72] softfloat: Rearrange FloatParts64

2021-05-11 Thread Alex Bennée
Richard Henderson writes: > Shuffle the fraction to the end, otherwise sort by size. > Add frac_hi and frac_lo members to alias frac. > > Signed-off-by: Richard Henderson > --- > fpu/softfloat.c | 13 +++-- > 1 file changed, 11 insertions(+), 2 deletions(-) > > diff --git

Re: [PATCH 24/72] softfloat: Use pointers with parts_silence_nan

2021-05-11 Thread Alex Bennée
Richard Henderson writes: > At the same time, rename to parts64_silence_nan, split out > parts_silence_nan_frac, and define a macro for parts_silence_nan. Reviewed-by: Alex Bennée -- Alex Bennée

Re: [RFC PATCH 14/15] gitlab-ci: Allow forks to use different set of jobs

2021-05-11 Thread Stefan Hajnoczi
On Tue, May 11, 2021 at 08:48:44AM +0200, Philippe Mathieu-Daudé wrote: > +Stefan/Peter > > On 4/19/21 12:59 PM, Thomas Huth wrote: > > On 19/04/2021 12.51, Daniel P. Berrangé wrote: > >> On Mon, Apr 19, 2021 at 12:48:25PM +0200, Thomas Huth wrote: > >>> On 19/04/2021 12.36, Daniel P. Berrangé

Re: [PATCH 23/72] softfloat: Use pointers with ftype_round_pack_canonical

2021-05-11 Thread Alex Bennée
Richard Henderson writes: > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée -- Alex Bennée

Re: [PATCH 22/72] softfloat: Use pointers with ftype_unpack_canonical

2021-05-11 Thread Alex Bennée
Richard Henderson writes: > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée -- Alex Bennée

Re: [PATCH 01/12] gitlab: move linux user build job from CentOS 7 to CentOS 8

2021-05-11 Thread Thomas Huth
On 11/05/2021 15.26, Daniel P. Berrangé wrote: It has been over two years since RHEL-8 was released, and thus per the platform build policy, we no longer need to support RHEL-7 as a build target. Signed-off-by: Daniel P. Berrangé --- .gitlab-ci.yml | 6 +++---

[Bug 1896298] Re: memory leak

2021-05-11 Thread Thomas Huth
** Tags added: tcg -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1896298 Title: memory leak Status in QEMU: Confirmed Bug description: qemu trunk as of today leaks memory FAST when freedos'

Re: [PATCH] hw/block/nvme: re-enable NVMe PCI hotplug

2021-05-11 Thread Klaus Jensen
On May 11 15:12, Hannes Reinecke wrote: On 5/11/21 2:22 PM, Klaus Jensen wrote: On May 11 09:35, Hannes Reinecke wrote: Ever since commit e570768566 ("hw/block/nvme: support for shared namespace in subsystem") NVMe PCI hotplug is broken, as the PCI hotplug infrastructure will only work for the

[Bug 1897481] Re: qemu crashes with VGA pass-through, e-GPU, nvidia 1060

2021-05-11 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting the bug state to "Incomplete" now. If the bug has already been fixed in the latest upstream version of QEMU, then

[vhost-user] Expectations around reconnection

2021-05-11 Thread Boeuf, Sebastien
Hi All, In the context of vhost-user, I was wondering how a reconnection should be handled from the VMM perspective? In particular, I'm looking at the OVS-DPDK use case using the client mode (meaning QEMU acts as the server), and I'd like to understand what QEMU does to handle this. Upon

[PATCH 12/12] configure: bump min required CLang to 7.0.0 / XCode 10.2

2021-05-11 Thread Daniel P . Berrangé
Several distros have been dropped since the last time we bumped the minimum required CLang version. Per repology, currently shipping versions are: RHEL-8: 10.0.1 Debian Stretch: 7.0.1 Debian Buster: 7.0.1 openSUSE Leap 15.2: 9.0.1 Ubuntu LTS 18.04: 10.0.0 Ubuntu

[PATCH 11/12] configure: bump min required GCC to 6.3.0

2021-05-11 Thread Daniel P . Berrangé
Several distros have been dropped since the last time we bumped the minimum required GCC version. Per repology, currently shipping versions are: RHEL-8: 8.3.1 Debian Stretch: 6.3.0 Debian Buster: 8.3.0 openSUSE Leap 15.2: 7.5.0 Ubuntu LTS 18.04: 7.5.0 Ubuntu LTS

[PATCH 08/12] tests/vm: convert centos VM recipe to CentOS 8

2021-05-11 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- tests/vm/centos | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/vm/centos b/tests/vm/centos index efe3dbbb36..215da14c23 100755 --- a/tests/vm/centos +++ b/tests/vm/centos @@ -26,13 +26,13 @@ class CentosVM(basevm.BaseVM):

[PATCH 10/12] bump min required glib version to 2.50

2021-05-11 Thread Daniel P . Berrangé
The glib version was not previously constrained by RHEL-7 since it rebases fairly often. Instead SLES 12 and Ubuntu 16.04 were the constraints in 00f2cfbbec63fb6f5a7789797a62ccedd22466ea. Both of these are old enough that they are outside our platform support matrix now. Per repology, current

[PATCH 06/12] crypto: bump min gnutls to 3.5.8, dropping RHEL-7 support

2021-05-11 Thread Daniel P . Berrangé
It has been over two years since RHEL-8 was released, and thus per the platform build policy, we no longer need to support RHEL-7 as a build target. This lets us increment the minimum required gnutls version Per repology, current shipping versions are: RHEL-8: 3.6.14 Debian

[PATCH 09/12] tests/docker: drop CentOS 7 container

2021-05-11 Thread Daniel P . Berrangé
It has been over two years since RHEL-8 was released, and thus per the platform build policy, we no longer need to support RHEL-7 as a build target. Signed-off-by: Daniel P. Berrangé --- .gitlab-ci.d/containers.yml | 5 --- tests/docker/dockerfiles/centos7.docker | 43

[PATCH 07/12] crypto: drop used conditional check

2021-05-11 Thread Daniel P . Berrangé
The condition being tested has never been set since the day the code was first introduced. Signed-off-by: Daniel P. Berrangé --- crypto/tlscredsx509.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/crypto/tlscredsx509.c b/crypto/tlscredsx509.c index bc503bab55..d9d6f4421e 100644 ---

[PATCH 03/12] crypto: bump min nettle to 3.3, dropping RHEL-7 support

2021-05-11 Thread Daniel P . Berrangé
It has been over two years since RHEL-8 was released, and thus per the platform build policy, we no longer need to support RHEL-7 as a build target. This lets us increment the minimum required nettle version and drop a lot of backwards compatibility code for 2.x series of nettle. Per repology,

[PATCH 04/12] crypto: drop back compatibility typedefs for nettle

2021-05-11 Thread Daniel P . Berrangé
Now that we only support modern nettle, we don't need to have local typedefs to mask the real nettle types. Signed-off-by: Daniel P. Berrangé --- crypto/cipher-nettle.c.inc | 60 -- crypto/hash-nettle.c | 6 ++-- crypto/hmac-nettle.c | 8 ++---

[PATCH 05/12] crypto: bump min gcrypt to 1.7.6, dropping RHEL-7 support

2021-05-11 Thread Daniel P . Berrangé
It has been over two years since RHEL-8 was released, and thus per the platform build policy, we no longer need to support RHEL-7 as a build target. This lets us increment the minimum required gcrypt version and assume that HMAC is always supported Per repology, current shipping versions are:

[PATCH 02/12] patchew: move quick build job from CentOS 7 to CentOS 8 container

2021-05-11 Thread Daniel P . Berrangé
It has been over two years since RHEL-8 was released, and thus per the platform build policy, we no longer need to support RHEL-7 as a build target. Signed-off-by: Daniel P. Berrangé --- .patchew.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.patchew.yml

[PATCH 00/12] Wave goodbye to RHEL 7 vintage distros

2021-05-11 Thread Daniel P . Berrangé
The main motivation for this series is to eliminate some backcompat logic in the crypto code only needed for RHEL-7. I take the opportunity to also bump the min required versions of glib, gcc and clang since we have dropped many distros since they were last bumped. There are possibly some more

[PATCH 01/12] gitlab: move linux user build job from CentOS 7 to CentOS 8

2021-05-11 Thread Daniel P . Berrangé
It has been over two years since RHEL-8 was released, and thus per the platform build policy, we no longer need to support RHEL-7 as a build target. Signed-off-by: Daniel P. Berrangé --- .gitlab-ci.yml | 6 +++--- tests/docker/dockerfiles/centos8.docker | 1 + 2 files

Re: [PATCH] hw/block/nvme: re-enable NVMe PCI hotplug

2021-05-11 Thread Hannes Reinecke
On 5/11/21 2:22 PM, Klaus Jensen wrote: > On May 11 09:35, Hannes Reinecke wrote: >> Ever since commit e570768566 ("hw/block/nvme: support for shared >> namespace in subsystem") NVMe PCI hotplug is broken, as the PCI >> hotplug infrastructure will only work for the nvme devices (which >> are PCI

Re: [PATCH v2 0/6] hw/southbridge: QOM'ify vt82c686 as VT82C686B_SOUTHBRIDGE

2021-05-11 Thread BALATON Zoltan
On Tue, 11 May 2021, Philippe Mathieu-Daudé wrote: Hi Zoltan, On 5/11/21 1:28 PM, BALATON Zoltan wrote: On Tue, 11 May 2021, Philippe Mathieu-Daudé wrote: The motivation behind this series is to remove the isa_get_irq(NULL) call to simplify the ISA generic model. Since v1: - rebased on top

Re: [PATCH 1/2] Consistent function names for sifive uart read and write function

2021-05-11 Thread Bin Meng
Hi Lukas, On Wed, May 5, 2021 at 12:49 AM Lukas Jünger wrote: > While we are here, could we make other functions sifive_ prefixed? Also the commit title should include a tag of "hw/char: sifive_uart" > Signed-off-by: Lukas Jünger > --- > hw/char/sifive_uart.c | 14 +++--- > 1 file

Re: [PATCH v6 18/82] target/arm: Implement SVE2 complex integer add

2021-05-11 Thread Peter Maydell
On Fri, 30 Apr 2021 at 21:43, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > v2: Fix subtraction ordering (laurent desnogues). > --- > target/arm/helper-sve.h| 10 + > target/arm/sve.decode | 9 > target/arm/sve_helper.c| 42

Re: [PATCH v6 17/82] target/arm: Implement SVE2 bitwise permute

2021-05-11 Thread Peter Maydell
On Fri, 30 Apr 2021 at 21:40, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/cpu.h | 5 +++ > target/arm/helper-sve.h| 15 > target/arm/sve.decode | 6 > target/arm/sve_helper.c| 73 ++ >

Re: [Virtio-fs] [for-6.1 v3 3/3] virtiofsd: Add support for FUSE_SYNCFS request

2021-05-11 Thread Vivek Goyal
On Tue, May 11, 2021 at 02:31:14PM +0200, Miklos Szeredi wrote: > On Mon, May 10, 2021 at 5:55 PM Greg Kurz wrote: > > > > Honor the expected behavior of syncfs() to synchronously flush all data > > and metadata on linux systems. Simply loop on all known submounts and > > call syncfs() on them. >

[Bug 1901532] Re: Assertion failure `mr != NULL' failed through usb-ehci

2021-05-11 Thread Thomas Huth
Can you still reproduce this with QEMU v6.0 ? For me, qemu now does not crash anymore, so I assume this might have been fixed within the past months? ** Changed in: qemu Status: Confirmed => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml,

vhost-user reconnection and crash recovery

2021-05-11 Thread Stefan Hajnoczi
Hi Sebastien, On #virtio-fs IRC you asked: I have a vhost-user question regarding disconnection/reconnection. How should this be handled? Let's say the vhost-user backend disconnects, and reconnects later on, does QEMU reset the virtio device by notifying the guest? Or does it simply

Re: [PATCH v6 16/82] target/arm: Implement SVE2 bitwise exclusive-or interleaved

2021-05-11 Thread Peter Maydell
On Fri, 30 Apr 2021 at 21:35, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/helper-sve.h| 5 + > target/arm/sve.decode | 5 + > target/arm/sve_helper.c| 20 > target/arm/translate-sve.c | 19 +++ > 4

Re: [PATCH v6 15/82] target/arm: Implement SVE2 bitwise shift left long

2021-05-11 Thread Peter Maydell
On Fri, 30 Apr 2021 at 21:41, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/helper-sve.h| 8 ++ > target/arm/sve.decode | 8 ++ > target/arm/sve_helper.c| 26 ++ > target/arm/translate-sve.c | 159 + >

[Bug 1902306] Re: Allow setting usb storage device ID parameters

2021-05-11 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting the bug state to "Incomplete" now. If the bug has already been fixed in the latest upstream version of QEMU, then

Re: [PATCH v6 14/82] target/arm: Implement PMULLB and PMULLT

2021-05-11 Thread Peter Maydell
On Fri, 30 Apr 2021 at 21:34, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/cpu.h | 10 ++ > target/arm/helper-sve.h| 1 + > target/arm/sve.decode | 2 ++ > target/arm/translate-sve.c | 22 ++ >

Re: [Virtio-fs] [for-6.1 v3 3/3] virtiofsd: Add support for FUSE_SYNCFS request

2021-05-11 Thread Miklos Szeredi
On Mon, May 10, 2021 at 5:55 PM Greg Kurz wrote: > > Honor the expected behavior of syncfs() to synchronously flush all data > and metadata on linux systems. Simply loop on all known submounts and > call syncfs() on them. Why not pass the submount's root to the server, so it can do just one

Re: [PATCH 4/6] progressmeter: protect with a mutex

2021-05-11 Thread Paolo Bonzini
On 10/05/21 13:28, Vladimir Sementsov-Ogievskiy wrote: Could we instead add a c file and add the structure private? Then we'll have progress_new() and progress_free() APIs instead. This way, it would be a lot simpler to control that nobady use structure fields directly. I don't know...

Re: [PATCH 2/2] QOMify sifive_uart model

2021-05-11 Thread Philippe Mathieu-Daudé
Hi Lukas, On 5/4/21 5:34 PM, Lukas Jünger wrote: > Signed-off-by: Lukas Jünger > --- > include/hw/char/sifive_uart.h | 6 +-- > hw/char/sifive_uart.c | 72 ++- > 2 files changed, 65 insertions(+), 13 deletions(-) > +static void

Re: [PATCH] hw/block/nvme: re-enable NVMe PCI hotplug

2021-05-11 Thread Klaus Jensen
On May 11 09:35, Hannes Reinecke wrote: Ever since commit e570768566 ("hw/block/nvme: support for shared namespace in subsystem") NVMe PCI hotplug is broken, as the PCI hotplug infrastructure will only work for the nvme devices (which are PCI devices), but not for any attached namespaces. So

Re: [PATCH v6 13/82] target/arm: Implement SVE2 integer multiply long

2021-05-11 Thread Peter Maydell
On Fri, 30 Apr 2021 at 21:41, Richard Henderson wrote: > > Exclude PMULL from this category for the moment. > > Signed-off-by: Richard Henderson > --- > target/arm/helper-sve.h| 15 +++ > target/arm/sve.decode | 9 + > target/arm/sve_helper.c| 31

Re: [PATCH v2 0/6] hw/southbridge: QOM'ify vt82c686 as VT82C686B_SOUTHBRIDGE

2021-05-11 Thread Philippe Mathieu-Daudé
Hi Zoltan, On 5/11/21 1:28 PM, BALATON Zoltan wrote: > On Tue, 11 May 2021, Philippe Mathieu-Daudé wrote: >> The motivation behind this series is to remove the >> isa_get_irq(NULL) call to simplify the ISA generic model. >> >> Since v1: >> - rebased on top of

Re: [PULL 0/7] s390x update

2021-05-11 Thread Cornelia Huck
On Tue, 11 May 2021 13:02:08 +0100 Peter Maydell wrote: > On Thu, 6 May 2021 at 16:44, Cornelia Huck wrote: > > > > The following changes since commit d45a5270d075ea589f0b0ddcf963a5fea1f500ac: > > > > Merge remote-tracking branch > > 'remotes/vivier2/tags/trivial-branch-for-6.1-pull-request'

Re: [PULL 0/7] s390x update

2021-05-11 Thread Peter Maydell
On Thu, 6 May 2021 at 16:44, Cornelia Huck wrote: > > The following changes since commit d45a5270d075ea589f0b0ddcf963a5fea1f500ac: > > Merge remote-tracking branch > 'remotes/vivier2/tags/trivial-branch-for-6.1-pull-request' into staging > (2021-05-05 13:52:00 +0100) > > are available in the

Re: [PATCH v3 14/20] virtio-gpu: Add initial definitions for explict flush feature

2021-05-11 Thread Gerd Hoffmann
On Tue, May 11, 2021 at 01:08:12AM -0700, Vivek Kasireddy wrote: > Add the property bit, conf flag and other relevant declarations > associated with this feature. I think this and the following patches should go to a separate series. I expect we can merge 1-13 quicky. The flush bits probably

Re: [PATCH v3 12/20] virtio-gpu: Add virtio_gpu_set_scanout_blob

2021-05-11 Thread Gerd Hoffmann
Hi, > -pixman_image_unref(res->image); > +if (res->image) { > +pixman_image_unref(res->image); > +} There is qemu_pixman_image_unref(). Like pixman_image_unref except that it also accepts (and ignores) NULL pointers. > virtio_gpu_cleanup_mapping(g, res); >

Re: [PATCH 2/2] QOMify sifive_uart model

2021-05-11 Thread Luc Michel
On 5/4/21 5:34 PM, Lukas Jünger wrote: Signed-off-by: Lukas Jünger Reviewed-by: Luc Michel --- include/hw/char/sifive_uart.h | 6 +-- hw/char/sifive_uart.c | 72 ++- 2 files changed, 65 insertions(+), 13 deletions(-) diff --git

Re: [PATCH 1/2] Consistent function names for sifive uart read and write function

2021-05-11 Thread Luc Michel
On 5/4/21 5:34 PM, Lukas Jünger wrote: Signed-off-by: Lukas Jünger Reviewed-by: Luc Michel --- hw/char/sifive_uart.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/hw/char/sifive_uart.c b/hw/char/sifive_uart.c index 3a00ba7f00..cb70374ead 100644 ---

Re: [PATCH 21/72] softfloat: Use pointers with ftype_pack_raw

2021-05-11 Thread Alex Bennée
Richard Henderson writes: > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée -- Alex Bennée

Re: [PATCH 20/72] softfloat: Use pointers with pack_raw

2021-05-11 Thread Alex Bennée
Richard Henderson writes: > At the same time, rename to pack_raw64. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée -- Alex Bennée

Re: [PATCH 19/72] softfloat: Use pointers with ftype_unpack_raw

2021-05-11 Thread Alex Bennée
Richard Henderson writes: > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée -- Alex Bennée

Re: [PATCH v2 0/6] hw/southbridge: QOM'ify vt82c686 as VT82C686B_SOUTHBRIDGE

2021-05-11 Thread BALATON Zoltan
On Tue, 11 May 2021, Philippe Mathieu-Daudé wrote: The motivation behind this series is to remove the isa_get_irq(NULL) call to simplify the ISA generic model. Since v1: - rebased on top of remotes/dg-gitlab/tags/ppc-for-6.1-20210504 I'll try to have a look at these later but some notes: The

Re: [PATCH v8] introduce vfio-user protocol specification

2021-05-11 Thread John Levon
On Tue, May 11, 2021 at 11:09:53AM +0100, Stefan Hajnoczi wrote: > > > > +* *sub-regions* is the array of Sub-Region IO FD info structures > > > > + > > > > +The reply message will additionally include at least one file > > > > descriptor in the > > > > +ancillary data. Note that more than one

Re: [PATCH v3 03/20] virtio-gpu: Add udmabuf helpers

2021-05-11 Thread Gerd Hoffmann
Hi, > +void virtio_gpu_fini_udmabuf(struct virtio_gpu_simple_resource *res) > +{ > +uint32_t size = res->width * res->height * 4; Hmm, no. We'll go use udmabufs for blob resources only, so this should not be needed. Maybe squash this with patch #8? take care, Gerd

Re: [PATCH 14/72] softfloat: Do not produce a default_nan from parts_silence_nan

2021-05-11 Thread Alex Bennée
Richard Henderson writes: > Require default_nan_mode to be set instead. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée -- Alex Bennée

[PULL v3 42/42] target/riscv: Fix the RV64H decode comment

2021-05-11 Thread Alistair Francis
BugLink: https://gitlab.com/qemu-project/qemu/-/issues/47 Signed-off-by: Alistair Francis Reviewed-by: Richard Henderson Message-id: 024ce841221c1d15c74b253512428c4baca7e4ba.1619234854.git.alistair.fran...@wdc.com --- target/riscv/insn32.decode | 2 +- 1 file changed, 1 insertion(+), 1

<    1   2   3   4   5   6   >