Re: [PATCH v3 0/9] qapi: untie 'if' conditions from C preprocessor

2021-05-12 Thread Markus Armbruster
Marc-André Lureau writes: > Hi Markus > > On Tue, May 11, 2021 at 8:53 PM Stefan Hajnoczi wrote: > >> On Thu, Apr 29, 2021 at 05:40:23PM +0400, marcandre.lur...@redhat.com >> wrote: >> > From: Marc-André Lureau >> > >> > Hi, >> > >> > This series makes the 'if' conditions less liberal, by forma

Re: [PATCH v3 0/8] block: refactor write threshold

2021-05-12 Thread Max Reitz
On 06.05.21 11:06, Vladimir Sementsov-Ogievskiy wrote: Hi all! v3: 01-04,06,07: add Max's r-b. 01: improve commit msg and comments 03: improve commit msg 05: add more comments and qemu/atomic.h include 08: new, replacement for v2:08,09 Vladimir Sementsov-Ogievskiy (8): block/write-threshold:

[PULL 19/20] bsd-user: Stop building the sparc targets

2021-05-12 Thread Warner Losh
The forked bsd-user tree doesn't really support these targets. They aren't functional at the moment anyway. Remove them from the build so that the major reorg patch series can focus on one platform (x86) before adding addition platforms once things are shuffled. This should make it easier to revie

Re: [PATCH 0/4] iotests/297: Cover tests/

2021-05-12 Thread Max Reitz
On 05.05.21 10:02, Vladimir Sementsov-Ogievskiy wrote: Hi! Kindly remind. Didn't you forget? I'm responsible for these two tests, let me know if you don't have time, and I'll resend this series :) Sorry, I forgot indeed... v2 coming right up. :) Max

Re: [PATCH v6 1/4] slirp: Advance libslirp submodule to add ipv6 host-forward support

2021-05-12 Thread Marc-André Lureau
Hi On Wed, May 12, 2021 at 8:43 PM Doug Evans wrote: > Ping. > > On Fri, May 7, 2021 at 8:46 AM Doug Evans wrote: > >> On Fri, May 7, 2021 at 8:23 AM Marc-André Lureau < >> marcandre.lur...@gmail.com> wrote: >> >>> Hi >>> >>> [...] Changes from v5: 1/4 slirp: Advance li

[PULL 13/20] bsd-user: whitespace changes

2021-05-12 Thread Warner Losh
Fix various whitespace-only issues from checkpatch: keyword space ( no space before ( on function calls spaces around operators suspect indentations (including one functions reindented) extra spaces around unary operators Reviewed-by: Richard Henderson Signed-off-by: Warner Lo

[PULL 16/20] bsd-user: style tweak: Remove #if 0'd code

2021-05-12 Thread Warner Losh
Reviewed-by: Richard Henderson Signed-off-by: Warner Losh --- bsd-user/strace.c | 8 1 file changed, 8 deletions(-) diff --git a/bsd-user/strace.c b/bsd-user/strace.c index 2c3b59caf0..be40b8a20c 100644 --- a/bsd-user/strace.c +++ b/bsd-user/strace.c @@ -128,14 +128,6 @@ static void pr

[Bug 1924738] Re: Failed to restore domain - error load load virtio-balloon:virtio

2021-05-12 Thread Thomas Huth
** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1924738 Title: Failed to restore domain - error load load virtio-balloon:virtio Status in QEMU:

[PULL 06/20] bsd-user: style tweak: move extern to header file

2021-05-12 Thread Warner Losh
extern char **environ has no standard home, so move the declaration from the .c file to a handy .h file. Since this is a standard, old-school UNIX interface dating from the 5th edition, it's not quite the same issue that the rule is supposed to protect against, though. Reviewed-by: Richard Henders

[PULL 20/20] bsd-user: rename linux_binprm to bsd_binprm

2021-05-12 Thread Warner Losh
Rename linux_binprm to bsd_binprm to reflect that we're loading BSD binaries, not ELF ones. Reviewed-by: Richard Henderson Signed-off-by: Warner Losh --- bsd-user/bsdload.c | 4 ++-- bsd-user/elfload.c | 4 ++-- bsd-user/qemu.h| 6 +++--- 3 files changed, 7 insertions(+), 7 deletions(-) di

[PULL 04/20] bsd-user: style tweak: Use preferred block comments

2021-05-12 Thread Warner Losh
Use the preferred block comment style. Reviewed-by: Richard Henderson Signed-off-by: Warner Losh --- bsd-user/main.c | 28 ++-- 1 file changed, 18 insertions(+), 10 deletions(-) diff --git a/bsd-user/main.c b/bsd-user/main.c index c342dd7829..cd1c26516b 100644 --- a/bsd

[PULL 17/20] bsd-user: style tweak: keyword space (

2021-05-12 Thread Warner Losh
Reviewed-by: Richard Henderson Signed-off-by: Warner Losh --- bsd-user/mmap.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/bsd-user/mmap.c b/bsd-user/mmap.c index 01ec808003..0ac1b92706 100644 --- a/bsd-user/mmap.c +++ b/bsd-user/mmap.c @@ -93,11 +

[PULL 11/20] bsd-user: style tweak: use {} consistently in for / if / else statements

2021-05-12 Thread Warner Losh
Fix various issues with {} not being present on if / for statements. Minor line length tweaks Move an assignment in an if out. Reviewed-by: Richard Henderson Signed-off-by: Warner Losh --- bsd-user/main.c | 66 - 1 file changed, 43 insertions(+),

[PULL 12/20] bsd-user: use qemu_strtoul in preference to strtol

2021-05-12 Thread Warner Losh
Reviewed-by: Richard Henderson Signed-off-by: Warner Losh --- bsd-user/main.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/bsd-user/main.c b/bsd-user/main.c index 0f9e6bfbc0..18f806b032 100644 --- a/bsd-user/main.c +++ b/bsd-user/main.c @@ -36,6 +36,7 @@ #inc

[PULL 18/20] bsd-user: remove target_signal.h, it's unused

2021-05-12 Thread Warner Losh
Remove the target_signal.h file. None of its contents are currently used and the bsd-user fork doesn't use them (so this reduces the diffs there). Reviewed-by: Richard Henderson Signed-off-by: Warner Losh --- bsd-user/i386/target_signal.h| 20 bsd-user/qemu.h

[PULL 10/20] bsd-user: style tweak: use {} for all if statements, format else correctly

2021-05-12 Thread Warner Losh
Reviewed-by: Richard Henderson Signed-off-by: Warner Losh --- bsd-user/qemu.h | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/bsd-user/qemu.h b/bsd-user/qemu.h index 2494d9209d..8d3767964d 100644 --- a/bsd-user/qemu.h +++ b/bsd-user/qemu.h @@ -358,16 +35

[PULL 03/20] bsd-user: style tweak: Remove #if 0'd code

2021-05-12 Thread Warner Losh
Reviewed-by: Richard Henderson Signed-off-by: Warner Losh --- bsd-user/main.c | 143 1 file changed, 143 deletions(-) diff --git a/bsd-user/main.c b/bsd-user/main.c index 5253ceb24b..c342dd7829 100644 --- a/bsd-user/main.c +++ b/bsd-user/main.c @

[PULL 08/20] bsd-user: style tweak: Use preferred block comments

2021-05-12 Thread Warner Losh
Reviewed-by: Richard Henderson Signed-off-by: Warner Losh --- bsd-user/qemu.h | 74 - 1 file changed, 43 insertions(+), 31 deletions(-) diff --git a/bsd-user/qemu.h b/bsd-user/qemu.h index de20e8329a..7f3cfa68aa 100644 --- a/bsd-user/qemu.h +++ b/

[PULL 14/20] bsd-user: style tweak: keyword space (

2021-05-12 Thread Warner Losh
Reviewed-by: Richard Henderson Signed-off-by: Warner Losh --- bsd-user/syscall.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/bsd-user/syscall.c b/bsd-user/syscall.c index 4abff796c7..7d986e9700 100644 --- a/bsd-user/syscall.c +++ b/bsd-user/syscall.c @@

[PULL 00/20] bsd-user style tweaks and start cleanup

2021-05-12 Thread Warner Losh
The following changes since commit f9a576a818044133f8564e0d243ebd97df0b3280: Merge remote-tracking branch 'remotes/dgilbert-gitlab/tags/pull-virtiofs-20210506' into staging (2021-05-11 13:03:44 +0100) are available in the Git repository at: https://gitlab.com/bsdimp/qemu.git tags/pull-bsd-

[PULL 05/20] bsd-user: Remove commented out code

2021-05-12 Thread Warner Losh
Remove dead code that's been commented out forever. Reviewed-by: Richard Henderson Signed-off-by: Warner Losh --- bsd-user/qemu.h | 4 1 file changed, 4 deletions(-) diff --git a/bsd-user/qemu.h b/bsd-user/qemu.h index b836b603af..7ccc8ad397 100644 --- a/bsd-user/qemu.h +++ b/bsd-user/qem

[PULL 07/20] bsd-user: style tweak: remove spacing after '*' and add after }

2021-05-12 Thread Warner Losh
Reviewed-by: Richard Henderson Signed-off-by: Warner Losh --- bsd-user/qemu.h | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/bsd-user/qemu.h b/bsd-user/qemu.h index 5a82722281..de20e8329a 100644 --- a/bsd-user/qemu.h +++ b/bsd-user/qemu.h @@ -124,19 +124,1

[PULL 15/20] bsd-user: style tweak: keyword space (

2021-05-12 Thread Warner Losh
Reviewed-by: Richard Henderson Signed-off-by: Warner Losh --- bsd-user/uaccess.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bsd-user/uaccess.c b/bsd-user/uaccess.c index 91e2067933..89163257f4 100644 --- a/bsd-user/uaccess.c +++ b/bsd-user/uaccess.c @@ -46,7 +46,7 @@ abi

[PATCH 1/3] pc-bios/s390-ccw: Fix inline assembly for older versions of Clang

2021-05-12 Thread Thomas Huth
Clang versions before v11.0 insist on having the %rX or %cX register names instead of just a number. Since our Travis-CI is currently still using Clang v6.0, we have to fix this to avoid failing jobs. Signed-off-by: Thomas Huth --- pc-bios/s390-ccw/helper.h | 2 +- pc-bios/s390-ccw/jump2ipl.c

[PULL 01/20] bsd-user: whitespace changes

2021-05-12 Thread Warner Losh
Space after keywords, no space for function calls and spaces around operators. Reviewed-by: Richard Henderson Signed-off-by: Warner Losh --- bsd-user/main.c | 40 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/bsd-user/main.c b/bsd-user/

[PULL 02/20] bsd-user: style tweak: use C not C++ comments

2021-05-12 Thread Warner Losh
Reviewed-by: Richard Henderson Signed-off-by: Warner Losh --- bsd-user/main.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/bsd-user/main.c b/bsd-user/main.c index 079520737b..5253ceb24b 100644 --- a/bsd-user/main.c +++ b/bsd-user/main.c @@ -147,7 +147,7 @@

[PULL 09/20] bsd-user: style tweak: don't assign in if statements

2021-05-12 Thread Warner Losh
Reviewed-by: Richard Henderson Signed-off-by: Warner Losh --- bsd-user/qemu.h | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/bsd-user/qemu.h b/bsd-user/qemu.h index 7f3cfa68aa..2494d9209d 100644 --- a/bsd-user/qemu.h +++ b/bsd-user/qemu.h @@ -288,7 +288,8 @@ static inl

[PATCH 3/3] pc-bios/s390-ccw: Add a proper prototype for main()

2021-05-12 Thread Thomas Huth
Older versions of Clang complain if there is no prototype for main(). Add one, and while we're at it, make sure that we use the same type for main.c and netmain.c - since the return value does not matter, declare the return type of main() as "void". Signed-off-by: Thomas Huth --- pc-bios/s390-cc

[PATCH 2/3] pc-bios/s390-ccw/Makefile: Check more compiler flags for Clang

2021-05-12 Thread Thomas Huth
Older versions of Clang do not like -fno-delete-null-pointer-checks or -msoft-float. So let's add a proper check for those. Signed-off-by: Thomas Huth --- pc-bios/s390-ccw/Makefile | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/pc-bios/s390-ccw/Makefile b/pc-bios/s390

[PATCH 0/3] Fix Travis-CI / compiling with older versions of Clang

2021-05-12 Thread Thomas Huth
My last pull request enabled compiling the s390-ccw bios with Clang. However, I only tested it with Clang version 11, and older versions of Clang are a little bit more picky. Fix those issues now, too, so that the corresponding job with Clang on s390x in the Travis-CI works correctly again. Thomas

Re: [PATCH 06/11] target/ppc: updated vscr manipulation in machine.c

2021-05-12 Thread Richard Henderson
On 5/12/21 9:08 AM, Bruno Larsen (billionai) wrote: Updated the code in machine.c to use the generic ppc_{store,get}_vscr instead of helper style functions, so it can build without TCG Signed-off-by: Bruno Larsen (billionai) --- target/ppc/machine.c | 7 +++ 1 file changed, 3 insertions(+

Re: [PULL 2/5] Remove the deprecated moxie target

2021-05-12 Thread Thomas Huth
On 12/05/2021 18.37, Philippe Mathieu-Daudé wrote: On 5/12/21 6:24 PM, Markus Armbruster wrote: From: Thomas Huth There are no known users of this CPU anymore, and there are no binaries available online which could be used for regression tests, so the code has likely completely bit-rotten alre

Re: [PATCH 05/11] target/ppc: moved ppc_store_lpcr to cpu.c

2021-05-12 Thread Richard Henderson
On 5/12/21 9:08 AM, Bruno Larsen (billionai) wrote: This function is used in !TCG cases, so it has been moved into a file that is compiled when --disable-tcg is selected. Signed-off-by: Bruno Larsen (billionai) --- target/ppc/cpu.c | 11 +++ target/ppc/misc_helper.c | 10 -

Re: [PATCH 04/11] target/ppc: moved ppc_store_msr into gdbstub.c

2021-05-12 Thread Richard Henderson
On 5/12/21 9:08 AM, Bruno Larsen (billionai) wrote: This function is used by !TCG cases, so it was moved to a common code file. We chose gdbstub.c since it was the one giving us grief over it. Signed-off-by: Bruno Larsen (billionai) --- target/ppc/gdbstub.c | 7 +++ target/ppc/misc_he

Re: [PATCH v2] qemu-iotests: fix pylint 2.8 consider-using-with error

2021-05-12 Thread Max Reitz
On 10.05.21 21:04, Emanuele Giuseppe Esposito wrote: pylint 2.8 introduces consider-using-with error, suggesting to use the 'with' block statement when possible. Modify all subprocess.Popen call to use the 'with' statement, except the one in __init__ of QemuIoInteractive class, since it is assig

Re: [PATCH 03/11] target/ppc: moved ppc_cpu_dump_state to cpu_init.c

2021-05-12 Thread Richard Henderson
On 5/12/21 11:58 AM, Richard Henderson wrote: On 5/12/21 9:08 AM, Bruno Larsen (billionai) wrote: This function was forgotten in the cpu_init code motion series, but it seems to be used regardless of TCG, and so needs to be moved to support disabling TCG. Signed-off-by: Bruno Larsen (billionai)

Re: [PATCH 03/11] target/ppc: moved ppc_cpu_dump_state to cpu_init.c

2021-05-12 Thread Richard Henderson
On 5/12/21 9:08 AM, Bruno Larsen (billionai) wrote: This function was forgotten in the cpu_init code motion series, but it seems to be used regardless of TCG, and so needs to be moved to support disabling TCG. Signed-off-by: Bruno Larsen (billionai) --- target/ppc/cpu_init.c | 182 +++

Re: [PATCH 02/11] target/ppc: moved ppc_store_sdr1 to cpu.c

2021-05-12 Thread Richard Henderson
On 5/12/21 9:08 AM, Bruno Larsen (billionai) wrote: Moved this function that is required in !TCG cases into a common code file Signed-off-by: Bruno Larsen (billionai) Reviewed-by: Richard Henderson +void ppc_store_sdr1(CPUPPCState *env, target_ulong value) +{ +PowerPCCPU *cpu = env_ar

Re: [PATCH 00/72] Convert floatx80 and float128 to FloatParts

2021-05-12 Thread Alex Bennée
Richard Henderson writes: > Reorg everything using QEMU_GENERIC and multiple inclusion to > reduce the amount of code duplication between the formats. > > The use of QEMU_GENERIC means that we need to use pointers instead > of structures, which means that even the smaller float formats > need r

Re: [PATCH 01/11] target/ppc: created ppc_{store,get}_vscr for generic vscr usage

2021-05-12 Thread Richard Henderson
On 5/12/21 9:08 AM, Bruno Larsen (billionai) wrote: Some functions unrelated to TCG use helper_m{t,f}vscr, so generic versions of those functions were added to cpu.c, in preparation for compilation without TCG Signed-off-by: Bruno Larsen (billionai) --- target/ppc/arch_dump.c | 3 +-- targe

Re: [PATCH V3 00/22] Live Update

2021-05-12 Thread Stefan Hajnoczi
On Fri, May 07, 2021 at 05:24:58AM -0700, Steve Sistare wrote: > Provide the cprsave and cprload commands for live update. These save and > restore VM state, with minimal guest pause time, so that qemu may be updated > to a new version in between. > > cprsave stops the VM and saves vmstate to an

Re: [PULL 0/5] Miscellaneous patches for 2021-05-12

2021-05-12 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210512162412.338120-1-arm...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210512162412.338120-1-arm...@redhat.com Subject: [PULL 0/5] Miscellaneous patches for 202

Re: [PATCH v6 1/4] slirp: Advance libslirp submodule to add ipv6 host-forward support

2021-05-12 Thread Doug Evans
Ping. On Fri, May 7, 2021 at 8:46 AM Doug Evans wrote: > On Fri, May 7, 2021 at 8:23 AM Marc-André Lureau < > marcandre.lur...@gmail.com> wrote: > >> Hi >> >> [...] >>> >>> >>> Changes from v5: >>> >>> 1/4 slirp: Advance libslirp submodule to current master >>> NOTE TO REVIEWERS: It may be a bet

Re: [PULL 2/5] Remove the deprecated moxie target

2021-05-12 Thread Philippe Mathieu-Daudé
On 5/12/21 6:24 PM, Markus Armbruster wrote: > From: Thomas Huth > > There are no known users of this CPU anymore, and there are no > binaries available online which could be used for regression tests, > so the code has likely completely bit-rotten already. It's been > marked as deprecated since

Re: [PATCH v2 1/2] net/tap: fix FreeBSD portability problem receiving TAP FD

2021-05-12 Thread Philippe Mathieu-Daudé
On 5/12/21 5:36 PM, Daniel P. Berrangé wrote: > The CMSG_LEN and CMSG_SPACE macros must not be assumed to return the > same value. The msg_controllen field must be initialized using > CMSG_SPACE when using SCM_RIGHTS. > > This ought to fix any FD receive issues users might be hitting on > 64-bit F

Re: [PATCH V3 06/22] vl: add helper to request re-exec

2021-05-12 Thread Stefan Hajnoczi
On Fri, May 07, 2021 at 05:25:04AM -0700, Steve Sistare wrote: > @@ -660,6 +673,16 @@ void qemu_system_debug_request(void) > qemu_notify_event(); > } > > +static void qemu_exec(void) > +{ > +const char *helper = "/usr/bin/qemu-exec"; The network up script is get_relocated_path(CONFIG_S

Re: [PULL 0/5] Miscellaneous patches for 2021-05-12

2021-05-12 Thread Peter Maydell
On Wed, 12 May 2021 at 17:24, Markus Armbruster wrote: > > The following changes since commit a5ccdccc97d6e0d75282ede5b866cf694e9602b0: > > Merge remote-tracking branch > 'remotes/kraxel/tags/vga-20210510-pull-request' into staging (2021-05-12 > 14:45:21 +0100) > > are available in the Git rep

Re: [PULL 00/33] Misc (mostly i386) patches for 2021-05-11

2021-05-12 Thread Peter Maydell
On Tue, 11 May 2021 at 09:16, Paolo Bonzini wrote: > > The following changes since commit e58c7a3bba3076890592f02d2b0e596bf191b5c2: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20210510-1' into staging (2021-05-10 > 17:28:11 +0100) > > are available in the Git repo

Re: [PATCH 01/12] gitlab: move linux user build job from CentOS 7 to CentOS 8

2021-05-12 Thread Peter Maydell
On Wed, 12 May 2021 at 17:19, Philippe Mathieu-Daudé wrote: > I was testing on CentOS 7 by accident, and noticed Peter reported the > same error on his "ppc64 box", so I figured it would be more useful > to the community if we could catch such error (old kernel headers) > before reaching Peter gat

[PULL 3/5] block: Drop the sheepdog block driver

2021-05-12 Thread Markus Armbruster
It was deprecated in commit e1c4269763, v5.2.0. See that commit message for rationale. Signed-off-by: Markus Armbruster Message-Id: <20210501075747.3293186-1-arm...@redhat.com> ACKed-by: Peter Krempa --- docs/system/deprecated.rst |9 - docs/system/device-url-syntax.rst.inc |

[PULL 5/5] Drop the deprecated unicore32 target

2021-05-12 Thread Markus Armbruster
Target unicore32 was deprecated in commit 8e4ff4a8d2b, v5.2.0. See there for rationale. Cc: Guan Xuetao Signed-off-by: Markus Armbruster Message-Id: <20210503084034.3804963-3-arm...@redhat.com> Acked-by: Thomas Huth --- docs/system/deprecated.rst|8 - docs/system/remov

[PULL 0/5] Miscellaneous patches for 2021-05-12

2021-05-12 Thread Markus Armbruster
The following changes since commit a5ccdccc97d6e0d75282ede5b866cf694e9602b0: Merge remote-tracking branch 'remotes/kraxel/tags/vga-20210510-pull-request' into staging (2021-05-12 14:45:21 +0100) are available in the Git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-misc-2021-05-

[PULL 1/5] monitor/qmp: fix race on CHR_EVENT_CLOSED without OOB

2021-05-12 Thread Markus Armbruster
From: Stefan Reiter The QMP dispatcher coroutine holds the qmp_queue_lock over a yield point, where it expects to be rescheduled from the main context. If a CHR_EVENT_CLOSED event is received just then, it can race and block the main thread on the mutex in monitor_qmp_cleanup_queue_and_resume. m

[PULL 2/5] Remove the deprecated moxie target

2021-05-12 Thread Markus Armbruster
From: Thomas Huth There are no known users of this CPU anymore, and there are no binaries available online which could be used for regression tests, so the code has likely completely bit-rotten already. It's been marked as deprecated since two releases now and nobody spoke up that there is still

Re: [PATCH 01/12] gitlab: move linux user build job from CentOS 7 to CentOS 8

2021-05-12 Thread Philippe Mathieu-Daudé
+Peter On 5/11/21 4:04 PM, Daniel P. Berrangé wrote: > On Tue, May 11, 2021 at 03:54:26PM +0200, Thomas Huth wrote: >> On 11/05/2021 15.26, Daniel P. Berrangé wrote: >>> It has been over two years since RHEL-8 was released, and thus per the >>> platform build policy, we no longer need to support R

Re: [PULL v2 0/1] readthedoc theme patch

2021-05-12 Thread Peter Maydell
On Wed, 12 May 2021 at 17:02, Marc-André Lureau wrote: > On Wed, May 12, 2021 at 7:56 PM Peter Maydell > wrote: >> >> NetBSD now complains: >> >> >> >> Configuring 60-edk2-x86_64.json using configuration >> >> Program qemu-keymap found: NO >> >> Program sphinx-build found: YES >> >> ../docs/meso

Re: [PATCH V3 07/22] cpr

2021-05-12 Thread Stefan Hajnoczi
On Fri, May 07, 2021 at 05:25:05AM -0700, Steve Sistare wrote: > To use the restart mode, qemu must be started with the memfd-alloc machine > option. The memfd's are saved to the environment and kept open across exec, > after which they are found from the environment and re-mmap'd. Hence guest >

Re: [PATCH v6 38/82] target/arm: Implement SVE2 ADDHNB, ADDHNT

2021-05-12 Thread Richard Henderson
On 5/12/21 10:23 AM, Peter Maydell wrote: On Fri, 30 Apr 2021 at 22:00, Richard Henderson wrote: From: Stephen Long Signed-off-by: Stephen Long Message-Id: <20200417162231.10374-2-stepl...@quicinc.com> Signed-off-by: Richard Henderson --- diff --git a/target/arm/sve_helper.c b/target/ar

Re: [PATCH v6 26/82] target/arm: Implement SVE2 SHRN, RSHRN

2021-05-12 Thread Richard Henderson
On 5/12/21 3:52 AM, Peter Maydell wrote: On Fri, 30 Apr 2021 at 21:49, Richard Henderson wrote: Signed-off-by: Richard Henderson --- v2: Fix typo in gen_shrnb_vec (laurent desnogues) v3: Replace DO_RSHR with an inline function --- target/arm/helper-sve.h| 16 target/arm/sve.decod

Re: [PATCH v3 0/8] block: refactor write threshold

2021-05-12 Thread Stefan Hajnoczi
On Thu, May 06, 2021 at 12:06:13PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Hi all! > > v3: > 01-04,06,07: add Max's r-b. > 01: improve commit msg and comments > 03: improve commit msg > 05: add more comments and qemu/atomic.h include > 08: new, replacement for v2:08,09 > > Vladimir Sementsov

Re: [PATCH v2 0/4] virtio: Improve boot time of virtio-scsi-pci and virtio-blk-pci

2021-05-12 Thread Stefan Hajnoczi
On Fri, May 07, 2021 at 06:59:01PM +0200, Greg Kurz wrote: > Now that virtio-scsi-pci and virtio-blk-pci map 1 virtqueue per vCPU, > a serious slow down may be observed on setups with a big enough number > of vCPUs. > > Exemple with a pseries guest on a bi-POWER9 socket system (128 HW threads): >

Re: [PATCH] travis-ci: Use clang-10 for the [s390x] Clang (disable-tcg) job

2021-05-12 Thread Daniel P . Berrangé
On Wed, May 12, 2021 at 04:55:20PM +0100, Daniel P. Berrangé wrote: > On Wed, May 12, 2021 at 05:44:10PM +0200, Thomas Huth wrote: > > > > I think the configure script uses the same compiler as --host-cc for --cc if > > it is not specified. So depending on whether Daniel sets the minimum version >

Re: [PATCH 1/3] virtiofsd: Find original inode ID of mount points

2021-05-12 Thread Connor Kuehl
On 5/12/21 7:55 AM, Max Reitz wrote: > Mount point directories represent two inodes: On one hand, they are a > normal directory on their parent filesystem. On the other, they are > the > root node of the filesystem mounted there. Thus, they have two inode > IDs. > > Right now, we only report the

Re: [PULL v2 0/1] readthedoc theme patch

2021-05-12 Thread Marc-André Lureau
Hi On Wed, May 12, 2021 at 7:56 PM Peter Maydell wrote: > On Wed, 12 May 2021 at 16:17, Marc-André Lureau > wrote: > > > > Hi > > > > On Wed, May 12, 2021 at 5:47 PM Peter Maydell > wrote: > >> > >> On Mon, 10 May 2021 at 14:06, wrote: > >> > > >> > From: Marc-André Lureau > >> > > >> > The

Re: [PULL v2 0/1] readthedoc theme patch

2021-05-12 Thread Peter Maydell
On Wed, 12 May 2021 at 16:17, Marc-André Lureau wrote: > > Hi > > On Wed, May 12, 2021 at 5:47 PM Peter Maydell > wrote: >> >> On Mon, 10 May 2021 at 14:06, wrote: >> > >> > From: Marc-André Lureau >> > >> > The following changes since commit >> > d90f154867ec0ec22fd719164b88716e8fd48672: >>

Re: [PATCH 4/6] progressmeter: protect with a mutex

2021-05-12 Thread Stefan Hajnoczi
On Mon, May 10, 2021 at 10:59:39AM +0200, Emanuele Giuseppe Esposito wrote: > Progressmeter is protected by the AioContext mutex, which > is taken by the block jobs and their caller (like blockdev). > > We would like to remove the dependency of block layer code on the > AioContext mutex, since mos

Re: [PATCH] travis-ci: Use clang-10 for the [s390x] Clang (disable-tcg) job

2021-05-12 Thread Daniel P . Berrangé
On Wed, May 12, 2021 at 05:44:10PM +0200, Thomas Huth wrote: > On 12/05/2021 17.26, Philippe Mathieu-Daudé wrote: > > On 5/12/21 5:22 PM, Philippe Mathieu-Daudé wrote: > > > On Ubuntu Bionic 18.04 LTS clang binary points to the 6.0 version: > > > > > >$ clang --version > > >clang version 6

Re: [PATCH 0/3] hw/virtio: Constify VirtIOFeature

2021-05-12 Thread Stefan Hajnoczi
On Tue, May 11, 2021 at 12:41:54PM +0200, Philippe Mathieu-Daudé wrote: > Trivial patches to keep VirtIOFeature arrays read-only > (better safe than sorry). > > Philippe Mathieu-Daudé (3): > hw/virtio: Pass virtio_feature_get_config_size() a const argument > virtio-blk: Constify VirtIOFeature

Re: [PATCH v11 2/6] arm64: kvm: Introduce MTE VM feature

2021-05-12 Thread Steven Price
On 10/05/2021 19:35, Catalin Marinas wrote: On Fri, May 07, 2021 at 07:25:39PM +0100, Catalin Marinas wrote: On Thu, May 06, 2021 at 05:15:25PM +0100, Steven Price wrote: On 04/05/2021 18:40, Catalin Marinas wrote: On Thu, Apr 29, 2021 at 05:06:41PM +0100, Steven Price wrote: Given the change

Re: [PATCH 5/6] co-shared-resource: protect with a mutex

2021-05-12 Thread Stefan Hajnoczi
On Mon, May 10, 2021 at 10:59:40AM +0200, Emanuele Giuseppe Esposito wrote: > co-shared-resource is currently not thread-safe, as also reported > in co-shared-resource.h. Add a QemuMutex because co_try_get_from_shres > can also be invoked from non-coroutine context. > > Signed-off-by: Emanuele Giu

Re: [PATCH] travis-ci: Use clang-10 for the [s390x] Clang (disable-tcg) job

2021-05-12 Thread Thomas Huth
On 12/05/2021 17.26, Philippe Mathieu-Daudé wrote: On 5/12/21 5:22 PM, Philippe Mathieu-Daudé wrote: On Ubuntu Bionic 18.04 LTS clang binary points to the 6.0 version: $ clang --version clang version 6.0.0-1ubuntu2 (tags/RELEASE_600/final) However we can install clang-10 from the bionic-

Re: GICv3 for MTTCG

2021-05-12 Thread Alex Bennée
Andrey Shinkevich writes: > Dear colleagues, > > I am looking for ways to accelerate the MTTCG for ARM guest on x86-64 host. > The maximum number of CPUs for MTTCG that uses GICv2 is limited by 8: > > include/hw/intc/arm_gic_common.h:#define GIC_NCPU 8 > > The version 3 of the Generic Interrupt

[PATCH v2 2/2] net/tap: fix error reporting when bridge helper forgets to send an FD

2021-05-12 Thread Daniel P . Berrangé
The recv_fd() method returns -1 on error, 0 on end of file, or an FD number on success. Technically 0 is also a valid FD number, so the return value is ambiguous. The caller doesn't even consider the possibility of 0 meaning end of file, so just blindly assume it is a valid FD. IOW if the bridge

[PATCH v2 0/2] net/tap: minor fixes to interaction with the bridge helper

2021-05-12 Thread Daniel P . Berrangé
QEMU fails to report a good error message if the bridge helper exits with success code, but forgets to pass back an FD. There is also a minor portability problem impacting FreeBSD/NetBSD dealing with cmsg initialization. Changed in v2: - include helper binary name in error message Daniel P. Be

Re: [PATCH 2/2] net/tap: fix error reporting when bridge helper forgets to send an FD

2021-05-12 Thread Daniel P . Berrangé
On Wed, May 05, 2021 at 02:32:04PM +0200, Philippe Mathieu-Daudé wrote: > On 5/5/21 2:12 PM, Daniel P. Berrangé wrote: > > The recv_fd() method returns -1 on error, 0 on end of file, or an FD > > number on success. > > > > Technically 0 is also a valid FD number, so the return value is > > ambiguo

[PATCH v2 1/2] net/tap: fix FreeBSD portability problem receiving TAP FD

2021-05-12 Thread Daniel P . Berrangé
The CMSG_LEN and CMSG_SPACE macros must not be assumed to return the same value. The msg_controllen field must be initialized using CMSG_SPACE when using SCM_RIGHTS. This ought to fix any FD receive issues users might be hitting on 64-bit FeeBSD / NetBSD platforms. The flaw was noticed first in GN

Re: [PATCH 2/2] net/tap: fix error reporting when bridge helper forgets to send an FD

2021-05-12 Thread Daniel P . Berrangé
On Tue, May 11, 2021 at 01:53:39PM -0500, Connor Kuehl wrote: > On 5/5/21 7:12 AM, Daniel P. Berrangé wrote: > > [..] > > The recv_fd() method returns -1 on error, 0 on end of file, or an FD > > $ qemu-system-x86_64 -netdev bridge,br=br99,helper=/bin/true,id=ns0 > > qemu-system-x86_64: -netdev

Re: [PATCH 00/72] Convert floatx80 and float128 to FloatParts

2021-05-12 Thread Richard Henderson
On 5/12/21 6:22 AM, Alex Bennée wrote: I did note we are missing mulAdd tests but they seem to be missing from the underlying testfloat code as well. I guess we don't care that much for the 80bit code? Is it even used by any architectures? It's not used by any architecture, so no point in imple

Re: [PATCH v6 41/82] target/arm: Implement SVE2 RSUBHNB, RSUBHNT

2021-05-12 Thread Peter Maydell
On Fri, 30 Apr 2021 at 22:11, Richard Henderson wrote: > > From: Stephen Long > > This completes the section 'SVE2 integer add/subtract narrow high part' > > Signed-off-by: Stephen Long > Message-Id: <20200417162231.10374-5-stepl...@quicinc.com> > Signed-off-by: Richard Henderson > --- Reviewe

Re: non-x86 runners in the Gitlab-CI (was: Re: [PATCH 12/12] configure: bump min required CLang to 7.0.0 / XCode 10.2)

2021-05-12 Thread Daniel P . Berrangé
On Wed, May 12, 2021 at 04:51:25PM +0200, Philippe Mathieu-Daudé wrote: > Hi Daniel, > > On Wed, May 12, 2021 at 4:00 PM Daniel P. Berrangé > wrote: > > On Wed, May 12, 2021 at 03:55:59PM +0200, Thomas Huth wrote: > > > On 12/05/2021 15.47, Willian Rampazzo wrote: > > > > > I don't know if you

Re: [PATCH] travis-ci: Use clang-10 for the [s390x] Clang (disable-tcg) job

2021-05-12 Thread Philippe Mathieu-Daudé
On 5/12/21 5:22 PM, Philippe Mathieu-Daudé wrote: > On Ubuntu Bionic 18.04 LTS clang binary points to the 6.0 version: > > $ clang --version > clang version 6.0.0-1ubuntu2 (tags/RELEASE_600/final) > > However we can install clang-10 from the bionic-updates stream [*] > and use it, to silent t

[Bug 1910696] Re: Qemu fails to start with error " There is no option group 'spice'"

2021-05-12 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting the bug state to "Incomplete" now. If the bug has already been fixed in the latest upstream version of QEMU, then plea

Re: [PATCH v6 40/82] target/arm: Implement SVE2 SUBHNB, SUBHNT

2021-05-12 Thread Peter Maydell
On Fri, 30 Apr 2021 at 22:04, Richard Henderson wrote: > > From: Stephen Long > > Signed-off-by: Stephen Long > Message-Id: <20200417162231.10374-4-stepl...@quicinc.com> > Signed-off-by: Richard Henderson > --- > target/arm/helper-sve.h| 8 > target/arm/sve.decode | 2 ++ >

Re: [PATCH v6 39/82] target/arm: Implement SVE2 RADDHNB, RADDHNT

2021-05-12 Thread Peter Maydell
On Fri, 30 Apr 2021 at 21:56, Richard Henderson wrote: > > From: Stephen Long > > Signed-off-by: Stephen Long > Message-Id: <20200417162231.10374-3-stepl...@quicinc.com> > Signed-off-by: Richard Henderson > --- > v2: Fix round bit type (laurent desnogues) > --- Reviewed-by: Peter Maydell tha

[Bug 1907969] Re: linux-user/i386: Segfault when mixing threads and signals

2021-05-12 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting the bug state to "Incomplete" now. If the bug has already been fixed in the latest upstream version of QEMU, then plea

[PATCH] travis-ci: Use clang-10 for the [s390x] Clang (disable-tcg) job

2021-05-12 Thread Philippe Mathieu-Daudé
On Ubuntu Bionic 18.04 LTS clang binary points to the 6.0 version: $ clang --version clang version 6.0.0-1ubuntu2 (tags/RELEASE_600/final) However we can install clang-10 from the bionic-updates stream [*] and use it, to silent the following warnings: CC pc-bios/s390-ccw/main.o c

Re: [PATCH v6 38/82] target/arm: Implement SVE2 ADDHNB, ADDHNT

2021-05-12 Thread Peter Maydell
On Fri, 30 Apr 2021 at 22:00, Richard Henderson wrote: > > From: Stephen Long > > Signed-off-by: Stephen Long > Message-Id: <20200417162231.10374-2-stepl...@quicinc.com> > Signed-off-by: Richard Henderson > --- > diff --git a/target/arm/sve_helper.c b/target/arm/sve_helper.c > index 572d41a26c

Re: [PATCH v6 37/82] target/arm: Implement SVE2 complex integer multiply-add

2021-05-12 Thread Peter Maydell
On Fri, 30 Apr 2021 at 22:00, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > v2: Fix do_sqrdmlah_d (laurent desnogues) > --- > @@ -1448,6 +1448,48 @@ DO_SQDMLAL(sve2_sqdmlsl_zzzw_d, int64_t, int32_t, > , H1_4, > > #undef DO_SQDMLAL > > +#define DO_CMLA(NAME, TYPE, H,

Re: [PATCH 6/6] aiopool: protect with a mutex

2021-05-12 Thread Stefan Hajnoczi
On Mon, May 10, 2021 at 10:59:41AM +0200, Emanuele Giuseppe Esposito wrote: > Divide the fields in AioTaskPool in IN and Status, and > introduce a CoQueue instead of .wait to take care of suspending > and resuming the calling coroutine, and a lock to protect the > busy_tasks counter accesses and th

Re: [PATCH v6 36/82] target/arm: Implement SVE2 integer multiply-add long

2021-05-12 Thread Peter Maydell
On Fri, 30 Apr 2021 at 21:56, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/helper-sve.h| 28 ++ > target/arm/sve.decode | 11 ++ > target/arm/sve_helper.c| 18 + > target/arm/translate-sve.c | 76 +++

Re: [PULL v2 0/1] readthedoc theme patch

2021-05-12 Thread Marc-André Lureau
Hi On Wed, May 12, 2021 at 5:47 PM Peter Maydell wrote: > On Mon, 10 May 2021 at 14:06, wrote: > > > > From: Marc-André Lureau > > > > The following changes since commit > d90f154867ec0ec22fd719164b88716e8fd48672: > > > > Merge remote-tracking branch > 'remotes/dg-gitlab/tags/ppc-for-6.1-202

Re: [PATCH v6 35/82] target/arm: Implement SVE2 saturating multiply-add high

2021-05-12 Thread Peter Maydell
On Fri, 30 Apr 2021 at 21:53, Richard Henderson wrote: > > SVE2 has two additional sizes of the operation and unlike NEON, > there is no saturation flag. Create new entry points for SVE2 > that do not set QC. > > Signed-off-by: Richard Henderson > --- > target/arm/helper.h| 17 >

[Bug 1910540] Re: where the trace file "trace-*"

2021-05-12 Thread Thomas Huth
You can find the trace-event files in the source tree, if you were talking about those. Anyway, this does not really sound like a bug, so I'm closing this ticket now. If you need general help, please use the qemu-discuss mailing list or the #qemu channel on OFTC IRC instead. ** Changed in: qemu

Re: [PATCH v2] block: Improve backing file validation

2021-05-12 Thread Kevin Wolf
Am 11.05.2021 um 10:35 hat Daniel P. Berrangé geschrieben: > On Tue, May 11, 2021 at 01:55:18PM +0800, Li Zhijian wrote: > > Image below user cases: > > case 1: > > ``` > > $ qemu-img create -f raw source.raw 1G > > $ qemu-img create -f qcow2 -F raw -b source.raw ./source.raw > > qemu-img info sour

Re: [PULL 00/25] Vga 20210510 patches

2021-05-12 Thread Peter Maydell
On Mon, 10 May 2021 at 14:22, Gerd Hoffmann wrote: > > The following changes since commit d90f154867ec0ec22fd719164b88716e8fd48672: > > Merge remote-tracking branch 'remotes/dg-gitlab/tags/ppc-for-6.1-20210504' > into staging (2021-05-05 20:29:14 +0100) > > are available in the Git repository a

Re: [PATCH 0/3] vhost-user-blk-test: add tests for the vhost-user-blk server

2021-05-12 Thread Kevin Wolf
Am 11.05.2021 um 10:23 hat Stefan Hajnoczi geschrieben: > On Mon, Mar 22, 2021 at 09:23:24AM +, Stefan Hajnoczi wrote: > > These patches add a qtest for the vhost-user-blk server. CI found several > > issues that caused these patches to be dropped from Michael Tsirkin and > > Kevin > > Wolf's

Re: non-x86 runners in the Gitlab-CI (was: Re: [PATCH 12/12] configure: bump min required CLang to 7.0.0 / XCode 10.2)

2021-05-12 Thread Philippe Mathieu-Daudé
Hi Daniel, On Wed, May 12, 2021 at 4:00 PM Daniel P. Berrangé wrote: > On Wed, May 12, 2021 at 03:55:59PM +0200, Thomas Huth wrote: > > On 12/05/2021 15.47, Willian Rampazzo wrote: > > > I don't know if you saw this: > > > https://docs.travis-ci.com/user/billing-overview/#partner-queue-solution.

Re: [PULL 8/9] pc-bios/s390-ccw: Allow building with Clang, too

2021-05-12 Thread Thomas Huth
On 12/05/2021 16.00, Thomas Huth wrote: On 12/05/2021 15.40, Thomas Huth wrote: On 12/05/2021 13.53, Philippe Mathieu-Daudé wrote: On 5/10/21 9:35 AM, Thomas Huth wrote: Clang unfortunately does not support generating code for the z900 architecture level and starts with the z10 instead. Thus t

Re: [PATCH V2 0/2] Proposing custom CSR handling logic

2021-05-12 Thread Bin Meng
On Wed, May 12, 2021 at 2:03 PM Alistair Francis wrote: > > On Tue, May 11, 2021 at 8:07 PM Ruinland Chuan-Tzu Tsai > wrote: > > > > Hi all, > > > > My sincere apology that I missed the patch to include our own CSR table > > into the patch series and there were plenty of typos. > > Thus I'm sendi

Re: [PATCH 12/12] configure: bump min required CLang to 7.0.0 / XCode 10.2

2021-05-12 Thread Daniel P . Berrangé
On Wed, May 12, 2021 at 04:10:03PM +0200, Philippe Mathieu-Daudé wrote: > On 5/12/21 2:25 PM, Daniel P. Berrangé wrote: > > On Wed, May 12, 2021 at 01:44:51PM +0200, Philippe Mathieu-Daudé wrote: > >> On 5/11/21 3:26 PM, Daniel P. Berrangé wrote: > >>> Several distros have been dropped since the la

<    1   2   3   4   5   >