+Cc qemu-devel@nongnu.org
On 5/14/2021 9:07 AM, Chenyi Qiang wrote:
Hi Paolo, Eduardo
Any comments on this version?
On 4/30/2021 6:33 PM, Chenyi Qiang wrote:
A bus lock is acquired through either split locked access to writeback
(WB) memory or any locked access to non-WB memory. It is
On 13/05/21 23:02, Willian Rampazzo wrote:
I think I understand why you brought this thread back now. Finding a way
to correlate maintainers and tags is, indeed, a nice feature that can
help with your idea about correlating tags and maintainers to use on tests.
--verbose? :)
Paolo
On 14/05/21 01:35, David Gibson wrote:
"FDT" is set by meson.build if the library is available, LIBFDT is set by
the board to link with the library. In other words CONFIG_FDT is per-build,
while CONFIG_LIBFDT is per-target.
Oof... that's highly non-obvious. Could we call it HAVE_LIBFDT and
riscv_excp_names[] and riscv_intr_names[] are only referenced by
target/riscv/cpu.c locally.
Signed-off-by: Bin Meng
---
target/riscv/cpu.h | 2 --
target/riscv/cpu.c | 4 ++--
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/target/riscv/cpu.h b/target/riscv/cpu.h
index
On 5/13/21 8:20 PM, Alex Bennée wrote:
>
> Andrey Shinkevich writes:
>
>> Dear colleagues,
>>
>> Thank you all very much for your responses. Let me reply with one message.
>>
>> I configured QEMU for AARCH64 guest:
>> $ ./configure --target-list=aarch64-softmmu
>>
>> When I start QEMU with
Hi Jason,
On Mon, Mar 22, 2021 at 3:10 PM Jason Wang wrote:
>
>
> 在 2021/3/17 下午2:26, Bin Meng 写道:
> > The minimum Ethernet frame length is 60 bytes. For short frames with
> > smaller length like ARP packets (only 42 bytes), on a real world NIC
> > it can choose either padding its length to the
On 5/12/21 1:23 PM, Rebecca Cran wrote:
ARMv8.4 adds the mandatory FEAT_TLBIOS. It provides TLBI
maintenance instructions that extend to the Outer Shareable domain.
Signed-off-by: Rebecca Cran
---
target/arm/cpu.h| 5 +++
target/arm/helper.c | 43
2 files changed,
On 5/12/21 1:23 PM, Rebecca Cran wrote:
ARMv8.4 adds the mandatory FEAT_TLBIRANGE. It provides TLBI
maintenance instructions that apply to a range of input addresses.
Signed-off-by: Rebecca Cran
---
target/arm/cpu.h| 5 +
target/arm/helper.c | 281
2 files
Bug still present in latest master
** Changed in: qemu
Status: Incomplete => New
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1917184
Title:
qemu-user vm86() segfaults handling interrupt
On Wed, Apr 28, 2021 at 8:29 PM Changbin Du wrote:
>
> This dumps the CSR mscratch/sscratch/satp and meanwhile aligns
> the output of CSR mtval/stval.
>
> Signed-off-by: Changbin Du
> ---
> target/riscv/cpu.c | 7 +--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git
On Fri, May 14, 2021 at 12:56 AM Philippe Mathieu-Daudé
wrote:
>
> The pci_ide_create_devs() function is declared i hw/ide/qdev.c:
>
> $ git grep ide_create_drive
> hw/ide/pci.c:491:ide_create_drive(d->bus + bus[i], unit[i],
> hd_table[i]);
> hw/ide/qdev.c:127:IDEDevice
On Fri, May 14, 2021 at 12:53 AM Philippe Mathieu-Daudé
wrote:
>
> Per the kconfig.rst:
>
> A device should be listed [...] ``imply`` if (depending on
> the QEMU command line) the board may or may not be started
> without it.
>
> This is the case with the NVDIMM device (it is certainly
On Fri, May 14, 2021 at 10:53 AM Bin Meng wrote:
>
> On Fri, May 14, 2021 at 12:58 AM Philippe Mathieu-Daudé
> wrote:
> >
> > Cmmit 56b5170c87e ("semihosting: Move ARM semihosting code to
typo: Commit
> > shared directories"), added the ARM_COMPATIBLE_SEMIHOSTING symbol
> > which selects
On Fri, May 14, 2021 at 12:58 AM Philippe Mathieu-Daudé
wrote:
>
> Cmmit 56b5170c87e ("semihosting: Move ARM semihosting code to
> shared directories"), added the ARM_COMPATIBLE_SEMIHOSTING symbol
> which selects SEMIHOSTING.
>
> Since the ARM/RISC-V targets select ARM_COMPATIBLE_SEMIHOSTING,
>
On Fri, May 14, 2021 at 1:02 AM Philippe Mathieu-Daudé
wrote:
>
> Commit 7abb479c7ab ("PPC: E500: Add FSL I2C controller and integrate
> RTC with it") added a global dependency on the DS1338 model, instead
> of a machine one (via Kconfig). This gives trouble when building
> standalone machines
On Fri, May 14, 2021 at 12:58 AM Philippe Mathieu-Daudé
wrote:
>
> Only the Virt and Spike machines use NUMA. Add a RISCV_NUMA Kconfig
> symbol and only have these machines select it. Adapt the Meson file
> to only built it if required.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
>
Hi Philippe,
On Fri, May 14, 2021 at 12:57 AM Philippe Mathieu-Daudé
wrote:
>
> Commit a8fb0a500a6 ("hw/char: Add Microchip PolarFire SoC MMUART
> emulation") added a dependency on the SERIAL model, but forgot to
> add the Kconfig selector. Fix that to solve when built the
> MICROCHIP_PFSOC
On Fri, May 14, 2021 at 12:56 AM Philippe Mathieu-Daudé
wrote:
>
> Commit bfae1772c43 ("hw/arm/fsl-imx25: Wire up eSDHC controllers")
> added a dependency on the TYPE_IMX_USDHC model, but forgot to add
> the Kconfig selector. Fix that to solve when built stand-alone:
>
> $ qemu-system-arm -M
On Fri, May 14, 2021 at 12:56 AM Philippe Mathieu-Daudé
wrote:
>
> In commit c4f00daa5b3 ("imx25-pdk: create ds1338 for qtest inside
> the test") we removed the DS1338 device from the i.MX25 machine
> but forgot to remove it in the machine Kconfig definitions, do
> it now.
>
> Signed-off-by:
On Fri, May 14, 2021 at 12:53 AM Philippe Mathieu-Daudé
wrote:
>
> The TYPE_NPCM7XX_SMBUS device model exposes an SMBus, but
> this isn't advertised with proper Kconfig symbol, leading
> to an early build failure when building NPCM7XX machines
> standalone:
>
> The following clauses were found
On Thu, 13 May 2021, at 22:30, Jonathan Cameron wrote:
> On Thu, 13 May 2021 14:36:27 +0200
> Philippe Mathieu-Daudé wrote:
>
> > On 5/13/21 2:23 PM, Peter Maydell wrote:
> > > On Thu, 13 May 2021 at 12:49, Jonathan Cameron
> > > wrote:
> > >> My initial suggestion was to fix this by
On Thu, May 13, 2021 at 2:22 PM David Gibson
wrote:
>
> On Wed, May 05, 2021 at 08:18:27PM +0530, Mahesh Salgaonkar wrote:
> > With upstream kernel, especially after commit 98ba956f6a389
> > ("powerpc/pseries/eeh: Rework device EEH PE determination") we see that KVM
> > guest isn't able to enable
On 14/05/2021 01.15, Dr. David Alan Gilbert wrote:
> * Li Zhijian (lizhij...@cn.fujitsu.com) wrote:
>> A segmentation fault was triggered when i try to abort a postcopy + rdma
>> migration.
>>
>> since rdma_ack_cm_event releases a uninitialized cm_event in thise case.
>>
>> like below:
>> 2496
@aurent-vivier Checked.
This value does not affect the bug, after changing it, I still get an error.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1891748
Title:
qemu-arm-static 5.1 can't run gcc
On 5/13/21 7:24 AM, Matheus K. Ferst wrote:
+static bool trans_CFUGED(DisasContext *ctx, arg_X *a)
+{
+ REQUIRE_64BIT(ctx);
+ REQUIRE_INSNS_FLAGS2(ctx, ISA310);
+#if defined(TARGET_PPC64)
+ gen_helper_cfuged(cpu_gpr[a->ra], cpu_gpr[a->rt], cpu_gpr[a->rb]);
+#else
+ gen_invalid(ctx);
On Thu, May 13, 2021 at 05:20:06PM +0200, Paolo Bonzini wrote:
> On 12/05/21 09:02, David Gibson wrote:
> > > But with "imply" you could end up with a PSERIES that does not have NVDIMM
> > > when also using --without-default-devices, couldn't you? Why don't you use
> > > "select" instead of
On Thu, May 13, 2021 at 06:38:49PM +0200, Philippe Mathieu-Daudé wrote:
> Per the kconfig.rst:
>
> A device should be listed [...] ``imply`` if (depending on
> the QEMU command line) the board may or may not be started
> without it.
>
> This is the case with the NVDIMM device (it is
On Thu, May 13, 2021 at 05:26:37PM +0200, Paolo Bonzini wrote:
> On 13/05/21 05:46, David Gibson wrote:
> > > The patch makes sense in general. The file is only needed for pseries and
> > > powernv, not for e.g. e500 which does need fdt.
> >
> > Yes, agreed.
> >
> > > I would get rid of FDT_PPC
On Thu, May 13, 2021 at 06:38:56PM +0200, Philippe Mathieu-Daudé wrote:
> Commit 7abb479c7ab ("PPC: E500: Add FSL I2C controller and integrate
> RTC with it") added a global dependency on the DS1338 model, instead
> of a machine one (via Kconfig). This gives trouble when building
> standalone
On 5/13/21 8:33 AM, Alex Bennée wrote:
Now add and mul columns are going down when the only change is to
muladd? Is this just more noise?
Running again more times I think it is a real effect:
I don't believe it. If source code for a given function is not changing then
the generated code
On 5/13/21 9:03 AM, Lucas Mateus Martins Araujo e Castro wrote:
tlb_set_page is called by many ppc_hash64_handle_mmu_fault,
ppc_radix64_handle_mmu_fault and ppc_hash32_handle_mmu_fault, all of which from
what I've seen are only used inside #if defined(CONFIG_SOFTMMU).
tlb_set_page should only
On 5/13/21 11:36 AM, Bruno Piazera Larsen wrote:
On 12/05/2021 15:20, Richard Henderson wrote:
On 5/12/21 9:08 AM, Bruno Larsen (billionai) wrote:
diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c
index 104a308abb..a8a720eb48 100644
--- a/target/ppc/kvm.c
+++ b/target/ppc/kvm.c
@@ -2947,3
This is the addition of a new devices used in a lot of BMCs, and adds
the infrastructure so other devices of it's type can be added.
I will update the Changelog as necessary.
This was through several revisions on the mailing list recently.
Thanks,
-corey
The following changes since commit
On 12/05/21 09:15, Vladimir Sementsov-Ogievskiy wrote:
I don't understand. Why doesn't aio_co_enter go through the ctx !=
qemu_get_current_aio_context() branch and just do aio_co_schedule?
That was at least the idea behind aio_co_wake and aio_co_enter.
Because ctx is exactly
FYI, I had to setup Thunderbird to reply to you because Gmail web
interface was crashing when I was trying to expand the e-mail to delete
the code. So, as Peter mentioned, a nice April fools' joke.
On 5/13/21 3:32 PM, Philippe Mathieu-Daudé wrote:
Cc'ing John/Willian/Wainer
I think I
On 5/11/21 4:37 PM, Vivek Goyal wrote:
> There is no reason to set it in label "err". We should be able to set
> it right after sending reply. It is easier to read.
>
> Signed-off-by: Vivek Goyal
> ---
> tools/virtiofsd/fuse_virtio.c | 5 +
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
On 5/11/21 4:37 PM, Vivek Goyal wrote:
> Hi,
>
> Code in virtio_send_data_iov() little twisted and complicated. This
> patch series just tries to simplify it a bit to make it little easier
> to read this piece of code.
>
> Thanks
> Vivek
>
> Vivek Goyal (7):
> virtiofsd: Check for EINTR in
I will add to MAINTAINERS incrementally instead of at the end to make
checkpatch happy.
I will use qemu_strtol even though I thought the message "consider using
qemu_strtol"
was giving me a choice.
You can't fight The Man when the man is a robot.
- Steve
On 5/7/2021 9:00 AM,
On 13/05/21 21:12, Peter Maydell wrote:
Something weird has happened here.
I think I applied v1 of this pullreq (merge commit 31589644ba069ba06c5
now in master), and then when I came along to try to process this
one the tag was an entirely different set of commits.
Can you check whether what
On 5/12/2021 12:19 PM, Stefan Hajnoczi wrote:
> On Fri, May 07, 2021 at 05:25:05AM -0700, Steve Sistare wrote:
>> To use the restart mode, qemu must be started with the memfd-alloc machine
>> option. The memfd's are saved to the environment and kept open across exec,
>> after which they are found
On 5/12/2021 12:42 PM, Stefan Hajnoczi wrote:
> On Fri, May 07, 2021 at 05:24:58AM -0700, Steve Sistare wrote:
>> Provide the cprsave and cprload commands for live update. These save and
>> restore VM state, with minimal guest pause time, so that qemu may be updated
>> to a new version in
On 5/7/2021 10:33 AM, Eric Blake wrote:
> On 5/7/21 7:25 AM, Steve Sistare wrote:
>> Add QEMU_CHAR_FEATURE_CPR for devices that support cpr.
>> Add the chardev close_on_cpr option for devices that can be closed on cpr
>> and reopened after exec.
>> cpr is allowed only if either
On 5/12/2021 12:27 PM, Stefan Hajnoczi wrote:
> On Fri, May 07, 2021 at 05:25:04AM -0700, Steve Sistare wrote:
>> @@ -660,6 +673,16 @@ void qemu_system_debug_request(void)
>> qemu_notify_event();
>> }
>>
>> +static void qemu_exec(void)
>> +{
>> +const char *helper =
On 5/7/2021 10:31 AM, Eric Blake wrote:
> On 5/7/21 7:25 AM, Steve Sistare wrote:
>> Add a qemu_exec_requested() hook that causes the main loop to exit and
>> re-exec qemu using the same initial arguments. If /usr/bin/qemu-exec
>> exists, exec that instead. This is an optional site-specific
On 5/13/21 1:54 PM, BALATON Zoltan wrote:
> On Thu, 13 May 2021, Philippe Mathieu-Daudé wrote:
>> On 5/11/21 3:09 PM, BALATON Zoltan wrote:
>>> On Tue, 11 May 2021, Philippe Mathieu-Daudé wrote:
Hi Zoltan,
On 5/11/21 1:28 PM, BALATON Zoltan wrote:
> On Tue, 11 May 2021, Philippe
On 210513 1820, Philippe Mathieu-Daudé wrote:
> On Fedora 32, using clang (version 10.0.1-3.fc32) we get:
>
> tests/qtest/fuzz/fuzz.c:237:5: error: implicit declaration of function
> 'qemu_init' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
> qemu_init(result.we_wordc,
On Fri, 30 Apr 2021 at 21:26, Richard Henderson
wrote:
>
> Based-on: 20210430132740.10391-1-peter.mayd...@linaro.org
> ("target/arm: Split translate-*.c.inc into separate compilation units")
>
> Based-on: 20210427214108.88503-1-richard.hender...@linaro.org
> ("linux-user/aarch64: Enable hwcap for
On Fri, 30 Apr 2021 at 22:36, Richard Henderson
wrote:
>
> This is {S,U,US}MMLA for both AArch64 AdvSIMD and SVE,
> and V{S,U,US}MMLA.S8 for AArch32 NEON.
>
> Signed-off-by: Richard Henderson
> ---
> target/arm/helper.h | 7
> target/arm/neon-shared.decode | 7
>
On Fri, 30 Apr 2021 at 22:37, Richard Henderson
wrote:
>
> Signed-off-by: Richard Henderson
> ---
> target/arm/cpu.c | 1 +
> target/arm/cpu64.c | 13 +
> 2 files changed, 14 insertions(+)
>
> diff --git a/target/arm/cpu.c b/target/arm/cpu.c
> index 0dd623e590..30fd5d5ff7 100644
On Fri, 30 Apr 2021 at 22:43, Richard Henderson
wrote:
>
> Signed-off-by: Richard Henderson
> ---
> linux-user/elfload.c | 10 ++
> 1 file changed, 10 insertions(+)
>
Reviewed-by: Peter Maydell
thanks
-- PMM
On Fri, 30 Apr 2021 at 22:20, Richard Henderson
wrote:
>
> Signed-off-by: Richard Henderson
> ---
> target/arm/cpu.h | 5 +
> target/arm/neon-shared.decode | 6 ++
> target/arm/translate-neon.c | 27 +++
> 3 files changed, 38 insertions(+)
On Fri, 30 Apr 2021 at 22:21, Richard Henderson
wrote:
>
> Now that we have a common helper, sharing decode does not
> save much. Also, this will solve an upcoming naming problem.
>
> Signed-off-by: Richard Henderson
> ---
> target/arm/neon-shared.decode | 9 ++---
>
On Fri, 30 Apr 2021 at 22:23, Richard Henderson
wrote:
>
> We were extracting the M register twice, once incorrectly
> as M:vm and once correctly as rm. Remove the incorrect
> name and remove the incorrect decode.
>
> Signed-off-by: Richard Henderson
> ---
> target/arm/neon-shared.decode | 4
On 4/11/21 10:09 PM, Cleber Rosa wrote:
At this time I don't have a need for it in the PyPI upload, but I
wonder if this exception is justified. I mean, what would be gained,
besides dealing with the exception itself, by not including it?
I just don't want to support or maintain little
On Wed, 12 May 2021 at 09:43, Paolo Bonzini wrote:
>
> The following changes since commit e58c7a3bba3076890592f02d2b0e596bf191b5c2:
>
> Merge remote-tracking branch
> 'remotes/pmaydell/tags/pull-target-arm-20210510-1' into staging (2021-05-10
> 17:28:11 +0100)
>
> are available in the Git
On 4/12/21 12:46 AM, Cleber Rosa wrote:
Slightly different versions for the same utility code are currently
present on different locations. This unifies them all, giving
preference to the version from virtiofs_submounts.py, because of the
last tweaks added to it.
While at it, this adds a
On 5/11/21 8:48 AM, Philippe Mathieu-Daudé wrote:
> Not sure if following up this thread or start a new one, but I got
> blocked again from Gitlab, tagged as a crypto miner for running QEMU
> CI...
> [1]
>
On Thu, 13 May 2021 at 19:36, Philippe Mathieu-Daudé wrote:
>
> Cc'ing John/Willian/Wainer
>
> On 4/1/19 1:29 PM, Paolo Bonzini wrote:
> > JSON is already in wide use within QEMU for QMP and QAPI, enable
> > wider usage of MAINTAINERS by applying a well-defined machine-readable
> > format.
On 4/14/21 1:03 PM, Emanuele Giuseppe Esposito wrote:
As with gdbserver, valgrind delays the test execution, so
the default QMP socket timeout timeout too soon.
Signed-off-by: Emanuele Giuseppe Esposito
---
python/qemu/machine.py| 2 +-
tests/qemu-iotests/iotests.py | 4 ++--
2
I built QEMU from the source files downloaded from
https://github.com/qemu/qemu
latest commit 3e9f48bcdabe57f8
I have applied the series "GICv3 LPI and ITS feature implementation".
When I tried to start QEMU back then with the '-kernel' option, the boot
loader failed to locate the rootfs disk by
Hi Shashi,
Thank you very much for letting me know.
I changed virt machine to the version 6.1 and the error disappeared.
But the guest OS is experiencing severe delays while booting and
starting. The delays take minutes mostly here:
#0 0x7f1d0932554d in __lll_lock_wait () at
Inspired-by: Volker Rümelin
Signed-off-by: Philippe Mathieu-Daudé
---
hw/input/ps2.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/input/ps2.c b/hw/input/ps2.c
index 72cdb80ae1c..02d7e5da723 100644
--- a/hw/input/ps2.c
+++ b/hw/input/ps2.c
@@ -213,7 +213,7 @@
On 5/3/21 11:02 AM, Max Reitz wrote:
On 30.04.21 23:03, Emanuele Giuseppe Esposito wrote:
On 30/04/2021 13:59, Max Reitz wrote:
On 14.04.21 19:03, Emanuele Giuseppe Esposito wrote:
Attaching a gdbserver implies that the qmp socket
should wait indefinitely for an answer from QEMU.
On 5/13/21 7:58 PM, Paolo Bonzini wrote:
> On 13/05/21 18:38, Philippe Mathieu-Daudé wrote:
>> ARM_COMPATIBLE_SEMIHOSTING is not optional on these targets.
>> Move the variable assignment out of the block documented with
>> "Uncomment the following lines to disable these optional devices".
>
>
On 13/05/21 18:38, Philippe Mathieu-Daudé wrote:
Various Kconfig fixes when building stand-alone machine binaries.
FYI I'm looking at a way to test this automatically, by generating
all the configurations using:
https://docs.gitlab.com/ee/ci/parent_child_pipelines.html#dynamic-child-pipel=
ines
On 13/05/21 18:38, Philippe Mathieu-Daudé wrote:
ARM_COMPATIBLE_SEMIHOSTING is not optional on these targets.
Move the variable assignment out of the block documented with
"Uncomment the following lines to disable these optional devices".
Can you document why it is always required in the
From: David Hildenbrand
Resizing while migrating is dangerous and does not work as expected.
The whole migration code works with the usable_length of a ram block and
does not expect this value to change at random points in time.
In the case of postcopy, relying on used_length is racy as soon as
On 4/14/21 1:03 PM, Emanuele Giuseppe Esposito wrote:
Signed-off-by: Emanuele Giuseppe Esposito
Assuming it doesn't make the linter explode, which I didn't run:
Reviewed-by: John Snow
---
python/qemu/qtest.py | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git
From: David Hildenbrand
Add two new helper functions. This will come in come handy once we want to
handle ram block resizes while postcopy is active.
Note that ram_block_from_stream() will already print proper errors.
Reviewed-by: Dr. David Alan Gilbert
Signed-off-by: David Hildenbrand
On 4/14/21 1:03 PM, Emanuele Giuseppe Esposito wrote:
Add a new _qmp_timer field to the QEMUMachine class.
The default timer is 15 sec, as per the default in the
qmp accept() function.
Fine enough for now.
What's the exact need for this change, exactly? Is it just to prevent
any unbounded
On 13/05/21 10:25, Mirela Grujic wrote:
Once we define MachineInitPhase in qapi, the generated enumeration
constants will be prefixed with the MACHINE_INIT_PHASE_.
We need to define the MachineInitPhase enum in qapi in order to
add the QMP command that will query current machine init phase.
From: David Hildenbrand
Resizing while migrating is dangerous and does not work as expected.
The whole migration code works on the usable_length of ram blocks and does
not expect this to change at random points in time.
In the case of precopy, the ram block size must not change on the source,
Hi Mirela, this is very interesting!
It's unfortunate that I completely missed the discussions in
January/February. You might have noticed that in the 5.2/6.0 timeframe
I worked on cleaning up the machine initialization phases and qemu_init.
The idea behind the cleanup was to identify
From: Hyman
Guestperf tool does not cover the multifd-enabled migration
currently, it is worth supporting so that developers can
analysis the migration performance with all kinds of
migration.
To request that multifd is enabled, with 4 channels:
$ ./tests/migration/guestperf.py \
--multifd
From: David Hildenbrand
Let's make add/remove optional. We want to introduce a RAM block
notifier for RAM migration that is only interested in resize events.
Reviewed-by: Peter Xu
Signed-off-by: David Hildenbrand
Message-Id: <20210429112708.12291-4-da...@redhat.com>
Signed-off-by: Dr. David
From: Peter Maydell
Coverity notices that several places in the migration-test code fail
to free memory in error-exit paths. This is pretty unimportant in
test case code, but we can avoid having to manually free the memory
entirely by using g_autofree.
The places where Coverity spotted a leak
On 13/05/21 10:25, Mirela Grujic wrote:
The command returns current machine initialization phase.
From now on, the MachineInitPhase enum is generated.
Signed-off-by: Mirela Grujic
---
qapi/machine.json | 54 ++
include/hw/qdev-core.h | 29
* Peter Maydell (peter.mayd...@linaro.org) wrote:
> On Tue, 11 May 2021 at 16:08, Dr. David Alan Gilbert (git)
> wrote:
> >
> > From: "Dr. David Alan Gilbert"
> >
> > The following changes since commit e4f3ede95ce813d5705c65e1c0e1c80c70739ebb:
> >
> > Merge remote-tracking branch
> >
From: Markus Armbruster
Result @blocked is redundant. Unfortunately, we realized this too
close to the release to risk dropping it, so we deprecated it
instead, in commit e11ce6c06.
Since it was deprecated from the start, we can delete it without
the customary grace period. Do so.
From: David Hildenbrand
We never read or write beyond the used_length of memory blocks when
migrating. Make this clearer by using offset_in_ramblock() consistently.
Reviewed-by: Dr. David Alan Gilbert
Signed-off-by: David Hildenbrand
Message-Id: <20210429112708.12291-11-da...@redhat.com>
On 13/05/21 10:25, Mirela Grujic wrote:
The existing code had to be restructured to make room for adding
checks that are specific to the machine phases.
The fix is related to the way that commands with the 'allow-preconfig'
option are treated.
Commands labelled with the 'allow-preconfig'
From: "Dr. David Alan Gilbert"
Accidental use of "true" as a boolean; spotted by coverity
and Peter.
Fixes: b99784ef6c3
Fixes: d795f47466e
Reported-by: Peter Maydell
Reported-by: Coverity (CID 1432373, 1432292, 1432288)
Signed-off-by: Dr. David Alan Gilbert
Message-Id:
From: Kunkun Jiang
When the host page is a huge page and something is sent in the
current iteration, migration_rate_limit() should be executed.
If not, it can be omitted.
Signed-off-by: Keqian Zhu
Signed-off-by: Kunkun Jiang
Reviewed-by: David Edmondson
Reviewed-by: Dr. David Alan Gilbert
From: David Hildenbrand
We want to make use of ram_block_discard_range() in the RAM block resize
callback when growing a RAM block, *before* used_length is changed.
Let's relax the check. As RAM blocks always mmap the whole max_length area,
we cannot corrupt unrelated data.
Reviewed-by: Peter
From: David Hildenbrand
We actually want to print the used_length, against which we check.
Reviewed-by: Dr. David Alan Gilbert
Signed-off-by: David Hildenbrand
Message-Id: <20210429112708.12291-10-da...@redhat.com>
Signed-off-by: Dr. David Alan Gilbert
---
migration/multifd.c | 2 +-
1 file
From: Kunkun Jiang
Starting from pss->page, ram_save_host_page() will check every page
and send the dirty pages up to the end of the current host page or
the boundary of used_length of the block. If the host page size is
a huge page, the step "check" will take a lot of time.
It will improve
From: David Hildenbrand
In case we grow our RAM after ram_postcopy_incoming_init() (e.g., when
synchronizing the RAM block state with the migration source), the resized
part would not get discarded. Let's perform that when being notified
about a resize while postcopy has been advised, but is not
From: David Hildenbrand
Factor it out into common code when a new notifier is registered, just
as done with the memory region notifier. This keeps logic about how to
process existing ram blocks at a central place.
Just like when adding a new ram block, we have to register the max_length.
Ram
From: David Hildenbrand
Ram block notifiers are currently not aware of resizes. To properly
handle resizes during migration, we want to teach ram block notifiers about
resizeable ram.
Introduce the basic infrastructure but keep using max_size in the
existing notifiers. Supply the max_size when
From: "Dr. David Alan Gilbert"
The following changes since commit dab59ce031228066eb95a9c518846fcacfb0dbbf:
Merge remote-tracking branch 'remotes/philmd/tags/pflash-20210511' into
staging (2021-05-13 14:45:38 +0100)
are available in the Git repository at:
git://github.com/dagrh/qemu.git
From: David Hildenbrand
The bulk stage is kind of weird: migration_bitmap_find_dirty() will
indicate a dirty page, however, ram_save_host_page() will never save it, as
migration_bitmap_clear_dirty() detects that it is not dirty.
We already fill the bitmap in ram_list_init_bitmaps() with ones,
On Fri, 30 Apr 2021 at 22:35, Richard Henderson
wrote:
>
> Split out a helper that can handle the 4-register
> format for helpers shared with SVE.
>
> Signed-off-by: Richard Henderson
> ---
> target/arm/translate-neon.c | 98 -
> 1 file changed, 43
Le 13/05/2021 à 19:04, Philippe Mathieu-Daudé a écrit :
> Cc'ing qemu-trivial@
Applied to my trivial-patches branch.
Thanks,
Laurent
> On 5/5/21 3:35 PM, Fred Konrad wrote:
>> Le 5/2/21 à 9:09 PM, Philippe Mathieu-Daudé a écrit :
>>> Running the WDR opcode triggers a segfault:
>>>
>>> $ cat
Inspired-by: Volker Rümelin
Signed-off-by: Philippe Mathieu-Daudé
---
hw/input/ps2.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/input/ps2.c b/hw/input/ps2.c
index 72cdb80ae1c..02d7e5da723 100644
--- a/hw/input/ps2.c
+++ b/hw/input/ps2.c
@@ -213,7 +213,7 @@
Andrey Shinkevich writes:
> Dear colleagues,
>
> Thank you all very much for your responses. Let me reply with one message.
>
> I configured QEMU for AARCH64 guest:
> $ ./configure --target-list=aarch64-softmmu
>
> When I start QEMU with GICv3 on an x86 host:
> qemu-system-aarch64 -machine
Cc'ing qemu-trivial@
On 5/5/21 3:35 PM, Fred Konrad wrote:
> Le 5/2/21 à 9:09 PM, Philippe Mathieu-Daudé a écrit :
>> Running the WDR opcode triggers a segfault:
>>
>> $ cat > foo.S << EOF
>> > __start:
>> > wdr
>> > EOF
>> $ avr-gcc -nostdlib -nostartfiles -mmcu=avr6 foo.S -o
** Changed in: qemu
Status: Incomplete => New
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1916343
Title:
-daemonize not working on macOS
Status in QEMU:
New
Bug description:
On Fri, 30 Apr 2021 at 22:29, Richard Henderson
wrote:
>
> Cut and paste error from another pattern.
>
> Signed-off-by: Richard Henderson
> ---
> target/arm/translate-neon.c | 3 ---
> 1 file changed, 3 deletions(-)
Reviewed-by: Peter Maydell
thanks
-- PMM
Forgot to Cc Alex.
On 5/13/21 6:38 PM, Philippe Mathieu-Daudé wrote:
> Cmmit 56b5170c87e ("semihosting: Move ARM semihosting code to
> shared directories"), added the ARM_COMPATIBLE_SEMIHOSTING symbol
> which selects SEMIHOSTING.
>
> Since the ARM/RISC-V targets select
On Thu, 13 May 2021 at 17:03, Marc-André Lureau
wrote:
> This should work, can you check?:
>
> diff --git a/docs/conf.py b/docs/conf.py
> index 3802b70d62..9e3d7cee0e 100644
> --- a/docs/conf.py
> +++ b/docs/conf.py
> @@ -29,6 +29,7 @@
> import os
> import sys
> import sphinx
> +from
1 - 100 of 354 matches
Mail list logo
