Re: [PATCH v3 1/9] qapi: replace List[str] by QAPISchemaIfCond

On 5/17/21 7:17 AM, Marc-André Lureau wrote: Hi On Thu, May 13, 2021 at 12:53 AM John Snow > wrote: On 4/29/21 9:40 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau mailto:marcandre.lur...@redhat.com>>

[PATCH v4 1/9] qapi: replace List[str] by QAPISchemaIfCond

From: Marc-André Lureau Wrap the 'if' condition in a higher-level object. Not only this allows more type safety but also further refactoring without too much churn. The following patches will change the syntax of the schema 'if' conditions to be predicate expressions, and will generate code for

[PULL 24/29] tests/tcg: don't allow clang as a cross compiler

Currently there are two problems. The first is clang generates a preamble (that is always executed) to stack xmm registers. This causes a ILLOP on the x86_64 softmmu tests as SSE isn't enabled. The second is the inline assembler in test-i386.c breaks clangs compiler and I don't know how to fix

Re: [PATCH 1/3] pc-bios/s390-ccw: Fix inline assembly for older versions of Clang

On Wed, 12 May 2021 19:15:48 +0200 Thomas Huth wrote: > Clang versions before v11.0 insist on having the %rX or %cX register > names instead of just a number. Since our Travis-CI is currently > still using Clang v6.0, we have to fix this to avoid failing jobs. > > Signed-off-by: Thomas Huth >

[PATCH v4 2/9] qapi: make gen_if/gen_endif take a simple string

From: Marc-André Lureau Instead of building prepocessor conditions from a list of string, use the result generated from QAPISchemaIfCond.cgen(). Signed-off-by: Marc-André Lureau --- scripts/qapi/common.py | 22 ++ scripts/qapi/gen.py| 4 ++--

[PATCH v4 0/9] qapi: untie 'if' conditions from C preprocessor

From: Marc-André Lureau Hi, This series makes the 'if' conditions less liberal, by formalizing a simple expression tree based on bare boolean logic of configure option identifiers. (this allows to express conditions in Rust in my QAPI-Rust PoC series) thanks v4: - keep gen_if/gen_endif in

Re: [PATCH 3/3] pc-bios/s390-ccw: Add a proper prototype for main()

On Wed, 12 May 2021 19:15:50 +0200 Thomas Huth wrote: > Older versions of Clang complain if there is no prototype for main(). > Add one, and while we're at it, make sure that we use the same type > for main.c and netmain.c - since the return value does not matter, > declare the return type of

Re: [RFC PATCH v3 6/9] hw/arm/virt-acpi-build: Use possible cpus in generation of MADT

Hi Drew, On 2021/5/17 15:42, Andrew Jones wrote: On Sun, May 16, 2021 at 06:28:57PM +0800, Yanan Wang wrote: When building ACPI tables regarding CPUs we should always build them for the number of possible CPUs, not the number of present CPUs. So we create gicc nodes in MADT for possible cpus

Re: [PATCH v6 04/26] plugins: Drop tcg_flags from struct qemu_plugin_dyn_cb

On 5/16/21 7:53 AM, Philippe Mathieu-Daudé wrote: -op->args[*cb_idx + 1] = tcg_flags; +op->args[*cb_idx + 1] = (*begin_op)->args[*cb_idx + 1]; I don't understand this change, can you explain? This patch drops a mostly-unimplemented feature from plugins, where in theory the

[PULL 25/29] configure: use cc, not host_cc to set cross_cc for build arch

Otherwise you run into hilarity like trying when cross compiling a 32 bit ARM build on a 64 bit system trying to use host_cc to build 32 bit test cases. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20210512102051.12134-32-alex.ben...@linaro.org> diff --git

[PULL 16/29] tests/tcg/tricore: Add fadd test

From: Bastian Koppelmann Signed-off-by: Bastian Koppelmann Signed-off-by: Alex Bennée Tested-by: Alex Bennée Message-Id: <20210305170045.869437-11-kbast...@mail.uni-paderborn.de> Message-Id: <20210512102051.12134-21-alex.ben...@linaro.org> diff --git

Re: [PATCH 06/21] block/backup: drop support for copy_range

On 17.05.21 08:44, Vladimir Sementsov-Ogievskiy wrote: copy_range is not a default behavior since 6a30f663d4c0b3c, and it's now available only though x-perf experimantal argument, so it's OK to drop it. Even when backup is used to copy disk to same filesystem, and filesystem supports zero-copy

[PULL 19/29] tests/tcg/tricore: Add madd test

From: Bastian Koppelmann Signed-off-by: Bastian Koppelmann Signed-off-by: Alex Bennée Tested-by: Alex Bennée Message-Id: <20210305170045.869437-14-kbast...@mail.uni-paderborn.de> Message-Id: <20210512102051.12134-24-alex.ben...@linaro.org> diff --git a/tests/tcg/tricore/macros.h

Re: [PATCH 1/5] docs: fix references to docs/devel/tracing.rst

On Mon, 17 May 2021 17:16:58 +0200 Stefano Garzarella wrote: > Commit e50caf4a5c ("tracing: convert documentation to rST") > converted docs/devel/tracing.txt to docs/devel/tracing.rst. > > We still have several references to the old file, so let's fix them > with the following command: > >

[PULL 14/29] tests/tcg/tricore: Add clz test

From: Bastian Koppelmann [AJB: dropped duplicate Makefile] Signed-off-by: Bastian Koppelmann Signed-off-by: Alex Bennée Tested-by: Alex Bennée Message-Id: <20210305170045.869437-9-kbast...@mail.uni-paderborn.de> Message-Id: <20210512102051.12134-19-alex.ben...@linaro.org> diff --git

[PULL 21/29] tests/tcg/tricore: Add muls test

From: Bastian Koppelmann Signed-off-by: Bastian Koppelmann Signed-off-by: Alex Bennée Tested-by: Alex Bennée Message-Id: <20210305170045.869437-16-kbast...@mail.uni-paderborn.de> Message-Id: <20210512102051.12134-26-alex.ben...@linaro.org> diff --git

Re: [PATCH 00/10] Python: delint iotests, machine.py and console_socket.py

On 5/12/21 5:46 PM, John Snow wrote: gitlab CI: https://gitlab.com/jsnow/qemu/-/pipelines/301924893 branch: https://gitlab.com/jsnow/qemu/-/commits/python-package-pre-cleanup This series serves as a pre-requisite for packaging the python series and getting the linters running via CI. The first

[PULL 18/29] tests/tcg/tricore: Add ftoi test

From: Bastian Koppelmann Signed-off-by: Bastian Koppelmann Signed-off-by: Alex Bennée Tested-by: Alex Bennée Message-Id: <20210305170045.869437-13-kbast...@mail.uni-paderborn.de> Message-Id: <20210512102051.12134-23-alex.ben...@linaro.org> diff --git a/tests/tcg/tricore/macros.h

[PULL 26/29] plugins: Update qemu-plugins.symbols to match qemu-plugins.h

From: Yonggang Luo Reorder the function symbols that consistence with qemu-plugins.h Signed-off-by: Yonggang Luo Signed-off-by: Alex Bennée Message-Id: <2021031818.434-2-luoyongg...@gmail.com> Message-Id: <20210505092259.8202-2-alex.ben...@linaro.org> diff --git

[PULL 23/29] tests/tcg: fix missing return

This was picked up when clang built the test. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20210512102051.12134-30-alex.ben...@linaro.org> diff --git a/tests/tcg/multiarch/system/memory.c b/tests/tcg/multiarch/system/memory.c index eb0ec6f8eb..41c7f66e2e 100644

Re: [PATCH 5/5] docs: fix references to docs/devel/s390-dasd-ipl.rst

On Mon, 17 May 2021 17:17:02 +0200 Stefano Garzarella wrote: > Commit cc3d15a5ea ("docs: rstfy s390 dasd ipl documentation") > converted docs/devel/s390-dasd-ipl.txt to docs/devel/s390-dasd-ipl.rst. > > We still have several references to the old file, so let's fix them > with the following

[PULL 20/29] tests/tcg/tricore: Add msub test

From: Bastian Koppelmann Signed-off-by: Bastian Koppelmann Signed-off-by: Alex Bennée Tested-by: Alex Bennée Message-Id: <20210305170045.869437-15-kbast...@mail.uni-paderborn.de> Message-Id: <20210512102051.12134-25-alex.ben...@linaro.org> diff --git

[PULL 11/29] configure: Emit HOST_CC to config-host.mak

From: Bastian Koppelmann this is needed by the tricore-tcg-tests as tricore-gcc is not easily available. Thus we rely on the HOST_CC to do the preprocessing of the tricore assembly files. Signed-off-by: Bastian Koppelmann Signed-off-by: Alex Bennée Message-Id:

[PULL 10/29] tests/tcg/tricore: Add build infrastructure

From: Bastian Koppelmann this includes the Makefile and linker script to build all the tests. Signed-off-by: Bastian Koppelmann Signed-off-by: Alex Bennée Reviewed-by: Alex Bennée Message-Id: <20210305170045.869437-5-kbast...@mail.uni-paderborn.de> Message-Id:

[PULL 15/29] tests/tcg/tricore: Add dvstep test

From: Bastian Koppelmann Signed-off-by: Bastian Koppelmann Signed-off-by: Alex Bennée Tested-by: Alex Bennée Message-Id: <20210305170045.869437-10-kbast...@mail.uni-paderborn.de> Message-Id: <20210512102051.12134-20-alex.ben...@linaro.org> diff --git a/tests/tcg/tricore/macros.h

[PULL 07/29] tests/docker: Added libbpf library to the docker files.

From: Andrew Melnychenko The series of patches for eBPF RSS adds libbpf dependency for qemu. https://lists.gnu.org/archive/html/qemu-devel/2021-03/msg08887.html With this patch, libbpf added: Alpine - added libbpf-dev Centos 8 - added libbpf-devel Fedora - added libbpf-devel

[PULL 28/29] plugins/hotblocks: Properly freed the hash table values

From: Mahmoud Mandour Freed the values stored in the hash table ``hotblocks`` returned by ``g_hash_table_get_values()`` by freeing the sorted list and destroyed the hash table afterward. Signed-off-by: Mahmoud Mandour Signed-off-by: Alex Bennée Message-Id:

Re: [PATCH v12 3/8] arm64: mte: Sync tags for pages where PTE is untagged

On Mon, 17 May 2021 13:32:34 +0100, Steven Price wrote: > > A KVM guest could store tags in a page even if the VMM hasn't mapped > the page with PROT_MTE. So when restoring pages from swap we will > need to check to see if there are any saved tags even if !pte_tagged(). > > However don't check

[PULL 12/29] tests/tcg/tricore: Add macros to create tests and first test 'abs'

From: Bastian Koppelmann This kind of tests is inspired by the riscv-tests repository. This adds macros that makes it easy to create single instruction self containing tests. It is achieved by macros that create a test sequence for an instruction and check for a supplied correct value. If the

[PULL 06/29] tests/tcg: Use Hexagon Docker image

From: Alessandro Di Federico [PMD: Split from 'Add Hexagon Docker image' patch] [AJB: add container_hosts] Signed-off-by: Alessandro Di Federico Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée Tested-by: Philippe Mathieu-Daudé Reviewed-by: Philippe Mathieu-Daudé

[PULL 04/29] tests/docker: add "fetch" sub-command

This simply wraps up fetching a build from the registry and tagging it as the local build. Signed-off-by: Alex Bennée Reviewed-by: Willian Rampazzo Message-Id: <20210512102051.12134-6-alex.ben...@linaro.org> diff --git a/tests/docker/docker.py b/tests/docker/docker.py index

[PULL 13/29] tests/tcg/tricore: Add bmerge test

From: Bastian Koppelmann Signed-off-by: Bastian Koppelmann Signed-off-by: Alex Bennée Tested-by: Alex Bennée Message-Id: <20210305170045.869437-8-kbast...@mail.uni-paderborn.de> Message-Id: <20210512102051.12134-18-alex.ben...@linaro.org> diff --git a/tests/tcg/tricore/macros.h

[PULL 03/29] tests/docker: allow "update" to add the current user

The current user functionality is used for cross compiling to avoid complications with permissions when building test programs. However for images that come from the registry we still need the ability to add the user after the fact. Signed-off-by: Alex Bennée Reviewed-by: Willian Rampazzo

[PULL 08/29] tests/tcg: Run timeout cmds using --foreground

From: Bastian Koppelmann when trying to run successful short tests from the Makefile timeout would not terminate. Rather it would wait until the time runs out. Excerpt from the manpage: --foreground when not running timeout directly from a shell prompt, allow COMMAND to read from the

[PULL 05/29] docker: Add Hexagon image

This image is a little special because it takes a long time to build. As such most users don't want to be doing that and just pull random binaries from the ether as intended by the container gods. This involves someone with credentials and a beefy machine running: make

[PULL 01/29] tests/docker: fix copying of executable in "update"

We have the same symlink chasing problem when doing an "update" operation. Fix that. Signed-off-by: Alex Bennée Reviewed-by: Willian Rampazzo Inspired-by: 5e33f7fead ("tests/docker: better handle symlinked libs") Message-Id: <20210512102051.12134-3-alex.ben...@linaro.org> diff --git

Re: [PATCH 0/5] docs: fix references to files converted to rST

On 5/17/21 5:16 PM, Stefano Garzarella wrote: > Trivial patches that fix references to old files in docs/ converted > to rST. > > Broken references found running: > > for f in $(git grep -oh "docs.*txt") > do > test -f "$f" || echo "$f not exists" > done > > Stefano

[PULL 02/29] tests/docker: make executable an optional argument to "update"

We're going to extend the abilities of the command shortly. Signed-off-by: Alex Bennée Reviewed-by: Willian Rampazzo Message-Id: <20210512102051.12134-4-alex.ben...@linaro.org> diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include index 9f464cb92c..820423d718 100644 ---

[PULL 09/29] hw/tricore: Add testdevice for tests in tests/tcg/

From: Bastian Koppelmann this device is used to verify the correctness of regression tests by allowing guests to write their exit status to this device. This is then used by qemu to exit using the written status. Signed-off-by: Bastian Koppelmann Signed-off-by: Alex Bennée Reviewed-by: Alex

[PULL 00/29] testing and plugin updates

The following changes since commit 6005ee07c380cbde44292f5f6c96e7daa70f4f7d: Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2021-05-16 17:22:46 +0100) are available in the Git repository at: https://github.com/stsquad/qemu.git

Re: [RFC PATCH 08/11] target/ppc: wrapped some TCG only logic with ifdefs

On 5/16/21 11:10 PM, David Gibson wrote: Removing excp_helper.c gives linker errors for the functions: * ppc_cpu_do_system_reset, on hw/ppc/pnv.c and hw/ppc/spapr.c Oof, that's a bit tricky. We definitely do need this system reset injection for KVM as well as TCG. Unfortunately it calls

Re: [PATCH 05/21] block: rename backup-top to copy-before-write

On 17.05.21 08:44, Vladimir Sementsov-Ogievskiy wrote: We are going to convert backup_top to full featured public filter, which can be used in separate of backup job. Start from renaming from "how it used" to "what it does". Is this safe? The name was externally visible in queries after all.

Re: [RFC PATCH v3 8/9] hw/arm/virt-acpi-build: Generate PPTT table

On 2021/5/17 22:45, Andrew Jones wrote: On Mon, May 17, 2021 at 09:43:34PM +0800, wangyanan (Y) wrote: BTW, it seems patch 1 and 5 were possibly missed for some review. Any comments for them too? Thanks! I reviewed them and agreed with them, but you already provided my s-o-b on them, so I

Re: [PATCH 50/72] softfloat: Move minmax_flags to softfloat-parts.c.inc

On 5/17/21 8:14 AM, David Hildenbrand wrote: This patch introduces two issues: 1. Comparing two negative numbers is broken. We have to invert the a_less result. 2. The check "flags & minmax_ismag" is broken because "minmax_ismag = 4 | minmax_isnum" and it, therefore, also triggers for "flags =

Re: [PATCH 01/21] block: introduce bdrv_replace_child_bs()

On 17.05.21 16:30, Vladimir Sementsov-Ogievskiy wrote: 17.05.2021 15:09, Max Reitz wrote: On 17.05.21 08:44, Vladimir Sementsov-Ogievskiy wrote: Add function to transactionally replace bs inside BdrvChild. Signed-off-by: Vladimir Sementsov-Ogievskiy ---   include/block/block.h |  2 ++  

[Bug 1883268] Re: random errors on aarch64 when executing __aarch64_cas8_acq_rel

Opened ticket on gitlab: https://gitlab.com/qemu- project/qemu/-/issues/333 ** Bug watch added: gitlab.com/qemu-project/qemu/-/issues #333 https://gitlab.com/qemu-project/qemu/-/issues/333 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed

Re: [PATCH v6 77/82] target/arm: Fix decode for VDOT (indexed)

On 5/16/21 11:09 AM, Peter Maydell wrote: On Sat, 15 May 2021 at 18:13, Richard Henderson wrote: On 5/13/21 2:25 PM, Peter Maydell wrote: -VDOT_scalar 1110 0 . 10 1101 . q:1 index:1 u:1 rm:4 \ - vm=%vm_dp vn=%vn_dp vd=%vd_dp +VDOT_scalar 1110 0 . 10

Re: [PATCH 04/21] qdev: allow setting drive property for realized device

On 17.05.21 08:44, Vladimir Sementsov-Ogievskiy wrote: We need an ability to insert filters above top block node, attached to block device. It can't be achieved with blockdev-reopen command. So, we want do it with help of qom-set. Intended usage: 1. blockdev-add, creating the filter, which

Re: [Qemu-devel] [PATCH 7/7] target/xtensa: move non-HELPER functions to helper.c

On Mon, May 17, 2021 at 8:25 AM Max Filippov wrote: > > On Mon, May 17, 2021 at 6:10 AM Philippe Mathieu-Daudé > wrote: > > > > On 5/17/21 2:11 PM, Max Filippov wrote: > > > On Mon, May 17, 2021 at 4:50 AM Max Filippov wrote: > > >> > > >> Hi Philippe, > > >> > > >> On Sun, May 16, 2021 at

Re: [PATCH v5 0/7] eBPF RSS support for virtio-net

On Fri, May 14, 2021 at 4:43 PM Michael S. Tsirkin wrote: > > On Thu, Mar 25, 2021 at 05:35:22PM +0200, Andrew Melnychenko wrote: > > This set of patches introduces the usage of eBPF for packet steering > > and RSS hash calculation: > > * RSS(Receive Side Scaling) is used to distribute network

Re: [Qemu-devel] [PATCH 7/7] target/xtensa: move non-HELPER functions to helper.c

On Mon, May 17, 2021 at 6:10 AM Philippe Mathieu-Daudé wrote: > > On 5/17/21 2:11 PM, Max Filippov wrote: > > On Mon, May 17, 2021 at 4:50 AM Max Filippov wrote: > >> > >> Hi Philippe, > >> > >> On Sun, May 16, 2021 at 10:05 PM Philippe Mathieu-Daudé > >> wrote: > >>> > >>> Hi Max, > >>> > >>>

[PATCH 5/5] docs: fix references to docs/devel/s390-dasd-ipl.rst

Commit cc3d15a5ea ("docs: rstfy s390 dasd ipl documentation") converted docs/devel/s390-dasd-ipl.txt to docs/devel/s390-dasd-ipl.rst. We still have several references to the old file, so let's fix them with the following command: sed -i s/s390-dasd-ipl.txt/s390-dasd-ipl.rst/ \ $(git grep

RE: [RFC PATCH v3 4/4] hw/arm/virt: Parse -smp cluster parameter in virt_smp_parse

> From: Qemu-devel > [mailto:qemu-devel-bounces+salil.mehta=huawei@nongnu.org] On Behalf Of > Yanan Wang > Sent: Sunday, May 16, 2021 11:32 AM > To: Peter Maydell ; Paolo Bonzini > ; Andrew Jones ; Michael S . Tsirkin > ; Igor Mammedov ; Shannon Zhao > ; qemu-devel@nongnu.org;

[PATCH 4/5] docs: fix references to docs/specs/tpm.rst

Commit 6e8a3ff6ed ("docs/specs/tpm: reST-ify TPM documentation") converted docs/specs/tpm.txt to docs/specs/tpm.rst. We still have several references to the old file, so let's fix them with the following command: sed -i s/tpm.txt/tpm.rst/ $(git grep -l docs/specs/tpm.txt) Signed-off-by:

[PATCH 0/5] docs: fix references to files converted to rST

Trivial patches that fix references to old files in docs/ converted to rST. Broken references found running: for f in $(git grep -oh "docs.*txt") do test -f "$f" || echo "$f not exists" done Stefano Garzarella (5): docs: fix references to docs/devel/tracing.rst docs: fix

[PATCH 1/5] docs: fix references to docs/devel/tracing.rst

Commit e50caf4a5c ("tracing: convert documentation to rST") converted docs/devel/tracing.txt to docs/devel/tracing.rst. We still have several references to the old file, so let's fix them with the following command: sed -i s/tracing.txt/tracing.rst/ $(git grep -l docs/devel/tracing.txt)

[PATCH 3/5] docs: fix references to docs/devel/build-system.rst

Commit a14f0bf165 ("docs: convert build system documentation to rST") converted docs/devel/build-system.txt to docs/devel/build-system.rst. We still have several references to the old file, so let's fix them with the following command: sed -i s/build-system.txt/build-system.rst/ \ $(git

[PATCH 2/5] docs: fix references to docs/devel/atomics.rst

Commit 15e8699f00 ("atomics: convert to reStructuredText") converted docs/devel/atomics.txt to docs/devel/atomics.rst. We still have several references to the old file, so let's fix them with the following command: sed -i s/atomics.txt/atomics.rst/ $(git grep -l docs/devel/atomics.txt)

Re: [RFC PATCH v3 4/4] hw/arm/virt: Parse -smp cluster parameter in virt_smp_parse

Hi Drew, On 2021/5/17 17:12, Andrew Jones wrote: On Sun, May 16, 2021 at 06:32:28PM +0800, Yanan Wang wrote: There is a separate function virt_smp_parse() in hw/virt/arm.c used to parse cpu topology for the ARM machines. So add parsing of -smp cluster parameter in it, then total number of

Re: [RFC PATCH v3 1/4] vl.c: Add -smp, clusters=* command line support for ARM cpu

On 2021/5/17 17:07, Andrew Jones wrote: On Sun, May 16, 2021 at 06:32:25PM +0800, Yanan Wang wrote: In implementations of ARM architecture, at most there could be a cpu hierarchy like "sockets/dies/clusters/cores/threads" defined. For example, ARM64 server chip Kunpeng 920 totally has 2

[Bug 1924912] Re: VirtIO drivers don't work on Windows: "GLib: Too many handles to wait for!" crash

Moved to https://gitlab.com/qemu-project/qemu/-/issues/332 ** Changed in: qemu Status: Incomplete => Fix Released ** Bug watch added: gitlab.com/qemu-project/qemu/-/issues #332 https://gitlab.com/qemu-project/qemu/-/issues/332 -- You received this bug notification because you are a

Re: [RFC PATCH v3 3/9] hw/arm/virt: Add cpu-map to device tree

Hi Drew, On 2021/5/17 14:41, Andrew Jones wrote: On Sun, May 16, 2021 at 06:28:54PM +0800, Yanan Wang wrote: From: Andrew Jones Support device tree CPU topology descriptions. In accordance with the Devicetree Specification, the Linux Doc "arm/cpus.yaml" requires that cpus and cpu nodes in

Re: [PATCH v2 3/7] ACPI ERST: support for ACPI ERST feature

Hi Igor, I've been working to transition ERST to use the hostmem-file object as the backing store, as requested. I have the backend-file object now in ERST, and I have a question for you. This hostmem-file initializes itself from a file, but in looking at the code, I do not see that it ever

Re: [PATCH 14/14] machine: add smp compound property

On Thu, 13 May 2021 12:29:01 -0400 Paolo Bonzini wrote: > Make -smp syntactic sugar for a compound property "-machine > smp.{cores,threads,cpu,...}". machine_smp_parse is replaced by the > setter for the property. > > numa-test will now cover the new syntax, while other tests > still use -smp.

[PATCH v3 3/5] blkdebug: track all actions

Add a counter for each action that a rule can trigger. This is mainly used to keep track of how many coroutine_yield() we need to perform after processing all rules in the list. Co-developed-by: Paolo Bonzini Signed-off-by: Emanuele Giuseppe Esposito --- block/blkdebug.c | 17 -

Re: [PATCH 1/3] virtiofsd: Find original inode ID of mount points

On Wed, May 12, 2021 at 02:55:42PM +0200, Max Reitz wrote: > Mount point directories represent two inodes: On one hand, they are a > normal directory on their parent filesystem. On the other, they are the > root node of the filesystem mounted there. Thus, they have two inode > IDs. > > Right

[PATCH v3 1/5] blkdebug: refactor removal of a suspended request

Extract to a separate function. Do not rely on FOREACH_SAFE, which is only "safe" if the *current* node is removed---not if another node is removed. Instead, just walk the entire list from the beginning when asked to resume all suspended requests with a given tag. Co-developed-by: Paolo Bonzini

Re: [PATCH v12 1/8] arm64: mte: Handle race when synchronising tags

On 17/05/2021 15:03, Marc Zyngier wrote: > Hi Steven, Hi Marc, > On Mon, 17 May 2021 13:32:32 +0100, > Steven Price wrote: >> >> mte_sync_tags() used test_and_set_bit() to set the PG_mte_tagged flag >> before restoring/zeroing the MTE tags. However if another thread were to >> race and attempt

[PATCH v3 5/5] blkdebug: protect rules and suspended_reqs with a lock

Co-developed-by: Paolo Bonzini Signed-off-by: Emanuele Giuseppe Esposito --- block/blkdebug.c | 53 1 file changed, 40 insertions(+), 13 deletions(-) diff --git a/block/blkdebug.c b/block/blkdebug.c index dffd869b32..cf8b088ce7 100644 ---

[PATCH v3 2/5] blkdebug: move post-resume handling to resume_req_by_tag

We want to move qemu_coroutine_yield() after the loop on rules, because QLIST_FOREACH_SAFE is wrong if the rule list is modified while the coroutine has yielded. Therefore move the suspended request to the heap and clean it up from the remove side. All that is left is for blkdebug_debug_event to

Re: [PATCH 2/2] tests/tcg/x86_64: add vsyscall smoke test

On Mon, 2021-05-17 at 14:52 +0200, Cornelia Huck wrote: > On Wed, 12 May 2021 06:02:50 +0200 > Ilya Leoshkevich wrote: > > > Having a small test will prevent trivial regressions in the future. > > > > Signed-off-by: Ilya Leoshkevich > > --- > >  tests/tcg/x86_64/Makefile.target |  6 +- > >

[PATCH v3 4/5] blkdebug: do not suspend in the middle of QLIST_FOREACH_SAFE

That would be unsafe in case a rule other than the current one is removed while the coroutine has yielded. Keep FOREACH_SAFE because suspend_request deletes the current rule. After this patch, *all* matching rules are deleted before suspending the coroutine, rather than just one. This doesn't

[PATCH v3 0/5] blkdebug: fix racing condition when iterating on

When qemu_coroutine_enter is executed in a loop (even QEMU_FOREACH_SAFE), the new routine can modify the list, for example removing an element, causing problem when control is given back to the caller that continues iterating on the same list. Patch 1 solves the issue in blkdebug_debug_resume by

Re: [PATCH 03/21] qdev-properties: PropertyInfo: add realized_set_allowed field

17.05.2021 15:40, Max Reitz wrote: On 17.05.21 08:44, Vladimir Sementsov-Ogievskiy wrote: Add field, so property can declare support for setting the property when device is realized. To be used in the following commit. Signed-off-by: Vladimir Sementsov-Ogievskiy ---  

[PATCH v2 24/26] s390x/tcg: Implement VECTOR FP (MAXIMUM|MINIMUM)

For IEEE functions, we can reuse the softfloat implementations. For the other functions, implement it generically for 32bit/64bit/128bit - carefully taking care of all weird special cases according to the tables defined in the PoP. Signed-off-by: David Hildenbrand --- target/s390x/helper.h

[PATCH v2 25/26] s390x/tcg: We support Vector enhancements facility

Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/gen-features.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/s390x/gen-features.c b/target/s390x/gen-features.c index a6ec918e90..219b1f9420 100644 --- a/target/s390x/gen-features.c +++

[PATCH v2 22/26] s390x/tcg: Implement VECTOR FP NEGATIVE MULTIPLY AND (ADD|SUBTRACT)

Signed-off-by: David Hildenbrand --- target/s390x/helper.h | 6 + target/s390x/insn-data.def | 4 target/s390x/translate_vx.c.inc | 39 +++-- target/s390x/vec_fpu_helper.c | 2 ++ 4 files changed, 49 insertions(+), 2 deletions(-) diff

Re: [RFC PATCH v3 8/9] hw/arm/virt-acpi-build: Generate PPTT table

On Mon, May 17, 2021 at 09:43:34PM +0800, wangyanan (Y) wrote: > BTW, it seems patch 1 and 5 were possibly missed for some review. > Any comments for them too? Thanks! I reviewed them and agreed with them, but you already provided my s-o-b on them, so I didn't bother giving an r-b. Feel free to

[PATCH v2 19/26] s390x/tcg: Implement 32/128 bit for VECTOR FP PERFORM SIGN OPERATION

Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/translate_vx.c.inc | 106 ++-- 1 file changed, 73 insertions(+), 33 deletions(-) diff --git a/target/s390x/translate_vx.c.inc b/target/s390x/translate_vx.c.inc index

[PATCH v2 20/26] s390x/tcg: Implement 32/128 bit for VECTOR FP TEST DATA CLASS IMMEDIATE

Signed-off-by: David Hildenbrand --- target/s390x/helper.h | 2 ++ target/s390x/translate_vx.c.inc | 23 ++-- target/s390x/vec_fpu_helper.c | 47 + 3 files changed, 70 insertions(+), 2 deletions(-) diff --git a/target/s390x/helper.h

Re: [PATCH 01/21] block: introduce bdrv_replace_child_bs()

17.05.2021 15:09, Max Reitz wrote: On 17.05.21 08:44, Vladimir Sementsov-Ogievskiy wrote: Add function to transactionally replace bs inside BdrvChild. Signed-off-by: Vladimir Sementsov-Ogievskiy ---   include/block/block.h |  2 ++   block.c   | 36

[PATCH v2 15/26] s390x/tcg: Implement 32/128 bit for VECTOR FP COMPARE *

In addition to 32/128bit variants, we also have to support the "Signal-on-QNaN (SQ)" bit. Signed-off-by: David Hildenbrand --- target/s390x/helper.h | 12 +++ target/s390x/translate_vx.c.inc | 57 - target/s390x/vec_fpu_helper.c | 64

[PATCH v2 12/26] s390x/tcg: Implement VECTOR MULTIPLY SUM LOGICAL

Fortunately, we only need the Doubleword implementation. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/insn-data.def | 2 ++ target/s390x/translate_vx.c.inc | 50 + 2 files changed, 52 insertions(+) diff --git

[PATCH v2 17/26] s390x/tcg: Implement 64 bit for VECTOR FP LOAD LENGTHENED

64 bit -> 128 bit, there is only a single final element. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/helper.h | 1 + target/s390x/translate_vx.c.inc | 19 --- target/s390x/vec_fpu_helper.c | 13 + 3 files changed, 30

[PATCH v2 14/26] s390x/tcg: Implement 32/128 bit for VECTOR (LOAD FP INTEGER|FP SQUARE ROOT)

Signed-off-by: David Hildenbrand --- target/s390x/helper.h | 4 ++ target/s390x/translate_vx.c.inc | 74 ++--- target/s390x/vec_fpu_helper.c | 46 +++- 3 files changed, 109 insertions(+), 15 deletions(-) diff --git a/target/s390x/helper.h

[PATCH v2 18/26] s390x/tcg: Implement 128 bit for VECTOR FP LOAD ROUNDED

128 bit -> 64 bit, there is only a single element to process. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/helper.h | 1 + target/s390x/translate_vx.c.inc | 11 ++- target/s390x/vec_fpu_helper.c | 19 +++ 3 files changed,

[PATCH v2 13/26] s390x/tcg: Implement 32/128 bit for VECTOR FP (ADD|DIVIDE|MULTIPLY|SUBTRACT)

In case of 128bit, we always have a single element. Add new helpers for reading/writing 32/128 bit floats. Signed-off-by: David Hildenbrand --- target/s390x/helper.h | 8 target/s390x/translate_vx.c.inc | 85 + target/s390x/vec_fpu_helper.c | 74

[PATCH v2 07/26] s390x/tcg: Simplify vfma64() handling

Signed-off-by: David Hildenbrand --- target/s390x/helper.h | 2 -- target/s390x/translate_vx.c.inc | 8 +++ target/s390x/vec_fpu_helper.c | 42 + 3 files changed, 20 insertions(+), 32 deletions(-) diff --git a/target/s390x/helper.h

Re: [PATCH v1] softmmu/vl: make default prealloc-threads work w/o -mem-prealloc

On Thu, 11 Mar 2021 11:59:18 +0300 Denis Plotnikov wrote: > Preallocation in memory backends can be specified with either global > QEMU option "-mem-prealloc", or with per-backend property > "prealloc=true". In the latter case, however, the default for the > number of preallocation threads is

[PATCH v2 16/26] s390x/tcg: Implement 32/128 bit for VECTOR FP COMPARE (AND SIGNAL) SCALAR

Signed-off-by: David Hildenbrand --- target/s390x/helper.h | 4 +++ target/s390x/translate_vx.c.inc | 38 ++-- target/s390x/vec_fpu_helper.c | 44 - 3 files changed, 77 insertions(+), 9 deletions(-) diff --git

[PATCH v2 08/26] s390x/tcg: Simplify vfll32() handling

Signed-off-by: David Hildenbrand --- target/s390x/helper.h | 1 - target/s390x/translate_vx.c.inc | 6 +- target/s390x/vec_fpu_helper.c | 21 + 3 files changed, 6 insertions(+), 22 deletions(-) diff --git a/target/s390x/helper.h b/target/s390x/helper.h

[PATCH v2 06/26] s390x/tcg: Simplify vftci64() handling

Signed-off-by: David Hildenbrand --- target/s390x/helper.h | 1 - target/s390x/translate_vx.c.inc | 7 ++- target/s390x/vec_fpu_helper.c | 29 +++-- 3 files changed, 13 insertions(+), 24 deletions(-) diff --git a/target/s390x/helper.h

[PATCH v2 26/26] s390x/cpumodel: Bump up QEMU model to a stripped-down IBM z14 GA2

TCG implements everything we need to run basic z14 OS+software. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- hw/s390x/s390-virtio-ccw.c | 3 +++ target/s390x/cpu_models.c | 4 ++-- target/s390x/gen-features.c | 15 +-- 3 files changed, 14 insertions(+),

[PATCH v2 11/26] s390x/tcg: Implement VECTOR BIT PERMUTE

Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/helper.h | 1 + target/s390x/insn-data.def | 2 ++ target/s390x/translate_vx.c.inc | 8 target/s390x/vec_helper.c | 22 ++ 4 files changed, 33 insertions(+)

[PATCH v2 05/26] s390x/tcg: Simplify vfc64() handling

Pass the m5 field via simd_data() and don't provide specialized handlers for single-element variants. Signed-off-by: David Hildenbrand --- target/s390x/helper.h | 6 --- target/s390x/translate_vx.c.inc | 45 +--- target/s390x/vec_fpu_helper.c | 94

[PATCH v2 02/26] s390x/tcg: Fix instruction name for VECTOR FP LOAD (LENGTHENED|ROUNDED)

Let's use the correct name. Signed-off-by: David Hildenbrand --- target/s390x/insn-data.def | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/s390x/insn-data.def b/target/s390x/insn-data.def index 0bb1886a2e..35a0086a85 100644 --- a/target/s390x/insn-data.def +++

[PATCH v2 23/26] softfloat: Implement float128_(min|minnum|minnummag|max|maxnum|maxnummag)

With Richard's softfloat rework, the float128 implementation is straight-forward. Unfortuantely, we don't have any tests we can simply adjust/unlock. Cc: Aurelien Jarno Cc: Peter Maydell Cc: "Alex Bennée" Cc: Richard Henderson Signed-off-by: David Hildenbrand --- fpu/softfloat.c |

[PATCH v2 10/26] s390x/tcg: Simplify wfc64() handling

... and prepare for 32/128 bit support. Signed-off-by: David Hildenbrand --- target/s390x/vec_fpu_helper.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/target/s390x/vec_fpu_helper.c b/target/s390x/vec_fpu_helper.c index d07bc7cd64..219ef19d24

[PATCH v2 03/26] s390x/tcg: Simplify vop64_3() handling

Let's simplify, reworking our handler generation, passing the whole "m5" register content and not providing specialized handlers for "se", and reading/writing proper float64 values using new helpers. Suggested-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/helper.h

[PATCH v2 01/26] s390x/tcg: Fix FP CONVERT TO (LOGICAL) FIXED NaN handling

In case we encounter a NaN, we have to return the smallest possible number, corresponding to either 0 or the maximum negative number. This seems to differ from IEEE handling as implemented in softfloat, whereby we return the biggest possible number. While at it, use float32_to_uint64() in the

<    1   2   3   4   5   6   7   >