Re: [PATCH v1] hw/input/ps2: Use ps2_raise_irq() instead of open coding it

2021-05-30 Thread Ani Sinha
My apologies … please ignore … On Mon, May 31, 2021 at 11:21 Ani Sinha wrote: > From: Philippe Mathieu-Daudé > > Inspired-by: Volker Rümelin > Signed-off-by: Philippe Mathieu-Daudé > Reviewed-by: Volker Rümelin > Reviewed-by: Bin Meng > Message-Id:

[PATCH v2 09/11] linux-user: Make the qemu detection for /proc/$pid/exe a bit conservative

2021-05-30 Thread YAMAMOTO Takashi
Perform the qemu special case only when the binary seems the same as our own executable. This is enough for my use case (docker and runc) where the involved qemu binaries are always for the same arch. Signed-off-by: YAMAMOTO Takashi --- linux-user/syscall.c | 38

[PATCH v2 07/11] linux-user: simplify is_proc_myself

2021-05-30 Thread YAMAMOTO Takashi
Signed-off-by: YAMAMOTO Takashi --- linux-user/syscall.c | 23 +++ 1 file changed, 3 insertions(+), 20 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 999760448d..86b12cc8b4 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -8027,26

[PATCH v2 08/11] linux-user: Implement exec of /proc/$pid/exe of qemu process

2021-05-30 Thread YAMAMOTO Takashi
dockerd makes runc invoke dockerd using /proc/$pid/exe. This commit makes it work when both of dockerd and runc are emulated by qemu linux-user. In that case, we (the qemu interpreting runc) need to invoke the real executable (dockerd), where /proc/$pid/exe in question is the qemu command

[PATCH v2 06/11] linux-user: add get_exe_path

2021-05-30 Thread YAMAMOTO Takashi
Refactor to prepare the special cases for /proc/$pid/exe where pid is not the calling process. Signed-off-by: YAMAMOTO Takashi --- linux-user/syscall.c | 48 ++-- 1 file changed, 46 insertions(+), 2 deletions(-) diff --git a/linux-user/syscall.c

[PATCH v2 05/11] linux-user: Implement pivot_root

2021-05-30 Thread YAMAMOTO Takashi
Used by runc. Signed-off-by: YAMAMOTO Takashi --- linux-user/syscall.c | 21 + 1 file changed, 21 insertions(+) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 2947e79dc0..51144c6d29 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -8254,6

[PATCH v2 00/11] linux-user changes to run docker

2021-05-30 Thread YAMAMOTO Takashi
These patches allowed me to run arm64 and armv7 version of dind image on amd64. This patchset includes a few patches marked [!MERGE], which are not for the upsteam merge. They are included here just to show the context to reviewers. You can find my test setup here:

[PATCH v2 04/11] linux-user: make exec_path realpath

2021-05-30 Thread YAMAMOTO Takashi
Otherwise, it can be easily fooled by the user app using chdir(). Signed-off-by: YAMAMOTO Takashi --- linux-user/main.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/linux-user/main.c b/linux-user/main.c index a9d02f9583..be604a84f9 100644 ---

[PATCH v2 02/11] linux-user: Fix the execfd case of /proc/self/exe open

2021-05-30 Thread YAMAMOTO Takashi
It's problematic to return AT_EXECFD as it is because the user app would close it. This patch opens it via /proc/self/fd instead. Signed-off-by: YAMAMOTO Takashi --- linux-user/syscall.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/linux-user/syscall.c

[PATCH v2 01/11] linux-user: handle /proc/self/exe for execve

2021-05-30 Thread YAMAMOTO Takashi
It seems somehow common to execve /proc/self/exe in docker or golang community these days. At least, moby "reexec" and runc "libcontainer" do that. Signed-off-by: YAMAMOTO Takashi --- linux-user/syscall.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git

[PATCH v2 03/11] linux-user: dup the execfd on start up

2021-05-30 Thread YAMAMOTO Takashi
So that it can be used for other purposes (e.g. syscall.c) after the elf loader closed it. Signed-off-by: YAMAMOTO Takashi --- linux-user/main.c| 10 +- linux-user/qemu.h| 2 ++ linux-user/syscall.c | 5 ++--- 3 files changed, 13 insertions(+), 4 deletions(-) diff --git

Re: [PATCH v4] i386: Add ratelimit for bus locks acquired in guest

2021-05-30 Thread Chenyi Qiang
On 5/28/2021 5:19 AM, Eduardo Habkost wrote: On Fri, May 21, 2021 at 12:38:20PM +0800, Chenyi Qiang wrote: [...] @@ -4222,6 +4247,15 @@ void kvm_arch_pre_run(CPUState *cpu, struct kvm_run *run) } } +static void kvm_rate_limit_on_bus_lock(void) +{ +uint64_t delay_ns =

Re: [PATCH] tests/vm: update openbsd to release 6.9

2021-05-30 Thread Gerd Hoffmann
On Sun, May 30, 2021 at 10:01:28PM -0400, Brad Smith wrote: > tests/vm: update openbsd to release 6.9 > > Signed-off-by: Brad Smith Tested-by: Gerd Hoffmann

Re: [PATCH] replay: improve determinism of virtio-net

2021-05-30 Thread Jason Wang
在 2021/5/17 下午9:04, Pavel Dovgalyuk 写道: virtio-net device uses bottom halves for callbacks. These callbacks should be deterministic, because they affect VM state. This patch replaces BH invocations with corresponding replay functions, making them deterministic in record/replay mode. This patch

Re: [PATCH] virtio: disable ioeventfd for record/replay

2021-05-30 Thread Pavel Dovgalyuk
ping On 17.05.2021 16:06, Pavel Dovgalyuk wrote: virtio devices support separate iothreads waiting for events from file descriptors. These are asynchronous events that can't be recorded and replayed, therefore this patch disables ioeventfd for all devices when record or replay is enabled.

Re: [PATCH] replay: fix event queue flush for qemu shutdown

2021-05-30 Thread Pavel Dovgalyuk
ping On 17.05.2021 16:05, Pavel Dovgalyuk wrote: This patch fixes event queue flush in the case of emulator shutdown. replay_finish_events should be called when replay_mode is not cleared. Signed-off-by: Pavel Dovgalyuk --- replay/replay.c |3 +-- 1 file changed, 1 insertion(+), 2

Re: [PATCH] replay: improve determinism of virtio-net

2021-05-30 Thread Pavel Dovgalyuk
ping On 17.05.2021 16:04, Pavel Dovgalyuk wrote: virtio-net device uses bottom halves for callbacks. These callbacks should be deterministic, because they affect VM state. This patch replaces BH invocations with corresponding replay functions, making them deterministic in record/replay mode.

[PATCH v1 3/3] hw/riscv: OpenTitan: Connect the mtime and mtimecmp timer

2021-05-30 Thread Alistair Francis
Signed-off-by: Alistair Francis --- include/hw/riscv/opentitan.h | 5 - hw/riscv/opentitan.c | 14 +++--- 2 files changed, 15 insertions(+), 4 deletions(-) diff --git a/include/hw/riscv/opentitan.h b/include/hw/riscv/opentitan.h index aab9bc9245..86cceef698 100644 ---

[PATCH v1 2/3] hw/timer: Initial commit of Ibex Timer

2021-05-30 Thread Alistair Francis
Signed-off-by: Alistair Francis --- include/hw/timer/ibex_timer.h | 52 ++ hw/timer/ibex_timer.c | 305 ++ MAINTAINERS | 6 +- hw/timer/meson.build | 1 + 4 files changed, 360 insertions(+), 4 deletions(-) create mode

[PATCH v1 1/3] hw/char/ibex_uart: Make the register layout private

2021-05-30 Thread Alistair Francis
We don't need to expose the register layout in the public header, so don't. Signed-off-by: Alistair Francis --- include/hw/char/ibex_uart.h | 37 - hw/char/ibex_uart.c | 37 + 2 files changed, 37 insertions(+), 37

[PATCH v1 0/3] hw/riscv: OpenTitan: Add support for the RISC-V timer

2021-05-30 Thread Alistair Francis
Alistair Francis (3): hw/char/ibex_uart: Make the register layout private hw/timer: Initial commit of Ibex Timer hw/riscv: OpenTitan: Connect the mtime and mtimecmp timer include/hw/char/ibex_uart.h | 37 - include/hw/riscv/opentitan.h | 5 +- include/hw/timer/ibex_timer.h | 52

[PATCH v1 1/1] target/riscv: Use target_ulong for the DisasContext misa

2021-05-30 Thread Alistair Francis
The is_32bit() check in translate.c expects a 64-bit guest to have a 64-bit misa value otherwise the macro check won't work. This patches fixes that and fixes a Coverity issue at the same time. Fixes: CID 1453107 Signed-off-by: Alistair Francis --- target/riscv/translate.c | 2 +- 1 file

Re: Google summer program

2021-05-30 Thread Thomas Huth
On 30/05/2021 03.03, Shehab Badawy wrote: Hello i just saw the application you are developing from google summer of code and i'm curious about it what prerequisites that i need to learn so i can contribute in the application thanks in advance Hi, thanks for your interest in the QEMU

[Bug 1414466] Re: -net user,hostfwd=... is not working

2021-05-30 Thread Apteryx
That's rather embarrassing, but the problem with my VM was that it was lacking networking support. I turned this (too) minimal example of a Guix System: ;;; file: os.scm (use-modules (gnu services ssh) (gnu system) (gnu tests)) (simple-operating-system (service

Re: HSS Issue with GCC 10, Qemu Setup for microchip-icicle-kit

2021-05-30 Thread Bin Meng
Hi Rahul, On Mon, May 31, 2021 at 1:08 AM Rahul Pathak wrote: > > Hi Bin, > > I was reading a github issue which you raised for the issue with HSS because > of GCC 10.1. Its pretty old and not sure what has changed so I thought to ask > you over email for help. The HSS issue of GCC 10.1 was

Re: [PATCH 0/5] linux-user changes to run docker

2021-05-30 Thread Takashi Yamamoto
On Thu, May 27, 2021 at 10:25 PM Alex Bennée wrote: > > > Takashi Yamamoto writes: > > > On Tue, May 25, 2021 at 8:22 AM Takashi Yamamoto > > wrote: > >> > >> On Tue, May 25, 2021 at 2:49 AM Alex Bennée wrote: > >> > > >> > > >> > YAMAMOTO Takashi writes: > >> > > >> > > These patches, along

Re: [PATCH v2 1/8] hw/riscv: sifive_u: Switch to use qemu_fdt_setprop_string_array() helper

2021-05-30 Thread Bin Meng
On Fri, Apr 30, 2021 at 3:13 PM Bin Meng wrote: > > From: Bin Meng > > Since commit 78da6a1bca22 ("device_tree: add qemu_fdt_setprop_string_array > helper"), > we can use the new helper to set the clock name for the ethernet > controller node. > > Signed-off-by: Bin Meng > Reviewed-by:

[PATCH] tests/vm: update openbsd to release 6.9

2021-05-30 Thread Brad Smith
tests/vm: update openbsd to release 6.9 Signed-off-by: Brad Smith --- tests/vm/openbsd | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/vm/openbsd b/tests/vm/openbsd index 4d1399378e..c4c78a80f1 100755 --- a/tests/vm/openbsd +++ b/tests/vm/openbsd @@ -22,8 +22,8 @@

Re: [PULL 0/3] Usb 20210528 patches

2021-05-30 Thread Peter Maydell
On Fri, 28 May 2021 at 15:24, Gerd Hoffmann wrote: > > The following changes since commit c8616fc7670b884de5f74d2767aade224c1c5c3a: > > Merge remote-tracking branch 'remotes/philmd/tags/gitlab-ci-20210527' into > staging (2021-05-27 16:32:57 +0100) > > are available in the Git repository at: >

[Bug 1414466] Re: -net user,hostfwd=... is not working

2021-05-30 Thread Apteryx
Here's what `tcpdump -i lo` reports during attempting the SSH access: 17:09:30.573545 IP localhost.55526 > localhost.: Flags [S], seq 1198531632, win 65495, options [mss 65495,sackOK,TS val 1662149852 ecr 0,nop,wscale 7], length 0 17:09:30.573569 IP localhost. > localhost.55526: Flags

[Bug 1414466] Re: -net user,hostfwd=... is not working

2021-05-30 Thread Apteryx
Hello, I'm also experiencing such a problem, using qemu-system-x86_64 (hence the retitling of this issue). More information and output is available at http://issues.guix.gnu.org/48739, but basically with the following QEMU command used to run a VM:

[Bug 1414466] Re: -net user,hostfwd=... is not working

2021-05-30 Thread Apteryx
** Summary changed: - -net user,hostfwd=... is not working(qemu-system-aarch64) + -net user,hostfwd=... is not working -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1414466 Title: -net

Re: [PATCH] oslib-posix: Remove OpenBSD workaround for fcntl("/dev/null", F_SETFL, O_NONBLOCK) failure

2021-05-30 Thread Brad Smith
ping. On 4/1/2021 1:34 PM, Brad Smith wrote: OpenBSD prior to 6.3 required a workaround to utilize fcntl(F_SETFL) on memory devices. Since modern verions of OpenBSD that are only officialy supported and buildable on do not have this issue I am garbage collecting this workaround.

Re: [PULL 00/44] Python patches

2021-05-30 Thread John Snow
On 5/30/21 3:09 PM, Peter Maydell wrote: On Fri, 28 May 2021 at 03:32, John Snow wrote: The following changes since commit c8616fc7670b884de5f74d2767aade224c1c5c3a: Merge remote-tracking branch 'remotes/philmd/tags/gitlab-ci-20210527' into staging (2021-05-27 16:32:57 +0100) are

Re: [PULL 00/44] Python patches

2021-05-30 Thread Peter Maydell
On Fri, 28 May 2021 at 03:32, John Snow wrote: > > The following changes since commit c8616fc7670b884de5f74d2767aade224c1c5c3a: > > Merge remote-tracking branch 'remotes/philmd/tags/gitlab-ci-20210527' into > staging (2021-05-27 16:32:57 +0100) > > are available in the Git repository at: > >

Re: [PATCH 1/3] vhost-user-blk-test: fix Coverity open(2) false positives

2021-05-30 Thread Peter Maydell
On Wed, 26 May 2021 at 10:16, Stefan Hajnoczi wrote: > > Coverity checks that the file descriptor return value of open(2) is > checked and used. Normally this is helpful in identifying real bugs but > vhost-user-blk-test opens /dev/null as stdin and stdout after fork. > > In this case we don't

Re: [PATCH 2/3] vhost-user-blk-test: fix Coverity mkstemp(2) umask warning

2021-05-30 Thread Peter Maydell
On Wed, 26 May 2021 at 10:14, Stefan Hajnoczi wrote: > > The Linux man page for mkstemp(3) states: > > In glibc versions 2.06 and earlier, the file is created with > permissions 0666, that is, read and write for all users. This old > behavior may be a security risk, especially since other

Re: [PULL 00/23] Vga 20210527 patches

2021-05-30 Thread Peter Maydell
On Thu, 27 May 2021 at 15:25, Gerd Hoffmann wrote: > > The following changes since commit 2ab2dad01f6dc3667c0d53d2b1ba46b511031207: > > Merge remote-tracking branch > 'remotes/kraxel/tags/input-20210526-pull-request' into staging (2021-05-26 > 15:27:20 +0100) > > are available in the Git

Re: [PULL V2 0/3] Net patches

2021-05-30 Thread Peter Maydell
On Thu, 27 May 2021 at 05:24, Jason Wang wrote: > > The following changes since commit d90f154867ec0ec22fd719164b88716e8fd48672: > > Merge remote-tracking branch 'remotes/dg-gitlab/tags/ppc-for-6.1-20210504' > into staging (2021-05-05 20:29:14 +0100) > > are available in the git repository at:

Re: [PATCH qemu v20] spapr: Implement Open Firmware client interface

2021-05-30 Thread BALATON Zoltan
Hello, Two more problems I've found while testing with pegasos2 but I'm not sure how to fix them: On Thu, 20 May 2021, Alexey Kardashevskiy wrote: diff --git a/hw/ppc/vof.c b/hw/ppc/vof.c new file mode 100644 index ..a283b7d251a7 --- /dev/null +++ b/hw/ppc/vof.c @@ -0,0 +1,1021

Re: [PATCH] target/mips: Fix DBALIGN DSP-R2 opcode 'byte position' field size

2021-05-30 Thread Richard Henderson
On 5/29/21 6:05 AM, Philippe Mathieu-Daudé wrote: Per the "MIPS® DSP Module for MIPS64 Architecture" manual (rev 3.02), Figure 5.12 "SPECIAL3 Encoding of APPEND/DAPPEND Instruction Sub-class" the byte position field ('bp') is 2 bits, not 3. Rev 2.34 has 3 bits, not 2. The mips32 version of

Re: [PATCH] target/mips: Fix TCG temporary leaks in gen_pool32a5_nanomips_insn()

2021-05-30 Thread Richard Henderson
On 5/30/21 2:45 AM, Philippe Mathieu-Daudé wrote: Fix a pair of TCG temporary leak when translating nanoMIPS SHILO opcode. Fixes: 3285a3e4445 ("target/mips: Add emulation of DSP ASE for nanoMIPS") Signed-off-by: Philippe Mathieu-Daudé --- target/mips/tcg/translate.c | 2 ++ 1 file changed, 2

[PATCH v7 2/2] target/i386: Correct implementation for FCS, FIP, FDS and FDP

2021-05-30 Thread Ziqiao Kong
Update FCS:FIP and FDS:FDP according to the Intel Manual Vol.1 8.1.8. Note that CPUID.(EAX=07H,ECX=0H):EBX[bit 13] is not implemented by design in this patch and will be added along with TCG features flag in a separate patch later. Signed-off-by: Ziqiao Kong --- Sorry for the duplicate emails

[PATCH v7 1/2] target/i386: Trivial code motion and code style fix

2021-05-30 Thread Ziqiao Kong
A new pair of braces has to be added to declare variables in the case block. The code style is also fixed according to the transalte.c itself during the code motion. Signed-off-by: Ziqiao Kong --- Sorry for the duplicate emails due to my bad network. The v7 has no difference from v6 and is sent

Re: [PATCH v2 2/2] hw/char: sifive_uart

2021-05-30 Thread Peter Maydell
On Sun, 30 May 2021 at 11:55, Lukas Jünger wrote: > > QOMify sifive_uart model > > Signed-off-by: Lukas Jünger > --- > include/hw/char/sifive_uart.h | 6 +-- > hw/char/sifive_uart.c | 72 ++- > 2 files changed, 65 insertions(+), 13 deletions(-) >

[PATCH v6 1/2] target/i386: Trivial code motion and code style fix

2021-05-30 Thread Ziqiao Kong
A new pair of braces has to be added to declare variables in the case block. The code style is also fixed according to the transalte.c itself during the code motion. Signed-off-by: Ziqiao Kong --- Sorry for duplicate emails due to my bad network. Changes since v5: - None Changes since v4: -

[PATCH v6 1/2] target/i386: Trivial code motion and code style fix

2021-05-30 Thread Ziqiao Kong
A new pair of braces has to be added to declare variables in the case block. The code style is also fixed according to the transalte.c itself during the code motion. Signed-off-by: Ziqiao Kong --- Sorry for duplicate emails due to my bad network. Changes since v5: - None Changes since v4: -

[PATCH v6 1/2] target/i386: Trivial code motion and code style fix

2021-05-30 Thread Ziqiao Kong
A new pair of braces has to be added to declare variables in the case block. The code style is also fixed according to the transalte.c itself during the code motion. Signed-off-by: Ziqiao Kong --- Sorry for duplicate emails due to my bad network. Changes since v5: - None Changes since v4: -

[PATCH v6 1/2] target/i386: Trivial code motion and code style fix

2021-05-30 Thread Ziqiao Kong
A new pair of braces has to be added to declare variables in the case block. The code style is also fixed according to the transalte.c itself during the code motion. Signed-off-by: Ziqiao Kong --- Changes since v5: - None Changes since v4: - Rewrite commit message to specify the reason to add

Re: [PATCH v2 2/2] hw/char: sifive_uart

2021-05-30 Thread Bin Meng
On Sun, May 30, 2021 at 6:49 PM Lukas Jünger wrote: > > QOMify sifive_uart model > > Signed-off-by: Lukas Jünger > --- > include/hw/char/sifive_uart.h | 6 +-- > hw/char/sifive_uart.c | 72 ++- > 2 files changed, 65 insertions(+), 13 deletions(-) >

Re: [PATCH v2 1/2] hw/char: sifive_uart

2021-05-30 Thread Bin Meng
On Sun, May 30, 2021 at 6:49 PM Lukas Jünger wrote: > > Make function names consistent > > Signed-off-by: Lukas Jünger > --- > hw/char/sifive_uart.c | 44 +-- > 1 file changed, 22 insertions(+), 22 deletions(-) > Reviewed-by: Bin Meng

[PATCH v2 2/2] hw/char: sifive_uart

2021-05-30 Thread Lukas Jünger
QOMify sifive_uart model Signed-off-by: Lukas Jünger --- include/hw/char/sifive_uart.h | 6 +-- hw/char/sifive_uart.c | 72 ++- 2 files changed, 65 insertions(+), 13 deletions(-) diff --git a/include/hw/char/sifive_uart.h b/include/hw/char/sifive_uart.h

[PATCH v2 0/2] QOMify Sifive UART Model

2021-05-30 Thread Lukas Jünger
Hello, I have updated the commit messages and cleaned up the other function names as requested by Bin. I hope this is acceptable now. I did not add the migration fields as requested by Philippe as migration is not supported by several devices in the sifive_u machine and was not supported by the

[PATCH v2 1/2] hw/char: sifive_uart

2021-05-30 Thread Lukas Jünger
Make function names consistent Signed-off-by: Lukas Jünger --- hw/char/sifive_uart.c | 44 +-- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/hw/char/sifive_uart.c b/hw/char/sifive_uart.c index fe12666789..101d68d8cf 100644 ---

[PATCH v5 2/2] target/i386: Correct implementation for FCS, FIP, FDS and FDP

2021-05-30 Thread Ziqiao Kong
Update FCS:FIP and FDS:FDP according to the Intel Manual Vol.1 8.1.8. Note that CPUID.(EAX=07H,ECX=0H):EBX[bit 13] is not implemented by design in this patch and would be added along with TCG features flag in a separate patch later. Signed-off-by: Ziqiao Kong --- Changes since v4: - Remove the

[PATCH RESEND v5 1/2] target/i386: Trivial code motion and code style fix

2021-05-30 Thread Ziqiao Kong
A new pair of braces has to be added to declare variables in the case block. The code style is also fixed according to the transalte.c itself during the code motion. Signed-off-by: Ziqiao Kong --- Change since v4: - Rewrite commit message to specify the reason to add the braces. ---

[PATCH v5 2/2] target/i386: Correct implementation for FCS, FIP, FDS and FDP

2021-05-30 Thread Ziqiao Kong
Update FCS:FIP and FDS:FDP according to the Intel Manual Vol.1 8.1.8. Note that CPUID.(EAX=07H,ECX=0H):EBX[bit 13] is not implemented by design in this patch and would be added along with TCG features flag in a separate patch later. Signed-off-by: Ziqiao Kong --- Changes since v4: - Remove the

[PATCH v5 1/2] target/i386: Trivial code motion and code style fix

2021-05-30 Thread Ziqiao Kong
A new pair of braces has to be added to declare variables in the case block. The code style is also fixed according to the transalte.c itself during the code motion. Signed-off-by: Ziqiao Kong --- Change since v4: - Rewrite commit message to specify the reason to add the braces. ---

[PATCH] target/mips: Fix TCG temporary leaks in gen_pool32a5_nanomips_insn()

2021-05-30 Thread Philippe Mathieu-Daudé
Fix a pair of TCG temporary leak when translating nanoMIPS SHILO opcode. Fixes: 3285a3e4445 ("target/mips: Add emulation of DSP ASE for nanoMIPS") Signed-off-by: Philippe Mathieu-Daudé --- target/mips/tcg/translate.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [PATCH] target/mips: Fix DBALIGN DSP-R2 opcode 'byte position' field size

2021-05-30 Thread Philippe Mathieu-Daudé
On 5/29/21 3:05 PM, Philippe Mathieu-Daudé wrote: > Per the "MIPS® DSP Module for MIPS64 Architecture" manual (rev 3.02), > Figure 5.12 "SPECIAL3 Encoding of APPEND/DAPPEND Instruction Sub-class" > the byte position field ('bp') is 2 bits, not 3. > > Cc: Jia Liu > Fixes: 26690560240

Re: [RFC PATCH v2 0/3] Cache modelling TCG plugin

2021-05-30 Thread Mahmoud Mandour
On Sun, May 30, 2021 at 8:37 AM Mahmoud Mandour wrote: > In this RFC patch series, I propose an initial cache modelling TCG > plugin. As of now, it models separate L1 data cache and L1 instruction > cache. It supports three eviction policies: LRU, random, and FIFO. Once > a policy is chosen,

Re: [RFC PATCH 0/3] Cache modelling TCG plugin

2021-05-30 Thread Mahmoud Mandour
Thank you, I'll also CC Emilio in the v2 of this series. On Sun, May 30, 2021 at 8:36 AM Philippe Mathieu-Daudé wrote: > Cc'ing Emilio too. > > On 5/29/21 5:22 PM, Mahmoud Mandour wrote: > > In this RFC patch series, I propose an initial cache modelling TCG > > plugin. As of now, it models

[RFC PATCH v2 2/3] plugins: cache: Enabled parameterization and added trace printing

2021-05-30 Thread Mahmoud Mandour
Made both icache and dcache configurable through plugin arguments and added memory trace printing in a separate file. Signed-off-by: Mahmoud Mandour --- contrib/plugins/cache.c | 68 +++-- 1 file changed, 66 insertions(+), 2 deletions(-) diff --git

[RFC PATCH v2 3/3] plugins: cache: Added FIFO and LRU eviction policies.

2021-05-30 Thread Mahmoud Mandour
Now one of the three eviction policies can be chosen as an argument. On not specifying an argument, LRU is used by default. Signed-off-by: Mahmoud Mandour --- contrib/plugins/cache.c | 159 1 file changed, 146 insertions(+), 13 deletions(-) diff --git

[RFC PATCH v2 0/3] Cache modelling TCG plugin

2021-05-30 Thread Mahmoud Mandour
In this RFC patch series, I propose an initial cache modelling TCG plugin. As of now, it models separate L1 data cache and L1 instruction cache. It supports three eviction policies: LRU, random, and FIFO. Once a policy is chosen, it's used for both instruction and data caches. v1 -> v2: Unlocked

Re: [RFC PATCH 0/3] Cache modelling TCG plugin

2021-05-30 Thread Philippe Mathieu-Daudé
Cc'ing Emilio too. On 5/29/21 5:22 PM, Mahmoud Mandour wrote: > In this RFC patch series, I propose an initial cache modelling TCG > plugin. As of now, it models separate L1 data cache and L1 instruction > cache. It supports three eviction policies: LRU, random, and FIFO. Once > a policy is

[RFC PATCH v2 1/3] plugins: Added a new cache modelling plugin

2021-05-30 Thread Mahmoud Mandour
Added a cache modelling plugin that uses a static configuration used in many of the commercial microprocessors and uses random eviction policy. Signed-off-by: Mahmoud Mandour --- contrib/plugins/Makefile | 1 + contrib/plugins/cache.c | 398 +++ 2 files