Re: [PATCH v3 33/33] block/nbd: drop connection_co

04.06.2021 00:27, Eric Blake wrote: On Fri, Apr 16, 2021 at 11:09:11AM +0300, Vladimir Sementsov-Ogievskiy wrote: OK, that's a big rewrite of the logic. Pre-patch we have an always running coroutine - connection_co. It does reply receiving and reconnecting. And it leads to a lot of difficult

Re: [PATCH v3 32/33] block/nbd: safer transition to receiving request

04.06.2021 00:11, Eric Blake wrote: On Fri, Apr 16, 2021 at 11:09:10AM +0300, Vladimir Sementsov-Ogievskiy wrote: req->receiving is a flag of request being in one concrete yield point in nbd_co_do_receive_one_chunk(). Such kind of boolean flag is always better to unset before scheduling the

Re: [PATCH v3 28/33] nbd/client-connection: do qio_channel_set_delay(false)

03.06.2021 23:48, Eric Blake wrote: On Fri, Apr 16, 2021 at 11:09:06AM +0300, Vladimir Sementsov-Ogievskiy wrote: nbd_open() does it (through nbd_establish_connection()). Actually we lost that call on reconnect path in 1dc4718d849e1a1fe "block/nbd: use non-blocking connect: fix vm hang on

Re: [PATCH v3 27/33] block/nbd: split nbd_co_do_establish_connection out of nbd_reconnect_attempt

03.06.2021 23:04, Eric Blake wrote: On Fri, Apr 16, 2021 at 11:09:05AM +0300, Vladimir Sementsov-Ogievskiy wrote: Split out part, that we want to reuse for nbd_open(). Split out the part that we want to reuse for nbd_open(). Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/nbd.c |

Re: [PATCH v3 26/33] block-coroutine-wrapper: allow non bdrv_ prefix

03.06.2021 23:53, Eric Blake wrote: On Fri, Apr 16, 2021 at 11:09:04AM +0300, Vladimir Sementsov-Ogievskiy wrote: We are going to reuse the script to generate a qcow2_ function in Is qcow2_ right here? Looking ahead to patch 30/33, it looks like you meant nbd_, at least in the context of

Re: [PATCH_V3] Adding ifdefs to call the respective routines only when their configs are enabled

Hello, I have tested this patch with our qemu and it works, thank you. What are the next steps for this patch? So is it approved and ready to go in mainline? Thanks, Swetha. On Thu, Jun 3, 2021 at 10:30 AM Swetha Joshi wrote: > > Oh okay, thank you. I will test this by eod today! > > > On

Re: [PATCH v1 2/3] hw/timer: Initial commit of Ibex Timer

On Fri, Jun 4, 2021 at 10:38 AM Alistair Francis wrote: > > On Fri, Jun 4, 2021 at 12:34 PM Bin Meng wrote: > > > > On Fri, Jun 4, 2021 at 10:33 AM Alistair Francis > > wrote: > > > > > > On Fri, Jun 4, 2021 at 12:11 PM Bin Meng wrote: > > > > > > > > On Fri, Jun 4, 2021 at 7:21 AM Alistair

Re: [PATCH v1 2/3] hw/timer: Initial commit of Ibex Timer

On Fri, Jun 4, 2021 at 12:34 PM Bin Meng wrote: > > On Fri, Jun 4, 2021 at 10:33 AM Alistair Francis wrote: > > > > On Fri, Jun 4, 2021 at 12:11 PM Bin Meng wrote: > > > > > > On Fri, Jun 4, 2021 at 7:21 AM Alistair Francis > > > wrote: > > > > > > > > On Tue, Jun 1, 2021 at 11:05 PM Bin Meng

Re: [PATCH v1 2/3] hw/timer: Initial commit of Ibex Timer

On Fri, Jun 4, 2021 at 10:33 AM Alistair Francis wrote: > > On Fri, Jun 4, 2021 at 12:11 PM Bin Meng wrote: > > > > On Fri, Jun 4, 2021 at 7:21 AM Alistair Francis > > wrote: > > > > > > On Tue, Jun 1, 2021 at 11:05 PM Bin Meng wrote: > > > > > > > > On Mon, May 31, 2021 at 12:33 PM Alistair

Re: [PATCH v1 2/3] hw/timer: Initial commit of Ibex Timer

On Fri, Jun 4, 2021 at 12:11 PM Bin Meng wrote: > > On Fri, Jun 4, 2021 at 7:21 AM Alistair Francis wrote: > > > > On Tue, Jun 1, 2021 at 11:05 PM Bin Meng wrote: > > > > > > On Mon, May 31, 2021 at 12:33 PM Alistair Francis > > > wrote: > > > > > > Please write some commit message, for

Re: [PATCH v1 2/3] hw/timer: Initial commit of Ibex Timer

On Fri, Jun 4, 2021 at 7:21 AM Alistair Francis wrote: > > On Tue, Jun 1, 2021 at 11:05 PM Bin Meng wrote: > > > > On Mon, May 31, 2021 at 12:33 PM Alistair Francis > > wrote: > > > > Please write some commit message, for example, what is supported in > > this initial version, and what is not.

Re: [PATCH 2/6] target/microblaze: Extract FPU helpers to fpu_helper.c

On Thu, Jun 3, 2021 at 7:05 PM Philippe Mathieu-Daudé wrote: > > Extract FPU helpers to their own file: fpu_helper.c, > so it is easier to focus on the generic helpers in > op_helper.c. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- >

Re: [PATCH 1/6] target/microblaze: Use the IEC binary prefix definitions

On Thu, Jun 3, 2021 at 7:03 PM Philippe Mathieu-Daudé wrote: > > IEC binary prefixes ease code review: the unit is explicit. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > target/microblaze/mmu.c | 5 +++-- > 1 file changed, 3 insertions(+), 2

Re: [PATCH v1 3/3] hw/riscv: OpenTitan: Connect the mtime and mtimecmp timer

On Tue, Jun 1, 2021 at 11:10 PM Bin Meng wrote: > > On Mon, May 31, 2021 at 12:33 PM Alistair Francis > wrote: > > > > Please write some commit message here Done. > > > Signed-off-by: Alistair Francis > > --- > > include/hw/riscv/opentitan.h | 5 - > > hw/riscv/opentitan.c | 14

Re: [PATCH v1 2/3] hw/timer: Initial commit of Ibex Timer

On Tue, Jun 1, 2021 at 11:05 PM Bin Meng wrote: > > On Mon, May 31, 2021 at 12:33 PM Alistair Francis > wrote: > > Please write some commit message, for example, what is supported in > this initial version, and what is not. I'll add something. > > > > > Signed-off-by: Alistair Francis > > ---

Re: [PATCH v7 9/9] qtest/hyperv: Introduce a simple hyper-v test

On Thu, Jun 03, 2021 at 01:48:35PM +0200, Vitaly Kuznetsov wrote: > For the beginning, just test 'hv-passthrough' and a couple of custom > Hyper-V enlightenments configurations through QMP. Later, it would > be great to complement this by checking CPUID values from within the > guest. > >

Re: [PATCH v7 8/9] i386: Hyper-V SynIC requires POST_MESSAGES/SIGNAL_EVENTS priviliges

On Thu, Jun 03, 2021 at 01:48:34PM +0200, Vitaly Kuznetsov wrote: > When Hyper-V SynIC is enabled, we may need to allow Windows guests to make > hypercalls (POST_MESSAGES/SIGNAL_EVENTS). No issue is currently observed > because KVM is very permissive, allowing these hypercalls regarding of > guest

Re: [PATCH v7 7/9] i386: HV_HYPERCALL_AVAILABLE privilege bit is always needed

On Thu, Jun 03, 2021 at 01:48:33PM +0200, Vitaly Kuznetsov wrote: > According to TLFS, Hyper-V guest is supposed to check > HV_HYPERCALL_AVAILABLE privilege bit before accessing > HV_X64_MSR_GUEST_OS_ID/HV_X64_MSR_HYPERCALL MSRs but at least some > Windows versions ignore that. As KVM is very

Re: [PATCH v7 5/9] i386: expand Hyper-V features during CPU feature expansion time

On Thu, Jun 03, 2021 at 01:48:31PM +0200, Vitaly Kuznetsov wrote: > To make Hyper-V features appear in e.g. QMP query-cpu-model-expansion we > need to expand and set the corresponding CPUID leaves early. Modify > x86_cpu_get_supported_feature_word() to call newly intoduced Hyper-V > specific

Re: [PATCH v7 4/9] i386: make hyperv_expand_features() return bool

On Thu, Jun 03, 2021 at 01:48:30PM +0200, Vitaly Kuznetsov wrote: > Return 'false' when hyperv_expand_features() sets an error. > > No functional change intended. > > Signed-off-by: Vitaly Kuznetsov Reviewed-by: Eduardo Habkost -- Eduardo

Re: [PATCH v7 3/9] i386: hardcode supported eVMCS version to '1'

On Thu, Jun 03, 2021 at 01:48:29PM +0200, Vitaly Kuznetsov wrote: > Currently, the only eVMCS version, supported by KVM (and described in TLFS) > is '1'. When Enlightened VMCS feature is enabled, QEMU takes the supported > eVMCS version range (from KVM_CAP_HYPERV_ENLIGHTENED_VMCS enablement) and >

Re: [PATCH v7 2/9] i386: clarify 'hv-passthrough' behavior

On Thu, Jun 03, 2021 at 01:48:28PM +0200, Vitaly Kuznetsov wrote: > Clarify the fact that 'hv-passthrough' only enables features which are > already known to QEMU and that it overrides all other 'hv-*' settings. > > Signed-off-by: Vitaly Kuznetsov Reviewed-by: Eduardo Habkost -- Eduardo

Re: [PATCH v7 1/9] i386: avoid hardcoding '12' as 'hyperv_vendor_id' length

On Thu, Jun 03, 2021 at 01:48:27PM +0200, Vitaly Kuznetsov wrote: > While this is very unlikely to change, let's avoid hardcoding '12' as > 'hyperv_vendor_id' length. > > No functional change intended. > > Signed-off-by: Vitaly Kuznetsov Reviewed-by: Eduardo Habkost -- Eduardo

[PULL 20/29] softfloat: Convert integer to floatx80 to FloatParts

Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- fpu/softfloat.c | 58 +++-- 1 file changed, 13 insertions(+), 45 deletions(-) diff --git a/fpu/softfloat.c b/fpu/softfloat.c index 9caf1ecf9c..be7583780d 100644 --- a/fpu/softfloat.c +++

[PULL 25/29] softfloat: Convert float32_exp2 to FloatParts

Keep the intermediate results in FloatParts instead of converting back and forth between float64. Use muladd instead of separate mul+add. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- fpu/softfloat.c | 53 + 1 file changed, 23

[PULL 22/29] softfloat: Convert floatx80 to integer to FloatParts

Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- fpu/softfloat.c | 336 ++-- 1 file changed, 42 insertions(+), 294 deletions(-) diff --git a/fpu/softfloat.c b/fpu/softfloat.c index acaab6a127..5a2a872408 100644 --- a/fpu/softfloat.c +++

[PULL 29/29] softfloat: Use hard-float for {u}int64_to_float{32,64}

For the normal case of no additional scaling, this reduces the profile contribution of int64_to_float64 to the testcase in the linked issue from 0.81% to 0.04%. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/134 Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson ---

[PULL 26/29] softfloat: Move floatN_log2 to softfloat-parts.c.inc

Rename to parts$N_log2. Though this is partly a ruse, since I do not believe the code will succeed for float128 without work. Which is ok for now, because we do not need this for more than float32 and float64. Since berkeley-testfloat-3 doesn't support log2, compare float64_log2 vs the system

[PULL 15/29] softfloat: Convert floatx80_mul to FloatParts

Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- fpu/softfloat.c | 76 + 1 file changed, 14 insertions(+), 62 deletions(-) diff --git a/fpu/softfloat.c b/fpu/softfloat.c index 737f5d7701..ae2e7aa274 100644 --- a/fpu/softfloat.c +++

[PULL 28/29] tests/fp: Enable more tests

From: Alex Bennée Fix the trivial typo in extF80_lt_quiet, and re-enable all of the floatx80 tests that are now fixed. Signed-off-by: Alex Bennée Message-ID: <87bl9iyahr@linaro.org> [rth: Squash the fix for lt_quiet, and enable that too.] Signed-off-by: Richard Henderson ---

[PULL 23/29] softfloat: Convert floatx80_scalbn to FloatParts

Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- fpu/softfloat.c | 50 +++-- 1 file changed, 11 insertions(+), 39 deletions(-) diff --git a/fpu/softfloat.c b/fpu/softfloat.c index 5a2a872408..770badd447 100644 --- a/fpu/softfloat.c +++

[PULL 16/29] softfloat: Convert floatx80_div to FloatParts

Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- fpu/softfloat.c | 100 +++- 1 file changed, 13 insertions(+), 87 deletions(-) diff --git a/fpu/softfloat.c b/fpu/softfloat.c index ae2e7aa274..9c26ba5960 100644 --- a/fpu/softfloat.c +++

[PULL 14/29] softfloat: Convert floatx80_add/sub to FloatParts

Since this is the first such, this includes all of the packing and unpacking routines as well. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- fpu/softfloat.c | 339 +++- 1 file changed, 136 insertions(+), 203 deletions(-) diff --git

[PULL 27/29] softfloat: Convert modrem operations to FloatParts

Rename to parts$N_modrem. This was the last use of a lot of the legacy infrastructure, so remove it as required. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- include/fpu/softfloat-macros.h | 34 + fpu/softfloat.c| 1339 +++-

[PULL 24/29] softfloat: Convert floatx80 compare to FloatParts

Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- fpu/softfloat.c | 82 + 1 file changed, 22 insertions(+), 60 deletions(-) diff --git a/fpu/softfloat.c b/fpu/softfloat.c index 770badd447..c32b1c7113 100644 --- a/fpu/softfloat.c +++

[PULL 11/29] softfloat: Introduce Floatx80RoundPrec

Use an enumeration instead of raw 32/64/80 values. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- include/fpu/softfloat-helpers.h | 5 +- include/fpu/softfloat-types.h | 10 +++- include/fpu/softfloat.h | 4 +- fpu/softfloat.c | 32 ++--

[PULL 13/29] tests/fp/fp-test: Reverse order of floatx80 precision tests

Many qemu softfloat will check floatx80_rounding_precision even when berkeley testfloat will not. So begin with floatx80_precision_x, so that's the one we use when !FUNC_EFF_ROUNDINGPRECISION. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- tests/fp/fp-test.c | 8 1

[PULL 21/29] softfloat: Convert floatx80 float conversions to FloatParts

This is the last use of commonNaNT and all of the routines that use it, so remove all of them for Werror. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- fpu/softfloat.c| 276 - fpu/softfloat-specialize.c.inc | 175

[PULL 17/29] softfloat: Convert floatx80_sqrt to FloatParts

Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- fpu/softfloat.c | 82 +++-- 1 file changed, 11 insertions(+), 71 deletions(-) diff --git a/fpu/softfloat.c b/fpu/softfloat.c index 9c26ba5960..5a320e5302 100644 --- a/fpu/softfloat.c +++

[PULL 12/29] softfloat: Adjust parts_uncanon_normal for floatx80

With floatx80_precision_x, the rounding happens across the break between words. Notice this case with frac_lsb = round_mask + 1 -> 0 and check the bits in frac_hi as needed. In addition, since frac_shift == 0, we won't implicitly clear round_mask via the right-shift, so explicitly clear

[PULL 06/29] softfloat: Move compare_floats to softfloat-parts.c.inc

Rename to parts$N_compare. Rename all of the intermediate functions to ftype_do_compare. Rename the hard-float functions to ftype_hs_compare. Convert float128 to FloatParts128. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- fpu/softfloat.c | 208

[PULL 19/29] softfloat: Convert floatx80_round_to_int to FloatParts

Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- fpu/softfloat.c | 116 ++-- 1 file changed, 13 insertions(+), 103 deletions(-) diff --git a/fpu/softfloat.c b/fpu/softfloat.c index 74787d5a6e..9caf1ecf9c 100644 --- a/fpu/softfloat.c +++

[PULL 18/29] softfloat: Convert floatx80_round to FloatParts

Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- fpu/softfloat.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/fpu/softfloat.c b/fpu/softfloat.c index 5a320e5302..74787d5a6e 100644 --- a/fpu/softfloat.c +++ b/fpu/softfloat.c @@ -5792,10 +5792,12 @@

[PULL 05/29] softfloat: Implement float128_(min|minnum|minnummag|max|maxnum|maxnummag)

From: David Hildenbrand The float128 implementation is straight-forward. Unfortuantely, we don't have any tests we can simply adjust/unlock. Signed-off-by: David Hildenbrand Message-Id: <20210517142739.38597-24-da...@redhat.com> [rth: Update for changed parts_minmax return value]

[PULL 03/29] softfloat: Move uint_to_float to softfloat-parts.c.inc

Rename to parts$N_uint_to_float. Reimplement uint64_to_float128 with FloatParts128. Reviewed-by: Alex Bennée Reviewed-by: David Hildenbrand Signed-off-by: Richard Henderson --- fpu/softfloat.c | 83 --- fpu/softfloat-parts.c.inc | 23 +++

[PULL 10/29] softfloat: Reduce FloatFmt

Remove frac_lsb, frac_lsbm1, roundeven_mask. Compute these from round_mask in parts$N_uncanon_normal. With floatx80, round_mask will not be tied to frac_shift. Everything else is easily computable. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- fpu/softfloat.c | 29

[PULL 08/29] softfloat: Move sqrt_float to softfloat-parts.c.inc

Rename to parts$N_sqrt. Reimplement float128_sqrt with FloatParts128. Reimplement with the inverse sqrt newton-raphson algorithm from musl. This is significantly faster than even the berkeley sqrt n-r algorithm, because it does not use division instructions, only multiplication. Ordinarily,

[PULL 07/29] softfloat: Move scalbn_decomposed to softfloat-parts.c.inc

Rename to parts$N_scalbn. Reimplement float128_scalbn with FloatParts128. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- fpu/softfloat.c | 103 +- fpu/softfloat-parts.c.inc | 21 2 files changed, 55 insertions(+), 69

[PULL 01/29] softfloat: Move round_to_uint_and_pack to softfloat-parts.c.inc

Rename to parts$N_float_to_uint. Reimplement float128_to_uint{32,64}{_round_to_zero} with FloatParts128. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- fpu/softfloat.c | 357 +- fpu/softfloat-parts.c.inc | 68 +++- 2 files

[PULL 04/29] softfloat: Move minmax_flags to softfloat-parts.c.inc

Rename to parts$N_minmax. Combine 3 bool arguments to a bitmask. Introduce ftype_minmax functions as a common optimization point. Fold bfloat16 expansions into the same macro as the other types. Reviewed-by: David Hildenbrand Signed-off-by: Richard Henderson --- fpu/softfloat.c |

[PULL 09/29] softfloat: Split out parts_uncanon_normal

We will need to treat the non-normal cases of floatx80 specially, so split out the normal case that we can reuse. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- fpu/softfloat.c | 8 ++ fpu/softfloat-parts.c.inc | 59 +-- 2 files

[PULL 02/29] softfloat: Move int_to_float to softfloat-parts.c.inc

Rename to parts$N_sint_to_float. Reimplement int{32,64}_to_float128 with FloatParts128. Reviewed-by: Alex Bennée Reviewed-by: David Hildenbrand Signed-off-by: Richard Henderson --- fpu/softfloat.c | 136 +++--- fpu/softfloat-parts.c.inc | 32

[PULL 00/29] softfloat patch queue

The following changes since commit 453d9c61dd5681159051c6e4d07e7b2633de2e70: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20210603' into staging (2021-06-03 16:59:46 +0100) are available in the Git repository at: https://gitlab.com/rth7680/qemu.git tags/pull-fpu

Re: [PATCH v3 33/33] block/nbd: drop connection_co

On Fri, Apr 16, 2021 at 11:09:11AM +0300, Vladimir Sementsov-Ogievskiy wrote: > OK, that's a big rewrite of the logic. > > Pre-patch we have an always running coroutine - connection_co. It does > reply receiving and reconnecting. And it leads to a lot of difficult > and unobvious code around

Re: [PATCH v3 32/33] block/nbd: safer transition to receiving request

On Fri, Apr 16, 2021 at 11:09:10AM +0300, Vladimir Sementsov-Ogievskiy wrote: > req->receiving is a flag of request being in one concrete yield point > in nbd_co_do_receive_one_chunk(). > > Such kind of boolean flag is always better to unset before scheduling > the coroutine, to avoid double

Re: [PATCH v3 31/33] block/nbd: add nbd_clinent_connected() helper

On Fri, Apr 16, 2021 at 11:09:09AM +0300, Vladimir Sementsov-Ogievskiy wrote: In the subject: s/clinent/client/ > We already have two similar helpers for other state. Let's add another > one for convenience. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/nbd.c | 25

Re: [PATCH v3 30/33] block/nbd: reuse nbd_co_do_establish_connection() in nbd_open()

On Fri, Apr 16, 2021 at 11:09:08AM +0300, Vladimir Sementsov-Ogievskiy wrote: > The only last step we need to reuse the function is coroutine-wrapper. > nbd_open() may be called from non-coroutine context. So, generate the > wrapper and use it. > > Signed-off-by: Vladimir Sementsov-Ogievskiy >

Re: [PATCH v3 26/33] block-coroutine-wrapper: allow non bdrv_ prefix

On Fri, Apr 16, 2021 at 11:09:04AM +0300, Vladimir Sementsov-Ogievskiy wrote: > We are going to reuse the script to generate a qcow2_ function in Is qcow2_ right here? Looking ahead to patch 30/33, it looks like you meant nbd_, at least in the context of this series. -- Eric Blake, Principal

Re: [PATCH v3 29/33] nbd/client-connection: add option for non-blocking connection attempt

On Fri, Apr 16, 2021 at 11:09:07AM +0300, Vladimir Sementsov-Ogievskiy wrote: > We'll need a possibility of non-blocking nbd_co_establish_connection(), > so that it returns immediately, and it returns success only if > connections was previously established in background. only if a connection was

Re: [PATCH v3 28/33] nbd/client-connection: do qio_channel_set_delay(false)

On Fri, Apr 16, 2021 at 11:09:06AM +0300, Vladimir Sementsov-Ogievskiy wrote: > nbd_open() does it (through nbd_establish_connection()). > Actually we lost that call on reconnect path in 1dc4718d849e1a1fe > "block/nbd: use non-blocking connect: fix vm hang on connect()" > when we have introduced

Re: [PATCH V3 00/22] Live Update [restart]

On Thu, Jun 03, 2021 at 08:36:42PM +0100, Dr. David Alan Gilbert wrote: > * Steven Sistare (steven.sist...@oracle.com) wrote: > > On 5/24/2021 6:39 AM, Dr. David Alan Gilbert wrote: > > > * Steven Sistare (steven.sist...@oracle.com) wrote: > > >> On 5/20/2021 9:13 AM, Dr. David Alan Gilbert wrote:

Re: [PATCH v3 1/2] GitLab: Add "Bug" issue reporting template

On Thu, Jun 03, 2021 at 03:11:28PM -0400, John Snow wrote: > On 6/3/21 3:26 AM, Philippe Mathieu-Daudé wrote: > > I haven't reviewed earlier version, but I wonder about the "build from > > sources" use case (this is not a template for distributions but for the > > mainstream project), so maybe

Re: [PULL 00/45] target-arm queue

On Thu, 3 Jun 2021 at 16:59, Peter Maydell wrote: > > The following changes since commit a97978bcc2d1f650c7d411428806e5b03082b8c7: > > Merge remote-tracking branch 'remotes/dg-gitlab/tags/ppc-for-6.1-20210603' > into staging (2021-06-03 10:00:35 +0100) > > are available

Re: [RFC] Adding the A64FX's HPC funtions.

On 6/3/21 1:17 AM, ishii.shuuic...@fujitsu.com wrote: Hi, Richard. Thank you for your comment. My first thought is that -cpu max can simply enable the extensions, without extra flags. The max cpu has all of the features that we can enable, and as I see it this is just one more. Let me

Re: [PATCH v3 27/33] block/nbd: split nbd_co_do_establish_connection out of nbd_reconnect_attempt

On Fri, Apr 16, 2021 at 11:09:05AM +0300, Vladimir Sementsov-Ogievskiy wrote: > Split out part, that we want to reuse for nbd_open(). Split out the part that we want to reuse for nbd_open(). > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/nbd.c | 79

Re: [PATCH v3 26/33] block-coroutine-wrapper: allow non bdrv_ prefix

On Fri, Apr 16, 2021 at 11:09:04AM +0300, Vladimir Sementsov-Ogievskiy wrote: > We are going to reuse the script to generate a qcow2_ function in > further commit. Prepare the script now. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > scripts/block-coroutine-wrapper.py | 7 --- > 1

Re: [PATCH v3 25/33] nbd/client-connection: return only one io channel

On Fri, Apr 16, 2021 at 11:09:03AM +0300, Vladimir Sementsov-Ogievskiy wrote: > block/nbd doesn't need underlying sioc channel anymore. So, we can > update nbd/client-connection interface to return only one top-most io > channel, which is more straight forward. > > Signed-off-by: Vladimir

Re: [PATCH v2 1/3] doc: Fix some mistakes in the SEV documentation

On Thu, Jun 03, 2021 at 10:29:35AM +0200, Laszlo Ersek wrote: > On 06/02/21 21:19, Tom Lendacky wrote: > > Just a quick ping on this series... > > Right, I'm unsure who is supposed to merge this... Do you remember who > usually merges the SEV-related patch series (plural)? I'm queueing this

Re: [PATCH V3 00/22] Live Update [restart]

* Steven Sistare (steven.sist...@oracle.com) wrote: > On 5/24/2021 6:39 AM, Dr. David Alan Gilbert wrote: > > * Steven Sistare (steven.sist...@oracle.com) wrote: > >> On 5/20/2021 9:13 AM, Dr. David Alan Gilbert wrote: > >>> On the 'restart' branch of questions; can you explain, > >>> other than

Re: [PATCH v3 24/33] block/nbd: drop BDRVNBDState::sioc

On Fri, Apr 16, 2021 at 11:09:02AM +0300, Vladimir Sementsov-Ogievskiy wrote: > Currently sioc pointer is used just to pass from socket-connection to > nbd negotiation. Drop the field, and use local variables instead. With > next commit we'll update nbd/client-connection.c to behave >

Re: [PATCH v3 1/2] GitLab: Add "Bug" issue reporting template

On 6/3/21 3:26 AM, Philippe Mathieu-Daudé wrote: I haven't reviewed earlier version, but I wonder about the "build from sources" use case (this is not a template for distributions but for the mainstream project), so maybe add: ## Build environment (in case you built QEMU from source) -

Re: [PATCH] Update Linux headers to 5.13-rc4

On Tue, Jun 01, 2021 at 04:17:41PM -0400, Eduardo Habkost wrote: > Signed-off-by: Eduardo Habkost > --- > KVM_RUN_X86_BUS_LOCK is a requirement for: > [PATCH v4] i386: Add ratelimit for bus locks acquired in guest > Message-Id: <20210521043820.29678-1-chenyi.qi...@intel.com> I forgot to

Re: [RFC PATCH] accel/tcg: change default codegen buffer size for i386-softmmu

On 5/25/21 9:45 AM, Alex Bennée wrote: There are two justifications for making this change. The first is that i386 emulation is typically for smaller machines where having a 1gb of generated code is overkill for basic emulation. The second is the propensity of self-modifying code (c.f.

Re: [PATCH v3 23/33] block/nbd: nbd_teardown_connection() don't touch s->sioc

On Fri, Apr 16, 2021 at 11:09:01AM +0300, Vladimir Sementsov-Ogievskiy wrote: For the subject line, might read better as: block/nbd: don't touch s->sioc in nbd_teardown_connection() > Negotiation during reconnect is now done in thread, and s->sioc is not in a thread > available during

Re: [PATCH v4 01/15] python: qemu: add timer parameter for qmp.accept socket

On 6/3/21 4:06 AM, Emanuele Giuseppe Esposito wrote: On 03/06/2021 01:23, John Snow wrote: On 5/20/21 3:52 AM, Emanuele Giuseppe Esposito wrote: Alsp add a new _qmp_timer field to the QEMUMachine class. Let's change the default socket timeout to None, so that if a subclass needs to add a

Re: [PATCH 3/3] target/arm: Use acpi_ghes_present() to see if we report ACPI memory errors

On 6/3/21 10:12 AM, Peter Maydell wrote: The virt_is_acpi_enabled() function is specific to the virt board, as is the check for its 'ras' property. Use the new acpi_ghes_present() function to check whether we should report memory errors via acpi_ghes_record_errors(). This avoids a link error

Re: [PATCH 2/3] hw/acpi: Provide function acpi_ghes_present()

On 6/3/21 10:12 AM, Peter Maydell wrote: Allow code elsewhere in the system to check whether the ACPI GHES table is present, so it can determine whether it is OK to try to record an error by calling acpi_ghes_record_errors(). (We don't need to migrate the new 'present' field in AcpiGhesState,

Re: [PATCH 1/3] hw/acpi: Provide stub version of acpi_ghes_record_errors()

On 6/3/21 10:12 AM, Peter Maydell wrote: +softmmu_ss.add(when: 'CONFIG_ACPI', if_false: files('acpi-stub.c', 'aml-build-stub.c', 'ghes-stub.c')) softmmu_ss.add_all(when: 'CONFIG_ACPI', if_true: acpi_ss) softmmu_ss.add(when: 'CONFIG_ALL', if_true: files('acpi-stub.c', 'aml-build-stub.c', -

Re: [PATCH v3 22/33] block/nbd: pass monitor directly to connection thread

03.06.2021 21:16, Eric Blake wrote: On Fri, Apr 16, 2021 at 11:09:00AM +0300, Vladimir Sementsov-Ogievskiy wrote: monitor_cur() is used by socket_get_fd, but it doesn't work in connection thread. Let's monitor directly to cover this thing. We are going to unify connection establishing path in

Re: [PATCH v3 22/33] block/nbd: pass monitor directly to connection thread

On Fri, Apr 16, 2021 at 11:09:00AM +0300, Vladimir Sementsov-Ogievskiy wrote: > monitor_cur() is used by socket_get_fd, but it doesn't work in > connection thread. Let's monitor directly to cover this thing. We are > going to unify connection establishing path in nbd_open and reconnect, > so we

Re: [PATCH 1/2] i386: reorder call to cpu_exec_realizefn in x86_cpu_realizefn

On Thu, Jun 03, 2021 at 10:13:30AM +0200, Claudio Fontana wrote: > On 6/1/21 8:48 PM, Eduardo Habkost wrote: > > +Vitaly > > > > On Sat, May 29, 2021 at 11:13:12AM +0200, Claudio Fontana wrote: > >> we need to expand features first, before we attempt to check them > >> in the accel realizefn code

Re: [PATCH v2 24/26] s390x/tcg: Implement VECTOR FP (MAXIMUM|MINIMUM)

On 5/17/21 7:27 AM, David Hildenbrand wrote: +if (unlikely(nan_a || nan_b)) { Perhaps better as (dcmask_a | dcmask_b) & DCMASK_NAN ? +if (sig_a || sig_b) { Similarly. +} else if (unlikely(inf_a && inf_b)) { +switch (type) { +case S390_MINMAX_TYPE_JAVA: +

Re: [PATCH v3 20/33] block/nbd: use negotiation of NBDClientConnection

On Fri, Apr 16, 2021 at 11:08:58AM +0300, Vladimir Sementsov-Ogievskiy wrote: > Use a new possibility of negotiation in connect thread. Now we are on > the way of simplifying connection_co. We want to move the whole > reconnect code to NBDClientConnection. NBDClientConnection already > updated to

Re: [RFC PATCH 2/2] migration/rdma: Enable use of g_autoptr with struct rdma_cm_event

* Philippe Mathieu-Daudé (phi...@redhat.com) wrote: > Since 00f2cfbbec6 ("glib: bump min required glib library version to > 2.48") we can use g_auto/g_autoptr to have the compiler automatically > free an allocated variable when it goes out of scope, removing this > burden on the developers. > >

Re: [PATCH v3 17/33] nbd/client-connection: implement connection retry

03.06.2021 19:17, Eric Blake wrote: On Fri, Apr 16, 2021 at 11:08:55AM +0300, Vladimir Sementsov-Ogievskiy wrote: Add an option for thread to retry connection until success. We'll use for a thread to retry connection until it succeeds. nbd/client-connection both for reconnect and for

Re: [PATCH v2 22/26] s390x/tcg: Implement VECTOR FP NEGATIVE MULTIPLY AND (ADD|SUBTRACT)

On 5/17/21 7:27 AM, David Hildenbrand wrote: Signed-off-by: David Hildenbrand --- target/s390x/helper.h | 6 + target/s390x/insn-data.def | 4 target/s390x/translate_vx.c.inc | 39 +++-- target/s390x/vec_fpu_helper.c | 2 ++ 4 files

Re: [PATCH v2 21/26] s390x/tcg: Implement 32/128 bit for VECTOR FP MULTIPLY AND (ADD|SUBTRACT)

On 5/17/21 7:27 AM, David Hildenbrand wrote: Signed-off-by: David Hildenbrand --- target/s390x/helper.h | 4 +++ target/s390x/translate_vx.c.inc | 47 - target/s390x/vec_fpu_helper.c | 44 +- 3 files changed, 87

Re: [PATCH v2 20/26] s390x/tcg: Implement 32/128 bit for VECTOR FP TEST DATA CLASS IMMEDIATE

On 5/17/21 7:27 AM, David Hildenbrand wrote: Signed-off-by: David Hildenbrand --- target/s390x/helper.h | 2 ++ target/s390x/translate_vx.c.inc | 23 ++-- target/s390x/vec_fpu_helper.c | 47 + 3 files changed, 70 insertions(+), 2

Re: [PATCH v2 16/26] s390x/tcg: Implement 32/128 bit for VECTOR FP COMPARE (AND SIGNAL) SCALAR

On 5/17/21 7:27 AM, David Hildenbrand wrote: Signed-off-by: David Hildenbrand --- target/s390x/helper.h | 4 +++ target/s390x/translate_vx.c.inc | 38 ++-- target/s390x/vec_fpu_helper.c | 44 - 3 files changed, 77

Re: [PATCH v2 15/26] s390x/tcg: Implement 32/128 bit for VECTOR FP COMPARE *

On 5/17/21 7:27 AM, David Hildenbrand wrote: In addition to 32/128bit variants, we also have to support the "Signal-on-QNaN (SQ)" bit. Signed-off-by: David Hildenbrand --- target/s390x/helper.h | 12 +++ target/s390x/translate_vx.c.inc | 57 -

Re: [PATCH v2 14/26] s390x/tcg: Implement 32/128 bit for VECTOR (LOAD FP INTEGER|FP SQUARE ROOT)

On 5/17/21 7:27 AM, David Hildenbrand wrote: Signed-off-by: David Hildenbrand --- target/s390x/helper.h | 4 ++ target/s390x/translate_vx.c.inc | 74 ++--- target/s390x/vec_fpu_helper.c | 46 +++- 3 files changed, 109 insertions(+),

Re: [PATCH v3 3/7] block: add max_hw_transfer to BlockLimits

On Thu, Jun 03, 2021 at 03:37:18PM +0200, Paolo Bonzini wrote: > For block host devices, I/O can happen through either the kernel file > descriptor I/O system calls (preadv/pwritev, io_submit, io_uring) > or the SCSI passthrough ioctl SG_IO. > > In the latter case, the size of each transfer can

Re: [PATCH v2 13/26] s390x/tcg: Implement 32/128 bit for VECTOR FP (ADD|DIVIDE|MULTIPLY|SUBTRACT)

On 5/17/21 7:27 AM, David Hildenbrand wrote: In case of 128bit, we always have a single element. Add new helpers for reading/writing 32/128 bit floats. Signed-off-by: David Hildenbrand --- target/s390x/helper.h | 8 target/s390x/translate_vx.c.inc | 85

Re: [PATCH_V3] Adding ifdefs to call the respective routines only when their configs are enabled

Oh okay, thank you. I will test this by eod today! On Thu, Jun 3, 2021 at 10:22 AM Peter Maydell wrote: > On Fri, 28 May 2021 at 20:41, Swetha Joshi > wrote: > > > > I apologize for the delay, here are the repro steps: > > 1. Remove CONFIG_ARM_VIRT=y from arm-softmmu.mak > > 2. In

Re: [PATCH v2 10/26] s390x/tcg: Simplify wfc64() handling

On 5/17/21 7:27 AM, David Hildenbrand wrote: ... and prepare for 32/128 bit support. Signed-off-by: David Hildenbrand --- target/s390x/vec_fpu_helper.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) Reviewed-by: Richard Henderson r~

Re: [PATCH v2 09/26] s390x/tcg: Simplify vflr64() handling

On 5/17/21 7:27 AM, David Hildenbrand wrote: Signed-off-by: David Hildenbrand --- target/s390x/helper.h | 1 - target/s390x/translate_vx.c.inc | 3 +-- target/s390x/vec_fpu_helper.c | 29 +++-- 3 files changed, 8 insertions(+), 25 deletions(-)

Re: [PATCH v2 08/26] s390x/tcg: Simplify vfll32() handling

On 5/17/21 7:27 AM, David Hildenbrand wrote: Signed-off-by: David Hildenbrand --- target/s390x/helper.h | 1 - target/s390x/translate_vx.c.inc | 6 +- target/s390x/vec_fpu_helper.c | 21 + 3 files changed, 6 insertions(+), 22 deletions(-) Reviewed-by:

Re: [PATCH_V3] Adding ifdefs to call the respective routines only when their configs are enabled

On Fri, 28 May 2021 at 20:41, Swetha Joshi wrote: > > I apologize for the delay, here are the repro steps: > 1. Remove CONFIG_ARM_VIRT=y from arm-softmmu.mak > 2. In .gitlab-ci.yml, crossbuild.yml and in tests/vm/Makefile.include, in all > the places where we disable kvm using -disable-kvm,

Re: [PATCH v2 07/26] s390x/tcg: Simplify vfma64() handling

On 5/17/21 7:27 AM, David Hildenbrand wrote: Signed-off-by: David Hildenbrand --- target/s390x/helper.h | 2 -- target/s390x/translate_vx.c.inc | 8 +++ target/s390x/vec_fpu_helper.c | 42 + 3 files changed, 20 insertions(+), 32 deletions(-)

Re: [PATCH v2 06/26] s390x/tcg: Simplify vftci64() handling

On 5/17/21 7:27 AM, David Hildenbrand wrote: Signed-off-by: David Hildenbrand --- target/s390x/helper.h | 1 - target/s390x/translate_vx.c.inc | 7 ++- target/s390x/vec_fpu_helper.c | 29 +++-- 3 files changed, 13 insertions(+), 24 deletions(-)

  1   2   3   4   >