Oh well. Let's add a to-do marker.
Paolo
Il mer 23 giu 2021, 09:36 Gerd Hoffmann ha scritto:
> On Tue, Jun 22, 2021 at 06:03:45PM +0200, Paolo Bonzini wrote:
> > On 21/06/21 14:52, Gerd Hoffmann wrote:
> > > ninja: error: 'libui-curses.a.p/meson-generated_.._config-host.h.o',
> needed by
On Mon, Jun 21, 2021 at 09:51:09AM -0300, Bruno Larsen (billionai) wrote:
> From: Richard Henderson
>
> Instead of returning non-zero for failure, return true for success.
>
> Signed-off-by: Richard Henderson
Applied to ppc-for-6.1, thanks.
> ---
> target/ppc/mmu-radix64.c | 30
On Mon, Jun 21, 2021 at 09:51:08AM -0300, Bruno Larsen (billionai) wrote:
> From: Richard Henderson
>
> This removes some incomplete duplication between
> ppc_radix64_handle_mmu_fault and ppc_radix64_get_phys_page_debug.
> The former was correct wrt SPR_HRMOR and the latter was not.
>
>
On Mon, Jun 21, 2021 at 09:51:07AM -0300, Bruno Larsen (billionai) wrote:
> From: Richard Henderson
>
> These changes were waiting until we didn't need to match
> the function type of PowerPCCPUClass.handle_mmu_fault.
>
> Signed-off-by: Richard Henderson
Applied to ppc-for-6.1, thanks.
> ---
Patchew URL:
https://patchew.org/QEMU/20210624041040.1250631-1-vivek.kasire...@intel.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210624041040.1250631-1-vivek.kasire...@intel.com
Subject: [RFC v1 0/1] ui: Add
Cc: Gerd Hoffmann
Signed-off-by: Vivek Kasireddy
---
configure | 17 ++
meson.build | 25 +++
meson_options.txt | 2 +
qapi/ui.json | 19 ++-
ui/meson.build| 52 ++
ui/wayland.c | 402 ++
6 files changed, 516
Why does Qemu need a new Wayland UI backend?
The main reason why there needs to be a plain and simple Wayland backend
for Qemu UI is to eliminate the Blit (aka GPU copy) that happens if using
a toolkit like GTK or SDL (because they use EGL). The Blit can be eliminated
by sharing the dmabuf fd --
> -Original Message-
> From: Alessandro Di Federico
> Sent: Saturday, June 19, 2021 3:37 AM
> To: qemu-devel@nongnu.org
> Cc: Taylor Simpson ; Brian Cain
> ; bab...@rev.ng; ni...@rev.ng; phi...@redhat.com;
> richard.hender...@linaro.org; Alessandro Di Federico
> Subject: [PATCH v5
TYPE_AC97 is "AC97", capitalized. Fix the config to account for that.
Signed-off-by: Alexander Bulekov
---
tests/qtest/fuzz/generic_fuzz_configs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qtest/fuzz/generic_fuzz_configs.h
Using a custom timeout is useful to continue fuzzing complex devices,
even after we run into some slow code-path. However, simply adding a
fixed timeout to each input effectively caps the maximum input
length/number of operations at some artificial value. There are two
major problems with this:
1.
By default, -fsanitize=fuzzer instruments all code with coverage
information. However, this means that libfuzzer will track coverage over
hundreds of source files that are unrelated to virtual-devices. This
means that libfuzzer will optimize inputs for coverage observed in timer
code, memory APIs
v3:
- Check in ./configure whether clang supports -fsanitize-coverage-allowlist
v2:
- Add the instrumentation filter to the instrumentation filter patch
These patches
1.) Change generic-fuzzer timeouts so they are reconfigured prior to
each individual IO command, to allow for
TYPE_ES1370 is "ES1370", capitalized. Fix the config to account for
that.
Signed-off-by: Alexander Bulekov
---
tests/qtest/fuzz/generic_fuzz_configs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qtest/fuzz/generic_fuzz_configs.h
On Mon, Jun 21, 2021 at 09:51:06AM -0300, Bruno Larsen (billionai) wrote:
> From: Richard Henderson
>
> Instead, use a switch on env->mmu_model. This avoids some
> replicated information in cpu setup.
>
> Signed-off-by: Richard Henderson
As I mentioned on the earlier posting, I don't love
On Tue, Jun 22, 2021 at 05:03:36PM +1000, Alexey Kardashevskiy wrote:
> QEMU reserves space for RTAS via /rtas/rtas-size which tells the client
> how much space the RTAS requires to work which includes the RTAS binary
> blob implementing RTAS runtime. Because pseries supports FWNMI which
>
On Tue, Jun 22, 2021 at 04:09:24PM +0200, Greg Kurz wrote:
> Class method is overkill and cause code duplication in CPU setup functions.
> Switch to a more lightweight solution with a unique inline helper.
LGTM, applied to ppc-for-6.1, thanks.
>
> Greg Kurz (2):
> target/ppc: Introduce
On 210623 2000, Philippe Mathieu-Daudé wrote:
> Hi Ubi-Wan Kenubi and Tom,
>
> In commit a9bcedd (SD card size has to be power of 2) we decided
> to restrict SD card size to avoid security problems (CVE-2020-13253)
> but this became not practical to some users.
>
> This RFC series tries to
The I/O sampling rate range is enforced to 5000 to 45000HZ according to
commit a2cd86a9. Setting I/O sampling rate with command 41h/42h, a guest
user can break this assumption and trigger an assertion in audio_calloc
via command 0xd4. This patch restricts the I/O sampling rate range for
command
Hi
> This looks like your mailer mangled the patch.
> Can you resent using 'git send-email`?
Yes, I can. I finally figure it out how to config my Gmail. I should
send a new email
and this thread is supposed to be closed, right?
Best
Qiang
On 210623 1514, Steven Raasch wrote:
> Hi -
>
> I'm trying to create a hack that will allow me to extract an instruction
> trace from QEMU/KVM (i386). The KVM part is important (see below).
>
> Background:
>
>- I have used KVM to create a snapshot of a windows-10 guest running a
>
On 6/23/21 6:16 PM, Andrew Jones wrote:
On Wed, Jun 23, 2021 at 10:07:36AM +0200, Andrew Jones wrote:
On Wed, Jun 23, 2021 at 02:43:49PM +1000, Gavin Shan wrote:
On 6/22/21 5:13 PM, Andrew Jones wrote:
On Tue, Jun 22, 2021 at 06:53:41PM +1000, Gavin Shan wrote:
On 6/3/21 2:48 PM, Gavin Shan
Hi Gerd,
I am able to compile the code without error with my v3 patch. I don't see my
patch showing up in https://patchew.org/QEMU/ , is it due to this compilation
error?
I tried to change from %ld -> %lld but I encountered compilation error this
time.
../ui/gtk.c: In function
> On Jun 23, 2021, at 5:42 PM, Philippe Mathieu-Daudé wrote:
>
>> I'm trying to wrap my head around how to achieve this in Qemu. I don't see
>> an obvious way from my initial study of how the PCI code and memory regions
>> work. Some guidance would be appreciated!
>
> Is bitband_ops[]
On 6/24/21 2:27 AM, Jason Thorpe wrote:
> As a "learn the internals of Qemu a little better" exercise, I am planning to
> write models for some older Alpha systems, initially for one based on the
> LCA45. One of the quirks of these old systems, though, is lack of byte/word
> load/store. So,
As a "learn the internals of Qemu a little better" exercise, I am planning to
write models for some older Alpha systems, initially for one based on the
LCA45. One of the quirks of these old systems, though, is lack of byte/word
load/store. So, to support 8- and 16-bit accesses to I/O devices,
On 06/16/21 22:43, Philippe Mathieu-Daudé wrote:
> Special comment for Laszlo: Please don't review this version,
> wait for the respin (hoping the SEV cleanup patch get accepted,
> the respin will be focused on OVMF).
Appreciate the note.
Laszlo
Hi -
I'm trying to create a hack that will allow me to extract an instruction
trace from QEMU/KVM (i386). The KVM part is important (see below).
Background:
- I have used KVM to create a snapshot of a windows-10 guest running a
graphics-intensive app. The *original* issue is that the app
> -Original Message-
> From: Alessandro Di Federico
> Sent: Saturday, June 19, 2021 3:37 AM
> To: qemu-devel@nongnu.org
> Cc: Taylor Simpson ; Brian Cain
> ; bab...@rev.ng; ni...@rev.ng; phi...@redhat.com;
> richard.hender...@linaro.org; Alessandro Di Federico
> Subject: [PATCH v5
> -Original Message-
> From: Alessandro Di Federico
> Sent: Saturday, June 19, 2021 3:37 AM
> To: qemu-devel@nongnu.org
> Cc: Taylor Simpson ; Brian Cain
> ; bab...@rev.ng; ni...@rev.ng; phi...@redhat.com;
> richard.hender...@linaro.org; Alessandro Di Federico
> Subject: [PATCH v5
On Wed, 23 Jun 2021 10:30:29 +0100
Joao Martins wrote:
> On 6/22/21 10:16 PM, Alex Williamson wrote:
> > On Tue, 22 Jun 2021 16:48:59 +0100
> > Joao Martins wrote:
> >
> >> Hey,
> >>
> >> This series lets Qemu properly spawn i386 guests with >= 1Tb with VFIO,
> >> particularly
> >> when
On Wed, 23 Jun 2021 08:40:56 +0100
David Edmondson wrote:
> On Tuesday, 2021-06-22 at 15:16:29 -06, Alex Williamson wrote:
>
> >> Additionally, an alternative to hardcoded ranges as we do today,
> >> VFIO could advertise the platform valid IOVA ranges without
> >> necessarily
> >>
Hi Gerd,
> Hi,
>
> > dmabuf->buf.fd = res->dmabuf_fd;
> > +dmabuf->buf.blob = true;
>
> Do you actually need the 'blob' field?
> I think checking 'fd' instead should work too.
[Kasireddy, Vivek] I want these changes to be limited to blob resources only as
I do not
know how they
The default SD/MMC host controller uses SD spec v2.00. 64-bit system bus
capability
was added in v2.
In this change, we arrive at 0x157834b4 by computing (0x057834b4 | (1ul << 28))
where 28 represents the BUS64BIT SDHC_CAPAB field.
Signed-off-by: Joanne Koong
---
hw/sd/sdhci-internal.h | 4
> -Original Message-
> From: Alessandro Di Federico
> Sent: Saturday, June 19, 2021 3:37 AM
> To: qemu-devel@nongnu.org
> Cc: Taylor Simpson ; Brian Cain
> ; bab...@rev.ng; ni...@rev.ng; phi...@redhat.com;
> richard.hender...@linaro.org; Alessandro Di Federico
> Subject: [PATCH v5
> -Original Message-
> From: Alessandro Di Federico
> Sent: Saturday, June 19, 2021 3:37 AM
> To: qemu-devel@nongnu.org
> Cc: Taylor Simpson ; Brian Cain
> ; bab...@rev.ng; ni...@rev.ng; phi...@redhat.com;
> richard.hender...@linaro.org; Alessandro Di Federico
> Subject: [PATCH v5
Hi Pavel,
On Thu, Jun 10, 2021 at 8:25 AM Pavel Dovgalyuk
wrote:
>
> From: Pavel Dovgalyuk
>
> This patch adds a test for record/replay, which boots Linux
> image from the disk and interacts with the network.
> The idea and code of this test is borrowed from boot_linux.py
> This test includes
Reviewed-by: Taylor Simpson
On Sat, Jun 19, 2021 at 4:44 AM Alessandro Di Federico via <
qemu-devel@nongnu.org> wrote:
> From: Paolo Montesel
>
> Make certain helper functions non-static, making them available outside
> genptr.c. These functions are required by code generated by the
>
We don't use pow2ceil() anymore, remove it.
Signed-off-by: Philippe Mathieu-Daudé
---
tests/acceptance/boot_linux_console.py | 12
1 file changed, 12 deletions(-)
diff --git a/tests/acceptance/boot_linux_console.py
b/tests/acceptance/boot_linux_console.py
index
U-Boot expects the SD card size to be at least 2GiB, so
expand the SD card image to this size before using it.
Signed-off-by: Philippe Mathieu-Daudé
---
TODO: U-Boot reference?
---
tests/acceptance/boot_linux_console.py | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff
The NetBSD OrangePi image must be at least 2GiB, not less.
Expand the SD card image to this size before using it.
Signed-off-by: Philippe Mathieu-Daudé
---
tests/acceptance/boot_linux_console.py | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git
In commit a9bcedd15a5 ("hw/sd/sdcard: Do not allow invalid SD card
sizes") we tried to protect us from CVE-2020-13253 by only allowing
card with power-of-2 sizes. However doing so we disrupted valid user
cases. As a compromise, allow any card size, but warn only power of 2
sizes are supported,
To be able to expand an image to a non-power-of-2 value,
extract image_expand() from image_pow2ceil_expand().
Signed-off-by: Philippe Mathieu-Daudé
---
tests/acceptance/boot_linux_console.py | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git
Multiple commands have to check the address requested is valid.
Extract this code pattern as a new address_in_range() helper, and
log invalid accesses as guest errors.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/sd/sd.c | 32
1 file changed, 20 insertions(+),
XXX it seems to work...
Signed-off-by: Philippe Mathieu-Daudé
---
tests/acceptance/boot_linux_console.py | 1 -
1 file changed, 1 deletion(-)
diff --git a/tests/acceptance/boot_linux_console.py
b/tests/acceptance/boot_linux_console.py
index c4c0f0b393d..48c0ba09117 100644
---
Avocado allows us to select set of tests using tags.
When wanting to run all tests using a NetBSD guest OS,
it is convenient to have them tagged, add the 'os:netbsd'
tag.
Signed-off-by: Philippe Mathieu-Daudé
---
tests/acceptance/boot_linux_console.py | 1 +
tests/acceptance/ppc_prep_40p.py
We report the card is in an inconsistent state, but don't precise
in which state it is. Add this information, as it is useful when
debugging problems.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/sd/sd.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/sd/sd.c
Hi Ubi-Wan Kenubi and Tom,
In commit a9bcedd (SD card size has to be power of 2) we decided
to restrict SD card size to avoid security problems (CVE-2020-13253)
but this became not practical to some users.
This RFC series tries to remove the limitation, keeping our
functional tests working. It
** Changed in: qemu
Status: Expired => Fix Committed
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1585840
Title:
multiprocess program gets incorrect results with qemu arm-linux-user
** Changed in: qemu
Status: Expired => Fix Committed
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1892081
Title:
Performance improvement when using "QEMU_FLATTEN" with softfloat type
** Changed in: qemu
Status: Expired => Fix Committed
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1705118
Title:
qemu user mode: rt signals not implemented for sparc guests
Status in
Great!! I'm happy to do so. Thanks for the reply!
On Tue, Jun 22, 2021 at 1:51 PM Philippe Mathieu-Daudé
wrote:
> Hi Joanne,
>
> On 6/22/21 8:07 PM, Joanne Koong wrote:
> > Hello! I noticed that the default SD/MMC host controller only supports a
> > 32-bit system bus. Is there a reason 64-bit
On Wed, Jun 23, 2021 at 04:39:18PM +0100, Daniel P. Berrangé wrote:
> On Wed, Jun 23, 2021 at 07:31:13PM +0400, Marc-André Lureau wrote:
> > Hi
> >
> > On Wed, Jun 23, 2021 at 7:10 PM Daniel P. Berrangé
> > wrote:
> >
> > > On Wed, Jun 23, 2021 at 02:16:55PM +0200, Markus Armbruster wrote:
> >
On 6/23/21 5:56 PM, John Snow wrote:
> On 6/14/21 3:32 PM, Philippe Mathieu-Daudé wrote:
>> Hi,
>>
>> The floppy disc controllers pulls in irrelevant devices (sysbus in
>> an ISA-only machine, ISA bus + isa devices on a sysbus-only machine).
>>
>> This series clean that by extracting each device
On Wed, 23 Jun 2021 at 15:31, Taylor Simpson wrote:
>
> Adding Peter to the CC list ...
This is on my to-process list (I catch pull requests by
looking for particular text in the email), but it's from
a git repository I haven't dealt with before, so it went
onto my "deal with when I have some
On Wed, Jun 23, 2021 at 7:04 PM Kevin Wolf wrote:
>
> Am 23.06.2021 um 15:58 hat Nir Soffer geschrieben:
> > On Wed, Jun 23, 2021 at 11:58 AM Kevin Wolf wrote:
> > >
> > > Am 22.06.2021 um 18:56 hat Nir Soffer geschrieben:
> > > > On Tue, Jun 22, 2021 at 6:38 PM Kevin Wolf wrote:
> > > > >
> >
Adding Marcel and Dave.
Adding Alex (seriously, a vfio- / iommu-related patch set without Alex on CC?)
comments below
On 06/23/21 14:30, Igor Mammedov wrote:
> On Tue, 22 Jun 2021 16:49:03 +0100
> Joao Martins wrote:
>
>> pci_memory initialized by q35 and i440fx is set to a range
>> of 0 ..
Am 23.06.2021 um 15:58 hat Nir Soffer geschrieben:
> On Wed, Jun 23, 2021 at 11:58 AM Kevin Wolf wrote:
> >
> > Am 22.06.2021 um 18:56 hat Nir Soffer geschrieben:
> > > On Tue, Jun 22, 2021 at 6:38 PM Kevin Wolf wrote:
> > > >
> > > > Am 11.06.2021 um 21:03 hat Eric Blake geschrieben:
> > > > >
Arguments were passed to plugins in the following form:
-plugin path/to/plugin,arg="positional_arg=value",arg="second_arg"
This patch removes the need for "arg" so that the argument name itself
is now expected and passed directly to the plugin.
Now options can be passed in the following
> -Original Message-
> From: Alessandro Di Federico
> Sent: Saturday, June 19, 2021 3:37 AM
> To: qemu-devel@nongnu.org
> Cc: Taylor Simpson ; Brian Cain
> ; bab...@rev.ng; ni...@rev.ng; phi...@redhat.com;
> richard.hender...@linaro.org; Alessandro Di Federico
> Subject: [PATCH v5
On 6/14/21 3:32 PM, Philippe Mathieu-Daudé wrote:
Hi,
The floppy disc controllers pulls in irrelevant devices (sysbus in
an ISA-only machine, ISA bus + isa devices on a sysbus-only machine).
This series clean that by extracting each device in its own file,
adding the corresponding Kconfig
Arguments were passed to plugins in the following form:
-plugin path/to/plugin,arg="positional_arg=value",arg="second_arg"
This patch removes the need for "arg" so that the argument name itself
is now expected and passed directly to the plugin.
Now options can be passed in the following
On 08.06.21 15:16, Paolo Bonzini wrote:
From: Joelle van Dyne
iOS hosts do not have these defined so we fallback to the
default behaviour.
Co-authored-by: Warner Losh
Reviewed-by: Peter Maydell
Signed-off-by: Joelle van Dyne
Message-Id: <20210315180341.31638-...@getutm.app>
Signed-off-by:
> -Original Message-
> From: Alessandro Di Federico
> Sent: Saturday, June 19, 2021 3:37 AM
> To: qemu-devel@nongnu.org
> Cc: Taylor Simpson ; Brian Cain
> ; bab...@rev.ng; ni...@rev.ng; phi...@redhat.com;
> richard.hender...@linaro.org; Alessandro Di Federico
> Subject: [PATCH v5
On 08.06.21 15:16, Paolo Bonzini wrote:
From: Joelle van Dyne
On Darwin (iOS), there are no system level APIs for directly accessing
host block devices. We detect this at configure time.
Signed-off-by: Joelle van Dyne
Message-Id: <20210315180341.31638-...@getutm.app>
Signed-off-by: Paolo
On 08.06.21 21:14, Vladimir Sementsov-Ogievskiy wrote:
08.06.2021 16:16, Paolo Bonzini wrote:
Even though it was only called for devices that have bs->sg set (which
must be character devices), sg_get_max_segments looked at /sys/dev/block
which only works for block devices.
On Linux the sg
On Wed, Jun 23, 2021 at 07:31:13PM +0400, Marc-André Lureau wrote:
> Hi
>
> On Wed, Jun 23, 2021 at 7:10 PM Daniel P. Berrangé
> wrote:
>
> > On Wed, Jun 23, 2021 at 02:16:55PM +0200, Markus Armbruster wrote:
> > > _abort has been a clear win for us. _fatal too, when used
> > > judiciously.
Hi
On Wed, Jun 23, 2021 at 7:10 PM Daniel P. Berrangé
wrote:
> On Wed, Jun 23, 2021 at 02:16:55PM +0200, Markus Armbruster wrote:
> > _abort has been a clear win for us. _fatal too, when used
> > judiciously. Marc-André tried to get both into GLib, unsuccessfully[2].
>
> ...snip...
>
> > [2]
On 06/23/21 07:47, Bin Meng wrote:
> Hi Laszlo,
>
> On Wed, Jun 23, 2021 at 12:13 AM Laszlo Ersek wrote:
>
>> On 06/18/21 15:06, Bin Meng wrote:
>>> On Fri, Jun 18, 2021 at 7:46 PM Gerd Hoffmann wrote:
>>>
On Fri, Jun 18, 2021 at 06:46:57PM +0800, Bin Meng wrote:
> Hi Laszlo,
>
Yes, you are right.
I think keep the old pattern is better.
From: Cornelia Huck
Sent: Tuesday, June 22, 2021 7:39 PM
To: Al Cho ; qemu-devel@nongnu.org ;
qemu-s3...@nongnu.org
Cc: Claudio Fontana ; Al Cho ; Claudio
Fontana ; David Hildenbrand
Subject: Re: [RFC
On Mon, Jun 21, 2021 at 12:16:41PM +0800, Jason Wang wrote:
The queue_index of NetClientState should be assigned in set_netdev()
afterwards, so trying to net_vhost_vdpa_init() is meaningless. This
patch removes this.
Signed-off-by: Jason Wang
---
net/vhost-vdpa.c | 1 -
1 file changed, 1
On Wed, Jun 23, 2021 at 02:16:55PM +0200, Markus Armbruster wrote:
> _abort has been a clear win for us. _fatal too, when used
> judiciously. Marc-André tried to get both into GLib, unsuccessfully[2].
...snip...
> [2] https://gitlab.gnome.org/GNOME/glib/-/issues/2288
This doesn't actually
As we have attempted before
(https://lists.gnu.org/archive/html/qemu-devel/2019-01/msg06451.html,
"file-posix: Cache lseek result for data regions";
https://lists.nongnu.org/archive/html/qemu-block/2021-02/msg00934.html,
"file-posix: Cache next hole"), this patch seeks to reduce the number of
On Mon, Jun 21, 2021 at 12:16:42PM +0800, Jason Wang wrote:
This path switches to open device fd in net_init_vhost_vpda(). This is
used to prepare for the multiqueue support.
Signed-off-by: Jason Wang
---
net/vhost-vdpa.c | 23 +++
1 file changed, 15 insertions(+), 8
On Mon, Jun 21, 2021 at 12:16:40PM +0800, Jason Wang wrote:
Vhost_vdpa_add() can fail for various reasons, so the assertion of the
succeed is wrong. Instead, we should free the NetClientState and
propagate the error to the caller
Signed-off-by: Jason Wang
---
net/vhost-vdpa.c | 5 -
1 file
bdrv_co_block_status() does it for us, we do not need to do it here.
The advantage of not capping *pnum is that bdrv_co_block_status() can
cache larger data regions than requested by its caller.
Signed-off-by: Max Reitz
Reviewed-by: Eric Blake
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
bdrv_co_block_status() does it for us, we do not need to do it here.
The advantage of not capping *pnum is that bdrv_co_block_status() can
cache larger data regions than requested by its caller.
Signed-off-by: Max Reitz
Reviewed-by: Eric Blake
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
On Mon, Jun 21, 2021 at 12:16:39PM +0800, Jason Wang wrote:
Introduce new error label to avoid the unnecessary checking of net
pointer.
Fixes: 1e0a84ea49b68 ("vhost-vdpa: introduce vhost-vdpa net client")
Signed-off-by: Jason Wang
---
net/vhost-vdpa.c | 13 ++---
1 file changed, 6
There is a comment above the BDS definition stating care must be taken
to consider handling newly added fields in bdrv_append().
Actually, this comment should have said "bdrv_swap()" as of 4ddc07cac
(nine years ago), and in any case, bdrv_swap() was dropped in
8e419aefa (six years ago). So no
bdrv_co_block_status() does it for us, we do not need to do it here.
The advantage of not capping *pnum is that bdrv_co_block_status() can
cache larger data regions than requested by its caller.
Signed-off-by: Max Reitz
Reviewed-by: Eric Blake
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
.bdrv_co_block_status() implementations are free to return a *pnum that
exceeds @bytes, because bdrv_co_block_status() in block/io.c will clamp
*pnum as necessary.
On the other hand, if drivers' implementations return values for *pnum
that are as large as possible, our recently introduced
Hi,
See the cover letter from v1 for the general idea:
https://lists.nongnu.org/archive/html/qemu-block/2021-06/msg00843.html
The biggest change here in v2 is that instead of having a common CoMutex
protect the block-status cache, we’re using RCU now. So to read from
the cache, or even to
On 6/23/21 8:16 AM, Markus Armbruster wrote:
Nevertheless, I'm reluctant to add more differeneces. That's not a
"no". It's a "you need to make a compelling case".
I'm not sure it's my case to make; I believe you are the authority in
this matter so the work should be defined in terms of what
On Mon, Jun 21, 2021 at 12:16:38PM +0800, Jason Wang wrote:
Fixes: 1e0a84ea49b68 ("vhost-vdpa: introduce vhost-vdpa net client")
Signed-off-by: Jason Wang
---
net/vhost-vdpa.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c
index f5689a7c32..21f09c546f
On Mon, Jun 21, 2021 at 12:16:37PM +0800, Jason Wang wrote:
The previous vhost_net_cleanup is sufficient for freeing, calling
vhost_vdpa_del() in this case will lead an extra round of free. Note
that this kind of "double free" is safe since vhost_dev_cleanup() zero
the whole structure.
On Mon, Jun 21, 2021 at 12:16:36PM +0800, Jason Wang wrote:
The VhostVDPAState is just allocated by qemu_new_net_client() via
g_malloc0() in net_vhost_vdpa_init(). So s->vhost_net is NULL for
sure, let's remove this unnecessary check in vhost_vdpa_add().
Signed-off-by: Jason Wang
---
The FP-to-integer conversion instructions need to set CC 3 whenever
a "special case" occurs; this is the case whenever the instruction
also signals the IEEE invalid exception. (See e.g. figure 19-18
in the Principles of Operation.)
However, qemu currently will set CC 3 only in the case where the
On Mon, Jun 21, 2021 at 12:16:35PM +0800, Jason Wang wrote:
This patch switches to initialize dev.nvqs from the VhostNetOptions
instead of assuming it was 2. This is useful for implementing control
virtqueue support which will be a single vhost_net structure with a
single cvq.
Signed-off-by:
PCIE_SLOT property renamed to "native-hotplug" to be more concise
and consistent with other properties.
Signed-off-by: Julia Suvorova
---
hw/i386/pc_q35.c | 4 ++--
hw/pci/pcie_port.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c
Patchew URL:
https://patchew.org/QEMU/20210623142245.307776-1-berra...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210623142245.307776-1-berra...@redhat.com
Subject: [PATCH v4 00/22] tests/docker:
This commit is best examined using the "-b" option to diff.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Daniel P. Berrangé
---
tests/docker/dockerfiles-refresh.py| 6 +
tests/docker/dockerfiles/ubuntu2004.docker | 253 -
2 files changed, 146 insertions(+),
Adding Peter to the CC list ...
> -Original Message-
> From: Taylor Simpson
> Sent: Friday, June 18, 2021 1:07 PM
> To: qemu-devel@nongnu.org
> Cc: Taylor Simpson ; richard.hender...@linaro.org;
> phi...@redhat.com; a...@rev.ng; Brian Cain
> Subject: [PULL 0/4] Hexagon (target/hexagon)
This commit is best examined using the "-b" option to diff.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Daniel P. Berrangé
---
tests/docker/dockerfiles-refresh.py| 6 +
tests/docker/dockerfiles/ubuntu1804.docker | 251 -
2 files changed, 145 insertions(+),
This introduces
https://gitlab.com/libvirt/libvirt-ci
as a git submodule at tests/docker/libvirt-ci
This submodule only needs to be checked out when needing to re-generate
the files in tests/docker/dockerfiles.
When a new build pre-requisite is needed for QEMU, it should be added to
the
This commit is best examined using the "-b" option to diff.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Daniel P. Berrangé
---
tests/docker/dockerfiles-refresh.py| 1 +
tests/docker/dockerfiles/fedora.docker | 254 ++---
2 files changed, 141 insertions(+), 114
This is the fully expanded list of build pre-requisites QEMU can
conceivably use in any scenario.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Daniel P. Berrangé
---
tests/docker/dockerfiles/opensuse-leap.docker | 59 ++-
1 file changed, 58 insertions(+), 1 deletion(-)
This commit is best examined using the "-b" option to diff.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Daniel P. Berrangé
---
tests/docker/dockerfiles-refresh.py | 1 +
tests/docker/dockerfiles/opensuse-leap.docker | 239 ++
2 files changed, 130
> On Jun 21, 2021, at 7:46 AM, Paolo Bonzini wrote:
> I agree that there's obviously a bug in QEMU. However, I'm worried of two
> things with this patch.
>
> First, the RTC device model has a complicated mechanism to deliver missed
> ticks of the periodic timer. This is used with old
This is the fully expanded list of build pre-requisites QEMU can
conceivably use in any scenario.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Daniel P. Berrangé
---
tests/docker/dockerfiles/ubuntu1804.docker | 61 +-
1 file changed, 60 insertions(+), 1 deletion(-)
This duplicates the ubuntu2004 container but with an inconsistent set of
packages.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Daniel P. Berrangé
---
.gitlab-ci.d/containers.yml| 5 --
tests/docker/dockerfiles/ubuntu.docker | 71 --
2 files changed,
This commit is best examined using the "-b" option to diff.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Daniel P. Berrangé
---
tests/docker/dockerfiles-refresh.py | 2 +-
tests/docker/dockerfiles/centos8.docker | 238 +---
2 files changed, 132 insertions(+),
1 - 100 of 236 matches
Mail list logo
