[Bug 1905297] Moved bug report

2021-07-10 Thread Thomas Huth
This is an automated cleanup. This bug report has been moved to QEMU's new bug tracker on gitlab.com and thus gets marked as 'expired' now. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/468 -- You received this bug notification because you are a member

[Bug 1905297] Re: Zynq7000 UART clock reset initialization

2021-07-10 Thread Thomas Huth
I guess the patch has never been sent to the qemu-devel mailing list and thus was never considered for inclusion. Anyway, let's move this ticket over to the new bug tracker at gitlab.com, maybe it gets more attention there... ** Changed in: qemu Status: Incomplete => Expired ** Bug watch

[Bug 1779955] Re: qemu linux-user requires read permissions on memory passed to syscalls that should only need write access

2021-07-10 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1779955 Title: qemu

[Bug 1785734] Re: movdqu partial write at page boundary

2021-07-10 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1785734 Title: movdqu

[Bug 1862874] Re: java may stuck for a long time in system mode with "-cpu max"

2021-07-10 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1862874 Title: java may

[Bug 1870331] Re: default nic device created even though supplied by configfile

2021-07-10 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1870331 Title: default

[Bug 1897481] Re: qemu crashes with VGA pass-through, e-GPU, nvidia 1060

2021-07-10 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1897481 Title: qemu

[Bug 1869006] Re: PCIe cards passthrough to TCG guest works on 2GB of guest memory but fails on 4GB (vfio_dma_map invalid arg)

2021-07-10 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1869006 Title: PCIe cards

[Bug 1902306] Re: Allow setting usb storage device ID parameters

2021-07-10 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1902306 Title: Allow

[Bug 1873769] Re: SB16 audio playback freezes emulation in Windows 95 guest

2021-07-10 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1873769 Title: SB16 audio

[Bug 1878501] Re: qemu-i386 does not define AT_SYSINFO

2021-07-10 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1878501 Title: qemu-i386

Re: [PATCH v3 0/8] dp8393x: fixes and improvements

2021-07-10 Thread Finn Thain
On Sat, 10 Jul 2021, Philippe Mathieu-Daudé wrote: > > The last 2 patches are included for Mark, but I don't plan to merge > > them without Finn's Ack, and apparently they require more work. > I tested the patch series both with and without the last 2 patches. Both builds worked fine with

Re: [PATCH 00/41] tcg patch queue

2021-07-10 Thread Richard Henderson
ch 'remotes/mst/tags/for_upstream' into > staging (2021-07-09 14:30:01 +0100) > > > > are available in the Git repository at: > > > > https://gitlab.com/rth7680/qemu.git tags/pull-tcg-20210710 > > > > for you to fetch changes up to ad1a706f386c2281adb0b09257d892735e4058

Re: [NOTFORMERGE PATCH v3 8/8] dp8393x: don't force 32-bit register access

2021-07-10 Thread Mark Cave-Ayland
On 10/07/2021 18:49, Philippe Mathieu-Daudé wrote: From: Mark Cave-Ayland Commit 3fe9a838ec "dp8393x: Always use 32-bit accesses" set .impl.min_access_size and .impl.max_access_size to 4 to try and fix the Linux jazzsonic driver which uses 32-bit accesses. The problem with forcing the

Re: [NOTFORMERGE PATCH v3 7/8] dp8393x: Rewrite dp8393x_get() / dp8393x_put()

2021-07-10 Thread Mark Cave-Ayland
On 10/07/2021 18:49, Philippe Mathieu-Daudé wrote: Instead of accessing N registers via a single address_space API call using a temporary buffer (stored in the device state) and updating each register, move the address_space call in the register put/get. The load/store and word size checks are

Re: [PATCH v3 6/8] dp8393x: Store CRC using device configured endianess

2021-07-10 Thread Mark Cave-Ayland
On 10/07/2021 18:49, Philippe Mathieu-Daudé wrote: Little-Endian CRC is dubious. The datasheet does not specify it being little-endian. Use big-endian access when the device is configured in such endianess. (This is a theoretical bug fix.) Signed-off-by: Philippe Mathieu-Daudé ---

Re: [PATCH v3 5/8] dp8393x: Migrate registers as array of uint16

2021-07-10 Thread Mark Cave-Ayland
On 10/07/2021 18:49, Philippe Mathieu-Daudé wrote: The CAM registers are now arrays of 3 uint16_t. We can avoid using the VMSTATE_BUFFER_UNSAFE() macro by using VMSTATE_UINT16_2DARRAY() which is more appropriate. Suggested-by: Mark Cave-Ayland Signed-off-by: Philippe Mathieu-Daudé ---

Re: [PATCH v3 4/8] dp8393x: Store CAM registers as 16-bit

2021-07-10 Thread Mark Cave-Ayland
On 10/07/2021 18:49, Philippe Mathieu-Daudé wrote: Per the DP83932C datasheet from July 1995: 4.0 SONIC Registers 4.1 THE CAM UNIT The Content Addressable Memory (CAM) consists of sixteen 48-bit entries for complete address filtering of network packets. Each entry

Re: [PATCH v3 3/8] dp8393x: Only shift the device registers mapping by 1 bit

2021-07-10 Thread Mark Cave-Ayland
On 10/07/2021 18:49, Philippe Mathieu-Daudé wrote: The SONIC device only allows 16/32-bit accesses. From the machine view (from the bus), it is only shifted by 1 bit. Another bit is shifted, but it is an implementation detail of the QEMU model. Signed-off-by: Philippe Mathieu-Daudé ---

Re: [PATCH v3 2/8] dp8393x: Replace 0x40 magic value by SONIC_REG16_COUNT definition

2021-07-10 Thread Mark Cave-Ayland
On 10/07/2021 18:49, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé --- hw/net/dp8393x.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/net/dp8393x.c b/hw/net/dp8393x.c index 9118364aa33..d1e147a82a6 100644 --- a/hw/net/dp8393x.c +++

Re: [PATCH v3 1/8] dp8393x: Replace address_space_rw(is_write=1) by address_space_write()

2021-07-10 Thread Mark Cave-Ayland
On 10/07/2021 18:49, Philippe Mathieu-Daudé wrote: Replace address_space_rw(is_write=1) by address_space_write() and remove pointless cast. Signed-off-by: Philippe Mathieu-Daudé --- hw/net/dp8393x.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

Re: [RFC PATCH 1/6] linux-header: add the SNP specific command

2021-07-10 Thread Michael S. Tsirkin
On Fri, Jul 09, 2021 at 04:55:45PM -0500, Brijesh Singh wrote: > Sync the kvm.h with the kernel to include the SNP specific commands. > > Signed-off-by: Brijesh Singh Pls specify which kernel version you used for the sync. > --- > linux-headers/linux/kvm.h | 47

Re: [PULL 00/28] Block layer patches

2021-07-10 Thread Peter Maydell
On Fri, 9 Jul 2021 at 13:50, Kevin Wolf wrote: > > The following changes since commit 9db3065c62a983286d06c207f4981408cf42184d: > > Merge remote-tracking branch > 'remotes/vivier2/tags/linux-user-for-6.1-pull-request' into staging > (2021-07-08 16:30:18 +0100) > > are available in the Git

[PULL v2 48/48] meson: Use input/output for entitlements target

2021-07-10 Thread Paolo Bonzini
From: Akihiko Odaki input/output parameters respect dependencies. Signed-off-by: Akihiko Odaki Message-Id: <20210709012533.58262-1-akihiko.od...@gmail.com> Signed-off-by: Paolo Bonzini --- meson.build| 30 +- scripts/entitlement.sh | 10 +- 2

[PULL v2 05/48] modules: add modinfo macros

2021-07-10 Thread Paolo Bonzini
From: Gerd Hoffmann Add macros for module info annotations. Instead of having that module meta-data stored in lists in util/module.c place directly in the module source code. Signed-off-by: Gerd Hoffmann Reviewed-by: Jose R. Ziviani Message-Id: <20210624103836.2382472-2-kra...@redhat.com>

[PULL v2 00/48] Misc patches for QEMU 6.1 soft freeze

2021-07-10 Thread Paolo Bonzini
The following changes since commit 05de778b5b8ab0b402996769117b88c7ea5c7c61: Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2021-07-09 14:30:01 +0100) are available in the Git repository at: https://gitlab.com/bonzini/qemu.git tags/for-upstream for you to fetch

Re: [PULL 00/33] ppc-for-6.1 queue 20210709

2021-07-10 Thread Peter Maydell
On Fri, 9 Jul 2021 at 06:17, David Gibson wrote: > > The following changes since commit 9db3065c62a983286d06c207f4981408cf42184d: > > Merge remote-tracking branch > 'remotes/vivier2/tags/linux-user-for-6.1-pull-request' into staging > (2021-07-08 16:30:18 +0100) > > are available in the Git

Re: [PATCH v2 3/3] qemu-img: Add --skip-broken-bitmaps for 'convert --bitmaps'

2021-07-10 Thread Nir Soffer
On 7/9/21 6:39 PM, Eric Blake wrote: The point of 'qemu-img convert --bitmaps' is to be a convenience for actions that are already possible through a string of smaller 'qemu-img bitmap' sub-commands. One situation not accounted for already is that if a source image contains an inconsistent

Re: [PATCH v2 2/3] qemu-img: Fail fast on convert --bitmaps with inconsistent bitmap

2021-07-10 Thread Nir Soffer
On 7/9/21 6:39 PM, Eric Blake wrote: Waiting until the end of the convert operation (a potentially time-consuming task) to finally detect that we can't copy a bitmap is bad, comparing to failing fast up front. Furthermore, this prevents us from leaving a file behind with a bitmap that is not

[NOTFORMERGE PATCH v3 7/8] dp8393x: Rewrite dp8393x_get() / dp8393x_put()

2021-07-10 Thread Philippe Mathieu-Daudé
Instead of accessing N registers via a single address_space API call using a temporary buffer (stored in the device state) and updating each register, move the address_space call in the register put/get. The load/store and word size checks are moved to put/get too. This simplifies a bit, making

[PATCH v3 5/8] dp8393x: Migrate registers as array of uint16

2021-07-10 Thread Philippe Mathieu-Daudé
The CAM registers are now arrays of 3 uint16_t. We can avoid using the VMSTATE_BUFFER_UNSAFE() macro by using VMSTATE_UINT16_2DARRAY() which is more appropriate. Suggested-by: Mark Cave-Ayland Signed-off-by: Philippe Mathieu-Daudé --- hw/net/dp8393x.c | 6 +++--- 1 file changed, 3

[NOTFORMERGE PATCH v3 8/8] dp8393x: don't force 32-bit register access

2021-07-10 Thread Philippe Mathieu-Daudé
From: Mark Cave-Ayland Commit 3fe9a838ec "dp8393x: Always use 32-bit accesses" set .impl.min_access_size and .impl.max_access_size to 4 to try and fix the Linux jazzsonic driver which uses 32-bit accesses. The problem with forcing the register access to 32-bit in this way is that since the

Re: [PATCH v3 2/8] dp8393x: Replace 0x40 magic value by SONIC_REG16_COUNT definition

2021-07-10 Thread Philippe Mathieu-Daudé
Typo 'SONIC_REG_COUNT' in subject. On Sat, Jul 10, 2021 at 7:50 PM Philippe Mathieu-Daudé wrote: > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/net/dp8393x.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/hw/net/dp8393x.c b/hw/net/dp8393x.c > index

[PATCH v3 4/8] dp8393x: Store CAM registers as 16-bit

2021-07-10 Thread Philippe Mathieu-Daudé
Per the DP83932C datasheet from July 1995: 4.0 SONIC Registers 4.1 THE CAM UNIT The Content Addressable Memory (CAM) consists of sixteen 48-bit entries for complete address filtering of network packets. Each entry corresponds to a 48-bit destination address that is user

[PATCH v3 6/8] dp8393x: Store CRC using device configured endianess

2021-07-10 Thread Philippe Mathieu-Daudé
Little-Endian CRC is dubious. The datasheet does not specify it being little-endian. Use big-endian access when the device is configured in such endianess. (This is a theoretical bug fix.) Signed-off-by: Philippe Mathieu-Daudé --- hw/net/dp8393x.c | 11 --- 1 file changed, 8

[PATCH v3 3/8] dp8393x: Only shift the device registers mapping by 1 bit

2021-07-10 Thread Philippe Mathieu-Daudé
The SONIC device only allows 16/32-bit accesses. From the machine view (from the bus), it is only shifted by 1 bit. Another bit is shifted, but it is an implementation detail of the QEMU model. Signed-off-by: Philippe Mathieu-Daudé --- hw/m68k/q800.c | 2 +- hw/mips/jazz.c | 2 +-

[PATCH v3 2/8] dp8393x: Replace 0x40 magic value by SONIC_REG16_COUNT definition

2021-07-10 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- hw/net/dp8393x.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/net/dp8393x.c b/hw/net/dp8393x.c index 9118364aa33..d1e147a82a6 100644 --- a/hw/net/dp8393x.c +++ b/hw/net/dp8393x.c @@ -85,6 +85,7 @@ static const char

[PATCH v3 1/8] dp8393x: Replace address_space_rw(is_write=1) by address_space_write()

2021-07-10 Thread Philippe Mathieu-Daudé
Replace address_space_rw(is_write=1) by address_space_write() and remove pointless cast. Signed-off-by: Philippe Mathieu-Daudé --- hw/net/dp8393x.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/net/dp8393x.c b/hw/net/dp8393x.c index 11810c9b600..9118364aa33

[PATCH v3 0/8] dp8393x: fixes and improvements

2021-07-10 Thread Philippe Mathieu-Daudé
Hi Mark, Finn. This respin aims go group all the fixes sent/suggested on the list the last weeks around the dp8393x device. Mark, can you send your S-o-b for patches 4 & 6? The last 2 patches are included for Mark, but I don't plan to merge them without Finn's Ack, and apparently they require

Re: [PATCH v2 1/3] iotests: Improve and rename test 291 to qemu-img-bitmap

2021-07-10 Thread Nir Soffer
On 7/9/21 6:39 PM, Eric Blake wrote: Enhance the test to demonstrate existing less-than-stellar behavior of qemu-img with a qcow2 image containing an inconsistent bitmap: we don't diagnose the problem until after copying the entire image (a potentially long time), and when we do diagnose the

Re: retrying failed gitlab CI external jobs (travis)

2021-07-10 Thread Peter Maydell
On Sat, 10 Jul 2021 at 14:34, Peter Maydell wrote: > > Hi; we now have travis's CI hooked into gitlab, which is nice. However, > unlike the gitlab native CI jobs, there's no UI for saying "retry this" > when the "travis CI" part of the overall gitlab pipeline fails. > This is awkward because

Re: [PATCH 00/41] tcg patch queue

2021-07-10 Thread Peter Maydell
in the Git repository at: > > https://gitlab.com/rth7680/qemu.git tags/pull-tcg-20210710 > > for you to fetch changes up to ad1a706f386c2281adb0b09257d892735e405834: > > cpu: Add breakpoint tracepoints (2021-07-09 21:31:11 -0700) > >

[Bug 1905297] Re: Zynq7000 UART clock reset initialization

2021-07-10 Thread Floyd42
Any update? ** Changed in: qemu Status: Expired => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1905297 Title: Zynq7000 UART clock reset initialization Status in QEMU:

[PATCH 38/41] accel/tcg: Split out log_cpu_exec

2021-07-10 Thread Richard Henderson
Split out CPU_LOG_EXEC and CPU_LOG_TB_CPU logging from cpu_tb_exec to a new function. Perform only one pc range check after a combined mask check. Use the new function in lookup_tb_ptr. This enables CPU_LOG_TB_CPU between indirectly chained tbs. Signed-off-by: Richard Henderson ---

[PATCH 37/41] accel/tcg: Move tb_lookup to cpu-exec.c

2021-07-10 Thread Richard Henderson
Now that we've moved helper_lookup_tb_ptr, the only user of tb-lookup.h is cpu-exec.c; merge the contents in. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- accel/tcg/tb-lookup.h | 49 --- accel/tcg/cpu-exec.c | 31

[PATCH 36/41] accel/tcg: Move helper_lookup_tb_ptr to cpu-exec.c

2021-07-10 Thread Richard Henderson
This will allow additional code sharing. No functional change. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- accel/tcg/cpu-exec.c| 30 ++ accel/tcg/tcg-runtime.c | 22 -- 2 files changed, 30 insertions(+), 22

[PATCH 34/41] tcg: Fix prologue disassembly

2021-07-10 Thread Richard Henderson
In tcg_region_prologue_set, we reset TCGContext.code_gen_ptr. So do that after we've used it to dump the prologue contents. Fixes: b0a0794a0f16 Signed-off-by: Richard Henderson --- tcg/tcg.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tcg/tcg.c b/tcg/tcg.c index

[PATCH 31/41] target/tricore: Use translator_use_goto_tb

2021-07-10 Thread Richard Henderson
Just use translator_use_goto_tb directly at the one call site, rather than maintaining a local wrapper. Reviewed-by: Bastian Koppelmann Signed-off-by: Richard Henderson --- target/tricore/translate.c | 17 ++--- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git

[PATCH 40/41] tcg: Remove TCG_TARGET_HAS_goto_ptr

2021-07-10 Thread Richard Henderson
Since 6eea04347eb6, all tcg backends support goto_ptr. Remove the conditional, making support mandatory. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- include/tcg/tcg-opc.h| 3 +-- tcg/aarch64/tcg-target.h | 1 - tcg/arm/tcg-target.h | 1 -

[PATCH 28/41] target/s390x: Remove use_exit_tb

2021-07-10 Thread Richard Henderson
We have not needed to end a TB for I/O since ba3e7926691 ("icount: clean up cpu_can_io at the entry to the block"). In use_goto_tb, the check for singlestep_enabled is in the generic translator_use_goto_tb. In s390x_tr_tb_stop, the check for singlestep_enabled is in the preceding do_debug test.

[PATCH 25/41] target/riscv: Use translator_use_goto_tb

2021-07-10 Thread Richard Henderson
Just use translator_use_goto_tb directly at the one call site, rather than maintaining a local wrapper. Reviewed-by: Alistair Francis Signed-off-by: Richard Henderson --- target/riscv/translate.c | 20 +--- 1 file changed, 1 insertion(+), 19 deletions(-) diff --git

[PATCH 39/41] accel/tcg: Log tb->cflags with -d exec

2021-07-10 Thread Richard Henderson
Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- accel/tcg/cpu-exec.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c index 67ed25beb9..e22bcb99f7 100644 --- a/accel/tcg/cpu-exec.c +++

[PATCH 23/41] target/openrisc: Use translator_use_goto_tb

2021-07-10 Thread Richard Henderson
Reorder the control statements to allow using the page boundary check from translator_use_goto_tb(). Reviewed-by: Stafford Horne Signed-off-by: Richard Henderson --- target/openrisc/translate.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git

[PATCH 32/41] target/tricore: Use tcg_gen_lookup_and_goto_ptr

2021-07-10 Thread Richard Henderson
The non-single-step case of gen_goto_tb may use tcg_gen_lookup_and_goto_ptr to indirectly chain. Reviewed-by: Bastian Koppelmann Signed-off-by: Richard Henderson --- target/tricore/translate.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/target/tricore/translate.c

[PATCH 22/41] target/nios2: Use translator_use_goto_tb

2021-07-10 Thread Richard Henderson
Just use translator_use_goto_tb directly at the one call site, rather than maintaining a local wrapper. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/nios2/translate.c | 15 +-- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git

[PATCH 24/41] target/ppc: Use translator_use_goto_tb

2021-07-10 Thread Richard Henderson
Reviewed-by: Luis Pires Signed-off-by: Richard Henderson --- target/ppc/translate.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/target/ppc/translate.c b/target/ppc/translate.c index 07d79acc08..0ad601793c 100644 --- a/target/ppc/translate.c +++

[PATCH 18/41] target/m68k: Use translator_use_goto_tb

2021-07-10 Thread Richard Henderson
Just use translator_use_goto_tb directly at the one call site, rather than maintaining a local wrapper. Acked-by: Laurent Vivier Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/m68k/translate.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff

[PATCH 35/41] target/i386: Use cpu_breakpoint_test in breakpoint_handler

2021-07-10 Thread Richard Henderson
The loop is performing a simple boolean test for the existence of a BP_CPU breakpoint at EIP. Plus it gets the iteration wrong, if we happen to have a BP_GDB breakpoint at the same address. We have a function for this: cpu_breakpoint_test. Signed-off-by: Richard Henderson Reviewed-by: Eduardo

[PATCH 20/41] target/mips: Use translator_use_goto_tb

2021-07-10 Thread Richard Henderson
Just use translator_use_goto_tb directly at the one call site, rather than maintaining a local wrapper. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/mips/tcg/translate.c | 17 ++--- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git

[PATCH 17/41] target/i386: Use translator_use_goto_tb

2021-07-10 Thread Richard Henderson
Just use translator_use_goto_tb directly at the one call site, rather than maintaining a local wrapper. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/i386/tcg/translate.c | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git

[PATCH 19/41] target/microblaze: Use translator_use_goto_tb

2021-07-10 Thread Richard Henderson
Just use translator_use_goto_tb directly at the one call site, rather than maintaining a local wrapper. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/microblaze/translate.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git

[PATCH 30/41] target/sparc: Use translator_use_goto_tb

2021-07-10 Thread Richard Henderson
Reviewed-by: Mark Cave-Ayland Signed-off-by: Richard Henderson --- target/sparc/translate.c | 19 +-- 1 file changed, 5 insertions(+), 14 deletions(-) diff --git a/target/sparc/translate.c b/target/sparc/translate.c index f3fe7a0369..e530cb4aa8 100644 ---

[PATCH 16/41] target/hppa: Use translator_use_goto_tb

2021-07-10 Thread Richard Henderson
Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/hppa/translate.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/target/hppa/translate.c b/target/hppa/translate.c index 424ec3252e..835120c038 100644 --- a/target/hppa/translate.c +++

[PATCH 26/41] target/rx: Use translator_use_goto_tb

2021-07-10 Thread Richard Henderson
Just use translator_use_goto_tb directly at the one call site, rather than maintaining a local wrapper. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/rx/translate.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/target/rx/translate.c

[PATCH 14/41] target/avr: Mark some helpers noreturn

2021-07-10 Thread Richard Henderson
All of these helpers end with cpu_loop_exit. Reviewed-by: Michael Rolnik Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/avr/helper.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target/avr/helper.h b/target/avr/helper.h index

[PATCH 41/41] cpu: Add breakpoint tracepoints

2021-07-10 Thread Richard Henderson
Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- cpu.c| 13 + trace-events | 5 + 2 files changed, 14 insertions(+), 4 deletions(-) diff --git a/cpu.c b/cpu.c index 164fefeaa3..83059537d7 100644 --- a/cpu.c +++ b/cpu.c @@ -38,6 +38,7 @@

[PATCH 11/41] target/arm: Use translator_use_goto_tb for aarch64

2021-07-10 Thread Richard Henderson
We have not needed to end a TB for I/O since ba3e7926691 ("icount: clean up cpu_can_io at the entry to the block"), and gdbstub singlestep is handled by the generic function. Drop the unused 'n' argument to use_goto_tb. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson ---

[PATCH 21/41] target/mips: Fix missing else in gen_goto_tb

2021-07-10 Thread Richard Henderson
Do not emit dead code for the singlestep_enabled case, after having exited the TB with a debug exception. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/mips/tcg/translate.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH 12/41] target/arm: Use translator_use_goto_tb for aarch32

2021-07-10 Thread Richard Henderson
Just use translator_use_goto_tb directly at the one call site, rather than maintaining a local wrapper. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/arm/translate.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/target/arm/translate.c

[PATCH 33/41] target/xtensa: Use translator_use_goto_tb

2021-07-10 Thread Richard Henderson
Reviewed-by: Max Filippov Signed-off-by: Richard Henderson --- target/xtensa/translate.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/target/xtensa/translate.c b/target/xtensa/translate.c index d5da35f4fc..7094cfcf1d 100644 --- a/target/xtensa/translate.c +++

[PATCH 07/41] target/alpha: Remove use_exit_tb

2021-07-10 Thread Richard Henderson
We have not needed to end a TB for I/O since ba3e7926691 ("icount: clean up cpu_can_io at the entry to the block"). We do not need to use exit_tb for singlestep, which only means generate one insn per TB. Which leaves only singlestep_enabled, which means raise a debug trap after every TB, which

[PATCH 15/41] target/cris: Use translator_use_goto_tb

2021-07-10 Thread Richard Henderson
The test for singlestepping is done in translator_use_goto_tb, so we may elide it from cris_tr_tb_stop. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/cris/translate.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/target/cris/translate.c

[PATCH 08/41] target/alpha: Remove in_superpage

2021-07-10 Thread Richard Henderson
The number of links across (normal) pages using this is low, and it will shortly violate the contract for breakpoints. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/alpha/translate.c | 24 ++-- 1 file changed, 2 insertions(+), 22 deletions(-) diff

[PATCH 29/41] target/sh4: Use translator_use_goto_tb

2021-07-10 Thread Richard Henderson
Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/sh4/translate.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/target/sh4/translate.c b/target/sh4/translate.c index 8a25a4362e..40898e2393 100644 --- a/target/sh4/translate.c +++

[PATCH 13/41] target/avr: Use translator_use_goto_tb

2021-07-10 Thread Richard Henderson
Single stepping is not the only reason not to use goto_tb. If goto_tb is disallowed, and single-stepping is not enabled, then use tcg_gen_lookup_and_goto_tb to indirectly chain. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/avr/translate.c | 9 ++--- 1 file

[PATCH 05/41] tcg: Move tb_phys_invalidate_count to tb_ctx

2021-07-10 Thread Richard Henderson
We can call do_tb_phys_invalidate from an iocontext, which has no per-thread tcg_ctx. Move this to tb_ctx, which is global. The actual update still takes place with a lock held, so only an atomic set is required, not an atomic increment. Resolves:

[PATCH 02/41] tcg: Avoid including 'trace-tcg.h' in target translate.c

2021-07-10 Thread Richard Henderson
From: Philippe Mathieu-Daudé The root trace-events only declares a single TCG event: $ git grep -w tcg trace-events trace-events:115:# tcg/tcg-op.c trace-events:137:vcpu tcg guest_mem_before(TCGv vaddr, uint16_t info) "info=%d", "vaddr=0x%016"PRIx64" info=%d" and only a tcg/tcg-op.c

[PATCH 27/41] target/s390x: Use translator_use_goto_tb

2021-07-10 Thread Richard Henderson
Reviewed-by: David Hildenbrand Signed-off-by: Richard Henderson --- target/s390x/translate.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/target/s390x/translate.c b/target/s390x/translate.c index 5af68e01c6..767e77ca19 100644 --- a/target/s390x/translate.c +++

[PATCH 09/41] target/alpha: Use translator_use_goto_tb

2021-07-10 Thread Richard Henderson
Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/alpha/translate.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/target/alpha/translate.c b/target/alpha/translate.c index bb7b5ce994..833d3baa7b 100644 --- a/target/alpha/translate.c +++

[PATCH 03/41] accel/tcg: Hoist tcg_tb_insert() up above tb_link_page()

2021-07-10 Thread Richard Henderson
From: Liren Wei TranslationBlocks not inserted into the corresponding region tree shall be regarded as partially initialized objects, and needs to be finalized first before inserting into QHT. Signed-off-by: Liren Wei Message-Id: Signed-off-by: Richard Henderson ---

[PATCH 04/41] tcg: Bake tb_destroy() into tcg_region_tree

2021-07-10 Thread Richard Henderson
From: Liren Wei The function is called only at tcg_gen_code() when duplicated TBs are translated by different threads, and when the tcg_region_tree is reset. Bake it into the underlying GTree as its value destroy function to unite these situations. Also remove tcg_region_tree_traverse() which

[PATCH 10/41] target/arm: Use DISAS_TOO_MANY for ISB and SB

2021-07-10 Thread Richard Henderson
Using gen_goto_tb directly misses the single-step check. Let the branch or debug exception be emitted by arm_tr_tb_stop. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/arm/translate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 06/41] accel/tcg: Introduce translator_use_goto_tb

2021-07-10 Thread Richard Henderson
Add a generic version of the common use_goto_tb test. Various targets avoid the page crossing test for CONFIG_USER_ONLY, but that is wrong: mmap and mprotect can change page permissions. Reviewed-by: Max Filippov Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson ---

[PATCH 00/41] tcg patch queue

2021-07-10 Thread Richard Henderson
The following changes since commit 05de778b5b8ab0b402996769117b88c7ea5c7c61: Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2021-07-09 14:30:01 +0100) are available in the Git repository at: https://gitlab.com/rth7680/qemu.git tags/pull-tcg-20210710 for you

[PATCH 01/41] tcg: Add separator in INDEX_op_call dump

2021-07-10 Thread Richard Henderson
We lost the ',' following the called function name. Fixes: 3e92aa34434 Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- tcg/tcg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tcg/tcg.c b/tcg/tcg.c index 5150ed700e..4dd4084419 100644 ---

Re: [PULL v2 00/15] Machine queue, 2021-07-07

2021-07-10 Thread Peter Maydell
On Thu, 8 Jul 2021 at 20:55, Eduardo Habkost wrote: > > Changes v2: > * Fix doc build warning > > The following changes since commit 9aef0954195cc592e86846dbbe7f3c2c5603690a: > > Merge remote-tracking branch 'remotes/bonzini-gitlab/tags/for-upstream' > into staging (2021-07-06 11:24:58 +0100)

Re: [RFC PATCH 06/11] target/riscv: Update CSR xtvec in CLIC mode

2021-07-10 Thread Frank Chang
LIU Zhiwei 於 2021年4月9日 週五 下午3:51寫道: > The new CLIC interrupt-handling mode is encoded as a new state in the > existing WARL xtvec register, where the low two bits of are 11. > > Signed-off-by: LIU Zhiwei > --- > target/riscv/csr.c | 22 -- > 1 file changed, 20

Re: [RFC PATCH 08/11] target/riscv: Update CSR xnxti in CLIC mode

2021-07-10 Thread Frank Chang
LIU Zhiwei 於 2021年4月9日 週五 下午3:52寫道: > The CSR can be used by software to service the next horizontal interrupt > when it has greater level than the saved interrupt context > (held in xcause`.pil`) and greater level than the interrupt threshold of > the corresponding privilege mode, > >

Re: [PATCH v1 1/5] target/riscv: Expose interrupt pending bits as GPIO lines

2021-07-10 Thread Bin Meng
On Fri, Jul 9, 2021 at 11:30 AM Alistair Francis wrote: > > Expose the 12 interrupt pending bits in MIP as GPIO lines. > > Signed-off-by: Alistair Francis > --- > target/riscv/cpu.c | 30 ++ > 1 file changed, 30 insertions(+) > Reviewed-by: Bin Meng

retrying failed gitlab CI external jobs (travis)

2021-07-10 Thread Peter Maydell
Hi; we now have travis's CI hooked into gitlab, which is nice. However, unlike the gitlab native CI jobs, there's no UI for saying "retry this" when the "travis CI" part of the overall gitlab pipeline fails. This is awkward because travis seems to be prone to intermittent failures. Is there any

intermittent hang in qos-test for qemu-system-i386 on 32-bit arm host

2021-07-10 Thread Peter Maydell
I've noticed recently that intermittently 'make check' will hang on my aarch32 test system (really an aarch64 box with an aarch32 chroot). I think from grep that this must be the vhost-user-blk test. Here's the process tree: pmaydell 13126 0.0 0.0 8988 6416 ?SJul09 0:01 make

Re: [PATCH 2/4] target/openrisc: Use tcg_constant_tl for dc->R0

2021-07-10 Thread Stafford Horne
On Thu, Jul 08, 2021 at 02:37:52PM -0700, Richard Henderson wrote: > The temp allocated for tcg_const_tl is auto-freed at branches, > but pure constants are not. So we can remove the extra hoop > jumping in trans_l_swa. This is nice. > Signed-off-by: Richard Henderson Reviewed-by: Stafford

Re: [PATCH v1 1/1] vfio: Make migration support non experimental by default.

2021-07-10 Thread Claudio Fontana
On 3/8/21 5:09 PM, Tarun Gupta wrote: > VFIO migration support in QEMU is experimental as of now, which was done to > provide soak time and resolve concerns regarding bit-stream. > But, with the patches discussed in > https://www.mail-archive.com/qemu-devel@nongnu.org/msg784931.html , we have >

Re: [PATCH v4 3/3] memory_hotplug.c: send DEVICE_UNPLUG_ERROR in acpi_memory_hotplug_write()

2021-07-10 Thread Markus Armbruster
Igor Mammedov writes: > On Fri, 09 Jul 2021 13:25:43 +0200 > Markus Armbruster wrote: > >> Igor Mammedov writes: >> >> > On Thu, 08 Jul 2021 15:08:57 +0200 >> > Markus Armbruster wrote: >> > >> >> Daniel Henrique Barboza writes: >> >> >> >> > MEM_UNPLUG_ERROR is deprecated since the

Use of migrate_add_blocker() in qxl.c

2021-07-10 Thread Markus Armbruster
migrate_add_blocker() fails when running with --only-migratable, and when migration is in progress. qxl.c continues after migrate_add_blocker() fails: { /* * Windows 8 drivers place qxl commands in the vram * (instead of the ram) bar. We can't live