[PATCH v2 1/3] target-arm: delete ARM_FEATURE_A64FX

2021-07-29 Thread Shuuichirou Ishii
The ARM_FEATURE_A64FX property was added, but there is no function that uses this property yet, so it will be removed until a function that uses it is added. Signed-off-by: Shuuichirou Ishii --- target/arm/cpu.h | 1 - target/arm/cpu64.c | 1 - 2 files changed, 2 deletions(-) diff --git

[PATCH v2 3/3] target-arm: Add A64FX processor support to virt machine

2021-07-29 Thread Shuuichirou Ishii
Fix for patch consistency. https://lists.gnu.org/archive/html/qemu-devel/2021-07/msg06993.html Signed-off-by: Shuuichirou Ishii --- docs/system/arm/virt.rst | 1 + hw/arm/virt.c| 1 + 2 files changed, 2 insertions(+) diff --git a/docs/system/arm/virt.rst b/docs/system/arm/virt.rst

[PATCH v2 0/3] Add support for Fujitsu A64FX processor

2021-07-29 Thread Shuuichirou Ishii
This is the v2 patch series. v2: No features have been added or removed from the v1 patch series. Removal of unused definitions that were added in excess, and consolidation of patches for the purpose of functional consistency. For patch 1, ARM_FEATURE_A64FX is not used in the v1 patch series, so

[PATCH v2 2/3] target-arm: cpu64: Add support for Fujitsu A64FX

2021-07-29 Thread Shuuichirou Ishii
Remove unused definitions, change of appearance and fix for patch consistency https://lists.gnu.org/archive/html/qemu-devel/2021-07/msg04789.html https://lists.gnu.org/archive/html/qemu-devel/2021-07/msg04790.html Signed-off-by: Shuuichirou Ishii --- docs/system/arm/virt.rst | 1 -

[PATCH v2 0/3] Add support for Fujitsu A64FX processor

2021-07-29 Thread Shuuichirou Ishii
This is the v2 patch series. v2: No features have been added or removed from the v1 patch series. Removal of unused definitions that were added in excess, and consolidation of patches for the purpose of functional consistency. For patch 1, ARM_FEATURE_A64FX is not used in the v1 patch series, so

[PATCH] hw/char/virtio-serial-bus: fix: Unpop throttled VirtQueueElement to queue before discard vq data

2021-07-29 Thread AIERPATIJIANG1 [艾尔帕提江·阿布都赛买提]
Ports enter a "throttled" state when writing to the chardev would block. The current output VirtQueueElement is kept around until the chardev becomes writable again. Because closing the virtio serial device does not reset the queue, we cannot directly discard this element, otherwise the control

[PATCH] intel_iommu: Fix typo in comments

2021-07-29 Thread Cai Huoqing
Fix typo: *Unknwon ==> Unknown *futher ==> further *configed ==> configured Signed-off-by: Cai Huoqing --- hw/i386/intel_iommu.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c index 209b3f5553..75f075547f 100644 ---

[PATCH] hw/usb: Fix typo in comments and print

2021-07-29 Thread Cai Huoqing
Fix typo: *informations ==> information *enougth ==> enough *enouth ==> enough *registy ==> registry *releated ==> related *Ouptut ==> Output *manualy ==> manually *Attemping ==> Attempting *contine ==> continue *tranceiver ==> transceiver *Tranceiver ==> Transceiver Signed-off-by: Cai

[PATCH] hw/vfio: Fix typo in comments

2021-07-29 Thread Cai Huoqing
Fix typo in comments: *programatically ==> programmatically *disconecting ==> disconnecting *mulitple ==> multiple *timout ==> timeout *regsiter ==> register *forumula ==> formula Signed-off-by: Cai Huoqing --- hw/vfio/igd.c| 2 +- hw/vfio/pci-quirks.c | 2 +- hw/vfio/pci.c

Re: [PATCH v4 2/3] hw/net: e1000e: Correct the initial value of VET register

2021-07-29 Thread Bin Meng
Hi Jason, On Fri, Jul 23, 2021 at 3:55 PM Bin Meng wrote: > > From: Christina Wang > > The initial value of VLAN Ether Type (VET) register is 0x8100, as per > the manual and real hardware. > > While Linux e1000e driver always writes VET register to 0x8100, it is > not always the case for

Re: [PATCH for-6.2 12/43] target/sh4: Implement do_unaligned_access for user-only

2021-07-29 Thread Richard Henderson
On 7/29/21 3:52 AM, Peter Maydell wrote: sh4 kernel default for unaligned accesses seems to be "warn and fixup", not SIGBUS, unless the user changes that by writing to /proc/cpu/alignment or the process changes it via prctl(). We will still need this for load-locked/store-conditional

Re: [PATCH 1/3] ui/gtk: adds status bar for expressing ups and fps

2021-07-29 Thread Eric Blake
On Mon, Jul 26, 2021 at 03:25:49PM -0700, Dongwon Kim wrote: [meta-comment] When sending a patch series, remember to include a 0/3 cover letter, as it makes it easier to distinguish replies about the series as a whole from review of the first patch. > With a display option, "show-fps=on", qemu

Re: [PATCH v2 0/6] migration/ram: Optimize for virtio-mem via RamDiscardManager

2021-07-29 Thread Peter Xu
On Thu, Jul 29, 2021 at 10:06:16PM +0200, David Hildenbrand wrote: > On 29.07.21 22:00, Peter Xu wrote: > > On Thu, Jul 29, 2021 at 09:39:24PM +0200, David Hildenbrand wrote: > > > > > > > > In the meantime I adjusted the code but it does the clearing under the > > > > > iothread lock, which

Re: [PATCH-for-6.1? v2] target/nios2: Mark raise_exception() as noreturn

2021-07-29 Thread Richard Henderson
On 7/29/21 9:13 AM, Richard Henderson wrote: On 7/29/21 12:13 AM, Philippe Mathieu-Daudé wrote: Raised exceptions don't return, so mark the helper with noreturn. Fixes: 032c76bc6f9 ("nios2: Add architecture emulation support") Signed-off-by: Philippe Mathieu-Daudé --- Reviewed-by: Richard

Re: [PATCH v2 0/6] migration/ram: Optimize for virtio-mem via RamDiscardManager

2021-07-29 Thread David Hildenbrand
On 29.07.21 22:00, Peter Xu wrote: On Thu, Jul 29, 2021 at 09:39:24PM +0200, David Hildenbrand wrote: In the meantime I adjusted the code but it does the clearing under the iothread lock, which should not be what we want ... I'll have a look. Thanks; if it takes more changes than expected

Re: [PATCH v2 0/6] migration/ram: Optimize for virtio-mem via RamDiscardManager

2021-07-29 Thread Peter Xu
On Thu, Jul 29, 2021 at 09:39:24PM +0200, David Hildenbrand wrote: > > > > In the meantime I adjusted the code but it does the clearing under the > > > iothread lock, which should not be what we want ... I'll have a look. > > > > Thanks; if it takes more changes than expected we can still start

Re: [PATCH for-6.2 17/43] accel/tcg: Report unaligned atomics for user-only

2021-07-29 Thread Philippe Mathieu-Daudé
On 7/29/21 5:02 PM, Peter Maydell wrote: > On Thu, 29 Jul 2021 at 02:09, Richard Henderson > wrote: >> >> Use the newly exposed do_unaligned_access hook from atomic_mmu_lookup, >> which has access to complete alignment info from the TCGMemOpIdx arg. >> >> Signed-off-by: Richard Henderson >> ---

Re: [PATCH v2 0/6] migration/ram: Optimize for virtio-mem via RamDiscardManager

2021-07-29 Thread David Hildenbrand
In the meantime I adjusted the code but it does the clearing under the iothread lock, which should not be what we want ... I'll have a look. Thanks; if it takes more changes than expected we can still start from simple, IMHO, by taking bql and timely yield it. At the meantime, I found two

migration-test hang, s390x host, aarch64 guest

2021-07-29 Thread Peter Maydell
migration-test hung again during 'make check'. Process tree: ubuntu 42067 0.0 0.0 5460 3156 ?S13:55 0:00 \_ bash -o pipefail -c echo 'MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))} QTEST_QEMU_IMG=./qemu-img

Re: [PATCH v2 0/6] migration/ram: Optimize for virtio-mem via RamDiscardManager

2021-07-29 Thread Peter Xu
On Thu, Jul 29, 2021 at 06:19:31PM +0200, David Hildenbrand wrote: > On 29.07.21 18:12, Peter Xu wrote: > > On Thu, Jul 29, 2021 at 10:14:47AM +0200, David Hildenbrand wrote: > > > > > > > > The thing is I still think this extra operation during sync() > > > > > > > > can be ignored by > > > > >

Re: [PATCH v3 0/2] x86/sev: Measured Linux SEV guest with kernel/initrd/cmdline

2021-07-29 Thread Dov Murik
Hi Paolo, Phil, Connor, On 08/07/2021 20:16, Connor Kuehl wrote: > On 7/8/21 10:03 AM, Philippe Mathieu-Daudé wrote: >> On 7/8/21 6:41 PM, Connor Kuehl wrote: >>> Hi Paolo, >>> >>> Please consider this series[1] for inclusion into your next pull request. >>> >>> Just a note that this series has a

Re: [PATCH v2 5/6] migration/postcopy: Handle RAMBlocks with a RamDiscardManager on the destination

2021-07-29 Thread David Hildenbrand
On 29.07.21 21:20, Peter Xu wrote: On Thu, Jul 29, 2021 at 06:15:58PM +0200, David Hildenbrand wrote: On 29.07.21 17:52, Peter Xu wrote: On Thu, Jul 29, 2021 at 02:14:41PM +0200, David Hildenbrand wrote: On 24.07.21 00:10, Peter Xu wrote: On Fri, Jul 23, 2021 at 09:01:42PM +0200, David

[PATCH 1/2] virtio: add a way to disable a queue

2021-07-29 Thread Laurent Vivier
Add virtio_queue_disable()/virtio_queue_enable() to disable/enable a queue by setting vring.num to 0 (or num_default). This is needed to be able to disable a guest driver from the host side Signed-off-by: Laurent Vivier --- include/hw/virtio/virtio.h | 2 ++ hw/virtio/virtio.c | 10

Re: [PATCH v2 5/6] migration/postcopy: Handle RAMBlocks with a RamDiscardManager on the destination

2021-07-29 Thread Peter Xu
On Thu, Jul 29, 2021 at 06:15:58PM +0200, David Hildenbrand wrote: > On 29.07.21 17:52, Peter Xu wrote: > > On Thu, Jul 29, 2021 at 02:14:41PM +0200, David Hildenbrand wrote: > > > On 24.07.21 00:10, Peter Xu wrote: > > > > On Fri, Jul 23, 2021 at 09:01:42PM +0200, David Hildenbrand wrote: > > > >

[PATCH 2/2] virtio: failover: define the default device to use in case of error

2021-07-29 Thread Laurent Vivier
If the guest driver doesn't support the STANDBY feature, by default we keep the virtio-net device and don't hotplug the VFIO device, but in some cases, user can prefer to use the VFIO device rather than the virtio-net one. We can't unplug the virtio-net device (because on migration it is expected

[PATCH 0/2] virtio: failover: allow to keep the VFIO device rather than the virtio-net one

2021-07-29 Thread Laurent Vivier
With failover, when the guest virtio-net driver doesn't support the STANDBY feature, the primary device is not plugged and only the virtio-net device is kept. Doing like that we can migrate the machine and keep the network connection. But in some cases, when performance is more important than

Re: [PATCH-for-6.1? v2] target/nios2: Mark raise_exception() as noreturn

2021-07-29 Thread Richard Henderson
On 7/29/21 12:13 AM, Philippe Mathieu-Daudé wrote: Raised exceptions don't return, so mark the helper with noreturn. Fixes: 032c76bc6f9 ("nios2: Add architecture emulation support") Signed-off-by: Philippe Mathieu-Daudé --- Reviewed-by: Richard Henderson r~

Re: [PATCH for-6.2 03/43] target/arm: Implement do_unaligned_access for user-only

2021-07-29 Thread Richard Henderson
On 7/29/21 3:14 AM, Peter Maydell wrote: On Thu, 29 Jul 2021 at 01:47, Richard Henderson wrote: Cc: qemu-...@nongnu.org Signed-off-by: Richard Henderson --- linux-user/aarch64/cpu_loop.c | 4 linux-user/arm/cpu_loop.c | 43 +++ target/arm/cpu.c

Re: [PATCH for-6.2 05/43] target/microblaze: Implement do_unaligned_access for user-only

2021-07-29 Thread Edgar E. Iglesias
On Thu, Jul 29, 2021 at 08:00:50AM -1000, Richard Henderson wrote: > On 7/29/21 3:26 AM, Peter Maydell wrote: > > On Thu, 29 Jul 2021 at 01:54, Richard Henderson > > wrote: > > > > > > Cc: Edgar E. Iglesias > > > Signed-off-by: Richard Henderson > > > --- > > > target/microblaze/cpu.c | 2 +-

Re: [PATCH for-6.1? 23/43] accel/tcg: Remove double bswap for helper_atomic_sto_*_mmu

2021-07-29 Thread Richard Henderson
On 7/28/21 8:29 PM, Philippe Mathieu-Daudé wrote: On 7/29/21 2:46 AM, Richard Henderson wrote: This crept in as either a cut-and-paste error, or rebase error. Fixes: cfec388518d Signed-off-by: Richard Henderson --- accel/tcg/atomic_template.h | 1 - 1 file changed, 1 deletion(-) diff

Re: [PATCH for-6.2 16/43] target/xtensa: Implement do_unaligned_access for user-only

2021-07-29 Thread Richard Henderson
On 7/29/21 4:55 AM, Peter Maydell wrote: On Thu, 29 Jul 2021 at 02:03, Richard Henderson wrote: Cc: Max Filippov Signed-off-by: Richard Henderson --- target/xtensa/cpu.c| 2 +- target/xtensa/helper.c | 30 +++--- 2 files changed, 16 insertions(+), 16

Re: [PATCH for-6.2 15/43] target/sparc: Implement do_unaligned_access for user-only

2021-07-29 Thread Richard Henderson
On 7/28/21 11:40 PM, Philippe Mathieu-Daudé wrote: On 7/29/21 2:46 AM, Richard Henderson wrote: Cc: Mark Cave-Ayland Signed-off-by: Richard Henderson --- linux-user/sparc/cpu_loop.c | 11 +++ target/sparc/cpu.c | 2 +- target/sparc/ldst_helper.c | 2 -- 3 files

Re: [PATCH for-6.2 07/43] target/ppc: Set fault address in ppc_cpu_do_unaligned_access

2021-07-29 Thread Richard Henderson
On 7/29/21 3:44 AM, Peter Maydell wrote: On Thu, 29 Jul 2021 at 01:51, Richard Henderson wrote: We ought to have been recording the virtual address for reporting to the guest trap handler. Cc: qemu-...@nongnu.org Signed-off-by: Richard Henderson --- target/ppc/excp_helper.c | 2 ++ 1

Re: [PATCH for-6.2 05/43] target/microblaze: Implement do_unaligned_access for user-only

2021-07-29 Thread Richard Henderson
On 7/29/21 3:26 AM, Peter Maydell wrote: On Thu, 29 Jul 2021 at 01:54, Richard Henderson wrote: Cc: Edgar E. Iglesias Signed-off-by: Richard Henderson --- target/microblaze/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/microblaze/cpu.c

[PATCH for-6.2 10/10] MAINTAINERS: Add qom.rst to QOM section

2021-07-29 Thread Eduardo Habkost
Add qom.rst to the QOM section of MAINTAINERS. Signed-off-by: Eduardo Habkost --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 42ac45c3e50..dc3f04242eb 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2651,6 +2651,7 @@ M: Paolo Bonzini R:

[PATCH for-6.2 09/10] docs: qom: Remove OBJECT_CHECK macro examples

2021-07-29 Thread Eduardo Habkost
We shouldn't encourage people to keep defining typecast macros manually, when we have the OBJECT_DECLARE* macros. Remove the section showing how to define them, and replace with a section explaining how typecasting works. Signed-off-by: Eduardo Habkost --- docs/devel/qom.rst | 46

[PATCH for-6.2 08/10] docs: qom: Show actual typecast functions in examples

2021-07-29 Thread Eduardo Habkost
For clarity and to avoid encouraging people to copy the examples, show the actual typecast functions being defined by OBJECT_DECLARE* macros in the examples. Signed-off-by: Eduardo Habkost --- docs/devel/qom.rst | 24 1 file changed, 16 insertions(+), 8 deletions(-)

[PATCH for-6.2 07/10] docs: qom: Fix OBJECT_DECLARE_SIMPLE_TYPE documentation

2021-07-29 Thread Eduardo Habkost
The OBJECT_DECLARE_SIMPLE_TYPE documentation was inaccurate: it doesn't define a class struct or class type checking helpers. OBJECT_DECLARE_TYPE expansion looks very similar to the existing example, though. Rewrite that section to show both both OBJECT_DECLARE_SIMPLE_TYPE and

[PATCH for-6.2 05/10] docs: qom: Add subsection headings to declaration/definition macros section

2021-07-29 Thread Eduardo Habkost
Add two new subsection headings to make the separation between "declaration macros" and "definition macros" more visible. Signed-off-by: Eduardo Habkost --- docs/devel/qom.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/docs/devel/qom.rst b/docs/devel/qom.rst index

[PATCH for-6.2 06/10] docs: qom: Remove unnecessary class typedefs from example

2021-07-29 Thread Eduardo Habkost
When there's no specific class struct used for a QOM type, we normally don't define a typedef for it. Remove the typedef from the minimal example, as it is unnecessary. Signed-off-by: Eduardo Habkost --- docs/devel/qom.rst | 3 --- 1 file changed, 3 deletions(-) diff --git

[PATCH for-6.2 03/10] docs: qom: Fix autoptr expansion example

2021-07-29 Thread Eduardo Habkost
The wrong type name was being used. The autoptr cleanup function will be declared for the instance type, not the class type. Signed-off-by: Eduardo Habkost --- docs/devel/qom.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/devel/qom.rst b/docs/devel/qom.rst index

[PATCH for-6.2 01/10] docs: qom: Replace old GTK-Doc #symbol syntax with `symbol`

2021-07-29 Thread Eduardo Habkost
Replace leftover of GTK-Doc #name syntax with `name`, and use default-role:: any, so we can add references to other functions, types, and macros. There are 3 cases that required extra care: - #TypeInfo.class_init: kernel-doc doesn't generate c:member:: directives, so references to C struct

[PATCH for-6.2 02/10] docs: qom: Use Sphinx cross references more often

2021-07-29 Thread Eduardo Habkost
To make the document easier to navigate, use `reference` syntax more often when mentioning other types, functions, and macros. Signed-off-by: Eduardo Habkost --- docs/devel/qom.rst | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git

[PATCH for-6.2 04/10] docs: qom: Fix "API Reference" heading level

2021-07-29 Thread Eduardo Habkost
The API reference section was being rendered as a subsection of the "Standard type declaration and definition macros" subsection. Fix that. Signed-off-by: Eduardo Habkost --- docs/devel/qom.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/devel/qom.rst

[PATCH for-6.2 00/10] QOM documentation updates

2021-07-29 Thread Eduardo Habkost
This series includes a few fixes to the QOM documentation, and add some changes to avoid encouraging people from defining typecast macros manually. Eduardo Habkost (10): docs: qom: Replace old GTK-Doc #symbol syntax with `symbol` docs: qom: Use Sphinx cross references more often docs: qom:

Re: [PATCH for-6.2 04/43] target/hppa: Implement do_unaligned_access for user-only

2021-07-29 Thread Richard Henderson
On 7/29/21 3:15 AM, Peter Maydell wrote: On Thu, 29 Jul 2021 at 01:57, Richard Henderson wrote: Signed-off-by: Richard Henderson --- linux-user/hppa/cpu_loop.c | 2 +- target/hppa/cpu.c | 8 +--- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git

Re: [PATCH for-6.2 01/43] hw/core: Make do_unaligned_access available to user-only

2021-07-29 Thread Richard Henderson
On 7/28/21 8:19 PM, Philippe Mathieu-Daudé wrote: On 7/29/21 2:46 AM, Richard Henderson wrote: We shouldn't be ignoring SIGBUS for user-only. Move our existing TCGCPUOps hook out from CONFIG_SOFTMMU. Signed-off-by: Richard Henderson --- include/hw/core/tcg-cpu-ops.h | 14 +++--- 1

Re: [PULL 0/7] Misc patches for QEMU 6.1-rc2

2021-07-29 Thread Peter Maydell
On Thu, 29 Jul 2021 at 13:49, Paolo Bonzini wrote: > > The following changes since commit 69ea12b19a15ae006521cd5cc0f627f27f738746: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-misc-2021-07-27' > into staging (2021-07-28 13:32:12 +0100) > > are available in the Git repository at:

Re: [PULL 6/7] meson: fix meson 0.58 warning with libvhost-user subproject

2021-07-29 Thread Yonggang Luo
Relative symlink should work on Windows. Only symlink that points to non-exist file would file. On Thu, Jul 29, 2021 at 11:09 PM Peter Maydell wrote: > > On Thu, 29 Jul 2021 at 15:05, Thomas Huth wrote: > > > > On 29/07/2021 14.58, Peter Maydell wrote: > > > On Thu, 29 Jul 2021 at 13:56, Paolo

Re: modular tcg (was: Re: [PATCH v2 1/1] modules: Improve error message when module is not) found

2021-07-29 Thread Paolo Bonzini
On 29/07/21 11:14, Gerd Hoffmann wrote: The common functions could be added TCGCPUOps to allow them being called via CPUClass->tcg_ops->$name instead of a direct symbol reference. Not sure this is a good idea though. Experimental patch covering tcg_exec_realizefn + tcg_exec_unrealizefn below.

Re: modular tcg

2021-07-29 Thread Claudio Fontana
On 7/29/21 4:59 PM, Philippe Mathieu-Daudé wrote: > On 7/29/21 4:22 PM, Claudio Fontana wrote: >> On 7/29/21 1:34 PM, Philippe Mathieu-Daudé wrote: >>> On 7/29/21 12:44 PM, Claudio Fontana wrote: On 7/29/21 12:29 PM, Gerd Hoffmann wrote: > Hi, > >> And another comment: I think

Re: [PATCH v2] block/io_uring: resubmit when result is -EAGAIN

2021-07-29 Thread Stefan Hajnoczi
On Thu, Jul 29, 2021 at 11:10:29AM +0200, Fabian Ebner wrote: > Linux SCSI can throw spurious -EAGAIN in some corner cases in its > completion path, which will end up being the result in the completed > io_uring request. > > Resubmitting such requests should allow block jobs to complete, even >

Re: [PATCH v2 5/6] migration/postcopy: Handle RAMBlocks with a RamDiscardManager on the destination

2021-07-29 Thread David Hildenbrand
On 29.07.21 17:52, Peter Xu wrote: On Thu, Jul 29, 2021 at 02:14:41PM +0200, David Hildenbrand wrote: On 24.07.21 00:10, Peter Xu wrote: On Fri, Jul 23, 2021 at 09:01:42PM +0200, David Hildenbrand wrote: It can happen in corner cases and is valid: with the current virtio-mem spec, guests are

Re: [PATCH RFC 0/3] mirror: rework soft-cancelling READY mirror

2021-07-29 Thread Vladimir Sementsov-Ogievskiy
29.07.2021 16:47, Max Reitz wrote: On 29.07.21 13:35, Vladimir Sementsov-Ogievskiy wrote: 29.07.2021 13:38, Max Reitz wrote: On 29.07.21 12:02, Vladimir Sementsov-Ogievskiy wrote: 28.07.2021 10:00, Max Reitz wrote: On 27.07.21 18:47, Vladimir Sementsov-Ogievskiy wrote: Hi all! That's an

Re: [PATCH v2 0/6] migration/ram: Optimize for virtio-mem via RamDiscardManager

2021-07-29 Thread David Hildenbrand
On 29.07.21 18:12, Peter Xu wrote: On Thu, Jul 29, 2021 at 10:14:47AM +0200, David Hildenbrand wrote: The thing is I still think this extra operation during sync() can be ignored by simply clear dirty log during bitmap init, then.. why not? :) I guess clearing the dirty log (especially in

Re: [PATCH] MAINTAINERS: Added myself as a reviewer for the NVMe Block Driver

2021-07-29 Thread Stefan Hajnoczi
On Wed, Jul 28, 2021 at 08:33:40PM +0200, Philippe Mathieu-Daudé wrote: > I'm interested in following the activity around the NVMe bdrv. > > Signed-off-by: Philippe Mathieu-Daudé > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) Thanks, applied to my block tree:

[PULL for-6.1 0/3] Block patches

2021-07-29 Thread Stefan Hajnoczi
The following changes since commit 3521ade3510eb5cefb2e27a101667f25dad89935: Merge remote-tracking branch 'remotes/thuth-gitlab/tags/pull-request-2021-07-29' into staging (2021-07-29 13:17:20 +0100) are available in the Git repository at: https://gitlab.com/stefanha/qemu.git

[PULL for-6.1 1/3] MAINTAINERS: add Stefano Garzarella as io_uring reviewer

2021-07-29 Thread Stefan Hajnoczi
From: Stefano Garzarella I've been working with io_uring for a while so I'd like to help with reviews. Signed-off-by: Stefano Garzarella Message-Id: <20210728131515.131045-1-sgarz...@redhat.com> Signed-off-by: Stefan Hajnoczi --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git

[PULL for-6.1 2/3] block/io_uring: resubmit when result is -EAGAIN

2021-07-29 Thread Stefan Hajnoczi
From: Fabian Ebner Linux SCSI can throw spurious -EAGAIN in some corner cases in its completion path, which will end up being the result in the completed io_uring request. Resubmitting such requests should allow block jobs to complete, even if such spurious errors are encountered.

[PULL for-6.1 3/3] MAINTAINERS: Added myself as a reviewer for the NVMe Block Driver

2021-07-29 Thread Stefan Hajnoczi
From: Philippe Mathieu-Daudé I'm interested in following the activity around the NVMe bdrv. Signed-off-by: Philippe Mathieu-Daudé Message-id: 20210728183340.2018313-1-phi...@redhat.com Signed-off-by: Stefan Hajnoczi --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [PING][PING][PATCH v2] vhost: make SET_VRING_ADDR, SET_FEATURES send replies

2021-07-29 Thread Stefan Hajnoczi
On Thu, Jul 29, 2021 at 02:53:53PM +0200, Philippe Mathieu-Daudé wrote: > Cc more ppl. This needs to go through Michael Tsirkin's tree. Stefan > > On 7/29/21 12:56 PM, Denis Plotnikov wrote: > > > > On 23.07.2021 12:59, Denis Plotnikov wrote: > >> > >> ping! > >> > >> On 19.07.2021 17:21,

Re: [PATCH v2 0/6] migration/ram: Optimize for virtio-mem via RamDiscardManager

2021-07-29 Thread Peter Xu
On Thu, Jul 29, 2021 at 10:14:47AM +0200, David Hildenbrand wrote: > > > > > > The thing is I still think this extra operation during sync() can > > > > > > be ignored by > > > > > > simply clear dirty log during bitmap init, then.. why not? :) > > > > > > > > > > I guess clearing the dirty log

Re: aarch64 efi boot failures with qemu 6.0+

2021-07-29 Thread Michael S. Tsirkin
On Thu, Jul 29, 2021 at 09:42:52AM -0500, Bjorn Helgaas wrote: > On Thu, Jul 29, 2021 at 3:08 AM Philippe Mathieu-Daudé > wrote: > > > Michael, if describing the issue in the revert is too complex, could you > > include a link to this thread in the revert description? > > (Message-Id:

Re: [PATCH v2 5/6] migration/postcopy: Handle RAMBlocks with a RamDiscardManager on the destination

2021-07-29 Thread Peter Xu
On Thu, Jul 29, 2021 at 02:14:41PM +0200, David Hildenbrand wrote: > On 24.07.21 00:10, Peter Xu wrote: > > On Fri, Jul 23, 2021 at 09:01:42PM +0200, David Hildenbrand wrote: > > > It can happen in corner cases and is valid: with the current virtio-mem > > > spec, guests are allowed to read

Re: [PATCH] tests: Fix migration-test build failure for sparc

2021-07-29 Thread Peter Xu
On Thu, Jul 29, 2021 at 01:48:57AM +0200, Philippe Mathieu-Daudé wrote: > On 7/28/21 11:41 PM, Peter Xu wrote: > > Even if seems to exist for all archs on linux, however > > including > > it with __linux__ defined seems to be not working yet as it'll try to > > include > > asm/kvm.h and that

Re: [PULL 6/7] meson: fix meson 0.58 warning with libvhost-user subproject

2021-07-29 Thread Peter Maydell
On Thu, 29 Jul 2021 at 15:05, Thomas Huth wrote: > > On 29/07/2021 14.58, Peter Maydell wrote: > > On Thu, 29 Jul 2021 at 13:56, Paolo Bonzini wrote: > >> > >> From: Marc-André Lureau > >> > >> Meson now checks that subprojects do not access files from parent > >> project. While we all agree

Re: [PULL 0/9] Gitlab-CI improvements and some other fixes

2021-07-29 Thread Peter Maydell
On Thu, 29 Jul 2021 at 09:22, Thomas Huth wrote: > > Hi Peter! > > The following changes since commit 69ea12b19a15ae006521cd5cc0f627f27f738746: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-misc-2021-07-27' > into staging (2021-07-28 13:32:12 +0100) > > are available in the Git

Re: [PATCH for-6.2 17/43] accel/tcg: Report unaligned atomics for user-only

2021-07-29 Thread Peter Maydell
On Thu, 29 Jul 2021 at 02:09, Richard Henderson wrote: > > Use the newly exposed do_unaligned_access hook from atomic_mmu_lookup, > which has access to complete alignment info from the TCGMemOpIdx arg. > > Signed-off-by: Richard Henderson > --- > accel/tcg/user-exec.c | 23

Re: modular tcg

2021-07-29 Thread Philippe Mathieu-Daudé
On 7/29/21 4:22 PM, Claudio Fontana wrote: > On 7/29/21 1:34 PM, Philippe Mathieu-Daudé wrote: >> On 7/29/21 12:44 PM, Claudio Fontana wrote: >>> On 7/29/21 12:29 PM, Gerd Hoffmann wrote: Hi, > And another comment: I think we should have some progress on ARM with > the kvm/tcg

Re: [PATCH for-6.2 16/43] target/xtensa: Implement do_unaligned_access for user-only

2021-07-29 Thread Peter Maydell
On Thu, 29 Jul 2021 at 02:03, Richard Henderson wrote: > > Cc: Max Filippov > Signed-off-by: Richard Henderson > --- > target/xtensa/cpu.c| 2 +- > target/xtensa/helper.c | 30 +++--- > 2 files changed, 16 insertions(+), 16 deletions(-) The xtensa kernel has a

Re: [PATCH for-6.2 14/43] target/sparc: Set fault address in sparc_cpu_do_unaligned_access

2021-07-29 Thread Peter Maydell
On Thu, 29 Jul 2021 at 02:01, Richard Henderson wrote: > > We ought to have been recording the virtual address for reporting > to the guest trap handler. Mirror the SFSR FIXME from the sparc64 > version of get_physical_address_data. > > Cc: Mark Cave-Ayland > Signed-off-by: Richard Henderson >

Re: aarch64 efi boot failures with qemu 6.0+

2021-07-29 Thread Bjorn Helgaas
On Thu, Jul 29, 2021 at 3:08 AM Philippe Mathieu-Daudé wrote: > Michael, if describing the issue in the revert is too complex, could you > include a link to this thread in the revert description? > (Message-Id: <20210724185234.ga2265...@roeck-us.net> or >

Re: modular tcg

2021-07-29 Thread Claudio Fontana
On 7/29/21 1:34 PM, Philippe Mathieu-Daudé wrote: > On 7/29/21 12:44 PM, Claudio Fontana wrote: >> On 7/29/21 12:29 PM, Gerd Hoffmann wrote: >>> Hi, >>> And another comment: I think we should have some progress on ARM with the kvm/tcg split and with the KConfig of boards, before we

[PATCH 2/2] vl: stop recording -smp in QemuOpts

2021-07-29 Thread Paolo Bonzini
-readconfig is still recording SMP options in QemuOpts instead of using machine_opts_dict. This means that SMP options from -readconfig are ignored. Just stop using QemuOpts for -smp, making it return false for is_qemuopts_group. Configuration files will merge the values in machine_opts_dict

[PATCH 1/2] vl: introduce machine_merge_property

2021-07-29 Thread Paolo Bonzini
It will be used to parse smp-opts config groups from configuration files. The point to note is that it does not steal a reference from the caller. This is better because this function will be called from qemu_config_foreach's callback; qemu_config_foreach does not cede its reference to the qdict

[PATCH 0/2] vl: fix passing smp options via -readconfig

2021-07-29 Thread Paolo Bonzini
Even though [smp] does not work in config files, [smp-opts] does and lxd is using it. So, fix it. Paolo Bonzini (2): vl: introduce machine_merge_property vl: stop recording -smp in QemuOpts softmmu/vl.c | 47 +-- 1 file changed, 33 insertions(+),

Re: [PULL 6/7] meson: fix meson 0.58 warning with libvhost-user subproject

2021-07-29 Thread Thomas Huth
On 29/07/2021 14.58, Peter Maydell wrote: On Thu, 29 Jul 2021 at 13:56, Paolo Bonzini wrote: From: Marc-André Lureau Meson now checks that subprojects do not access files from parent project. While we all agree this is best practice, libvhost-user also want to share a few headers with QEMU,

Re: [PATCH for-6.2 00/43] Unaligned accesses for user-only

2021-07-29 Thread Claudio Fontana
On 7/29/21 8:14 AM, Philippe Mathieu-Daudé wrote: > On 7/29/21 2:46 AM, Richard Henderson wrote: >> This began with Peter wanting a cpu_ldst.h interface that can handle >> alignment info for Arm M-profile system mode, which will also compile >> for user-only without ifdefs. This is patch 32. >>

Re: [PATCH for-6.2 12/43] target/sh4: Implement do_unaligned_access for user-only

2021-07-29 Thread Peter Maydell
On Thu, 29 Jul 2021 at 02:01, Richard Henderson wrote: > > Cc: Yoshinori Sato > Signed-off-by: Richard Henderson > --- > linux-user/sh4/cpu_loop.c | 8 > target/sh4/cpu.c | 2 +- > target/sh4/op_helper.c| 3 --- > 3 files changed, 9 insertions(+), 4 deletions(-) > > diff

[PATCH] hyperv: Fix struct hv_message_header ordering

2021-07-29 Thread Siddharth Chandrasekaran
According to Hyper-V TLFS Version 6.0b, struct hv_message_header members should be defined in the order: message_type, _reserved, message_flags, payload_size but we have it defined in the order: message_type, payload_size, message_flags, _reserved that is, the payload_size and

Re: [PATCH RFC 0/3] mirror: rework soft-cancelling READY mirror

2021-07-29 Thread Max Reitz
On 29.07.21 13:35, Vladimir Sementsov-Ogievskiy wrote: 29.07.2021 13:38, Max Reitz wrote: On 29.07.21 12:02, Vladimir Sementsov-Ogievskiy wrote: 28.07.2021 10:00, Max Reitz wrote: On 27.07.21 18:47, Vladimir Sementsov-Ogievskiy wrote: Hi all! That's an alternative to (part of) Max's "[PATCH

Re: [PATCH for-6.2 07/43] target/ppc: Set fault address in ppc_cpu_do_unaligned_access

2021-07-29 Thread Peter Maydell
On Thu, 29 Jul 2021 at 01:51, Richard Henderson wrote: > > We ought to have been recording the virtual address for reporting > to the guest trap handler. > > Cc: qemu-...@nongnu.org > Signed-off-by: Richard Henderson > --- > target/ppc/excp_helper.c | 2 ++ > 1 file changed, 2 insertions(+) > >

Re: [PATCH for-6.2 05/43] target/microblaze: Implement do_unaligned_access for user-only

2021-07-29 Thread Peter Maydell
On Thu, 29 Jul 2021 at 01:54, Richard Henderson wrote: > > Cc: Edgar E. Iglesias > Signed-off-by: Richard Henderson > --- > target/microblaze/cpu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/microblaze/cpu.c b/target/microblaze/cpu.c > index

Re: [PATCH 00/16] Various error handling fixes and cleanups

2021-07-29 Thread Markus Armbruster
Markus Armbruster writes: > I doubt the fixes are 6.1 material at this late stage. If you > disagree, let me know. PATCH 16 has become commit 3e61a13af3. Remainder queued for 6.2; additional review is welcome all the same. Thanks, guys!

[PATCH] hw/acpi: use existing references to pci device struct within functions

2021-07-29 Thread Ani Sinha
There is no need to use fresh typecasts to get references to pci device structs when there is an existing reference to pci device struct. Use existing reference. Minor cleanup. Signed-off-by: Ani Sinha --- hw/acpi/pcihp.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Make and

Re: [PATCH for-6.2 04/43] target/hppa: Implement do_unaligned_access for user-only

2021-07-29 Thread Peter Maydell
On Thu, 29 Jul 2021 at 01:57, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > linux-user/hppa/cpu_loop.c | 2 +- > target/hppa/cpu.c | 8 +--- > 2 files changed, 6 insertions(+), 4 deletions(-) > > diff --git a/linux-user/hppa/cpu_loop.c

Re: [PATCH for-6.2 03/43] target/arm: Implement do_unaligned_access for user-only

2021-07-29 Thread Peter Maydell
On Thu, 29 Jul 2021 at 01:47, Richard Henderson wrote: > > Cc: qemu-...@nongnu.org > Signed-off-by: Richard Henderson > --- > linux-user/aarch64/cpu_loop.c | 4 > linux-user/arm/cpu_loop.c | 43 +++ > target/arm/cpu.c | 2 +- >

Re: [PATCH] hw/i386/ich9: add comment explaining an argument to acpi_pcihp_reset call

2021-07-29 Thread Ani Sinha
ping ... On Tue, 27 Jul 2021, Ani Sinha wrote: > acpi_pcihp_reset() call from ich9/pm_reset() passes an unconditional truth > value > as the second argument. Added a commnet here to explain the reason why the > argument is being passed unconditionally. > > Signed-off-by: Ani Sinha > --- >

Re: [PATCH for-6.2 02/43] target/alpha: Implement do_unaligned_access for user-only

2021-07-29 Thread Peter Maydell
On Thu, 29 Jul 2021 at 01:50, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/alpha/cpu.c| 2 +- > target/alpha/mem_helper.c | 8 +++- > 2 files changed, 4 insertions(+), 6 deletions(-) > > diff --git a/target/alpha/cpu.c b/target/alpha/cpu.c > index

Re: [PATCH for-6.2 01/43] hw/core: Make do_unaligned_access available to user-only

2021-07-29 Thread Peter Maydell
On Thu, 29 Jul 2021 at 01:50, Richard Henderson wrote: > > We shouldn't be ignoring SIGBUS for user-only. > Move our existing TCGCPUOps hook out from CONFIG_SOFTMMU. > > Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell thanks -- PMM

[PULL 7/7] docs: Fold usb2.txt passthrough information into usb.rst

2021-07-29 Thread Gerd Hoffmann
From: Peter Maydell Fold the usb2.txt information on device passthrough into usb.rst; since this is the last part of the .txt file we can delete it now. Signed-off-by: Peter Maydell Message-Id: <20210728141457.14825-5-peter.mayd...@linaro.org> Signed-off-by: Gerd Hoffmann --- docs/usb2.txt

Re: [PULL 6/7] meson: fix meson 0.58 warning with libvhost-user subproject

2021-07-29 Thread Peter Maydell
On Thu, 29 Jul 2021 at 13:56, Paolo Bonzini wrote: > > From: Marc-André Lureau > > Meson now checks that subprojects do not access files from parent > project. While we all agree this is best practice, libvhost-user also > want to share a few headers with QEMU, and libvhost-user isn't really a >

[PULL 4/7] docs: Incorporate information in usb-storage.txt into rST manual

2021-07-29 Thread Gerd Hoffmann
From: Peter Maydell We already have a section on USB in the rST manual; fold the information in docs/usb-storage.txt into it. We add 'format=raw' to the various -drive options in the code examples, because QEMU will print warnings these days if you omit it. Signed-off-by: Peter Maydell

[PULL 0/7] Usb 20210729 patches

2021-07-29 Thread Gerd Hoffmann
The following changes since commit f2da205cb4142259d9bc6b9d4596ebbe2426fe49: Update version for v6.1.0-rc1 release (2021-07-27 18:07:52 +0100) are available in the Git repository at: git://git.kraxel.org/qemu tags/usb-20210729-pull-request for you to fetch changes up

Re: [PATCH v2] hw/net/can: sja1000 fix buff2frame_bas and buff2frame_pel when dlc is out of std CAN 8 bytes

2021-07-29 Thread Philippe Mathieu-Daudé
"hw/net/can: sja1000 fix buff2frame* when dlc is out of std CAN 8 bytes" On 7/29/21 2:33 PM, Pavel Pisa wrote: > Problem reported by openEuler fuzz-sig group. > > The buff2frame_bas function (hw\net\can\can_sja1000.c) > infoleak(qemu5.x~qemu6.x) or stack-overflow(qemu 4.x). Cc:

[PULL 5/7] docs: Fold usb2.txt USB controller information into usb.rst

2021-07-29 Thread Gerd Hoffmann
From: Peter Maydell Fold the information in docs/usb2.txt about the different kinds of supported USB controller into the main rST manual. Signed-off-by: Peter Maydell Message-Id: <20210728141457.14825-3-peter.mayd...@linaro.org> Signed-off-by: Gerd Hoffmann --- docs/usb2.txt |

[PULL 6/7] meson: fix meson 0.58 warning with libvhost-user subproject

2021-07-29 Thread Paolo Bonzini
From: Marc-André Lureau Meson now checks that subprojects do not access files from parent project. While we all agree this is best practice, libvhost-user also want to share a few headers with QEMU, and libvhost-user isn't really a standalone project at this point (although this is making the

Re: [PING][PING][PATCH v2] vhost: make SET_VRING_ADDR, SET_FEATURES send replies

2021-07-29 Thread Philippe Mathieu-Daudé
Cc more ppl. On 7/29/21 12:56 PM, Denis Plotnikov wrote: > > On 23.07.2021 12:59, Denis Plotnikov wrote: >> >> ping! >> >> On 19.07.2021 17:21, Denis Plotnikov wrote: >>> On vhost-user-blk migration, qemu normally sends a number of commands >>> to enable logging if

[PULL 2/7] ci: add libusb for windows builds

2021-07-29 Thread Gerd Hoffmann
Add CI coverage for usb passthrough on windows. Signed-off-by: Gerd Hoffmann Reviewed-by: Willian Rampazzo Message-Id: <20210623085249.1151901-3-kra...@redhat.com> Signed-off-by: Gerd Hoffmann --- tests/docker/dockerfiles/fedora-win32-cross.docker | 1 +

[PULL 3/7] usbredir: fix free call

2021-07-29 Thread Gerd Hoffmann
data might point into the middle of a larger buffer, there is a separate free_on_destroy pointer passed into bufp_alloc() to handle that. It is only used in the normal workflow though, not when dropping packets due to the queue being full. Fix that. Resolves:

  1   2   3   >