Re: [RFC PATCH v0 1/2] spapr: Add H_REG_SNS hcall

2021-08-08 Thread David Gibson
On Thu, Aug 05, 2021 at 01:02:27PM +0530, Bharata B Rao wrote: > Add support for H_REG_SNS hcall so that asynchronous page > fault mechanism can be supported on PowerKVM guests. > > This hcall essentially issues KVM_PPC_SET_SNS to let the > host map and pin the memory containing the Subvention >

Re: [PATCH for-6.2 v6 3/7] spapr_drc.c: do not error_report() when drc->dev->id == NULL

2021-08-08 Thread David Gibson
On Sat, Aug 07, 2021 at 03:41:52PM +0200, Markus Armbruster wrote: > Daniel Henrique Barboza writes: > > > The error_report() call in drc_unisolate_logical() is not considering > > that drc->dev->id can be NULL, and the underlying functions error_report() > > calls to do its job (vprintf(),

Re: [PATCH for-6.2 v6 7/7] memory_hotplug.c: send DEVICE_UNPLUG_ERROR in acpi_memory_hotplug_write()

2021-08-08 Thread David Gibson
On Sat, Aug 07, 2021 at 04:09:40PM +0200, Markus Armbruster wrote: > Daniel Henrique Barboza writes: > > > MEM_UNPLUG_ERROR is deprecated since the introduction of > > DEVICE_UNPLUG_ERROR. Keep emitting both while the deprecation of > > MEM_UNPLUG_ERROR is pending. > > > > CC: Michael S. Tsirkin

Re: [PATCH 0/7] Add vmnet.framework based network backend

2021-08-08 Thread Jason Wang
在 2021/8/7 上午3:03, Vladislav Yaroshchuk 写道: ping https://patchew.org/QEMU/20210617143246.55336-1-yaroshchuk2...@gmail.com/ Will review this week. Thanks чт, 17 июн. 2021 г. в 17:33, Vladislav Yaroshchuk

Re: [PATCH v3] net/macos: implement vmnet-based netdev

2021-08-08 Thread Jason Wang
在 2021/8/7 下午8:24, Markus Armbruster 写道: Jason, did this fall through the cracks? Kind of, will review this week. 6.2 material though. Thanks My review is for the QAPI schema only. Akihiko Odaki writes: From: Phillip Tennen This patch implements a new netdev device, reachable

Re: [PATCH 1/2] virtio: add a way to disable a queue

2021-08-08 Thread Jason Wang
在 2021/8/6 下午3:27, Laurent Vivier 写道: On 06/08/2021 08:25, Jason Wang wrote: 在 2021/8/2 下午4:42, Laurent Vivier 写道: On 02/08/2021 06:50, Jason Wang wrote: 在 2021/7/30 上午3:19, Laurent Vivier 写道: Add virtio_queue_disable()/virtio_queue_enable() to disable/enable a queue by setting vring.num

Re: [RFC PATCH 03/13] target/riscv: Support UXL32 on 64-bit cpu for load/store

2021-08-08 Thread LIU Zhiwei
On 2021/8/6 上午3:08, Richard Henderson wrote: On 8/4/21 4:53 PM, LIU Zhiwei wrote: Get the LSB 32 bits and zero-extend as the base address. Signed-off-by: LIU Zhiwei ---   target/riscv/insn_trans/trans_rvi.c.inc | 4 ++--   1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [RFC PATCH 02/13] target/riscv: Support UXL32 for branch instructions

2021-08-08 Thread LIU Zhiwei
On 2021/8/6 上午3:06, Richard Henderson wrote: On 8/4/21 4:53 PM, LIU Zhiwei wrote: +static TCGv gpr_src_u(DisasContext *ctx, int reg_num) +{ +    if (reg_num == 0) { +    return ctx->zero; +    } +    if (ctx->uxl32) { +    tcg_gen_ext32u_tl(cpu_gpr[reg_num], cpu_gpr[reg_num]); +    }

Re: [RFC PATCH 00/13] Support UXL field in mstatus

2021-08-08 Thread LIU Zhiwei
On 2021/8/6 下午6:05, Alistair Francis wrote: On Thu, Aug 5, 2021 at 5:15 PM LIU Zhiwei wrote: On 2021/8/5 下午2:01, Alistair Francis wrote: On Thu, Aug 5, 2021 at 12:55 PM LIU Zhiwei wrote: This patch set implements UXL field in mstatus register. Programmer can change UXLEN by writting to

Re: [PATCH] target/riscv: Correct a comment in riscv_csrrw()

2021-08-08 Thread Alistair Francis
On Sun, Aug 8, 2021 at 12:10 AM Bin Meng wrote: > > When privilege check fails, RISCV_EXCP_ILLEGAL_INST is returned, > not -1 (RISCV_EXCP_NONE). > > Signed-off-by: Bin Meng Thanks! Applied to riscv-to-apply.next Alistair > --- > > target/riscv/csr.c | 2 +- > 1 file changed, 1 insertion(+),

Re: [PATCH] hw/riscv: virt: Move flash node to root

2021-08-08 Thread Alistair Francis
On Sat, Aug 7, 2021 at 1:57 PM Bin Meng wrote: > > The flash is not inside the SoC, so it's inappropriate to put it > under the /soc node. Move it to root instead. > > Signed-off-by: Bin Meng Thanks! Applied to riscv-to-apply.next Alistair > --- > > hw/riscv/virt.c | 2 +- > 1 file changed,

Re: [PATCH for 6.2 23/49] bsd-user: pull in target_arch_thread.h update target_arch_elf.h

2021-08-08 Thread Warner Losh
On Sun, Aug 8, 2021 at 3:43 PM Warner Losh wrote: > > > On Sun, Aug 8, 2021 at 12:24 AM Richard Henderson < > richard.hender...@linaro.org> wrote: > >> On 8/7/21 11:42 AM, Warner Losh wrote: >> > +++ b/bsd-user/x86_64/target_arch_elf.h >> > @@ -19,48 +19,14 @@ >> > #ifndef_TARGET_ARCH_ELF_H_

Re: [PATCH for 6.2 23/49] bsd-user: pull in target_arch_thread.h update target_arch_elf.h

2021-08-08 Thread Warner Losh
On Sun, Aug 8, 2021 at 12:24 AM Richard Henderson < richard.hender...@linaro.org> wrote: > On 8/7/21 11:42 AM, Warner Losh wrote: > > +++ b/bsd-user/x86_64/target_arch_elf.h > > @@ -19,48 +19,14 @@ > > #ifndef_TARGET_ARCH_ELF_H_ > > #define_TARGET_ARCH_ELF_H_ > > > > -#define ELF_PLATFORM

[PATCH] hw: arm: aspeed: Enable eth0 interface for aspeed-ast2600-evb

2021-08-08 Thread Guenter Roeck
Commit 7582591ae7 ("aspeed: Support AST2600A1 silicon revision") switched the silicon revision for AST2600 to revision A1. On revision A1, the first Ethernet interface is operational. Enable it. Signed-off-by: Guenter Roeck --- hw/arm/aspeed.c | 3 ++- 1 file changed, 2 insertions(+), 1

Re: [PATCH for 6.2 22/49] bsd-user: Move per-cpu code into target_arch_cpu.h

2021-08-08 Thread Warner Losh
On Sun, Aug 8, 2021 at 12:16 AM Richard Henderson < richard.hender...@linaro.org> wrote: > On 8/7/21 8:03 PM, Warner Losh wrote: > > > > > > On Sat, Aug 7, 2021 at 11:35 PM Richard Henderson < > richard.hender...@linaro.org > > > wrote: > > > > On 8/7/21

[PATCH-for-6.2 v3 7/7] target/mips: Convert Vr54xx MSA* opcodes to decodetree

2021-08-08 Thread Philippe Mathieu-Daudé
Convert the following Integer Multiply-Accumulate opcodes: * MSAC Multiply, negate, accumulate, and move LO * MSACHI Multiply, negate, accumulate, and move HI * MSACHIU Unsigned multiply, negate, accumulate, and move HI * MSACUUnsigned multiply, negate, accumulate,

[PATCH-for-6.2 v3 6/7] target/mips: Convert Vr54xx MUL* opcodes to decodetree

2021-08-08 Thread Philippe Mathieu-Daudé
Convert the following Integer Multiply-Accumulate opcodes: * MULHIMultiply and move HI * MULHIU Unsigned multiply and move HI * MULS Multiply, negate, and move LO * MULSHI Multiply, negate, and move HI * MULSHIU Unsigned multiply, negate, and move HI * MULSU

[PATCH-for-6.2 v3 3/7] target/mips: Extract NEC Vr54xx helpers to vr54xx_helper.c

2021-08-08 Thread Philippe Mathieu-Daudé
Extract NEC Vr54xx helpers from op_helper.c to a new file: 'vr54xx_helper.c'. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20201120210844.2625602-14-f4...@amsat.org> --- target/mips/tcg/op_helper.c | 118 --

[PATCH-for-6.2 v3 5/7] target/mips: Convert Vr54xx MACC* opcodes to decodetree

2021-08-08 Thread Philippe Mathieu-Daudé
Convert the following Integer Multiply-Accumulate opcodes: * MACC Multiply, accumulate, and move LO * MACCHI Multiply, accumulate, and move HI * MACCHIU Unsigned multiply, accumulate, and move HI * MACCUUnsigned multiply, accumulate, and move LO Since all opcodes

[PATCH-for-6.2 v3 2/7] target/mips: Extract NEC Vr54xx helper definitions

2021-08-08 Thread Philippe Mathieu-Daudé
Extract the NEC Vr54xx helper definitions to 'vendor-vr54xx_helper.h'. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20201120210844.2625602-15-f4...@amsat.org> --- target/mips/helper.h| 18 +++---

[PATCH-for-6.2 v3 4/7] target/mips: Introduce decodetree structure for NEC Vr54xx extension

2021-08-08 Thread Philippe Mathieu-Daudé
The decoder is called but doesn't decode anything. This will ease reviewing the next commit. Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20210801235926.3178085-3-f4...@amsat.org> Reviewed-by: Richard Henderson --- target/mips/tcg/translate.h| 1 + target/mips/tcg/vr54xx.decode

[PATCH-for-6.2 v3 1/7] target/mips: Introduce generic TRANS() macro for decodetree helpers

2021-08-08 Thread Philippe Mathieu-Daudé
Plain copy/paste of the TRANS() macro introduced in the PPC commit f2aabda8ac9 ("target/ppc: Move D/DS/X-form integer loads to decodetree") to the MIPS target. Suggested-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- target/mips/tcg/translate.h | 8 1 file changed, 8

[PATCH-for-6.2 v3 0/7] target/mips: Convert NEC Vr54xx to decodetree

2021-08-08 Thread Philippe Mathieu-Daudé
Missing review: #1 Trivial conversion, few more lines moved out of the huge translate.c. Since v2: - Move TRANS() to translate.h (rth) Since v1: - Use TRANS() macro from ppc/translate.c, per rth's comment: https://www.mail-archive.com/qemu-devel@nongnu.org/msg827660.html Philippe

Re: [PATCH for 6.2 12/49] bsd-user: implement path searching

2021-08-08 Thread Warner Losh
On Sat, Aug 7, 2021 at 11:49 PM Kyle Evans wrote: > On Sat, Aug 7, 2021 at 10:11 PM Richard Henderson > wrote: > > > > On 8/7/21 11:42 AM, Warner Losh wrote: > > > +path = g_strdup(p); > > > +if (path == NULL) { > > > > Only returns null when the input is null, which you've

Re: [PATCH for 6.2 20/49] bsd-user: save the path the qemu emulator

2021-08-08 Thread Warner Losh
On Sat, Aug 7, 2021 at 11:24 PM Richard Henderson < richard.hender...@linaro.org> wrote: > On 8/7/21 11:42 AM, Warner Losh wrote: > > Save the path to the qemu emulator. This will be used later when we have > > a more complete implementation of exec. > > > > Signed-off-by: Stacey Son > >

[PATCH-for-6.2 2/2] target/mips/mxu: Use tcg_constant_i32()

2021-08-08 Thread Philippe Mathieu-Daudé
Replace uses of tcg_const_i32() with the allocate and free close together. Signed-off-by: Philippe Mathieu-Daudé --- target/mips/tcg/mxu_translate.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/target/mips/tcg/mxu_translate.c b/target/mips/tcg/mxu_translate.c index

[PATCH-for-6.2 1/2] target/mips/tx79: Use tcg_constant_tl()

2021-08-08 Thread Philippe Mathieu-Daudé
Replace uses of tcg_const_tl() with the allocate and free close together. Signed-off-by: Philippe Mathieu-Daudé --- target/mips/tcg/tx79_translate.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/target/mips/tcg/tx79_translate.c b/target/mips/tcg/tx79_translate.c

[PATCH-for-6.2 0/2] target/mips: Use tcg_constant_* in TX79 & MXU

2021-08-08 Thread Philippe Mathieu-Daudé
Philippe Mathieu-Daudé (2): target/mips/tx79: Use tcg_constant_tl() target/mips/mxu: Use tcg_constant_i32() target/mips/tcg/mxu_translate.c | 6 ++ target/mips/tcg/tx79_translate.c | 6 ++ 2 files changed, 4 insertions(+), 8 deletions(-) -- 2.31.1

Re: [PATCH for 6.2 23/49] bsd-user: pull in target_arch_thread.h update target_arch_elf.h

2021-08-08 Thread Richard Henderson
On 8/7/21 11:42 AM, Warner Losh wrote: +++ b/bsd-user/x86_64/target_arch_elf.h @@ -19,48 +19,14 @@ #ifndef_TARGET_ARCH_ELF_H_ #define_TARGET_ARCH_ELF_H_ -#define ELF_PLATFORM get_elf_platform() - -static const char *get_elf_platform(void) -{ -static char elf_platform[] = "i386"; -

Re: [PATCH for 6.2 22/49] bsd-user: Move per-cpu code into target_arch_cpu.h

2021-08-08 Thread Richard Henderson
On 8/7/21 8:03 PM, Warner Losh wrote: On Sat, Aug 7, 2021 at 11:35 PM Richard Henderson > wrote: On 8/7/21 11:42 AM, Warner Losh wrote: > diff --git a/bsd-user/i386/target_arch_cpu.c b/bsd-user/i386/target_arch_cpu.c > index

Re: [PATCH for 6.2 22/49] bsd-user: Move per-cpu code into target_arch_cpu.h

2021-08-08 Thread Warner Losh
On Sat, Aug 7, 2021 at 11:35 PM Richard Henderson < richard.hender...@linaro.org> wrote: > On 8/7/21 11:42 AM, Warner Losh wrote: > > diff --git a/bsd-user/i386/target_arch_cpu.c > b/bsd-user/i386/target_arch_cpu.c > > index 7f2f755a11..71998e5ba5 100644 > > --- a/bsd-user/i386/target_arch_cpu.c