Re: [RFC PATCH 02/13] target/riscv: Support UXL32 for branch instructions

2021-08-11 Thread LIU Zhiwei
On 2021/8/12 下午12:42, Richard Henderson wrote: On 8/11/21 12:40 PM, LIU Zhiwei wrote: If the software doesn't use the high part, who cares the really value in high part? Do you know the benefit?  Thanks again. I do not. I simply presume that they already have the hardware, in the form of

Re: [PATCH 12/19] target/ppc/pmu_book3s_helper.c: enable PMC1 counter negative EBB

2021-08-11 Thread Richard Henderson
On 8/11/21 6:45 PM, Richard Henderson wrote: On 8/11/21 5:39 PM, David Gibson wrote: I mean, nothing is stopping us from calculating cycles using time, but in the end we would do the same thing we're already doing today. Oh.. ok.  I had assumed that icount worked by instrumenting the generate

Re: [PATCH 12/19] target/ppc/pmu_book3s_helper.c: enable PMC1 counter negative EBB

2021-08-11 Thread Richard Henderson
On 8/11/21 5:39 PM, David Gibson wrote: I mean, nothing is stopping us from calculating cycles using time, but in the end we would do the same thing we're already doing today. Oh.. ok. I had assumed that icount worked by instrumenting the generate TCG code to actually count instructions,

Re: [RFC PATCH 02/13] target/riscv: Support UXL32 for branch instructions

2021-08-11 Thread Richard Henderson
On 8/11/21 12:40 PM, LIU Zhiwei wrote: If the software doesn't use the high part, who cares the really value in high part? Do you know the benefit?  Thanks again. I do not. I simply presume that they already have the hardware, in the form of the addw instruction, etc. The mistake, I think,

Re: [PATCH 12/19] target/ppc/pmu_book3s_helper.c: enable PMC1 counter negative EBB

2021-08-11 Thread David Gibson
On Wed, Aug 11, 2021 at 08:18:29AM -0300, Daniel Henrique Barboza wrote: > > > On 8/11/21 12:40 AM, David Gibson wrote: > > On Tue, Aug 10, 2021 at 05:26:09PM -0300, Daniel Henrique Barboza wrote: > > > > > > > > > On 8/10/21 1:01 AM, David Gibson wrote: > > > > On Mon, Aug 09, 2021 at

[PATCH] hw/arm/Kconfig: no need to enable ACPI_MEMORY_HOTPLUG explicitly

2021-08-11 Thread Ani Sinha
ACPI_MEMORY_HOTPLUG is implicitly turned on when ACPI_HW_REDUCED is selected. ACPI_HW_REDUCED is already enabled. No need to turn on ACPI_MEMORY_HOTPLUG explicitly. This is a minor cleanup. Signed-off-by: Ani Sinha --- hw/arm/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH] hw/virtio: Fix leak of host-notifier memory-region

2021-08-11 Thread Yajun Wu via
If call virtio_queue_set_host_notifier_mr fails, should free host-notifier memory-region. Signed-off-by: Yajun Wu --- hw/virtio/vhost-user.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c index aec6cc1..3ae5297 100644 ---

Re: [PATCH 06/19] target/ppc/pmu_book3s_helper: enable PMC1-PMC4 events

2021-08-11 Thread David Gibson
On Tue, Aug 10, 2021 at 08:08:04PM -0300, Daniel Henrique Barboza wrote: > > > On 8/10/21 12:03 PM, Daniel Henrique Barboza wrote: > > > > > > On 8/10/21 12:42 AM, David Gibson wrote: > > > On Mon, Aug 09, 2021 at 10:10:44AM -0300, Daniel Henrique Barboza wrote: > > > > So far the PMU logic

Re: [PATCH 15/19] target/ppc/pmu_book3s_helper: enable counter negative for all PMCs

2021-08-11 Thread David Gibson
On Tue, Aug 10, 2021 at 06:02:41PM -0300, Daniel Henrique Barboza wrote: > > > On 8/10/21 1:11 AM, David Gibson wrote: > > On Mon, Aug 09, 2021 at 10:10:53AM -0300, Daniel Henrique Barboza wrote: > > > All performance monitor counters can trigger a counter negative > > > condition if the proper

Re: [PATCH v2] target/riscv: Don't wrongly override isa version

2021-08-11 Thread Bin Meng
On Wed, Aug 11, 2021 at 10:46 PM LIU Zhiwei wrote: > > For some cpu, the isa version has already been set in cpu init function. > Thus only override the isa version when isa version is not set, or > users set different isa version explicitly by cpu parameters. > > Signed-off-by: LIU Zhiwei > ---

Re: [PATCH] tests/acceptance: Test powernv machines

2021-08-11 Thread David Gibson
On Wed, Aug 11, 2021 at 11:07:31AM +0200, Thomas Huth wrote: > On 10/08/2021 11.09, Cédric Le Goater wrote: > > On 8/10/21 10:36 AM, Joel Stanley wrote: > > > On Tue, 10 Aug 2021 at 08:34, Cédric Le Goater wrote: > > > > > > > > Fetch the OpenPOWER images to boot the powernv8 and powernv9

Re: [RFC PATCH v0 1/2] spapr: Add H_REG_SNS hcall

2021-08-11 Thread David Gibson
On Wed, Aug 11, 2021 at 02:56:13PM +0530, Bharata B Rao wrote: > On Mon, Aug 09, 2021 at 01:49:54PM +1000, David Gibson wrote: > > On Thu, Aug 05, 2021 at 01:02:27PM +0530, Bharata B Rao wrote: [snip] > > > diff --git a/linux-headers/asm-powerpc/kvm.h > > > b/linux-headers/asm-powerpc/kvm.h > > >

Using loadvm with snapshot

2021-08-11 Thread Gabriel Southern
Hi, Are there plans to support using -loadvm with -snapshot? I saw some past discussion on mailing list including bug that was closed earlier this year but no recent activity: https://lore.kernel.org/qemu-devel/162424905685.11837.7303570061857383641.mal...@loganberry.canonical.com/ Testing

Re: [PATCH 06/19] target/ppc/pmu_book3s_helper: enable PMC1-PMC4 events

2021-08-11 Thread Daniel Henrique Barboza
On 8/10/21 8:08 PM, Daniel Henrique Barboza wrote: On 8/10/21 12:03 PM, Daniel Henrique Barboza wrote: On 8/10/21 12:42 AM, David Gibson wrote: On Mon, Aug 09, 2021 at 10:10:44AM -0300, Daniel Henrique Barboza wrote: So far the PMU logic was using PMC5 for instruction counting (linux

Re: [RFC PATCH 02/13] target/riscv: Support UXL32 for branch instructions

2021-08-11 Thread LIU Zhiwei
On 2021/8/12 上午1:56, Richard Henderson wrote: On 8/11/21 4:57 AM, LIU Zhiwei wrote: I  still don't know why the value written sign-extended.  If that's the the rule of final specification, I will try to obey it although our Linux will not depend on the high part. The text that I'm looking

[PATCH] accel/tcg: remove redundant TCG_KICK_PERIOD define

2021-08-11 Thread Luc Michel
The TCG_KICK_PERIOD macro is already defined in tcg-accel-ops-rr.h. Remove it from tcg-accel-ops-rr.c. Signed-off-by: Luc Michel --- accel/tcg/tcg-accel-ops-rr.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/accel/tcg/tcg-accel-ops-rr.c b/accel/tcg/tcg-accel-ops-rr.c index

Re: [PATCH] target/i386: Remove split lock detect in Snowridge CPU model

2021-08-11 Thread Eduardo Habkost
On Wed, Jun 30, 2021 at 09:20:53AM +0800, Chenyi Qiang wrote: > At present, there's no mechanism intelligent enough to virtualize split > lock detection correctly. Remove it in Snowridge CPU model to avoid the > feature exposure. > > Signed-off-by: Chenyi Qiang Sorry I have missed this before

Re: [PATCH] accel/tcg: remove redundant TCG_KICK_PERIOD define

2021-08-11 Thread Richard Henderson
On 8/11/21 4:12 AM, Luc Michel wrote: The TCG_KICK_PERIOD macro is already defined in tcg-accel-ops-rr.h. Remove it from tcg-accel-ops-rr.c. Signed-off-by: Luc Michel --- accel/tcg/tcg-accel-ops-rr.c | 2 -- 1 file changed, 2 deletions(-) Reviewed-by: Richard Henderson r~

Re: [RFC PATCH 02/13] target/riscv: Support UXL32 for branch instructions

2021-08-11 Thread Richard Henderson
On 8/11/21 4:57 AM, LIU Zhiwei wrote: I  still don't know why the value written sign-extended.  If that's the the rule of final specification, I will try to obey it although our Linux will not depend on the high part. The text that I'm looking at is

Re: [RFC PATCH] vhost-vdpa: Do not send empty IOTLB update batches

2021-08-11 Thread Eugenio Perez Martin
On Thu, Aug 5, 2021 at 9:10 AM Jason Wang wrote: > > > 在 2021/8/5 下午3:04, Eugenio Perez Martin 写道: > > On Thu, Aug 5, 2021 at 8:16 AM Jason Wang wrote: > >> On Wed, Aug 4, 2021 at 10:44 PM Eugenio Pérez wrote: > >>> With the introduction of the batch hinting, meaningless batches can be > >>>

[PATCH v2] vhost-vdpa: Do not send empty IOTLB update batches

2021-08-11 Thread Eugenio Pérez
With the introduction of the batch hinting, meaningless batches can be created with no IOTLB updates if the memory region was skipped by vhost_vdpa_listener_skipped_section. This is the case of host notifiers memory regions, device un/realize, and others. This causes the vdpa device to receive dma

Re: [PATCH v3] hw/acpi: add an assertion check for non-null return from acpi_get_i386_pci_host

2021-08-11 Thread Ani Sinha
On Fri, 6 Aug 2021, Philippe Mathieu-Daudé wrote: > On 8/6/21 12:52 PM, Ani Sinha wrote: > > On Fri, 6 Aug 2021, Igor Mammedov wrote: > >> On Thu, 5 Aug 2021 19:42:35 +0530 (IST) > >> Ani Sinha wrote: > >>> On Thu, 5 Aug 2021, Ani Sinha wrote: > On Thu, 5 Aug 2021, Ani Sinha wrote: >

Re: [RFC PATCH 02/13] target/riscv: Support UXL32 for branch instructions

2021-08-11 Thread LIU Zhiwei
On 2021/8/10 上午3:34, Richard Henderson wrote: On 8/8/21 3:45 PM, LIU Zhiwei wrote: On 2021/8/6 上午3:06, Richard Henderson wrote: On 8/4/21 4:53 PM, LIU Zhiwei wrote: +static TCGv gpr_src_u(DisasContext *ctx, int reg_num) +{ +    if (reg_num == 0) { +    return ctx->zero; +    } +    if

Re: [PATCH] tests/acceptance: Test powernv machines

2021-08-11 Thread Cédric Le Goater
On 8/11/21 11:07 AM, Thomas Huth wrote: > On 10/08/2021 11.09, Cédric Le Goater wrote: >> On 8/10/21 10:36 AM, Joel Stanley wrote: >>> On Tue, 10 Aug 2021 at 08:34, Cédric Le Goater wrote: Fetch the OpenPOWER images to boot the powernv8 and powernv9 machines with a simple PCI

[PATCH v2] target/riscv: Don't wrongly override isa version

2021-08-11 Thread LIU Zhiwei
For some cpu, the isa version has already been set in cpu init function. Thus only override the isa version when isa version is not set, or users set different isa version explicitly by cpu parameters. Signed-off-by: LIU Zhiwei --- target/riscv/cpu.c | 14 -- 1 file changed, 8

Re: [PATCH] target/riscv: Don't wrongly overide isa version

2021-08-11 Thread Bin Meng
On Wed, Aug 11, 2021 at 10:07 PM LIU Zhiwei wrote: > > > On 2021/8/11 下午5:26, Bin Meng wrote: > > On Tue, Aug 10, 2021 at 11:35 AM LIU Zhiwei wrote: > >> For some cpu, the isa version has already been set in cpu init function. > >> Thus only overide the isa version when isa version is not set,

Re: [PATCH] target/riscv: Don't wrongly overide isa version

2021-08-11 Thread LIU Zhiwei
On 2021/8/11 下午5:26, Bin Meng wrote: On Tue, Aug 10, 2021 at 11:35 AM LIU Zhiwei wrote: For some cpu, the isa version has already been set in cpu init function. Thus only overide the isa version when isa version is not set, or typo: override, please fix the commit title as well OK users

Re: [PATCH v12] qapi: introduce 'query-x86-cpuid' QMP command.

2021-08-11 Thread Eduardo Habkost
On Wed, Aug 11, 2021 at 9:44 AM Thomas Huth wrote: > > On 11/08/2021 15.40, Eduardo Habkost wrote: > > On Wed, Aug 11, 2021 at 2:10 AM Thomas Huth wrote: > >> > >> On 10/08/2021 20.56, Eduardo Habkost wrote: > >>> On Sat, Aug 07, 2021 at 04:22:42PM +0200, Markus Armbruster wrote: > Is this

Re: [PATCH v12] qapi: introduce 'query-x86-cpuid' QMP command.

2021-08-11 Thread Thomas Huth
On 11/08/2021 15.40, Eduardo Habkost wrote: On Wed, Aug 11, 2021 at 2:10 AM Thomas Huth wrote: On 10/08/2021 20.56, Eduardo Habkost wrote: On Sat, Aug 07, 2021 at 04:22:42PM +0200, Markus Armbruster wrote: Is this intended to be a stable interface? Interfaces intended just for debugging

Re: [PATCH v12] qapi: introduce 'query-x86-cpuid' QMP command.

2021-08-11 Thread Eduardo Habkost
On Wed, Aug 11, 2021 at 2:10 AM Thomas Huth wrote: > > On 10/08/2021 20.56, Eduardo Habkost wrote: > > On Sat, Aug 07, 2021 at 04:22:42PM +0200, Markus Armbruster wrote: > >> Is this intended to be a stable interface? Interfaces intended just for > >> debugging usually aren't. > > > > I don't

Re: [PULL 0/7] Maintainers 20210811 patches

2021-08-11 Thread Peter Maydell
rg/qemu tags/maintainers-20210811-pull-request > > for you to fetch changes up to a4de5e8a0667e3ee43ca9953ec7fd11ff19f2c92: > > MAINTAINERS: update virtio-gpu entry. (2021-08-11 08:39:16 +0200) > > -

Re: [PATCH 0/2] Set user creatable for flag ibex uart and plic

2021-08-11 Thread Damien Hedde
On 8/11/21 1:15 PM, Peter Maydell wrote: > On Wed, 11 Aug 2021 at 10:43, Damien Hedde wrote: >> This small series only consist in setting the user_creatable flag >> of ibex_uart and ibex_plic devices. These two devices are already >> using properties to configure themselves so nothing else is

qcow2 perfomance: read-only IO on the guest generates high write IO on the host

2021-08-11 Thread Christopher Pereira
Hi, I'm reading a directory with 5.000.000 files (2,4 GB) inside a guest using "find | grep -c". On the host I saw high write IO (40 MB/s !) during over 1 hour using virt-top. I later repeated the read-only operation inside the guest and no additional data was written on the host. The

Re: [PATCH v2] docs: make sphinx-build be quiet by default

2021-08-11 Thread Daniel P . Berrangé
On Wed, Aug 11, 2021 at 03:22:43PM +0400, Marc-André Lureau wrote: > Hi > > On Tue, Aug 10, 2021 at 3:32 PM Daniel P. Berrangé > wrote: > > > The sphinx-build is fairly verbose spitting out pages of output to the > > console, which causes errors from other build commands to be scrolled > > off

Re: [PATCH v2] docs: make sphinx-build be quiet by default

2021-08-11 Thread Marc-André Lureau
Hi On Tue, Aug 10, 2021 at 3:32 PM Daniel P. Berrangé wrote: > The sphinx-build is fairly verbose spitting out pages of output to the > console, which causes errors from other build commands to be scrolled > off the top of the terminal. This can leave the mistaken impression that > the build

Re: [PATCH 12/19] target/ppc/pmu_book3s_helper.c: enable PMC1 counter negative EBB

2021-08-11 Thread Daniel Henrique Barboza
On 8/11/21 12:40 AM, David Gibson wrote: On Tue, Aug 10, 2021 at 05:26:09PM -0300, Daniel Henrique Barboza wrote: On 8/10/21 1:01 AM, David Gibson wrote: On Mon, Aug 09, 2021 at 10:10:50AM -0300, Daniel Henrique Barboza wrote: This patch starts the counter negative EBB support by

Re: [PATCH 0/2] Set user creatable for flag ibex uart and plic

2021-08-11 Thread Peter Maydell
On Wed, 11 Aug 2021 at 10:43, Damien Hedde wrote: > This small series only consist in setting the user_creatable flag > of ibex_uart and ibex_plic devices. These two devices are already > using properties to configure themselves so nothing else is required. > > Note that this change alone will

Re: [PATCH] tests/qtest/vhost-user-blk-test: Check whether qemu-storage-daemon is available

2021-08-11 Thread Peter Maydell
On Wed, 11 Aug 2021 at 11:00, Thomas Huth wrote: > > The vhost-user-blk-test currently hangs if QTEST_QEMU_STORAGE_DAEMON_BINARY > points to a non-existing binary. Let's improve this situation by checking > for the availability of the binary first, so we can fail gracefully if > it is not

Re: [PATCH] storage-daemon: Add missing build dependency to the vhost-user-blk-test

2021-08-11 Thread Peter Maydell
On Wed, 11 Aug 2021 at 10:47, Thomas Huth wrote: > > vhost-user-blk-test needs the qemu-storage-deamon, otherwise it typo: 'daemon' > currently hangs. So make sure that we build the daemon before running > the tests. -- PMM

Re: [PATCH] Use EGL device extension in display initialization.

2021-08-11 Thread Marc-André Lureau
Hi On Wed, Aug 11, 2021 at 11:58 AM Eugene Huang wrote: > Hi, > > > > I have had some hard time to set up git send-email. I am not even sure if > it is doable here. I read that attachments can be used a last resort for > first timers. Here are the attachments. Hope it works. > > >

Re: [PATCH] tests/qtest/vhost-user-blk-test: Check whether qemu-storage-daemon is available

2021-08-11 Thread Alexander Bulekov
On 210811 1159, Thomas Huth wrote: > The vhost-user-blk-test currently hangs if QTEST_QEMU_STORAGE_DAEMON_BINARY > points to a non-existing binary. Let's improve this situation by checking > for the availability of the binary first, so we can fail gracefully if > it is not accessible. > >

Re: [PATCH] storage-daemon: Add missing build dependency to the vhost-user-blk-test

2021-08-11 Thread Alexander Bulekov
On 210811 1147, Thomas Huth wrote: > vhost-user-blk-test needs the qemu-storage-deamon, otherwise it > currently hangs. So make sure that we build the daemon before running > the tests. > > Signed-off-by: Thomas Huth > --- Tested-by: Alexander Bulekov

[PATCH for 6.1] plugins: do not limit exported symbols if modules are active

2021-08-11 Thread Paolo Bonzini
On Mac --enable-modules and --enable-plugins are currently incompatible, because the Apple -Wl,-exported_symbols_list command line options prevents the export of any symbols needed by the modules. On x86 -Wl,--dynamic-list does not have this effect, but only because the -Wl,--export-dynamic

[PATCH for 6.1] plugins: do not limit exported symbols if modules are active

2021-08-11 Thread Paolo Bonzini
On Mac --enable-modules and --enable-plugins are currently incompatible, because the Apple -Wl,-exported_symbols_list command line options prevents the export of any symbols needed by the modules. On x86 -Wl,--dynamic-list does not have this effect, but only because the -Wl,--export-dynamic

[PATCH] tests/qtest/vhost-user-blk-test: Check whether qemu-storage-daemon is available

2021-08-11 Thread Thomas Huth
The vhost-user-blk-test currently hangs if QTEST_QEMU_STORAGE_DAEMON_BINARY points to a non-existing binary. Let's improve this situation by checking for the availability of the binary first, so we can fail gracefully if it is not accessible. Signed-off-by: Thomas Huth ---

Re: [PATCH v4] failover: unregister ROM on unplug

2021-08-11 Thread Laurent Vivier
On 11/08/2021 08:50, Michael S. Tsirkin wrote: > On Wed, Jul 21, 2021 at 06:09:05PM +0200, Laurent Vivier wrote: >> The intend of failover is to allow to migrate a VM with a VFIO >> networking card without disrupting the network operation by switching >> to a virtio-net device during the

[PATCH] storage-daemon: Add missing build dependency to the vhost-user-blk-test

2021-08-11 Thread Thomas Huth
vhost-user-blk-test needs the qemu-storage-deamon, otherwise it currently hangs. So make sure that we build the daemon before running the tests. Signed-off-by: Thomas Huth --- storage-daemon/meson.build | 8 tests/qtest/meson.build| 7 +-- 2 files changed, 9 insertions(+), 6

[PATCH 1/2] hw/char/ibex_uart: set user-creatable

2021-08-11 Thread Damien Hedde
The ibex_uart meets the criteria to be user_creatable: all parameters are set from properties. Note that this patch, alone, does not allow to create an instance with -device cli option or device_add qmp command. Since it is a sysbus device, additional authorization must be done by the machine.

[PATCH 0/2] Set user creatable for flag ibex uart and plic

2021-08-11 Thread Damien Hedde
Hi, This small series only consist in setting the user_creatable flag of ibex_uart and ibex_plic devices. These two devices are already using properties to configure themselves so nothing else is required. Note that this change alone will not allow creation of these devices using -device cli

[PATCH 2/2] hw/char/ibex_plic: set user-creatable

2021-08-11 Thread Damien Hedde
The ibex_plic meets the criteria to be user_creatable: all parameters are set from properties. Note that this patch, alone, does not allow to create an instance with -device cli option or device_add qmp command. Since it is a sysbus device, additional authorization must be done by the machine.

Re: [PATCH] target/riscv: Don't wrongly overide isa version

2021-08-11 Thread Bin Meng
On Tue, Aug 10, 2021 at 11:35 AM LIU Zhiwei wrote: > > For some cpu, the isa version has already been set in cpu init function. > Thus only overide the isa version when isa version is not set, or typo: override, please fix the commit title as well > users set different isa version explicitly by

Re: [RFC PATCH v0 1/2] spapr: Add H_REG_SNS hcall

2021-08-11 Thread Bharata B Rao
On Mon, Aug 09, 2021 at 01:49:54PM +1000, David Gibson wrote: > On Thu, Aug 05, 2021 at 01:02:27PM +0530, Bharata B Rao wrote: > > Add support for H_REG_SNS hcall so that asynchronous page > > fault mechanism can be supported on PowerKVM guests. > > > > This hcall essentially issues

Re: [PATCH] tests/acceptance: Test powernv machines

2021-08-11 Thread Thomas Huth
On 10/08/2021 11.09, Cédric Le Goater wrote: On 8/10/21 10:36 AM, Joel Stanley wrote: On Tue, 10 Aug 2021 at 08:34, Cédric Le Goater wrote: Fetch the OpenPOWER images to boot the powernv8 and powernv9 machines with a simple PCI layout. Cc: Cleber Rosa Cc: Wainer dos Santos Moschetta

[PATCH v2 09/13] hw/s390x/s390-skeys: use memory mapping to detect which storage keys to migrate

2021-08-11 Thread David Hildenbrand
Let's use the guest_phys_blocks API to get physical memory regions that are well defined inside our physical address space and migrate the storage keys of these. This is a preparation for having memory besides initial ram defined in the guest physical address space, for example, via memory

[PATCH v2 06/13] s390x/mmu_helper: fixup mmu_translate() documentation

2021-08-11 Thread David Hildenbrand
Looks like we forgot to adjust documentation of one parameter. Reviewed-by: Thomas Huth Signed-off-by: David Hildenbrand --- target/s390x/mmu_helper.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/target/s390x/mmu_helper.c b/target/s390x/mmu_helper.c index

[PATCH v2 05/13] s390x/mmu_helper: no need to pass access type to mmu_translate_asce()

2021-08-11 Thread David Hildenbrand
The access type is unused since commit 81d7e3bc45 ("s390x/mmu: Inject DAT exceptions from a single place"). Reviewed-by: Thomas Huth Signed-off-by: David Hildenbrand --- target/s390x/mmu_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/s390x/mmu_helper.c

[PATCH v2 13/13] hw/s390x/s390-skeys: lazy storage key enablement under TCG

2021-08-11 Thread David Hildenbrand
Let's enable storage keys lazily under TCG, just as we do under KVM. Only fairly old Linux versions actually make use of storage keys, so it can be kind of wasteful to allocate quite some memory and track changes and references if nobody cares. We have to make sure to flush the TLB when enabling

[PATCH v2 12/13] hw/s390x/s390-skeys: rename skeys_enabled to skeys_are_enabled

2021-08-11 Thread David Hildenbrand
... and make it return a bool instead. Signed-off-by: David Hildenbrand --- hw/s390x/s390-skeys-kvm.c | 4 ++-- hw/s390x/s390-skeys.c | 12 ++-- include/hw/s390x/storage-keys.h | 2 +- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git

[PATCH v2 08/13] s390x/mmu_helper: avoid setting the storage key if nothing changed

2021-08-11 Thread David Hildenbrand
Avoid setting the key if nothing changed. Reviewed-by: Thomas Huth Signed-off-by: David Hildenbrand --- target/s390x/mmu_helper.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/target/s390x/mmu_helper.c b/target/s390x/mmu_helper.c index de6df928d2..e2b372efd9

[PATCH v2 04/13] s390x/tcg: check for addressing exceptions for RRBE, SSKE and ISKE

2021-08-11 Thread David Hildenbrand
Let's replace the ram_size check by a proper physical address space check (for example, to prepare for memory hotplug), trigger addressing exceptions and trace the return value of the storage key getter/setter. Provide an helper mmu_absolute_addr_valid() to be used in other context soon. Always

[PATCH qemu v2] docs: how to use gdb with unix sockets (v2)

2021-08-11 Thread ~archi42
From: Sebastian Meyer This includes the changes suggested by Philippe. I kept the `-S` in the command line. The user shall use that instead of `wait=on`. Signed-off-by: Sebastian Meyer --- docs/system/gdb.rst | 24 +++- 1 file changed, 23 insertions(+), 1 deletion(-) diff

[PATCH v2 10/13] hw/s390x/s390-skeys: use memory mapping to detect which storage keys to dump

2021-08-11 Thread David Hildenbrand
Handle it similar to migration. Assert that we're holding the BQL, to make sure we don't see concurrent modifications. Reviewed-by: Thomas Huth Signed-off-by: David Hildenbrand --- hw/s390x/s390-skeys.c | 50 ++- 1 file changed, 30 insertions(+), 20

[PATCH v2 03/13] s390x/tcg: convert real to absolute address for RRBE, SSKE and ISKE

2021-08-11 Thread David Hildenbrand
For RRBE, SSKE, and ISKE, we're dealing with real addresses, so we have to convert to an absolute address first. In the future, when adding EDAT1 support, we'll have to pay attention to SSKE handling, as we'll be dealing with absolute addresses when the multiple-block control is one.

[PATCH v2 02/13] s390x/tcg: fix ignoring bit 63 when setting the storage key in SSKE

2021-08-11 Thread David Hildenbrand
Right now we could set an 8-bit storage key via SSKE and retrieve it again via ISKE, which is against the architecture description: SSKE: " The new seven-bit storage-key value, or selected bits thereof, is obtained from bit positions 56-62 of gen- eral register R 1 . The contents of bit positions

[PATCH v2 11/13] hw/s390x/s390-skeys: check if an address is valid before dumping the key

2021-08-11 Thread David Hildenbrand
Let's validate the given address and report a proper error in case it's not. All call paths now properly check the validity of the given GFN. Remove the TODO. The errors inside the getter and setter should only trigger if something really goes wrong now, for example, with a broken migration

[PATCH v2 01/13] s390x/tcg: wrap address for RRBE

2021-08-11 Thread David Hildenbrand
Let's wrap the address just like for SSKE and ISKE. Reviewed-by: Thomas Huth Signed-off-by: David Hildenbrand --- target/s390x/tcg/mem_helper.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/target/s390x/tcg/mem_helper.c b/target/s390x/tcg/mem_helper.c index

[PATCH v2 07/13] s390x/mmu_helper: move address validation into mmu_translate*()

2021-08-11 Thread David Hildenbrand
Let's move address validation into mmu_translate() and mmu_translate_real(). This allows for checking whether an absolute address is valid before looking up the storage key. We can now get rid of the ram_size check. Interestingly, we're already handling LOAD REAL ADDRESS wrong, because a) We're

[PATCH v2 00/13] s390x: skey related fixes, cleanups, and memory device preparations

2021-08-11 Thread David Hildenbrand
This series fixes multiple TCG issues related to storage key instructions, fixes some TCG issues related to LOAD REAL ADDRESS and skeys, implements lazy skey enablement under TCG, and prepares the whole skey infrastructure for dealing with addresses beyond initial RAM (e.g., memory devices like

[PATCH 1/1] edid: Added support for 4k@60 Hz monitor

2021-08-11 Thread Singh, Satyeshwar
Previously, the large modes (>1080p) that were generated by Qemu in its EDID were all 50 Hz. If we provide them to a Guest OS and the user selects one of these modes, then the OS by default only gets 50 FPS. This is especially true for Windows OS. With this patch, we are now exposing a

[PATCH 2/2] hw/i386: Rename default_bus_bypass_iommu

2021-08-11 Thread Jean-Philippe Brucker
Since commit d8fb7d0969d5 ("vl: switch -M parsing to keyval"), machine parameter definitions cannot use underscores, because keyval_dashify() transforms them to dashes and the parser doesn't find the parameter. This affects option default_bus_bypass_iommu which was introduced in the same release:

[PATCH 1/2] hw/arm/virt: Rename default_bus_bypass_iommu

2021-08-11 Thread Jean-Philippe Brucker
Since commit d8fb7d0969d5 ("vl: switch -M parsing to keyval"), machine parameter definitions cannot use underscores, because keyval_dashify() transforms them to dashes and the parser doesn't find the parameter. This affects option default_bus_bypass_iommu which was introduced in the same release:

Re: [PATCH 2/2] gitlab: skip many more targets in windows cross builds

2021-08-11 Thread Daniel P . Berrangé
On Wed, Aug 11, 2021 at 08:20:37AM +0200, Philippe Mathieu-Daudé wrote: > On 8/10/21 4:06 PM, Daniel P. Berrangé wrote: > > The windows cross builds still take way too long in gitlab CI, so need > > more targets to be skipped. We don't want to hurt coverage of other > > cross builds more though,

[PATCH v2 4/6] docs/about/removed-features: Document removed HMP commands from QEMU v2.12

2021-08-11 Thread Thomas Huth
These HMP commands had been removed/replaced in QEMU v2.12. Still, some people might want to update from older versions to the recent QEMU version, so we should give some recommendations for the replacements in our documentation. Signed-off-by: Thomas Huth --- docs/about/removed-features.rst |

Re: [PATCH v1 12/12] hw/s390x/s390-skeys: lazy storage key enablement under TCG

2021-08-11 Thread David Hildenbrand
Shouldn't there be some modifications to qemu_s390_skeys_get() in that case? Or does "fail" mean that it crashes? qemu_s390_skeys_get() should simply return -EINVAL because skeydev->key_count == 0. So don't think we need any modifications. Makes sense? Ah, right, make sense, indeed.

[PATCH v2 5/6] docs/about/removed-features: Document removed devices from older QEMU versions

2021-08-11 Thread Thomas Huth
These devices had been removed/replaced in QEMU v2.12 and v4.0. Signed-off-by: Thomas Huth --- docs/about/removed-features.rst | 11 +++ 1 file changed, 11 insertions(+) diff --git a/docs/about/removed-features.rst b/docs/about/removed-features.rst index 8bf3ebecab..0c860be62d 100644

[PATCH v2 6/6] docs/about/removed-features: Document removed machines from older QEMU versions

2021-08-11 Thread Thomas Huth
These machines had been removed in the QEMU v2.6 up to 4.0 time frame. Signed-off-by: Thomas Huth --- docs/about/removed-features.rst | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/docs/about/removed-features.rst b/docs/about/removed-features.rst index

[PATCH v2 1/6] docs/about/removed-features: Document removed CLI options from QEMU v2.12

2021-08-11 Thread Thomas Huth
These CLI options had been removed/replaced in QEMU v2.12. Still, some people might want to update from older versions to the recent QEMU version, so we should give some recommendations for the replacements in our documentation. Signed-off-by: Thomas Huth --- docs/about/removed-features.rst |

[PATCH v2 0/6] Document removed features from older QEMU versions

2021-08-11 Thread Thomas Huth
Before we started to gather the information about removed features in the git repo, we collected the information in the Wiki here: https://wiki.qemu.org/Features/RemovedFeatures Since it's rather confusing for the users to have two sources where to look up the related information, let's add the

[PATCH v2 3/6] docs/about/removed-features: Document removed CLI options from QEMU v3.1

2021-08-11 Thread Thomas Huth
These CLI options had been removed/replaced in QEMU v3.1. Still, some people might want to update from older versions to the recent QEMU version, so we should give some recommendations for the replacements in our documentation. Signed-off-by: Thomas Huth --- docs/about/removed-features.rst | 67

[PATCH v2 2/6] docs/about/removed-features: Document removed CLI options from QEMU v3.0

2021-08-11 Thread Thomas Huth
These CLI options had been removed/replaced in QEMU v3.0. Still, some people might want to update from older versions to the recent QEMU version, so we should give some recommendations for the replacements in our documentation. Signed-off-by: Thomas Huth --- docs/about/removed-features.rst | 35

Re: [PATCH] build: remove redundant 'check-build' make target

2021-08-11 Thread Daniel P . Berrangé
On Wed, Aug 11, 2021 at 08:02:44AM +0200, Thomas Huth wrote: > On 10/08/2021 18.44, Daniel P. Berrangé wrote: > > The 'check-build' make target was added as a way to build all the unit > > test binaries, since the standard 'all' target would not trigger this. > > > > Since the switch to meson,

Re: [PULL ppc] powernv queue

2021-08-11 Thread Cédric Le Goater
On 8/11/21 10:15 AM, Peter Maydell wrote: > On Tue, 10 Aug 2021 at 20:36, Cédric Le Goater wrote: >> Yes. I should have added a 'ppc-for-6.2' prefix. > > If this wasn't intended for master, can you make sure the > cover letter includes the "PULL SUBSYSTEM whatever" subject > tag and has "not for

Re: [PULL ppc] powernv queue

2021-08-11 Thread Peter Maydell
On Tue, 10 Aug 2021 at 20:36, Cédric Le Goater wrote: > Yes. I should have added a 'ppc-for-6.2' prefix. If this wasn't intended for master, can you make sure the cover letter includes the "PULL SUBSYSTEM whatever" subject tag and has "not for master" in the body, as noted in

Re: [PATCH 08/10] aspeed: Emulate the AST2600A3

2021-08-11 Thread Cédric Le Goater
On 8/9/21 5:55 PM, Philippe Mathieu-Daudé wrote: > On 8/9/21 3:15 PM, Cédric Le Goater wrote: >> From: Joel Stanley >> >> This is the latest revision of the ASPEED 2600 SoC. As there is no >> need to model multiple revisions of the same SoC for the moment, >> update the SCU AST2600 to model the

RE: [PATCH] Use EGL device extension in display initialization.

2021-08-11 Thread Eugene Huang via
Hi, I have had some hard time to set up git send-email. I am not even sure if it is doable here. I read that attachments can be used a last resort for first timers. Here are the attachments. Hope it works. Thanks, Eugene From: Marc-André Lureau Sent: Friday, August 6, 2021 12:25 AM To:

Re: [PATCH 1/7] MAINTAINERS: update edk2 entry.

2021-08-11 Thread Philippe Mathieu-Daudé
On 8/10/21 10:34 AM, Gerd Hoffmann wrote: > I want keep an eye on the edk2 things happening in qemu. > > Cc: Philippe Mathieu-Daudé > Signed-off-by: Gerd Hoffmann > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index

Re: [PATCH 09/19] PPC64/TCG: Implement 'rfebb' instruction

2021-08-11 Thread David Gibson
On Tue, Aug 10, 2021 at 04:32:35PM -0300, Daniel Henrique Barboza wrote: > > > On 8/10/21 12:50 AM, David Gibson wrote: > > On Mon, Aug 09, 2021 at 10:10:47AM -0300, Daniel Henrique Barboza wrote: > > > From: Gustavo Romero > > > > > > An Event-Based Branch (EBB) allows applications to change

Re: [PATCH 18/19] target/ppc/pmu_book3s_helper.c: add PM_CMPLU_STALL mock events

2021-08-11 Thread David Gibson
On Tue, Aug 10, 2021 at 04:48:59PM -0300, Daniel Henrique Barboza wrote: > > > On 8/10/21 1:17 AM, David Gibson wrote: > > On Mon, Aug 09, 2021 at 10:10:56AM -0300, Daniel Henrique Barboza wrote: > > > EBB powerpc kernel test 'multi_counter_test' uses PM_CMPLU_STALL events > > > that we do not

Re: [PATCH 12/19] target/ppc/pmu_book3s_helper.c: enable PMC1 counter negative EBB

2021-08-11 Thread David Gibson
On Tue, Aug 10, 2021 at 05:26:09PM -0300, Daniel Henrique Barboza wrote: > > > On 8/10/21 1:01 AM, David Gibson wrote: > > On Mon, Aug 09, 2021 at 10:10:50AM -0300, Daniel Henrique Barboza wrote: > > > This patch starts the counter negative EBB support by enabling PMC1 > > > counter negative

Re: [PATCH v4] failover: unregister ROM on unplug

2021-08-11 Thread Michael S. Tsirkin
On Wed, Jul 21, 2021 at 06:09:05PM +0200, Laurent Vivier wrote: > The intend of failover is to allow to migrate a VM with a VFIO > networking card without disrupting the network operation by switching > to a virtio-net device during the migration. > > This simple change allows to test failover

[PULL 7/7] MAINTAINERS: update virtio-gpu entry.

2021-08-11 Thread Gerd Hoffmann
New maintainer wanted. Downgrade status to "Odd Fixes" for now. Signed-off-by: Gerd Hoffmann Message-Id: <20210810083450.2377374-8-kra...@redhat.com> --- MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index

Re: [PATCH 13/19] target/ppc/translate: PMU: handle setting of PMCs while running

2021-08-11 Thread David Gibson
On Tue, Aug 10, 2021 at 05:44:18PM -0300, Daniel Henrique Barboza wrote: > > > On 8/10/21 1:06 AM, David Gibson wrote: > > On Mon, Aug 09, 2021 at 10:10:51AM -0300, Daniel Henrique Barboza wrote: > > > The initial PMU support were made under the assumption that the counters > > > would be set

[PULL 5/7] MAINTAINERS: update usb entries.

2021-08-11 Thread Gerd Hoffmann
New maintainer wanted. Switch role to "Reviewer" for usb-serial, downgrade status to "Odd Fixes" for everything else. Cc: Samuel Thibault Signed-off-by: Gerd Hoffmann Message-Id: <20210810083450.2377374-6-kra...@redhat.com> --- MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [PATCH 06/19] target/ppc/pmu_book3s_helper: enable PMC1-PMC4 events

2021-08-11 Thread David Gibson
On Tue, Aug 10, 2021 at 12:03:15PM -0300, Daniel Henrique Barboza wrote: > > > On 8/10/21 12:42 AM, David Gibson wrote: > > On Mon, Aug 09, 2021 at 10:10:44AM -0300, Daniel Henrique Barboza wrote: > > > So far the PMU logic was using PMC5 for instruction counting (linux > > > kernel

[PULL 3/7] MAINTAINERS: update audio entry.

2021-08-11 Thread Gerd Hoffmann
New maintainer wanted. Downgrade status to "Odd Fixes" for now. Signed-off-by: Gerd Hoffmann Message-Id: <20210810083450.2377374-4-kra...@redhat.com> --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 79b0148cfc27..5cb402d402ec

[PULL 1/7] MAINTAINERS: update edk2 entry.

2021-08-11 Thread Gerd Hoffmann
I want keep an eye on the edk2 things happening in qemu. Cc: Philippe Mathieu-Daudé Signed-off-by: Gerd Hoffmann Message-Id: <20210810083450.2377374-2-kra...@redhat.com> --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index

[PULL 6/7] MAINTAINERS: update virtio-input entry.

2021-08-11 Thread Gerd Hoffmann
New maintainer wanted. Downgrade status to "Odd Fixes" for now. Signed-off-by: Gerd Hoffmann Message-Id: <20210810083450.2377374-7-kra...@redhat.com> --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index b84b7e33e4d0..6e86426572a3

[PULL 2/7] MAINTAINERS: update sockets entry.

2021-08-11 Thread Gerd Hoffmann
I have not touched the code for years. Make the entry match reality and drop my name. Cc: Daniel P. Berrange Signed-off-by: Gerd Hoffmann Message-Id: <20210810083450.2377374-3-kra...@redhat.com> --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index

[PULL 4/7] MAINTAINERS: update spice entry.

2021-08-11 Thread Gerd Hoffmann
New maintainer wanted. Downgrade status to "Odd Fixes" for now. Signed-off-by: Gerd Hoffmann Message-Id: <20210810083450.2377374-5-kra...@redhat.com> --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 5cb402d402ec..33b4fc25e349

[PULL 0/7] Maintainers 20210811 patches

2021-08-11 Thread Gerd Hoffmann
The following changes since commit 703e8cd6189cf699c8d5c094bc68b5f3afa6ad71: Update version for v6.1.0-rc3 release (2021-08-10 19:08:09 +0100) are available in the Git repository at: git://git.kraxel.org/qemu tags/maintainers-20210811-pull-request for you to fetch changes up

  1   2   >