Re: [PATCH v4 12/21] target/riscv: Use DisasExtend in shift operations

2021-08-23 Thread Alistair Francis
On Sat, Aug 21, 2021 at 3:56 AM Richard Henderson wrote: > > These operations are greatly simplified by ctx->w, which allows > us to fold gen_shiftw into gen_shift. Split gen_shifti into > gen_shift_imm_{fn,tl} like we do for gen_arith_imm_{fn,tl}. > > Reviewed-by: Bin Meng > Signed-off-by:

Re: [PATCH v4 11/21] target/riscv: Add DisasExtend to gen_unary

2021-08-23 Thread Alistair Francis
On Sat, Aug 21, 2021 at 3:50 AM Richard Henderson wrote: > > Use ctx->w for ctpopw, which is the only one that can > re-use the generic algorithm for the narrow operation. > > Signed-off-by: Richard Henderson Reviewed-by: Alistair Francis Alistair > --- > target/riscv/translate.c

Re: [PATCH v4 10/21] target/riscv: Move gen_* helpers for RVB

2021-08-23 Thread Alistair Francis
On Sat, Aug 21, 2021 at 3:53 AM Richard Henderson wrote: > > Move these helpers near their use by the trans_* > functions within insn_trans/trans_rvb.c.inc. > > Reviewed-by: Bin Meng > Reviewed-by: Philippe Mathieu-Daudé > Signed-off-by: Richard Henderson Reviewed-by: Alistair Francis

Re: [PATCH v4 03/21] target/riscv: Clean up division helpers

2021-08-23 Thread Alistair Francis
On Sat, Aug 21, 2021 at 3:48 AM Richard Henderson wrote: > > Utilize the condition in the movcond more; this allows some of > the setcond that were feeding into movcond to be removed. > Do not write into source1 and source2. Re-name "condN" to "tempN" > and use the temporaries for more than

Re: [PATCH v4 02/21] tests/tcg/riscv64: Add test for division

2021-08-23 Thread Alistair Francis
On Mon, Aug 23, 2021 at 1:19 PM Bin Meng wrote: > > On Sat, Aug 21, 2021 at 1:43 AM Richard Henderson > wrote: > > > > Signed-off-by: Richard Henderson Reviewed-by: Alistair Francis Alistair > > --- > > tests/tcg/riscv64/test-div.c | 58 +++ > >

<    1   2   3   4