[PULL 07/12] mac_via: move VIA1 reset logic from mac_via_reset() to mos6522_q800_via1_reset()

2021-09-08 Thread Laurent Vivier
From: Mark Cave-Ayland After this change mac_via_reset() is now empty and can be removed. Signed-off-by: Mark Cave-Ayland Reviewed-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20210830102447.10806-8-mark.cave-ayl...@ilande.co.uk> Signed-off-by: Laurent Vivier ---

Re: [RFC v3 13/32] rust: use vendored-sources

2021-09-08 Thread Ian Jackson
marcandre.lur...@redhat.com writes ("[RFC v3 13/32] rust: use vendored-sources"): > Most likely, QEMU will want tighter control over the sources, rather > than relying on crates.io downloading, use a git submodule with all the > dependencies. However, cargo --offline was added in 1.36. Hi.

[PULL 08/12] mac_via: move VIA1 realize logic from mac_via_realize() to mos6522_q800_via1_realize()

2021-09-08 Thread Laurent Vivier
From: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Reviewed-by: Laurent Vivier Message-Id: <20210830102447.10806-9-mark.cave-ayl...@ilande.co.uk> Signed-off-by: Laurent Vivier --- hw/misc/mac_via.c | 86 --- 1 file changed, 44 insertions(+), 42

[PULL 06/12] mac_via: move q800 VIA1 timer variables to q800 VIA1 VMStateDescription

2021-09-08 Thread Laurent Vivier
From: Mark Cave-Ayland These variables are already present in MOS6522Q800VIA1State and so it is just the VMStateDescription move that is needed. With this change the mac_via VMStateDescription is now empty and can be removed completely. Signed-off-by: Mark Cave-Ayland Reviewed-by: Laurent

[PULL 09/12] mac_via: remove mac_via device

2021-09-08 Thread Laurent Vivier
From: Mark Cave-Ayland Remove the mac_via device and wire up both q800 VIA1 and VIA2 directly for the m68k q800 machine. Signed-off-by: Mark Cave-Ayland Reviewed-by: Laurent Vivier Message-Id: <20210830102447.10806-10-mark.cave-ayl...@ilande.co.uk> Signed-off-by: Laurent Vivier ---

[PULL 10/12] mac_via: remove explicit viaN prefix from VIA IRQ gpios

2021-09-08 Thread Laurent Vivier
From: Mark Cave-Ayland Now that q800 VIA1 and VIA2 are completely separate devices there is no need to add a specific device prefix to ensure that the IRQ lines remain separate. Signed-off-by: Mark Cave-Ayland Reviewed-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé Message-Id:

[PULL 00/12] Q800 patches

2021-09-08 Thread Laurent Vivier
/q800-pull-request for you to fetch changes up to dde602ae539910c3579952834b713e2f360ec34a: mac_via: add qdev gpios for nubus slot interrupts to VIA2 (2021-09-08 15:37:41 +0200) q800 pull request 20210908 mac_via: remove MAC_VIA

[PULL 12/12] mac_via: add qdev gpios for nubus slot interrupts to VIA2

2021-09-08 Thread Laurent Vivier
From: Mark Cave-Ayland These will soon be required to enable nubus devices to support interrupts. Signed-off-by: Mark Cave-Ayland Reviewed-by: Laurent Vivier Message-Id: <20210830102447.10806-13-mark.cave-ayl...@ilande.co.uk> Signed-off-by: Laurent Vivier --- include/hw/misc/mac_via.h | 10

[PULL 02/12] mac_via: move last_b variable into q800 VIA1 VMStateDescription

2021-09-08 Thread Laurent Vivier
From: Mark Cave-Ayland This variable is already present in MOS6522Q800VIA1State and can be moved immediately into the q800 VIA1 VMStateDescription. Signed-off-by: Mark Cave-Ayland Reviewed-by: Laurent Vivier Message-Id: <20210830102447.10806-3-mark.cave-ayl...@ilande.co.uk> Signed-off-by:

[PULL 03/12] mac_via: move PRAM contents and block backend to MOS6522Q800VIA1State

2021-09-08 Thread Laurent Vivier
From: Mark Cave-Ayland The PRAM contents are accessed using clock and data pins on q800 VIA1 port B and so can be moved to MOS6522Q800VIA1State. Signed-off-by: Mark Cave-Ayland Reviewed-by: Laurent Vivier Message-Id: <20210830102447.10806-4-mark.cave-ayl...@ilande.co.uk> Signed-off-by:

[PULL 01/12] mac_via: introduce new VMStateDescription for q800 VIA1 and VIA2

2021-09-08 Thread Laurent Vivier
From: Mark Cave-Ayland Move the parent mos6522 objects from vmstate_mac_via into the new VMStateDescription structures to begin the process of splitting MacVIAState into separate VIA1 and VIA2 devices. Signed-off-by: Mark Cave-Ayland Reviewed-by: Laurent Vivier Message-Id:

[Bug 985288] Re: scsi disk emulation doesn't enforce FUA (Force Unit Access) in write-back mode

2021-09-08 Thread Paolo Bonzini
Fixed in 1.1 (commit 7e8c49c56154ab5c45d4f07edf0c22728735da35). :) ** Changed in: qemu Status: Won't Fix => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/985288 Title: scsi

Re: [PATCH v3 0/8] memory: Sanity checks memory transaction when releasing BQL

2021-09-08 Thread Peter Xu
On Wed, Jul 28, 2021 at 02:31:43PM -0400, Peter Xu wrote: > This is v3 of the series. And, I think this is 6.2 material. Ping - just remembered this one too.. -- Peter Xu

Re: [PATCH v1 3/3] migration: multifd: Enable zerocopy

2021-09-08 Thread Daniel P . Berrangé
On Tue, Sep 07, 2021 at 12:13:28PM +0100, Dr. David Alan Gilbert wrote: > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > On Wed, Sep 01, 2021 at 11:35:33AM -0400, Peter Xu wrote: > > > On Wed, Sep 01, 2021 at 09:53:07AM +0100, Daniel P. Berrangé wrote: > > > > On Tue, Aug 31, 2021 at

Re: [PATCH 0/5] Stop adding HMP-only commands, allow QMP for all

2021-09-08 Thread Daniel P . Berrangé
On Wed, Sep 08, 2021 at 05:09:13PM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > We are still adding HMP commands without any QMP counterparts. This is > > done because there are a reasonable number of scenarios where the cost > > of designing a QAPI data type for the

Re: [PATCH v1 2/3] io: Add zerocopy and errqueue

2021-09-08 Thread Peter Xu
On Wed, Sep 08, 2021 at 09:30:58AM +0100, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > On Tue, Sep 07, 2021 at 12:06:15PM +0100, Dr. David Alan Gilbert wrote: > > > > > What if we do the 'flush()' before we start post-copy, instead of > > > > > after each > > > > >

Re: [PATCH RFC server v2 05/11] vfio-user: run vfio-user context

2021-09-08 Thread John Levon
On Wed, Sep 08, 2021 at 04:02:22PM +0100, Stefan Hajnoczi wrote: > > We'd have to have a whole separate API to do that, so a separate thread > > seems a > > better approach? > > Whether to support non-blocking properly in libvfio-user is a decision > for you. If libvfio-user doesn't support

Re: [PATCH v1 2/4] virtio: increase virtuqueue size for virtio-scsi and virtio-blk

2021-09-08 Thread Denis Plotnikov
On 08.09.2021 16:22, Stefano Garzarella wrote: Message bounced, I use new Denis's email address. On Wed, Sep 08, 2021 at 03:17:16PM +0200, Stefano Garzarella wrote: Hi Denis, I just found this discussion since we still have the following line in hw/core/machine.c:    { "vhost-blk-device",

Re: [PATCH v1 3/3] migration: multifd: Enable zerocopy

2021-09-08 Thread Peter Xu
On Wed, Sep 08, 2021 at 09:19:27AM +0100, Dr. David Alan Gilbert wrote: > * Jason Wang (jasow...@redhat.com) wrote: > > On Wed, Sep 8, 2021 at 2:32 AM Peter Xu wrote: > > > > > > On Thu, Sep 02, 2021 at 04:22:55AM -0300, Leonardo Bras Soares Passos > > > wrote: > > > > > I don't think it is

Re: [PATCH 0/5] Stop adding HMP-only commands, allow QMP for all

2021-09-08 Thread Markus Armbruster
Daniel P. Berrangé writes: > We are still adding HMP commands without any QMP counterparts. This is > done because there are a reasonable number of scenarios where the cost > of designing a QAPI data type for the command is not justified. > > This has the downside, however, that we will never be

Re: [PATCH 0/2] iothread: cleanup after adding a new parameter to IOThread

2021-09-08 Thread Stefan Hajnoczi
On Tue, Jul 27, 2021 at 04:59:34PM +0200, Stefano Garzarella wrote: > We recently added a new parameter (aio-max-batch) to IOThread. > This series cleans up the code a bit, no functional changes. > > Stefano Garzarella (2): > iothread: rename PollParamInfo to IOThreadParamInfo > iothread: use

Re: [PATCH RFC server v2 05/11] vfio-user: run vfio-user context

2021-09-08 Thread Stefan Hajnoczi
On Wed, Sep 08, 2021 at 01:37:53PM +, John Levon wrote: > On Wed, Sep 08, 2021 at 01:58:46PM +0100, Stefan Hajnoczi wrote: > > > > +static void *vfu_object_attach_ctx(void *opaque) > > > +{ > > > +VfuObject *o = opaque; > > > +int ret; > > > + > > > +retry_attach: > > > +ret =

Re: [PULL v4 36/43] sgx-epc: Add the fill_device_info() callback support

2021-09-08 Thread Eric Blake
On Wed, Sep 08, 2021 at 12:04:19PM +0200, Paolo Bonzini wrote: > From: Yang Zhong > > Since there is no fill_device_info() callback support, and when we > execute "info memory-devices" command in the monitor, the segfault > will be found. > > This patch will add this callback support and "info

Re: [PULL v4 13/43] vl: Add sgx compound properties to expose SGX EPC sections to guest

2021-09-08 Thread Eric Blake
On Wed, Sep 08, 2021 at 12:03:56PM +0200, Paolo Bonzini wrote: > From: Sean Christopherson > > Because SGX EPC is enumerated through CPUID, EPC "devices" need to be > realized prior to realizing the vCPUs themselves, i.e. long before > generic devices are parsed and realized. From a

Re: [PULL v4 11/43] qom: Add memory-backend-epc ObjectOptions support

2021-09-08 Thread Eric Blake
On Wed, Sep 08, 2021 at 12:03:54PM +0200, Paolo Bonzini wrote: > From: Yang Zhong > > Add the new 'memory-backend-epc' user creatable QOM object in > the ObjectOptions to support SGX since v6.1, or the sgx backend > object cannot bootup. > > Signed-off-by: Yang Zhong > > v1-->v2: >- Added

Re: [PATCH 2/2] iothread: use IOThreadParamInfo in iothread_[set|get]_param()

2021-09-08 Thread Stefan Hajnoczi
On Tue, Jul 27, 2021 at 04:59:36PM +0200, Stefano Garzarella wrote: > Commit 0445409d74 ("iothread: generalize > iothread_set_param/iothread_get_param") moved common code to set and > get IOThread parameters in two new functions. > > These functions are called inside callbacks, so we don't need

Re: [PATCH 1/2] iothread: rename PollParamInfo to IOThreadParamInfo

2021-09-08 Thread Stefan Hajnoczi
On Tue, Jul 27, 2021 at 04:59:35PM +0200, Stefano Garzarella wrote: > Commit 1793ad0247 ("iothread: add aio-max-batch parameter") added > a new parameter (aio-max-batch) to IOThread and used PollParamInfo > structure to handle it. > > Since it is not a parameter of the polling mechanism, we

[PATCH RESEND v2 1/1] hmp: synchronize cpu state for lapic info

2021-09-08 Thread Dongli Zhang
While the default "info lapic" always synchronizes cpu state ... mon_get_cpu() -> mon_get_cpu_sync(mon, true) -> cpu_synchronize_state(cpu) -> ioctl KVM_GET_LAPIC (taking KVM as example) ... the cpu state is not synchronized when the apic-id is available as argument. The cpu state

Re: [RFC v3 03/32] scripts/qapi: teach c_param_type() to return const argument type

2021-09-08 Thread Marc-André Lureau
Hi On Wed, Sep 8, 2021 at 4:12 PM Markus Armbruster wrote: > marcandre.lur...@redhat.com writes: > > > From: Marc-André Lureau > > > > The argument isn't owned by the callee, so it better be const. > > But a lot of code in QEMU rely on non-const arguments to tweak it (steal > > values etc). >

Re: [RFC v3 10/32] build-sys: add --with-rust{-target} & basic build infrastructure

2021-09-08 Thread Marc-André Lureau
Hi On Wed, Sep 8, 2021 at 6:01 PM Peter Maydell wrote: > On Tue, 7 Sept 2021 at 13:41, wrote: > > > > From: Marc-André Lureau > > > > Add the build-sys infrastructure to optionally build Rust code. > > Introduce a top-level workspace, so various sub-projects (libraries, > > executables etc)

Re: [PATCH] block/vvfat: Fix ro shared folder

2021-09-08 Thread Kevin Wolf
Am 31.08.2021 um 16:17 hat Guillaume Roche geschrieben: > QEMU exits in error when passing a vfat shared folder in read-only mode. > > To fix this issue, this patch removes any potential write permission > from cumulative_perms, when a read-only block device is in use. > > Buglink:

RE: [PATCH] hw/ssi: imx_spi: Improve chip select handling

2021-09-08 Thread Cheng, Xuzhou
Thanks Bin added me into this loop. Hi, Guenter I am interested in your patch and the issue what you found. I want to reproduce your issue on Linux, but I failed, the spi-nor of sabrelite on Linux does not work. Could you share your Linux kernel version? It would be great if you can share

Re: [RFC v3 14/32] scripts/qapi: add QAPISchemaIfCond.rsgen()

2021-09-08 Thread Marc-André Lureau
Hi On Wed, Sep 8, 2021 at 4:33 PM Markus Armbruster wrote: > marcandre.lur...@redhat.com writes: > > > From: Marc-André Lureau > > > > Generate Rust #[cfg(...)] guards from QAPI 'if' conditions. > > > > Signed-off-by: Marc-André Lureau > > --- > > scripts/qapi/common.py | 16

Re: [RFC v3 10/32] build-sys: add --with-rust{-target} & basic build infrastructure

2021-09-08 Thread Peter Maydell
On Tue, 7 Sept 2021 at 13:41, wrote: > > From: Marc-André Lureau > > Add the build-sys infrastructure to optionally build Rust code. > Introduce a top-level workspace, so various sub-projects (libraries, > executables etc) can be developed together, sharing the dependencies and > output

Re: [RFC v3 00/32] Rust binding for QAPI and qemu-ga QMP handler examples

2021-09-08 Thread Marc-André Lureau
Hi On Wed, Sep 8, 2021 at 5:23 PM Markus Armbruster wrote: > Build fails for me: > > make: Entering directory '/work/armbru/qemu/bld' > config-host.mak is out-of-date, running configure > GIT ui/keycodemapdb meson tests/fp/berkeley-testfloat-3 > tests/fp/berkeley-softfloat-3 dtc capstone

Re: [RFC v3 04/32] glib-compat: add G_SIZEOF_MEMBER

2021-09-08 Thread Marc-André Lureau
Hi On Wed, Sep 8, 2021 at 4:16 PM Markus Armbruster wrote: > marcandre.lur...@redhat.com writes: > > > From: Marc-André Lureau > > > > The macro was introduced in 2.64. Let's redefine it, to allow its usage > > with older versions and silence the deprecation warning. > > > > Signed-off-by:

Re: [PATCH] vhost-vsock: fix migration issue when seqpacket is supported

2021-09-08 Thread Daniel P . Berrangé
On Wed, Sep 08, 2021 at 03:41:35PM +0200, Stefano Garzarella wrote: > On Tue, Sep 07, 2021 at 03:47:56PM +0200, Stefano Garzarella wrote: > > On Tue, Sep 07, 2021 at 02:22:24PM +0100, Daniel P. Berrangé wrote: > > > On Tue, Sep 07, 2021 at 02:49:35PM +0200, Stefano Garzarella wrote: > > > > Commit

Re: [RFC v3 09/32] build-sys: add i686 cpu target

2021-09-08 Thread Peter Maydell
On Tue, 7 Sept 2021 at 13:37, wrote: > > From: Marc-André Lureau > > Rust does not have i386 targets, so distinguish when target cpu is i686. > > Signed-off-by: Marc-André Lureau > --- > configure | 13 + > 1 file changed, 9 insertions(+), 4 deletions(-) > > diff --git a/configure

Re: [PATCH 0/3] qapi: static typing conversion, pt5c

2021-09-08 Thread Markus Armbruster
Needs a rebase now. Let's finish discussing my review of pt5b [v2] first. Pending patches to expr.py should have made it to master by then. If you're impatient, suggest to base on master + "[PATCH 0/5] qapi: Another round of minor fixes and cleanups" + pt5b [v2].

Re: [PATCH] vhost-vsock: fix migration issue when seqpacket is supported

2021-09-08 Thread Stefano Garzarella
On Tue, Sep 07, 2021 at 03:47:56PM +0200, Stefano Garzarella wrote: On Tue, Sep 07, 2021 at 02:22:24PM +0100, Daniel P. Berrangé wrote: On Tue, Sep 07, 2021 at 02:49:35PM +0200, Stefano Garzarella wrote: Commit 1e08fd0a46 ("vhost-vsock: SOCK_SEQPACKET feature bit support") enabled the

Re: [PATCH RFC server v2 05/11] vfio-user: run vfio-user context

2021-09-08 Thread John Levon
On Wed, Sep 08, 2021 at 01:58:46PM +0100, Stefan Hajnoczi wrote: > > +static void *vfu_object_attach_ctx(void *opaque) > > +{ > > +VfuObject *o = opaque; > > +int ret; > > + > > +retry_attach: > > +ret = vfu_attach_ctx(o->vfu_ctx); > > +if (ret < 0 && (errno == EAGAIN || errno ==

Re: [PATCH 5/5] qapi: Fix bogus error for 'if': { 'not': '' }

2021-09-08 Thread Markus Armbruster
Markus Armbruster writes: > Signed-off-by: Markus Armbruster > --- > scripts/qapi/expr.py | 21 + > tests/qapi-schema/bad-if-not.err | 2 +- > 2 files changed, 14 insertions(+), 9 deletions(-) > > diff --git a/scripts/qapi/expr.py b/scripts/qapi/expr.py > index

Re: [RFC v3 00/32] Rust binding for QAPI and qemu-ga QMP handler examples

2021-09-08 Thread Markus Armbruster
Build fails for me: make: Entering directory '/work/armbru/qemu/bld' config-host.mak is out-of-date, running configure GIT ui/keycodemapdb meson tests/fp/berkeley-testfloat-3 tests/fp/berkeley-softfloat-3 dtc capstone slirp fatal: remote error: upload-pack: not our ref

Re: [PATCH v1 2/4] virtio: increase virtuqueue size for virtio-scsi and virtio-blk

2021-09-08 Thread Stefano Garzarella
Message bounced, I use new Denis's email address. On Wed, Sep 08, 2021 at 03:17:16PM +0200, Stefano Garzarella wrote: Hi Denis, I just found this discussion since we still have the following line in hw/core/machine.c: { "vhost-blk-device", "seg_max_adjust", "off"} IIUC it was a typo, and

Re: [PATCH v1 2/4] virtio: increase virtuqueue size for virtio-scsi and virtio-blk

2021-09-08 Thread Stefano Garzarella
Hi Denis, I just found this discussion since we still have the following line in hw/core/machine.c: { "vhost-blk-device", "seg_max_adjust", "off"} IIUC it was a typo, and I think we should fix it since in the future we can have `vhost-blk-device`. So, I think we have 2 options: 1.

[RFC PATCH 0/4] block layer: split block APIs in graph and I/O

2021-09-08 Thread Emanuele Giuseppe Esposito
Currently, block layer APIs like block-backend.h contain a mix of functions that are either running in the main loop and under the BQL, or are thread-safe functions and run in iothreads performing I/O. The functions running under BQL also take care of modifying the block graph, by using drain

[RFC PATCH 4/4] block/block-backend.c: assertions for block-backend

2021-09-08 Thread Emanuele Giuseppe Esposito
All the graph API functions will check that qemu_in_main_thread() returns true. If not, it means that the safety of BQL cannot be guaranteed, and they need to be moved to I/O. Signed-off-by: Emanuele Giuseppe Esposito --- block/block-backend.c | 93 +-

[RFC PATCH 1/4] main-loop.h: introduce qemu_in_main_thread()

2021-09-08 Thread Emanuele Giuseppe Esposito
When invoked from the main loop, this function is the same as qemu_mutex_iothread_locked, and returns true if the BQL is held. When invoked from iothreads or tests, it returns true only if the current AioContext is the Main Loop. This essentially just extends qemu_mutex_iothread_locked to work

[RFC PATCH 3/4] include/sysemu/block-backend: split header into I/O and graph API

2021-09-08 Thread Emanuele Giuseppe Esposito
block-backend.h currently contains a mix of functions: some of them run under the BQL and modify the block layer graph, others are instead thread-safe and perform I/O in iothreads. It is not easy to understand which function is part of which group (I/O vs graph), and this patch aims to clarify it.

[RFC PATCH 2/4] migration: block-dirty-bitmap: add missing qemu_mutex_lock_iothread

2021-09-08 Thread Emanuele Giuseppe Esposito
init_dirty_bitmap_migration assumes the iothread lock (BQL) to be held, but instead it isn't. Instead of adding the lock to qemu_savevm_state_setup(), follow the same pattern as the other ->save_setup callbacks and lock+unlock inside dirty_bitmap_save_setup(). Signed-off-by: Emanuele Giuseppe

Re: [PATCH v3 4/6] qapi: Apply aliases in qobject-input-visitor

2021-09-08 Thread Kevin Wolf
Am 06.09.2021 um 17:16 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > When looking for an object in a struct in the external representation, > > check not only the currently visited struct, but also whether an alias > > in the current StackObject matches and try to fetch the value

Re: [PATCH RFC server v2 05/11] vfio-user: run vfio-user context

2021-09-08 Thread Stefan Hajnoczi
On Fri, Aug 27, 2021 at 01:53:24PM -0400, Jagannathan Raman wrote: > Setup a handler to run vfio-user context. The context is driven by > messages to the file descriptor associated with it - get the fd for > the context and hook up the handler with it > > Signed-off-by: Elena Ufimtseva >

Re: [PATCH RFC server v2 04/11] vfio-user: find and init PCI device

2021-09-08 Thread Stefan Hajnoczi
On Fri, Aug 27, 2021 at 01:53:23PM -0400, Jagannathan Raman wrote: > @@ -96,6 +102,28 @@ static void vfu_object_machine_done(Notifier *notifier, > void *data) > strerror(errno)); > return; > } > + > +dev = qdev_find_recursive(sysbus_get_default(), o->devid);

[qemu-web PATCH 5/6] Simplify and restructure the page footer

2021-09-08 Thread Daniel P . Berrangé
The footer is not an effective place to locate frequently needed site navigation links. Some of the links are already present in the top navigation bar, while others are just one jump away on the subsequent page in a fairly obvious place. This removes all the local site navigation links from the

Re: [PATCH RFC server v2 03/11] vfio-user: instantiate vfio-user context

2021-09-08 Thread Stefan Hajnoczi
On Fri, Aug 27, 2021 at 01:53:22PM -0400, Jagannathan Raman wrote: > create a context with the vfio-user library to run a PCI device > > Signed-off-by: Elena Ufimtseva > Signed-off-by: John G Johnson > Signed-off-by: Jagannathan Raman > --- > hw/remote/vfio-user-obj.c | 29

[qemu-web PATCH 2/6] Simplify copyright and integrate into footer

2021-09-08 Thread Daniel P . Berrangé
The copyright information is at the base of the page so logically part of the page footer structure. Signed-off-by: Daniel P. Berrangé --- _includes/copyright.html| 8 _includes/footer.html | 3 +++ _layouts/blog.html | 1 - _layouts/home.html | 1 -

Re: [PATCH RFC server v2 02/11] vfio-user: define vfio-user object

2021-09-08 Thread Stefan Hajnoczi
On Fri, Aug 27, 2021 at 01:53:21PM -0400, Jagannathan Raman wrote: > Define vfio-user object which is remote process server for QEMU. Setup > object initialization functions and properties necessary to instantiate > the object > > Signed-off-by: Elena Ufimtseva > Signed-off-by: John G Johnson >

Re: [RFC v3 14/32] scripts/qapi: add QAPISchemaIfCond.rsgen()

2021-09-08 Thread Markus Armbruster
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Generate Rust #[cfg(...)] guards from QAPI 'if' conditions. > > Signed-off-by: Marc-André Lureau > --- > scripts/qapi/common.py | 16 > scripts/qapi/schema.py | 4 > 2 files changed, 20 insertions(+) > >

[qemu-web PATCH 6/6] Add link to "page source" for all pages

2021-09-08 Thread Daniel P . Berrangé
The link takes the user directly to the source markdown file in gitlab. This gives them guidance as to what file should be editted to make changes to the content. The link text is replaced by an icon in normal rendering. Signed-off-by: Daniel P. Berrangé --- _includes/footer.html | 3

[qemu-web PATCH 3/6] Put a full SFC membership blurb in footer of every page

2021-09-08 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- _includes/footer.html | 4 +++- assets/css/style.css | 6 +- index.html| 2 -- 3 files changed, 8 insertions(+), 4 deletions(-) diff --git a/_includes/footer.html b/_includes/footer.html index 6e1b247..411ff55 100644 ---

[qemu-web PATCH 0/6] Small header/footer layout changes

2021-09-08 Thread Daniel P . Berrangé
I previously sent a large series to more fully re-design the website, especially the front page https://lists.gnu.org/archive/html/qemu-devel/2020-10/msg08205.html Paolo had some feedback on that which I want to take into account but playing with CSS / layout always takes me way too long. I

[qemu-web PATCH 4/6] Move wiki link from footer into the header navbar

2021-09-08 Thread Daniel P . Berrangé
The wiki is important enough that it should be presented more prominently in the page header navbar, rather than the footer. Signed-off-by: Daniel P. Berrangé --- _includes/footer.html | 1 - _includes/nav.html| 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PULL 0/1] qemu-openbios queue 20210908

2021-09-08 Thread Peter Maydell
> > are available in the Git repository at: > > git://github.com/mcayland/qemu.git tags/qemu-openbios-20210908 > > for you to fetch changes up to bac97d80cee950a1f68af27dc153c96d701c5d5a: > > Update OpenBIOS images to d657b653 built fro

[qemu-web PATCH 1/6] Compress the two front page headings into one

2021-09-08 Thread Daniel P . Berrangé
The current headings are repetative and waste vertical screen real estate which could hold more useful content. Signed-off-by: Daniel P. Berrangé --- index.html | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/index.html b/index.html index e52868d..ad7624f 100644 ---

Re: [RFC v3 05/32] scripts/qapi: add QAPISchemaVisitor.visit_module_end

2021-09-08 Thread Markus Armbruster
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Used in following patches to generate code after visiting a module. > > Signed-off-by: Marc-André Lureau > --- > scripts/qapi/schema.py | 4 > 1 file changed, 4 insertions(+) > > diff --git a/scripts/qapi/schema.py

Re: [PATCH RFC server v2 01/11] vfio-user: build library

2021-09-08 Thread Stefan Hajnoczi
On Fri, Aug 27, 2021 at 01:53:20PM -0400, Jagannathan Raman wrote: > diff --git a/meson.build b/meson.build > index bf63784..2b2d5c2 100644 > --- a/meson.build > +++ b/meson.build > @@ -1898,6 +1898,34 @@ if get_option('cfi') and slirp_opt == 'system' > + ' Please configure with

Re: [PATCH 0/5] Stop adding HMP-only commands, allow QMP for all

2021-09-08 Thread Ján Tomko
On a Wednesday in 2021, Daniel P. Berrangé wrote: We are still adding HMP commands without any QMP counterparts. This is done because there are a reasonable number of scenarios where the cost of designing a QAPI data type for the command is not justified. This has the downside, however, that we

Re: [PATCH 3/5] target/i386: convert to use format_state instead of dump_state

2021-09-08 Thread Ján Tomko
On a Wednesday in 2021, Daniel P. Berrangé wrote: Signed-off-by: Daniel P. Berrangé --- target/i386/cpu-dump.c | 325 ++--- target/i386/cpu.c | 2 +- target/i386/cpu.h | 2 +- 3 files changed, 174 insertions(+), 155 deletions(-) diff --git

Re: [RFC v3 04/32] glib-compat: add G_SIZEOF_MEMBER

2021-09-08 Thread Markus Armbruster
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > The macro was introduced in 2.64. Let's redefine it, to allow its usage > with older versions and silence the deprecation warning. > > Signed-off-by: Marc-André Lureau > --- > include/glib-compat.h | 7 +++ > 1 file changed,

PING [PATCH v2] accel/tcg/user-exec: Fix read-modify-write of code on s390 hosts

2021-09-08 Thread Ilya Leoshkevich
On Wed, 2021-08-04 at 00:16 +0200, Ilya Leoshkevich wrote: > x86_64 dotnet/runtime uses cmpxchg for code patching. When running it > under s390x qemu-linux user, cpu_signal_handler() does not recognize > this as a write and does not restore PAGE_WRITE cleared by > tb_page_add(), incorrectly

Re: [PATCH] hw/i386/acpi-build: adjust q35 IO addr range for acpi pci hotplug

2021-09-08 Thread Igor Mammedov
On Wed, 8 Sep 2021 12:21:26 +0200 Philippe Mathieu-Daudé wrote: > On 9/8/21 10:43 AM, Igor Mammedov wrote: > > On Wed, 8 Sep 2021 12:51:04 +0530 (IST) > > Ani Sinha wrote: > > > >> On Wed, 8 Sep 2021, Igor Mammedov wrote: > >> > >>> On Wed, 8 Sep 2021 09:41:39 +0530 > >>> Ani Sinha

Re: [RFC v3 03/32] scripts/qapi: teach c_param_type() to return const argument type

2021-09-08 Thread Markus Armbruster
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > The argument isn't owned by the callee, so it better be const. > But a lot of code in QEMU rely on non-const arguments to tweak it (steal > values etc). > > Since Rust types / bindings are derived from the C version, we have to >

Re: [PATCH RFC server v2 00/11] vfio-user server in QEMU

2021-09-08 Thread Jag Raman
> On Sep 8, 2021, at 6:08 AM, Stefan Hajnoczi wrote: > > On Fri, Aug 27, 2021 at 01:53:19PM -0400, Jagannathan Raman wrote: >> Hi, >> >> This series depends on the following series from >> Elena Ufimtseva : >> [PATCH RFC v2 00/16] vfio-user implementation > > Please send future revisions as

Re: arm: Launching EFI-enabled arm32 Linux

2021-09-08 Thread Adam Lackorzynski
Hi Andre, On Wed Sep 08, 2021 at 00:47:10 +0100, Andre Przywara wrote: > On Wed, 8 Sep 2021 01:25:04 +0200 > Adam Lackorzynski wrote: > > Hi Adam, > > > On Mon Sep 06, 2021 at 16:34:03 +0100, Andre Przywara wrote: > > > On Sat, 4 Sep 2021 21:26:45 +0200 > > > Adam Lackorzynski wrote: > > > >

[PULL 12/12] escc: fix STATUS_SYNC bit in R_STATUS register

2021-09-08 Thread Mark Cave-Ayland
After an SDLC "Enter hunt" command has been sent the STATUS_SYNC bit should remain high until the flag byte has been detected. Whilst the ESCC device doesn't yet implement SDLC mode, without this change the active low STATUS_SYNC is constantly asserted causing the MacOS OpenTransport extension

[PULL 10/12] escc: remove register changes from escc_reset_chn()

2021-09-08 Thread Mark Cave-Ayland
Now that register values at reset are handled elsewhere for all of device reset, soft reset and hard reset, escc_reset_chn() only needs to handle initialisation of internal device state. Signed-off-by: Mark Cave-Ayland Reviewed-by: Peter Maydell Message-Id:

Re: [RFC v3 02/32] build-sys: add HAVE_IPPROTO_MPTCP

2021-09-08 Thread Markus Armbruster
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > The QAPI schema shouldn't rely on C system headers #define, but on > configure-time project #define, so we can express the build condition in > a C-independent way. > > Signed-off-by: Marc-André Lureau Reviewed-by: Markus

[PULL 09/12] escc: implement hard reset as described in the datasheet

2021-09-08 Thread Mark Cave-Ayland
The hardware reset differs from a device reset in that it only changes the contents of specific registers. Remove the code that resets all the registers to zero during hardware reset and implement the default values using the existing soft reset code with the additional changes listed in the

[PULL 11/12] escc: re-use escc_reset_chn() for soft reset

2021-09-08 Thread Mark Cave-Ayland
This removes duplication of the internal device state initialisation between device reset and soft reset. Signed-off-by: Mark Cave-Ayland Reviewed-by: Peter Maydell Message-Id: <20210903113223.19551-9-mark.cave-ayl...@ilande.co.uk> Signed-off-by: Mark Cave-Ayland --- hw/char/escc.c | 9

[PULL 06/12] escc: introduce escc_soft_reset_chn() for software reset

2021-09-08 Thread Mark Cave-Ayland
This new software reset function is to be called when the appropriate channel software reset bit is written to register WR9. Its initial implementation is the same as the existing escc_reset_chn() function used for device reset. Add a new trace event when the guest initiates a soft reset via the

[PULL 03/12] sun4m: fix setting CPU id when more than one CPU is present

2021-09-08 Thread Mark Cave-Ayland
Commit 24f675cd3b ("sparc/sun4m: Use start-powered-off CPUState property") changed the sun4m CPU reset code to use the start-powered-off property and so split the creation of the CPU into separate instantiation and realization phases to enable the new start-powered-off property to be set. This

[PULL 08/12] escc: implement soft reset as described in the datasheet

2021-09-08 Thread Mark Cave-Ayland
The software reset differs from a device reset in that it only changes the contents of specific registers. Remove the code that resets all the registers to zero during soft reset and implement the default values listed in the table in the "Z85C30 Reset" section. Signed-off-by: Mark Cave-Ayland

[PULL 07/12] escc: introduce escc_hard_reset_chn() for hardware reset

2021-09-08 Thread Mark Cave-Ayland
This new hardware reset function is to be called for both channels when the hardware reset bit is written to register WR9. Its initial implementation is the same as the existing escc_reset_chn() function used for device reset. Add a new trace event when the guest initiates a hard reset via the

[PULL 04/12] escc: checkpatch fixes

2021-09-08 Thread Mark Cave-Ayland
Also fix a couple of spelling mistakes in comments. Signed-off-by: Mark Cave-Ayland Reviewed-by: Peter Maydell Message-Id: <20210903113223.19551-2-mark.cave-ayl...@ilande.co.uk> Signed-off-by: Mark Cave-Ayland --- hw/char/escc.c | 162 + 1 file

[PULL 05/12] escc: reset register values to zero in escc_reset()

2021-09-08 Thread Mark Cave-Ayland
This is to ensure that a device reset always returns the ESCC to a known state. Note that this is currently redundant with the same code in escc_reset_chn() but that will change shortly. Signed-off-by: Mark Cave-Ayland Reviewed-by: Peter Maydell Message-Id:

[PULL 02/12] tcg: Drop gen_io_end()

2021-09-08 Thread Mark Cave-Ayland
From: Peter Maydell Now we have removed all the uses of gen_io_end() from target frontends, the only callsite is inside gen_tb_start(). Inline the code there, and remove the reference to it from the documentation. While we are inlining the code, switch it to use tcg_constant_i32() so we don't

[PULL 00/12] qemu-sparc queue 20210908

2021-09-08 Thread Mark Cave-Ayland
-sparc-20210908 for you to fetch changes up to 15a2a1a4d1eecc74a87e1552f5cc4e3668375715: escc: fix STATUS_SYNC bit in R_STATUS register (2021-09-08 11:09:45 +0100) qemu-sparc queue

[PULL 01/12] target/sparc: Drop use of gen_io_end()

2021-09-08 Thread Mark Cave-Ayland
From: Peter Maydell The gen_io_end() function is obsolete (as documented in docs/devel/tcg-icount.rst). Where an instruction is an I/O operation, the translator frontend should call gen_io_start() before generating the code which does the I/O, and then end the TB immediately after this insn.

Re: [PATCH RFC v2 14/16] vfio-user: dma read/write operations

2021-09-08 Thread John Levon
On Wed, Sep 08, 2021 at 10:51:11AM +0100, Stefan Hajnoczi wrote: > > + > > +buf = g_malloc0(size); > > +memcpy(buf, msg, sizeof(*msg)); > > + > > +pci_dma_read(pdev, msg->offset, buf + sizeof(*msg), msg->count); > > The vfio-user spec doesn't go into errors but pci_dma_read() can

Re: [PATCH 5/5] monitor: rewrite 'info registers' in terms of 'x-query-registers'

2021-09-08 Thread Daniel P . Berrangé
On Wed, Sep 08, 2021 at 01:01:21PM +0200, Philippe Mathieu-Daudé wrote: > On 9/8/21 12:37 PM, Daniel P. Berrangé wrote: > > Now that we have a QMP command 'x-query-registers', the HMP counterpart > > 'info registers' can be refactored to call the former. > > > > Signed-off-by: Daniel P. Berrangé

Re: [PATCH 5/5] monitor: rewrite 'info registers' in terms of 'x-query-registers'

2021-09-08 Thread Philippe Mathieu-Daudé
On 9/8/21 12:37 PM, Daniel P. Berrangé wrote: > Now that we have a QMP command 'x-query-registers', the HMP counterpart > 'info registers' can be refactored to call the former. > > Signed-off-by: Daniel P. Berrangé > --- > monitor/misc.c | 25 - > 1 file changed, 16

Re: [PATCH] meson: remove dead variable

2021-09-08 Thread Daniel P . Berrangé
On Wed, Sep 08, 2021 at 12:14:16PM +0200, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > ui/meson.build | 2 -- > 1 file changed, 2 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |:

Re: [PATCH] meson: do not use python.full_path() unnecessarily

2021-09-08 Thread Daniel P . Berrangé
On Wed, Sep 08, 2021 at 12:13:32PM +0200, Paolo Bonzini wrote: > The "python" variable is an external program and can be passed > directly to custom_target. This avoids the need to look it up > multiple times, which was previously silent but is now explicit > in recent Meson versions. > >

[PATCH 4/5] qapi: introduce x-query-registers QMP command

2021-09-08 Thread Daniel P . Berrangé
This is a counterpart to the HMP "info registers" command. It is being added with an "x-" prefix because this QMP command is intended as an adhoc debugging tool and will thus not be modelled in QAPI as fully structured data, nor will it have long term guaranteed stability. Signed-off-by: Daniel

Re: [PATCH v1 1/2] Only check CONFIG_NVMM when NEED_CPU_H is defined

2021-09-08 Thread Philippe Mathieu-Daudé
+Thomas On 9/8/21 11:46 AM, Reinoud Zandijk wrote: > On Tue, Sep 07, 2021 at 06:20:33PM +0200, Philippe Mathieu-Daudé wrote: >> On 7/18/21 3:46 PM, Reinoud Zandijk wrote: >>> Userland targers will otherwise use a poisoned CONFIG_NVMM >> >> Typo "targets", but do you mean bsd-user or linux-user? >

Re: [PATCH] meson: remove dead variable

2021-09-08 Thread Philippe Mathieu-Daudé
On 9/8/21 12:14 PM, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > ui/meson.build | 2 -- > 1 file changed, 2 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

[PATCH 3/5] target/i386: convert to use format_state instead of dump_state

2021-09-08 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- target/i386/cpu-dump.c | 325 ++--- target/i386/cpu.c | 2 +- target/i386/cpu.h | 2 +- 3 files changed, 174 insertions(+), 155 deletions(-) diff --git a/target/i386/cpu-dump.c b/target/i386/cpu-dump.c index

Re: [PATCH] meson: do not use python.full_path() unnecessarily

2021-09-08 Thread Philippe Mathieu-Daudé
On 9/8/21 12:13 PM, Paolo Bonzini wrote: > The "python" variable is an external program and can be passed > directly to custom_target. This avoids the need to look it up > multiple times, which was previously silent but is now explicit > in recent Meson versions. > > Signed-off-by: Paolo Bonzini

[PATCH 2/5] hw/core: introduce 'format_state' callback to replace 'dump_state'

2021-09-08 Thread Daniel P . Berrangé
The 'dump_state' callback assumes it will be outputting to a FILE object. This is fine for HMP, but not so useful for QMP. Introduce a new 'format_state' callback that returns a formatted GString instead. Signed-off-by: Daniel P. Berrangé --- hw/core/cpu-common.c | 15 +++

Re: [PATCH] hw/i386/acpi-build: adjust q35 IO addr range for acpi pci hotplug

2021-09-08 Thread Philippe Mathieu-Daudé
On 9/8/21 10:43 AM, Igor Mammedov wrote: > On Wed, 8 Sep 2021 12:51:04 +0530 (IST) > Ani Sinha wrote: > >> On Wed, 8 Sep 2021, Igor Mammedov wrote: >> >>> On Wed, 8 Sep 2021 09:41:39 +0530 >>> Ani Sinha wrote: >>> Change caf108bc58790 ("hw/i386/acpi-build: Add ACPI PCI hot-plug methods

<    1   2   3   4   >