Re: [PATCH] target/ppc, hw/ppc: Change maintainers

2021-11-05 Thread David Gibson
On Fri, Nov 05, 2021 at 05:05:25PM -0300, Daniel Henrique Barboza wrote: > > > On 11/5/21 16:16, Philippe Mathieu-Daudé wrote: > > Hi Daniel, > > > > On 11/5/21 10:48, Daniel Henrique Barboza wrote: > > > On 11/5/21 00:46, David Gibson wrote: > > > > As our day jobs and interests have moved

Re: [PATCH 3/3] hw/input/pckbd: Rename i8042_setup_a20_line() and its a20 irq argument

2021-11-05 Thread wangyanan (Y)
On 2021/11/6 1:21, Philippe Mathieu-Daudé wrote: 'a20_out' is an input IRQ, rename it as 'a20_input'. i8042_setup_a20_line() doesn't take a Device parameter but an ISADevice one. Rename it as i8042_isa_*() to make it explicit. Signed-off-by: Philippe Mathieu-Daudé ---

Re: [PATCH 2/3] hw/qdev: Rename qdev_connect_gpio_out*() 'input_pin' parameter

2021-11-05 Thread wangyanan (Y)
On 2021/11/6 1:21, Philippe Mathieu-Daudé wrote: @pin is an input where we connect a device output. Rename it @input_pin to simplify the documentation. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/qdev-core.h | 8 hw/core/gpio.c | 13 +++-- 2 files

Re: [PATCH 1/3] hw/qdev: Correct qdev_connect_gpio_out_named() documentation

2021-11-05 Thread wangyanan (Y)
Hi Philippe, On 2021/11/6 1:21, Philippe Mathieu-Daudé wrote: qdev_connect_gpio_out_named() is described as qdev_connect_gpio_out(), and referring to itself in an endless loop, which is confusing. Fix. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/qdev-core.h | 5 ++--- 1 file

Re: [PATCH] trace-events,pci: unify trace events format

2021-11-05 Thread wangyanan (Y)
On 2021/11/6 3:25, Laurent Vivier wrote: Unify format used by trace_pci_update_mappings_del(), trace_pci_update_mappings_add(), trace_pci_cfg_write() and trace_pci_cfg_read() to print the device name and bus number, slot number and function number. For instance: pci_cfg_read

Re: [PATCH] docs/about/deprecated: Remove empty 'related binaries' section

2021-11-05 Thread wangyanan (Y)
On 2021/11/5 22:26, Philippe Mathieu-Daudé wrote: Commit 497a30dbb06 ("qemu-img: Require -F with -b backing image") removed the content of the "Related binaries" section but forgot to remove the section title. Since it is now empty, remove it too. Signed-off-by: Philippe Mathieu-Daudé ---

Re: [PATCH] target/ppc, hw/ppc: Change maintainers

2021-11-05 Thread Cédric Le Goater
In term of the MAINTAINERS file: S: Status, one of the following: Supported: Someone is actually paid to look after this. Maintained: Someone actually looks after it. The PPC entries have a 'Maintained' status. You say "IBM will shoulder this responsibility",

Re: [PATCH] s390x: kvm: adjust diag318 resets to retain data

2021-11-05 Thread Collin Walling
On 11/5/21 18:46, Collin Walling wrote: > The CPNC portion of the diag 318 data is erroneously reset during an > initial CPU reset caused by SIGP. Let's go ahead and relocate the > diag318_info field within the CPUS390XState struct such that it is > only zeroed during a clear reset. This way, the

[PATCH] s390x: kvm: adjust diag318 resets to retain data

2021-11-05 Thread Collin Walling
The CPNC portion of the diag 318 data is erroneously reset during an initial CPU reset caused by SIGP. Let's go ahead and relocate the diag318_info field within the CPUS390XState struct such that it is only zeroed during a clear reset. This way, the CPNC will be retained for each VCPU in the

Re: [PATCH] hw/ppc/mac.h: Remove MAX_CPUS macro

2021-11-05 Thread Cédric Le Goater
On 11/5/21 19:42, Peter Maydell wrote: The mac.h header defines a MAX_CPUS macro. This is confusingly named, because it suggests it's a generic setting, but in fact it's used by only the g3beige and mac99 machines. It's also using a single macro for two values which aren't inherently the same --

Re: [PATCH] target/ppc, hw/ppc: Change maintainers

2021-11-05 Thread Daniel Henrique Barboza
On 11/5/21 16:16, Philippe Mathieu-Daudé wrote: Hi Daniel, On 11/5/21 10:48, Daniel Henrique Barboza wrote: On 11/5/21 00:46, David Gibson wrote: As our day jobs and interests have moved onto other things, Greg and I have been struggling to keep on top of maintainership of target/ppc and

Re: [PATCH v4 3/3] qapi: deprecate drive-backup

2021-11-05 Thread Eric Blake
On Thu, Nov 04, 2021 at 09:58:11AM +0100, Markus Armbruster wrote: > From: Vladimir Sementsov-Ogievskiy > > Modern way is using blockdev-add + blockdev-backup, which provides a > lot more control on how target is opened. > > As example of drive-backup problems consider the following: > > User

Re: [PATCH] trace-events,pci: unify trace events format

2021-11-05 Thread Philippe Mathieu-Daudé
On 11/5/21 20:25, Laurent Vivier wrote: > Unify format used by trace_pci_update_mappings_del(), > trace_pci_update_mappings_add(), trace_pci_cfg_write() and > trace_pci_cfg_read() to print the device name and bus number, > slot number and function number. > > For instance: > > pci_cfg_read

[PATCH] trace-events,pci: unify trace events format

2021-11-05 Thread Laurent Vivier
Unify format used by trace_pci_update_mappings_del(), trace_pci_update_mappings_add(), trace_pci_cfg_write() and trace_pci_cfg_read() to print the device name and bus number, slot number and function number. For instance: pci_cfg_read virtio-net-pci 00:0 @0x20 -> 0xc00c pci_cfg_write

Re: [PATCH] target/ppc, hw/ppc: Change maintainers

2021-11-05 Thread Philippe Mathieu-Daudé
Hi Daniel, On 11/5/21 10:48, Daniel Henrique Barboza wrote: > On 11/5/21 00:46, David Gibson wrote: >> As our day jobs and interests have moved onto other things, Greg and I >> have >> been struggling to keep on top of maintainership of target/ppc and >> associated pieces like the pseries and

Re: [PATCH] spapr_numa.c: FORM2 table handle nodes with no distance info

2021-11-05 Thread Daniel Henrique Barboza
On 11/5/21 10:51, Nicholas Piggin wrote: A configuration that specifies multiple nodes without distance info results in the non-local points in the FORM2 matrix having a distance of 0. This causes Linux to complain "Invalid distance value range" because a node distance is smaller than the

Re: [PATCH] hw/ppc/mac.h: Remove MAX_CPUS macro

2021-11-05 Thread Philippe Mathieu-Daudé
On 11/5/21 19:42, Peter Maydell wrote: > The mac.h header defines a MAX_CPUS macro. This is confusingly named, > because it suggests it's a generic setting, but in fact it's used > by only the g3beige and mac99 machines. It's also using a single > macro for two values which aren't inherently the

Re: [PULL 0/6] Egl 20211105 patches

2021-11-05 Thread Philippe Mathieu-Daudé
ing branch 'remotes/bonzini/tags/for-upstream' >>> into staging (2021-11-03 13:07:30 -0400) >>> >>> are available in the Git repository at: >>> >>>    git://git.kraxel.org/qemu tags/egl-20211105-pull-request >>> >>> for you to fe

Re: [PATCH] macfb: fix a memory leak (CID 1465231)

2021-11-05 Thread Peter Maydell
On Fri, 5 Nov 2021 at 18:32, Laurent Vivier wrote: > > Le 05/11/2021 à 18:01, Peter Maydell a écrit : > > On Fri, 5 Nov 2021 at 16:52, Laurent Vivier wrote: > >> > >> Rewrite the function using g_string_append_printf() rather than > >> g_strdup_printf()/g_strconcat(). > >> > >> Fixes:

[PATCH] hw/ppc/mac.h: Remove MAX_CPUS macro

2021-11-05 Thread Peter Maydell
The mac.h header defines a MAX_CPUS macro. This is confusingly named, because it suggests it's a generic setting, but in fact it's used by only the g3beige and mac99 machines. It's also using a single macro for two values which aren't inherently the same -- if one of these two machines was updated

Re: [PATCH] macfb: fix a memory leak (CID 1465231)

2021-11-05 Thread Laurent Vivier
Le 05/11/2021 à 18:01, Peter Maydell a écrit : On Fri, 5 Nov 2021 at 16:52, Laurent Vivier wrote: Rewrite the function using g_string_append_printf() rather than g_strdup_printf()/g_strconcat(). Fixes: df8abbbadf74 ("macfb: add common monitor modes supported by the MacOS toolbox ROM") Cc:

Re: [PATCH 0/3] SEV: fixes for -kernel launch with incompatible OVMF

2021-11-05 Thread Dov Murik
On 02/11/2021 16:48, Brijesh Singh wrote: > > > On 11/2/21 8:22 AM, Dov Murik wrote: >> >> >> On 02/11/2021 12:52, Brijesh Singh wrote: >>> Hi Dov, >>> >>> Overall the patch looks good, only question I have is that now we are >>> enforce qemu to hash the kernel, initrd and cmdline

Re: [PULL 0/6] Egl 20211105 patches

2021-11-05 Thread Philippe Mathieu-Daudé
taging (2021-11-03 13:07:30 -0400) >> >> are available in the Git repository at: >> >>    git://git.kraxel.org/qemu tags/egl-20211105-pull-request >> >> for you to fetch changes up to 1350ff156b25be65c599ecca9957ce6726c6d383: >> >>    ui/gtk-egl: blit

Re: [PULL 00/11] Sphinx patches

2021-11-05 Thread Richard Henderson
On 11/5/21 9:32 AM, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau The following changes since commit 18e356a53a2926a15343b914db64324d63748f25: Merge remote-tracking branch 'remotes/stsquad/tags/pull-for-6.2-041121-2' into staging (2021-11-04 08:33:46 -0400) are available in

Re: [PATCH v4 33/36] bsd-user/arm/target_arch_signal.c: arm set_mcontext

2021-11-05 Thread Warner Losh
On Fri, Nov 5, 2021 at 10:44 AM Richard Henderson < richard.hender...@linaro.org> wrote: > On 11/4/21 11:19 PM, Warner Losh wrote: > > +/* Compare to arm/arm/exec_machdep.c set_mcontext() */ > > +abi_long set_mcontext(CPUARMState *env, target_mcontext_t *mcp, int > srflag) > > +{ > > +int err

[PATCH 1/3] hw/qdev: Correct qdev_connect_gpio_out_named() documentation

2021-11-05 Thread Philippe Mathieu-Daudé
qdev_connect_gpio_out_named() is described as qdev_connect_gpio_out(), and referring to itself in an endless loop, which is confusing. Fix. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/qdev-core.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git

[PATCH 3/3] hw/input/pckbd: Rename i8042_setup_a20_line() and its a20 irq argument

2021-11-05 Thread Philippe Mathieu-Daudé
'a20_out' is an input IRQ, rename it as 'a20_input'. i8042_setup_a20_line() doesn't take a Device parameter but an ISADevice one. Rename it as i8042_isa_*() to make it explicit. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/input/i8042.h | 2 +- hw/i386/pc.c | 2 +-

[PATCH 0/3] hw/qdev: Clarify qdev_connect_gpio_out() documentation

2021-11-05 Thread Philippe Mathieu-Daudé
Trivial patches clarifying qdev_connect_gpio_out() use, basically that the qemu_irq argument is an input. No logical change, only function name / parameter changed. Philippe Mathieu-Daudé (3): hw/qdev: Correct qdev_connect_gpio_out_named() documentation hw/qdev: Rename

[PATCH 2/3] hw/qdev: Rename qdev_connect_gpio_out*() 'input_pin' parameter

2021-11-05 Thread Philippe Mathieu-Daudé
@pin is an input where we connect a device output. Rename it @input_pin to simplify the documentation. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/qdev-core.h | 8 hw/core/gpio.c | 13 +++-- 2 files changed, 11 insertions(+), 10 deletions(-) diff --git

Re: [PATCH 00/31] passage: Define a standard for firmware data flow

2021-11-05 Thread Simon Glass
) to signal Hi François, On Fri, 5 Nov 2021 at 10:31, François Ozog wrote: > > Hi Simon, > > Le ven. 5 nov. 2021 à 17:12, Simon Glass a écrit : >> >> Hi François, >> >> On Fri, 5 Nov 2021 at 02:27, François Ozog wrote: >> > >> > >> > >> > On Fri, 5 Nov 2021 at 03:02, Simon Glass wrote: >> >>

Re: [PULL 0/6] Egl 20211105 patches

2021-11-05 Thread Richard Henderson
/qemu tags/egl-20211105-pull-request for you to fetch changes up to 1350ff156b25be65c599ecca9957ce6726c6d383: ui/gtk-egl: blitting partial guest fb to the proper scanout surface (2021-11-05 12:29:44 +0100) gtk: a collection of egl

Re: [PATCH v4 05/10] target/arm: Advance pc for arch single-step exception

2021-11-05 Thread Peter Maydell
On Wed, 3 Nov 2021 at 04:09, Richard Henderson wrote: > > The size of the code covered by a TranslationBlock cannot be 0; > this is checked via assert in tb_gen_code. > > Signed-off-by: Richard Henderson > --- > target/arm/translate-a64.c | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by:

Re: [PATCH v4 07/10] target/arm: Take an exception if PC is misaligned

2021-11-05 Thread Peter Maydell
On Wed, 3 Nov 2021 at 04:11, Richard Henderson wrote: > > For A64, any input to an indirect branch can cause this. > > For A32, many indirect branch paths force the branch to be aligned, > but BXWritePC does not. This includes the BX instruction but also > other interworking changes to PC.

Re: [PATCH v4 01/10] target/arm: Hoist pc_next to a local variable in aarch64_tr_translate_insn

2021-11-05 Thread Peter Maydell
On Wed, 3 Nov 2021 at 04:04, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/translate-a64.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v4 11/36] bsd-user/x86_64: Move functions into signal.c

2021-11-05 Thread Warner Losh
On Fri, Nov 5, 2021 at 10:25 AM Richard Henderson < richard.hender...@linaro.org> wrote: > On 11/4/21 11:18 PM, Warner Losh wrote: > > Move the current inline functions into sigal.c. This will increate the > > flexibility of implementation in the future. > > > > Signed-off-by: Warner Losh > > ---

Re: [PATCH v4 03/10] target/arm: Hoist pc_next to a local variable in thumb_tr_translate_insn

2021-11-05 Thread Peter Maydell
On Wed, 3 Nov 2021 at 04:04, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) > Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v4 04/10] target/arm: Split arm_pre_translate_insn

2021-11-05 Thread Peter Maydell
On Wed, 3 Nov 2021 at 04:07, Richard Henderson wrote: > > Create arm_check_ss_active and arm_check_kernelpage. > > Reverse the order of the tests. While it doesn't matter in practice, > because only user-only has a kernel page and user-only never sets > ss_active, ss_active has priority over

Re: [PATCH v4 06/10] target/arm: Split compute_fsr_fsc out of arm_deliver_fault

2021-11-05 Thread Peter Maydell
On Wed, 3 Nov 2021 at 04:09, Richard Henderson wrote: > > We will reuse this section of arm_deliver_fault for > raising pc alignment faults. > > Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v4 02/10] target/arm: Hoist pc_next to a local variable in arm_tr_translate_insn

2021-11-05 Thread Peter Maydell
On Wed, 3 Nov 2021 at 04:07, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH] macfb: fix a memory leak (CID 1465231)

2021-11-05 Thread Peter Maydell
On Fri, 5 Nov 2021 at 16:52, Laurent Vivier wrote: > > Rewrite the function using g_string_append_printf() rather than > g_strdup_printf()/g_strconcat(). > > Fixes: df8abbbadf74 ("macfb: add common monitor modes supported by the MacOS > toolbox ROM") > Cc: mark.cave-ayl...@ilande.co.uk >

Re: [PATCH v4 07/36] bsd-user/i386: Move the inlines into signal.c

2021-11-05 Thread Warner Losh
On Fri, Nov 5, 2021 at 10:45 AM Warner Losh wrote: > > > On Fri, Nov 5, 2021 at 10:21 AM Richard Henderson < > richard.hender...@linaro.org> wrote: > >> On 11/4/21 11:18 PM, Warner Losh wrote: >> > +abi_long set_sigtramp_args(CPUX86State *env, int sig, >> > + struct

[PATCH] macfb: fix a memory leak (CID 1465231)

2021-11-05 Thread Laurent Vivier
Rewrite the function using g_string_append_printf() rather than g_strdup_printf()/g_strconcat(). Fixes: df8abbbadf74 ("macfb: add common monitor modes supported by the MacOS toolbox ROM") Cc: mark.cave-ayl...@ilande.co.uk Reported-by: Peter Maydell Suggested-by: Peter Maydell Signed-off-by:

Re: [PATCH v4 35/36] bsd-user/freebsd/target_os_ucontext.h: Require TARGET_*CONTEXT_SIZE

2021-11-05 Thread Richard Henderson
On 11/4/21 11:19 PM, Warner Losh wrote: Now that all architecutres define TARGET_[MU]CONTEXT_SIZE, enforce requiring them and always check the sizeof target_{u,m}context_t sizes. Signed-off-by: Warner Losh --- bsd-user/freebsd/target_os_ucontext.h | 2 -- 1 file changed, 2 deletions(-)

Re: [PATCH v4 07/36] bsd-user/i386: Move the inlines into signal.c

2021-11-05 Thread Warner Losh
On Fri, Nov 5, 2021 at 10:21 AM Richard Henderson < richard.hender...@linaro.org> wrote: > On 11/4/21 11:18 PM, Warner Losh wrote: > > +abi_long set_sigtramp_args(CPUX86State *env, int sig, > > + struct target_sigframe *frame, > > + abi_ulong

Re: [PATCH v4 33/36] bsd-user/arm/target_arch_signal.c: arm set_mcontext

2021-11-05 Thread Richard Henderson
On 11/4/21 11:19 PM, Warner Losh wrote: +/* Compare to arm/arm/exec_machdep.c set_mcontext() */ +abi_long set_mcontext(CPUARMState *env, target_mcontext_t *mcp, int srflag) +{ +int err = 0; +const uint32_t *gr = mcp->__gregs; +uint32_t cpsr, ccpsr = cpsr_read(env); +uint32_t

Re: [PULL 09/13] macfb: add common monitor modes supported by the MacOS toolbox ROM

2021-11-05 Thread Laurent Vivier
Le 05/11/2021 à 16:56, Peter Maydell a écrit : On Fri, 8 Oct 2021 at 12:57, Laurent Vivier wrote: From: Mark Cave-Ayland The monitor modes table is found by experimenting with the Monitors Control Panel in MacOS and analysing the reads/writes. From this it can be found that the mode is

Re: [PATCH v4 32/36] bsd-user/arm/target_arch_signal.c: arm get_mcontext

2021-11-05 Thread Richard Henderson
On 11/4/21 11:19 PM, Warner Losh wrote: Get the machine context from the CPU state. Signed-off-by: Stacey Son Signed-off-by: Kyle Evans Signed-off-by: Warner Losh --- bsd-user/arm/signal.c | 51 +++ bsd-user/arm/target_arch_signal.h | 1 + 2 files

Re: [PATCH 00/31] passage: Define a standard for firmware data flow

2021-11-05 Thread François Ozog
Hi Simon, Le ven. 5 nov. 2021 à 17:12, Simon Glass a écrit : > Hi François, > > On Fri, 5 Nov 2021 at 02:27, François Ozog > wrote: > > > > > > > > On Fri, 5 Nov 2021 at 03:02, Simon Glass wrote: > >> > >> Hi François, > >> > >> On Tue, 2 Nov 2021 at 10:03, François Ozog > wrote: > >> > > >>

Re: [PATCH v4 11/36] bsd-user/x86_64: Move functions into signal.c

2021-11-05 Thread Richard Henderson
On 11/4/21 11:18 PM, Warner Losh wrote: Move the current inline functions into sigal.c. This will increate the flexibility of implementation in the future. Signed-off-by: Warner Losh --- bsd-user/x86_64/signal.c | 56 +++-

Re: [PATCH v4 30/36] bsd-user/arm/target_arch_signal.h: Define size of *context_t

2021-11-05 Thread Richard Henderson
On 11/4/21 11:19 PM, Warner Losh wrote: Define the native sizes of mcontext_t and ucontext_t so that the tests in target_os_ucontext.h ensure the size of arm's version of these structures is correct. Signed-off-by: Warner Losh --- bsd-user/arm/target_arch_signal.h | 3 +++ 1 file changed, 3

Re: [PATCH v4 29/36] bsd-user/arm/target_arch_signal.h: arm machine context and trapframe for signals

2021-11-05 Thread Richard Henderson
On 11/4/21 11:19 PM, Warner Losh wrote: Signed-off-by: Stacey Son Signed-off-by: Kyle Evans Signed-off-by: Warner Losh --- bsd-user/arm/target_arch_signal.h | 28 1 file changed, 28 insertions(+) Reviewed-by: Richard Henderson r~

Re: [PATCH v4 10/36] bsd-user/x86_64/target_arch_signal.h: Fill in mcontext_t

2021-11-05 Thread Richard Henderson
On 11/4/21 11:18 PM, Warner Losh wrote: Fill in target_mcontext match the FreeBSD mcontext_t structure. Also define the size correctly. Signed-off-by: Warner Losh --- bsd-user/x86_64/target_arch_signal.h | 54 1 file changed, 54 insertions(+) Reviewed-by:

Re: [PULL 21/30] target/arm: use official org.gnu.gdb.aarch64.sve layout for registers

2021-11-05 Thread Luis Machado
On 11/5/21 1:15 PM, Alex Bennée wrote: Luis Machado writes: On 11/4/21 6:03 PM, Luis Machado wrote: On 10/4/21 3:44 PM, Luis Machado wrote: Hi, On 9/21/21 10:55 AM, Peter Maydell wrote: On Tue, 19 Jan 2021 at 15:57, Alex Bennée wrote: Claudio Fontana writes: On 1/19/21 3:50 PM,

Re: [PATCH v4 02/36] bsd-user/freebsd: Create common target_os_ucontext.h file

2021-11-05 Thread Richard Henderson
On 11/4/21 11:18 PM, Warner Losh wrote: FreeBSD has a MI ucontext structure that contains the MD mcontext machine state and other things that are machine independent. Create an include file for all the ucontext stuff. It needs to be included in the arch specific files after target_mcontext is

Re: [PATCH v4 07/36] bsd-user/i386: Move the inlines into signal.c

2021-11-05 Thread Richard Henderson
On 11/4/21 11:18 PM, Warner Losh wrote: +abi_long set_sigtramp_args(CPUX86State *env, int sig, + struct target_sigframe *frame, + abi_ulong frame_addr, + struct target_sigaction *ka); +abi_long get_mcontext(CPUX86State

Re: [PATCH v2 1/2] tests/acceptance: introduce new check-avocado tartget

2021-11-05 Thread Philippe Mathieu-Daudé
On 11/5/21 16:53, Willian Rampazzo wrote: > This introduces a new `make` target, `check-avocado`, and adds a > deprecation message about the `check-acceptance` target. This is > a preparation for renaming the `tests/acceptance` folder to > `tests/avocado`. > > The plan is to remove the call to

[PATCH v2 0/2] tests/acceptance: rename tests acceptance to tests avocado

2021-11-05 Thread Willian Rampazzo
In the discussion about renaming the `tests/acceptance` [1], the conclusion was that the folders inside `tests` are related to the framework running the tests and not directly related to the type of the tests. This changes the folder to `tests/avocado` and adjusts the MAKEFILE, the CI related

Re: [PATCH v4 06/36] bsd-user/i386/target_arch_signal.h: Update mcontext_t to match FreeBSD

2021-11-05 Thread Richard Henderson
On 11/4/21 11:18 PM, Warner Losh wrote: Fill in target_mcontext_t to match the FreeBSD mcontex_t. Also tag the current size of mcontext and ucontext to enable size checking for i386. Signed-off-by: Warner Losh --- bsd-user/i386/target_arch_signal.h | 46 ++ 1 file

Re: [PULL 01/26] linux-user: Add infrastructure for a signal trampoline page

2021-11-05 Thread Peter Maydell
On Mon, 4 Oct 2021 at 08:44, Laurent Vivier wrote: > > From: Richard Henderson > > Allocate a page to hold the signal trampoline(s). > Invoke a guest-specific hook to fill in the contents > of the page before marking it read-execute again. Hi; Coverity complains here about a missing error check

Re: [PULL 21/30] target/arm: use official org.gnu.gdb.aarch64.sve layout for registers

2021-11-05 Thread Alex Bennée
Luis Machado writes: > On 11/4/21 6:03 PM, Luis Machado wrote: >> On 10/4/21 3:44 PM, Luis Machado wrote: >>> Hi, >>> >>> On 9/21/21 10:55 AM, Peter Maydell wrote: On Tue, 19 Jan 2021 at 15:57, Alex Bennée wrote: > > > Claudio Fontana writes: > >> On 1/19/21

Re: Artificially target-dependend compiles

2021-11-05 Thread Paolo Bonzini
On 11/5/21 14:45, Markus Armbruster wrote: Moving these definitions to machine-target.json moves the generated C from qapi/qapi-*-machine.[ch] to qapi/qapi-*-machine-target.[ch], where CONFIG_ACPI_VMGENID is okay. It also makes qmp_query_vm_generation_id() target-dependent: it needs

Re: [PATCH 00/31] passage: Define a standard for firmware data flow

2021-11-05 Thread Simon Glass
Hi François, On Fri, 5 Nov 2021 at 02:27, François Ozog wrote: > > > > On Fri, 5 Nov 2021 at 03:02, Simon Glass wrote: >> >> Hi François, >> >> On Tue, 2 Nov 2021 at 10:03, François Ozog wrote: >> > >> > Hi Simon, >> > >> > On Tue, 2 Nov 2021 at 15:59, Simon Glass wrote: >> >> >> >> Hi

Re: [PATCH v4 03/36] bsd-user: create a per-arch signal.c file

2021-11-05 Thread Richard Henderson
On 11/4/21 11:18 PM, Warner Losh wrote: Create a place-holder signal.c file for each of the architectures that are currently built. In the future, some code that's currently inlined in target_arch_signal.h will live here. Signed-off-by: Warner Losh --- bsd-user/i386/signal.c | 1 +

Re: [PATCH v4 01/36] bsd-user/mips*: Remove

2021-11-05 Thread Warner Losh
On Fri, Nov 5, 2021 at 9:52 AM Richard Henderson < richard.hender...@linaro.org> wrote: > On 11/4/21 11:18 PM, Warner Losh wrote: > > FreeBSD has dropped support for mips starting with FreeBSD 14. mips > > support has been removed from the bsd-user fork because updating it for > > new signal

Re: [PULL 03/10] microvm: add device tree support.

2021-11-05 Thread Peter Maydell
On Tue, 2 Nov 2021 at 16:48, Gerd Hoffmann wrote: > > Allows edk2 detect virtio-mmio devices and pcie ecam. > See comment in hw/i386/microvm-dt.c for more details. > > Signed-off-by: Gerd Hoffmann > Reviewed-by: Sergio Lopez > Message-Id: <20211014193617.2475578-1-kra...@redhat.com> Hi;

Re: [PATCH] docs/about/deprecated: Remove empty 'related binaries' section

2021-11-05 Thread Willian Rampazzo
On Fri, Nov 5, 2021 at 11:31 AM Philippe Mathieu-Daudé wrote: > > Commit 497a30dbb06 ("qemu-img: Require -F with -b backing image") > removed the content of the "Related binaries" section but forgot > to remove the section title. Since it is now empty, remove it too. > > Signed-off-by: Philippe

Re: FW: New Defects reported by Coverity Scan for QEMU

2021-11-05 Thread Paolo Bonzini
On 11/5/21 16:31, Peter Maydell wrote: The loop nest in question is (the index must be < 128) for (int offset = 1; offset < 128; offset <<= 1) { for (int k = 0; k < 128; k++) { if (!(k & offset)) { swap(vector1.ub[k], vector0.ub[k + offset]);

Re: [PULL 09/13] macfb: add common monitor modes supported by the MacOS toolbox ROM

2021-11-05 Thread Peter Maydell
On Fri, 8 Oct 2021 at 12:57, Laurent Vivier wrote: > > From: Mark Cave-Ayland > > The monitor modes table is found by experimenting with the Monitors Control > Panel in MacOS and analysing the reads/writes. From this it can be found that > the mode is controlled by writes to the DAFB_MODE_CTRL1

Re: [PATCH v4 01/36] bsd-user/mips*: Remove

2021-11-05 Thread Kyle Evans
On Fri, Nov 5, 2021 at 10:52 AM Richard Henderson wrote: > > On 11/4/21 11:18 PM, Warner Losh wrote: > > FreeBSD has dropped support for mips starting with FreeBSD 14. mips > > support has been removed from the bsd-user fork because updating it for > > new signal requirements. Remove it here

[PATCH v2 2/2] tests/acceptance: rename tests acceptance to tests avocado

2021-11-05 Thread Willian Rampazzo
In the discussion about renaming the `tests/acceptance` [1], the conclusion was that the folders inside `tests` are related to the framework running the tests and not directly related to the type of the tests. This changes the folder to `tests/avocado` and adjusts the MAKEFILE, the CI related

Re: [PATCH v4 01/36] bsd-user/mips*: Remove

2021-11-05 Thread Richard Henderson
On 11/4/21 11:18 PM, Warner Losh wrote: FreeBSD has dropped support for mips starting with FreeBSD 14. mips support has been removed from the bsd-user fork because updating it for new signal requirements. Remove it here since it is a distraction. Signed-off-by: Warner Losh ---

[PATCH v2 1/2] tests/acceptance: introduce new check-avocado tartget

2021-11-05 Thread Willian Rampazzo
This introduces a new `make` target, `check-avocado`, and adds a deprecation message about the `check-acceptance` target. This is a preparation for renaming the `tests/acceptance` folder to `tests/avocado`. The plan is to remove the call to the `check-avocado` target one or two months after the

Re: [PATCH] hw/arm/virt: Allow additions to the generated device tree

2021-11-05 Thread François Ozog
Hi, On Wed, 3 Nov 2021 at 14:17, François Ozog wrote: > Hi, > > Thanks Alex to patch me in. > > I'd like to present another perspective on the motivation as I can't > really comment on the actual "how". > > On real Arm boards, firmware is often assembled into a FIP. > That FIP can contain quite

Re: [PATCH 0/7] block: Attempt on fixing 030-reported errors

2021-11-05 Thread Kevin Wolf
Am 04.11.2021 um 11:38 hat Hanna Reitz geschrieben: > Hanna Reitz (7): > stream: Traverse graph after modification > block: Manipulate children list in .attach/.detach > block: Unite remove_empty_child and child_free > block: Drop detached child from ignore list > block: Pass BdrvChild

Re: Pre-built binaries

2021-11-05 Thread Peter Maydell
On Fri, 5 Nov 2021 at 15:24, House, Michael via wrote: > I’ve been working with QEMU a bit and I haven’t been able to find > pre-built binaries for different platforms. Does Xilinx maintain > releases, or should I build it from source for my platform? Hi! This is the mailing list for the

Re: [PATCH 6/7] block: Let replace_child_noperm free children

2021-11-05 Thread Kevin Wolf
Am 04.11.2021 um 11:38 hat Hanna Reitz geschrieben: > In most of the block layer, especially when traversing down from other > BlockDriverStates, we assume that BdrvChild.bs can never be NULL. When > it becomes NULL, it is expected that the corresponding BdrvChild pointer > also becomes NULL and

Re: [PULL 0/2] Net patches

2021-11-05 Thread Richard Henderson
On 11/5/21 12:17 AM, Jason Wang wrote: The following changes since commit 18e356a53a2926a15343b914db64324d63748f25: Merge remote-tracking branch 'remotes/stsquad/tags/pull-for-6.2-041121-2' into staging (2021-11-04 08:33:46 -0400) are available in the git repository at:

RE: FW: New Defects reported by Coverity Scan for QEMU

2021-11-05 Thread Taylor Simpson
> -Original Message- > From: Peter Maydell > Sent: Friday, November 5, 2021 10:31 AM > To: Taylor Simpson > Cc: qemu-devel@nongnu.org; Richard Henderson > ; Philippe Mathieu-Daudé > > Subject: Re: FW: New Defects reported by Coverity Scan for QEMU > > On Thu, 4 Nov 2021 at 22:34,

Re: FW: New Defects reported by Coverity Scan for QEMU

2021-11-05 Thread Peter Maydell
On Thu, 4 Nov 2021 at 22:34, Taylor Simpson wrote: > > Coverity is getting confused here. The index can never actually overflow. > Does Coverity have a pragma or something to tell it it's OK? > > The loop nest in question is (the index must be < 128) > for (int offset = 1; offset < 128;

Pre-built binaries

2021-11-05 Thread House, Michael
Hello, I've been working with QEMU a bit and I haven't been able to find pre-built binaries for different platforms. Does Xilinx maintain releases, or should I build it from source for my platform? Thanks! Michael House Embedded Software Engineer DESE Research, Inc. Cell: (256) 348 5997

Re: [PATCH 5/7] block: Pass BdrvChild ** to replace_child_noperm

2021-11-05 Thread Kevin Wolf
Am 04.11.2021 um 11:38 hat Hanna Reitz geschrieben: > bdrv_replace_child_noperm() modifies BdrvChild.bs, and can potentially > set it to NULL. That is dangerous, because BDS parents generally assume > that their children's .bs pointer is never NULL. We therefore want to > let

[PATCH v6 6/6] tests/acceptance: Rename avocado_qemu.Test -> QemuSystemTest

2021-11-05 Thread Philippe Mathieu-Daudé
To run user-mode emulation tests, we introduced the avocado_qemu.QemuUserTest which inherits from avocado_qemu.QemuBaseTest. System-mode emulation tests are based on the avocado_qemu.Test class, which also inherits avocado_qemu.QemuBaseTest. To avoid confusion, rename it as

[PATCH v6 1/6] tests/acceptance: Extract QemuBaseTest from Test

2021-11-05 Thread Philippe Mathieu-Daudé
The Avocado Test::fetch_asset() is handy to download artifacts before running tests. The current class is named Test but only tests system emulation. As we want to test user emulation, refactor the common code as QemuBaseTest. Reviewed-by: Willian Rampazzo Signed-off-by: Philippe Mathieu-Daudé

[PATCH v6 2/6] tests/acceptance: Make pick_default_qemu_bin() more generic

2021-11-05 Thread Philippe Mathieu-Daudé
Make pick_default_qemu_bin() generic to find qemu-system or qemu-user binaries. Reviewed-by: Willian Rampazzo Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20211102084232.2965062-3-f4...@amsat.org> --- tests/avocado/avocado_qemu/__init__.py | 10 +- 1 file changed, 5

[PATCH v6 5/6] tests/acceptance: Add bFLT loader linux-user test

2021-11-05 Thread Philippe Mathieu-Daudé
Add a very quick test that runs a busybox binary in bFLT format: $ AVOCADO_ALLOW_UNTRUSTED_CODE=1 \ avocado --show=app run -t linux_user tests/acceptance/load_bflt.py JOB ID : db94d5960ce564c50904d666a7e259148c27e88f JOB LOG:

[PATCH v6 4/6] tests/acceptance: Share useful helpers from virtiofs_submounts test

2021-11-05 Thread Philippe Mathieu-Daudé
Move the useful has_cmd()/has_cmds() helpers from the virtiofs test to the avocado_qemu public class. Reviewed-by: Wainer dos Santos Moschetta Reviewed-by: Willian Rampazzo Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20211102084232.2965062-5-f4...@amsat.org> ---

[PATCH v6 3/6] tests/acceptance: Introduce QemuUserTest base class

2021-11-05 Thread Philippe Mathieu-Daudé
Similarly to the 'System' Test base class with methods for testing system emulation, the QemuUserTest class contains methods useful to test user-mode emulation. Reviewed-by: Wainer dos Santos Moschetta Reviewed-by: Willian Rampazzo Signed-off-by: Philippe Mathieu-Daudé Message-Id:

[PATCH v6 0/6] tests/acceptance: Add bFLT loader linux-user test

2021-11-05 Thread Philippe Mathieu-Daudé
Since v5: - rebased on Willian's "rename tests acceptance to tests avocado" [*] Since v4: - rebased - addressed Willian review comments Since v3: - rebased - addressed Wainer review comments from v2 - rename avocado_qemu.Test -> QemuSystemTest Since v2: - rebased

[PATCH] docs/about/deprecated: Remove empty 'related binaries' section

2021-11-05 Thread Philippe Mathieu-Daudé
Commit 497a30dbb06 ("qemu-img: Require -F with -b backing image") removed the content of the "Related binaries" section but forgot to remove the section title. Since it is now empty, remove it too. Signed-off-by: Philippe Mathieu-Daudé --- docs/about/deprecated.rst | 3 --- 1 file changed, 3

Re: [PATCH 12/15] hw/nvme: Initialize capability structures for primary/secondary controllers

2021-11-05 Thread Łukasz Gieryk
On Fri, Nov 05, 2021 at 09:46:28AM +0100, Łukasz Gieryk wrote: > On Thu, Nov 04, 2021 at 04:48:43PM +0100, Łukasz Gieryk wrote: > > On Wed, Nov 03, 2021 at 01:07:31PM +0100, Klaus Jensen wrote: > > > On Oct 7 18:24, Lukasz Maniak wrote: > > > > From: Łukasz Gieryk > > > > > > > > With two new

Re: [PATCH] target/ppc, hw/ppc: Change maintainers

2021-11-05 Thread Cédric Le Goater
On 11/5/21 04:46, David Gibson wrote: As our day jobs and interests have moved onto other things, Greg and I have been struggling to keep on top of maintainership of target/ppc and associated pieces like the pseries and powernv machine types, with their platform specific devices. We've

Re: [RFC PATCH 00/12] QOM/QAPI integration part 1

2021-11-05 Thread Kevin Wolf
Am 04.11.2021 um 16:52 hat Damien Hedde geschrieben: > On 11/4/21 10:07, Kevin Wolf wrote: > > Am 03.11.2021 um 22:26 hat Paolo Bonzini geschrieben: > > > On 11/3/21 18:29, Kevin Wolf wrote: > > > > This series adds QOM class definitions to the QAPI schema, introduces > > > > a new

[PATCH] spapr_numa.c: FORM2 table handle nodes with no distance info

2021-11-05 Thread Nicholas Piggin
A configuration that specifies multiple nodes without distance info results in the non-local points in the FORM2 matrix having a distance of 0. This causes Linux to complain "Invalid distance value range" because a node distance is smaller than the local distance. Fix this by building a simple

Re: [PATCH v3 03/12] vfio-user: define vfio-user-server object

2021-11-05 Thread Peter Krempa
On Fri, Nov 05, 2021 at 14:19:34 +0100, Kevin Wolf wrote: > Am 05.11.2021 um 11:08 hat Markus Armbruster geschrieben: > > Kevin Wolf writes: > > > > > Am 04.11.2021 um 13:13 hat Markus Armbruster geschrieben: [...] > We can deprecate on two different levels. I think it's useful to do > both: >

Re: [PATCH] docs: adjust for demise of scripts/create_config

2021-11-05 Thread Markus Armbruster
Paolo Bonzini writes: > The config-host.h, $TARGET-NAME/config-target.h, > $TARGET-NAME/config-devices.h files > are now generated by configure_file() rather than scripts/create_config. > Adjust > the relevant paragraph in docs/devel/build-system.rst, and take the occasion > to > fix a

Artificially target-dependend compiles

2021-11-05 Thread Markus Armbruster
Some .c need to be compiled per target. build-system.rst calls these target-dependent. Consider hw/acpi/vmgenid.c. hw/acpi/meson.build has acpi_ss.add(when: 'CONFIG_ACPI_VMGENID', if_true: files('vmgenid.c')) and softmmu_ss.add_all(when: 'CONFIG_ACPI', if_true: acpi_ss) softmmu_ss

[PULL 09/11] docs: remove non-reference uses of single backticks

2021-11-05 Thread marcandre . lureau
From: John Snow The single backtick markup in ReST is the "default role". Currently, Sphinx's default role is called "content". Sphinx suggests you can use the "Any" role instead to turn any single-backtick enclosed item into a cross-reference. This is useful for things like autodoc for Python

[PULL 11/11] docs/sphinx: change default role to "any"

2021-11-05 Thread marcandre . lureau
From: John Snow This interprets single-backtick syntax in all of our Sphinx docs as a cross-reference to *something*, including Python symbols. >From here on out, new uses of `backticks` will cause a build failure if the target cannot be referenced. Signed-off-by: John Snow Reviewed-by:

[PULL 08/11] docs/sphinx: add 's' keyboard binding to focus search

2021-11-05 Thread marcandre . lureau
From: Marc-André Lureau This is pretty ubiquitous. ('/' is already taken by some browsers for quick search) Signed-off-by: Marc-André Lureau Reviewed-by: John Snow Reviewed-by: Paolo Bonzini --- docs/conf.py | 4 docs/sphinx-static/custom.js | 9 + 2 files

Re: [PULL 21/30] target/arm: use official org.gnu.gdb.aarch64.sve layout for registers

2021-11-05 Thread Luis Machado
On 11/4/21 6:03 PM, Luis Machado wrote: On 10/4/21 3:44 PM, Luis Machado wrote: Hi, On 9/21/21 10:55 AM, Peter Maydell wrote: On Tue, 19 Jan 2021 at 15:57, Alex Bennée wrote: Claudio Fontana writes: On 1/19/21 3:50 PM, Alex Bennée wrote: Claudio Fontana writes: qemu-system-aarch64:

  1   2   >