Re: [PATCH 2/3] virtio-net: Only enable userland vq if using tap backend

2021-11-17 Thread Eugenio Perez Martin
On Thu, Nov 18, 2021 at 6:06 AM Jason Wang wrote: > > On Thu, Nov 18, 2021 at 3:29 AM Eugenio Pérez wrote: > > > > Qemu falls back on userland handlers even if vhost-user and vhost-vdpa > > cases. These assumes a tap device can handle the packets. > > > > If a vdpa device fail to start, it can

Re: [qemu-web PATCH] update links to the SubmitAPatch wiki page

2021-11-17 Thread Thomas Huth
On 18/11/2021 08.47, Paolo Bonzini wrote: The page is now part of the documentation, but it also has a redirect in the qemu.org web server to provide a stable URL. Use it instead of linking out to wiki.qemu.org. Signed-off-by: Paolo Bonzini --- CONTRIBUTING.md| 2 +-

Re: [qemu-web PATCH] remove deployment phase from CI

2021-11-17 Thread Thomas Huth
On 18/11/2021 08.47, Paolo Bonzini wrote: qemu.org is now served via a reverse proxy from qemu-project.gitlab.io; it does not need anymore the rsync step to the QEMU project's shell server. Remove it from the CI. Signed-off-by: Paolo Bonzini --- .gitlab-ci.yml | 24

[qemu-web PATCH] remove deployment phase from CI

2021-11-17 Thread Paolo Bonzini
qemu.org is now served via a reverse proxy from qemu-project.gitlab.io; it does not need anymore the rsync step to the QEMU project's shell server. Remove it from the CI. Signed-off-by: Paolo Bonzini --- .gitlab-ci.yml | 24 1 file changed, 24 deletions(-) diff --git

[qemu-web PATCH] update links to the SubmitAPatch wiki page

2021-11-17 Thread Paolo Bonzini
The page is now part of the documentation, but it also has a redirect in the qemu.org web server to provide a stable URL. Use it instead of linking out to wiki.qemu.org. Signed-off-by: Paolo Bonzini --- CONTRIBUTING.md| 2 +- contribute.md | 2 +-

Re: [PATCH v2 03/13] hw/arm/npcm7xx_boards: Replace drive_get_next() by drive_get()

2021-11-17 Thread Markus Armbruster
Havard Skinnemoen writes: > On Wed, Nov 17, 2021 at 8:34 AM Markus Armbruster wrote: >> >> drive_get_next() is basically a bad idea. It returns the "next" block >> backend of a certain interface type. "Next" means bus=0,unit=N, where >> subsequent calls count N up from zero, per interface

Re: [PATCH] docs/COLO-FT.txt: Drop deprecated 'props' from object-add in COLO docs

2021-11-17 Thread Markus Armbruster
"Rao, Lei" writes: > From: "Rao, Lei" > > With the removal of deprecated 'props' from object-add in the commit of > "50243407457a9fb0ed17b9a9ba9fc9aee09495b1", we also should update COLO's > documents. We should've done this right when we deprecated it. Not your fault, and better late than

Re: [PULL 0/5] Python patches

2021-11-17 Thread Gerd Hoffmann
Hi, > - Split python/qemu/qmp out into its own repository and begin uploading it > to PyPI, as a test. (Do not delete python/qemu/qmp yet at this phase.) I think you can do that as two separate steps. pip can install from vcs too, i.e. when splitted to a separate repo but not yet uploaded to

[PATCH v1 3/3] cpus-common: implement dirty restraint on vCPU

2021-11-17 Thread huangy81
From: Hyman Huang(黄勇) implement dirtyrate calculation periodically basing on dirty-ring and throttle vCPU until it reachs the quota dirtyrate given by user. introduce qmp commands dirty-restraint/dirty-restraint-cancel to impose/cancel dirty restraint on vCPU Signed-off-by: Hyman Huang(黄勇)

[PATCH v1 0/3] support dirty restraint on vCPU

2021-11-17 Thread huangy81
From: Hyman Huang(黄勇) this patchset introduce a mechanism to impose dirty restraint on vCPU, aiming to keep the vCPU running in a certain dirtyrate given by user. dirty restraint on vCPU maybe an alternative method to implement convergence logic for live migration, which could improve guest

[PATCH v1 1/3] migration/dirtyrate: implement vCPU dirtyrate calculation periodically

2021-11-17 Thread huangy81
From: Hyman Huang(黄勇) introduce the third method GLOBAL_DIRTY_RESTRAINT of dirty tracking for calculate dirtyrate periodly for dirty restraint. implement thread for calculate dirtyrate periodly, which will be used for dirty restraint. add dirtyrestraint.h to introduce the util function for

[PATCH v1 2/3] cpu-throttle: implement vCPU throttle

2021-11-17 Thread huangy81
From: Hyman Huang(黄勇) implement dirty restraint by kicking each vcpu as the auto-converge does during migration, but just kick the specified vcpu instead, not all the vcpu of vm. start a thread to track the dirty restraint status and adjuct the throttle pencentage dynamically depend on current

RE: [PATCH] docs/block-replication.txt: Fix replication top-id command demo

2021-11-17 Thread Zhang, Chen
Ping... and add more people. The original demo can't boot block-replication with COLO. Thanks Chen > -Original Message- > From: Zhang, Chen > Sent: Monday, October 18, 2021 4:51 PM > To: Xie Changlong ; Wen Congyang > ; qemu-triv...@nongnu.org > Cc: Zhang, Chen ; qemu-dev

Re: [PATCH v6 01/10] target/ppc: introduce PMUEventType and PMU overflow timers

2021-11-17 Thread David Gibson
On Sat, Nov 13, 2021 at 04:02:02PM -0300, Daniel Henrique Barboza wrote: > > > On 11/12/21 00:02, David Gibson wrote: > > On Mon, Nov 08, 2021 at 07:50:38PM -0300, Daniel Henrique Barboza wrote: > > > This patch starts an IBM Power8+ compatible PMU implementation by adding > > > the

RE: [PATCH] docs/COLO-FT.txt: Drop deprecated 'props' from object-add in COLO docs

2021-11-17 Thread Zhang, Chen
> -Original Message- > From: Rao, Lei > Sent: Thursday, November 18, 2021 12:17 PM > To: Zhang, Chen ; > zhang.zhanghaili...@huawei.com; quint...@redhat.com; > dgilb...@redhat.com > Cc: qemu-triv...@nongnu.org; qemu-devel@nongnu.org; Rao, Lei > > Subject: [PATCH] docs/COLO-FT.txt:

Re: [PATCH 2/3] virtio-net: Only enable userland vq if using tap backend

2021-11-17 Thread Jason Wang
On Thu, Nov 18, 2021 at 3:29 AM Eugenio Pérez wrote: > > Qemu falls back on userland handlers even if vhost-user and vhost-vdpa > cases. These assumes a tap device can handle the packets. > > If a vdpa device fail to start, it can trigger a sigsegv because of > that. Do not resort on them unless

[PATCH] docs/COLO-FT.txt: Drop deprecated 'props' from object-add in COLO docs

2021-11-17 Thread Rao, Lei
From: "Rao, Lei" With the removal of deprecated 'props' from object-add in the commit of "50243407457a9fb0ed17b9a9ba9fc9aee09495b1", we also should update COLO's documents. Signed-off-by: Lei Rao --- docs/COLO-FT.txt | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff

[PATCH 2/2] net/colo-compare.c: Fix incorrect return when input wrong size

2021-11-17 Thread Zhang Chen
Signed-off-by: Zhang Chen --- net/colo-compare.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/colo-compare.c b/net/colo-compare.c index 1225f40e41..b966e7e514 100644 --- a/net/colo-compare.c +++ b/net/colo-compare.c @@ -807,7 +807,7 @@ static int

[PATCH 1/2] net/colo-compare.c: Fix ACK track reverse issue

2021-11-17 Thread Zhang Chen
The TCP protocol ACK maybe bigger than uint32_t MAX. At this time, the ACK will reverse to 0. This patch fix the max_ack and min_ack track issue. Signed-off-by: Zhang Chen --- net/colo-compare.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/net/colo-compare.c

Re: [PATCH v10 04/26] target/loongarch: Add fixed point arithmetic instruction translation

2021-11-17 Thread gaosong
Hi Richard, On 2021/11/17 下午5:55, Richard Henderson wrote: @fmt_rr_i12 and @fmt_rr_ui12 are two 'Formats',  but they use the same 'Argument sets'(rr_i). What I meant is that there would be a single gen_rr_i function handing the argument set rr_i; no need for two gen_rr_i* functions. Got

RE: [PATCH 1/2] block:hdev: support BLKSECDISCARD

2021-11-17 Thread Qi, Yadong
> What is the use case for exposing secure erase in qemu? The whole concept for > a LBA based secure erase is generally not a very smart idea for flash based > media.. Hi, Christoph We got a user requirement: support BLKSECDISCARD in VM. Which is: ioctl(BLKSECDISCARD) in guest -> qemu backend

Re: [PATCH] docs: Introducing pseries documentation.

2021-11-17 Thread David Gibson
On Wed, Nov 17, 2021 at 05:14:30PM -0300, lagar...@linux.ibm.com wrote: > From: Leonardo Garcia > > The purpose of this document is to substitute the content currently > available in the QEMU wiki at [0]. This initial version does contain > some additional content as well. Whenever this

Re: [PATCH for-6.2] Fix some typos in documentation (found by codespell)

2021-11-17 Thread Philippe Mathieu-Daudé
On 11/17/21 22:07, Stefan Weil wrote: > Signed-off-by: Stefan Weil > --- > docs/devel/multi-process.rst| 2 +- > docs/devel/qgraph.rst | 2 +- > docs/devel/writing-monitor-commands.rst | 2 +- > docs/hyperv.txt | 2 +- >

[PATCH-for-6.2 v2 1/2] hw/block/fdc: Kludge missing floppy drive to fix CVE-2021-20196

2021-11-17 Thread Philippe Mathieu-Daudé
Guest might select another drive on the bus by setting the DRIVE_SEL bit of the DIGITAL OUTPUT REGISTER (DOR). The current controller model doesn't expect a BlockBackend to be NULL. A simple way to fix CVE-2021-20196 is to create an empty BlockBackend when it is missing. All further accesses will

[PATCH-for-6.2 v2 2/2] tests/qtest/fdc-test: Add a regression test for CVE-2021-20196

2021-11-17 Thread Philippe Mathieu-Daudé
From: Alexander Bulekov When running 'make check-qtest-i386' with QEMU configured with '--enable-sanitizers' we get: AddressSanitizer:DEADLYSIGNAL = ==287878==ERROR: AddressSanitizer: SEGV on unknown address 0x0344

[PATCH-for-6.2 v2 0/2] hw/block/fdc: Fix CVE-2021-20196

2021-11-17 Thread Philippe Mathieu-Daudé
I'm not sure what happened to v1 from Prasad, so since we are at rc2 I took a simpler approach to fix this CVE: create an empty drive to satisfy the BlockBackend API calls. Added Alexander's reproducer along. v1: https://lore.kernel.org/qemu-devel/20210123100345.642933-1-ppan...@redhat.com/

Re: Failing QEMU iotests

2021-11-17 Thread John Snow
On Wed, Nov 17, 2021 at 4:33 PM Thomas Huth wrote: > On 17/11/2021 20.59, John Snow wrote: > > > > > > On Wed, Nov 17, 2021 at 2:45 PM Thomas Huth > > wrote: > > > > On 17/11/2021 19.13, John Snow wrote: > > > > > > > > > On Wed, Nov 17, 2021 at 5:07

Re: Failing QEMU iotests

2021-11-17 Thread Thomas Huth
On 17/11/2021 20.59, John Snow wrote: On Wed, Nov 17, 2021 at 2:45 PM Thomas Huth > wrote: On 17/11/2021 19.13, John Snow wrote: > > > On Wed, Nov 17, 2021 at 5:07 AM Thomas Huth mailto:th...@redhat.com> >

[PATCH v2 1/2] qtest/libqos: add a function to initialize secondary PCI buses

2021-11-17 Thread Laurent Vivier
Scan the PCI devices to find bridge and set PCI_SECONDARY_BUS and PCI_SUBORDINATE_BUS (algorithm from seabios) Signed-off-by: Laurent Vivier --- include/hw/pci/pci_bridge.h | 8 +++ tests/qtest/libqos/pci.c| 118 tests/qtest/libqos/pci.h| 1 + 3

[PATCH v2 2/2] tests/qtest: add some tests for virtio-net failover

2021-11-17 Thread Laurent Vivier
Add test cases to test several error cases that must be generated by invalid failover configuration. Add a combination of coldplug and hotplug test cases to be sure the primary is correctly managed according the presence or not of the STANDBY feature. Signed-off-by: Laurent Vivier ---

[PATCH v2 0/2] tests/qtest: add some tests for virtio-net failover

2021-11-17 Thread Laurent Vivier
This series adds a qtest entry to test virtio-net failover feature. We check following error cases: - check missing id on device with failover_pair_id triggers an error - check a primary device plugged on a bus that doesn't support hotplug triggers an error We check the status of the machine

[PATCH for-6.2] Fix some typos in documentation (found by codespell)

2021-11-17 Thread Stefan Weil
Signed-off-by: Stefan Weil --- docs/devel/multi-process.rst| 2 +- docs/devel/qgraph.rst | 2 +- docs/devel/writing-monitor-commands.rst | 2 +- docs/hyperv.txt | 2 +- docs/system/cpu-models-x86.rst.inc | 2 +-

[PATCH v2 for-6.2] meson.build: Support ncurses on MacOS and OpenBSD

2021-11-17 Thread Stefan Weil
MacOS provides header files for curses 5.7 with support for wide characters, but requires _XOPEN_SOURCE_EXTENDED=1 to activate that. By default those old header files are used even if there is a newer Homebrew installation of ncurses 6.2 available. Change also the old macro definition of

Re: [PATCH for-6.2? 2/2] nbd/server: Simplify zero and trim

2021-11-17 Thread Vladimir Sementsov-Ogievskiy
17.11.2021 23:49, Eric Blake wrote: On Wed, Nov 17, 2021 at 09:04:34PM +0300, Vladimir Sementsov-Ogievskiy wrote: 17.11.2021 20:02, Eric Blake wrote: Now that the block layer supports 64-bit operations, we no longer have to self-fragment requests larger than 2G, reverting the workaround added

Re: [PATCH for-6.2] hw/nvme: fix buffer overrun in nvme_changed_nslist (CVE-2021-3947)

2021-11-17 Thread Philippe Mathieu-Daudé
On 11/17/21 14:23, Klaus Jensen wrote: > From: Klaus Jensen > > Fix missing offset verification. > > Cc: qemu-sta...@nongnu.org > Cc: Philippe Mathieu-Daudé > Reported-by: Qiuhao Li > Fixes: f432fdfa121 ("support changed namespace asynchronous event") > Signed-off-by: Klaus Jensen

Re: [PATCH for-6.2? 2/2] nbd/server: Simplify zero and trim

2021-11-17 Thread Eric Blake
On Wed, Nov 17, 2021 at 09:04:34PM +0300, Vladimir Sementsov-Ogievskiy wrote: > 17.11.2021 20:02, Eric Blake wrote: > > Now that the block layer supports 64-bit operations, we no longer have > > to self-fragment requests larger than 2G, reverting the workaround > > added in 890cbccb08 (nbd: Fix

Re: [PATCH v2] Fix typo in comment.

2021-11-17 Thread Philippe Mathieu-Daudé
Hi Leonardo, On 11/17/21 21:26, lagar...@linux.ibm.com wrote: > From: Leonardo Garcia > > Signed-off-by: Leonardo Garcia > Reviewed-by: Laurent Vivier > --- > hw/virtio/vhost.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Better if you prefix the patch subject with

Re: [PATCH for-6.2 1/2] nbd/server: Don't complain on certain client disconnects

2021-11-17 Thread Eric Blake
On Wed, Nov 17, 2021 at 08:57:35PM +0300, Vladimir Sementsov-Ogievskiy wrote: > 17.11.2021 20:02, Eric Blake wrote: > > This patch fixes things to avoid uninitialized memory, and in general > > avoids warning about a client that does a hard shutdown when not in > > the middle of a packet. A

[PATCH v2] Fix typo in comment.

2021-11-17 Thread lagarcia
From: Leonardo Garcia Signed-off-by: Leonardo Garcia Reviewed-by: Laurent Vivier --- hw/virtio/vhost.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c index 437347ad01..20913cf8fb 100644 --- a/hw/virtio/vhost.c +++ b/hw/virtio/vhost.c

[PATCH] docs: Minor updates on the powernv documentation.

2021-11-17 Thread lagarcia
From: Leonardo Garcia Signed-off-by: Leonardo Garcia --- docs/system/ppc/powernv.rst | 56 +++-- 1 file changed, 29 insertions(+), 27 deletions(-) diff --git a/docs/system/ppc/powernv.rst b/docs/system/ppc/powernv.rst index 86186b7d2c..907c4ce4f9 100644 ---

[PATCH] docs: Introducing pseries documentation.

2021-11-17 Thread lagarcia
From: Leonardo Garcia The purpose of this document is to substitute the content currently available in the QEMU wiki at [0]. This initial version does contain some additional content as well. Whenever this documentation gets upstream and is reflected in [1], the QEMU wiki will be edited to point

Re: Failing QEMU iotests

2021-11-17 Thread John Snow
On Wed, Nov 17, 2021 at 2:45 PM Thomas Huth wrote: > On 17/11/2021 19.13, John Snow wrote: > > > > > > On Wed, Nov 17, 2021 at 5:07 AM Thomas Huth > > wrote: > > > > > >Hi! > > > > I think it has been working fine for me a couple of weeks ago, > > but

Re: [PATCH v1] hw/i386/amd_iommu: clean up broken event logging

2021-11-17 Thread Valentin Sinitsyn
Hi, On 17.11.2021 19:46, Daniil Tatianin wrote: - Don't create evt buffer in every function where we want to log, instead make amdvi_log_event construct the buffer in-place using the arguments it was given. - Correctly place address & info in the event buffer. Previously both would

Re: [PATCH v1] hw/i386/amd_iommu: clean up broken event logging

2021-11-17 Thread Valentin Sinitsyn
On 18.11.2021 00:03, Roman Kagan wrote: On Wed, Nov 17, 2021 at 11:13:27PM +0500, Valentin Sinitsyn wrote: On 17.11.2021 19:46, Daniil Tatianin wrote: -/* - * AMDVi event structure - *0:15 -> DeviceID - *55:63 -> event type + miscellaneous info - *63:127 -> related address Did

Re: Failing QEMU iotests

2021-11-17 Thread Thomas Huth
On 17/11/2021 19.13, John Snow wrote: On Wed, Nov 17, 2021 at 5:07 AM Thomas Huth > wrote:   Hi! I think it has been working fine for me a couple of weeks ago, but when I now run:   make check SPEED=slow I'm getting a couple of failing

Re: [PATCH v2 01/13] hw/sd/ssi-sd: Do not create SD card within controller's realize

2021-11-17 Thread Philippe Mathieu-Daudé
Hi Markus, Peter, On 11/17/21 17:33, Markus Armbruster wrote: > ssi_sd_realize() creates an "sd-card" device. This is inappropriate, > and marked FIXME. > > Move it to the boards that create these devices. Prior art: commit > eb4f566bbb for device "generic-sdhci", and commit 26c607b86b for >

Re: [RFC PATCH] plugins/meson.build: fix linker issue with weird paths (for v6.2?)

2021-11-17 Thread Stefan Weil
Am 17.11.21 um 12:19 schrieb Alex Bennée: Signed-off-by: Alex Bennée Fixes: https://gitlab.com/qemu-project/qemu/-/issues/712 --- plugins/meson.build | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Thank you. The fix works for me and looks fine. meson.project_build_root() was

[PATCH 1/3] virtio-net: Fix indentation

2021-11-17 Thread Eugenio Pérez
Signed-off-by: Eugenio Pérez --- hw/net/virtio-net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index f2014d5ea0..004acf858f 100644 --- a/hw/net/virtio-net.c +++ b/hw/net/virtio-net.c @@ -3501,7 +3501,7 @@ static void

[PATCH 3/3] virtio-net: Fix log message

2021-11-17 Thread Eugenio Pérez
The message has never been true in the case of non tap networking, so only tell that userland networking will be used if possible. Signed-off-by: Eugenio Pérez --- hw/net/virtio-net.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/hw/net/virtio-net.c

[PATCH 2/3] virtio-net: Only enable userland vq if using tap backend

2021-11-17 Thread Eugenio Pérez
Qemu falls back on userland handlers even if vhost-user and vhost-vdpa cases. These assumes a tap device can handle the packets. If a vdpa device fail to start, it can trigger a sigsegv because of that. Do not resort on them unless actually possible. Signed-off-by: Eugenio Pérez ---

[PATCH 0/3] virtio-net: Only enable userland vq if using tap backend

2021-11-17 Thread Eugenio Pérez
Qemu falls back on userland handlers even if vhost-user and vhost-vdpa cases. These assumes a tap device can handle the packets. If a vdpa device fail to start, it can trigger a sigsegv because of that. Do not resort on them unless actually possible. Tested with tap backend vhost=on and

Re: [PATCH v2] vfio: Fix memory leak of hostwin

2021-11-17 Thread Alex Williamson
On Wed, 17 Nov 2021 09:47:39 +0800 Peng Liang wrote: > hostwin is allocated and added to hostwin_list in vfio_host_win_add, but > it is only deleted from hostwin_list in vfio_host_win_del, which causes > a memory leak. Also, freeing all elements in hostwin_list is missing in >

[PULL 1/1] vfio: Fix memory leak of hostwin

2021-11-17 Thread Alex Williamson
From: Peng Liang hostwin is allocated and added to hostwin_list in vfio_host_win_add, but it is only deleted from hostwin_list in vfio_host_win_del, which causes a memory leak. Also, freeing all elements in hostwin_list is missing in vfio_disconnect_container. Fix: 2e4109de8e58 ("vfio/spapr:

[PULL 0/1] VFIO fixes 2021-11-17 (for v6.2)

2021-11-17 Thread Alex Williamson
The following changes since commit 3bb87484e77d22cf4e580a78856529c982195d32: Merge tag 'pull-request-2021-11-17' of https://gitlab.com/thuth/qemu into staging (2021-11-17 12:35:51 +0100) are available in the Git repository at: git://github.com/awilliam/qemu-vfio.git

Re: [PULL 0/5] Python patches

2021-11-17 Thread Vladimir Sementsov-Ogievskiy
17.11.2021 22:07, John Snow wrote: On Wed, Nov 17, 2021 at 1:20 PM Vladimir Sementsov-Ogievskiy mailto:vsement...@virtuozzo.com>> wrote: 17.11.2021 20:56, John Snow wrote: > > On Wed, Nov 17, 2021 at 4:42 AM Gerd Hoffmann mailto:kra...@redhat.com>

Re: [PULL 0/5] Python patches

2021-11-17 Thread John Snow
On Wed, Nov 17, 2021 at 1:20 PM Vladimir Sementsov-Ogievskiy < vsement...@virtuozzo.com> wrote: > 17.11.2021 20:56, John Snow wrote: > > > > On Wed, Nov 17, 2021 at 4:42 AM Gerd Hoffmann > wrote: > > > >Hi, > > > > > https://gitlab.com/jsnow/qemu.git < >

Re: [PATCH v1] hw/i386/amd_iommu: clean up broken event logging

2021-11-17 Thread Roman Kagan
On Wed, Nov 17, 2021 at 11:13:27PM +0500, Valentin Sinitsyn wrote: > On 17.11.2021 19:46, Daniil Tatianin wrote: > > -/* > > - * AMDVi event structure > > - *0:15 -> DeviceID > > - *55:63 -> event type + miscellaneous info > > - *63:127 -> related address > Did you mean 64:127?

Re: [PATCH v2] hw/arm/virt: Expose empty NUMA nodes through ACPI

2021-11-17 Thread David Hildenbrand
On 12.11.21 14:27, Igor Mammedov wrote: > On Wed, 10 Nov 2021 12:01:11 +0100 > David Hildenbrand wrote: > >> On 10.11.21 11:33, Igor Mammedov wrote: >>> On Fri, 5 Nov 2021 23:47:37 +1100 >>> Gavin Shan wrote: >>> Hi Drew and Igor, On 11/2/21 6:39 PM, Andrew Jones wrote:

Re: [PULL 0/5] Python patches

2021-11-17 Thread Vladimir Sementsov-Ogievskiy
17.11.2021 20:56, John Snow wrote: On Wed, Nov 17, 2021 at 4:42 AM Gerd Hoffmann mailto:kra...@redhat.com>> wrote:   Hi, > https://gitlab.com/jsnow/qemu.git tags/python-pull-request What is the status of the plan to upload this to pypi

[ANNOUNCE] QEMU 6.2.0-rc1 is now available

2021-11-17 Thread Michael Roth
Hello, On behalf of the QEMU Team, I'd like to announce the availability of the second release candidate for the QEMU 6.2 release. This release is meant for testing purposes and should not be used in a production environment. http://download.qemu-project.org/qemu-6.2.0-rc1.tar.xz

Re: [PATCH for-6.2] tests/tcg/ppc64le: Fix compile flags for byte_reverse

2021-11-17 Thread Richard Henderson
On 11/17/21 7:12 PM, Cédric Le Goater wrote: On 11/17/21 18:33, Richard Henderson wrote: With a host compiler new enough to recognize power10 insns, CROSS_CC_HAS_POWER10 is true, but we do not supply the -cpu option to the compiler, resulting in /tmp/ccAVdYJd.s: Assembler messages:

Re: Failing QEMU iotests

2021-11-17 Thread John Snow
On Wed, Nov 17, 2021 at 5:07 AM Thomas Huth wrote: > > Hi! > > I think it has been working fine for me a couple of weeks ago, > but when I now run: > > make check SPEED=slow > > I'm getting a couple of failing iotests... not sure whether > these are known issues already, so I thought I'd

Re: [PATCH] pmu: fix pmu vmstate subsection list

2021-11-17 Thread Cédric Le Goater
On 11/16/21 16:08, Laurent Vivier wrote: The subsection is not closed by a NULL marker so this can trigger a segfault when the pmu vmstate is saved. This can be easily shown with: $ ./qemu-system-ppc64 -dump-vmstate vmstate.json Segmentation fault (core dumped) Fixes: d811d61fbc6c

Re: [PATCH for-6.2] tests/tcg/ppc64le: Fix compile flags for byte_reverse

2021-11-17 Thread Cédric Le Goater
On 11/17/21 18:33, Richard Henderson wrote: With a host compiler new enough to recognize power10 insns, CROSS_CC_HAS_POWER10 is true, but we do not supply the -cpu option to the compiler, resulting in /tmp/ccAVdYJd.s: Assembler messages: /tmp/ccAVdYJd.s:49: Error: unrecognized opcode: `brh'

Re: [PATCH v2] hw/arm/virt: Expose empty NUMA nodes through ACPI

2021-11-17 Thread David Hildenbrand
On 17.11.21 15:30, Jonathan Cameron wrote: > On Tue, 16 Nov 2021 12:11:29 +0100 > David Hildenbrand wrote: > Examples include exposing HBM or PMEM to the VM. Just like on real HW, this memory is exposed via cpu-less, special nodes. In contrast to real HW, the memory is

Re: Failing QEMU iotests

2021-11-17 Thread John Snow
On Wed, Nov 17, 2021 at 7:50 AM Thomas Huth wrote: > On 17/11/2021 11.59, Hanna Reitz wrote: > > On 17.11.21 11:07, Thomas Huth wrote: > > >> +++ 297.out.bad > >> @@ -1,2 +1,21 @@ > >> === pylint === > >> +* Module image-fleecing > >> +tests/image-fleecing:34:24: C0326: Exactly one

Re: [PATCH for-6.2? 2/2] nbd/server: Simplify zero and trim

2021-11-17 Thread Vladimir Sementsov-Ogievskiy
17.11.2021 20:02, Eric Blake wrote: Now that the block layer supports 64-bit operations, we no longer have to self-fragment requests larger than 2G, reverting the workaround added in 890cbccb08 (nbd: Fix large trim/zero requests). Signed-off-by: Eric Blake Reviewed-by: Vladimir

Re: [PATCH for-6.2 1/2] nbd/server: Don't complain on certain client disconnects

2021-11-17 Thread Vladimir Sementsov-Ogievskiy
17.11.2021 20:02, Eric Blake wrote: When a client disconnects abruptly, but did not have any pending requests (for example, when using nbdsh without calling h.shutdown), we used to output the following message: $ qemu-nbd -f raw file $ nbdsh -u 'nbd://localhost:10809' -c 'h.trim(1,0)' qemu-nbd:

Re: [PULL 0/5] Python patches

2021-11-17 Thread John Snow
On Wed, Nov 17, 2021 at 4:42 AM Gerd Hoffmann wrote: > Hi, > > > https://gitlab.com/jsnow/qemu.git tags/python-pull-request > > What is the status of the plan to upload this to pypi eventually? > > Thanks for asking! The honest answer is "I'm not exactly sure", but there are a few things to

Re: [PATCH v2 03/13] hw/arm/npcm7xx_boards: Replace drive_get_next() by drive_get()

2021-11-17 Thread Hao Wu
Yes, there's SD and MMC buses. It looks like the current code only supports mmc ("soc->mmc.sdhci") but not the sd ("soc->sd.sdhci"). It's probably good to make the bus number a parameter as well and use them to distinguish. We might need a separate patch to do that. On Wed, Nov 17, 2021 at 8:54

[PATCH] linux-user: Add license in files generated by scripts/gensyscalls.sh

2021-11-17 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- scripts/gensyscalls.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/scripts/gensyscalls.sh b/scripts/gensyscalls.sh index 8fb450e3c96..aee5cc64a15 100755 --- a/scripts/gensyscalls.sh +++ b/scripts/gensyscalls.sh @@ -75,7 +75,8 @@

Re: [PATCH] qemu-keymap: Add license in generated files

2021-11-17 Thread Warner Losh
On Wed, Nov 17, 2021 at 10:46 AM Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > qemu-keymap.c | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by: Warner Losh > diff --git a/qemu-keymap.c b/qemu-keymap.c > index 536e8f2385d..4095b654a60 100644 > ---

[PATCH] qemu-keymap: Add license in generated files

2021-11-17 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- qemu-keymap.c | 1 + 1 file changed, 1 insertion(+) diff --git a/qemu-keymap.c b/qemu-keymap.c index 536e8f2385d..4095b654a60 100644 --- a/qemu-keymap.c +++ b/qemu-keymap.c @@ -187,6 +187,7 @@ int main(int argc, char *argv[]) }

[PATCH-for-6.2] hw/i386/microvm: Reduce annoying debug message in dt_setup_microvm()

2021-11-17 Thread Philippe Mathieu-Daudé
Fixes: f5918a99283 ("microvm: add device tree support.") Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/microvm-dt.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/i386/microvm-dt.c b/hw/i386/microvm-dt.c index 875ba919639..6ee6c42904d 100644 ---

Re: [PATCH v5 00/17] linux-user: simplify safe signal handling

2021-11-17 Thread Warner Losh
On Wed, Nov 17, 2021 at 9:04 AM Richard Henderson < richard.hender...@linaro.org> wrote: > Warner's v3: > https://patchew.org/QEMU/2023045603.60391-1-...@bsdimp.com/ > > Changes for v5: > * Fix safe-syscall.S FreeBSD typos. > * Rename special TARGET_EFOO to QEMU_EFOO. > * Create

[PATCH for-6.2] tests/tcg/ppc64le: Fix compile flags for byte_reverse

2021-11-17 Thread Richard Henderson
With a host compiler new enough to recognize power10 insns, CROSS_CC_HAS_POWER10 is true, but we do not supply the -cpu option to the compiler, resulting in /tmp/ccAVdYJd.s: Assembler messages: /tmp/ccAVdYJd.s:49: Error: unrecognized opcode: `brh' /tmp/ccAVdYJd.s:78: Error: unrecognized opcode:

Re: Follow-up on the CXL discussion at OFTC

2021-11-17 Thread Jonathan Cameron
On Wed, 17 Nov 2021 08:57:19 -0800 Ben Widawsky wrote: > Hi Saransh. Please add the list for these kind of questions. I've converted > your > HTML mail, but going forward, the list will eat it, so please use text only. > > On 21-11-16 00:14:33, Saransh Gupta1 wrote: > >Hi Ben, > > > >

Re: [PATCH v5 16/17] meson: Move linux_user_ss to linux-user/

2021-11-17 Thread Warner Losh
On Wed, Nov 17, 2021 at 9:04 AM Richard Henderson < richard.hender...@linaro.org> wrote: > We have no need to reference linux_user_ss outside of linux-user. > Go ahead and merge it directly into specific_ss. > > Signed-off-by: Richard Henderson > --- > meson.build| 3 --- >

Re: [PATCH v5 17/17] meson: Move bsd_user_ss to bsd-user/

2021-11-17 Thread Warner Losh
On Wed, Nov 17, 2021 at 9:04 AM Richard Henderson < richard.hender...@linaro.org> wrote: > We have no need to reference bsd_user_ss outside of bsd-user. > Go ahead and merge it directly into specific_ss. > > Signed-off-by: Richard Henderson > --- > meson.build | 3 --- >

Re: [PATCH v5 15/17] linux-user: Move thunk.c from top-level

2021-11-17 Thread Warner Losh
On Wed, Nov 17, 2021 at 9:04 AM Richard Henderson < richard.hender...@linaro.org> wrote: > So far, linux-user is the only user of these functions. > Clean up the build machinery by restricting it to linux-user. > > Signed-off-by: Richard Henderson > --- > meson.build | 1 - >

Re: [PATCH v5 14/17] common-user: Move safe-syscall.* from linux-user

2021-11-17 Thread Warner Losh
On Wed, Nov 17, 2021 at 9:04 AM Richard Henderson < richard.hender...@linaro.org> wrote: > Move linux-user/safe-syscall.S to common-user so that bsd-user > can also use it. Also move safe-syscall.h to include/user/. > Since there is nothing here that is related to the guest, as > opposed to the

Re: [PATCH v5 13/17] meson: Add build infrastructure for common-user

2021-11-17 Thread Warner Losh
On Wed, Nov 17, 2021 at 9:04 AM Richard Henderson < richard.hender...@linaro.org> wrote: > The first objects to be added will be target-independent, > and so built once for the host. > > Signed-off-by: Richard Henderson > --- > meson.build | 16 +++- >

Re: [PATCH v5 11/17] bsd-user: Create special-errno.h

2021-11-17 Thread Warner Losh
On Wed, Nov 17, 2021 at 9:04 AM Richard Henderson < richard.hender...@linaro.org> wrote: > Pull the internal errno used by qemu internally its own > header file, for use by safe-syscall.S. > > Signed-off-by: Richard Henderson > --- > bsd-user/errno_defs.h| 6 +- >

Re: [PATCH v5 12/17] linux-user: Create special-errno.h

2021-11-17 Thread Warner Losh
On Wed, Nov 17, 2021 at 9:04 AM Richard Henderson < richard.hender...@linaro.org> wrote: > Pull the two internal errno used by qemu internally into their own > header file. This includes the one define required by safe-syscall.S. > > Signed-off-by: Richard Henderson > --- >

Re: [PATCH v5 16/17] meson: Move linux_user_ss to linux-user/

2021-11-17 Thread Richard Henderson
On 11/17/21 5:56 PM, Philippe Mathieu-Daudé wrote: +Thomas/Paolo On 11/17/21 17:04, Richard Henderson wrote: We have no need to reference linux_user_ss outside of linux-user. Go ahead and merge it directly into specific_ss. The patch is correct, so: Reviewed-by: Philippe Mathieu-Daudé But

Re: [PATCH v5 10/17] linux-user: Rename TARGET_QEMU_ESIGRETURN to QEMU_ESIGRETURN

2021-11-17 Thread Warner Losh
On Wed, Nov 17, 2021 at 9:04 AM Richard Henderson < richard.hender...@linaro.org> wrote: > This value is fully internal to qemu, and so is not a TARGET define. > > Signed-off-by: Richard Henderson > --- > linux-user/generic/target_errno_defs.h | 2 +- > linux-user/aarch64/cpu_loop.c |

[PATCH for-6.2 0/2] NBD 6.2-rc fixes

2021-11-17 Thread Eric Blake
Back in September, Rich proposed a patch to silence an EPIPE message from qemu-nbd when used with Unix sockets: https://lists.gnu.org/archive/html/qemu-devel/2021-09/msg03359.html But investigating that further, I found that we had a different message with TCP sockets, and that we regressed in

Re: [PATCH v5 16/17] meson: Move linux_user_ss to linux-user/

2021-11-17 Thread Philippe Mathieu-Daudé
On Wed, Nov 17, 2021 at 6:04 PM Richard Henderson wrote: > On 11/17/21 5:56 PM, Philippe Mathieu-Daudé wrote: > > +Thomas/Paolo > > > > On 11/17/21 17:04, Richard Henderson wrote: > >> We have no need to reference linux_user_ss outside of linux-user. > >> Go ahead and merge it directly into

Re: [PATCH v5 16/17] meson: Move linux_user_ss to linux-user/

2021-11-17 Thread Philippe Mathieu-Daudé
+Thomas/Paolo On 11/17/21 17:04, Richard Henderson wrote: > We have no need to reference linux_user_ss outside of linux-user. > Go ahead and merge it directly into specific_ss. The patch is correct, so: Reviewed-by: Philippe Mathieu-Daudé But ... > Signed-off-by: Richard Henderson > --- >

Re: [PATCH v5 17/17] meson: Move bsd_user_ss to bsd-user/

2021-11-17 Thread Philippe Mathieu-Daudé
On 11/17/21 17:04, Richard Henderson wrote: > We have no need to reference bsd_user_ss outside of bsd-user. > Go ahead and merge it directly into specific_ss. > > Signed-off-by: Richard Henderson > --- > meson.build | 3 --- > bsd-user/meson.build | 4 > 2 files changed, 4

Re: [PATCH v2 03/13] hw/arm/npcm7xx_boards: Replace drive_get_next() by drive_get()

2021-11-17 Thread Havard Skinnemoen
On Wed, Nov 17, 2021 at 8:34 AM Markus Armbruster wrote: > > drive_get_next() is basically a bad idea. It returns the "next" block > backend of a certain interface type. "Next" means bus=0,unit=N, where > subsequent calls count N up from zero, per interface type. > > This lets you define unit

[PATCH v4 5/5] s390x: kvm: topology: interception of PTF instruction

2021-11-17 Thread Pierre Morel
When the host supports the CPU topology facility, the PTF instruction with function code 2 is interpreted by the SIE, provided that the userland hypervizor activates the interpretation by using the KVM_CAP_S390_CPU_TOPOLOGY KVM extension. The PTF instructions with function code 0 and 1 are

[PATCH for-6.2? 2/2] nbd/server: Simplify zero and trim

2021-11-17 Thread Eric Blake
Now that the block layer supports 64-bit operations, we no longer have to self-fragment requests larger than 2G, reverting the workaround added in 890cbccb08 (nbd: Fix large trim/zero requests). Signed-off-by: Eric Blake --- nbd/server.c | 23 +++ 1 file changed, 3

Re: [PATCH v5 09/17] *-user: Rename TARGET_ERESTARTSYS to QEMU_ERESTARTSYS

2021-11-17 Thread Philippe Mathieu-Daudé
On 11/17/21 17:04, Richard Henderson wrote: > This value is fully internal to qemu, and so is not a TARGET define. > We use this as an extra marker for both host and target errno. Thanks for this cleanup, I often wondered what was it really. Reviewed-by: Philippe Mathieu-Daudé > Signed-off-by:

[PATCH v4 2/5] s390x: topology: CPU topology objects and structures

2021-11-17 Thread Pierre Morel
We use new objects to have a dynamic administration of the CPU topology. The highest level object in this implementation is the s390 book and in this first implementation of CPU topology for S390 we have a single book. The book is built as a SYSBUS bridge during the CPU initialization. Every

[PATCH for-6.2 1/2] nbd/server: Don't complain on certain client disconnects

2021-11-17 Thread Eric Blake
When a client disconnects abruptly, but did not have any pending requests (for example, when using nbdsh without calling h.shutdown), we used to output the following message: $ qemu-nbd -f raw file $ nbdsh -u 'nbd://localhost:10809' -c 'h.trim(1,0)' qemu-nbd: Disconnect client, due to: Failed to

[PATCH v4 4/5] s390x: CPU topology: CPU topology migration

2021-11-17 Thread Pierre Morel
Both source and target must have the same configuration regarding the activation of Perform Topology Function and Store Topology System Information. Signed-off-by: Pierre Morel --- target/s390x/cpu.h | 2 ++ target/s390x/cpu_features_def.h.inc | 1 + target/s390x/cpu_models.c

[PATCH v4 0/5] s390x: CPU Topology

2021-11-17 Thread Pierre Morel
Hi, This series is a first part of the implementation of CPU topology for S390 greatly reduced from the first spin. In particular, we reduced the scope to the S390x specificities, removing all code touching to SMP or NUMA, with the goal to: - facilitate review and acceptance - let for later the

Re: [PATCH v5 09/17] *-user: Rename TARGET_ERESTARTSYS to QEMU_ERESTARTSYS

2021-11-17 Thread Warner Losh
On Wed, Nov 17, 2021 at 9:04 AM Richard Henderson < richard.hender...@linaro.org> wrote: > This value is fully internal to qemu, and so is not a TARGET define. > We use this as an extra marker for both host and target errno. > > Signed-off-by: Richard Henderson > --- > bsd-user/errno_defs.h

[PATCH v4 3/5] s390x: topology: implementating Store Topology System Information

2021-11-17 Thread Pierre Morel
The handling of STSI is enhanced with the interception of the function code 15 for storing CPU topology. Using the objects built during the pluging of CPU, we build the SYSIB 15_1_x structures. With this patch the maximum MNEST level is 2, this is also the only level allowed and only SYSIB

  1   2   3   >