Re: [PATCH 2/3] virtio-net: Only enable userland vq if using tap backend

2021-11-18 Thread Eugenio Perez Martin
On Fri, Nov 19, 2021 at 3:44 AM Jason Wang wrote: > > On Thu, Nov 18, 2021 at 3:57 PM Eugenio Perez Martin > wrote: > > > > On Thu, Nov 18, 2021 at 6:06 AM Jason Wang wrote: > > > > > > On Thu, Nov 18, 2021 at 3:29 AM Eugenio Pérez wrote: > > > > > > > > Qemu falls back on userland handlers

Re: [PATCH 1/5] hw/core: Remove use of QERR_UNSUPPORTED

2021-11-18 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > QERR_UNSUPPORTED definition is obsolete since 2015 (commit > 4629ed1e989, "qerror: Finally unused, clean up"). Replace it. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/core/nmi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

[PATCH v11 23/26] default-configs: Add loongarch linux-user support

2021-11-18 Thread Song Gao
This patch adds loongarch64 linux-user default configs file. Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang Reviewed-by: Richard Henderson --- configs/targets/loongarch64-linux-user.mak | 3 +++ 1 file changed, 3 insertions(+) create mode 100644

[PATCH v11 26/26] scripts: add loongarch64 binfmt config

2021-11-18 Thread Song Gao
Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang Reviewed-by: Richard Henderson --- scripts/qemu-binfmt-conf.sh | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/scripts/qemu-binfmt-conf.sh b/scripts/qemu-binfmt-conf.sh index 7de996d..da6a937 100755 ---

[PATCH v11 12/26] target/loongarch: Add floating point conversion instruction translation

2021-11-18 Thread Song Gao
This includes: - FCVT.S.D, FCVT.D.S - FFINT.{S/D}.{W/L}, FTINT.{W/L}.{S/D} - FTINT{RM/RP/RZ/RNE}.{W/L}.{S/D} - FRINT.{S/D} Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang Reviewed-by: Richard Henderson --- target/loongarch/fpu_helper.c| 393 +++

Re: [PATCH 4/5] hw/core: Remove uses of QERR_PROPERTY_VALUE_BAD

2021-11-18 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > QERR_PROPERTY_VALUE_BAD definition is obsolete since 2015 (commit > 4629ed1e989, "qerror: Finally unused, clean up"). Replace the two > uses and drop the definition. > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/qapi/qmp/qerror.h | 3 --- >

[PATCH v11 25/26] target/loongarch: 'make check-tcg' support

2021-11-18 Thread Song Gao
Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang Reviewed-by: Richard Henderson Acked-by: Alex Bennée --- tests/tcg/configure.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/tcg/configure.sh b/tests/tcg/configure.sh index 9b76f58..49a05ec 100755 --- a/tests/tcg/configure.sh

[PATCH v11 24/26] target/loongarch: Add target build suport

2021-11-18 Thread Song Gao
This patch adds build loongarch-linux-user target support. Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang Reviewed-by: Richard Henderson --- meson.build | 2 +- target/loongarch/meson.build | 19 +++ target/meson.build | 1 + 3 files changed,

[PATCH v11 16/26] target/loongarch: Add disassembler

2021-11-18 Thread Song Gao
This patch adds support for disassembling via option '-d in_asm'. Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang --- include/disas/dis-asm.h | 2 + meson.build | 1 + target/loongarch/disas.c | 625 +++ 3 files changed, 628

[PATCH v11 20/26] linux-user: Add LoongArch elf support

2021-11-18 Thread Song Gao
Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang --- include/elf.h | 2 ++ linux-user/elfload.c| 58 + linux-user/loongarch64/target_elf.h | 12 3 files changed, 72 insertions(+) create mode 100644

[PATCH v11 14/26] target/loongarch: Add floating point load/store instruction translation

2021-11-18 Thread Song Gao
This includes: - FLD.{S/D}, FST.{S/D} - FLDX.{S/D}, FSTX.{S/D} - FLD{GT/LE}.{S/D}, FST{GT/LE}.{S/D} Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang Reviewed-by: Richard Henderson --- target/loongarch/insn_trans/trans_fmemory.c.inc | 184

[PATCH v11 22/26] linux-user: Add LoongArch cpu_loop support

2021-11-18 Thread Song Gao
Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang --- configure | 5 ++ linux-user/loongarch64/cpu_loop.c | 97 + linux-user/loongarch64/target_cpu.h | 34 + 3 files changed, 136 insertions(+) create mode 100644

[PATCH v11 18/26] linux-user: Add LoongArch specific structures

2021-11-18 Thread Song Gao
Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang --- linux-user/loongarch64/target_structs.h | 48 + 1 file changed, 48 insertions(+) create mode 100644 linux-user/loongarch64/target_structs.h diff --git a/linux-user/loongarch64/target_structs.h

[PATCH v11 13/26] target/loongarch: Add floating point move instruction translation

2021-11-18 Thread Song Gao
This includes: - FMOV.{S/D} - FSEL - MOVGR2FR.{W/D}, MOVGR2FRH.W - MOVFR2GR.{S/D}, MOVFRH2GR.S - MOVGR2FCSR, MOVFCSR2GR - MOVFR2CF, MOVCF2FR - MOVGR2CF, MOVCF2GR Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang Reviewed-by: Richard Henderson --- target/loongarch/fpu_helper.c

[PATCH v11 15/26] target/loongarch: Add branch instruction translation

2021-11-18 Thread Song Gao
This includes: - BEQ, BNE, BLT[U], BGE[U] - BEQZ, BNEZ - B - BL - JIRL - BCEQZ, BCNEZ Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang Reviewed-by: Richard Henderson --- target/loongarch/insn_trans/trans_branch.c.inc | 82 ++ target/loongarch/insns.decode

[PATCH v11 17/26] linux-user: Add LoongArch generic header files

2021-11-18 Thread Song Gao
This includes: - sockbits.h - target_errno_defs.h - target_fcntl.h - termbits.h Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang --- linux-user/loongarch64/sockbits.h | 11 +++ linux-user/loongarch64/target_errno_defs.h | 12

[PATCH v11 01/26] target/loongarch: Add README

2021-11-18 Thread Song Gao
This patch gives an introduction to the LoongArch target. Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang Reviewed-by: Richard Henderson --- MAINTAINERS | 5 target/loongarch/README | 76 + 2 files changed, 81

[PATCH v11 09/26] target/loongarch: Add fixed point extra instruction translation

2021-11-18 Thread Song Gao
This includes: - CRC[C].W.{B/H/W/D}.W - SYSCALL - BREAK - ASRT{LE/GT}.D - RDTIME{L/H}.W, RDTIME.D - CPUCFG Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang Reviewed-by: Richard Henderson --- target/loongarch/helper.h | 4 ++

[PATCH v11 11/26] target/loongarch: Add floating point comparison instruction translation

2021-11-18 Thread Song Gao
This includes: - FCMP.cond.{S/D} Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang Reviewed-by: Richard Henderson --- target/loongarch/fpu_helper.c| 60 target/loongarch/helper.h| 9 +

[PATCH v11 21/26] linux-user: Add LoongArch syscall support

2021-11-18 Thread Song Gao
We should disable '__BITS_PER_LONG' at [1] before run gensyscalls.sh [1] arch/loongarch/include/uapi/asm/bitsperlong.h Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang --- linux-user/loongarch64/syscall_nr.h | 312

[PATCH v11 03/26] target/loongarch: Add main translation routines

2021-11-18 Thread Song Gao
This patch adds main translation routines and basic functions for translation. Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang Reviewed-by: Richard Henderson --- target/loongarch/helper.h| 6 ++ target/loongarch/op_helper.c | 21 ++ target/loongarch/translate.c | 159

[PATCH v11 08/26] target/loongarch: Add fixed point atomic instruction translation

2021-11-18 Thread Song Gao
This includes: - LL.{W/D}, SC.{W/D} - AM{SWAP/ADD/AND/OR/XOR/MAX/MIN}[_DB].{W/D} - AM{MAX/MIN}[_DB].{WU/DU} Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang Reviewed-by: Richard Henderson --- target/loongarch/insn_trans/trans_atomic.c.inc | 130 +

[PATCH v11 19/26] linux-user: Add LoongArch signal support

2021-11-18 Thread Song Gao
Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang --- linux-user/loongarch64/signal.c| 162 + linux-user/loongarch64/target_signal.h | 29 ++ 2 files changed, 191 insertions(+) create mode 100644 linux-user/loongarch64/signal.c create mode

[PATCH v11 06/26] target/loongarch: Add fixed point bit instruction translation

2021-11-18 Thread Song Gao
This includes: - EXT.W.{B/H} - CL{O/Z}.{W/D}, CT{O/Z}.{W/D} - BYTEPICK.{W/D} - REVB.{2H/4H/2W/D} - REVH.{2W/D} - BITREV.{4B/8B}, BITREV.{W/D} - BSTRINS.{W/D}, BSTRPICK.{W/D} - MASKEQZ, MASKNEZ Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang Reviewed-by: Richard Henderson ---

[PATCH v11 04/26] target/loongarch: Add fixed point arithmetic instruction translation

2021-11-18 Thread Song Gao
This includes: - ADD.{W/D}, SUB.{W/D} - ADDI.{W/D}, ADDU16ID - ALSL.{W[U]/D} - LU12I.W, LU32I.D LU52I.D - SLT[U], SLT[U]I - PCADDI, PCADDU12I, PCADDU18I, PCALAU12I - AND, OR, NOR, XOR, ANDN, ORN - MUL.{W/D}, MULH.{W[U]/D[U]} - MULW.D.W[U] - DIV.{W[U]/D[U]}, MOD.{W[U]/D[U]} - ANDI, ORI, XORI

[PATCH v11 02/26] target/loongarch: Add core definition

2021-11-18 Thread Song Gao
This patch adds target state header, target definitions and initialization routines. Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang Reviewed-by: Richard Henderson --- target/loongarch/cpu-param.h | 18 +++ target/loongarch/cpu.c | 314 +++

[PATCH v11 10/26] target/loongarch: Add floating point arithmetic instruction translation

2021-11-18 Thread Song Gao
This includes: - F{ADD/SUB/MUL/DIV}.{S/D} - F{MADD/MSUB/NMADD/NMSUB}.{S/D} - F{MAX/MIN}.{S/D} - F{MAXA/MINA}.{S/D} - F{ABS/NEG}.{S/D} - F{SQRT/RECIP/RSQRT}.{S/D} - F{SCALEB/LOGB/COPYSIGN}.{S/D} - FCLASS.{S/D} Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang Reviewed-by: Richard Henderson

[PATCH v11 00/26] Add LoongArch linux-user emulation support

2021-11-18 Thread Song Gao
Hi all, This series only support linux-user emulation. More about LoongArch at: https://github.com/loongson/ The latest kernel: * https://github.com/loongson/linux/tree/loongarch-next Patches need review: * 0016-target-loongarch-Add-disassembler.patch *

[PATCH v11 05/26] target/loongarch: Add fixed point shift instruction translation

2021-11-18 Thread Song Gao
This includes: - SLL.W, SRL.W, SRA.W, ROTR.W - SLLI.W, SRLI.W, SRAI.W, ROTRI.W - SLL.D, SRL.D, SRA.D, ROTR.D - SLLI.D, SRLI.D, SRAI.D, ROTRI.D Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang Reviewed-by: Richard Henderson --- target/loongarch/insn_trans/trans_shift.c.inc | 128

[PATCH v11 07/26] target/loongarch: Add fixed point load/store instruction translation

2021-11-18 Thread Song Gao
This includes: - LD.{B[U]/H[U]/W[U]/D}, ST.{B/H/W/D} - LDX.{B[U]/H[U]/W[U]/D}, STX.{B/H/W/D} - LDPTR.{W/D}, STPTR.{W/D} - PRELD - LD{GT/LE}.{B/H/W/D}, ST{GT/LE}.{B/H/W/D} - DBAR, IBAR Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang Reviewed-by: Richard Henderson ---

[PATCH V3 2/2] test/qtest/test-filter-mirror.c: Change the default vnet_hdr_support

2021-11-18 Thread Zhang Chen
As net filters changed default vnet_hdr_support=on. For this e1000 test case need to add vnet_hdr_support=off. Signed-off-by: Zhang Chen --- tests/qtest/test-filter-mirror.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qtest/test-filter-mirror.c

[PATCH V3 1/2] net/filter: Enable the vnet_hdr_support by default

2021-11-18 Thread Zhang Chen
This patch make filters and colo-compare module support vnet_hdr by default. And also support -device non-virtio-net(like e1000.). Because when enabled the support will make the vnet_hdr_len field become must-delivery part of filter transfer protocol(even 0 in use -device e1000). It fully

RE: [PATCH] net/filter: Enable the vnet_hdr_support by default

2021-11-18 Thread Zhang, Chen
> -Original Message- > From: Jason Wang > Sent: Friday, November 19, 2021 11:37 AM > To: Zhang, Chen > Cc: qemu-dev ; Markus Armbruster > ; Li Zhijian > Subject: Re: [PATCH] net/filter: Enable the vnet_hdr_support by default > > On Fri, Nov 19, 2021 at 11:17 AM Jason Wang > wrote: >

Re: [PATCH v4 13/20] target/riscv: Fix RESERVED field length in VTYPE

2021-11-18 Thread Alistair Francis
On Fri, Nov 12, 2021 at 2:06 AM LIU Zhiwei wrote: > > Signed-off-by: LIU Zhiwei > Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis Alistair > --- > target/riscv/cpu.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/riscv/cpu.h

Re: [PATCH v4 12/20] target/riscv: Split out the vill from vtype

2021-11-18 Thread Alistair Francis
On Fri, Nov 12, 2021 at 2:03 AM LIU Zhiwei wrote: > > We need not specially process vtype when XLEN changes. > > Signed-off-by: LIU Zhiwei > Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis Alistair > --- > target/riscv/cpu.h | 1 + > target/riscv/cpu_helper.c|

Re: [PATCH v4 11/20] target/riscv: Split pm_enabled into mask and base

2021-11-18 Thread Alistair Francis
On Fri, Nov 12, 2021 at 2:05 AM LIU Zhiwei wrote: > > Use cached cur_pmmask and cur_pmbase to infer the > current PM mode. > > This may decrease the TCG IR by one when pm_enabled > is true and pm_base_enabled is false. > > Signed-off-by: LIU Zhiwei > Reviewed-by: Richard Henderson Reviewed-by:

Re: [PATCH v4 10/20] target/riscv: Calculate address according to XLEN

2021-11-18 Thread Alistair Francis
On Fri, Nov 12, 2021 at 1:59 AM LIU Zhiwei wrote: > > Define one common function to compute a canonical address from a register > plus offset. Merge gen_pm_adjust_address into this function. > > Signed-off-by: LIU Zhiwei > Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis Alistair

Re: [PATCH v4 09/20] target/riscv: Alloc tcg global for cur_pm[mask|base]

2021-11-18 Thread Alistair Francis
On Fri, Nov 12, 2021 at 2:03 AM LIU Zhiwei wrote: > > Replace the array of pm_mask/pm_base with scalar variables. > Remove the cached array value in DisasContext. > > Signed-off-by: LIU Zhiwei > Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis Alistair > --- >

Re: [PATCH v4 08/20] target/riscv: Create current pm fields in env

2021-11-18 Thread Alistair Francis
On Fri, Nov 12, 2021 at 2:00 AM LIU Zhiwei wrote: > > Signed-off-by: LIU Zhiwei Reviewed-by: Alistair Francis Alistair > --- > target/riscv/cpu.c| 1 + > target/riscv/cpu.h| 4 > target/riscv/cpu_helper.c | 43 +++ >

[PULL 3/3] net/colo-compare.c: Fix incorrect return when input wrong size

2021-11-18 Thread Jason Wang
From: Zhang Chen Signed-off-by: Zhang Chen Signed-off-by: Jason Wang --- net/colo-compare.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/colo-compare.c b/net/colo-compare.c index 1225f40..b966e7e 100644 --- a/net/colo-compare.c +++ b/net/colo-compare.c @@ -807,7

[PULL 1/3] net: vmxnet3: validate configuration values during activate (CVE-2021-20203)

2021-11-18 Thread Jason Wang
From: Prasad J Pandit While activating device in vmxnet3_acticate_device(), it does not validate guest supplied configuration values against predefined minimum - maximum limits. This may lead to integer overflow or OOB access issues. Add checks to avoid it. Fixes: CVE-2021-20203 Buglink:

[PULL 0/3] Net patches

2021-11-18 Thread Jason Wang
The following changes since commit 44a3aa0608f01274418487b655d42467c1d8334e: Merge tag 'sev-hashes-pull-request' of https://gitlab.com/berrange/qemu into staging (2021-11-18 15:06:05 +0100) are available in the git repository at: https://github.com/jasowang/qemu.git tags/net-pull-request

[PULL 2/3] net/colo-compare.c: Fix ACK track reverse issue

2021-11-18 Thread Jason Wang
From: Zhang Chen The TCP protocol ACK maybe bigger than uint32_t MAX. At this time, the ACK will reverse to 0. This patch fix the max_ack and min_ack track issue. Signed-off-by: Zhang Chen Signed-off-by: Jason Wang --- net/colo-compare.c | 6 -- 1 file changed, 4 insertions(+), 2

Re: [PATCH] net/filter: Enable the vnet_hdr_support by default

2021-11-18 Thread Jason Wang
On Fri, Nov 19, 2021 at 11:17 AM Jason Wang wrote: > > > 在 2021/11/10 上午10:39, Zhang Chen 写道: > > This patch make filters and colo-compare module support vnet_hdr by > > default. And also support -device non-virtio-net(like e1000.). > > But it can't avoid user manual configuration error between >

Re: [PATCH-for-6.2] net: vmxnet3: validate configuration values during activate (CVE-2021-20203)

2021-11-18 Thread Jason Wang
在 2021/11/18 下午8:32, Philippe Mathieu-Daudé 写道: ping? Applied. Thanks On 10/18/21 11:09, P J P wrote: On Monday, 18 October, 2021, 12:20:55 pm IST, Thomas Huth wrote: On 30/01/2021 14.16, P J P wrote: diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c index eff299f629..4a910ca971

Re: Follow-up on the CXL discussion at OFTC

2021-11-18 Thread Ben Widawsky
On 21-11-19 02:29:51, Shreyas Shah wrote: > Hi Ben > > Are you planning to add the CXL2.0 switch inside QEMU or already added in one > of the version? > >From me, there are no plans for QEMU anything until/unless upstream thinks it will merge the existing patches, or provide feedback as to

Re: [PATCH 2/2] net/colo-compare.c: Fix incorrect return when input wrong size

2021-11-18 Thread Jason Wang
在 2021/11/18 上午11:20, Zhang Chen 写道: Signed-off-by: Zhang Chen --- Applied. Thanks net/colo-compare.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/colo-compare.c b/net/colo-compare.c index 1225f40e41..b966e7e514 100644 --- a/net/colo-compare.c +++

Re: [PATCH 1/2] net/colo-compare.c: Fix ACK track reverse issue

2021-11-18 Thread Jason Wang
在 2021/11/18 上午11:20, Zhang Chen 写道: The TCP protocol ACK maybe bigger than uint32_t MAX. At this time, the ACK will reverse to 0. This patch fix the max_ack and min_ack track issue. Signed-off-by: Zhang Chen --- Applied. Thanks net/colo-compare.c | 6 -- 1 file changed, 4

Re: [PATCH] net/filter: Enable the vnet_hdr_support by default

2021-11-18 Thread Jason Wang
在 2021/11/10 上午10:39, Zhang Chen 写道: This patch make filters and colo-compare module support vnet_hdr by default. And also support -device non-virtio-net(like e1000.). But it can't avoid user manual configuration error between different filters when enable/disable virtio-net-pci.

Re: [PATCH v4 00/25] block layer: split block APIs in global state and I/O

2021-11-18 Thread Paolo Bonzini
El jue., 18 nov. 2021 16:31, Hanna Reitz escribió: > On 18.11.21 14:50, Paolo Bonzini wrote: > > On 11/15/21 17:03, Hanna Reitz wrote: > >> > >> I only really see four solutions for this: > >> (1) We somehow make the amend job run in the main context under the > >> BQL and have it prevent all

Re: [PATCH v5 3/6] net/vmnet: implement shared mode (vmnet-shared)

2021-11-18 Thread Jason Wang
On Fri, Nov 19, 2021 at 1:12 AM Vladislav Yaroshchuk wrote: > > > > пн, 15 нояб. 2021 г. в 07:47, Jason Wang : >> >> On Fri, Nov 12, 2021 at 5:14 PM Vladislav Yaroshchuk >> wrote: >> > >> > Signed-off-by: Phillip Tennen >> > Signed-off-by: Vladislav Yaroshchuk >> > --- >> >> Commit log please.

Re: [PATCH v5 0/6] Add vmnet.framework based network backend

2021-11-18 Thread Jason Wang
On Fri, Nov 19, 2021 at 1:42 AM Vladislav Yaroshchuk wrote: > > > > ср, 17 нояб. 2021 г. в 09:10, Jason Wang : >> >> On Tue, Nov 16, 2021 at 11:30 PM Vladislav Yaroshchuk >> wrote: >> > >> > >> > >> > вт, 16 нояб. 2021 г. в 10:23, Jason Wang : >> >> >> >> On Mon, Nov 15, 2021 at 6:45 PM

Re: [PATCH 2/3] virtio-net: Only enable userland vq if using tap backend

2021-11-18 Thread Jason Wang
On Thu, Nov 18, 2021 at 3:57 PM Eugenio Perez Martin wrote: > > On Thu, Nov 18, 2021 at 6:06 AM Jason Wang wrote: > > > > On Thu, Nov 18, 2021 at 3:29 AM Eugenio Pérez wrote: > > > > > > Qemu falls back on userland handlers even if vhost-user and vhost-vdpa > > > cases. These assumes a tap

RE: Follow-up on the CXL discussion at OFTC

2021-11-18 Thread Shreyas Shah via
Hi Ben Are you planning to add the CXL2.0 switch inside QEMU or already added in one of the version? Regards, Shreyas -Original Message- From: Ben Widawsky Sent: Thursday, November 18, 2021 5:48 PM To: Shreyas Shah Cc: Saransh Gupta1 ; Jonathan Cameron ;

Re: Follow-up on the CXL discussion at OFTC

2021-11-18 Thread Ben Widawsky
On 21-11-18 15:20:34, Saransh Gupta1 wrote: > Hi Ben and Jonathan, > > Thanks for your replies. I'm looking forward to the patches. > > For QEMU, I see hotplug support as an item on the list and would like to > start working on it. It would be great if you can provide some pointers > about how

Re: Follow-up on the CXL discussion at OFTC

2021-11-18 Thread Ben Widawsky
On 21-11-18 22:52:56, Shreyas Shah wrote: > Hello Folks, > > Any plan to add CXL2.0 switch ports in QEMU? What's your definition of plan? > > Regards, > Shreyas [snip]

RE: Follow-up on the CXL discussion at OFTC

2021-11-18 Thread Shreyas Shah via
Hello Folks, Any plan to add CXL2.0 switch ports in QEMU? Regards, Shreyas -Original Message- From: Saransh Gupta1 Sent: Thursday, November 18, 2021 2:21 PM To: Jonathan Cameron ; Ben Widawsky Cc: linux-...@vger.kernel.org; qemu-devel@nongnu.org Subject: RE: Follow-up on the CXL

RE: [PATCH] docs/COLO-FT.txt: Drop deprecated 'props' from object-add in COLO docs

2021-11-18 Thread Rao, Lei
OK,all files you mentioned will be modified in the next patch. Thanks, Lei. -Original Message- From: Markus Armbruster Sent: Thursday, November 18, 2021 2:50 PM To: Rao, Lei Cc: Zhang, Chen ; zhang.zhanghaili...@huawei.com; quint...@redhat.com; dgilb...@redhat.com;

RE: Follow-up on the CXL discussion at OFTC

2021-11-18 Thread Saransh Gupta1
Hi Ben and Jonathan, Thanks for your replies. I'm looking forward to the patches. For QEMU, I see hotplug support as an item on the list and would like to start working on it. It would be great if you can provide some pointers about how I should go about it. Also, which version of kernel and

Re: [PATCH v2 for-6.2] meson.build: Support ncurses on MacOS and OpenBSD

2021-11-18 Thread Brad Smith
On 11/17/2021 3:53 PM, Stefan Weil wrote: MacOS provides header files for curses 5.7 with support for wide characters, but requires _XOPEN_SOURCE_EXTENDED=1 to activate that. By default those old header files are used even if there is a newer Homebrew installation of ncurses 6.2 available.

[PATCH] ui/gtk: mon_num parameter to specify target monitor for launching Qemu

2021-11-18 Thread Dongwon Kim
Introducing a new integer parameter to specify the monitor where the Qemu window is placed upon launching. Monitor index can start from 0 to (total number of monitors - 1). Default value for the parameter is -1, which doesn't affect anything. It can be used together with full-screen=on, which

Re: [PULL 02/22] arm: tcg: Adhere to SMCCC 1.3 section 5.2

2021-11-18 Thread Peter Maydell
On Thu, 30 Sept 2021 at 16:12, Peter Maydell wrote: > > From: Alexander Graf > > The SMCCC 1.3 spec section 5.2 says > > The Unknown SMC Function Identifier is a sign-extended value of (-1) > that is returned in the R0, W0 or X0 registers. An implementation must > return this error code

Re: [RFC PATCH v2 5/5] softmmu/physmem: Have flaview API check MemTxAttrs::bus_perm field

2021-11-18 Thread Philippe Mathieu-Daudé
On 8/24/21 16:21, Peter Maydell wrote: > On Tue, 24 Aug 2021 at 14:50, Philippe Mathieu-Daudé > wrote: >> On 8/24/21 3:15 PM, Stefan Hajnoczi wrote: >>> On Mon, Aug 23, 2021 at 06:41:57PM +0200, Philippe Mathieu-Daudé wrote: Check bus permission in flatview_access_allowed() before

[PATCH 7/7] python/aqmp: fix send_fd_scm for python 3.6.x

2021-11-18 Thread John Snow
3.6 doesn't play keepaway with the socket object, so we don't need to go fishing for it on this version. In fact, so long as 'sendmsg' is still available, it's probably preferable to just use that method and only go fishing for forbidden details when we absolutely have to. Reported-by: Thomas

[PATCH 0/7] python: More fixes for 6.2

2021-11-18 Thread John Snow
GitLab: https://gitlab.com/jsnow/qemu/-/pipelines/412040104 Patch 5 fixes a race condition in machine.py exposed by device-crash-test. Patch 6 fixes a hang in device-crash-test. Patch 7 fixes send_fd_scm in AQMP under Python 3.6. Patches 1-3 provide a minor concurrency fix that happened to get

[PATCH 4/7] python/machine: move more variable initializations to _pre_launch

2021-11-18 Thread John Snow
No need to clear them only to set them later. Signed-off-by: John Snow --- python/qemu/machine/machine.py | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/python/qemu/machine/machine.py b/python/qemu/machine/machine.py index ad529fd92a..f92e73de40 100644 ---

[PATCH 6/7] scripts/device-crash-test: Use a QMP timeout

2021-11-18 Thread John Snow
Despite all the previous fixes, it's still possible for device-crash-test to wedge itself in the case that QEMU terminates *so quickly* that it doesn't even begin a connection attempt to our QMP client. Python will just joyfully wait ad infinitum for a connection that will now never arrive. The

[PATCH 1/7] python/machine: add @sock_dir property

2021-11-18 Thread John Snow
Analogous to temp_dir and log_dir, add a sock_dir property that defaults to @temp_dir -- instead of base_temp_dir -- when the user hasn't overridden the sock dir value in the initializer. This gives us a much more unique directory to put sockfiles in by default. Signed-off-by: John Snow ---

[PATCH 3/7] python/machine: add instance disambiguator to default nickname

2021-11-18 Thread John Snow
If you create two instances of QEMUMachine(), they'll both create the same nickname by default -- which is not that helpful. Luckily, they'll both create unique temporary directories ... but due to user configuration, they may share logging and sockfile directories, meaning two instances can

[PATCH 2/7] python/machine: remove _remove_monitor_sockfile property

2021-11-18 Thread John Snow
It doesn't matter if it was the user or the class itself that specified where the sockfile should be created; the fact is that if we are using a sockfile here, we created it and we can clean it up. Signed-off-by: John Snow --- python/qemu/machine/machine.py | 5 + 1 file changed, 1

[PATCH 5/7] python/machine: handle "fast" QEMU terminations

2021-11-18 Thread John Snow
In the case that the QEMU process actually launches -- but then dies so quickly that we can't establish a QMP connection to it -- QEMUMachine currently calls _post_shutdown() assuming that it never launched the VM process. This isn't true, though: it "merely" may have failed to establish a QMP

Re: device-crash-test

2021-11-18 Thread John Snow
On Thu, Nov 18, 2021 at 1:31 PM Philippe Mathieu-Daudé wrote: > On 11/18/21 18:55, John Snow wrote: > > I finally squashed all of the bugs and got a clean run of > > device-crash-test with a full build of QEMU, over 182,000 individual > > test cases. > > > > Here's all of the legitimate failures

[PATCH-for-6.2? v2] docs: Render binary names as monospaced text

2021-11-18 Thread Philippe Mathieu-Daudé
Reviewed-by: Darren Kenny Signed-off-by: Philippe Mathieu-Daudé --- v2: Addressed Eric comments --- docs/about/removed-features.rst| 8 docs/devel/build-system.rst| 6 +++--- docs/devel/multi-process.rst | 6 +++--- docs/devel/testing.rst

Re: [PATCH] audio: Add sndio backend

2021-11-18 Thread Brad Smith
On 11/14/2021 8:18 AM, Christian Schoenebeck wrote: On Samstag, 13. November 2021 21:40:39 CET Brad Smith wrote: On 11/8/2021 8:03 AM, Christian Schoenebeck wrote: On Sonntag, 7. November 2021 06:19:26 CET Brad Smith wrote: audio: Add sndio backend Add a sndio backend. Hi Brad! sndio is

[PATCH-for-6.2 2/2] hw/display: Do not allow multiple identical VGA devices

2021-11-18 Thread Philippe Mathieu-Daudé
vga_common_init() create a MemoryRegion named "vga.vram", used as a singleton for the device class. When creating the same device type multiple times, we get: $ qemu-system-mips64 -M pica61 -device isa-cirrus-vga RAMBlock "vga.vram" already registered, abort! Aborted (core dumped) Commit

[PATCH-for-6.2 1/2] hw/display: Add Error* handle to vga_common_init()

2021-11-18 Thread Philippe Mathieu-Daudé
We want vga_common_init() to fail gracefully, therefore allow it to take an Error* handle. Signed-off-by: Philippe Mathieu-Daudé --- hw/display/vga_int.h| 2 +- hw/display/ati.c| 4 +++- hw/display/cirrus_vga.c | 4 +++- hw/display/cirrus_vga_isa.c | 4 +++-

[PATCH-for-6.2 0/2] hw/display: Do not allow multiple (identical) VGA devices

2021-11-18 Thread Philippe Mathieu-Daudé
Commit 7852a77f598 fixed creating multiple TYPE_ISA_VGA devices, generalize the fix to all VGA devices. See https://gitlab.com/qemu-project/qemu/-/issues/44 Philippe Mathieu-Daudé (2): hw/display: Add Error* handle to vga_common_init() hw/display: Do not allow multiple identical VGA devices

Re: device-crash-test

2021-11-18 Thread Philippe Mathieu-Daudé
On 11/18/21 18:55, John Snow wrote: > I finally squashed all of the bugs and got a clean run of > device-crash-test with a full build of QEMU, over 182,000 individual > test cases. > > Here's all of the legitimate failures I saw: > > CRITICAL: failed: binary=./qemu-system-x86_64 accel=kvm

Re: [PATCH for-6.2 0/2] escc: fixes for STATUS_TXEMPTY and SPEC_ALLSENT

2021-11-18 Thread Peter Maydell
On Thu, 18 Nov 2021 at 18:18, Mark Cave-Ayland wrote: > > This is another attempt to fix booting 32-bit QEMU SPARC machines in > qemu-system-sparc using a real Sun PROM based upon further experiments and > re-reading of the ESCC datasheet from a previous patch posted at >

Re: [PATCH for-6.2 2/2] escc: update the R_SPEC register SPEC_ALLSENT bit when writing to W_TXCTRL1

2021-11-18 Thread Philippe Mathieu-Daudé
On 11/18/21 19:18, Mark Cave-Ayland wrote: > The ESCC datasheet states that SPEC_ALLSENT is always set in sync mode and set > in async mode once all characters have cleared the transmitter. Since writes > to > SERIAL_DATA use a synchronous chardev API, the guest can never see the state > when >

Re: [PATCH-for-6.2?] docs: Render binary names as monospaced text

2021-11-18 Thread Philippe Mathieu-Daudé
On 11/18/21 16:46, Eric Blake wrote: > On Thu, Nov 18, 2021 at 03:43:17PM +0100, Philippe Mathieu-Daudé wrote: >> Signed-off-by: Philippe Mathieu-Daudé >> --- > >> +++ b/docs/about/removed-features.rst >> @@ -658,8 +658,8 @@ enforce that any failure to open the backing image >> (including if

[PATCH for-6.2 2/2] escc: update the R_SPEC register SPEC_ALLSENT bit when writing to W_TXCTRL1

2021-11-18 Thread Mark Cave-Ayland
The ESCC datasheet states that SPEC_ALLSENT is always set in sync mode and set in async mode once all characters have cleared the transmitter. Since writes to SERIAL_DATA use a synchronous chardev API, the guest can never see the state when transmission is in progress so it is possible to set

[PATCH for-6.2 1/2] escc: always set STATUS_TXEMPTY in R_STATUS on device reset

2021-11-18 Thread Mark Cave-Ayland
The "Transmit Interrupts and Transmit Buffer Empty Bit" section of the ESCC datasheet states the following about the STATUS_TXEMPTY bit: "After a hardware reset (including a hardware reset by software), or a channel reset, this bit is set to 1". Update escc_reset() to set the STATUS_TXEMPTY bit

[PATCH for-6.2 0/2] escc: fixes for STATUS_TXEMPTY and SPEC_ALLSENT

2021-11-18 Thread Mark Cave-Ayland
This is another attempt to fix booting 32-bit QEMU SPARC machines in qemu-system-sparc using a real Sun PROM based upon further experiments and re-reading of the ESCC datasheet from a previous patch posted at https://lists.gnu.org/archive/html/qemu-devel/2021-11/msg00324.html. It appears that

[PATCH v2 0/3] support dirty restraint on vCPU

2021-11-18 Thread huangy81
From: Hyman Huang(黄勇) v2: - rebase on master - modify the following points according to the advices given by Juan 1. rename dirtyrestraint to dirtylimit 2. implement the full lifecyle function of dirtylimit_calc, include dirtylimit_calc and dirtylimit_calc_quit 3. introduce 'quit'

[PATCH v2 1/3] migration/dirtyrate: implement vCPU dirtyrate calculation periodically

2021-11-18 Thread huangy81
From: Hyman Huang(黄勇) introduce the third method GLOBAL_DIRTY_RESTRAINT of dirty tracking for calculate dirtyrate periodly for dirty restraint. implement thread for calculate dirtyrate periodly, which will be used for dirty restraint. add dirtylimit.h to introduce the util function for dirty

[PATCH v2 3/3] cpus-common: implement dirty limit on vCPU

2021-11-18 Thread huangy81
From: Hyman Huang(黄勇) implement dirtyrate calculation periodically basing on dirty-ring and throttle vCPU until it reachs the quota dirtyrate given by user. introduce qmp commands set-dirty-limit/cancel-dirty-limit to set/cancel dirty limit on vCPU. Signed-off-by: Hyman Huang(黄勇) ---

[PATCH v2 2/3] cpu-throttle: implement vCPU throttle

2021-11-18 Thread huangy81
From: Hyman Huang(黄勇) impose dirty restraint on vCPU by kicking it and sleep as the auto-converge does during migration, but just kick the specified vCPU instead, not all vCPUs of vm. start a thread to track the dirtylimit status and adjust the throttle pencentage dynamically depend on current

Re: [qemu-web PATCH] remove deployment phase from CI

2021-11-18 Thread Willian Rampazzo
On Thu, Nov 18, 2021 at 4:50 AM Paolo Bonzini wrote: > > qemu.org is now served via a reverse proxy from qemu-project.gitlab.io; it > does > not need anymore the rsync step to the QEMU project's shell server. > Remove it from the CI. > > Signed-off-by: Paolo Bonzini > --- > .gitlab-ci.yml | 24

device-crash-test

2021-11-18 Thread John Snow
I finally squashed all of the bugs and got a clean run of device-crash-test with a full build of QEMU, over 182,000 individual test cases. Here's all of the legitimate failures I saw: CRITICAL: failed: binary=./qemu-system-x86_64 accel=kvm machine=none device=sgx-epc CRITICAL: cmdline:

Re: [PATCH v5 0/6] Add vmnet.framework based network backend

2021-11-18 Thread Vladislav Yaroshchuk
ср, 17 нояб. 2021 г. в 09:10, Jason Wang : > On Tue, Nov 16, 2021 at 11:30 PM Vladislav Yaroshchuk > wrote: > > > > > > > > вт, 16 нояб. 2021 г. в 10:23, Jason Wang : > >> > >> On Mon, Nov 15, 2021 at 6:45 PM Vladislav Yaroshchuk > >> wrote: > >> > > >> > > >> > > >> > пн, 15 нояб. 2021 г. в

Re: [PATCH] hw/i2c: add pca9543 support to mux

2021-11-18 Thread Patrick Venture
On Mon, Nov 8, 2021 at 1:58 PM Patrick Venture wrote: > Adds support for the 2 channel pca9543 i2c switch. > > Signed-off-by: Patrick Venture > --- > hw/i2c/i2c_mux_pca954x.c | 12 > include/hw/i2c/i2c_mux_pca954x.h | 1 + > 2 files changed, 13 insertions(+) > > diff

Re: [PATCH v5 3/6] net/vmnet: implement shared mode (vmnet-shared)

2021-11-18 Thread Vladislav Yaroshchuk
пн, 15 нояб. 2021 г. в 07:47, Jason Wang : > On Fri, Nov 12, 2021 at 5:14 PM Vladislav Yaroshchuk > wrote: > > > > Signed-off-by: Phillip Tennen > > Signed-off-by: Vladislav Yaroshchuk > > --- > > Commit log please. > > > Sorry, I don't understand what you mean here. What is the 'commit log'?

[qemu-web PATCH] Update URLs of "SubmitAPatch" wiki doc

2021-11-18 Thread Kashyap Chamarthy
We've recently converted[1] the "SubmitAPatch" page from Wiki to in-tree docs. So update the website to reflect this. [1] https://gitlab.com/qemu-project/qemu/-/commit/9f73de8df03 -- 9f73de8df0 (docs: rSTify the "SubmitAPatch" wiki, 2021-11-10) Signed-off-by: Kashyap Chamarthy ---

Re: [PULL 0/6 for-6.2] AMD SEV patches

2021-11-18 Thread Richard Henderson
On 11/18/21 2:35 PM, Daniel P. Berrangé wrote: The following changes since commit 0055ecca84cb948c935224b4f7ca1ceb26209790: Merge tag 'vfio-fixes-2027.0' of git://github.com/awilliam/qemu-vfio into staging (2021-11-18 09:39:47 +0100) are available in the Git repository at:

Re: [PATCH] nvmm: Fix support for stable version

2021-11-18 Thread nia
Ping? It would be very nice if this could make it into 6.2 so we don't have to continue patching around this. On Tue, Nov 02, 2021 at 10:12:28AM +0100, Kamil Rytarowski wrote: > Reviewed-by: Kamil Rytarowski > > Paolo, could you please merge it? > > On 13.10.2021 15:54, nia wrote: > > NVMM

Re: [PATCH v2 2/2] iotests/149: Skip on unsupported ciphers

2021-11-18 Thread Hanna Reitz
On 17.11.21 16:46, Daniel P. Berrangé wrote: On Wed, Nov 17, 2021 at 04:17:07PM +0100, Hanna Reitz wrote: Whenever qemu-img or qemu-io report that some cipher is unsupported, skip the whole test, because that is probably because qemu has been configured with the gnutls crypto backend. We could

Re: [PULL 0/5] Python patches

2021-11-18 Thread John Snow
On Thu, Nov 18, 2021 at 1:46 AM Gerd Hoffmann wrote: > Hi, > > > - Split python/qemu/qmp out into its own repository and begin uploading > it > > to PyPI, as a test. (Do not delete python/qemu/qmp yet at this phase.) > > I think you can do that as two separate steps. > > pip can install from

Re: [PATCH-for-6.2?] docs: Render binary names as monospaced text

2021-11-18 Thread Eric Blake
On Thu, Nov 18, 2021 at 03:43:17PM +0100, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > +++ b/docs/about/removed-features.rst > @@ -658,8 +658,8 @@ enforce that any failure to open the backing image > (including if the > backing file is missing or an incorrect

Re: [PATCH-for-6.2?] docs: Spell QEMU all caps

2021-11-18 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > Replace Qemu -> QEMU. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Markus Armbruster

  1   2   3   >