Re: [PATCH v6 5/6] test/libqtest: add some virtio-net failover migration cancelling tests

2021-12-07 Thread Thomas Huth
On 08/12/2021 08.48, Thomas Huth wrote: On 08/12/2021 08.44, Michael S. Tsirkin wrote: On Mon, Dec 06, 2021 at 11:20:39PM +0100, Laurent Vivier wrote: Add some tests to check the state of the machine if the migration is cancelled while we are using virtio-net failover. Signed-off-by: Laurent

Re: [PATCH v5 3/4] failover: fix unplug pending detection

2021-12-07 Thread Thomas Huth
On 08/12/2021 08.36, Michael S. Tsirkin wrote: On Fri, Nov 19, 2021 at 10:07:17AM +0100, Laurent Vivier wrote: Failover needs to detect the end of the PCI unplug to start migration after the VFIO card has been unplugged. To do that, a flag is set in pcie_cap_slot_unplug_request_cb() and reset

Re: [PATCH v6 5/6] test/libqtest: add some virtio-net failover migration cancelling tests

2021-12-07 Thread Thomas Huth
On 08/12/2021 08.44, Michael S. Tsirkin wrote: On Mon, Dec 06, 2021 at 11:20:39PM +0100, Laurent Vivier wrote: Add some tests to check the state of the machine if the migration is cancelled while we are using virtio-net failover. Signed-off-by: Laurent Vivier So this one I think is needed

Re: [PATCH v6 0/6] tests/qtest: add some tests for virtio-net failover

2021-12-07 Thread Michael S. Tsirkin
On Mon, Dec 06, 2021 at 11:20:34PM +0100, Laurent Vivier wrote: > This series adds a qtest entry to test virtio-net failover feature. I think it's a good idea to CC me and Jason on the next version. Thanks! > We check following error cases: > > - check missing id on device with

Re: [PATCH v6 5/6] test/libqtest: add some virtio-net failover migration cancelling tests

2021-12-07 Thread Michael S. Tsirkin
On Mon, Dec 06, 2021 at 11:20:39PM +0100, Laurent Vivier wrote: > Add some tests to check the state of the machine if the migration > is cancelled while we are using virtio-net failover. > > Signed-off-by: Laurent Vivier So this one I think is needed for the release. Thomas, are you merging it

Re: [PATCH v5 3/4] failover: fix unplug pending detection

2021-12-07 Thread Michael S. Tsirkin
On Fri, Nov 19, 2021 at 10:07:17AM +0100, Laurent Vivier wrote: > Failover needs to detect the end of the PCI unplug to start migration > after the VFIO card has been unplugged. > > To do that, a flag is set in pcie_cap_slot_unplug_request_cb() and reset in > pcie_unplug_device(). > > But since

Re: [PATCH v7 2/4] tests/qtest: add some tests for virtio-net failover

2021-12-07 Thread Michael S. Tsirkin
On Wed, Dec 08, 2021 at 08:33:31AM +0100, Thomas Huth wrote: > On 07/12/2021 18.23, Laurent Vivier wrote: > > Add test cases to test several error cases that must be > > generated by invalid failover configuration. > > > > Add a combination of coldplug and hotplug test cases to be > > sure the

Re: [PATCH v5 0/4] tests/qtest: add some tests for virtio-net failover

2021-12-07 Thread Michael S. Tsirkin
On Fri, Nov 19, 2021 at 10:07:14AM +0100, Laurent Vivier wrote: > This series adds a qtest entry to test virtio-net failover feature. Reviewed-by: Michael S. Tsirkin > We check following error cases: > > - check missing id on device with failover_pair_id triggers an error > - check a primary

Re: [PATCH v7 2/4] tests/qtest: add some tests for virtio-net failover

2021-12-07 Thread Thomas Huth
On 07/12/2021 18.23, Laurent Vivier wrote: Add test cases to test several error cases that must be generated by invalid failover configuration. Add a combination of coldplug and hotplug test cases to be sure the primary is correctly managed according the presence or not of the STANDBY feature.

Re: [PATCH RFC 00/11] vl: Explore redesign of startup

2021-12-07 Thread Markus Armbruster
Damien Hedde writes: > Hi Markus, > > It looks promising. I did not think we could so "easily" have a new > working startup. Look at this big axe I got! ;) > But I'm not so sure that I understand how we should > progress from here. I neglected to explain this my cover

[PATCH 7/7] hw/riscv: Use error_fatal for SoC realisation

2021-12-07 Thread Alistair Francis
From: Alistair Francis When realising the SoC use error_fatal instead of error_abort as the process can fail and report useful information to the user. Currently a user can see this: $ ../qemu/bld/qemu-system-riscv64 -M sifive_u -S -monitor stdio -display none -drive if=pflash QEMU

[PATCH 4/7] hw/intc: sifive_plic: Cleanup remaining functions

2021-12-07 Thread Alistair Francis
From: Alistair Francis We can remove the original sifive_plic_irqs_pending() function and instead just use the sifive_plic_claim() function (renamed to sifive_plic_claimed()) to determine if any interrupts are pending. This requires move the side effects outside of sifive_plic_claimed(), but as

[PATCH 6/7] target/riscv: Enable the Hypervisor extension by default

2021-12-07 Thread Alistair Francis
From: Alistair Francis Let's enable the Hypervisor extension by default. This doesn't affect named CPUs (such as lowrisc-ibex or sifive-u54) but does enable the Hypervisor extensions by default for the virt machine. Signed-off-by: Alistair Francis --- target/riscv/cpu.c | 2 +- 1 file

[PATCH 2/7] hw/intc: sifive_plic: Cleanup the write function

2021-12-07 Thread Alistair Francis
From: Alistair Francis Signed-off-by: Alistair Francis Reviewed-by: Bin Meng --- hw/intc/sifive_plic.c | 82 +-- 1 file changed, 33 insertions(+), 49 deletions(-) diff --git a/hw/intc/sifive_plic.c b/hw/intc/sifive_plic.c index 35f097799a..c1fa689868

[PATCH 3/7] hw/intc: sifive_plic: Cleanup the read function

2021-12-07 Thread Alistair Francis
From: Alistair Francis Signed-off-by: Alistair Francis Reviewed-by: Bin Meng --- hw/intc/sifive_plic.c | 55 +-- 1 file changed, 11 insertions(+), 44 deletions(-) diff --git a/hw/intc/sifive_plic.c b/hw/intc/sifive_plic.c index c1fa689868..7f9715a584

[PATCH 5/7] target/riscv: Mark the Hypervisor extension as non experimental

2021-12-07 Thread Alistair Francis
From: Alistair Francis The Hypervisor spec is now frozen, so remove the experimental tag. Signed-off-by: Alistair Francis --- target/riscv/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index f812998123..1edb2771b4 100644 ---

Re: [PATCH v10 00/77] support vector extension v1.0

2021-12-07 Thread Alistair Francis
On Mon, Nov 29, 2021 at 1:04 PM wrote: > > From: Frank Chang > > This patchset implements the vector extension v1.0 for RISC-V on QEMU. > > RVV v1.0 spec is now fronzen for public review: > https://github.com/riscv/riscv-v-spec/releases/tag/v1.0 > > The port is available here: >

[PATCH 0/7] A collection of RISC-V cleanups and improvements

2021-12-07 Thread Alistair Francis
From: Alistair Francis This is a few patches to cleanup some RISC-V hardware and mark the Hyperisor extension as non experimental. Alistair Francis (7): hw/intc: sifive_plic: Add a reset function hw/intc: sifive_plic: Cleanup the write function hw/intc: sifive_plic: Cleanup the read

[PATCH 1/7] hw/intc: sifive_plic: Add a reset function

2021-12-07 Thread Alistair Francis
From: Alistair Francis Signed-off-by: Alistair Francis --- hw/intc/sifive_plic.c | 12 1 file changed, 12 insertions(+) diff --git a/hw/intc/sifive_plic.c b/hw/intc/sifive_plic.c index 877e76877c..35f097799a 100644 --- a/hw/intc/sifive_plic.c +++ b/hw/intc/sifive_plic.c @@ -355,6

Re: [RFC] vhost-vdpa-net: add vhost-vdpa-net host device support

2021-12-07 Thread Jason Wang
On Wed, Dec 8, 2021 at 1:20 PM Longpeng(Mike) wrote: > > From: Longpeng > > Hi guys, > > This patch introduces vhost-vdpa-net device, which is inspired > by vhost-user-blk and the proposal of vhost-vdpa-blk device [1]. > > I've tested this patch on Huawei's offload card: >

[RFC] vhost-vdpa-net: add vhost-vdpa-net host device support

2021-12-07 Thread Longpeng(Mike)
From: Longpeng Hi guys, This patch introduces vhost-vdpa-net device, which is inspired by vhost-user-blk and the proposal of vhost-vdpa-blk device [1]. I've tested this patch on Huawei's offload card: ./x86_64-softmmu/qemu-system-x86_64 \ -device

[PATCH] Adding Cédric's repos in MAINTAINERS file.

2021-12-07 Thread lagarcia
From: Leonardo Garcia Signed-off-by: Leonardo Garcia --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 7543eb4d59..52c6b99763 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -273,6 +273,7 @@ F: hw/ppc/ppc.c F: hw/ppc/ppc_booke.c F:

Re: [PATCH v10 77/77] target/riscv: rvv-1.0: Add ELEN checks for widening and narrowing instructions

2021-12-07 Thread Alistair Francis
On Mon, Nov 29, 2021 at 1:54 PM wrote: > > From: Frank Chang > > SEW has the limitation which cannot exceed ELEN. > > Widening instructions have a destination group with EEW = 2*SEW > and narrowing instructions have a source operand with EEW = 2*SEW. > Both of the instructions have the

[PATCH v2] docs: Introducing pseries documentation.

2021-12-07 Thread lagarcia
From: Leonardo Garcia The purpose of this document is to substitute the content currently available in the QEMU wiki at [0]. This initial version does contain some additional content as well. Whenever this documentation gets upstream and is reflected in [1], the QEMU wiki will be edited to point

Re: [PATCH v10 70/77] target/riscv: rvv-1.0: floating-point reciprocal estimate instruction

2021-12-07 Thread Alistair Francis
On Mon, Nov 29, 2021 at 1:58 PM wrote: > > From: Frank Chang > > Implement the floating-point reciprocal estimate to 7 bits instruction. > > Signed-off-by: Frank Chang Acked-by: Alistair Francis Alistair > --- > target/riscv/helper.h | 4 + > target/riscv/insn32.decode

Re: [PATCH v10 69/77] target/riscv: rvv-1.0: floating-point reciprocal square-root estimate instruction

2021-12-07 Thread Alistair Francis
On Mon, Nov 29, 2021 at 1:57 PM wrote: > > From: Frank Chang > > Implement the floating-point reciprocal square-root estimate to 7 bits > instruction. > > Signed-off-by: Frank Chang Acked-by: Alistair Francis Alistair > --- > target/riscv/helper.h | 4 + >

Re: [PATCH v3 1/1] target/riscv: Fix PMP propagation for tlb

2021-12-07 Thread Alistair Francis
On Tue, Nov 23, 2021 at 7:09 PM LIU Zhiwei wrote: > > Only the pmp index that be checked by pmp_hart_has_privs can be used > by pmp_get_tlb_size to avoid an error pmp index. > > Before modification, we may use an error pmp index. For example, > we check address 0x4fc, and the size 0x4 in

Re: [PATCH v3 1/1] target/riscv: Fix PMP propagation for tlb

2021-12-07 Thread Alistair Francis
On Tue, Nov 23, 2021 at 7:09 PM LIU Zhiwei wrote: > > Only the pmp index that be checked by pmp_hart_has_privs can be used > by pmp_get_tlb_size to avoid an error pmp index. > > Before modification, we may use an error pmp index. For example, > we check address 0x4fc, and the size 0x4 in

Re: dozens of qemu/kvm VMs getting into stuck states since kernel ~5.13

2021-12-07 Thread Sean Christopherson
On Tue, Dec 07, 2021, Chris Murphy wrote: > cc: qemu-devel > > Hi, > > I'm trying to help progress a very troublesome and so far elusive bug > we're seeing in Fedora infrastructure. When running dozens of qemu-kvm > VMs simultaneously, eventually they become unresponsive, as well as > new

[PATCH 12/12] s390x/pci: let intercept devices have separate PCI groups

2021-12-07 Thread Matthew Rosato
Let's use the reserved pool of simulated PCI groups to allow intercept devices to have separate groups from interpreted devices as some group values may be different. If we run out of simulated PCI groups, subsequent intercept devices just get the default group. Furthermore, if we encounter any

[PATCH 07/12] s390x/pci: enable for load/store intepretation

2021-12-07 Thread Matthew Rosato
Use the associated vfio feature ioctl to enable interpretation for devices when requested. As part of this process, we must use the host function handle rather than a QEMU-generated one -- this is provided as part of the ioctl payload. Signed-off-by: Matthew Rosato --- hw/s390x/s390-pci-bus.c

[PATCH 06/12] target/s390x: add zpci-interp to cpu models

2021-12-07 Thread Matthew Rosato
The zpci-interp feature is used to specify whether zPCI interpretation is to be used for this guest. Signed-off-by: Matthew Rosato --- target/s390x/cpu_features_def.h.inc | 1 + target/s390x/gen-features.c | 2 ++ target/s390x/kvm/kvm.c | 1 + 3 files changed, 4

[PATCH 04/12] Update linux headers

2021-12-07 Thread Matthew Rosato
This is a placeholder that pulls in 5.16-rc4 + unmerged kernel changes required by this item. A proper header sync can be done once the associated kernel code merges. Signed-off-by: Matthew Rosato --- include/standard-headers/asm-x86/kvm_para.h | 1 +

[PATCH 11/12] s390x/pci: use dtsm provided from vfio capabilities for interpreted devices

2021-12-07 Thread Matthew Rosato
When using the IOAT assist via interpretation, we should advertise what the host driver supports, not QEMU. Signed-off-by: Matthew Rosato --- hw/s390x/s390-pci-vfio.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/s390x/s390-pci-vfio.c b/hw/s390x/s390-pci-vfio.c

[PATCH 05/12] virtio-gpu: do not byteswap padding

2021-12-07 Thread Matthew Rosato
From: Paolo Bonzini In Linux 5.16, the padding of struct virtio_gpu_ctrl_hdr has become a single-byte field followed by a uint8_t[3] array of padding bytes, and virtio_gpu_ctrl_hdr_bswap does not compile anymore. Signed-off-by: Paolo Bonzini Reviewed-by: Alex Bennée Reviewed-by: Michael S.

[PATCH 09/12] s390x/pci: enable adapter event notification for interpreted devices

2021-12-07 Thread Matthew Rosato
Use the associated vfio feature ioctl to enable adapter event notification and forwarding for devices when requested. This feature will be set up with or without firmware assist based upon the 'intassist' setting. Signed-off-by: Matthew Rosato --- hw/s390x/s390-pci-bus.c | 24

[PATCH 10/12] s390x/pci: use I/O Address Translation assist when interpreting

2021-12-07 Thread Matthew Rosato
Allow the underlying kvm host to handle the Refresh PCI Translation instruction intercepts. Signed-off-by: Matthew Rosato --- hw/s390x/s390-pci-bus.c | 6 ++-- hw/s390x/s390-pci-inst.c | 51 ++-- hw/s390x/s390-pci-vfio.c | 33

[PATCH 02/12] s390x/pci: don't use hard-coded dma range in reg_ioat

2021-12-07 Thread Matthew Rosato
Instead use the values from clp info, they will either be the hard-coded values or what came from the host driver via vfio. Fixes: 9670ee752727 ("s390x/pci: use a PCI Function structure") Reviewed-by: Eric Farman Reviewed-by: Pierre Morel Signed-off-by: Matthew Rosato ---

[PATCH 03/12] s390x/pci: add supported DT information to clp response

2021-12-07 Thread Matthew Rosato
The DTSM is a mask that specifies which I/O Address Translation designation types are supported. Today QEMU only supports DT=1. Reviewed-by: Pierre Morel Reviewed-by: Eric Farman Signed-off-by: Matthew Rosato --- hw/s390x/s390-pci-bus.c | 1 + hw/s390x/s390-pci-inst.c| 1 +

[PATCH 08/12] s390x/pci: don't fence interpreted devices without MSI-X

2021-12-07 Thread Matthew Rosato
Lack of MSI-X support is not an issue for interpreted passthrough devices, so let's let these in. This will allow, for example, ISM devices to be passed through -- but only when interpretation is available and being used. Signed-off-by: Matthew Rosato --- hw/s390x/s390-pci-bus.c | 2 +- 1 file

[PATCH 01/12] s390x/pci: use a reserved ID for the default PCI group

2021-12-07 Thread Matthew Rosato
The current default PCI group being used can technically collide with a real group ID passed from a hostdev. Let's instead use a group ID that comes from a special pool (0xF0-0xFF) that is architected to be reserved for simulated devices. Fixes: 28dc86a072 ("s390x/pci: use a PCI Group

[PATCH 00/12] s390x/pci: zPCI interpretation support

2021-12-07 Thread Matthew Rosato
Note: The first 3 patches of this series are included as pre-reqs, but should be pulled via a separate series. Also, patch 5 is needed to support 5.16+ linux header-sync and was already done by Paolo but not merged yet so is thus included here as well. For QEMU, the majority of the work in

[PATCH v2 1/2] spice: Update QXLInterface for spice >= 0.15.0

2021-12-07 Thread John Snow
spice updated the spelling (and arguments) of "attache_worker" in 0.15.0. Update QEMU to match, preventing -Wdeprecated-declarations compilations from reporting build errors. See also: https://gitlab.freedesktop.org/spice/spice/-/commit/974692bda1e77af92b71ed43b022439448492cb9 Signed-off-by:

[PATCH v2 2/2] ui/clipboard: Don't use g_autoptr just to free a variable

2021-12-07 Thread John Snow
Clang doesn't recognize that the variable is being "used" and will emit a warning: ../ui/clipboard.c:47:34: error: variable 'old' set but not used [-Werror,-Wunused-but-set-variable] g_autoptr(QemuClipboardInfo) old = NULL; ^ 1 error generated. OK,

Re: [PATCH] docs: Introducing pseries documentation.

2021-12-07 Thread Leonardo Augusto Guimarães Garcia
Hi Cédric, On 11/18/21 05:57, Cédric Le Goater wrote: > Hello Leonardo, > > On 11/17/21 21:14, lagar...@linux.ibm.com wrote: >> From: Leonardo Garcia >> >> The purpose of this document is to substitute the content currently >> available in the QEMU wiki at [0]. This initial version does contain

[PATCH v2 0/2] Misc: build fixes for Fedora 35, Ubuntu et al

2021-12-07 Thread John Snow
I didn't push this through in time for 6.2, so this series just worries about the little fixes necessary for building QEMU under Fedora 35 and the latest Ubuntu distributions. The actual container changes have been cut off of this series in favor of Dan's larger series that switches us over to

Re: [PATCH v2 for 6.2?] gicv3: fix ICH_MISR's LRENP computation

2021-12-07 Thread Peter Maydell
On Tue, 7 Dec 2021 at 15:49, Damien Hedde wrote: > > > > On 12/7/21 16:45, Peter Maydell wrote: > > On Tue, 7 Dec 2021 at 15:24, Peter Maydell wrote: > >> The bug is a bug in any case and we'll fix it, it's just a > >> question of whether it meets the bar to go into 6.2, which is > >> hopefully

[PATCH v3 1/1] multifd: Shut down the QIO channels to avoid blocking the send threads when they are terminated

2021-12-07 Thread Li Zhang
When doing live migration with multifd channels 8, 16 or larger number, the guest hangs in the presence of the network errors such as missing TCP ACKs. At sender's side: The main thread is blocked on qemu_thread_join, migration_fd_cleanup is called because one thread fails on

dozens of qemu/kvm VMs getting into stuck states since kernel ~5.13

2021-12-07 Thread Chris Murphy
cc: qemu-devel Hi, I'm trying to help progress a very troublesome and so far elusive bug we're seeing in Fedora infrastructure. When running dozens of qemu-kvm VMs simultaneously, eventually they become unresponsive, as well as new processes as we try to extract information from the host about

Re: [PULL for-6.2 0/1] target-arm queue

2021-12-07 Thread Richard Henderson
into staging (2021-12-06 11:18:06 -0800) are available in the Git repository at: https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20211207 for you to fetch changes up to 2958e5150dfa297dd5a51fe57a29156b8744f07f: gicv3: fix ICH_MISR's LRENP computation (2021-12-07 15:30:08

Re: [PATCH v2 1/3] qmp: Support for querying stats

2021-12-07 Thread Daniel P . Berrangé
Copying in Markus as QAPI maintainer, since I feel this proposed design is a little oddball from typical QAPI design approach On Fri, Nov 19, 2021 at 01:51:51PM -0600, Mark Kanda wrote: > Introduce qmp support for querying stats. Provide a framework for > adding new stats and support for the

Re: [PATCH 0/3] iotests: multiprocessing!!

2021-12-07 Thread John Snow
On Mon, Dec 6, 2021 at 3:26 PM Vladimir Sementsov-Ogievskiy < vsement...@virtuozzo.com> wrote: > 06.12.2021 21:37, John Snow wrote: > > > > > > On Fri, Dec 3, 2021 at 7:22 AM Vladimir Sementsov-Ogievskiy < > vsement...@virtuozzo.com > wrote: > > > > Hi all! >

Re: [PATCH] fuzz: pass failures from child process into libfuzzer engine

2021-12-07 Thread Alexander Bulekov
On 211206 2348, Konstantin Khlebnikov wrote: >  >  >06.12.2021, 19:35, "Alexander Bulekov" <[1]alx...@bu.edu>: > > On 211205 1917, Konstantin Khlebnikov wrote: > > Fuzzer is supposed to stop when first bug is found and report >failure. > Present fuzzers

Re: [PATCH v7 1/7] net/vmnet: add vmnet dependency and customizable option

2021-12-07 Thread Vladislav Yaroshchuk
If you meant patch series cover letter, it exists, see https://patchew.org/QEMU/20211207101828.22033-1-yaroshchuk2...@gmail.com/ вт, 7 дек. 2021 г. в 17:12, Markus Armbruster : > No cover letter? > > -- Best Regards, Vladislav Yaroshchuk

[PULL 1/1] gicv3: fix ICH_MISR's LRENP computation

2021-12-07 Thread Peter Maydell
From: Damien Hedde According to the "Arm Generic Interrupt Controller Architecture Specification GIC architecture version 3 and 4" (version G: page 345 for aarch64 or 509 for aarch32): LRENP bit of ICH_MISR is set when ICH_HCR.LRENPIE==1 and ICH_HCR.EOIcount is non-zero. When only LRENPIE was

[PATCH v7 2/4] tests/qtest: add some tests for virtio-net failover

2021-12-07 Thread Laurent Vivier
Add test cases to test several error cases that must be generated by invalid failover configuration. Add a combination of coldplug and hotplug test cases to be sure the primary is correctly managed according the presence or not of the STANDBY feature. Signed-off-by: Laurent Vivier ---

[PULL for-6.2 0/1] target-arm queue

2021-12-07 Thread Peter Maydell
in the Git repository at: https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20211207 for you to fetch changes up to 2958e5150dfa297dd5a51fe57a29156b8744f07f: gicv3: fix ICH_MISR's LRENP computation (2021-12-07 15:30:08 +

[PATCH v7 1/4] qtest/libqos: add a function to initialize secondary PCI buses

2021-12-07 Thread Laurent Vivier
Scan the PCI devices to find bridge and set PCI_SECONDARY_BUS and PCI_SUBORDINATE_BUS (algorithm from seabios) Signed-off-by: Laurent Vivier Acked-by: Thomas Huth --- include/hw/pci/pci_bridge.h | 8 +++ tests/qtest/libqos/pci.c| 118

[PATCH v7 0/4] tests/qtest: add some tests for virtio-net failover

2021-12-07 Thread Laurent Vivier
This series adds a qtest entry to test virtio-net failover feature. We check following error cases: - check missing id on device with failover_pair_id triggers an error - check a primary device plugged on a bus that doesn't support hotplug triggers an error We check the status of the machine

Re: [PULL 0/1] tcg patch queue for 6.2

2021-12-07 Thread Richard Henderson
://gitlab.com/rth7680/qemu.git tags/pull-tcg-20211207 for you to fetch changes up to b9537d5904f6e3df896264a6144883ab07db9608: tcg/arm: Reduce vector alignment requirement for NEON (2021-12-07 06:32:09 -0800) Fix stack spills for arm neon

[PATCH v7 3/4] test/libqtest: add some virtio-net failover migration cancelling tests

2021-12-07 Thread Laurent Vivier
Add some tests to check the state of the machine if the migration is cancelled while we are using virtio-net failover. Signed-off-by: Laurent Vivier Acked-by: Thomas Huth --- tests/qtest/virtio-net-failover.c | 276 ++ 1 file changed, 276 insertions(+) diff --git

[PATCH v7 4/4] tests/libqtest: add a migration test with two couples of failover devices

2021-12-07 Thread Laurent Vivier
Signed-off-by: Laurent Vivier Acked-by: Thomas Huth --- tests/qtest/virtio-net-failover.c | 277 ++ 1 file changed, 277 insertions(+) diff --git a/tests/qtest/virtio-net-failover.c b/tests/qtest/virtio-net-failover.c index f3d4ba69f51b..43d32ce17ba4 100644 ---

RE: [PATCH for-7.0 2/4] target/hexagon/cpu.h: don't include qemu-common.h

2021-12-07 Thread Taylor Simpson
> -Original Message- > From: Peter Maydell > Sent: Monday, November 29, 2021 2:05 PM > To: qemu-...@nongnu.org; qemu-devel@nongnu.org > Cc: Paolo Bonzini ; Sergio Lopez ; > Taylor Simpson ; Yoshinori Sato > ; Marcel Apfelbaum > > Subject: [PATCH for-7.0 2/4] target/hexagon/cpu.h:

Re: [PATCH RFC 00/11] vl: Explore redesign of startup

2021-12-07 Thread Damien Hedde
Hi Markus, It looks promising. I did not think we could so "easily" have a new working startup. But I'm not so sure that I understand how we should progress from here. I see 3 main parts in this: A. introducing new binary (meson, ...) B. startup api: phase related stuff (maybe more) C. cli

Re: [RFC v3 0/4] tls: add macros for coroutine-safe TLS variables

2021-12-07 Thread Stefan Hajnoczi
On Tue, Dec 07, 2021 at 01:55:34PM +, Peter Maydell wrote: > On Tue, 7 Dec 2021 at 13:53, Stefan Hajnoczi wrote: > > > > On Mon, Dec 06, 2021 at 02:34:45PM +, Peter Maydell wrote: > > > On Mon, 6 Dec 2021 at 14:33, Stefan Hajnoczi wrote: > > > > > > > > v3: > > > > - Added

Re: [PATCH] spec: Add NBD_OPT_EXTENDED_HEADERS

2021-12-07 Thread Wouter Verhelst
On Mon, Dec 06, 2021 at 05:00:47PM -0600, Eric Blake wrote: > On Mon, Dec 06, 2021 at 02:40:45PM +0300, Vladimir Sementsov-Ogievskiy wrote: > > > Simple reply message > > > > > > The simple reply message MUST be sent by the server in response to all > > > requests if structured replies

Re: [PATCH] tests/docker: add libfuse3 development headers

2021-12-07 Thread Richard W.M. Jones
On Tue, Dec 07, 2021 at 04:00:25PM +, Stefan Hajnoczi wrote: ... > diff --git a/tests/docker/dockerfiles/centos8.docker > b/tests/docker/dockerfiles/centos8.docker > index 7f135f8e8c..a2dae4be29 100644 > --- a/tests/docker/dockerfiles/centos8.docker > +++

[PATCH] tests/docker: add libfuse3 development headers

2021-12-07 Thread Stefan Hajnoczi
The FUSE exports feature is not built because most container images do not have libfuse3 development headers installed. Add the necessary packages to the Dockerfiles. Cc: Hanna Reitz Cc: Richard W.M. Jones Signed-off-by: Stefan Hajnoczi --- tests/docker/dockerfiles/alpine.docker| 1 +

Re: [PATCH v2 for 6.2?] gicv3: fix ICH_MISR's LRENP computation

2021-12-07 Thread Damien Hedde
On 12/7/21 16:45, Peter Maydell wrote: On Tue, 7 Dec 2021 at 15:24, Peter Maydell wrote: The bug is a bug in any case and we'll fix it, it's just a question of whether it meets the bar to go into 6.2, which is hopefully going to have its final RC tagged today. If this patch had arrived a

Re: [PATCH v2 for 6.2?] gicv3: fix ICH_MISR's LRENP computation

2021-12-07 Thread Peter Maydell
On Tue, 7 Dec 2021 at 15:24, Peter Maydell wrote: > The bug is a bug in any case and we'll fix it, it's just a > question of whether it meets the bar to go into 6.2, which is > hopefully going to have its final RC tagged today. If this > patch had arrived a week ago then the bar would have been >

Re: [PATCH v2 0/1] migration: multifd live migration improvement

2021-12-07 Thread Li Zhang
On 12/7/21 3:16 PM, Daniel P. Berrangé wrote: On Tue, Dec 07, 2021 at 02:45:10PM +0100, Li Zhang wrote: On 12/6/21 8:54 PM, Dr. David Alan Gilbert wrote: * Li Zhang (lizh...@suse.de) wrote: When testing live migration with multifd channels (8, 16, or a bigger number) and using qemu

RE: [PATCH v2 for 6.2?] gicv3: fix ICH_MISR's LRENP computation

2021-12-07 Thread Brian Cain
> -Original Message- > From: Peter Maydell ... > On Tue, 7 Dec 2021 at 15:18, Brian Cain wrote: > > Peter Maydell wrote: > > > I won't try to put this into 6.2 unless you have a common guest > > > that runs into this bug. > > > I know that Qualcomm encounters this issue with its

Re: [PATCH v2 for 6.2?] gicv3: fix ICH_MISR's LRENP computation

2021-12-07 Thread Peter Maydell
On Tue, 7 Dec 2021 at 15:18, Brian Cain wrote: > Peter Maydell wrote: > > I won't try to put this into 6.2 unless you have a common guest > > that runs into this bug. > I know that Qualcomm encounters this issue with its hypervisor > (https://github.com/quic/gunyah-hypervisor). Apologies for

Re: [PATCH v2 for 6.2?] gicv3: fix ICH_MISR's LRENP computation

2021-12-07 Thread Damien Hedde
On 12/7/21 15:21, Peter Maydell wrote: On Tue, 7 Dec 2021 at 09:44, Damien Hedde wrote: According to the "Arm Generic Interrupt Controller Architecture Specification GIC architecture version 3 and 4" (version G: page 345 for aarch64 or 509 for aarch32): LRENP bit of ICH_MISR is set when

RE: [PATCH v2 for 6.2?] gicv3: fix ICH_MISR's LRENP computation

2021-12-07 Thread Brian Cain
> -Original Message- > From: Qemu-devel > On Behalf Of Peter Maydell ... > On Tue, 7 Dec 2021 at 09:44, Damien Hedde > wrote: > > > > According to the "Arm Generic Interrupt Controller Architecture > > Specification GIC architecture version 3 and 4" (version G: page 345 > > for aarch64

Re: [PATCH v1 2/2] osdep: support mempolicy for preallocation in os_mem_prealloc

2021-12-07 Thread David Hildenbrand
On 07.12.21 14:58, Daniil Tatianin wrote: > I believe you're right. Looking at the implementation of > shmem_alloc_page, it uses the inode policy, which is set via > vma->set_policy (from the mbind() call in this case). set_mempolicy is > both useless and redundant here, as thread's > policy is

Re: [PATCH v1 1/1] osdep: asynchronous teardown for shutdown on Linux

2021-12-07 Thread Halil Pasic
On Mon, 6 Dec 2021 11:47:55 + Daniel P. Berrangé wrote: > On Mon, Dec 06, 2021 at 12:43:12PM +0100, Claudio Imbrenda wrote: > > On Mon, 6 Dec 2021 11:21:10 + > > Daniel P. Berrangé wrote: > > > > > On Mon, Dec 06, 2021 at 12:06:11PM +0100, Claudio Imbrenda wrote: > > > > This patch

[PULL 1/1] tcg/arm: Reduce vector alignment requirement for NEON

2021-12-07 Thread Richard Henderson
With arm32, the ABI gives us 8-byte alignment for the stack. While it's possible to realign the stack to provide 16-byte alignment, it's far easier to simply not encode 16-byte alignment in the VLD1 and VST1 instructions that we emit. Remove the assertion in temp_allocate_frame, limit natural

[PULL 0/1] tcg patch queue for 6.2

2021-12-07 Thread Richard Henderson
The following changes since commit 7635eff97104242d618400e4b6746d0a5c97af82: Merge tag 'block-pull-request' of https://gitlab.com/stefanha/qemu into staging (2021-12-06 11:18:06 -0800) are available in the Git repository at: https://gitlab.com/rth7680/qemu.git tags/pull-tcg-20211207

Re: [PATCH 07/14] ppc/pnv: Introduce a num_pecs class attribute for PHB4 PEC devices

2021-12-07 Thread Cédric Le Goater
On 12/7/21 15:03, Frederic Barrat wrote: On 07/12/2021 11:45, Cédric Le Goater wrote: On 12/7/21 11:00, Frederic Barrat wrote: On 02/12/2021 15:42, Cédric Le Goater wrote: POWER9 processor comes with 3 PHB4 PECs (PCI Express Controller) and each PEC can have several PHBs :    * PEC0

Re: [PATCH v2 for 6.2?] gicv3: fix ICH_MISR's LRENP computation

2021-12-07 Thread Peter Maydell
On Tue, 7 Dec 2021 at 09:44, Damien Hedde wrote: > > According to the "Arm Generic Interrupt Controller Architecture > Specification GIC architecture version 3 and 4" (version G: page 345 > for aarch64 or 509 for aarch32): > LRENP bit of ICH_MISR is set when ICH_HCR.LRENPIE==1 and >

Re: [PATCH v2 0/1] migration: multifd live migration improvement

2021-12-07 Thread Daniel P . Berrangé
On Tue, Dec 07, 2021 at 02:45:10PM +0100, Li Zhang wrote: > > On 12/6/21 8:54 PM, Dr. David Alan Gilbert wrote: > > * Li Zhang (lizh...@suse.de) wrote: > > > When testing live migration with multifd channels (8, 16, or a bigger > > > number) > > > and using qemu -incoming (without "defer"), if a

Re: [PATCH v7 1/7] net/vmnet: add vmnet dependency and customizable option

2021-12-07 Thread Markus Armbruster
No cover letter?

Re: [PATCH 07/14] ppc/pnv: Introduce a num_pecs class attribute for PHB4 PEC devices

2021-12-07 Thread Frederic Barrat
On 07/12/2021 11:45, Cédric Le Goater wrote: On 12/7/21 11:00, Frederic Barrat wrote: On 02/12/2021 15:42, Cédric Le Goater wrote: POWER9 processor comes with 3 PHB4 PECs (PCI Express Controller) and each PEC can have several PHBs :    * PEC0 provides 1 PHB  (PHB0)    * PEC1 provides 2

Re: [PATCH v1 2/2] osdep: support mempolicy for preallocation in os_mem_prealloc

2021-12-07 Thread Daniil Tatianin
I believe you're right. Looking at the implementation of shmem_alloc_page, it uses the inode policy, which is set viavma->set_policy (from the mbind() call in this case). set_mempolicy is both useless and redundant here, as thread'spolicy is only ever used in case vma->get_policy returns NULL

Re: [RFC v3 0/4] tls: add macros for coroutine-safe TLS variables

2021-12-07 Thread Peter Maydell
On Tue, 7 Dec 2021 at 13:53, Stefan Hajnoczi wrote: > > On Mon, Dec 06, 2021 at 02:34:45PM +, Peter Maydell wrote: > > On Mon, 6 Dec 2021 at 14:33, Stefan Hajnoczi wrote: > > > > > > v3: > > > - Added __attribute__((weak)) to get_ptr_*() [Florian] > > > > Do we really need it *only* on

Re: [RFC v3 0/4] tls: add macros for coroutine-safe TLS variables

2021-12-07 Thread Stefan Hajnoczi
On Mon, Dec 06, 2021 at 02:34:45PM +, Peter Maydell wrote: > On Mon, 6 Dec 2021 at 14:33, Stefan Hajnoczi wrote: > > > > v3: > > - Added __attribute__((weak)) to get_ptr_*() [Florian] > > Do we really need it *only* on get_ptr_*() ? If we need to > noinline the other two we probably also

Re: [PATCH v2 1/1] multifd: Shut down the QIO channels to avoid blocking the send threads when they are terminated.

2021-12-07 Thread Li Zhang
On 12/6/21 8:50 PM, Dr. David Alan Gilbert wrote: * Li Zhang (lizh...@suse.de) wrote: Thanks for Daniel's review. Hi David and Juan, Any comments for this patch? Yeh I think that's OK, so Reviewed-by: Dr. David Alan Gilbert I'd have a slight preference for it being before the post I

Re: [PATCH v2 0/1] migration: multifd live migration improvement

2021-12-07 Thread Li Zhang
On 12/6/21 8:54 PM, Dr. David Alan Gilbert wrote: * Li Zhang (lizh...@suse.de) wrote: When testing live migration with multifd channels (8, 16, or a bigger number) and using qemu -incoming (without "defer"), if a network error occurs (for example, triggering the kernel SYN flooding

Re: [PATCH v2 for 6.2?] gicv3: fix ICH_MISR's LRENP computation

2021-12-07 Thread Peter Maydell
On Tue, 7 Dec 2021 at 13:05, Damien Hedde wrote: > On 12/7/21 13:45, Philippe Mathieu-Daudé wrote: > > On 12/7/21 10:44, Damien Hedde wrote: > >> According to the "Arm Generic Interrupt Controller Architecture > >> Specification GIC architecture version 3 and 4" (version G: page 345 > >> for

Re: [RFC v3 0/4] tls: add macros for coroutine-safe TLS variables

2021-12-07 Thread Stefan Hajnoczi
On Mon, Dec 06, 2021 at 02:34:45PM +, Peter Maydell wrote: > On Mon, 6 Dec 2021 at 14:33, Stefan Hajnoczi wrote: > > > > v3: > > - Added __attribute__((weak)) to get_ptr_*() [Florian] > > Do we really need it *only* on get_ptr_*() ? If we need to > noinline the other two we probably also

[PATCH v3 6/6] virtio: unify dataplane and non-dataplane ->handle_output()

2021-12-07 Thread Stefan Hajnoczi
Now that virtio-blk and virtio-scsi are ready, get rid of the handle_aio_output() callback. It's no longer needed. Signed-off-by: Stefan Hajnoczi --- include/hw/virtio/virtio.h | 4 +-- hw/block/dataplane/virtio-blk.c | 16 ++ hw/scsi/virtio-scsi-dataplane.c | 54

[PATCH v3 1/6] aio-posix: split poll check from ready handler

2021-12-07 Thread Stefan Hajnoczi
Adaptive polling measures the execution time of the polling check plus handlers called when a polled event becomes ready. Handlers can take a significant amount of time, making it look like polling was running for a long time when in fact the event handler was running for a long time. For

[PATCH v3 5/6] virtio: use ->handle_output() instead of ->handle_aio_output()

2021-12-07 Thread Stefan Hajnoczi
The difference between ->handle_output() and ->handle_aio_output() was that ->handle_aio_output() returned a bool return value indicating progress. This was needed by the old polling API but now that the bool return value is gone, the two functions can be unified. Signed-off-by: Stefan Hajnoczi

[PATCH v3 2/6] virtio: get rid of VirtIOHandleAIOOutput

2021-12-07 Thread Stefan Hajnoczi
The virtqueue host notifier API virtio_queue_aio_set_host_notifier_handler() polls the virtqueue for new buffers. AioContext previously required a bool progress return value indicating whether an event was handled or not. This is no longer necessary because the AioContext polling API has been

[PATCH v3 3/6] virtio-blk: drop unused virtio_blk_handle_vq() return value

2021-12-07 Thread Stefan Hajnoczi
The return value of virtio_blk_handle_vq() is no longer used. Get rid of it. This is a step towards unifying the dataplane and non-dataplane virtqueue handler functions. Prepare virtio_blk_handle_output() to be used by both dataplane and non-dataplane by making the condition for starting

[PATCH v3 4/6] virtio-scsi: prepare virtio_scsi_handle_cmd for dataplane

2021-12-07 Thread Stefan Hajnoczi
Prepare virtio_scsi_handle_cmd() to be used by both dataplane and non-dataplane by making the condition for starting ioeventfd more specific. This way it won't trigger when dataplane has already been started. Signed-off-by: Stefan Hajnoczi --- hw/scsi/virtio-scsi.c | 2 +- 1 file changed, 1

[PATCH v3 0/6] aio-posix: split poll check from ready handler

2021-12-07 Thread Stefan Hajnoczi
v3: - Fixed FUSE export aio_set_fd_handler() call that I missed and double-checked for any other missing call sites using Coccinelle [Rich] v2: - Cleaned up unused return values in nvme and virtio-blk [Stefano] - Documented try_poll_mode() ready_list argument [Stefano] - Unified virtio-blk/scsi

Re: [PATCH v2 for 6.2?] gicv3: fix ICH_MISR's LRENP computation

2021-12-07 Thread Damien Hedde
On 12/7/21 13:45, Philippe Mathieu-Daudé wrote: On 12/7/21 10:44, Damien Hedde wrote: According to the "Arm Generic Interrupt Controller Architecture Specification GIC architecture version 3 and 4" (version G: page 345 for aarch64 or 509 for aarch32): LRENP bit of ICH_MISR is set when

Re: [PATCH v2 for 6.2?] gicv3: fix ICH_MISR's LRENP computation

2021-12-07 Thread Philippe Mathieu-Daudé
On 12/7/21 10:44, Damien Hedde wrote: > According to the "Arm Generic Interrupt Controller Architecture > Specification GIC architecture version 3 and 4" (version G: page 345 > for aarch64 or 509 for aarch32): > LRENP bit of ICH_MISR is set when ICH_HCR.LRENPIE==1 and > ICH_HCR.EOIcount is

  1   2   >