Re: [PATCH 4/6] target/arm: Implement FEAT_LVA

2022-01-06 Thread Peter Maydell
On Wed, 8 Dec 2021 at 23:16, Richard Henderson wrote: > > This feature is relatively small, as it applies only to > 64k pages and thus requires no additional changes to the > table descriptor walking algorithm, only a change to the > minimum TSZ (which is the inverse of the maximum virtual >

Re: [PATCH 3/6] target/arm: Honor TCR_ELx.{I}PS

2022-01-06 Thread Peter Maydell
On Wed, 8 Dec 2021 at 23:18, Richard Henderson wrote: > > This field controls the output (intermediate) physical address size > of the translation process. V8 requires to raise an AddressSize > fault if the page tables are programmed incorrectly, such that any > intermediate descriptor address,

Re: [PATCH] target/riscv: Fix position of 'experimental' comment

2022-01-06 Thread Philippe Mathieu-Daudé
Cc'ing qemu-trivial@ On 6/1/22 14:40, Philipp Tomsich wrote: When commit 0643c12e4b dropped the 'x-' prefix for Zb[abcs] and set them to be enabled by default, the comment about experimental extensions was kept in place above them. This moves it down a few lines to only cover experimental

Re: [PATCH] net: Fix uninitialized data usage

2022-01-06 Thread Philippe Mathieu-Daudé
On 6/1/22 19:28, Patrick Venture wrote: From: Peter Foley e.g. 1109 15:16:20.151506 Uninitialized bytes in ioctl_common_pre at offset 0 inside [0x7ffc516af9b8, 4) 1109 15:16:20.151659 ==588974==WARNING: MemorySanitizer: use-of-uninitialized-value 1109 15:16:20.312923 #0

Re: [PATCH v2] tcg/loongarch64: Support raising sigbus for user-only

2022-01-06 Thread Richard Henderson
On 1/6/22 5:42 AM, WANG Xuerui wrote: Based-on:<20220104021543.396571-1-richard.hender...@linaro.org> Reviewed-by: Richard Henderson Signed-off-by: WANG Xuerui --- v2 -> v1: - Dropped assert and added comment documenting reason to choose bstrpick.d over andi for the masking operation -

Re: [PATCH V3] block/rbd: implement bdrv_co_block_status

2022-01-06 Thread Peter Lieven
t;>>>>>> +*map = offset; >>>>>>>> +*file = bs; >>>>>>>> +*pnum = bytes; >>>>>>>> + >>>>>>>> +/* check if RBD image supports fast-diff */ >>>>>>>> +

Re: [PATCH v2 1/5] hw/arm/virt: Key enablement of highmem PCIe on highmem_ecam

2022-01-06 Thread Marc Zyngier
Hi Eric, On Wed, 05 Jan 2022 09:41:19 +, Eric Auger wrote: > > couldn't you simply introduce highmem_redist which is truly missing. You > could set it in virt_set_memmap() in case you skip extended_map overlay > and use it in virt_gicv3_redist_region_count() as you did? > In addition to the

Re: [PATCH v2] hw/arm/virt: KVM: Enable PAuth when supported by the host

2022-01-06 Thread Marc Zyngier
On Thu, 06 Jan 2022 18:26:29 +, Richard Henderson wrote: > > Mm. It does beg the question of why KVM exposes multiple bits. If > they must be tied, then it only serves to make the interface more > complicated than necessary. We would be better served to have a > single bit to control all

Re: [PATCH V7 19/29] vfio-pci: cpr part 1 (fd and dma)

2022-01-06 Thread Steven Sistare
On 1/6/2022 4:12 AM, Michael S. Tsirkin wrote: > On Wed, Jan 05, 2022 at 06:24:25PM -0500, Steven Sistare wrote: >> On 1/5/2022 6:09 PM, Michael S. Tsirkin wrote: >>> On Wed, Jan 05, 2022 at 04:40:43PM -0500, Steven Sistare wrote: On 1/5/2022 4:14 PM, Michael S. Tsirkin wrote: > On Wed,

Re: [RFC PATCH] target/ppc: Remove xscmpnedp instruction

2022-01-06 Thread Richard Henderson
On 1/6/22 3:23 AM, Víctor Colombo wrote: xscmpnedp was added in ISA v3.0 but removed in v3.0B. This patch removes this instruction as it was not in the final version of v3.0. RFC to know if you think this is the correct approach. Should be fine. I assume the -cpu power9 that we intend to

[PATCH] net: Fix uninitialized data usage

2022-01-06 Thread Patrick Venture
From: Peter Foley e.g. 1109 15:16:20.151506 Uninitialized bytes in ioctl_common_pre at offset 0 inside [0x7ffc516af9b8, 4) 1109 15:16:20.151659 ==588974==WARNING: MemorySanitizer: use-of-uninitialized-value 1109 15:16:20.312923 #0 0x5639b88acb21 in tap_probe_vnet_hdr_len

Re: [PATCH 1/6] target/arm: Fault on invalid TCR_ELx.TxSZ

2022-01-06 Thread Peter Maydell
On Wed, 8 Dec 2021 at 23:16, Richard Henderson wrote: > > Without FEAT_LVA, the behaviour of programming an invalid value > is IMPLEMENTATION DEFINED. With FEAT_LVA, programming an invalid > minimum value requires a Translation fault. > > It is most self-consistent to choose to generate the

Re: [PATCH v2] hw/arm/virt: KVM: Enable PAuth when supported by the host

2022-01-06 Thread Richard Henderson
On 1/6/22 9:29 AM, Marc Zyngier wrote: On Thu, 06 Jan 2022 17:20:33 +, Richard Henderson wrote: On 1/6/22 1:16 AM, Marc Zyngier wrote: +static bool kvm_arm_pauth_supported(void) +{ +return (kvm_check_extension(kvm_state, KVM_CAP_ARM_PTRAUTH_ADDRESS) && +

Re: [PATCH] i386/tcg: generate an illegal op when translating AVX instructions

2022-01-06 Thread Richard Henderson
On 1/6/22 2:35 AM, Stevie Lavern wrote: The AVX instruction set is not supported by Qemu. However, some AVX instructions are properly decoded and emulated as their legacy SSE version. This patch prevent this by generating an illegal_op instead of a bogus SSE instruction. Signed-off-by: Stevie

Re: [PATCH v5 2/3] acpi: tpm: Add missing device identification objects

2022-01-06 Thread Stefan Berger
On 1/6/22 11:55, Igor Mammedov wrote: On Thu, 6 Jan 2022 09:01:36 -0500 Stefan Berger wrote: On 1/6/22 08:56, Michael S. Tsirkin wrote: On Thu, Jan 06, 2022 at 08:53:00AM -0500, Stefan Berger wrote: On 1/6/22 03:36, Igor Mammedov wrote: On Tue, 4 Jan 2022 12:58:05 -0500 Stefan Berger

Re: [PATCH V3] block/rbd: implement bdrv_co_block_status

2022-01-06 Thread Ilya Dryomov
pports fast-diff */ > >>>>>> +r = rbd_get_features(s->image, ); > >>>>>> +if (r < 0) { > >>>>>> +goto out; > >>>>>> +} > >>>>>> +if (!(features & RBD_FEATURE_FA

[PATCH] hw/sensor: enable setting adm1272 temperature with qmp

2022-01-06 Thread Patrick Venture
From: Titus Rwantare Reviewed-by: Patrick Venture Reviewed-by: Chris Rauer Reviewed-by: Hao Wu Signed-off-by: Titus Rwantare --- hw/sensor/adm1272.c| 27 ++- tests/qtest/adm1272-test.c | 28 +++- 2 files changed, 53 insertions(+), 2

Re: [PATCH] docs: Clarifications and formatting changes in ppc docs.

2022-01-06 Thread Cédric Le Goater
On 1/5/22 19:08, lagar...@linux.ibm.com wrote: From: Leonardo Garcia Signed-off-by: Leonardo Garcia Reviewed-by: Cédric Le Goater One comment below. Thanks, C. --- docs/specs/ppc-spapr-hcalls.rst | 22 - docs/system/ppc/pseries.rst | 43

Re: [PATCH v1] Add dummy Aspeed AST2600 Display Port MCU (DPMCU)

2022-01-06 Thread Peter Maydell
On Fri, 10 Dec 2021 at 14:05, Cédric Le Goater wrote: > > On 12/10/21 09:30, Troy Lee wrote: > > AST2600 Display Port MCU introduces 0x1800~0x1803 as it's memory > > and io address. If guest machine try to access DPMCU memory, it will > > cause a fatal error. > > The Aspeed SoCs have an

Re: [PATCH v5 2/3] acpi: tpm: Add missing device identification objects

2022-01-06 Thread Ani Sinha
On Thu, Jan 6, 2022 at 19:31 Stefan Berger wrote: > > >>> Can you smoke test TPM with Windows, and check if adding UID doesn't > >>> break anything if VM actually uses TMP (though I'm not sure how to > >>> check it on Windows, maybe install Windows 11 without this patch > >>> and then see if it

Re: [PATCH v2 00/18] user creatable pnv-phb3/pnv-phb4 devices

2022-01-06 Thread Cédric Le Goater
On 1/6/22 13:36, Daniel Henrique Barboza wrote: On 1/6/22 05:18, Cédric Le Goater wrote: On 1/5/22 22:23, Daniel Henrique Barboza wrote: Hi, This second version was rebased with upstream and includes fixed/amended versions of relevant patches that were sent to the mailing list and aren't

Re: [PATCH v2] hw/arm/virt: KVM: Enable PAuth when supported by the host

2022-01-06 Thread Marc Zyngier
On Thu, 06 Jan 2022 17:20:33 +, Richard Henderson wrote: > > On 1/6/22 1:16 AM, Marc Zyngier wrote: > >>> +static bool kvm_arm_pauth_supported(void) > >>> +{ > >>> +return (kvm_check_extension(kvm_state, KVM_CAP_ARM_PTRAUTH_ADDRESS) > >>> && > >>> +

Re: [PATCH v1 21/34] hw/arm: add control knob to disable kaslr_seed via DTB

2022-01-06 Thread Peter Maydell
On Wed, 5 Jan 2022 at 14:00, Alex Bennée wrote: > > Generally a guest needs an external source of randomness to properly > enable things like address space randomisation. However in a trusted > boot environment where the firmware will cryptographically verify > components having random data in

Re: [PATCH v2] hw/arm/virt: KVM: Enable PAuth when supported by the host

2022-01-06 Thread Richard Henderson
On 1/6/22 1:16 AM, Marc Zyngier wrote: +static bool kvm_arm_pauth_supported(void) +{ +return (kvm_check_extension(kvm_state, KVM_CAP_ARM_PTRAUTH_ADDRESS) && +kvm_check_extension(kvm_state, KVM_CAP_ARM_PTRAUTH_GENERIC)); +} Do we really need to have them both set to play the

Re: [PATCH] target/arm: Add missing FEAT_TLBIOS instructions

2022-01-06 Thread Peter Maydell
On Fri, 31 Dec 2021 at 10:40, Idan Horowitz wrote: > > Some of the instructions added by the FEAT_TLBIOS extension were forgotten > when the extension was originally added to QEMU. > > Fixes: 7113d618505b ("target/arm: Add support for FEAT_TLBIOS") > Signed-off-by: Idan Horowitz > -- Richard,

Re: New arm alignment issue with 6.2.0 - bisected to single revision

2022-01-06 Thread Peter Maydell
On Wed, 29 Dec 2021 at 20:15, Mark Watson wrote: > I'm seeing a repeatable alignment exception running m68k system mode on > armv7l (arm cortex a9) following this commit: > "fa947a667fceab02f9f85fc99f54aebcc9ae6b51 is the first bad commit > commit fa947a667fceab02f9f85fc99f54aebcc9ae6b51 >

Re: [PATCH v2 1/2] target/arm: Implement Cortex-A5

2022-01-06 Thread Peter Maydell
On Thu, 16 Dec 2021 at 06:48, Byron Lathi wrote: > > Add support for the Cortex-A5. These changes are based off of the A7 and > A9 Init functions, using the appropriate values from the technical > reference manual for the A5. > > Signed-off-by: Byron Lathi > --- > target/arm/cpu_tcg.c | 36

Re: [PATCH v5 1/3] tests: acpi: prepare for updated TPM related tables

2022-01-06 Thread Igor Mammedov
On Tue, 4 Jan 2022 12:58:04 -0500 Stefan Berger wrote: > Replace existing TPM related tables, that are about to change, with > empty files. > > Cc: Michael S. Tsirkin > Cc: Igor Mammedov > Cc: Ani Sinha > Signed-off-by: Stefan Berger > Acked-by: Ani Sinha > Message-id:

Re: [PATCH v5 2/3] acpi: tpm: Add missing device identification objects

2022-01-06 Thread Igor Mammedov
On Thu, 6 Jan 2022 09:01:36 -0500 Stefan Berger wrote: > On 1/6/22 08:56, Michael S. Tsirkin wrote: > > On Thu, Jan 06, 2022 at 08:53:00AM -0500, Stefan Berger wrote: > >> On 1/6/22 03:36, Igor Mammedov wrote: > >>> On Tue, 4 Jan 2022 12:58:05 -0500 > >>> Stefan Berger wrote: > >>> >

Re: [PATCH V3] block/rbd: implement bdrv_co_block_status

2022-01-06 Thread Peter Lieven
flags: create_timestamp: Tue Sep 21 14:16:56 2021 access_timestamp: Thu Jan 6 15:24:46 2022 modify_timestamp: Thu Jan 6 15:45:42 2022 $ rbd --conf /etc/ceph/ceph-dev01.conf --id lieven snap ls dhp-standard/c4ca7ee9-36ce-4fc9-9d3b-ece8a4f8b83e/c1ad11d0-4f6a-4cc1-8aa3

Re: Rational behind partial AVX support in Qemu

2022-01-06 Thread Richard Henderson
On 1/6/22 1:14 AM, Stevie Lavern wrote: Do you think it qualifies as "trivial patch" or should i go on with the full patch submission process? There is no "short" patch submission process. r~

Re: [RFC PATCH v2 20/44] i386/tdx: Parse tdx metadata and store the result into TdxGuestState

2022-01-06 Thread Laszlo Ersek
On 01/04/22 14:08, Xiaoyao Li wrote: > + Laszlo, > > Regarding laoding TDVF as pflash, I have some questions: > > - pflash requires KVM to support readonly mmeory. However, for TDX, it > doesn't support readonly memory. Is it a must? or we can make an > exception for TDX? > > - I saw from >

Re: [PATCH V3] block/rbd: implement bdrv_co_block_status

2022-01-06 Thread Ilya Dryomov
replace > >>> these gotos with returns. > >> > >> That would be return with the bitmask directly coded in if I also > >> > >> drop the ret variable. I can change that, no problem. > >> > >> > >>>> +} > >>>>

Re: Trying to understand QOM object creation and property linking

2022-01-06 Thread Peter Maydell
On Thu, 6 Jan 2022 at 15:45, Alex Bennée wrote: > Peter Maydell writes: > > Yeah, that trick only works for the real CPU object, not for > > passing to SoC or SoC-like objects. > > Hmm I wonder if I should be instantiating the underlying CPU object? > AIUI the cores are cortex-m0+ so I assume

Re: [PATCH 2/2] virtio: Add shared memory capability

2022-01-06 Thread Antonio Caggiano
Where's that commit? I think we should drop this, right? Yes, I will submit another version without that line. You don't need & mask32 I think. cpu_to_le32 will truncate the value. Makes sense, will be fixed in next version. So it's a new API, but where's the user? I guess just include

Re: Trying to understand QOM object creation and property linking

2022-01-06 Thread Alex Bennée
Peter Maydell writes: > On Thu, 6 Jan 2022 at 14:26, Alex Bennée wrote: >> >> >> Peter Maydell writes: >> >> > On Wed, 5 Jan 2022 at 21:05, Alex Bennée wrote: >> >> Can't be added as a subregion to the container... >> >> >> >> qemu-system-arm: ../../softmmu/memory.c:2538: >> >>

Re: [PATCH 3/3] hw/sysbus: Document GPIO related functions

2022-01-06 Thread Peter Maydell
On Wed, 29 Dec 2021 at 22:52, Philippe Mathieu-Daudé wrote: > > Similarly to cd07d7f9f51 ("qdev: Document GPIO related functions"), > add documentation comments for the various sysbus functions > related to creating and connecting GPIO lines. > > Signed-off-by: Philippe Mathieu-Daudé > --- >

Re: [PATCH v7 00/18] Adding partial support for 128-bit riscv target

2022-01-06 Thread Frédéric Pétrot
On 06/01/2022 09:33, Alistair Francis wrote: On Tue, Dec 14, 2021 at 2:39 AM Frédéric Pétrot wrote: This series of patches provides partial 128-bit support for the riscv target architecture, namely RVI and RVM, with minimal csr support. Thanks again for the reviews and advices. I think

Re: [PATCH v2 0/5] hw/qdev: Clarify qdev_connect_gpio_out() documentation

2022-01-06 Thread Peter Maydell
On Thu, 23 Dec 2021 at 09:05, Philippe Mathieu-Daudé wrote: > > Hi Peter. > > Since you reviewed v1, and Ack-by on v2 would be welcomed. > Otherwise, if you don't object, I plan to queue this via > machine-next tree. Been on holiday since mid-Dec :-) I see this is already upstream, which is

Re: [PATCH] Supporting AST2600 HACE engine accumulative mode

2022-01-06 Thread Peter Maydell
On Tue, 28 Dec 2021 at 03:34, Troy Lee wrote: > > Hi Klaus, > > On Thu, Dec 23, 2021 at 11:57 PM Klaus Heinrich Kiwi > wrote: > > > > Em qui., 23 de dez. de 2021 às 09:54, Cédric Le Goater > > escreveu: > > > > > > [ Adding Klaus ] > > > > Thanks Cedric. It's been a while since I've looked at

Re: [PATCH V3] block/rbd: implement bdrv_co_block_status

2022-01-06 Thread Peter Lieven
imestamp: Thu Jan  6 15:45:42 2022 $ rbd --conf /etc/ceph/ceph-dev01.conf --id lieven snap ls dhp-standard/c4ca7ee9-36ce-4fc9-9d3b-ece8a4f8b83e/c1ad11d0-4f6a-4cc1-8aa3-ff3c413c1471.raw SNAPID  NAME SIZE    PROTECTED TIMESTAMP  12297  dlp-20210921-144509  20 GiB Tue Se

Re: Trying to understand QOM object creation and property linking

2022-01-06 Thread Peter Maydell
On Thu, 6 Jan 2022 at 14:26, Alex Bennée wrote: > > > Peter Maydell writes: > > > On Wed, 5 Jan 2022 at 21:05, Alex Bennée wrote: > >> Can't be added as a subregion to the container... > >> > >> qemu-system-arm: ../../softmmu/memory.c:2538: > >> memory_region_add_subregion_common: Assertion

[PATCH 07/15] audio: copy playback stream in sequential order

2022-01-06 Thread Volker Rümelin
From: Volker Rümelin Change the code to copy the playback stream in sequential order. The advantage can be seen in the next patches where the stream copy operation effectively becomes a write through operation. The following diagram shows the average buffer fill level and the stream copy

[PATCH 11/15] paaudio: reduce effective playback buffer size

2022-01-06 Thread Volker Rümelin
From: Volker Rümelin Add the buffer_get_free pcm_ops function to reduce the effective playback buffer size. All intermediate audio playback buffers become temporary buffers. Signed-off-by: Volker Rümelin --- audio/paaudio.c | 33 - 1 file changed, 24

[PATCH 14/15] paaudio: fix samples vs. frames mix-up

2022-01-06 Thread Volker Rümelin
From: Volker Rümelin Now that the mixing buffer size no longer adds to playback latency, fix the samples vs. frames mix-up in the mixing buffer size calculation. This change will go largely unnoticed as long as the user doesn't use a buffer-size smaller than timer-period. Signed-off-by: Volker

[PATCH 12/15] dsoundaudio: reduce effective playback buffer size

2022-01-06 Thread Volker Rümelin
From: Volker Rümelin Add the buffer_get_free pcm_ops function to reduce the effective playback buffer size. All intermediate audio playback buffers become temporary buffers. Signed-off-by: Volker Rümelin --- audio/dsoundaudio.c | 30 +- 1 file changed, 17

[PATCH 04/15] audio: inline function audio_pcm_sw_get_rpos_in()

2022-01-06 Thread Volker Rümelin
From: Volker Rümelin Simplify code by inlining function audio_pcm_sw_get_rpos_in() at the only call site and remove the duplicated audio_bug() test. Signed-off-by: Volker Rümelin --- audio/audio.c | 23 +-- 1 file changed, 5 insertions(+), 18 deletions(-) diff --git

[PATCH 08/15] audio: add pcm_ops function table for capture backend

2022-01-06 Thread Volker Rümelin
From: Volker Rümelin Add a pcm_ops function table for the capture backend. This avoids additional code in the next patches to test if the pcm_ops table is available. Signed-off-by: Volker Rümelin --- audio/audio.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/audio/audio.c

[PATCH 10/15] audio: restore mixing-engine playback buffer size

2022-01-06 Thread Volker Rümelin
From: Volker Rümelin Commit ff095e5231 "audio: api for mixeng code free backends" introduced another FIFO for the audio subsystem with exactly the same size as the mixing-engine FIFO. Most audio backends use this generic FIFO. The generic FIFO used together with the mixing-engine FIFO doubles

[PATCH 15/15] sdlaudio: fix samples vs. frames mix-up

2022-01-06 Thread Volker Rümelin
From: Volker Rümelin Fix the same samples vs. frames mix-up that the previous commit fixed for the PulseAudio backend. Signed-off-by: Volker Rümelin --- audio/sdlaudio.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/audio/sdlaudio.c b/audio/sdlaudio.c index

[PATCH 06/15] jackaudio: use more jack audio buffers

2022-01-06 Thread Volker Rümelin
From: Volker Rümelin The next patch reduces the effective qemu playback buffer size by timer-period. Increase the number of jack audio buffers by one to preserve the total effective buffer size. The size of one jack audio buffer is 512 samples. With audio defaults that's 512 samples / 44100

[PATCH 13/15] ossaudio: reduce effective playback buffer size

2022-01-06 Thread Volker Rümelin
From: Volker Rümelin Add the buffer_get_free pcm_ops function for the mmapped case to reduce the effective playback buffer size. All intermediate audio playback buffers become temporary buffers. Signed-off-by: Volker Rümelin --- audio/ossaudio.c | 7 --- 1 file changed, 4 insertions(+), 3

[PATCH 01/15] audio: replace open-coded buffer arithmetic

2022-01-06 Thread Volker Rümelin
From: Volker Rümelin Replace open-coded buffer arithmetic with the available function audio_ring_dist(). Because the name audio_ring_dist implies it calculates the distance between two points, define the alias function name audio_ring_posb. That's the position in backward direction of a given

[PATCH 05/15] paaudio: increase default latency to 46ms

2022-01-06 Thread Volker Rümelin
From: Volker Rümelin This is a patch to improve the pulseaudio playback experience. Asking pulseaudio for a playback latency of 15ms is quite demanding. Increase this to 46ms. The total playback latency now is 31ms larger. One of the next patches will reduce the total playback latency again by

[PATCH 03/15] audio: add function audio_pcm_hw_conv_in()

2022-01-06 Thread Volker Rümelin
From: Volker Rümelin Add a function audio_pcm_hw_conv_in() similar to the existing counterpart function audio_pcm_hw_clip_out(). This function reduces the number of calls to the pcm_ops functions get_buffer_in() and put_buffer_in(). That's one less call to get_buffer_in() and put_buffer_in()

[PATCH 02/15] audio: move function audio_pcm_hw_clip_out()

2022-01-06 Thread Volker Rümelin
From: Volker Rümelin Move the function audio_pcm_hw_clip_out() into the correct section 'Hard voice (playback)'. Signed-off-by: Volker Rümelin --- audio/audio.c | 38 +++--- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/audio/audio.c

[PATCH 09/15] audio: revert tests for pcm_ops table

2022-01-06 Thread Volker Rümelin
From: Volker Rümelin With previous commit every audio backend has a pcm_ops function table. It's no longer necessary to test if the table is available. This reverts commit cbaf25d1f5: "audio: fix wavcapture segfault" Signed-off-by: Volker Rümelin --- audio/audio.c | 4 ++-- 1 file changed, 2

Re: [PATCH] hw/misc/auxbus: Improve aux_bus_init() docstring

2022-01-06 Thread Peter Maydell
On Mon, 22 Nov 2021 at 11:11, Philippe Mathieu-Daudé wrote: > > Mention in aux_bus_init() docstring that the AUXBus > is not simply initialized, it is also allocated. > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/misc/auxbus.h | 12 +++- > 1 file changed, 7 insertions(+),

Re: [PATCH v2 14/18] pnv_phb4.h: turn phb into a pointer in struct PnvPhb4PecStack

2022-01-06 Thread Cédric Le Goater
On 1/5/22 22:23, Daniel Henrique Barboza wrote: At this moment, stack->phb is the plain PnvPHB4 device itself instead of a pointer to the device. This will present a problem when adding user creatable devices because we can't deal with this struct and the realize() callback from the user

Re: [PATCH v3 0/3] hw/net: Move MV88W8618 network device out of hw/arm/ directory

2022-01-06 Thread Peter Maydell
On Fri, 17 Dec 2021 at 23:30, Philippe Mathieu-Daudé wrote: > > This series simply extract the MV88W8618 device from the ARM > machine in hw/arm/ and move it to hw/net/. > > Since v2: > - declare MARVELL_88W8618 in hw/arm/Kconfig > - use MARVELL_88W8618 Kconfig (rth) > > Since v1: > - update (c)

Re: [PATCH v2 14/18] pnv_phb4.h: turn phb into a pointer in struct PnvPhb4PecStack

2022-01-06 Thread Cédric Le Goater
On 1/5/22 22:23, Daniel Henrique Barboza wrote: At this moment, stack->phb is the plain PnvPHB4 device itself instead of a pointer to the device. This will present a problem when adding user creatable devices because we can't deal with this struct and the realize() callback from the user

Re: [PATCH] target/riscv: Fix position of 'experimental' comment

2022-01-06 Thread Bin Meng
On Thu, Jan 6, 2022 at 10:29 PM Philipp Tomsich wrote: > > When commit 0643c12e4b dropped the 'x-' prefix for Zb[abcs] and set > them to be enabled by default, the comment about experimental > extensions was kept in place above them. This moves it down a few > lines to only cover experimental

Re: [PATCH v2 17/18] ppc/pnv: Introduce user creatable pnv-phb4 devices

2022-01-06 Thread Cédric Le Goater
On 1/5/22 22:23, Daniel Henrique Barboza wrote: This patch introduces pnv-phb4 user creatable devices that are created in a similar manner as pnv-phb3 devices, allowing the user to interact with the PHBs directly instead of creating PCI Express Controllers that will create a certain amount of

Re: [PATCH v4 2/7] tcg/aarch64: Support raising sigbus for user-only

2022-01-06 Thread Peter Maydell
On Tue, 4 Jan 2022 at 02:15, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v2 13/18] pnv_phb4_pec: use pnv_phb4_pec_get_phb_id() in pnv_pec_dt_xscom()

2022-01-06 Thread Cédric Le Goater
On 1/5/22 22:23, Daniel Henrique Barboza wrote: Relying on stack->phb to write the xscom DT of the PEC is something that we won't be able to do with user creatable pnv-phb4 devices. Hopefully, this can be done by using pnv_phb4_pec_get_phb_id(), which is already used by pnv_pec_realize() to set

Re: [PATCH v2 11/18] pnv_phb4.c: introduce pnv_phb4_set_stack_phb_props()

2022-01-06 Thread Cédric Le Goater
On 1/5/22 22:23, Daniel Henrique Barboza wrote: We want to be able to support user creatable pnv-phb4 objects to allow users to instantiate a powernv9 machine similar to what it is done with powernv8. The main difference is that pnv-phb3 devs are attached directly to the system bus and can be

Re: [PATCH v2 15/18] pnv_phb4_pec.c: use 'default_enabled()' to init stack->phb

2022-01-06 Thread Cédric Le Goater
On 1/5/22 22:23, Daniel Henrique Barboza wrote: The next step before enabling user creatable pnv-phb4 devices is to decople the init of the stack->phb object from pnv_pec_stk_instance_init(). First, use 'defaults_enabled()' inside pnv_pec_realize() to create the stack->phb object, while

Re: Trying to understand QOM object creation and property linking

2022-01-06 Thread Alex Bennée
Peter Maydell writes: > On Wed, 5 Jan 2022 at 21:05, Alex Bennée wrote: >> Can't be added as a subregion to the container... >> >> qemu-system-arm: ../../softmmu/memory.c:2538: >> memory_region_add_subregion_common: Assertion `!subregion->container' failed. > > This assert means you tried

Re: [PATCH v2 18/18] pnv_phb4.c: change TYPE_PNV_PHB4_ROOT_BUS name

2022-01-06 Thread Cédric Le Goater
On 1/5/22 22:23, Daniel Henrique Barboza wrote: Similar to what was happening with pnv-phb3 buses, TYPE_PNV_PHB4_ROOT_BUS set to "pnv-phb4-root-bus" is a bit too long for a default root bus name. The usual default name for theses buses in QEMU are 'pcie', but we want to make a distinction

Re: [PATCH v2 16/18] pnv_phb4.c: introduce pnv_pec_init_stack_xscom()

2022-01-06 Thread Cédric Le Goater
On 1/5/22 22:23, Daniel Henrique Barboza wrote: The XSCOM address space of the stack must be populated after the initialization of its associated PHB4 is completed. At this moment this is always true because stk_realize() will always succeeds the realize of stack->phb, but that will not be the

Re: [RFC 02/10] vhost: add 3 commands for vhost-vdpa

2022-01-06 Thread Michael S. Tsirkin
On Thu, Jan 06, 2022 at 10:34:20AM +0800, Jason Wang wrote: > On Wed, Jan 5, 2022 at 8:26 PM Michael S. Tsirkin wrote: > > > > On Wed, Jan 05, 2022 at 05:09:07PM +0800, Jason Wang wrote: > > > On Wed, Jan 5, 2022 at 4:37 PM Longpeng (Mike, Cloud Infrastructure > > > Service Product Dept.) wrote:

Re: [PATCH v2 12/18] pnv_phb4_pec.c: move pnv_pec_phb_offset() to pnv_phb4.c

2022-01-06 Thread Cédric Le Goater
On 1/5/22 22:23, Daniel Henrique Barboza wrote: The logic inside pnv_pec_phb_offset() will be useful in the next patch to determine the stack that should contain a PHB4 device. Move the function to pnv_phb4.c and make it public since there's no pnv_phb4_pec.h header. While we're at it, add

Byte Sized task (was Re: [PATCH] linux-user/syscall.c: malloc to g_try_malloc)

2022-01-06 Thread Laurent Vivier
Hi Ahmed, the email address you use for the trivial ML is broken. I've fixed it for my answer and added qemu-devel. Le 05/01/2022 à 20:09, Ahmed Abouzied a écrit : Hello, Thanks for the review. I also found some occurrences of "cpu_physical_memor_*" calls that should be replaced with

[PATCH] target/riscv: Fix position of 'experimental' comment

2022-01-06 Thread Philipp Tomsich
When commit 0643c12e4b dropped the 'x-' prefix for Zb[abcs] and set them to be enabled by default, the comment about experimental extensions was kept in place above them. This moves it down a few lines to only cover experimental extensions. References: 0643c12e4b ("target/riscv: Enable bitmanip

Re: [PATCH v5 2/3] acpi: tpm: Add missing device identification objects

2022-01-06 Thread Stefan Berger
On 1/6/22 08:56, Michael S. Tsirkin wrote: On Thu, Jan 06, 2022 at 08:53:00AM -0500, Stefan Berger wrote: On 1/6/22 03:36, Igor Mammedov wrote: On Tue, 4 Jan 2022 12:58:05 -0500 Stefan Berger wrote: Add missing TPM device identification objects _STR and _UID. They will appear as files

Re: [PATCH] linux-user: Remove the deprecated ppc64abi32 target

2022-01-06 Thread Alex Bennée
Laurent Vivier writes: > Le 20/12/2021 à 17:01, Laurent Vivier a écrit : >> Le 15/12/2021 à 09:49, Thomas Huth a écrit : >>> >> Applied to my linux-user-for-7.0 branch. > > I've removed the patch from my series as Alex has added it to his > testing/next branch. > As it modifies the gitlab CI

Re: [PATCH v5 2/3] acpi: tpm: Add missing device identification objects

2022-01-06 Thread Michael S. Tsirkin
On Thu, Jan 06, 2022 at 08:53:00AM -0500, Stefan Berger wrote: > > On 1/6/22 03:36, Igor Mammedov wrote: > > On Tue, 4 Jan 2022 12:58:05 -0500 > > Stefan Berger wrote: > > > > > Add missing TPM device identification objects _STR and _UID. They will > > > appear as files 'description' and 'uid'

Re: [PATCH] MAINTAINERS: Add entry for QEMU Guest Agent Windows components

2022-01-06 Thread Michael Roth
On Wed, Jan 05, 2022 at 11:50:55AM +0200, Kostiantyn Kostiuk wrote: > Signed-off-by: Kostiantyn Kostiuk Reviewed-by: Michael Roth > --- > MAINTAINERS | 8 > 1 file changed, 8 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index f871d759fd..1f255ec874 100644 > ---

Re: [PATCH v5 2/3] acpi: tpm: Add missing device identification objects

2022-01-06 Thread Stefan Berger
On 1/6/22 03:36, Igor Mammedov wrote: On Tue, 4 Jan 2022 12:58:05 -0500 Stefan Berger wrote: Add missing TPM device identification objects _STR and _UID. They will appear as files 'description' and 'uid' under Linux sysfs. Following inspection of sysfs entries for hardware TPMs we chose

Re: [PATCH v4 07/14] vfio-user: run vfio-user context

2022-01-06 Thread Stefan Hajnoczi
On Wed, Jan 05, 2022 at 10:38:10AM +, Thanos Makatos wrote: > > > > -Original Message- > > From: Jag Raman > > Sent: 17 December 2021 18:00 > > To: Stefan Hajnoczi ; John Levon > > ; Thanos Makatos > > Cc: qemu-devel ; Alex Williamson > > ; Marc-André Lureau > > ; Philippe

[PULL 04/52] virtio-pci: decouple notifier from interrupt process

2022-01-06 Thread Michael S. Tsirkin
From: Cindy Lu To reuse the notifier process in configure interrupt. Use the virtio_pci_get_notifier function to get the notifier. the INPUT of this function is the IDX, the OUTPUT is notifier and the vector Signed-off-by: Cindy Lu Message-Id: <20211104164827.21911-3-l...@redhat.com>

[PATCH v2] tcg/loongarch64: Support raising sigbus for user-only

2022-01-06 Thread WANG Xuerui
Based-on: <20220104021543.396571-1-richard.hender...@linaro.org> Reviewed-by: Richard Henderson Signed-off-by: WANG Xuerui --- v2 -> v1: - Dropped assert and added comment documenting reason to choose bstrpick.d over andi for the masking operation - Collected R-b tag

[PULL 52/52] virtio/vhost-vsock: don't double close vhostfd, remove redundant cleanup

2022-01-06 Thread Michael S. Tsirkin
From: Daniil Tatianin In case of an error during initialization in vhost_dev_init, vhostfd is closed in vhost_dev_cleanup. Remove close from err_virtio as it's both redundant and causes a double close on vhostfd. Signed-off-by: Daniil Tatianin Message-Id:

[PULL 32/52] util/oslib-posix: Don't create too many threads with small memory or little pages

2022-01-06 Thread Michael S. Tsirkin
From: David Hildenbrand Let's limit the number of threads to something sane, especially that - We don't have more threads than the number of pages we have - We don't have threads that initialize small (< 64 MiB) memory Reviewed-by: Pankaj Gupta Reviewed-by: Dr. David Alan Gilbert Reviewed-by:

[PULL 44/52] tests: acpi: whitelist expected blobs before changing them

2022-01-06 Thread Michael S. Tsirkin
From: Igor Mammedov Signed-off-by: Igor Mammedov Message-Id: <20211227193120.1084176-3-imamm...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- tests/qtest/bios-tables-test-allowed-diff.h | 2 ++ tests/data/acpi/q35/FACP.slic | Bin 0 -> 244

[PULL 51/52] hw/scsi/vhost-scsi: don't double close vhostfd on error

2022-01-06 Thread Michael S. Tsirkin
From: Daniil Tatianin vhost_dev_init calls vhost_dev_cleanup on error, which closes vhostfd, don't double close it. Signed-off-by: Daniil Tatianin Message-Id: <20211129132358.1110372-2-d-tatia...@yandex-team.ru> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin ---

Re: [PATCH] qemu_fw_cfg: use default_groups in kobj_type

2022-01-06 Thread Greg Kroah-Hartman
On Wed, Jan 05, 2022 at 05:56:26PM -0500, Michael S. Tsirkin wrote: > On Wed, Jan 05, 2022 at 07:31:33PM +0100, Greg Kroah-Hartman wrote: > > There are currently 2 ways to create a set of sysfs files for a > > kobj_type, through the default_attrs field, and the default_groups > > field. Move the

[PULL 31/52] util/oslib-posix: Introduce and use MemsetContext for touch_all_pages()

2022-01-06 Thread Michael S. Tsirkin
From: David Hildenbrand Let's minimize the number of global variables to prepare for os_mem_prealloc() getting called concurrently and make the code a bit easier to read. The only consumer that really needs a global variable is the sigbus handler, which will require protection via a mutex in

[PULL 50/52] hw/scsi/vhost-scsi: don't leak vqs on error

2022-01-06 Thread Michael S. Tsirkin
From: Daniil Tatianin vhost_dev_init calls vhost_dev_cleanup in case of an error during initialization, which zeroes out the entire vsc->dev as well as the vsc->dev.vqs pointer. This prevents us from properly freeing it in free_vqs. Keep a local copy of the pointer so we can free it later.

[PULL 45/52] tests: acpi: add SLIC table test

2022-01-06 Thread Michael S. Tsirkin
From: Igor Mammedov When user uses '-acpitable' to add SLIC table, some ACPI tables (FADT) will change its 'Oem ID'/'Oem Table ID' fields to match that of SLIC. Test makes sure thati QEMU handles those fields correctly when SLIC table is added with '-acpitable' option. Signed-off-by: Igor

[PULL 43/52] acpi: fix QEMU crash when started with SLIC table

2022-01-06 Thread Michael S. Tsirkin
From: Igor Mammedov if QEMU is started with used provided SLIC table blob, -acpitable sig=SLIC,oem_id='CRASH ',oem_table_id="ME",oem_rev=2210,asl_compiler_id="",asl_compiler_rev=,data=/dev/null it will assert with: hw/acpi/aml-build.c:61:build_append_padded_str: assertion

[PULL 36/52] virtio-mem: Support "prealloc=on" option

2022-01-06 Thread Michael S. Tsirkin
From: David Hildenbrand For scarce memory resources, such as hugetlb, we want to be able to prealloc such memory resources in order to not crash later on access. On simple user errors we could otherwise easily run out of memory resources an crash the VM -- pretty much undesired. For ordinary

[PULL 49/52] docs: reSTify virtio-balloon-stats documentation and move to docs/interop

2022-01-06 Thread Michael S. Tsirkin
From: Thomas Huth The virtio-balloon-stats documentation might be useful for people that are implementing software that talks to QEMU via QMP, so this should reside in the docs/interop/ directory. While we're at it, also convert the file to restructured text and mention it in the MAINTAINERS

[PULL 41/52] virtio-mem: Set "unplugged-inaccessible=auto" for the 7.0 machine on x86

2022-01-06 Thread Michael S. Tsirkin
From: David Hildenbrand Set the new default to "auto", keeping it set to "off" for compat machines. This property is only available for x86 targets. Reviewed-by: Michal Privoznik Reviewed-by: Pankaj Gupta Signed-off-by: David Hildenbrand Message-Id: <20211217134039.29670-4-da...@redhat.com>

[PULL 47/52] acpihp: simplify acpi_pcihp_disable_root_bus

2022-01-06 Thread Michael S. Tsirkin
From: Ani Sinha Get rid of the static variable that keeps track of whether hotplug has been disabled on the root pci bus. Simply use qbus_is_hotpluggable() api to perform the same check. This eliminates additional if conditional and simplifies the function. Signed-off-by: Ani Sinha Message-Id:

[PULL 46/52] tests: acpi: SLIC: update expected blobs

2022-01-06 Thread Michael S. Tsirkin
From: Igor Mammedov Signed-off-by: Igor Mammedov Message-Id: <20211227193120.1084176-5-imamm...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- tests/qtest/bios-tables-test-allowed-diff.h | 2 -- tests/data/acpi/q35/FACP.slic | Bin 244 -> 244

[PULL 35/52] util/oslib-posix: Forward SIGBUS to MCE handler under Linux

2022-01-06 Thread Michael S. Tsirkin
From: David Hildenbrand Temporarily modifying the SIGBUS handler is really nasty, as we might be unlucky and receive an MCE SIGBUS while having our handler registered. Unfortunately, there is no way around messing with SIGBUS when MADV_POPULATE_WRITE is not applicable or not around. Let's

[PULL 48/52] hw/i386/pc: Add missing property descriptions

2022-01-06 Thread Michael S. Tsirkin
From: Thomas Huth When running "qemu-system-x86_64 -M pc,help" I noticed that some properties were still missing their description. Add them now so that users get at least a slightly better idea what they are all about. Signed-off-by: Thomas Huth Message-Id:

[PULL 24/52] pcie_aer: Don't trigger a LSI if none are defined

2022-01-06 Thread Michael S. Tsirkin
From: Frederic Barrat Skip triggering an LSI when the AER root error status is updated if no LSI is defined for the device. We can have a root bridge with no LSI, MSI and MSI-X defined, for example on POWER systems. Signed-off-by: Frederic Barrat Message-Id:

[PULL 18/52] vhost-backend: stick to -errno error return convention

2022-01-06 Thread Michael S. Tsirkin
From: Roman Kagan Almost all VhostOps methods in kernel_ops follow the convention of returning negated errno on error. Adjust the only one that doesn't. Signed-off-by: Roman Kagan Message-Id: <2021153354.18807-7-rvka...@yandex-team.ru> Reviewed-by: Michael S. Tsirkin Signed-off-by:

<    1   2   3   4   >