Re: [PATCH v14 02/26] target/loongarch: Add core definition

2022-01-10 Thread gaosong
Hi, On 2022/1/10 上午2:49, Richard Henderson wrote: +static bool loongarch_cpu_has_work(CPUState *cs) +{ +    return true; Note: this is only applicable to CONFIG_USER_ONLY, and needs to be changed in the following commits adding system emulation. To better convey your intention it may be bett

Re: [RFC PATCH v2 2/6] audio/coreaudio: Remove a deprecation warning on macOS 12

2022-01-10 Thread Philippe Mathieu-Daudé
On 1/10/22 09:44, Philippe Mathieu-Daudé wrote: > On 1/10/22 09:17, Akihiko Odaki wrote: >> On 2022/01/10 2:06, Philippe Mathieu-Daudé wrote: >>> When building on macOS 12 we get: >>> >>>    audio/coreaudio.c:50:5: error: 'kAudioObjectPropertyElementMaster' >>> is deprecated: first deprecated in ma

Re: /usr/shared/qemu binaries

2022-01-10 Thread Alistair Francis
On Mon, Jan 10, 2022 at 8:16 PM Liviu Ionescu wrote: > > I successfully built two QEMU 6.2 binary packages, one with Arm and one with > RISC-V, each with standalone variants for Linux Intel, Linux Arm, Windows > Intel, macOS Intel and macOS Arm. > > Each package includes only the relevant execut

Re: [RFC PATCH v2 20/44] i386/tdx: Parse tdx metadata and store the result into TdxGuestState

2022-01-10 Thread Xiaoyao Li
On 1/10/2022 7:01 PM, Gerd Hoffmann wrote: If you go without pflash, then you likely will not have a standards-conformant UEFI variable store. (Unless you reimplement the variable arch protocols in edk2 on top of something else than the Fault Tolerant Write and Firmware Volume Block protocols.) W

Re: [RFC PATCH v2 06/44] hw/i386: Introduce kvm-type for TDX guest

2022-01-10 Thread Daniel P . Berrangé
On Mon, Jan 10, 2022 at 08:01:33PM +0800, Xiaoyao Li wrote: > On 1/10/2022 7:18 PM, Daniel P. Berrangé wrote: > > On Wed, Nov 24, 2021 at 03:31:13PM +0800, Xiaoyao Li wrote: > > > On 8/26/2021 6:22 PM, Gerd Hoffmann wrote: > > > > On Wed, Jul 07, 2021 at 05:54:36PM -0700, isaku.yamah...@gmail.com

Re: [RFC PATCH v2 06/44] hw/i386: Introduce kvm-type for TDX guest

2022-01-10 Thread Xiaoyao Li
On 1/10/2022 7:18 PM, Daniel P. Berrangé wrote: On Wed, Nov 24, 2021 at 03:31:13PM +0800, Xiaoyao Li wrote: On 8/26/2021 6:22 PM, Gerd Hoffmann wrote: On Wed, Jul 07, 2021 at 05:54:36PM -0700, isaku.yamah...@gmail.com wrote: From: Xiaoyao Li Introduce a machine property, kvm-type, to allow t

[PATCH 1/2] block/rbd: fix handling of holes in .bdrv_co_block_status

2022-01-10 Thread Peter Lieven
the assumption that we can't hit a hole if we do not diff against a snapshot was wrong. We can see a hole in an image if we diff against base if there exists an older snapshot of the image and we have discarded blocks in the image where the snapshot has data. Fixes: 0347a8fd4c3faaedf119be04c19

Re: [PATCH 0/2] block-backend: Retain permissions after migration

2022-01-10 Thread Peng Liang via
On 11/25/2021 9:53 PM, Hanna Reitz wrote: > Hi, > > Peng Liang has reported an issue regarding migration of raw images here: > https://lists.nongnu.org/archive/html/qemu-block/2021-11/msg00673.html > > It turns out that after migrating, all permissions are shared when they > weren’t before. The

[PATCH 0/2] block/rbd: fixes for bdrv_co_block_status

2022-01-10 Thread Peter Lieven
Peter Lieven (2): block/rbd: fix handling of holes in .bdrv_co_block_status block/rbd: workaround for ceph issue #53784 block/rbd.c | 72 + 1 file changed, 50 insertions(+), 22 deletions(-) -- 2.25.1

[PATCH 2/2] block/rbd: workaround for ceph issue #53784

2022-01-10 Thread Peter Lieven
librbd had a bug until early 2022 that affected all versions of ceph that supported fast-diff. This bug results in reporting of incorrect offsets if the offset parameter to rbd_diff_iterate2 is not object aligned. Work around this bug by rounding down the offset to object boundaries. Fixes: https:

Re: [PATCH v4 08/11] target/riscv: Add sscofpmf extension support

2022-01-10 Thread Anup Patel
On Fri, Jan 7, 2022 at 7:45 AM Atish Patra wrote: > > The Sscofpmf ('Ss' for Privileged arch and Supervisor-level extensions, > and 'cofpmf' for Count OverFlow and Privilege Mode Filtering) > extension allows the perf to handle overflow interrupts and filtering > support. This patch provides a fra

Re: [PATCH] docs: Add measurement calculation details to amd-memory-encryption.txt

2022-01-10 Thread Daniel P . Berrangé
On Mon, Jan 10, 2022 at 01:17:02PM +0200, Dov Murik wrote: > > > On 07/01/2022 22:18, Daniel P. Berrangé wrote: > > On Thu, Dec 16, 2021 at 11:41:27PM +0200, Dov Murik wrote: > >> > >> > >> On 16/12/2021 18:09, Daniel P. Berrangé wrote: > >>> On Thu, Dec 16, 2021 at 12:38:34PM +0200, Dov Murik wr

Re: [PATCH v2 5/5] libvhost-user: handle removal of identical regions

2022-01-10 Thread Stefan Hajnoczi
On Thu, Jan 06, 2022 at 06:47:36AM +, Raphael Norwitz wrote: > Today if QEMU (or any other VMM) has sent multiple copies of the same > region to a libvhost-user based backend and then attempts to remove the > region, only one instance of the region will be removed, leaving stale > copies of the

Re: [PATCH v1 1/2] decodetree: Add an optional predicate-function for decoding

2022-01-10 Thread Philippe Mathieu-Daudé
On 1/10/22 12:11, Philipp Tomsich wrote: > On Mon, 10 Jan 2022 at 11:03, Philippe Mathieu-Daudé > wrote: > > On 1/10/22 10:52, Philipp Tomsich wrote: > > For RISC-V the opcode decode will change between different vendor > > implementations of RISC-V (emulated b

Re: [PATCH v2 0/5] Clean up error handling in libvhost-user memory mapping

2022-01-10 Thread Stefan Hajnoczi
On Thu, Jan 06, 2022 at 06:47:24AM +, Raphael Norwitz wrote: > Hey Stefan, Marc-Andre, MST, David - > > As promised here is a series cleaning up error handling in the > libvhost-user memory mapping path. Most of these cleanups are > straightforward and have been discussed on the mailing list i

Re: [PATCH v2 4/5] libvhost-user: prevent over-running max RAM slots

2022-01-10 Thread Stefan Hajnoczi
On Thu, Jan 06, 2022 at 06:47:35AM +, Raphael Norwitz wrote: > When VHOST_USER_PROTOCOL_F_CONFIGURE_MEM_SLOTS support was added to > libvhost-user, no guardrails were added to protect against QEMU > attempting to hot-add too many RAM slots to a VM with a libvhost-user > based backed attached. >

Re: ui/cocoa.m compile error

2022-01-10 Thread Liviu Ionescu
> On 10 Jan 2022, at 12:44, Peter Maydell wrote: > > ... On Linux this tends to take the form > of dropping support for older versions of various dependencies > and compilers. My build environment uses modern tools (like GCC 11, etc), but compiled from sources on an older Linux release. The

Re: [RFC PATCH v2 06/44] hw/i386: Introduce kvm-type for TDX guest

2022-01-10 Thread Daniel P . Berrangé
On Wed, Nov 24, 2021 at 03:31:13PM +0800, Xiaoyao Li wrote: > On 8/26/2021 6:22 PM, Gerd Hoffmann wrote: > > On Wed, Jul 07, 2021 at 05:54:36PM -0700, isaku.yamah...@gmail.com wrote: > > > From: Xiaoyao Li > > > > > > Introduce a machine property, kvm-type, to allow the user to create a > > > Tru

Re: [PATCH] docs: Add measurement calculation details to amd-memory-encryption.txt

2022-01-10 Thread Dov Murik
On 07/01/2022 22:18, Daniel P. Berrangé wrote: > On Thu, Dec 16, 2021 at 11:41:27PM +0200, Dov Murik wrote: >> >> >> On 16/12/2021 18:09, Daniel P. Berrangé wrote: >>> On Thu, Dec 16, 2021 at 12:38:34PM +0200, Dov Murik wrote: On 14/12/2021 20:39, Daniel P. Berrangé wrote: > I

Re: [PATCH v1 1/2] decodetree: Add an optional predicate-function for decoding

2022-01-10 Thread Philipp Tomsich
On Mon, 10 Jan 2022 at 11:03, Philippe Mathieu-Daudé wrote: > On 1/10/22 10:52, Philipp Tomsich wrote: > > For RISC-V the opcode decode will change between different vendor > > implementations of RISC-V (emulated by the same qemu binary). > > Any two vendors may reuse the same opcode space, e.g.,

Re: [RFC PATCH v2 20/44] i386/tdx: Parse tdx metadata and store the result into TdxGuestState

2022-01-10 Thread Gerd Hoffmann
> > If you go without pflash, then you likely will not have a > > standards-conformant UEFI variable store. (Unless you reimplement the > > variable arch protocols in edk2 on top of something else than the Fault > > Tolerant Write and Firmware Volume Block protocols.) Whether a > > conformant UEFI

Re: [PATCH v3 2/2] hw/arm/virt: Support for virtio-mem-pci

2022-01-10 Thread David Hildenbrand
On 10.01.22 11:50, Peter Maydell wrote: > On Sat, 8 Jan 2022 at 07:22, Gavin Shan wrote: >> >> Hi Peter, >> >> On 1/8/22 12:40 AM, Peter Maydell wrote: >>> On Fri, 3 Dec 2021 at 23:34, Gavin Shan wrote: diff --git a/hw/virtio/virtio-mem.c b/hw/virtio/virtio-mem.c index b20595a496..21e4d

Re: [PATCH v3 2/2] hw/arm/virt: Support for virtio-mem-pci

2022-01-10 Thread Peter Maydell
On Sat, 8 Jan 2022 at 07:22, Gavin Shan wrote: > > Hi Peter, > > On 1/8/22 12:40 AM, Peter Maydell wrote: > > On Fri, 3 Dec 2021 at 23:34, Gavin Shan wrote: > >> diff --git a/hw/virtio/virtio-mem.c b/hw/virtio/virtio-mem.c > >> index b20595a496..21e4d572ab 100644 > >> --- a/hw/virtio/virtio-mem.c

Re: ui/cocoa.m compile error

2022-01-10 Thread Peter Maydell
On Fri, 7 Jan 2022 at 23:47, Liviu Ionescu wrote: > > > > > On 8 Jan 2022, at 00:16, Peter Maydell wrote: > > > > ... In this > > specific case, NSPasteboardTypeOwner seems to be part of > > an API introduced in 10.14 (Mojave). > > Thank you for the details, this explains the error. > > > So the

Re: ui/cocoa.m compile error (Cocoa -> SDL)

2022-01-10 Thread Liviu Ionescu
I now have successful builds on all platforms, including on macOS 11 with Apple Silicon and macOS 10.13 with Intel, but I had to disable Cocoa support, and enable SDL support. The resulting binaries (qemu-system-arm/aarch64/riscv32/riscv64) start, but I could not tell if the lack of Cocoa in th

Re: [PATCH v2] target/arm/cpu64: Use 32-bit GDBstub when running in 32-bit KVM mode

2022-01-10 Thread Alex Bennée
Ard Biesheuvel writes: > When running under KVM, we may decide to run the CPU in 32-bit mode, by > setting the 'aarch64=off' CPU option. In this case, we need to switch to > the 32-bit version of the GDB stub too, so that GDB has the correct view > of the CPU state. Without this, GDB debugging

Re: [PATCH v1 27/34] tests/avocado: add :avocado: tags for some tests

2022-01-10 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > On 1/5/22 14:50, Alex Bennée wrote: >> This stops a bunch of tests failing because of a lack of >> "./qemu-system-x86-64" in a build directory where you have configured >> only one non-default target. I suspect what we really need is: >> >> :avocado: tags=a

/usr/shared/qemu binaries

2022-01-10 Thread Liviu Ionescu
I successfully built two QEMU 6.2 binary packages, one with Arm and one with RISC-V, each with standalone variants for Linux Intel, Linux Arm, Windows Intel, macOS Intel and macOS Arm. Each package includes only the relevant executables (qemu-system-arm/aarch64 and respectively qemu-system-risc

Re: [PATCH v1 1/2] decodetree: Add an optional predicate-function for decoding

2022-01-10 Thread Philippe Mathieu-Daudé
On 1/10/22 10:52, Philipp Tomsich wrote: > For RISC-V the opcode decode will change between different vendor > implementations of RISC-V (emulated by the same qemu binary). > Any two vendors may reuse the same opcode space, e.g., we may end up with: > > # *** RV64 Custom-3 Extension *** > { > vt

Re: [PATCH v1 1/2] decodetree: Add an optional predicate-function for decoding

2022-01-10 Thread Philipp Tomsich
Philippe, Assuming that we move into this direction for the vendor-extensions, I would like to also see some of the other conditionally available extensions in RISC-V to move to predicated decode (which would move this mechanism past overlapping multi-patterns). E.g., we have the following clumsi

Re: [PATCH v1 19/34] tests/tcg: use CONFIG_LINUX_USER, not CONFIG_LINUX

2022-01-10 Thread Philippe Mathieu-Daudé
+Warner On 1/5/22 14:49, Alex Bennée wrote: > From: Paolo Bonzini > > The two more or less overlap, because CONFIG_LINUX is a requirement for Linux > user-mode emulation. However, CONFIG_LINUX is technically a host symbol > that applies even to system emulation. Defining CONFIG_LINUX_USER, and

Re: [PATCH v1 27/34] tests/avocado: add :avocado: tags for some tests

2022-01-10 Thread Philippe Mathieu-Daudé
On 1/5/22 14:50, Alex Bennée wrote: > This stops a bunch of tests failing because of a lack of > "./qemu-system-x86-64" in a build directory where you have configured > only one non-default target. I suspect what we really need is: > > :avocado: tags=arch:host This doesn't seem right, these t

Re: [PATCH v1 25/34] linux-user/elfload: add extra logging for hole finding

2022-01-10 Thread Philippe Mathieu-Daudé
On 1/5/22 14:50, Alex Bennée wrote: > The various approaches to finding memory holes are quite complicated > to follow especially at a distance. Improve the logging so we can see > exactly what method found the space for the guest memory. > > Signed-off-by: Alex Bennée > --- > linux-user/elfload

Re: [PATCH v1 1/2] decodetree: Add an optional predicate-function for decoding

2022-01-10 Thread Philipp Tomsich
For RISC-V the opcode decode will change between different vendor implementations of RISC-V (emulated by the same qemu binary). Any two vendors may reuse the same opcode space, e.g., we may end up with: # *** RV64 Custom-3 Extension *** { vt_maskc 000 . . 110 . 011 @r |has

Re: [RFC PATCH 6/7] x86: Use new XSAVE ioctls handling

2022-01-10 Thread Zeng Guang
On 1/10/2022 4:40 PM, Tian, Kevin wrote: From: Zhong, Yang Sent: Friday, January 7, 2022 5:32 PM From: Jing Liu Extended feature has large state while current kvm_xsave only allows 4KB. Use new XSAVE ioctls if the xstate size is large than kvm_xsave. shouldn't we always use the new xsave ioc

Re: [PATCH] net/dump.c: Suppress spurious compiler warning

2022-01-10 Thread Philipp Tomsich
Note that I don't expect this to get applied. I just put it onto the list for visibility and to make the workaround available for downstream users that might run into the issue while Ubuntu 22.04 is maturing. I won't have any time to dig into this on the GCC side until GCC12 is out. Philipp. On

Re: [PATCH v1 1/2] decodetree: Add an optional predicate-function for decoding

2022-01-10 Thread Philippe Mathieu-Daudé
Hi Philipp, On 1/9/22 21:56, Philipp Tomsich wrote: > This adds the possibility to specify a predicate-function that is > called as part of decoding in multi-patterns; it is intended for > use-cases (such as vendor-defined instructions in RISC-V) where the > same bitpattern may decode into differe

Re: [PATCH v2 4/5] libvhost-user: prevent over-running max RAM slots

2022-01-10 Thread Michael S. Tsirkin
On Thu, Jan 06, 2022 at 06:47:35AM +, Raphael Norwitz wrote: > When VHOST_USER_PROTOCOL_F_CONFIGURE_MEM_SLOTS support was added to > libvhost-user, no guardrails were added to protect against QEMU > attempting to hot-add too many RAM slots to a VM with a libvhost-user > based backed attached. >

Re: [PATCH] net/dump.c: Suppress spurious compiler warning

2022-01-10 Thread Philippe Mathieu-Daudé
Cc'ing Richard & Eric for dubious compiler warning. On 1/9/22 21:57, Philipp Tomsich wrote: > Compiling with gcc version 11.2.0 (Ubuntu 11.2.0-13ubuntu1) results in > a (spurious) warning: > > In function ‘dump_receive_iov’, > inlined from ‘filter_dump_receive_iov’ at ../net/dump.c:157:5:

Re: [RFC 06/10] vdpa-dev: implement the unrealize interface

2022-01-10 Thread Stefano Garzarella
On Thu, Jan 06, 2022 at 03:23:07AM +, Longpeng (Mike, Cloud Infrastructure Service Product Dept.) wrote: -Original Message- From: Stefano Garzarella [mailto:sgarz...@redhat.com] Sent: Wednesday, January 5, 2022 7:16 PM To: Longpeng (Mike, Cloud Infrastructure Service Product Dept.

Re: [PATCH v2 1/5] libvhost-user: Add vu_rem_mem_reg input validation

2022-01-10 Thread Michael S. Tsirkin
On Thu, Jan 06, 2022 at 06:47:26AM +, Raphael Norwitz wrote: > Signed-off-by: Raphael Norwitz Raphael any chance you can add a bit more to commit logs? E.g. what happens right now if you pass more? > --- > subprojects/libvhost-user/libvhost-user.c | 6 ++ > 1 file changed, 6 insertions

Re: [PATCH] hw/sensor: Add SB-TSI Temperature Sensor Interface

2022-01-10 Thread Philippe Mathieu-Daudé
Hi Patrick, On 1/8/22 04:04, Patrick Venture wrote: > From: Hao Wu > > SB Temperature Sensor Interface (SB-TSI) is an SMBus compatible > interface that reports AMD SoC's Ttcl (normalized temperature), > and resembles a typical 8-pin remote temperature sensor's I2C interface > to BMC. > > This p

Re: [PATCH] hw: timer: ibex_timer: Fixup reading w/o register

2022-01-10 Thread Philippe Mathieu-Daudé
On 1/10/22 06:16, Alistair Francis wrote: > From: Wilfred Mallawa > > This change fixes a bug where a write only register is read. > As per https://docs.opentitan.org/hw/ip/rv_timer/doc/#register-table > the 'INTR_TEST0' register is write only. > > Signed-off-by: Wilfred Mallawa > --- > hw/tim

Re: [PATCH v2 6/6] gitlab-ci: Support macOS 12 via cirrus-run

2022-01-10 Thread Daniel P . Berrangé
On Sun, Jan 09, 2022 at 06:06:12PM +0100, Philippe Mathieu-Daudé wrote: > Add support for macOS 12 build on Cirrus-CI, similarly to commit > 0e103a65ba1 ("gitlab: support for ... macOS 11 via cirrus-run"). > > Disable deprecation warnings on Objective C to avoid: > > [2789/6622] Compiling Objec

Re: [PATCH v2 9/9] hw/dma: Let dma_buf_read() / dma_buf_write() propagate MemTxResult

2022-01-10 Thread Philippe Mathieu-Daudé
On 1/10/22 09:51, David Hildenbrand wrote: > On 04.01.22 09:54, Philippe Mathieu-Daudé wrote: >> From: Philippe Mathieu-Daudé >> >> Since the previous commit, dma_buf_rw() returns a MemTxResult >> type. Do not discard it, return it to the caller. >> >> Since both dma_buf_read/dma_buf_write functio

Re: [PATCH v2 8/9] hw/dma: Use dma_addr_t type definition when relevant

2022-01-10 Thread Philippe Mathieu-Daudé
On 1/10/22 09:49, David Hildenbrand wrote: > On 04.01.22 09:54, Philippe Mathieu-Daudé wrote: >> From: Philippe Mathieu-Daudé >> >> Update the obvious places where dma_addr_t should be used >> (instead of uint64_t, hwaddr, size_t, int32_t types). >> >> This allows to have &dma_addr_t type portable

Re: [PATCH v2 0/5] Clean up error handling in libvhost-user memory mapping

2022-01-10 Thread David Hildenbrand
On 06.01.22 07:47, Raphael Norwitz wrote: > Hey Stefan, Marc-Andre, MST, David - > > As promised here is a series cleaning up error handling in the > libvhost-user memory mapping path. Most of these cleanups are > straightforward and have been discussed on the mailing list in threads > [1] and [2]

Re: [PATCH v2 4/5] libvhost-user: prevent over-running max RAM slots

2022-01-10 Thread David Hildenbrand
On 06.01.22 07:47, Raphael Norwitz wrote: > When VHOST_USER_PROTOCOL_F_CONFIGURE_MEM_SLOTS support was added to > libvhost-user, no guardrails were added to protect against QEMU > attempting to hot-add too many RAM slots to a VM with a libvhost-user > based backed attached. > > This change adds th

Re: [PATCH v2 5/5] libvhost-user: handle removal of identical regions

2022-01-10 Thread David Hildenbrand
On 06.01.22 07:47, Raphael Norwitz wrote: > Today if QEMU (or any other VMM) has sent multiple copies of the same > region to a libvhost-user based backend and then attempts to remove the > region, only one instance of the region will be removed, leaving stale > copies of the region in dev->regions

Re: [PATCH v2 1/5] libvhost-user: Add vu_rem_mem_reg input validation

2022-01-10 Thread David Hildenbrand
On 06.01.22 07:47, Raphael Norwitz wrote: > Signed-off-by: Raphael Norwitz > --- > subprojects/libvhost-user/libvhost-user.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/subprojects/libvhost-user/libvhost-user.c > b/subprojects/libvhost-user/libvhost-user.c > index 787f4d2d4f.

Re: [PATCH v2 2/5] libvhost-user: Add vu_add_mem_reg input validation

2022-01-10 Thread David Hildenbrand
On 06.01.22 07:47, Raphael Norwitz wrote: > Signed-off-by: Raphael Norwitz > --- > subprojects/libvhost-user/libvhost-user.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/subprojects/libvhost-user/libvhost-user.c > b/subprojects/libvhost-user/libvhost-user.c > index a6dadeb637.

Re: [PATCH v2 9/9] hw/dma: Let dma_buf_read() / dma_buf_write() propagate MemTxResult

2022-01-10 Thread David Hildenbrand
On 04.01.22 09:54, Philippe Mathieu-Daudé wrote: > From: Philippe Mathieu-Daudé > > Since the previous commit, dma_buf_rw() returns a MemTxResult > type. Do not discard it, return it to the caller. > > Since both dma_buf_read/dma_buf_write functions were previously > returning the QEMUSGList siz

Re: [PATCH v2 8/9] hw/dma: Use dma_addr_t type definition when relevant

2022-01-10 Thread David Hildenbrand
On 04.01.22 09:54, Philippe Mathieu-Daudé wrote: > From: Philippe Mathieu-Daudé > > Update the obvious places where dma_addr_t should be used > (instead of uint64_t, hwaddr, size_t, int32_t types). > > This allows to have &dma_addr_t type portable on 32/64-bit > hosts. > > Move QEMUSGList decla

Re: [PATCH v2 6/6] gitlab-ci: Support macOS 12 via cirrus-run

2022-01-10 Thread Akihiko Odaki
On 2022/01/10 2:06, Philippe Mathieu-Daudé wrote: Add support for macOS 12 build on Cirrus-CI, similarly to commit 0e103a65ba1 ("gitlab: support for ... macOS 11 via cirrus-run"). Disable deprecation warnings on Objective C to avoid: [2789/6622] Compiling Objective-C object libcommon.fa.p

Re: [PATCH v2 7/9] hw/dma: Fix format string issues using dma_addr_t

2022-01-10 Thread David Hildenbrand
On 04.01.22 09:54, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/ide/ahci.c| 2 +- > hw/rdma/trace-events | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c > index 205dfdc6622..6c727dd0c08 100644 >

Re: [PATCH v2 5/9] hw/rdma/rdma_utils: Rename rdma_pci_dma_map 'len' argument

2022-01-10 Thread David Hildenbrand
On 04.01.22 09:54, Philippe Mathieu-Daudé wrote: > From: Philippe Mathieu-Daudé > > Various APIs use 'pval' naming for 'pointer to val'. > rdma_pci_dma_map() uses 'plen' for 'PCI length', but since > 'PCI' is already explicit in the function name, simplify > and rename the argument 'len'. No logi

Re: [PATCH v2 4/9] hw/dma: Remove CONFIG_USER_ONLY check

2022-01-10 Thread David Hildenbrand
On 04.01.22 09:54, Philippe Mathieu-Daudé wrote: > From: Philippe Mathieu-Daudé > > DMA API should not be included in user-mode emulation. > If so, build should fail. Remove the CONFIG_USER_ONLY check. > > Signed-off-by: Philippe Mathieu-Daudé > Signed-off-by: Philippe Mathieu-Daudé > --- > i

Re: [PATCH v2 6/9] hw/scsi: Rename SCSIRequest::resid as 'residual'

2022-01-10 Thread David Hildenbrand
On 04.01.22 09:54, Philippe Mathieu-Daudé wrote: > From: Philippe Mathieu-Daudé > > The 'resid' field is slightly confusing and could be > interpreted as some ID. Rename it as 'residual' which > is clearer to review. No logical change. > > Signed-off-by: Philippe Mathieu-Daudé > Signed-off-by:

Re: [RFC PATCH v2 2/6] audio/coreaudio: Remove a deprecation warning on macOS 12

2022-01-10 Thread Philippe Mathieu-Daudé
On 1/10/22 09:17, Akihiko Odaki wrote: > On 2022/01/10 2:06, Philippe Mathieu-Daudé wrote: >> When building on macOS 12 we get: >> >>    audio/coreaudio.c:50:5: error: 'kAudioObjectPropertyElementMaster' >> is deprecated: first deprecated in macOS 12.0 >> [-Werror,-Wdeprecated-declarations] >>

Re: [PATCH v2 2/9] hw/pci: Restrict pci-bus stub to sysemu

2022-01-10 Thread David Hildenbrand
On 04.01.22 09:54, Philippe Mathieu-Daudé wrote: > From: Philippe Mathieu-Daudé > > Neither tools nor user-mode emulation require the PCI bus stub. > > Signed-off-by: Philippe Mathieu-Daudé > Signed-off-by: Philippe Mathieu-Daudé > --- > stubs/meson.build | 2 +- > 1 file changed, 1 insertion

RE: [RFC PATCH 6/7] x86: Use new XSAVE ioctls handling

2022-01-10 Thread Tian, Kevin
> From: Zhong, Yang > Sent: Friday, January 7, 2022 5:32 PM > > From: Jing Liu > > Extended feature has large state while current > kvm_xsave only allows 4KB. Use new XSAVE ioctls > if the xstate size is large than kvm_xsave. shouldn't we always use the new xsave ioctls as long as CAP_XSAVE2 i

RE: [RFC PATCH 4/7] x86: Add XFD faulting bit for state components

2022-01-10 Thread Tian, Kevin
> From: Zhong, Yang > Sent: Friday, January 7, 2022 5:32 PM > > From: Jing Liu > > Intel introduces XFD faulting mechanism for extended > XSAVE features to dynamically enable the features in > runtime. If CPUID (EAX=0Dh, ECX=n, n>1).ECX[2] is set > as 1, it indicates support for XFD faulting of

RE: [RFC PATCH 3/7] x86: Grant AMX permission for guest

2022-01-10 Thread Tian, Kevin
> From: Zhong, Yang > Sent: Friday, January 7, 2022 5:32 PM > > Kernel mechanism for dynamically enabled XSAVE features there is no definition of "dynamically-enabled XSAVE features). > asks userspace VMM requesting guest permission if it wants > to expose the features. Only with the permission

Re: [PATCH v4 09/11] target/riscv: Simplify counter predicate function

2022-01-10 Thread Bin Meng
On Fri, Jan 7, 2022 at 10:22 AM Atish Patra wrote: > > All the hpmcounters and the fixed counters (CY, IR, TM) can be represented > as a unified counter. Thus, the predicate function doesn't need handle each > case separately. > > Simplify the predicate function so that we just handle things diffe

RE: [RFC PATCH 2/7] x86: Add AMX XTILECFG and XTILEDATA components

2022-01-10 Thread Tian, Kevin
> From: Zhong, Yang > Sent: Friday, January 7, 2022 5:31 PM > > From: Jing Liu > > AMX XTILECFG and XTILEDATA are managed by XSAVE feature > set. State component 17 is used for 64-byte TILECFG register > (XTILECFG state) and component 18 is used for 8192 bytes > of tile data (XTILEDATA state).

RE: [RFC PATCH 1/7] x86: Fix the 64-byte boundary enumeration for extended state

2022-01-10 Thread Tian, Kevin
> From: Zhong, Yang > Sent: Friday, January 7, 2022 5:31 PM > > From: Jing Liu > > The extended state subleaves (EAX=0Dh, ECX=n, n>1).ECX[1] > are all zero, while spec actually introduces that bit 01 > should indicate if the extended state component locates > on the next 64-byte boundary follow

Re: [RFC PATCH v2 2/6] audio/coreaudio: Remove a deprecation warning on macOS 12

2022-01-10 Thread Akihiko Odaki
On 2022/01/10 2:06, Philippe Mathieu-Daudé wrote: When building on macOS 12 we get: audio/coreaudio.c:50:5: error: 'kAudioObjectPropertyElementMaster' is deprecated: first deprecated in macOS 12.0 [-Werror,-Wdeprecated-declarations] kAudioObjectPropertyElementMaster ^~~~

Re: [PATCH] target/ppc: Fix e6500 boot

2022-01-10 Thread Cédric Le Goater
Hello Mario, I have tried to launch a freshly compiled qemu from git master on a NXP T2080RDB devkit that has a e6500 CPU in combination with a freshly compiled kernel 5.16-rc6 I have Debian SID ppc64 up and running using such a kernel, and when I launch qemu to run a VM with the same debian

Re: [PATCH v3 0/8] target/ppc: powerpc_excp improvements (2/n)

2022-01-10 Thread Cédric Le Goater
Hello Fabiano, On 1/7/22 23:25, Fabiano Rosas wrote: Version 3: - patches 1,3,4,5,6,7: unchanged, reviewed; - patch 2: started using qemu_loglevel_mask(CPU_LOG_MMU) instead of qemu_log_enabled; I decided to not rename the function at this point because it is

Re: [PATCH 1/2] riscv: opentitan: fixup plic stride len

2022-01-10 Thread Bin Meng
On Mon, Jan 10, 2022 at 2:13 PM Alistair Francis wrote: > > From: Wilfred Mallawa > > The following change was made to rectify incorrectly set stride length > on the PLIC. Where it should be 32bit and not 24bit (0x18). This was PLIC [1] > discovered whilst attempting to fix a bug where a timer_

Re: [PATCH v3 7/7] target/riscv: rvk: expose zbk* and zk* properties

2022-01-10 Thread Weiwei Li
在 2022/1/10 下午3:06, Alistair Francis 写道: On Fri, Dec 31, 2021 at 12:32 AM liweiwei wrote: Signed-off-by: liweiwei Signed-off-by: wangjunqiang --- target/riscv/cpu.c | 13 + 1 file changed, 13 insertions(+) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index 961c5f4334

<    1   2   3   4