[PATCH v6 2/8] tcg/sparc: Split out tcg_out_movi_imm32

2022-02-07 Thread Richard Henderson
Handle 32-bit constants with a separate function, so that tcg_out_movi_int does not need to recurse. This slightly rearranges the order of tests for small constants, but produces the same output. Signed-off-by: Richard Henderson --- tcg/sparc/tcg-target.c.inc | 36

Re: [PATCH 3/5] vduse-blk: implements vduse-blk export

2022-02-07 Thread Yongji Xie
On Mon, Feb 7, 2022 at 10:15 PM Stefan Hajnoczi wrote: > > On Tue, Jan 25, 2022 at 09:17:58PM +0800, Xie Yongji wrote: > > This implements a VDUSE block backends based on > > the libvduse library. We can use it to export the BDSs > > for both VM and container (host) usage. > > > > The new

[PATCH 2/5] linux-user: Introduce host_signal_mask

2022-02-07 Thread Richard Henderson
Do not directly access the uc_sigmask member. This is preparation for a sparc64 fix. Signed-off-by: Richard Henderson --- linux-user/include/host/aarch64/host-signal.h | 5 + linux-user/include/host/alpha/host-signal.h| 5 + linux-user/include/host/arm/host-signal.h | 5

[PATCH v6 1/8] tcg/sparc: Use tcg_out_movi_imm13 in tcg_out_addsub2_i64

2022-02-07 Thread Richard Henderson
When BH is constant, it is constrained to 10 bits for use in MOVCC. For the cases in which we must load the constant BH into a register, we do not need the full logic of tcg_out_movi; we can use the simpler function for emitting a 13 bit constant. This eliminates the only case in which TCG_REG_T2

[PATCH 5/5] linux-user/include/host/sparc64: Fix host_sigcontext

2022-02-07 Thread Richard Henderson
Sparc64 is unique on linux in *not* passing ucontext_t as the third argument to a SA_SIGINFO handler. It passes the old struct sigcontext instead.t log Fixes: 8b5bd461935b ("linux-user/host/sparc: Populate host_signal.h") Signed-off-by: Richard Henderson ---

Re: [PATCH v9 00/23] QEMU RISC-V AIA support

2022-02-07 Thread Alistair Francis
On Tue, Feb 8, 2022 at 2:16 PM Alistair Francis wrote: > > On Sat, Feb 5, 2022 at 3:47 AM Anup Patel wrote: > > > > From: Anup Patel > > > > The advanced interrupt architecture (AIA) extends the per-HART local > > interrupt support. Along with this, it also adds IMSIC (MSI contrllor) > > and

Re: [PATCH 16/31] vhost: pass queue index to vhost_vq_get_addr

2022-02-07 Thread Jason Wang
在 2022/2/1 上午1:44, Eugenio Perez Martin 写道: On Sat, Jan 29, 2022 at 9:20 AM Jason Wang wrote: 在 2022/1/22 上午4:27, Eugenio Pérez 写道: Doing that way allows vhost backend to know what address to return. Signed-off-by: Eugenio Pérez --- hw/virtio/vhost.c | 6 +++--- 1 file changed, 3

Re: [PATCH] hvf: arm: Handle ID_AA64ISAR2_EL1 reads

2022-02-07 Thread Ivan Babrou
The patch addresses the current issue for me, thanks! Is it possible to make it more future proof? I can imagine a very similar situation arising in the future and it would be good to be able to handle it gracefully. If it's not possible, then maybe there's a way to output some sort of error from

Re: [PATCH 2/5] libvduse: Add VDUSE (vDPA Device in Userspace) library

2022-02-07 Thread Yongji Xie
On Mon, Feb 7, 2022 at 10:01 PM Stefan Hajnoczi wrote: > > On Tue, Jan 25, 2022 at 09:17:57PM +0800, Xie Yongji wrote: > > VDUSE [1] is a linux framework that makes it possible to implement > > software-emulated vDPA devices in userspace. This adds a library > > as a subproject to help

Re: [PATCH v6 3/7] target/riscv: access configuration through cfg_ptr in DisasContext

2022-02-07 Thread Alistair Francis
On Tue, Feb 8, 2022 at 4:07 PM Alistair Francis wrote: > > On Wed, Feb 2, 2022 at 11:26 AM Philipp Tomsich > wrote: > > > > The implementation in trans_{rvi,rvv,rvzfh}.c.inc accesses the shallow > > copies (in DisasContext) of some of the elements available in the > > RISCVCPUConfig structure.

Re: [PATCH v6 3/7] target/riscv: access configuration through cfg_ptr in DisasContext

2022-02-07 Thread Alistair Francis
On Wed, Feb 2, 2022 at 11:26 AM Philipp Tomsich wrote: > > The implementation in trans_{rvi,rvv,rvzfh}.c.inc accesses the shallow > copies (in DisasContext) of some of the elements available in the > RISCVCPUConfig structure. This commit redirects accesses to use the > cfg_ptr copied into

Re: [PATCH 08/11] mos6522: add "info via" HMP command for debugging

2022-02-07 Thread Philippe Mathieu-Daudé via
On 7/2/22 20:34, Peter Maydell wrote: On Thu, 27 Jan 2022 at 21:03, Mark Cave-Ayland wrote: This displays detailed information about the device registers and timers to aid debugging problems with timers and interrupts. Signed-off-by: Mark Cave-Ayland --- hmp-commands-info.hx | 12 ++

Re: [PATCH] MAINTAINERS: python - remove ehabkost and add bleal

2022-02-07 Thread Philippe Mathieu-Daudé via
On 8/2/22 01:05, John Snow wrote: Eduardo Habkost has left Red Hat and has other daily responsibilities to attend to. In order to stop spamming him on every series, remove him as "Reviewer" for the python/ library dir and add Beraldo Leal instead. For the "python scripts" stanza (which is

Re: target/arm: cp15.dacr migration

2022-02-07 Thread Pavel Dovgalyuk
On 07.02.2022 16:44, Peter Maydell wrote: On Mon, 7 Feb 2022 at 12:13, Pavel Dovgalyuk wrote: I recently encountered a problem with cp15.dacr register. It has _s and _ns versions. During the migration only dacr_ns is saved/loaded. But both of the values are used in get_phys_addr_v5 and

Re: [PATCH RFC 14/15] migration: Postcopy preemption on separate channel

2022-02-07 Thread Peter Xu
On Thu, Feb 03, 2022 at 05:45:32PM +, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > This patch enables postcopy-preempt feature. > > > > It contains two major changes to the migration logic: > > > > (1) Postcopy requests are now sent via a different socket from

Re: [PATCH v9 00/23] QEMU RISC-V AIA support

2022-02-07 Thread Alistair Francis
On Sat, Feb 5, 2022 at 3:47 AM Anup Patel wrote: > > From: Anup Patel > > The advanced interrupt architecture (AIA) extends the per-HART local > interrupt support. Along with this, it also adds IMSIC (MSI contrllor) > and Advanced PLIC (wired interrupt controller). > > The latest AIA draft

Re: [PATCH 17/31] vdpa: adapt vhost_ops callbacks to svq

2022-02-07 Thread Jason Wang
在 2022/2/1 上午2:58, Eugenio Perez Martin 写道: On Sun, Jan 30, 2022 at 5:03 AM Jason Wang wrote: 在 2022/1/22 上午4:27, Eugenio Pérez 写道: First half of the buffers forwarding part, preparing vhost-vdpa callbacks to SVQ to offer it. QEMU cannot enable it at this moment, so this is effectively

Re: [PATCH RFC 10/15] migration: Move static var in ram_block_from_stream() into global

2022-02-07 Thread Peter Xu
On Thu, Feb 03, 2022 at 05:48:31PM +, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > Static variable is very unfriendly to threading of ram_block_from_stream(). > > Move it into MigrationIncomingState. > > > > Make the incoming state pointer to be passed over to >

Re: [PATCH 11/31] vhost: Add vhost_svq_valid_device_features to shadow vq

2022-02-07 Thread Jason Wang
在 2022/2/1 下午6:57, Eugenio Perez Martin 写道: On Mon, Jan 31, 2022 at 4:49 PM Eugenio Perez Martin wrote: On Sat, Jan 29, 2022 at 9:11 AM Jason Wang wrote: 在 2022/1/22 上午4:27, Eugenio Pérez 写道: This allows SVQ to negotiate features with the device. For the device, SVQ is a driver. While

Re: [PATCH RFC 09/15] migration: Add postcopy_thread_create()

2022-02-07 Thread Peter Xu
On Thu, Feb 03, 2022 at 03:19:48PM +, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > Postcopy create threads. A common manner is we init a sem and use it to sync > > with the thread. Namely, we have fault_thread_sem and listen_thread_sem and > > they're only used

Re: [PATCH RFC 07/15] migration: Introduce postcopy channels on dest node

2022-02-07 Thread Peter Xu
On Thu, Feb 03, 2022 at 03:08:39PM +, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > Postcopy handles huge pages in a special way that currently we can only have > > one "channel" to transfer the page. > > > > It's because when we install pages using UFFDIO_COPY, we

Re: [PATCH 09/31] vhost-vdpa: Take into account SVQ in vhost_vdpa_set_vring_call

2022-02-07 Thread Jason Wang
在 2022/1/31 下午11:34, Eugenio Perez Martin 写道: On Sat, Jan 29, 2022 at 9:06 AM Jason Wang wrote: 在 2022/1/22 上午4:27, Eugenio Pérez 写道: Signed-off-by: Eugenio Pérez --- hw/virtio/vhost-vdpa.c | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git

Re: [PATCH RFC 02/15] migration: Allow pss->page jump over clean pages

2022-02-07 Thread Peter Xu
On Thu, Feb 03, 2022 at 06:19:22PM +, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > On Wed, Jan 19, 2022 at 01:42:47PM +, Dr. David Alan Gilbert wrote: > > > * Peter Xu (pet...@redhat.com) wrote: > > > > Commit ba1b7c812c ("migration/ram: Optimize

Re: [PATCH 1/5] linux-headers: Add vduse.h

2022-02-07 Thread Yongji Xie
On Mon, Feb 7, 2022 at 9:12 PM Stefan Hajnoczi wrote: > > On Tue, Jan 25, 2022 at 09:17:56PM +0800, Xie Yongji wrote: > > diff --git a/scripts/update-linux-headers.sh > > b/scripts/update-linux-headers.sh > > index fea4d6eb65..4c7846076f 100755 > > --- a/scripts/update-linux-headers.sh > > +++

Re: [PATCH v8 5/5] multifd: Implement zero copy write in multifd migration (multifd-zero-copy)

2022-02-07 Thread Peter Xu
On Mon, Feb 07, 2022 at 11:49:38PM -0300, Leonardo Bras Soares Passos wrote: > Hello Peter, thanks for reviewing! > > On Mon, Feb 7, 2022 at 11:22 PM Peter Xu wrote: > > > > On Tue, Feb 01, 2022 at 03:29:03AM -0300, Leonardo Bras wrote: > > > -void multifd_send_sync_main(QEMUFile *f) > > > +int

Re: [PATCH v8 5/5] multifd: Implement zero copy write in multifd migration (multifd-zero-copy)

2022-02-07 Thread Leonardo Bras Soares Passos
Hello Peter, thanks for reviewing! On Mon, Feb 7, 2022 at 11:22 PM Peter Xu wrote: > > On Tue, Feb 01, 2022 at 03:29:03AM -0300, Leonardo Bras wrote: > > -void multifd_send_sync_main(QEMUFile *f) > > +int multifd_send_sync_main(QEMUFile *f) > > { > > int i; > > +bool flush_zero_copy; >

Re: [PATCH v5 1/1] virtio: fix the condition for iommu_platform not supported

2022-02-07 Thread Jason Wang
On Mon, Feb 7, 2022 at 7:29 PM Halil Pasic wrote: > > The commit 04ceb61a40 ("virtio: Fail if iommu_platform is requested, but > unsupported") claims to fail the device hotplug when iommu_platform > is requested, but not supported by the (vhost) device. On the first > glance the condition for

Re: [PATCH 1/4] target/ppc: Remove powerpc_excp_legacy

2022-02-07 Thread David Gibson
On Mon, Feb 07, 2022 at 03:30:33PM -0300, Fabiano Rosas wrote: > Now that all CPU families have their own separate exception > dispatching code we can remove powerpc_excp_legacy. > > Signed-off-by: Fabiano Rosas > --- > target/ppc/excp_helper.c | 477 +-- > 1

Re: [PATCH v8 5/5] multifd: Implement zero copy write in multifd migration (multifd-zero-copy)

2022-02-07 Thread Peter Xu
On Tue, Feb 01, 2022 at 03:29:03AM -0300, Leonardo Bras wrote: > -void multifd_send_sync_main(QEMUFile *f) > +int multifd_send_sync_main(QEMUFile *f) > { > int i; > +bool flush_zero_copy; > > if (!migrate_use_multifd()) { > -return; > +return 0; > } > if

Re: [RFC PATCH 1/1] virtio: fix feature negotiation for ACCESS_PLATFORM

2022-02-07 Thread Halil Pasic
On Mon, 7 Feb 2022 16:46:04 -0300 Daniel Henrique Barboza wrote: > On 2/7/22 11:46, Halil Pasic wrote: > > On Mon, 7 Feb 2022 08:46:34 -0300 > > Daniel Henrique Barboza wrote: > > > > I have considered this and decided against it. The reason why is > > if that approach is taken, we can't

Re: [PATCH] hvf: arm: Handle ID_AA64ISAR2_EL1 reads

2022-02-07 Thread Cameron Esfahani
Reviewed-by: Cameron Esfahani mailto:di...@apple.com>> Cameron > On Feb 7, 2022, at 2:52 PM, Alexander Graf wrote: > > Recent Linux versions added support to read ID_AA64ISAR2_EL1. On M1, > those reads trap into QEMU which handles them as faults. > > However, according to the ARMv8 spec

[PATCH] MAINTAINERS: python - remove ehabkost and add bleal

2022-02-07 Thread John Snow
Eduardo Habkost has left Red Hat and has other daily responsibilities to attend to. In order to stop spamming him on every series, remove him as "Reviewer" for the python/ library dir and add Beraldo Leal instead. For the "python scripts" stanza (which is separate due to level of support),

Re: [PATCH v5 10/11] 9p: darwin: meson: Allow VirtFS on Darwin

2022-02-07 Thread Will Cohen
On Mon, Feb 7, 2022 at 6:44 PM Christian Schoenebeck wrote: > On Montag, 7. Februar 2022 23:40:23 CET Will Cohen wrote: > > From: Keno Fischer > > > > To allow VirtFS on darwin, we need to check that pthread_fchdir_np is > > available, which has only been available since macOS 10.12. > > > >

Re: [PATCH v5 10/11] 9p: darwin: meson: Allow VirtFS on Darwin

2022-02-07 Thread Christian Schoenebeck
On Montag, 7. Februar 2022 23:40:23 CET Will Cohen wrote: > From: Keno Fischer > > To allow VirtFS on darwin, we need to check that pthread_fchdir_np is > available, which has only been available since macOS 10.12. > > Additionally, virtfs_proxy_helper is disabled on Darwin. This patch > series

Re: [PATCH 06/16] hw/arm/xlnx-zcu102: Don't enable PSCI conduit when booting guest in EL3

2022-02-07 Thread Alexander Graf
On 07.02.22 19:59, Philippe Mathieu-Daudé wrote: On 7/2/22 19:13, Edgar E. Iglesias wrote: On Mon, Feb 7, 2022 at 5:24 PM Alexander Graf > wrote:     On 07.02.22 17:06, Philippe Mathieu-Daudé wrote: > On 7/2/22 16:59, Alexander Graf wrote: >> >> On

Re: [PATCH v2] tests/qtest: add qtests for npcm7xx sdhci

2022-02-07 Thread Patrick Venture
On Mon, Feb 7, 2022 at 9:34 AM Peter Maydell wrote: > On Sun, 6 Feb 2022 at 01:41, Patrick Venture wrote: > > > > From: Shengtan Mao > > > > Reviewed-by: Hao Wu > > Reviewed-by: Chris Rauer > > Signed-off-by: Shengtan Mao > > Signed-off-by: Patrick Venture > > --- > > v2: > > * update

[PATCH] hvf: arm: Handle ID_AA64ISAR2_EL1 reads

2022-02-07 Thread Alexander Graf
Recent Linux versions added support to read ID_AA64ISAR2_EL1. On M1, those reads trap into QEMU which handles them as faults. However, according to the ARMv8 spec (issue D17783), reads on this register in older ARMv8 revisions should be RES0. So let's treat it as such instead. Reported-by: Ivan

[PATCH v5 10/11] 9p: darwin: meson: Allow VirtFS on Darwin

2022-02-07 Thread Will Cohen
From: Keno Fischer To allow VirtFS on darwin, we need to check that pthread_fchdir_np is available, which has only been available since macOS 10.12. Additionally, virtfs_proxy_helper is disabled on Darwin. This patch series does not currently provide an implementation of the proxy-helper, but

Re: [PATCH v5 09/11] 9p: darwin: Implement compatibility for mknodat

2022-02-07 Thread Christian Schoenebeck
On Montag, 7. Februar 2022 23:40:22 CET Will Cohen wrote: > From: Keno Fischer > > Darwin does not support mknodat. However, to avoid race conditions > with later setting the permissions, we must avoid using mknod on > the full path instead. We could try to fchdir, but that would cause >

[PATCH v5 08/11] 9p: darwin: Compatibility for f/l*xattr

2022-02-07 Thread Will Cohen
From: Keno Fischer On darwin `fgetxattr` takes two extra optional arguments, and the l* variants are not defined (in favor of an extra flag to the regular variants. Signed-off-by: Keno Fischer [Michael Roitzsch: - Rebase for NixOS] Signed-off-by: Michael Roitzsch Signed-off-by: Will Cohen

Re: [PATCH v4 09/11] 9p: darwin: Implement compatibility for mknodat

2022-02-07 Thread Will Cohen
On Mon, Feb 7, 2022 at 5:48 PM Christian Schoenebeck wrote: > On Montag, 7. Februar 2022 22:07:34 CET Will Cohen wrote: > > On Mon, Feb 7, 2022 at 9:21 AM Christian Schoenebeck > > > > wrote: > > > On Montag, 7. Februar 2022 11:57:25 CET Dr. David Alan Gilbert wrote: > > > > * Greg Kurz

Re: [PATCH v4 09/11] 9p: darwin: Implement compatibility for mknodat

2022-02-07 Thread Christian Schoenebeck
On Montag, 7. Februar 2022 22:07:34 CET Will Cohen wrote: > On Mon, Feb 7, 2022 at 9:21 AM Christian Schoenebeck > > wrote: > > On Montag, 7. Februar 2022 11:57:25 CET Dr. David Alan Gilbert wrote: > > > * Greg Kurz (gr...@kaod.org) wrote: > > > > On Mon, 7 Feb 2022 11:30:18 +0100 > > > > > > >

[PATCH v5 06/11] 9p: darwin: Move XATTR_SIZE_MAX->P9_XATTR_SIZE_MAX

2022-02-07 Thread Will Cohen
From: Keno Fischer Signed-off-by: Keno Fischer Signed-off-by: Michael Roitzsch Because XATTR_SIZE_MAX is not defined on Darwin, create a cross-platform P9_XATTR_SIZE_MAX instead. [Will Cohen: - Adjust coding style - Lower XATTR_SIZE_MAX to 64k - Add explanatory

[PATCH v5 04/11] 9p: darwin: Handle struct dirent differences

2022-02-07 Thread Will Cohen
From: Keno Fischer On darwin d_seekoff exists, but is optional and does not seem to be commonly used by file systems. Use `telldir` instead to obtain the seek offset and inject it into d_seekoff, and create a qemu_dirent_off helper to call it appropriately when appropriate. Signed-off-by: Keno

[PATCH v5 02/11] 9p: Rename 9p-util -> 9p-util-linux

2022-02-07 Thread Will Cohen
From: Keno Fischer The current file only has the Linux versions of these functions. Rename the file accordingly and update the Makefile to only build it on Linux. A Darwin version of these will follow later in the series. Signed-off-by: Keno Fischer [Michael Roitzsch: - Rebase for NixOS]

[PATCH v5 07/11] 9p: darwin: *xattr_nofollow implementations

2022-02-07 Thread Will Cohen
From: Keno Fischer This implements the darwin equivalent of the functions that were moved to 9p-util(-linux) earlier in this series in the new 9p-util-darwin file. Signed-off-by: Keno Fischer [Michael Roitzsch: - Rebase for NixOS] Signed-off-by: Michael Roitzsch Signed-off-by: Will Cohen ---

[PATCH v5 05/11] 9p: darwin: Ignore O_{NOATIME, DIRECT}

2022-02-07 Thread Will Cohen
From: Keno Fischer Darwin doesn't have either of these flags. Darwin does have F_NOCACHE, which is similar to O_DIRECT, but has different enough semantics that other projects don't generally map them automatically. In any case, we don't support O_DIRECT on Linux at the moment either.

[PATCH v5 01/11] 9p: linux: Fix a couple Linux assumptions

2022-02-07 Thread Will Cohen
From: Keno Fischer - Guard Linux only headers. - Add qemu/statfs.h header to abstract over the which headers are needed for struct statfs - Define `ENOATTR` only if not only defined (it's defined in system headers on Darwin). Signed-off-by: Keno Fischer [Michael Roitzsch: - Rebase for

[PATCH v5 11/11] 9p: darwin: Adjust assumption on virtio-9p-test

2022-02-07 Thread Will Cohen
The previous test depended on the assumption that P9_DOTL_AT_REMOVEDIR and AT_REMOVEDIR have the same value. While this is true on Linux, it is not true everywhere, and leads to an incorrect test failure on unlink_at, noticed when adding 9p to darwin: Received response 7 (RLERROR) instead of 77

[PATCH v5 03/11] 9p: darwin: Handle struct stat(fs) differences

2022-02-07 Thread Will Cohen
From: Keno Fischer Signed-off-by: Keno Fischer Signed-off-by: Michael Roitzsch [Will Cohen: - Note lack of f_namelen and f_frsize on Darwin - Ensure that tv_sec and tv_nsec are both initialized for Darwin and non-Darwin] Signed-off-by: Will Cohen ---

[PATCH v5 09/11] 9p: darwin: Implement compatibility for mknodat

2022-02-07 Thread Will Cohen
From: Keno Fischer Darwin does not support mknodat. However, to avoid race conditions with later setting the permissions, we must avoid using mknod on the full path instead. We could try to fchdir, but that would cause problems if multiple threads try to call mknodat at the same time. However,

[PATCH v5 00/11] 9p: Add support for darwin

2022-02-07 Thread Will Cohen
This is a followup to https://lists.gnu.org/archive/html/qemu-devel/2022-02/msg01223.html, adding 9p server support for Darwin. Since v4, the following changes have been made to the following patches: Patch 4/11: 9p: darwin: Handle struct dirent differences - Cleanup of telldir error handling -

Re: [PATCH v4 09/11] 9p: darwin: Implement compatibility for mknodat

2022-02-07 Thread Will Cohen
On Mon, Feb 7, 2022 at 4:07 PM Will Cohen wrote: > On Mon, Feb 7, 2022 at 9:21 AM Christian Schoenebeck < > qemu_...@crudebyte.com> wrote: > >> On Montag, 7. Februar 2022 11:57:25 CET Dr. David Alan Gilbert wrote: >> > * Greg Kurz (gr...@kaod.org) wrote: >> > > On Mon, 7 Feb 2022 11:30:18 +0100

[PATCH 1/5] ui/gtk: new param monitor to specify target monitor for launching QEMU

2022-02-07 Thread Dongwon Kim
Introducing a new integer parameter to specify the monitor where the Qemu window is placed upon launching. Monitor can be any number between 0 and (total number of monitors - 1). It can be used together with full-screen=on, which will make the QEMU window full-screened on the targeted monitor.

Re: [PATCH v2 0/6] qtests/libqos: Allow PCI tests to be run with virt-machine

2022-02-07 Thread Eric Auger
Hi Michael, On 2/5/22 2:43 AM, Michael S. Tsirkin wrote: > On Tue, Jan 18, 2022 at 09:38:27PM +0100, Eric Auger wrote: >> Up to now the virt-machine node only contains a virtio-mmio >> driver node but no driver that eventually produces any pci-bus >> interface. >> >> Hence, PCI libqos tests

Re: [PATCH v5 1/6] tcg/sparc: Add scratch argument to tcg_out_movi_int

2022-02-07 Thread Richard Henderson
On 2/8/22 04:59, Peter Maydell wrote: On Sun, 6 Feb 2022 at 10:31, Richard Henderson wrote: This will allow us to control exactly what scratch register is used for loading the constant. Also, fix a theoretical problem in recursing through tcg_out_movi, which may provide a different value for

Re: [PATCH v5 0/9] virtiofsd: Add support for file security context at file creation

2022-02-07 Thread Daniel Walsh
On 2/7/22 16:19, Vivek Goyal wrote: On Mon, Feb 07, 2022 at 01:05:16PM +, Daniel P. Berrangé wrote: On Wed, Feb 02, 2022 at 02:39:26PM -0500, Vivek Goyal wrote: Hi, This is V5 of the patches. I posted V4 here. https://listman.redhat.com/archives/virtio-fs/2022-January/msg00041.html

[PATCH] Python: discourage direct setup.py install

2022-02-07 Thread John Snow
When invoking setup.py directly, the default behavior for 'install' is to run the bdist_egg installation hook, which is ... actually deprecated by setuptools. It doesn't seem to work quite right anymore. By contrast, 'pip install' will invoke the bdist_wheel hook instead. This leads to

Re: [PATCH v5 0/9] virtiofsd: Add support for file security context at file creation

2022-02-07 Thread Vivek Goyal
On Mon, Feb 07, 2022 at 01:05:16PM +, Daniel P. Berrangé wrote: > On Wed, Feb 02, 2022 at 02:39:26PM -0500, Vivek Goyal wrote: > > Hi, > > > > This is V5 of the patches. I posted V4 here. > > > > https://listman.redhat.com/archives/virtio-fs/2022-January/msg00041.html > > > > These will

Re: [PATCH v4 09/11] 9p: darwin: Implement compatibility for mknodat

2022-02-07 Thread Will Cohen
On Mon, Feb 7, 2022 at 9:21 AM Christian Schoenebeck wrote: > On Montag, 7. Februar 2022 11:57:25 CET Dr. David Alan Gilbert wrote: > > * Greg Kurz (gr...@kaod.org) wrote: > > > On Mon, 7 Feb 2022 11:30:18 +0100 > > > > > > Philippe Mathieu-Daudé wrote: > > > > On 7/2/22 09:47, Greg Kurz wrote:

Re: [PATCH v3 0/2] python: a few improvements to qmp-shell

2022-02-07 Thread John Snow
On Fri, Jan 28, 2022 at 11:12 AM Daniel P. Berrangé wrote: > > This makes the qmp-shell program a little more pleasant to use when you > are just trying to spawn a throw-away QEMU process to query some info > from. > > First it introduces a 'qmp-shell-wrap' command that takes a QEMU command >

Re: [PATCH v8 1/5] QIOChannel: Add flags on io_writev and introduce io_flush callback

2022-02-07 Thread Leonardo Bras Soares Passos
Hello Peter, On Mon, Feb 7, 2022 at 9:50 AM Peter Xu wrote: > > On Tue, Feb 01, 2022 at 03:28:59AM -0300, Leonardo Bras wrote: > > Add flags to io_writev and introduce io_flush as optional callback to > > QIOChannelClass, allowing the implementation of zero copy writes by > > subclasses. > > > >

[PATCH RFCv2 2/4] i386/pc: relocate 4g start to 1T where applicable

2022-02-07 Thread Joao Martins
It is assumed that the whole GPA space is available to be DMA addressable, within a given address space limit, expect for a tiny region before the 4G. Since Linux v5.4, VFIO validates whether the selected GPA is indeed valid i.e. not reserved by IOMMU on behalf of some specific devices or

[PATCH RFCv2 0/4] i386/pc: Fix creation of >= 1010G guests on AMD systems with IOMMU

2022-02-07 Thread Joao Martins
RFC[0] -> RFCv2: * At Igor's suggestion in one of the patches I reworked the series enterily, and more or less as he was thinking it is far simpler to relocate the ram-above-4g to be at 1TiB where applicable. The changeset is 3x simpler, and less intrusive. (patch 1 & 2) * Check phys-bits is big

[PATCH RFCv2 4/4] i386/pc: Restrict AMD-only enforcing of valid IOVAs to new machine type

2022-02-07 Thread Joao Martins
The added enforcing is only relevant in the case of AMD where the range right before the 1TB is restricted and cannot be DMA mapped by the kernel consequently leading to IOMMU INVALID_DEVICE_REQUEST or possibly other kinds of IOMMU events in the AMD IOMMU. Although, there's a case where it may

[PATCH RFCv2 3/4] i386/pc: warn if phys-bits is too low

2022-02-07 Thread Joao Martins
Default phys-bits on Qemu is TCG_PHYS_BITS (40) which is enough to address 1Tb (0xff ). On AMD platforms, if a ram-above-4g relocation happens and the CPU wasn't configured with a big enough phys-bits, warn the user. There isn't a catastrophic failure exactly, the guest will still boot,

[PATCH RFCv2 1/4] hw/i386: add 4g boundary start to X86MachineState

2022-02-07 Thread Joao Martins
Rather than hardcoding the 4G boundary everywhere, introduce a X86MachineState property @above_4g_mem_start and use it accordingly. This is in preparation for relocating ram-above-4g to be dynamically start at 1T on AMD platforms. Signed-off-by: Joao Martins --- hw/i386/acpi-build.c | 2 +-

Re: [RFC PATCH 1/1] virtio: fix feature negotiation for ACCESS_PLATFORM

2022-02-07 Thread Daniel Henrique Barboza
On 2/7/22 11:46, Halil Pasic wrote: On Mon, 7 Feb 2022 08:46:34 -0300 Daniel Henrique Barboza wrote: On 2/3/22 13:45, Halil Pasic wrote: Unlike most virtio features ACCESS_PATFORM is considered mandatory, i.e. the driver must accept it if offered by the device. The virtio specification

Re: [PATCH 08/11] mos6522: add "info via" HMP command for debugging

2022-02-07 Thread Peter Maydell
On Thu, 27 Jan 2022 at 21:03, Mark Cave-Ayland wrote: > > This displays detailed information about the device registers and timers to > aid > debugging problems with timers and interrupts. > > Signed-off-by: Mark Cave-Ayland > --- > hmp-commands-info.hx | 12 ++ > hw/misc/mos6522.c| 92

Re: [PATCH 07/11] mos6522: add register names to register read/write trace events

2022-02-07 Thread Peter Maydell
On Thu, 27 Jan 2022 at 21:11, Mark Cave-Ayland wrote: > > This helps to follow how the guest is programming the mos6522 when debugging. > > Signed-off-by: Mark Cave-Ayland > --- > hw/misc/mos6522.c| 10 -- > hw/misc/trace-events | 4 ++-- > 2 files changed, 10 insertions(+), 4

Re: [PATCH 06/11] mos6522: use device_class_set_parent_reset() to propagate reset to parent

2022-02-07 Thread Peter Maydell
On Thu, 27 Jan 2022 at 21:04, Mark Cave-Ayland wrote: > > Switch from using a legacy approach to the more formal approach for > propagating > device reset to the parent. > > Signed-off-by: Mark Cave-Ayland > --- > hw/misc/mac_via.c| 7 +-- > hw/misc/macio/cuda.c | 3 ++- >

Re: [PATCH 04/11] mos6522: switch over to use qdev gpios for IRQs

2022-02-07 Thread Peter Maydell
On Thu, 27 Jan 2022 at 21:01, Mark Cave-Ayland wrote: > > For historical reasons each mos6522 instance implements its own setting and > update of the IFR flag bits using methods exposed by MOS6522DeviceClass. As > of today this is no longer required, and it is now possible to implement > the

Re: [PATCH 05/11] mos6522: remove update_irq() and set_sr_int() methods from MOS6522DeviceClass

2022-02-07 Thread Peter Maydell
On Thu, 27 Jan 2022 at 21:03, Mark Cave-Ayland wrote: > > Now that the mos6522 IRQs are managed using standard qdev gpios these methods > are no longer required. > > Signed-off-by: Mark Cave-Ayland Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v4 02/12] mm/memfd: Introduce MFD_INACCESSIBLE flag

2022-02-07 Thread Vlastimil Babka
On 1/18/22 14:21, Chao Peng wrote: > Introduce a new memfd_create() flag indicating the content of the > created memfd is inaccessible from userspace. It does this by force > setting F_SEAL_INACCESSIBLE seal when the file is created. It also set > F_SEAL_SEAL to prevent future sealing, which

Re: [PATCH 06/16] hw/arm/xlnx-zcu102: Don't enable PSCI conduit when booting guest in EL3

2022-02-07 Thread Philippe Mathieu-Daudé via
On 7/2/22 19:13, Edgar E. Iglesias wrote: On Mon, Feb 7, 2022 at 5:24 PM Alexander Graf > wrote: On 07.02.22 17:06, Philippe Mathieu-Daudé wrote: > On 7/2/22 16:59, Alexander Graf wrote: >> >> On 07.02.22 16:52, Edgar E. Iglesias wrote: >

[PATCH 0/4] target/ppc: powerpc_excp improvements (9/9)

2022-02-07 Thread Fabiano Rosas
This is the last part of this series of changes to the exceptions code. First two patches remove the powerpc_excp_legacy function which is not needed anymore and move some of the common code from the individual powerpc_excp_* functions into powerpc_excp. Third patch makes the sanity check

Re: [PATCH v4] hw/sensor: Add lsm303dlhc magnetometer device

2022-02-07 Thread Peter Maydell
On Sun, 30 Jan 2022 at 09:53, Kevin Townsend wrote: > > This commit adds emulation of the magnetometer on the LSM303DLHC. > It allows the magnetometer's X, Y and Z outputs to be set via the > mag-x, mag-y and mag-z properties, as well as the 12-bit > temperature output via the temperature

[PATCH 1/4] target/ppc: Remove powerpc_excp_legacy

2022-02-07 Thread Fabiano Rosas
Now that all CPU families have their own separate exception dispatching code we can remove powerpc_excp_legacy. Signed-off-by: Fabiano Rosas --- target/ppc/excp_helper.c | 477 +-- 1 file changed, 3 insertions(+), 474 deletions(-) diff --git

[PATCH 2/4] target/ppc: powerpc_excp: Move common code to the caller function

2022-02-07 Thread Fabiano Rosas
Make the cpu-specific powerpc_excp_* functions a bit simpler by moving the bounds check and logging to powerpc_excp. Signed-off-by: Fabiano Rosas --- target/ppc/excp_helper.c | 57 +++- 1 file changed, 9 insertions(+), 48 deletions(-) diff --git

[PATCH 3/4] target/ppc: Assert if MSR bits differ from msr_mask during exceptions

2022-02-07 Thread Fabiano Rosas
We currently abort QEMU during the dispatch of an interrupt if we try to set MSR_HV without having MSR_HVB in the msr_mask. I think we should verify this for all MSR bits. There is no reason to ever have a MSR bit set if the corresponding bit is not set in that CPU's msr_mask. Note that this is

Re: [PATCH v5 6/6] tcg/sparc: Support unaligned access for user-only

2022-02-07 Thread Peter Maydell
On Sun, 6 Feb 2022 at 10:31, Richard Henderson wrote: > > This is kinda sorta the opposite of the other tcg hosts, where > we get (normal) alignment checks for free with host SIGBUS and > need to add code to support unaligned accesses. > > This inline code expansion is somewhat large, but it

[PATCH 4/4] target/ppc: books: Remove excp_model argument from ppc_excp_apply_ail

2022-02-07 Thread Fabiano Rosas
We don't really need to check for exception model while applying AIL. We can check the lpcr_mask for the presence of LPCR_AIL/LPCR_HAIL. This removes one more instance of passing the exception model ID around. Signed-off-by: Fabiano Rosas --- target/ppc/excp_helper.c | 25

Re: [PATCH v6 00/33] block layer: split block APIs in global state and I/O

2022-02-07 Thread Kevin Wolf
Am 21.01.2022 um 18:05 hat Emanuele Giuseppe Esposito geschrieben: > Each function in the GS API will have an assertion, checking > that it is always running under BQL. > I/O functions are instead thread safe (or so should be), meaning > that they *can* run under BQL, but also in an iothread in

Re: [PATCH 00/13] hw/intc/arm_gicv3_its: more cleanups, bugfixes

2022-02-07 Thread Peter Maydell
On Tue, 1 Feb 2022 at 19:32, Peter Maydell wrote: > > This is another set of patches to the ITS emulation; mostly > cleanups, but there are two bug fixes. Applied to target-arm.next, thanks. -- PMM

Re: [PULL 0/2] VFIO fixes 2022-02-03

2022-02-07 Thread Alex Williamson
On Mon, 7 Feb 2022 09:54:59 -0700 Alex Williamson wrote: > On Mon, 7 Feb 2022 17:08:01 +0100 > Philippe Mathieu-Daudé wrote: > > > On 7/2/22 16:50, Alex Williamson wrote: > > > On Sat, 5 Feb 2022 10:49:35 + > > > Peter Maydell wrote: > > > > >> Hi; this has a format-string issue

Re: [PATCH v2] tests/qtest: add qtests for npcm7xx sdhci

2022-02-07 Thread Peter Maydell
On Sun, 6 Feb 2022 at 01:41, Patrick Venture wrote: > > From: Shengtan Mao > > Reviewed-by: Hao Wu > Reviewed-by: Chris Rauer > Signed-off-by: Shengtan Mao > Signed-off-by: Patrick Venture > --- > v2: > * update copyright year > * check result of open > * use g_free instead of free > *

Re: [PATCH v6 31/33] include/qemu/job.h: introduce job->pre_run() and use it in amend

2022-02-07 Thread Kevin Wolf
Am 21.01.2022 um 18:05 hat Emanuele Giuseppe Esposito geschrieben: > Introduce .pre_run() job callback. This cb will run in job_start, > before the coroutine is created and runs run() in the job aiocontext. > > Therefore, .pre_run() always runs in the main loop. > We can use this function

Re: [PATCH v5 16/43] tests/acpi: Add update DSDT.viot

2022-02-07 Thread Jonathan Cameron via
On Mon, 7 Feb 2022 16:10:14 +0100 Igor Mammedov wrote: > On Fri, 4 Feb 2022 09:01:31 -0500 > "Michael S. Tsirkin" wrote: > > > On Wed, Feb 02, 2022 at 02:10:10PM +, Jonathan Cameron wrote: > > > From: Jonathan Cameron > > > > > > The consolidation of DSDT AML generation for PCI host

Re: [PATCH 06/16] hw/arm/xlnx-zcu102: Don't enable PSCI conduit when booting guest in EL3

2022-02-07 Thread Edgar E. Iglesias
On Mon, Feb 7, 2022 at 5:24 PM Alexander Graf wrote: > > On 07.02.22 17:06, Philippe Mathieu-Daudé wrote: > > On 7/2/22 16:59, Alexander Graf wrote: > >> > >> On 07.02.22 16:52, Edgar E. Iglesias wrote: > > > >>> Both Versal and ZynqMP require MicroBlaze firmware to run the > >>> reference

Re: Adding a 'qemu.qmp' repository to gitlab.com/qemu-project/

2022-02-07 Thread Daniel P . Berrangé
On Mon, Feb 07, 2022 at 04:54:25PM +, Alex Bennée wrote: > > John Snow writes: > > > Hi Peter: > > > > I am working my way towards splitting the QMP library out of the > > qemu.git source tree. I'd like to ask for permission to: > > > > (1) Create a "qemu.qmp" repository under the

Re: [PATCH v6 22/33] block/coroutines: I/O API

2022-02-07 Thread Kevin Wolf
Am 21.01.2022 um 18:05 hat Emanuele Giuseppe Esposito geschrieben: > block coroutines functions run in different aiocontext, and are > not protected by the BQL. Therefore are I/O. > > Signed-off-by: Emanuele Giuseppe Esposito > Reviewed-by: Paolo Bonzini > Reviewed-by: Stefan Hajnoczi > --- >

Re: [PATCH v5 1/6] tcg/sparc: Add scratch argument to tcg_out_movi_int

2022-02-07 Thread Peter Maydell
On Sun, 6 Feb 2022 at 10:31, Richard Henderson wrote: > > This will allow us to control exactly what scratch register is > used for loading the constant. Also, fix a theoretical problem > in recursing through tcg_out_movi, which may provide a different > value for in_prologue. > > Signed-off-by:

Re: Adding a 'qemu.qmp' repository to gitlab.com/qemu-project/

2022-02-07 Thread Alex Bennée
John Snow writes: > Hi Peter: > > I am working my way towards splitting the QMP library out of the > qemu.git source tree. I'd like to ask for permission to: > > (1) Create a "qemu.qmp" repository under the qemu-project umbrella on > GitLab No objection for my part except maybe a better name?

Re: [PATCH v6 09/33] block: introduce assert_bdrv_graph_writable

2022-02-07 Thread Kevin Wolf
Am 21.01.2022 um 18:05 hat Emanuele Giuseppe Esposito geschrieben: > We want to be sure that the functions that write the child and > parent list of a bs are under BQL and drain. > > BQL prevents from concurrent writings from the GS API, while > drains protect from I/O. > > TODO: drains are

Re: Adding a 'qemu.qmp' repository to gitlab.com/qemu-project/

2022-02-07 Thread John Snow
On Mon, Feb 7, 2022 at 11:56 AM Alex Bennée wrote: > > > John Snow writes: > > > Hi Peter: > > > > I am working my way towards splitting the QMP library out of the > > qemu.git source tree. I'd like to ask for permission to: > > > > (1) Create a "qemu.qmp" repository under the qemu-project

[PATCH 05/14] block: merge bdrv_delete and bdrv_close

2022-02-07 Thread Vladimir Sementsov-Ogievskiy
bdrv_delete() is the only caller of bdrv_close(). Let's merge them to simplify further commits. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block.c | 27 ++- 1 file changed, 10 insertions(+), 17 deletions(-) diff --git a/block.c b/block.c index

Re: [RFC PATCH] arm: force flag recalculation when messing with DAIF

2022-02-07 Thread Peter Maydell
On Wed, 2 Feb 2022 at 12:24, Alex Bennée wrote: > > The recently introduced debug tests in kvm-unit-tests exposed an error > in our handling of singlestep cause by stale hflags. This is caught by > --enable-debug-tcg when running the tests. > > Signed-off-by: Alex Bennée > Cc: Richard Henderson

Re: [PATCH v3 1/1] util: adjust coroutine pool size to virtio block queue

2022-02-07 Thread Stefan Hajnoczi
On Fri, Jan 28, 2022 at 05:36:16PM +0900, Hiroki Narukawa wrote: > Coroutine pool size was 64 from long ago, and the basis was organized in the > commit message in c740ad92. > > At that time, virtio-blk queue-size and num-queue were not configuable, and > equivalent values were 128 and 1. > >

[PATCH 10/14] qcow2: qcow2_inactivate(): don't call qcow2_mark_clean() when RO

2022-02-07 Thread Vladimir Sementsov-Ogievskiy
qcow2_inactivate() prints errors on different failures, let's not exclude qcow2_mark_clean() call. Still, if image is read-only, no reason to report failed write and no reason even to try write. Write failure is possible when we open dirty image for check in read-only mode. Let's not do it.

Re: [PATCH v6 05/33] include/sysemu/block-backend: split header into I/O and global state (GS) API

2022-02-07 Thread Kevin Wolf
Am 21.01.2022 um 18:05 hat Emanuele Giuseppe Esposito geschrieben: > Similarly to the previous patches, split block-backend.h > in block-backend-io.h and block-backend-global-state.h > > In addition, remove "block/block.h" include as it seems > it is not necessary anymore, together with

  1   2   3   >